12020-08-07T00:00:03 *** Guest45455 has quit IRC
22020-08-07T00:01:47 *** Chris_Stewart_5 has quit IRC
32020-08-07T00:05:49 *** mrostecki has quit IRC
42020-08-07T00:05:59 *** mrostecki has joined #bitcoin-core-dev
52020-08-07T00:06:43 *** Pavlenex has quit IRC
62020-08-07T00:10:32 *** Chris_Stewart_5 has joined #bitcoin-core-dev
72020-08-07T00:13:43 *** tryphe_ has joined #bitcoin-core-dev
82020-08-07T00:14:25 *** tryphe has quit IRC
92020-08-07T00:14:39 *** promag_ has quit IRC
102020-08-07T00:20:51 *** afk11 has joined #bitcoin-core-dev
112020-08-07T00:22:25 *** tekojo has joined #bitcoin-core-dev
122020-08-07T00:31:32 *** luke-jr has quit IRC
132020-08-07T00:32:58 *** luke-jr has joined #bitcoin-core-dev
142020-08-07T01:00:05 *** mol_ has quit IRC
152020-08-07T01:02:02 *** arowser_ has quit IRC
162020-08-07T01:02:29 *** arowser_ has joined #bitcoin-core-dev
172020-08-07T01:18:24 *** proofofkeags has quit IRC
182020-08-07T01:19:25 *** arowser_ has quit IRC
192020-08-07T01:20:01 *** arowser_ has joined #bitcoin-core-dev
202020-08-07T01:25:22 *** proofofkeags has joined #bitcoin-core-dev
212020-08-07T01:25:41 *** mol has joined #bitcoin-core-dev
222020-08-07T01:40:40 *** mdunnio has joined #bitcoin-core-dev
232020-08-07T01:42:05 *** proofofkeags has quit IRC
242020-08-07T01:42:40 *** proofofkeags has joined #bitcoin-core-dev
252020-08-07T01:43:50 *** arowser_ has quit IRC
262020-08-07T01:44:53 *** mdunnio has quit IRC
272020-08-07T01:45:54 *** mdunnio has joined #bitcoin-core-dev
282020-08-07T01:46:51 *** mdrollette has quit IRC
292020-08-07T01:46:59 *** proofofkeags has quit IRC
302020-08-07T01:47:10 *** mdrollette has joined #bitcoin-core-dev
312020-08-07T01:50:20 *** mdunnio has quit IRC
322020-08-07T01:51:24 *** shesek has quit IRC
332020-08-07T01:53:35 *** gzhao408 has joined #bitcoin-core-dev
342020-08-07T02:06:14 *** arowser_ has joined #bitcoin-core-dev
352020-08-07T02:13:44 *** proofofkeags has joined #bitcoin-core-dev
362020-08-07T02:18:07 *** proofofkeags has quit IRC
372020-08-07T02:20:10 *** mattdrollette has joined #bitcoin-core-dev
382020-08-07T02:21:26 *** mdrollette has quit IRC
392020-08-07T02:26:51 *** jarthur has quit IRC
402020-08-07T02:31:07 *** bitcoin-git has joined #bitcoin-core-dev
412020-08-07T02:31:08 <bitcoin-git> [bitcoin] andrewtoth closed pull request #19271: validation: Warm coins cache during prevalidation to connect blocks faster (master...warm-coinscache) https://github.com/bitcoin/bitcoin/pull/19271
422020-08-07T02:31:20 *** bitcoin-git has left #bitcoin-core-dev
432020-08-07T02:44:10 *** dr-orlovsky has quit IRC
442020-08-07T02:50:26 *** proofofkeags has joined #bitcoin-core-dev
452020-08-07T02:55:06 *** proofofkeags has quit IRC
462020-08-07T02:58:52 *** proofofkeags has joined #bitcoin-core-dev
472020-08-07T03:00:02 *** tekojo has quit IRC
482020-08-07T03:05:04 *** watersnake1 has quit IRC
492020-08-07T03:08:25 *** arowser_ has quit IRC
502020-08-07T03:14:58 *** arowser_ has joined #bitcoin-core-dev
512020-08-07T03:20:25 *** Highway61 has quit IRC
522020-08-07T03:21:26 *** edunham1 has joined #bitcoin-core-dev
532020-08-07T03:38:41 <sipa> i don't understand this
542020-08-07T03:38:43 <sipa> https://travis-ci.org/github/bitcoin/bitcoin/builds/715710056
552020-08-07T03:39:02 <sipa> it's failing consistently, in the same way, for all platforms that run functional tests & have wallet enabled
562020-08-07T03:39:26 <sipa> but i can't reproduce it locally, not even after git clean -dfx && ccache -C
572020-08-07T03:40:14 <sipa> can anyone try to build & run #17977, and run tests/functional/feature_taproot.py ?
582020-08-07T03:40:16 <gribble> https://github.com/bitcoin/bitcoin/issues/17977 | Implement BIP 340-342 validation (Schnorr/taproot/tapscript) by sipa · Pull Request #17977 · bitcoin/bitcoin · GitHub
592020-08-07T03:40:20 *** bitcoin-git has joined #bitcoin-core-dev
602020-08-07T03:40:20 <bitcoin-git> [bitcoin] JeremyRubin closed pull request #19531: add static_check_equal for easier to read compiler errors (master...static_check) https://github.com/bitcoin/bitcoin/pull/19531
612020-08-07T03:40:21 *** bitcoin-git has left #bitcoin-core-dev
622020-08-07T03:40:40 *** bitcoin-git has joined #bitcoin-core-dev
632020-08-07T03:40:40 <bitcoin-git> [bitcoin] JeremyRubin reopened pull request #19531: add static_check_equal for easier to read compiler errors (master...static_check) https://github.com/bitcoin/bitcoin/pull/19531
642020-08-07T03:40:41 *** bitcoin-git has left #bitcoin-core-dev
652020-08-07T03:43:28 *** Emcy_ has left #bitcoin-core-dev
662020-08-07T03:43:41 *** Emcy_ has quit IRC
672020-08-07T03:47:02 <sipa> oh, maybe a recent merge
682020-08-07T03:49:27 <troygiorshev> sipa: test passed for me
692020-08-07T03:50:08 <sipa> troygiorshev: thanks for trying - i think i know what caused it
702020-08-07T03:50:22 <sipa> the merge of #19620
712020-08-07T03:50:26 <gribble> https://github.com/bitcoin/bitcoin/issues/19620 | Add txids with non-standard inputs to reject filter by sdaftuar · Pull Request #19620 · bitcoin/bitcoin · GitHub
722020-08-07T03:50:59 *** Emcy has joined #bitcoin-core-dev
732020-08-07T03:51:03 <troygiorshev> ah great
742020-08-07T03:51:13 <troygiorshev> fwiw too, I think this test should be moved to the "less than 2m" section
752020-08-07T03:51:24 <troygiorshev> Took 1:12 on my i7-8750H
762020-08-07T03:51:25 <aj> sipa: that seems to match the error in the travis log
772020-08-07T03:52:28 <sipa> troygiorshev: thanks, doing that
782020-08-07T03:53:04 <sipa> aj: yeah, i can reproduce after a rebase on master
792020-08-07T04:00:46 <fanquake> sipa: gotta keep up :p
802020-08-07T04:02:01 <fanquake> bitcoin/bitcoin is a fast moving repository
812020-08-07T04:02:29 <sipa> fanquake: i started this set of changes over a week ago, then when i was done rebased on master, and right then "someone" merges probably the only open PR in the whole repo that breaks the tests without causing a compilation failure :p
822020-08-07T04:15:38 *** arowser_ has quit IRC
832020-08-07T04:29:17 *** gzhao408 has quit IRC
842020-08-07T04:31:03 *** da2ce7_ has quit IRC
852020-08-07T04:37:57 *** da2ce7 has joined #bitcoin-core-dev
862020-08-07T04:38:14 *** arowser_ has joined #bitcoin-core-dev
872020-08-07T04:41:10 *** justan0theruser has joined #bitcoin-core-dev
882020-08-07T04:43:12 *** justanotheruser has quit IRC
892020-08-07T04:46:15 *** justanotheruser has joined #bitcoin-core-dev
902020-08-07T04:49:06 *** justan0theruser has quit IRC
912020-08-07T04:51:51 *** TallTim has quit IRC
922020-08-07T05:00:24 *** arowser_ has quit IRC
932020-08-07T05:01:02 *** arowser_ has joined #bitcoin-core-dev
942020-08-07T05:10:11 *** arowser_ has quit IRC
952020-08-07T05:10:31 *** arowser_ has joined #bitcoin-core-dev
962020-08-07T05:15:27 *** justanotheruser has quit IRC
972020-08-07T05:20:18 *** justanotheruser has joined #bitcoin-core-dev
982020-08-07T05:23:16 *** bitcoin-git has joined #bitcoin-core-dev
992020-08-07T05:23:17 <bitcoin-git> [bitcoin] JeremyRubin opened pull request #19677: WIP: Switch BlockMap to use an unordered_set under the hood (master...refactor-blockmap-blockset) https://github.com/bitcoin/bitcoin/pull/19677
1002020-08-07T05:23:17 *** bitcoin-git has left #bitcoin-core-dev
1012020-08-07T05:25:09 *** arowser_ has quit IRC
1022020-08-07T05:25:33 *** arowser_ has joined #bitcoin-core-dev
1032020-08-07T05:44:19 *** justan0theruser has joined #bitcoin-core-dev
1042020-08-07T05:45:49 *** justanotheruser has quit IRC
1052020-08-07T05:50:18 *** justan0theruser has quit IRC
1062020-08-07T06:00:02 *** edunham1 has quit IRC
1072020-08-07T06:08:25 *** proofofkeags has quit IRC
1082020-08-07T06:08:59 *** proofofkeags has joined #bitcoin-core-dev
1092020-08-07T06:09:00 *** bitcoin-git has joined #bitcoin-core-dev
1102020-08-07T06:09:00 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6d8543504d8c...4b705b1c98f6
1112020-08-07T06:09:01 <bitcoin-git> bitcoin/master edc3160 Russell Yanofsky: test: Remove duplicate NodeContext hacks
1122020-08-07T06:09:01 <bitcoin-git> bitcoin/master 4b705b1 MarcoFalke: Merge #19098: test: Remove duplicate NodeContext hacks
1132020-08-07T06:09:03 *** bitcoin-git has left #bitcoin-core-dev
1142020-08-07T06:09:45 *** bitcoin-git has joined #bitcoin-core-dev
1152020-08-07T06:09:46 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19098: test: Remove duplicate NodeContext hacks (master...pr/qtx) https://github.com/bitcoin/bitcoin/pull/19098
1162020-08-07T06:09:47 *** bitcoin-git has left #bitcoin-core-dev
1172020-08-07T06:13:26 *** proofofkeags has quit IRC
1182020-08-07T06:16:44 *** justanotheruser has joined #bitcoin-core-dev
1192020-08-07T06:18:48 *** justanotheruser has joined #bitcoin-core-dev
1202020-08-07T06:21:50 *** Esky33 has joined #bitcoin-core-dev
1212020-08-07T06:22:02 *** pehjota1 has joined #bitcoin-core-dev
1222020-08-07T06:22:11 *** arowser_ has quit IRC
1232020-08-07T06:22:40 *** arowser_ has joined #bitcoin-core-dev
1242020-08-07T06:29:42 *** justanotheruser has quit IRC
1252020-08-07T06:30:01 *** justanotheruser has joined #bitcoin-core-dev
1262020-08-07T06:33:59 *** davec has quit IRC
1272020-08-07T06:37:07 *** Esky33 has quit IRC
1282020-08-07T06:41:12 *** arowser_ has quit IRC
1292020-08-07T06:41:33 *** arowser_ has joined #bitcoin-core-dev
1302020-08-07T06:42:37 *** davec has joined #bitcoin-core-dev
1312020-08-07T06:43:25 *** davterra has quit IRC
1322020-08-07T06:57:09 *** arowser_ has quit IRC
1332020-08-07T06:57:29 *** arowser_ has joined #bitcoin-core-dev
1342020-08-07T06:59:10 *** davec has quit IRC
1352020-08-07T07:07:16 *** marcoagner has joined #bitcoin-core-dev
1362020-08-07T07:08:03 *** ghost43 has joined #bitcoin-core-dev
1372020-08-07T07:10:33 *** Emcy has quit IRC
1382020-08-07T07:12:21 *** Emcy has joined #bitcoin-core-dev
1392020-08-07T07:12:34 *** davec has joined #bitcoin-core-dev
1402020-08-07T07:14:50 *** arowser_ has quit IRC
1412020-08-07T07:21:42 *** arowser_ has joined #bitcoin-core-dev
1422020-08-07T07:29:12 *** arowser_ has quit IRC
1432020-08-07T07:29:36 *** arowser_ has joined #bitcoin-core-dev
1442020-08-07T07:33:23 *** Dean_Guss has quit IRC
1452020-08-07T07:43:16 *** marcoagner has quit IRC
1462020-08-07T07:53:03 *** vasild has quit IRC
1472020-08-07T07:56:12 *** arowser_ has quit IRC
1482020-08-07T07:56:31 *** arowser_ has joined #bitcoin-core-dev
1492020-08-07T08:04:51 *** bitcoin-git has joined #bitcoin-core-dev
1502020-08-07T08:04:51 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #15045: [test] Apply maximal flags to tx_valid tests and minimal flags to tx_invalid tests (master...min_txtests_flags) https://github.com/bitcoin/bitcoin/pull/15045
1512020-08-07T08:04:52 *** bitcoin-git has left #bitcoin-core-dev
1522020-08-07T08:05:40 *** promag has quit IRC
1532020-08-07T08:11:40 *** tryphe_ has quit IRC
1542020-08-07T08:11:44 *** tryphe__ has joined #bitcoin-core-dev
1552020-08-07T08:19:14 *** vincenzopalazzo has joined #bitcoin-core-dev
1562020-08-07T08:21:27 *** palazzovincenzo has joined #bitcoin-core-dev
1572020-08-07T08:22:16 *** palazzovincenzo has joined #bitcoin-core-dev
1582020-08-07T08:23:09 *** Davterra has joined #bitcoin-core-dev
1592020-08-07T08:23:25 *** ghost43_ has joined #bitcoin-core-dev
1602020-08-07T08:24:03 *** ghost43 has quit IRC
1612020-08-07T08:24:11 *** vincenzopalazzo has quit IRC
1622020-08-07T08:24:36 *** palazzovincenzo has quit IRC
1632020-08-07T08:25:03 *** promag has joined #bitcoin-core-dev
1642020-08-07T08:25:44 *** mrostecki has quit IRC
1652020-08-07T08:26:07 *** mrostecki has joined #bitcoin-core-dev
1662020-08-07T08:31:16 *** vincenzopalazzo has joined #bitcoin-core-dev
1672020-08-07T08:31:35 *** promag_ has joined #bitcoin-core-dev
1682020-08-07T08:32:36 *** promag has quit IRC
1692020-08-07T08:34:04 *** vasild has joined #bitcoin-core-dev
1702020-08-07T08:36:26 *** pehjota1 has quit IRC
1712020-08-07T08:38:13 *** tryphe_ has joined #bitcoin-core-dev
1722020-08-07T08:38:26 *** tryphe__ has quit IRC
1732020-08-07T08:42:25 *** Pavlenex has joined #bitcoin-core-dev
1742020-08-07T08:54:54 *** Alucard has joined #bitcoin-core-dev
1752020-08-07T08:55:54 *** K4TJAN has joined #bitcoin-core-dev
1762020-08-07T08:55:56 *** tryphe has joined #bitcoin-core-dev
1772020-08-07T08:55:59 *** K4TJAN has quit IRC
1782020-08-07T08:56:21 *** K4TJANG95 has joined #bitcoin-core-dev
1792020-08-07T08:56:35 *** dr-orlovsky has joined #bitcoin-core-dev
1802020-08-07T08:56:46 *** K4TJANG95 has quit IRC
1812020-08-07T08:57:52 *** tryphe_ has quit IRC
1822020-08-07T09:10:51 *** dr-orlovsky has quit IRC
1832020-08-07T09:16:10 *** davec has quit IRC
1842020-08-07T09:22:40 *** davec has joined #bitcoin-core-dev
1852020-08-07T09:33:00 *** Bullitje has left #bitcoin-core-dev
1862020-08-07T09:41:44 *** syperf has joined #bitcoin-core-dev
1872020-08-07T09:46:13 *** EagleTM has joined #bitcoin-core-dev
1882020-08-07T09:47:08 *** arowser_ has quit IRC
1892020-08-07T09:47:54 *** arowser_ has joined #bitcoin-core-dev
1902020-08-07T09:49:08 *** dr-orlovsky has joined #bitcoin-core-dev
1912020-08-07T09:52:00 *** andreacab has joined #bitcoin-core-dev
1922020-08-07T10:03:28 *** Shanie14Harris has joined #bitcoin-core-dev
1932020-08-07T10:11:49 *** andreacab has quit IRC
1942020-08-07T10:12:15 *** andreacab has joined #bitcoin-core-dev
1952020-08-07T10:16:19 *** andreacab has quit IRC
1962020-08-07T10:16:26 *** andreacab has joined #bitcoin-core-dev
1972020-08-07T10:16:52 *** andreacab has quit IRC
1982020-08-07T10:19:32 *** andreacab has joined #bitcoin-core-dev
1992020-08-07T10:27:01 <sdaftuar> sipa: just catching up now, is the test in #19620 not stable?
2002020-08-07T10:27:03 <gribble> https://github.com/bitcoin/bitcoin/issues/19620 | Add txids with non-standard inputs to reject filter by sdaftuar · Pull Request #19620 · bitcoin/bitcoin · GitHub
2012020-08-07T10:28:19 *** Kiminuo has joined #bitcoin-core-dev
2022020-08-07T10:35:52 *** jeremyrubin has quit IRC
2032020-08-07T10:36:49 *** dr-orlovsky has quit IRC
2042020-08-07T10:37:08 *** arowser_ has quit IRC
2052020-08-07T10:37:30 *** arowser_ has joined #bitcoin-core-dev
2062020-08-07T10:37:50 *** Shanie14Harris has quit IRC
2072020-08-07T10:39:20 *** dr-orlovsky has joined #bitcoin-core-dev
2082020-08-07T10:44:44 *** bitcoin-git has joined #bitcoin-core-dev
2092020-08-07T10:44:44 <bitcoin-git> [bitcoin] fanquake closed pull request #19675: Run clang-tidy -*,performance-* (master...master) https://github.com/bitcoin/bitcoin/pull/19675
2102020-08-07T10:44:45 *** bitcoin-git has left #bitcoin-core-dev
2112020-08-07T10:49:58 *** arowser_ has quit IRC
2122020-08-07T10:53:13 *** andreacab has quit IRC
2132020-08-07T10:55:33 *** vasild_ has joined #bitcoin-core-dev
2142020-08-07T10:58:23 *** vasild has quit IRC
2152020-08-07T10:58:25 *** vasild_ is now known as vasild
2162020-08-07T11:00:35 *** kristapsk has quit IRC
2172020-08-07T11:03:42 *** arowser_ has joined #bitcoin-core-dev
2182020-08-07T11:14:59 *** promag_ has quit IRC
2192020-08-07T11:21:27 *** promag has joined #bitcoin-core-dev
2202020-08-07T11:21:58 *** TallTim has joined #bitcoin-core-dev
2212020-08-07T11:24:05 *** promag has quit IRC
2222020-08-07T11:28:36 *** morcos has quit IRC
2232020-08-07T11:29:01 *** morcos has joined #bitcoin-core-dev
2242020-08-07T11:35:00 *** dr-orlovsky has quit IRC
2252020-08-07T11:35:36 *** dr-orlovsky has joined #bitcoin-core-dev
2262020-08-07T11:41:52 *** syperf has quit IRC
2272020-08-07T11:49:52 *** dr-orlovsky has quit IRC
2282020-08-07T11:51:52 *** vincenzopalazzo has quit IRC
2292020-08-07T11:56:50 *** dr-orlovsky has joined #bitcoin-core-dev
2302020-08-07T11:58:34 *** promag has joined #bitcoin-core-dev
2312020-08-07T12:02:54 *** promag has quit IRC
2322020-08-07T12:14:32 *** reallll has joined #bitcoin-core-dev
2332020-08-07T12:17:41 *** belcher_ has quit IRC
2342020-08-07T12:18:00 *** reallll is now known as belcher
2352020-08-07T12:22:02 *** Raccoon has joined #bitcoin-core-dev
2362020-08-07T12:28:25 *** vincenzopalazzo has joined #bitcoin-core-dev
2372020-08-07T12:29:32 *** dr_orlovsky has joined #bitcoin-core-dev
2382020-08-07T12:32:02 *** Kiminuo has quit IRC
2392020-08-07T12:36:13 *** arowser_ has quit IRC
2402020-08-07T12:38:04 *** arowser_ has joined #bitcoin-core-dev
2412020-08-07T12:40:23 *** tryphe_ has joined #bitcoin-core-dev
2422020-08-07T12:42:35 *** promag has joined #bitcoin-core-dev
2432020-08-07T12:43:08 *** tryphe has quit IRC
2442020-08-07T12:52:27 *** promag has quit IRC
2452020-08-07T12:53:23 *** Kiminuo has joined #bitcoin-core-dev
2462020-08-07T12:53:52 *** promag has joined #bitcoin-core-dev
2472020-08-07T12:56:16 *** Guyver2 has joined #bitcoin-core-dev
2482020-08-07T13:04:23 *** ghost43_ has quit IRC
2492020-08-07T13:05:29 *** ghost43 has joined #bitcoin-core-dev
2502020-08-07T13:06:12 *** arowser_ has quit IRC
2512020-08-07T13:06:31 *** arowser_ has joined #bitcoin-core-dev
2522020-08-07T13:07:12 *** arowser_ has quit IRC
2532020-08-07T13:07:31 *** arowser_ has joined #bitcoin-core-dev
2542020-08-07T13:08:09 *** arowser_ has quit IRC
2552020-08-07T13:08:46 *** arowser_ has joined #bitcoin-core-dev
2562020-08-07T13:09:10 *** arowser_ has quit IRC
2572020-08-07T13:09:37 *** arowser_ has joined #bitcoin-core-dev
2582020-08-07T13:10:03 *** Highway61 has joined #bitcoin-core-dev
2592020-08-07T13:10:11 *** arowser_ has quit IRC
2602020-08-07T13:10:57 *** arowser_ has joined #bitcoin-core-dev
2612020-08-07T13:11:10 *** arowser_ has quit IRC
2622020-08-07T13:11:30 *** arowser_ has joined #bitcoin-core-dev
2632020-08-07T13:12:11 *** arowser_ has quit IRC
2642020-08-07T13:12:30 *** arowser_ has joined #bitcoin-core-dev
2652020-08-07T13:15:12 *** promag has quit IRC
2662020-08-07T13:23:09 *** bitdex has quit IRC
2672020-08-07T13:24:11 *** arowser_ has quit IRC
2682020-08-07T13:24:42 *** arowser_ has joined #bitcoin-core-dev
2692020-08-07T13:27:10 *** Dean_Guss has joined #bitcoin-core-dev
2702020-08-07T13:28:11 <sipa> sdaftuar: no no; there was an actual interaction between 19620 and 17977, and 17977's tests started failing after merging (as it didn't move taproot outputs out of WITNESS_UNKNOWN, those ended up being nonstandard to spend)
2712020-08-07T13:31:53 <sdaftuar> ah!
2722020-08-07T13:32:23 *** Pavlenex has quit IRC
2732020-08-07T13:41:06 *** arowser_ has quit IRC
2742020-08-07T13:43:10 *** arowser_ has joined #bitcoin-core-dev
2752020-08-07T13:44:30 *** dr-orlovsky has quit IRC
2762020-08-07T13:45:16 *** dr_orlovsky has quit IRC
2772020-08-07T13:45:33 *** dr-orlovsky has joined #bitcoin-core-dev
2782020-08-07T13:47:19 *** dr-orlovsky has quit IRC
2792020-08-07T13:47:52 *** dr-orlovsky has joined #bitcoin-core-dev
2802020-08-07T13:52:18 *** promag has joined #bitcoin-core-dev
2812020-08-07T13:52:25 *** promag has quit IRC
2822020-08-07T14:00:37 *** mdunnio has joined #bitcoin-core-dev
2832020-08-07T14:04:25 *** proofofkeags has joined #bitcoin-core-dev
2842020-08-07T14:09:20 *** arowser_ has quit IRC
2852020-08-07T14:09:49 *** arowser_ has joined #bitcoin-core-dev
2862020-08-07T14:10:16 *** arowser_ has quit IRC
2872020-08-07T14:10:40 *** mdunnio has quit IRC
2882020-08-07T14:10:45 *** arowser_ has joined #bitcoin-core-dev
2892020-08-07T14:10:54 *** mdunnio has joined #bitcoin-core-dev
2902020-08-07T14:11:14 *** arowser_ has quit IRC
2912020-08-07T14:11:42 *** arowser_ has joined #bitcoin-core-dev
2922020-08-07T14:11:53 *** promag has joined #bitcoin-core-dev
2932020-08-07T14:12:39 *** sdaftuar has quit IRC
2942020-08-07T14:13:04 *** sdaftuar has joined #bitcoin-core-dev
2952020-08-07T14:19:44 *** justanotheruser has quit IRC
2962020-08-07T14:20:44 *** promag has quit IRC
2972020-08-07T14:22:07 *** mrostecki has quit IRC
2982020-08-07T14:30:20 *** Pavlenex has joined #bitcoin-core-dev
2992020-08-07T14:33:08 *** arowser_ has quit IRC
3002020-08-07T14:33:46 *** arowser_ has joined #bitcoin-core-dev
3012020-08-07T14:44:33 *** Highway61 has quit IRC
3022020-08-07T14:45:11 *** dongcarl has quit IRC
3032020-08-07T14:45:23 *** Highway61 has joined #bitcoin-core-dev
3042020-08-07T14:45:26 *** dongcarl has joined #bitcoin-core-dev
3052020-08-07T14:47:16 *** arowser_ has quit IRC
3062020-08-07T14:47:45 *** arowser_ has joined #bitcoin-core-dev
3072020-08-07T14:59:34 *** Talkless has joined #bitcoin-core-dev
3082020-08-07T15:00:01 *** Raccoon has quit IRC
3092020-08-07T15:08:24 *** Highway61 has quit IRC
3102020-08-07T15:09:17 *** arowser_ has quit IRC
3112020-08-07T15:09:46 *** arowser_ has joined #bitcoin-core-dev
3122020-08-07T15:21:29 *** gzhao408 has joined #bitcoin-core-dev
3132020-08-07T15:21:40 *** superfly1 has joined #bitcoin-core-dev
3142020-08-07T15:23:17 *** arowser_ has quit IRC
3152020-08-07T15:23:33 *** Pavlenex has joined #bitcoin-core-dev
3162020-08-07T15:24:03 *** arowser_ has joined #bitcoin-core-dev
3172020-08-07T15:29:18 *** Talkless has quit IRC
3182020-08-07T15:31:50 *** Pavlenex has quit IRC
3192020-08-07T15:32:29 *** bitcoin-git has joined #bitcoin-core-dev
3202020-08-07T15:32:30 <bitcoin-git> [bitcoin] sdaftuar opened pull request #19680: 0.20: Add txids with non-standard inputs to reject filter (0.20...2020-08-reject-unknown-wit-0.20) https://github.com/bitcoin/bitcoin/pull/19680
3212020-08-07T15:32:30 *** bitcoin-git has left #bitcoin-core-dev
3222020-08-07T15:33:24 *** bitcoin-git has joined #bitcoin-core-dev
3232020-08-07T15:33:25 <bitcoin-git> [bitcoin] sdaftuar opened pull request #19681: 0.19: Add txids with non-standard inputs to reject filter (0.19...2020-08-reject-unknown-wit-0.19) https://github.com/bitcoin/bitcoin/pull/19681
3242020-08-07T15:33:37 *** bitcoin-git has left #bitcoin-core-dev
3252020-08-07T15:35:39 *** superfly1 has quit IRC
3262020-08-07T15:37:18 *** gzhao408 has quit IRC
3272020-08-07T15:38:12 *** arowser_ has quit IRC
3282020-08-07T15:38:49 *** arowser_ has joined #bitcoin-core-dev
3292020-08-07T15:40:33 *** gzhao408 has joined #bitcoin-core-dev
3302020-08-07T15:40:40 *** bitcoin-git has joined #bitcoin-core-dev
3312020-08-07T15:40:40 <bitcoin-git> [bitcoin] hebasto closed pull request #19600: doc: Fix log message for -reindex (master...200727-load-log) https://github.com/bitcoin/bitcoin/pull/19600
3322020-08-07T15:40:41 *** bitcoin-git has left #bitcoin-core-dev
3332020-08-07T15:45:03 *** andreacab has joined #bitcoin-core-dev
3342020-08-07T15:52:05 *** justanotheruser has joined #bitcoin-core-dev
3352020-08-07T15:52:55 *** proofofkeags has quit IRC
3362020-08-07T15:55:58 *** leoburd has joined #bitcoin-core-dev
3372020-08-07T15:57:12 *** proofofkeags has joined #bitcoin-core-dev
3382020-08-07T15:57:13 *** proofofkeags has quit IRC
3392020-08-07T15:57:25 *** proofofkeags has joined #bitcoin-core-dev
3402020-08-07T15:58:26 *** justanotheruser has quit IRC
3412020-08-07T16:03:10 *** arowser_ has quit IRC
3422020-08-07T16:03:33 *** arowser_ has joined #bitcoin-core-dev
3432020-08-07T16:04:05 *** luke-jr has quit IRC
3442020-08-07T16:04:27 *** luke-jr has joined #bitcoin-core-dev
3452020-08-07T16:13:42 *** justanotheruser has joined #bitcoin-core-dev
3462020-08-07T16:13:53 *** andreacab has quit IRC
3472020-08-07T16:14:19 *** andreacab has joined #bitcoin-core-dev
3482020-08-07T16:18:06 *** justanotheruser has quit IRC
3492020-08-07T16:19:09 *** andreacab has quit IRC
3502020-08-07T16:20:06 *** proofofkeags has quit IRC
3512020-08-07T16:20:40 *** proofofkeags has joined #bitcoin-core-dev
3522020-08-07T16:25:08 *** proofofkeags has quit IRC
3532020-08-07T16:31:33 *** marcoagner has joined #bitcoin-core-dev
3542020-08-07T16:43:35 *** jeremyrubin has joined #bitcoin-core-dev
3552020-08-07T16:51:14 *** roconnor_ has joined #bitcoin-core-dev
3562020-08-07T16:52:17 *** roconnor has quit IRC
3572020-08-07T16:52:21 *** roconnor_ is now known as roconnor
3582020-08-07T17:00:04 *** jb55 has quit IRC
3592020-08-07T17:00:32 *** jb55 has joined #bitcoin-core-dev
3602020-08-07T17:11:13 *** Highway61 has joined #bitcoin-core-dev
3612020-08-07T17:18:07 *** mattdrollette is now known as MDrollette
3622020-08-07T17:22:29 *** proofofkeags has joined #bitcoin-core-dev
3632020-08-07T17:22:53 *** promag_ has joined #bitcoin-core-dev
3642020-08-07T17:30:41 *** promag_ has quit IRC
3652020-08-07T17:32:07 *** watersnake1 has joined #bitcoin-core-dev
3662020-08-07T17:36:50 *** marcoagner has quit IRC
3672020-08-07T17:41:54 *** bitcoin-git has joined #bitcoin-core-dev
3682020-08-07T17:41:55 <bitcoin-git> [bitcoin] dongcarl opened pull request #19683: WIP: depends: Explicitly specify clang search paths for darwin host (master...2020-08-clang-search-path-robustness) https://github.com/bitcoin/bitcoin/pull/19683
3692020-08-07T17:42:07 *** bitcoin-git has left #bitcoin-core-dev
3702020-08-07T17:45:45 *** marcoagner has joined #bitcoin-core-dev
3712020-08-07T17:55:25 *** owowo has quit IRC
3722020-08-07T17:59:56 *** owowo has joined #bitcoin-core-dev
3732020-08-07T18:00:01 *** leoburd has quit IRC
3742020-08-07T18:00:06 *** gzhao408 has quit IRC
3752020-08-07T18:00:51 *** gzhao408 has joined #bitcoin-core-dev
3762020-08-07T18:10:47 *** Guyver2 has quit IRC
3772020-08-07T18:13:40 *** Davterra has quit IRC
3782020-08-07T18:16:36 *** Chris_Stewart_5 has quit IRC
3792020-08-07T18:22:32 *** drybjed1 has joined #bitcoin-core-dev
3802020-08-07T18:35:28 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3812020-08-07T18:38:19 *** watersnake1 has quit IRC
3822020-08-07T18:38:23 *** sdaftuar has quit IRC
3832020-08-07T18:38:48 *** sdaftuar has joined #bitcoin-core-dev
3842020-08-07T18:57:05 *** Highway61 has quit IRC
3852020-08-07T18:59:18 *** Highway61 has joined #bitcoin-core-dev
3862020-08-07T19:05:14 *** gzhao408 has quit IRC
3872020-08-07T19:18:59 *** Dean_Guss has quit IRC
3882020-08-07T19:20:16 *** jarthur has joined #bitcoin-core-dev
3892020-08-07T19:29:14 *** cloudhead has joined #bitcoin-core-dev
3902020-08-07T19:29:23 *** Davterra has joined #bitcoin-core-dev
3912020-08-07T19:32:51 *** EagleTM has quit IRC
3922020-08-07T19:34:13 *** Dean_Guss has joined #bitcoin-core-dev
3932020-08-07T19:41:03 *** mrostecki has joined #bitcoin-core-dev
3942020-08-07T19:41:03 *** justanotheruser has joined #bitcoin-core-dev
3952020-08-07T19:48:33 *** filchef has joined #bitcoin-core-dev
3962020-08-07T19:52:47 *** filchef has quit IRC
3972020-08-07T20:00:43 *** arowser_ has quit IRC
3982020-08-07T20:01:07 *** arowser_ has joined #bitcoin-core-dev
3992020-08-07T20:04:44 *** troygiorshev has quit IRC
4002020-08-07T20:05:34 *** troygiorshev has joined #bitcoin-core-dev
4012020-08-07T20:22:07 *** lnostdal has quit IRC
4022020-08-07T20:22:47 *** troygiorshev has quit IRC
4032020-08-07T20:23:04 *** troygiorshev has joined #bitcoin-core-dev
4042020-08-07T20:28:45 *** EagleTM has joined #bitcoin-core-dev
4052020-08-07T20:35:36 *** alko has quit IRC
4062020-08-07T20:41:11 *** promag has joined #bitcoin-core-dev
4072020-08-07T20:45:32 *** promag has quit IRC
4082020-08-07T20:46:45 *** proofofkeags has quit IRC
4092020-08-07T20:47:21 *** proofofkeags has joined #bitcoin-core-dev
4102020-08-07T20:51:45 *** proofofkeags has quit IRC
4112020-08-07T20:58:03 *** mrostecki has quit IRC
4122020-08-07T21:00:01 *** drybjed1 has quit IRC
4132020-08-07T21:05:07 *** bitcoin-git has joined #bitcoin-core-dev
4142020-08-07T21:05:07 <bitcoin-git> [bitcoin] JeremyRubin closed pull request #18071: Refactoring CHashWriter & Get{Prevouts,Sequence,Outputs}Hash to SHA256 (master...refactoring-hashers) https://github.com/bitcoin/bitcoin/pull/18071
4152020-08-07T21:05:08 *** bitcoin-git has left #bitcoin-core-dev
4162020-08-07T21:16:25 <Kiminuo> Hi, I'm trying to slowly move forward this https://github.com/bitcoin/bitcoin/pull/19245. And it seems I need to put somewhere `-lstdc++fs` (as per https://www.bfilipek.com/2019/05/boost-to-stdfs.html) to fix failing travis configurations (https://travis-ci.org/github/bitcoin/bitcoin/builds/715745829). I know everybody is busy but any advice or pointer would help me immensely as this is not something I know much about. :-|
4172020-08-07T21:18:09 *** Talkless has joined #bitcoin-core-dev
4182020-08-07T21:22:20 *** ThunderChicken1 has joined #bitcoin-core-dev
4192020-08-07T21:23:32 <jeremyrubin> hi Kiminuo
4202020-08-07T21:23:43 <sipa> Kiminuo: is that needed if you're actually building in c++17 mode?
4212020-08-07T21:23:51 <jeremyrubin> I don't think you need to do -lstdc++fs if the gcc > 9.0
4222020-08-07T21:24:02 *** andreacab has joined #bitcoin-core-dev
4232020-08-07T21:24:15 <jeremyrubin> It sounds like you only need it to build against an earlier version
4242020-08-07T21:24:34 <Kiminuo> well, I can see that #include <filesystem> is not recognized in those tests
4252020-08-07T21:24:52 <sipa> -l only affects linking
4262020-08-07T21:24:58 <sipa> it can't affect header includes
4272020-08-07T21:25:00 <Kiminuo> I'm not entirely sure c++17 is correctly enabled in my branch
4282020-08-07T21:25:07 <Kiminuo> ok
4292020-08-07T21:25:20 <sipa> do you build with --enable-c++17 ?
4302020-08-07T21:25:53 <jeremyrubin> The travis builds won't work until c++17 is default I guess
4312020-08-07T21:26:34 <jeremyrubin> This patch might just have to sit for a year for that
4322020-08-07T21:26:35 <Kiminuo> https://github.com/bitcoin/bitcoin/pull/19245/files#diff-309426131fa2cf2ebbc5cde58961b8a9R19 - Marco Falke actually have a PR that I build upon
4332020-08-07T21:26:49 <Kiminuo> and I can see a few instance of `--enable-c++17`
4342020-08-07T21:27:07 <Kiminuo> *instances
4352020-08-07T21:27:16 <jeremyrubin> you need to pass it to ./configure --enable-c++17
4362020-08-07T21:27:28 <Kiminuo> jeremyrubin, I'm fine with waiting :)
4372020-08-07T21:28:08 <jeremyrubin> sipa may know otherwise, but I suspect waiting till we are no longer building for c++11 is the most likely case due to the API changes
4382020-08-07T21:28:15 *** Pavlenex has joined #bitcoin-core-dev
4392020-08-07T21:28:47 *** andreacab has quit IRC
4402020-08-07T21:28:49 <gwillen> the change to configure.ac in that PR does appear to make c++17 unconditional in configure
4412020-08-07T21:29:02 <gwillen> it removes the configure flag and forces it on
4422020-08-07T21:29:13 *** andreacab has joined #bitcoin-core-dev
4432020-08-07T21:29:14 <gwillen> (I don't know if there could be other places that were using it that got missed though)
4442020-08-07T21:29:27 <Kiminuo> https://github.com/bitcoin/bitcoin/pull/19245/files#diff-67e997bcfdac55191033d57a16d1408aR72 - do you mean this, right?
4452020-08-07T21:30:19 <gwillen> right, yeah. So I'm not sure if $use_cxx17 is referenced anywhere else, or if that change is enough to be the same as passing the flag to configure.
4462020-08-07T21:30:41 *** andreacab has quit IRC
4472020-08-07T21:30:48 *** andreacab has joined #bitcoin-core-dev
4482020-08-07T21:31:00 <gwillen> I don't see any other uses, so off the top of my head I'd expect that to work
4492020-08-07T21:31:55 <Kiminuo> Well, travis shows:
4502020-08-07T21:31:56 <Kiminuo> ./fs.h:14:10: fatal error: filesystem: No such file or directory
4512020-08-07T21:31:56 <Kiminuo> #include <filesystem>
4522020-08-07T21:31:56 <Kiminuo> ^~~~~~~~~~~~
4532020-08-07T21:31:59 <Kiminuo> here https://travis-ci.org/github/bitcoin/bitcoin/jobs/715745835
4542020-08-07T21:32:02 <gwillen> looking at the travis failures it does look like some headers got rearranged in c++17 that you haven't accounted for, but I don't know if you were even looking at that yet (e.g. std::function got moved into #include <functional>, which is causing a ton of errors, but not the ones you're asking about)
4552020-08-07T21:33:37 <sipa> Kiminuo: but your changes to use std::filesystem instead of boost::filesystem should only be active whenever you're building in C++17 mode
4562020-08-07T21:33:49 <sipa> i think?
4572020-08-07T21:34:03 <sipa> ah
4582020-08-07T21:34:07 <sipa> sorry, just reading
4592020-08-07T21:34:11 <jeremyrubin> sipa: they're building on mandatory c++17
4602020-08-07T21:34:17 <Kiminuo> gwillen, I have based my PR on this: https://github.com/bitcoin/bitcoin/pull/19183
4612020-08-07T21:34:17 <sipa> hmm, ok
4622020-08-07T21:34:27 <sipa> and does the problem arise on all platforms?
4632020-08-07T21:34:35 <gwillen> configure does say at the end: CXX = /usr/bin/ccache g++ -m64 -std=c++17
4642020-08-07T21:34:59 <Kiminuo> sipa, all I know is this result: https://travis-ci.org/github/bitcoin/bitcoin/builds/715745829
4652020-08-07T21:35:09 <Kiminuo> > but your changes to use std::filesystem instead of boost::filesystem should only be active whenever you're building in C++17 mode
4662020-08-07T21:35:25 <sipa> yeah, ignore me;
4672020-08-07T21:35:30 <Kiminuo> that would be preferable I guess, but it's out of scope of my ability
4682020-08-07T21:36:37 <sipa> erhhh
4692020-08-07T21:36:49 <gwillen> it seems that the <filesystem> library may not be broadly available yet, even in c++17 mode
4702020-08-07T21:36:50 <sipa> the windows build fails to include <filesystem>
4712020-08-07T21:37:04 <sipa> that sounds like we just can't use it
4722020-08-07T21:37:11 <sipa> even in c++17 mode
4732020-08-07T21:37:23 <gwillen> it's hard for me to find up-to-date info though
4742020-08-07T21:37:34 <Kiminuo> Interestingly, I have a C++ project on Windows where <filesystem> works.
4752020-08-07T21:37:34 <gwillen> it seems likely there is a minimum compiler version to support it
4762020-08-07T21:37:38 <jeremyrubin> Kiminuo: I would just wait on it till mandatory c++17 goes in
4772020-08-07T21:37:46 <jeremyrubin> it should be like a year or so
4782020-08-07T21:37:48 <sipa> jeremyrubin: that won't help
4792020-08-07T21:37:59 <sipa> because c++17 is enabled in these builds that are failing
4802020-08-07T21:38:16 <jeremyrubin> sipa: wait on it meaning, not worth spending more time now?
4812020-08-07T21:38:20 <gwillen> what version of gcc do we use? It appears <filesystem> is introduced without qualifications in gcc 8
4822020-08-07T21:38:31 <gwillen> before that you can use <experimental/filesystem> with an additional compile flag
4832020-08-07T21:38:34 <sipa> jeremyrubin: waiting on mandatory c++17 won't change the fact that these builds fail
4842020-08-07T21:38:52 <sipa> oh
4852020-08-07T21:38:56 <sipa> ok, i get it
4862020-08-07T21:39:12 <sipa> i assumed that -std=c++17 would only _work_ at all on compilers that fully support c++17
4872020-08-07T21:39:32 <gwillen> yeah it seems that it means "give me as much c++17 as you have"
4882020-08-07T21:39:40 <sipa> right
4892020-08-07T21:39:46 <jeremyrubin> the shakespeare rule
4902020-08-07T21:39:54 <gwillen> https://old.reddit.com/r/cpp/comments/7o9kg6/gcc_80_support_stdfilesystem_include_filesystem/
4912020-08-07T21:40:20 <sipa> so we won't make c++17 mandatory until we drop support for all platforms that don't support it fully (or at least, sufficiently)
4922020-08-07T21:40:40 <jeremyrubin> Or, we will do that
4932020-08-07T21:40:48 <jeremyrubin> as long as we have libs we can still use
4942020-08-07T21:40:55 <jeremyrubin> like boost::filesystem
4952020-08-07T21:40:55 <Kiminuo> https://travis-ci.org/github/bitcoin/bitcoin/jobs/715745835 - I can see in this build that GCC 7.5 is used. Is enough for <filesystem>?
4962020-08-07T21:40:55 <sipa> how so?
4972020-08-07T21:40:56 <gwillen> Kiminuo: if you still want to experiment, understanding it could be quite awhile before this is feasible in production, it looks like you could try including <experimental/filesystem> and linking with "-lstdc++fs"
4982020-08-07T21:41:13 <gwillen> Kiminuo: no it seems you need 8.0
4992020-08-07T21:41:26 <Kiminuo> gwillen, so that may be the issue, right?
5002020-08-07T21:41:31 <gwillen> yeah I think that is indeed the issue
5012020-08-07T21:41:38 <jeremyrubin> I think c++17 will be fine for even "as much as you have of 17" compilers with the current code
5022020-08-07T21:41:55 <jeremyrubin> but we may not be able to use *all* c++17 features until then
5032020-08-07T21:41:58 <gwillen> your local compiler is newer than the one that CI is using, so you have <filesystem> but CI does not
5042020-08-07T21:42:17 <gwillen> I assume the compiler CI uses is the benchmark for "minimum supported to build bitcoin with"?
5052020-08-07T21:42:37 <Kiminuo> gwillen, I don't think <experimental/filesystem> is way to go. It will make it more complex and it does not sound good to use something experimental in Bitcoin.
5062020-08-07T21:43:31 <gwillen> I believe it is the same library, it just moved when it was finally standardized to a new name. But I agree it may not be suitable for inclusion into Bitcoin for real for now.
5072020-08-07T21:43:48 <gwillen> especially since boost::filesystem is probably _also_ the same library under a different name, more or less
5082020-08-07T21:45:33 *** andreacab has quit IRC
5092020-08-07T21:46:35 <Kiminuo> std::filesystem is kind of renamed boost::filesystem with some modifications, but the details are sometimes not that easy to find (at least for me)
5102020-08-07T21:46:39 *** andreacab has joined #bitcoin-core-dev
5112020-08-07T21:47:12 <gwillen> yeah, that's usually how it goes with C++ library features being standardized I think -- they start in boost and work their way into the standard library
5122020-08-07T21:50:00 <sipa> GCC 7 jusy predates the c++17 standard being finalized
5132020-08-07T21:50:31 <sipa> so i guess that'z why it's only available under experimental - at the time it was written there was no way to know of that would eventually match the spec
5142020-08-07T21:51:01 <sipa> GCC 7.5 is more than recent enough, but i guess these things are only updated in major releasesm
5152020-08-07T21:51:39 *** andreacab has quit IRC
5162020-08-07T21:53:03 <Kiminuo> https://travis-ci.org/github/bitcoin/bitcoin/jobs/715745836 - but here GCC is also 7.5 and the test passes
5172020-08-07T21:53:16 <sipa> hmm, strange
5182020-08-07T21:53:33 <Kiminuo> actually it's verbatim the same thing as in the failing test
5192020-08-07T21:58:09 *** promag has joined #bitcoin-core-dev
5202020-08-07T22:00:31 <Kiminuo> https://www.diffchecker.com/Q52OO5NI - "Build system information" sections are actually the same for OK test & failing test.
5212020-08-07T22:01:23 <gwillen> according to https://gcc.gnu.org/onlinedocs/libstdc++/manual/status.html#status.iso.2017 it was not added until 8.1 _and_ it still requires a special link argument, -lstdc++fs
5222020-08-07T22:01:29 <gwillen> so, there's something weird happening
5232020-08-07T22:11:02 <Kiminuo> yeah, I have mentioned that earlier
5242020-08-07T22:11:12 <Kiminuo> (that link argument)
5252020-08-07T22:12:02 <Kiminuo> I'm not sure how long it would take to wait for GCC 8.1 to be widespread.
5262020-08-07T22:14:04 <sipa> this is something to report on https://github.com/bitcoin/bitcoin/issues/16684
5272020-08-07T22:15:22 <sipa> so perhaps the right thing to do is making std::filesystem based builds still configurable, and only enable them on GCC 8.1+ platforms and others that we know support it
5282020-08-07T22:16:45 <sipa> so that the lack of full std::filesystem support doesn't hold up otherwise migrating to C++17
5292020-08-07T22:17:21 <sipa> gwillen, Kiminuo: perhaps a discrepancy is due to libstdc++ and gcc not being the exact same thing and available in lockstep?
5302020-08-07T22:17:34 <sipa> std::filesystem support is purely a libstdc++ side thing, i expect
5312020-08-07T22:19:04 *** promag has quit IRC
5322020-08-07T22:19:17 <Kiminuo> sipa, I don't know about that configuration. The APIs of both libraries is not in one-to-one correspondence. It can be done by a wrapper I guess.
5332020-08-07T22:19:52 <sipa> well, that wrapper already exists
5342020-08-07T22:19:57 <sipa> this is why we have the fs namespace
5352020-08-07T22:20:00 *** promag has joined #bitcoin-core-dev
5362020-08-07T22:20:04 <Kiminuo> True
5372020-08-07T22:20:13 <Kiminuo> But you would need to add more functions
5382020-08-07T22:20:52 <sipa> i expect that slight differences between boost::filesystem and std::filesystem make it not exactly a "using fs = boost::filesystem" vs "using fs = std::filesystem", but it shouldn't be too much more than that
5392020-08-07T22:21:37 <Kiminuo> https://github.com/bitcoin/bitcoin/pull/19245 - it's documented here
5402020-08-07T22:21:53 <Kiminuo> The differences are not that big
5412020-08-07T22:22:20 <sipa> ok
5422020-08-07T22:22:23 *** Guest25949 has quit IRC
5432020-08-07T22:22:52 <Kiminuo> But if you have a fs::path and you use operator "/", I think it behaves slightly differently. And that may be hard to explain to people
5442020-08-07T22:23:07 <sipa> what is the difference?
5452020-08-07T22:23:33 *** per has joined #bitcoin-core-dev
5462020-08-07T22:23:56 *** per is now known as Guest55343
5472020-08-07T22:24:48 <Kiminuo> https://github.com/bitcoin/bitcoin/pull/19466#discussion_r451809243
5482020-08-07T22:24:54 <Kiminuo> there was something like this
5492020-08-07T22:25:09 <Kiminuo> let me check what that was actually about
5502020-08-07T22:25:14 *** andreacab has joined #bitcoin-core-dev
5512020-08-07T22:26:49 <Kiminuo> PR 19466 is based on boost::filesystem and Marco said that in https://github.com/bitcoin/bitcoin/pull/19466#discussion_r451809243 you would get `/tmp//sadf` and in std::filesystem you would get "/foo"
5522020-08-07T22:27:09 <Kiminuo> I hope I'm saying that correctly
5532020-08-07T22:27:52 <sipa> heh
5542020-08-07T22:33:32 <Kiminuo> That's pretty nasty, if true
5552020-08-07T22:34:04 <Kiminuo> That makes me thing that using boost::filesystem & std::filesystem at the same time may bring troubles
5562020-08-07T22:37:02 *** Talkless has quit IRC
5572020-08-07T22:42:57 *** andreacab has quit IRC
5582020-08-07T22:55:33 *** vasild_ has joined #bitcoin-core-dev
5592020-08-07T22:58:43 *** vasild has quit IRC
5602020-08-07T22:58:44 *** vasild_ is now known as vasild
5612020-08-07T23:04:29 *** promag has quit IRC
5622020-08-07T23:14:21 *** Pavlenex has joined #bitcoin-core-dev
5632020-08-07T23:17:35 *** Pavlenex has quit IRC
5642020-08-07T23:19:25 *** Chris_Stewart_5 has quit IRC
5652020-08-07T23:29:02 *** marcoagner has quit IRC
5662020-08-07T23:31:05 *** Davterra has quit IRC
5672020-08-07T23:34:06 *** arowser_ has quit IRC
5682020-08-07T23:34:34 *** arowser_ has joined #bitcoin-core-dev
5692020-08-07T23:34:35 *** promag has joined #bitcoin-core-dev
5702020-08-07T23:41:06 *** arowser_ has quit IRC
5712020-08-07T23:41:34 *** arowser_ has joined #bitcoin-core-dev
5722020-08-07T23:54:06 *** arowser_ has quit IRC
5732020-08-07T23:54:35 *** arowser_ has joined #bitcoin-core-dev
5742020-08-07T23:59:26 *** troygiorshev has quit IRC