12020-08-12T00:00:03 *** kwm1 has quit IRC
22020-08-12T00:03:19 *** promag has quit IRC
32020-08-12T00:04:23 *** promag has joined #bitcoin-core-dev
42020-08-12T00:13:41 *** jonatack has quit IRC
52020-08-12T00:20:58 *** diogorsergio has joined #bitcoin-core-dev
62020-08-12T00:22:04 *** SukhE1 has joined #bitcoin-core-dev
72020-08-12T00:27:04 *** promag has quit IRC
82020-08-12T00:29:21 *** Davterra has joined #bitcoin-core-dev
92020-08-12T00:33:52 *** mdunnio has joined #bitcoin-core-dev
102020-08-12T00:44:57 *** promag has joined #bitcoin-core-dev
112020-08-12T00:48:25 *** SukhE1 has quit IRC
122020-08-12T00:49:43 *** bitcoin-git has joined #bitcoin-core-dev
132020-08-12T00:49:43 <bitcoin-git> [bitcoin] achow101 opened pull request #19700: wallet: Replace -zapwallettxes with wallet tool command (master...zapwallettxes-wallettool) https://github.com/bitcoin/bitcoin/pull/19700
142020-08-12T00:49:45 *** bitcoin-git has left #bitcoin-core-dev
152020-08-12T00:58:51 <luke-jr> I thought that was already open O.o
162020-08-12T00:59:13 *** jb55 has quit IRC
172020-08-12T00:59:45 *** jb55 has joined #bitcoin-core-dev
182020-08-12T01:05:56 *** promag has quit IRC
192020-08-12T01:06:01 <achow101> luke-jr: I've opened 3 prs, one for each option
202020-08-12T01:06:58 <luke-jr> aha
212020-08-12T01:09:20 *** justanotheruser has joined #bitcoin-core-dev
222020-08-12T01:10:49 *** promag has joined #bitcoin-core-dev
232020-08-12T01:13:40 *** promag has quit IRC
242020-08-12T01:25:10 *** arowser_ has quit IRC
252020-08-12T01:25:32 *** arowser_ has joined #bitcoin-core-dev
262020-08-12T01:27:15 *** promag has joined #bitcoin-core-dev
272020-08-12T01:31:07 *** joeykrim1 has joined #bitcoin-core-dev
282020-08-12T01:31:24 *** trash_mapache has joined #bitcoin-core-dev
292020-08-12T01:34:39 *** Eagle[TM] has joined #bitcoin-core-dev
302020-08-12T01:34:42 *** mdunnio has quit IRC
312020-08-12T01:36:42 *** EagleTM has quit IRC
322020-08-12T01:53:42 *** promag has quit IRC
332020-08-12T01:57:08 *** arowser_ has quit IRC
342020-08-12T01:59:14 <luke-jr> where can I learn about this crazy(?) new RPC implementation syntax, and why it's better than the older more readable version?
352020-08-12T02:02:26 *** bitcoin-git has joined #bitcoin-core-dev
362020-08-12T02:02:27 <bitcoin-git> [bitcoin] fanquake pushed 20 commits to master: https://github.com/bitcoin/bitcoin/compare/cb1ee1551cf3...ce3bdd0ed1bb
372020-08-12T02:02:28 <bitcoin-git> bitcoin/master 3f1b714 Amiti Uttarwar: scripted-diff: Rename OneShot to AddrFetch
382020-08-12T02:02:29 <bitcoin-git> bitcoin/master 26304b4 Amiti Uttarwar: [net/refactor] Introduce an enum to distinguish type of connection
392020-08-12T02:02:30 <bitcoin-git> bitcoin/master 1521c47 Amiti Uttarwar: [net/refactor] Add manual connections to ConnectionType enum
402020-08-12T02:02:31 *** bitcoin-git has left #bitcoin-core-dev
412020-08-12T02:02:50 *** bitcoin-git has joined #bitcoin-core-dev
422020-08-12T02:02:51 <bitcoin-git> [bitcoin] fanquake merged pull request #19316: [net] Cleanup logic around connection types (master...2020-06-conn-refactor) https://github.com/bitcoin/bitcoin/pull/19316
432020-08-12T02:02:52 *** bitcoin-git has left #bitcoin-core-dev
442020-08-12T02:03:36 *** arowser_ has joined #bitcoin-core-dev
452020-08-12T02:07:08 *** Davterra has quit IRC
462020-08-12T02:08:57 *** mdunnio has joined #bitcoin-core-dev
472020-08-12T02:09:37 *** Davterra has joined #bitcoin-core-dev
482020-08-12T02:12:30 <jeremyrubin> luke-jr: eh? example
492020-08-12T02:13:05 <achow101> you mean the RPCHelpMan stuff?
502020-08-12T02:13:08 <luke-jr> yes
512020-08-12T02:13:14 <luke-jr> jeremyrubin: https://github.com/bitcoin/bitcoin/pull/19550
522020-08-12T02:13:25 *** mdunnio has quit IRC
532020-08-12T02:13:51 <achow101> luke-jr: it's better because it aligns all the help text correctly
542020-08-12T02:14:01 <achow101> the syntax is just matching brackets correctly
552020-08-12T02:14:08 *** arowser_ has quit IRC
562020-08-12T02:16:50 <luke-jr> achow101: I don't mean RPCHelpMan itself, I mean the new change of moving code inside it
572020-08-12T02:17:40 <jeremyrubin> it looks like it has for some time now
582020-08-12T02:17:53 <jeremyrubin> i don't see any changes from what it's been for a while
592020-08-12T02:18:18 <achow101> luke-jr: oh, I see, 19550 is don't something funky
602020-08-12T02:18:23 <achow101> *doing
612020-08-12T02:18:56 <jeremyrubin> line 638?
622020-08-12T02:19:07 <achow101> I assume so
632020-08-12T02:19:12 *** arowser_ has joined #bitcoin-core-dev
642020-08-12T02:19:22 <luke-jr> yeah
652020-08-12T02:19:44 <achow101> did someone suggest him to do that? I haven't seen that syntax before
662020-08-12T02:20:14 <luke-jr> https://github.com/bitcoin/bitcoin/pull/19550#discussion_r456865552
672020-08-12T02:21:22 <achow101> luke-jr: I guess #19528 explains it
682020-08-12T02:21:24 <gribble> https://github.com/bitcoin/bitcoin/issues/19528 | rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc) by MarcoFalke · Pull Request #19528 · bitcoin/bitcoin · GitHub
692020-08-12T02:22:48 <jeremyrubin> seems like a good change
702020-08-12T02:23:00 <achow101> this'll be one of those things that you just copy and paste
712020-08-12T02:24:18 <luke-jr> I don't see the explanation
722020-08-12T02:24:50 <achow101> " However, in the future they could be used to teach the server the named arguments. Named arguments are currently registered by the CRPCCommands and duplicate the RPCArg names from the documentation. This redundancy is fragile, and has lead to errors in the past (despite having linters to catch those kind of errors)."
732020-08-12T02:25:13 <luke-jr> what does that have to do with this new RPC method definition stuff?
742020-08-12T02:25:28 <jeremyrubin> it checks the args and then makes the call
752020-08-12T02:25:41 <achow101> it makes the function return the RPCHelpMan which can then report the arg names
762020-08-12T02:25:43 <luke-jr> it did that before this..?
772020-08-12T02:25:45 *** justanotheruser has quit IRC
782020-08-12T02:25:59 <achow101> then the actual RPC stuff is a function within the RPCHelpMan
792020-08-12T02:26:04 <jeremyrubin> but it required redundant and potentially inconsistent info
802020-08-12T02:27:16 <luke-jr> this seems like a rather ugly way to accomplish it :/
812020-08-12T02:30:05 <luke-jr> probably better to get rid of the function/return, and just declare it as a static variable?
822020-08-12T02:31:46 *** justanotheruser has joined #bitcoin-core-dev
832020-08-12T02:32:35 <achow101> it's just a lambda
842020-08-12T02:33:40 *** troygior1hev has quit IRC
852020-08-12T02:34:05 <luke-jr> #proposedmeetingtopic Can we recreate bitcoin-core/gui so GitHub will let us do PRs from the same <user>/bitcoin forks instead of making a new remote for everyone?
862020-08-12T02:34:35 *** arowser_ has quit IRC
872020-08-12T02:35:02 *** arowser_ has joined #bitcoin-core-dev
882020-08-12T02:52:35 *** Highway61 has quit IRC
892020-08-12T03:00:02 *** joeykrim1 has quit IRC
902020-08-12T03:05:50 *** Eagle[TM] has quit IRC
912020-08-12T03:06:50 *** EagleTM has joined #bitcoin-core-dev
922020-08-12T03:09:32 *** Emcy has quit IRC
932020-08-12T03:13:02 *** Emcy has joined #bitcoin-core-dev
942020-08-12T03:16:37 *** trash_mapache has quit IRC
952020-08-12T03:21:52 *** Phace has joined #bitcoin-core-dev
962020-08-12T03:41:10 *** arowser_ has quit IRC
972020-08-12T03:41:59 *** arowser_ has joined #bitcoin-core-dev
982020-08-12T03:43:11 *** arowser_ has quit IRC
992020-08-12T03:43:41 *** arowser_ has joined #bitcoin-core-dev
1002020-08-12T03:45:02 *** watersnake1 has quit IRC
1012020-08-12T03:46:09 *** arowser_ has quit IRC
1022020-08-12T03:46:29 *** arowser_ has joined #bitcoin-core-dev
1032020-08-12T03:50:05 <kallewoof> Signet pull request has been updated with ajtowns suggestions, and the network is up and running now. Please review! https://github.com/bitcoin/bitcoin/pull/18267
1042020-08-12T03:53:35 *** Dean_Guss has joined #bitcoin-core-dev
1052020-08-12T03:55:43 *** DeanWeen has quit IRC
1062020-08-12T04:25:09 *** arowser_ has quit IRC
1072020-08-12T04:25:34 *** arowser_ has joined #bitcoin-core-dev
1082020-08-12T04:35:08 *** arowser_ has quit IRC
1092020-08-12T04:35:36 *** arowser_ has joined #bitcoin-core-dev
1102020-08-12T04:55:38 *** TheHoliestRoger has quit IRC
1112020-08-12T04:55:43 *** TheHoliestRoger_ has joined #bitcoin-core-dev
1122020-08-12T04:56:10 *** arowser_ has quit IRC
1132020-08-12T04:56:35 *** arowser_ has joined #bitcoin-core-dev
1142020-08-12T04:57:08 *** mdunnio has joined #bitcoin-core-dev
1152020-08-12T05:05:37 *** mdunnio has quit IRC
1162020-08-12T05:21:09 *** arowser_ has quit IRC
1172020-08-12T05:21:28 *** arowser_ has joined #bitcoin-core-dev
1182020-08-12T05:30:13 *** Dean_Guss has quit IRC
1192020-08-12T05:30:24 *** Dean_Guss has joined #bitcoin-core-dev
1202020-08-12T05:33:37 *** Emcy has quit IRC
1212020-08-12T05:35:11 *** arowser_ has quit IRC
1222020-08-12T05:35:39 *** arowser_ has joined #bitcoin-core-dev
1232020-08-12T05:36:08 *** Emcy has joined #bitcoin-core-dev
1242020-08-12T05:36:41 *** justanotheruser has quit IRC
1252020-08-12T05:42:47 *** jb55 has quit IRC
1262020-08-12T05:44:33 *** Deacydal has quit IRC
1272020-08-12T06:00:01 *** Phace has quit IRC
1282020-08-12T06:11:37 *** arowser_ has quit IRC
1292020-08-12T06:12:59 *** vfP56jSe has quit IRC
1302020-08-12T06:14:14 *** vfP56jSe has joined #bitcoin-core-dev
1312020-08-12T06:22:16 *** torax has joined #bitcoin-core-dev
1322020-08-12T06:23:40 *** arowser_ has joined #bitcoin-core-dev
1332020-08-12T06:37:09 *** EagleTM has quit IRC
1342020-08-12T06:47:12 *** arowser_ has quit IRC
1352020-08-12T06:47:35 *** arowser_ has joined #bitcoin-core-dev
1362020-08-12T06:59:48 *** marcoagner has joined #bitcoin-core-dev
1372020-08-12T07:05:17 *** DeanWeen has joined #bitcoin-core-dev
1382020-08-12T07:05:47 *** Dean_Guss has quit IRC
1392020-08-12T07:09:20 *** davec has quit IRC
1402020-08-12T07:09:56 *** davec has joined #bitcoin-core-dev
1412020-08-12T07:12:18 *** Guyver2 has joined #bitcoin-core-dev
1422020-08-12T07:18:45 *** arowser_ has quit IRC
1432020-08-12T07:19:34 *** davec has quit IRC
1442020-08-12T07:21:11 *** davec has joined #bitcoin-core-dev
1452020-08-12T07:30:59 *** arowser_ has joined #bitcoin-core-dev
1462020-08-12T07:43:13 *** arowser_ has quit IRC
1472020-08-12T07:43:42 *** arowser_ has joined #bitcoin-core-dev
1482020-08-12T07:46:00 *** vincenzopalazzo has quit IRC
1492020-08-12T07:50:23 *** jonatack has joined #bitcoin-core-dev
1502020-08-12T07:56:32 *** sipsorcery has joined #bitcoin-core-dev
1512020-08-12T08:08:54 *** midnight has quit IRC
1522020-08-12T08:11:03 *** midnight has joined #bitcoin-core-dev
1532020-08-12T08:12:46 *** vincenzopalazzo has joined #bitcoin-core-dev
1542020-08-12T08:15:41 *** davec has quit IRC
1552020-08-12T08:16:24 *** Deacyde has joined #bitcoin-core-dev
1562020-08-12T08:28:19 *** arowser_ has quit IRC
1572020-08-12T08:28:39 *** arowser_ has joined #bitcoin-core-dev
1582020-08-12T08:29:16 *** arowser_ has quit IRC
1592020-08-12T08:29:36 *** arowser_ has joined #bitcoin-core-dev
1602020-08-12T08:35:09 *** davec has joined #bitcoin-core-dev
1612020-08-12T08:45:19 *** b10c has joined #bitcoin-core-dev
1622020-08-12T08:51:05 <jonatack> review beg for #19455 (which arguably should have been in the last release with -generate to make multiple bitcoin command line tutorials work again for users), as requested by ajonas and MarcoFalke. It's a quick review with complete test coverage.
1632020-08-12T08:51:07 <gribble> https://github.com/bitcoin/bitcoin/issues/19455 | rpc generate: print useful help and error message by jonatack · Pull Request #19455 · bitcoin/bitcoin · GitHub
1642020-08-12T08:54:49 *** promag has joined #bitcoin-core-dev
1652020-08-12T08:59:26 *** promag has quit IRC
1662020-08-12T09:00:02 *** torax has quit IRC
1672020-08-12T09:05:39 *** TheFuzzStone[m] has quit IRC
1682020-08-12T09:05:39 *** icota[m] has quit IRC
1692020-08-12T09:05:47 *** thunderbiscuit[m has quit IRC
1702020-08-12T09:06:16 *** AaronvanW has quit IRC
1712020-08-12T09:08:14 *** Pavlenex has joined #bitcoin-core-dev
1722020-08-12T09:12:39 *** SergeySherkunov[ has joined #bitcoin-core-dev
1732020-08-12T09:18:38 *** b10c_ has joined #bitcoin-core-dev
1742020-08-12T09:22:14 *** zakk has joined #bitcoin-core-dev
1752020-08-12T09:22:36 *** zakk is now known as Guest84477
1762020-08-12T09:25:07 *** Pavlenex has quit IRC
1772020-08-12T09:28:45 *** davec has quit IRC
1782020-08-12T09:29:36 *** davec has joined #bitcoin-core-dev
1792020-08-12T09:32:14 *** AaronvanW has joined #bitcoin-core-dev
1802020-08-12T09:34:20 *** thunderbiscuit[m has joined #bitcoin-core-dev
1812020-08-12T09:34:21 *** icota[m] has joined #bitcoin-core-dev
1822020-08-12T09:34:21 *** TheFuzzStone[m] has joined #bitcoin-core-dev
1832020-08-12T09:49:10 *** arowser_ has quit IRC
1842020-08-12T09:49:26 *** reallll has joined #bitcoin-core-dev
1852020-08-12T09:49:56 *** arowser_ has joined #bitcoin-core-dev
1862020-08-12T09:51:09 *** davec has quit IRC
1872020-08-12T09:51:41 *** davec has joined #bitcoin-core-dev
1882020-08-12T09:53:11 *** belcher_ has quit IRC
1892020-08-12T09:53:27 *** AaronvanW has quit IRC
1902020-08-12T09:58:17 *** jeremyrubin has quit IRC
1912020-08-12T09:59:42 *** EagleTM has joined #bitcoin-core-dev
1922020-08-12T10:03:18 *** Vinnie23Vandervo has joined #bitcoin-core-dev
1932020-08-12T10:11:34 *** Pavlenex has joined #bitcoin-core-dev
1942020-08-12T10:12:25 *** sipsorcery has quit IRC
1952020-08-12T10:13:18 *** SergeySherkunov[ has quit IRC
1962020-08-12T10:14:02 *** Pavlenex has quit IRC
1972020-08-12T10:17:01 *** sipsorcery has joined #bitcoin-core-dev
1982020-08-12T10:19:15 *** Talkless has joined #bitcoin-core-dev
1992020-08-12T10:37:08 <jonatack> elichai2: "<elichai2> I don't work on anything p2p related right now, but I do plan to review a bunch of stuff, so if there'll be a high priority for review out of this it would be great" --> high prority suggestion: #19628
2002020-08-12T10:37:10 <gribble> https://github.com/bitcoin/bitcoin/issues/19628 | net: change CNetAddr::ip to have flexible size by vasild · Pull Request #19628 · bitcoin/bitcoin · GitHub
2012020-08-12T10:37:20 <jonatack> as part of #19031
2022020-08-12T10:37:22 <gribble> https://github.com/bitcoin/bitcoin/issues/19031 | Implement ADDRv2 support (part of BIP155) by vasild · Pull Request #19031 · bitcoin/bitcoin · GitHub
2032020-08-12T10:37:55 <vasild> +1
2042020-08-12T10:38:34 <elichai2> jonatack: Thanks!
2052020-08-12T10:40:48 <jonatack> elichai2: 10/10 you'll like it, lots of low-level memcpy/memcmp mixed with some Span to overhaul the critical netaddress infra ;)
2062020-08-12T10:40:48 *** Vinnie23Vandervo has quit IRC
2072020-08-12T10:40:59 <elichai2> :D
2082020-08-12T10:42:05 <vasild> well, in my defence, I tried to split the patch, but everything seems to be linked together...
2092020-08-12T10:43:23 <jonatack> that is true
2102020-08-12T10:45:29 <vasild> it would be possible to remove GetByte() as a first patch, but that would be lots of mechanical changes, all retouched/redone in the second patch
2112020-08-12T10:49:19 <jonatack> while shilling PRs, i find having the cli -netinfo peer connections dashboard (e.g. <human-readable getpeerinfo>) reassuring as a sanity check for testing running nodes with the addrv2 changes
2122020-08-12T10:50:16 <vasild> e.g. GetByte(3) (this gets the first byte!) would become ip[sizeof(IPV4_IN_IPV6_PREFIX) + 0] (in about 100 places) and then all those will be changed to m_addr[0] in a second patch - I think that would be wasting reviewer's time
2132020-08-12T10:51:20 *** Highway61 has joined #bitcoin-core-dev
2142020-08-12T10:53:35 <jonatack> vasild: i think you'll have several acks soon so would not rework it now
2152020-08-12T10:54:05 <vasild> let it rain acks! :)
2162020-08-12T10:54:20 <ryanofsky> fanquake, can you give specific examples of where review recap comments have been misleading? I think they are essential for long-lived prs because we have no explicit standards for merging
2172020-08-12T10:54:20 <vasild> (but not before I address your suggestions)
2182020-08-12T10:55:25 <ryanofsky> so without review recap comments, there's basically no transparency about why a pr has or hasn't been merged
2192020-08-12T10:55:37 *** vasild_ has joined #bitcoin-core-dev
2202020-08-12T10:56:42 <ryanofsky> if a comment is misleading, you can call out the comment, not discourage comments in general
2212020-08-12T10:58:43 *** vasild has quit IRC
2222020-08-12T10:58:44 *** vasild_ is now known as vasild
2232020-08-12T11:11:47 *** jonatack has quit IRC
2242020-08-12T11:19:32 <fanquake> ryanofsky: Sure, I'll try dig up some examples. I wasn't trying to discourage commenting. My point is that Concept ACKs left at the opening of a PR, are not necessarily relevant if they are being "recapped" 2 months later, after the implementation has changed, or a different approach is being taken. Similarly, if someone ACK'd something 3 rebases and a few code changes ago, I'm not really looking at that as
2252020-08-12T11:19:32 <fanquake> a "tested ACK".
2262020-08-12T11:19:59 <fanquake> Do you think people are changing how they are reviewing based on these comments, or just wether or not they are going to review something in the first place?
2272020-08-12T11:21:21 *** sipsorcery has quit IRC
2282020-08-12T11:21:45 <fanquake> I'd also like to avoid the idea that just because a PR has *had* a large number of ACKs throughout it's lifetime, it just ready to merge. Obviously this is all dependent on the change itself, and a bit hard to generalize. However as I mentioned above, ACKs are certainly not equal when it comes to more important parts of the code.
2292020-08-12T11:22:39 *** sipsorcery has joined #bitcoin-core-dev
2302020-08-12T11:23:35 <fanquake> Hopefully this is something we'll only have to worry about less as more (frequent) contributors are onboarded etc etc
2312020-08-12T11:26:29 <ryanofsky> Sure I agree with all that, I just think it's mostly obvious. I plan to keep making review recap comments and want to encourage other people to make them
2322020-08-12T11:27:09 <ryanofsky> So if there are specific comments that are misleading, which includes outdated acks, or mischaracterized acks, let's just respond to and fix those comments
2332020-08-12T11:38:40 *** bitcoin-git has joined #bitcoin-core-dev
2342020-08-12T11:38:40 <bitcoin-git> [bitcoin] jnewbery opened pull request #19704: Net processing: move ProcessMessage() to PeerLogicValidation (master...2020-07-process-message-plv) https://github.com/bitcoin/bitcoin/pull/19704
2352020-08-12T11:38:42 *** bitcoin-git has left #bitcoin-core-dev
2362020-08-12T11:48:50 *** spikee has joined #bitcoin-core-dev
2372020-08-12T11:49:51 *** spikee has joined #bitcoin-core-dev
2382020-08-12T11:49:55 *** Pavlenex has joined #bitcoin-core-dev
2392020-08-12T11:51:04 *** andreacab has joined #bitcoin-core-dev
2402020-08-12T11:56:50 *** Highway61 has quit IRC
2412020-08-12T11:57:27 *** Guest84477 has quit IRC
2422020-08-12T12:00:23 *** Highway61 has joined #bitcoin-core-dev
2432020-08-12T12:03:33 *** andreacab has quit IRC
2442020-08-12T12:04:00 *** andreacab has joined #bitcoin-core-dev
2452020-08-12T12:07:02 *** Highway61 has quit IRC
2462020-08-12T12:08:02 *** andreacab has quit IRC
2472020-08-12T12:18:56 *** lliehu has joined #bitcoin-core-dev
2482020-08-12T12:19:22 *** Highway61 has joined #bitcoin-core-dev
2492020-08-12T12:21:21 *** spikee has quit IRC
2502020-08-12T12:22:33 <wumpus> yes, definitely call out comments that you think are misleading or ask for more information if you think someone is not clear enough in their review, I definitely agree "number of ACKs" is not the only measure, judging whether something is ready for merge is not *that* trivial
2512020-08-12T12:23:03 *** wullon58 has joined #bitcoin-core-dev
2522020-08-12T12:23:19 *** wullon5 has quit IRC
2532020-08-12T12:24:25 <wumpus> in general I pay attention to: number of ACKs, who has ACKed, are there tests that cover the functionality, are there any unaddressed comments, if it's a bugfix did the original reporter test it, is there anyone with principal problems with the concept or its implementation, etc etcâ¦
2542020-08-12T12:26:07 <wumpus> it definitely also matters where the code change is, is it in one of the risky parts or only user facing, need different kinds of review
2552020-08-12T12:26:48 <wumpus> this is why we need actual maintainers and not a merge-bot :-)
2562020-08-12T12:27:18 *** troygiorshev has joined #bitcoin-core-dev
2572020-08-12T12:29:05 *** davec has quit IRC
2582020-08-12T12:29:20 *** davec has joined #bitcoin-core-dev
2592020-08-12T12:36:06 *** davec has quit IRC
2602020-08-12T12:41:42 <jnewbery> is there a make target that I can run before pushing that will maximize my chances of passing travis? I used to do `make check && ./test/functional/test_runner.py`, but that often doesn't catch stuff now because of linters and fuzzers.
2612020-08-12T12:41:56 *** justanotheruser has joined #bitcoin-core-dev
2622020-08-12T12:42:46 <fanquake> You could append && ./test/lint/lint-all.sh (I think) for the linters
2632020-08-12T12:43:11 <fanquake> If you want to sanity check the fuzzers you'll have to recompile
2642020-08-12T12:46:03 *** andreacab has joined #bitcoin-core-dev
2652020-08-12T12:53:19 *** andreacab has quit IRC
2662020-08-12T12:53:31 <troygiorshev> We were trying to get away from that, right? in #19388?
2672020-08-12T12:53:33 <gribble> https://github.com/bitcoin/bitcoin/issues/19388 | Build fuzz tests by default · Issue #19388 · bitcoin/bitcoin · GitHub
2682020-08-12T12:58:15 *** Pavlenex has joined #bitcoin-core-dev
2692020-08-12T12:58:38 *** TheHoliestRoger_ is now known as TheHoliestRoger
2702020-08-12T13:00:37 *** Pavlenex has quit IRC
2712020-08-12T13:00:48 *** promag has joined #bitcoin-core-dev
2722020-08-12T13:04:49 *** promag_ has joined #bitcoin-core-dev
2732020-08-12T13:05:37 *** promag has quit IRC
2742020-08-12T13:06:21 *** arowser_ has quit IRC
2752020-08-12T13:06:41 *** arowser_ has joined #bitcoin-core-dev
2762020-08-12T13:07:14 *** arowser_ has quit IRC
2772020-08-12T13:07:34 *** arowser_ has joined #bitcoin-core-dev
2782020-08-12T13:07:40 <wumpus> troygiorshev: yes and no: the fuzz tests that would be always built are shims and not actually useful for fuzzing, it's just to make sure there's 100% compiler coverage
2792020-08-12T13:08:12 *** arowser_ has quit IRC
2802020-08-12T13:08:52 *** arowser_ has joined #bitcoin-core-dev
2812020-08-12T13:09:12 *** arowser_ has quit IRC
2822020-08-12T13:09:14 *** promag_ has quit IRC
2832020-08-12T13:09:30 *** arowser_ has joined #bitcoin-core-dev
2842020-08-12T13:10:21 *** arowser_ has quit IRC
2852020-08-12T13:10:49 *** arowser_ has joined #bitcoin-core-dev
2862020-08-12T13:12:16 *** arowser_ has quit IRC
2872020-08-12T13:12:57 *** arowser_ has joined #bitcoin-core-dev
2882020-08-12T13:13:11 *** arowser_ has quit IRC
2892020-08-12T13:13:36 *** arowser_ has joined #bitcoin-core-dev
2902020-08-12T13:13:51 <troygiorshev> wumpus: you're right, thx
2912020-08-12T13:19:13 *** arowser_ has quit IRC
2922020-08-12T13:19:36 *** davec has joined #bitcoin-core-dev
2932020-08-12T13:19:38 *** arowser_ has joined #bitcoin-core-dev
2942020-08-12T13:23:40 *** bitcoin-git has joined #bitcoin-core-dev
2952020-08-12T13:23:40 <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/ce3bdd0ed1bb...bd00d3b1f203
2962020-08-12T13:23:42 <bitcoin-git> bitcoin/master f26502e John Newbery: [addrman] Specify max addresses and pct when calling GetAddresses()
2972020-08-12T13:23:43 <bitcoin-git> bitcoin/master ae8051b John Newbery: [test] Test that getnodeaddresses() can return all known addresses
2982020-08-12T13:23:43 <bitcoin-git> bitcoin/master 37a480e John Newbery: [net] Add addpeeraddress RPC method
2992020-08-12T13:23:44 *** bitcoin-git has left #bitcoin-core-dev
3002020-08-12T13:24:00 *** bitcoin-git has joined #bitcoin-core-dev
3012020-08-12T13:24:00 <bitcoin-git> [bitcoin] laanwj merged pull request #19658: [rpc] Allow RPC to fetch all addrman records and add records to addrman (master...2020-07-addrman-get) https://github.com/bitcoin/bitcoin/pull/19658
3022020-08-12T13:24:01 *** bitcoin-git has left #bitcoin-core-dev
3032020-08-12T13:24:11 *** andreacab has joined #bitcoin-core-dev
3042020-08-12T13:26:24 *** andreacab has quit IRC
3052020-08-12T13:32:27 *** lliehu has quit IRC
3062020-08-12T13:43:25 *** Guyver2_ has joined #bitcoin-core-dev
3072020-08-12T13:46:16 *** Guyver2 has quit IRC
3082020-08-12T13:46:16 *** Guyver2_ is now known as Guyver2
3092020-08-12T13:46:37 *** mdunnio has joined #bitcoin-core-dev
3102020-08-12T13:47:59 *** Guyver2_ has joined #bitcoin-core-dev
3112020-08-12T13:49:40 *** Chris_Stewart_5 has quit IRC
3122020-08-12T13:50:48 *** Guyver2 has quit IRC
3132020-08-12T13:51:45 *** Mikaku1 has joined #bitcoin-core-dev
3142020-08-12T13:55:17 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3152020-08-12T13:59:32 *** mdunnio has quit IRC
3162020-08-12T13:59:46 *** mdunnio has joined #bitcoin-core-dev
3172020-08-12T14:11:57 *** Pavlenex has joined #bitcoin-core-dev
3182020-08-12T14:15:48 *** b10c__ has joined #bitcoin-core-dev
3192020-08-12T14:17:03 *** b10c_ has quit IRC
3202020-08-12T14:20:11 *** bitcoin-git has joined #bitcoin-core-dev
3212020-08-12T14:20:11 <bitcoin-git> [bitcoin] vasild opened pull request #19705: Shrink CAddress from 48 to 40 bytes on x64 (master...shrink_caddress) https://github.com/bitcoin/bitcoin/pull/19705
3222020-08-12T14:20:13 *** bitcoin-git has left #bitcoin-core-dev
3232020-08-12T14:23:53 *** Pavlenex has quit IRC
3242020-08-12T14:24:15 *** Pavlenex has joined #bitcoin-core-dev
3252020-08-12T14:28:49 *** b10c has quit IRC
3262020-08-12T14:31:17 *** jonatack has joined #bitcoin-core-dev
3272020-08-12T14:32:14 *** arowser_ has quit IRC
3282020-08-12T14:32:54 *** arowser_ has joined #bitcoin-core-dev
3292020-08-12T14:36:29 *** jonatack has quit IRC
3302020-08-12T14:40:09 *** jonatack has joined #bitcoin-core-dev
3312020-08-12T14:41:00 *** Chris_Stewart_5 has quit IRC
3322020-08-12T14:44:32 *** bitcoin-git has joined #bitcoin-core-dev
3332020-08-12T14:44:33 <bitcoin-git> [bitcoin] theStack opened pull request #19706: refactor: make EncodeBase58{Check} consume Spans (master...20200810-util-make-base58encode-consume-spans) https://github.com/bitcoin/bitcoin/pull/19706
3342020-08-12T14:44:34 *** bitcoin-git has left #bitcoin-core-dev
3352020-08-12T14:45:17 *** arowser_ has quit IRC
3362020-08-12T14:45:45 *** arowser_ has joined #bitcoin-core-dev
3372020-08-12T14:45:51 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3382020-08-12T14:46:16 *** arowser_ has quit IRC
3392020-08-12T14:46:52 *** arowser_ has joined #bitcoin-core-dev
3402020-08-12T15:00:02 *** Mikaku1 has quit IRC
3412020-08-12T15:11:45 *** EagleTM has quit IRC
3422020-08-12T15:15:00 *** jonatack has quit IRC
3432020-08-12T15:15:23 *** PaulTroo_ has joined #bitcoin-core-dev
3442020-08-12T15:17:17 *** Davterra has quit IRC
3452020-08-12T15:18:05 *** PaulTro__ has quit IRC
3462020-08-12T15:20:51 *** Davterra has joined #bitcoin-core-dev
3472020-08-12T15:26:32 <jamesob> fwiw going to take some time this weekend to get the next assumeutxo PR filed, which will be the (unused) process for snapshot activation. main bottleneck is that I've gotta write some decent unittests, which will take a few hours.
3482020-08-12T15:29:21 *** jeremyrubin has joined #bitcoin-core-dev
3492020-08-12T15:29:25 *** davec has quit IRC
3502020-08-12T15:30:01 *** kristapsk_ has quit IRC
3512020-08-12T15:30:25 *** Davterra has quit IRC
3522020-08-12T15:32:04 *** Deacyde has quit IRC
3532020-08-12T15:37:10 *** Mercury_Vapor has quit IRC
3542020-08-12T15:38:25 *** davec has joined #bitcoin-core-dev
3552020-08-12T15:40:46 *** Mercury_Vapor has joined #bitcoin-core-dev
3562020-08-12T15:41:11 *** Mercury_Vapor has joined #bitcoin-core-dev
3572020-08-12T15:41:27 *** jonatack has joined #bitcoin-core-dev
3582020-08-12T15:48:50 *** davec has quit IRC
3592020-08-12T15:50:16 *** davec has joined #bitcoin-core-dev
3602020-08-12T15:50:37 *** sipsorcery has quit IRC
3612020-08-12T15:53:57 *** jb55 has joined #bitcoin-core-dev
3622020-08-12T15:55:08 *** amcrae1 has joined #bitcoin-core-dev
3632020-08-12T16:01:27 *** Pavlenex has quit IRC
3642020-08-12T16:01:33 *** troygiorshev has quit IRC
3652020-08-12T16:06:34 *** sipsorcery has joined #bitcoin-core-dev
3662020-08-12T16:12:46 *** troygiorshev has joined #bitcoin-core-dev
3672020-08-12T16:12:53 *** baldur has quit IRC
3682020-08-12T16:18:09 *** Pavlenex has joined #bitcoin-core-dev
3692020-08-12T16:25:22 *** baldur has joined #bitcoin-core-dev
3702020-08-12T16:31:15 *** arowser_ has quit IRC
3712020-08-12T16:31:43 *** arowser_ has joined #bitcoin-core-dev
3722020-08-12T16:31:46 *** bitcoin-git has joined #bitcoin-core-dev
3732020-08-12T16:31:46 <bitcoin-git> [bitcoin] achow101 closed pull request #19653: wallet: Replace -zapwallettxes with zapwallettxes RPC (master...zapwallettxes-rpc) https://github.com/bitcoin/bitcoin/pull/19653
3742020-08-12T16:31:55 *** bitcoin-git has left #bitcoin-core-dev
3752020-08-12T16:32:03 <willcl_ark> troygiorshev: I did make a bit of progress on #19388 but could not get the linking working correctly at the end. If you have any ideas on this, my branch is here: https://github.com/willcl-ark/bitcoin/tree/default_fuzz_tests
3762020-08-12T16:32:04 <gribble> https://github.com/bitcoin/bitcoin/issues/19388 | Build fuzz tests by default · Issue #19388 · bitcoin/bitcoin · GitHub
3772020-08-12T16:33:49 <troygiorshev> willcl_ark: thanks for the link. build stuff is definitely something I'm weak on, but if I spend a day figuring it out I'll give that a look!
3782020-08-12T16:35:04 *** Guyver2__ has joined #bitcoin-core-dev
3792020-08-12T16:37:26 *** Guyver2_ has quit IRC
3802020-08-12T16:49:27 *** tripleslash has joined #bitcoin-core-dev
3812020-08-12T16:49:57 *** Pavlenex has quit IRC
3822020-08-12T16:52:33 *** Chris_Stewart_5 has quit IRC
3832020-08-12T16:52:40 *** gzhao408 has joined #bitcoin-core-dev
3842020-08-12T16:57:42 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3852020-08-12T16:59:10 *** Guyver2_ has joined #bitcoin-core-dev
3862020-08-12T17:01:23 *** lightlike has joined #bitcoin-core-dev
3872020-08-12T17:01:31 *** mrostecki has joined #bitcoin-core-dev
3882020-08-12T17:02:01 *** Guyver2__ has quit IRC
3892020-08-12T17:05:39 <nehan> "< wumpus> this is why we need actual maintainers and not a merge-bot :-)" <-- wait wumpus isn't a bot?
3902020-08-12T17:11:49 *** Highway62 has joined #bitcoin-core-dev
3912020-08-12T17:12:14 *** Highway61 has quit IRC
3922020-08-12T17:12:14 *** Highway62 is now known as Highway61
3932020-08-12T17:14:35 *** pinheadmz has quit IRC
3942020-08-12T17:24:40 *** PaulTroo_ has quit IRC
3952020-08-12T17:26:19 *** EagleTM has joined #bitcoin-core-dev
3962020-08-12T17:27:16 *** Chris_Stewart_5 has quit IRC
3972020-08-12T17:28:44 *** Highway61 has quit IRC
3982020-08-12T17:28:46 *** mrostecki has quit IRC
3992020-08-12T17:29:58 *** bitcoin-git has joined #bitcoin-core-dev
4002020-08-12T17:29:59 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bd00d3b1f203...13c4635a3ecf
4012020-08-12T17:29:59 <bitcoin-git> bitcoin/master a51d0ad Fabian Jahr: rpc: Improve addnode remove command error message
4022020-08-12T17:30:00 <bitcoin-git> bitcoin/master 13c4635 Wladimir J. van der Laan: Merge #19696: rpc: Fix addnode remove command error
4032020-08-12T17:30:02 *** bitcoin-git has left #bitcoin-core-dev
4042020-08-12T17:30:19 *** bitcoin-git has joined #bitcoin-core-dev
4052020-08-12T17:30:19 <bitcoin-git> [bitcoin] laanwj merged pull request #19696: rpc: Fix addnode remove command error (master...rpc_net_tests) https://github.com/bitcoin/bitcoin/pull/19696
4062020-08-12T17:30:31 *** bitcoin-git has left #bitcoin-core-dev
4072020-08-12T17:32:08 *** arowser_ has quit IRC
4082020-08-12T17:32:32 *** arowser_ has joined #bitcoin-core-dev
4092020-08-12T17:33:36 *** Chris_Stewart_5 has joined #bitcoin-core-dev
4102020-08-12T18:00:01 *** amcrae1 has quit IRC
4112020-08-12T18:02:17 *** EagleTM has quit IRC
4122020-08-12T18:02:53 *** sipsorcery has quit IRC
4132020-08-12T18:06:43 *** gzhao408 has quit IRC
4142020-08-12T18:07:58 *** Pavlenex has joined #bitcoin-core-dev
4152020-08-12T18:12:41 *** Landryl3 has joined #bitcoin-core-dev
4162020-08-12T18:12:57 *** Galvas_ has joined #bitcoin-core-dev
4172020-08-12T18:13:02 *** GoldmanSats_ has joined #bitcoin-core-dev
4182020-08-12T18:13:06 *** hsmiths_ has joined #bitcoin-core-dev
4192020-08-12T18:13:06 *** jkczyz_ has joined #bitcoin-core-dev
4202020-08-12T18:13:06 *** ajonas_ has joined #bitcoin-core-dev
4212020-08-12T18:13:21 *** Pavlenex has quit IRC
4222020-08-12T18:13:28 *** bosma_ has joined #bitcoin-core-dev
4232020-08-12T18:20:07 *** meshcoll- has joined #bitcoin-core-dev
4242020-08-12T18:20:35 *** thunderbiscuit[m has quit IRC
4252020-08-12T18:20:36 *** TheFuzzStone[m] has quit IRC
4262020-08-12T18:20:37 *** Galvas has quit IRC
4272020-08-12T18:20:37 *** GoldmanSats has quit IRC
4282020-08-12T18:20:37 *** meshcollider has quit IRC
4292020-08-12T18:20:37 *** bosma has quit IRC
4302020-08-12T18:20:37 *** hsmiths has quit IRC
4312020-08-12T18:20:37 *** ajonas has quit IRC
4322020-08-12T18:20:37 *** Landryl has quit IRC
4332020-08-12T18:20:37 *** jkczyz has quit IRC
4342020-08-12T18:20:37 *** Landryl3 is now known as Landryl
4352020-08-12T18:20:37 *** hsmiths_ is now known as hsmiths
4362020-08-12T18:20:37 *** jkczyz_ is now known as jkczyz
4372020-08-12T18:20:38 *** Galvas_ is now known as Galvas
4382020-08-12T18:20:40 *** bosma_ is now known as bosma
4392020-08-12T18:21:39 *** icota[m] has quit IRC
4402020-08-12T18:27:03 *** thunderbiscuit[m has joined #bitcoin-core-dev
4412020-08-12T18:31:04 *** pinheadmz has joined #bitcoin-core-dev
4422020-08-12T18:38:46 *** PaulTroo_ has joined #bitcoin-core-dev
4432020-08-12T18:42:29 *** Davterra has joined #bitcoin-core-dev
4442020-08-12T18:48:14 *** go121212 has quit IRC
4452020-08-12T18:48:41 *** kyprizel has joined #bitcoin-core-dev
4462020-08-12T18:49:24 *** EagleTM has joined #bitcoin-core-dev
4472020-08-12T18:49:28 *** icota[m] has joined #bitcoin-core-dev
4482020-08-12T18:49:29 *** TheFuzzStone[m] has joined #bitcoin-core-dev
4492020-08-12T18:57:16 *** sipsorcery has joined #bitcoin-core-dev
4502020-08-12T18:59:56 *** PaulTro__ has joined #bitcoin-core-dev
4512020-08-12T19:03:06 *** PaulTroo_ has quit IRC
4522020-08-12T19:10:10 <wumpus> nehan: shhh that's supposed to be secret
4532020-08-12T19:25:03 <michaelfolkson> If we were going to down the road of quantifying it, it would be a reputation score for each reviewer based on various metrics e.g. bugs found in past, code reviews that led to material changes in the code other than nits, number of PRs reviewed, understanding displayed in the past on the part of the codebase they are reviewing.
4542020-08-12T19:25:25 <michaelfolkson> Obivuosly we won't go down that road but highlights why simple ACK counts aren't sufficient
4552020-08-12T19:31:47 *** Guyver2_ has quit IRC
4562020-08-12T19:34:43 *** Talkless has quit IRC
4572020-08-12T19:35:48 <michaelfolkson> The only downside to beginners posting comments about testing etc that I see is GitHub hides large swathes of comments (Marco has mentioned this before). I don't see any harm otherwise when the maintainers can just ignore them.
4582020-08-12T19:36:54 <michaelfolkson> Assuming we all understand that one ACK can be much more valuable than another ACK
4592020-08-12T19:37:06 *** pinheadmz has quit IRC
4602020-08-12T19:38:45 *** T3 has joined #bitcoin-core-dev
4612020-08-12T19:43:41 <sipa> an "expand all" button on github pages would be really useful
4622020-08-12T19:44:03 <sipa> it's a pain to go through the history of big PRs as an author to see if you've addressed everything
4632020-08-12T19:47:43 <michaelfolkson> Something like this https://github.com/isaacs/github/issues/1190#issuecomment-367607027
4642020-08-12T19:48:17 <michaelfolkson> It must be a commonly requested feature
4652020-08-12T19:52:17 <wumpus> michaelfolkson: maybe, the thing is, as soon as you quantify it, people will try to game it
4662020-08-12T19:52:50 <michaelfolkson> It wasn't a serious suggestion. Just a thought exercise ;)
4672020-08-12T19:53:51 <michaelfolkson> In reality the discretion of maintainers is the best option of many worse options
4682020-08-12T19:56:02 <sipa> goodhart's law
4692020-08-12T20:05:45 <luke-jr> sipa: at least a few times, I didn't even realise I was missing the comments :/
4702020-08-12T20:09:45 *** owowo has quit IRC
4712020-08-12T20:14:45 <wumpus> michaelfolkson: but yes it's annoying that github hides comments, like at some point they made the website too heavy for some browsers then they started hiding comments to compensate for that, if it was just dumb HTML there'd be no problem
4722020-08-12T20:14:55 *** owowo has joined #bitcoin-core-dev
4732020-08-12T20:14:55 *** owowo has joined #bitcoin-core-dev
4742020-08-12T20:15:10 <sipa> i'm ok even with if hiding stuff by default
4752020-08-12T20:15:22 <wumpus> or even a forum-like "page 1 of N" interface would be better than this
4762020-08-12T20:15:26 <sipa> but clicking to expand everything can take ages
4772020-08-12T20:16:36 <wumpus> yes, when you expand everything it becomes really slow
4782020-08-12T20:16:59 <wumpus> there's probably 40MB of javascript running in the background
4792020-08-12T20:17:57 *** pinheadmz has joined #bitcoin-core-dev
4802020-08-12T20:19:06 * sipa , remembering spendong 4 hours downloading several megabytes internet explorer when he first got internet..
4812020-08-12T20:21:42 *** meshcoll- has quit IRC
4822020-08-12T20:22:07 *** meshcollider has joined #bitcoin-core-dev
4832020-08-12T20:22:48 *** bitcoin-git has joined #bitcoin-core-dev
4842020-08-12T20:22:48 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/13c4635a3ecf...038a04eb80a5
4852020-08-12T20:22:49 <bitcoin-git> bitcoin/master c71bdf9 Hennadii Stepanov: build, test: Add support for llvm-cov
4862020-08-12T20:22:49 <bitcoin-git> bitcoin/master 8ebc050 Hennadii Stepanov: build: Add missed fuzz_filtered.info to COVERAGE_INFO
4872020-08-12T20:22:50 <bitcoin-git> bitcoin/master 75f9659 Hennadii Stepanov: build: Add missed fuzz.coverage/ directory to .gitignore
4882020-08-12T20:22:59 *** bitcoin-git has left #bitcoin-core-dev
4892020-08-12T20:23:12 *** bitcoin-git has joined #bitcoin-core-dev
4902020-08-12T20:23:13 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19688: build: Add support for llvm-cov (master...200808-lcov) https://github.com/bitcoin/bitcoin/pull/19688
4912020-08-12T20:23:14 *** bitcoin-git has left #bitcoin-core-dev
4922020-08-12T20:25:26 *** mol has quit IRC
4932020-08-12T20:26:21 *** mol has joined #bitcoin-core-dev
4942020-08-12T20:42:03 *** PaulTro__ has quit IRC
4952020-08-12T20:42:26 *** Davterra has quit IRC
4962020-08-12T20:42:51 *** Davterra has joined #bitcoin-core-dev
4972020-08-12T20:51:53 *** dergoegge has joined #bitcoin-core-dev
4982020-08-12T20:55:03 *** proofofkeags has joined #bitcoin-core-dev
4992020-08-12T21:00:02 *** kyprizel has quit IRC
5002020-08-12T21:04:26 *** Mario35Carroll has joined #bitcoin-core-dev
5012020-08-12T21:05:18 *** go1111111 has joined #bitcoin-core-dev
5022020-08-12T21:20:09 *** kaimi1 has joined #bitcoin-core-dev
5032020-08-12T21:32:40 *** vincenzopalazzo has quit IRC
5042020-08-12T21:38:45 *** fox2p has quit IRC
5052020-08-12T21:39:58 *** fox2p has joined #bitcoin-core-dev
5062020-08-12T21:53:56 *** EagleTM has quit IRC
5072020-08-12T22:09:36 *** tryphe has joined #bitcoin-core-dev
5082020-08-12T22:11:56 *** lightlike has quit IRC
5092020-08-12T22:12:39 *** Mario35Carroll has quit IRC
5102020-08-12T22:21:34 *** mdunnio has quit IRC
5112020-08-12T22:24:32 *** AaronvanW has joined #bitcoin-core-dev
5122020-08-12T22:31:35 *** mrostecki has joined #bitcoin-core-dev
5132020-08-12T22:53:03 *** proofofkeags has quit IRC
5142020-08-12T22:53:05 *** marcoagner has quit IRC
5152020-08-12T22:58:43 *** vasild has quit IRC
5162020-08-12T23:00:35 *** vasild has joined #bitcoin-core-dev
5172020-08-12T23:00:52 *** reallll is now known as belcher
5182020-08-12T23:01:46 *** mdunnio has joined #bitcoin-core-dev
5192020-08-12T23:06:35 *** mdunnio has quit IRC
5202020-08-12T23:14:30 *** Highway61 has joined #bitcoin-core-dev
5212020-08-12T23:39:43 *** Davterra has quit IRC
5222020-08-12T23:40:44 *** T3 has quit IRC
5232020-08-12T23:49:45 *** sipsorcery has quit IRC
5242020-08-12T23:51:39 *** mrostecki has quit IRC
5252020-08-12T23:52:46 <fanquake> wumpus sipa: I've also been trying to make the point to GH https://0bin.net/paste/jzVybfePdQQQgBcs#Y2Vh1PlrS2WQBeT8TRJPJPfaOlIgcsR53q1iHk+AW2l
5262020-08-12T23:53:26 <fanquake> Obviously still not complaining loud enough