12020-08-13T00:00:01 *** kaimi1 has quit IRC
22020-08-13T00:03:09 *** jarthur_ has joined #bitcoin-core-dev
32020-08-13T00:06:16 *** jarthur has quit IRC
42020-08-13T00:11:26 *** gzhao408 has joined #bitcoin-core-dev
52020-08-13T00:15:26 *** gzhao408 has quit IRC
62020-08-13T00:21:53 *** bitcoin-git has joined #bitcoin-core-dev
72020-08-13T00:21:54 <bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/038a04eb80a5...8a85377cd0b6
82020-08-13T00:21:55 <bitcoin-git> bitcoin/master 4638224 Andrew Chow: Add psbtbumpfee RPC
92020-08-13T00:21:55 <bitcoin-git> bitcoin/master 431071c Andrew Chow: Hide bumpfee's psbt creation behavior behind -deprecatedrpc
102020-08-13T00:21:56 <bitcoin-git> bitcoin/master 79d6332 Andrew Chow: moveonly: Fix indentation in bumpfee RPC
112020-08-13T00:21:58 *** bitcoin-git has left #bitcoin-core-dev
122020-08-13T00:22:05 *** RISCi_ATOM1 has joined #bitcoin-core-dev
132020-08-13T00:22:52 *** bitcoin-git has joined #bitcoin-core-dev
142020-08-13T00:22:52 <bitcoin-git> [bitcoin] meshcollider merged pull request #18654: rpc: separate bumpfee's psbt creation function into psbtbumpfee (master...psbtbumpfee) https://github.com/bitcoin/bitcoin/pull/18654
152020-08-13T00:22:53 *** bitcoin-git has left #bitcoin-core-dev
162020-08-13T00:37:35 *** ajonas_ has quit IRC
172020-08-13T00:38:07 *** ajonas has joined #bitcoin-core-dev
182020-08-13T00:42:28 *** mdunnio has joined #bitcoin-core-dev
192020-08-13T00:50:47 *** jarthur_ has quit IRC
202020-08-13T00:52:46 *** Davterra has joined #bitcoin-core-dev
212020-08-13T01:11:44 *** frogar has quit IRC
222020-08-13T01:12:03 *** frogar has joined #bitcoin-core-dev
232020-08-13T01:21:07 *** stevenroose has quit IRC
242020-08-13T01:25:05 *** stevenroose has joined #bitcoin-core-dev
252020-08-13T01:34:14 *** troygiorshev has quit IRC
262020-08-13T01:39:06 *** arowser_ has quit IRC
272020-08-13T01:39:49 *** arowser_ has joined #bitcoin-core-dev
282020-08-13T01:40:48 *** troygiorshev has joined #bitcoin-core-dev
292020-08-13T01:42:37 *** mdunnio has quit IRC
302020-08-13T01:44:11 *** arowser_ has quit IRC
312020-08-13T01:50:42 *** arowser_ has joined #bitcoin-core-dev
322020-08-13T02:03:10 *** arowser_ has quit IRC
332020-08-13T02:04:21 *** arowser_ has joined #bitcoin-core-dev
342020-08-13T02:10:54 *** arowser_ has quit IRC
352020-08-13T02:11:11 *** watersnake1 has joined #bitcoin-core-dev
362020-08-13T02:14:35 *** arowser_ has joined #bitcoin-core-dev
372020-08-13T02:17:51 *** watersnake1 has quit IRC
382020-08-13T02:18:20 *** watersnake1 has joined #bitcoin-core-dev
392020-08-13T02:19:56 *** mdunnio has joined #bitcoin-core-dev
402020-08-13T02:21:14 *** watersnake1 has quit IRC
412020-08-13T02:24:52 *** mdunnio has quit IRC
422020-08-13T02:24:57 *** AaronvanW has quit IRC
432020-08-13T02:26:59 *** arowser_ has quit IRC
442020-08-13T02:39:17 *** arowser_ has joined #bitcoin-core-dev
452020-08-13T02:49:10 *** bitdex has joined #bitcoin-core-dev
462020-08-13T02:58:08 *** AaronvanW has joined #bitcoin-core-dev
472020-08-13T03:00:02 *** RISCi_ATOM1 has quit IRC
482020-08-13T03:02:35 *** AaronvanW has quit IRC
492020-08-13T03:12:13 *** arowser_ has quit IRC
502020-08-13T03:12:33 *** arowser_ has joined #bitcoin-core-dev
512020-08-13T03:16:50 *** Highway61 has quit IRC
522020-08-13T03:17:16 *** Highway61 has joined #bitcoin-core-dev
532020-08-13T03:19:26 *** justanotheruser has quit IRC
542020-08-13T03:21:34 *** mdrjr1 has joined #bitcoin-core-dev
552020-08-13T03:41:25 *** troygiorshev has quit IRC
562020-08-13T03:43:38 *** Highway61 has quit IRC
572020-08-13T03:46:24 *** arowser_ has quit IRC
582020-08-13T03:46:38 *** justanotheruser has joined #bitcoin-core-dev
592020-08-13T03:52:57 *** arowser_ has joined #bitcoin-core-dev
602020-08-13T04:18:25 *** jarthur has joined #bitcoin-core-dev
612020-08-13T04:27:09 *** jarthur has quit IRC
622020-08-13T04:43:20 *** AaronvanW has joined #bitcoin-core-dev
632020-08-13T04:46:25 *** PaulTroo_ has joined #bitcoin-core-dev
642020-08-13T04:51:00 *** PaulTroo_ has quit IRC
652020-08-13T04:59:46 *** waldoirc has joined #bitcoin-core-dev
662020-08-13T05:05:06 *** shesek has quit IRC
672020-08-13T05:09:25 *** davec has quit IRC
682020-08-13T05:12:11 *** Mercury_Vapor has quit IRC
692020-08-13T05:16:43 *** AaronvanW has quit IRC
702020-08-13T05:28:46 *** mdunnio has joined #bitcoin-core-dev
712020-08-13T05:29:12 *** EagleTM has joined #bitcoin-core-dev
722020-08-13T05:33:35 *** mdunnio has quit IRC
732020-08-13T05:34:51 *** T3 has joined #bitcoin-core-dev
742020-08-13T05:39:44 <wumpus> fanquake: thanks
752020-08-13T05:44:12 *** arowser_ has quit IRC
762020-08-13T05:44:29 *** arowser_ has joined #bitcoin-core-dev
772020-08-13T06:00:01 *** mdrjr1 has quit IRC
782020-08-13T06:00:48 *** proofofkeags has joined #bitcoin-core-dev
792020-08-13T06:05:14 *** arowser_ has quit IRC
802020-08-13T06:05:33 *** arowser_ has joined #bitcoin-core-dev
812020-08-13T06:20:07 *** directhex1 has joined #bitcoin-core-dev
822020-08-13T06:24:10 *** arowser_ has quit IRC
832020-08-13T06:24:29 *** arowser_ has joined #bitcoin-core-dev
842020-08-13T06:28:29 *** AaronvanW has joined #bitcoin-core-dev
852020-08-13T06:33:13 *** PaulTroo_ has joined #bitcoin-core-dev
862020-08-13T06:38:25 *** Mercury_Vapor has joined #bitcoin-core-dev
872020-08-13T06:38:27 *** sipsorcery has joined #bitcoin-core-dev
882020-08-13T06:53:14 *** trash_mapache has joined #bitcoin-core-dev
892020-08-13T06:54:07 *** Talkless has joined #bitcoin-core-dev
902020-08-13T07:00:41 *** AaronvanW has quit IRC
912020-08-13T07:01:14 *** marcoagner has joined #bitcoin-core-dev
922020-08-13T07:02:08 *** bitcoin-git has joined #bitcoin-core-dev
932020-08-13T07:02:09 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19707: net: Remove unused conn_type default arg in OpenNetworkConnection (master...1908-netDefault) https://github.com/bitcoin/bitcoin/pull/19707
942020-08-13T07:02:10 *** bitcoin-git has left #bitcoin-core-dev
952020-08-13T07:09:01 *** trash_mapache has quit IRC
962020-08-13T07:13:17 *** andreacab has joined #bitcoin-core-dev
972020-08-13T07:13:44 *** bitcoin-git has joined #bitcoin-core-dev
982020-08-13T07:13:44 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16548: Make the global flag *fDiscover* an instance variable of CConnman (master...bitcoin_issue_14210) https://github.com/bitcoin/bitcoin/pull/16548
992020-08-13T07:13:45 *** bitcoin-git has left #bitcoin-core-dev
1002020-08-13T07:14:38 *** andreacab has quit IRC
1012020-08-13T07:15:00 *** proofofkeags has quit IRC
1022020-08-13T07:15:28 *** bitcoin-git has joined #bitcoin-core-dev
1032020-08-13T07:15:28 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #13360: [Policy] Reject SIGHASH_SINGLE with output out of bound (master...insecure_single) https://github.com/bitcoin/bitcoin/pull/13360
1042020-08-13T07:15:29 *** bitcoin-git has left #bitcoin-core-dev
1052020-08-13T07:25:53 *** jonatack has quit IRC
1062020-08-13T07:33:12 *** arowser_ has quit IRC
1072020-08-13T07:33:40 *** arowser_ has joined #bitcoin-core-dev
1082020-08-13T07:36:56 *** davec has joined #bitcoin-core-dev
1092020-08-13T07:39:53 *** Davterra has quit IRC
1102020-08-13T07:40:26 *** Davterra has joined #bitcoin-core-dev
1112020-08-13T07:44:13 *** vincenzopalazzo has joined #bitcoin-core-dev
1122020-08-13T07:50:03 *** ghost43_ has quit IRC
1132020-08-13T07:51:08 *** ghost43 has joined #bitcoin-core-dev
1142020-08-13T08:07:58 *** jonatack has joined #bitcoin-core-dev
1152020-08-13T08:16:13 *** AaronvanW has joined #bitcoin-core-dev
1162020-08-13T08:30:49 *** arowser_ has quit IRC
1172020-08-13T08:37:48 *** arowser_ has joined #bitcoin-core-dev
1182020-08-13T08:39:10 *** bitcoin-git has joined #bitcoin-core-dev
1192020-08-13T08:39:10 <bitcoin-git> [bitcoin] jonasschnelli pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/8a85377cd0b6...1052b09031c6
1202020-08-13T08:39:11 <bitcoin-git> bitcoin/master 25e1d0b Jonas Schnelli: RPCConsole, take initial chaintip data as parameter
1212020-08-13T08:39:11 <bitcoin-git> bitcoin/master b354a14 Jonas Schnelli: Add BlockAndHeaderTipInfo to the node interface/appInit
1222020-08-13T08:39:12 <bitcoin-git> bitcoin/master d42cb79 Jonas Schnelli: Optionally populate BlockAndHeaderTipInfo during AppInitMain
1232020-08-13T08:39:13 *** bitcoin-git has left #bitcoin-core-dev
1242020-08-13T08:40:00 *** bitcoin-git has joined #bitcoin-core-dev
1252020-08-13T08:40:00 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #19011: Reduce cs_main lock accumulation during GUI startup (master...2020/05/guilocks) https://github.com/bitcoin/bitcoin/pull/19011
1262020-08-13T08:40:01 *** bitcoin-git has left #bitcoin-core-dev
1272020-08-13T08:40:13 *** arowser_ has quit IRC
1282020-08-13T08:40:33 *** arowser_ has joined #bitcoin-core-dev
1292020-08-13T08:41:16 *** arowser_ has quit IRC
1302020-08-13T08:41:43 *** arowser_ has joined #bitcoin-core-dev
1312020-08-13T08:43:13 *** proofofkeags has joined #bitcoin-core-dev
1322020-08-13T08:48:35 *** proofofkeags has quit IRC
1332020-08-13T09:00:01 *** directhex1 has quit IRC
1342020-08-13T09:18:50 *** AaronvanW has quit IRC
1352020-08-13T09:32:00 *** proofofkeags has joined #bitcoin-core-dev
1362020-08-13T09:34:19 *** AaronvanW has joined #bitcoin-core-dev
1372020-08-13T09:34:59 *** Davterra has quit IRC
1382020-08-13T09:35:56 *** Davterra has joined #bitcoin-core-dev
1392020-08-13T09:40:38 *** proofofkeags has quit IRC
1402020-08-13T09:44:29 *** jonatack has quit IRC
1412020-08-13T09:48:55 *** belcher has quit IRC
1422020-08-13T09:49:01 *** belcher_ has joined #bitcoin-core-dev
1432020-08-13T09:49:38 *** Davterra has quit IRC
1442020-08-13T09:50:42 *** Davterra has joined #bitcoin-core-dev
1452020-08-13T09:54:53 *** vBm1 has joined #bitcoin-core-dev
1462020-08-13T10:03:20 *** Phoebe89Zulauf has joined #bitcoin-core-dev
1472020-08-13T10:08:19 *** luke-jr has quit IRC
1482020-08-13T10:10:41 *** luke-jr has joined #bitcoin-core-dev
1492020-08-13T10:10:55 *** Phoebe89Zulauf has quit IRC
1502020-08-13T10:13:41 *** bitcoin-git has joined #bitcoin-core-dev
1512020-08-13T10:13:42 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1052b09031c6...6757b3ac8f67
1522020-08-13T10:13:42 <bitcoin-git> bitcoin/master c133cdc Adam Stein: Cap listsinceblock target_confirmations param
1532020-08-13T10:13:43 <bitcoin-git> bitcoin/master 6757b3a Wladimir J. van der Laan: Merge #19655: rpc: Catch listsinceblock target_confirmations exceeding blo...
1542020-08-13T10:13:44 *** bitcoin-git has left #bitcoin-core-dev
1552020-08-13T10:14:01 *** bitcoin-git has joined #bitcoin-core-dev
1562020-08-13T10:14:02 <bitcoin-git> [bitcoin] laanwj merged pull request #19655: rpc: Catch listsinceblock target_confirmations exceeding block count (master...listsinceblock_rpc) https://github.com/bitcoin/bitcoin/pull/19655
1572020-08-13T10:14:04 *** bitcoin-git has left #bitcoin-core-dev
1582020-08-13T10:33:40 *** proofofkeags has joined #bitcoin-core-dev
1592020-08-13T10:38:59 *** proofofkeags has quit IRC
1602020-08-13T10:40:05 *** jonatack has joined #bitcoin-core-dev
1612020-08-13T10:41:00 *** T3 has quit IRC
1622020-08-13T10:41:17 *** T3 has joined #bitcoin-core-dev
1632020-08-13T10:42:29 *** Pavlenex has joined #bitcoin-core-dev
1642020-08-13T10:44:21 *** Pavlenex has quit IRC
1652020-08-13T10:50:58 *** Pavlenex has joined #bitcoin-core-dev
1662020-08-13T10:54:45 *** Davterra has quit IRC
1672020-08-13T10:55:44 *** vasild_ has joined #bitcoin-core-dev
1682020-08-13T10:55:45 *** Davterra has joined #bitcoin-core-dev
1692020-08-13T10:58:43 *** vasild has quit IRC
1702020-08-13T10:58:44 *** vasild_ is now known as vasild
1712020-08-13T11:02:10 *** mrostecki has joined #bitcoin-core-dev
1722020-08-13T11:14:20 *** shesek has joined #bitcoin-core-dev
1732020-08-13T11:14:20 *** shesek has joined #bitcoin-core-dev
1742020-08-13T11:26:02 *** troygiorshev has joined #bitcoin-core-dev
1752020-08-13T11:26:03 *** sipsorcery has quit IRC
1762020-08-13T11:34:26 *** bitcoin-git has joined #bitcoin-core-dev
1772020-08-13T11:34:27 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #19707: net: Remove unused conn_type default arg in OpenNetworkConnection (master...1908-netDefault) https://github.com/bitcoin/bitcoin/pull/19707
1782020-08-13T11:34:27 *** bitcoin-git has left #bitcoin-core-dev
1792020-08-13T11:42:11 *** arowser_ has quit IRC
1802020-08-13T11:42:30 *** arowser_ has joined #bitcoin-core-dev
1812020-08-13T11:52:27 *** vBm1 has quit IRC
1822020-08-13T11:55:35 *** troygiorshev has quit IRC
1832020-08-13T11:55:51 *** troygiorshev has joined #bitcoin-core-dev
1842020-08-13T11:56:17 *** arowser_ has quit IRC
1852020-08-13T11:57:31 *** sipsorcery has joined #bitcoin-core-dev
1862020-08-13T11:58:26 *** arowser_ has joined #bitcoin-core-dev
1872020-08-13T12:09:44 *** Davterra has quit IRC
1882020-08-13T12:09:56 *** Davterra has joined #bitcoin-core-dev
1892020-08-13T12:20:16 *** tadeo has joined #bitcoin-core-dev
1902020-08-13T12:20:39 *** proofofkeags has joined #bitcoin-core-dev
1912020-08-13T12:24:48 *** Davterra has quit IRC
1922020-08-13T12:25:08 *** arowser_ has quit IRC
1932020-08-13T12:25:28 *** proofofkeags has quit IRC
1942020-08-13T12:25:43 *** Davterra has joined #bitcoin-core-dev
1952020-08-13T12:27:03 *** arowser_ has joined #bitcoin-core-dev
1962020-08-13T12:31:10 *** face has joined #bitcoin-core-dev
1972020-08-13T12:33:38 *** sipsorcery has quit IRC
1982020-08-13T12:35:01 *** Davterra has quit IRC
1992020-08-13T12:35:56 *** Davterra has joined #bitcoin-core-dev
2002020-08-13T12:42:33 *** Guyver2 has joined #bitcoin-core-dev
2012020-08-13T12:44:23 *** Davterra has quit IRC
2022020-08-13T12:45:01 *** Davterra has joined #bitcoin-core-dev
2032020-08-13T12:49:03 *** mrostecki has quit IRC
2042020-08-13T12:50:16 *** sipsorcery has joined #bitcoin-core-dev
2052020-08-13T13:00:05 *** Davterra has quit IRC
2062020-08-13T13:00:25 *** Highway61 has joined #bitcoin-core-dev
2072020-08-13T13:00:52 *** Davterra has joined #bitcoin-core-dev
2082020-08-13T13:06:22 *** arowser_ has quit IRC
2092020-08-13T13:06:50 *** arowser_ has joined #bitcoin-core-dev
2102020-08-13T13:07:13 *** arowser_ has quit IRC
2112020-08-13T13:07:33 *** arowser_ has joined #bitcoin-core-dev
2122020-08-13T13:08:17 *** arowser_ has quit IRC
2132020-08-13T13:08:45 *** arowser_ has joined #bitcoin-core-dev
2142020-08-13T13:09:05 *** MDrollette has quit IRC
2152020-08-13T13:09:15 *** arowser_ has quit IRC
2162020-08-13T13:14:17 *** mdrollette has joined #bitcoin-core-dev
2172020-08-13T13:15:18 *** arowser_ has joined #bitcoin-core-dev
2182020-08-13T13:16:04 *** proofofkeags has joined #bitcoin-core-dev
2192020-08-13T13:18:44 *** shesek has quit IRC
2202020-08-13T13:21:22 *** gzhao408 has joined #bitcoin-core-dev
2212020-08-13T13:23:16 *** Guyver2_ has joined #bitcoin-core-dev
2222020-08-13T13:23:35 *** EagleTM has quit IRC
2232020-08-13T13:26:20 *** Guyver2 has quit IRC
2242020-08-13T13:31:15 *** bitcoin-git has joined #bitcoin-core-dev
2252020-08-13T13:31:15 <bitcoin-git> [bitcoin] hebasto opened pull request #19709: test: Fix 'make cov' with clang (master...200813-lcov) https://github.com/bitcoin/bitcoin/pull/19709
2262020-08-13T13:31:16 *** bitcoin-git has left #bitcoin-core-dev
2272020-08-13T13:37:48 *** luke-jr has quit IRC
2282020-08-13T13:38:10 *** luke-jr has joined #bitcoin-core-dev
2292020-08-13T13:44:28 *** proofofkeags has quit IRC
2302020-08-13T13:44:43 *** proofofkeags has joined #bitcoin-core-dev
2312020-08-13T13:45:05 *** bitdex_ has joined #bitcoin-core-dev
2322020-08-13T13:45:18 *** bitcoin-git has joined #bitcoin-core-dev
2332020-08-13T13:45:19 <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/6757b3ac8f67...b4d0366b47dd
2342020-08-13T13:45:20 <bitcoin-git> bitcoin/master b3fbc94 John Newbery: Apply cfilters review fixups
2352020-08-13T13:45:21 <bitcoin-git> bitcoin/master 132b30d Jim Posen: [net] Signal NODE_COMPACT_FILTERS if we're serving compact filters.
2362020-08-13T13:45:22 <bitcoin-git> bitcoin/master f5c003d Jim Posen: [test] Add test for NODE_COMPACT_FILTER.
2372020-08-13T13:45:24 *** bitcoin-git has left #bitcoin-core-dev
2382020-08-13T13:46:03 *** bitcoin-git has joined #bitcoin-core-dev
2392020-08-13T13:46:03 <bitcoin-git> [bitcoin] laanwj merged pull request #19070: p2p: Signal support for compact block filters with NODE_COMPACT_FILTERS (master...2020-05-node-compact-filters) https://github.com/bitcoin/bitcoin/pull/19070
2402020-08-13T13:46:04 *** bitcoin-git has left #bitcoin-core-dev
2412020-08-13T13:48:03 *** bitdex has quit IRC
2422020-08-13T13:51:18 *** mrostecki has joined #bitcoin-core-dev
2432020-08-13T13:55:01 *** mdunnio has joined #bitcoin-core-dev
2442020-08-13T13:59:25 *** vincenzopalazzo has quit IRC
2452020-08-13T14:12:20 *** arowser_ has quit IRC
2462020-08-13T14:12:49 *** arowser_ has joined #bitcoin-core-dev
2472020-08-13T14:14:52 *** vincenzopalazzo has joined #bitcoin-core-dev
2482020-08-13T14:15:32 *** bitdex_ has quit IRC
2492020-08-13T14:18:16 *** mrostecki has quit IRC
2502020-08-13T14:23:25 *** EagleTM has joined #bitcoin-core-dev
2512020-08-13T14:26:20 *** bitcoin-git has joined #bitcoin-core-dev
2522020-08-13T14:26:21 <bitcoin-git> [bitcoin] hebasto opened pull request #19710: bench: Prevent thread oversubscription and decreases the variance of result values (master...200813-var) https://github.com/bitcoin/bitcoin/pull/19710
2532020-08-13T14:26:22 *** bitcoin-git has left #bitcoin-core-dev
2542020-08-13T14:27:36 *** bitcoin-git has joined #bitcoin-core-dev
2552020-08-13T14:27:36 <bitcoin-git> [bitcoin] jnewbery closed pull request #18876: [WIP] Serve BIP 157 compact filters (master...pr16442.3) https://github.com/bitcoin/bitcoin/pull/18876
2562020-08-13T14:27:47 *** bitcoin-git has left #bitcoin-core-dev
2572020-08-13T14:32:37 *** arowser_ has quit IRC
2582020-08-13T14:33:39 *** Davterra has quit IRC
2592020-08-13T14:33:57 *** arowser_ has joined #bitcoin-core-dev
2602020-08-13T14:38:00 *** bizmindx has joined #bitcoin-core-dev
2612020-08-13T14:53:29 *** nickbtc63 has joined #bitcoin-core-dev
2622020-08-13T14:57:37 *** nickbtc63 has quit IRC
2632020-08-13T14:59:26 *** arowser_ has quit IRC
2642020-08-13T14:59:45 *** arowser_ has joined #bitcoin-core-dev
2652020-08-13T15:00:02 *** tadeo has quit IRC
2662020-08-13T15:00:34 *** bizmindx has quit IRC
2672020-08-13T15:01:12 *** platesondeck has joined #bitcoin-core-dev
2682020-08-13T15:04:51 *** platesondeck has quit IRC
2692020-08-13T15:05:00 *** palazzovincenzo has joined #bitcoin-core-dev
2702020-08-13T15:07:23 *** vincenzopalazzo has quit IRC
2712020-08-13T15:09:09 *** proofofkeags has quit IRC
2722020-08-13T15:16:46 *** dviola has quit IRC
2732020-08-13T15:17:34 *** dviola has joined #bitcoin-core-dev
2742020-08-13T15:17:47 *** proofofkeags has joined #bitcoin-core-dev
2752020-08-13T15:18:38 *** waldoirc_ has joined #bitcoin-core-dev
2762020-08-13T15:19:01 *** waldoirc_ has joined #bitcoin-core-dev
2772020-08-13T15:19:29 *** waldoirc_ has joined #bitcoin-core-dev
2782020-08-13T15:19:55 *** waldoirc_ has joined #bitcoin-core-dev
2792020-08-13T15:20:22 *** waldoirc_ has joined #bitcoin-core-dev
2802020-08-13T15:21:45 *** waldoirc has quit IRC
2812020-08-13T15:22:24 *** pav5088 has joined #bitcoin-core-dev
2822020-08-13T15:22:48 <fjahr> #19528 seems RFM
2832020-08-13T15:22:50 <gribble> https://github.com/bitcoin/bitcoin/issues/19528 | rpc: Assert that RPCArg names are equal to CRPCCommand ones (misc) by MarcoFalke · Pull Request #19528 · bitcoin/bitcoin · GitHub
2842020-08-13T15:27:02 *** proofofkeags has quit IRC
2852020-08-13T15:59:55 *** Pavlenex has quit IRC
2862020-08-13T16:04:27 *** Pavlenex has joined #bitcoin-core-dev
2872020-08-13T16:12:24 *** arowser_ has quit IRC
2882020-08-13T16:12:52 *** arowser_ has joined #bitcoin-core-dev
2892020-08-13T16:16:32 *** Davterra has joined #bitcoin-core-dev
2902020-08-13T16:19:33 *** bitcoin-git has joined #bitcoin-core-dev
2912020-08-13T16:19:34 <bitcoin-git> [bitcoin] hebasto closed pull request #19064: refactor: Cleanup thread ctor calls (master...200524-bind) https://github.com/bitcoin/bitcoin/pull/19064
2922020-08-13T16:19:35 *** bitcoin-git has left #bitcoin-core-dev
2932020-08-13T16:19:54 *** bitcoin-git has joined #bitcoin-core-dev
2942020-08-13T16:19:54 <bitcoin-git> [bitcoin] hebasto reopened pull request #19064: refactor: Cleanup thread ctor calls (master...200524-bind) https://github.com/bitcoin/bitcoin/pull/19064
2952020-08-13T16:19:55 *** bitcoin-git has left #bitcoin-core-dev
2962020-08-13T16:22:58 *** alko89 has quit IRC
2972020-08-13T16:24:39 <fjahr> re loading all GH comments: I remember having that discussion here as well back then (probably when fanquake made the comment). There is a browser extension that offers that functionality and it worked well but seemed stupid to keep it just for that and some of the other functionality is annoying: https://github.com/sindresorhus/refined-github
2982020-08-13T16:24:45 <fjahr> If you are really desperate you may paste this into your js console: https://gist.github.com/fjahr/bfaf119dddae37c490a4949e956b3b7a It works for me.
2992020-08-13T16:26:23 <achow101> there's no way to turn off the annoying features?
3002020-08-13T16:27:40 <luke-jr> I wonder if there's a non-browser GH open source app
3012020-08-13T16:27:52 <fjahr> achow101: i didn't look into it that deeply but maybe (https://github.com/sindresorhus/refined-github#customization). I just try to keep my use of extensions at a minimum.
3022020-08-13T16:28:01 <luke-jr> maybe it could even work with GitLab too so someday we can get off GitHub :P
3032020-08-13T16:28:51 <achow101> luke-jr: there's a github android app now. I don't know if it's open source
3042020-08-13T16:29:47 <luke-jr> I mean Qt or such
3052020-08-13T16:29:47 <achow101> fjahr: seems like you can turn on and off features
3062020-08-13T16:30:39 <achow101> luke-jr: they have an open source desktop app for windows and mac
3072020-08-13T16:30:52 <achow101> electron based though, so bleh
3082020-08-13T16:31:05 <fjahr> achow101: yeah, I don't remember seeing that, so maybe worth another try
3092020-08-13T16:34:09 *** proofofkeags has joined #bitcoin-core-dev
3102020-08-13T16:35:12 *** proofofkeags has quit IRC
3112020-08-13T16:36:43 <luke-jr> achow101: that's just a browser wrapper afaik
3122020-08-13T16:39:25 *** sipsorcery has quit IRC
3132020-08-13T16:42:19 *** alko89 has joined #bitcoin-core-dev
3142020-08-13T16:43:39 *** PaulTroo_ has quit IRC
3152020-08-13T16:44:16 *** sipsorcery has joined #bitcoin-core-dev
3162020-08-13T16:46:42 *** shesek has joined #bitcoin-core-dev
3172020-08-13T16:46:42 *** shesek has quit IRC
3182020-08-13T16:46:42 *** shesek has joined #bitcoin-core-dev
3192020-08-13T16:53:08 *** mr_burdell_ has joined #bitcoin-core-dev
3202020-08-13T16:53:15 *** PaulTroo_ has joined #bitcoin-core-dev
3212020-08-13T16:53:17 *** mr_burdell has quit IRC
3222020-08-13T17:11:42 *** justanotheruser has quit IRC
3232020-08-13T17:26:35 *** Talkless has quit IRC
3242020-08-13T17:27:30 *** Talkless has joined #bitcoin-core-dev
3252020-08-13T17:28:06 *** justanotheruser has joined #bitcoin-core-dev
3262020-08-13T17:50:18 *** Highway62 has joined #bitcoin-core-dev
3272020-08-13T17:50:40 *** Highway61 has quit IRC
3282020-08-13T17:50:40 *** Highway62 is now known as Highway61
3292020-08-13T17:52:06 *** bitcoin-git has joined #bitcoin-core-dev
3302020-08-13T17:52:07 <bitcoin-git> [bitcoin] Crypt-iQ opened pull request #19713: fuzz: fix -fsanitize=integer complaints (master...fuzz_supp_0813) https://github.com/bitcoin/bitcoin/pull/19713
3312020-08-13T17:52:08 *** bitcoin-git has left #bitcoin-core-dev
3322020-08-13T17:52:22 <jeremyrubin> btw interesting article for the rust folks https://people.gnome.org/~federico/blog/rust-stable-abi.html
3332020-08-13T17:53:18 <jeremyrubin> elichai2: luke-jr michaelfolkson
3342020-08-13T17:55:16 *** lightlike has joined #bitcoin-core-dev
3352020-08-13T18:00:02 *** pav5088 has quit IRC
3362020-08-13T18:05:11 *** mdunnio has quit IRC
3372020-08-13T18:08:12 <luke-jr> jeremyrubin: tl;dr: no solutions
3382020-08-13T18:08:54 *** mol_ has joined #bitcoin-core-dev
3392020-08-13T18:11:56 *** mol has quit IRC
3402020-08-13T18:14:38 *** dviola has left #bitcoin-core-dev
3412020-08-13T18:15:01 *** dviola has joined #bitcoin-core-dev
3422020-08-13T18:17:16 *** mdunnio has joined #bitcoin-core-dev
3432020-08-13T18:21:23 *** [RuCTFE]tswr has joined #bitcoin-core-dev
3442020-08-13T18:47:47 <michaelfolkson> tl;dr Rust does not have a stable ABI
3452020-08-13T18:49:12 <michaelfolkson> .. but we can override this
3462020-08-13T18:49:18 <luke-jr> frankly it'd probably be good enough if they simply limit ABI breakage to minor (major?) version bumps
3472020-08-13T18:49:27 <luke-jr> so you could dynamic link stuff so long as you kept the same compiler
3482020-08-13T18:49:41 <luke-jr> michaelfolkson: having to annotate every interface in code isn't a solution
3492020-08-13T18:50:09 <luke-jr> especially when it's losing features (eg, Rust's decision to sort fields a certain optimal way)
3502020-08-13T18:51:31 <luke-jr> the template/generic point does seem fundamentally unsolvable, though
3512020-08-13T18:53:30 <luke-jr> a real world point on the topic: it's frustrating when Chromium releases new security fixes, and I have to forego having a browser for 48 hours while the entire thing recompiles.. if it was using proper shared libraries, I could just rebuild the affected one(s) and go.
3522020-08-13T18:54:03 <luke-jr> (Chromium isn't Rust, but this is a static compiling/linking issue, not a Rust issue specifically)
3532020-08-13T18:57:16 *** chjj has quit IRC
3542020-08-13T18:58:37 *** chjj has joined #bitcoin-core-dev
3552020-08-13T19:00:07 <wumpus> #startmeeting
3562020-08-13T19:00:07 <lightningbot> Meeting started Thu Aug 13 19:00:07 2020 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
3572020-08-13T19:00:07 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3582020-08-13T19:00:11 <jnewbery> hi
3592020-08-13T19:00:18 <jonasschnelli> Hi
3602020-08-13T19:00:19 <troygiorshev> hi
3612020-08-13T19:00:20 <hebasto> hi
3622020-08-13T19:00:36 <luke-jr> hi
3632020-08-13T19:00:42 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
3642020-08-13T19:00:44 <wumpus> amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2
3652020-08-13T19:00:51 <sipsorcery> hi
3662020-08-13T19:00:55 <achow101> hi
3672020-08-13T19:00:59 <jamesob> hi
3682020-08-13T19:01:06 <aj> hi
3692020-08-13T19:01:09 <fjahr> hi
3702020-08-13T19:01:11 <wumpus> one proposed topic in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt: Can we recreate bitcoin-core/gui (Luke-jr)
3712020-08-13T19:01:19 <wumpus> any last minute topic proposals?
3722020-08-13T19:01:33 <jeremyrubin> hi
3732020-08-13T19:01:37 <ajonas> hi
3742020-08-13T19:01:43 <sipa> hi
3752020-08-13T19:02:15 <wumpus> #topic High priority for review
3762020-08-13T19:02:31 <wumpus> https://github.com/bitcoin/bitcoin/projects/8 10 blockers, 1 bugfix, 3 chasing conept
3772020-08-13T19:02:44 <jonatack> hi
3782020-08-13T19:02:55 <wumpus> anything to add/remove or that is probably ready for merge?
3792020-08-13T19:03:03 <luke-jr> â¦
3802020-08-13T19:03:27 <jonatack> i'd like to nominate #19628 for blockers
3812020-08-13T19:03:29 <gribble> https://github.com/bitcoin/bitcoin/issues/19628 | net: change CNetAddr::ip to have flexible size by vasild · Pull Request #19628 · bitcoin/bitcoin · GitHub
3822020-08-13T19:03:32 <wumpus> luke-jr: ?
3832020-08-13T19:04:08 *** luke-jr has quit IRC
3842020-08-13T19:04:29 *** luke-jr has joined #bitcoin-core-dev
3852020-08-13T19:04:36 <wumpus> jonatack: added
3862020-08-13T19:05:28 <jnewbery> #11082 is the only one that needs rebase. There was discussion last week about whether it was even needed anymore now that we have the settings file
3872020-08-13T19:05:30 <gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
3882020-08-13T19:06:05 <wumpus> let's remove it for now
3892020-08-13T19:06:57 *** Pavlenex has quit IRC
3902020-08-13T19:07:04 <wumpus> I see the other ones were rebased, great
3912020-08-13T19:08:09 <wumpus> ok, that concludes the topic if no one else has suggestions
3922020-08-13T19:08:46 <wumpus> #topic Can we recreate bitcoin-core/gui (Luke-jr)
3932020-08-13T19:09:08 *** Highway62 has joined #bitcoin-core-dev
3942020-08-13T19:09:10 *** Highway61 has quit IRC
3952020-08-13T19:09:11 *** Highway62 is now known as Highway61
3962020-08-13T19:09:11 <luke-jr> sorry, my IRC flaked out (I saw nothing for 5 minutes)
3972020-08-13T19:09:12 <wumpus> I'd personally rather not, just now that all kinds of issues and PRs were moved there
3982020-08-13T19:09:49 <jeremyrubin> To be clear
3992020-08-13T19:09:53 <jeremyrubin> This is for a repo
4002020-08-13T19:09:56 <michaelfolkson> What was the motivation for wanting this? Sorry missing context
4012020-08-13T19:10:01 *** kristapsk has joined #bitcoin-core-dev
4022020-08-13T19:10:02 <jeremyrubin> not for the actual QT impl
4032020-08-13T19:10:22 *** luke-jr_ has joined #bitcoin-core-dev
4042020-08-13T19:10:24 <luke-jr_> Can we recreate bitcoin-core/gui so GitHub will let us do PRs from the same <user>/bitcoin forks instead of making a new remote for everyone?
4052020-08-13T19:10:24 <wumpus> he wants to inherit it from bitcoin/bitcoin I think instead of having it as completely disparate repo
4062020-08-13T19:10:29 <luke-jr_> Or Maybe our contacts at GitHub can just link it?
4072020-08-13T19:10:30 <wumpus> I'm not convinced
4082020-08-13T19:10:46 <luke-jr_> As things are, every dev needs to create a new fork to make PRs on it
4092020-08-13T19:11:08 <achow101> I'm not sure that's possible by ourselves
4102020-08-13T19:11:12 <wumpus> yes, that is true, though if they drift further apart in the future, that's what you'll need to do anyway
4112020-08-13T19:11:26 <achow101> we may need to ask github support to do that
4122020-08-13T19:11:27 <luke-jr_> achow101: we could delete, refork, and rename; but probably better if GitHub just links it
4132020-08-13T19:11:30 <hebasto> hope, that gui repo would be interested for just created designers community.
4142020-08-13T19:11:39 <jeremyrubin> michaelfolkson: I think it was to allow more focus on the gui work in the gui subrepo
4152020-08-13T19:11:48 <jnewbery> wumpus: if you push a branch to <developer>/bitcoin , then you can't open a PR against bitcoin-core/gui because they don't share a common fork in gitub
4162020-08-13T19:12:01 <wumpus> right now they're basically the same, but it's not clear that will always be the case, e.g. after process separation there might be repo separation as well
4172020-08-13T19:12:02 <jeremyrubin> oops I hit enter late XD
4182020-08-13T19:12:13 <jnewbery> if we delete bitcoin-core/gui and then recreate it as a fork of bitcoin/bitcoin, you'd be able to
4192020-08-13T19:12:27 <luke-jr_> I suppose if the thought is to remove core code from /gui, and remove GUI from the core codebase, then it makes sense to leave it alone..
4202020-08-13T19:12:31 <wumpus> then again if a lot of people feel like it would be easier if it's a bitcoin/bitcoin fork we could try asking github
4212020-08-13T19:12:37 <jonatack> I agree that it's annoying friction, and things seems quiet in GUI-land.
4222020-08-13T19:13:10 <luke-jr_> but I think we've been planning that for years, and progress is slow
4232020-08-13T19:13:16 <wumpus> deleting the repo right now sounds like a bad plan to me, just now that eerything was set up there
4242020-08-13T19:13:45 <wumpus> might as well move things back to the main repo and delete it and give up on the idea then
4252020-08-13T19:13:56 <luke-jr_> also, while it used to be possible to have multiple forks under the same org (so bitcoin-core/gui and bitcoin-core/foobar), GitHub seems to have removed that possibility too
4262020-08-13T19:14:07 <jnewbery> wumpus: I don't think so
4272020-08-13T19:14:42 <jnewbery> just because things aren't perfect the first time doesn't mean you should give up on the idea
4282020-08-13T19:14:44 <wumpus> luke-jr_: that seems another issue, would make it imopssible to move bitcoin itself there
4292020-08-13T19:14:53 <luke-jr_> wumpus: right, that's my concern with that
4302020-08-13T19:14:59 *** owowo has quit IRC
4312020-08-13T19:15:16 <wumpus> jnewbery: it's just that it's not clear that the idea will work at all, causing the people that spent lots of time movign issues around extra work by doing it again seems terrible
4322020-08-13T19:15:34 <michaelfolkson> It seems to me that the experiment has been very short. I will try to find out if there is genuine interest in contributing, reviewing on that Bitcoin Design Slack
4332020-08-13T19:15:35 <wumpus> fanquake is not here but I think he'd agree
4342020-08-13T19:15:44 <jeremyrubin> Maybe a magic friend at github can help us add a feature for this?
4352020-08-13T19:16:09 <aj> yeah, isn't at least asking someone at github to tweak the database worthwhile?
4362020-08-13T19:16:10 <hebasto> michaelfolkson: great!
4372020-08-13T19:16:18 <wumpus> also some GUI people have created issues there, would you have them make them again?
4382020-08-13T19:16:34 <wumpus> it just seems nasty to me, sorry
4392020-08-13T19:16:40 <jnewbery> aj: yes. I think moneyball and fanquake are the most likely to know someone at github
4402020-08-13T19:16:42 <luke-jr_> wumpus: I agree recreating is probably a bad approach, but IF we wanted to do it, better sooner than later
4412020-08-13T19:17:13 <michaelfolkson> The motivations for it were attracting more contributors/reviewers and reducing noise for those not interested in GUI. I think the rationale made sense and it hasn't been given enough time at this stage
4422020-08-13T19:17:17 <luke-jr_> probably the best approach would be to allow PRs across code "networks"
4432020-08-13T19:17:29 <luke-jr_> if GitHub could add that, it'd be nice
4442020-08-13T19:17:34 <wumpus> michaelfolkson: I agree
4452020-08-13T19:18:19 <jeremyrubin> Let's ask github if they can tweak it first before doing anything?
4462020-08-13T19:18:23 <wumpus> I don't actually want to give up the idea, just don't want to take drastic measures like that
4472020-08-13T19:18:26 <luke-jr> jeremyrubin: +1
4482020-08-13T19:18:27 <sipa> i certainly like it, it means i can mute the gui PR mails/notofications :)
4492020-08-13T19:18:36 <luke-jr> sipa: well, procmail can do that much :P
4502020-08-13T19:18:49 <wumpus> sipa: wait, you can't do that now?
4512020-08-13T19:19:08 <moneyball> let's see if fanquake will follow-up with github as he's had the most recent contact with them. if not, i am happy to
4522020-08-13T19:19:13 <wumpus> how does it make a difference for notifications?
4532020-08-13T19:19:25 <sipa> wumpus: i can do that since the gui repo is split up
4542020-08-13T19:19:27 <ajonas> michaelfolkson: there are designers interested in the slack group. I put them in touch with hebasto, but they are looking for other devs to connect with.
4552020-08-13T19:19:31 <wumpus> sipa: ohh right
4562020-08-13T19:19:32 <luke-jr> wumpus: sipa means not giving up the idea; it's the same whether the repos are linked or not AFAIK
4572020-08-13T19:19:40 <sipa> wumpus: sorry, i was talking about the split itself; not the recreatio
4582020-08-13T19:19:51 <wumpus> yes, makes sense then
4592020-08-13T19:19:56 *** luke-jr_ has quit IRC
4602020-08-13T19:20:05 <michaelfolkson> ajonas: We set up a separate Slack channel and have notifications set up from GitHub
4612020-08-13T19:20:06 <luke-jr> (still here)
4622020-08-13T19:20:44 <jeremyrubin> Are there other topics? moneyball's suggestion sounds like a concrete next step and revisit next week if no word back
4632020-08-13T19:20:54 <wumpus> I don't think there are any other topics
4642020-08-13T19:21:24 *** owowo has joined #bitcoin-core-dev
4652020-08-13T19:21:34 <wumpus> unless anyone has one now
4662020-08-13T19:21:46 <jnewbery> I have a quick proposed topic
4672020-08-13T19:22:01 <jnewbery> moving functions in net_processing into PeerLogicValidation
4682020-08-13T19:22:18 <jeremyrubin> is there a relevant PR?
4692020-08-13T19:22:31 <wumpus> #topic Moving functions from net_processing to PeerLogicValidation (jnewbery)
4702020-08-13T19:22:34 * luke-jr wishes C++ allowed for private methods to not be in the header
4712020-08-13T19:22:36 <jnewbery> currently, most of the logic and much of the state in net_processing is static functions and globals
4722020-08-13T19:22:44 <jeremyrubin> #19704
4732020-08-13T19:22:45 <gribble> https://github.com/bitcoin/bitcoin/issues/19704 | Net processing: move ProcessMessage() to PeerLogicValidation by jnewbery · Pull Request #19704 · bitcoin/bitcoin · GitHub
4742020-08-13T19:23:13 <jnewbery> on a recent PR of mine, several reviewers suggested making new state a member of PLV rather than a global
4752020-08-13T19:23:28 <jnewbery> doing so would involve moving almost all of net_processing into PLV
4762020-08-13T19:23:41 <jnewbery> is that a sensible thing to do, or do people have strong objections to that?
4772020-08-13T19:23:46 <aj> luke-jr: you can get most of the way by moving the private members into a friend class
4782020-08-13T19:23:52 <jamesob> doesn't sound worth the churn unless there are big benefits to fuzzing/testability
4792020-08-13T19:24:39 <wumpus> luke-jr: the usual way to do that is a private implementation class (pimpl) pattern
4802020-08-13T19:24:58 <luke-jr> yes, just feels ugly
4812020-08-13T19:25:07 <jnewbery> MarcoFalke sdaftuar and theuni were the reviewers who suggested this
4822020-08-13T19:25:54 <wumpus> luke-jr: maybe, but a lot of software e.g. qt does it everywhere
4832020-08-13T19:25:58 <luke-jr> to be clear, I don't object to doing this, just find C++ a bit annoying in this regard
4842020-08-13T19:26:59 <jnewbery> jamesob: I think removing globals and better encapsulation benefits testability, no?
4852020-08-13T19:27:01 <wumpus> I'm not sure really it's worth changing around just for code organization, there's nothing wrong with functinos
4862020-08-13T19:27:08 <wumpus> not everythign has to be an object or a method
4872020-08-13T19:27:52 <jamesob> jnewbery: yeah I agree if what we're talking about is replacing global state with something that's more tightly scoped, but if it's mostly a matter of functions vs. methods I think the difference is pretty negligible. but haven't looked at it in a while...
4882020-08-13T19:28:08 <wumpus> agree wrt global state
4892020-08-13T19:28:24 <jamesob> it'd be nice if people could motivate changes like these with large draft branches that demonstrate better testability
4902020-08-13T19:28:30 <jnewbery> I'm not so interested in opinions like "I'm not sure if it's worth it". More looking for "this is a bad idea and we do it this way because..."
4912020-08-13T19:28:41 <jnewbery> (if you're not sure it's worth it, just don't review it)
4922020-08-13T19:29:13 <wumpus> okay sorry...
4932020-08-13T19:29:35 <jeremyrubin> It sounds like these changes are requested by reviewers already of other work that is made better by it, right jnewbery
4942020-08-13T19:29:36 <wumpus> will not give my oopinion on this again
4952020-08-13T19:29:48 <jamesob> wumpus: that was probably mostly directed at me
4962020-08-13T19:29:52 <jnewbery> jeremyrubin: exactly
4972020-08-13T19:31:14 <cfields> jnewbery: I didn't look too deeply into it when I +1'd. I certainly didn't realize it'd be a big change.
4982020-08-13T19:32:09 <cfields> I figured it made sense logically to be there, but yeah, if it means moving everything in, that wouldn't make much sense.
4992020-08-13T19:32:14 <jeremyrubin> jnewbery: do you feel it's blocking for the other work?
5002020-08-13T19:32:31 <aj> "not worth it -> don't review" seems like a bad idea?
5012020-08-13T19:32:55 <jnewbery> it's not blocking. I can abandon it.
5022020-08-13T19:33:25 <jnewbery> It just seems like it's a better design and allows better testing
5032020-08-13T19:33:31 <aj> just seems like it'd result in only interested people review, lots of shallow acks, stuff gets merged without deep review
5042020-08-13T19:33:33 <michaelfolkson> I know video calls (especially when livestreamed, transcribed) aren't for everyone. But if anyone wants to chat Signet this is scheduled for next Wednesday: https://www.meetup.com/BitDevsLDN/events/272121581/
5052020-08-13T19:33:56 <luke-jr> aj: that already happens I think
5062020-08-13T19:34:24 <luke-jr> aj: though usually the result is more of "not enough reviews to get merged"
5072020-08-13T19:34:27 <aj> jnewbery: (agree it's a better design, not sure it's worth it, think doing tx relay overhaul and separating that chunk of code into a separate file might be a start)
5082020-08-13T19:34:36 *** Pedromvpg has joined #bitcoin-core-dev
5092020-08-13T19:35:32 <jonatack> jnewbery: i don't know how much work it entails, but sometimes seeing the actual code helps to resolve these questions, as well as looking at if it's a priority worth attempting to do so before writing the code
5102020-08-13T19:35:32 <jeremyrubin> jnewbery: I'd like to see how it interacts with turning the individual handlers into functions as well. I could see it being good or bad for that.
5112020-08-13T19:35:48 <jnewbery> aj: that seems tangentially related
5122020-08-13T19:37:07 <jnewbery> jonatack: 19704 is the first step
5132020-08-13T19:37:15 <jeremyrubin> jnewbery: it seems this would make it easier to do that right? Less argument passing all over
5142020-08-13T19:37:27 <jeremyrubin> But then those funcs would also have to methods on the class
5152020-08-13T19:37:40 <jeremyrubin> So maybe might make sense to encapsulate it in a separate class?
5162020-08-13T19:37:56 <jnewbery> yes, instead of every function in net_processing having 10 arguments for passing params and connman and banman and ....., they're methods
5172020-08-13T19:38:00 <cfields> jnewbery: as a concrete answer: it makes sense to me as part of an effort to encapsulate and enhance what an instance of plv can do by itself, primarily for testing.
5182020-08-13T19:38:26 <jnewbery> cfields: that's how I feel too, which is why I went ahead after you, Marco and Suhas suggested it
5192020-08-13T19:38:29 <cfields> but absent that greater effort, it doesn't do much good.
5202020-08-13T19:38:45 <jnewbery> The reason I raised it here was to poll if there was a good reason that it's the way it is now
5212020-08-13T19:38:54 <dongcarl> cfields: is there a particular test you have in mind that this would enable?
5222020-08-13T19:38:59 <jeremyrubin> I think it sounds like a general "we're slow to make changes, so this won't have impact because we won't do the follow up for a while"
5232020-08-13T19:39:11 <jeremyrubin> But at some point we need to make a step
5242020-08-13T19:39:24 <jeremyrubin> dongcarl: imagine writing individual unit tests for message handlers
5252020-08-13T19:39:39 <jnewbery> jeremyrubin: +1. We've got to do something eventually instead of always saying that things don't seem worth it
5262020-08-13T19:39:40 <cfields> dongcarl: I've always, for ex, wanted to be able to run instances of our net/net_processing against themselves.
5272020-08-13T19:40:06 <jamesob> I think in general for issues like these, someone should come up with a branch that implements (i) the necessary changes and (ii) the new tests that we'd like to be able to do. seeing the tests motivates the changes.
5282020-08-13T19:40:16 <cfields> (that was the primary goal with CConnman, which never fully worked out :( )
5292020-08-13T19:40:39 <jeremyrubin> I think there's a balance to that. If the work is huge like this, it sounds like setting jnewbery up for rebase hell
5302020-08-13T19:40:46 <jnewbery> jamesob: I'm not looking for motivation. I'm looking for anti-motivation, ie is there a strong reason not to do it
5312020-08-13T19:41:10 <jamesob> the strong motivation not to do it would be a continuation of death-by-a-thousand-small-refactorings going on in the repo
5322020-08-13T19:41:16 <aj> jnewbery: "we've got to do something" -- work on the things that are clearly worth it?
5332020-08-13T19:41:19 <jeremyrubin> jnewbery: I think you're inadvdertently asking people what color the shed should be :P
5342020-08-13T19:41:44 <jnewbery> aj: I think better encapsulated code is worth it
5352020-08-13T19:41:48 <cfields> jnewbery: I think this was actually the intention for PLV.
5362020-08-13T19:42:18 <jnewbery> cfields: ah. That makes sense. I haven't looked at the history.
5372020-08-13T19:42:52 <sipa> is the question if those fields should move into PLV at all, or if they that should happen now?
5382020-08-13T19:43:07 <jeremyrubin> BTW here's a concrete motivation: Makes it easier to do individual function handlers. Function handlers can be dispatched in O(1), we currently do O(N) string matches to process a message. Concrete motivation for this step in that direction.
5392020-08-13T19:43:13 <sipa> i think my answers are (1) yes (2) don't care
5402020-08-13T19:43:35 <jnewbery> The question is "Is there a good reason _not_ to move these functions and data into PLV?"
5412020-08-13T19:44:08 <jnewbery> If the answer is 'no', then I'll proceed. If the answer is 'yes', then I'll stop.
5422020-08-13T19:44:13 <jonatack> jnewbery: it doesn't look like a slog to review. more a question of priority and opportunity cost. review pings are piling up atm.
5432020-08-13T19:44:27 <jeremyrubin> I don't have any.
5442020-08-13T19:44:36 <jeremyrubin> (objections or reasons not to)
5452020-08-13T19:44:55 <jeremyrubin> I think jnewbery is only interested in technical objections.
5462020-08-13T19:45:07 <jeremyrubin> He has 4 strong reviewers who will spend time on it.
5472020-08-13T19:45:13 <jnewbery> jeremyrubin: I also like individual function handlers. Smaller chunks of code are easier to review/understand and hide less bugs.
5482020-08-13T19:45:22 <jnewbery> but that wasn't really my main motivation here
5492020-08-13T19:45:31 <jnewbery> (also easier to test)
5502020-08-13T19:45:36 <jeremyrubin> But it's a question of if anyone has any technical problems with this move, e.g., conflicting work
5512020-08-13T19:45:49 <cfields> jnewbery: only one I can think of is: it may reveal a tangled mess that takes more effort than expected to untangle. But you kinda have to work through it to determine that.
5522020-08-13T19:46:09 <jamesob> moving big swathes of code creates rebase burden for everyone
5532020-08-13T19:46:19 <jnewbery> cfields: working through a tangled mess is good work. I've done it before :)
5542020-08-13T19:46:50 <luke-jr> rebase burden will happen no matter what PRs do it
5552020-08-13T19:47:18 <luke-jr> helpful refactors may reduce it in the long run though
5562020-08-13T19:47:26 <jnewbery> better encapsulated code is good medicine: more rebase pain now, for much less rebase pain forever after it's done
5572020-08-13T19:47:33 <luke-jr> ^
5582020-08-13T19:48:12 <jnewbery> I didn't expect this topic to be so heated :)
5592020-08-13T19:48:28 <jeremyrubin> jnewbery: new around here are ya?
5602020-08-13T19:48:29 <jnewbery> It sounds like there aren't any fundamental objections
5612020-08-13T19:48:45 <sipa> i think it only looks that way because the people here aren't familiar with the concrete implications
5622020-08-13T19:48:54 <sipa> so we have to talk in generalities
5632020-08-13T19:49:08 <sipa> it's probably best left to discussion on the PR?
5642020-08-13T19:49:28 <jnewbery> sipa: yes. For specifics we can use the PR.
5652020-08-13T19:49:50 <jnewbery> just wanted to make sure there were no high-level reasons why we shouldn't even consider it
5662020-08-13T19:50:27 <jeremyrubin> Any other 'quick' topics :)
5672020-08-13T19:51:04 <jamesob> haha
5682020-08-13T19:51:55 <luke-jr> lol
5692020-08-13T19:53:03 <wumpus> #endmeeting
5702020-08-13T19:53:03 <lightningbot> Meeting ended Thu Aug 13 19:53:03 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
5712020-08-13T19:53:03 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-13-19.00.html
5722020-08-13T19:53:03 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-13-19.00.txt
5732020-08-13T19:53:03 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-13-19.00.log.html
5742020-08-13T19:53:32 <sipa> lunch?
5752020-08-13T19:53:41 <luke-jr> more like dinner
5762020-08-13T19:54:03 <dongcarl> tea time!
5772020-08-13T19:54:08 <jamesob> luke-jr: what, do you go to bed around 7pm?
5782020-08-13T19:54:34 <jonatack> jnewbery: in the absence of strong reasons against, the code looks ~ok to me
5792020-08-13T19:54:38 <sipa> dongcarl: havin a yasmine tea at this exact moment
5802020-08-13T19:54:40 <jonatack> jamesob: i do
5812020-08-13T19:54:40 <luke-jr> jamesob: I don't eat dinner in bed
5822020-08-13T19:54:54 <jnewbery> jonatack: thanks :)
5832020-08-13T19:54:56 <jamesob> I'm envious
5842020-08-13T19:55:30 <dongcarl> sipa: Out of red bull?
5852020-08-13T19:55:45 * dongcarl ducks
5862020-08-13T19:56:23 <sipa> dongcarl: nope.
5872020-08-13T19:59:18 *** gzhao408 has quit IRC
5882020-08-13T20:00:55 *** Guyver2_ has quit IRC
5892020-08-13T20:01:42 *** Talkless has quit IRC
5902020-08-13T20:09:56 *** sipsorcery has quit IRC
5912020-08-13T20:10:39 *** sipsorcery has joined #bitcoin-core-dev
5922020-08-13T20:12:13 *** Highway61 has quit IRC
5932020-08-13T20:17:51 *** watersnake1 has joined #bitcoin-core-dev
5942020-08-13T20:25:13 *** paracyst has quit IRC
5952020-08-13T20:26:08 *** paracyst has joined #bitcoin-core-dev
5962020-08-13T21:00:01 *** [RuCTFE]tswr has quit IRC
5972020-08-13T21:02:26 *** lightlike has quit IRC
5982020-08-13T21:14:42 *** EagleTM has quit IRC
5992020-08-13T21:21:49 *** SukhE1 has joined #bitcoin-core-dev
6002020-08-13T21:25:10 *** arowser_ has quit IRC
6012020-08-13T21:27:14 *** arowser_ has joined #bitcoin-core-dev
6022020-08-13T21:30:06 *** Chris_Stewart_5 has quit IRC
6032020-08-13T21:36:53 *** PaulTroo_ has quit IRC
6042020-08-13T21:58:40 *** bitcoin-git has joined #bitcoin-core-dev
6052020-08-13T21:58:40 <bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b4d0366b47dd...609ce2d0da49
6062020-08-13T21:58:40 <bitcoin-git> bitcoin/master f110b7c Sebastian Falbesoner: rpc: document returned error fields as optional if applicable
6072020-08-13T21:58:42 <bitcoin-git> bitcoin/master 609ce2d Samuel Dobson: Merge #19644: rpc: document returned error fields as optional if applicabl...
6082020-08-13T21:58:43 *** bitcoin-git has left #bitcoin-core-dev
6092020-08-13T21:59:00 *** bitcoin-git has joined #bitcoin-core-dev
6102020-08-13T21:59:00 <bitcoin-git> [bitcoin] meshcollider merged pull request #19644: rpc: document returned error fields as optional if applicable (master...20200802-rpc-document_errors_fields_as_optional) https://github.com/bitcoin/bitcoin/pull/19644
6112020-08-13T21:59:02 *** bitcoin-git has left #bitcoin-core-dev
6122020-08-13T22:05:16 *** norou has joined #bitcoin-core-dev
6132020-08-13T22:11:01 *** Chris_Stewart_5 has joined #bitcoin-core-dev
6142020-08-13T22:18:38 *** marcoagner has quit IRC
6152020-08-13T22:32:02 *** sipsorcery has quit IRC
6162020-08-13T22:39:56 *** sipsorcery has joined #bitcoin-core-dev
6172020-08-13T22:40:34 *** mdunnio has quit IRC
6182020-08-13T22:49:26 *** gzhao408 has joined #bitcoin-core-dev
6192020-08-13T22:55:45 *** vasild_ has joined #bitcoin-core-dev
6202020-08-13T22:59:03 *** vasild has quit IRC
6212020-08-13T22:59:04 *** vasild_ is now known as vasild
6222020-08-13T23:06:05 *** infernix has quit IRC
6232020-08-13T23:13:13 *** Highway61 has joined #bitcoin-core-dev
6242020-08-13T23:14:06 *** norou has quit IRC
6252020-08-13T23:14:24 *** sipsorcery has quit IRC
6262020-08-13T23:17:10 *** gzhao408 has quit IRC
6272020-08-13T23:17:51 *** sipsorcery has joined #bitcoin-core-dev
6282020-08-13T23:20:41 *** arowser_ has quit IRC
6292020-08-13T23:21:47 *** arowser_ has joined #bitcoin-core-dev
6302020-08-13T23:32:11 *** T3 has quit IRC
6312020-08-13T23:54:12 *** sipsorcery has quit IRC