12020-08-17T00:00:02 *** ndrst1 has quit IRC
22020-08-17T00:02:46 <achow101> luke-jr: it didn't?
32020-08-17T00:03:10 <achow101> I thought signrawtransaction* always signed stuff if it had the necessary info, however it was provided
42020-08-17T00:03:33 *** bitcoin-git has joined #bitcoin-core-dev
52020-08-17T00:03:33 <bitcoin-git> [bitcoin] theStack opened pull request #19739: refactor: remove c-string interfaces for DecodeBase58{Check} (master...20200811-util-remove-cstring-decodebase58) https://github.com/bitcoin/bitcoin/pull/19739
62020-08-17T00:03:34 *** bitcoin-git has left #bitcoin-core-dev
72020-08-17T00:05:36 *** dgenr8 has joined #bitcoin-core-dev
82020-08-17T00:06:07 *** PaulTroo_ has joined #bitcoin-core-dev
92020-08-17T00:07:13 *** bitcoin-git has joined #bitcoin-core-dev
102020-08-17T00:07:14 <bitcoin-git> [bitcoin] promag closed pull request #15204: gui: Add Open External Wallet action (master...2019-01-openexternalwallet) https://github.com/bitcoin/bitcoin/pull/15204
112020-08-17T00:07:15 *** bitcoin-git has left #bitcoin-core-dev
122020-08-17T00:10:57 *** dgenr8 has quit IRC
132020-08-17T00:11:28 *** PaulTroo_ has quit IRC
142020-08-17T00:12:07 <luke-jr> achow101: well, if I backport #17204, the test fails apparently because of this
152020-08-17T00:12:09 <gribble> https://github.com/bitcoin/bitcoin/issues/17204 | wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (sipa) by meshcollider · Pull Request #17204 · bitcoin/bitcoin · GitHub
162020-08-17T00:17:54 <achow101> luke-jr: interesting, I'll have a look
172020-08-17T00:20:45 *** Klox04 has joined #bitcoin-core-dev
182020-08-17T00:21:37 <achow101> luke-jr: my expectation is that 0.20 and earlier would attempt to sign non-wallet inputs and fail silently. Now what's happening is that it's attempting to sign but failing loudly
192020-08-17T00:22:18 *** binbasti has joined #bitcoin-core-dev
202020-08-17T00:22:42 *** mr_burdell_ has quit IRC
212020-08-17T00:23:45 *** dgenr8 has joined #bitcoin-core-dev
222020-08-17T00:28:43 *** mdunnio has joined #bitcoin-core-dev
232020-08-17T00:34:16 *** proofofkeags has joined #bitcoin-core-dev
242020-08-17T00:34:39 <achow101> erm got that backwards
252020-08-17T00:43:14 *** proofofkeags has quit IRC
262020-08-17T00:50:29 <luke-jr> achow101: master is succeeding..
272020-08-17T00:50:59 <achow101> this is looking more like a bug in 0.20 to me rather than a bug in master
282020-08-17T00:55:57 <achow101> luke-jr: the test passes on 0.19
292020-08-17T00:58:26 *** justanotheruser has quit IRC
302020-08-17T01:00:17 *** dgenr8 has quit IRC
312020-08-17T01:07:13 <luke-jr> XD
322020-08-17T01:08:02 <sipa> it was my expectectation too that that should work
332020-08-17T01:08:26 <sipa> if yiu agree to signing a tx, there is no reason why you wouldn't sign it for all inputs/keys that you can
342020-08-17T01:10:42 <luke-jr> achow101: did you bisect it already?
352020-08-17T01:12:35 *** dgenr8 has joined #bitcoin-core-dev
362020-08-17T01:13:29 <achow101> luke-jr: no, but I don't need to
372020-08-17T01:14:02 <achow101> I already know what introduced the bug
382020-08-17T01:14:13 <luke-jr> ?
392020-08-17T01:15:45 <achow101> #18115
402020-08-17T01:15:49 <gribble> https://github.com/bitcoin/bitcoin/issues/18115 | wallet: Pass in transactions and messages for signing instead of exporting the private keys by achow101 · Pull Request #18115 · bitcoin/bitcoin · GitHub
412020-08-17T01:16:22 *** justanotheruser has joined #bitcoin-core-dev
422020-08-17T01:17:00 *** troygiorshev has quit IRC
432020-08-17T01:17:15 <sipa> so, is there a simple backport we could use in 0.20.2 ?
442020-08-17T01:17:29 <achow101> pretty sure no
452020-08-17T01:17:50 <sipa> a less than simple one? that doesn't involve all of descriptor wallets...?
462020-08-17T01:18:25 <achow101> I don't think there's a commit we can directly backport
472020-08-17T01:18:33 <achow101> but it shouldn't be hard to write a fix
482020-08-17T01:18:38 <sipa> ok
492020-08-17T01:19:12 <sipa> i don't think this is all that worrisome, though it's good practice to fix discovered issues
502020-08-17T01:19:13 *** dgenr8 has quit IRC
512020-08-17T01:20:12 <luke-jr> especially while 0.20 is our latest
522020-08-17T01:20:41 <instagibbs> it's conceivable you'd want to not necessarily sign all inputs in a tx(payjoin is an example) but you'd want a specific api to exclude inputs
532020-08-17T01:20:56 <instagibbs> not important to discussion per se, just saying
542020-08-17T01:21:11 *** arowser has quit IRC
552020-08-17T01:21:19 <sipa> instagibbs: yes, agree, though that's a much more specialized situation
562020-08-17T01:21:27 <instagibbs> agreed!
572020-08-17T01:21:50 <luke-jr> probably just a PSBT use case though?
582020-08-17T01:21:59 *** arowser has joined #bitcoin-core-dev
592020-08-17T01:22:27 <instagibbs> anyways, not really something pertaining to this issue
602020-08-17T01:22:29 <luke-jr> achow101: if it's trivial to fix correctly, I'd like to include it in Knots 0.20.1 if possible
612020-08-17T01:28:31 *** proofofkeags has joined #bitcoin-core-dev
622020-08-17T01:28:41 *** mdunnio has quit IRC
632020-08-17T01:31:44 *** dgenr8 has joined #bitcoin-core-dev
642020-08-17T01:36:48 *** proofofkeags has quit IRC
652020-08-17T01:39:36 *** bitcoin-git has joined #bitcoin-core-dev
662020-08-17T01:39:37 <bitcoin-git> [bitcoin] achow101 opened pull request #19740: [0.20] wallet: Simplify and fix CWallet::SignTransaction (0.20...backport-17204-fix) https://github.com/bitcoin/bitcoin/pull/19740
672020-08-17T01:39:41 <achow101> luke-jr: ^ Turns out copy and paste from master works
682020-08-17T01:39:49 *** bitcoin-git has left #bitcoin-core-dev
692020-08-17T01:39:58 <luke-jr> XD
702020-08-17T01:41:50 <luke-jr> achow101: is it really safe to drop all the error checking there?
712020-08-17T01:43:23 <achow101> I think so. See #19568. The errors should already be coming from the called functions
722020-08-17T01:43:25 <gribble> https://github.com/bitcoin/bitcoin/issues/19568 | Wallet should not override signing errors by fjahr · Pull Request #19568 · bitcoin/bitcoin · GitHub
732020-08-17T01:44:02 *** gzhao408 has quit IRC
742020-08-17T01:45:28 <achow101> Don't think that has changed in master
752020-08-17T01:45:44 <luke-jr> oh, right, I remember that PR
762020-08-17T01:47:02 *** Eagle[TM] has joined #bitcoin-core-dev
772020-08-17T01:49:35 *** EagleTM has quit IRC
782020-08-17T01:53:11 *** arowser has quit IRC
792020-08-17T01:53:33 *** dgenr8 has quit IRC
802020-08-17T01:54:14 *** arowser has joined #bitcoin-core-dev
812020-08-17T02:04:52 *** mdunnio has joined #bitcoin-core-dev
822020-08-17T02:04:55 *** dgenr8 has joined #bitcoin-core-dev
832020-08-17T02:06:59 *** arowser has quit IRC
842020-08-17T02:08:05 *** arowser has joined #bitcoin-core-dev
852020-08-17T02:08:15 *** raddar has joined #bitcoin-core-dev
862020-08-17T02:09:45 *** mdunnio has quit IRC
872020-08-17T02:14:10 *** arowser has quit IRC
882020-08-17T02:17:50 *** arowser has joined #bitcoin-core-dev
892020-08-17T02:19:52 *** dgenr8 has quit IRC
902020-08-17T02:20:23 *** melande has quit IRC
912020-08-17T02:28:22 *** arowser has quit IRC
922020-08-17T02:29:49 *** raddar has quit IRC
932020-08-17T02:30:44 *** arowser has joined #bitcoin-core-dev
942020-08-17T02:31:39 *** dviola has left #bitcoin-core-dev
952020-08-17T02:32:14 *** dgenr8 has joined #bitcoin-core-dev
962020-08-17T02:33:45 *** Klox04 has quit IRC
972020-08-17T02:38:10 *** melande has joined #bitcoin-core-dev
982020-08-17T02:44:06 *** dgenr8 has quit IRC
992020-08-17T02:44:14 *** arowser has quit IRC
1002020-08-17T02:46:19 *** arowser has joined #bitcoin-core-dev
1012020-08-17T02:51:43 *** Davterra has joined #bitcoin-core-dev
1022020-08-17T02:55:53 *** dgenr8 has joined #bitcoin-core-dev
1032020-08-17T03:00:02 *** binbasti has quit IRC
1042020-08-17T03:00:25 *** dviola has joined #bitcoin-core-dev
1052020-08-17T03:07:43 *** dgenr8 has quit IRC
1062020-08-17T03:11:16 *** arowser has quit IRC
1072020-08-17T03:12:02 *** arowser has joined #bitcoin-core-dev
1082020-08-17T03:20:13 *** dgenr8 has joined #bitcoin-core-dev
1092020-08-17T03:22:08 *** ggainey has joined #bitcoin-core-dev
1102020-08-17T03:30:41 *** melande has quit IRC
1112020-08-17T03:35:21 *** melande has joined #bitcoin-core-dev
1122020-08-17T03:35:42 *** dgenr8 has quit IRC
1132020-08-17T03:48:17 *** dgenr8 has joined #bitcoin-core-dev
1142020-08-17T03:51:39 *** asoltys has quit IRC
1152020-08-17T03:54:57 *** dgenr8 has quit IRC
1162020-08-17T04:02:31 *** dviola has quit IRC
1172020-08-17T04:04:57 *** dviola has joined #bitcoin-core-dev
1182020-08-17T04:07:46 *** dgenr8 has joined #bitcoin-core-dev
1192020-08-17T04:12:42 *** proofofkeags has joined #bitcoin-core-dev
1202020-08-17T04:18:25 *** proofofkeags has quit IRC
1212020-08-17T04:19:40 *** bitcoin-git has joined #bitcoin-core-dev
1222020-08-17T04:19:41 <bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ffad34816722...c831e105c567
1232020-08-17T04:19:41 <bitcoin-git> bitcoin/master b82067b Karl-Johan Alm: wallet: try -avoidpartialspends mode and use its result if fees are below ...
1242020-08-17T04:19:42 <bitcoin-git> bitcoin/master 7f13dfb Karl-Johan Alm: test: test the implicit avoid partial spends functionality
1252020-08-17T04:19:43 <bitcoin-git> bitcoin/master c831e10 Samuel Dobson: Merge #14582: wallet: always do avoid partial spends if fees are within a ...
1262020-08-17T04:19:44 *** bitcoin-git has left #bitcoin-core-dev
1272020-08-17T04:21:30 *** bitcoin-git has joined #bitcoin-core-dev
1282020-08-17T04:21:30 <bitcoin-git> [bitcoin] meshcollider merged pull request #14582: wallet: always do avoid partial spends if fees are within a specified range (master...181026-try-avoidpartialspends) https://github.com/bitcoin/bitcoin/pull/14582
1292020-08-17T04:21:43 *** bitcoin-git has left #bitcoin-core-dev
1302020-08-17T04:21:58 *** melande has quit IRC
1312020-08-17T04:22:46 *** melande has joined #bitcoin-core-dev
1322020-08-17T04:29:42 *** dgenr8 has quit IRC
1332020-08-17T04:30:22 *** proofofkeags has joined #bitcoin-core-dev
1342020-08-17T04:34:44 *** proofofkeags has quit IRC
1352020-08-17T04:40:37 *** dviola has left #bitcoin-core-dev
1362020-08-17T04:40:57 *** dviola has joined #bitcoin-core-dev
1372020-08-17T04:42:03 *** dgenr8 has joined #bitcoin-core-dev
1382020-08-17T04:54:27 *** dgenr8 has quit IRC
1392020-08-17T05:02:36 *** melande has quit IRC
1402020-08-17T05:03:44 *** melande has joined #bitcoin-core-dev
1412020-08-17T05:07:10 *** dgenr8 has joined #bitcoin-core-dev
1422020-08-17T05:12:52 *** dgenr8 has quit IRC
1432020-08-17T05:25:06 *** dgenr8 has joined #bitcoin-core-dev
1442020-08-17T05:27:36 *** melande has quit IRC
1452020-08-17T05:27:56 *** manantial has joined #bitcoin-core-dev
1462020-08-17T05:28:45 *** melande has joined #bitcoin-core-dev
1472020-08-17T05:31:12 *** dgenr8 has quit IRC
1482020-08-17T05:40:51 *** manantial has quit IRC
1492020-08-17T05:42:45 *** jonatack has quit IRC
1502020-08-17T05:43:47 *** proofofkeags has joined #bitcoin-core-dev
1512020-08-17T05:43:47 *** dgenr8 has joined #bitcoin-core-dev
1522020-08-17T05:44:53 *** bitcoin-git has joined #bitcoin-core-dev
1532020-08-17T05:44:53 <bitcoin-git> [bitcoin] kallewoof opened pull request #19743: -maxapsfee follow-up (master...20200817-maxapsfee-followup) https://github.com/bitcoin/bitcoin/pull/19743
1542020-08-17T05:44:55 *** bitcoin-git has left #bitcoin-core-dev
1552020-08-17T05:48:05 *** proofofkeags has quit IRC
1562020-08-17T05:54:08 *** dgenr8 has quit IRC
1572020-08-17T05:55:27 *** ggainey has quit IRC
1582020-08-17T05:59:40 *** proofofkeags has joined #bitcoin-core-dev
1592020-08-17T06:00:22 *** PaulTroo_ has joined #bitcoin-core-dev
1602020-08-17T06:04:16 *** proofofkeags has quit IRC
1612020-08-17T06:07:02 *** dgenr8 has joined #bitcoin-core-dev
1622020-08-17T06:13:32 *** dgenr8 has quit IRC
1632020-08-17T06:22:23 *** jungnam has joined #bitcoin-core-dev
1642020-08-17T06:23:37 *** dviola has quit IRC
1652020-08-17T06:25:00 *** dviola has joined #bitcoin-core-dev
1662020-08-17T06:26:05 *** dgenr8 has joined #bitcoin-core-dev
1672020-08-17T06:37:16 *** jonatack has joined #bitcoin-core-dev
1682020-08-17T06:47:03 *** dgenr8 has quit IRC
1692020-08-17T06:53:10 *** Guyver2 has joined #bitcoin-core-dev
1702020-08-17T06:55:21 *** IPGlider has quit IRC
1712020-08-17T06:55:25 *** Livestradamus has quit IRC
1722020-08-17T06:59:48 *** dgenr8 has joined #bitcoin-core-dev
1732020-08-17T07:05:37 *** jonatack has quit IRC
1742020-08-17T07:06:52 *** dgenr8 has quit IRC
1752020-08-17T07:07:16 *** marcoagner has joined #bitcoin-core-dev
1762020-08-17T07:08:00 *** opsec_x12 has joined #bitcoin-core-dev
1772020-08-17T07:16:35 *** jonatack has joined #bitcoin-core-dev
1782020-08-17T07:19:45 *** dgenr8 has joined #bitcoin-core-dev
1792020-08-17T07:27:02 *** dgenr8 has quit IRC
1802020-08-17T07:30:54 *** TheHoliestRoger has quit IRC
1812020-08-17T07:31:59 *** TheHoliestRoger has joined #bitcoin-core-dev
1822020-08-17T07:36:53 *** mrostecki has joined #bitcoin-core-dev
1832020-08-17T07:39:37 *** dgenr8 has joined #bitcoin-core-dev
1842020-08-17T07:41:36 *** andreacab has joined #bitcoin-core-dev
1852020-08-17T07:44:43 *** mrostecki has quit IRC
1862020-08-17T07:45:37 *** justanotheruser has quit IRC
1872020-08-17T07:45:57 *** dgenr8 has quit IRC
1882020-08-17T07:46:04 *** andreacab has quit IRC
1892020-08-17T07:46:19 *** _flow_ has quit IRC
1902020-08-17T07:46:31 *** andreacab has joined #bitcoin-core-dev
1912020-08-17T07:47:29 *** andreaca_ has joined #bitcoin-core-dev
1922020-08-17T07:48:25 *** kljasdfvv has joined #bitcoin-core-dev
1932020-08-17T07:50:54 *** andreacab has quit IRC
1942020-08-17T07:51:26 *** Talkless has joined #bitcoin-core-dev
1952020-08-17T07:52:54 *** _flow_ has joined #bitcoin-core-dev
1962020-08-17T07:54:23 *** andreaca_ has quit IRC
1972020-08-17T07:54:56 *** andreacab has joined #bitcoin-core-dev
1982020-08-17T07:58:43 *** dgenr8 has joined #bitcoin-core-dev
1992020-08-17T08:13:23 *** andreacab has quit IRC
2002020-08-17T08:14:59 *** Pavlenex has joined #bitcoin-core-dev
2012020-08-17T08:24:04 *** dgenr8 has quit IRC
2022020-08-17T08:34:42 *** andreaca_ has joined #bitcoin-core-dev
2032020-08-17T08:35:57 *** dgenr8 has joined #bitcoin-core-dev
2042020-08-17T08:40:32 *** dgenr8 has quit IRC
2052020-08-17T08:53:08 *** dgenr8 has joined #bitcoin-core-dev
2062020-08-17T08:56:09 *** bitcoin-git has joined #bitcoin-core-dev
2072020-08-17T08:56:09 <bitcoin-git> [bitcoin] hebasto opened pull request #19745: build: Drop back compatibility code for 32-bit x86 Linux binaries (master...200817-i686) https://github.com/bitcoin/bitcoin/pull/19745
2082020-08-17T08:56:10 *** bitcoin-git has left #bitcoin-core-dev
2092020-08-17T09:00:01 *** jungnam has quit IRC
2102020-08-17T09:05:50 *** jonatack has quit IRC
2112020-08-17T09:09:23 *** dgenr8 has quit IRC
2122020-08-17T09:09:56 *** NicolasDorier has quit IRC
2132020-08-17T09:10:08 *** hebasto has quit IRC
2142020-08-17T09:10:21 *** endogenic has quit IRC
2152020-08-17T09:10:21 *** CodeShark___ has quit IRC
2162020-08-17T09:10:39 *** mmitech__ has quit IRC
2172020-08-17T09:10:58 *** digi_james has quit IRC
2182020-08-17T09:11:16 *** mariorz has quit IRC
2192020-08-17T09:12:53 *** fjahr has quit IRC
2202020-08-17T09:13:17 *** mrostecki has joined #bitcoin-core-dev
2212020-08-17T09:14:22 *** mrostecki has quit IRC
2222020-08-17T09:14:33 *** mrostecki has joined #bitcoin-core-dev
2232020-08-17T09:15:13 *** hebasto has joined #bitcoin-core-dev
2242020-08-17T09:15:16 *** NicolasDorier has joined #bitcoin-core-dev
2252020-08-17T09:17:22 *** fjahr has joined #bitcoin-core-dev
2262020-08-17T09:17:22 *** Tralfaz has joined #bitcoin-core-dev
2272020-08-17T09:17:50 *** digi_james has joined #bitcoin-core-dev
2282020-08-17T09:17:53 *** mmitech__ has joined #bitcoin-core-dev
2292020-08-17T09:18:09 *** Pavlenex has joined #bitcoin-core-dev
2302020-08-17T09:18:26 *** mariorz has joined #bitcoin-core-dev
2312020-08-17T09:19:55 *** Davterra has quit IRC
2322020-08-17T09:20:57 *** feb has joined #bitcoin-core-dev
2332020-08-17T09:21:42 *** dgenr8 has joined #bitcoin-core-dev
2342020-08-17T09:21:48 *** Davterra has joined #bitcoin-core-dev
2352020-08-17T09:22:14 *** endogenic has joined #bitcoin-core-dev
2362020-08-17T09:23:22 *** Pavlenex has quit IRC
2372020-08-17T09:23:46 *** CodeShark___ has joined #bitcoin-core-dev
2382020-08-17T09:24:29 *** Tralfaz has quit IRC
2392020-08-17T09:28:27 *** bitcoin-git has joined #bitcoin-core-dev
2402020-08-17T09:28:27 <bitcoin-git> [bitcoin] hebasto closed pull request #19745: build: Drop back compatibility code for 32-bit x86 Linux binaries (master...200817-i686) https://github.com/bitcoin/bitcoin/pull/19745
2412020-08-17T09:28:29 *** bitcoin-git has left #bitcoin-core-dev
2422020-08-17T09:29:46 *** dgenr8 has quit IRC
2432020-08-17T09:39:24 *** Tennis has joined #bitcoin-core-dev
2442020-08-17T09:39:31 *** jonatack has joined #bitcoin-core-dev
2452020-08-17T09:41:25 *** dgenr8 has joined #bitcoin-core-dev
2462020-08-17T09:42:00 *** andreacab has joined #bitcoin-core-dev
2472020-08-17T09:44:45 *** andreaca_ has quit IRC
2482020-08-17T09:44:59 *** AaronvanW has joined #bitcoin-core-dev
2492020-08-17T09:47:00 *** Guyver2_ has joined #bitcoin-core-dev
2502020-08-17T09:49:50 *** dgenr8 has quit IRC
2512020-08-17T09:50:02 *** Guyver2 has quit IRC
2522020-08-17T09:50:13 *** Highway61 has joined #bitcoin-core-dev
2532020-08-17T09:51:13 *** Pavlenex has joined #bitcoin-core-dev
2542020-08-17T09:54:48 *** Pavlenex has joined #bitcoin-core-dev
2552020-08-17T09:57:08 *** bitcoin-git has joined #bitcoin-core-dev
2562020-08-17T09:57:09 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19746: ci: Move valgrind fuzzer to cirrus (master...2008-ciValgrind) https://github.com/bitcoin/bitcoin/pull/19746
2572020-08-17T09:57:10 *** bitcoin-git has left #bitcoin-core-dev
2582020-08-17T10:01:30 *** dgenr8 has joined #bitcoin-core-dev
2592020-08-17T10:08:53 *** Livestradamus has joined #bitcoin-core-dev
2602020-08-17T10:12:22 *** Tralfaz has joined #bitcoin-core-dev
2612020-08-17T10:13:04 *** Pavlenex has joined #bitcoin-core-dev
2622020-08-17T10:13:36 *** dgenr8 has quit IRC
2632020-08-17T10:14:52 *** Davterra has quit IRC
2642020-08-17T10:16:44 *** Davterra has joined #bitcoin-core-dev
2652020-08-17T10:17:01 *** andreacab has quit IRC
2662020-08-17T10:17:25 *** mrostecki_ has joined #bitcoin-core-dev
2672020-08-17T10:17:26 *** Guyver2__ has joined #bitcoin-core-dev
2682020-08-17T10:17:54 *** mrostecki has quit IRC
2692020-08-17T10:17:54 *** andreacab has joined #bitcoin-core-dev
2702020-08-17T10:18:24 *** Norwood2Runte has joined #bitcoin-core-dev
2712020-08-17T10:19:50 *** Tralfaz has quit IRC
2722020-08-17T10:20:01 *** Guyver2_ has quit IRC
2732020-08-17T10:25:01 *** andreacab has quit IRC
2742020-08-17T10:25:33 *** dgenr8 has joined #bitcoin-core-dev
2752020-08-17T10:25:53 *** andreacab has joined #bitcoin-core-dev
2762020-08-17T10:29:36 *** andreacab has quit IRC
2772020-08-17T10:29:42 *** andreacab has joined #bitcoin-core-dev
2782020-08-17T10:31:11 *** jonatack has quit IRC
2792020-08-17T10:31:52 *** PaulTro__ has joined #bitcoin-core-dev
2802020-08-17T10:33:47 *** PaulTroo_ has quit IRC
2812020-08-17T10:34:07 *** andreacab has quit IRC
2822020-08-17T10:34:16 *** andreacab has joined #bitcoin-core-dev
2832020-08-17T10:34:17 *** dgenr8 has quit IRC
2842020-08-17T10:37:22 *** Tralfaz has joined #bitcoin-core-dev
2852020-08-17T10:40:06 *** Davterra has quit IRC
2862020-08-17T10:40:07 *** Pavlenex has quit IRC
2872020-08-17T10:41:27 *** Davterra has joined #bitcoin-core-dev
2882020-08-17T10:44:08 *** andreacab has quit IRC
2892020-08-17T10:44:37 *** Tralfaz has quit IRC
2902020-08-17T10:44:38 *** andreacab has joined #bitcoin-core-dev
2912020-08-17T10:46:33 *** dgenr8 has joined #bitcoin-core-dev
2922020-08-17T10:47:30 *** andreacab has quit IRC
2932020-08-17T10:47:38 *** andreacab has joined #bitcoin-core-dev
2942020-08-17T10:49:02 *** bitcoin-git has joined #bitcoin-core-dev
2952020-08-17T10:49:03 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c831e105c567...1bc8e8eae2dc
2962020-08-17T10:49:03 <bitcoin-git> bitcoin/master 7668db3 Marcin Jachymiak: Move only: Move CDiskTxPos to its own file
2972020-08-17T10:49:04 <bitcoin-git> bitcoin/master 1bc8e8e MarcoFalke: Merge #19734: Move CDiskTxPos to its own file
2982020-08-17T10:49:05 *** bitcoin-git has left #bitcoin-core-dev
2992020-08-17T10:49:22 *** bitcoin-git has joined #bitcoin-core-dev
3002020-08-17T10:49:23 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19734: Move CDiskTxPos to its own file (master...move-disktxpos) https://github.com/bitcoin/bitcoin/pull/19734
3012020-08-17T10:49:24 *** bitcoin-git has left #bitcoin-core-dev
3022020-08-17T10:51:28 *** dgenr8 has quit IRC
3032020-08-17T10:52:21 *** Highway61 has quit IRC
3042020-08-17T10:55:42 *** vasild_ has joined #bitcoin-core-dev
3052020-08-17T10:55:56 *** Highway61 has joined #bitcoin-core-dev
3062020-08-17T10:56:23 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3072020-08-17T10:58:43 *** vasild has quit IRC
3082020-08-17T10:58:45 *** vasild_ is now known as vasild
3092020-08-17T11:04:18 *** dgenr8 has joined #bitcoin-core-dev
3102020-08-17T11:04:40 *** Highway61 has quit IRC
3112020-08-17T11:16:44 *** andreacab has quit IRC
3122020-08-17T11:17:35 *** andreacab has joined #bitcoin-core-dev
3132020-08-17T11:18:52 *** dgenr8 has quit IRC
3142020-08-17T11:22:13 *** andreacab has quit IRC
3152020-08-17T11:22:42 *** bitcoin-git has joined #bitcoin-core-dev
3162020-08-17T11:22:42 <bitcoin-git> [bitcoin] S3RK closed pull request #19384: test: speed up functional tests (master...test_speed_up) https://github.com/bitcoin/bitcoin/pull/19384
3172020-08-17T11:22:43 *** bitcoin-git has left #bitcoin-core-dev
3182020-08-17T11:27:22 *** Tralfaz has joined #bitcoin-core-dev
3192020-08-17T11:30:10 *** Davterra has quit IRC
3202020-08-17T11:30:35 *** Pavlenex has joined #bitcoin-core-dev
3212020-08-17T11:31:42 *** dgenr8 has joined #bitcoin-core-dev
3222020-08-17T11:31:44 *** Davterra has joined #bitcoin-core-dev
3232020-08-17T11:33:44 *** Pavlenex has quit IRC
3242020-08-17T11:34:20 *** Tralfaz has quit IRC
3252020-08-17T11:34:45 *** Highway61 has joined #bitcoin-core-dev
3262020-08-17T11:38:51 *** dgenr8 has quit IRC
3272020-08-17T11:43:50 *** bitcoin-git has joined #bitcoin-core-dev
3282020-08-17T11:43:51 <bitcoin-git> [bitcoin] S3RK opened pull request #19747: wallet: restore condition for HD chain split upgrade (master...wallet_upgrade_fix) https://github.com/bitcoin/bitcoin/pull/19747
3292020-08-17T11:43:52 *** bitcoin-git has left #bitcoin-core-dev
3302020-08-17T11:47:09 *** troygiorshev has joined #bitcoin-core-dev
3312020-08-17T11:50:27 *** dgenr8 has joined #bitcoin-core-dev
3322020-08-17T11:53:49 *** jonatack has joined #bitcoin-core-dev
3332020-08-17T11:55:19 *** andreacab has joined #bitcoin-core-dev
3342020-08-17T11:58:48 *** Guyver2_ has joined #bitcoin-core-dev
3352020-08-17T11:58:58 *** Highway61 has quit IRC
3362020-08-17T12:00:01 *** feb has quit IRC
3372020-08-17T12:02:01 *** Guyver2__ has quit IRC
3382020-08-17T12:08:35 *** Norwood2Runte has quit IRC
3392020-08-17T12:10:48 *** dgenr8 has quit IRC
3402020-08-17T12:13:15 *** dviola has left #bitcoin-core-dev
3412020-08-17T12:13:36 *** dviola has joined #bitcoin-core-dev
3422020-08-17T12:17:12 *** andreacab has quit IRC
3432020-08-17T12:19:52 *** jeremyrubin has quit IRC
3442020-08-17T12:21:50 *** forcer1 has joined #bitcoin-core-dev
3452020-08-17T12:23:17 *** dgenr8 has joined #bitcoin-core-dev
3462020-08-17T12:25:10 *** Guyver2__ has joined #bitcoin-core-dev
3472020-08-17T12:25:26 *** andreacab has joined #bitcoin-core-dev
3482020-08-17T12:27:00 *** Guyver2_ has quit IRC
3492020-08-17T12:29:27 *** dgenr8 has quit IRC
3502020-08-17T12:31:02 *** andreacab has quit IRC
3512020-08-17T12:34:05 *** davec has quit IRC
3522020-08-17T12:37:21 *** Tralfaz has joined #bitcoin-core-dev
3532020-08-17T12:39:52 *** Davterra has quit IRC
3542020-08-17T12:42:13 *** dgenr8 has joined #bitcoin-core-dev
3552020-08-17T12:45:43 *** fox2p has quit IRC
3562020-08-17T12:46:23 *** Davterra has joined #bitcoin-core-dev
3572020-08-17T12:49:50 *** Tralfaz has quit IRC
3582020-08-17T12:52:32 *** dgenr8 has quit IRC
3592020-08-17T12:54:23 *** Guyver2__ has quit IRC
3602020-08-17T12:54:55 *** gzhao408 has joined #bitcoin-core-dev
3612020-08-17T12:59:29 *** owowo has quit IRC
3622020-08-17T13:00:00 *** owowo has joined #bitcoin-core-dev
3632020-08-17T13:02:43 *** Murch has quit IRC
3642020-08-17T13:05:02 *** dgenr8 has joined #bitcoin-core-dev
3652020-08-17T13:08:28 *** arowser has quit IRC
3662020-08-17T13:09:11 *** arowser has joined #bitcoin-core-dev
3672020-08-17T13:09:24 *** arowser has quit IRC
3682020-08-17T13:10:08 *** arowser has joined #bitcoin-core-dev
3692020-08-17T13:10:20 *** davec has joined #bitcoin-core-dev
3702020-08-17T13:12:16 *** dgenr8 has quit IRC
3712020-08-17T13:12:16 *** arowser has quit IRC
3722020-08-17T13:13:05 *** arowser has joined #bitcoin-core-dev
3732020-08-17T13:13:12 *** arowser has quit IRC
3742020-08-17T13:13:56 *** arowser has joined #bitcoin-core-dev
3752020-08-17T13:17:51 *** davec has quit IRC
3762020-08-17T13:25:06 *** dgenr8 has joined #bitcoin-core-dev
3772020-08-17T13:30:23 *** bitdex has quit IRC
3782020-08-17T13:31:02 *** dgenr8 has quit IRC
3792020-08-17T13:33:10 *** mrostecki_ has quit IRC
3802020-08-17T13:33:23 *** mrostecki has joined #bitcoin-core-dev
3812020-08-17T13:36:24 *** fearbeag has joined #bitcoin-core-dev
3822020-08-17T13:36:52 *** Tralfaz has joined #bitcoin-core-dev
3832020-08-17T13:39:21 *** andreacab has joined #bitcoin-core-dev
3842020-08-17T13:39:23 *** Davterra has quit IRC
3852020-08-17T13:43:34 *** dgenr8 has joined #bitcoin-core-dev
3862020-08-17T13:44:05 *** andreacab has quit IRC
3872020-08-17T13:45:40 *** proofofkeags has joined #bitcoin-core-dev
3882020-08-17T13:46:59 *** Davterra has joined #bitcoin-core-dev
3892020-08-17T13:49:05 *** Tralfaz has quit IRC
3902020-08-17T13:49:23 *** dgenr8 has quit IRC
3912020-08-17T13:52:36 *** watersnake1 has joined #bitcoin-core-dev
3922020-08-17T13:55:04 *** Guyver2 has joined #bitcoin-core-dev
3932020-08-17T13:55:22 *** watersnake1 has quit IRC
3942020-08-17T14:00:28 *** tryphe_ has joined #bitcoin-core-dev
3952020-08-17T14:00:44 *** mdunnio has joined #bitcoin-core-dev
3962020-08-17T14:00:59 *** davec has joined #bitcoin-core-dev
3972020-08-17T14:02:14 *** dgenr8 has joined #bitcoin-core-dev
3982020-08-17T14:03:25 *** tryphe has quit IRC
3992020-08-17T14:04:11 *** troygiorshev has quit IRC
4002020-08-17T14:05:02 *** watersnake1 has joined #bitcoin-core-dev
4012020-08-17T14:10:07 *** dgenr8 has quit IRC
4022020-08-17T14:13:32 *** mdunnio has quit IRC
4032020-08-17T14:13:47 *** mdunnio has joined #bitcoin-core-dev
4042020-08-17T14:15:21 *** Tralfaz has joined #bitcoin-core-dev
4052020-08-17T14:15:58 *** zndtoshi has joined #bitcoin-core-dev
4062020-08-17T14:16:14 *** troygiorshev has joined #bitcoin-core-dev
4072020-08-17T14:16:23 *** arowser has quit IRC
4082020-08-17T14:17:09 *** arowser has joined #bitcoin-core-dev
4092020-08-17T14:17:50 *** Davterra has quit IRC
4102020-08-17T14:19:02 *** rh0nj has quit IRC
4112020-08-17T14:19:56 *** troygior1hev has joined #bitcoin-core-dev
4122020-08-17T14:20:26 *** troygior1hev has quit IRC
4132020-08-17T14:20:47 *** troygior1hev has joined #bitcoin-core-dev
4142020-08-17T14:21:49 *** troygiorshev has quit IRC
4152020-08-17T14:21:55 *** troygior1hev has quit IRC
4162020-08-17T14:22:07 *** rh0nj has joined #bitcoin-core-dev
4172020-08-17T14:22:37 *** dgenr8 has joined #bitcoin-core-dev
4182020-08-17T14:43:09 *** satwo has joined #bitcoin-core-dev
4192020-08-17T14:45:57 *** dgenr8 has quit IRC
4202020-08-17T14:48:45 *** proofofkeags has quit IRC
4212020-08-17T14:52:17 *** jb55 has quit IRC
4222020-08-17T14:52:48 *** jb55 has joined #bitcoin-core-dev
4232020-08-17T14:52:55 *** andreacab has joined #bitcoin-core-dev
4242020-08-17T14:55:52 *** jb55 has quit IRC
4252020-08-17T14:56:04 *** zndtoshi has quit IRC
4262020-08-17T14:56:20 *** jb55 has joined #bitcoin-core-dev
4272020-08-17T14:57:38 *** andreacab has quit IRC
4282020-08-17T14:58:45 *** dgenr8 has joined #bitcoin-core-dev
4292020-08-17T15:00:02 *** forcer1 has quit IRC
4302020-08-17T15:04:07 *** dgenr8 has quit IRC
4312020-08-17T15:04:34 *** tryphe_ has quit IRC
4322020-08-17T15:05:22 *** tryphe_ has joined #bitcoin-core-dev
4332020-08-17T15:05:52 *** Pavlenex has joined #bitcoin-core-dev
4342020-08-17T15:17:49 *** dgenr8 has joined #bitcoin-core-dev
4352020-08-17T15:22:25 *** kpyke has joined #bitcoin-core-dev
4362020-08-17T15:26:00 *** Tralfaz has quit IRC
4372020-08-17T15:27:29 *** Tralfaz has joined #bitcoin-core-dev
4382020-08-17T15:31:01 *** andreacab has joined #bitcoin-core-dev
4392020-08-17T15:32:56 *** Davterra has joined #bitcoin-core-dev
4402020-08-17T15:32:57 *** dgenr8 has quit IRC
4412020-08-17T15:34:07 *** weedcoder has joined #bitcoin-core-dev
4422020-08-17T15:34:35 *** Tralfaz has quit IRC
4432020-08-17T15:35:05 *** weedcoder has quit IRC
4442020-08-17T15:35:13 *** weedcoder has joined #bitcoin-core-dev
4452020-08-17T15:35:33 *** andreacab has quit IRC
4462020-08-17T15:35:40 *** Tralfaz has joined #bitcoin-core-dev
4472020-08-17T15:35:59 *** weedcoder has quit IRC
4482020-08-17T15:38:45 *** mol has quit IRC
4492020-08-17T15:39:40 *** Davterra has quit IRC
4502020-08-17T15:43:06 *** weedcoder has joined #bitcoin-core-dev
4512020-08-17T15:45:36 *** dgenr8 has joined #bitcoin-core-dev
4522020-08-17T15:50:19 *** alko has quit IRC
4532020-08-17T15:51:27 *** bitcoin-git has joined #bitcoin-core-dev
4542020-08-17T15:51:28 <bitcoin-git> [bitcoin] theStack opened pull request #19750: refactor: remove unused c-string variant of atoi64() (master...20200817-util-remove-unused_cstr_atoi64) https://github.com/bitcoin/bitcoin/pull/19750
4552020-08-17T15:51:28 *** bitcoin-git has left #bitcoin-core-dev
4562020-08-17T15:51:53 *** dgenr8 has quit IRC
4572020-08-17T15:53:17 *** Davterra has joined #bitcoin-core-dev
4582020-08-17T15:55:06 *** Tralfaz has quit IRC
4592020-08-17T15:55:40 *** Tralfaz has joined #bitcoin-core-dev
4602020-08-17T15:56:42 *** satwo has quit IRC
4612020-08-17T16:00:15 *** Davterra has quit IRC
4622020-08-17T16:04:14 *** dgenr8 has joined #bitcoin-core-dev
4632020-08-17T16:07:35 *** proofofkeags has joined #bitcoin-core-dev
4642020-08-17T16:11:53 *** proofofkeags has quit IRC
4652020-08-17T16:12:04 *** gzhao408 has quit IRC
4662020-08-17T16:14:21 *** ghost1 has joined #bitcoin-core-dev
4672020-08-17T16:14:35 *** mol has joined #bitcoin-core-dev
4682020-08-17T16:16:20 *** roconnor has joined #bitcoin-core-dev
4692020-08-17T16:16:42 *** dgenr8 has quit IRC
4702020-08-17T16:20:26 *** jeremyrubin has joined #bitcoin-core-dev
4712020-08-17T16:23:20 *** proofofkeags has joined #bitcoin-core-dev
4722020-08-17T16:23:20 *** arowser has quit IRC
4732020-08-17T16:24:09 *** arowser has joined #bitcoin-core-dev
4742020-08-17T16:27:38 *** belcher has joined #bitcoin-core-dev
4752020-08-17T16:27:46 *** proofofkeags has quit IRC
4762020-08-17T16:29:06 *** dgenr8 has joined #bitcoin-core-dev
4772020-08-17T16:38:34 *** PaulTro__ has quit IRC
4782020-08-17T16:41:05 *** andreacab has joined #bitcoin-core-dev
4792020-08-17T16:41:28 *** dgenr8 has quit IRC
4802020-08-17T16:45:51 *** andreacab has quit IRC
4812020-08-17T16:54:14 *** dgenr8 has joined #bitcoin-core-dev
4822020-08-17T16:55:03 * luke-jr wonders if he needs to pivot PPC64 support to Knots-only :/
4832020-08-17T16:55:38 *** mrostecki has quit IRC
4842020-08-17T16:57:48 <sipa> why?
4852020-08-17T16:58:32 <luke-jr> sipa: nobody's reviewing it, and as it stands, I'm having to build Qt separately for Core and Knots since PPC64 requires upstream libpng :/
4862020-08-17T16:59:00 <luke-jr> (it needs rebase yet again, but it didn't get any activity after the last rebase either)
4872020-08-17T16:59:20 <sipa> who else here has power9 hardware?
4882020-08-17T16:59:35 <sipa> there are a few at least, afaik
4892020-08-17T17:00:05 <luke-jr> not sure
4902020-08-17T17:00:07 *** dgenr8 has quit IRC
4912020-08-17T17:00:22 <luke-jr> gmaxwell I think did, but isn't here these days :x
4922020-08-17T17:00:58 <sipa> bluematt, sdaftuar, ...
4932020-08-17T17:00:59 * luke-jr ponders if splitting up the libpng change would be more reviewable for now
4942020-08-17T17:01:14 <sipa> maybe midnight ?
4952020-08-17T17:02:18 *** adiabat has quit IRC
4962020-08-17T17:12:20 * luke-jr rebases it again for now
4972020-08-17T17:12:45 *** dgenr8 has joined #bitcoin-core-dev
4982020-08-17T17:13:56 *** thomasb06 has joined #bitcoin-core-dev
4992020-08-17T17:19:08 *** thomasb06 has quit IRC
5002020-08-17T17:21:27 *** pinheadmz has quit IRC
5012020-08-17T17:22:48 *** alko89 has quit IRC
5022020-08-17T17:22:54 *** zndtoshi has joined #bitcoin-core-dev
5032020-08-17T17:23:02 *** justanotheruser has joined #bitcoin-core-dev
5042020-08-17T17:23:22 *** andreacab has joined #bitcoin-core-dev
5052020-08-17T17:24:32 *** bitcoin-git has joined #bitcoin-core-dev
5062020-08-17T17:24:32 <bitcoin-git> [bitcoin] luke-jr opened pull request #19751: depends: Split libpng out of Qt (master...depends_libpng) https://github.com/bitcoin/bitcoin/pull/19751
5072020-08-17T17:24:33 *** bitcoin-git has left #bitcoin-core-dev
5082020-08-17T17:28:17 *** andreacab has quit IRC
5092020-08-17T17:32:20 *** Tennis has quit IRC
5102020-08-17T17:39:53 *** dongcarl has quit IRC
5112020-08-17T17:40:09 *** dongcarl has joined #bitcoin-core-dev
5122020-08-17T17:41:30 *** Tralfaz has quit IRC
5132020-08-17T17:45:52 <amiti> just want to highlight for anyone who might not have seen yet- as of #19316 "oneshots" have been renamed to "addr fetch" connections
5142020-08-17T17:45:56 <gribble> https://github.com/bitcoin/bitcoin/issues/19316 | [net] Cleanup logic around connection types by amitiuttarwar · Pull Request #19316 · bitcoin/bitcoin · GitHub
5152020-08-17T17:46:45 *** Tralfaz has joined #bitcoin-core-dev
5162020-08-17T17:48:50 *** Pavlenex has quit IRC
5172020-08-17T17:55:31 *** dongcarl has quit IRC
5182020-08-17T17:55:47 *** dongcarl has joined #bitcoin-core-dev
5192020-08-17T17:56:43 *** Tralfaz has quit IRC
5202020-08-17T17:59:22 *** Davterra has joined #bitcoin-core-dev
5212020-08-17T18:00:01 *** kpyke has quit IRC
5222020-08-17T18:10:56 *** dongcarl has quit IRC
5232020-08-17T18:11:12 *** dongcarl has joined #bitcoin-core-dev
5242020-08-17T18:13:30 *** mol_ has joined #bitcoin-core-dev
5252020-08-17T18:16:02 *** mol has quit IRC
5262020-08-17T18:19:31 *** bitcoin-git has joined #bitcoin-core-dev
5272020-08-17T18:19:31 <bitcoin-git> [bitcoin] slmtpz opened pull request #19752: test: Update wait_until usage in tests not to use the one from utils (master...master) https://github.com/bitcoin/bitcoin/pull/19752
5282020-08-17T18:19:33 *** bitcoin-git has left #bitcoin-core-dev
5292020-08-17T18:21:52 *** tflgen2 has joined #bitcoin-core-dev
5302020-08-17T18:26:24 *** dongcarl has quit IRC
5312020-08-17T18:26:39 *** dongcarl has joined #bitcoin-core-dev
5322020-08-17T18:26:45 *** adiabat has joined #bitcoin-core-dev
5332020-08-17T18:33:03 <achow101> Why are there both RemoveWallet and UnloadWallet? It seems like unloadwallet calls both, but the GUI only calls RemoveWallet?
5342020-08-17T18:33:20 <achow101> Can these be consolidated?
5352020-08-17T18:41:45 *** dongcarl has quit IRC
5362020-08-17T18:42:01 *** dongcarl has joined #bitcoin-core-dev
5372020-08-17T18:56:11 *** troygiorshev has joined #bitcoin-core-dev
5382020-08-17T18:58:39 *** alko89 has joined #bitcoin-core-dev
5392020-08-17T19:01:28 *** bitcoin-git has joined #bitcoin-core-dev
5402020-08-17T19:01:28 <bitcoin-git> [bitcoin] troygiorshev opened pull request #19753: p2p: fix recentRejects filling bug (master...2020-08-clean-tx-processing) https://github.com/bitcoin/bitcoin/pull/19753
5412020-08-17T19:01:29 *** bitcoin-git has left #bitcoin-core-dev
5422020-08-17T19:06:43 *** belcher has quit IRC
5432020-08-17T19:10:03 *** Dean_Guss has joined #bitcoin-core-dev
5442020-08-17T19:10:10 *** DeanWeen has quit IRC
5452020-08-17T19:27:03 *** PaulTroo_ has joined #bitcoin-core-dev
5462020-08-17T19:45:02 *** bitcoin-git has joined #bitcoin-core-dev
5472020-08-17T19:45:02 <bitcoin-git> [bitcoin] achow101 opened pull request #19754: wallet: Move UpdateWalletSetting to wallet module and use from GUI interface (master...load-on-start-gui) https://github.com/bitcoin/bitcoin/pull/19754
5482020-08-17T19:45:13 *** bitcoin-git has left #bitcoin-core-dev
5492020-08-17T20:07:54 *** nullptr| has quit IRC
5502020-08-17T20:07:56 *** Murch has joined #bitcoin-core-dev
5512020-08-17T20:08:38 *** Talkless has quit IRC
5522020-08-17T20:09:00 *** nullptr| has joined #bitcoin-core-dev
5532020-08-17T20:10:45 <ryanofsky> difference between gui and rpc unloading sequences is that gui sequence is nonblocking while rpc blocks, but that code is a mess
5542020-08-17T20:11:57 <ryanofsky> i started changes to clean it up https://github.com/ryanofsky/bitcoin/commits/pr/path.1, #19619 came out of that
5552020-08-17T20:12:01 <gribble> https://github.com/bitcoin/bitcoin/issues/19619 | Remove wallet.dat path handling from wallet.cpp, rpcwallet.cpp by ryanofsky · Pull Request #19619 · bitcoin/bitcoin · GitHub
5562020-08-17T20:13:57 *** Guyver2_ has joined #bitcoin-core-dev
5572020-08-17T20:15:04 *** Guyver2 has quit IRC
5582020-08-17T20:28:16 *** Guyver2_ has quit IRC
5592020-08-17T20:28:35 *** mrostecki has joined #bitcoin-core-dev
5602020-08-17T20:32:46 *** pinheadmz has joined #bitcoin-core-dev
5612020-08-17T20:35:16 *** owowo has quit IRC
5622020-08-17T20:39:48 *** owowo has joined #bitcoin-core-dev
5632020-08-17T21:00:02 *** tflgen2 has quit IRC
5642020-08-17T21:06:42 *** PaulTroo_ has quit IRC
5652020-08-17T21:07:11 *** Sample-dev has joined #bitcoin-core-dev
5662020-08-17T21:08:57 *** Sample-dev has quit IRC
5672020-08-17T21:09:39 *** dongcarl has quit IRC
5682020-08-17T21:09:54 *** dongcarl has joined #bitcoin-core-dev
5692020-08-17T21:22:25 *** hari has joined #bitcoin-core-dev
5702020-08-17T21:22:27 *** hari is now known as Guest25230
5712020-08-17T21:25:25 *** dongcarl has quit IRC
5722020-08-17T21:25:41 *** dongcarl has joined #bitcoin-core-dev
5732020-08-17T21:40:40 *** dongcarl has quit IRC
5742020-08-17T21:40:56 *** dongcarl has joined #bitcoin-core-dev
5752020-08-17T21:48:13 *** marcoagner has quit IRC
5762020-08-17T21:55:53 *** dongcarl has quit IRC
5772020-08-17T21:56:08 *** dongcarl has joined #bitcoin-core-dev
5782020-08-17T22:02:31 *** luke-jr has quit IRC
5792020-08-17T22:02:57 *** luke-jr has joined #bitcoin-core-dev
5802020-08-17T22:11:09 *** dongcarl has quit IRC
5812020-08-17T22:11:24 *** dongcarl has joined #bitcoin-core-dev
5822020-08-17T22:26:12 *** dongcarl has quit IRC
5832020-08-17T22:26:13 *** mdunnio has quit IRC
5842020-08-17T22:26:27 *** dongcarl has joined #bitcoin-core-dev
5852020-08-17T22:41:40 *** dongcarl has quit IRC
5862020-08-17T22:41:55 *** dongcarl has joined #bitcoin-core-dev
5872020-08-17T22:48:41 *** watersnake1 has quit IRC
5882020-08-17T22:55:46 *** vasild_ has joined #bitcoin-core-dev
5892020-08-17T22:57:01 *** dongcarl has quit IRC
5902020-08-17T22:57:17 *** dongcarl has joined #bitcoin-core-dev
5912020-08-17T22:58:43 *** vasild has quit IRC
5922020-08-17T22:58:44 *** vasild_ is now known as vasild
5932020-08-17T23:00:13 *** Eagle[TM] has quit IRC
5942020-08-17T23:12:27 *** dongcarl has quit IRC
5952020-08-17T23:12:42 *** dongcarl has joined #bitcoin-core-dev
5962020-08-17T23:16:37 *** weedcoder has quit IRC
5972020-08-17T23:19:01 *** nullptr_ has joined #bitcoin-core-dev
5982020-08-17T23:21:13 *** nullptr| has quit IRC
5992020-08-17T23:27:37 *** dongcarl has quit IRC
6002020-08-17T23:27:52 *** dongcarl has joined #bitcoin-core-dev
6012020-08-17T23:37:06 *** troygiorshev has quit IRC
6022020-08-17T23:41:21 *** Evel-Knievel has quit IRC
6032020-08-17T23:42:05 *** Evel-Knievel has joined #bitcoin-core-dev
6042020-08-17T23:42:45 *** dongcarl has quit IRC
6052020-08-17T23:43:00 *** dongcarl has joined #bitcoin-core-dev
6062020-08-17T23:51:00 <sipa> achow101: any idea how i can resolve this bdb error?
6072020-08-17T23:51:00 <sipa> BDB0552 Page 0: last_pgno is not correct: 272 != 287
6082020-08-17T23:51:01 <sipa> wallet.dat: BDB0090 DB_VERIFY_BAD: Database verification failed
6092020-08-17T23:51:07 <sipa> when starting bitcoind?
6102020-08-17T23:51:46 <achow101> Sounds like part of the database is missing
6112020-08-17T23:52:31 <sipa> all my wallet files have this
6122020-08-17T23:52:49 <sipa> if i stop loading one, the next one gives that error
6132020-08-17T23:54:33 <achow101> Huh.
6142020-08-17T23:55:07 <achow101> Same mismatching last_pgno or different numbers?
6152020-08-17T23:55:36 <sipa> i just ran db_dump | db_load on all of them
6162020-08-17T23:55:37 <sipa> now it works
6172020-08-17T23:56:33 <achow101> were these copied from another system?
6182020-08-17T23:56:36 <sipa> nope
6192020-08-17T23:56:42 <achow101> just randomly happened today?
6202020-08-17T23:56:53 <sipa> yes, they worked 3 days ago
6212020-08-17T23:56:59 <sipa> i may have recompiled in between
6222020-08-17T23:57:30 <sipa> i know this isn't a useful bug report, as i don't know what commit exactly i was using before
6232020-08-17T23:58:01 <sipa> it may also have been an unclean shutdown
6242020-08-17T23:58:03 *** dongcarl has quit IRC
6252020-08-17T23:58:18 *** dongcarl has joined #bitcoin-core-dev
6262020-08-17T23:58:46 <sipa> actually, pretty sure it was an unclean shutdown, i'm also getting "Rolling forward" messages now
6272020-08-17T23:58:56 <achow101> So that particular error is that the metadata says there are 287 pages, but the actual number of pages was 272
6282020-08-17T23:59:14 <achow101> if you had an unclean shutdown, then it seems reasonable that the metadata could have been updated but not the file itself
6292020-08-17T23:59:33 <achow101> *metadata meaning the metadata page of the file
6302020-08-17T23:59:41 *** justanotheruser has quit IRC
6312020-08-17T23:59:55 * sipa is scared of bdb...