12020-08-28T00:00:01  *** Perlboy has quit IRC
  22020-08-28T00:03:13  *** justanotheruser has quit IRC
  32020-08-28T00:05:41  *** melande has quit IRC
  42020-08-28T00:06:12  <fanquake> Yea it's rare that we'd backport something that isn't actually bugfix, especially to such an old/stable branch.
  52020-08-28T00:06:27  *** AaronvanW has quit IRC
  62020-08-28T00:06:55  *** melande has joined #bitcoin-core-dev
  72020-08-28T00:09:01  *** justanotheruser has joined #bitcoin-core-dev
  82020-08-28T00:11:44  *** sipa has joined #bitcoin-core-dev
  92020-08-28T00:17:09  *** arowser has quit IRC
 102020-08-28T00:17:53  *** arowser has joined #bitcoin-core-dev
 112020-08-28T00:22:36  *** zelazny has joined #bitcoin-core-dev
 122020-08-28T00:23:40  *** melande has quit IRC
 132020-08-28T00:24:53  *** melande has joined #bitcoin-core-dev
 142020-08-28T00:36:47  *** Highway61 has quit IRC
 152020-08-28T00:41:56  *** AaronvanW has joined #bitcoin-core-dev
 162020-08-28T00:47:23  *** AaronvanW has quit IRC
 172020-08-28T00:53:47  *** promag has quit IRC
 182020-08-28T00:57:12  *** bitcoin-git has joined #bitcoin-core-dev
 192020-08-28T00:57:13  <bitcoin-git> [bitcoin] fanquake closed pull request #19009: Print "verifychain" progress every 1 step if user verifies whole blockchain. (master...patch-3) https://github.com/bitcoin/bitcoin/pull/19009
 202020-08-28T00:57:14  *** bitcoin-git has left #bitcoin-core-dev
 212020-08-28T01:07:42  *** melande has quit IRC
 222020-08-28T01:08:53  *** melande has joined #bitcoin-core-dev
 232020-08-28T01:10:14  *** melande has quit IRC
 242020-08-28T01:14:57  *** melande has joined #bitcoin-core-dev
 252020-08-28T01:24:00  *** bitdex has joined #bitcoin-core-dev
 262020-08-28T01:29:23  *** AaronvanW has joined #bitcoin-core-dev
 272020-08-28T01:48:05  * kallewoof wakes up
 282020-08-28T01:49:12  <kallewoof> so, the mining stuff is a bit of a work in progress, but AJ is making a follow-up pull request on top of the current one, which has mining in it. the current miner I use on my end is this: https://github.com/kallewoof/bitcoin/tree/202008-signet-ajkey-scripts
 292020-08-28T01:51:02  <kallewoof> I'll look into making simple tests that check the current signet consensus stuff with what we have, if people are uncomfortable with the PR not having enoguh tests, but i personally think "worst thing that happens is that signet does not work" (everything else has tests, after all, and the signet code *is* touched then too) fwiw.
 302020-08-28T01:51:35  <kallewoof> wumpus sipa aj ^
 312020-08-28T01:58:36  <sipa> kallewoof: what PoW difficulty does (the default) signet have?
 322020-08-28T01:58:54  <kallewoof> sipa: very low, lower than main/testnet
 332020-08-28T01:58:54  <sipa> or maybe better, how low can you set it for a custom one
 342020-08-28T01:59:06  <kallewoof> it takes a few seconds on a cpu initially
 352020-08-28T01:59:17  <aj> kallewoof: poking at making it accept OP_TRUE as the block challenge with no witness commitment, so plain -generate works
 362020-08-28T01:59:54  <sipa> alternatively, if it can be made low enough, a block could be constructed entirely on the python side (the test framework probably has nearly everything already)
 372020-08-28T02:01:14  <kallewoof> we could also just pre-mine the block(s) in that case. if the coinbase etc. are all predefined we can set the nonce and such. shouldn't be needed tho as the difficulty is pretty low. (the original mining tests used the c++ miner though, so it may be slow actually..)
 382020-08-28T02:01:23  *** AaronvanW has quit IRC
 392020-08-28T02:01:56  <sipa> yeah, that's also a possibility
 402020-08-28T02:02:54  *** melande has quit IRC
 412020-08-28T02:02:59  <sipa> mining from the python side means you could easily extend it with some less trivial challenge script too (though that would mean adding the sighash logic there as well, which may make sense anyway)
 422020-08-28T02:03:50  *** melande has joined #bitcoin-core-dev
 432020-08-28T02:04:28  <kallewoof> yeah, i mean the signing code is not big; we could literally drop the generate script into the test framework and use it
 442020-08-28T02:05:17  <kallewoof> aj: that would mean the generate script can import those things without doing import path hacks too.. maybe the contrib/signet stuff should just call ../../test/functional/test_framework/(signet_)generate.py or something
 452020-08-28T02:18:22  <sipa> kallewoof: fwiw, the powLimit in the signet PR doesn't exactly match the difficulty as specified in BIP325 (the digits after 00002adc28 should be zeroes)
 462020-08-28T02:18:41  <kallewoof> *blinks*
 472020-08-28T02:18:45  <aj> kallewoof: https://github.com/ajtowns/bitcoin/commit/33b01c42be9e4635c9f590c65d6c2873b0b0f8be allows you to set `-signet_blockscript=51` and then just pretend you're on regtest (except for difficulty)
 482020-08-28T02:19:25  <kallewoof> aj: nice, thanks
 492020-08-28T02:20:12  <aj> kallewoof: another option (short of including generate.py) might be have the blockscript be "OP_SHA256 x OP_EQUAL" which would mean just adding a constant suffix to the witness commitment for each block
 502020-08-28T02:20:36  <sipa> exercising the sighash logic would be even nicer :)
 512020-08-28T02:20:41  * sipa hides
 522020-08-28T02:23:03  <kallewoof> sipa: are you saying that the compact 0x1e2adc28 expands to 00002adc28000[...] and not the one that is there now? I derived it the other way around, and just kept it as is. Having zeroes makes sense but would mean another reset.
 532020-08-28T02:23:49  <sipa> kallewoof: yes
 542020-08-28T02:24:14  <sipa> well it wouldn't invalidate any existing blocks (with high probability), but it is technically a signet softfork i guess
 552020-08-28T02:24:40  <kallewoof> ohh... actually, you're right it wouldn't. it would just make the limit drop a small amount
 562020-08-28T02:25:37  <sipa> i mean: the implementation doesn't match the spec right now (and though the probability is small, it's not unobservable; one in 299928 attempts)
 572020-08-28T02:25:40  *** melande has quit IRC
 582020-08-28T02:25:58  <sipa> one in 299928 *succesful* attempts
 592020-08-28T02:26:21  <aj> sipa: yeah, that needs generate.py or equivalent
 602020-08-28T02:26:53  *** melande has joined #bitcoin-core-dev
 612020-08-28T02:27:31  <kallewoof> aj: generate.py without the copy-pasted stuff is not large, though. maybe it should (permanently) reside in the test framework path
 622020-08-28T02:27:48  <kallewoof> but that means more for reviewers to review, so probably just try to hack something easy for now..
 632020-08-28T02:28:36  <aj> kallewoof: yeah, maybe; don't really want to add it in before cleaning it up more though
 642020-08-28T02:29:17  <kallewoof> aj: all right
 652020-08-28T02:30:12  <aj> sipa, kallewoof: changing the powLimit to 2adc280000000 doesn't seem to invalidate any existing blocks
 662020-08-28T02:30:25  <kallewoof> i just confirmed that it doesn't, too
 672020-08-28T02:30:44  <kallewoof> pushed squashie
 682020-08-28T02:54:14  <kallewoof> is there a point not squashing if you end up having to rebase on master due to a conflict? I can't see one personally, so gonna squash.
 692020-08-28T03:00:02  *** zelazny has quit IRC
 702020-08-28T03:08:34  <gwillen> kallewoof: if you squash + rebase in one operation it becomes slightly harder to tell whether the squash was just a squash or changed anything (when re-reviewing), but I don't know that it's a big deal
 712020-08-28T03:08:43  <gwillen> unless it's a large complex PR with a bunch of existing review
 722020-08-28T03:08:52  <gwillen> (and you can always use commandline git to check)
 732020-08-28T03:08:54  *** melande1 has joined #bitcoin-core-dev
 742020-08-28T03:09:04  <gwillen> (but it's a bit of a PITA)
 752020-08-28T03:09:42  *** melande has quit IRC
 762020-08-28T03:22:24  *** Vogone has joined #bitcoin-core-dev
 772020-08-28T03:23:41  *** melande1 has quit IRC
 782020-08-28T03:26:50  *** melande1 has joined #bitcoin-core-dev
 792020-08-28T03:44:45  <kallewoof> gwillen: i made squash commits, then ended up with a conflict against master and rebased. the entire PR is as such "detached" from whatever commit reviewers saw the last time, so i could've added stuff to the other commits without anyone noticing at that point.
 802020-08-28T03:45:59  <sipa> kallewoof: unless PRs are huge (i haven't reviewed your signet one on detail, but it doesn't look very large), i find that most of the work in a review is understanding the flow of changes and how things fot together
 812020-08-28T03:46:29  <kallewoof> yeah, i thought so, but i caused poor jonatack to have to restart his review several times cause i kept squashing changes.
 822020-08-28T03:46:31  <sipa> once that's done, i don't mind reviewing things from scratch again... it'll go a lot faster
 832020-08-28T03:46:37  *** roconnor has quit IRC
 842020-08-28T03:47:13  <sipa> and for the fact that you coukd introduce small bur dangerous changes that could be missed on re-review... well ideally that's what you have tests for
 852020-08-28T03:47:47  <kallewoof> *nod*
 862020-08-28T03:47:49  <sipa> they don't just help guarantee that functionality won't break, they also give reviewers confidence
 872020-08-28T03:48:40  <kallewoof> yeah, tests are important. i felt like i had them in the signet PR because i USED to have them, before I split it up to make review easier.
 882020-08-28T03:48:57  *** justanotheruser has quit IRC
 892020-08-28T03:49:10  *** arowser has quit IRC
 902020-08-28T03:49:53  *** arowser has joined #bitcoin-core-dev
 912020-08-28T03:51:31  <sipa> kallewoof: i think i've moved in that direction as well; for segwit, everything was tested by adding segwit support into the wallet and using that to test the consensus logic... which i think made the change much bigger than it needed to be
 922020-08-28T03:52:02  <gwillen> I don't know if this is something we could add to one of the workflow docs under doc/, but it's not too hard to ask git to check for you whether squashing changed anything
 932020-08-28T03:52:05  <sipa> for taproot there is zero wallet support, and signing isn't even implemented in the consensus pr... but there are tests in python that just reimplement it
 942020-08-28T03:52:18  <gwillen> it's a bit fiddly, but now that github allows checking out arbitrary commits, including ones that were rebased-away, it's more straightforward
 952020-08-28T03:52:59  <kallewoof> sipa: yeah, i noticed! it makes sense, but i was surprised when i was trying to use it in btcdeb/tap :)
 962020-08-28T03:53:35  <sipa> kallewoof: right, i see how that complicates things :)
 972020-08-28T03:53:39  <kallewoof> gwillen: i am actually confused why git(hub) doesn't have a way to just compare changes since last time. like, give me a diff of what i reviewed before and now
 982020-08-28T03:54:06  <kallewoof> gwillen: i hit that "submit review" button so github clearly knows exactly where i was the last time..
 992020-08-28T03:54:13  <gwillen> I know that gitlab makes this possible, I thought github had some way to do this
1002020-08-28T03:54:27  *** promag has joined #bitcoin-core-dev
1012020-08-28T03:54:41  <gwillen> but at least in gitlab, the only thing you can compare is "changes since last push", so if they rebase against changes to upstream, it's useless because the diff includes all the upstream changes too
1022020-08-28T03:56:50  <kallewoof> yeah... having a snapshot of the state when you last reviewed and comparing that to current form would be ideal
1032020-08-28T03:57:48  <sipa> i think there is just less effort done on making rebase-heavy workflows easy
1042020-08-28T03:58:41  <gwillen> at least when it says "so-and-so force-pushed from <id> to <id>", getting a direct diff on the command line is easy
1052020-08-28T03:58:55  <gwillen> just 'git fetch <id>' each of them, then 'git diff <id> <id>'
1062020-08-28T03:58:55  *** promag has quit IRC
1072020-08-28T03:59:15  *** AaronvanW has joined #bitcoin-core-dev
1082020-08-28T03:59:21  <aj> i think lots of rebases is something a few open source projects do, but most/paying customers tend not to?
1092020-08-28T03:59:21  <gwillen> (however if that includes a rebase against new upstream changes, that command won't be useful because it will include those, the right command for that is a little more subtle)
1102020-08-28T04:00:28  <luke-jr> sipa: when you're splitting up the Taproot PR, I do think it would make sense to do consensus and policy separately
1112020-08-28T04:00:52  *** melande1 has quit IRC
1122020-08-28T04:00:56  <gwillen> ahhh, I always forget this -- in the github UI when you see "so-and-so force-pushed", the words "force-pushed" are a link to the diff
1132020-08-28T04:01:04  <gwillen> they kind of hide it, but if you click there you can see the changes in the force push
1142020-08-28T04:01:57  <luke-jr> gwillen: the notification emails have links that I suspect are supposed to be that, but they never seem to work for me
1152020-08-28T04:02:03  *** melande1 has joined #bitcoin-core-dev
1162020-08-28T04:03:09  <aj> kallewoof, sipa: so currently signet/generate.py supports signing the blocktx via either constructing a psbt, or by calling signrawtransactionwithwallet directly. any reason to keep the latter or can/should i go psbt only, do you think?
1172020-08-28T04:03:56  <kallewoof> aj: i think psbt only is ok
1182020-08-28T04:04:41  *** melande1 has quit IRC
1192020-08-28T04:04:43  *** infernix has quit IRC
1202020-08-28T04:05:51  *** melande1 has joined #bitcoin-core-dev
1212020-08-28T04:12:50  <sipa> aj: i'd do psbt only
1222020-08-28T04:18:35  * aj deletes some more code
1232020-08-28T04:21:16  *** bitdex has quit IRC
1242020-08-28T04:21:41  *** bitdex has joined #bitcoin-core-dev
1252020-08-28T04:24:00  <kallewoof> https://github.com/bitcoin/bitcoin/pull/18267/commits/cbb6f9439df8593c3aa52b56698788cc73108831 now tests OP_TRUE mining, and also submitblock checks the first 10 blocks in the current signet chain and also tries the first of those on a non-compatible (different challenge) signet chain.
1262020-08-28T04:31:26  *** AaronvanW has quit IRC
1272020-08-28T04:32:38  *** ppisati has quit IRC
1282020-08-28T04:39:17  *** ppisati has joined #bitcoin-core-dev
1292020-08-28T05:16:35  *** baldur has quit IRC
1302020-08-28T05:17:11  *** baldur has joined #bitcoin-core-dev
1312020-08-28T05:17:42  *** melande1 has quit IRC
1322020-08-28T05:18:51  *** melande1 has joined #bitcoin-core-dev
1332020-08-28T05:26:43  *** melande1 has quit IRC
1342020-08-28T05:29:51  *** melande1 has joined #bitcoin-core-dev
1352020-08-28T05:31:44  *** justanotheruser has joined #bitcoin-core-dev
1362020-08-28T05:53:22  *** shesek has quit IRC
1372020-08-28T06:00:01  *** Vogone has quit IRC
1382020-08-28T06:14:38  *** sipsorcery has joined #bitcoin-core-dev
1392020-08-28T06:14:45  *** melande1 has quit IRC
1402020-08-28T06:15:50  *** melande1 has joined #bitcoin-core-dev
1412020-08-28T06:22:18  *** openstackstatus1 has joined #bitcoin-core-dev
1422020-08-28T06:24:19  *** bitcoin-git has joined #bitcoin-core-dev
1432020-08-28T06:24:19  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/28a9df7d76a6...89a6bb924571
1442020-08-28T06:24:20  <bitcoin-git> bitcoin/0.19 ed0223e Luke Dashjr: scheduler: Workaround negative nsecs bug in boost's wait_until
1452020-08-28T06:24:21  <bitcoin-git> bitcoin/0.19 89a6bb9 MarcoFalke: Merge #18284: [0.19] scheduler: Workaround negative nsecs bug in boost's w...
1462020-08-28T06:24:22  *** bitcoin-git has left #bitcoin-core-dev
1472020-08-28T06:24:39  *** bitcoin-git has joined #bitcoin-core-dev
1482020-08-28T06:24:39  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18284: [0.19] scheduler: Workaround negative nsecs bug in boost's wait_until (0.19...wrkarnd_boost_wait_until) https://github.com/bitcoin/bitcoin/pull/18284
1492020-08-28T06:24:40  *** bitcoin-git has left #bitcoin-core-dev
1502020-08-28T06:24:41  *** melande1 has quit IRC
1512020-08-28T06:25:51  *** melande1 has joined #bitcoin-core-dev
1522020-08-28T06:29:04  *** AaronvanW has joined #bitcoin-core-dev
1532020-08-28T06:33:19  *** bitcoin-git has joined #bitcoin-core-dev
1542020-08-28T06:33:19  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/15886b08aa5f...862fde88be70
1552020-08-28T06:33:19  <bitcoin-git> bitcoin/master cc26fab practicalswift: tests: Add fuzzing harness for CNode
1562020-08-28T06:33:20  <bitcoin-git> bitcoin/master 862fde8 MarcoFalke: Merge #19067: tests: Add fuzzing harness for CNode
1572020-08-28T06:33:21  *** bitcoin-git has left #bitcoin-core-dev
1582020-08-28T06:34:03  *** bitcoin-git has joined #bitcoin-core-dev
1592020-08-28T06:34:04  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19067: tests: Add fuzzing harness for CNode (master...fuzzers-2020-05-25) https://github.com/bitcoin/bitcoin/pull/19067
1602020-08-28T06:34:05  *** bitcoin-git has left #bitcoin-core-dev
1612020-08-28T06:36:57  *** jonatack has quit IRC
1622020-08-28T06:42:23  *** Talkless has joined #bitcoin-core-dev
1632020-08-28T06:51:02  *** watersnake1 has quit IRC
1642020-08-28T06:54:20  *** andreacab has joined #bitcoin-core-dev
1652020-08-28T07:00:12  *** arowser has quit IRC
1662020-08-28T07:00:19  *** sipsorcery has quit IRC
1672020-08-28T07:00:25  *** jonatack has joined #bitcoin-core-dev
1682020-08-28T07:00:54  *** arowser has joined #bitcoin-core-dev
1692020-08-28T07:01:25  *** AaronvanW has quit IRC
1702020-08-28T07:04:44  *** sipsorcery has joined #bitcoin-core-dev
1712020-08-28T07:06:20  *** infernix has joined #bitcoin-core-dev
1722020-08-28T07:09:01  *** EagleTM has joined #bitcoin-core-dev
1732020-08-28T07:09:22  *** bitcoin-git has joined #bitcoin-core-dev
1742020-08-28T07:09:24  <bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/89a6bb924571...aee9d2306ad1
1752020-08-28T07:09:24  <bitcoin-git> bitcoin/0.19 2ea826c Suhas Daftuar: Add txids with non-standard inputs to reject filter
1762020-08-28T07:09:25  <bitcoin-git> bitcoin/0.19 52c3bec Gregory Sanders: test addition of unknown segwit spends to txid reject filter
1772020-08-28T07:09:26  <bitcoin-git> bitcoin/0.19 aee9d23 Jonas Schnelli: Merge #19681: 0.19: Add txids with non-standard inputs to reject filter
1782020-08-28T07:09:28  *** bitcoin-git has left #bitcoin-core-dev
1792020-08-28T07:09:43  *** bitcoin-git has joined #bitcoin-core-dev
1802020-08-28T07:09:43  <bitcoin-git> [bitcoin] jonasschnelli merged pull request #19681: 0.19: Add txids with non-standard inputs to reject filter (0.19...2020-08-reject-unknown-wit-0.19) https://github.com/bitcoin/bitcoin/pull/19681
1812020-08-28T07:09:44  *** bitcoin-git has left #bitcoin-core-dev
1822020-08-28T07:22:40  *** marcoagner has joined #bitcoin-core-dev
1832020-08-28T07:25:25  *** Talkless has quit IRC
1842020-08-28T07:26:24  *** Pavlenex has joined #bitcoin-core-dev
1852020-08-28T07:34:51  *** sipa has quit IRC
1862020-08-28T07:35:07  *** andreacab has quit IRC
1872020-08-28T07:35:34  *** andreacab has joined #bitcoin-core-dev
1882020-08-28T07:35:46  *** eugene99 has joined #bitcoin-core-dev
1892020-08-28T07:36:24  *** andreaca_ has joined #bitcoin-core-dev
1902020-08-28T07:39:41  *** andreacab has quit IRC
1912020-08-28T07:42:38  *** andreaca_ has quit IRC
1922020-08-28T07:43:43  *** bitcoin-git has joined #bitcoin-core-dev
1932020-08-28T07:43:44  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #19629: refactor: Keep mempool interface in validation  (master...2007-nomem) https://github.com/bitcoin/bitcoin/pull/19629
1942020-08-28T07:43:44  *** bitcoin-git has left #bitcoin-core-dev
1952020-08-28T07:45:01  *** sipa has joined #bitcoin-core-dev
1962020-08-28T07:55:03  *** promag has joined #bitcoin-core-dev
1972020-08-28T07:55:27  <MarcoFalke> gwillen: Are you aware of git range-diff ? This helps re-reviewing a fixed up version of the changes, and it "hides" any rebases that happened in between.
1982020-08-28T07:59:31  <sipa> MarcoFalke: TIL
1992020-08-28T07:59:37  *** promag has quit IRC
2002020-08-28T08:01:33  <MarcoFalke> Well, it can also be used to review rebases and see what manual changes were needed to rebase.
2012020-08-28T08:02:33  <aj> oops, looking at rust-bitcoin and misread "macro_rules!" as "marco_rules!"
2022020-08-28T08:02:36  <MarcoFalke> Though, it doesn't work for large rewrites... In which case you are better of reviewing from scratch anyway
2032020-08-28T08:02:56  *** sipsorcery has quit IRC
2042020-08-28T08:03:03  <MarcoFalke> macro fake
2052020-08-28T08:04:49  <sipa> in c++ most uses of marcos have been replaced with templates, thankfully
2062020-08-28T08:17:00  *** sr_gi has joined #bitcoin-core-dev
2072020-08-28T08:20:08  *** sipsorcery has joined #bitcoin-core-dev
2082020-08-28T08:27:32  *** andreacab has joined #bitcoin-core-dev
2092020-08-28T08:27:58  <vasild> Has it been considered before importing an external library into bitcoin core as a git submodule?
2102020-08-28T08:30:00  <vasild> I am trying to add a stripped version of crypto++ - just the bits that do sha3-256, but it is all tied together by internal dependencies, so the process may end up importing e.g. 80% of the library source
2112020-08-28T08:36:09  *** arowser has quit IRC
2122020-08-28T08:36:27  *** openstackstatus1 has quit IRC
2132020-08-28T08:36:53  *** arowser has joined #bitcoin-core-dev
2142020-08-28T08:39:13  <MarcoFalke> Which dependency is tor using?
2152020-08-28T08:41:45  *** eugene99 has quit IRC
2162020-08-28T08:42:44  <vasild> let me see...
2172020-08-28T08:43:07  *** jeremyrubin has quit IRC
2182020-08-28T08:43:25  *** bitcoin-git has joined #bitcoin-core-dev
2192020-08-28T08:43:25  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19826: Pass mempool reference to chainstate constructor (master...2008-valMemRef) https://github.com/bitcoin/bitcoin/pull/19826
2202020-08-28T08:43:26  *** bitcoin-git has left #bitcoin-core-dev
2212020-08-28T08:44:53  *** eugene70 has joined #bitcoin-core-dev
2222020-08-28T08:44:54  <sipsorcery> vasild: it may not be of any use but this is the repo I used as a basis for a keccak hash https://github.com/ethereum/ethash/tree/master/src/libethash
2232020-08-28T08:45:33  <sipsorcery> I only ended up needing two classes and 4 headers and no external dependencies
2242020-08-28T08:45:53  *** IPGlider has joined #bitcoin-core-dev
2252020-08-28T08:46:52  *** Pavlenex has quit IRC
2262020-08-28T08:52:53  *** infernix has quit IRC
2272020-08-28T08:58:54  *** AaronvanW has joined #bitcoin-core-dev
2282020-08-28T08:58:55  <vasild> MarcoFalke: tor could use openssl as an external dependency or src/ext/keccak-tiny
2292020-08-28T08:59:19  <MarcoFalke> well, then copy src/ext/keccak-tiny for now ;)
2302020-08-28T09:00:22  <vasild> https://gitlab.torproject.org/legacy/trac/-/issues/17783
2312020-08-28T09:04:52  *** kexkey has quit IRC
2322020-08-28T09:07:17  *** jonatack has quit IRC
2332020-08-28T09:22:19  *** krazyj has joined #bitcoin-core-dev
2342020-08-28T09:22:54  *** infernix has joined #bitcoin-core-dev
2352020-08-28T09:25:00  *** andreacab has quit IRC
2362020-08-28T09:25:42  *** andreacab has joined #bitcoin-core-dev
2372020-08-28T09:29:56  *** andreacab has quit IRC
2382020-08-28T09:32:08  *** AaronvanW has quit IRC
2392020-08-28T09:33:47  *** bitcoin-git has joined #bitcoin-core-dev
2402020-08-28T09:33:48  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19827: init: Disallow negation of blockversion (master...2008-parseBoolBlockVersion) https://github.com/bitcoin/bitcoin/pull/19827
2412020-08-28T09:33:49  *** bitcoin-git has left #bitcoin-core-dev
2422020-08-28T09:35:46  <wumpus> vasild: I woudl suggest finding a stand-alone implementation of SHA3, a reminder: it does not need to be efficient
2432020-08-28T09:35:57  <wumpus> we're not going to take up a subtree of submodule just for this
2442020-08-28T09:36:34  <wumpus> MarcoFalke: exactly, a tiny implementation (as far as possible for something like Keccak) is preferred here
2452020-08-28T09:37:44  <vasild> I gave up with crypto++ after it turned out that it is not possible to take just sha3.h and sha3.cpp from its implementation (I don't want to do any modificatoins of those imported files)
2462020-08-28T09:38:50  <vasild> looking at https://github.com/coruus/keccak-tiny now
2472020-08-28T09:39:20  <wumpus> sure, I understand you don't want to end up maintaining this, but I wouldn't say small modifications (e.g. type names) are a problem to fit it better in our repository
2482020-08-28T09:39:41  *** jonatack has joined #bitcoin-core-dev
2492020-08-28T09:39:42  *** AaronvanW has joined #bitcoin-core-dev
2502020-08-28T09:39:47  <wumpus> nice
2512020-08-28T09:41:07  *** promag has joined #bitcoin-core-dev
2522020-08-28T09:41:23  <vasild> I also added a wrapper class SHA3_256 that has the same interface as our existing hashers: Write(), Finalize() and Reset() methods.
2532020-08-28T09:42:03  <wumpus> awesome, it's good to be consistent about that
2542020-08-28T09:42:53  <vasild> yeah, would also help if we decide to ditch whatever we have imported and import something else
2552020-08-28T09:43:09  <fanquake> That certainly looks better than random Tor code, git submodules,  OpenSSL or other shared libs
2562020-08-28T09:43:19  <wumpus> exactly
2572020-08-28T09:43:20  <vasild> :-)
2582020-08-28T09:43:29  <wumpus> we were getting scared for a bit
2592020-08-28T09:43:40  <vasild> fear not! :-D
2602020-08-28T09:44:41  *** andreacab has joined #bitcoin-core-dev
2612020-08-28T09:46:38  *** Pavlenex has joined #bitcoin-core-dev
2622020-08-28T09:54:18  <kallewoof> Weirdly, one of my linux machines complains that ./optional.h:24 ('static auto& nullopt = boost::none;') is unused in like 40+ places; it looks correct, but none of my other machines give me that warning no matter what flags I try (the specified -Wunused-variable is already present, I think)...
2632020-08-28T10:18:22  *** Jaren26Bogisich has joined #bitcoin-core-dev
2642020-08-28T10:22:28  <wumpus> isn't *const* missing?
2652020-08-28T10:22:32  <wumpus> or constexpr
2662020-08-28T10:24:05  <wumpus> it doesn't look right if you can assign something else to nullopt, and also, this is likely the reason you get a warning when including the file and not using nullopt
2672020-08-28T10:26:12  *** Pavlenex has quit IRC
2682020-08-28T10:32:08  *** arowser has quit IRC
2692020-08-28T10:32:51  *** arowser has joined #bitcoin-core-dev
2702020-08-28T10:34:19  *** midnight has quit IRC
2712020-08-28T10:37:10  *** Jaren26Bogisich has quit IRC
2722020-08-28T10:37:40  *** midnight has joined #bitcoin-core-dev
2732020-08-28T10:41:23  *** andreacab has quit IRC
2742020-08-28T10:41:30  *** andreacab has joined #bitcoin-core-dev
2752020-08-28T10:42:46  *** andreacab has joined #bitcoin-core-dev
2762020-08-28T10:46:56  *** andreacab has quit IRC
2772020-08-28T10:46:56  *** cato_ has quit IRC
2782020-08-28T10:51:44  *** cato_ has joined #bitcoin-core-dev
2792020-08-28T10:58:52  *** sipsorcery has quit IRC
2802020-08-28T10:59:11  *** Talkless has joined #bitcoin-core-dev
2812020-08-28T10:59:23  *** vasild has quit IRC
2822020-08-28T10:59:31  *** sipsorcery has joined #bitcoin-core-dev
2832020-08-28T11:00:45  *** vasild has joined #bitcoin-core-dev
2842020-08-28T11:09:32  *** Pavlenex has joined #bitcoin-core-dev
2852020-08-28T11:09:55  *** justanotheruser has quit IRC
2862020-08-28T11:15:28  *** andreacab has joined #bitcoin-core-dev
2872020-08-28T11:19:56  *** andreacab has quit IRC
2882020-08-28T11:42:22  *** roconnor has joined #bitcoin-core-dev
2892020-08-28T11:46:01  *** bitcoin-git has joined #bitcoin-core-dev
2902020-08-28T11:46:01  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/862fde88be70...4326515f01d7
2912020-08-28T11:46:02  <bitcoin-git> bitcoin/master df53688 Carl Dong: chain: Remove UB CChain comparison
2922020-08-28T11:46:03  <bitcoin-git> bitcoin/master 4326515 fanquake: Merge #19822: chain: Fix CChain comparison UB by removing it (it was unuse...
2932020-08-28T11:46:04  *** bitcoin-git has left #bitcoin-core-dev
2942020-08-28T11:46:21  *** bitcoin-git has joined #bitcoin-core-dev
2952020-08-28T11:46:21  <bitcoin-git> [bitcoin] fanquake merged pull request #19822: chain: Fix CChain comparison UB by removing it (it was unused) (master...2020-08-chain-comparison-UB) https://github.com/bitcoin/bitcoin/pull/19822
2962020-08-28T11:46:22  *** bitcoin-git has left #bitcoin-core-dev
2972020-08-28T11:50:53  *** andreacab has joined #bitcoin-core-dev
2982020-08-28T11:54:55  *** andreacab has quit IRC
2992020-08-28T12:00:02  *** krazyj has quit IRC
3002020-08-28T12:03:29  *** bitcoin-git has joined #bitcoin-core-dev
3012020-08-28T12:03:29  <bitcoin-git> [bitcoin] promag opened pull request #19828: wallet, refactor: Remove duplicate map lookups in GetAddressBalances (master...2020-08-getaddressbalances) https://github.com/bitcoin/bitcoin/pull/19828
3022020-08-28T12:03:30  *** bitcoin-git has left #bitcoin-core-dev
3032020-08-28T12:22:24  *** DocScrutinizer has joined #bitcoin-core-dev
3042020-08-28T12:22:25  *** DocScrutinizer is now known as Guest2955
3052020-08-28T12:30:13  *** Guyver2 has joined #bitcoin-core-dev
3062020-08-28T12:33:58  *** andreacab has joined #bitcoin-core-dev
3072020-08-28T12:37:11  *** bitcoin-git has joined #bitcoin-core-dev
3082020-08-28T12:37:11  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4326515f01d7...1dac4dcf088f
3092020-08-28T12:37:11  <bitcoin-git> bitcoin/master 9034f6e Hennadii Stepanov: Drop deprecated and unused GUARDED_VAR and PT_GUARDED_VAR annotations
3102020-08-28T12:37:12  <bitcoin-git> bitcoin/master 1dac4dc fanquake: Merge #19758: Drop deprecated and unused GUARDED_VAR and PT_GUARDED_VAR an...
3112020-08-28T12:37:13  *** bitcoin-git has left #bitcoin-core-dev
3122020-08-28T12:37:31  *** bitcoin-git has joined #bitcoin-core-dev
3132020-08-28T12:37:31  <bitcoin-git> [bitcoin] fanquake merged pull request #19758: Drop deprecated and unused GUARDED_VAR and PT_GUARDED_VAR annotations (master...200818-tsa) https://github.com/bitcoin/bitcoin/pull/19758
3142020-08-28T12:37:32  *** bitcoin-git has left #bitcoin-core-dev
3152020-08-28T12:38:31  *** andreacab has quit IRC
3162020-08-28T12:55:12  *** arowser has quit IRC
3172020-08-28T12:55:54  *** arowser has joined #bitcoin-core-dev
3182020-08-28T13:04:09  *** arowser has quit IRC
3192020-08-28T13:04:31  *** Mercury_Vapor has quit IRC
3202020-08-28T13:04:50  *** arowser has joined #bitcoin-core-dev
3212020-08-28T13:05:40  *** Pavlenex has quit IRC
3222020-08-28T13:06:10  *** arowser has quit IRC
3232020-08-28T13:06:51  *** arowser has joined #bitcoin-core-dev
3242020-08-28T13:07:09  *** arowser has quit IRC
3252020-08-28T13:07:30  *** EagleTM has quit IRC
3262020-08-28T13:07:50  *** arowser has joined #bitcoin-core-dev
3272020-08-28T13:11:10  *** arowser has quit IRC
3282020-08-28T13:11:41  *** troygiorshev has joined #bitcoin-core-dev
3292020-08-28T13:11:53  *** arowser has joined #bitcoin-core-dev
3302020-08-28T13:12:08  *** arowser has quit IRC
3312020-08-28T13:12:49  *** arowser has joined #bitcoin-core-dev
3322020-08-28T13:13:08  *** arowser has quit IRC
3332020-08-28T13:13:49  *** arowser has joined #bitcoin-core-dev
3342020-08-28T13:19:09  *** arowser has quit IRC
3352020-08-28T13:19:50  *** arowser has joined #bitcoin-core-dev
3362020-08-28T13:20:17  *** Mercury_Vapor has joined #bitcoin-core-dev
3372020-08-28T13:24:55  *** bitcoin-git has joined #bitcoin-core-dev
3382020-08-28T13:24:57  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1dac4dcf088f...22acd36d5365
3392020-08-28T13:24:57  <bitcoin-git> bitcoin/master c91b241 Jake Leventhal: Updated outdated help command for getblocktemplate (fixes #19625)
3402020-08-28T13:24:57  <bitcoin-git> bitcoin/master 22acd36 Wladimir J. van der Laan: Merge #19646: doc: Updated outdated help command for getblocktemplate
3412020-08-28T13:24:59  *** bitcoin-git has left #bitcoin-core-dev
3422020-08-28T13:25:15  *** bitcoin-git has joined #bitcoin-core-dev
3432020-08-28T13:25:16  <bitcoin-git> [bitcoin] laanwj merged pull request #19646: doc: Updated outdated help command for getblocktemplate (master...fix-outdated-getblocktemplate-help) https://github.com/bitcoin/bitcoin/pull/19646
3442020-08-28T13:25:17  *** bitcoin-git has left #bitcoin-core-dev
3452020-08-28T13:29:56  *** kljasdfvv has quit IRC
3462020-08-28T13:30:58  *** bitdex has quit IRC
3472020-08-28T13:40:13  *** arowser has quit IRC
3482020-08-28T13:40:55  *** arowser has joined #bitcoin-core-dev
3492020-08-28T13:51:12  *** arowser has quit IRC
3502020-08-28T13:51:53  *** arowser has joined #bitcoin-core-dev
3512020-08-28T13:53:48  *** shesek has joined #bitcoin-core-dev
3522020-08-28T13:53:48  *** shesek has joined #bitcoin-core-dev
3532020-08-28T14:08:08  *** Dean_Guss has quit IRC
3542020-08-28T14:08:56  *** Dean_Guss has joined #bitcoin-core-dev
3552020-08-28T14:10:40  *** EagleTM has joined #bitcoin-core-dev
3562020-08-28T14:13:28  *** _flow_ has joined #bitcoin-core-dev
3572020-08-28T14:28:14  *** _flow_ has quit IRC
3582020-08-28T14:28:29  *** _flow_ has joined #bitcoin-core-dev
3592020-08-28T14:29:52  *** _flow_ has quit IRC
3602020-08-28T14:32:44  *** _flow_ has joined #bitcoin-core-dev
3612020-08-28T14:33:20  *** arowser has quit IRC
3622020-08-28T14:34:02  *** arowser has joined #bitcoin-core-dev
3632020-08-28T14:36:17  *** Pavlenex has joined #bitcoin-core-dev
3642020-08-28T14:51:59  *** bitcoin-git has joined #bitcoin-core-dev
3652020-08-28T14:51:59  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/22acd36d5365...9632b7edc748
3662020-08-28T14:51:59  <bitcoin-git> bitcoin/master d3e8adf Sebastian Falbesoner: util: remove c-string interfaces for DecodeBase58{Check}
3672020-08-28T14:52:00  <bitcoin-git> bitcoin/master 9632b7e Wladimir J. van der Laan: Merge #19739: refactor: remove c-string interfaces for DecodeBase58{Check}...
3682020-08-28T14:52:00  *** bitcoin-git has left #bitcoin-core-dev
3692020-08-28T14:52:18  *** bitcoin-git has joined #bitcoin-core-dev
3702020-08-28T14:52:19  <bitcoin-git> [bitcoin] laanwj merged pull request #19739: refactor: remove c-string interfaces for DecodeBase58{Check} (master...20200811-util-remove-cstring-decodebase58) https://github.com/bitcoin/bitcoin/pull/19739
3712020-08-28T14:52:20  *** bitcoin-git has left #bitcoin-core-dev
3722020-08-28T15:00:02  *** Guest2955 has quit IRC
3732020-08-28T15:02:27  *** morcos has quit IRC
3742020-08-28T15:03:12  *** morcos has joined #bitcoin-core-dev
3752020-08-28T15:09:22  *** dviola has joined #bitcoin-core-dev
3762020-08-28T15:20:50  *** Pavlenex1 has joined #bitcoin-core-dev
3772020-08-28T15:21:26  *** bitcoin-git has joined #bitcoin-core-dev
3782020-08-28T15:21:26  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #19827: init: Disallow negation of blockversion (master...2008-parseBoolBlockVersion) https://github.com/bitcoin/bitcoin/pull/19827
3792020-08-28T15:21:28  *** bitcoin-git has left #bitcoin-core-dev
3802020-08-28T15:22:07  *** atiti has joined #bitcoin-core-dev
3812020-08-28T15:22:09  *** arowser has quit IRC
3822020-08-28T15:22:49  *** arowser has joined #bitcoin-core-dev
3832020-08-28T15:22:51  *** troygior1hev has joined #bitcoin-core-dev
3842020-08-28T15:24:14  *** Pavlenex has quit IRC
3852020-08-28T15:24:14  *** Pavlenex1 is now known as Pavlenex
3862020-08-28T15:25:47  *** troygiorshev has quit IRC
3872020-08-28T15:27:15  *** xurzua has joined #bitcoin-core-dev
3882020-08-28T15:28:46  *** melande1 has quit IRC
3892020-08-28T15:29:55  *** melande1 has joined #bitcoin-core-dev
3902020-08-28T15:32:03  *** sipsorcery has quit IRC
3912020-08-28T15:32:52  *** kexkey has joined #bitcoin-core-dev
3922020-08-28T15:32:55  *** sipsorcery has joined #bitcoin-core-dev
3932020-08-28T15:35:19  *** Pavlenex has quit IRC
3942020-08-28T15:39:03  *** Talkless has quit IRC
3952020-08-28T15:46:50  *** pinheadmz has quit IRC
3962020-08-28T15:53:25  *** atiti has quit IRC
3972020-08-28T15:53:27  *** xurzua has quit IRC
3982020-08-28T15:53:54  *** bitcoin-git has joined #bitcoin-core-dev
3992020-08-28T15:53:54  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9632b7edc748...5edef20a65f0
4002020-08-28T15:53:54  <bitcoin-git> bitcoin/master 7b6d0f1 Raúl Martínez (RME): Remove old check for 3-byte shifted IP addresses from pre-0.2.9 node messa...
4012020-08-28T15:53:55  <bitcoin-git> bitcoin/master 5edef20 MarcoFalke: Merge #19797: net: Remove old check for 3-byte shifted IP addresses from p...
4022020-08-28T15:53:56  *** bitcoin-git has left #bitcoin-core-dev
4032020-08-28T15:54:14  *** bitcoin-git has joined #bitcoin-core-dev
4042020-08-28T15:54:14  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19797: net: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 nodes (master...patch-1) https://github.com/bitcoin/bitcoin/pull/19797
4052020-08-28T15:54:15  *** bitcoin-git has left #bitcoin-core-dev
4062020-08-28T15:56:12  *** andreacab has joined #bitcoin-core-dev
4072020-08-28T15:56:23  *** bitcoin-git has joined #bitcoin-core-dev
4082020-08-28T15:56:24  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5edef20a65f0...ca30d34cf94b
4092020-08-28T15:56:25  <bitcoin-git> bitcoin/master 4227a8e Hennadii Stepanov: qt: Make "Create new receiving address" default unconditionally
4102020-08-28T15:56:26  <bitcoin-git> bitcoin/master 4ec49f8 Hennadii Stepanov: qt: Leverage the default "Create new receiving address" button
4112020-08-28T15:56:27  <bitcoin-git> bitcoin/master ca30d34 MarcoFalke: Merge bitcoin-core/gui#39: Add visual accenting for the 'Create new receiv...
4122020-08-28T15:56:28  *** bitcoin-git has left #bitcoin-core-dev
4132020-08-28T15:57:18  *** hiNikolay has joined #bitcoin-core-dev
4142020-08-28T16:01:11  *** andreacab has quit IRC
4152020-08-28T16:03:45  *** melande1 has quit IRC
4162020-08-28T16:03:53  *** melande2 has joined #bitcoin-core-dev
4172020-08-28T16:08:02  *** troygior1hev has quit IRC
4182020-08-28T16:14:43  *** melande2 has quit IRC
4192020-08-28T16:15:54  *** melande2 has joined #bitcoin-core-dev
4202020-08-28T16:18:50  *** jeremyrubin has joined #bitcoin-core-dev
4212020-08-28T16:30:57  *** wjp1 has joined #bitcoin-core-dev
4222020-08-28T16:37:56  *** Pavlenex has joined #bitcoin-core-dev
4232020-08-28T16:40:11  *** yancy has quit IRC
4242020-08-28T16:40:28  *** vincenzopalazzo has joined #bitcoin-core-dev
4252020-08-28T16:42:12  *** Pavlenex1 has joined #bitcoin-core-dev
4262020-08-28T16:42:28  *** Pavlenex has quit IRC
4272020-08-28T16:42:28  *** Pavlenex1 is now known as Pavlenex
4282020-08-28T17:00:12  *** arowser has quit IRC
4292020-08-28T17:00:55  *** arowser has joined #bitcoin-core-dev
4302020-08-28T17:03:25  *** TheRec has quit IRC
4312020-08-28T17:03:35  *** TheRec_ has joined #bitcoin-core-dev
4322020-08-28T17:03:35  *** TheRec_ has joined #bitcoin-core-dev
4332020-08-28T17:08:43  *** melande2 has quit IRC
4342020-08-28T17:09:15  *** Pavlenex has quit IRC
4352020-08-28T17:09:58  *** melande2 has joined #bitcoin-core-dev
4362020-08-28T17:17:28  *** Pavlenex has joined #bitcoin-core-dev
4372020-08-28T17:30:39  *** belcher_ has joined #bitcoin-core-dev
4382020-08-28T17:32:10  *** melande2 has quit IRC
4392020-08-28T17:32:52  *** melande2 has joined #bitcoin-core-dev
4402020-08-28T17:33:44  *** Pavlenex has quit IRC
4412020-08-28T17:33:47  *** belcher has quit IRC
4422020-08-28T17:43:48  <jnewbery> wumpus: #19607 may be ready for merge if you're happy with it
4432020-08-28T17:43:51  <gribble> https://github.com/bitcoin/bitcoin/issues/19607 | [p2p] Add Peer struct for per-peer data in net processing by jnewbery · Pull Request #19607 · bitcoin/bitcoin · GitHub
4442020-08-28T17:50:02  *** dkrm has joined #bitcoin-core-dev
4452020-08-28T17:51:13  *** owowo has quit IRC
4462020-08-28T17:56:34  *** owowo has joined #bitcoin-core-dev
4472020-08-28T17:57:52  *** andreacab has joined #bitcoin-core-dev
4482020-08-28T18:00:02  *** wjp1 has quit IRC
4492020-08-28T18:02:47  *** andreacab has quit IRC
4502020-08-28T18:08:53  <wumpus> jnewbery: let's see!
4512020-08-28T18:15:42  *** melande2 has quit IRC
4522020-08-28T18:16:56  *** melande2 has joined #bitcoin-core-dev
4532020-08-28T18:21:38  *** frank001 has joined #bitcoin-core-dev
4542020-08-28T18:24:30  <jonatack> maybe #19405 too
4552020-08-28T18:24:31  <gribble> https://github.com/bitcoin/bitcoin/issues/19405 | rpc, cli: add network in/out connections to `getnetworkinfo` and `-getinfo` by jonatack · Pull Request #19405 · bitcoin/bitcoin · GitHub
4562020-08-28T18:29:43  *** bitcoin-git has joined #bitcoin-core-dev
4572020-08-28T18:29:45  <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/ca30d34cf94b...1cf73fb8eba3
4582020-08-28T18:29:46  <bitcoin-git> bitcoin/master aba0335 John Newbery: [net processing] Remove CNodeState.name
4592020-08-28T18:29:46  <bitcoin-git> bitcoin/master 7cd4159 John Newbery: [net processing] Add Peer
4602020-08-28T18:29:47  <bitcoin-git> bitcoin/master 1f96d2e John Newbery: [net processing] Move misbehavior tracking state to Peer
4612020-08-28T18:29:49  *** bitcoin-git has left #bitcoin-core-dev
4622020-08-28T18:30:04  *** bitcoin-git has joined #bitcoin-core-dev
4632020-08-28T18:30:05  <bitcoin-git> [bitcoin] laanwj merged pull request #19607: [p2p] Add Peer struct for per-peer data in net processing (master...2020-07-peer) https://github.com/bitcoin/bitcoin/pull/19607
4642020-08-28T18:30:05  *** bitcoin-git has left #bitcoin-core-dev
4652020-08-28T18:34:24  *** justanotheruser has joined #bitcoin-core-dev
4662020-08-28T18:35:13  *** twistedline has joined #bitcoin-core-dev
4672020-08-28T18:35:13  *** twistedline has joined #bitcoin-core-dev
4682020-08-28T18:40:48  <jonatack> Looks like merging doesn't remove a PR from Chasing Concept ACK in https://github.com/bitcoin/bitcoin/projects/8
4692020-08-28T18:40:55  <jonatack> :)
4702020-08-28T18:41:49  <jonatack> at least, not automatically
4712020-08-28T18:43:05  <sipa> better Concept ACK is quickly
4722020-08-28T18:46:56  <luke-jr> lol
4732020-08-28T18:50:40  *** belcher_ has quit IRC
4742020-08-28T19:00:02  <meshcollider> jonatack: indeed, same with high priority and everything, still need to manually remove after merge
4752020-08-28T19:00:12  <meshcollider> #startmeeting
4762020-08-28T19:00:12  <lightningbot> Meeting started Fri Aug 28 19:00:12 2020 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
4772020-08-28T19:00:12  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
4782020-08-28T19:00:17  <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr
4792020-08-28T19:00:17  <meshcollider> jeremyrubin emilengler jonatack hebasto jb55
4802020-08-28T19:00:25  <provoostenator> hi
4812020-08-28T19:00:27  <achow101> hi
4822020-08-28T19:00:34  <meshcollider> Topics this week?
4832020-08-28T19:01:58  <provoostenator> No topics from me. I rebased a bunch of things.
4842020-08-28T19:02:03  <meshcollider> There are a few PRs that need review (from myself included) at the moment
4852020-08-28T19:02:05  <kanzure> hi
4862020-08-28T19:02:15  <achow101> just waiting on some reviews
4872020-08-28T19:02:28  <provoostenator> And just got back from vacation, so will do more review soon(tm)
4882020-08-28T19:02:33  <luke-jr> just a few? :P
4892020-08-28T19:02:44  <meshcollider> Always a few :)
4902020-08-28T19:02:56  <achow101> soon(tm)
4912020-08-28T19:03:15  <meshcollider> So hopefully we can tick off some bigger things this upcoming week
4922020-08-28T19:03:40  <provoostenator> Yeah, SQLite, Taproot wallet, OP_SECURE_THE_BAG support, should be doable.
4932020-08-28T19:04:13  <meshcollider> :D
4942020-08-28T19:04:41  <achow101> don't forget hardware wallets
4952020-08-28T19:04:42  *** melande2 has quit IRC
4962020-08-28T19:05:35  <provoostenator> Can we get fast rescan while we're at it?
4972020-08-28T19:05:47  <sipa> paypal integration?
4982020-08-28T19:05:47  <provoostenator> I keep forgetting to disable debug mode when I open ancient wallets
4992020-08-28T19:05:54  *** melande2 has joined #bitcoin-core-dev
5002020-08-28T19:06:10  <jonatack> hi
5012020-08-28T19:06:52  <provoostenator> Or maybe just a way to turn off debug mode without recompiling :-)
5022020-08-28T19:07:14  <achow101> I'd like to shill for #19619
5032020-08-28T19:07:19  <gribble> https://github.com/bitcoin/bitcoin/issues/19619 | Remove wallet.dat path handling from wallet.cpp, rpcwallet.cpp by ryanofsky · Pull Request #19619 · bitcoin/bitcoin · GitHub
5042020-08-28T19:07:40  *** Pavlenex has joined #bitcoin-core-dev
5052020-08-28T19:07:41  <meshcollider> achow101: I am mid-way through reviewing that
5062020-08-28T19:07:43  <achow101> as that's a requirement for sqlite wallets now
5072020-08-28T19:07:59  *** Pavlenex has quit IRC
5082020-08-28T19:08:35  <meshcollider> But Marco's comment needs addressing anyway
5092020-08-28T19:08:41  <sipa> provoostenator: what is debug mode?
5102020-08-28T19:09:29  <provoostenator> --enable-debug
5112020-08-28T19:09:36  <provoostenator> Which slows rescan down enourmously
5122020-08-28T19:10:02  <achow101> I think phantomcircuit had something for rescanning on the block filters
5132020-08-28T19:10:09  <achow101> or was working on something for that
5142020-08-28T19:10:16  <provoostenator> I think MarcoFalke had a PR, but closed it.
5152020-08-28T19:10:22  <provoostenator> Indeed using filters
5162020-08-28T19:10:35  <provoostenator> There were some hairy issues around refilling the keypool and updating the filters.
5172020-08-28T19:11:02  <jonatack> I plan to get to the #11413 follow-ups soon, e.g. tests, cleanups, and universal explicit feerate argument for RPCs. Needed before feature freeze.
5182020-08-28T19:11:06  <gribble> https://github.com/bitcoin/bitcoin/issues/11413 | [wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option by kallewoof · Pull Request #11413 · bitcoin/bitcoin · GitHub
5192020-08-28T19:11:40  <jonatack> RN we're overriding conf_target, which is a little confusing/scary
5202020-08-28T19:11:44  <provoostenator> jonatack: nice, feel free to tag me on it
5212020-08-28T19:11:57  <jonatack> will do
5222020-08-28T19:12:15  <meshcollider> Yeah, #15845
5232020-08-28T19:12:20  <gribble> https://github.com/bitcoin/bitcoin/issues/15845 | wallet: Fast rescan with BIP157 block filters by MarcoFalke · Pull Request #15845 · bitcoin/bitcoin · GitHub
5242020-08-28T19:12:44  <provoostenator> Also let me know if there's anything in #16378 that needs changing for your vision of universal fee rates.
5252020-08-28T19:12:46  <jonatack> provoostenator: enable-debug slows down everything by ~half for me anyway
5262020-08-28T19:12:47  <gribble> https://github.com/bitcoin/bitcoin/issues/16378 | The ultimate send RPC by Sjors · Pull Request #16378 · bitcoin/bitcoin · GitHub
5272020-08-28T19:12:57  <provoostenator> More like 10x for rescan
5282020-08-28T19:13:11  <provoostenator> But I can never be bothered to stop.
5292020-08-28T19:13:41  <jonatack> provoostenator: mentioned that PR to moneyball recently, will review/test it
5302020-08-28T19:13:42  <meshcollider> Ok so basically #action review lots!
5312020-08-28T19:13:53  <achow101> just review every PR tagged wallet
5322020-08-28T19:14:00  <jonatack> (ultimate send rpc)
5332020-08-28T19:14:22  <meshcollider> #endmeeting
5342020-08-28T19:14:22  <lightningbot> Meeting ended Fri Aug 28 19:14:22 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
5352020-08-28T19:14:22  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-28-19.00.html
5362020-08-28T19:14:22  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-28-19.00.txt
5372020-08-28T19:14:22  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-28-19.00.log.html
5382020-08-28T19:14:42  <provoostenator> One reason I made that PR is that people didn't like overloading arguments like conf_target even more
5392020-08-28T19:14:47  <jonatack> I should review 16378 asap actually
5402020-08-28T19:15:38  <jnewbery> thanks wumpus!
5412020-08-28T19:21:16  *** hiNikolay has quit IRC
5422020-08-28T19:21:27  <achow101> wen miniscript?
5432020-08-28T19:22:34  <sipa> i'll get back to it some time; too many other things to work on right now
5442020-08-28T19:45:26  *** justanotheruser has quit IRC
5452020-08-28T19:51:00  *** eugene70 has quit IRC
5462020-08-28T20:04:28  *** Talkless has joined #bitcoin-core-dev
5472020-08-28T20:26:47  *** melande2 has quit IRC
5482020-08-28T20:27:51  *** melande2 has joined #bitcoin-core-dev
5492020-08-28T20:29:05  *** Anduck has quit IRC
5502020-08-28T20:30:48  *** melande2 has quit IRC
5512020-08-28T20:31:55  *** melande2 has joined #bitcoin-core-dev
5522020-08-28T20:34:24  *** eugene72 has joined #bitcoin-core-dev
5532020-08-28T20:43:22  *** andreacab has joined #bitcoin-core-dev
5542020-08-28T20:45:29  *** Anduck has joined #bitcoin-core-dev
5552020-08-28T20:48:03  *** andreacab has quit IRC
5562020-08-28T20:49:51  *** Guyver2_ has joined #bitcoin-core-dev
5572020-08-28T20:52:30  *** Guyver2 has quit IRC
5582020-08-28T21:00:02  *** frank001 has quit IRC
5592020-08-28T21:01:01  *** eugene72 has quit IRC
5602020-08-28T21:02:35  *** Talkless has quit IRC
5612020-08-28T21:06:19  *** eugene71 has joined #bitcoin-core-dev
5622020-08-28T21:10:25  *** Deacyde has joined #bitcoin-core-dev
5632020-08-28T21:11:12  *** melande2 has quit IRC
5642020-08-28T21:11:52  *** melande2 has joined #bitcoin-core-dev
5652020-08-28T21:21:53  *** ferringb has joined #bitcoin-core-dev
5662020-08-28T21:28:07  *** Guyver2__ has joined #bitcoin-core-dev
5672020-08-28T21:30:49  *** Guyver2_ has quit IRC
5682020-08-28T21:34:19  *** dkrm has quit IRC
5692020-08-28T21:47:53  *** Mercury_Vapor has quit IRC
5702020-08-28T21:48:17  *** Mercury_Vapor has joined #bitcoin-core-dev
5712020-08-28T21:57:17  *** Guyver2__ has quit IRC
5722020-08-28T22:05:55  *** eugene71 has quit IRC
5732020-08-28T22:08:16  *** pinheadmz has joined #bitcoin-core-dev
5742020-08-28T22:17:25  *** jeremyrubin has quit IRC
5752020-08-28T22:26:42  *** melande2 has quit IRC
5762020-08-28T22:26:54  <phantomcircuit> achow101, i have something but kept getting frustrated because the organization of the gcs block filter stuff just seems wrong, it's really hard to extend without h4x
5772020-08-28T22:27:51  *** melande2 has joined #bitcoin-core-dev
5782020-08-28T22:29:26  *** Chris_Stewart_5 has quit IRC
5792020-08-28T22:44:20  *** andreacab has joined #bitcoin-core-dev
5802020-08-28T22:45:01  *** spinza has quit IRC
5812020-08-28T22:46:11  *** andreaca_ has joined #bitcoin-core-dev
5822020-08-28T22:49:03  *** andreacab has quit IRC
5832020-08-28T22:55:52  *** melande2 has quit IRC
5842020-08-28T22:56:56  *** melande2 has joined #bitcoin-core-dev
5852020-08-28T22:58:43  *** vasild has quit IRC
5862020-08-28T22:58:53  *** spinza has joined #bitcoin-core-dev
5872020-08-28T23:00:45  *** melande2 has quit IRC
5882020-08-28T23:00:49  *** vasild has joined #bitcoin-core-dev
5892020-08-28T23:01:51  *** melande2 has joined #bitcoin-core-dev
5902020-08-28T23:19:30  *** andreaca_ has quit IRC
5912020-08-28T23:22:05  *** arowser has quit IRC
5922020-08-28T23:22:47  *** arowser has joined #bitcoin-core-dev
5932020-08-28T23:31:48  *** melande2 has quit IRC
5942020-08-28T23:32:51  *** melande2 has joined #bitcoin-core-dev
5952020-08-28T23:33:26  *** Deacyde has quit IRC
5962020-08-28T23:47:24  *** jeremyrubin has joined #bitcoin-core-dev
5972020-08-28T23:50:17  <ariard> sdaftuar: we may have another slight improvement to eviction logic after #19670, if our slots are full we actually reject inbound connection from past IsDiscouraged peers
5982020-08-28T23:50:19  <gribble> https://github.com/bitcoin/bitcoin/issues/19670 | Protect localhost and block-relay-only peers from eviction by sdaftuar · Pull Request #19670 · bitcoin/bitcoin · GitHub
5992020-08-28T23:50:52  <ariard> but we don't pick them up as prioritized candidates for eviction if they're already connected to us and we get a new inbound
6002020-08-28T23:54:10  <ariard> as a first heuristic we could iterate on all IsDiscouraged and randomly pick out for eviction, thus biasing towards not-known-misbehaving peers
6012020-08-28T23:57:23  <sipa> ariard: discouraged peers have m_prefer_evict set, which goes into the eviction logic