12020-09-09T00:00:01 *** Voker571 has quit IRC
22020-09-09T00:00:32 *** davterra has quit IRC
32020-09-09T00:01:00 *** davterra has joined #bitcoin-core-dev
42020-09-09T00:01:25 *** go121212 has joined #bitcoin-core-dev
52020-09-09T00:03:02 *** mrostecki has joined #bitcoin-core-dev
62020-09-09T00:03:54 *** go11111111111 has quit IRC
72020-09-09T00:06:29 *** mdunnio has quit IRC
82020-09-09T00:06:34 *** Tennis has quit IRC
92020-09-09T00:12:32 *** promag_ has joined #bitcoin-core-dev
102020-09-09T00:13:38 *** Tennis has joined #bitcoin-core-dev
112020-09-09T00:17:19 *** promag_ has quit IRC
122020-09-09T00:22:21 *** Rennex1 has joined #bitcoin-core-dev
132020-09-09T00:27:11 *** gribble has quit IRC
142020-09-09T00:35:16 *** mrostecki has quit IRC
152020-09-09T00:36:43 *** morcos has quit IRC
162020-09-09T00:37:06 *** morcos has joined #bitcoin-core-dev
172020-09-09T00:40:46 *** mdunnio has joined #bitcoin-core-dev
182020-09-09T00:41:40 *** gribble has joined #bitcoin-core-dev
192020-09-09T00:42:05 *** worc3131 has quit IRC
202020-09-09T00:45:43 *** mdunnio has quit IRC
212020-09-09T00:45:49 *** justanotheruser has quit IRC
222020-09-09T00:46:25 *** worc3131 has joined #bitcoin-core-dev
232020-09-09T00:51:26 *** justanotheruser has joined #bitcoin-core-dev
242020-09-09T00:53:06 *** justanotheruser has quit IRC
252020-09-09T01:00:24 *** morcos has quit IRC
262020-09-09T01:01:13 *** morcos has joined #bitcoin-core-dev
272020-09-09T01:12:23 *** afk11 has quit IRC
282020-09-09T01:12:35 *** justanotheruser has joined #bitcoin-core-dev
292020-09-09T01:14:53 *** afk11 has joined #bitcoin-core-dev
302020-09-09T01:15:04 *** arowser has quit IRC
312020-09-09T01:15:29 *** arowser has joined #bitcoin-core-dev
322020-09-09T01:18:36 *** mdunnio has joined #bitcoin-core-dev
332020-09-09T01:18:54 *** AaronvanW has joined #bitcoin-core-dev
342020-09-09T01:23:25 *** mdunnio has quit IRC
352020-09-09T01:24:03 *** sipsorcery has quit IRC
362020-09-09T01:25:26 *** v14 has joined #bitcoin-core-dev
372020-09-09T01:35:00 *** kristapsk has quit IRC
382020-09-09T01:35:28 *** kristapsk has joined #bitcoin-core-dev
392020-09-09T01:39:43 *** morcos has quit IRC
402020-09-09T01:40:54 *** morcos has joined #bitcoin-core-dev
412020-09-09T01:49:59 *** proofofkeags has quit IRC
422020-09-09T01:50:20 *** AaronvanW has quit IRC
432020-09-09T01:53:00 *** v14 has quit IRC
442020-09-09T01:54:05 *** arowser has quit IRC
452020-09-09T01:54:26 *** arowser has joined #bitcoin-core-dev
462020-09-09T01:58:23 *** andreacab has joined #bitcoin-core-dev
472020-09-09T01:58:23 *** morcos has quit IRC
482020-09-09T02:02:51 *** andreacab has quit IRC
492020-09-09T02:03:41 *** morcos has joined #bitcoin-core-dev
502020-09-09T02:06:05 *** arowser has quit IRC
512020-09-09T02:06:25 *** arowser has joined #bitcoin-core-dev
522020-09-09T02:28:12 *** promag_ has joined #bitcoin-core-dev
532020-09-09T02:32:39 *** promag_ has quit IRC
542020-09-09T02:39:24 *** vhuffst has joined #bitcoin-core-dev
552020-09-09T02:40:35 *** isis is now known as isis_
562020-09-09T02:40:44 *** vhuffst has quit IRC
572020-09-09T02:41:59 *** bitcoin-git has joined #bitcoin-core-dev
582020-09-09T02:41:59 <bitcoin-git> [bitcoin] sipa closed pull request #19695: [do not merge] Test impact of secp256k1 endianness detection change (master...202008_test_appveyer_secp256k1) https://github.com/bitcoin/bitcoin/pull/19695
592020-09-09T02:42:00 *** bitcoin-git has left #bitcoin-core-dev
602020-09-09T02:57:32 *** tryphe_ has quit IRC
612020-09-09T02:57:42 *** tryphe_ has joined #bitcoin-core-dev
622020-09-09T03:00:01 *** Rennex1 has quit IRC
632020-09-09T03:04:50 *** go11111111111 has joined #bitcoin-core-dev
642020-09-09T03:04:57 *** go121212 has quit IRC
652020-09-09T03:06:21 *** go121212 has joined #bitcoin-core-dev
662020-09-09T03:09:45 *** go11111111111 has quit IRC
672020-09-09T03:11:03 *** opsec_x122 is now known as opsec_x12
682020-09-09T03:16:24 *** tryphe_ has quit IRC
692020-09-09T03:16:28 *** tryphe has joined #bitcoin-core-dev
702020-09-09T03:19:32 *** mdunnio has joined #bitcoin-core-dev
712020-09-09T03:21:54 *** midnightmagic has joined #bitcoin-core-dev
722020-09-09T03:22:18 *** midnightmagic is now known as Guest32689
732020-09-09T03:23:54 *** mdunnio has quit IRC
742020-09-09T03:30:22 *** Dean_Guss has quit IRC
752020-09-09T03:30:46 *** Dean_Guss has joined #bitcoin-core-dev
762020-09-09T03:32:04 *** arowser has quit IRC
772020-09-09T03:32:23 *** arowser has joined #bitcoin-core-dev
782020-09-09T03:47:31 *** AaronvanW has joined #bitcoin-core-dev
792020-09-09T03:56:38 *** mekster6 has joined #bitcoin-core-dev
802020-09-09T03:57:56 *** Evel-Knievel has quit IRC
812020-09-09T03:57:59 *** sr_gi has quit IRC
822020-09-09T03:58:00 *** sr_gi6 has joined #bitcoin-core-dev
832020-09-09T03:58:02 *** TheHoliestRoger has quit IRC
842020-09-09T03:58:28 *** mekster has quit IRC
852020-09-09T03:58:29 *** mekster6 is now known as mekster
862020-09-09T03:58:41 *** Evel-Knievel has joined #bitcoin-core-dev
872020-09-09T03:59:10 *** proofofkeags has joined #bitcoin-core-dev
882020-09-09T03:59:18 *** TheHoliestRoger has joined #bitcoin-core-dev
892020-09-09T04:19:41 *** promag_ has joined #bitcoin-core-dev
902020-09-09T04:20:32 *** AaronvanW has quit IRC
912020-09-09T04:24:01 *** promag_ has quit IRC
922020-09-09T04:34:23 *** melande has quit IRC
932020-09-09T04:37:00 *** melande has joined #bitcoin-core-dev
942020-09-09T04:53:50 *** tralfaz has joined #bitcoin-core-dev
952020-09-09T04:53:58 *** davterra has quit IRC
962020-09-09T05:11:55 *** melande has quit IRC
972020-09-09T05:12:20 *** melande has joined #bitcoin-core-dev
982020-09-09T05:15:54 *** tralfaz has quit IRC
992020-09-09T05:16:40 *** davterra has joined #bitcoin-core-dev
1002020-09-09T05:20:23 *** mdunnio has joined #bitcoin-core-dev
1012020-09-09T05:24:53 *** pinheadmz has quit IRC
1022020-09-09T05:25:19 *** mdunnio has quit IRC
1032020-09-09T05:26:14 *** andreacab has joined #bitcoin-core-dev
1042020-09-09T05:30:46 *** andreacab has quit IRC
1052020-09-09T05:30:58 *** melande has quit IRC
1062020-09-09T05:31:19 *** melande has joined #bitcoin-core-dev
1072020-09-09T05:32:03 *** promag_ has joined #bitcoin-core-dev
1082020-09-09T05:36:49 *** promag_ has quit IRC
1092020-09-09T05:44:32 *** Dean_Guss has quit IRC
1102020-09-09T05:45:09 *** Dean_Guss has joined #bitcoin-core-dev
1112020-09-09T06:00:01 *** Guest32689 has quit IRC
1122020-09-09T06:01:25 *** Dean_Guss has quit IRC
1132020-09-09T06:02:41 *** Dean_Guss has joined #bitcoin-core-dev
1142020-09-09T06:06:54 *** melande has quit IRC
1152020-09-09T06:07:19 *** melande has joined #bitcoin-core-dev
1162020-09-09T06:17:05 *** arowser has quit IRC
1172020-09-09T06:17:17 *** AaronvanW has joined #bitcoin-core-dev
1182020-09-09T06:17:24 *** arowser has joined #bitcoin-core-dev
1192020-09-09T06:21:45 *** whartung1 has joined #bitcoin-core-dev
1202020-09-09T06:30:02 *** Pavlenex has joined #bitcoin-core-dev
1212020-09-09T06:30:31 <vasild> Next step to TORv3 is at #19845, waiting for some reviewers to shoot it down :)
1222020-09-09T06:30:39 <gribble> https://github.com/bitcoin/bitcoin/issues/19845 | net: CNetAddr: add support to (un)serialize as ADDRv2 by vasild · Pull Request #19845 · bitcoin/bitcoin · GitHub
1232020-09-09T06:34:54 <jonatack> ð
1242020-09-09T06:38:24 *** Guyver2 has joined #bitcoin-core-dev
1252020-09-09T06:39:05 *** arowser has quit IRC
1262020-09-09T06:39:25 *** arowser has joined #bitcoin-core-dev
1272020-09-09T06:41:44 *** jonatack has quit IRC
1282020-09-09T06:46:07 *** andreacab has joined #bitcoin-core-dev
1292020-09-09T06:49:34 *** harrigan has joined #bitcoin-core-dev
1302020-09-09T06:49:36 *** Pavlenex has quit IRC
1312020-09-09T06:50:09 *** AaronvanW has quit IRC
1322020-09-09T06:54:06 *** Pavlenex has joined #bitcoin-core-dev
1332020-09-09T06:54:35 *** promag_ has joined #bitcoin-core-dev
1342020-09-09T06:56:18 *** harrigan has quit IRC
1352020-09-09T06:56:56 *** harrigan has joined #bitcoin-core-dev
1362020-09-09T06:59:37 *** Pavlenex has quit IRC
1372020-09-09T07:00:31 *** Pavlenex has joined #bitcoin-core-dev
1382020-09-09T07:03:53 *** promag_ has quit IRC
1392020-09-09T07:04:19 *** promag has quit IRC
1402020-09-09T07:07:29 *** promag_ has joined #bitcoin-core-dev
1412020-09-09T07:09:14 *** bitcoin-git has joined #bitcoin-core-dev
1422020-09-09T07:09:14 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4f229d8904f8...564e1ab0f3dc
1432020-09-09T07:09:15 <bitcoin-git> bitcoin/master fa39c62 MarcoFalke: test: inline hashToHex
1442020-09-09T07:09:15 <bitcoin-git> bitcoin/master fa188c9 MarcoFalke: test: Use MiniWalet in p2p_feefilter
1452020-09-09T07:09:16 <bitcoin-git> bitcoin/master 564e1ab MarcoFalke: Merge #19800: test: Mockwallet
1462020-09-09T07:09:18 *** bitcoin-git has left #bitcoin-core-dev
1472020-09-09T07:09:34 *** bitcoin-git has joined #bitcoin-core-dev
1482020-09-09T07:09:34 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19800: test: Mockwallet (master...2008-testMiniWallet) https://github.com/bitcoin/bitcoin/pull/19800
1492020-09-09T07:09:36 *** bitcoin-git has left #bitcoin-core-dev
1502020-09-09T07:10:16 *** andreacab has quit IRC
1512020-09-09T07:11:47 *** promag_ has quit IRC
1522020-09-09T07:12:46 *** marcoagner has joined #bitcoin-core-dev
1532020-09-09T07:14:19 *** sipsorcery has joined #bitcoin-core-dev
1542020-09-09T07:16:02 *** andreacab has joined #bitcoin-core-dev
1552020-09-09T07:16:45 *** andreacab has joined #bitcoin-core-dev
1562020-09-09T07:21:03 *** sipa has quit IRC
1572020-09-09T07:21:04 *** mdunnio has joined #bitcoin-core-dev
1582020-09-09T07:25:55 *** mdunnio has quit IRC
1592020-09-09T07:26:50 *** sipa has joined #bitcoin-core-dev
1602020-09-09T07:27:55 *** melande has quit IRC
1612020-09-09T07:28:02 *** belcher_ has joined #bitcoin-core-dev
1622020-09-09T07:28:23 *** melande has joined #bitcoin-core-dev
1632020-09-09T07:29:06 *** andreacab has quit IRC
1642020-09-09T07:29:36 *** andreacab has joined #bitcoin-core-dev
1652020-09-09T07:30:17 *** jonatack has joined #bitcoin-core-dev
1662020-09-09T07:31:14 *** belcher has quit IRC
1672020-09-09T07:32:55 *** andreaca_ has joined #bitcoin-core-dev
1682020-09-09T07:33:55 *** andreacab has quit IRC
1692020-09-09T07:33:57 *** promag has joined #bitcoin-core-dev
1702020-09-09T07:34:49 *** jonatack has quit IRC
1712020-09-09T07:35:14 *** melande has quit IRC
1722020-09-09T07:35:19 *** melande1 has joined #bitcoin-core-dev
1732020-09-09T07:36:05 *** arowser has quit IRC
1742020-09-09T07:36:24 *** arowser has joined #bitcoin-core-dev
1752020-09-09T07:36:35 *** jonatack has joined #bitcoin-core-dev
1762020-09-09T07:38:37 *** promag has quit IRC
1772020-09-09T07:53:42 *** promag has joined #bitcoin-core-dev
1782020-09-09T07:53:45 *** promag_ has joined #bitcoin-core-dev
1792020-09-09T07:56:06 *** EagleTM has joined #bitcoin-core-dev
1802020-09-09T07:58:55 <jonasschnelli> How is the process of merging "back" the state from the GUI repository? Is there a planed timeframe? Will there just be one PR to the main repository that includes all changes (like a backport PR)? Is that process documented already?
1812020-09-09T07:58:58 <jonasschnelli> ^ MarcoFalke
1822020-09-09T08:00:58 *** melande1 has quit IRC
1832020-09-09T08:01:24 *** melande1 has joined #bitcoin-core-dev
1842020-09-09T08:04:27 *** andreaca_ has quit IRC
1852020-09-09T08:04:54 *** andreacab has joined #bitcoin-core-dev
1862020-09-09T08:06:17 <promag> jonasschnelli: +1
1872020-09-09T08:08:46 *** andreaca_ has joined #bitcoin-core-dev
1882020-09-09T08:08:58 *** andreacab has quit IRC
1892020-09-09T08:10:35 *** promag has quit IRC
1902020-09-09T08:14:42 *** promag has joined #bitcoin-core-dev
1912020-09-09T08:23:00 *** melande1 has quit IRC
1922020-09-09T08:23:22 *** melande1 has joined #bitcoin-core-dev
1932020-09-09T08:27:26 *** andreaca_ has quit IRC
1942020-09-09T08:27:34 <jnewbery> #proposed meeting topic: stategies for removing recursive locking in the mempool (https://github.com/bitcoin/bitcoin/pull/19872#issuecomment-688852261)
1952020-09-09T08:27:34 *** andreacab has joined #bitcoin-core-dev
1962020-09-09T08:30:17 *** andreacab has quit IRC
1972020-09-09T08:30:43 *** andreacab has joined #bitcoin-core-dev
1982020-09-09T08:30:57 *** AaronvanW has joined #bitcoin-core-dev
1992020-09-09T08:35:11 *** andreacab has quit IRC
2002020-09-09T08:36:53 *** AaronvanW has quit IRC
2012020-09-09T08:37:13 *** AaronvanW has joined #bitcoin-core-dev
2022020-09-09T08:38:02 *** andreacab has joined #bitcoin-core-dev
2032020-09-09T08:44:08 *** bitcoin-git has joined #bitcoin-core-dev
2042020-09-09T08:44:08 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #19922: test: Run rpc_txoutproof.py even with wallet disabled (master...2009-testMoreMiniWallet) https://github.com/bitcoin/bitcoin/pull/19922
2052020-09-09T08:44:09 *** bitcoin-git has left #bitcoin-core-dev
2062020-09-09T08:50:20 *** promag has quit IRC
2072020-09-09T08:50:56 *** promag has joined #bitcoin-core-dev
2082020-09-09T08:51:50 *** promag has quit IRC
2092020-09-09T08:52:07 *** promag has joined #bitcoin-core-dev
2102020-09-09T08:54:59 *** someone235 has joined #bitcoin-core-dev
2112020-09-09T08:55:05 *** arowser has quit IRC
2122020-09-09T08:55:24 *** arowser has joined #bitcoin-core-dev
2132020-09-09T09:00:02 *** whartung1 has quit IRC
2142020-09-09T09:00:25 *** afk11 has quit IRC
2152020-09-09T09:00:56 *** afk11 has joined #bitcoin-core-dev
2162020-09-09T09:04:57 *** Pavlenex has quit IRC
2172020-09-09T09:15:25 *** promag has quit IRC
2182020-09-09T09:15:51 *** andreacab has quit IRC
2192020-09-09T09:16:18 *** andreacab has joined #bitcoin-core-dev
2202020-09-09T09:16:40 *** promag has joined #bitcoin-core-dev
2212020-09-09T09:20:41 *** andreacab has quit IRC
2222020-09-09T09:21:57 *** mdunnio has joined #bitcoin-core-dev
2232020-09-09T09:22:21 *** kaimi1 has joined #bitcoin-core-dev
2242020-09-09T09:24:57 *** melande1 has quit IRC
2252020-09-09T09:25:21 *** melande1 has joined #bitcoin-core-dev
2262020-09-09T09:26:37 *** mdunnio has quit IRC
2272020-09-09T09:30:02 *** AaronvanW has quit IRC
2282020-09-09T09:31:39 *** andreacab has joined #bitcoin-core-dev
2292020-09-09T09:31:56 *** melande1 has quit IRC
2302020-09-09T09:32:25 *** melande1 has joined #bitcoin-core-dev
2312020-09-09T09:42:30 *** promag has quit IRC
2322020-09-09T09:54:21 *** provoostenator has quit IRC
2332020-09-09T09:56:41 *** mrostecki has joined #bitcoin-core-dev
2342020-09-09T10:02:56 *** melande1 has quit IRC
2352020-09-09T10:04:17 *** melande1 has joined #bitcoin-core-dev
2362020-09-09T10:07:56 *** AaronvanW has joined #bitcoin-core-dev
2372020-09-09T10:11:00 *** andreacab has quit IRC
2382020-09-09T10:11:28 *** andreacab has joined #bitcoin-core-dev
2392020-09-09T10:12:35 *** AaronvanW has quit IRC
2402020-09-09T10:13:25 *** EagleTM has quit IRC
2412020-09-09T10:15:49 *** jonatack has quit IRC
2422020-09-09T10:16:07 *** andreacab has quit IRC
2432020-09-09T10:18:28 *** Emily79Grady has joined #bitcoin-core-dev
2442020-09-09T10:28:05 *** arowser has quit IRC
2452020-09-09T10:28:26 *** arowser has joined #bitcoin-core-dev
2462020-09-09T10:29:01 *** melande1 has quit IRC
2472020-09-09T10:29:25 *** melande1 has joined #bitcoin-core-dev
2482020-09-09T10:30:41 *** promag has joined #bitcoin-core-dev
2492020-09-09T10:32:26 *** promag has quit IRC
2502020-09-09T10:39:18 *** promag has joined #bitcoin-core-dev
2512020-09-09T10:39:20 <promag> jnewbery: +1
2522020-09-09T10:39:39 *** promag_ has quit IRC
2532020-09-09T10:41:57 *** brianhoffman has quit IRC
2542020-09-09T10:42:13 *** brianhoffman has joined #bitcoin-core-dev
2552020-09-09T10:42:38 *** Emily79Grady has quit IRC
2562020-09-09T10:43:27 *** AaronvanW has joined #bitcoin-core-dev
2572020-09-09T10:44:19 *** promag has quit IRC
2582020-09-09T10:48:29 *** promag has joined #bitcoin-core-dev
2592020-09-09T10:59:23 *** vasild has quit IRC
2602020-09-09T10:59:48 *** promag_ has joined #bitcoin-core-dev
2612020-09-09T11:01:28 *** vasild has joined #bitcoin-core-dev
2622020-09-09T11:07:43 <elichai2> MarcoFalke: I can't manage to reproduce the error in #19920, instead I'm getting a really weird bug without the full details, any idea why? (I'm getting this: https://pastebin.com/raw/MBzJ0ixB)
2632020-09-09T11:07:47 <gribble> https://github.com/bitcoin/bitcoin/issues/19920 | test: Fuzzing siphash against reference implementation [Request for feedback] by elichai · Pull Request #19920 · bitcoin/bitcoin · GitHub
2642020-09-09T11:08:39 *** promag has quit IRC
2652020-09-09T11:08:40 *** melande1 is now known as melande
2662020-09-09T11:14:19 *** EagleTM has joined #bitcoin-core-dev
2672020-09-09T11:15:54 *** melande has quit IRC
2682020-09-09T11:16:23 *** melande has joined #bitcoin-core-dev
2692020-09-09T11:16:55 <elichai2> found the bug :) you're not allowed to do `&*it` on null ð
2702020-09-09T11:16:56 *** AaronvanW has quit IRC
2712020-09-09T11:18:20 *** worc3131 has quit IRC
2722020-09-09T11:18:23 *** melande has quit IRC
2732020-09-09T11:19:38 *** worc3131 has joined #bitcoin-core-dev
2742020-09-09T11:22:52 *** mdunnio has joined #bitcoin-core-dev
2752020-09-09T11:23:02 *** melande has joined #bitcoin-core-dev
2762020-09-09T11:24:10 *** ghost43 has quit IRC
2772020-09-09T11:24:39 *** ghost43 has joined #bitcoin-core-dev
2782020-09-09T11:25:44 *** melande has quit IRC
2792020-09-09T11:26:10 *** melande has joined #bitcoin-core-dev
2802020-09-09T11:27:35 *** mdunnio has quit IRC
2812020-09-09T11:48:05 *** arowser has quit IRC
2822020-09-09T11:48:48 *** arowser has joined #bitcoin-core-dev
2832020-09-09T11:49:54 *** promag_ has quit IRC
2842020-09-09T11:53:05 *** EagleTM has quit IRC
2852020-09-09T12:00:02 *** kaimi1 has quit IRC
2862020-09-09T12:02:59 *** melande has quit IRC
2872020-09-09T12:03:30 *** melande has joined #bitcoin-core-dev
2882020-09-09T12:04:51 *** jonatack has joined #bitcoin-core-dev
2892020-09-09T12:05:49 *** opsec_x12 has quit IRC
2902020-09-09T12:06:14 *** opsec_x12 has joined #bitcoin-core-dev
2912020-09-09T12:20:41 *** Eric3 has quit IRC
2922020-09-09T12:21:27 *** Jamalaka1 has joined #bitcoin-core-dev
2932020-09-09T12:21:42 *** ExEric3 has joined #bitcoin-core-dev
2942020-09-09T12:27:35 *** Highway61 has joined #bitcoin-core-dev
2952020-09-09T12:29:58 *** melande has quit IRC
2962020-09-09T12:33:58 *** andreacab has joined #bitcoin-core-dev
2972020-09-09T12:34:14 *** melande has joined #bitcoin-core-dev
2982020-09-09T12:38:44 *** promag has joined #bitcoin-core-dev
2992020-09-09T12:43:11 *** promag has quit IRC
3002020-09-09T12:49:01 *** twistedline_ has quit IRC
3012020-09-09T12:49:19 *** twistedline_ has joined #bitcoin-core-dev
3022020-09-09T12:55:51 *** vasild has quit IRC
3032020-09-09T12:56:08 *** vasild has joined #bitcoin-core-dev
3042020-09-09T13:02:22 *** andreacab has quit IRC
3052020-09-09T13:04:18 *** vasild has quit IRC
3062020-09-09T13:04:35 *** vasild has joined #bitcoin-core-dev
3072020-09-09T13:05:05 *** arowser has quit IRC
3082020-09-09T13:05:46 *** arowser has joined #bitcoin-core-dev
3092020-09-09T13:06:05 *** arowser has quit IRC
3102020-09-09T13:06:25 *** arowser has joined #bitcoin-core-dev
3112020-09-09T13:07:07 *** andreacab has joined #bitcoin-core-dev
3122020-09-09T13:08:04 *** arowser has quit IRC
3132020-09-09T13:08:25 *** arowser has joined #bitcoin-core-dev
3142020-09-09T13:10:05 *** arowser has quit IRC
3152020-09-09T13:10:48 *** arowser has joined #bitcoin-core-dev
3162020-09-09T13:11:05 *** arowser has quit IRC
3172020-09-09T13:11:21 *** andreacab has quit IRC
3182020-09-09T13:11:25 *** arowser has joined #bitcoin-core-dev
3192020-09-09T13:12:05 *** arowser has quit IRC
3202020-09-09T13:12:26 *** arowser has joined #bitcoin-core-dev
3212020-09-09T13:12:41 *** nim87 has joined #bitcoin-core-dev
3222020-09-09T13:13:05 *** arowser has quit IRC
3232020-09-09T13:13:27 *** arowser has joined #bitcoin-core-dev
3242020-09-09T13:14:03 *** AaronvanW has joined #bitcoin-core-dev
3252020-09-09T13:14:06 *** arowser has quit IRC
3262020-09-09T13:14:27 *** arowser has joined #bitcoin-core-dev
3272020-09-09T13:16:12 *** promag has joined #bitcoin-core-dev
3282020-09-09T13:16:28 *** promag has quit IRC
3292020-09-09T13:16:42 *** promag has joined #bitcoin-core-dev
3302020-09-09T13:23:50 *** mdunnio has joined #bitcoin-core-dev
3312020-09-09T13:28:30 *** mdunnio has quit IRC
3322020-09-09T13:39:30 *** nim87 has quit IRC
3332020-09-09T13:41:06 *** arowser has quit IRC
3342020-09-09T13:41:27 *** arowser has joined #bitcoin-core-dev
3352020-09-09T13:42:43 *** melande has quit IRC
3362020-09-09T13:43:05 *** arowser has quit IRC
3372020-09-09T13:43:25 *** arowser has joined #bitcoin-core-dev
3382020-09-09T13:44:33 *** mdunnio has joined #bitcoin-core-dev
3392020-09-09T13:44:33 *** andreacab has joined #bitcoin-core-dev
3402020-09-09T13:45:11 *** melande has joined #bitcoin-core-dev
3412020-09-09T13:46:18 *** AaronvanW has quit IRC
3422020-09-09T13:49:19 *** andreacab has quit IRC
3432020-09-09T13:51:51 *** AaronvanW has joined #bitcoin-core-dev
3442020-09-09T13:56:05 *** arowser has quit IRC
3452020-09-09T13:56:47 *** arowser has joined #bitcoin-core-dev
3462020-09-09T14:02:58 *** melande has quit IRC
3472020-09-09T14:07:18 *** melande has joined #bitcoin-core-dev
3482020-09-09T14:09:35 *** mrostecki has quit IRC
3492020-09-09T14:10:11 *** mrostecki has joined #bitcoin-core-dev
3502020-09-09T14:13:56 *** melande has quit IRC
3512020-09-09T14:17:56 *** melande has joined #bitcoin-core-dev
3522020-09-09T14:19:04 *** arowser has quit IRC
3532020-09-09T14:19:26 *** arowser has joined #bitcoin-core-dev
3542020-09-09T14:25:05 *** proofofkeags has quit IRC
3552020-09-09T14:25:19 *** bitcoin-git has joined #bitcoin-core-dev
3562020-09-09T14:25:19 <bitcoin-git> [bitcoin] hebasto opened pull request #19926: gui: Add Tor icon (master...200909-tor) https://github.com/bitcoin/bitcoin/pull/19926
3572020-09-09T14:25:20 *** bitcoin-git has left #bitcoin-core-dev
3582020-09-09T14:39:56 *** pinheadmz has joined #bitcoin-core-dev
3592020-09-09T14:56:54 *** mol_ has quit IRC
3602020-09-09T14:57:23 *** mol_ has joined #bitcoin-core-dev
3612020-09-09T15:00:01 *** Jamalaka1 has quit IRC
3622020-09-09T15:01:11 *** jonatack has quit IRC
3632020-09-09T15:04:28 *** jonatack has joined #bitcoin-core-dev
3642020-09-09T15:05:43 *** morcos has quit IRC
3652020-09-09T15:06:52 *** proofofkeags has joined #bitcoin-core-dev
3662020-09-09T15:11:03 *** morcos has joined #bitcoin-core-dev
3672020-09-09T15:16:07 *** melande has quit IRC
3682020-09-09T15:16:19 *** melande has joined #bitcoin-core-dev
3692020-09-09T15:16:58 *** melande has quit IRC
3702020-09-09T15:17:22 *** melande has joined #bitcoin-core-dev
3712020-09-09T15:17:43 *** Talkless has joined #bitcoin-core-dev
3722020-09-09T15:21:01 *** ggainey1 has joined #bitcoin-core-dev
3732020-09-09T15:31:21 *** andreacab has joined #bitcoin-core-dev
3742020-09-09T15:35:33 *** andreacab has quit IRC
3752020-09-09T15:45:52 *** owowo has quit IRC
3762020-09-09T15:50:46 *** owowo has joined #bitcoin-core-dev
3772020-09-09T15:57:35 *** AaronvanW has quit IRC
3782020-09-09T16:02:57 *** melande has quit IRC
3792020-09-09T16:03:21 *** melande has joined #bitcoin-core-dev
3802020-09-09T16:11:10 *** andreacab has joined #bitcoin-core-dev
3812020-09-09T16:12:05 *** arowser has quit IRC
3822020-09-09T16:12:24 *** arowser has joined #bitcoin-core-dev
3832020-09-09T16:14:00 *** AaronvanW has joined #bitcoin-core-dev
3842020-09-09T16:15:34 *** andreacab has quit IRC
3852020-09-09T16:19:59 *** melande has quit IRC
3862020-09-09T16:20:20 *** melande has joined #bitcoin-core-dev
3872020-09-09T16:34:42 *** gzhao408 has joined #bitcoin-core-dev
3882020-09-09T16:57:31 *** MrPaz has joined #bitcoin-core-dev
3892020-09-09T17:00:34 *** b10c has joined #bitcoin-core-dev
3902020-09-09T17:04:20 *** melande1 has joined #bitcoin-core-dev
3912020-09-09T17:04:42 *** melande has quit IRC
3922020-09-09T17:08:20 *** bitcoin-git has joined #bitcoin-core-dev
3932020-09-09T17:08:20 <bitcoin-git> [bitcoin] dongcarl opened pull request #19927: validation: Reduce direct g_chainman usage (master...2020-09-reduce-g_chainman-usage) https://github.com/bitcoin/bitcoin/pull/19927
3942020-09-09T17:08:21 *** bitcoin-git has left #bitcoin-core-dev
3952020-09-09T17:10:33 *** filchef has joined #bitcoin-core-dev
3962020-09-09T17:12:24 *** AaronvanW has quit IRC
3972020-09-09T17:15:09 *** lightlike has joined #bitcoin-core-dev
3982020-09-09T17:20:53 <ariard> jonasschnelli: just replied on bip324, AFAICT real-or-random and I favor MACing the length a la noise, even if as Lloyd is pointing we don't a concrete exploitation of it
3992020-09-09T17:23:54 *** owowo has quit IRC
4002020-09-09T17:27:01 <achow101> jonasschnelli: IIRC PRs merged to the GUI repo are also pushed to the main repo simultaneously
4012020-09-09T17:28:54 *** owowo has joined #bitcoin-core-dev
4022020-09-09T17:33:48 *** AaronvanW has joined #bitcoin-core-dev
4032020-09-09T17:42:55 *** melande1 has quit IRC
4042020-09-09T17:43:25 *** melande1 has joined #bitcoin-core-dev
4052020-09-09T18:00:03 *** ggainey1 has quit IRC
4062020-09-09T18:02:34 *** andreacab has joined #bitcoin-core-dev
4072020-09-09T18:03:55 *** melande1 has quit IRC
4082020-09-09T18:04:19 *** melande1 has joined #bitcoin-core-dev
4092020-09-09T18:05:23 *** melande1 has joined #bitcoin-core-dev
4102020-09-09T18:20:18 *** b10c has quit IRC
4112020-09-09T18:20:38 *** b10c has joined #bitcoin-core-dev
4122020-09-09T18:20:50 *** ThunderChicken1 has joined #bitcoin-core-dev
4132020-09-09T18:34:47 *** jb55 has quit IRC
4142020-09-09T18:35:17 *** jb55 has joined #bitcoin-core-dev
4152020-09-09T18:50:22 *** b10c has quit IRC
4162020-09-09T18:57:35 <luke-jr> wtf :/ https://github.com/bitcoin/bitcoin/issues/19928
4172020-09-09T19:00:12 <achow101> luke-jr: O.o
4182020-09-09T19:00:47 <achow101> the filenames are hardcoded...
4192020-09-09T19:00:54 *** tryphe has quit IRC
4202020-09-09T19:01:42 *** tryphe has joined #bitcoin-core-dev
4212020-09-09T19:02:00 <luke-jr> achow101: isn't this the directory name, actually?
4222020-09-09T19:02:42 <achow101> https://twitter.com/2btc10000pizzas/status/1303767335258542085 would indicate it effects the wallet.dat file
4232020-09-09T19:03:01 *** worc3131 has quit IRC
4242020-09-09T19:03:17 <achow101> although the previous tweet also suggests the directory name
4252020-09-09T19:03:33 <luke-jr> ackup.dat doesn't
4262020-09-09T19:03:49 *** bitcoin-git has joined #bitcoin-core-dev
4272020-09-09T19:03:49 <bitcoin-git> [bitcoin] vasild opened pull request #19929: sync: use proper TSA attributes (master...use_proper_tsa_attributes) https://github.com/bitcoin/bitcoin/pull/19929
4282020-09-09T19:03:50 *** bitcoin-git has left #bitcoin-core-dev
4292020-09-09T19:04:15 *** worc3131 has joined #bitcoin-core-dev
4302020-09-09T19:04:16 <achow101> right
4312020-09-09T19:04:34 <achow101> allet.dat does but maybe he specified wallet.dat and not just ""
4322020-09-09T19:04:45 <achow101> so that would mean it's a wallet name handling thing
4332020-09-09T19:04:50 <luke-jr> "" is never on disk :p
4342020-09-09T19:05:18 <luke-jr> you saw that apparently the actual on-disk filenames are being renamed, right?
4352020-09-09T19:05:31 <achow101> yes
4362020-09-09T19:05:33 <luke-jr> I'm not 100% sure they know what they're talking about in that regard, but it's weird
4372020-09-09T19:06:03 <gwillen> off the top of my head, one way to eat the first character of a path component would be issues with quoting and backslash as a path separator on Windows
4382020-09-09T19:06:12 <luke-jr> hmm
4392020-09-09T19:07:05 *** melande1 has quit IRC
4402020-09-09T19:07:17 <luke-jr> "It would have been Gentoo Linux with the wallet files on an NTFS partition." lol totally unexpected
4412020-09-09T19:07:19 *** melande1 has joined #bitcoin-core-dev
4422020-09-09T19:07:25 <luke-jr> I doubt the other guy has the same setup tho
4432020-09-09T19:07:30 <gwillen> iiiiiinteresting
4442020-09-09T19:07:54 <gwillen> could be an issue in the NTFS driver, that thing was always marked 'experimental'
4452020-09-09T19:07:58 *** Talkless has quit IRC
4462020-09-09T19:08:10 <luke-jr> what's the chance the other guy had Linux+NTFS tho
4472020-09-09T19:08:12 <achow101> luke-jr: yeah, other guy is Win 10
4482020-09-09T19:08:27 <achow101> could be a NTFS issue
4492020-09-09T19:09:39 <luke-jr> seems unlikely
4502020-09-09T19:09:59 <luke-jr> it's not like Windows and Linux share the same NTFS code
4512020-09-09T19:10:07 <achow101> if he only see the problem on knots, then we could probably find the problem by looking at the diff?
4522020-09-09T19:10:29 <luke-jr> achow101: the second guy had it on Core
4532020-09-09T19:10:35 <luke-jr> I think
4542020-09-09T19:10:41 <gwillen> any chance the win 10 guy is using WSL or something weird like that?
4552020-09-09T19:11:34 <luke-jr> maybe if the Linux guy was using Captive NTFS.. he did say it was a long time ago
4562020-09-09T19:12:15 <gwillen> in that case why doesn't every windows user see it, though
4572020-09-09T19:12:27 <luke-jr> even the same user couldn't reproduce :/
4582020-09-09T19:16:06 *** melande1 has quit IRC
4592020-09-09T19:16:20 *** melande1 has joined #bitcoin-core-dev
4602020-09-09T19:18:06 *** jb55 has quit IRC
4612020-09-09T19:19:03 *** b10c has joined #bitcoin-core-dev
4622020-09-09T19:24:52 *** davterra has quit IRC
4632020-09-09T19:25:28 *** davterra has joined #bitcoin-core-dev
4642020-09-09T19:31:21 *** mrostecki has quit IRC
4652020-09-09T19:34:22 *** filchef has quit IRC
4662020-09-09T19:35:41 *** mrostecki has joined #bitcoin-core-dev
4672020-09-09T19:58:47 <phantomcircuit> anybody know how many transaction outputs are in the chain? (not utxo, txo)
4682020-09-09T20:00:41 *** arowser has quit IRC
4692020-09-09T20:00:52 <sipa> years ago it was half a billion iirc
4702020-09-09T20:00:57 *** arowser has joined #bitcoin-core-dev
4712020-09-09T20:06:42 *** Guyver2 has quit IRC
4722020-09-09T20:07:09 *** andreacab has quit IRC
4732020-09-09T20:08:55 *** Guest82 has joined #bitcoin-core-dev
4742020-09-09T20:10:32 *** Guest82 has left #bitcoin-core-dev
4752020-09-09T20:10:57 *** melande1 has quit IRC
4762020-09-09T20:11:32 *** melande1 has joined #bitcoin-core-dev
4772020-09-09T20:12:36 *** andreacab has joined #bitcoin-core-dev
4782020-09-09T20:16:57 *** andreacab has quit IRC
4792020-09-09T20:18:27 *** ThunderChicken1 has quit IRC
4802020-09-09T20:18:32 <andytoshi> i have a simple script i used for my mimblewimble presentation, i can get this number in a couple hours
4812020-09-09T20:18:50 <andytoshi> it seems to be taking 2-3 seconds per 100 blocks to scan, i don't remember it being so slow
4822020-09-09T20:23:23 *** kristapsk has quit IRC
4832020-09-09T20:28:07 *** Deacyde has quit IRC
4842020-09-09T20:30:06 *** blardo has joined #bitcoin-core-dev
4852020-09-09T20:32:58 *** melande1 has quit IRC
4862020-09-09T20:33:20 *** melande1 has joined #bitcoin-core-dev
4872020-09-09T20:36:50 <phantomcircuit> andytoshi, i've rigged up rescanblockchain to tell me
4882020-09-09T21:00:01 *** blardo has quit IRC
4892020-09-09T21:00:05 <andytoshi> ok cool. i had rigged the `getblock` rpc to dump the number of txouts per block and was using bash from there, but this is pretty brutal ... in the 40 minutes since i last spoke i'm up to block 200k. so it'll finish tonight :P
4902020-09-09T21:00:51 <sipa> andytoshi: it may not... there are barely any transactions before 200k i think
4912020-09-09T21:00:57 *** melande1 has quit IRC
4922020-09-09T21:01:18 *** melande1 has joined #bitcoin-core-dev
4932020-09-09T21:02:02 <aj> maybe update the coin stats index from #19521 and use that?
4942020-09-09T21:02:06 <andytoshi> hmm, so, i definitely did this in fall 2016 for scaling bitcoin milan and it only took a few hours
4952020-09-09T21:02:13 <andytoshi> i guess it's been 4 years :P
4962020-09-09T21:02:16 <gribble> https://github.com/bitcoin/bitcoin/issues/19521 | Coinstats Index (without UTXO set hash) by fjahr · Pull Request #19521 · bitcoin/bitcoin · GitHub
4972020-09-09T21:03:11 <aj> andytoshi: (maybe rusty's bitcoin-iterate is faster?)
4982020-09-09T21:04:17 <sipa> 7316308 transactions up to block 200000
4992020-09-09T21:04:40 <sipa> out of 566745810 in total
5002020-09-09T21:05:09 <sipa> phantomcircuit: given that there have been more transactions now than my claimed earlier historical number for the total txouts, you can safely disregard it
5012020-09-09T21:05:15 <yanmaani> luke-jr: Maybe worth adding a check for it?
5022020-09-09T21:05:28 <yanmaani> "if wallet.dat doesn't exist and allet.dat does, show a message box"
5032020-09-09T21:06:29 <yanmaani> "Hi, a very rare bug has occured. We would be happy if you could email us at asd@asd.com and tell us what filesystem drivers you're using. To fix it, open that folder and rename allet.dat again."
5042020-09-09T21:06:39 <yanmaani> bit hacky though
5052020-09-09T21:07:57 *** promag has quit IRC
5062020-09-09T21:08:21 *** promag has joined #bitcoin-core-dev
5072020-09-09T21:11:59 <phantomcircuit> i think we've regressed on IBD somewhere, i have a server that's comically overpowered and there doesn't seem to be anything that's bottlenecking
5082020-09-09T21:13:24 <phantomcircuit> running steady at about 100mbps cpu and disk basically idle on a 1gbps connection
5092020-09-09T21:14:15 <sipa> phantomcircuit: do you have good peers to sync from?
5102020-09-09T21:14:56 <sipa> the stalling detection logic can kick out the worst peers, but whether you get actually good ones can be hit or miss
5112020-09-09T21:18:34 <yanmaani> what's usually the bottleneck for IBD? DB sync?
5122020-09-09T21:18:57 *** melande1 has quit IRC
5132020-09-09T21:19:10 <aj> phantomcircuit: i often find i'm stuck on block X from a slow peer, while the other peers are on block X+500 or so
5142020-09-09T21:19:20 *** melande1 has joined #bitcoin-core-dev
5152020-09-09T21:20:23 <sipa> yanmaani: depends... with lots of cache it's either network or (in-memory) utxo datastructure maintenance; with low cache it can be disk I/O
5162020-09-09T21:20:52 <phantomcircuit> sipa, it must be the eviction logic cause im sure it would otherwise be network limited
5172020-09-09T21:21:33 *** maurits1 has joined #bitcoin-core-dev
5182020-09-09T21:21:40 <yanmaani> how much disk I/O do you need? It's just 300gb or so right?
5192020-09-09T21:22:02 <aj> yanmaani: disk io is mostly updating the utxo set, which is mitigated by cache
5202020-09-09T21:22:19 <yanmaani> Can't you disable disk IO during IBD for utxo set?
5212020-09-09T21:22:33 <sipa> yanmaani: yes, by making your cache big enough for the entire utxo set :)
5222020-09-09T21:22:53 <sipa> which is 8 GB or so
5232020-09-09T21:23:06 <yanmaani> No I mean can't you turn off DB sync and so?
5242020-09-09T21:23:14 <yanmaani> Or will it just need to spill to disk regardless?
5252020-09-09T21:23:29 <sipa> well the UTXOs need to be stored somewhere!
5262020-09-09T21:23:37 <sipa> how will you validate transactions otherwise?
5272020-09-09T21:23:42 <yanmaani> yeah, but there's no need to sync the database
5282020-09-09T21:23:54 <yanmaani> You can have MongoDB tier safety
5292020-09-09T21:24:02 <yanmaani> (during IBD)
5302020-09-09T21:24:05 <aj> you have to have a database, it can be in memory or on disk; if it's in memory, it's in cache
5312020-09-09T21:24:19 <sipa> if you set the cache big enough to keep the entire utxo set in memory, there will be no database I/O whatsoever during IBD
5322020-09-09T21:24:47 <sipa> and it'll be flushed once at the end
5332020-09-09T21:24:58 *** andreacab has joined #bitcoin-core-dev
5342020-09-09T21:26:37 *** Dean_Guss has quit IRC
5352020-09-09T21:27:01 *** Dean_Guss has joined #bitcoin-core-dev
5362020-09-09T21:29:45 *** andreacab has quit IRC
5372020-09-09T21:31:25 *** brianhoffman has quit IRC
5382020-09-09T21:31:47 *** b10c has quit IRC
5392020-09-09T21:35:18 <phantomcircuit> yanmaani, if you set the dbcache high enough you will only write to disk once when you shutdown the node
5402020-09-09T21:37:13 <yanmaani> If I set it say 99% of the way, will I notice a sharp slowdown, or is it smart enough to cache as much as possible?
5412020-09-09T21:39:22 <sipa> it's a sawtooth function; our cache is kind of a weird mix between a buffer and a cache
5422020-09-09T21:39:34 <sipa> once it fills up, it's written entirely to disk, and cleared
5432020-09-09T21:40:05 <sipa> (the reason for this is an unusual design that lets us remove entries from the cache if they're created and deleted between flushes, without them ever hitting disk)
5442020-09-09T21:40:45 <sipa> and at least years ago, we tried several alternative designs that kept some part in memory when flushing, but this turned out to be always worse
5452020-09-09T21:40:56 <yanmaani> And I'm guessing the database is being interacted with by fwrite() rather than mmap
5462020-09-09T21:41:11 <sipa> it's leveldb
5472020-09-09T21:41:39 <sipa> so whatever leveldb uses, which is a mix (iirc it's all fwrite on 32-bit platforms, and a combination of fwrite and mmap on 64-bit ones)
5482020-09-09T21:41:50 <yanmaani> So it's leveldb but with a custom cache?
5492020-09-09T21:42:14 <sipa> it's probably better to call it an in-memory database, backed by an on-disk leveldb database
5502020-09-09T21:42:38 <sipa> leveldb has its own caching too
5512020-09-09T21:43:19 <yanmaani> wouldn't a file-backed mmap be better?
5522020-09-09T21:43:28 <yanmaani> it's like malloc but with explicit swap handled by the OS
5532020-09-09T21:43:51 <sipa> you're welcome to try, but we're really talking about different layers
5542020-09-09T21:44:17 <sipa> the on-disk caching layer is a byte array
5552020-09-09T21:44:28 <yanmaani> No, I mean isntead of the RAM blob being used for in-ram caching
5562020-09-09T21:44:38 <sipa> there is no RAM blob
5572020-09-09T21:44:52 <sipa> there is an in-memory database, with expanded, efficient, data structures
5582020-09-09T21:44:56 <sipa> not serialized bytes
5592020-09-09T21:45:06 <yanmaani> Isn't the in-memory database in RAM????
5602020-09-09T21:45:14 <sipa> yes, but it's not a blob
5612020-09-09T21:45:17 <sipa> no need to yell
5622020-09-09T21:45:27 <yanmaani> It's several mallocs?
5632020-09-09T21:45:31 <sipa> yes
5642020-09-09T21:46:08 <yanmaani> so, wouldn't it make more sense to replace them with backed mmaps that you never flush? Then the OS would have a lot more liberty to optimize
5652020-09-09T21:46:14 <yanmaani> than if you force it into RAM
5662020-09-09T21:46:20 <sipa> seriouysly, you're welcome to try
5672020-09-09T21:46:29 <sipa> i've spent months on optizing that stuff
5682020-09-09T21:47:02 <sipa> it's a highly unusual design, but yes, based on the experiments we did back then, it works very well
5692020-09-09T21:47:09 <yanmaani> huh
5702020-09-09T21:48:15 <sipa> the unusual part is that the UTXOs really have a create-lookuponce-deleteimmediate cycle
5712020-09-09T21:48:19 <sipa> which is very strange for databases
5722020-09-09T21:48:50 <sipa> usual things aren't designed to take advantage of the degree to which looked up entries are immediately deleted
5732020-09-09T21:49:58 <sipa> (and they'll instead create some sort of log that contains the creation and deletion, which still get written to disk at flush time)
5742020-09-09T21:50:02 *** kristapsk has joined #bitcoin-core-dev
5752020-09-09T21:50:29 <sipa> by having an allocation per entry, you can just throw it away instantly when spent, and forget about its existence entirely
5762020-09-09T21:51:17 <sipa> if you have a few hundred MB or more of cache, it means most UTXOs never hit disk at all
5772020-09-09T21:52:05 <yanmaani> Wouldn't mmaps do this nearly as efficiently? Or is the OS too eager to flush changes?
5782020-09-09T21:52:16 <sipa> sigh
5792020-09-09T21:52:32 <sipa> you're talking about a different layer
5802020-09-09T21:52:47 <yanmaani> No, I mean that the malloc is replaced by a mmap
5812020-09-09T21:53:03 <yanmaani> And the mmap'd file is then treated like a RAM buffer of 8 GB
5822020-09-09T21:53:06 <sipa> then you'd get inconsistent state on disk in case of a crash
5832020-09-09T21:53:14 <yanmaani> Yeah, is that a problem?
5842020-09-09T21:53:19 <sipa> yes
5852020-09-09T21:53:24 <yanmaani> Can't you just remove the UTXO state in case of a crash?
5862020-09-09T21:53:29 <yanmaani> at least during IBD
5872020-09-09T21:53:32 <sipa> and sync from scratch? :o
5882020-09-09T21:53:42 <yanmaani> if you make it fast enough it should be a gain on net
5892020-09-09T21:53:57 <yanmaani> and dropping ACID guarantees and giving it the MongoDB treatment seems like it would make things faster
5902020-09-09T21:53:59 <sipa> in pruned mode, you'd need to start over redownloading even
5912020-09-09T21:54:16 <yanmaani> yeah, that's true. For pruned mode, you'd need to make sure it was synced properly.
5922020-09-09T21:54:58 <yanmaani> Although if you're substituting malloc() for mmap() of a temporary file, isn't the persistence as good? "The synced stuff stays, the stuff in RAM doesn't"
5932020-09-09T21:55:31 <sipa> there is no guarantee that mmap flushing happens in the same order as writes
5942020-09-09T21:55:38 <sipa> is there?
5952020-09-09T21:57:58 <yanmaani> no
5962020-09-09T21:58:04 <yanmaani> if it crashes, your mmap will be garbage
5972020-09-09T21:58:14 <yanmaani> but if you're using it to substitute malloc it should be fine
5982020-09-09T21:58:22 <yanmaani> since there's no expectation malloc persists on crash
5992020-09-09T21:58:34 <sipa> ah, i see
6002020-09-09T22:01:36 <sipa> what advantages would this have? if used with the same cache size as you'd use now, it wouldn't be any faster or have other advantages i think
6012020-09-09T22:02:03 <sipa> it'd permit you to make a cache larger than your ram, which may or may not be better
6022020-09-09T22:02:11 <sipa> depending on how fast disk is etc
6032020-09-09T22:02:39 <yanmaani> If used with the same cache size as you have now, it's roughly identical, but uses less RAM/is more fair
6042020-09-09T22:02:51 *** lightlike has quit IRC
6052020-09-09T22:02:51 <yanmaani> (OS can swap it out as it needs if there's a deficit of RAM)
6062020-09-09T22:02:57 <yanmaani> if used with the max cache size*
6072020-09-09T22:03:09 <sipa> that assumes the OS can predict better what's useful to have cached
6082020-09-09T22:03:26 <yanmaani> it has some caching algorithm on a block level, yes
6092020-09-09T22:03:45 <yanmaani> and users who are using zram/zswap will benefit from compression
6102020-09-09T22:03:57 *** melande1 has quit IRC
6112020-09-09T22:03:57 <yanmaani> it'll avoid sync disk writes in the cases where cache is too small
6122020-09-09T22:03:58 <sipa> sure, but it doesn't know for example that after deleting some UTXO entry it's no longer useful to keep it around
6132020-09-09T22:04:23 <yanmaani> after deleting the utxo entry, the ram is filled with something else surely?
6142020-09-09T22:04:40 <yanmaani> (or it's never touched again, in which case the OS won't give it a very high priority)
6152020-09-09T22:04:42 <sipa> at some point, sure
6162020-09-09T22:04:44 *** melande1 has joined #bitcoin-core-dev
6172020-09-09T22:05:07 <sipa> anyway, you're welcome to try and benchmark :)
6182020-09-09T22:06:33 <yanmaani> yeah. Where is the cache?
6192020-09-09T22:06:36 <yanmaani> i.e. what file
6202020-09-09T22:06:45 <yanmaani> is it src/index/*/
6212020-09-09T22:07:03 <sipa> CCoinsViewCache in src/coins.h
6222020-09-09T22:09:58 <yanmaani> right, thanks!
6232020-09-09T22:13:21 <luke-jr> mallocs can get swapped out too..
6242020-09-09T22:13:54 <yanmaani> Only if you have swap enabled
6252020-09-09T22:13:59 <yanmaani> Otherwise it'll go straight to thrashing
6262020-09-09T22:14:13 <yanmaani> With a file-backed mmap, it can flush the pages to disk without consuming your swap
6272020-09-09T22:14:41 <sipa> yanmaani: it would add I/O though, because the OS will start writing dirty pages from the mmap to disk, and then you'll read them again and write them again when flushing to the "real" database on disk
6282020-09-09T22:14:59 <sipa> though that wouldn't be I/O on the critical latency path
6292020-09-09T22:15:07 *** jb55 has joined #bitcoin-core-dev
6302020-09-09T22:15:27 *** mdunnio has quit IRC
6312020-09-09T22:16:50 <yanmaani> yes, but so does normal thrashing
6322020-09-09T22:17:25 <sipa> if the cache is so large that it gets swapped out to disk, you're better off picking a smaller cache
6332020-09-09T22:17:27 <luke-jr> yanmaani: did you see my recent PR?
6342020-09-09T22:17:48 <yanmaani> there's two options with malloc: either swap (if that's enabled), or thrashing (swap out libc). With mmap, you can also flush it
6352020-09-09T22:17:57 *** tryphe_ has joined #bitcoin-core-dev
6362020-09-09T22:18:02 <yanmaani> sipa: not necessarily - it might figure out which bits aren't so useful, and swap out those, for a net gain
6372020-09-09T22:18:05 <luke-jr> #19873
6382020-09-09T22:18:07 <gribble> https://github.com/bitcoin/bitcoin/issues/19873 | [WIP] Flush dbcache early if system is under memory pressure by luke-jr · Pull Request #19873 · bitcoin/bitcoin · GitHub
6392020-09-09T22:19:01 <yanmaani> That might also work. I don't know which approach is better.
6402020-09-09T22:19:03 <sipa> yanmaani: given that every piece of data in the cache is accessed exactly once - when it's spent, i don't see how the OS could predict what is useful and what isn't
6412020-09-09T22:19:31 <yanmaani> I suppose I'll have to benchmark it
6422020-09-09T22:19:43 <sipa> yeah, it'd be interesting to know
6432020-09-09T22:19:43 *** tryphe has quit IRC
6442020-09-09T22:19:55 <sipa> you'll need some mmap-backed allocator i guess
6452020-09-09T22:20:08 <luke-jr> I think a more likely improvement would be to flag cache entries rather than delete them, when writing to db
6462020-09-09T22:20:33 <sipa> luke-jr: ?
6472020-09-09T22:20:38 <yanmaani> I wonder if it'd make more sense to write everything to DB and have it in some extremely lax sync mode
6482020-09-09T22:20:46 <yanmaani> so, take out the cache, and set the DB to MongoDB mode
6492020-09-09T22:20:49 <luke-jr> sipa: after flushing changes to db, keep them in memory in case they're read soon
6502020-09-09T22:20:57 <yanmaani> write during IBD, then flush when synced
6512020-09-09T22:20:59 <sipa> luke-jr: i tried that
6522020-09-09T22:20:59 <luke-jr> flag them so you know they don't need to be written anymore
6532020-09-09T22:21:22 <luke-jr> sipa: why didn't it work?
6542020-09-09T22:21:34 <sipa> luke-jr: at least a few years ago, it will never a win; the reason is that there is less memory available to exploit the "newly created entries that get deleted before ever hitting disk"
6552020-09-09T22:22:08 <luke-jr> sipa: you'd delete the flagged entries when you need more space?
6562020-09-09T22:22:39 <sipa> luke-jr: yes, i believe i tried something like that
6572020-09-09T22:22:58 <luke-jr> I don't see how this can be a lose :/
6582020-09-09T22:23:19 <sipa> where the flushing is done in two tiers; in one, you'd flush everything, but keep the most recently created half around
6592020-09-09T22:23:35 <sipa> and in the second tier, when the memory is full, delete all non-dirty entries
6602020-09-09T22:23:51 <sipa> luke-jr: because of extra CPU to walk the cache and find things to delete
6612020-09-09T22:24:00 *** melande1 has quit IRC
6622020-09-09T22:24:11 <luke-jr> std::move it to a second cache? :x
6632020-09-09T22:24:42 <sipa> there are definitely more combinations that could be tried, not claiming it's a certain loss
6642020-09-09T22:24:51 <sipa> but after trying half a dozen things, i think it was time to give up :)
6652020-09-09T22:25:03 <sipa> it may also depend on relative speeds of RAM/CPU/disk
6662020-09-09T22:25:28 <sipa> this was also pre-pertxout that was added in 0.15; that may have changed things
6672020-09-09T22:25:46 <luke-jr> hmm
6682020-09-09T22:25:54 *** melande1 has joined #bitcoin-core-dev
6692020-09-09T22:26:13 <sipa> i did have a design a few years ago that i'd like to get back to at some point, which would permit flushing in the background without invalidating on-disk cache
6702020-09-09T22:26:19 <phantomcircuit> sipa, nvm for some reason my gateway<->modem was in 100 not 1000
6712020-09-09T22:26:21 <phantomcircuit> <.<
6722020-09-09T22:26:22 <phantomcircuit> >.>
6732020-09-09T22:26:22 <sipa> eh, on-disk storage
6742020-09-09T22:26:42 <luke-jr> hmmmm
6752020-09-09T22:27:00 <sipa> so you could be continuously writing the oldest entries, outside of the latency critical path
6762020-09-09T22:27:19 <sipa> though it'd need extra memory to keep things ordered
6772020-09-09T22:27:44 <yanmaani> Is std::unordered_map really the fastest in-memory kv store around?
6782020-09-09T22:27:49 <sipa> it's nontrivial to make it work correctly with reorgs etc though, but not impossible, if i remember
6792020-09-09T22:28:43 <sipa> yanmaani: it's not
6802020-09-09T22:29:50 <yanmaani> But it's advantageous for some other reason? Or is it just being used for some small part?
6812020-09-09T22:31:40 <sipa> i think people have tried some variations
6822020-09-09T22:32:00 <sipa> the biggest differency would come from using different allocation strategies, i think
6832020-09-09T22:32:14 <sipa> this was tried before though: https://github.com/bitcoin/bitcoin/pull/16801
6842020-09-09T22:32:17 <sipa> #16801
6852020-09-09T22:32:19 <gribble> https://github.com/bitcoin/bitcoin/issues/16801 | faster & less memory for sync: bulk pool allocator for node based containers by martinus · Pull Request #16801 · bitcoin/bitcoin · GitHub
6862020-09-09T22:32:48 <achow101> how do I make a const unsigned char* into a span?
6872020-09-09T22:33:08 <sipa> achow101: do you have its length?
6882020-09-09T22:33:13 <achow101> yes
6892020-09-09T22:33:27 <sipa> Span<const unsigned char>(ptr, len) should work
6902020-09-09T22:33:53 <achow101> ah, thanks
6912020-09-09T22:34:11 <sipa> post c++17 we can add type inference, and you can use Span(ptr, len)
6922020-09-09T22:34:14 *** kristapsk has quit IRC
6932020-09-09T22:34:34 <luke-jr> doesn't C++17 include std::span anyway? :P
6942020-09-09T22:34:36 *** kristapsk has joined #bitcoin-core-dev
6952020-09-09T22:34:44 <sipa> luke-jr: no, that's only in c++20
6962020-09-09T22:34:54 <sipa> achow101: if you're passing to a function that takes a Span<const unsigned char> already, you can use fn({ptr, len})
6972020-09-09T22:34:57 <luke-jr> oh :x
6982020-09-09T22:35:11 <achow101> sipa: even better
6992020-09-09T22:35:21 <sipa> or {beginptr, endptr}
7002020-09-09T22:43:54 *** sr_gi6 has quit IRC
7012020-09-09T22:44:02 <jb55> is there something in 0.20.0 -> 0.20.1 that would cause it to redownload the blockchain? trying to figure out why it's doing that after I upgraded my kernel+bitcoin. no configs changed ...
7022020-09-09T22:44:23 *** sr_gi has joined #bitcoin-core-dev
7032020-09-09T22:44:26 <jb55> maybe this ? https://jb55.com/s/a8e916c5b6f0404b.txt
7042020-09-09T22:46:55 <sipa> jb55: there shouldn't be any changes relates to that in minor releases
7052020-09-09T22:47:06 <phantomcircuit> sipa, can confirm i am dumb
7062020-09-09T22:47:09 <jb55> hmm yeah I figured, maybe weird io issue
7072020-09-09T22:49:23 *** vasild has quit IRC
7082020-09-09T22:50:22 *** jb55 has quit IRC
7092020-09-09T22:50:54 *** jb55 has joined #bitcoin-core-dev
7102020-09-09T22:52:11 *** wullon587 has quit IRC
7112020-09-09T22:55:34 *** mdunnio has joined #bitcoin-core-dev
7122020-09-09T22:55:57 *** gzhao408 has quit IRC
7132020-09-09T22:58:14 *** justanotheruser has quit IRC
7142020-09-09T23:00:41 *** mdunnio has quit IRC
7152020-09-09T23:09:54 *** proofofkeags has quit IRC
7162020-09-09T23:11:39 *** proofofkeags has joined #bitcoin-core-dev
7172020-09-09T23:13:50 *** sipa has quit IRC
7182020-09-09T23:16:30 *** sipa has joined #bitcoin-core-dev
7192020-09-09T23:19:14 *** proofofkeags has quit IRC
7202020-09-09T23:20:31 *** promag has quit IRC
7212020-09-09T23:26:28 *** andreacab has joined #bitcoin-core-dev
7222020-09-09T23:28:59 *** melande1 has quit IRC
7232020-09-09T23:29:19 *** melande1 has joined #bitcoin-core-dev
7242020-09-09T23:31:21 *** andreacab has quit IRC
7252020-09-09T23:31:34 *** promag has joined #bitcoin-core-dev
7262020-09-09T23:41:58 *** melande1 has quit IRC
7272020-09-09T23:42:24 *** melande1 has joined #bitcoin-core-dev
7282020-09-09T23:57:57 *** promag has quit IRC
7292020-09-09T23:57:59 *** marcoagner has quit IRC