12020-11-17T00:00:02 *** willmoffat <willmoffat!~willmoffa@84.39.117.57> has quit IRC ()
22020-11-17T00:00:33 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
32020-11-17T00:01:22 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
42020-11-17T00:01:22 <bitcoin-git> [bitcoin] promag opened pull request #20407: rpc: Support -rpcauthfile argument (master...2020-11-rpcauthfile) https://github.com/bitcoin/bitcoin/pull/20407
52020-11-17T00:01:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
62020-11-17T00:09:23 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
72020-11-17T00:23:11 *** tummy <tummy!~tummy@178.239.168.171> has joined #bitcoin-core-dev
82020-11-17T00:23:13 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has quit IRC (Remote host closed the connection)
92020-11-17T00:29:27 <luke-jr> I don't understand why we lost the high_minversion wallet test
102020-11-17T00:32:37 *** cryptapus <cryptapus!~cryptapus@unaffiliated/cryptapus> has joined #bitcoin-core-dev
112020-11-17T00:36:39 <achow101> luke-jr: when was it removed?
122020-11-17T00:40:03 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
132020-11-17T00:43:23 <luke-jr> achow101: when -upgradewallet CLI was dropped IIRC
142020-11-17T00:43:35 <achow101> yeah, I see. in #15761
152020-11-17T00:43:38 <gribble> https://github.com/bitcoin/bitcoin/issues/15761 | Replace -upgradewallet startup option with upgradewallet RPC by achow101 · Pull Request #15761 · bitcoin/bitcoin · GitHub
162020-11-17T00:50:13 <achow101> luke-jr: It might have been removed by mistake when -upgradewallet was removed
172020-11-17T00:50:57 <achow101> The test doesn't really need upgradewallet at all, but the fact that it did likely confused me when removing it
182020-11-17T00:53:04 <achow101> feature_backwards_compatibility kind of does the test, but only really on releases and actual incompatibilities. I guess it would be good to re-add it.
192020-11-17T00:53:28 <achow101> it can even be done without including a wallet.dat file by using createfromdump (after that's merged)
202020-11-17T00:53:40 <luke-jr> that one was forwards compat
212020-11-17T00:54:06 <luke-jr> with some hypothetical future wallet version
222020-11-17T00:57:43 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
232020-11-17T00:59:55 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
242020-11-17T01:01:04 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 272 seconds)
252020-11-17T01:08:27 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th> has joined #bitcoin-core-dev
262020-11-17T01:14:22 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
272020-11-17T01:14:58 *** cryptapus <cryptapus!~cryptapus@unaffiliated/cryptapus> has quit IRC (Quit: Konversation terminated!)
282020-11-17T01:15:45 *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Remote host closed the connection)
292020-11-17T01:16:08 *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
302020-11-17T01:16:20 *** cryptapus <cryptapus!~cryptapus@unaffiliated/cryptapus> has joined #bitcoin-core-dev
312020-11-17T01:24:34 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 260 seconds)
322020-11-17T01:31:01 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Quit: Leaving)
332020-11-17T01:46:56 *** tralfaz <tralfaz!~davterra@94.198.43.106> has joined #bitcoin-core-dev
342020-11-17T01:51:04 *** davterra <davterra!~davterra@94.198.43.74> has quit IRC (Ping timeout: 256 seconds)
352020-11-17T01:53:14 *** m9aq <m9aq!~m9aq@106.37.187.213> has joined #bitcoin-core-dev
362020-11-17T01:58:40 *** bosch-0 <bosch-0!uid472282@gateway/web/irccloud.com/x-bimhjlcpcolfalpi> has joined #bitcoin-core-dev
372020-11-17T02:09:43 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
382020-11-17T02:21:56 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Read error: Connection reset by peer)
392020-11-17T02:22:18 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
402020-11-17T02:23:28 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
412020-11-17T02:25:39 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Read error: Connection reset by peer)
422020-11-17T02:29:11 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
432020-11-17T02:29:59 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
442020-11-17T02:39:02 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
452020-11-17T02:41:09 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 260 seconds)
462020-11-17T02:41:34 *** Moe_Epsilon <Moe_Epsilon!~Moe_Epsil@185.204.1.185> has quit IRC (Remote host closed the connection)
472020-11-17T02:48:08 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (Read error: Connection reset by peer)
482020-11-17T02:49:17 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
492020-11-17T02:51:02 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has joined #bitcoin-core-dev
502020-11-17T03:00:01 *** tummy <tummy!~tummy@178.239.168.171> has quit IRC ()
512020-11-17T03:02:13 *** Guest48480 <Guest48480!~luka@217.146.82.202> has joined #bitcoin-core-dev
522020-11-17T03:23:31 *** dougvann <dougvann!~dougvann@217.146.82.202> has joined #bitcoin-core-dev
532020-11-17T03:29:33 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
542020-11-17T03:34:32 *** S3RK <S3RK!~S3RK@116.118.73.180> has quit IRC (Ping timeout: 256 seconds)
552020-11-17T03:45:22 *** S3RK <S3RK!~S3RK@116.118.73.180> has joined #bitcoin-core-dev
562020-11-17T03:45:47 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
572020-11-17T03:54:09 *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
582020-11-17T03:56:27 *** theChief <theChief!~Mohamed@bb121-6-182-56.singnet.com.sg> has joined #bitcoin-core-dev
592020-11-17T03:57:12 *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 256 seconds)
602020-11-17T04:08:26 *** bosch-0 <bosch-0!uid472282@gateway/web/irccloud.com/x-bimhjlcpcolfalpi> has quit IRC (Quit: Connection closed for inactivity)
612020-11-17T04:20:02 *** nothingmuch_ <nothingmuch_!~nothingmu@unaffiliated/nothingmuch> has joined #bitcoin-core-dev
622020-11-17T04:20:21 *** nothingmuch <nothingmuch!~nothingmu@unaffiliated/nothingmuch> has quit IRC (Quit: ZNC - https://znc.in)
632020-11-17T04:20:27 *** prusnak <prusnak!sid403625@gateway/web/irccloud.com/x-tslnimwlvlwfgivq> has quit IRC (Ping timeout: 272 seconds)
642020-11-17T04:21:37 *** prusnak <prusnak!sid403625@gateway/web/irccloud.com/x-ezsvdnujwchntoda> has joined #bitcoin-core-dev
652020-11-17T04:22:59 *** larryruane <larryruane!uid473749@gateway/web/irccloud.com/x-bqsotlrueovfrfaw> has quit IRC (Ping timeout: 272 seconds)
662020-11-17T04:23:06 *** larryruane <larryruane!uid473749@gateway/web/irccloud.com/x-ebpadwqlxrootpws> has joined #bitcoin-core-dev
672020-11-17T04:36:56 *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Read error: Connection reset by peer)
682020-11-17T04:40:09 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th> has quit IRC (Ping timeout: 260 seconds)
692020-11-17T04:41:59 *** prusnak <prusnak!sid403625@gateway/web/irccloud.com/x-ezsvdnujwchntoda> has quit IRC (Ping timeout: 272 seconds)
702020-11-17T04:42:43 *** prusnak <prusnak!sid403625@gateway/web/irccloud.com/x-yumdjzikgzqapczc> has joined #bitcoin-core-dev
712020-11-17T04:43:39 *** owowo <owowo!~ovovo@91.193.4.68> has joined #bitcoin-core-dev
722020-11-17T04:44:05 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (Read error: Connection reset by peer)
732020-11-17T04:46:50 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
742020-11-17T04:47:10 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 246 seconds)
752020-11-17T04:52:03 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
762020-11-17T04:52:07 *** prusnak <prusnak!sid403625@gateway/web/irccloud.com/x-yumdjzikgzqapczc> has quit IRC (Ping timeout: 272 seconds)
772020-11-17T04:52:34 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
782020-11-17T04:55:41 *** prusnak <prusnak!sid403625@gateway/web/irccloud.com/x-lfcyzjgfjcjtebkp> has joined #bitcoin-core-dev
792020-11-17T04:58:07 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
802020-11-17T05:06:05 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
812020-11-17T05:08:44 *** troygiorshev <troygiorshev!~troygiors@d67-193-140-136.home3.cgocable.net> has quit IRC (Ping timeout: 260 seconds)
822020-11-17T05:09:02 *** troygiorshev <troygiorshev!~troygiors@d67-193-140-136.home3.cgocable.net> has joined #bitcoin-core-dev
832020-11-17T05:09:52 *** ctrlbreak_MAD <ctrlbreak_MAD!~ctrlbreak@159.2.182.106> has joined #bitcoin-core-dev
842020-11-17T05:10:38 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
852020-11-17T05:13:24 *** ctrlbreak <ctrlbreak!~ctrlbreak@159.2.182.106> has quit IRC (Ping timeout: 260 seconds)
862020-11-17T05:16:23 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has quit IRC (Ping timeout: 240 seconds)
872020-11-17T05:19:59 *** Isthmus <Isthmus!sid302307@gateway/web/irccloud.com/x-dgyibcpawhcecoaf> has quit IRC (Ping timeout: 272 seconds)
882020-11-17T05:20:57 *** Isthmus <Isthmus!sid302307@gateway/web/irccloud.com/x-egyhrwljsnapkjej> has joined #bitcoin-core-dev
892020-11-17T05:22:32 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@ppp-223-24-92-243.revip6.asianet.co.th> has joined #bitcoin-core-dev
902020-11-17T05:23:47 *** eragmus <eragmus!sid136308@gateway/web/irccloud.com/x-flqaevhzstzdkxwj> has quit IRC (Ping timeout: 272 seconds)
912020-11-17T05:23:47 *** fjahr <fjahr!sid374480@gateway/web/irccloud.com/x-idmozsqtyjsaymjn> has quit IRC (Ping timeout: 272 seconds)
922020-11-17T05:24:14 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has joined #bitcoin-core-dev
932020-11-17T05:25:02 *** eragmus <eragmus!sid136308@gateway/web/irccloud.com/x-kfnppxbxjcmnhbib> has joined #bitcoin-core-dev
942020-11-17T05:25:43 *** fjahr <fjahr!sid374480@gateway/web/irccloud.com/x-zejehgvppaebqwly> has joined #bitcoin-core-dev
952020-11-17T05:32:39 *** fjahr <fjahr!sid374480@gateway/web/irccloud.com/x-zejehgvppaebqwly> has quit IRC (Ping timeout: 272 seconds)
962020-11-17T05:36:27 *** eragmus <eragmus!sid136308@gateway/web/irccloud.com/x-kfnppxbxjcmnhbib> has quit IRC (Ping timeout: 272 seconds)
972020-11-17T05:37:14 *** eragmus <eragmus!sid136308@gateway/web/irccloud.com/x-igibofjeoqzcptra> has joined #bitcoin-core-dev
982020-11-17T05:39:21 *** fjahr <fjahr!sid374480@gateway/web/irccloud.com/x-bftuodvmfdbwrhhw> has joined #bitcoin-core-dev
992020-11-17T05:42:05 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@ppp-223-24-92-243.revip6.asianet.co.th> has quit IRC (Ping timeout: 240 seconds)
1002020-11-17T05:46:23 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has quit IRC (Ping timeout: 240 seconds)
1012020-11-17T05:51:35 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has joined #bitcoin-core-dev
1022020-11-17T05:57:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1032020-11-17T05:57:03 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c48e788246fc...7c0d412a74ba
1042020-11-17T05:57:04 <bitcoin-git> bitcoin/master d355a30 lontivero: Break circuit earlier
1052020-11-17T05:57:05 <bitcoin-git> bitcoin/master 7c0d412 fanquake: Merge #20405: p2p: avoid calculating onion address checksum when version i...
1062020-11-17T05:57:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1072020-11-17T05:57:21 *** digi_james <digi_james!sid281632@gateway/web/irccloud.com/x-jxyqlpnraydxvprs> has quit IRC (Ping timeout: 272 seconds)
1082020-11-17T05:57:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1092020-11-17T05:57:33 <bitcoin-git> [bitcoin] fanquake merged pull request #20405: p2p: avoid calculating onion address checksum when version is not 3 (master...tinyrefactoring) https://github.com/bitcoin/bitcoin/pull/20405
1102020-11-17T05:57:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1112020-11-17T05:58:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1122020-11-17T05:58:09 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7c0d412a74ba...3457054c61d5
1132020-11-17T05:58:09 <bitcoin-git> bitcoin/master b6121ed Tyler Chambers: swapped "is" for "==" in literal comparison
1142020-11-17T05:58:10 <bitcoin-git> bitcoin/master 3457054 fanquake: Merge #20346: script: modify security-check.py to use "==" instead of "is"...
1152020-11-17T05:58:11 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1162020-11-17T05:58:14 *** digi_james <digi_james!sid281632@gateway/web/irccloud.com/x-luadapapmlcwedbg> has joined #bitcoin-core-dev
1172020-11-17T05:58:28 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1182020-11-17T05:58:28 <bitcoin-git> [bitcoin] fanquake merged pull request #20346: script: modify security-check.py to use "==" instead of "is" for literal comparison (master...literal-comparison-update) https://github.com/bitcoin/bitcoin/pull/20346
1192020-11-17T05:58:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1202020-11-17T06:00:02 *** dougvann <dougvann!~dougvann@217.146.82.202> has quit IRC ()
1212020-11-17T06:03:05 *** TallTim <TallTim!~TallTim@208-107-234-198-dynamic.midco.net> has quit IRC (Ping timeout: 240 seconds)
1222020-11-17T06:08:32 *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has quit IRC (Ping timeout: 260 seconds)
1232020-11-17T06:10:39 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 260 seconds)
1242020-11-17T06:10:40 *** twistedline <twistedline!~twisted@c-73-200-216-219.hsd1.dc.comcast.net> has joined #bitcoin-core-dev
1252020-11-17T06:20:47 *** hsmiths <hsmiths!uid95325@gateway/web/irccloud.com/x-eprdllrvdwdqzdbh> has quit IRC (Ping timeout: 272 seconds)
1262020-11-17T06:21:03 *** hsmiths <hsmiths!uid95325@gateway/web/irccloud.com/x-yfzozmdheoeybubz> has joined #bitcoin-core-dev
1272020-11-17T06:21:03 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has quit IRC (Ping timeout: 240 seconds)
1282020-11-17T06:23:07 *** MaddinSM <MaddinSM!~MaddinSM@185.204.1.185> has joined #bitcoin-core-dev
1292020-11-17T06:28:28 *** kristapsk_ <kristapsk_!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
1302020-11-17T06:30:51 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Quit: Leaving)
1312020-11-17T06:38:38 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has joined #bitcoin-core-dev
1322020-11-17T06:43:29 *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
1332020-11-17T06:44:35 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@ppp-27-55-77-167.revip3.asianet.co.th> has joined #bitcoin-core-dev
1342020-11-17T06:48:03 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
1352020-11-17T06:48:47 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
1362020-11-17T06:59:05 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@ppp-27-55-77-167.revip3.asianet.co.th> has quit IRC (Ping timeout: 240 seconds)
1372020-11-17T07:07:38 *** dongcarl <dongcarl!~dongcarl@unaffiliated/dongcarl> has quit IRC (Quit: Ping timeout (120 seconds))
1382020-11-17T07:07:57 *** dongcarl <dongcarl!~dongcarl@unaffiliated/dongcarl> has joined #bitcoin-core-dev
1392020-11-17T07:29:58 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th> has joined #bitcoin-core-dev
1402020-11-17T07:36:09 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th> has quit IRC (Ping timeout: 272 seconds)
1412020-11-17T07:50:32 *** m9aq <m9aq!~m9aq@106.37.187.213> has quit IRC (Quit: m9aq)
1422020-11-17T08:00:03 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has quit IRC (Ping timeout: 240 seconds)
1432020-11-17T08:14:33 *** kcalvinalvin <kcalvinalvin!~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com> has quit IRC (Ping timeout: 256 seconds)
1442020-11-17T08:15:32 *** kcalvinalvin <kcalvinalvin!~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com> has joined #bitcoin-core-dev
1452020-11-17T08:33:00 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has joined #bitcoin-core-dev
1462020-11-17T09:00:01 *** MaddinSM <MaddinSM!~MaddinSM@185.204.1.185> has quit IRC ()
1472020-11-17T09:04:43 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has quit IRC (Ping timeout: 240 seconds)
1482020-11-17T09:16:28 *** AdulrunaRedviva <AdulrunaRedviva!c3d69d22@195.214.157.34> has joined #bitcoin-core-dev
1492020-11-17T09:40:43 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th> has joined #bitcoin-core-dev
1502020-11-17T09:56:50 *** hardaker <hardaker!~hardaker@193.56.252.12> has joined #bitcoin-core-dev
1512020-11-17T10:08:49 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
1522020-11-17T10:12:23 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
1532020-11-17T10:12:24 *** vasild_ is now known as vasild
1542020-11-17T10:21:18 *** MarcoFalke <MarcoFalke!~none@198.12.116.246> has quit IRC (Quit: ZNC 1.7.1 - https://znc.in)
1552020-11-17T10:23:06 *** MarcoFalke <MarcoFalke!~none@198.12.116.246> has joined #bitcoin-core-dev
1562020-11-17T10:47:40 *** promag <promag!~promag@188.251.225.32> has joined #bitcoin-core-dev
1572020-11-17T10:50:56 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1582020-11-17T10:54:58 *** promag_ <promag_!~promag@188.251.225.32> has joined #bitcoin-core-dev
1592020-11-17T10:54:59 *** promag <promag!~promag@188.251.225.32> has quit IRC (Read error: Connection reset by peer)
1602020-11-17T10:57:33 *** promag <promag!~promag@188.251.225.32> has joined #bitcoin-core-dev
1612020-11-17T10:57:54 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th> has quit IRC (Ping timeout: 265 seconds)
1622020-11-17T11:00:48 *** promag_ <promag_!~promag@188.251.225.32> has quit IRC (Ping timeout: 265 seconds)
1632020-11-17T11:18:26 *** Johathan56Kovace <Johathan56Kovace!~Johathan5@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
1642020-11-17T11:24:07 *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-iymvwrqjwidgojhb> has quit IRC (Quit: Connection closed for inactivity)
1652020-11-17T11:43:38 *** Guest48480 <Guest48480!~luka@217.146.82.202> has quit IRC (Remote host closed the connection)
1662020-11-17T11:45:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1672020-11-17T11:45:05 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3457054c61d5...c463f70fb05e
1682020-11-17T11:45:06 <bitcoin-git> bitcoin/master 9636962 Sishir Giri: [upgradewallet] removed unused warning param
1692020-11-17T11:45:06 <bitcoin-git> bitcoin/master c463f70 MarcoFalke: Merge #20139: Wallet: do not return warnings from UpgradeWallet()
1702020-11-17T11:45:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1712020-11-17T11:45:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1722020-11-17T11:45:30 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20139: Wallet: do not return warnings from UpgradeWallet() (master...upgradewallet_rpc_cleanup) https://github.com/bitcoin/bitcoin/pull/20139
1732020-11-17T11:45:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1742020-11-17T11:54:33 *** belcher_ is now known as belcher
1752020-11-17T12:00:02 *** hardaker <hardaker!~hardaker@193.56.252.12> has quit IRC ()
1762020-11-17T12:02:33 *** FredC <FredC!~FredC@178.239.168.171> has joined #bitcoin-core-dev
1772020-11-17T12:03:25 *** promag <promag!~promag@188.251.225.32> has quit IRC (Remote host closed the connection)
1782020-11-17T12:05:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1792020-11-17T12:05:22 <bitcoin-git> [gui] MarcoFalke merged pull request #96: Slight improve create wallet dialog (master...2020/09/create_wallet) https://github.com/bitcoin-core/gui/pull/96
1802020-11-17T12:05:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1812020-11-17T12:05:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1822020-11-17T12:05:40 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c463f70fb05e...e7986c51bc7a
1832020-11-17T12:05:41 <bitcoin-git> bitcoin/master 5bff825 Sjors Provoost: [gui] create wallet: smarter checkbox toggling
1842020-11-17T12:05:41 <bitcoin-git> bitcoin/master c99d6f6 Sjors Provoost: gui: create wallet: name placeholder
1852020-11-17T12:05:42 <bitcoin-git> bitcoin/master ac64cec Sjors Provoost: gui: create wallet: add advanced section
1862020-11-17T12:05:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1872020-11-17T12:22:42 *** lahwran <lahwran!~lahwran@185.163.110.116> has joined #bitcoin-core-dev
1882020-11-17T12:25:27 *** lahwran <lahwran!~lahwran@185.163.110.116> has quit IRC (Remote host closed the connection)
1892020-11-17T12:28:16 *** Johathan56Kovace <Johathan56Kovace!~Johathan5@static.57.1.216.95.clients.your-server.de> has quit IRC (Ping timeout: 240 seconds)
1902020-11-17T12:30:49 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
1912020-11-17T12:35:43 *** promag <promag!~promag@188.250.84.129> has quit IRC (Ping timeout: 272 seconds)
1922020-11-17T12:39:28 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
1932020-11-17T12:43:11 *** per <per!~per@gateway/tor-sasl/wsm> has joined #bitcoin-core-dev
1942020-11-17T12:44:50 *** pinheadmz <pinheadmz!~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
1952020-11-17T12:47:45 *** pinheadm_ <pinheadm_!~pinheadmz@152.89.204.173> has quit IRC (Ping timeout: 272 seconds)
1962020-11-17T12:52:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1972020-11-17T12:52:21 <bitcoin-git> [bitcoin] MarcoFalke pushed 14 commits to master: https://github.com/bitcoin/bitcoin/compare/e7986c51bc7a...80e32e120ee4
1982020-11-17T12:52:22 <bitcoin-git> bitcoin/master 3f72791 Jon Atack: wallet: fix bug in RPC send options
1992020-11-17T12:52:23 <bitcoin-git> bitcoin/master 6112cf2 Jon Atack: wallet: add CFeeRate ctor doxygen documentation
2002020-11-17T12:52:24 <bitcoin-git> bitcoin/master e21212f Jon Atack: wallet: remove unneeded WALLET_BTC_KB_TO_SAT_B constant
2012020-11-17T12:52:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2022020-11-17T12:52:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2032020-11-17T12:52:40 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20305: wallet: introduce fee_rate sat/vB param/option (master...fee_rate_sat_vb) https://github.com/bitcoin/bitcoin/pull/20305
2042020-11-17T12:52:42 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2052020-11-17T12:53:05 <MarcoFalke> looks like we can ship?
2062020-11-17T12:53:14 <MarcoFalke> Is there anything left other than #20401?
2072020-11-17T12:53:16 <gribble> https://github.com/bitcoin/bitcoin/issues/20401 | qt: Pre-splitoff translations update by laanwj · Pull Request #20401 · bitcoin/bitcoin · GitHub
2082020-11-17T12:55:06 *** geekosaur <geekosaur!~geekosaur@217.146.82.202> has joined #bitcoin-core-dev
2092020-11-17T12:55:29 *** geekosaur is now known as Guest21218
2102020-11-17T12:58:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2112020-11-17T12:58:06 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/80e32e120ee4...831675c8dccf
2122020-11-17T12:58:07 <bitcoin-git> bitcoin/master bb6441b Wladimir J. van der Laan: qt: Pre-splitoff translations update
2132020-11-17T12:58:07 <bitcoin-git> bitcoin/master 831675c fanquake: Merge #20401: qt: Pre-splitoff translations update
2142020-11-17T12:58:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2152020-11-17T12:58:11 <jonatack> MarcoFalke: (thanks!) maybe #20403 after bugfix update this afternoon
2162020-11-17T12:58:13 <gribble> https://github.com/bitcoin/bitcoin/issues/20403 | wallet: upgradewallet fixes, improvements, test coverage by jonatack · Pull Request #20403 · bitcoin/bitcoin · GitHub
2172020-11-17T12:58:17 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th> has joined #bitcoin-core-dev
2182020-11-17T12:58:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2192020-11-17T12:58:26 <bitcoin-git> [bitcoin] fanquake merged pull request #20401: qt: Pre-splitoff translations update (master...2020_11_translations_update) https://github.com/bitcoin/bitcoin/pull/20401
2202020-11-17T12:58:27 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2212020-11-17T12:59:03 <MarcoFalke> jonatack: I don't think this should hold back an rc1
2222020-11-17T12:59:11 <MarcoFalke> It can be included in rc2 if it is ready by then
2232020-11-17T12:59:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2242020-11-17T12:59:26 <bitcoin-git> [bitcoin] ajtowns opened pull request #20408: CConnman: move initialization into Init() (master...202011-connman-fuzz) https://github.com/bitcoin/bitcoin/pull/20408
2252020-11-17T12:59:28 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2262020-11-17T13:00:28 <jonatack> MarcoFalke: sgtm
2272020-11-17T13:05:27 *** AdulrunaRedviva <AdulrunaRedviva!c3d69d22@195.214.157.34> has quit IRC (Remote host closed the connection)
2282020-11-17T13:20:29 *** Landryl <Landryl!~Landryl@ns528256.ip-192-99-10.net> has quit IRC (Quit: The Lounge - https://thelounge.chat)
2292020-11-17T13:23:51 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
2302020-11-17T13:25:31 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
2312020-11-17T13:27:02 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
2322020-11-17T13:30:27 *** Guest21218 <Guest21218!~geekosaur@217.146.82.202> has quit IRC (Remote host closed the connection)
2332020-11-17T13:41:43 *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
2342020-11-17T13:43:16 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th> has quit IRC (Ping timeout: 240 seconds)
2352020-11-17T13:43:34 *** Livestradamus <Livestradamus!~quassel@unaffiliated/livestradamus> has quit IRC (Quit: I'm out.)
2362020-11-17T13:43:57 *** Livestradamus <Livestradamus!~quassel@unaffiliated/livestradamus> has joined #bitcoin-core-dev
2372020-11-17T13:44:45 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 272 seconds)
2382020-11-17T13:48:31 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th> has joined #bitcoin-core-dev
2392020-11-17T13:51:04 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
2402020-11-17T13:51:15 *** Landryl <Landryl!~Landryl@ns528256.ip-192-99-10.net> has joined #bitcoin-core-dev
2412020-11-17T13:54:47 *** Landryl <Landryl!~Landryl@ns528256.ip-192-99-10.net> has quit IRC (Read error: Connection reset by peer)
2422020-11-17T13:57:42 *** Suigintou <Suigintou!~Suigintou@92.223.89.101> has joined #bitcoin-core-dev
2432020-11-17T13:57:52 *** Landryl <Landryl!~Landryl@ns528256.ip-192-99-10.net> has joined #bitcoin-core-dev
2442020-11-17T13:58:12 *** Landryl <Landryl!~Landryl@ns528256.ip-192-99-10.net> has quit IRC (Client Quit)
2452020-11-17T13:59:06 *** Landryl4 <Landryl4!~Landryl@ns528256.ip-192-99-10.net> has joined #bitcoin-core-dev
2462020-11-17T14:00:49 *** Landryl4 <Landryl4!~Landryl@ns528256.ip-192-99-10.net> has quit IRC (Client Quit)
2472020-11-17T14:01:14 *** Landryl4 <Landryl4!~Landryl@ns528256.ip-192-99-10.net> has joined #bitcoin-core-dev
2482020-11-17T14:01:18 *** Landryl4 <Landryl4!~Landryl@ns528256.ip-192-99-10.net> has quit IRC (Client Quit)
2492020-11-17T14:03:17 *** Landryl <Landryl!~Landryl@ns528256.ip-192-99-10.net> has joined #bitcoin-core-dev
2502020-11-17T14:34:24 *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
2512020-11-17T14:35:21 *** ajonas_ <ajonas_!sid385278@gateway/web/irccloud.com/x-texshgghcgszektg> has joined #bitcoin-core-dev
2522020-11-17T14:38:33 *** ajonas_ <ajonas_!sid385278@gateway/web/irccloud.com/x-texshgghcgszektg> has left #bitcoin-core-dev
2532020-11-17T14:39:46 *** ajonas <ajonas!sid385278@gateway/web/irccloud.com/x-fzklvcabnnbgevvy> has joined #bitcoin-core-dev
2542020-11-17T14:44:12 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
2552020-11-17T14:46:41 *** tynes <tynes!~tynes@30.50.237.35.bc.googleusercontent.com> has quit IRC (Ping timeout: 256 seconds)
2562020-11-17T14:47:59 *** tralfaz is now known as davterra
2572020-11-17T14:48:55 *** tynes <tynes!~tynes@30.50.237.35.bc.googleusercontent.com> has joined #bitcoin-core-dev
2582020-11-17T14:50:24 <jnewbery> hi folks. We'll get started on the p2p meeting in 10 minutes
2592020-11-17T14:51:49 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 264 seconds)
2602020-11-17T14:55:54 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
2612020-11-17T14:56:03 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has joined #bitcoin-core-dev
2622020-11-17T14:58:09 <fanquake> ð°ï¸
2632020-11-17T14:58:27 *** tralfaz <tralfaz!~davterra@94.198.43.53> has joined #bitcoin-core-dev
2642020-11-17T14:58:54 *** davterra <davterra!~davterra@94.198.43.106> has quit IRC (Disconnected by services)
2652020-11-17T14:59:04 *** tralfaz is now known as davterra
2662020-11-17T15:00:01 *** Suigintou <Suigintou!~Suigintou@92.223.89.101> has quit IRC ()
2672020-11-17T15:00:13 <jnewbery> #startmeeting
2682020-11-17T15:00:13 <core-meetingbot> Meeting started Tue Nov 17 15:00:13 2020 UTC. The chair is jnewbery. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
2692020-11-17T15:00:13 <core-meetingbot> Available commands: action commands idea info link nick
2702020-11-17T15:00:17 <amiti> hi
2712020-11-17T15:00:21 <jnewbery> #bitcoin-core-dev P2P Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
2722020-11-17T15:00:22 <ariard> hello
2732020-11-17T15:00:27 <jnewbery> amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2
2742020-11-17T15:00:34 <jnewbery> fanquake: your clock is 2 minutes fast
2752020-11-17T15:00:34 <sdaftuar> heya
2762020-11-17T15:00:36 <troygiorshev> hi!
2772020-11-17T15:00:55 <jnewbery> Hi folks. Welcome to the first p2p meeting of 22.0!
2782020-11-17T15:01:00 <ajonas> hi
2792020-11-17T15:01:11 <sdaftuar> we branched off already?
2802020-11-17T15:01:13 <jnewbery> The last 0.21 milestone PRs were merged today, so I guess the branch off is imminent.
2812020-11-17T15:01:15 *** anekdotin <anekdotin!~edwin___@068-187-232-180.res.spectrum.com> has joined #bitcoin-core-dev
2822020-11-17T15:01:40 <jnewbery> We have one proposed topic for today's meeting: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#17-nov-2020.
2832020-11-17T15:01:44 <gribble> https://github.com/bitcoin/bitcoin/issues/17 | listaccounts method · Issue #17 · bitcoin/bitcoin · GitHub
2842020-11-17T15:01:59 <ariard> yep
2852020-11-17T15:02:06 <jnewbery> Before we get to that, I think it'd be useful for us to all share what our goals/priorities are for the 22.0 release cycle.
2862020-11-17T15:02:12 <jonatack> hi
2872020-11-17T15:02:28 <jnewbery> does anyone want to go first?
2882020-11-17T15:02:28 <fanquake> hi
2892020-11-17T15:02:34 <kanzure> hi
2902020-11-17T15:03:28 <sdaftuar> i'd say that i think it'd be great to prioritize erlay now
2912020-11-17T15:03:28 <ariard> Im waiting for https://github.com/bitcoin/bitcoin/pull/19160 landing before to go forward with altnet
2922020-11-17T15:03:47 <ariard> agree with erlay
2932020-11-17T15:04:17 *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-ohnvkcxaiqyauzpi> has joined #bitcoin-core-dev
2942020-11-17T15:04:29 <jonatack> BIP 342 implementation. Erlay. (And non-p2p-specific: multiprocess, coinstats, consensus code separation, assumeUTXO...)
2952020-11-17T15:05:01 <jnewbery> For me, I'd like to make some substantial progress in clarifying the net/net_processing and net_processing/validation interfaces. Those two projects are tracked in #19398 and #20158.
2962020-11-17T15:05:04 <gribble> https://github.com/bitcoin/bitcoin/issues/19398 | Move remaining application layer data to net processing · Issue #19398 · bitcoin/bitcoin · GitHub
2972020-11-17T15:05:06 <gribble> https://github.com/bitcoin/bitcoin/issues/20158 | tree-wide: De-globalize ChainstateManager by dongcarl · Pull Request #20158 · bitcoin/bitcoin · GitHub
2982020-11-17T15:05:17 *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has quit IRC (Read error: Connection reset by peer)
2992020-11-17T15:05:19 <sdaftuar> i plan to work on block-relay-only peering too, though i'm stuck on some annoying addr-relay things that might hold me up
3002020-11-17T15:05:37 <troygiorshev> With the feature freeze now thawed, I wanted to remind everyone about Per-Peer Message logging #19509. It got a lot of attention a while ago and I think it's a feature a lot of people would appreciate. Just needs a bit more review!
3012020-11-17T15:05:40 <gribble> https://github.com/bitcoin/bitcoin/issues/19509 | Per-Peer Message Capture by troygiorshev · Pull Request #19509 · bitcoin/bitcoin · GitHub
3022020-11-17T15:05:49 *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has joined #bitcoin-core-dev
3032020-11-17T15:05:51 <troygiorshev> I'm also paying attention to BIP324 #18242
3042020-11-17T15:05:57 <gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
3052020-11-17T15:06:08 <jonatack> jnewbery: sdaftuar: good stuff. i plan to resume review of those.
3062020-11-17T15:06:31 <jnewbery> thanks jonatack!
3072020-11-17T15:06:42 <jonatack> troygiorshev: thank you, i meant BIP324 :)
3082020-11-17T15:06:43 <ariard> I'm planning to work on a better version of #18797 and so understand better tx-standarndes before going back to package relay
3092020-11-17T15:06:46 <gribble> https://github.com/bitcoin/bitcoin/issues/18797 | Export standard Script flags in bitcoinconsensus by ariard · Pull Request #18797 · bitcoin/bitcoin · GitHub
3102020-11-17T15:07:34 <amiti> in terms of my work: hoping to make progress on 19315 (adding full-relay and block-relay-only to tests), and I'm working on reviving rebroadcast
3112020-11-17T15:07:34 <nehan> hi
3122020-11-17T15:09:00 <jonatack> amiti: will review
3132020-11-17T15:09:02 <jnewbery> ok, anyone want to add any topics before we get onto "Reducing CVE-2020-26895 class of bugs and Tx-standardness" (ariard)
3142020-11-17T15:09:14 <gleb> Hi
3152020-11-17T15:09:16 <aj> touch base on wtxid backport?
3162020-11-17T15:09:44 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th> has quit IRC (Ping timeout: 272 seconds)
3172020-11-17T15:09:56 <jnewbery> hi aj. Yes, let's do that one first
3182020-11-17T15:10:09 <jnewbery> #topic touch base on wtic backport (aj)
3192020-11-17T15:10:09 <core-meetingbot> topic: touch base on wtic backport (aj)
3202020-11-17T15:10:41 <jnewbery> *wtxid
3212020-11-17T15:10:43 <sdaftuar> i'm not sure we should have backported wtxid-relay to the 0.20 branch
3222020-11-17T15:11:09 <aj> #20317 and #20399
3232020-11-17T15:11:11 <gribble> https://github.com/bitcoin/bitcoin/issues/20317 | Backport wtxid orphan fetch to v0.20 by jnewbery · Pull Request #20317 · bitcoin/bitcoin · GitHub
3242020-11-17T15:11:12 <gribble> https://github.com/bitcoin/bitcoin/issues/20399 | Revert "Merge #19606: Backport wtxid relay to v0.20" by MarcoFalke · Pull Request #20399 · bitcoin/bitcoin · GitHub
3252020-11-17T15:11:17 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th> has joined #bitcoin-core-dev
3262020-11-17T15:12:08 <aj> afaik, #19620 which is in 0.19 and 0.20 already does everything we really need wtxid to do backport-wise for taproot
3272020-11-17T15:12:12 <gribble> https://github.com/bitcoin/bitcoin/issues/19620 | Add txids with non-standard inputs to reject filter by sdaftuar · Pull Request #19620 · bitcoin/bitcoin · GitHub
3282020-11-17T15:12:59 <aj> so 20399 is there to revert wtxid relay from 0.20; or 20317 is there to fix up the orphan handling regression if there's a reason to keep it
3292020-11-17T15:13:02 <sdaftuar> (i missed that github discussion, catching up now)
3302020-11-17T15:13:11 <jnewbery> I don't have a strong opinion, but I
3312020-11-17T15:13:51 <jnewbery> 'm curious what has changed since this was discussed in a previous meeting, when people agreed that it should be backported
3322020-11-17T15:14:30 <aj> 19620 imo
3332020-11-17T15:15:41 <anekdotin> great job guys
3342020-11-17T15:15:47 <sdaftuar> (ok caught up)
3352020-11-17T15:16:16 <sdaftuar> i think that knowing that there was a crashing bug in that line of work sort of heightens the sense that backporting a feature is not really a great idea?
3362020-11-17T15:16:53 <sdaftuar> i don't think backporting it was a requirement in the first place, but i saw the reasoning that it was a nice-to-have. but given that it indeed turned out to be risky, i'd say let's drop it, as there's no compelling reason for backport after #19620 either
3372020-11-17T15:16:57 <gribble> https://github.com/bitcoin/bitcoin/issues/19620 | Add txids with non-standard inputs to reject filter by sdaftuar · Pull Request #19620 · bitcoin/bitcoin · GitHub
3382020-11-17T15:17:17 <sdaftuar> so falling back on our principle of only backporting bugfixes seems like the prudent thing
3392020-11-17T15:20:08 <jonatack> A propos, sharing a message from moneyball who mentioned tripling down on testing (bug discovery+fixes) between now and the 0.21 release with all of the new features.
3402020-11-17T15:20:14 *** TallTim <TallTim!~TallTim@184-83-248-206-dynamic.midco.net> has joined #bitcoin-core-dev
3412020-11-17T15:20:36 <jnewbery> sdaftuar: do you think it should be reverted?
3422020-11-17T15:20:39 <sdaftuar> yeah
3432020-11-17T15:21:15 <jnewbery> because we're not confident in the code?
3442020-11-17T15:21:19 <sdaftuar> if 0.21 has some other crashign bug related to wtxid-relay, it'd be great to be able to go back to 0.20.2 or whatever and have it not crash!
3452020-11-17T15:21:32 *** blardo <blardo!~blardo@178.239.168.171> has joined #bitcoin-core-dev
3462020-11-17T15:22:19 <aj> jnewbery: so i think your review beg on oct-20th should've resulted in some sort of a "do we really still need this?" response, rather than silence both here and on the PR -- i think that was the only time it was mentioned in these meetings since 19620
3472020-11-17T15:23:18 <jnewbery> aj: yeah, people agreed in the original meeting that it should have been backported, and then I've raised reviewing the PR in several meetings since then
3482020-11-17T15:23:52 <jnewbery> I don't think the presence of a bug that was caught in review and fixed in the follow up changes the facts, but I can understand that it makes people nervous
3492020-11-17T15:24:35 <jnewbery> so if people want it out, then it should be reverted
3502020-11-17T15:25:20 <jnewbery> #action revert #20317
3512020-11-17T15:25:21 <core-meetingbot> ACTION: revert #20317
3522020-11-17T15:25:23 <gribble> https://github.com/bitcoin/bitcoin/issues/20317 | Backport wtxid orphan fetch to v0.20 by jnewbery · Pull Request #20317 · bitcoin/bitcoin · GitHub
3532020-11-17T15:25:23 <gribble> https://github.com/bitcoin/bitcoin/issues/20317 | Backport wtxid orphan fetch to v0.20 by jnewbery · Pull Request #20317 · bitcoin/bitcoin · GitHub
3542020-11-17T15:26:01 <jnewbery> #topic Reducing CVE-2020-26895 class of bugs and Tx-standardness (ariard)
3552020-11-17T15:26:01 <core-meetingbot> topic: Reducing CVE-2020-26895 class of bugs and Tx-standardness (ariard)
3562020-11-17T15:26:07 <ariard> hello
3572020-11-17T15:26:47 <ariard> first and foremost, I apologize for the previous rounds of discussion on this issue, it was a bit noisy to talk grasp problem right this without this vuln being public
3582020-11-17T15:27:00 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
3592020-11-17T15:28:00 <ariard> for the context, lnd didn't check that counterparty commitment signatures were in the curve order /2
3602020-11-17T15:28:42 <ariard> which means a malicous counterparty was able to feed them with non-relayable witness and thus complete break its security
3612020-11-17T15:29:03 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th> has quit IRC (Ping timeout: 265 seconds)
3622020-11-17T15:29:14 <ariard> because those time-sensitive transactions won't propagate before timelock expiration
3632020-11-17T15:29:29 <ariard> of the HTLCs
3642020-11-17T15:30:21 <ariard> I think the lesson it's not the first time that a LN implementation had issues with tx-standard, CL had some 2y ago IIRC about minimal relay fee
3652020-11-17T15:31:14 <ariard> so it sounds we have this class of vulns concerning any time-sensitive protocols, and how to mitigate it correctly is a bit unclear
3662020-11-17T15:31:30 <luke-jr> be strict on transaction form..
3672020-11-17T15:31:31 <sdaftuar> testmempoolaccept?
3682020-11-17T15:31:34 <aj> testmempoolaccept RPC isn't useful because you don't want to finish signing the tx, i guess?
3692020-11-17T15:31:50 <luke-jr> you can never rely on node/relay policies
3702020-11-17T15:31:51 *** filchef <filchef!~filchef@212.104.97.177> has joined #bitcoin-core-dev
3712020-11-17T15:32:00 <luke-jr> just have to do what you can to reasonably pass them
3722020-11-17T15:32:19 <luke-jr> testmempoolaccept only tells you about your own policy
3732020-11-17T15:32:24 <ariard> aj: my concern with testmempoolaccept its checks are blurred with the fees ones
3742020-11-17T15:32:43 <ariard> but your transaction is okay because you plan to broadcast only in the future
3752020-11-17T15:33:01 <sdaftuar> luke-jr: i agree, but perhaps a belt and suspenders approach where you enforce a strict transaction form and also double-check against testmempoolaccept might be helpful
3762020-11-17T15:33:17 <luke-jr> it might detect bugs I suppose
3772020-11-17T15:33:25 <ariard> also you have a really code architecture thing, LN mobiles won't have a mempool but they need to do the check
3782020-11-17T15:33:25 <sdaftuar> or unexpected changes
3792020-11-17T15:34:01 <sdaftuar> ariard: i think you'll need to specify the problem a bit better if you are assuming not having access to a full node
3802020-11-17T15:34:04 <luke-jr> ariard: it can't be secure without your own full node anyway
3812020-11-17T15:34:06 <sdaftuar> for instance, do you have access to all the inputs?
3822020-11-17T15:34:20 *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
3832020-11-17T15:34:33 <ariard> luke-jr: you might receive the headers from a trusted connection to your full node on your LN node
3842020-11-17T15:34:53 <luke-jr> so you mean you don't have RPC access?
3852020-11-17T15:35:02 <ariard> sdaftuar: I think we should assume no, it's concering any kind of LN clients
3862020-11-17T15:35:06 <luke-jr> too bad we removed the reject message..
3872020-11-17T15:35:16 <sdaftuar> ariard: if no, then isn't this problem hopeless?
3882020-11-17T15:35:38 <ariard> sdaftuar: you have access to the funding utxo of your channel
3892020-11-17T15:35:49 <ariard> always, that's a protocol assumption
3902020-11-17T15:36:04 <sdaftuar> ariard: but if i include an input you don't know about, then you must reject the transaction, because you have no way of knowing if it's valid, let alone standard?
3912020-11-17T15:36:11 <ariard> what you want to verify is the chain of transaction built from this utxo (commitment+HTLC txn) are tx-relay "valid"
3922020-11-17T15:36:46 <ariard> sdaftuar: for commitment transaction the utxo is 2-of-2
3932020-11-17T15:36:50 <luke-jr> ariard: not possible to do reliably..
3942020-11-17T15:37:10 *** kexkey <kexkey!~kexkey@static-198-54-132-91.cust.tzulo.com> has joined #bitcoin-core-dev
3952020-11-17T15:38:01 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 264 seconds)
3962020-11-17T15:38:02 <ariard> luke-jr: at least you should be able to be sure your transaction is accepted by your full-node
3972020-11-17T15:38:04 <luke-jr> nodes will relay what they want; there are no consensus rules forcing relay
3982020-11-17T15:38:26 <luke-jr> ariard: sure
3992020-11-17T15:38:27 <ariard> luke-jr: I finally agree with you on this, it's more a LN-client to its full-node relation we should care about?
4002020-11-17T15:39:13 <luke-jr> ariard: so this part of problem is because you don't necessarily have RPC access, and we no longer support the reject msg?
4012020-11-17T15:40:01 <ariard> luke-jr: I think it's more subtle, you have those LN transactions, that both you and your counterparty must agree on, but ultimately their validity is decided by your full-node
4022020-11-17T15:40:09 <aj> ariard: what good is a commitment tx with a low fee rate that won't be acceptable possibly for months? don't you want to know that your node will (currently) reject that?
4032020-11-17T15:40:37 <luke-jr> hmm, I suppose the TXOs spent in it migth also not be something you want broadcast yet
4042020-11-17T15:40:47 <ariard> aj: in the future we might have fixed-fee commitment transactions and their feerate adjusted by a CPFP+package relay
4052020-11-17T15:40:58 <ariard> but I may jump one step in the reasoning here, hard to see
4062020-11-17T15:41:15 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
4072020-11-17T15:41:30 <aj> ariard: right, but at that point you'd expect testmempoolaccept to support packages
4082020-11-17T15:41:45 <sdaftuar> aj: bold :)
4092020-11-17T15:42:18 <aj> sdaftuar: (easier to implement package testmempoolaccept than package relay anyway?)
4102020-11-17T15:42:32 <ariard> luke-jr: what's concerning is right now we are leaking those policy check directly in the LN spec, but we may should do the reverse and let those tx-relay be ultimaltey defined by LN clients
4112020-11-17T15:42:39 <sdaftuar> aj: fewer DoS vectors to worry about for sure!
4122020-11-17T15:42:53 <glozow> aj: hey guess what
4132020-11-17T15:43:03 <aj> glozow: you already did it??
4142020-11-17T15:43:23 <ariard> aj: yes if this the case, it's more a cod architecture reason, to have a strict transaction form lib
4152020-11-17T15:43:48 <glozow> a little bit, i have a math test this week though, and then i'll send you my draft of package testmempoolaccept
4162020-11-17T15:43:52 <luke-jr> ariard: the spec just needs to be narrow enough that there's a good hope any tx will be accpeted
4172020-11-17T15:44:42 <ariard> aj: we shouldn't require LN clients to have access to all the utxo set, you just care about your channel utxo only, testmempoolaccept assume you have access to the full set rn?
4182020-11-17T15:44:43 <luke-jr> double-checking against your own node makes sense, but ultimately shouldn't be your security check
4192020-11-17T15:45:13 <luke-jr> ariard: to open a channel, you need access to the entire UTXO set to be sure the inputs are valid..
4202020-11-17T15:45:49 <sdaftuar> ariard: oh, yes you're right that testmempoolaccept requires all inputs to be available in mempool or utxo set, so if you're testing validity further down a chain that won't work right now
4212020-11-17T15:45:58 <aj> ariard: i think if you pull some checks out of "here's my full node" into "here's my light library" you'll run the same risk of missing some checks that are actually needed; but ymmv of course
4222020-11-17T15:46:00 <ariard> luke-jr: I see your point, but you might not have access to the UTXO set for the rest of the discussion
4232020-11-17T15:46:08 <ariard> *protocol execution, sorry
4242020-11-17T15:46:54 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 260 seconds)
4252020-11-17T15:47:05 <ariard> aj: yes that's exactly my worry, mempool checks are a bit blurred, and some we are interested with are also inside the script interpreter
4262020-11-17T15:47:14 <aj> ariard: maybe a psbt validator could make more sense, alternatively? partial so you don't need all the inputs or even all the signatures, but still get useful results like "fees look low!" "this is a dust output!" "this signature is wrong!"
4272020-11-17T15:48:06 <aj> ariard: psbts are (probably) common enough that it would justify thorough useful (re)implementation of standardness and consensus and sanity checks
4282020-11-17T15:48:12 <ariard> luke-jr: without entering in a light-client debtate, for LN if you assume people are using light-clients, it's not reason for them not being at least secure on tx-relay checks
4292020-11-17T15:48:18 <ariard> lke layering security reasoning
4302020-11-17T15:48:47 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
4312020-11-17T15:49:19 <jnewbery> ariard: testmempoolaccept does require the full UTXO set, but you could imagine a version where you provide the inputs, like signrawtransaction
4322020-11-17T15:49:21 <sdaftuar> philosophically though there is no such thing as "bitcoin's tx relay rules". i think that's luke's fundamental point (which I agree with)
4332020-11-17T15:49:22 <ariard> aj: only validating the inputs and not the other transaction check like version, number of max outputs
4342020-11-17T15:49:25 <ariard> ?
4352020-11-17T15:49:42 <aj> ariard: validating all the other stuff seems relevant for psbts in general, i think?
4362020-11-17T15:49:53 <luke-jr> ariard: your non-debatable premise is false
4372020-11-17T15:50:10 <ariard> sdaftuar: I finally agree with it, what I'm trying to understand is the margin we might have to make thing better
4382020-11-17T15:50:53 <sdaftuar> i think the best we can do is what luke suggested already: narrow what you accept to a small enough subset that you think will likely to always be relayable now and in the future, and hope for the best.
4392020-11-17T15:51:28 <sdaftuar> testing validity against a bunch of full-node implementations is a nice backup to make sure your code isn't broken or things haven't changed out from under you
4402020-11-17T15:53:02 <aj> sdaftuar: not very robust against hostile peers who have access to your code base to find checks you forgot to implement, though; hard to fuzz test for valid-but-non-standard sigs and the like even, afaik
4412020-11-17T15:53:09 <ariard> I see the point, which means anytime someone is implementing or desinging a L2 protocol you have to open your full-node code and understand those blurred checks
4422020-11-17T15:53:42 <jnewbery> ariard: do you have what you need from this discussion? Anything else you need or could use help with?
4432020-11-17T15:53:52 <ariard> aj: we should assume your counterparty shouldn't be able to observe your full-node implementation or policy, but can we really do this?
4442020-11-17T15:54:44 <ariard> jnewbery: if I'm reworking on a #18797 as a wrapper on top of testmempoolaccept like libconsensus is anyone have strong NACK?
4452020-11-17T15:54:47 <gribble> https://github.com/bitcoin/bitcoin/issues/18797 | Export standard Script flags in bitcoinconsensus by ariard · Pull Request #18797 · bitcoin/bitcoin · GitHub
4462020-11-17T15:55:20 <ariard> for code architecture reason, not making an assumption your LN client has access to a RPC interace
4472020-11-17T15:56:12 <jnewbery> I don't understand what you mean as a 'wrapper on top of testmempoolaccept'
4482020-11-17T15:56:59 <ariard> jnewbery: on top of ATMP, but it sounds we need to be able to pass a partial utxo set first to it
4492020-11-17T15:57:07 <jnewbery> but in any case, we should wrap this up. It's almost endmeeting time.
4502020-11-17T15:57:22 <jnewbery> Any last minute topics before we close?
4512020-11-17T15:57:27 <gleb> Just wanted to let you guys know that #18261 is ready for review (despite Travis being a bit unhappy, fixing that)
4522020-11-17T15:57:27 <sdaftuar> if you mean add package support to testmempoolaccept, i think that would be reasonable
4532020-11-17T15:57:29 <gribble> https://github.com/bitcoin/bitcoin/issues/18261 | Erlay: bandwidth-efficient transaction relay protocol by naumenkogs · Pull Request #18261 · bitcoin/bitcoin · GitHub
4542020-11-17T15:57:36 <sdaftuar> gleb: nice!
4552020-11-17T15:57:40 <ariard> yeah people want to run those LN clients on hardware, and you might not want to run a full-node with full resource on this
4562020-11-17T15:57:47 <ariard> jnewbery: sure, thanks anyone for the discussion
4572020-11-17T15:57:54 <jnewbery> sdaftuar: glozow has a draft implementation of that
4582020-11-17T15:57:59 <aj> gleb: haha, was just checking logs to see if it'd be rude to ask about that
4592020-11-17T15:58:16 <jnewbery> thanks gleb!
4602020-11-17T15:58:17 <ariard> jnewbery: is it coalesing the feerate check ?
4612020-11-17T15:58:34 <jnewbery> ariard: yes, returns feerate for each individual tx and the package
4622020-11-17T15:59:06 <jnewbery> ok, that's time. Thanks all!
4632020-11-17T15:59:08 <jnewbery> #endmeeting
4642020-11-17T15:59:08 <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
4652020-11-17T15:59:09 <core-meetingbot> Meeting ended Tue Nov 17 15:59:08 2020 UTC.
4662020-11-17T15:59:09 <core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-11-17-15.00.moin.txt
4672020-11-17T15:59:14 <ariard> jnewbery: checking if the feerate of the whole package is okay while one of the transaction might be under the mempool min fee
4682020-11-17T16:02:28 <jnewbery> ariard: I believe it would reject the package if any of the txs are below the min feerate (which makes sense while we don't have package relay). That could be changed later
4692020-11-17T16:03:22 <sipa> hi
4702020-11-17T16:03:29 <sipa> i guess i'm a bit late
4712020-11-17T16:03:30 <sdaftuar> sipa: off by one hour?
4722020-11-17T16:03:37 <luke-jr> XD
4732020-11-17T16:03:42 <sipa> actually i just forgot
4742020-11-17T16:04:12 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 272 seconds)
4752020-11-17T16:04:27 <pinheadmz> what time is the p2p meeting in UTC? the event just floated around my calendar due to daylight savings
4762020-11-17T16:05:10 <ariard> jnewbery: right, let do step by step, it's not bad to un-blurred those checks
4772020-11-17T16:06:36 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
4782020-11-17T16:06:52 <ariard> aj: I need to think about your psbt validator suggestion, because the caller being able to select the verification scope, it let you validate counterparty signature without actually to produce yours
4792020-11-17T16:07:33 <ariard> and that's a good thing, for LN, in the happy case you don't have to generate your LN commitment signature
4802020-11-17T16:10:44 <aj> ariard: might be something that's useful elsewhere (hardware wallets, multisig setups in general), which might help it stay maintained
4812020-11-17T16:13:02 *** kljasdfvv <kljasdfvv!~flack@p200300d46f24de00370042481f229b06.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
4822020-11-17T16:14:42 *** kljasdfvv <kljasdfvv!~flack@p200300d46f24de0037c8a8d81a15c016.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
4832020-11-17T16:16:20 *** theChief <theChief!~Mohamed@bb121-6-182-56.singnet.com.sg> has quit IRC ()
4842020-11-17T16:26:30 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
4852020-11-17T16:35:11 <jnewbery> pinheadmz: it's 15:00 UTC on alternate Tuesdays: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings
4862020-11-17T17:08:53 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
4872020-11-17T17:22:58 *** anekdotin <anekdotin!~edwin___@068-187-232-180.res.spectrum.com> has quit IRC (Quit: Leaving)
4882020-11-17T17:32:06 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
4892020-11-17T17:32:41 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
4902020-11-17T17:35:46 *** einyx <einyx!einyx@fsf/member/einyx> has quit IRC (Ping timeout: 246 seconds)
4912020-11-17T17:36:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4922020-11-17T17:36:31 <bitcoin-git> [bitcoin] jnewbery closed pull request #20317: Backport wtxid orphan fetch to v0.20 (0.20...2020-07-v20-wtxid-orphan) https://github.com/bitcoin/bitcoin/pull/20317
4932020-11-17T17:36:32 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4942020-11-17T17:39:47 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
4952020-11-17T17:40:22 *** einyx <einyx!einyx@fsf/member/einyx> has joined #bitcoin-core-dev
4962020-11-17T17:52:19 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
4972020-11-17T17:57:00 *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
4982020-11-17T17:59:30 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 256 seconds)
4992020-11-17T17:59:59 *** shesek <shesek!~shesek@unaffiliated/shesek> has joined #bitcoin-core-dev
5002020-11-17T18:00:01 *** blardo <blardo!~blardo@178.239.168.171> has quit IRC ()
5012020-11-17T18:07:50 *** foxp2 <foxp2!~foxp2@ec2-18-235-230-166.compute-1.amazonaws.com> has joined #bitcoin-core-dev
5022020-11-17T18:14:32 *** twistedline_ <twistedline_!~twisted@c-73-200-216-219.hsd1.dc.comcast.net> has joined #bitcoin-core-dev
5032020-11-17T18:16:49 *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has quit IRC (Ping timeout: 260 seconds)
5042020-11-17T18:22:27 *** dfkt <dfkt!~dfkt@178.162.212.214> has joined #bitcoin-core-dev
5052020-11-17T18:29:55 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
5062020-11-17T18:30:59 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5072020-11-17T18:30:59 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20410: wallet: Do not treat default constructed types as None-type (master...2011-rpcWalletNoneType) https://github.com/bitcoin/bitcoin/pull/20410
5082020-11-17T18:31:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5092020-11-17T18:37:31 <achow101> so branching soon?
5102020-11-17T18:38:06 *** cryptapus <cryptapus!~cryptapus@unaffiliated/cryptapus> has quit IRC (Ping timeout: 272 seconds)
5112020-11-17T18:38:34 *** pinheadmz <pinheadmz!~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net> has quit IRC (Quit: pinheadmz)
5122020-11-17T18:40:35 <MarcoFalke> https://i.redd.it/az0w7m53abb21.png
5132020-11-17T18:41:35 <MarcoFalke> ping wumpus :)
5142020-11-17T18:49:06 *** cryptapus <cryptapus!~cryptapus@jupiter.osmus.org> has joined #bitcoin-core-dev
5152020-11-17T18:50:04 *** pinheadmz <pinheadmz!~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
5162020-11-17T18:50:46 *** miketwenty1 <miketwenty1!~miketwent@ec2-52-73-85-113.compute-1.amazonaws.com> has joined #bitcoin-core-dev
5172020-11-17T18:51:00 <miketwenty1> Q: is there an equivalent gitian.sigs for guix build process?
5182020-11-17T18:52:03 <sipa> i assumed we'd just run the guix build inside gitian, but haven't followed in detail
5192020-11-17T18:56:10 <luke-jr> same here
5202020-11-17T18:56:19 <luke-jr> especially since Guix still requires trusted third-party blobs
5212020-11-17T18:56:33 <miketwenty1> sipa, right now in bitcoin-core repo we have the gitian sigs for non guix process .. but would we have a sigs folder for guix build process or am i thinking about this incorrectly?
5222020-11-17T18:57:02 <achow101> I would expect that we would keep the same assert files and have them in the same repo
5232020-11-17T18:57:05 <luke-jr> miketwenty1: at some point, I expect the gitian descriptors will be rewritten to use Guix instead of Ubuntu, and the depends/ build system will go away
5242020-11-17T18:57:12 <achow101> it would just be a slightly misnamed repo
5252020-11-17T18:57:19 <luke-jr> misnamed?
5262020-11-17T18:57:51 <miketwenty1> i see.. seems like the idea here is gitian build process improves with guix instead of replaces it?
5272020-11-17T18:57:54 <achow101> gitian.sigs wouldn't be strictly tied to gitian because in theory you could produce them without gitian
5282020-11-17T18:58:15 <luke-jr> achow101: in theory you already could :P
5292020-11-17T18:58:25 <achow101> I would expect the gitian descriptors to do the guix build because that makes the transition easier
5302020-11-17T18:58:31 <sipa> once we have guix-based deterministic builds, much of what gitian provides would be technically overkill
5312020-11-17T18:58:36 <luke-jr> miketwenty1: gitian is providing less of the deterministic stuff with guix
5322020-11-17T18:58:54 <sipa> but given that it already exists, and has infrastructure around it, it's probably easier to keep it (and just use guix inside gitian)
5332020-11-17T18:59:40 <achow101> luke-jr: iirc guix can be fully bootstrapped with only trusting a single small blob that is kind of verifiable. but it also takes forever to build everything
5342020-11-17T19:07:16 <wumpus> achow101: MarcoFalke: will do the split-off tomorrow morning (europe time)
5352020-11-17T19:07:37 <MarcoFalke> wumpus: Thanks
5362020-11-17T19:07:44 <achow101> ack
5372020-11-17T19:08:05 <luke-jr> achow101: "a single small blob" is still a blob
5382020-11-17T19:08:21 <luke-jr> and it's not very verifiable
5392020-11-17T19:08:34 <achow101> luke-jr: it can be disassembled and verified
5402020-11-17T19:09:08 <luke-jr> achow101: it's still too big for that
5412020-11-17T19:09:18 <MarcoFalke> I am not sure if it is easier to set up gitian than guix these days
5422020-11-17T19:09:30 *** foxp2 <foxp2!~foxp2@ec2-18-235-230-166.compute-1.amazonaws.com> has quit IRC (Quit: \/\/)
5432020-11-17T19:10:36 <luke-jr> MarcoFalke: I have failed to setup Guix to date
5442020-11-17T19:10:41 <luke-jr> after spending hours on it
5452020-11-17T19:11:39 <MarcoFalke> It will still be easier to set up a debian vm and run the one-line install command for you than to setup gitian on a debian vm
5462020-11-17T19:12:18 <achow101> I have it setup but I don't remember how I did it
5472020-11-17T19:12:22 <luke-jr> "one-line install command" does not get you a trustless setup
5482020-11-17T19:12:45 <luke-jr> achow101: mind you, I refuse to run third-party binaries, and am using ppc64le
5492020-11-17T19:13:15 <MarcoFalke> Ok, then wait for debian to ship guix in the package manager, this will be as trustless as the current gitian build
5502020-11-17T19:13:19 <luke-jr> I suppose it's not entirely fair since I don't have gitian working on ppc64le, and Ubuntu is a huge blob :P
5512020-11-17T19:13:43 <luke-jr> MarcoFalke: I don't use Debian.
5522020-11-17T19:14:11 <MarcoFalke> Our gitian descriptors use debian/ubuntu
5532020-11-17T19:14:18 <luke-jr> inside the VM, yes
5542020-11-17T19:14:58 <MarcoFalke> So if you don't trust them, I doubt you can trust the overall build setup
5552020-11-17T19:15:38 <luke-jr> MarcoFalke: again, Guix is an improvement over Ubuntu, I fully agree with that
5562020-11-17T19:15:53 <luke-jr> but it isn't an alternative for gitian entirely at this point
5572020-11-17T19:16:11 *** DeanWeen <DeanWeen!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
5582020-11-17T19:16:36 <luke-jr> gitian can be setup without trusted binaries (outside the VM)
5592020-11-17T19:19:13 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
5602020-11-17T19:19:23 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Ping timeout: 240 seconds)
5612020-11-17T19:36:35 *** FredC <FredC!~FredC@178.239.168.171> has quit IRC (Remote host closed the connection)
5622020-11-17T19:56:07 *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 246 seconds)
5632020-11-17T19:56:57 *** ajbiz11 <ajbiz11!~ajbiz11@217.146.82.202> has joined #bitcoin-core-dev
5642020-11-17T19:59:08 *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
5652020-11-17T20:00:13 *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
5662020-11-17T20:01:10 *** owowo <owowo!~ovovo@unaffiliated/ovovo> has joined #bitcoin-core-dev
5672020-11-17T20:17:09 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has left #bitcoin-core-dev
5682020-11-17T20:21:10 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
5692020-11-17T20:22:35 *** syperf <syperf!~danie@2001:8a0:ba80:1a01:1c24:aaa4:ae86:9ba0> has joined #bitcoin-core-dev
5702020-11-17T20:35:40 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (Ping timeout: 246 seconds)
5712020-11-17T20:36:09 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
5722020-11-17T20:36:49 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
5732020-11-17T20:43:23 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
5742020-11-17T20:45:23 *** miketwenty1 <miketwenty1!~miketwent@ec2-52-73-85-113.compute-1.amazonaws.com> has quit IRC (Ping timeout: 256 seconds)
5752020-11-17T20:58:49 *** syperf <syperf!~danie@2001:8a0:ba80:1a01:1c24:aaa4:ae86:9ba0> has quit IRC (Quit: Konversation terminated!)
5762020-11-17T21:00:01 *** dfkt <dfkt!~dfkt@178.162.212.214> has quit IRC ()
5772020-11-17T21:12:13 *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
5782020-11-17T21:15:03 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 260 seconds)
5792020-11-17T21:17:04 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
5802020-11-17T21:22:11 *** havenwood1 <havenwood1!~havenwood@185.204.1.185> has joined #bitcoin-core-dev
5812020-11-17T21:25:47 *** miketwenty1 <miketwenty1!~miketwent@ec2-18-235-230-166.compute-1.amazonaws.com> has joined #bitcoin-core-dev
5822020-11-17T21:26:12 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
5832020-11-17T21:32:00 *** b10c <b10c!~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a> has quit IRC (Remote host closed the connection)
5842020-11-17T21:43:10 *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
5852020-11-17T21:47:42 *** miketwenty1 <miketwenty1!~miketwent@ec2-18-235-230-166.compute-1.amazonaws.com> has quit IRC (Remote host closed the connection)
5862020-11-17T21:49:09 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 260 seconds)
5872020-11-17T21:50:45 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
5882020-11-17T22:02:45 *** syperf <syperf!~danie@2001:8a0:ba80:1a01:1c24:aaa4:ae86:9ba0> has joined #bitcoin-core-dev
5892020-11-17T22:04:18 *** DeanWeen <DeanWeen!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
5902020-11-17T22:04:41 *** DeanWeen <DeanWeen!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
5912020-11-17T22:07:12 *** miketwenty1 <miketwenty1!~miketwent@c-98-251-86-215.hsd1.ga.comcast.net> has joined #bitcoin-core-dev
5922020-11-17T22:08:54 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
5932020-11-17T22:12:03 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
5942020-11-17T22:12:05 *** vasild_ is now known as vasild
5952020-11-17T22:15:23 *** miketwenty1 <miketwenty1!~miketwent@c-98-251-86-215.hsd1.ga.comcast.net> has quit IRC (Remote host closed the connection)
5962020-11-17T22:15:47 *** troygiorshev <troygiorshev!~troygiors@d67-193-140-136.home3.cgocable.net> has quit IRC (Quit: leaving)
5972020-11-17T22:16:08 *** syperf <syperf!~danie@2001:8a0:ba80:1a01:1c24:aaa4:ae86:9ba0> has quit IRC (Quit: Konversation terminated!)
5982020-11-17T22:36:55 *** filchef <filchef!~filchef@212.104.97.177> has quit IRC (Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/)
5992020-11-17T22:42:31 *** Squidicuz <Squidicuz!~squid@pool-72-74-34-120.bstnma.fios.verizon.net> has quit IRC (Quit: Oh no, not again)
6002020-11-17T22:45:19 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
6012020-11-17T22:57:53 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
6022020-11-17T23:02:33 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
6032020-11-17T23:04:50 *** DeanWeen <DeanWeen!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
6042020-11-17T23:55:44 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 260 seconds)