12020-11-19T00:09:59 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
22020-11-19T00:14:25 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
32020-11-19T00:14:29 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Remote host closed the connection)
42020-11-19T00:14:52 *** promag <promag!~promag@188.250.84.129> has quit IRC (Ping timeout: 256 seconds)
52020-11-19T00:18:49 *** miketwen_ <miketwen_!~miketwent@ec2-18-235-230-166.compute-1.amazonaws.com> has quit IRC (Ping timeout: 264 seconds)
62020-11-19T00:20:43 *** DeanWeen <DeanWeen!~dean@gateway/tor-sasl/deanguss> has quit IRC (Ping timeout: 240 seconds)
72020-11-19T00:32:39 *** theStack <theStack!~honeybadg@vps1648322.vs.webtropia-customer.com> has quit IRC (Quit: leaving)
82020-11-19T00:45:44 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Read error: Connection reset by peer)
92020-11-19T00:58:57 *** Isthmus <Isthmus!sid302307@gateway/web/irccloud.com/x-egyhrwljsnapkjej> has quit IRC (Ping timeout: 260 seconds)
102020-11-19T01:00:14 *** Isthmus <Isthmus!sid302307@gateway/web/irccloud.com/x-tsjwkjmdmowmbbfl> has joined #bitcoin-core-dev
112020-11-19T01:00:50 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 272 seconds)
122020-11-19T01:31:12 *** eugene-ff <eugene-ff!~eugene_ff@2604:2000:1383:472b:14c1:e1a8:def3:399e> has joined #bitcoin-core-dev
132020-11-19T01:35:25 *** Aaronvan_ <Aaronvan_!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
142020-11-19T01:40:06 *** eugene-f_ <eugene-f_!~eugene_ff@2604:2000:1383:472b:7caa:aa6e:179d:2f18> has joined #bitcoin-core-dev
152020-11-19T01:43:02 *** eugene-ff <eugene-ff!~eugene_ff@2604:2000:1383:472b:14c1:e1a8:def3:399e> has quit IRC (Ping timeout: 260 seconds)
162020-11-19T01:44:04 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
172020-11-19T01:54:42 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 260 seconds)
182020-11-19T02:29:42 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
192020-11-19T02:29:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
202020-11-19T02:29:56 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/50e019a97a5b...ea7926527ce3
212020-11-19T02:29:56 <bitcoin-git> bitcoin/master faaee81 MarcoFalke: build: Require C++17 compiler
222020-11-19T02:29:57 <bitcoin-git> bitcoin/master fac7198 MarcoFalke: Use std::make_unique
232020-11-19T02:29:57 <bitcoin-git> bitcoin/master ea79265 fanquake: Merge #20413: build: Require C++17 compiler
242020-11-19T02:29:59 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
252020-11-19T02:30:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
262020-11-19T02:30:15 <bitcoin-git> [bitcoin] fanquake merged pull request #20413: build: Require C++17 compiler (master...2011-buildCxx17) https://github.com/bitcoin/bitcoin/pull/20413
272020-11-19T02:30:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
282020-11-19T02:49:09 *** shaunsun <shaunsun!shaunsun@gateway/vpn/privateinternetaccess/shaunsun> has quit IRC (Quit: Leaving)
292020-11-19T03:02:02 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
302020-11-19T03:02:11 *** m9aq <m9aq!~m9aq@106.37.187.213> has joined #bitcoin-core-dev
312020-11-19T03:06:31 *** DeanWeen <DeanWeen!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
322020-11-19T03:12:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
332020-11-19T03:12:12 <bitcoin-git> [bitcoin] fanquake opened pull request #20421: build: miniupnpc 2.2.0 (master...miniupnpc_220) https://github.com/bitcoin/bitcoin/pull/20421
342020-11-19T03:12:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
352020-11-19T03:22:23 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
362020-11-19T03:24:09 *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
372020-11-19T03:33:46 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 256 seconds)
382020-11-19T03:36:20 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
392020-11-19T03:47:44 *** m9aq <m9aq!~m9aq@106.37.187.213> has quit IRC (Quit: m9aq)
402020-11-19T03:54:06 *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
412020-11-19T03:56:04 *** davterra <davterra!~davterra@94.198.43.53> has quit IRC (Quit: Leaving)
422020-11-19T03:57:05 *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 240 seconds)
432020-11-19T04:08:18 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
442020-11-19T04:09:32 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
452020-11-19T04:09:55 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
462020-11-19T04:14:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
472020-11-19T04:14:17 <bitcoin-git> [bitcoin] fanquake opened pull request #20422: build: mac deployment unification (master...macdeploy_unify) https://github.com/bitcoin/bitcoin/pull/20422
482020-11-19T04:14:18 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
492020-11-19T04:49:52 *** jpcw1 <jpcw1!~jpcw@185.103.96.135> has quit IRC (Remote host closed the connection)
502020-11-19T04:55:23 *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has quit IRC (Ping timeout: 240 seconds)
512020-11-19T04:55:43 *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
522020-11-19T05:03:45 *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
532020-11-19T05:04:17 *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has joined #bitcoin-core-dev
542020-11-19T05:20:18 *** flag <flag!~flag@net-109-115-35-195.cust.vodafonedsl.it> has quit IRC (Quit: leaving)
552020-11-19T05:21:32 *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has quit IRC (Remote host closed the connection)
562020-11-19T05:21:56 *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has joined #bitcoin-core-dev
572020-11-19T05:23:13 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 256 seconds)
582020-11-19T05:27:00 *** flag <flag!~flag@net-5-94-131-153.cust.vodafonedsl.it> has joined #bitcoin-core-dev
592020-11-19T05:28:51 *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Remote host closed the connection)
602020-11-19T05:29:19 *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
612020-11-19T05:29:33 *** cltrbreak_MAD2 <cltrbreak_MAD2!~ctrlbreak@159.2.182.106> has joined #bitcoin-core-dev
622020-11-19T05:30:39 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
632020-11-19T05:33:03 *** ctrlbreak_MAD <ctrlbreak_MAD!~ctrlbreak@159.2.182.106> has quit IRC (Ping timeout: 272 seconds)
642020-11-19T05:42:04 *** esandeen <esandeen!~esandeen@185.204.1.185> has joined #bitcoin-core-dev
652020-11-19T05:56:23 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
662020-11-19T06:00:55 * fanquake shouts at the whitespace linter
672020-11-19T06:02:23 *** miketwen_ <miketwen_!~miketwent@ec2-52-73-85-113.compute-1.amazonaws.com> has joined #bitcoin-core-dev
682020-11-19T06:02:45 <sipa> a worthy shouting partner, that is
692020-11-19T06:03:29 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 260 seconds)
702020-11-19T06:04:33 <miketwen_> don't forget your \u180E - Mongolian Vowel Separator
712020-11-19T06:05:25 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 240 seconds)
722020-11-19T06:06:13 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
732020-11-19T06:09:30 *** miketwen_ <miketwen_!~miketwent@ec2-52-73-85-113.compute-1.amazonaws.com> has quit IRC (Remote host closed the connection)
742020-11-19T06:12:17 <sipa> ð±
752020-11-19T07:03:49 *** First <First!df18a13b@ppp-223-24-161-59.revip6.asianet.co.th> has joined #bitcoin-core-dev
762020-11-19T07:03:59 *** First <First!df18a13b@ppp-223-24-161-59.revip6.asianet.co.th> has quit IRC (Remote host closed the connection)
772020-11-19T07:16:05 *** eugene-f_ <eugene-f_!~eugene_ff@2604:2000:1383:472b:7caa:aa6e:179d:2f18> has quit IRC (Remote host closed the connection)
782020-11-19T07:16:32 *** eugene-ff <eugene-ff!~eugene_ff@2604:2000:1383:472b:7caa:aa6e:179d:2f18> has joined #bitcoin-core-dev
792020-11-19T07:20:44 *** eugene-ff <eugene-ff!~eugene_ff@2604:2000:1383:472b:7caa:aa6e:179d:2f18> has quit IRC (Ping timeout: 240 seconds)
802020-11-19T07:31:55 *** eugene-ff <eugene-ff!~eugene_ff@2604:2000:1383:472b:7caa:aa6e:179d:2f18> has joined #bitcoin-core-dev
812020-11-19T07:36:33 *** eugene-ff <eugene-ff!~eugene_ff@2604:2000:1383:472b:7caa:aa6e:179d:2f18> has quit IRC (Ping timeout: 272 seconds)
822020-11-19T07:40:48 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
832020-11-19T07:47:17 *** kcalvinalvin <kcalvinalvin!~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com> has quit IRC (Quit: ZNC 1.7.4 - https://znc.in)
842020-11-19T07:47:23 *** MarcoFalke <MarcoFalke!~none@198.12.116.246> has quit IRC (Quit: ZNC 1.7.1 - https://znc.in)
852020-11-19T07:48:01 *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has quit IRC (Disconnected by services)
862020-11-19T07:49:01 *** kcalvinalvin <kcalvinalvin!~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com> has joined #bitcoin-core-dev
872020-11-19T07:49:42 *** MarcoFalke <MarcoFalke!~none@198.12.116.246> has joined #bitcoin-core-dev
882020-11-19T07:59:42 *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev
892020-11-19T08:00:06 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
902020-11-19T08:01:31 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
912020-11-19T08:07:14 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
922020-11-19T08:26:06 <wumpus2> i didn't actually label rc1 yet
932020-11-19T08:26:11 *** wumpus2 is now known as wumpus
942020-11-19T08:33:44 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 260 seconds)
952020-11-19T08:40:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
962020-11-19T08:40:03 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/6cde7bb9b26c...80496f9e8116
972020-11-19T08:40:03 <bitcoin-git> bitcoin/0.21 80496f9 Wladimir J. van der Laan: build: Set msvc builds's CLIENT_VERSION_IS_RELEASE
982020-11-19T08:40:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
992020-11-19T08:54:58 <wumpus> the make-tag script can now check all you favorite extra msvc build version strings too https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/66/files
1002020-11-19T09:05:18 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
1012020-11-19T09:21:31 <MarcoFalke> #proposedmeetingtopic 0.20.2
1022020-11-19T09:22:21 <wumpus> sure can we first do 0.21.0rc1
1032020-11-19T09:27:23 *** midnight <midnight!~midnight@unaffiliated/midnightmagic> has quit IRC (Ping timeout: 272 seconds)
1042020-11-19T09:28:02 <MarcoFalke> I'd guess it makes sense to do them at approximately the same time, so that gitian builders can run both in a row
1052020-11-19T09:29:15 *** midnight <midnight!~midnight@unaffiliated/midnightmagic> has joined #bitcoin-core-dev
1062020-11-19T09:38:53 *** nckx <nckx!~nckx@tobias.gr> has quit IRC (Quit: Updating my Guix System â https://guix.gnu.org)
1072020-11-19T09:40:23 <wumpus> sure
1082020-11-19T09:41:33 *** nckx <nckx!~nckx@tobias.gr> has joined #bitcoin-core-dev
1092020-11-19T09:41:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1102020-11-19T09:41:34 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ea7926527ce3...cddcd22ab326
1112020-11-19T09:41:35 <bitcoin-git> bitcoin/master dd7b5f4 Jon Atack: script: fix deprecation warning in makeseeds.py
1122020-11-19T09:41:36 <bitcoin-git> bitcoin/master 961f148 Jon Atack: doc: update contrib/seeds/README dnspython installation info
1132020-11-19T09:41:36 <bitcoin-git> bitcoin/master cddcd22 Wladimir J. van der Laan: Merge #20288: script, doc: contrib/seeds updates
1142020-11-19T09:41:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1152020-11-19T09:41:53 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1162020-11-19T09:41:53 <bitcoin-git> [bitcoin] laanwj merged pull request #20288: script, doc: contrib/seeds updates (master...contrib-seeds-fixups) https://github.com/bitcoin/bitcoin/pull/20288
1172020-11-19T09:41:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1182020-11-19T09:59:24 *** twistedline__ <twistedline__!~twisted@2601:14d:8500:d3e0:84e0:58ef:36b6:dc83> has joined #bitcoin-core-dev
1192020-11-19T10:02:18 *** twistedline_ <twistedline_!~twisted@c-73-200-216-219.hsd1.dc.comcast.net> has quit IRC (Read error: Connection reset by peer)
1202020-11-19T10:04:45 *** kexkey <kexkey!~kexkey@static-198-54-132-91.cust.tzulo.com> has quit IRC (Ping timeout: 240 seconds)
1212020-11-19T10:08:58 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
1222020-11-19T10:12:03 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
1232020-11-19T10:12:04 *** vasild_ is now known as vasild
1242020-11-19T10:16:24 *** jonatack <jonatack!~jon@213.152.161.149> has quit IRC (Read error: Connection reset by peer)
1252020-11-19T10:18:14 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1262020-11-19T10:19:57 *** jonatack <jonatack!~jon@213.152.161.249> has joined #bitcoin-core-dev
1272020-11-19T10:32:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1282020-11-19T10:32:56 <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/cddcd22ab326...888c22e0dd35
1292020-11-19T10:32:56 <bitcoin-git> bitcoin/master 6c7e8f0 Carl Dong: depends: Allow relative CONFIG_SITE path env var
1302020-11-19T10:32:57 <bitcoin-git> bitcoin/master 618cbd2 Carl Dong: lint: Also lint files with shellcheck directive
1312020-11-19T10:32:58 <bitcoin-git> bitcoin/master 46756a6 Carl Dong: depends: Fix PYTHONPATH setting in config.site.in
1322020-11-19T10:33:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1332020-11-19T10:33:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1342020-11-19T10:33:17 <bitcoin-git> [bitcoin] laanwj merged pull request #20359: depends: Various config.site.in improvements and linting (master...2020-11-config-site-cleanup) https://github.com/bitcoin/bitcoin/pull/20359
1352020-11-19T10:33:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1362020-11-19T10:36:33 *** belcher_ is now known as belcher
1372020-11-19T10:39:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1382020-11-19T10:39:35 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/888c22e0dd35...47b6ad837c07
1392020-11-19T10:39:35 <bitcoin-git> bitcoin/master 7087440 fanquake: depends: native_ds_store 1.3.0
1402020-11-19T10:39:36 <bitcoin-git> bitcoin/master 47b6ad8 Wladimir J. van der Laan: Merge #20333: build: remove native_biplist dependency
1412020-11-19T10:39:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1422020-11-19T10:39:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1432020-11-19T10:39:54 <bitcoin-git> [bitcoin] laanwj merged pull request #20333: build: remove native_biplist dependency (master...no_more_biplist) https://github.com/bitcoin/bitcoin/pull/20333
1442020-11-19T10:39:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1452020-11-19T10:45:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1462020-11-19T10:45:05 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/47b6ad837c07...e12ad7f38346
1472020-11-19T10:45:06 <bitcoin-git> bitcoin/master d9141a0 Anthony Towns: doc: clarify CRollingBloomFilter size estimate
1482020-11-19T10:45:06 <bitcoin-git> bitcoin/master e12ad7f Wladimir J. van der Laan: Merge #19968: doc: clarify CRollingBloomFilter size estimate
1492020-11-19T10:45:10 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1502020-11-19T10:45:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1512020-11-19T10:45:25 <bitcoin-git> [bitcoin] laanwj merged pull request #19968: doc: clarify CRollingBloomFilter size estimate (master...bloom-doc) https://github.com/bitcoin/bitcoin/pull/19968
1522020-11-19T10:45:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1532020-11-19T10:51:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1542020-11-19T10:51:25 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e12ad7f38346...fbb2bee82d83
1552020-11-19T10:51:26 <bitcoin-git> bitcoin/master 6f4e393 Sebastian Falbesoner: refactor: remove use of boost::algorithm::replace_first
1562020-11-19T10:51:26 <bitcoin-git> bitcoin/master fbb2bee Wladimir J. van der Laan: Merge #20067: refactor: remove use of boost::algorithm::replace_first
1572020-11-19T10:51:28 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1582020-11-19T10:51:45 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1592020-11-19T10:51:45 <bitcoin-git> [bitcoin] laanwj merged pull request #20067: refactor: remove use of boost::algorithm::replace_first (master...20201003-get-rid-of-boost-replace_first) https://github.com/bitcoin/bitcoin/pull/20067
1602020-11-19T10:51:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1612020-11-19T10:57:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1622020-11-19T10:57:19 <bitcoin-git> [bitcoin] vasild closed pull request #20000: test: fix creation of "std::string"s with \0s (master...fix_base32_tests) https://github.com/bitcoin/bitcoin/pull/20000
1632020-11-19T10:57:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1642020-11-19T10:57:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1652020-11-19T10:57:34 <bitcoin-git> [bitcoin] vasild reopened pull request #20000: test: fix creation of "std::string"s with \0s (master...fix_base32_tests) https://github.com/bitcoin/bitcoin/pull/20000
1662020-11-19T10:57:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1672020-11-19T11:00:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1682020-11-19T11:00:38 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fbb2bee82d83...1cc5e693c186
1692020-11-19T11:00:38 <bitcoin-git> bitcoin/master 330cb33 Fabrice Fontaine: src/randomenv.cpp: fix build on uclibc
1702020-11-19T11:00:39 <bitcoin-git> bitcoin/master 1cc5e69 Wladimir J. van der Laan: Merge #20358: src/randomenv.cpp: fix build on uclibc
1712020-11-19T11:00:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1722020-11-19T11:00:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1732020-11-19T11:00:57 <bitcoin-git> [bitcoin] laanwj merged pull request #20358: src/randomenv.cpp: fix build on uclibc (master...master) https://github.com/bitcoin/bitcoin/pull/20358
1742020-11-19T11:01:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1752020-11-19T11:01:05 *** eugene-ff <eugene-ff!~eugene_ff@2604:2000:1383:472b:61cf:8422:5aa2:39dd> has joined #bitcoin-core-dev
1762020-11-19T11:04:16 *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has quit IRC (Ping timeout: 240 seconds)
1772020-11-19T11:05:22 *** eugene-ff <eugene-ff!~eugene_ff@2604:2000:1383:472b:61cf:8422:5aa2:39dd> has quit IRC (Ping timeout: 260 seconds)
1782020-11-19T11:06:32 *** wullon4 <wullon4!~wullon@241.243.86.88.rdns.comcable.net> has quit IRC (Ping timeout: 256 seconds)
1792020-11-19T11:09:37 *** mrostecki <mrostecki!~mrostecki@gateway/tor-sasl/mrostecki> has quit IRC (Quit: Leaving)
1802020-11-19T11:09:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1812020-11-19T11:09:49 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1cc5e693c186...d9180c50b689
1822020-11-19T11:09:50 <bitcoin-git> bitcoin/master 355d0c4 Karl-Johan Alm: contrib: add getcoins.py script to get coins from (signet) faucet
1832020-11-19T11:09:50 <bitcoin-git> bitcoin/master e9c8e6e Karl-Johan Alm: doc: add contrib/signet readme
1842020-11-19T11:09:51 <bitcoin-git> bitcoin/master d9180c5 Wladimir J. van der Laan: Merge #20145: contrib: add getcoins.py script to get coins from (signet) f...
1852020-11-19T11:09:52 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1862020-11-19T11:10:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1872020-11-19T11:10:09 <bitcoin-git> [bitcoin] laanwj merged pull request #20145: contrib: add getcoins.py script to get coins from (signet) faucet (master...202010-signet-getcoins) https://github.com/bitcoin/bitcoin/pull/20145
1882020-11-19T11:10:10 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1892020-11-19T11:14:40 *** Kiminuo <Kiminuo!~mix@193.9.112.252> has joined #bitcoin-core-dev
1902020-11-19T11:16:38 *** pergaminho <pergaminho!~Cleber@189.26.121.248> has joined #bitcoin-core-dev
1912020-11-19T11:16:56 *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev
1922020-11-19T11:17:01 <Kiminuo> MarcoFalke, Hi Marco, could you say whether it's worth working on std::fs at this time? You have, I think, mentioned that `std::fs` is not supported by some OSs. So I just want to know whether it makes sense to work on this or let it wait a few months or a few years for next upgrade (https://github.com/bitcoin/bitcoin/pull/19245#issuecomment-730291399)
1932020-11-19T11:18:22 *** Dwight85Ankundin <Dwight85Ankundin!~Dwight85A@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
1942020-11-19T11:19:08 <MarcoFalke> It would mean that compilation on Ubuntu 18.04 no longer works, I think
1952020-11-19T11:19:28 <MarcoFalke> I might have to check again
1962020-11-19T11:21:01 *** mrostecki <mrostecki!~mrostecki@gateway/tor-sasl/mrostecki> has joined #bitcoin-core-dev
1972020-11-19T11:22:15 *** Dwight85Ankundin <Dwight85Ankundin!~Dwight85A@static.57.1.216.95.clients.your-server.de> has quit IRC (Read error: Connection timed out)
1982020-11-19T11:22:48 <Kiminuo> Thanks for info
1992020-11-19T11:24:45 <wumpus> no opinion on timespan but one thing to be really careful with when transitioning to std::fs is that the unicode character subtleties still work, across OSes
2002020-11-19T11:25:26 <wumpus> including interaction between Qt and it, especially on windows there has been a history of issues there
2012020-11-19T11:26:18 <wumpus> unfortunately, locale stuff tends to be really awful in C standard libraries
2022020-11-19T11:33:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2032020-11-19T11:33:31 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d9180c50b689...9ab9665c74dd
2042020-11-19T11:33:31 <bitcoin-git> bitcoin/master 32def8d Peter Bushnell: Catch ios_base::failure specifically
2052020-11-19T11:33:32 <bitcoin-git> bitcoin/master 7486e27 Bushstar: Tests: Unit test related to WalletDB ReadKeyValue
2062020-11-19T11:33:32 <bitcoin-git> bitcoin/master 9ab9665 Wladimir J. van der Laan: Merge #15710: wallet: Catch ios_base::failure specifically
2072020-11-19T11:33:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2082020-11-19T11:34:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2092020-11-19T11:34:00 <bitcoin-git> [bitcoin] laanwj merged pull request #15710: wallet: Catch ios_base::failure specifically (master...walletdb-readthrow) https://github.com/bitcoin/bitcoin/pull/15710
2102020-11-19T11:34:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2112020-11-19T11:40:38 *** jonatack <jonatack!~jon@213.152.161.249> has quit IRC (Quit: jonatack)
2122020-11-19T11:41:17 <Kiminuo> wumpus, Yes, I have tried to collect PRs for "fs" to see what the issues were. I can only say that it *tentatively seems* that std::fs behaves nicer wrt unicode than Boost. But it will be a long ride and maybe I'm wrong. It's hard to guess at this point.
2132020-11-19T11:59:42 *** pergaminho <pergaminho!~Cleber@189.26.121.248> has quit IRC (Read error: No route to host)
2142020-11-19T11:59:56 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
2152020-11-19T12:04:59 *** pergaminho <pergaminho!~Cleber@189.26.121.248> has joined #bitcoin-core-dev
2162020-11-19T12:10:54 *** jonatack <jonatack!~jon@109.202.107.147> has joined #bitcoin-core-dev
2172020-11-19T12:24:31 *** eugene-ff <eugene-ff!~eugene_ff@2604:2000:1383:472b:4e1:99fe:ab7c:b3cf> has joined #bitcoin-core-dev
2182020-11-19T13:00:56 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
2192020-11-19T13:17:22 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
2202020-11-19T13:20:36 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2212020-11-19T13:20:37 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/9ab9665c74dd...71d068db4058
2222020-11-19T13:20:38 <bitcoin-git> bitcoin/master fa19bb2 MarcoFalke: remove dead rpc code
2232020-11-19T13:20:39 <bitcoin-git> bitcoin/master faaf9c5 MarcoFalke: remove CRPCCommand constructor that takes rpcfn_type function pointer
2242020-11-19T13:20:39 <bitcoin-git> bitcoin/master 71d068d MarcoFalke: Merge #18531: rpc: remove deprecated CRPCCommand constructor
2252020-11-19T13:20:48 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2262020-11-19T13:21:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2272020-11-19T13:21:06 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #18531: rpc: remove deprecated CRPCCommand constructor (master...2004-rpcMan) https://github.com/bitcoin/bitcoin/pull/18531
2282020-11-19T13:21:07 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2292020-11-19T13:22:03 *** miketwenty1 <miketwenty1!~miketwent@ec2-52-73-85-113.compute-1.amazonaws.com> has joined #bitcoin-core-dev
2302020-11-19T13:25:08 <Kiminuo> https://stackoverflow.com/a/53531186 - It seems, you can compile Bitcoin codebase on Ubuntu 18.04 with std::filesystem only with GCC 8.
2312020-11-19T13:25:22 <Kiminuo> https://github.com/bitcoin/bitcoin/blob/master/doc/dependencies.md - mentions that the lowest supported GCC version is 7.
2322020-11-19T13:25:28 <Kiminuo> So this is a problem.
2332020-11-19T13:26:18 <Kiminuo> MarcoFalke, I have verified that vanilla Ubuntu 18.04 reports: filesystem: No such file or directory
2342020-11-19T13:26:19 <Kiminuo> #include <filesystem>
2352020-11-19T13:26:37 <Kiminuo> So I guess. That's game over :)
2362020-11-19T13:26:58 <MarcoFalke> At some point we'll drop compile support for 18.04
2372020-11-19T13:27:17 <MarcoFalke> Maybe 23.0?
2382020-11-19T13:27:29 <Kiminuo> Yeah, that's what I mean. Game over until then.
2392020-11-19T13:27:33 <MarcoFalke> Can bionic clang compile it?
2402020-11-19T13:27:58 <Kiminuo> That's beyond my capability to try.
2412020-11-19T13:28:05 <MarcoFalke> https://packages.ubuntu.com/bionic/clang-10
2422020-11-19T13:28:30 <MarcoFalke> apt install clang-10 llvm-10 && ./configure CC=clang-10 CXX=clang-10++ && make
2432020-11-19T13:28:36 <Kiminuo> thanks
2442020-11-19T13:30:21 <MarcoFalke> std::fs is in clang-7, I think. So it should work
2452020-11-19T13:31:42 <Kiminuo> https://pastebin.com/hMM1DbrV I'm getting this with " ./configure CC=clang-10 CXX=clang-10++"
2462020-11-19T13:32:40 <Kiminuo> https://pastebin.com/HLHmF5Me config.log
2472020-11-19T13:35:22 <hebasto> bionic has g++-8 package in its repo https://packages.ubuntu.com/bionic/devel/g++-8
2482020-11-19T13:36:24 <MarcoFalke> hebasto: Good point
2492020-11-19T13:36:46 <hebasto> and version 8.4 should be enough for std::filesystem as it was introduced in 8.1
2502020-11-19T13:37:36 <MarcoFalke> oh, it is called clang++-10
2512020-11-19T13:41:30 <Kiminuo> hebasto, https://github.com/kiminuo/bitcoin/tree/feature/2020-11-19-replace-boost-filesystem-with-cpp17-filesystem could you possibly try that on Ubuntu 18.04, if you have one?
2522020-11-19T13:41:55 <Kiminuo> I'm trying but I can't get rid of the C++ compiler cannot create executables
2532020-11-19T13:41:59 <Kiminuo> error
2542020-11-19T13:42:18 <Kiminuo> It looks like I have broken my Ubuntu 18.04 :)
2552020-11-19T13:43:05 <Kiminuo> Still trying though
2562020-11-19T13:43:35 <MarcoFalke> will try. One sec
2572020-11-19T13:43:40 <Kiminuo> thank you
2582020-11-19T13:46:50 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
2592020-11-19T13:49:38 <Kiminuo> ./configure CC=clang-10 CXX=clang++-10 BDB_LIBS="-L${BDB_PREFIX}/lib -ldb_cxx-4.8" BDB_CFLAGS="-I${BDB_PREFIX}/include" reports now:
2602020-11-19T13:49:47 <Kiminuo> ./logging.h:108:38: error: expected expression
2612020-11-19T13:49:48 <Kiminuo> std::list<std::function<void(const std::string&)>>::iterator PushBackCallback(std::function<void(const std::string&)> fun)
2622020-11-19T13:49:48 <Kiminuo> ^
2632020-11-19T13:53:51 <MarcoFalke> Checked "g++ (Ubuntu 7.5.0-3ubuntu1~18.04)" fails as expected. Checked g++-8 works.
2642020-11-19T13:54:03 <MarcoFalke> Kiminuo: You are missing an #include functional
2652020-11-19T13:54:35 <Kiminuo> ok, interesting
2662020-11-19T14:05:07 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
2672020-11-19T14:05:20 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.161.165> has joined #bitcoin-core-dev
2682020-11-19T14:07:17 <wumpus> Kiminuo: glad to hear that it doesn't seem worse at first glance :)
2692020-11-19T14:09:48 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.161.165> has quit IRC (Ping timeout: 256 seconds)
2702020-11-19T14:10:38 *** miketwenty1 <miketwenty1!~miketwent@ec2-52-73-85-113.compute-1.amazonaws.com> has quit IRC (Remote host closed the connection)
2712020-11-19T14:11:37 <wumpus> I guess supporting two file system backends is a bit too much or we could have a period in which it's possible to choose
2722020-11-19T14:13:45 *** miketwen_ <miketwen_!~miketwent@ec2-52-73-85-113.compute-1.amazonaws.com> has joined #bitcoin-core-dev
2732020-11-19T14:14:30 <Kiminuo> wumpus, supporting two file system libraries is difficult and probably a little bit dangerous (due to small differences)
2742020-11-19T14:14:49 *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
2752020-11-19T14:15:15 <Kiminuo> well, it's hard to let users to choose. There's no selling point for that.
2762020-11-19T14:15:33 <Kiminuo> Either Boost filesystem is better or std::filesystem is better.
2772020-11-19T14:15:42 <wumpus> it was the original idea behind fs.h, and we need to be aware of the differences anyhow, but yea
2782020-11-19T14:16:06 <wumpus> it's not as much of a drop-in replacement as thought at the time
2792020-11-19T14:16:20 <Kiminuo> right, but it brings more complexity and I'm not sure if there is any benefit. I don't see any
2802020-11-19T14:17:08 <wumpus> well one is that the std::fs using code would already be tested at the time it becomes mandatory, less of a 'flag day'
2812020-11-19T14:18:16 <MarcoFalke> Anyone mind to ACK https://github.com/bitcoin-core/univalue/pull/24 ?
2822020-11-19T14:18:39 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 256 seconds)
2832020-11-19T14:20:36 <Kiminuo> wumpus, for that to work, you would need to wrap more functions in fs.h, then it would work as you say. If that's what you mean.
2842020-11-19T14:20:39 <wumpus> MarcoFalke:done
2852020-11-19T14:20:48 <Kiminuo> And that would be probably useful
2862020-11-19T14:20:49 <MarcoFalke> thx
2872020-11-19T14:21:15 <Kiminuo> because it would also nicely show what the differences between those fs implementations are
2882020-11-19T14:21:18 <wumpus> Kiminuo: yes, the idea would be for fs.h to encapsulate the differences as much of possible
2892020-11-19T14:21:29 <Kiminuo> right, I finally understand. Sorry.
2902020-11-19T14:22:38 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 272 seconds)
2912020-11-19T14:33:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2922020-11-19T14:33:39 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/71d068db4058...7aa94569ce1a
2932020-11-19T14:33:39 <bitcoin-git> bitcoin/master ea93bbe practicalswift: init: Fix incorrect warning "Reducing -maxconnections from N to N-1, becau...
2942020-11-19T14:33:40 <bitcoin-git> bitcoin/master 7aa9456 Wladimir J. van der Laan: Merge #20024: init: Fix incorrect warning "Reducing -maxconnections from N...
2952020-11-19T14:33:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2962020-11-19T14:33:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2972020-11-19T14:33:54 <bitcoin-git> [bitcoin] laanwj merged pull request #20024: init: Fix incorrect warning "Reducing -maxconnections from N to N-1, because of system limitations" (master...fix-incorrect-warning) https://github.com/bitcoin/bitcoin/pull/20024
2982020-11-19T14:33:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2992020-11-19T14:34:31 *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
3002020-11-19T14:35:10 *** miketwen_ <miketwen_!~miketwent@ec2-52-73-85-113.compute-1.amazonaws.com> has quit IRC (Remote host closed the connection)
3012020-11-19T14:35:39 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
3022020-11-19T14:38:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3032020-11-19T14:38:55 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7aa94569ce1a...c4d1e24f5480
3042020-11-19T14:38:55 <bitcoin-git> bitcoin/master 136d96b Sebastian Falbesoner: test: use wait_for_{block,header} helpers in p2p_fingerprint.py
3052020-11-19T14:38:56 <bitcoin-git> bitcoin/master 6b56c1f Sebastian Falbesoner: test: remove last_{block,header}_equals() in p2p_fingerprint.py
3062020-11-19T14:38:57 <bitcoin-git> bitcoin/master c4d1e24 Wladimir J. van der Laan: Merge #20047: test: use wait_for_{block,header} helpers in p2p_fingerprint...
3072020-11-19T14:38:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3082020-11-19T14:39:14 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3092020-11-19T14:39:14 <bitcoin-git> [bitcoin] laanwj merged pull request #20047: test: use wait_for_{block,header} helpers in p2p_fingerprint.py (master...20200930-test-use-wait-for-block-header-in-fingerprint-py) https://github.com/bitcoin/bitcoin/pull/20047
3102020-11-19T14:39:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3112020-11-19T14:40:14 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 256 seconds)
3122020-11-19T14:41:55 *** DeanWeen <DeanWeen!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
3132020-11-19T14:42:18 *** DeanWeen <DeanWeen!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
3142020-11-19T14:43:57 *** miketwenty1 <miketwenty1!~miketwent@ec2-18-235-230-166.compute-1.amazonaws.com> has joined #bitcoin-core-dev
3152020-11-19T14:52:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3162020-11-19T14:52:12 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20424: build: Update univalue subtree (master...2011-subtreeUnivalue) https://github.com/bitcoin/bitcoin/pull/20424
3172020-11-19T14:52:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3182020-11-19T14:59:48 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
3192020-11-19T14:59:49 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
3202020-11-19T15:00:10 *** shesek <shesek!~shesek@164.90.217.137> has joined #bitcoin-core-dev
3212020-11-19T15:03:26 *** davterra <davterra!~davterra@static-198-54-129-60.cust.tzulo.com> has joined #bitcoin-core-dev
3222020-11-19T15:08:28 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
3232020-11-19T15:08:30 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
3242020-11-19T15:22:54 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 256 seconds)
3252020-11-19T15:28:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3262020-11-19T15:28:34 <bitcoin-git> [bitcoin] glozow closed pull request #20025: validation/util: add GetTransactionFee (master...2020-09-getfee) https://github.com/bitcoin/bitcoin/pull/20025
3272020-11-19T15:28:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3282020-11-19T15:32:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3292020-11-19T15:32:41 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c4d1e24f5480...884bde510e2d
3302020-11-19T15:32:41 <bitcoin-git> bitcoin/master eefe194 John Newbery: [net] Consolidate logic around calling CAddrMan::Connected()
3312020-11-19T15:32:42 <bitcoin-git> bitcoin/master 0bfce9d John Newbery: [addrman] Fix Connected() comment
3322020-11-19T15:32:43 <bitcoin-git> bitcoin/master 884bde5 MarcoFalke: Merge #20291: [net] Consolidate logic around calling CAddrMan::Connected()...
3332020-11-19T15:32:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3342020-11-19T15:33:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3352020-11-19T15:33:00 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20291: [net] Consolidate logic around calling CAddrMan::Connected() (master...2020-11-consolidate-addrman-connect) https://github.com/bitcoin/bitcoin/pull/20291
3362020-11-19T15:33:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3372020-11-19T15:35:44 *** Kiminuo <Kiminuo!~mix@193.9.112.252> has quit IRC (Ping timeout: 260 seconds)
3382020-11-19T15:40:10 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3392020-11-19T15:40:10 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/884bde510e2d...848d66519c39
3402020-11-19T15:40:11 <bitcoin-git> bitcoin/master 0000a0c MarcoFalke: Remove confusing and almost useless "unexpected version" warning
3412020-11-19T15:40:11 <bitcoin-git> bitcoin/master 848d665 Wladimir J. van der Laan: Merge #20054: Remove confusing and useless "unexpected version" warning
3422020-11-19T15:40:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3432020-11-19T15:40:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3442020-11-19T15:40:30 <bitcoin-git> [bitcoin] laanwj merged pull request #20054: Remove confusing and useless "unexpected version" warning (master...2010-valRemVerWarn) https://github.com/bitcoin/bitcoin/pull/20054
3452020-11-19T15:40:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3462020-11-19T15:40:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3472020-11-19T15:40:50 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/848d66519c39...04670ef81ea2
3482020-11-19T15:40:50 <bitcoin-git> bitcoin/master 21f2433 Michael Dietz: test: run mempool_spend_coinbase.py even with wallet disabled
3492020-11-19T15:40:51 <bitcoin-git> bitcoin/master 04670ef Wladimir J. van der Laan: Merge #20385: test: run mempool_spend_coinbase.py even with wallet disable...
3502020-11-19T15:40:52 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3512020-11-19T15:41:10 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3522020-11-19T15:41:10 <bitcoin-git> [bitcoin] laanwj merged pull request #20385: test: run mempool_spend_coinbase.py even with wallet disabled (master...mempool-tests-to-miniwallet) https://github.com/bitcoin/bitcoin/pull/20385
3532020-11-19T15:41:11 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3542020-11-19T15:46:12 *** esandeen <esandeen!~esandeen@185.204.1.185> has quit IRC (Remote host closed the connection)
3552020-11-19T15:52:10 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
3562020-11-19T16:00:07 *** awesome_doge <awesome_doge!awesome-do@gateway/shell/matrix.org/x-kgvlagchdhvhofka> has quit IRC (Quit: Idle for 30+ days)
3572020-11-19T16:04:05 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
3582020-11-19T16:07:21 *** pehjota1 <pehjota1!~pehjota@178.239.168.171> has joined #bitcoin-core-dev
3592020-11-19T16:10:34 *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has quit IRC (Quit: Find me in #TheHolyRoger or https://theholyroger.com)
3602020-11-19T16:13:02 *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has joined #bitcoin-core-dev
3612020-11-19T16:25:02 <wumpus> can someone please check if this minor documentation change is correct: #20329
3622020-11-19T16:25:04 <gribble> https://github.com/bitcoin/bitcoin/issues/20329 | docs/descriptors.md: Remove hardened marker in the path after xpub by dgpv · Pull Request #20329 · bitcoin/bitcoin · GitHub
3632020-11-19T16:29:11 *** justan0theruser <justan0theruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
3642020-11-19T16:35:15 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
3652020-11-19T16:35:43 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
3662020-11-19T16:46:09 *** justan0theruser <justan0theruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
3672020-11-19T16:46:46 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
3682020-11-19T16:55:22 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
3692020-11-19T17:01:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3702020-11-19T17:01:05 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/04670ef81ea2...db58b857f77a
3712020-11-19T17:01:06 <bitcoin-git> bitcoin/master dc80a7d Dmitry Petukhov: docs/descriptors.md: Remove hardened marker in the path after xpub
3722020-11-19T17:01:07 <bitcoin-git> bitcoin/master db58b85 MarcoFalke: Merge #20329: docs/descriptors.md: Remove hardened marker in the path afte...
3732020-11-19T17:01:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3742020-11-19T17:01:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3752020-11-19T17:01:25 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20329: docs/descriptors.md: Remove hardened marker in the path after xpub (master...fix-descriptors-md-hardened-after-xpub) https://github.com/bitcoin/bitcoin/pull/20329
3762020-11-19T17:01:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3772020-11-19T17:04:47 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Read error: Connection reset by peer)
3782020-11-19T17:05:34 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
3792020-11-19T17:09:03 *** pergamo <pergamo!~Cleber@189.26.121.248> has joined #bitcoin-core-dev
3802020-11-19T17:09:49 *** pergaminho <pergaminho!~Cleber@189.26.121.248> has quit IRC (Ping timeout: 264 seconds)
3812020-11-19T17:12:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3822020-11-19T17:12:40 <bitcoin-git> [bitcoin] practicalswift opened pull request #20425: fuzz: Make addrman fuzzing harness deterministic (master...fuzzers-make-addrman-harness-deterministic) https://github.com/bitcoin/bitcoin/pull/20425
3832020-11-19T17:12:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3842020-11-19T17:27:36 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
3852020-11-19T17:27:44 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
3862020-11-19T17:28:45 *** DeanWeen <DeanWeen!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
3872020-11-19T17:29:12 *** DeanWeen <DeanWeen!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
3882020-11-19T17:32:29 *** promag <promag!~promag@188.250.84.129> has quit IRC (Ping timeout: 265 seconds)
3892020-11-19T17:32:43 *** Kiminuo <Kiminuo!~mix@193.9.112.252> has joined #bitcoin-core-dev
3902020-11-19T17:54:23 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
3912020-11-19T17:57:23 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
3922020-11-19T17:58:38 <hebasto> jonasschnelli: MarcoFalke: could https://github.com/bitcoin-core/gui/pull/46 be considered early for 0.22 to make compiling on macos more pleasant?
3932020-11-19T18:01:11 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
3942020-11-19T18:05:56 *** pergamo <pergamo!~Cleber@189.26.121.248> has quit IRC (Quit: Saindo)
3952020-11-19T18:06:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3962020-11-19T18:06:12 <bitcoin-git> [gui] MarcoFalke merged pull request #46: refactor: Fix deprecation warnings when building against Qt 5.15 (master...200809-depr) https://github.com/bitcoin-core/gui/pull/46
3972020-11-19T18:06:14 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3982020-11-19T18:06:32 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3992020-11-19T18:06:33 <bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/db58b857f77a...0a267f4eb885
4002020-11-19T18:06:33 <bitcoin-git> bitcoin/master b02264c Hennadii Stepanov: qt, refactor: Fix 'QDateTime is deprecated' warnings
4012020-11-19T18:06:34 <bitcoin-git> bitcoin/master fa5749c Hennadii Stepanov: qt, refactor: Fix 'pixmap is deprecated' warnings
4022020-11-19T18:06:34 <bitcoin-git> bitcoin/master 8e12d69 Hennadii Stepanov: qt, refactor: Fix 'QFlags is deprecated' warnings
4032020-11-19T18:06:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4042020-11-19T18:07:16 <hebasto> MarcoFalke: thanks!
4052020-11-19T18:07:49 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
4062020-11-19T18:15:04 *** kexkey <kexkey!~kexkey@static-198-54-132-107.cust.tzulo.com> has joined #bitcoin-core-dev
4072020-11-19T18:21:18 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4082020-11-19T18:21:18 <bitcoin-git> [bitcoin] jonatack opened pull request #20426: wallet: allow zero-fee fundrawtransaction/walletcreatefundedpsbt and other fixes (master...fee_rate_followups) https://github.com/bitcoin/bitcoin/pull/20426
4092020-11-19T18:21:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4102020-11-19T18:27:33 *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
4112020-11-19T18:38:36 *** dhruvm <dhruvm!~noreply@c-73-158-59-66.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 240 seconds)
4122020-11-19T18:51:34 *** lightlike <lightlike!~lightlike@p200300c7ef17e3007c1705fd94e35505.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
4132020-11-19T19:00:15 <MarcoFalke> hi
4142020-11-19T19:00:26 <fjahr> hi
4152020-11-19T19:00:31 <hebasto> hi
4162020-11-19T19:00:42 <wumpus> #startmeeting
4172020-11-19T19:00:42 <core-meetingbot> Meeting started Thu Nov 19 19:00:41 2020 UTC. The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
4182020-11-19T19:00:42 <core-meetingbot> Available commands: action commands idea info link nick
4192020-11-19T19:00:44 <kanzure> hi
4202020-11-19T19:01:03 <jonasschnelli> hi
4212020-11-19T19:01:05 <wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
4222020-11-19T19:01:07 <wumpus> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus
4232020-11-19T19:01:12 <jonatack> hi
4242020-11-19T19:01:27 <luke-jr> hi
4252020-11-19T19:01:35 <achow101> hi
4262020-11-19T19:01:36 <sipa> hi
4272020-11-19T19:01:44 <wumpus> there is one proposed meeting topic for this week: 0.20.2 (MarcoFalke)
4282020-11-19T19:01:49 <miketwenty1> hi
4292020-11-19T19:02:48 <murch> hi
4302020-11-19T19:02:57 <wumpus> I wanted to tag rc1 today but apparently some things have been tagge 0.21 since: https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.21.0
4312020-11-19T19:03:26 <wumpus> I guess if these are really urgent, please help reviewing them
4322020-11-19T19:03:43 <MarcoFalke> wumpus: Don't worry abou those. They are minor RPC inconsistencies
4332020-11-19T19:03:53 <hebasto> the tagged for backporting, no?
4342020-11-19T19:03:55 <wumpus> if not, let's move them to the 0.21.1 milestone instead
4352020-11-19T19:04:09 <luke-jr> wumpus: feature_segwit test is failing too
4362020-11-19T19:04:13 <MarcoFalke> I am sure we will find more issus for rc2
4372020-11-19T19:04:19 <sipa> inconsistencies in newly introduced stuff?
4382020-11-19T19:04:27 <jnewbery> hi
4392020-11-19T19:04:31 <MarcoFalke> sipa: The feerate things ...
4402020-11-19T19:04:41 <luke-jr> sipa: what we discussed the other night
4412020-11-19T19:04:42 <sipa> sounds like it - if so i think we'll want those in 0.21 anyway i guess
4422020-11-19T19:04:46 <murch> Sending feerates were restricted to >0 instead of >=0
4432020-11-19T19:05:00 <murch> mea culpa, I missed it in the review
4442020-11-19T19:05:01 <MarcoFalke> Also, "" == null 0==null
4452020-11-19T19:05:13 <MarcoFalke> and the third one a minor issue with upgradewallet
4462020-11-19T19:05:24 <sipa> no objection to doing rc1 without them in that case, but if it means there'll be an rc2 anyway.... up to wumpus i guess
4472020-11-19T19:05:31 <wumpus> anyhow right now they're holding up the release
4482020-11-19T19:05:44 <luke-jr> more of a beta1 than a rc1 in that case :P
4492020-11-19T19:05:50 <MarcoFalke> I'd be highly surprised if this was the first major release with just one rc
4502020-11-19T19:06:03 <sipa> ha, fair
4512020-11-19T19:06:08 <MarcoFalke> we'll find more bugs, don't worry
4522020-11-19T19:06:13 <wumpus> anyhow merging the feerate last minute was probaly ill advised so I understand if last minute issues came up
4532020-11-19T19:06:34 <sipa> luke-jr: i wonder why you're the only one hitting this
4542020-11-19T19:06:35 <MarcoFalke> wumpus: It had to be merged (or everything reverted)
4552020-11-19T19:06:45 <sipa> luke-jr: is signing or hashing particularly slow on your system?
4562020-11-19T19:06:47 <luke-jr> wumpus: well, it was really a bugfix for the explicit fee rate mess merged months ago
4572020-11-19T19:06:49 <wumpus> MarcoFalke: yes, but it should have been merged sooner in the release cycle
4582020-11-19T19:06:53 <luke-jr> sipa: I saw it on CI too?
4592020-11-19T19:06:57 <sipa> oh, ok
4602020-11-19T19:06:57 <MarcoFalke> wumpus: Agree
4612020-11-19T19:07:00 <jonatack> I think they've been addressed and those PRs are close to RFM. There is a lot of test coverage in place now, which helps.
4622020-11-19T19:07:04 <MarcoFalke> luke-jr: feature_taproot?
4632020-11-19T19:07:05 <luke-jr> sipa: no reason it would be - I have 16 SMT4 cores
4642020-11-19T19:07:26 <sipa> MarcoFalke: there is a simple fix; aj posted one the other day, i think an even simpler one is possible
4652020-11-19T19:07:29 <sipa> i'll PR soon
4662020-11-19T19:07:32 <MarcoFalke> wumpus: This release is the heavies ever in features merged per time, I think
4672020-11-19T19:07:44 <MarcoFalke> sipa: Thx, I'll ack
4682020-11-19T19:07:59 <luke-jr> MarcoFalke: yes, sorry
4692020-11-19T19:08:01 <MarcoFalke> so the delay was expected
4702020-11-19T19:08:05 <wumpus> MarcoFalke: yes, seems like it :)
4712020-11-19T19:08:13 <luke-jr> MarcoFalke: looks like it simply builds a huge wallet and then times out in coin selection
4722020-11-19T19:08:32 <sipa> yeah, or quadratic hashing of legacy spends
4732020-11-19T19:08:36 <MarcoFalke> luke-jr: No coin selection. It is signrawtxwithwallet
4742020-11-19T19:08:58 <MarcoFalke> (or a bug in the wallet)
4752020-11-19T19:09:16 <luke-jr> I thoguht it was the create
4762020-11-19T19:09:19 <wumpus> it fails on 0.21 branch but not on master?
4772020-11-19T19:09:21 <aj> sipa, luke-jr: want me to PR that patch?
4782020-11-19T19:09:27 <luke-jr> aj: sgtm
4792020-11-19T19:09:37 <MarcoFalke> wumpus: It fails on slow CPUs ;)
4802020-11-19T19:09:48 <luke-jr> MarcoFalke: my CPU is nothing close to slow..
4812020-11-19T19:10:05 <MarcoFalke> CI should be unaffected, because it has the timeouts cranked up to max
4822020-11-19T19:10:08 <wumpus> I haven't noticed any tests failing on master but haven't locally run the tests for the 0.21 branch yet
4832020-11-19T19:10:27 <wumpus> (because there is no divergence yet)
4842020-11-19T19:10:31 <achow101> I've had feature_taproot fail occasionally, but only with the test runner
4852020-11-19T19:10:33 <MarcoFalke> luke-jr: Its not intel, so it doesn't have the speedup-backdoors
4862020-11-19T19:10:58 <sipa> that could be it
4872020-11-19T19:11:03 <MarcoFalke> And running test_runner with high --jobs might also cause it
4882020-11-19T19:11:12 <sipa> SHA-NI hashing is a lot faster
4892020-11-19T19:11:17 <achow101> MarcoFalke: that's what I ran into
4902020-11-19T19:11:47 <jonatack> achow101: same here
4912020-11-19T19:11:54 <wumpus> it would definitely be good to not have the tests dependent on specific intel optimizations :)
4922020-11-19T19:12:00 <sipa> it's just silly
4932020-11-19T19:12:11 <luke-jr> aj's optimisation seems like a good idea even with longer timeouts
4942020-11-19T19:12:14 <sipa> we could also split the test in two, and run it once for post-activation and once for pre-activation
4952020-11-19T19:12:57 <michaelfolkson> sipa said he runs -j60. I'm assuming that is too high. Something like -j5 better?
4962020-11-19T19:13:07 <luke-jr> lol?
4972020-11-19T19:13:36 <wumpus> disable-all-timeouts mode would be useful in that case xD
4982020-11-19T19:13:42 <michaelfolkson> Or that's what I remembered. Am I remembering incorrectly...?
4992020-11-19T19:13:45 <sipa> -j60 works fine here
5002020-11-19T19:13:52 <MarcoFalke> wumpus: The ci runs it, but we can't enable that locally
5012020-11-19T19:13:55 <sipa> and seems around the fastest in overall clock time
5022020-11-19T19:14:00 <luke-jr> michaelfolkson: as long as -j is set sensibly, the number itself shouldn't make problems
5032020-11-19T19:14:03 <MarcoFalke> I guess we can scale the timeout with --jobs
5042020-11-19T19:14:32 <jonatack> michaelfolkson: i've adopted -j60 since sipa mentioned it, and added the suggestion as an option to try in the compile guide
5052020-11-19T19:14:39 <luke-jr> I was getting it 100% of the time, with just the one test
5062020-11-19T19:14:45 <wumpus> I'm not sure that needs to be done automatically, but instructions on how to do it for people running into timeouts would be useful
5072020-11-19T19:15:52 <sipa> luke-jr: i think it's fair to say the test is just broken, and it's masked by the fact that almost everyone runs it on hardware where SHA256 is sufficiently optimized to mask the issue
5082020-11-19T19:16:02 <jonatack> michaelfolkson: (not for make, just for running the functional suite)
5092020-11-19T19:16:03 <wumpus> hehe
5102020-11-19T19:16:14 <MarcoFalke> Jup, each raise of a timeout error could mention "You can use --timeout_factor to scale the timeouts"
5112020-11-19T19:16:27 <luke-jr> MarcoFalke: but it shouldn't be necessary
5122020-11-19T19:16:29 <wumpus> MarcoFalke: good idea!
5132020-11-19T19:16:42 <aj> sipa: seems like there's something wrong with signrawtx in that it's taking 20s (for me) or 30s+ (for luke) as well though
5142020-11-19T19:16:44 <sipa> luke-jr: https://0bin.net/paste/yldL+QX5#hXq0n10PZrK9flMwh2313ueXFAQjPBE2+VaWvKNO+bB
5152020-11-19T19:16:46 <luke-jr> if a test hits it normally, that means the timeout is too low
5162020-11-19T19:16:46 <michaelfolkson> jonatack: Let me try make with -j60... :)
5172020-11-19T19:17:02 <miketwenty1> does -j1 or no -j flag fail?
5182020-11-19T19:17:17 <MarcoFalke> with enough ram you can do -j 999
5192020-11-19T19:17:21 <sipa> miketwenty1: -j1 is just painfully slow
5202020-11-19T19:17:41 <luke-jr> miketwenty1: I was running the test by itself, nothing else
5212020-11-19T19:17:52 <sipa> aj: quadratic hashing of enormous (non-standard!) transactions is a known issue
5222020-11-19T19:17:53 <miketwenty1> i know it's slow i've compiled bitcoin like 5 times today with no -j flag
5232020-11-19T19:17:57 <wumpus> the thing with test timeouts (especially for CPU intensive ones) is that it's kind of a random barrel shoot, you can always have a slower machine where it fails
5242020-11-19T19:17:59 <MarcoFalke> sipa: That patch would still fail intermittently
5252020-11-19T19:18:03 <sipa> MarcoFalke: how so?
5262020-11-19T19:18:12 <luke-jr> miketwenty1: alias make='make -j60'
5272020-11-19T19:18:12 <MarcoFalke> sec ...
5282020-11-19T19:18:14 <jonatack> miketwenty1: use ccache? see doc/productivity.md
5292020-11-19T19:18:33 <jonatack> miketwenty1: also build only what you need
5302020-11-19T19:18:39 <miketwenty1> the hardware that's compiling is purposely small
5312020-11-19T19:18:39 <wumpus> alias invokeoomkiller='make -j60'
5322020-11-19T19:18:44 <luke-jr> wumpus: unless the timeout is set high enough it only fails when there's hanging
5332020-11-19T19:18:52 <luke-jr> wumpus: lol
5342020-11-19T19:18:59 <luke-jr> ok, I really do make -j32
5352020-11-19T19:19:37 <MarcoFalke> sipa: Maybe coin selection picking only the small coins?
5362020-11-19T19:19:38 <luke-jr> (but having it aliased really helps me use it)
5372020-11-19T19:20:27 <sipa> MarcoFalke: how would it fail?
5382020-11-19T19:20:41 <miketwenty1> what is the logical way to calculate how many threads or the -j<n> count you can use for a machine?
5392020-11-19T19:20:53 <MarcoFalke> sipa: It picks a lot of small coins, which takes long to sign?
5402020-11-19T19:21:09 <MarcoFalke> coin selection isn't deterministic and the amounts in the test aren't either
5412020-11-19T19:21:13 <sipa> MarcoFalke: with just 70% of the balance there should be no need for many tiny coins
5422020-11-19T19:21:42 <luke-jr> miketwenty1: start with number of cores + 1
5432020-11-19T19:21:55 <luke-jr> miketwenty1: possibly including SMT in core count
5442020-11-19T19:21:58 <sipa> miketwenty1: for building, not more than your number of threads + 1, and assume around 1 GB of memory per -j
5452020-11-19T19:22:01 <wumpus> miketwenty1: in my experience it's about 1.5GB memory per -j, for the C++ build, for running the functional tests it's different though
5462020-11-19T19:22:19 <sipa> miketwenty1: for functional tests, you can go way higher than what your thread count permits
5472020-11-19T19:22:59 <MarcoFalke> sipa: I guess we could try
5482020-11-19T19:23:12 <michaelfolkson> miketwenty1: https://jonatack.github.io/articles/how-to-compile-bitcoin-core-and-run-the-tests
5492020-11-19T19:23:15 <sipa> MarcoFalke: afaik the pessimal behavior of coin selections only occurs when you're really close to the balance
5502020-11-19T19:23:48 <sipa> luke-jr: does my patch fix things for you? (aj's may work too, i think in general mine may be even faster)
5512020-11-19T19:23:54 <MarcoFalke> Anyway back to the 0.21 topic, I suggest to ship rc1 soon, so that testing can start
5522020-11-19T19:24:01 <wumpus> heh that's like with place and route on FPGAs
5532020-11-19T19:24:06 <luke-jr> sipa: too many worktrees open to test right now, maybe after meeting
5542020-11-19T19:24:11 <sipa> luke-jr: sure
5552020-11-19T19:24:43 <MarcoFalke> If we are lucky and no issues are found we can ship 0.21 early-mid december
5562020-11-19T19:24:48 <wumpus> MarcoFalke: so maybe do a rc1 without merging anything more?
5572020-11-19T19:24:57 <MarcoFalke> I'd say so
5582020-11-19T19:25:12 <wumpus> okay, going to tag it after the meeting
5592020-11-19T19:25:16 <sipa> wumpus: with the plan of doing an rc2 anyway?
5602020-11-19T19:25:20 <luke-jr> I'd call it beta1, but dunno how easy that is
5612020-11-19T19:25:24 <MarcoFalke> sipa: I'd say so too
5622020-11-19T19:25:44 <MarcoFalke> The fixups are just for edge-cases in the rpc
5632020-11-19T19:25:50 <sipa> indeed
5642020-11-19T19:25:52 <MarcoFalke> (and they have tests)
5652020-11-19T19:26:01 <wumpus> right, major versions tend to have 3-5 rcs anyway
5662020-11-19T19:26:15 <sipa> wumpus: if doing rc1 now is fine by you, it's fine by me
5672020-11-19T19:26:23 <wumpus> sure
5682020-11-19T19:26:42 <luke-jr> might want to add a "Known issues" to the announce
5692020-11-19T19:26:46 <luke-jr> so people don't report them
5702020-11-19T19:26:57 <wumpus> I intended to do the rc1 tag right after the branch but was distracted by some msvc version stuff xD
5712020-11-19T19:26:58 <sipa> MarcoFalke: did 17 runs with my patch, no failures
5722020-11-19T19:27:18 <MarcoFalke> sipa: It passed for you before, too
5732020-11-19T19:27:45 <MarcoFalke> luke-jr should test maybe overnight in a loop or so
5742020-11-19T19:27:47 <jonatack> a propos editing the release notes in the wiki, istm that is still feasible until -final, right?
5752020-11-19T19:27:55 <MarcoFalke> jonatack: Jup
5762020-11-19T19:27:58 <wumpus> jonatack: yep
5772020-11-19T19:28:18 <MarcoFalke> About 0.20.2, we should ship that soon as well
5782020-11-19T19:28:20 <MarcoFalke> https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.21.0
5792020-11-19T19:28:24 <luke-jr> MarcoFalke: bonus: I have Chromium building now :P
5802020-11-19T19:28:26 <wumpus> #topic 0.20.2
5812020-11-19T19:28:26 <core-meetingbot> topic: 0.20.2
5822020-11-19T19:28:27 <MarcoFalke> ^ Though, those need review
5832020-11-19T19:28:57 <MarcoFalke> One is a trivial revert (empty diff can be reviewed by anyone)
5842020-11-19T19:29:20 <MarcoFalke> The other is a wallet fix, so needs the wallet people to take a look
5852020-11-19T19:29:46 <MarcoFalke> wrong milestone link (sry)
5862020-11-19T19:29:59 <wumpus> going back and forth on the wtxid relay is a bit ugly, but if there is no confidence in it anymore then it's good to revert it
5872020-11-19T19:30:04 <MarcoFalke> maybe this: https://github.com/bitcoin/bitcoin/milestone/49
5882020-11-19T19:31:12 <MarcoFalke> #link https://github.com/bitcoin/bitcoin/milestone/49
5892020-11-19T19:32:00 <wumpus> I remember it was quite a difficult merge in the first place, maybe we shouldn't have done it, but I remember some were saying it was really important to get it in at the time
5902020-11-19T19:32:24 <achow101> the wallet fix just does what we do in master. it's not quite a backport because we kind of got to this result in master by accident through 3 or so prs
5912020-11-19T19:32:25 <aj> wumpus: i think there's reasonable confidence, but there's no need for it anymore either
5922020-11-19T19:32:37 <wumpus> aj: what removed the need for it?
5932020-11-19T19:33:16 <sipa> wumpus: https://github.com/bitcoin/bitcoin/pull/20317#issuecomment-727624755
5942020-11-19T19:33:22 <MarcoFalke> achow101: Have the "3 or so prs" touched other parts than just this single function?
5952020-11-19T19:33:29 <achow101> MarcoFalke: yes
5962020-11-19T19:33:38 <aj> wumpus: #19620 which got backported to 0.19 and 0.20 after the wtxid backport PR was already open
5972020-11-19T19:33:41 <gribble> https://github.com/bitcoin/bitcoin/issues/19620 | Add txids with non-standard inputs to reject filter by sdaftuar · Pull Request #19620 · bitcoin/bitcoin · GitHub
5982020-11-19T19:33:44 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
5992020-11-19T19:33:54 <MarcoFalke> achow101: That might make it harder to review
6002020-11-19T19:34:03 <aj> wumpus: (19680 and 19681 were the backports)
6012020-11-19T19:34:13 <wumpus> sipa: thanks
6022020-11-19T19:34:36 <jnewbery> wumpus: should be trivial to back it out. It wasn't actually too difficult to backapply, and as Marco says, if the diff after the revert is empty then it's a trivial ACK
6032020-11-19T19:35:16 <wumpus> jnewbery: yes, it's easy to revert (not much happend on the 0.20 branch since), I was just confused about the change in priorities suddenly
6042020-11-19T19:35:58 <jnewbery> wumpus: me too :)
6052020-11-19T19:36:06 <MarcoFalke> wumpus: I think there was confusion generally, and probably an assumption that no 0.20 release was planned any time soon
6062020-11-19T19:36:52 <wumpus> MarcoFalke: yes, I do remember that we wanted to do the next 0.20 release after 0.21.0
6072020-11-19T19:36:58 <luke-jr> not so sure about the latter
6082020-11-19T19:37:06 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Read error: Connection reset by peer)
6092020-11-19T19:37:23 <MarcoFalke> wumpus: Jup, that was under the assumption that wtxid relay was going to be backported
6102020-11-19T19:37:40 <wumpus> in any case please review the revert and other PRs for 0.20.2
6112020-11-19T19:38:39 <wumpus> when they're merged we can tag 0.20.2rc1 as well
6122020-11-19T19:38:45 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
6132020-11-19T19:39:17 <wumpus> any other topics?
6142020-11-19T19:39:57 <wumpus> I guess we can pick up high priority for review again
6152020-11-19T19:40:21 <wumpus> #topic High priority for review
6162020-11-19T19:40:21 <core-meetingbot> topic: High priority for review
6172020-11-19T19:40:23 <wumpus> https://github.com/bitcoin/bitcoin/projects/8
6182020-11-19T19:40:49 <wumpus> is the current list still relevant?
6192020-11-19T19:41:24 <MarcoFalke> Can I add #19893 ?
6202020-11-19T19:41:26 <gribble> https://github.com/bitcoin/bitcoin/issues/19893 | test: Remove or explain syncwithvalidationinterfacequeue by MarcoFalke · Pull Request #19893 · bitcoin/bitcoin · GitHub
6212020-11-19T19:41:48 <wumpus> sure
6222020-11-19T19:42:47 <jonasschnelli> I just removed #18242 (until the AEAD overhaul has been finalized)
6232020-11-19T19:42:53 <gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
6242020-11-19T19:42:57 <achow101> #20040 pls
6252020-11-19T19:43:00 <gribble> https://github.com/bitcoin/bitcoin/issues/20040 | wallet: Refactor OutputGroups to handle fees and spending eligibility on grouping by achow101 · Pull Request #20040 · bitcoin/bitcoin · GitHub
6262020-11-19T19:45:03 <wumpus> achow101: jonasschnelli added
6272020-11-19T19:45:11 <jnewbery> I'd like to add #19910, which is next in the #19398 sequence
6282020-11-19T19:45:23 <gribble> https://github.com/bitcoin/bitcoin/issues/19910 | net processing: Move peer_map to PeerManager by jnewbery · Pull Request #19910 · bitcoin/bitcoin · GitHub
6292020-11-19T19:45:23 <gribble> https://github.com/bitcoin/bitcoin/issues/19398 | Move remaining application layer data to net processing · Issue #19398 · bitcoin/bitcoin · GitHub
6302020-11-19T19:46:12 <wumpus> jnewbery: added too
6312020-11-19T19:46:32 <jnewbery> thanks wumpus!
6322020-11-19T19:47:43 <wumpus> I think that concludes the meeting, thanks everyone
6332020-11-19T19:47:46 <wumpus> #endmeeting
6342020-11-19T19:47:47 <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
6352020-11-19T19:47:47 <core-meetingbot> Meeting ended Thu Nov 19 19:47:46 2020 UTC.
6362020-11-19T19:47:47 <core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-11-19-19.00.moin.txt
6372020-11-19T19:48:07 <jonatack> o/
6382020-11-19T19:48:35 <nehan> 8
6392020-11-19T19:48:42 <luke-jr> 9
6402020-11-19T19:48:51 <nehan> oops.
6412020-11-19T19:49:26 <sipa> a
6422020-11-19T19:49:34 <achow101> rc1 soon?
6432020-11-19T19:49:36 <luke-jr> ⥠sipa
6442020-11-19T19:49:54 <aj> sipa: your fundrawtx patch seems to take 0.2s rather than 19.8s for me
6452020-11-19T19:51:12 <luke-jr> btw, 0bin is a nuisance for patches⦠:p
6462020-11-19T19:51:42 <sipa> luke-jr: use "copy to clipboard"; that avoids some formatting/indenting
6472020-11-19T19:52:27 <sipa> i want to try the patch on my odroid (as it also has unoptimized SHA256)... but it's been over a year since i logged into it and i have no idea what its password is
6482020-11-19T19:52:35 <sipa> i'm even more surprised it's still running
6492020-11-19T19:52:49 <luke-jr> sipa: yes, and then move the clipboard to my dev side, and can no longer see the patch URL in my BASH history. :/
6502020-11-19T19:53:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6512020-11-19T19:53:13 <bitcoin-git> [bitcoin] laanwj pushed tag v0.21.0rc1: https://github.com/bitcoin/bitcoin/compare/v0.21.0rc1
6522020-11-19T19:53:14 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6532020-11-19T19:53:18 <wumpus> ^^
6542020-11-19T19:53:22 <achow101> \o/
6552020-11-19T19:53:23 <MarcoFalke> \o/
6562020-11-19T19:53:23 <hebasto> \o/
6572020-11-19T19:53:25 <sipa> \o/
6582020-11-19T19:53:26 <luke-jr> oh no
6592020-11-19T19:53:29 <luke-jr> jk
6602020-11-19T19:53:45 <emzy> YES!!!
6612020-11-19T20:00:58 <meshcollider> \o/
6622020-11-19T20:01:22 <emzy> powering up my build machine :)
6632020-11-19T20:01:36 *** gabridome <gabridome!5ff5c0ed@host-95-245-192-237.retail.telecomitalia.it> has joined #bitcoin-core-dev
6642020-11-19T20:02:47 <emzy> And searching my physical PGP-key.
6652020-11-19T20:06:16 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (Remote host closed the connection)
6662020-11-19T20:06:28 <aj> sipa: if i change it from 70% to 99% it takes 1.5s instead
6672020-11-19T20:06:44 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
6682020-11-19T20:07:47 <aj> sipa: but hmm, if i set it to 100% with subtraceFeeFromOutputs I get a "Transaction too large" error, so doesn't this just give the same behaviour as when sendtoaddress was used?
6692020-11-19T20:07:57 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (Read error: Connection reset by peer)
6702020-11-19T20:08:36 <sipa> aj: oh, hmm.
6712020-11-19T20:08:46 <sipa> your approach may be better then
6722020-11-19T20:09:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6732020-11-19T20:09:55 <bitcoin-git> [bitcoin] luke-jr closed pull request #20121: configure: Allow users to explicitly enable libsecp256k1's GMP bignum support (master...secp256k1_allow_bignum) https://github.com/bitcoin/bitcoin/pull/20121
6742020-11-19T20:09:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6752020-11-19T20:11:48 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
6762020-11-19T20:13:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6772020-11-19T20:13:30 <bitcoin-git> [bitcoin] ajtowns opened pull request #20428: tests: split feature_taproot transfer of funds into smaller txs (master...202011-test-taproot-signmany) https://github.com/bitcoin/bitcoin/pull/20428
6782020-11-19T20:13:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6792020-11-19T20:13:34 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
6802020-11-19T20:13:36 *** gabridome <gabridome!5ff5c0ed@host-95-245-192-237.retail.telecomitalia.it> has quit IRC (Remote host closed the connection)
6812020-11-19T20:16:31 *** gabridome <gabridome!5ff5c0ed@host-95-245-192-237.retail.telecomitalia.it> has joined #bitcoin-core-dev
6822020-11-19T20:32:23 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
6832020-11-19T20:34:45 *** proofofkeags <proofofkeags!~proofofke@174-16-212-53.hlrn.qwest.net> has joined #bitcoin-core-dev
6842020-11-19T20:42:38 <luke-jr> sipa: aj: so what do I test now? or all done?
6852020-11-19T20:47:19 <aj> luke-jr: my patch is up at 20428 (above), re-test if you'd like but should be fine
6862020-11-19T20:48:20 *** nckx is now known as jorts
6872020-11-19T20:51:30 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
6882020-11-19T20:54:03 <luke-jr> tACK'd
6892020-11-19T20:54:23 *** jorts is now known as nckx
6902020-11-19T20:58:09 <luke-jr> aj: it'd be a clean merge to both branches if you rebase it onto fac865b72d5c0e01fce74b84ab21e5ebbf069327
6912020-11-19T20:58:10 <aj> sipa: hmmmm.... if i sort the unspends by amount first, i only need the top 500 of them to hit 70% (with ~4200 utxos remaining)
6922020-11-19T20:58:45 <sipa> aj: heh
6932020-11-19T20:59:31 <aj> sipa: top 500 seems to be about 90% of the value
6942020-11-19T20:59:57 <sipa> i think your first "top 500" is a typo
6952020-11-19T21:01:04 <aj> sipa: i was doing them in batches of 500, expecting i'd need more than one batch
6962020-11-19T21:03:08 <aj> luke-jr: rebased on top of the merge commit
6972020-11-19T21:04:50 <sipa> aj: you stated that the top 500 is both 70% and 90%... so i assume one of the two at least is wrong
6982020-11-19T21:05:40 <aj> sipa: it's just under 90%, but the first statement was nevertheless not a typo :)
6992020-11-19T21:06:28 <sipa> ok, not a typo, but still wrong?
7002020-11-19T21:06:31 * sipa very confused
7012020-11-19T21:06:51 <aj> sipa: i was rounding up to the nearest 500
7022020-11-19T21:11:37 <aj> sipa: (i'd tell you how many outputs were need for 70%, but i haven't worked it out yet. presumably it's 390ish?)
7032020-11-19T21:12:31 <sipa> <ultranitmode> rounding up, or rounding the nearest? </ultranitmode>
7042020-11-19T21:13:05 <aj> up, but i wanted to be clear i'm not skipping the next 500!
7052020-11-19T21:13:42 <aj> in case you thought the real answer was -300 coins were needed, i guess
7062020-11-19T21:21:06 <aj> sipa: 270 coins got me to 70%
7072020-11-19T21:22:28 <aj> sipa: so, sort lisunspent, take the 500 with highest amount, and be done with it maybe? or have a check that the top 500 are at least 70% of the total as well?
7082020-11-19T21:23:01 <sipa> aj: pretty sure you can take the top 10 outputs too, and be done with it :)
7092020-11-19T21:23:27 <sipa> only 10 transactions are performed with that amount
7102020-11-19T21:32:34 <miketwenty1> would this typically be the time people built, verified v0.21.0rc1 ? I would like to be signer going forward.
7112020-11-19T21:34:53 <sipa> miketwenty1: if you want to be a gitian signer for rc1, now is the time
7122020-11-19T21:35:11 <miketwenty1> sipa: hold on.. let me put my cape on..
7132020-11-19T21:35:21 <miketwenty1> k ready
7142020-11-19T21:35:34 <achow101> miketwenty1: yes
7152020-11-19T21:35:57 <miketwenty1> so.. i have gitian builds with 1 click.. only thing you need to specify is the tag.. and it builds with terraform module
7162020-11-19T21:36:16 <miketwenty1> im guessing this would belong in bitcoin-core or maybe personal repo
7172020-11-19T21:36:17 *** gabridome <gabridome!5ff5c0ed@host-95-245-192-237.retail.telecomitalia.it> has quit IRC (Remote host closed the connection)
7182020-11-19T21:41:36 *** justan0theruser <justan0theruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 240 seconds)
7192020-11-19T21:42:48 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
7202020-11-19T21:47:01 <luke-jr> aj: does your simplification break if unrelated parts of the test change in the futrue?
7212020-11-19T21:47:38 <sipa> luke-jr: very unlikely
7222020-11-19T21:49:15 *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Remote host closed the connection)
7232020-11-19T21:53:35 *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
7242020-11-19T22:07:09 *** Kiminuo <Kiminuo!~mix@193.9.112.252> has quit IRC (Ping timeout: 260 seconds)
7252020-11-19T22:08:54 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
7262020-11-19T22:12:03 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
7272020-11-19T22:12:04 *** vasild_ is now known as vasild
7282020-11-19T22:13:41 *** braydonf_ <braydonf_!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Remote host closed the connection)
7292020-11-19T22:14:14 *** pehjota1 <pehjota1!~pehjota@178.239.168.171> has quit IRC (Remote host closed the connection)
7302020-11-19T22:15:12 *** lightlike <lightlike!~lightlike@p200300c7ef17e3007c1705fd94e35505.dip0.t-ipconnect.de> has quit IRC (Quit: Leaving)
7312020-11-19T22:17:03 <emzy> where do I get the Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers.tar.gz for the gitian build?
7322020-11-19T22:20:05 <luke-jr> emzy: contrib/macdeploy/README.md
7332020-11-19T22:20:26 <luke-jr> emzy: be prepared for Apple "KYC"
7342020-11-19T22:20:35 <emzy> I have that :)
7352020-11-19T22:21:33 <emzy> https://github.com/bitcoin-core/docs/blob/master/gitian-building/gitian-building-mac-os-sdk.md is than outdated
7362020-11-19T22:21:39 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
7372020-11-19T22:22:20 <achow101> emzy: yes
7382020-11-19T22:25:01 *** cubancorona <cubancorona!~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net> has joined #bitcoin-core-dev
7392020-11-19T22:32:12 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
7402020-11-19T22:33:10 *** Andy2011Zoe <Andy2011Zoe!~Andy2011Z@185.163.110.116> has joined #bitcoin-core-dev
7412020-11-19T22:35:25 *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 240 seconds)
7422020-11-19T22:45:46 *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has quit IRC (Remote host closed the connection)
7432020-11-19T22:48:40 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
7442020-11-19T22:54:22 <miketwenty1> this is my first time doing a complete terraform from scratch build of a bitcoin with gitian process.. can someone tell me if they also got 073aaacb86e8898c4806ed10cd14d54869f31e353f86b60bb83f93ae89a3591d for bitcoin-0.21.0rc1-x86_64-linux-gnu.tar.gz
7452020-11-19T22:55:10 *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev
7462020-11-19T22:59:51 <achow101> miketwenty1: you can check against https://github.com/bitcoin-core/gitian.sigs
7472020-11-19T23:00:07 <miketwenty1> aww didn't know people were already sending them up
7482020-11-19T23:00:51 <miketwenty1> achow101: nice looks like we got the same result.. gives me confidence in this process i made
7492020-11-19T23:01:14 <emzy> 073aaacb86e8898c4806ed10cd14d54869f31e353f86b60bb83f93ae89a3591d bitcoin-0.21.0rc1-x86_64-linux-gnu.tar.gz
7502020-11-19T23:01:20 <emzy> match
7512020-11-19T23:01:25 <achow101> there's also a verify command you can run
7522020-11-19T23:01:58 <miketwenty1> verify against people who have already uploaded right?
7532020-11-19T23:02:05 <achow101> yes
7542020-11-19T23:02:06 <miketwenty1> didn't know you already updated lol
7552020-11-19T23:02:17 <miketwenty1> along with 1 other, hebasto
7562020-11-19T23:02:50 <emzy> I'm still on the macos build.
7572020-11-19T23:02:59 <achow101> my build runs pretty quickly :)
7582020-11-19T23:07:10 <emzy> Now that I have the right xcode version it will be ready soon :)
7592020-11-19T23:10:23 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Quit: WeeChat 2.9)
7602020-11-19T23:32:04 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 260 seconds)
7612020-11-19T23:44:08 *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-ohnvkcxaiqyauzpi> has quit IRC (Quit: Connection closed for inactivity)
7622020-11-19T23:45:34 <miketwenty1> yeah i see we both have PR's open
7632020-11-19T23:46:12 <miketwenty1> why does win have the postfix "unsigned" ? even though we are signing it
7642020-11-19T23:46:52 <luke-jr> miketwenty1: it's referring to the OS vendor signature
7652020-11-19T23:46:57 <luke-jr> that's a 2nd step
7662020-11-19T23:47:18 <sipa> yeah, there'll be a -signed version later, once the signature (of the unsigned one) is posted
7672020-11-19T23:49:02 <miketwenty1> im confused.. like microsoft needs to create public signature for their OS that gitian process is using to create build?]
7682020-11-19T23:49:20 <sipa> miketwenty1: no, cory (who has the codesigning key) creates the signature
7692020-11-19T23:49:43 <sipa> unfortunately there isn't really a distributed way to do OS codesigning
7702020-11-19T23:49:56 <miketwenty1> who does it for linux?
7712020-11-19T23:50:03 <sipa> linux doesn't have codesigning
7722020-11-19T23:50:30 <miketwenty1> is that due to it being oss?
7732020-11-19T23:50:34 <miketwenty1> im not really following this
7742020-11-19T23:50:48 <luke-jr> sipa: well, it does, but the distros do it normally
7752020-11-19T23:50:54 <luke-jr> and it isn't using gitian
7762020-11-19T23:50:59 <sipa> right, and it's done at the package manager leve
7772020-11-19T23:51:03 <sipa> not at the binary level
7782020-11-19T23:51:12 <luke-jr> miketwenty1: basically the Windows/macOS signing is to get around [soft] DRM
7792020-11-19T23:51:32 <luke-jr> miketwenty1: without it, the OS will give users an ugly warning
7802020-11-19T23:51:54 <emzy> is there a doku how to produce the -signed versions?
7812020-11-19T23:52:04 <luke-jr> emzy: there's another gitian .yml
7822020-11-19T23:52:16 <luke-jr> that injects the signature
7832020-11-19T23:52:26 <miketwenty1> i see so this is when users run the .exe they will get a warning if it's "not verified" kinda thing?
7842020-11-19T23:52:40 <luke-jr> also, I don't think Cory has the key anymore⦠but I'm not sure how public it is who does
7852020-11-19T23:52:43 <sipa> miketwenty1: yes, that's its only purpose
7862020-11-19T23:52:52 <luke-jr> the principle is 3 gitian signers before the signature is produced
7872020-11-19T23:53:25 <miketwenty1> well we have 2 in bitcoin-core and emzy and i have PR's :)
7882020-11-19T23:53:31 <fanquake> achow has it #18425
7892020-11-19T23:53:33 <gribble> https://github.com/bitcoin/bitcoin/issues/18425 | releases: Update with new Windows code signing certificate by achow101 · Pull Request #18425 · bitcoin/bitcoin · GitHub
7902020-11-19T23:53:40 <sipa> ah oops
7912020-11-19T23:56:32 *** jonatack <jonatack!~jon@109.202.107.147> has quit IRC (Ping timeout: 260 seconds)
7922020-11-19T23:57:58 <emzy> luke-jr: tnx. I will take a look tomorrow.
7932020-11-19T23:58:48 *** jonatack <jonatack!~jon@213.152.162.104> has joined #bitcoin-core-dev