12020-11-21T00:01:55 *** beng-nl1 <beng-nl1!~beng-nl@217.146.82.202> has quit IRC (Remote host closed the connection)
22020-11-21T00:02:00 *** Guyver2__ <Guyver2__!Guyver@guyver2.xs4all.nl> has quit IRC (Remote host closed the connection)
32020-11-21T00:12:19 *** k3tan172 <k3tan172!~pi@gateway/tor-sasl/k3tan> has joined #bitcoin-core-dev
42020-11-21T00:12:36 *** k3tan172 is now known as k3tan
52020-11-21T00:20:27 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
62020-11-21T00:22:34 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Read error: Connection reset by peer)
72020-11-21T00:23:00 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
82020-11-21T00:24:21 *** eugene-f_ <eugene-f_!~eugene_ff@2604:2000:1383:472b:2133:f154:b78a:8f9d> has joined #bitcoin-core-dev
92020-11-21T00:27:56 *** eugene-ff <eugene-ff!~eugene_ff@cpe-67-247-32-250.nyc.res.rr.com> has quit IRC (Ping timeout: 240 seconds)
102020-11-21T00:32:21 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
112020-11-21T00:47:12 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 256 seconds)
122020-11-21T00:48:28 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.161-165.dynamic.3bb.co.th> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
132020-11-21T00:52:57 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:6c06:f0fd:283a:1f37:de16> has joined #bitcoin-core-dev
142020-11-21T00:55:44 *** xnt14 <xnt14!~xnt14@185.204.1.185> has joined #bitcoin-core-dev
152020-11-21T01:00:02 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
162020-11-21T01:01:02 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Read error: Connection reset by peer)
172020-11-21T01:01:28 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
182020-11-21T01:05:01 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 264 seconds)
192020-11-21T01:10:46 *** Asbestos_Vapor <Asbestos_Vapor!~Mercury_V@174-082-166-092.res.spectrum.com> has quit IRC (Quit: Leaving)
202020-11-21T01:15:34 *** Mercury_Vapor <Mercury_Vapor!~Mercury_V@174-082-166-092.res.spectrum.com> has joined #bitcoin-core-dev
212020-11-21T01:23:44 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 240 seconds)
222020-11-21T01:28:35 *** foxp2 <foxp2!~foxp2@ec2-52-73-85-113.compute-1.amazonaws.com> has joined #bitcoin-core-dev
232020-11-21T01:38:31 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
242020-11-21T01:38:37 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
252020-11-21T01:40:29 *** foxp2 <foxp2!~foxp2@ec2-52-73-85-113.compute-1.amazonaws.com> has quit IRC (Quit: \/\/)
262020-11-21T01:40:55 *** foxp2 <foxp2!~foxp2@ec2-52-73-85-113.compute-1.amazonaws.com> has joined #bitcoin-core-dev
272020-11-21T01:49:16 *** nicknick <nicknick!4637b102@bras-base-tsrvpq3101w-grc-11-70-55-177-2.dsl.bell.ca> has joined #bitcoin-core-dev
282020-11-21T01:54:43 *** nicknick <nicknick!4637b102@bras-base-tsrvpq3101w-grc-11-70-55-177-2.dsl.bell.ca> has quit IRC (Remote host closed the connection)
292020-11-21T02:08:16 *** foxp2 <foxp2!~foxp2@ec2-52-73-85-113.compute-1.amazonaws.com> has quit IRC (Quit: \/\/)
302020-11-21T02:11:01 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 264 seconds)
312020-11-21T02:12:33 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
322020-11-21T02:13:25 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 264 seconds)
332020-11-21T02:29:36 *** luke <luke!~luke@bitnomial/staff/luke> has joined #bitcoin-core-dev
342020-11-21T02:38:01 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:6c06:f0fd:283a:1f37:de16> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
352020-11-21T02:42:39 *** mrostecki_ <mrostecki_!~mrostecki@gateway/tor-sasl/mrostecki> has joined #bitcoin-core-dev
362020-11-21T02:43:03 *** mrostecki <mrostecki!~mrostecki@gateway/tor-sasl/mrostecki> has quit IRC (Ping timeout: 240 seconds)
372020-11-21T02:47:29 *** luke <luke!~luke@bitnomial/staff/luke> has quit IRC (Quit: sleep)
382020-11-21T02:58:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
392020-11-21T02:58:40 <bitcoin-git> [bitcoin] fanquake closed pull request #20251: Move major version to first version integer as specified by SemVer (master...semver2) https://github.com/bitcoin/bitcoin/pull/20251
402020-11-21T02:58:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
412020-11-21T03:09:45 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
422020-11-21T03:14:14 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 260 seconds)
432020-11-21T03:35:41 *** proofofkeags <proofofkeags!~proofofke@174-16-212-53.hlrn.qwest.net> has joined #bitcoin-core-dev
442020-11-21T03:54:35 *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
452020-11-21T03:57:56 *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 272 seconds)
462020-11-21T04:22:35 *** twistedline__ <twistedline__!~twisted@2601:14d:8500:d3e0:84e0:58ef:36b6:dc83> has quit IRC (Quit: Leaving)
472020-11-21T04:22:44 *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has joined #bitcoin-core-dev
482020-11-21T04:47:22 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
492020-11-21T05:10:05 *** proofofkeags <proofofkeags!~proofofke@174-16-212-53.hlrn.qwest.net> has quit IRC (Ping timeout: 260 seconds)
502020-11-21T05:10:31 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
512020-11-21T05:11:54 *** Aaronvan_ <Aaronvan_!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
522020-11-21T05:14:59 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 260 seconds)
532020-11-21T05:16:27 *** Aaronvan_ <Aaronvan_!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 260 seconds)
542020-11-21T05:17:27 *** xnt14 <xnt14!~xnt14@185.204.1.185> has quit IRC (Remote host closed the connection)
552020-11-21T05:21:08 *** miketwen_ <miketwen_!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
562020-11-21T05:23:45 *** miketwenty1 <miketwenty1!~miketwent@ec2-18-235-230-166.compute-1.amazonaws.com> has quit IRC (Ping timeout: 240 seconds)
572020-11-21T05:25:25 *** miketwen_ <miketwen_!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 240 seconds)
582020-11-21T05:46:11 *** OldMiner <OldMiner!~OldMiner@178.162.212.214> has joined #bitcoin-core-dev
592020-11-21T06:12:05 *** S3RK <S3RK!~S3RK@116.118.73.180> has quit IRC (Ping timeout: 240 seconds)
602020-11-21T06:22:24 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 240 seconds)
612020-11-21T06:49:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
622020-11-21T06:49:40 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/d4159984c360...816132e6eb23
632020-11-21T06:49:40 <bitcoin-git> bitcoin/master 1b3d700 Jon Atack: Allow zero-fee fundrawtxn and walletcreatefundedpsbt calls
642020-11-21T06:49:41 <bitcoin-git> bitcoin/master 3f1e10b Jon Atack: Update feeRate (BTC/kvB) to fee_rate (sat/vB) in wallet_bumpfee
652020-11-21T06:49:42 <bitcoin-git> bitcoin/master 9f08780 Jon Atack: Use the correct incremental fee constant in bumpfee help
662020-11-21T06:49:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
672020-11-21T06:50:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
682020-11-21T06:50:03 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20426: wallet: allow zero-fee fundrawtransaction/walletcreatefundedpsbt and other fixes (master...fee_rate_followups) https://github.com/bitcoin/bitcoin/pull/20426
692020-11-21T06:50:04 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
702020-11-21T06:53:05 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
712020-11-21T07:11:22 *** jonatack <jonatack!~jon@213.152.162.181> has quit IRC (Ping timeout: 260 seconds)
722020-11-21T07:12:37 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
732020-11-21T07:13:38 *** jonatack <jonatack!~jon@88.124.242.136> has joined #bitcoin-core-dev
742020-11-21T07:16:45 *** gleb6 <gleb6!~gleb@178.150.137.228> has joined #bitcoin-core-dev
752020-11-21T07:16:56 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 240 seconds)
762020-11-21T07:18:05 *** gleb <gleb!~gleb@178.150.137.228> has quit IRC (Ping timeout: 240 seconds)
772020-11-21T07:18:05 *** gleb6 is now known as gleb
782020-11-21T07:21:20 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
792020-11-21T07:26:08 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 256 seconds)
802020-11-21T07:45:10 *** Klox04809318631 <Klox04809318631!~Klox@c-24-1-131-19.hsd1.il.comcast.net> has joined #bitcoin-core-dev
812020-11-21T07:45:23 *** Klox0480931863 <Klox0480931863!~Klox@c-24-1-131-19.hsd1.il.comcast.net> has quit IRC (Read error: Connection reset by peer)
822020-11-21T07:46:20 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
832020-11-21T07:46:34 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Client Quit)
842020-11-21T07:55:04 *** kinlo <kinlo!~peter@unaffiliated/kinlo> has quit IRC (Ping timeout: 240 seconds)
852020-11-21T07:55:59 *** Pavlenex <Pavlenex!~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs> has joined #bitcoin-core-dev
862020-11-21T08:05:09 *** Pavlenex <Pavlenex!~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs> has quit IRC (Quit: Pavlenex)
872020-11-21T08:14:03 *** kinlo <kinlo!~peter@unaffiliated/kinlo> has joined #bitcoin-core-dev
882020-11-21T08:14:33 *** Pavlenex <Pavlenex!~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs> has joined #bitcoin-core-dev
892020-11-21T08:20:24 *** Pavlenex <Pavlenex!~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs> has quit IRC (Quit: Pavlenex)
902020-11-21T08:29:33 *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has quit IRC (Remote host closed the connection)
912020-11-21T08:29:55 *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has joined #bitcoin-core-dev
922020-11-21T08:32:01 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
932020-11-21T08:41:15 <fanquake> achow101: if you wanted to run a test build, I have a branch here that seems to achieve the same thing as 20436, but maybe slightly less "nasty": https://github.com/fanquake/bitcoin/commits/no_echo_fix_clang_qt_determinism_backported
942020-11-21T08:50:02 <wumpus> O3 is the default?
952020-11-21T08:52:34 <wumpus> the highest optimization level also has the highest risk of exposing compiler issues, wouldn't mind turning down the whole thing to O2
962020-11-21T08:56:52 *** jonatack <jonatack!~jon@88.124.242.136> has quit IRC (Ping timeout: 272 seconds)
972020-11-21T08:57:25 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:6c06:8500:38e7:4522:4d5> has joined #bitcoin-core-dev
982020-11-21T08:58:01 *** jonatack <jonatack!~jon@213.152.161.69> has joined #bitcoin-core-dev
992020-11-21T08:58:59 *** Kiminuo <Kiminuo!~mix@141.98.103.124> has joined #bitcoin-core-dev
1002020-11-21T09:13:34 *** Kiminuo <Kiminuo!~mix@141.98.103.124> has quit IRC (Ping timeout: 260 seconds)
1012020-11-21T09:13:43 *** mrostecki_ <mrostecki_!~mrostecki@gateway/tor-sasl/mrostecki> has quit IRC (Ping timeout: 240 seconds)
1022020-11-21T09:16:04 *** Pavlenex <Pavlenex!~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs> has joined #bitcoin-core-dev
1032020-11-21T09:16:45 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:6c06:8500:38e7:4522:4d5> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
1042020-11-21T09:17:45 *** rm95 <rm95!bcd265d8@188.210.101.216> has joined #bitcoin-core-dev
1052020-11-21T09:17:51 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1062020-11-21T09:18:52 <fanquake> wumpus: I havenât looked at the qt code, but yes apparently so.
1072020-11-21T09:22:29 *** Pavlenex <Pavlenex!~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs> has quit IRC (Quit: Pavlenex)
1082020-11-21T09:41:42 <wumpus> fanquake: but making it macos scoped is a good idea at least I guess
1092020-11-21T09:44:10 <wumpus> it looks like mypy is not running on the python scripts in contrib/devtools in the CI
1102020-11-21T09:44:59 <wumpus> my glaring mistake in read_symbols in #20434 just passed (I've tried with mypy locally and did complain there)
1112020-11-21T09:45:01 <gribble> https://github.com/bitcoin/bitcoin/issues/20434 | contrib: Parse ELF directly for symbol and security checks by laanwj · Pull Request #20434 · bitcoin/bitcoin · GitHub
1122020-11-21T09:46:40 <wumpus> not a very important concern but I guess if we have these type specifications and don't check them they'll be out of whack complately in no time
1132020-11-21T09:50:45 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 240 seconds)
1142020-11-21T09:51:26 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
1152020-11-21T09:51:33 <fanquake> wumpus: yea I added most of the annotations, but we never hooked up a linter. Probably worth it now that you're writing pixie from scratch
1162020-11-21T09:53:44 <wumpus> I've tried to change the linter to mypy all .py files it gives a weird error about a duplicate module 'test_runner' (which should be allowed they're in different directories), so I see why it's only enabled for specific paths
1172020-11-21T09:54:41 <wumpus> aha it needs to be run per package you can't just run it over the whole tree https://github.com/python/mypy/issues/4008
1182020-11-21T09:55:50 <wumpus> fair enough I'll just add contrib/devtools though there are some more things that need to be fixed before it passes (not caused by my PR)
1192020-11-21T09:56:46 <wumpus> and I don't even have type annotations in pixie itself yet
1202020-11-21T09:57:52 *** rm95 <rm95!bcd265d8@188.210.101.216> has quit IRC (Remote host closed the connection)
1212020-11-21T09:57:53 <fanquake> I'm happy to fix up anything else in there
1222020-11-21T10:00:14 <wumpus> two in circular-dependencies and one in security-check.py to do with macos: https://0bin.net/paste/TbGa7dzE#1zLWR4E0d6EA04YtkIEq5Ss3ZuGUljw7Hru9PxEkvMZ
1232020-11-21T10:00:17 <gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
1242020-11-21T10:03:23 <fanquake> cool
1252020-11-21T10:09:45 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
1262020-11-21T10:14:01 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 246 seconds)
1272020-11-21T10:38:37 *** DeanWeen <DeanWeen!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
1282020-11-21T10:38:37 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1292020-11-21T10:38:46 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1302020-11-21T10:38:57 *** DeanWeen <DeanWeen!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
1312020-11-21T10:51:10 *** ghost43_ <ghost43_!~daer@gateway/tor-sasl/daer> has quit IRC (Quit: Leaving)
1322020-11-21T10:51:27 *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
1332020-11-21T11:02:57 *** mrostecki_ <mrostecki_!~mrostecki@gateway/tor-sasl/mrostecki> has joined #bitcoin-core-dev
1342020-11-21T11:09:37 <wumpus> gah adding type hints to pixie turns out to kind of annoying as all the structures are dynamically generated, so you get all kinds of errors like error: "Symbol" has no attribute "st_name"
1352020-11-21T11:10:32 <wumpus> and adding manual hints for all of those would make the code three times longer or so, which feels like fighting python instead of using it
1362020-11-21T11:20:53 *** Alford35Ebert <Alford35Ebert!~Alford35E@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
1372020-11-21T11:21:07 <fanquake> Oh nooo
1382020-11-21T11:32:40 <wumpus> I'm thinking of something quite evil: are the __annotations__ ordered? if so, I could do it the other way around and generate the Structs() from them by defining the various Elf integer types, this would even make the code more similar to elf.h
1392020-11-21T11:34:30 <wumpus> nah don't know if I'm actually gonig to do it, I think the code is fine as-is, could just add a workaround to ElfRecord for mypy to ignore it
1402020-11-21T11:36:45 <wumpus> _base = None # type: Any
1412020-11-21T11:36:47 <wumpus> class ELFRecord(_base):
1422020-11-21T11:36:49 <wumpus> tada
1432020-11-21T11:42:10 <fanquake> hehe
1442020-11-21T11:42:17 <fanquake> Any is the get out of jail free card
1452020-11-21T11:46:13 <wumpus> fwiw it *does seem* __annotations__ is guaranteed to be ordered as in the definitions so you can use type annotations for defining ordered records https://stackoverflow.com/questions/64444638/is-the-order-of-entries-in-class-annotations-consistent-with-their-definitio
1462020-11-21T12:03:31 <wumpus> inheriting from types.SimpleNamespace works too
1472020-11-21T12:04:00 <wumpus> much less ugly
1482020-11-21T12:05:04 <wumpus> and you get a sensible __repr__ for free, yippie
1492020-11-21T12:33:07 *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has quit IRC (Remote host closed the connection)
1502020-11-21T12:33:34 *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has joined #bitcoin-core-dev
1512020-11-21T12:44:15 *** noganoo <noganoo!sid146237@gateway/web/irccloud.com/x-gaeqrijscqapsoic> has quit IRC (Read error: Connection reset by peer)
1522020-11-21T12:44:24 *** noganoo <noganoo!sid146237@gateway/web/irccloud.com/x-jiqyxyrhvhhqazvk> has joined #bitcoin-core-dev
1532020-11-21T13:01:06 *** OldMiner <OldMiner!~OldMiner@178.162.212.214> has quit IRC (Remote host closed the connection)
1542020-11-21T13:07:40 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 272 seconds)
1552020-11-21T13:10:44 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 240 seconds)
1562020-11-21T13:13:16 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
1572020-11-21T13:16:02 *** eugene-f_ <eugene-f_!~eugene_ff@2604:2000:1383:472b:2133:f154:b78a:8f9d> has quit IRC (Remote host closed the connection)
1582020-11-21T13:20:22 <wumpus> pushed the mypy annotations; modern python is pretty neat, I may still do the annotation-based structure generation but we already went a long way from parsing the humongous elfread output to this, I think what would be nice is tests that it works for the range of architectures we support, although the guix/gitian run will help at least a bit there
1592020-11-21T13:22:10 <fanquake> wumpus: sounds good. Looking forward to having a review
1602020-11-21T13:22:23 <fanquake> This new code should be must nicer going forward
1612020-11-21T13:22:39 *** robbiet480 <robbiet480!~robbiet48@178.162.212.214> has joined #bitcoin-core-dev
1622020-11-21T13:22:39 *** belcher_ is now known as belcher
1632020-11-21T13:24:09 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.161.165> has joined #bitcoin-core-dev
1642020-11-21T13:28:26 *** eugene-ff <eugene-ff!~eugene_ff@2604:2000:1383:472b:2133:f154:b78a:8f9d> has joined #bitcoin-core-dev
1652020-11-21T13:30:16 <wumpus> fanquake: thanks!
1662020-11-21T13:32:12 *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
1672020-11-21T13:34:56 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
1682020-11-21T13:35:25 *** Kiminuo <Kiminuo!~mix@141.98.103.124> has joined #bitcoin-core-dev
1692020-11-21T13:35:26 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
1702020-11-21T13:38:26 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 256 seconds)
1712020-11-21T13:47:00 *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
1722020-11-21T13:47:58 <wumpus> oh apparently there is typing.Annotated / PEP 593 to do exactly what I wanted to do (e.g. for annotate fields as struct types, it even has a hypothetical 'struct2' as exmple), buuut it's python 3.9+ ð¤¦
1732020-11-21T13:49:28 <wumpus> I'll leave it for a future TODO
1742020-11-21T13:49:37 *** molz_ <molz_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
1752020-11-21T13:49:57 *** vadorovsky__ <vadorovsky__!~mrostecki@gateway/tor-sasl/mrostecki> has joined #bitcoin-core-dev
1762020-11-21T13:50:20 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 256 seconds)
1772020-11-21T13:52:03 *** mrostecki_ <mrostecki_!~mrostecki@gateway/tor-sasl/mrostecki> has quit IRC (Ping timeout: 240 seconds)
1782020-11-21T13:52:46 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 260 seconds)
1792020-11-21T13:53:32 *** robbiet480 <robbiet480!~robbiet48@178.162.212.214> has quit IRC (Remote host closed the connection)
1802020-11-21T13:54:51 <wumpus> let's see if I can create a lxc environment with alll the cross compilers and create some testing for the symbols/versions detection
1812020-11-21T13:56:28 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1822020-11-21T13:56:28 <bitcoin-git> [bitcoin] fanquake opened pull request #20440: build: fix determinism issue when building qt with Clang 8 (master...no_echo_fix_clang_qt_determinism) https://github.com/bitcoin/bitcoin/pull/20440
1832020-11-21T13:56:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1842020-11-21T13:57:28 <fanquake> That's enough Qt for one Saturday. Good chance we wont even use that patch heh
1852020-11-21T13:59:14 <wumpus> nice! yeah I still think the most effortless and straightforward "fix" seems be to bite the bullet and use llvm 9, but, dunno what the risks of being out of whack with apple's compiler entail really
1862020-11-21T14:00:39 <fanquake> Yea, that's probably what we'll end up doing for 22.0. Don't think we want to be swapping compilers last minute pre-release though.
1872020-11-21T14:00:54 <wumpus> well it's rc1 :)
1882020-11-21T14:01:11 <fanquake> the first of many perhaps
1892020-11-21T14:01:35 <wumpus> that's what I mean, we don't actually have a release yet, rc1 can be considered non-existent so rc2 is rc1
1902020-11-21T14:01:47 <wumpus> effectively
1912020-11-21T14:27:08 *** EricYuzo <EricYuzo!~EricYuzo@84.39.117.57> has joined #bitcoin-core-dev
1922020-11-21T14:34:43 *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
1932020-11-21T14:36:01 *** Alford35Ebert <Alford35Ebert!~Alford35E@static.57.1.216.95.clients.your-server.de> has quit IRC (Ping timeout: 256 seconds)
1942020-11-21T14:41:08 *** miketwenty1 <miketwenty1!~miketwent@ec2-18-235-230-166.compute-1.amazonaws.com> has joined #bitcoin-core-dev
1952020-11-21T15:14:52 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.161.165> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
1962020-11-21T15:29:53 *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1972020-11-21T15:30:38 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 256 seconds)
1982020-11-21T16:10:03 *** shesek <shesek!~shesek@unaffiliated/shesek> has joined #bitcoin-core-dev
1992020-11-21T16:20:02 *** pinheadmz <pinheadmz!~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net> has quit IRC (Remote host closed the connection)
2002020-11-21T16:21:41 *** pinheadmz <pinheadmz!~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
2012020-11-21T16:22:23 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Ping timeout: 240 seconds)
2022020-11-21T16:25:14 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
2032020-11-21T16:34:57 <achow101> fanquake: I have a third solution. I have a patch to qt_intersect_spans that doesn't trigger the bug in llvm. I did 40 or so gitian builds overnight and they all get the same result. https://github.com/achow101/bitcoin/tree/0.21-qpainter-fix
2042020-11-21T16:39:56 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
2052020-11-21T16:47:10 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2062020-11-21T16:47:10 <bitcoin-git> [bitcoin] achow101 opened pull request #20447: depends: Patch qt_intersect_spans to avoid non-deterministic behavior in LLVM 8 (master...0.21-qpainter-fix) https://github.com/bitcoin/bitcoin/pull/20447
2072020-11-21T16:47:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2082020-11-21T16:48:29 <luke-jr> can't we patch or wrap LLVM instead? what's to stop us from accidentally hitting this in our own code in 22.0?
2092020-11-21T16:48:42 <luke-jr> or do we expect LLVM to backport a fix by then?
2102020-11-21T16:49:03 <achow101> luke-jr: I think the plan is to bump to LLVM 9 which fixes this problem
2112020-11-21T16:49:32 <luke-jr> i c
2122020-11-21T16:50:01 <luke-jr> I guess that makes sense - probbly need it for macOS ARM too
2132020-11-21T16:52:08 *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
2142020-11-21T16:52:19 *** miketwenty1 <miketwenty1!~miketwent@ec2-18-235-230-166.compute-1.amazonaws.com> has quit IRC (Ping timeout: 246 seconds)
2152020-11-21T16:58:23 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has quit IRC (Ping timeout: 240 seconds)
2162020-11-21T17:06:00 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has joined #bitcoin-core-dev
2172020-11-21T17:15:58 *** Pavlenex <Pavlenex!~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs> has joined #bitcoin-core-dev
2182020-11-21T17:17:34 <jonatack> wait, are we all supposed to submit a qt proposal? i missed the memo :D
2192020-11-21T17:20:22 <jonatack> (great work though)
2202020-11-21T17:47:39 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
2212020-11-21T17:55:07 *** pinheadmz <pinheadmz!~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net> has quit IRC (Quit: pinheadmz)
2222020-11-21T17:56:54 <wumpus> gah ubuntu bionic gcc-8 with -Wl,-z,separate-code seems to make a printf hello world program about 4MB (from 8kB without), did we notice any size ballooning for bitcoin? (no such problem for gcc 9.3 on focal)
2232020-11-21T18:00:11 <wumpus> looks like it aligns the separated sections to increments of 2MB (and actually stores the zeroes) instead of the page size, only for x86_64 though not other architectures
2242020-11-21T18:06:50 <wumpus> bitcoind x86_64-linux-gnu went from 9.9M to 15M from 0.20.1 to 0.21.0rc1 ... I doubt this is actual code growth, will check another arch just to be sure
2252020-11-21T18:06:55 *** Pavlenex <Pavlenex!~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs> has quit IRC (Quit: Pavlenex)
2262020-11-21T18:07:01 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
2272020-11-21T18:07:07 *** pinheadmz <pinheadmz!~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
2282020-11-21T18:10:43 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 246 seconds)
2292020-11-21T18:11:13 <wumpus> for comparison: aarch64 went from 9.1M to 11M in the same span
2302020-11-21T18:11:20 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 256 seconds)
2312020-11-21T18:11:26 <wumpus> doesn't seem really worrying anyway but I just noticed
2322020-11-21T18:13:21 <wumpus> it's more visible, relatively, for bitcoin-cli which went from 2.8M to 4.6M for x86_64 and 1.8M to 1.9M for aarch64
2332020-11-21T18:13:44 <wumpus> at least it's zeroes so it compresses very well in the tar.gz :-)
2342020-11-21T18:17:17 <jonatack> bitcoin-cli did see additions of -netinfo and -generate, but wow o_O
2352020-11-21T18:24:01 <wumpus> I don't think it matters for memory usage in practice, paging operating systems are never going to read the empty, unreferenced pages; the virtual memory usage doesn't matter on 64 bit; it's just more disk space
2362020-11-21T18:24:38 * jonatack thinks back to when software was delivered with constraints of 4/16/48 KB of RAM
2372020-11-21T18:25:03 <wumpus> heh the times entire games fit into that
2382020-11-21T18:25:10 <jonatack> exactly
2392020-11-21T18:25:40 <wumpus> and to realize that on average, compilers became *better* at optimizing since then
2402020-11-21T18:26:49 <luke-jr> abstractions tend to break those optimisations tho
2412020-11-21T18:27:07 <wumpus> right
2422020-11-21T18:44:58 *** Pavlenex <Pavlenex!~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs> has joined #bitcoin-core-dev
2432020-11-21T18:50:29 *** Pavlenex <Pavlenex!~Thunderbi@109-92-102-11.dynamic.isp.telekom.rs> has quit IRC (Quit: Pavlenex)
2442020-11-21T18:50:34 <luke-jr> I'm confused about unloadwallet's intended behaviour. It looks broken.
2452020-11-21T18:50:59 <luke-jr> it appears that if the RPC request specifies a wallet, AND a wallet is named in the param, it errors even if those two match?
2462020-11-21T18:51:48 *** Kiminuo <Kiminuo!~mix@141.98.103.124> has quit IRC (Ping timeout: 256 seconds)
2472020-11-21T18:51:53 <luke-jr> I can see erroring if they differ, but even then the error message doesn't make sense for that scenario
2482020-11-21T18:51:59 <luke-jr> and the docs don't help
2492020-11-21T18:57:12 <jonatack> Hm, with unloadwallet I see the log printing "Releasing wallet"... but then no confirmation when the operation is completed, nor if it was successful.
2502020-11-21T18:59:01 *** pescador <pescador!~pescador@unaffiliated/pescador> has joined #bitcoin-core-dev
2512020-11-21T18:59:39 <jonatack> and the rpc result object only says "warning": "". i guess this can be improved to be more reassuring for users with funds.
2522020-11-21T19:01:20 <luke-jr> hrm, probabyl warning should be null or absent
2532020-11-21T19:02:27 <jonatack> i'd not show a warning field unless there was a warning to display, and otherwise print "result": "Wallet xyz was successfully unloaded."
2542020-11-21T19:03:18 <jonatack> like with the upgradewallet fixes PR tagged for 0.21
2552020-11-21T19:04:15 <jonatack> it's easy to add, if you're fixing things...happy to review if you do
2562020-11-21T19:04:52 <jonatack> (i agree with you)
2572020-11-21T19:05:24 *** Talkless <Talkless!~Talkless@m83-179-8-120.cust.tele2.lt> has joined #bitcoin-core-dev
2582020-11-21T19:10:34 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
2592020-11-21T19:11:06 <jonatack> even better, a "wallet_name": string field and a "result": "Wallet successfully unloaded.", see #20403
2602020-11-21T19:11:08 <gribble> https://github.com/bitcoin/bitcoin/issues/20403 | wallet: upgradewallet fixes, improvements, test coverage by jonatack · Pull Request #20403 · bitcoin/bitcoin · GitHub
2612020-11-21T19:15:56 *** larryruane <larryruane!uid473749@gateway/web/irccloud.com/x-ebpadwqlxrootpws> has quit IRC (Quit: Connection closed for inactivity)
2622020-11-21T19:15:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2632020-11-21T19:15:58 <bitcoin-git> [bitcoin] luke-jr opened pull request #20448: RPC/Wallet: unloadwallet: Allow specifying wallet_name param matching RPC request, and document behaviour (master...unloadwallet_namematch) https://github.com/bitcoin/bitcoin/pull/20448
2642020-11-21T19:15:59 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2652020-11-21T19:19:51 *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
2662020-11-21T19:28:28 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2672020-11-21T19:28:28 <bitcoin-git> [bitcoin] achow101 opened pull request #20449: build: Fix Windows installer build (master...fix-gitian-installers) https://github.com/bitcoin/bitcoin/pull/20449
2682020-11-21T19:28:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2692020-11-21T19:37:20 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
2702020-11-21T19:43:43 *** vadorovsky__ <vadorovsky__!~mrostecki@gateway/tor-sasl/mrostecki> has quit IRC (Ping timeout: 240 seconds)
2712020-11-21T19:56:51 *** proofofkeags <proofofkeags!~proofofke@174-16-212-53.hlrn.qwest.net> has joined #bitcoin-core-dev
2722020-11-21T20:02:38 *** pescador <pescador!~pescador@unaffiliated/pescador> has quit IRC (Remote host closed the connection)
2732020-11-21T20:06:40 *** pinheadmz <pinheadmz!~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net> has quit IRC (Quit: pinheadmz)
2742020-11-21T20:11:13 *** pinheadmz <pinheadmz!~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
2752020-11-21T20:26:27 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
2762020-11-21T20:29:19 *** queip <queip!~queip@unaffiliated/rezurus> has quit IRC (Ping timeout: 246 seconds)
2772020-11-21T20:36:02 *** dviola <dviola!~diego@unaffiliated/dviola> has joined #bitcoin-core-dev
2782020-11-21T20:38:35 *** queip <queip!~queip@unaffiliated/rezurus> has joined #bitcoin-core-dev
2792020-11-21T20:43:38 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
2802020-11-21T20:50:15 *** queip <queip!~queip@unaffiliated/rezurus> has quit IRC (Excess Flood)
2812020-11-21T20:51:22 *** queip <queip!~queip@unaffiliated/rezurus> has joined #bitcoin-core-dev
2822020-11-21T20:55:43 *** wumpus <wumpus!~ircclient@pdpc/supporter/professional/wumpus> has quit IRC (Quit: brb)
2832020-11-21T20:56:14 *** wumpus <wumpus!~ircclient@pdpc/supporter/professional/wumpus> has joined #bitcoin-core-dev
2842020-11-21T21:37:35 *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
2852020-11-21T21:37:43 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 265 seconds)
2862020-11-21T22:06:54 *** eugene-f_ <eugene-f_!~eugene_ff@2604:2000:1383:472b:3cf1:242e:7a1a:9714> has joined #bitcoin-core-dev
2872020-11-21T22:10:14 *** eugene-ff <eugene-ff!~eugene_ff@2604:2000:1383:472b:2133:f154:b78a:8f9d> has quit IRC (Ping timeout: 264 seconds)
2882020-11-21T22:11:35 *** Talkless <Talkless!~Talkless@m83-179-8-120.cust.tele2.lt> has quit IRC (Quit: Konversation terminated!)
2892020-11-21T22:23:46 *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has quit IRC (Ping timeout: 260 seconds)
2902020-11-21T22:35:59 *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
2912020-11-21T22:45:28 *** cltrbreak_MAD2 <cltrbreak_MAD2!~ctrlbreak@159.2.182.106> has quit IRC (Read error: Connection reset by peer)
2922020-11-21T22:46:56 *** ctrlbreak <ctrlbreak!~ctrlbreak@159.2.182.106> has joined #bitcoin-core-dev
2932020-11-21T23:14:50 *** brianddk <brianddk!47875d9c@71-135-93-156.lightspeed.hstntx.sbcglobal.net> has joined #bitcoin-core-dev
2942020-11-21T23:16:26 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 264 seconds)
2952020-11-21T23:54:21 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.161.165> has joined #bitcoin-core-dev
2962020-11-21T23:59:56 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev