12020-11-25T00:13:50 <achow101> fanquake: https://github.com/achow101/bitcoin/releases/tag/0.21-qpainter-backport
22020-11-25T00:13:57 <achow101> seems to be a strings difference I think
32020-11-25T00:14:05 <achow101> the disassembly all seems to match
42020-11-25T00:19:50 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC ()
52020-11-25T00:21:22 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Read error: Connection reset by peer)
62020-11-25T00:22:01 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
72020-11-25T00:24:57 * fanquake looking
82020-11-25T00:44:38 *** skyikot <skyikot!~skyikot@gateway/tor-sasl/skyikot> has joined #bitcoin-core-dev
92020-11-25T00:46:01 *** noggin77 <noggin77!ce4a6b95@206.74.107.149> has joined #bitcoin-core-dev
102020-11-25T00:46:45 *** noggin77 <noggin77!ce4a6b95@206.74.107.149> has quit IRC (Remote host closed the connection)
112020-11-25T00:50:42 <fanquake> achow: I see a diff like this when comparing all our binaries: https://gist.github.com/fanquake/5a38c523df0e54d24c626c339870082e
122020-11-25T00:51:47 <achow101> i see that now
132020-11-25T00:51:53 <achow101> llvm-objdump didn't show me that
142020-11-25T00:52:57 <achow101> This is likely unrelated to the pr. I think it's reasonable to just ignore my build result
152020-11-25T00:54:53 *** MTennis <MTennis!~Tennis@unaffiliated/tennis> has quit IRC (Quit: Leaving)
162020-11-25T00:57:44 <achow101> i'm very confused by this
172020-11-25T01:03:40 <sipa> fanquake: what function is that in?
182020-11-25T01:04:56 <achow101> sipa: it's related to the version string
192020-11-25T01:12:00 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:7ef3:e1ff:d578:a4d8:f807> has joined #bitcoin-core-dev
202020-11-25T01:16:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
212020-11-25T01:16:12 <bitcoin-git> [bitcoin] luke-jr opened pull request #20484: RPC: Migrate estimatesmartfee return value from "feerate" (BTC/kvB) to "fee_rate" (sat/vB) (master...estimatefee_fee_rate) https://github.com/bitcoin/bitcoin/pull/20484
222020-11-25T01:16:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
232020-11-25T01:24:38 *** lightlike <lightlike!~lightlike@p200300c7ef20d50001f5cb85886820ce.dip0.t-ipconnect.de> has quit IRC (Quit: Leaving)
242020-11-25T01:35:13 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
252020-11-25T01:38:23 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
262020-11-25T01:48:25 <achow101> nuked everything and now I get the same result
272020-11-25T01:49:29 <fanquake> ð
282020-11-25T01:49:47 <fanquake> Going to merge that now.
292020-11-25T01:50:04 <achow101> in other news, I hate build systems :)
302020-11-25T01:50:28 <sipa> ah, the certainties of life...
312020-11-25T02:08:06 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
322020-11-25T02:08:31 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 246 seconds)
332020-11-25T02:08:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
342020-11-25T02:08:41 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/3fae2f95f14d...17294c182039
352020-11-25T02:08:41 <bitcoin-git> bitcoin/0.21 ab23a83 Andrew Chow: Fix QPainter non-determinism on macOS
362020-11-25T02:08:42 <bitcoin-git> bitcoin/0.21 17294c1 fanquake: Merge #20479: Fix QPainter non-determinism on macOS (0.21 backport)
372020-11-25T02:08:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
382020-11-25T02:08:59 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
392020-11-25T02:08:59 <bitcoin-git> [bitcoin] fanquake merged pull request #20479: Fix QPainter non-determinism on macOS (0.21 backport) (0.21...2020_11_qpainter_0_21) https://github.com/bitcoin/bitcoin/pull/20479
402020-11-25T02:09:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
412020-11-25T02:45:01 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
422020-11-25T02:47:24 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 260 seconds)
432020-11-25T02:58:57 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (Read error: Connection reset by peer)
442020-11-25T03:02:32 *** Suntop1 <Suntop1!~Suntop@193.56.252.12> has quit IRC (Remote host closed the connection)
452020-11-25T03:03:36 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
462020-11-25T03:34:00 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
472020-11-25T03:34:23 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
482020-11-25T03:40:19 *** kallewoof <kallewoof!~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac> has joined #bitcoin-core-dev
492020-11-25T03:55:02 *** reallll <reallll!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
502020-11-25T03:57:36 *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 256 seconds)
512020-11-25T04:34:12 *** qubenix <qubenix!~qubenix@66.172.11.228> has quit IRC (Ping timeout: 272 seconds)
522020-11-25T04:44:23 *** qubenix <qubenix!~qubenix@66.172.11.228> has joined #bitcoin-core-dev
532020-11-25T05:12:37 *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-rrhldpecmromrixb> has quit IRC (Quit: Connection closed for inactivity)
542020-11-25T05:24:31 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
552020-11-25T05:36:10 *** Kiminuo <Kiminuo!~mix@141.98.103.172> has joined #bitcoin-core-dev
562020-11-25T05:37:37 *** guest534543 <guest534543!~mix@217.138.199.36> has joined #bitcoin-core-dev
572020-11-25T05:41:19 *** Kiminuo <Kiminuo!~mix@141.98.103.172> has quit IRC (Ping timeout: 256 seconds)
582020-11-25T05:46:17 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
592020-11-25T05:46:39 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
602020-11-25T06:32:52 *** Pavlenex <Pavlenex!~Thunderbi@178.220.103.52> has joined #bitcoin-core-dev
612020-11-25T06:33:56 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 256 seconds)
622020-11-25T06:39:51 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
632020-11-25T06:43:55 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 265 seconds)
642020-11-25T06:44:03 *** skyikot <skyikot!~skyikot@gateway/tor-sasl/skyikot> has quit IRC (Ping timeout: 240 seconds)
652020-11-25T06:51:35 *** guest534543 <guest534543!~mix@217.138.199.36> has quit IRC (Ping timeout: 256 seconds)
662020-11-25T06:54:45 *** zcd-alan <zcd-alan!b70e8545@183.14.133.69> has joined #bitcoin-core-dev
672020-11-25T07:04:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
682020-11-25T07:04:20 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/31c9987976af...ca4a7849420e
692020-11-25T07:04:20 <bitcoin-git> bitcoin/master fac4e13 MarcoFalke: refactor: Change pointer to reference because it can not be null
702020-11-25T07:04:21 <bitcoin-git> bitcoin/master fa69c2c MarcoFalke: wallet: Do not treat default constructed types as None-type
712020-11-25T07:04:21 <bitcoin-git> bitcoin/master ca4a784 MarcoFalke: Merge #20410: wallet: Do not treat default constructed types as None-type
722020-11-25T07:04:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
732020-11-25T07:04:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
742020-11-25T07:04:39 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20410: wallet: Do not treat default constructed types as None-type (master...2011-rpcWalletNoneType) https://github.com/bitcoin/bitcoin/pull/20410
752020-11-25T07:04:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
762020-11-25T07:05:23 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Quit: WeeChat 2.9)
772020-11-25T07:06:24 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
782020-11-25T07:09:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
792020-11-25T07:09:31 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20485: [backport] wallet: Do not treat default constructed types as None-type (0.21...2011-rpcWalletNoneType) https://github.com/bitcoin/bitcoin/pull/20485
802020-11-25T07:09:32 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
812020-11-25T07:10:37 *** miketwenty1 <miketwenty1!~miketwent@ec2-23-21-194-211.compute-1.amazonaws.com> has quit IRC (Remote host closed the connection)
822020-11-25T07:10:41 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:7ef3:e1ff:d578:a4d8:f807> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
832020-11-25T07:19:02 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
842020-11-25T07:21:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
852020-11-25T07:21:56 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ca4a7849420e...efd4cdb81fc7
862020-11-25T07:21:56 <bitcoin-git> bitcoin/master fa05d19 MarcoFalke: test: Fix intermittent issue in mempool_compatibility
872020-11-25T07:21:57 <bitcoin-git> bitcoin/master efd4cdb MarcoFalke: Merge #20456: test: Fix intermittent issue in mempool_compatibility
882020-11-25T07:21:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
892020-11-25T07:22:16 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
902020-11-25T07:22:16 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20456: test: Fix intermittent issue in mempool_compatibility (master...2011-testFixMempool) https://github.com/bitcoin/bitcoin/pull/20456
912020-11-25T07:22:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
922020-11-25T07:22:35 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:7ef3:e1ff:d578:a4d8:f807> has joined #bitcoin-core-dev
932020-11-25T07:23:28 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 256 seconds)
942020-11-25T07:24:21 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
952020-11-25T07:24:21 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20486: test: Fix intermittent issue in mempool_compatibility (0.21...2011-testFixMempool) https://github.com/bitcoin/bitcoin/pull/20486
962020-11-25T07:24:22 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
972020-11-25T07:26:29 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
982020-11-25T07:30:50 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 256 seconds)
992020-11-25T07:35:56 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 256 seconds)
1002020-11-25T07:39:10 *** kristapsk_ <kristapsk_!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
1012020-11-25T07:40:26 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:7ef3:e1ff:d578:a4d8:f807> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
1022020-11-25T07:44:03 *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Ping timeout: 240 seconds)
1032020-11-25T07:45:15 <wumpus> okay let's tag rc2!
1042020-11-25T07:45:22 *** romanz <romanz!~romanz@bzq-84-109-216-152.red.bezeqint.net> has joined #bitcoin-core-dev
1052020-11-25T07:45:43 <fanquake> ð
1062020-11-25T07:54:25 <wumpus> rc2 added two translation messages (seemingly to do with wallet GUI)
1072020-11-25T07:56:51 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@67.23.55.162> has joined #bitcoin-core-dev
1082020-11-25T07:58:30 *** Pavlenex <Pavlenex!~Thunderbi@178.220.103.52> has quit IRC (Quit: Pavlenex)
1092020-11-25T08:01:06 *** Pavlenex <Pavlenex!~Thunderbi@178.220.103.52> has joined #bitcoin-core-dev
1102020-11-25T08:03:50 *** reallll is now known as belcher
1112020-11-25T08:10:10 <sipa> w00t
1122020-11-25T08:18:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1132020-11-25T08:18:06 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/17294c182039...7264bcd20f70
1142020-11-25T08:18:06 <bitcoin-git> bitcoin/0.21 ba19f9b Wladimir J. van der Laan: build: Bump RC to rc2
1152020-11-25T08:18:07 <bitcoin-git> bitcoin/0.21 7264bcd Wladimir J. van der Laan: qt: Pre-rc2 translations update
1162020-11-25T08:18:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1172020-11-25T08:18:45 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1182020-11-25T08:18:45 <bitcoin-git> [bitcoin] laanwj pushed tag v0.21.0rc2: https://github.com/bitcoin/bitcoin/compare/v0.21.0rc2
1192020-11-25T08:18:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1202020-11-25T08:22:43 <wumpus> I'm suddenly seeing really strange behavior with gen-manpages.sh: all \- seem to be removed? (see https://github.com/laanwj/bitcoin/commit/d552e128254621fe6f4a44cb59a7759ad4b29f40 ) might be a local issue, not pushing a manual pages update
1212020-11-25T08:24:06 <wumpus> have fun building rc2 anyhow :)
1222020-11-25T08:27:03 <fanquake> manpage gremlins
1232020-11-25T08:27:20 * fanquake started trying to build 0.21.1rc1
1242020-11-25T08:27:43 <wumpus> remove non-determinism in one place and ...
1252020-11-25T08:30:00 <wumpus> the issue is the 'sed -i "s/\\\-${BTCVER[1]}//g" ${MANDIR}/${cmdname}.1', ${BTCVER[1]} evaluates to an empty string
1262020-11-25T08:30:17 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
1272020-11-25T08:31:41 <wumpus> what triggered this is that I ran it after tagging, there is still some weirdness in the version script with tags, generating a different kind of version spec
1282020-11-25T08:32:04 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
1292020-11-25T08:34:24 <wumpus> how easy commands like sed turn into run-away gremlins gives me shivers but at least this shouldn't normally happen
1302020-11-25T08:36:04 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 260 seconds)
1312020-11-25T08:49:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1322020-11-25T08:49:35 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/efd4cdb81fc7...1e9e4b68f3cb
1332020-11-25T08:49:36 <bitcoin-git> bitcoin/master e95aaef Niklas Gögge: build: Avoid secp256k1.h include from system
1342020-11-25T08:49:36 <bitcoin-git> bitcoin/master 1e9e4b6 Wladimir J. van der Laan: Merge #20469: build: Avoid secp256k1.h include from system
1352020-11-25T08:49:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1362020-11-25T08:49:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1372020-11-25T08:49:55 <bitcoin-git> [bitcoin] laanwj merged pull request #20469: build: Avoid secp256k1.h include from system (master...fixincludeorder) https://github.com/bitcoin/bitcoin/pull/20469
1382020-11-25T08:49:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1392020-11-25T08:53:31 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
1402020-11-25T08:57:45 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
1412020-11-25T09:01:31 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1422020-11-25T09:11:24 *** m9aq <m9aq!~m9aq@106.37.187.213> has joined #bitcoin-core-dev
1432020-11-25T09:11:26 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
1442020-11-25T09:15:27 *** vasild_ is now known as vasild
1452020-11-25T09:17:42 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 256 seconds)
1462020-11-25T09:28:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1472020-11-25T09:28:03 <bitcoin-git> [bitcoin] practicalswift opened pull request #20487: draft: Add syscall sandboxing using seccomp-bpf (Linux secure computing mode) (master...seccomp-bpf-2020-11) https://github.com/bitcoin/bitcoin/pull/20487
1482020-11-25T09:28:04 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1492020-11-25T09:29:04 *** Kiminuo <Kiminuo!~mix@217.138.199.36> has joined #bitcoin-core-dev
1502020-11-25T09:32:06 *** Kiminuo <Kiminuo!~mix@217.138.199.36> has quit IRC (Client Quit)
1512020-11-25T09:32:29 *** Kiminuo <Kiminuo!~mix@217.138.199.36> has joined #bitcoin-core-dev
1522020-11-25T09:32:32 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1532020-11-25T09:41:25 *** Bullit <Bullit!~Bullit01@042-236-158-163.dynamic.caiway.nl> has joined #bitcoin-core-dev
1542020-11-25T09:42:25 *** Bullit <Bullit!~Bullit01@042-236-158-163.dynamic.caiway.nl> has quit IRC (Remote host closed the connection)
1552020-11-25T09:42:53 *** Bullit <Bullit!~Bullit01@042-236-158-163.dynamic.caiway.nl> has joined #bitcoin-core-dev
1562020-11-25T09:44:14 *** Bullit <Bullit!~Bullit01@042-236-158-163.dynamic.caiway.nl> has quit IRC (Remote host closed the connection)
1572020-11-25T09:45:34 *** Bullit <Bullit!~Bullit01@042-236-158-163.dynamic.caiway.nl> has joined #bitcoin-core-dev
1582020-11-25T09:52:43 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
1592020-11-25T09:58:45 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 240 seconds)
1602020-11-25T10:03:55 *** zcd-alan <zcd-alan!b70e8545@183.14.133.69> has quit IRC (Remote host closed the connection)
1612020-11-25T10:04:31 *** kexkey <kexkey!~kexkey@static-198-54-132-118.cust.tzulo.com> has quit IRC (Ping timeout: 246 seconds)
1622020-11-25T10:11:05 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Quit: WeeChat 2.9)
1632020-11-25T10:12:26 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
1642020-11-25T10:13:41 <Kiminuo> https://github.com/bitcoin/bitcoin/issues/20488 I would be very grateful for any feedback on this.
1652020-11-25T10:26:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1662020-11-25T10:26:00 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/7264bcd20f70...4e964094dbcb
1672020-11-25T10:26:00 <bitcoin-git> bitcoin/0.21 fa05d19 MarcoFalke: test: Fix intermittent issue in mempool_compatibility
1682020-11-25T10:26:01 <bitcoin-git> bitcoin/0.21 4e96409 MarcoFalke: Merge #20486: [backport] test: Fix intermittent issue in mempool_compatibi...
1692020-11-25T10:26:04 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1702020-11-25T10:26:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1712020-11-25T10:26:20 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20486: [backport] test: Fix intermittent issue in mempool_compatibility (0.21...2011-testFixMempool) https://github.com/bitcoin/bitcoin/pull/20486
1722020-11-25T10:26:21 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1732020-11-25T10:26:50 *** m9aq <m9aq!~m9aq@106.37.187.213> has quit IRC (Quit: m9aq)
1742020-11-25T10:27:27 *** robotadam1 <robotadam1!~robotadam@s91904426.blix.com> has joined #bitcoin-core-dev
1752020-11-25T10:28:14 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1762020-11-25T10:28:14 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/4e964094dbcb...d47d16025e21
1772020-11-25T10:28:15 <bitcoin-git> bitcoin/0.21 fac4e13 MarcoFalke: refactor: Change pointer to reference because it can not be null
1782020-11-25T10:28:15 <bitcoin-git> bitcoin/0.21 fa69c2c MarcoFalke: wallet: Do not treat default constructed types as None-type
1792020-11-25T10:28:16 <bitcoin-git> bitcoin/0.21 d47d160 MarcoFalke: Merge #20485: [backport] wallet: Do not treat default constructed types as...
1802020-11-25T10:28:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1812020-11-25T10:28:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1822020-11-25T10:28:34 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20485: [backport] wallet: Do not treat default constructed types as None-type (0.21...2011-rpcWalletNoneType) https://github.com/bitcoin/bitcoin/pull/20485
1832020-11-25T10:28:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1842020-11-25T10:40:31 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1852020-11-25T10:45:00 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
1862020-11-25T10:47:21 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
1872020-11-25T10:56:28 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 260 seconds)
1882020-11-25T11:00:57 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
1892020-11-25T11:01:00 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Remote host closed the connection)
1902020-11-25T11:01:18 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
1912020-11-25T11:03:42 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
1922020-11-25T11:08:36 *** provoostenator <provoostenator!~quassel@provoostenator.sprovoost.nl> has quit IRC (Remote host closed the connection)
1932020-11-25T11:11:02 *** provoostenator <provoostenator!~quassel@provoostenator.sprovoost.nl> has joined #bitcoin-core-dev
1942020-11-25T11:18:33 *** Domenica84Connel <Domenica84Connel!~Domenica8@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
1952020-11-25T11:21:57 *** provoostenator <provoostenator!~quassel@provoostenator.sprovoost.nl> has quit IRC (Ping timeout: 272 seconds)
1962020-11-25T11:22:02 *** provoostenator_ <provoostenator_!~quassel@provoostenator.sprovoost.nl> has joined #bitcoin-core-dev
1972020-11-25T11:22:48 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 265 seconds)
1982020-11-25T11:29:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1992020-11-25T11:29:46 <bitcoin-git> [bitcoin] sipsorcery opened pull request #20489: CI msvc: only build vcpkg dependencies for release (not debug) to reduce build times (master...msvc_vcpkg_relonly) https://github.com/bitcoin/bitcoin/pull/20489
2002020-11-25T11:29:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2012020-11-25T11:29:56 *** Domenica84Connel <Domenica84Connel!~Domenica8@static.57.1.216.95.clients.your-server.de> has quit IRC (Ping timeout: 240 seconds)
2022020-11-25T11:33:57 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
2032020-11-25T11:35:03 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
2042020-11-25T11:39:27 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 256 seconds)
2052020-11-25T11:48:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2062020-11-25T11:48:30 <bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/1e9e4b68f3cb...afdfd3c8c1ce
2072020-11-25T11:48:30 <bitcoin-git> bitcoin/master c46c18b Jon Atack: wallet: refactor GetClosestWalletFeature()
2082020-11-25T11:48:31 <bitcoin-git> bitcoin/master 2498b04 Andrew Chow: Don't upgrade to HD split if it is already supported
2092020-11-25T11:48:32 <bitcoin-git> bitcoin/master 99d56e3 Jon Atack: wallet: fix and improve upgradewallet result responses
2102020-11-25T11:48:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2112020-11-25T11:48:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2122020-11-25T11:48:49 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20403: wallet: upgradewallet fixes, improvements, test coverage (master...upgradewallet-improvements) https://github.com/bitcoin/bitcoin/pull/20403
2132020-11-25T11:48:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2142020-11-25T11:50:22 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
2152020-11-25T11:51:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2162020-11-25T11:51:33 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20490: [backport] wallet: upgradewallet fixes, improvements, test coverage (0.21...2011-backportWalletUpgrade) https://github.com/bitcoin/bitcoin/pull/20490
2172020-11-25T11:51:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2182020-11-25T12:08:30 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@67.23.55.162> has quit IRC (Ping timeout: 256 seconds)
2192020-11-25T12:10:03 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
2202020-11-25T12:14:45 *** Aaronvan_ <Aaronvan_!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
2212020-11-25T12:18:19 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 272 seconds)
2222020-11-25T12:24:22 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
2232020-11-25T12:27:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2242020-11-25T12:27:23 <bitcoin-git> [bitcoin] hebasto opened pull request #20491: Drop noop gcc version checks (master...201125-gcc) https://github.com/bitcoin/bitcoin/pull/20491
2252020-11-25T12:27:24 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2262020-11-25T12:39:17 <gleb> jnewbery: Thanks for catching what seems to be a mistake in asmap supplying implementation! We should make a fix, a couple more eyes would be useful as well, just to confirm our understanding.
2272020-11-25T12:39:19 <gleb> https://github.com/bitcoin/bitcoin/pull/16702/files/3c1bc40205a3fcab606e70b0e3c13d68b2860e34#r530338668
2282020-11-25T12:40:31 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Quit: Leaving)
2292020-11-25T12:44:26 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Remote host closed the connection)
2302020-11-25T12:59:57 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.161.165> has joined #bitcoin-core-dev
2312020-11-25T13:00:37 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
2322020-11-25T13:03:56 *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 240 seconds)
2332020-11-25T13:15:09 *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
2342020-11-25T13:24:51 *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has quit IRC (Remote host closed the connection)
2352020-11-25T13:25:23 *** Aaronvan_ <Aaronvan_!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
2362020-11-25T13:31:45 *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has joined #bitcoin-core-dev
2372020-11-25T13:32:19 *** mira <mira!5631fc9d@ip-86-49-252-157.net.upcbroadband.cz> has joined #bitcoin-core-dev
2382020-11-25T13:32:42 *** mira is now known as Guest78554
2392020-11-25T13:33:58 *** Pavlenex <Pavlenex!~Thunderbi@178.220.103.52> has quit IRC (Quit: Pavlenex)
2402020-11-25T13:35:21 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
2412020-11-25T13:35:52 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has quit IRC (Remote host closed the connection)
2422020-11-25T13:38:43 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
2432020-11-25T13:40:24 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
2442020-11-25T13:41:21 <wumpus> finally got around to pushing my gitian sigs for 0.21.0rc2
2452020-11-25T13:43:11 <wumpus> all osx matching up to now that's reassuring
2462020-11-25T13:47:56 *** pinheadm_ <pinheadm_!~pinheadmz@91.207.175.28> has joined #bitcoin-core-dev
2472020-11-25T13:50:25 *** pinheadmz <pinheadmz!~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net> has quit IRC (Ping timeout: 240 seconds)
2482020-11-25T13:53:32 *** robotadam1 <robotadam1!~robotadam@s91904426.blix.com> has quit IRC (Remote host closed the connection)
2492020-11-25T14:04:30 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 256 seconds)
2502020-11-25T14:04:41 <vasild> rc versions are not published to https://bitcoincore.org/bin/?
2512020-11-25T14:05:04 <wumpus> vasild: they are
2522020-11-25T14:05:06 <hebasto> no signed rc for now
2532020-11-25T14:05:29 <wumpus> see e.g. https://bitcoincore.org/bin/bitcoin-core-0.20.0/test.rc2/
2542020-11-25T14:05:44 <wumpus> but this rc1 was dead on arrival
2552020-11-25T14:05:55 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
2562020-11-25T14:06:18 <vasild> ah, then it would be easy to upgrade the freebsd port to some rc
2572020-11-25T14:06:25 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
2582020-11-25T14:07:43 <vasild> because it expects to download the source code from https://bitcoincore.org/bin/...
2592020-11-25T14:09:04 *** Chris_Stewart_5 <Chris_Stewart_5!~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383> has quit IRC (Ping timeout: 265 seconds)
2602020-11-25T14:09:08 <vasild> that may help get more than 5 0.21.0 installations (according to https://bitnodes.io/nodes/)
2612020-11-25T14:14:39 *** Chris_Stewart_5 <Chris_Stewart_5!~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383> has joined #bitcoin-core-dev
2622020-11-25T14:20:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2632020-11-25T14:20:27 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/afdfd3c8c1ce...5c0aebfcd42a
2642020-11-25T14:20:27 <bitcoin-git> bitcoin/master 62733fe Cory Fields: span: (almost) match std::span's constructor behavior
2652020-11-25T14:20:28 <bitcoin-git> bitcoin/master 1d58cc7 Cory Fields: span: add lifetimebound attribute
2662020-11-25T14:20:29 <bitcoin-git> bitcoin/master e3e7446 Cory Fields: Add lifetimebound to attributes for general-purpose usage
2672020-11-25T14:20:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2682020-11-25T14:20:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2692020-11-25T14:20:55 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19387: span: update constructors to match c++20 draft spec and add lifetimebound attribute (master...lifetimebound2) https://github.com/bitcoin/bitcoin/pull/19387
2702020-11-25T14:20:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2712020-11-25T14:23:49 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.161.165> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
2722020-11-25T14:24:17 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
2732020-11-25T14:26:57 <kanzure> hi, when adding keys to a git repo, i think it would be good practice to also paste the armored key into the pull request text or comments because some folks follow by email and that's a good redundancy
2742020-11-25T14:28:53 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 256 seconds)
2752020-11-25T14:39:53 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2762020-11-25T14:39:53 <bitcoin-git> [bitcoin] ryanofsky opened pull request #20494: refactor: Move node and wallet code out of src/interfaces (master...pr/ipc-mv) https://github.com/bitcoin/bitcoin/pull/20494
2772020-11-25T14:39:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2782020-11-25T14:43:44 *** andyrtr1 <andyrtr1!~andyrtr@178.239.168.171> has joined #bitcoin-core-dev
2792020-11-25T14:45:05 *** Guest78554 <Guest78554!5631fc9d@ip-86-49-252-157.net.upcbroadband.cz> has quit IRC (Ping timeout: 245 seconds)
2802020-11-25T14:48:22 <wumpus> kanzure: agree
2812020-11-25T14:48:32 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
2822020-11-25T15:05:37 <wumpus> do we ever add actual keys to a repository these days though? I think we only have fingerprints
2832020-11-25T15:06:04 <wumpus> the actual keys became both too big and too big a hassle to keep up to date
2842020-11-25T15:10:25 *** miketwenty1 <miketwenty1!~miketwent@ec2-35-174-232-195.compute-1.amazonaws.com> has joined #bitcoin-core-dev
2852020-11-25T15:11:11 *** skyikot <skyikot!~skyikot@gateway/tor-sasl/skyikot> has joined #bitcoin-core-dev
2862020-11-25T15:12:39 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
2872020-11-25T15:30:22 *** Kiminuo <Kiminuo!~mix@217.138.199.36> has quit IRC (Ping timeout: 246 seconds)
2882020-11-25T15:33:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2892020-11-25T15:33:43 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5c0aebfcd42a...19b8071eaeb3
2902020-11-25T15:33:43 <bitcoin-git> bitcoin/master fa18e7c Aaron Clauson: This change to the appveyor CI config for msvc builds reverses a change in...
2912020-11-25T15:33:44 <bitcoin-git> bitcoin/master 19b8071 MarcoFalke: Merge #20489: CI msvc: only build vcpkg dependencies for release (not debu...
2922020-11-25T15:33:45 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2932020-11-25T15:33:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2942020-11-25T15:33:58 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20489: CI msvc: only build vcpkg dependencies for release (not debug) to reduce build times (master...msvc_vcpkg_relonly) https://github.com/bitcoin/bitcoin/pull/20489
2952020-11-25T15:33:59 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2962020-11-25T15:36:02 <elichai2> I'm looking at `IsInitialBlockDownload` and it's only does local checks on the state. do we anywhere check if another peer has a "better" chain and then start IBD from them?
2972020-11-25T15:37:50 *** _Sam314-- <_Sam314--!~sam@unaffiliated/iamthemusicman> has joined #bitcoin-core-dev
2982020-11-25T15:38:15 <_Sam314--> luke-jr, you are a despicable disgusting heap of rancid donkey shit.
2992020-11-25T15:42:33 <MarcoFalke> elichai2: FindNextBlocksToDownload?
3002020-11-25T15:44:11 <sipa> elichai2: IsIBD really has fairly little todo with the actual block download; it just informs a few heustistics
3012020-11-25T15:45:26 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
3022020-11-25T15:47:52 <elichai2> sipa: so the "meat" of IBD is in `FindNextBlocksToDownload`? I see it is called under some condition for a `getdata` message, but I don't think I understand that condition. I thought it will be like "if my peer and I have more than X blocks apart, do headers first and then change state to IBD and start downloading the blocks"
3032020-11-25T15:48:32 <_Sam314--> what does iritable bowl disease IBD has to do with bitcoin-core now?
3042020-11-25T15:49:25 <_Sam314--> luke-jr is diarreah from my IBD
3052020-11-25T15:50:56 <_Sam314--> btw there's a problem with IBD state in alpha bitcoin core
3062020-11-25T15:51:06 <_Sam314--> when it checks the blocks after rolling them back
3072020-11-25T15:51:17 <_Sam314--> you get a core dump and then have to restart
3082020-11-25T15:51:34 <_Sam314--> at least as of the last git pull i did last week
3092020-11-25T15:52:23 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has quit IRC (Ping timeout: 240 seconds)
3102020-11-25T15:52:25 *** ChanServ sets mode: +b _Sam314--!*@*
3112020-11-25T15:52:26 *** _Sam314-- was kicked by ChanServ (Banned: 1w rude)
3122020-11-25T15:52:39 <pinheadm_> elichai2 findnextblocks... is the meat of all block downloading. At this point, the node has asked all peers for headers and it wants to check if any of those headers are valid and have more chainwork than our own current tip
3132020-11-25T15:52:50 <pinheadm_> if so, we download those blocks and verify them
3142020-11-25T15:52:57 *** _Sam315-- <_Sam315--!~sam@unaffiliated/iamthemusicman> has joined #bitcoin-core-dev
3152020-11-25T15:53:08 <pinheadm_> and then in some cases a reorg is necessary to get our chain to the most work tip
3162020-11-25T15:53:47 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has joined #bitcoin-core-dev
3172020-11-25T15:54:24 *** proofofkeags__ <proofofkeags__!~proofofke@174-16-212-53.hlrn.qwest.net> has quit IRC (Ping timeout: 272 seconds)
3182020-11-25T15:54:58 <sipa> elichai2: headers sync and blocks sync are not sequential processes that run as a separate thread or so; they both always work simultaneously, and are just defined by reactions to incoming messages
3192020-11-25T15:56:20 <sipa> elichai2: FindNextBlock... is primarily called from SendMessages
3202020-11-25T15:56:23 <_Sam315--> the fact that you turd lips harbor a lying a fuckface troll luke-jr who ruined the bitcoin ecosystem with lies is really sad to me.
3212020-11-25T15:57:41 <sipa> elichai2: which just runs periodically for every peer
3222020-11-25T15:58:12 <sipa> it decides based on the current state (which blocks we know the peer has, and which are already in flight) what to download
3232020-11-25T16:03:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3242020-11-25T16:03:10 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/19b8071eaeb3...50091592dd87
3252020-11-25T16:03:10 <bitcoin-git> bitcoin/master 4df6567 Vasil Dimov: sync: make EnterCritical() & push_lock() type safe
3262020-11-25T16:03:11 <bitcoin-git> bitcoin/master 95975dd Vasil Dimov: sync: detect double lock from the same thread
3272020-11-25T16:03:12 <bitcoin-git> bitcoin/master 5009159 Wladimir J. van der Laan: Merge #19337: sync: detect double lock from the same thread
3282020-11-25T16:03:14 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3292020-11-25T16:03:28 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3302020-11-25T16:03:28 <bitcoin-git> [bitcoin] laanwj merged pull request #19337: sync: detect double lock from the same thread (master...detect_double_lock) https://github.com/bitcoin/bitcoin/pull/19337
3312020-11-25T16:03:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3322020-11-25T16:03:35 <hebasto> wumpus: thanks ^
3332020-11-25T16:03:49 <vasild> cool :)
3342020-11-25T16:08:17 <_Sam315--> Thank you for letting me vent, sorry for the interruption. Good day.
3352020-11-25T16:10:33 *** _Sam315-- <_Sam315--!~sam@unaffiliated/iamthemusicman> has left #bitcoin-core-dev ("Leaving")
3362020-11-25T16:14:46 *** kexkey <kexkey!~kexkey@static-198-54-132-150.cust.tzulo.com> has joined #bitcoin-core-dev
3372020-11-25T16:26:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3382020-11-25T16:26:57 <bitcoin-git> [bitcoin] Z5483 closed pull request #19823: ci: check if scripted diff is using BSD sed syntax (master...master) https://github.com/bitcoin/bitcoin/pull/19823
3392020-11-25T16:26:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3402020-11-25T16:29:23 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
3412020-11-25T16:34:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3422020-11-25T16:34:15 <bitcoin-git> [bitcoin] dongcarl opened pull request #20495: sync: Use decltype(auto) return type for WITH_LOCK (master...2020-11-decltype-auto) https://github.com/bitcoin/bitcoin/pull/20495
3432020-11-25T16:34:16 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3442020-11-25T16:41:40 *** jesseposner <jesseposner!~textual@2601:643:8980:bfd2:f8c7:7086:b02c:8117> has joined #bitcoin-core-dev
3452020-11-25T16:42:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3462020-11-25T16:42:49 <bitcoin-git> [bitcoin] hebasto opened pull request #20496: Drop unneeded macOS framework dependencies (master...201125-as) https://github.com/bitcoin/bitcoin/pull/20496
3472020-11-25T16:42:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3482020-11-25T16:42:51 *** jesseposner <jesseposner!~textual@2601:643:8980:bfd2:f8c7:7086:b02c:8117> has quit IRC (Client Quit)
3492020-11-25T16:43:11 *** jesseposner <jesseposner!~jesseposn@2601:643:8980:bfd2:f8c7:7086:b02c:8117> has joined #bitcoin-core-dev
3502020-11-25T16:53:39 *** lightlike <lightlike!~lightlike@p200300c7ef192500384a4babe11cbcaf.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
3512020-11-25T16:54:36 *** pinheadm_ <pinheadm_!~pinheadmz@91.207.175.28> has quit IRC (Quit: pinheadm_)
3522020-11-25T16:55:11 *** pinheadmz <pinheadmz!~pinheadmz@91.207.175.28> has joined #bitcoin-core-dev
3532020-11-25T16:59:30 *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-wgwavzwbrixyodio> has joined #bitcoin-core-dev
3542020-11-25T17:00:53 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
3552020-11-25T17:01:17 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
3562020-11-25T17:02:41 <kanzure> wumpus: well, if keys are too big it's possible to use the unsigned ones (for whatever that's worth!)
3572020-11-25T17:04:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3582020-11-25T17:04:24 <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/d47d16025e21...9facca3ce0ad
3592020-11-25T17:04:24 <bitcoin-git> bitcoin/0.21 c46c18b Jon Atack: wallet: refactor GetClosestWalletFeature()
3602020-11-25T17:04:25 <bitcoin-git> bitcoin/0.21 2498b04 Andrew Chow: Don't upgrade to HD split if it is already supported
3612020-11-25T17:04:26 <bitcoin-git> bitcoin/0.21 99d56e3 Jon Atack: wallet: fix and improve upgradewallet result responses
3622020-11-25T17:04:27 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3632020-11-25T17:04:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3642020-11-25T17:04:43 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20490: [backport] wallet: upgradewallet fixes, improvements, test coverage (0.21...2011-backportWalletUpgrade) https://github.com/bitcoin/bitcoin/pull/20490
3652020-11-25T17:04:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3662020-11-25T17:05:00 *** larryruane_ <larryruane_!uid473749@gateway/web/irccloud.com/x-vuztyjlkacjmkbdi> has joined #bitcoin-core-dev
3672020-11-25T17:14:33 *** proofofkeags <proofofkeags!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has joined #bitcoin-core-dev
3682020-11-25T17:22:00 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
3692020-11-25T17:23:50 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
3702020-11-25T17:29:59 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
3712020-11-25T17:33:08 *** kristapsk_ is now known as kristapsk
3722020-11-25T17:46:24 *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
3732020-11-25T17:48:43 *** Pavlenex <Pavlenex!~Thunderbi@178.220.103.52> has joined #bitcoin-core-dev
3742020-11-25T17:52:05 *** pinheadm_ <pinheadm_!~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
3752020-11-25T17:55:05 *** pinheadmz <pinheadmz!~pinheadmz@91.207.175.28> has quit IRC (Ping timeout: 256 seconds)
3762020-11-25T17:58:06 *** jorgieporgie <jorgieporgie!~jorgiepor@bb115-66-182-100.singnet.com.sg> has joined #bitcoin-core-dev
3772020-11-25T17:59:16 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
3782020-11-25T18:05:09 *** joelklabo <joelklabo!~textual@157-131-101-185.fiber.dynamic.sonic.net> has joined #bitcoin-core-dev
3792020-11-25T18:12:18 *** ricks_ <ricks_!~ricks_@unaffiliated/ricks-/x-3439430> has joined #bitcoin-core-dev
3802020-11-25T18:12:23 *** ricks_ <ricks_!~ricks_@unaffiliated/ricks-/x-3439430> has quit IRC (Client Quit)
3812020-11-25T18:13:24 *** jorgieporgie <jorgieporgie!~jorgiepor@bb115-66-182-100.singnet.com.sg> has quit IRC ()
3822020-11-25T18:31:52 <achow101> gitian builders: 0.21.0rc2 detached sigs are pushed
3832020-11-25T18:38:49 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
3842020-11-25T18:39:39 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
3852020-11-25T18:42:07 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 260 seconds)
3862020-11-25T18:43:49 * hebasto signing
3872020-11-25T18:44:27 * jonatack yoopi
3882020-11-25T18:58:17 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
3892020-11-25T19:20:36 *** miketwenty1 <miketwenty1!~miketwent@ec2-35-174-232-195.compute-1.amazonaws.com> has quit IRC (Ping timeout: 240 seconds)
3902020-11-25T19:25:13 <emzy> I also did it for the first time. Now that I understand it.
3912020-11-25T19:33:55 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
3922020-11-25T19:38:10 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 246 seconds)
3932020-11-25T19:40:18 *** pinheadm_ <pinheadm_!~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net> has quit IRC (Quit: pinheadm_)
3942020-11-25T19:40:33 *** pinheadmz <pinheadmz!~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
3952020-11-25T19:40:49 *** joelklabo <joelklabo!~textual@157-131-101-185.fiber.dynamic.sonic.net> has quit IRC (Quit: My iMac has gone to sleep. ZZZzzzâ¦)
3962020-11-25T19:41:50 *** blanching <blanching!~blanching@195.181.160.175.adsl.inet-telecom.org> has joined #bitcoin-core-dev
3972020-11-25T19:53:26 *** Pavlenex <Pavlenex!~Thunderbi@178.220.103.52> has quit IRC (Quit: Pavlenex)
3982020-11-25T19:55:30 *** Pavlenex <Pavlenex!~Thunderbi@178.220.103.52> has joined #bitcoin-core-dev
3992020-11-25T19:58:24 *** Pavlenex <Pavlenex!~Thunderbi@178.220.103.52> has quit IRC (Client Quit)
4002020-11-25T20:01:03 *** Kiminuo <Kiminuo!~mix@217.138.199.36> has joined #bitcoin-core-dev
4012020-11-25T20:07:16 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4022020-11-25T20:07:16 <bitcoin-git> [bitcoin] sanket1729 opened pull request #20497: [Refactor] Add MAX_STANDARD_SCRIPTSIG_SIZE to policy (master...policy) https://github.com/bitcoin/bitcoin/pull/20497
4032020-11-25T20:07:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4042020-11-25T20:23:13 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
4052020-11-25T20:30:27 *** shesek <shesek!~shesek@164.90.217.137> has joined #bitcoin-core-dev
4062020-11-25T21:05:01 *** lightlike <lightlike!~lightlike@p200300c7ef192500384a4babe11cbcaf.dip0.t-ipconnect.de> has quit IRC (Quit: Leaving)
4072020-11-25T21:14:08 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Read error: Connection reset by peer)
4082020-11-25T21:14:35 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
4092020-11-25T21:34:09 *** blanching <blanching!~blanching@195.181.160.175.adsl.inet-telecom.org> has quit IRC (Quit: blanching)
4102020-11-25T21:36:45 <sipa> when building master, in a clean work dir, empty ccache, configured with "./configure --with-incompatible-bdb", I get:
4112020-11-25T21:36:51 <sipa> /usr/bin/ld: cannot find -lQt5Core
4122020-11-25T21:37:31 <sipa> while configure finds qt5 fine, and "pkg-config Qt5Core --libs" outputs the expected -lQt5Core
4132020-11-25T21:37:36 <sipa> any ideas?
4142020-11-25T21:38:55 <sipa> ubuntu 20.10
4152020-11-25T21:40:43 *** skyikot <skyikot!~skyikot@gateway/tor-sasl/skyikot> has quit IRC (Ping timeout: 240 seconds)
4162020-11-25T21:41:53 <sipa> (i get the same with various other Qt libs)
4172020-11-25T21:47:22 <sipa> same when building with clang
4182020-11-25T21:56:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4192020-11-25T21:56:44 <bitcoin-git> [bitcoin] practicalswift opened pull request #20499: Remove obsolete NODISCARD ifdef forest. Use [[nodiscard]] (C++17). (master...remove-nodiscard-cruft) https://github.com/bitcoin/bitcoin/pull/20499
4202020-11-25T21:56:45 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4212020-11-25T22:27:24 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
4222020-11-25T22:33:48 *** openoms <openoms!~quassel@91.132.136.76> has joined #bitcoin-core-dev
4232020-11-25T22:37:30 *** Kiminuo <Kiminuo!~mix@217.138.199.36> has quit IRC (Ping timeout: 256 seconds)
4242020-11-25T22:44:18 *** joelklabo <joelklabo!~textual@157-131-101-185.fiber.dynamic.sonic.net> has joined #bitcoin-core-dev
4252020-11-25T22:54:56 *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 240 seconds)
4262020-11-25T22:55:50 <sipa> vasild: uh, bizarre thing in addrv2 disk serialization... the decision whether to use compactsize nservices is based on the nVersion number stored in CAddress, but the decision whether to use addrv2 ip/network serialization is based on the context only
4272020-11-25T22:55:57 *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has quit IRC (Remote host closed the connection)
4282020-11-25T22:56:21 *** twistedline <twistedline!~twisted@2601:14d:8500:d3e0:69d6:294e:9960:fcd0> has joined #bitcoin-core-dev
4292020-11-25T22:57:48 <sipa> so you can construct a peers.dat file where some addresses use compactsize nServices, and others don't, independent from whether the file format is V3_BIP155 or not)
4302020-11-25T23:02:43 * sipa suggests dropping support for that...
4312020-11-25T23:14:11 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 256 seconds)
4322020-11-25T23:14:21 *** romanz <romanz!~romanz@bzq-84-109-216-152.red.bezeqint.net> has quit IRC (Quit: WeeChat 2.8)
4332020-11-25T23:21:50 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
4342020-11-25T23:35:17 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
4352020-11-25T23:46:26 <fanquake> sipa: did you resolve your linking issue?
4362020-11-25T23:47:58 <sipa> fanquake: no
4372020-11-25T23:48:09 <sipa> i just went back to building with --without-gui
4382020-11-25T23:49:39 <fanquake> hmm ok. Unfortunately I have no answers for you. Other than maybe a missing package.
4392020-11-25T23:52:49 <sipa> /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 exists
4402020-11-25T23:53:04 <sipa> i don't see a libQt5Core.a file though, which i'd expect to exist
4412020-11-25T23:56:06 <sipa> hmm, i don't see any .a files in /usr/lib though, so i suspect those aren't needed anymore when dynamically linking?