12020-12-04T00:01:02 *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-suaydrfreocgdkkl> has quit IRC (Quit: Connection closed for inactivity)
22020-12-04T00:02:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
32020-12-04T00:02:25 <bitcoin-git> [bitcoin] BlockMechanic opened pull request #20565: Android : Ensure pic build for bdb (master...fix-bdb-android) https://github.com/bitcoin/bitcoin/pull/20565
42020-12-04T00:02:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
52020-12-04T00:09:17 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
62020-12-04T00:12:17 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:a1c2:b119:a4c8:3942:7eb> has joined #bitcoin-core-dev
72020-12-04T00:41:18 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 260 seconds)
82020-12-04T00:43:39 *** proofofkeags <proofofkeags!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has quit IRC (Remote host closed the connection)
92020-12-04T00:44:04 *** proofofkeags <proofofkeags!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has joined #bitcoin-core-dev
102020-12-04T00:56:57 *** amiti <amiti!sid373138@gateway/web/irccloud.com/x-ivprtaazvjpsstjf> has quit IRC (Ping timeout: 244 seconds)
112020-12-04T00:56:57 *** valwal_ <valwal_!sid334773@gateway/web/irccloud.com/x-qlebbpueqzhclgdu> has quit IRC (Ping timeout: 244 seconds)
122020-12-04T00:57:45 *** troygiorshev <troygiorshev!~troygiors@d67-193-140-136.home3.cgocable.net> has quit IRC (Quit: leaving)
132020-12-04T00:57:59 *** michagogo <michagogo!sid14316@wikia/Michagogo> has quit IRC (Ping timeout: 244 seconds)
142020-12-04T00:58:18 *** amiti <amiti!sid373138@gateway/web/irccloud.com/x-ayunlkaefenrhtuj> has joined #bitcoin-core-dev
152020-12-04T00:58:21 *** valwal_ <valwal_!sid334773@gateway/web/irccloud.com/x-xpdkkmqnrtcjkded> has joined #bitcoin-core-dev
162020-12-04T00:59:01 *** michagogo <michagogo!sid14316@wikia/Michagogo> has joined #bitcoin-core-dev
172020-12-04T00:59:30 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (Read error: Connection reset by peer)
182020-12-04T00:59:33 *** Emcy_ <Emcy_!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
192020-12-04T01:09:52 *** proofofkeags <proofofkeags!~proofofke@c-73-34-43-4.hsd1.co.comcast.net> has quit IRC (Ping timeout: 246 seconds)
202020-12-04T01:10:40 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
212020-12-04T01:12:53 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC ()
222020-12-04T01:56:47 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
232020-12-04T02:09:29 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
242020-12-04T02:10:46 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 246 seconds)
252020-12-04T02:15:40 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:a1c2:b119:a4c8:3942:7eb> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
262020-12-04T02:17:50 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.167.167> has joined #bitcoin-core-dev
272020-12-04T02:36:04 *** freeyao <freeyao!ac69eb05@172.105.235.5> has joined #bitcoin-core-dev
282020-12-04T02:36:29 *** freeyao <freeyao!ac69eb05@172.105.235.5> has quit IRC (Remote host closed the connection)
292020-12-04T02:42:59 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
302020-12-04T03:00:53 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
312020-12-04T03:03:22 *** pinheadm_ <pinheadm_!~pinheadmz@86.107.55.243> has joined #bitcoin-core-dev
322020-12-04T03:05:52 *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has quit IRC (Ping timeout: 256 seconds)
332020-12-04T03:06:36 *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has joined #bitcoin-core-dev
342020-12-04T03:09:50 *** pinheadm_ <pinheadm_!~pinheadmz@86.107.55.243> has quit IRC (Ping timeout: 256 seconds)
352020-12-04T03:31:27 *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has quit IRC (Quit: pinheadmz)
362020-12-04T03:35:09 *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has joined #bitcoin-core-dev
372020-12-04T03:58:59 *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
382020-12-04T04:10:01 *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has quit IRC (Quit: pinheadmz)
392020-12-04T04:12:03 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
402020-12-04T04:23:46 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
412020-12-04T04:24:13 <andytoshi> how does travis know the subtree remotes? if i try to run the ci/test/06_script.sh script locally i get a bunch of errors like
422020-12-04T04:24:16 <andytoshi> subtree commit 3967d96bf184519eb98b766af665b4d4b072563e unavailable: cannot compare. Did you add and fetch the remote?
432020-12-04T04:24:32 <andytoshi> and i see some manual instructions in the README for how to add these remotes
442020-12-04T04:24:40 <andytoshi> but i don't understand how travis is doing it
452020-12-04T04:32:23 <fanquake> some sort of black magic
462020-12-04T04:32:48 <fanquake> unclear to me as well after a quick look in ci/
472020-12-04T04:32:50 <fanquake> MarcoFalke can probably enlighten us
482020-12-04T04:33:32 <sipa> does travis even check the remotes?
492020-12-04T04:34:33 <fanquake> it's running the subtree checker against all the subtrees, which should require fetching the remotes
502020-12-04T04:36:34 <sipa> sure, but if it doesn"t have the remotes it succeeds with a warning
512020-12-04T04:42:26 <achow101> travis doesn't seem to have those remotes
522020-12-04T04:42:50 <achow101> the most recent job has the same error, but the script doesn't fail so the job doesn't fail
532020-12-04T04:47:26 <sipa> yes, it only does the local check iirc
542020-12-04T04:48:32 <andytoshi> ah cool, i am no longer confused then :)
552020-12-04T04:51:50 <sipa> that script should probablybtake a cmdline argument to decide whether to do the remote check
562020-12-04T05:02:47 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
572020-12-04T05:08:21 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.167.167> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
582020-12-04T05:23:56 *** cltrbreak_MAD2 <cltrbreak_MAD2!~ctrlbreak@159.2.182.106> has joined #bitcoin-core-dev
592020-12-04T05:26:14 *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has joined #bitcoin-core-dev
602020-12-04T05:26:46 *** ctrlbreak_MAD <ctrlbreak_MAD!~ctrlbreak@159.2.182.106> has quit IRC (Ping timeout: 246 seconds)
612020-12-04T05:27:32 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 256 seconds)
622020-12-04T05:27:49 <fanquake> could be done while it's ported to cirrus
632020-12-04T06:10:48 *** mdrjr1 <mdrjr1!~mdrjr@178.239.168.171> has quit IRC (Remote host closed the connection)
642020-12-04T06:27:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
652020-12-04T06:27:00 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a0489f3472f3...e2ae6a2befad
662020-12-04T06:27:00 <bitcoin-git> bitcoin/master 2f6fe4e Hennadii Stepanov: ci: Build with --enable-werror by default, and document exceptions
672020-12-04T06:27:01 <bitcoin-git> bitcoin/master e2ae6a2 MarcoFalke: Merge #20182: ci: Build with --enable-werror by default, and document exce...
682020-12-04T06:27:02 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
692020-12-04T06:27:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
702020-12-04T06:27:19 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20182: ci: Build with --enable-werror by default, and document exceptions (master...201018-error) https://github.com/bitcoin/bitcoin/pull/20182
712020-12-04T06:27:21 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
722020-12-04T06:31:27 *** popey1 <popey1!~popey@185.163.110.125> has joined #bitcoin-core-dev
732020-12-04T06:50:31 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.167.167> has joined #bitcoin-core-dev
742020-12-04T07:20:33 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
752020-12-04T07:23:04 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 260 seconds)
762020-12-04T07:23:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
772020-12-04T07:23:41 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20566: refactor: Use C++17 std::array where possible (master...2012-array) https://github.com/bitcoin/bitcoin/pull/20566
782020-12-04T07:23:42 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
792020-12-04T07:41:26 <wumpus> andytoshi: it doesn't really know, there's a manual fetch of all the repositories in there IIRC< it spooked me too once
802020-12-04T07:43:02 <wumpus> or no there isn't, I don't really know
812020-12-04T07:44:17 <wumpus> but I ran into some issues when I had to use a non-standard subtree for some temporary patches / experimentation in a PR (for a leveldb update)
822020-12-04T07:45:16 <wumpus> https://github.com/bitcoin/bitcoin/pull/17398#issuecomment-552811611
832020-12-04T07:50:58 <wumpus> on one hand I'm happy no longer being the only person running into this, on the other it would be good if it had better documentation
842020-12-04T07:52:38 <wumpus> err wait the 'error' exit has a positive exit status, riight
852020-12-04T08:07:26 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
862020-12-04T08:07:40 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
872020-12-04T08:08:38 <wumpus> I'll add an argument to the script instead
882020-12-04T08:10:28 <wumpus> and help
892020-12-04T08:14:26 <sipa> great
902020-12-04T08:23:49 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.167.167> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
912020-12-04T08:33:13 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 264 seconds)
922020-12-04T08:39:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
932020-12-04T08:39:58 <bitcoin-git> [bitcoin] laanwj opened pull request #20567: test: Add option to git-subtree-check to do full check, add help (master...2020_12_subtree_check) https://github.com/bitcoin/bitcoin/pull/20567
942020-12-04T08:39:59 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
952020-12-04T08:41:23 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
962020-12-04T08:44:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
972020-12-04T08:44:30 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20568: rpc: Use FeeModes doc helper in estimatesmartfee (master...2012-rpcDocFee) https://github.com/bitcoin/bitcoin/pull/20568
982020-12-04T08:44:42 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
992020-12-04T08:48:08 *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has quit IRC (Remote host closed the connection)
1002020-12-04T08:50:36 *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
1012020-12-04T08:51:58 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th> has joined #bitcoin-core-dev
1022020-12-04T08:57:12 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
1032020-12-04T09:01:06 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th> has joined #bitcoin-core-dev
1042020-12-04T09:01:27 *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has joined #bitcoin-core-dev
1052020-12-04T09:04:58 <promag> MarcoFalke: why just those 2 cases in #20566?
1062020-12-04T09:05:00 <gribble> https://github.com/bitcoin/bitcoin/issues/20566 | refactor: Use C++17 std::array where possible by MarcoFalke · Pull Request #20566 · bitcoin/bitcoin · GitHub
1072020-12-04T09:08:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1082020-12-04T09:08:48 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e2ae6a2befad...257cf05f9b84
1092020-12-04T09:08:48 <bitcoin-git> bitcoin/master d3ef947 Hennadii Stepanov: build: Check that Homebrew's berkeley-db4 package is actually installed
1102020-12-04T09:08:48 <bitcoin-git> bitcoin/master 257cf05 Jonas Schnelli: Merge #20563: build: Check that Homebrew's berkeley-db4 package is actuall...
1112020-12-04T09:08:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1122020-12-04T09:09:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1132020-12-04T09:09:08 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #20563: build: Check that Homebrew's berkeley-db4 package is actually installed (master...201203-bdb) https://github.com/bitcoin/bitcoin/pull/20563
1142020-12-04T09:09:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1152020-12-04T09:09:10 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
1162020-12-04T09:19:55 <wumpus> oh no did we break appveyor
1172020-12-04T09:20:08 <fanquake> ð¿
1182020-12-04T09:30:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1192020-12-04T09:30:37 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20569: test: Fix intermittent wallet_multiwallet issue with got_loading_error (master...2012-testWalletInt) https://github.com/bitcoin/bitcoin/pull/20569
1202020-12-04T09:30:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1212020-12-04T09:37:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1222020-12-04T09:37:16 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/257cf05f9b84...ca759bc743c9
1232020-12-04T09:37:17 <bitcoin-git> bitcoin/master 86e6add Adam Jonas: doc: rename CODEOWNERS to REVIEWERS
1242020-12-04T09:37:18 <bitcoin-git> bitcoin/master ca759bc Wladimir J. van der Laan: Merge #20200: doc: rename CODEOWNERS to REVIEWERS
1252020-12-04T09:37:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1262020-12-04T09:37:36 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1272020-12-04T09:37:36 <bitcoin-git> [bitcoin] laanwj merged pull request #20200: doc: rename CODEOWNERS to REVIEWERS (master...102020-fix-codeowners) https://github.com/bitcoin/bitcoin/pull/20200
1282020-12-04T09:37:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1292020-12-04T09:41:52 <MarcoFalke> promag: Only const arrays can make use of C++17 std::array
1302020-12-04T09:42:15 <promag> MarcoFalke: I've added a comment there
1312020-12-04T09:45:04 <MarcoFalke> is appveyor broken again? Can't be
1322020-12-04T09:45:37 <hebasto> current https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/36658306 seems going ok
1332020-12-04T09:46:48 <wumpus> but it fails on #20567, which makes no sense as that script isn't run by appveyor
1342020-12-04T09:46:49 <gribble> https://github.com/bitcoin/bitcoin/issues/20567 | test: Add option to git-subtree-check to do full check, add help by laanwj · Pull Request #20567 · bitcoin/bitcoin · GitHub
1352020-12-04T09:47:57 <MarcoFalke> how is it possible that appveryor breaks our config every 12 days
1362020-12-04T09:57:34 <hebasto> could 20567 appveyor failure be spontaneous? re-run?
1372020-12-04T09:57:59 <MarcoFalke> hebasto: happening on all other builds as well, starting from now
1382020-12-04T09:58:37 <MarcoFalke> hm https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/36658306 did just pass
1392020-12-04T09:58:55 <hebasto> ^ exactly
1402020-12-04T09:59:49 <wumpus> nice https://github.com/bitcoin/bitcoin/pull/20567#issuecomment-738686199
1412020-12-04T10:05:03 *** kexkey <kexkey!~kexkey@static-198-54-132-121.cust.tzulo.com> has quit IRC (Ping timeout: 260 seconds)
1422020-12-04T10:07:19 <jonasschnelli> fanquake: I think you can un-draft https://github.com/bitcoin/bitcoin/pull/19817
1432020-12-04T10:09:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1442020-12-04T10:09:57 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/ca759bc743c9...dca80ffb45fc
1452020-12-04T10:09:58 <bitcoin-git> bitcoin/master fa86156 practicalswift: util: Allow Assert(...) to be used in all contexts
1462020-12-04T10:09:59 <bitcoin-git> bitcoin/master fac5efe MarcoFalke: util: Add Assume() identity function
1472020-12-04T10:09:59 <bitcoin-git> bitcoin/master faa0585 MarcoFalke: util: Remove probably misleading TODO
1482020-12-04T10:10:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1492020-12-04T10:10:16 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1502020-12-04T10:10:16 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20255: util: Add Assume() identity function (master...2010-assume) https://github.com/bitcoin/bitcoin/pull/20255
1512020-12-04T10:10:18 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1522020-12-04T10:18:37 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1532020-12-04T10:37:04 <wumpus> why is all the addrv2 discussion happening last minute between rcs
1542020-12-04T10:41:08 <jnewbery> there were lots of very large features merged just before feature freeze, so it's maybe not surprising that issues are being found now
1552020-12-04T10:42:27 <wumpus> my first public draft was apparently june 1, 2018, I posted it to the mailing list feb 18, 2019 (there we no replies at all), I created the PR for the BIPs repository on feb 27, 2019, it was merged jul 23, 2019. Vasild picked up the implementation april this year, and quite quickly had a working implementation (though some other detailed were still ironed out). It was discussed in
1562020-12-04T10:42:29 <wumpus> meetings multiple times.
1572020-12-04T10:42:35 <wumpus> does any of this feel rushed to you
1582020-12-04T10:42:55 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th> has joined #bitcoin-core-dev
1592020-12-04T10:43:44 <wumpus> I am still struggling to find out what I did wrong for even such a relatively straightforward proposal
1602020-12-04T10:46:50 *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has quit IRC (Quit: Pavlenex)
1612020-12-04T10:46:58 <wumpus> I don't think people are exagerrating when they claim it has become almost imposible to make changes to bitcoin, even non-consensus, maybe this is a good thing! I don't know
1622020-12-04T10:47:24 *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has joined #bitcoin-core-dev
1632020-12-04T10:51:01 <wumpus> but it's too frustrating for me personally and I don't think I'll be working on BIPs again
1642020-12-04T10:51:28 *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has quit IRC (Client Quit)
1652020-12-04T10:53:19 <wumpus> it wasn't even controversial in any way
1662020-12-04T10:54:43 <vasild> indeed, why was this brought up now? the btcd issue for disconnecting was opened in btcd's repo 20+ days ago
1672020-12-04T10:55:06 <wumpus> nor even a new idea! people had been talking about a new address mechanism for years before that, I mainly collected some ideas people already had
1682020-12-04T10:55:20 <wumpus> and wrote them down
1692020-12-04T10:56:39 <vasild> what about releasing 0.21 as is and _considering_ #20564 for 0.21.1 based on reception of 0.21?
1702020-12-04T10:56:41 <gribble> https://github.com/bitcoin/bitcoin/issues/20564 | Dont send sendaddrv2 to pre-70016 software by sipa · Pull Request #20564 · bitcoin/bitcoin · GitHub
1712020-12-04T11:01:01 <vasild> wumpus: ^
1722020-12-04T11:02:54 <wumpus> vasild: well, it being a temporary workaround it should probably be merged quickly
1732020-12-04T11:03:37 <wumpus> sipa's change is very low risk in itself
1742020-12-04T11:04:18 <vasild> I agree it is low risk and can be merged quickly, but I dont see it being temporary.
1752020-12-04T11:04:32 <wumpus> what people are (rightly) being worried about is the implications of this behavior
1762020-12-04T11:04:36 <wumpus> yes
1772020-12-04T11:07:20 <vasild> so we have team1 insisting that new messages should come with a protocol bump and impl1 should disconnect when it sees unknown message, team2 thinks it is ok to just ignore unknown messages.
1782020-12-04T11:08:13 <vasild> if team1 still insists and team2 follows suit, I don't see team1 changing their mind...
1792020-12-04T11:09:05 <wumpus> I don't agree at all that ignoring unknown messages is a DoS vector, if you want to DoS it's better to use a known message type that consumes resources
1802020-12-04T11:09:30 <vasild> right
1812020-12-04T11:09:33 <wumpus> or that has a large response for a small message
1822020-12-04T11:10:04 <wumpus> just flooding a host is uninteresting and possible in so many ways
1832020-12-04T11:12:38 <vasild> That is kind of obvious, but apparently not for everybody. My worry with 20564 is that it is going to reaffirm "new messages come with protocol bump"
1842020-12-04T11:13:53 <wumpus> and while I do agree the P2P code could use some more anti-DoS measures this is not one
1852020-12-04T11:13:55 <wumpus> right
1862020-12-04T11:18:08 <wumpus> vasild: maybe, though at least everyone in the PR agrees that it's a one time thing -- this says nothign about signaling to other implementations of course
1872020-12-04T11:18:38 <vasild> :)
1882020-12-04T11:20:43 *** Ruben41Heaney <Ruben41Heaney!~Ruben41He@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
1892020-12-04T11:27:28 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
1902020-12-04T11:30:46 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 246 seconds)
1912020-12-04T11:32:47 *** Ruben41Heaney <Ruben41Heaney!~Ruben41He@static.57.1.216.95.clients.your-server.de> has quit IRC (Ping timeout: 260 seconds)
1922020-12-04T11:36:54 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has quit IRC (Remote host closed the connection)
1932020-12-04T11:37:59 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has joined #bitcoin-core-dev
1942020-12-04T11:39:48 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
1952020-12-04T11:40:34 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1962020-12-04T12:01:48 <jonasschnelli> <wumpus> my first public draft was apparently june 1, 2018, I posted it to the mailing list feb 18, 2019 (there we no replies at all), I created the PR for the BIPs repository on feb 27, 2019, it was merged jul 23, 2019. Vasild picked up the implementation april this year, and quite quickly had a working implementation (though some other detailed were still ironed out). [...]
1972020-12-04T12:02:05 <jonasschnelli> This is my main concern... fixing this quietly.
1982020-12-04T12:03:04 <jonasschnelli> It might lead to more reluctant testing and lesser interest to read BIPs more carefully
1992020-12-04T12:06:02 <wumpus> ... even less interest and we might as well puglish BIPs directly into the arctic code vault
2002020-12-04T12:09:23 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Read error: Connection reset by peer)
2012020-12-04T12:09:41 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
2022020-12-04T12:14:45 <wumpus> but I agree, the whole BIP process is there to standardize the bitcoin protocols, to coordinate between implementations, that's the point
2032020-12-04T12:17:24 <wumpus> well, it also helps coordinate between bitcoin core developers on a more conceptual level than implementation details, but that discussion happened on the BIP repo PRs, not on the mailing list
2042020-12-04T12:19:24 <wumpus> e.g. https://github.com/bitcoin/bips/pull/766 had some of the most fruitful discussion
2052020-12-04T12:20:32 *** kinlo <kinlo!~peter@unaffiliated/kinlo> has quit IRC (Ping timeout: 260 seconds)
2062020-12-04T12:21:57 <wumpus> maybe it should have been on the mailing list but I'm not sure most of the people commenting there are even subscribed there, not least because a lot of people consider mailing lists an awful communication medium
2072020-12-04T12:22:27 *** kinlo <kinlo!~peter@unaffiliated/kinlo> has joined #bitcoin-core-dev
2082020-12-04T12:25:27 *** popey1 <popey1!~popey@185.163.110.125> has quit IRC (Remote host closed the connection)
2092020-12-04T12:30:07 *** darkspadez|lapto <darkspadez|lapto!~darkspade@217.146.82.202> has joined #bitcoin-core-dev
2102020-12-04T12:37:04 <wumpus> it's also perfectly normal to find and fix issues in rcs at the implementation level, what is weird here is that BIP-level conceptual issues are raised now
2112020-12-04T12:38:10 <harding> FWIW, addrv2 was covered by the Optech newsletter six times total, three times this year. https://bitcoinops.org/en/topics/addr-v2/ We also directly covered sdaftuar's March 2020 mailing list post about using new messages for feature negotiation with the call to action, "Daftuar is seeking feedback from maintainers of full nodes about whether the insertion of negotiation messages would cause any problems. If youâre aware of any
2122020-12-04T12:38:10 <harding> problems, please reply to the thread." http://bitcoinops.org/en/newsletters/2020/03/04/#improving-feature-negotiation-between-full-nodes-at-startup Later (August), about the new wtxidrelay message, we wrote, "This behavior is already implemented in an unreleased development version of Bitcoin Core. If the maintainers of other implementations, or anyone else, opposes this change, please respond to the mailing list thread."
2132020-12-04T12:38:10 <harding> https://bitcoinops.org/en/newsletters/2020/08/19/#proposed-bip-for-p2p-protocol-feature-negotiation
2142020-12-04T12:38:42 <wumpus> harding: oh wow thanks for weighing in, I even forgot about that
2152020-12-04T12:42:03 <jonatack> Yes, it's not like we weren't publishing repeatedly about BIP 155 addrv2 arriving and testing, tweeting about it numerous times, people responding enthusiastically, etc.
2162020-12-04T12:43:27 <jonatack> also 2 review club sessions about it, one of which was covered with a monthly Optech feature writeup and quiz
2172020-12-04T12:44:27 <jonatack> I guess it's human nature to wait until things are really impending though
2182020-12-04T12:49:29 <jonatack> https://bitcoincore.reviews/19031 on 2020-07-15
2192020-12-04T12:49:56 <wumpus> it became a little more pressing with the Tor announcement that v2 was deprecated, but even then it was never hurried or rushed imo
2202020-12-04T12:50:01 <jonatack> https://bitcoincore.reviews/19845 on 2020-09-16 (the day after tor deprecated v2)
2212020-12-04T12:51:24 <jonatack> https://bitcoinops.org/en/topics/addr-v2 -> 3 posts in 2019, 3 posts in 2020 as harding wrote
2222020-12-04T12:52:31 <vasild> I opened https://github.com/btcsuite/btcd/pull/1671 to ignore unknown p2p messages in btcd
2232020-12-04T12:52:54 <jonatack> vasild: good idea
2242020-12-04T12:53:17 <wumpus> yes, good idea
2252020-12-04T12:57:30 *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has joined #bitcoin-core-dev
2262020-12-04T12:58:39 <vasild> they can probably rewrite the patch in a better way technically, but the point is how it will be received
2272020-12-04T13:00:56 <wumpus> right
2282020-12-04T13:06:22 *** Bullit <Bullit!~Bullit01@042-236-158-163.dynamic.caiway.nl> has quit IRC (Read error: Connection reset by peer)
2292020-12-04T13:08:23 <vasild> btw, the freebsd port upgrade from 0.20.1 to 0.21.0rc2 was rejected by its maintainer, who does not want to track RCs: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251453
2302020-12-04T13:19:06 <jonasschnelli> I don't get this... configure.ac sets AC_SUBST(HAVE_WEAK_GETAUXVAL), this means it will not get evaluated in #if defined(HAVE_STRONG_GETAUXVAL) || defined(HAVE_WEAK_GETAUXVAL), right?
2312020-12-04T13:20:43 <jonasschnelli> (without setting CPPFLAGS to -DHAVE_WEAK_GETAUXVAL=@HAVE_WEAK_GETAUXVAL@)
2322020-12-04T13:24:08 <jonasschnelli> There is no AC_DEFINE for HAVE_WEAK_GETAUXVAL but randomenv.cpp is evaluating it. My guess is that getauxval will never be used in randomenv.cpp.
2332020-12-04T13:27:14 <sdaftuar> wumpus: just to share my opinion -- the issue in my mind is that this is a surprise to anyone that we implemented a feature that will cause existing software to disconnect us. i think it shouldn't have been a surprise to us, because every time this topic comes up on the mailing list, there is opposition to the idea of sending unknown messages without a protocol bump (as i rediscovered in august)
2342020-12-04T13:27:57 <sdaftuar> i know this BIP was advertised in several places, but the updated draft of it was never sent to the -dev list after the negotiation changed; so i think that's something that would have brought this to light to everyone sooner
2352020-12-04T13:28:26 <sdaftuar> at any rate, i'm not trying to advocate that we necessarily change our feature negotiation. i know lots of other people ahve strong views on it, and i don't myself
2362020-12-04T13:29:00 <sdaftuar> i just think that we should all be aware that this is an area where people disagree, and our communication should reflect that by making it clear what our software will do
2372020-12-04T13:29:45 <sdaftuar> (anyway, i also did basically zero work to help addrv2 make it this far, so thank you to everyone who has worked on it! i hope my words don't come across as criticism of the overall effort)
2382020-12-04T13:30:27 *** darkspadez|lapto <darkspadez|lapto!~darkspade@217.146.82.202> has quit IRC (Remote host closed the connection)
2392020-12-04T13:30:44 <wumpus> I didn't bother with them ailing list anymore because the first time it got exactly zero engagement
2402020-12-04T13:31:01 <sdaftuar> wumpus: yeah i have encountered that myself in the past too :(
2412020-12-04T13:31:09 <wumpus> I don't personally expecti t would have been different when sending it a second time but feel free to disagree
2422020-12-04T13:31:28 <wumpus> okay :/ yes I can only imagine how difficult it is to make say, consensus changes
2432020-12-04T13:31:58 <wumpus> if even seomthing like this...
2442020-12-04T13:32:36 <sdaftuar> my thought is that even if people don't engage, by sending it to the mailing list (which has historically been our place of publication of protocol changes) it shifts the burden to others to read, respond, or object
2452020-12-04T13:34:27 *** forcer1 <forcer1!~forcer@185.204.1.185> has joined #bitcoin-core-dev
2462020-12-04T13:35:25 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
2472020-12-04T13:35:26 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
2482020-12-04T13:35:26 *** vasild_ is now known as vasild
2492020-12-04T13:36:38 <MarcoFalke> it is impossible to know how much reading engagement a post has received if the majority of subscribers are readers
2502020-12-04T13:36:57 <MarcoFalke> s/if/because/
2512020-12-04T13:38:22 <wumpus> sure...
2522020-12-04T13:40:23 *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
2532020-12-04T13:40:42 *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
2542020-12-04T13:40:42 *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has quit IRC (Client Quit)
2552020-12-04T13:46:15 <wumpus> it was kind of demotivating for a while in itself though
2562020-12-04T13:47:38 <kanzure> what is the mechanism by which ignoring an unknown message causes a DoS problem?
2572020-12-04T13:47:50 <sdaftuar> the great question :)
2582020-12-04T13:49:43 <wumpus> disconnecting literally generates more traffic than ignoring the message
2592020-12-04T13:51:09 <kanzure> MarcoFalke: readers also can't be determined on a github pull request or issue comment.
2602020-12-04T13:51:31 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
2612020-12-04T13:52:06 <MarcoFalke> wumpus: I think it was an oversight of the btcd devs
2622020-12-04T13:52:46 <MarcoFalke> The first comment says "Thanks for reporting this! The easiest way to resolve this is to permit unknown messages rather than disconnecting as we do now"
2632020-12-04T13:53:31 <MarcoFalke> Maybe the btcd devs wouldn't have noticed even if the bip was sent to the mailing list
2642020-12-04T13:54:34 <MarcoFalke> it is easy to forget details of how the p2p protocol is implemented (or even how it changed in the past)
2652020-12-04T13:56:30 <MarcoFalke> code/bip review can never catch all issues upfront. They come up when implementing or running tests on real networks
2662020-12-04T13:58:50 <MarcoFalke> we are the first ones to implement the bip, so no one else had the chance to spot bugs while implementing
2672020-12-04T14:14:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2682020-12-04T14:14:30 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dca80ffb45fc...9601c0d7aab7
2692020-12-04T14:14:31 <bitcoin-git> bitcoin/master e373959 Block Mechanic: Android : Ensure pic build for bdb
2702020-12-04T14:14:31 <bitcoin-git> bitcoin/master 9601c0d fanquake: Merge #20565: Android : Ensure pic build for bdb
2712020-12-04T14:14:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2722020-12-04T14:14:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2732020-12-04T14:14:49 <bitcoin-git> [bitcoin] fanquake merged pull request #20565: Android : Ensure pic build for bdb (master...fix-bdb-android) https://github.com/bitcoin/bitcoin/pull/20565
2742020-12-04T14:14:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2752020-12-04T14:18:24 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th> has joined #bitcoin-core-dev
2762020-12-04T14:18:40 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 272 seconds)
2772020-12-04T14:21:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2782020-12-04T14:21:20 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9601c0d7aab7...c1604483d34f
2792020-12-04T14:21:21 <bitcoin-git> bitcoin/master fac7ab1 MarcoFalke: refactor: Use C++17 std::array where possible
2802020-12-04T14:21:21 <bitcoin-git> bitcoin/master c160448 MarcoFalke: Merge #20566: refactor: Use C++17 std::array where possible
2812020-12-04T14:21:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2822020-12-04T14:21:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2832020-12-04T14:21:40 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20566: refactor: Use C++17 std::array where possible (master...2012-array) https://github.com/bitcoin/bitcoin/pull/20566
2842020-12-04T14:21:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2852020-12-04T14:27:25 *** dviola <dviola!~diego@unaffiliated/dviola> has quit IRC (Ping timeout: 256 seconds)
2862020-12-04T14:32:23 *** Guyver2_ <Guyver2_!~Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
2872020-12-04T14:35:30 *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 256 seconds)
2882020-12-04T14:46:38 *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has quit IRC (Quit: Pavlenex)
2892020-12-04T15:01:32 *** dviola <dviola!~diego@187.39.20.240> has joined #bitcoin-core-dev
2902020-12-04T15:05:51 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2912020-12-04T15:05:51 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c1604483d34f...751ffaabad82
2922020-12-04T15:05:52 <bitcoin-git> bitcoin/master 773c42b Andrew Chow: tests: Test that a fully signed tx given to signrawtx is unchanged
2932020-12-04T15:05:53 <bitcoin-git> bitcoin/master 751ffaa MarcoFalke: Merge #20562: tests: Test that a fully signed tx given to signrawtx is unc...
2942020-12-04T15:05:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2952020-12-04T15:06:11 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2962020-12-04T15:06:11 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20562: tests: Test that a fully signed tx given to signrawtx is unchanged (master...test-signraw-fullysigned) https://github.com/bitcoin/bitcoin/pull/20562
2972020-12-04T15:06:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2982020-12-04T15:21:49 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 256 seconds)
2992020-12-04T15:31:13 *** virtu_ <virtu_!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
3002020-12-04T15:32:03 *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Ping timeout: 240 seconds)
3012020-12-04T15:33:41 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
3022020-12-04T15:43:40 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th> has quit IRC (Read error: Connection reset by peer)
3032020-12-04T15:51:37 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
3042020-12-04T15:53:16 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 240 seconds)
3052020-12-04T15:58:18 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
3062020-12-04T15:59:42 *** pergaminho <pergaminho!~Cleber@189.26.121.248> has joined #bitcoin-core-dev
3072020-12-04T16:05:53 *** reallll <reallll!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
3082020-12-04T16:09:30 *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 272 seconds)
3092020-12-04T16:09:52 *** Provostro <Provostro!~Pvo@168.62.56.135> has joined #bitcoin-core-dev
3102020-12-04T16:15:09 *** Klox04809318631 <Klox04809318631!~Klox@c-24-1-131-19.hsd1.il.comcast.net> has joined #bitcoin-core-dev
3112020-12-04T16:15:28 <Provostro> Hi I asked about LedgerX and they told me to come here and speak with Kanzure
3122020-12-04T16:15:33 <Provostro> I was checking it out, but it seems like a scam.
3132020-12-04T16:15:38 <Provostro> the order books are scammy
3142020-12-04T16:15:42 <Provostro> kanzure, are you running a scam?
3152020-12-04T16:16:21 <Provostro> !tlast
3162020-12-04T16:16:21 <gribble> 18856.24
3172020-12-04T16:17:51 <luke-jr> Provostro: this channel is for Bitcoin Core development, not for speaking with specific people about other topics
3182020-12-04T16:17:53 <Provostro> I'd like to settle matter amicably, thats why i came to you to ask.
3192020-12-04T16:18:07 <Provostro> TO please stop running your scam, or pay me 100 btc.
3202020-12-04T16:18:22 <luke-jr> Provostro: /query kanzure
3212020-12-04T16:20:12 <Provostro> luke-jr, ok i typed that, now what?
3222020-12-04T16:20:31 <luke-jr> use that tab to talk privately with him
3232020-12-04T16:20:42 <Provostro> i like to do it publicly so the whole world knows who's a scammer
3242020-12-04T16:20:49 <luke-jr> well it's not welcome here
3252020-12-04T16:20:49 <Provostro> do you hagve an issue with that?
3262020-12-04T16:21:53 *** openoms_ <openoms_!~quassel@91.132.136.76> has quit IRC (Ping timeout: 256 seconds)
3272020-12-04T16:23:49 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
3282020-12-04T16:24:25 <Provostro> luke-jr, perhaps you too are a scammer in on the scam?
3292020-12-04T16:25:05 *** ChanServ sets mode: +o luke-jr
3302020-12-04T16:25:13 *** luke-jr sets mode: +q Provostro!*@*
3312020-12-04T16:25:21 *** luke-jr sets mode: -o luke-jr
3322020-12-04T16:26:44 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
3332020-12-04T16:26:58 *** openoms <openoms!~quassel@91.132.136.76> has joined #bitcoin-core-dev
3342020-12-04T16:29:17 *** Zenton <Zenton!~user@unaffiliated/vicenteh> has quit IRC (Read error: Connection reset by peer)
3352020-12-04T16:29:36 *** Zenton <Zenton!~user@unaffiliated/vicenteh> has joined #bitcoin-core-dev
3362020-12-04T16:30:38 *** reallll is now known as belcher
3372020-12-04T16:50:08 *** tryphe_ <tryphe_!~tryphe@unaffiliated/tryphe> has joined #bitcoin-core-dev
3382020-12-04T16:50:21 *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has joined #bitcoin-core-dev
3392020-12-04T16:52:45 *** tryphe <tryphe!~tryphe@unaffiliated/tryphe> has quit IRC (Ping timeout: 240 seconds)
3402020-12-04T16:54:31 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
3412020-12-04T16:55:57 *** jessepos_ <jessepos_!~jp@2600:380:c010:4d5b:595a:9185:2152:9cb8> has joined #bitcoin-core-dev
3422020-12-04T16:57:13 *** jessepos_ <jessepos_!~jp@2600:380:c010:4d5b:595a:9185:2152:9cb8> has quit IRC (Client Quit)
3432020-12-04T16:57:39 *** jessepos_ <jessepos_!~jp@2600:380:c010:4d5b:595a:9185:2152:9cb8> has joined #bitcoin-core-dev
3442020-12-04T16:57:40 *** kexkey <kexkey!~kexkey@static-198-54-132-173.cust.tzulo.com> has joined #bitcoin-core-dev
3452020-12-04T16:58:48 *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has quit IRC (Quit: Pavlenex)
3462020-12-04T17:00:02 *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:21a3:28f3:d78:7f10> has quit IRC (Ping timeout: 264 seconds)
3472020-12-04T17:05:36 *** proofofkeags <proofofkeags!~proofofke@174-16-212-53.hlrn.qwest.net> has joined #bitcoin-core-dev
3482020-12-04T17:14:43 *** kexkey <kexkey!~kexkey@static-198-54-132-173.cust.tzulo.com> has quit IRC (Quit: Do, don't don't)
3492020-12-04T17:21:48 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3502020-12-04T17:21:50 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/68bd88597a79...aa4b8ebfecdd
3512020-12-04T17:21:50 <bitcoin-git> bitcoin/0.21 54e1edc Jon Atack: Allow zero-fee fundrawtxn and walletcreatefundedpsbt calls
3522020-12-04T17:21:51 <bitcoin-git> bitcoin/0.21 6e4969f Jon Atack: Update feeRate (BTC/kvB) to fee_rate (sat/vB) in wallet_bumpfee
3532020-12-04T17:21:52 <bitcoin-git> bitcoin/0.21 6313362 Jon Atack: Use the correct incremental fee constant in bumpfee help
3542020-12-04T17:21:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3552020-12-04T17:23:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3562020-12-04T17:23:05 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20510: [backport] wallet: allow zero-fee fundrawtransaction/walletcreatefundedpsbt and other fixes (0.21...backport-fee_rate-follow-ups) https://github.com/bitcoin/bitcoin/pull/20510
3572020-12-04T17:23:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3582020-12-04T17:24:31 *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:888:c250:4010:2f1e> has joined #bitcoin-core-dev
3592020-12-04T17:26:53 *** kljasdfvv <kljasdfvv!~flack@p200300d46f24de00448d0b09d893fcb7.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
3602020-12-04T17:28:04 *** jessepos_ <jessepos_!~jp@2600:380:c010:4d5b:595a:9185:2152:9cb8> has quit IRC (Ping timeout: 240 seconds)
3612020-12-04T17:34:22 <andytoshi> i have another CI question .. if i do bash -c 'set -e; source ./ci/lint/06_script.sh ' locally it bombs out with
3622020-12-04T17:34:25 <andytoshi> test/functional/test_runner.py:42: error: Module has no attribute "getwindowsversion"
3632020-12-04T17:34:30 <andytoshi> presumably because i am not on windows
3642020-12-04T17:34:40 <andytoshi> is there a good way to deal with this
3652020-12-04T17:35:26 <sipa> ci/test_run_all.sh:set -o errexit; source ./ci/test/06_script_a.sh
3662020-12-04T17:35:28 <sipa> is that it?
3672020-12-04T17:35:34 <sipa> set -o errexit?
3682020-12-04T17:35:40 <sipa> oh, nvm, this is python
3692020-12-04T17:42:44 <andytoshi> yeah it's running the python linter
3702020-12-04T17:43:21 <andytoshi> the line i got is `set -o errexit; source ./ci/lint/06_script.sh` which is directly in .travis.yml
3712020-12-04T17:50:50 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
3722020-12-04T18:03:49 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 264 seconds)
3732020-12-04T18:06:18 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
3742020-12-04T18:17:36 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 240 seconds)
3752020-12-04T18:20:00 <MarcoFalke> andytoshi: You'll need to run the scripts in order, as they "pollute" the environment with variables
3762020-12-04T18:20:15 <MarcoFalke> s/in order/in the same bash/
3772020-12-04T18:20:57 <MarcoFalke> cp ./ci/test_run_all.sh ./ci/lint_run_all.sh && vim ./ci/lint_run_all.sh
3782020-12-04T18:21:13 <MarcoFalke> and then edit the file to run the same stuff that travis.yml runs
3792020-12-04T18:21:19 <andytoshi> i don't have apt and stuff
3802020-12-04T18:21:23 <andytoshi> i can't run the install scripts
3812020-12-04T18:21:43 <MarcoFalke> oh, the linters only run on ubuntu. I don't think they are tested on other operating systems
3822020-12-04T18:21:58 <andytoshi> as it happens, they pass on arch with very little modification
3832020-12-04T18:22:52 <andytoshi> just that it doesn't really check submodules (this is still a pass :)) and the one python issue which I'll try to PR to add a mypy whitelist to
3842020-12-04T18:22:58 <andytoshi> about sys.getwindowsversion not existing
3852020-12-04T18:26:14 *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has joined #bitcoin-core-dev
3862020-12-04T18:26:35 *** Pavlenex <Pavlenex!~Thunderbi@178.220.68.122> has quit IRC (Client Quit)
3872020-12-04T18:26:38 *** dviola <dviola!~diego@187.39.20.240> has left #bitcoin-core-dev
3882020-12-04T18:27:52 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
3892020-12-04T18:28:33 *** jbarcelo <jbarcelo!43daf305@67.218.243.5> has joined #bitcoin-core-dev
3902020-12-04T18:31:36 *** openoms <openoms!~quassel@91.132.136.76> has quit IRC (Ping timeout: 240 seconds)
3912020-12-04T18:32:07 <wumpus> i don't get it, sys.getwindowsversion doesn't exist on ubuntu either
3922020-12-04T18:32:25 *** openoms <openoms!~quassel@91.132.136.76> has joined #bitcoin-core-dev
3932020-12-04T18:33:45 <MarcoFalke> that part of the code is only executed when "os.name == 'nt'"
3942020-12-04T18:33:58 <wumpus> that makes sense
3952020-12-04T18:33:59 <andytoshi> yeah, it's just mypy that's complaining
3962020-12-04T18:34:03 <andytoshi> it's not an actual problem
3972020-12-04T18:34:31 <andytoshi> there are already mypy whitelists near that line related to windows stuff, i think this might've just been overlooked...but i'm surprissed that travis is ok with it
3982020-12-04T18:35:48 *** virtu_ is now known as virtu
3992020-12-04T18:38:14 *** dviola <dviola!~diego@unaffiliated/dviola> has joined #bitcoin-core-dev
4002020-12-04T18:41:11 <jonatack> andytoshi: possibly fixed by #20240?
4012020-12-04T18:41:13 <gribble> https://github.com/bitcoin/bitcoin/issues/20240 | script: fix linter error in test runner by jonatack · Pull Request #20240 · bitcoin/bitcoin · GitHub
4022020-12-04T18:43:17 <andytoshi> jonatack: yeah i think so, though i don't really understand why your fix works
4032020-12-04T18:43:25 <jonatack> it fixes error: Module has no attribute "getwindowsversion" for me since several months
4042020-12-04T18:43:40 <andytoshi> what is mypy looking at that it thinks getwindowsversion is used by the original code, but not your new code?
4052020-12-04T18:44:19 <andytoshi> is it just smart enough to understand `sys.platform` check but not smart enough to understand the `os.name` check?
4062020-12-04T18:44:46 <jonatack> idk, i've been waiting for someone else to hit the same issue
4072020-12-04T18:45:05 <jonatack> but it works :shrugs:
4082020-12-04T18:45:08 <andytoshi> heh, well, here i am, and my solution was to just add a `# type: ignore` on the offending line
4092020-12-04T18:46:16 <sipa> https://github.com/python/mypy/issues/8547
4102020-12-04T18:46:26 <sipa> using sys.platform is understood by mypy
4112020-12-04T18:46:49 <jonatack> andytoshi: yup, that works too: if os.name != 'nt' or sys.getwindowsversion() >= (10, 0, 14393): # type: ignore
4122020-12-04T18:47:19 <andytoshi> nice sipa
4132020-12-04T18:47:35 <andytoshi> so jonatack as i commented on your PR, there are a bunch of existing #type : ignore that you can probably drop
4142020-12-04T18:47:40 <andytoshi> though we'd need a windows tester to be sure
4152020-12-04T18:48:49 *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has quit IRC (Ping timeout: 264 seconds)
4162020-12-04T18:49:30 *** twistedline <twistedline!~twisted@c-68-33-78-41.hsd1.md.comcast.net> has joined #bitcoin-core-dev
4172020-12-04T18:51:07 <jonatack> thanks sipa and andytoshi for the info. if no one looks at it before tomorrow i'll look into it.
4182020-12-04T18:51:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4192020-12-04T18:51:33 <bitcoin-git> [bitcoin] OliverPetrovic opened pull request #20570: Logo added to the readme file. (master...master) https://github.com/bitcoin/bitcoin/pull/20570
4202020-12-04T18:51:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4212020-12-04T18:55:33 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Quit: Gone frying asparagus or my Windows had a BSOD)
4222020-12-04T19:00:28 <achow101> wallet meeting?
4232020-12-04T19:01:22 *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has quit IRC (Remote host closed the connection)
4242020-12-04T19:01:29 <achow101> #startmeeting
4252020-12-04T19:01:30 <core-meetingbot> Meeting started Fri Dec 4 19:01:29 2020 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
4262020-12-04T19:01:30 <core-meetingbot> Available commands: action commands idea info link nick
4272020-12-04T19:01:40 *** twistedline <twistedline!~twisted@c-68-33-78-41.hsd1.md.comcast.net> has joined #bitcoin-core-dev
4282020-12-04T19:01:51 <emzy> hi
4292020-12-04T19:01:56 <fjahr> hi
4302020-12-04T19:01:57 <jonatack> hi
4312020-12-04T19:01:59 <achow101> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr jeremyrubin emilengler jonatack hebasto
4322020-12-04T19:02:00 <achow101> jb55 kvaciral ariard digi_james amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai
4332020-12-04T19:02:15 <achow101> any topics?
4342020-12-04T19:03:47 <achow101> #topic wallet high priority for review
4352020-12-04T19:03:47 <core-meetingbot> topic: wallet high priority for review
4362020-12-04T19:04:09 <achow101> any wallet prs for high priority to add/remove/discuss?
4372020-12-04T19:04:15 <jonatack> pls review minor bugfix #20546
4382020-12-04T19:04:18 <gribble> https://github.com/bitcoin/bitcoin/issues/20546 | wallet: check for non-representable CFeeRates (0-0.0009 sat/vB) by jonatack · Pull Request #20546 · bitcoin/bitcoin · GitHub
4392020-12-04T19:04:21 *** twistedline_ <twistedline_!~twisted@c-68-33-78-41.hsd1.md.comcast.net> has joined #bitcoin-core-dev
4402020-12-04T19:05:03 <achow101> jonatack: is that for 0.21?
4412020-12-04T19:05:05 <jonatack> also found another bug in the send rpc; unlike the other rpcs, the fee rate cannot be passed as a string, only a number. Opening a fix today.
4422020-12-04T19:05:31 <jonatack> achow101: idk if it's a backport-worthy bug, up to others i guess
4432020-12-04T19:06:19 <provoostenator> (hi)
4442020-12-04T19:06:34 <provoostenator> It's marked experimental
4452020-12-04T19:06:49 <provoostenator> So I guess it depends on how annoyhing it is in practice
4462020-12-04T19:06:56 *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has quit IRC (Ping timeout: 256 seconds)
4472020-12-04T19:06:56 <jonatack> achow101: the fix in both cases is simple, the work is mostly writing good test coverage
4482020-12-04T19:08:17 <achow101> doesn't seem backport worthy, but no strong opinion on that
4492020-12-04T19:08:28 <jonatack> provoostenator: the help says it's an amount (string or number), and the fix is one line, but not up to me
4502020-12-04T19:08:29 <achow101> not the first time we've had a known issues section in the release notes
4512020-12-04T19:08:45 <kanzure> andytoshi: you can use import importlib; importlib.find_spec("somethingwindowsonly") and another function i forget.
4522020-12-04T19:09:12 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
4532020-12-04T19:09:35 <provoostenator> Well we probalby get another RC regardless because of a sendaddrv2 compatiblity issue with btcd
4542020-12-04T19:10:02 <jonatack> yess i'll just PR it and let ppl decide
4552020-12-04T19:10:06 <luke-jr> need another RC for the already merged stuff anyway
4562020-12-04T19:11:42 <jonatack> fjahr: i plan to review #19055 when i'm done with all the fee rate things
4572020-12-04T19:11:46 <gribble> https://github.com/bitcoin/bitcoin/issues/19055 | Add MuHash3072 implementation by fjahr · Pull Request #19055 · bitcoin/bitcoin · GitHub
4582020-12-04T19:11:48 <jonatack> as you've updated it
4592020-12-04T19:11:55 <fjahr> thanks
4602020-12-04T19:12:03 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has quit IRC (Ping timeout: 240 seconds)
4612020-12-04T19:12:35 *** jbarcelo <jbarcelo!43daf305@67.218.243.5> has quit IRC (Ping timeout: 245 seconds)
4622020-12-04T19:12:46 <provoostenator> I'm currently writing a PR for Specter to use descriptor wallets, so hopefully I don't encounter anything shocking on the core side.
4632020-12-04T19:13:01 <provoostenator> So far it works really well
4642020-12-04T19:13:02 <Murch> Hi
4652020-12-04T19:13:39 <provoostenator> It's annoying that getwalletinfo returns 3000 for keypool size
4662020-12-04T19:13:49 <achow101> it's not wrong though
4672020-12-04T19:13:52 <provoostenator> Although it's true,
4682020-12-04T19:14:00 <provoostenator> No, but it would be nice get 1000 somewhere as well
4692020-12-04T19:14:13 <provoostenator> Because I don't want to rely on having 3 types of addresses
4702020-12-04T19:14:24 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has joined #bitcoin-core-dev
4712020-12-04T19:14:32 <provoostenator> Need that number in order to pick a sane "range" param for importdescriptors
4722020-12-04T19:14:40 <provoostenator> Which doesn't have a default afaik
4732020-12-04T19:14:53 <achow101> just only support one address type then
4742020-12-04T19:15:14 <luke-jr> yeah, descriptor wallets don't need to have all the other types do they?
4752020-12-04T19:15:28 <provoostenator> That's not the issue. It's just that you can't know -keypoolsize
4762020-12-04T19:15:34 <provoostenator> Unless you parse bitcoin.conf
4772020-12-04T19:16:04 <achow101> since each spkm reports its own keypoolsize, getwalletinfo could be more granular there
4782020-12-04T19:16:07 <provoostenator> The range param for importdescriptors isn't super useful anyway
4792020-12-04T19:16:10 <achow101> just some output stuff, not particularly hard
4802020-12-04T19:17:02 <provoostenator> Would be nice if the range param defaulted to -keypoolsize so you can omit it.
4812020-12-04T19:17:47 <achow101> i think it does?
4822020-12-04T19:20:03 <achow101> anything else?
4832020-12-04T19:21:39 *** troygiorshev <troygiorshev!~troygiors@d67-193-140-136.home3.cgocable.net> has joined #bitcoin-core-dev
4842020-12-04T19:23:24 <achow101> #endmeeting
4852020-12-04T19:23:25 <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
4862020-12-04T19:23:25 <core-meetingbot> Meeting ended Fri Dec 4 19:23:24 2020 UTC.
4872020-12-04T19:23:25 <core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-12-04-19.01.moin.txt
4882020-12-04T19:23:42 * luke-jr peers at topic being in there
4892020-12-04T19:23:47 <jonatack> provoostenator: they should call it spectre like in the old bond films
4902020-12-04T19:24:14 <luke-jr> reminder that "Spectre" is a current-day series of vulnerabilities..
4912020-12-04T19:24:21 <achow101> depends on whether you're british or american
4922020-12-04T19:25:04 *** twistedline_ <twistedline_!~twisted@c-68-33-78-41.hsd1.md.comcast.net> has quit IRC (Ping timeout: 256 seconds)
4932020-12-04T19:25:33 <fjahr> the latest one was also also called spectre and it wasn't that great sooo... :)
4942020-12-04T19:30:43 <provoostenator> achow101: ah you're right, range can be ommited.
4952020-12-04T19:37:18 *** openoms <openoms!~quassel@91.132.136.76> has quit IRC (Ping timeout: 256 seconds)
4962020-12-04T19:38:18 *** openoms <openoms!~quassel@91.132.136.76> has joined #bitcoin-core-dev
4972020-12-04T19:40:37 <sipa> phantomcircuit or anyone else: you still have a large number of testnet coins?
4982020-12-04T19:41:35 <luke-jr> sipa: hi
4992020-12-04T19:41:56 <luke-jr> i herd u want TNBTC?
5002020-12-04T19:42:03 <luke-jr> how many & address?
5012020-12-04T19:42:07 <sipa> someone from bitgo is asking for some amount to test with
5022020-12-04T19:42:32 <sipa> ok, getting address
5032020-12-04T19:44:05 <phantomcircuit> sipa, i gave mine to matt
5042020-12-04T19:44:27 <phantomcircuit> either he gave them away or he's the testnet king
5052020-12-04T19:44:46 <sipa> ha
5062020-12-04T19:45:33 <gwillen> last christmas, I gave you my testnet coins, but the very next day, you gave them away
5072020-12-04T19:46:02 <luke-jr> hmm, testnet isn't letting me run it :x
5082020-12-04T19:46:17 <sipa> well, if anyone has some: 2N9KJZrryXJh26jqpX7cxHM7facYcSZrEFp
5092020-12-04T19:46:23 <achow101> sipa: how many?
5102020-12-04T19:46:32 <luke-jr> gwillen: are you implying bluematt isn't special?
5112020-12-04T19:46:53 <sipa> achow101: how many you have? :)
5122020-12-04T19:47:04 <achow101> several thousand
5132020-12-04T19:47:53 <gwillen> luke-jr: I would never
5142020-12-04T19:48:18 <sipa> gwillen: ok, you get a pass, it's december alright
5152020-12-04T19:48:30 <achow101> sipa: 6eb56f123eb1753fe6d74f5ce177c51eb99687afb34d70f72f598a1c85835bec
5162020-12-04T19:49:02 <sipa> achow101: thanks!
5172020-12-04T19:49:16 <gwillen> sipa: christmas music is allowed at any point after American Thanksgiving, I didn't make the rules
5182020-12-04T19:49:19 <sipa> gwillen: and i haven't heard any christmas songs yet this year for some reason
5192020-12-04T19:49:25 <luke-jr> gwillen: that's not the rules
5202020-12-04T19:49:33 <luke-jr> gwillen: Christmas music may begin on Christmas Day
5212020-12-04T19:50:03 <gwillen> you've failed to account for the effects of Christmas Creep, at this point you're lucky if it doesn't start right after Halloween
5222020-12-04T19:50:09 <achow101> luke-jr: begin or only on?
5232020-12-04T19:50:41 <luke-jr> achow101: well, Christmas is 40 days so
5242020-12-04T19:51:11 <luke-jr> Dec 25-Feb 2
5252020-12-04T19:51:15 <gwillen> actually I'm surprised you wouldn't allow for Christmas music starting during Advent
5262020-12-04T19:51:37 <luke-jr> Advent is supposed to be penetential
5272020-12-04T19:51:50 <gwillen> exactly, that's when the suffering should begin
5282020-12-04T19:51:56 <luke-jr> lol
5292020-12-04T19:54:57 *** Provostro <Provostro!~Pvo@168.62.56.135> has left #bitcoin-core-dev
5302020-12-04T20:34:41 *** pergaminho <pergaminho!~Cleber@189.26.121.248> has quit IRC (Quit: Saindo)
5312020-12-04T20:35:29 *** twistedline <twistedline!~twisted@c-73-200-216-219.hsd1.dc.comcast.net> has joined #bitcoin-core-dev
5322020-12-04T20:43:50 *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has quit IRC (Ping timeout: 256 seconds)
5332020-12-04T20:46:48 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5342020-12-04T20:46:48 <bitcoin-git> [bitcoin] hebasto opened pull request #20571: refactor: Use deduction guide for std::array<uint8_t, N> (master...201204-u8) https://github.com/bitcoin/bitcoin/pull/20571
5352020-12-04T20:46:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5362020-12-04T20:48:16 *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has joined #bitcoin-core-dev
5372020-12-04T20:49:54 *** davterra <davterra!~davterra@static-198-54-131-92.cust.tzulo.com> has quit IRC (Quit: Leaving)
5382020-12-04T20:57:33 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
5392020-12-04T21:03:52 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 265 seconds)
5402020-12-04T21:13:24 *** forcer1 <forcer1!~forcer@185.204.1.185> has quit IRC (Remote host closed the connection)
5412020-12-04T21:20:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5422020-12-04T21:20:38 <bitcoin-git> [bitcoin] hebasto opened pull request #20572: ci: Adjust Cirrus CI task names (follow up) (master...201204-cirrus) https://github.com/bitcoin/bitcoin/pull/20572
5432020-12-04T21:20:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5442020-12-04T21:20:57 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
5452020-12-04T21:32:57 *** Harekiet1 <Harekiet1!~Harekiet@84.39.117.57> has joined #bitcoin-core-dev
5462020-12-04T21:35:37 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
5472020-12-04T21:36:56 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 272 seconds)
5482020-12-04T21:38:56 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
5492020-12-04T21:52:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5502020-12-04T21:52:39 <bitcoin-git> [bitcoin] jonatack opened pull request #20573: wallet, bugfix: allow send with string fee_rate amounts (master...send-allow-feerates-as-strings) https://github.com/bitcoin/bitcoin/pull/20573
5512020-12-04T21:52:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5522020-12-04T21:59:43 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
5532020-12-04T22:18:06 *** dviola <dviola!~diego@unaffiliated/dviola> has quit IRC (Ping timeout: 272 seconds)
5542020-12-04T22:28:57 *** filchef <filchef!~filchef@212.104.97.177> has joined #bitcoin-core-dev
5552020-12-04T22:29:40 *** filchef <filchef!~filchef@212.104.97.177> has quit IRC (Client Quit)
5562020-12-04T22:31:14 *** dviola <dviola!~diego@187.39.20.240> has joined #bitcoin-core-dev
5572020-12-04T22:33:11 *** miketwenty1 <miketwenty1!~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com> has quit IRC (Ping timeout: 272 seconds)
5582020-12-04T22:34:26 *** dviola <dviola!~diego@187.39.20.240> has left #bitcoin-core-dev
5592020-12-04T22:36:34 *** Guyver2_ <Guyver2_!~Guyver@guyver2.xs4all.nl> has quit IRC (Remote host closed the connection)
5602020-12-04T22:52:42 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
5612020-12-04T23:00:05 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
5622020-12-04T23:03:23 *** twistedline_ <twistedline_!~twisted@c-73-200-216-219.hsd1.dc.comcast.net> has joined #bitcoin-core-dev
5632020-12-04T23:06:02 *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has quit IRC (Ping timeout: 260 seconds)
5642020-12-04T23:21:49 *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has joined #bitcoin-core-dev
5652020-12-04T23:23:16 *** twistedline_ <twistedline_!~twisted@c-73-200-216-219.hsd1.dc.comcast.net> has quit IRC (Ping timeout: 240 seconds)
5662020-12-04T23:27:25 *** miketwenty1 <miketwenty1!~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com> has joined #bitcoin-core-dev
5672020-12-04T23:28:40 *** miketwenty1 <miketwenty1!~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com> has quit IRC (Remote host closed the connection)
5682020-12-04T23:29:30 *** miketwenty1 <miketwenty1!~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com> has joined #bitcoin-core-dev
5692020-12-04T23:44:00 *** dviola <dviola!~diego@unaffiliated/dviola> has joined #bitcoin-core-dev
5702020-12-04T23:49:31 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
5712020-12-04T23:49:45 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
5722020-12-04T23:57:23 *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has quit IRC (Ping timeout: 240 seconds)