12020-12-14T00:07:07 <achow101> ok, I think my pr works now
22020-12-14T00:07:24 <achow101> I was able to do the whole macOS build and sign process and got valid binaries out the other end
32020-12-14T00:07:31 <achow101> will check sipa's pr now
42020-12-14T00:14:47 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
52020-12-14T00:14:52 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Remote host closed the connection)
62020-12-14T00:15:08 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
72020-12-14T00:19:00 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Remote host closed the connection)
82020-12-14T00:21:23 *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Ping timeout: 240 seconds)
92020-12-14T00:23:45 *** CubicEarth <CubicEarth!~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net> has quit IRC (Read error: Connection reset by peer)
102020-12-14T00:23:48 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
112020-12-14T00:27:23 *** CubicEarth <CubicEarth!~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net> has joined #bitcoin-core-dev
122020-12-14T00:31:22 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has joined #bitcoin-core-dev
132020-12-14T00:43:19 *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
142020-12-14T00:49:04 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
152020-12-14T00:50:14 *** aisak <aisak!be4a1432@190.74.20.50> has joined #bitcoin-core-dev
162020-12-14T01:05:27 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
172020-12-14T01:14:21 <achow101> sipa: 3021d9722182e2dfdcd29b1dec11514d66f3e566d5ae505d69c2c68b21f68a27 bitcoin-a4118c6e200e-osx-unsigned.tar.gz match?
182020-12-14T01:18:10 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 256 seconds)
192020-12-14T01:19:13 <sipa> achow101: match
202020-12-14T01:19:37 <achow101> vmsize 0x0000000000083000
212020-12-14T01:19:40 <achow101> no good I think
222020-12-14T01:19:51 <sipa> achow101: that's expected
232020-12-14T01:20:05 <achow101> how so?
242020-12-14T01:20:09 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
252020-12-14T01:20:09 <sipa> it'll be corrected at signature-attach time, not before
262020-12-14T01:20:16 <achow101> yes, this is post signing
272020-12-14T01:20:19 <sipa> oh
282020-12-14T01:20:20 <sipa> :(
292020-12-14T01:20:25 <sipa> wth
302020-12-14T01:20:28 <achow101> pre-signing is vmsize 0x0000000000043428
312020-12-14T01:20:36 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
322020-12-14T01:21:06 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 258 seconds)
332020-12-14T01:21:50 <achow101> our validation script correctly fails it too
342020-12-14T01:23:03 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
352020-12-14T01:24:23 <sipa> bizarre
362020-12-14T01:27:37 <fanquake> the saga continues
372020-12-14T01:28:12 <achow101> at least the bogus sig trick works
382020-12-14T01:28:28 *** aisak <aisak!be4a1432@190.74.20.50> has quit IRC (Remote host closed the connection)
392020-12-14T01:28:49 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
402020-12-14T01:33:49 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 264 seconds)
412020-12-14T01:35:30 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has joined #bitcoin-core-dev
422020-12-14T01:36:15 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
432020-12-14T01:36:16 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
442020-12-14T01:36:16 *** vasild_ is now known as vasild
452020-12-14T01:44:45 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Quit: Leaving)
462020-12-14T01:44:48 <sipa> achow101: i can't comprehend how it *did* round to 0x1000, but not 0x2000
472020-12-14T01:45:06 <sipa> the constant 0x1000 should exist anymore in any of the used code
482020-12-14T01:45:37 <sipa> is it possible it used a cached codesign_allocate from a previous build?
492020-12-14T01:48:16 <achow101> I don't think so
502020-12-14T01:48:32 <achow101> I definitely cleared the cache
512020-12-14T01:52:21 <achow101> the vmsize is also wildly off. it should've been 0x7b000
522020-12-14T01:52:53 <achow101> I thought maybe it had accidentally used my hack, but the unsigned was correct and the tarball matches yourss
532020-12-14T01:53:50 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
542020-12-14T01:54:31 <sipa> ok, perhaps changing this constant affects far more
552020-12-14T01:54:49 <sipa> still doesn't explain why the number isn't a multiple of 0x2000, though
562020-12-14T01:54:56 <sipa> i don't see how that's possible
572020-12-14T01:57:49 <sipa> achow101: do you have the unsigned Bitcoin-Qt binary somewhere?
582020-12-14T01:58:09 <achow101> yeah, do you need it?
592020-12-14T01:58:28 <sipa> oh, i guess i have it too!
602020-12-14T01:59:54 <achow101> I would expect so, since you did the gitian build
612020-12-14T02:00:18 <sipa> yeah, i do
622020-12-14T02:01:16 <sipa> any way to see the vmsize from linux?
632020-12-14T02:01:37 <achow101> native_cctools also has otool
642020-12-14T02:01:52 <achow101> it'll be x86_64-apple-darwin-otool
652020-12-14T02:02:03 <achow101> it'll be x86_64-apple-darwin-otool -l Bitcoin-Qt
662020-12-14T02:03:21 <sipa> what's the sig size?
672020-12-14T02:04:52 <achow101> 224592
682020-12-14T02:05:25 <sipa> unsigned:
692020-12-14T02:05:26 <sipa> segname __LINKEDIT
702020-12-14T02:05:26 <sipa> vmaddr 0x00000001018fa000
712020-12-14T02:05:27 <sipa> vmsize 0x0000000000043428
722020-12-14T02:05:39 <sipa> i run:
732020-12-14T02:05:42 <sipa> $ ./codesign_allocate -i dist/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt -a x86_64 224592 -o out
742020-12-14T02:06:12 <sipa> output:
752020-12-14T02:06:13 <sipa> segname __LINKEDIT
762020-12-14T02:06:13 <sipa> vmaddr 0x00000001018fa000
772020-12-14T02:06:14 <sipa> vmsize 0x000000000007c000
782020-12-14T02:06:38 <achow101> hmmm
792020-12-14T02:06:42 <achow101> ???????
802020-12-14T02:07:04 <sipa> this is using the codesign_allocate tool in my gitian build output
812020-12-14T02:07:14 <achow101> I guess I have an unclean environment
822020-12-14T02:08:13 <achow101> oh, it must be grabbing the wrong unsigned tarball
832020-12-14T02:08:40 *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has joined #bitcoin-core-dev
842020-12-14T02:15:11 <achow101> I can't get it to make the correct size
852020-12-14T02:16:03 <sipa> how are you invoking gitian-build.py ?
862020-12-14T02:16:15 <achow101> i'm using gbuild directly
872020-12-14T02:16:25 <achow101> https://drive.google.com/file/d/1xFdpQoAKHNG9eC6Jw5rY7gzIwb7rgR-q/view?usp=sharing is the sig tarball if you want to try
882020-12-14T02:17:22 <achow101> I'll try applying it manually
892020-12-14T02:20:38 <sipa> my best guess is thah somehow it's using the wrong bitcoin-osx-unsigned.tar.gz
902020-12-14T02:22:32 <achow101> running it locally instead of gitian definintely does the right thing
912020-12-14T02:23:09 <achow101> and it is valid
922020-12-14T02:25:46 *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has quit IRC (Ping timeout: 256 seconds)
932020-12-14T02:31:44 *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has joined #bitcoin-core-dev
942020-12-14T02:33:00 <achow101> ok, I got it working, it is valid now
952020-12-14T02:33:15 <achow101> it was the filenames...
962020-12-14T02:35:35 <sipa> 2 hardest problems in computer science: concurrency, off by one errors, and naming stuff
972020-12-14T02:35:50 <achow101> heh
982020-12-14T02:37:06 *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has quit IRC (Ping timeout: 256 seconds)
992020-12-14T02:37:44 *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has joined #bitcoin-core-dev
1002020-12-14T02:38:04 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1012020-12-14T02:38:05 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ade38b6ee8f9...25bc840e038f
1022020-12-14T02:38:05 <bitcoin-git> bitcoin/master a33442f Antoine Riard: Remove m_is_manual_connection from CNodeState
1032020-12-14T02:38:06 <bitcoin-git> bitcoin/master 25bc840 fanquake: Merge #20617: p2p: Remove m_is_manual_connection from CNodeState
1042020-12-14T02:38:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1052020-12-14T02:38:24 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1062020-12-14T02:38:24 <bitcoin-git> [bitcoin] fanquake merged pull request #20617: p2p: Remove m_is_manual_connection from CNodeState (master...2020-12-remove-is-manual-connection) https://github.com/bitcoin/bitcoin/pull/20617
1072020-12-14T02:38:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1082020-12-14T02:41:05 *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has quit IRC (Remote host closed the connection)
1092020-12-14T02:41:31 *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has joined #bitcoin-core-dev
1102020-12-14T02:42:47 <fanquake> Given the state of the last few PRs, looks like Appveyor is broken? I'm seeing:
1112020-12-14T02:42:50 <fanquake> EXEC : error : Building package openssl-windows:x64-windows-static failed with: BUILD_FAILED ...
1122020-12-14T02:46:35 *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has quit IRC (Ping timeout: 258 seconds)
1132020-12-14T02:52:59 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1142020-12-14T03:02:30 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
1152020-12-14T03:07:26 *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has joined #bitcoin-core-dev
1162020-12-14T03:11:43 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
1172020-12-14T03:12:23 *** fearbeag <fearbeag!~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca> has quit IRC (Ping timeout: 260 seconds)
1182020-12-14T03:15:49 *** dviola <dviola!~diego@unaffiliated/dviola> has quit IRC (Quit: WeeChat 2.9)
1192020-12-14T03:17:03 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
1202020-12-14T03:30:27 <luke-jr> appveyor always broken..?
1212020-12-14T04:15:32 *** tralfaz <tralfaz!~davterra@gateway/tor-sasl/tralfaz> has quit IRC (Quit: Leaving)
1222020-12-14T04:42:23 *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
1232020-12-14T04:51:58 *** jessepos_ <jessepos_!~jp@2601:643:8980:bfd2:447f:3dcb:9ae8:5b10> has joined #bitcoin-core-dev
1242020-12-14T04:55:22 *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:3c52:ceaf:5e03:1c52> has quit IRC (Ping timeout: 260 seconds)
1252020-12-14T04:56:47 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Remote host closed the connection)
1262020-12-14T04:59:14 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Quit: Leaving)
1272020-12-14T05:23:10 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
1282020-12-14T05:36:49 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 264 seconds)
1292020-12-14T06:09:37 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
1302020-12-14T06:09:57 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
1312020-12-14T06:20:46 *** vanaltj1 <vanaltj1!~vanaltj@84.39.117.57> has joined #bitcoin-core-dev
1322020-12-14T06:53:15 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has joined #bitcoin-core-dev
1332020-12-14T07:06:49 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 264 seconds)
1342020-12-14T07:15:31 *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:3cdc:b002:cf8:d4b2> has joined #bitcoin-core-dev
1352020-12-14T07:19:27 *** jessepos_ <jessepos_!~jp@2601:643:8980:bfd2:447f:3dcb:9ae8:5b10> has quit IRC (Ping timeout: 260 seconds)
1362020-12-14T07:29:14 *** tlev <tlev!~tlev@li120-195.members.linode.com> has quit IRC (Quit: Ping timeout (120 seconds))
1372020-12-14T07:29:28 *** tlev <tlev!~tlev@li120-195.members.linode.com> has joined #bitcoin-core-dev
1382020-12-14T07:33:30 *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has quit IRC (Remote host closed the connection)
1392020-12-14T07:33:47 *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
1402020-12-14T07:37:48 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
1412020-12-14T07:39:47 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has joined #bitcoin-core-dev
1422020-12-14T08:14:05 *** jessepos_ <jessepos_!~jp@2601:643:8980:bfd2:3cdc:b002:cf8:d4b2> has joined #bitcoin-core-dev
1432020-12-14T08:15:27 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has quit IRC (Ping timeout: 260 seconds)
1442020-12-14T08:15:27 *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:3cdc:b002:cf8:d4b2> has quit IRC (Ping timeout: 260 seconds)
1452020-12-14T08:16:02 *** sirpesto <sirpesto!sirpestoma@gateway/shell/matrix.org/x-owmmtitoawaupjmk> has quit IRC (Ping timeout: 260 seconds)
1462020-12-14T08:16:34 *** icota[m] <icota[m]!icotamatri@gateway/shell/matrix.org/x-rnuqoxaxpepnbgsa> has joined #bitcoin-core-dev
1472020-12-14T08:16:54 *** vanaltj1 <vanaltj1!~vanaltj@84.39.117.57> has quit IRC (*.net *.split)
1482020-12-14T08:16:54 *** jonatack <jonatack!~jon@134.19.179.139> has quit IRC (*.net *.split)
1492020-12-14T08:16:54 *** promag_ <promag_!~promag@188.250.84.129> has quit IRC (*.net *.split)
1502020-12-14T08:16:54 *** adiabat <adiabat!~adiabat@63.209.32.102> has quit IRC (*.net *.split)
1512020-12-14T08:16:55 *** darosior <darosior!~darosior@194.36.189.246> has quit IRC (*.net *.split)
1522020-12-14T08:16:55 *** dr-orlovsky <dr-orlovsky!~dr-orlovs@31.14.40.19> has quit IRC (*.net *.split)
1532020-12-14T08:16:55 *** btc_thc <btc_thc!annalee@kosher.marriageiguana.com> has quit IRC (*.net *.split)
1542020-12-14T08:16:55 *** gleb <gleb!~gleb@178.150.137.228> has quit IRC (*.net *.split)
1552020-12-14T08:16:55 *** nullptr| <nullptr|!~nullptr|@ip-94-112-13-119.net.upcbroadband.cz> has quit IRC (*.net *.split)
1562020-12-14T08:16:55 *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-ulqcremawialdixq> has quit IRC (*.net *.split)
1572020-12-14T08:16:56 *** cfields <cfields!~cfields@unaffiliated/cfields> has quit IRC (*.net *.split)
1582020-12-14T08:16:56 *** rabidus <rabidus!~rabidus@dsl-olubng12-54fa0c-1.dhcp.inet.fi> has quit IRC (*.net *.split)
1592020-12-14T08:16:56 *** wxss <wxss!~user@mail.deeplinkmedia.com> has quit IRC (*.net *.split)
1602020-12-14T08:16:57 *** pingwindyktator <pingwindyktator!~pingwindy@pingwindyktator.me> has quit IRC (*.net *.split)
1612020-12-14T08:17:20 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has joined #bitcoin-core-dev
1622020-12-14T08:17:38 *** sirpesto <sirpesto!sirpestoma@gateway/shell/matrix.org/x-dllbxpcyqshawxcr> has joined #bitcoin-core-dev
1632020-12-14T08:19:25 *** wraithm <wraithm!~wraithm@unaffiliated/wraithm> has quit IRC (Ping timeout: 264 seconds)
1642020-12-14T08:22:19 *** vanaltj1 <vanaltj1!~vanaltj@84.39.117.57> has joined #bitcoin-core-dev
1652020-12-14T08:22:19 *** jonatack <jonatack!~jon@134.19.179.139> has joined #bitcoin-core-dev
1662020-12-14T08:22:19 *** promag_ <promag_!~promag@188.250.84.129> has joined #bitcoin-core-dev
1672020-12-14T08:22:19 *** adiabat <adiabat!~adiabat@63.209.32.102> has joined #bitcoin-core-dev
1682020-12-14T08:22:19 *** darosior <darosior!~darosior@194.36.189.246> has joined #bitcoin-core-dev
1692020-12-14T08:22:19 *** dr-orlovsky <dr-orlovsky!~dr-orlovs@31.14.40.19> has joined #bitcoin-core-dev
1702020-12-14T08:22:19 *** btc_thc <btc_thc!annalee@kosher.marriageiguana.com> has joined #bitcoin-core-dev
1712020-12-14T08:22:19 *** gleb <gleb!~gleb@178.150.137.228> has joined #bitcoin-core-dev
1722020-12-14T08:22:19 *** nullptr| <nullptr|!~nullptr|@ip-94-112-13-119.net.upcbroadband.cz> has joined #bitcoin-core-dev
1732020-12-14T08:22:19 *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-ulqcremawialdixq> has joined #bitcoin-core-dev
1742020-12-14T08:22:19 *** cfields <cfields!~cfields@unaffiliated/cfields> has joined #bitcoin-core-dev
1752020-12-14T08:22:19 *** rabidus <rabidus!~rabidus@dsl-olubng12-54fa0c-1.dhcp.inet.fi> has joined #bitcoin-core-dev
1762020-12-14T08:22:19 *** wxss <wxss!~user@mail.deeplinkmedia.com> has joined #bitcoin-core-dev
1772020-12-14T08:22:19 *** pingwindyktator <pingwindyktator!~pingwindy@pingwindyktator.me> has joined #bitcoin-core-dev
1782020-12-14T08:22:29 *** wraithm <wraithm!~wraithm@unaffiliated/wraithm> has joined #bitcoin-core-dev
1792020-12-14T08:37:03 *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Ping timeout: 240 seconds)
1802020-12-14T08:43:00 *** hidrodo <hidrodo!76c811dd@118.200.17.221> has joined #bitcoin-core-dev
1812020-12-14T08:47:39 *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has joined #bitcoin-core-dev
1822020-12-14T08:49:13 *** hidrodo <hidrodo!76c811dd@118.200.17.221> has quit IRC (Remote host closed the connection)
1832020-12-14T08:54:41 *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
1842020-12-14T09:10:17 *** tralfaz <tralfaz!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
1852020-12-14T09:10:43 *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has quit IRC (Ping timeout: 240 seconds)
1862020-12-14T09:22:10 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1872020-12-14T09:22:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1882020-12-14T09:22:34 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20648: chainparams: Add default fixed seeds for signet (master...2012-chainFixedSeedsSignet) https://github.com/bitcoin/bitcoin/pull/20648
1892020-12-14T09:22:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1902020-12-14T09:32:25 *** kljasdfvv <kljasdfvv!~flack@p200300d46f24de00c295a82d97bf2816.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
1912020-12-14T09:34:42 *** kljasdfvv <kljasdfvv!~flack@p200300d46f24de00c295a82d97bf2816.dip0.t-ipconnect.de> has quit IRC (Client Quit)
1922020-12-14T09:36:28 *** kljasdfvv <kljasdfvv!~flack@p200300d46f24de00a3ce7892b0332293.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
1932020-12-14T09:38:29 <wumpus> achow101: nice!
1942020-12-14T09:40:37 *** kabaum <kabaum!~kabaum@h-13-35.A163.priv.bahnhof.se> has joined #bitcoin-core-dev
1952020-12-14T09:47:09 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 265 seconds)
1962020-12-14T09:51:56 <jonatack> yes, seeing the same appveyor issue
1972020-12-14T09:55:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1982020-12-14T09:55:24 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/25bc840e038f...096bd374da28
1992020-12-14T09:55:25 <bitcoin-git> bitcoin/master 4b7b58b Jon Atack: Update net_processing WTXID documentation per BIP339
2002020-12-14T09:55:25 <bitcoin-git> bitcoin/master 096bd37 MarcoFalke: Merge #20592: doc: update wtxidrelay documentation per BIP339
2012020-12-14T09:55:27 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2022020-12-14T09:55:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2032020-12-14T09:55:44 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20592: doc: update wtxidrelay documentation per BIP339 (master...update-wtxid-documentation-per-BIP339) https://github.com/bitcoin/bitcoin/pull/20592
2042020-12-14T09:55:45 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2052020-12-14T09:57:28 *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has quit IRC (Quit: Find me in #TheHolyRoger or https://theholyroger.com)
2062020-12-14T09:58:14 *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has joined #bitcoin-core-dev
2072020-12-14T10:03:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2082020-12-14T10:03:45 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/096bd374da28...eec9366f7dd6
2092020-12-14T10:03:45 <bitcoin-git> bitcoin/master 8b57013 John Newbery: [net processing] Remove nStartingHeight check from block relay
2102020-12-14T10:03:46 <bitcoin-git> bitcoin/master 94d2cc3 John Newbery: [net processing] Remove unnecesary nNewHeight variable in UpdatedBlockTip()
2112020-12-14T10:03:47 <bitcoin-git> bitcoin/master f636008 John Newbery: [net processing] Clarify UpdatedBlockTip()
2122020-12-14T10:03:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2132020-12-14T10:04:14 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2142020-12-14T10:04:14 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20624: net processing: Remove nStartingHeight check from block relay (master...2020-12-remove-starting-height) https://github.com/bitcoin/bitcoin/pull/20624
2152020-12-14T10:04:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2162020-12-14T10:16:59 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
2172020-12-14T10:17:05 <aj> really? proposed on friday, merged on monday?
2182020-12-14T10:23:31 *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has quit IRC (Remote host closed the connection)
2192020-12-14T10:24:28 *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
2202020-12-14T11:00:58 *** potato <potato!~Thunderbi@240d:1a:3d4:7d00:902d:8574:a5b7:8124> has joined #bitcoin-core-dev
2212020-12-14T11:16:02 *** davec <davec!~davec@072-183-054-196.res.spectrum.com> has quit IRC (Ping timeout: 260 seconds)
2222020-12-14T11:16:38 *** davec <davec!~davec@072-183-054-196.res.spectrum.com> has joined #bitcoin-core-dev
2232020-12-14T11:18:28 *** Estel51Heidenrei <Estel51Heidenrei!~Estel51He@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
2242020-12-14T11:18:45 <wumpus> that *is* really fast for a (non-trivial) P2P change
2252020-12-14T11:19:49 <wumpus> especially over a december weekend where everyone was occupied with macos signing
2262020-12-14T11:20:27 <wumpus> (pretty sure it's correct but we should be careful)
2272020-12-14T11:23:18 *** Estel51Heidenrei <Estel51Heidenrei!~Estel51He@static.57.1.216.95.clients.your-server.de> has quit IRC (Ping timeout: 256 seconds)
2282020-12-14T11:26:23 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
2292020-12-14T11:26:46 *** davec <davec!~davec@072-183-054-196.res.spectrum.com> has quit IRC (Ping timeout: 256 seconds)
2302020-12-14T11:27:02 *** davec <davec!~davec@072-183-054-196.res.spectrum.com> has joined #bitcoin-core-dev
2312020-12-14T11:28:07 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2322020-12-14T11:28:07 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20649: refactor: Remove nMyStartingHeight from CNode/Connman (master...2012-netNoMyHeight) https://github.com/bitcoin/bitcoin/pull/20649
2332020-12-14T11:28:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2342020-12-14T11:28:52 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
2352020-12-14T11:29:24 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
2362020-12-14T11:30:32 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
2372020-12-14T11:42:23 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has quit IRC (Ping timeout: 240 seconds)
2382020-12-14T11:43:59 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
2392020-12-14T11:45:57 *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has quit IRC (Quit: Leaving)
2402020-12-14T11:55:22 *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has quit IRC (Remote host closed the connection)
2412020-12-14T11:57:27 *** vanaltj1 <vanaltj1!~vanaltj@84.39.117.57> has quit IRC (Remote host closed the connection)
2422020-12-14T12:00:09 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has joined #bitcoin-core-dev
2432020-12-14T12:15:49 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
2442020-12-14T12:18:47 *** kro[au] <kro[au]!~kroau]@s91904426.blix.com> has joined #bitcoin-core-dev
2452020-12-14T12:22:03 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
2462020-12-14T12:22:29 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
2472020-12-14T12:23:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2482020-12-14T12:23:08 <bitcoin-git> [bitcoin] hebasto opened pull request #20650: depends: Drop workaround for a fixed bug in Qt build system (master...201214-xcb) https://github.com/bitcoin/bitcoin/pull/20650
2492020-12-14T12:23:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2502020-12-14T12:23:32 *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has joined #bitcoin-core-dev
2512020-12-14T12:31:23 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
2522020-12-14T12:36:10 *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has quit IRC (Remote host closed the connection)
2532020-12-14T12:36:32 *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has joined #bitcoin-core-dev
2542020-12-14T12:36:36 *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has quit IRC (Client Quit)
2552020-12-14T12:37:33 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
2562020-12-14T12:40:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2572020-12-14T12:40:14 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/eec9366f7dd6...b103fdcb3bf4
2582020-12-14T12:40:15 <bitcoin-git> bitcoin/master 7fabe0f Vasil Dimov: net: don't relay to the address' originator
2592020-12-14T12:40:16 <bitcoin-git> bitcoin/master b103fdc MarcoFalke: Merge #19763: net: don't try to relay to the address' originator
2602020-12-14T12:40:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2612020-12-14T12:40:25 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has joined #bitcoin-core-dev
2622020-12-14T12:40:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2632020-12-14T12:40:34 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19763: net: don't try to relay to the address' originator (master...only_relay_to_unaware) https://github.com/bitcoin/bitcoin/pull/19763
2642020-12-14T12:40:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2652020-12-14T12:47:05 *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has joined #bitcoin-core-dev
2662020-12-14T12:48:27 *** davec <davec!~davec@072-183-054-196.res.spectrum.com> has quit IRC (Ping timeout: 260 seconds)
2672020-12-14T12:48:41 *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has quit IRC (Client Quit)
2682020-12-14T12:50:37 *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has joined #bitcoin-core-dev
2692020-12-14T12:53:44 *** davec <davec!~davec@072-183-054-196.res.spectrum.com> has joined #bitcoin-core-dev
2702020-12-14T13:01:56 *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has joined #bitcoin-core-dev
2712020-12-14T13:01:58 *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has quit IRC (Client Quit)
2722020-12-14T13:03:54 *** tralfaz is now known as davterra
2732020-12-14T13:07:42 *** dermoth_ <dermoth_!~dermoth@unaffiliated/dermoth> has joined #bitcoin-core-dev
2742020-12-14T13:07:42 *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has quit IRC (Disconnected by services)
2752020-12-14T13:08:00 *** dermoth_ is now known as dermoth
2762020-12-14T13:22:46 *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has joined #bitcoin-core-dev
2772020-12-14T13:22:48 *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has quit IRC (Client Quit)
2782020-12-14T13:25:18 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2792020-12-14T13:25:18 <bitcoin-git> [bitcoin] jnewbery opened pull request #20651: net: Make p2p recv buffer timeout 20 minutes for all peers (master...2020-12-recv-buffer-timeout) https://github.com/bitcoin/bitcoin/pull/20651
2802020-12-14T13:25:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2812020-12-14T13:36:12 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
2822020-12-14T13:36:13 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
2832020-12-14T13:36:14 *** vasild_ is now known as vasild
2842020-12-14T13:37:35 *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has joined #bitcoin-core-dev
2852020-12-14T13:37:42 *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has quit IRC (Client Quit)
2862020-12-14T13:40:52 *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has joined #bitcoin-core-dev
2872020-12-14T13:41:09 *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has quit IRC (Client Quit)
2882020-12-14T13:43:08 *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:7d7e:ee39:a576:2c3c> has joined #bitcoin-core-dev
2892020-12-14T13:46:41 *** jessepos_ <jessepos_!~jp@2601:643:8980:bfd2:3cdc:b002:cf8:d4b2> has quit IRC (Ping timeout: 258 seconds)
2902020-12-14T13:48:38 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
2912020-12-14T13:53:32 *** kro[au] <kro[au]!~kroau]@s91904426.blix.com> has quit IRC (Remote host closed the connection)
2922020-12-14T13:54:52 *** jessepos_ <jessepos_!~jp@2601:643:8980:bfd2:98c1:5a96:a9af:37d1> has joined #bitcoin-core-dev
2932020-12-14T13:55:08 *** Nolar <Nolar!~Nolar@178.162.209.171> has joined #bitcoin-core-dev
2942020-12-14T13:55:43 <provoostenator> I assume there will be an rc4 to deal with the non-determinism macOS nightmare? So no point in me signing rc3?
2952020-12-14T13:58:27 *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:7d7e:ee39:a576:2c3c> has quit IRC (Ping timeout: 260 seconds)
2962020-12-14T14:08:31 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has joined #bitcoin-core-dev
2972020-12-14T14:09:21 <jonasschnelli> provoostenator: yes.
2982020-12-14T14:09:40 <jonasschnelli> provoostenator: I mean you can still sing the windows build... but the macOS is useless
2992020-12-14T14:19:03 *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
3002020-12-14T14:34:23 *** lontivero <lontivero!~lontivero@186.183.50.53> has joined #bitcoin-core-dev
3012020-12-14T14:36:32 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3022020-12-14T14:36:32 <bitcoin-git> [bitcoin] gbizzotto opened pull request #20652: Designer fees when coin control is enabled: (master...master) https://github.com/bitcoin/bitcoin/pull/20652
3032020-12-14T14:36:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3042020-12-14T14:37:15 *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has joined #bitcoin-core-dev
3052020-12-14T14:37:41 *** Pavlenex <Pavlenex!~Thunderbi@185.245.85.251> has quit IRC (Client Quit)
3062020-12-14T14:42:08 *** pinheadm_ <pinheadm_!~pinheadmz@71.190.30.138> has joined #bitcoin-core-dev
3072020-12-14T14:45:07 *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has quit IRC (Ping timeout: 260 seconds)
3082020-12-14T14:50:48 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
3092020-12-14T14:53:20 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has joined #bitcoin-core-dev
3102020-12-14T14:54:52 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
3112020-12-14T14:55:29 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
3122020-12-14T15:00:52 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d> has quit IRC (Ping timeout: 260 seconds)
3132020-12-14T15:01:34 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
3142020-12-14T15:21:23 *** miketwen_ <miketwen_!~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com> has joined #bitcoin-core-dev
3152020-12-14T15:25:16 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 256 seconds)
3162020-12-14T15:27:08 <wumpus> it's certain that there will be a rc4, that said, if you're going to sign rc3 or not is up to you
3172020-12-14T15:27:39 <wumpus> it's still worth testing rc3 for other things, besides the macos determinism change i do not expect many differences
3182020-12-14T15:30:42 <provoostenator> The determinism thing relates only to the signed binary, or also to the unsiged?
3192020-12-14T15:30:58 <provoostenator> (code signed)
3202020-12-14T15:32:01 <wumpus> sorry, it's not a determinism problem this time, it's a "broken code signature" problem, and it applies only to the codesigned build
3212020-12-14T15:34:07 <wumpus> the -unsigned macos build should be fine
3222020-12-14T15:35:26 <provoostenator> Ok, I managed to get a different unsigned build with #20638, so I'll build rc3 as well to see what's going on
3232020-12-14T15:35:28 <gribble> https://github.com/bitcoin/bitcoin/issues/20638 | build: Fix macOS code signing by pre-allocating space for the code signature during gitian build by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub
3242020-12-14T15:40:32 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3252020-12-14T15:40:32 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #20652: Designer fees when coin control is enabled (master...master) https://github.com/bitcoin/bitcoin/pull/20652
3262020-12-14T15:40:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3272020-12-14T15:40:44 <ariard> I proposed the following topic for tmrw p2p meeting : "Review of the P2P Review Process" : https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings
3282020-12-14T15:41:17 <ariard> it's end of year and it can be cool to reflect on the last 12 months of p2p PRs, what we can learn from :)
3292020-12-14T15:41:43 <ariard> feel free to add more example PRs, the ones I picked up were mostly on the number of comments
3302020-12-14T15:46:16 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 265 seconds)
3312020-12-14T15:50:53 <luke-jr> I wonder if there should be a "Backported" label to make it easier to look for missing backports (MarcoFalke, thoughts?)
3322020-12-14T15:52:47 <wumpus> please not another backport related label :-)
3332020-12-14T15:54:06 <luke-jr> <.<
3342020-12-14T15:54:49 <wumpus> I mean it's a little bit more work but you could look in the history of the PR whether it's been backported, or was ever to be backported, to the branch you're interested in
3352020-12-14T15:55:31 <wumpus> ariard: good idea
3362020-12-14T15:56:48 <luke-jr> is there a motive behind #20599 ?
3372020-12-14T15:56:51 <gribble> https://github.com/bitcoin/bitcoin/issues/20599 | net processing: Tolerate sendheaders and sendcmpct messages before verack by jnewbery · Pull Request #20599 · bitcoin/bitcoin · GitHub
3382020-12-14T15:57:11 <luke-jr> wumpus: my thought is to list all merged PRs minus backported ones
3392020-12-14T15:57:22 *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
3402020-12-14T15:58:39 <luke-jr> + a filter for bugfixes, it'd be pretty clean/easy actually
3412020-12-14T15:58:46 <wumpus> FWIW you could do this with a script, looking at commit metadata on the branches
3422020-12-14T15:59:09 <luke-jr> maybe, but a github link would be easier/nicer :P
3432020-12-14T15:59:12 <wumpus> it's more thorough than a tag that people might forget or not
3442020-12-14T15:59:20 <wumpus> also it's *per branch*
3452020-12-14T16:00:16 *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 240 seconds)
3462020-12-14T16:00:50 <wumpus> luke-jr: yes, to make it (on the very long term) possible move all protocol negotiation to that phase
3472020-12-14T16:01:49 *** belcher_ is now known as belcher
3482020-12-14T16:09:27 *** StopAndDecrypt <StopAndDecrypt!~StopAndDe@unaffiliated/stopanddecrypt> has joined #bitcoin-core-dev
3492020-12-14T16:10:44 <jonatack> ariard: i wonder if long-term contributors think the review bottleneck has improved over the past year...i'm too close to be objective but not sure that it has
3502020-12-14T16:11:07 <jonatack> s/review/review and testing/
3512020-12-14T16:12:56 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
3522020-12-14T16:13:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3532020-12-14T16:13:55 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b103fdcb3bf4...fff7d056a92f
3542020-12-14T16:13:55 <bitcoin-git> bitcoin/master b316dcb John Newbery: [net processing] Tolerate sendheaders and sendcmpct messages before verack...
3552020-12-14T16:13:56 <bitcoin-git> bitcoin/master fff7d05 MarcoFalke: Merge #20599: net processing: Tolerate sendheaders and sendcmpct messages ...
3562020-12-14T16:13:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3572020-12-14T16:14:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3582020-12-14T16:14:10 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20599: net processing: Tolerate sendheaders and sendcmpct messages before verack (master...2020-12-tolerate-early-send-messages) https://github.com/bitcoin/bitcoin/pull/20599
3592020-12-14T16:14:11 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3602020-12-14T16:17:10 <luke-jr> jonatack: IMO I'm also too close (and haven't even tried to look at it objectively), but I also think it hasn't improved
3612020-12-14T16:23:34 *** joelklabo <joelklabo!~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
3622020-12-14T16:34:42 <achow101> provoostenator: can you provide the bitcoin-7f9d623e0210-osx-unsigned.tar.gz for your build of #20638?
3632020-12-14T16:34:44 <gribble> https://github.com/bitcoin/bitcoin/issues/20638 | build: Fix macOS code signing by pre-allocating space for the code signature during gitian build by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub
3642020-12-14T16:35:33 <achow101> also, did you build 7f9d623 or the merge with master?
3652020-12-14T16:38:23 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
3662020-12-14T16:45:17 <provoostenator> achow101: I'll try to drop it somewhere. I built the commit
3672020-12-14T16:45:21 <provoostenator> (the branch)
3682020-12-14T16:51:14 <ariard> jonatack: how would you qualify such improvements? for really good reasons, it's a hard question, you have to consider we've all different priorities :)
3692020-12-14T16:59:39 <achow101> provoostenator: can you rebuild with a clean cache? it seems like the qt nondeterminism issue we fixed for rc2. did you perhaps do a gitian build on master earlier?
3702020-12-14T16:59:56 <provoostenator> Remind me how to nuke cache?
3712020-12-14T17:00:08 <provoostenator> Last thing I built before this was rc2
3722020-12-14T17:00:13 <provoostenator> I never built rc3
3732020-12-14T17:00:22 <provoostenator> (although I just did, but will do that again later, with a fresh cache)
3742020-12-14T17:00:26 <jonatack> rm -r cache
3752020-12-14T17:00:27 <jonatack> ?
3762020-12-14T17:00:30 <achow101> if you did a master build before that, it would use the master cache
3772020-12-14T17:00:32 <jonatack> make -C ../bitcoin/depends download SOURCES_PATH=`pwd`/cache/common
3782020-12-14T17:00:46 <achow101> rm -rf gitian-builder/cache/bitcoin-core-osx-22/
3792020-12-14T17:00:56 <jonatack> in gitian-builder
3802020-12-14T17:01:22 <jonatack> achow101: oh just the one, ok
3812020-12-14T17:01:27 <achow101> or if you want to nuke the entire cache, rm -r gitian-builder/cache
3822020-12-14T17:01:36 <provoostenator> I janked the whole cache, building your branch again now
3832020-12-14T17:01:54 <provoostenator> I prefer nuking cache over carefully salvaging it
3842020-12-14T17:02:01 <jonatack> heh
3852020-12-14T17:02:40 *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has joined #bitcoin-core-dev
3862020-12-14T17:03:51 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
3872020-12-14T17:08:46 *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has quit IRC (Quit: Pavlenex)
3882020-12-14T17:08:54 *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has quit IRC (Remote host closed the connection)
3892020-12-14T17:18:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3902020-12-14T17:18:31 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20653: doc: Move add relay comment in net to correct place (master...2012-docNetAddrRelay) https://github.com/bitcoin/bitcoin/pull/20653
3912020-12-14T17:18:32 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3922020-12-14T17:22:43 <wumpus> luke-jr: i'm not sure how to interpret your comment on #20605, are there any cases in which you see the code is unsafe on windows?
3932020-12-14T17:22:46 <gribble> https://github.com/bitcoin/bitcoin/issues/20605 | init: Signal-safe instant shutdown by laanwj · Pull Request #20605 · bitcoin/bitcoin · GitHub
3942020-12-14T17:24:11 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has quit IRC (Remote host closed the connection)
3952020-12-14T17:24:45 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has joined #bitcoin-core-dev
3962020-12-14T17:32:42 <luke-jr> wumpus: I don't know how Windows signals work, but there are definitely signals..
3972020-12-14T17:32:55 <wumpus> if so, is there any way to a similar thing to the pipe trick, if not we need to keep the polling loop on windows
3982020-12-14T17:34:05 <wumpus> I'm fine with that tbh, though it would have been nice to use a proper condition variable at least on one os
3992020-12-14T17:34:38 <luke-jr> https://docs.microsoft.com/en-us/windows/win32/api/namedpipeapi/nf-namedpipeapi-createpipe exists, but again, I don't know if we need it
4002020-12-14T17:35:31 <wumpus> I'm sure it exists
4012020-12-14T17:35:41 <sipa> https://docs.microsoft.com/en-us/previous-versions/xdkz3x12(v=vs.140)
4022020-12-14T17:36:04 <wumpus> the question is, is the solution wit ha condition variable safe, the pipe trick itself is very much a UNIX specitic thing and makes no sense *as it is* on win32
4032020-12-14T17:36:41 <wumpus> I think I prefer changing the PR to keep using the poll loop on windows, I dont' know enough about that OS to be sure of this
4042020-12-14T17:37:06 <wumpus> or maybe just close the PR maybe it's not relevant at all I dunno
4052020-12-14T17:38:08 <provoostenator> achow101: nuked cache, ran the build again, same result
4062020-12-14T17:38:13 <sipa> wumpus: so i'm confused in my link whether Win32 refers to just 32-bit windows
4072020-12-14T17:38:16 <sipa> or all windows
4082020-12-14T17:38:17 <provoostenator> Do I also need to replace the SDK?
4092020-12-14T17:38:31 <sipa> because it says it invokes the signal handler in a new thread
4102020-12-14T17:38:52 <wumpus> sipa: I don't know either
4112020-12-14T17:39:00 <achow101> provoostenator: shouldn't be necessary. I'll dig a bit further then
4122020-12-14T17:39:18 <achow101> but it doesn't seem like the issue is with the changes in the pr since it's all in the middle of the binary
4132020-12-14T17:40:06 <provoostenator> I'll push my rc3 as well
4142020-12-14T17:40:55 <luke-jr> sipa: it sounds like that's not even applicable to the signal() call
4152020-12-14T17:41:23 <luke-jr> sipa: as I read it, you can't use signal() for SIGINT because SIGINT is supposed to get its own thread (implying signal() doesn't do own thread)
4162020-12-14T17:42:21 <sipa> luke-jr: yes
4172020-12-14T17:42:48 <wumpus> we don't *use* signal() on windows though
4182020-12-14T17:43:18 <wumpus> so it shouldn't affect safety in our case because it doesn't call RequestShutdown
4192020-12-14T17:43:29 <sipa> wumpus: oh!
4202020-12-14T17:43:33 <sipa> there is an equivalent to catch interrupt signals for console applications, though
4212020-12-14T17:43:38 <sipa> we just don't?
4222020-12-14T17:43:51 <wumpus> there's a call to SetConsoleCtrlHandler
4232020-12-14T17:43:57 <wumpus> I have no idea what that does
4242020-12-14T17:43:58 <sipa> ah
4252020-12-14T17:45:16 <provoostenator> My rc3 checksums for macOS are pretty much the same as other contributors.
4262020-12-14T17:45:18 <wumpus> it does a Sleep(INFINITE) after calling StartShutdown so it seems to be different from a UNIX signal
4272020-12-14T17:45:20 <sipa> https://docs.microsoft.com/en-us/windows/console/console-control-handlers
4282020-12-14T17:45:25 <sipa> wumpus: separate thread
4292020-12-14T17:45:27 <sipa> we're good
4302020-12-14T17:45:40 *** Sebimot0 <Sebimot0!~tom@230.15.195.173.client.static.strong-in52.as13926.net> has joined #bitcoin-core-dev
4312020-12-14T17:45:53 <wumpus> yes, a separate thread should be safe, that's exactly what a condition variable is supposed tobe about
4322020-12-14T17:46:06 <sipa> indeed
4332020-12-14T17:46:50 <wumpus> thanks for looking that up
4342020-12-14T17:47:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4352020-12-14T17:47:57 <bitcoin-git> [bitcoin] laanwj reopened pull request #20605: init: Signal-safe instant shutdown (master...2020_12_instant_shutdown) https://github.com/bitcoin/bitcoin/pull/20605
4362020-12-14T17:47:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4372020-12-14T17:49:47 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Read error: Connection reset by peer)
4382020-12-14T17:50:10 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
4392020-12-14T17:51:53 *** kexkey <kexkey!~kexkey@static-198-54-132-174.cust.tzulo.com> has joined #bitcoin-core-dev
4402020-12-14T17:54:27 *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
4412020-12-14T17:57:16 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
4422020-12-14T18:08:50 <achow101> provoostenator: I've seen this non-determinism before. It has something to do with version numbers. I forget how (if) that was resolved though... I think it might be another instance of the clang 8 bug
4432020-12-14T18:12:56 *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has joined #bitcoin-core-dev
4442020-12-14T18:13:16 *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has quit IRC (Client Quit)
4452020-12-14T18:14:27 <wumpus> if it's another instance of the clang 8 bug, I'd really suggest to switch compilers this time
4462020-12-14T18:15:08 <wumpus> this bug-already fixed in upstream relaases-has given us enough work
4472020-12-14T18:16:29 <achow101> I found it: http://gnusha.org/bitcoin-core-dev/2020-11-24.log at 17:04
4482020-12-14T18:16:36 <achow101> was not resolved
4492020-12-14T18:16:52 <achow101> but it's something in master, not 0.21 afaict
4502020-12-14T18:17:30 *** jessepos_ <jessepos_!~jp@2601:643:8980:bfd2:98c1:5a96:a9af:37d1> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
4512020-12-14T18:17:54 *** jesseposner <jesseposner!~jp@2601:643:8980:bfd2:98c1:5a96:a9af:37d1> has joined #bitcoin-core-dev
4522020-12-14T18:18:33 <achow101> actually no, that time was a backport to 0.21 ... not sure, but it seems much less likely to trigger
4532020-12-14T18:32:30 *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 256 seconds)
4542020-12-14T18:36:57 <wumpus> what differs in the version string?
4552020-12-14T18:37:08 *** owowo <owowo!~ovovo@unaffiliated/ovovo> has joined #bitcoin-core-dev
4562020-12-14T18:45:08 *** jonatack <jonatack!~jon@134.19.179.139> has quit IRC (Quit: jonatack)
4572020-12-14T18:49:21 <achow101> I think it's in a string formatter
4582020-12-14T18:50:04 <wumpus> oh different code to generate the same output
4592020-12-14T18:50:12 <achow101> yeah
4602020-12-14T18:51:30 <achow101> it seems to have the same characteristics as the clang 8 issue in qt, so I think it's the same problem
4612020-12-14T18:52:14 *** jonatack <jonatack!~jon@88.124.242.136> has joined #bitcoin-core-dev
4622020-12-14T18:57:49 *** jonatack <jonatack!~jon@88.124.242.136> has quit IRC (Ping timeout: 264 seconds)
4632020-12-14T18:58:36 *** jonatack <jonatack!~jon@134.19.179.195> has joined #bitcoin-core-dev
4642020-12-14T19:04:25 <wumpus> it's rarer though, if it happens only for provoostenator :)
4652020-12-14T19:04:36 <achow101> it happened to me, once
4662020-12-14T19:05:01 <wumpus> he rebuilt with cleared cache and got the same, what's the random chance of that
4672020-12-14T19:06:04 <wumpus> anyhow we really need to get rid of clang 8
4682020-12-14T19:09:34 *** filchef <filchef!~filchef@89.253.179.83> has joined #bitcoin-core-dev
4692020-12-14T19:10:56 <provoostenator> Make Clang 9 again?
4702020-12-14T19:12:57 <luke-jr> til bitcoin-qt has 195 threads
4712020-12-14T19:13:07 <sipa> wut
4722020-12-14T19:13:32 <luke-jr> I think mostly llvmpipe to be fair
4732020-12-14T19:13:53 <luke-jr> no, that only accounts for 64 of them :x
4742020-12-14T19:14:54 <luke-jr> most look like https://dpaste.com/GDP5JUSZH
4752020-12-14T19:18:55 <wumpus> if only we had that kind of parallelism :p
4762020-12-14T19:20:43 <wumpus> how many cores/hardware threads does your CPU have? i think at least llvmpipe creates a thread for every one
4772020-12-14T19:21:31 <luke-jr> 64
4782020-12-14T19:23:54 <wumpus> par is limited to 15
4792020-12-14T19:24:14 <wumpus> how many threads does bitcoind have there?
4802020-12-14T19:24:31 <luke-jr> ?
4812020-12-14T19:24:48 <wumpus> MAX_SCRIPTCHECK_THREADS = 15
4822020-12-14T19:25:03 <luke-jr> I didn't change it
4832020-12-14T19:25:35 <wumpus> as far as i know that's the only variable number of threads scaled to cores, all the other ones are only based on configuration settings
4842020-12-14T19:26:13 <luke-jr> oh well :/
4852020-12-14T19:26:30 <luke-jr> is there a reason we prefer Freedesktop notifications over QSystemTray?
4862020-12-14T19:26:58 <wumpus> would be interesting to do a "info threads all" (or whatever the exact command is) in gdb
4872020-12-14T19:27:04 <luke-jr> the latter seems more ideal - not only is it platform-neutral, but it also presumably ties the notification to the icon
4882020-12-14T19:27:20 <luke-jr> Invalid thread ID: all
4892020-12-14T19:28:01 <wumpus> at the time it didn't work anymore for some desktops, static qt was unable to get notifications to ubuntu unity because it required a special plugin which wasn't available there
4902020-12-14T19:28:18 <wumpus> of course, unity is dead now, i have no clue how it's handled in gnome3 etc
4912020-12-14T19:29:24 <luke-jr> and it didn't fallback?
4922020-12-14T19:29:33 <wumpus> if notifications through qsystemtray work okay across linux desktop environments now that's be nice
4932020-12-14T19:29:37 <luke-jr> if(_trayIcon && _trayIcon->supportsMessages())
4942020-12-14T19:29:55 <luke-jr> I'm poking at this because I realised 90% of my startup wait is on a timeout of the FDO thing
4952020-12-14T19:30:42 <luke-jr> https://luke.dashjr.org/tmp/code/ita.xz has full backtraces of all my threads during splash fwiw
4962020-12-14T19:34:38 <wumpus> i'm sure it was some really annoying problem, e.g. it claimed to support it but just ignored them then
4972020-12-14T19:35:09 <luke-jr> >_<
4982020-12-14T19:36:16 <wumpus> we've had many of those problems, if you're going to implement it differently it'll require a lot of testing (of the gitian-built binaries) across distros to be sure
4992020-12-14T19:36:44 <luke-jr> what if I just add a guinotify=qsystemtray option or soemthing?
5002020-12-14T19:36:57 <wumpus> bah, that doesn't seem worth a configuration option
5012020-12-14T19:37:18 <wumpus> it's very much out of scope of the project, this is something that needs to be gotten right automatically
5022020-12-14T19:38:19 <luke-jr> it's automatic, but QDBus takes like 20 seconds to timeout :/
5032020-12-14T19:38:23 <wumpus> if we can drop the custom dbus code that'd be great but i'm sure i wrote it for a good reason at the time
5042020-12-14T19:38:48 <luke-jr> and it doesn't look like there's a way to change the timeout in our code
5052020-12-14T19:38:49 <wumpus> but that's what, half a decade ago?
5062020-12-14T19:39:17 <luke-jr> shrug
5072020-12-14T19:39:18 <wumpus> many new qt versions since, and as said, unity is dead
5082020-12-14T19:41:02 <wumpus> and ideally notifications is something that gets handlded correctly by qt, that's why we use an abstraction like qt
5092020-12-14T19:41:33 <luke-jr> but requires lots of testing = likely to get stuck in review limbo forever :/
5102020-12-14T19:41:59 <wumpus> otoh deleting code usually gets people enthousiatic
5112020-12-14T19:51:26 <wumpus> just don't add any regular expressions :-)
5122020-12-14T19:52:58 <luke-jr> â¹
5132020-12-14T19:53:12 <luke-jr> I was going to reimplement Notificator in Perl tho
5142020-12-14T19:56:40 <luke-jr> wumpus: Unity doesn't seem to be dead :/
5152020-12-14T19:57:15 <luke-jr> if someone wants to PR it, https://github.com/bitcoin-core/gui/compare/masterâ¦luke-jr:drop_dbus?expand=1
5162020-12-14T19:57:26 <luke-jr> not sure I care enough to deal with it
5172020-12-14T19:58:44 <wumpus> it's dead enough for me
5182020-12-14T19:59:13 <wumpus> I don't particularly care either it's you who brought it up
5192020-12-14T20:03:07 *** jarolrod <jarolrod!uid475272@gateway/web/irccloud.com/x-oeyqoxzpfotwpgrr> has quit IRC (Ping timeout: 258 seconds)
5202020-12-14T20:03:39 *** robot-dreams <robot-dreams!sid463268@gateway/web/irccloud.com/x-cndlteukbokvnpjt> has quit IRC (Ping timeout: 264 seconds)
5212020-12-14T20:03:48 *** digi_james <digi_james!sid281632@gateway/web/irccloud.com/x-vjrjbdfohnkqvcae> has quit IRC (Read error: Connection reset by peer)
5222020-12-14T20:03:49 *** endogenic <endogenic!sid145991@gateway/web/irccloud.com/x-rttmqpakeqwugsxe> has quit IRC (Ping timeout: 272 seconds)
5232020-12-14T20:04:09 *** digi_james <digi_james!sid281632@gateway/web/irccloud.com/x-ckjfcboybjfhlvon> has joined #bitcoin-core-dev
5242020-12-14T20:04:13 *** jarolrod <jarolrod!uid475272@gateway/web/irccloud.com/x-gbmckvtqrpvteemn> has joined #bitcoin-core-dev
5252020-12-14T20:04:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5262020-12-14T20:04:18 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fff7d056a92f...94a9cd25fd17
5272020-12-14T20:04:18 <bitcoin-git> bitcoin/master 41a413b Jonas Schnelli: Define correct symbols for getauxval
5282020-12-14T20:04:19 <bitcoin-git> bitcoin/master 836a3dc Jonas Schnelli: Avoid weak-linked getauxval support on non-linux platforms (like macOS)
5292020-12-14T20:04:19 <bitcoin-git> bitcoin/master 94a9cd2 Wladimir J. van der Laan: Merge #20594: Fix getauxval calls in randomenv.cpp
5302020-12-14T20:04:21 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5312020-12-14T20:04:27 *** mariorz <mariorz!sid490@gateway/web/irccloud.com/x-pajtjpcktkebvwdf> has quit IRC (Ping timeout: 272 seconds)
5322020-12-14T20:04:35 *** endogenic <endogenic!sid145991@gateway/web/irccloud.com/x-mljoynrkytaqlzva> has joined #bitcoin-core-dev
5332020-12-14T20:04:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5342020-12-14T20:04:37 <bitcoin-git> [bitcoin] laanwj merged pull request #20594: Fix getauxval calls in randomenv.cpp (master...2020/12/getauxval) https://github.com/bitcoin/bitcoin/pull/20594
5352020-12-14T20:04:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5362020-12-14T20:04:53 *** robot-dreams <robot-dreams!sid463268@gateway/web/irccloud.com/x-fpkuvfihnixtfrzh> has joined #bitcoin-core-dev
5372020-12-14T20:04:53 *** mariorz <mariorz!sid490@gateway/web/irccloud.com/x-dmlbtukjehcjydsc> has joined #bitcoin-core-dev
5382020-12-14T20:06:01 <wumpus> luke-jr: i don't get it why is dbus timing out for you in the first place? i'd expect it'd either make a connection (if the socket is available, available through the environment or throuh some X hack) or not
5392020-12-14T20:08:02 <wumpus> dbus is a local socket so it has no reason at all to time out
5402020-12-14T20:17:59 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
5412020-12-14T20:21:05 *** lontivero <lontivero!~lontivero@186.183.50.53> has quit IRC (Ping timeout: 240 seconds)
5422020-12-14T20:24:36 <luke-jr> wumpus: my development user has no access to my notifications
5432020-12-14T20:24:52 <luke-jr> the timeout is internal to dbus
5442020-12-14T20:24:57 <luke-jr> I don't know how it works
5452020-12-14T20:26:58 <andytoshi> is it considered a problem that `getblockcount` sometimes returns a blockheight before all the BlockConnected signals have been processed? i assume not, such is the nature of signals
5462020-12-14T20:27:00 <wumpus> it seems to me like there is some problem in the stack there; flatpak and such can also selectively reject dbus acces, it should be possible to reject access without causing applicatons to spend time timing out
5472020-12-14T20:27:47 <andytoshi> but it can mean that you `generate` 100 blocks then try to spend a coin and find that you can't, because `getblockcount` says you have 101 blocks but the wallet doesn't know yet
5482020-12-14T20:28:33 <luke-jr> wumpus: regardless, tiemout appears to be the default behaviour
5492020-12-14T20:28:36 <wumpus> andytoshi: there's generally no guarantee there, the RPC tests do some tricks there IIRC
5502020-12-14T20:28:49 <andytoshi> ok, cool, i'll study the existing tests
5512020-12-14T20:28:51 <wumpus> luke-jr: definitely an upstream problem though
5522020-12-14T20:29:12 <wumpus> we don't do anything partcularly complex or special
5532020-12-14T20:29:45 <sipa> andytoshi: tests synchronize by sending a ping and waiting for a pong
5542020-12-14T20:29:54 <andytoshi> sipa: i only have one node here
5552020-12-14T20:31:35 *** shesek <shesek!~shesek@unaffiliated/shesek> has joined #bitcoin-core-dev
5562020-12-14T20:32:06 <andytoshi> this is really hard to trigger, you have to generate and then immediately try to send coins (to a fixed address, even calling getnewaddress() is enough delay that you no longer see the race)
5572020-12-14T20:32:13 <sipa> andytoshi: the python code tests have a full p2p implementation
5582020-12-14T20:32:55 <wumpus> "syncwithvalidationinterfacequeue" RPC maybe?
5592020-12-14T20:33:05 <andytoshi> but for example, the taproot tests call `self.nodes[1].generate(101)` immediately followed by `self.test_spenders(self.nodes[1], ...`
5602020-12-14T20:33:06 <sipa> ah yes, that works too
5612020-12-14T20:33:22 <andytoshi> and i -think- this is ok because you call some other RPCs before doing any coin selection
5622020-12-14T20:33:24 <wumpus> it's some kind of barrier no idea if it's the right one
5632020-12-14T20:33:24 <sipa> andytoshi: those are all RPC calls which are fully synchronous
5642020-12-14T20:33:51 *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has joined #bitcoin-core-dev
5652020-12-14T20:34:04 <sipa> andytoshi: it's only a problem if you mix RPC calls with p2p interaction that an RPC may not reflect a P2P messsge that was already sent
5662020-12-14T20:34:13 <andytoshi> they're not, you can call `generate(101)` and then immediately `getblockcount` and it won't reflect the new blockcount
5672020-12-14T20:34:30 <sipa> really?
5682020-12-14T20:34:46 <sipa> on the same node?
5692020-12-14T20:34:53 <andytoshi> one moment, let me confirm that this isn't something crazy and elements-specific. but yes
5702020-12-14T20:35:56 <sipa> generate doesn't exist anymore iirc; it's generatetoaddress etc
5712020-12-14T20:36:20 <andytoshi> yeah, but the funcitonal tests have a generate method which internally calls generatetoaddress
5722020-12-14T20:36:24 <andytoshi> on a fresh getnewaddress
5732020-12-14T20:37:27 <sipa> ok
5742020-12-14T20:38:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5752020-12-14T20:38:44 <bitcoin-git> [gui] luke-jr opened pull request #152: GUI: Initialise DBus notifications in another thread (master...gui_notify_setup_bg) https://github.com/bitcoin-core/gui/pull/152
5762020-12-14T20:38:45 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5772020-12-14T20:38:50 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC ()
5782020-12-14T20:38:52 <andytoshi> ah i'm wrong, generatetoaddress and getblockcount are consistent
5792020-12-14T20:39:17 <andytoshi> but generatetoaddress followed by an immediate spend may not be (coin selection may fail, as the wallet has not yet received the BlockConnected signal)
5802020-12-14T20:43:08 <sipa> try syncwithvalidationinterfacequeue probably works
5812020-12-14T20:44:01 <andytoshi> (you can repro by adding `self.nodes[0].generate(101)` and `self.nodes[0].getnewaddress()` to the CLTV test, say, or anything with only one node, then looking at the logs, you will see intermittently that the `getnewaddress` is received before the final block is connected)
5822020-12-14T20:44:06 <andytoshi> ok thanks
5832020-12-14T20:44:39 <andytoshi> i didn't know about this RPC, i think it's exactly what i watn
5842020-12-14T20:44:44 <andytoshi> sorry for tech support spamming
5852020-12-14T20:51:57 <jonatack> probably not relevant but -generate is back, as client-side cli only, not rpc
5862020-12-14T20:52:21 <jonatack> as a replacement for the former generate rpc
5872020-12-14T20:53:26 *** potato <potato!~Thunderbi@240d:1a:3d4:7d00:902d:8574:a5b7:8124> has quit IRC (Ping timeout: 264 seconds)
5882020-12-14T20:59:42 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
5892020-12-14T21:01:39 <andytoshi> oh, that's good to know. though i'm fine using generatetoaddress
5902020-12-14T21:02:12 <andytoshi> the discrepancy was just between `getblockcount` and the wallet view. i wonder if `getblockcount` should call SyncWithValidationInterfaceQueue()
5912020-12-14T21:03:26 <sipa> i think a better long-term approach is giving the wallet its own getblockcount and related RPCs
5922020-12-14T21:03:34 *** molz_ <molz_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
5932020-12-14T21:03:52 <andytoshi> ah, yeah, i think that'd be cleaner and more performant
5942020-12-14T21:05:50 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
5952020-12-14T21:06:38 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 256 seconds)
5962020-12-14T21:07:09 *** alko89 <alko89!~alko89@unaffiliated/alko89> has quit IRC (Quit: ZNC 1.7.5 - https://znc.in)
5972020-12-14T21:08:32 *** molz_ <molz_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 272 seconds)
5982020-12-14T21:09:50 *** alko89 <alko89!~alko89@unaffiliated/alko89> has joined #bitcoin-core-dev
5992020-12-14T21:14:54 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Ping timeout: 256 seconds)
6002020-12-14T21:27:48 *** alko89 <alko89!~alko89@unaffiliated/alko89> has quit IRC (Quit: ZNC 1.7.5 - https://znc.in)
6012020-12-14T21:29:59 *** alko89 <alko89!~alko89@unaffiliated/alko89> has joined #bitcoin-core-dev
6022020-12-14T21:34:50 *** alko89 <alko89!~alko89@unaffiliated/alko89> has quit IRC (Client Quit)
6032020-12-14T21:38:01 *** alko89 <alko89!~alko89@unaffiliated/alko89> has joined #bitcoin-core-dev
6042020-12-14T21:46:51 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
6052020-12-14T21:51:34 *** miketwen_ <miketwen_!~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com> has quit IRC ()
6062020-12-14T21:56:09 <wumpus> yes, that would make sense
6072020-12-14T21:58:27 <wumpus> the node methods shouldn't depend on being synchronized with the wallet, but the wallet already needs to keep track of where it is in regard to synchronization with the node so exposing that in a RPC would make sense
6082020-12-14T22:02:01 <wumpus> each wallet separately in case of multiple wallets
6092020-12-14T22:03:57 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
6102020-12-14T22:06:43 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
6112020-12-14T22:07:25 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 264 seconds)
6122020-12-14T22:07:52 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
6132020-12-14T22:10:59 *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
6142020-12-14T22:11:02 *** Nolar <Nolar!~Nolar@178.162.209.171> has quit IRC (Remote host closed the connection)
6152020-12-14T22:14:03 *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has quit IRC (Ping timeout: 240 seconds)
6162020-12-14T22:14:58 <wumpus> these things mostly come up for the tests
6172020-12-14T22:15:22 *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has joined #bitcoin-core-dev
6182020-12-14T22:22:43 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
6192020-12-14T22:26:43 *** k3tan <k3tan!~pi@gateway/tor-sasl/k3tan> has quit IRC (Ping timeout: 240 seconds)
6202020-12-14T22:30:06 *** Guest7389 <Guest7389!~uptime@84.39.117.57> has joined #bitcoin-core-dev
6212020-12-14T22:30:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6222020-12-14T22:30:24 <bitcoin-git> [bitcoin] dhruv opened pull request #20656: testing linting travis -> cirrus (master...travis-to-cirrus) https://github.com/bitcoin/bitcoin/pull/20656
6232020-12-14T22:30:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6242020-12-14T22:32:32 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Read error: Connection reset by peer)
6252020-12-14T22:32:56 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
6262020-12-14T22:33:15 <wumpus> luke-jr: any idea what QThreadPoolThread is? you have 64 of those too apparently
6272020-12-14T22:33:50 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
6282020-12-14T22:37:55 <wumpus> so 64 for mesa, 64 for qthreadpool, 15 for script validation makes 143 of 195, ~15 normal bitcoind threads, still missing about 40 but getting closer
6292020-12-14T22:38:33 *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has joined #bitcoin-core-dev
6302020-12-14T22:41:58 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 260 seconds)
6312020-12-14T22:44:45 *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has quit IRC (Remote host closed the connection)
6322020-12-14T22:49:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6332020-12-14T22:49:49 <bitcoin-git> [bitcoin] dhruv closed pull request #20656: testing linting travis -> cirrus (master...travis-to-cirrus) https://github.com/bitcoin/bitcoin/pull/20656
6342020-12-14T22:49:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6352020-12-14T23:01:23 *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has quit IRC (Ping timeout: 240 seconds)
6362020-12-14T23:06:37 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
6372020-12-14T23:11:25 *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 240 seconds)
6382020-12-14T23:11:30 <luke-jr> wumpus: no idea :/
6392020-12-14T23:15:36 *** twistedline <twistedline!~twisted@unaffiliated/twistedline> has quit IRC (Ping timeout: 240 seconds)
6402020-12-14T23:21:39 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
6412020-12-14T23:38:36 *** joelklabo <joelklabo!~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: My iMac has gone to sleep. ZZZzzzâ¦)
6422020-12-14T23:54:04 *** joelklabo <joelklabo!~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev