12020-12-16T00:00:49 *** Mercury_Vapor <Mercury_Vapor!~Mercury_V@174-082-166-092.res.spectrum.com> has joined #bitcoin-core-dev
22020-12-16T00:00:57 *** palazzovincenzo <palazzovincenzo!~vincent@2001:b07:6474:9d49:5809:f8dd:2776:36cd> has quit IRC (Ping timeout: 260 seconds)
32020-12-16T00:02:03 *** miketwen_ <miketwen_!~miketwent@136.55.84.49> has quit IRC (Read error: Connection reset by peer)
42020-12-16T00:02:09 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
52020-12-16T00:05:09 *** eagless <eagless!~eagless@nova-153-092-149-207.cpe.nova.is> has quit IRC (Quit: Leaving)
62020-12-16T00:05:44 *** guaj0 <guaj0!~guaj0@231.red-95-120-196.dynamicip.rima-tde.net> has joined #bitcoin-core-dev
72020-12-16T00:07:22 *** palazzovincenzo <palazzovincenzo!~vincent@93-35-218-68.ip56.fastwebnet.it> has joined #bitcoin-core-dev
82020-12-16T00:07:54 *** palazzovincenzo <palazzovincenzo!~vincent@93-35-218-68.ip56.fastwebnet.it> has quit IRC (Remote host closed the connection)
92020-12-16T00:08:16 *** vincenzopalazzo <vincenzopalazzo!~vincent@93-35-218-68.ip56.fastwebnet.it> has quit IRC (Ping timeout: 268 seconds)
102020-12-16T00:09:38 *** guaj0 <guaj0!~guaj0@231.red-95-120-196.dynamicip.rima-tde.net> has quit IRC (Client Quit)
112020-12-16T00:18:04 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 256 seconds)
122020-12-16T00:28:40 *** iamgr00t_ is now known as iamgr00t
132020-12-16T00:28:46 *** lontivero <lontivero!~lontivero@186.141.228.160> has joined #bitcoin-core-dev
142020-12-16T00:30:34 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:a55b:90cf:1ae1:4d7b> has joined #bitcoin-core-dev
152020-12-16T00:35:22 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:a55b:90cf:1ae1:4d7b> has quit IRC (Ping timeout: 260 seconds)
162020-12-16T00:38:34 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:a55b:90cf:1ae1:4d7b> has joined #bitcoin-core-dev
172020-12-16T01:06:51 *** awesome_doge <awesome_doge!awesome-do@gateway/shell/matrix.org/x-witaeypfsoxnjlkc> has quit IRC (Ping timeout: 268 seconds)
182020-12-16T01:13:27 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
192020-12-16T01:23:03 *** lightlike <lightlike!~lightlike@p200300c7ef22170074211917a47a8485.dip0.t-ipconnect.de> has quit IRC (Quit: Leaving)
202020-12-16T01:34:12 *** joelklabo <joelklabo!~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: My iMac has gone to sleep. ZZZzzzâ¦)
212020-12-16T01:43:28 *** lontivero <lontivero!~lontivero@186.141.228.160> has quit IRC (Ping timeout: 256 seconds)
222020-12-16T01:52:17 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
232020-12-16T01:55:50 *** tryphe_ is now known as tryphe
242020-12-16T01:57:36 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 240 seconds)
252020-12-16T02:00:27 *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has quit IRC (Remote host closed the connection)
262020-12-16T02:00:30 *** lontivero <lontivero!~lontivero@186.183.3.236> has joined #bitcoin-core-dev
272020-12-16T02:01:10 *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
282020-12-16T02:10:09 *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has quit IRC (Remote host closed the connection)
292020-12-16T02:19:08 *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has quit IRC (Read error: Connection reset by peer)
302020-12-16T02:19:40 *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has joined #bitcoin-core-dev
312020-12-16T02:29:08 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
322020-12-16T02:29:43 *** lontivero <lontivero!~lontivero@186.183.3.236> has quit IRC (Ping timeout: 260 seconds)
332020-12-16T02:34:11 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
342020-12-16T02:34:11 <bitcoin-git> [bitcoin] adamjonas opened pull request #20668: doc: warn that incoming conns are unlikely when not using default ports (master...121520-non-standard-port-doc) https://github.com/bitcoin/bitcoin/pull/20668
352020-12-16T02:34:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
362020-12-16T02:37:51 <fanquake> wumpus / achow: do you have the links to any of the codesigning/inspection tools you wrote handy
372020-12-16T02:39:21 *** robert_spigler <robert_spigler!robertspig@gateway/shell/matrix.org/x-boajzynatzrltwgx> has quit IRC (Ping timeout: 268 seconds)
382020-12-16T02:39:30 <achow101> fanquake: https://gist.github.com/achow101/fef2415d99965de66ac083b54b83df6e is the tool we ended up with. I'm writing a full codesigning and inspection tool at https://github.com/achow101/signapple
392020-12-16T02:40:06 *** robert_spigler <robert_spigler!robertspig@gateway/shell/matrix.org/x-gyzoapdcugmmdwow> has joined #bitcoin-core-dev
402020-12-16T02:40:40 <fanquake> achow: thanks
412020-12-16T02:40:50 <sipa> achow101: how is that going?
422020-12-16T02:41:04 <fanquake> I see lots of blobs
432020-12-16T02:41:24 <achow101> sipa: I've reversed engineered the internal requirements thing. It's a mini scripting language with opcodes and stuff
442020-12-16T02:41:50 <achow101> considered writing an AST representation of it but decided that was too much effort
452020-12-16T02:41:54 <sipa> sounds like fun & an amazing timesink :)
462020-12-16T02:42:04 *** lontivero <lontivero!~lontivero@186.183.48.29> has joined #bitcoin-core-dev
472020-12-16T02:42:06 <achow101> I think I can have it sign in a few days
482020-12-16T02:42:43 <fanquake> achow101: is the goal here to replace codesign/codesign_allocate ?
492020-12-16T02:42:49 <achow101> it fully verifies, including stuff that we don't currently deal with in our signing, like whatever entitlements are
502020-12-16T02:42:52 <achow101> fanquake: yes
512020-12-16T02:43:04 *** awesome_doge <awesome_doge!awesome-do@gateway/shell/matrix.org/x-rnzdvvnshecmqbvf> has joined #bitcoin-core-dev
522020-12-16T03:00:24 <sipa> p
532020-12-16T03:00:43 <fanquake> q
542020-12-16T03:01:32 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 260 seconds)
552020-12-16T03:16:29 *** peterrizzo_ <peterrizzo_!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Quit: peterrizzo_)
562020-12-16T03:16:34 *** kexkey <kexkey!~kexkey@static-198-54-132-174.cust.tzulo.com> has quit IRC (Quit: Do, don't don't)
572020-12-16T03:39:48 *** Highway61 <Highway61!~Thunderbi@unaffiliated/highway61> has quit IRC (Ping timeout: 256 seconds)
582020-12-16T03:45:15 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Read error: Connection reset by peer)
592020-12-16T03:45:27 *** Highway61 <Highway61!~Thunderbi@unaffiliated/highway61> has joined #bitcoin-core-dev
602020-12-16T03:45:46 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
612020-12-16T03:51:25 *** Highway61 <Highway61!~Thunderbi@unaffiliated/highway61> has quit IRC (Ping timeout: 240 seconds)
622020-12-16T03:52:16 *** proofofkeags <proofofkeags!~proofofke@174-16-212-53.hlrn.qwest.net> has quit IRC (Ping timeout: 256 seconds)
632020-12-16T03:56:55 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
642020-12-16T04:27:06 *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has quit IRC (Remote host closed the connection)
652020-12-16T04:27:33 *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has joined #bitcoin-core-dev
662020-12-16T04:27:37 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Remote host closed the connection)
672020-12-16T04:32:03 *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has quit IRC (Quit: pinheadmz)
682020-12-16T04:58:42 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
692020-12-16T05:31:56 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 240 seconds)
702020-12-16T05:46:22 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
712020-12-16T05:50:25 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 240 seconds)
722020-12-16T05:59:45 *** lontivero <lontivero!~lontivero@186.183.48.29> has quit IRC (Ping timeout: 240 seconds)
732020-12-16T06:05:22 *** jonatack <jonatack!~jon@213.152.162.99> has quit IRC (Read error: Connection reset by peer)
742020-12-16T06:11:24 *** jonatack <jonatack!~jon@88.124.242.136> has joined #bitcoin-core-dev
752020-12-16T06:27:25 *** jeremyb <jeremyb!~jeremyb@84.39.117.57> has quit IRC (Remote host closed the connection)
762020-12-16T06:38:32 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
772020-12-16T06:38:32 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20669: [0.21] final rc4 backports (0.21...2012-rc4) https://github.com/bitcoin/bitcoin/pull/20669
782020-12-16T06:38:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
792020-12-16T06:43:35 *** [\\\] <[\\\]!~triplesla@unaffiliated/imsaguy> has joined #bitcoin-core-dev
802020-12-16T06:44:22 *** tripleslash <tripleslash!~triplesla@unaffiliated/imsaguy> has quit IRC (Read error: Connection reset by peer)
812020-12-16T07:00:22 <wumpus> from what i understood the entitlements are mostly used on iOS where it describes extra privileges of the application
822020-12-16T07:01:02 <fanquake> yea we'd only need them on macOS if we wanted to use things like NFC, location services, apple pay etc
832020-12-16T07:03:13 *** tripleslash <tripleslash!~triplesla@unaffiliated/imsaguy> has joined #bitcoin-core-dev
842020-12-16T07:03:57 *** [\\\] <[\\\]!~triplesla@unaffiliated/imsaguy> has quit IRC (Read error: Connection reset by peer)
852020-12-16T07:07:22 <sipa> apple pay integration, hmm!
862020-12-16T07:10:37 *** Kiminuo <Kiminuo!~mix@141.98.103.124> has joined #bitcoin-core-dev
872020-12-16T07:17:24 *** jackgassett <jackgassett!~jackgasse@84.39.117.57> has joined #bitcoin-core-dev
882020-12-16T07:23:44 <jonasschnelli> achow101: nice work!
892020-12-16T07:26:03 *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has quit IRC (Ping timeout: 240 seconds)
902020-12-16T07:30:26 <wumpus> yea desktop OSes tend to be much more lenient with regard to application permissions, though i was surprised recently that flatpak has a fine-grained system for controlling what an application is allowed to access, even some capability based thing to deny access to the entire home directory but allow access only to files selected by the user, kind of clever
912020-12-16T07:32:12 <jonasschnelli> Yeah. I like this feature in modern macOS. Each application has to ask permission to access certain directories of the filesystem. Same for camera access, location, etc..
922020-12-16T07:32:47 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 260 seconds)
932020-12-16T07:32:51 <jonasschnelli> On the other hand,.. it comes with a lot of control handed over to Apple (unnecessary). Like the whole notarization process.
942020-12-16T07:33:17 *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has joined #bitcoin-core-dev
952020-12-16T07:37:49 <wumpus> that's one issue with any security feature in proprietary OSes, they always ends up as a way the vendor can assert control, even if the feature itself was a good idea
962020-12-16T07:39:01 <wumpus> they always want to be the one controlling the locks and that makes it more like a jail (as Bunnie would say)
972020-12-16T07:47:15 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
982020-12-16T07:48:57 *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
992020-12-16T08:05:04 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:a55b:90cf:1ae1:4d7b> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
1002020-12-16T08:18:13 *** Aaronvan_ <Aaronvan_!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1012020-12-16T08:19:54 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@49.228.254.151> has joined #bitcoin-core-dev
1022020-12-16T08:20:52 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 256 seconds)
1032020-12-16T08:20:55 <wumpus> achow101: "It's a mini scripting language with opcodes and stuff" can you compile DOOM for it?
1042020-12-16T08:22:25 <jonasschnelli> heh
1052020-12-16T08:22:40 <sipa> yes, but does it run linux?
1062020-12-16T08:23:09 <wumpus> achow101: but nice work
1072020-12-16T08:23:40 <wumpus> sipa: finally a way to run linux on a mac !
1082020-12-16T08:24:13 *** Aaronvan_ <Aaronvan_!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 264 seconds)
1092020-12-16T08:25:39 *** Klox048093186316 <Klox048093186316!~Klox@c-24-1-131-19.hsd1.il.comcast.net> has quit IRC (Read error: Connection reset by peer)
1102020-12-16T08:32:47 <sipa> i mean, there is a linux system compiled to JS that runs in the browser right?
1112020-12-16T08:35:39 <jonasschnelli> OMG
1122020-12-16T08:36:07 <jonasschnelli> RiscV64 with X11 in my browser: https://bellard.org/jslinux/vm.html?cpu=riscv64&url=buildroot-riscv64-xwin.cfg&graphic=1&mem=256
1132020-12-16T08:37:17 <sipa> wow
1142020-12-16T08:37:29 <sipa> even works on my phone
1152020-12-16T08:39:10 <wumpus> jonasschnelli: risc-v is clearly the new webassembly
1162020-12-16T08:39:20 <jonasschnelli> windows98 with minesweeper: http://copy.sh/v86/?profile=windows98
1172020-12-16T08:41:26 <sipa> wth
1182020-12-16T08:42:52 <sipa> if my phone's cpu is fast enough to run a browser, in which an emulated operating system can run, and really all i do with it is using it as a pocket watch with wikipedia and irc functionality, i'm doing something wront
1192020-12-16T08:43:04 <wumpus> that one is veeery slow here
1202020-12-16T08:44:46 <wumpus> sipa: i'm sure it drains the battery like crazy, i guess that's the main bottleneck to doing more CPU heavy things on a phone
1212020-12-16T08:49:35 *** Pavlenex <Pavlenex!~Thunderbi@185.103.110.235> has joined #bitcoin-core-dev
1222020-12-16T08:53:17 *** Pavlenex <Pavlenex!~Thunderbi@185.103.110.235> has quit IRC (Client Quit)
1232020-12-16T09:03:01 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1242020-12-16T09:24:31 *** vincenzopalazzo <vincenzopalazzo!~vincent@2001:b07:6474:9d49:fc00:1cb5:3dd3:aa91> has joined #bitcoin-core-dev
1252020-12-16T09:28:15 *** Pavlenex <Pavlenex!~Thunderbi@185.103.110.235> has joined #bitcoin-core-dev
1262020-12-16T09:28:55 <wumpus> does anyone maybe have a better idea how we can avoid introducing a circular dependency here between coinstats and validation: https://github.com/bitcoin/bitcoin/pull/19806#pullrequestreview-552964012
1272020-12-16T09:31:34 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1282020-12-16T09:31:53 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
1292020-12-16T09:42:15 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
1302020-12-16T09:43:15 <jonasschnelli> I don't see other options than a separate implementation unit
1312020-12-16T09:53:17 *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
1322020-12-16T09:55:36 *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has quit IRC (Ping timeout: 260 seconds)
1332020-12-16T10:06:32 <wumpus> I think it makes logical sense too, snapshot handling is adjacent to but not part of validation
1342020-12-16T10:08:22 <wumpus> woohoo, appveyor cooked up a new reason to fail "The object or library file 'C:\Qt5.9.8_x64_static_vs2019\lib\Qt5Core.lib' was created by a different version of the compiler than other objects like 'x64\Release\bitcoin-qt\main.obj'; rebuild all objects and libraries with the same"
1352020-12-16T10:09:49 <wumpus> don't know if it's general or only on the 0.21 branch
1362020-12-16T10:13:24 *** shesek <shesek!~shesek@164.90.217.137> has joined #bitcoin-core-dev
1372020-12-16T10:13:58 *** jonatack <jonatack!~jon@88.124.242.136> has quit IRC (Ping timeout: 246 seconds)
1382020-12-16T10:15:43 *** jonatack <jonatack!~jon@134.19.179.147> has joined #bitcoin-core-dev
1392020-12-16T10:23:34 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@49.228.254.151> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
1402020-12-16T10:35:12 <vasild> jonatack: I2P! :)
1412020-12-16T10:40:21 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
1422020-12-16T10:41:26 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:313a:ef0a:c021:651e> has joined #bitcoin-core-dev
1432020-12-16T10:41:28 <vasild> What is the reason we don't gossip host names, e.g. bitcoinnode.foo.org:8333?
1442020-12-16T10:41:47 <wumpus> we really don't want DNS lookups in the P2P code
1452020-12-16T10:42:55 <vasild> wumpus: Why? For performance reasons?
1462020-12-16T10:42:57 <wumpus> also working with dynamically-sized strings in any network protocol has a large potential to introduce bugs
1472020-12-16T10:43:22 <wumpus> security/privacy reasons mostly, it's harder to do with tor
1482020-12-16T10:43:41 <vasild> I see
1492020-12-16T10:45:45 <wumpus> I don't really see much of an advantage in it personally, DNS is useful for humans, but for a addresses sent over a network protocol it seems to me it adds an unnecessary level of indirection
1502020-12-16T10:46:48 <vasild> yeah, maybe some benefit could be that a hostname could resolve to a few IP addresses or if the address changes over time, then addrman entries need not be updated
1512020-12-16T10:47:11 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
1522020-12-16T10:47:42 <vasild> I asked because in I2P we do need to do a lookup - the .b32.i2p address must be resolved to a "destination" (a few 100s of bytes) and then we connect to that "destination"
1532020-12-16T10:48:43 <wumpus> i didn't know that when writing the BIP
1542020-12-16T10:48:53 <wumpus> should we have gossipped destinations directly?
1552020-12-16T10:49:18 <wumpus> though we can fit 512 bytes i guess the size does make it impractical
1562020-12-16T10:51:52 <hebasto> wumpus: to fix appveyor on 0.21 the baclport of the recent changes seem required: #20489, #20506
1572020-12-16T10:51:54 <gribble> https://github.com/bitcoin/bitcoin/issues/20489 | CI msvc: only build vcpkg dependencies for release (not debug) to reduce build times by sipsorcery · Pull Request #20489 · bitcoin/bitcoin · GitHub
1582020-12-16T10:51:56 <gribble> https://github.com/bitcoin/bitcoin/issues/20506 | ci: AppVeyor fixes for Visual Studio 2019 16.8.1 image by sipsorcery · Pull Request #20506 · bitcoin/bitcoin · GitHub
1592020-12-16T10:51:56 *** Pavlenex1 <Pavlenex1!~Thunderbi@185.103.110.235> has joined #bitcoin-core-dev
1602020-12-16T10:52:00 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 256 seconds)
1612020-12-16T10:52:44 *** Pavlenex <Pavlenex!~Thunderbi@185.103.110.235> has quit IRC (Ping timeout: 256 seconds)
1622020-12-16T10:52:44 *** Pavlenex1 is now known as Pavlenex
1632020-12-16T10:53:07 <hebasto> should I take care of it?
1642020-12-16T10:53:45 <vasild> wumpus: I think it is fine as it is, gossiping destinations directly seems an overkill to me
1652020-12-16T10:54:50 <vasild> but it opens the opportunity to allow i2p hostnames, e.g. zzz.i2p in addition to .b32.i2p addresses
1662020-12-16T10:56:02 <vasild> also, lontivero mentioned in https://github.com/bitcoin/bitcoin/pull/20254#discussion_r543586946 that even .b32.i2p addresses may have different length :-X
1672020-12-16T10:57:45 <vasild> eventually, maybe we would update bip155 to mandate the i2p addr size is allowed to be either 32 or 35 bytes
1682020-12-16T10:58:01 <wumpus> fwiw, I would prefer not to broadcast hostnames, keep the gossiping to (low level) network addresses, preferably fixed length
1692020-12-16T10:58:36 <vasild> wumpus: right
1702020-12-16T11:00:21 <wumpus> right--the current protocol mandates a specific I2P address scheme, same as we do for TorV1/V2, if there's a different one in the future then we'll need to add a new address type
1712020-12-16T11:01:34 <vasild> i2p-exotic, length=35
1722020-12-16T11:01:38 <wumpus> I intentionally didn't leave any extensibility within one address type, to make it straightforward to handle
1732020-12-16T11:04:04 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1742020-12-16T11:05:54 *** Aaronvan_ <Aaronvan_!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1752020-12-16T11:06:34 *** einyx <einyx!einyx@fsf/member/einyx> has joined #bitcoin-core-dev
1762020-12-16T11:06:36 *** einyx_ <einyx_!~einyx@fsf/member/einyx> has quit IRC (Ping timeout: 265 seconds)
1772020-12-16T11:08:43 *** Aaronva__ <Aaronva__!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1782020-12-16T11:09:20 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 268 seconds)
1792020-12-16T11:10:01 *** Aaronva__ <Aaronva__!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Read error: Connection reset by peer)
1802020-12-16T11:10:38 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1812020-12-16T11:10:38 *** Aaronvan_ <Aaronvan_!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 260 seconds)
1822020-12-16T11:11:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1832020-12-16T11:11:12 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20671: Replace boost::optional with std::optional (master...2012-stdOpt) https://github.com/bitcoin/bitcoin/pull/20671
1842020-12-16T11:11:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1852020-12-16T11:12:15 *** Aaronvan_ <Aaronvan_!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1862020-12-16T11:15:19 *** Aaronva__ <Aaronva__!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1872020-12-16T11:15:30 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 272 seconds)
1882020-12-16T11:16:23 *** Aaronva__ <Aaronva__!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
1892020-12-16T11:17:08 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1902020-12-16T11:17:21 *** Aaronvan_ <Aaronvan_!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 268 seconds)
1912020-12-16T11:17:21 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (K-Lined)
1922020-12-16T11:18:30 *** Lisandro23Bechte <Lisandro23Bechte!~Lisandro2@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
1932020-12-16T11:21:03 *** dadybayo <dadybayo!d4707bc5@212.112.123.197> has joined #bitcoin-core-dev
1942020-12-16T11:22:56 *** Lisandro23Bechte <Lisandro23Bechte!~Lisandro2@static.57.1.216.95.clients.your-server.de> has quit IRC (Ping timeout: 240 seconds)
1952020-12-16T11:26:18 *** dadybayo <dadybayo!d4707bc5@212.112.123.197> has quit IRC (Remote host closed the connection)
1962020-12-16T11:28:29 <hebasto> wumpus: are you still seeing an issue with appveyor on the 0.21 branch?
1972020-12-16T11:31:40 *** aj <aj!aj@cerulean.erisian.com.au> has quit IRC (Ping timeout: 256 seconds)
1982020-12-16T11:38:53 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
1992020-12-16T11:39:19 <jonatack> vasild: hey, sorry, was reviewing. keeping each address types simple sgtm.
2002020-12-16T11:40:13 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
2012020-12-16T11:41:45 <vasild> jonatack: yeah, so on IP2 I am doing final self re-review and test ci runs to ensure it is still green and will open a PR with proper I2P support which will supersede #20254
2022020-12-16T11:41:47 <gribble> https://github.com/bitcoin/bitcoin/issues/20254 | Add I2P support using statically configured destinations by vasild · Pull Request #20254 · bitcoin/bitcoin · GitHub
2032020-12-16T11:42:20 <jonatack> vasild: nice, will look out for that
2042020-12-16T11:42:45 <vasild> I wonder if it makes sense to write a primitive SAM proxy server in python in order to test it in the functional tests... maybe yes
2052020-12-16T11:43:34 *** troygiorshev <troygiorshev!~troygiors@d67-193-140-136.home3.cgocable.net> has quit IRC (Ping timeout: 256 seconds)
2062020-12-16T11:43:59 *** troygiorshev <troygiorshev!~troygiors@d67-193-140-136.home3.cgocable.net> has joined #bitcoin-core-dev
2072020-12-16T11:45:01 <vasild> so far I used a hackish unit tests that kind of starts the "entire" bitcoind by calling CConnman::Start() and requires a running i2p server - not acceptable
2082020-12-16T11:45:10 *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
2092020-12-16T11:51:29 *** midnight <midnight!~midnight@unaffiliated/midnightmagic> has quit IRC (Ping timeout: 244 seconds)
2102020-12-16T11:57:53 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2112020-12-16T11:57:53 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16168: DevelopOmniLayer (master...develop) https://github.com/bitcoin/bitcoin/pull/16168
2122020-12-16T11:57:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2132020-12-16T12:00:42 *** midnight <midnight!~midnight@unaffiliated/midnightmagic> has joined #bitcoin-core-dev
2142020-12-16T12:17:27 *** Mercury_Vapor <Mercury_Vapor!~Mercury_V@174-082-166-092.res.spectrum.com> has quit IRC (Read error: Connection reset by peer)
2152020-12-16T12:17:51 *** Mercury_Vapor <Mercury_Vapor!~Mercury_V@174-082-166-092.res.spectrum.com> has joined #bitcoin-core-dev
2162020-12-16T12:17:51 *** Kiminuo <Kiminuo!~mix@141.98.103.124> has quit IRC (Read error: Connection reset by peer)
2172020-12-16T12:18:11 *** Kiminuo <Kiminuo!~mix@141.98.103.124> has joined #bitcoin-core-dev
2182020-12-16T12:28:10 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:313a:ef0a:c021:651e> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
2192020-12-16T12:28:21 *** Pavlenex <Pavlenex!~Thunderbi@185.103.110.235> has quit IRC (Quit: Pavlenex)
2202020-12-16T12:30:09 *** jonatack <jonatack!~jon@134.19.179.147> has quit IRC (Quit: jonatack)
2212020-12-16T12:33:23 *** jonatack <jonatack!~jon@88.124.242.136> has joined #bitcoin-core-dev
2222020-12-16T12:33:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2232020-12-16T12:33:56 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/dff0f6f753ea...b440c33179e7
2242020-12-16T12:33:56 <bitcoin-git> bitcoin/master ed73f8c practicalswift: net: Move eviction node selection logic to SelectNodeToEvict(...)
2252020-12-16T12:33:57 <bitcoin-git> bitcoin/master 685c428 practicalswift: test: Add unit testing of node eviction logic
2262020-12-16T12:33:57 <bitcoin-git> bitcoin/master fee8823 practicalswift: Assert eviction at >= 29 candidates. Assert non-eviction at <= 20 candidat...
2272020-12-16T12:33:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2282020-12-16T12:34:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2292020-12-16T12:34:16 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20477: net: Add unit testing of node eviction logic (master...unit-test-node-eviction-logic) https://github.com/bitcoin/bitcoin/pull/20477
2302020-12-16T12:34:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2312020-12-16T12:37:02 *** aj <aj!aj@cerulean.erisian.com.au> has joined #bitcoin-core-dev
2322020-12-16T12:38:52 *** jonatack <jonatack!~jon@88.124.242.136> has quit IRC (Ping timeout: 246 seconds)
2332020-12-16T12:39:39 *** jonatack <jonatack!~jon@213.152.186.173> has joined #bitcoin-core-dev
2342020-12-16T12:46:35 *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Quit: peterrizzo)
2352020-12-16T12:51:47 *** Pavlenex <Pavlenex!~Thunderbi@185.103.110.235> has joined #bitcoin-core-dev
2362020-12-16T12:53:08 *** Pavlenex <Pavlenex!~Thunderbi@185.103.110.235> has quit IRC (Client Quit)
2372020-12-16T12:57:06 *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has joined #bitcoin-core-dev
2382020-12-16T12:57:46 *** lontivero <lontivero!~lontivero@186.183.51.80> has joined #bitcoin-core-dev
2392020-12-16T12:59:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2402020-12-16T12:59:48 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b440c33179e7...6af8a6232b2d
2412020-12-16T12:59:48 <bitcoin-git> bitcoin/master 267f259 Hennadii Stepanov: depends: Drop workaround for a fixed bug in Qt build system
2422020-12-16T12:59:49 <bitcoin-git> bitcoin/master 6af8a62 Jonas Schnelli: Merge #20650: depends: Drop workaround for a fixed bug in Qt build system
2432020-12-16T12:59:51 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2442020-12-16T13:00:07 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2452020-12-16T13:00:07 <bitcoin-git> [bitcoin] jonasschnelli merged pull request #20650: depends: Drop workaround for a fixed bug in Qt build system (master...201214-xcb) https://github.com/bitcoin/bitcoin/pull/20650
2462020-12-16T13:00:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2472020-12-16T13:02:44 *** davterra <davterra!~davterra@107.182.237.19> has quit IRC (Quit: Leaving)
2482020-12-16T13:06:09 *** Highway61 <Highway61!~Thunderbi@unaffiliated/highway61> has joined #bitcoin-core-dev
2492020-12-16T13:07:12 <wumpus> hebasto: let's see how #20669 goes
2502020-12-16T13:07:13 <gribble> https://github.com/bitcoin/bitcoin/issues/20669 | [0.21] final rc4 backports by MarcoFalke · Pull Request #20669 · bitcoin/bitcoin · GitHub
2512020-12-16T13:08:01 <wumpus> vasild: we don't have testing for socks5 either, but agree it'd make sense
2522020-12-16T13:08:40 <wumpus> vasild: oh wait we do lol
2532020-12-16T13:09:14 <vasild> I will at least try to do it and hope it does not end in too many lines of python code
2542020-12-16T13:10:12 <vasild> test/functional/test_framework/socks5.py class Socks5Server() ...
2552020-12-16T13:10:27 <vasild> 160 lines
2562020-12-16T13:11:17 <vasild> btw, I noticed that we do send(sock, buf, size) and expect the return value to be "size" which is not robust
2572020-12-16T13:11:37 <vasild> also, the socket is non-blocking
2582020-12-16T13:11:57 <wumpus> true, it can't be generally relied on, e.g. if the system call is interrupted
2592020-12-16T13:12:02 <vasild> I guess it mostly works because the socks5 proxy is usually on localhost where the connection is "fast and stable" :)
2602020-12-16T13:13:00 <Jackielove4u> Does anybody here have rc3 running ?
2612020-12-16T13:14:16 <jonasschnelli> Jackielove4u: yes. Why?
2622020-12-16T13:14:37 *** potato <potato!~Thunderbi@240d:1a:3d4:7d00:9851:bcf:fdb3:6c0d> has quit IRC (Ping timeout: 260 seconds)
2632020-12-16T13:15:24 <wumpus> hey, didn't we create an issue for rc test reports this time?
2642020-12-16T13:15:28 *** lontivero <lontivero!~lontivero@186.183.51.80> has quit IRC (Ping timeout: 260 seconds)
2652020-12-16T13:15:32 <Jackielove4u> my rc3 node does not accept any incoming connections
2662020-12-16T13:15:37 <wumpus> looks like we forgot
2672020-12-16T13:15:46 <fanquake> #20555
2682020-12-16T13:15:47 <gribble> https://github.com/bitcoin/bitcoin/issues/20555 | v0.21.0 testing · Issue #20555 · bitcoin/bitcoin · GitHub
2692020-12-16T13:15:54 <Jackielove4u> i am trying to connect my rc3 client to my rc3 node
2702020-12-16T13:15:55 <wumpus> oh it's just not pinned
2712020-12-16T13:16:10 <fanquake> Yea I just pinned it
2722020-12-16T13:16:11 <Jackielove4u> with connect= parameter
2732020-12-16T13:16:14 <wumpus> thanks :)
2742020-12-16T13:16:20 <Jackielove4u> the connection gets dropped instantly
2752020-12-16T13:16:22 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:313a:ef0a:c021:651e> has joined #bitcoin-core-dev
2762020-12-16T13:16:31 <Jackielove4u> can i get a ip from any of you guys
2772020-12-16T13:16:38 <Jackielove4u> to try to connect to you
2782020-12-16T13:17:10 <Jackielove4u> i was able to get it fixed though by reverting this commit: https://github.com/bitcoin/bitcoin/pull/20612/commits/9e806887a8f9ef63431b28d7dfd0470aa663dd02
2792020-12-16T13:18:40 <Jackielove4u> not sure if this is the expected behaviour (rc3 not able to connect to rc3)
2802020-12-16T13:19:53 <wumpus> strange, that commit is supposed to *fix* disconnections by not sending sendaddrv2 to nodes we're not sure support it
2812020-12-16T13:20:13 *** vincenzopalazzo <vincenzopalazzo!~vincent@2001:b07:6474:9d49:fc00:1cb5:3dd3:aa91> has quit IRC (Remote host closed the connection)
2822020-12-16T13:22:27 <Jackielove4u> Can anybody replicate? or give me your node ip so i can try to connect to yours
2832020-12-16T13:22:32 <vasild> Jackielove4u: did you try to connect rc2 with rc3?
2842020-12-16T13:22:57 <Jackielove4u> no i did not
2852020-12-16T13:23:00 <Jackielove4u> i can try
2862020-12-16T13:23:15 <vasild> rc3 <-> {rc3, <=0.20.1} should be fine
2872020-12-16T13:24:32 <vasild> Jackielove4u: run both nodes with -debug=net and show both logs here (by pastebin)
2882020-12-16T13:25:32 *** jackgassett <jackgassett!~jackgasse@84.39.117.57> has quit IRC (Remote host closed the connection)
2892020-12-16T13:26:06 <MarcoFalke> Indeed rc3 <-> rc3 should be fine
2902020-12-16T13:27:11 <vasild> this is strange: https://bpa.st/HMPA why disconnect due to ping timeout (20 minutes), 2 minutes after we have received some messages from the peer?
2912020-12-16T13:28:09 <vasild> 1. should we disconnect in this case, given that the connection is obviously not dead and 2. where is the pong message in this particular case?
2922020-12-16T13:28:12 *** lontivero <lontivero!~lontivero@186.183.3.180> has joined #bitcoin-core-dev
2932020-12-16T13:28:14 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2942020-12-16T13:28:14 <bitcoin-git> [bitcoin] hebasto opened pull request #20673: depends: Use more legible qmake commands in qt package (master...201216-subdir) https://github.com/bitcoin/bitcoin/pull/20673
2952020-12-16T13:28:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2962020-12-16T13:29:02 *** Chris_Stewart_5 <Chris_Stewart_5!~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383> has quit IRC (Remote host closed the connection)
2972020-12-16T13:30:43 <jnewbery> vasild: the peer didn't respond to a ping message. We should disconnect. It also looks like it hasn't sent you a verack (and possibly not a version either)
2982020-12-16T13:31:06 <vasild> jnewbery: I removed the non-relevant messages
2992020-12-16T13:31:36 <vasild> just left the first one to show when the connection starts and addrv2 to show that something has arrived
3002020-12-16T13:31:46 <jnewbery> vasild: can you provide full logs? Very difficult to debug issues from partial logs
3012020-12-16T13:33:12 <jnewbery> but to answer your question, yes we always disconnect a peer that doesn't respond to a ping within 20 minutes. See InactivityCheck() in net.cpp
3022020-12-16T13:34:18 <MarcoFalke> Something's clearly wrong with the connection if they don't respond with pong
3032020-12-16T13:35:18 <jnewbery> Jackielove4u: I assume you also dropped the subsequent commit https://github.com/bitcoin/bitcoin/pull/20612/commits/9e806887a8f9ef63431b28d7dfd0470aa663dd02 as well? rc2 and rc3 don't play nice together with that commit, but rc3 <-> rc3 should be fine (and we have big problems if not)
3042020-12-16T13:36:04 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:313a:ef0a:c021:651e> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
3052020-12-16T13:36:11 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
3062020-12-16T13:36:12 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
3072020-12-16T13:36:15 *** vasild_ is now known as vasild
3082020-12-16T13:36:36 <Jackielove4u> rc3 <-> rc3 without dropping that commit is not connecting for me
3092020-12-16T13:36:57 *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
3102020-12-16T13:38:12 <vasild> jnewbery: here is the full log since you asked https://bpa.st/BE5Q, but I did not intend to debug this (yet), just ask if the behavior looks reasonable. You already answered the first question.
3112020-12-16T13:38:31 <vasild> I dont have the logs of the other side with -debug=net
3122020-12-16T13:39:41 <aj> jnewbery: re 19858 ; that log snippet is quite trimmed. https://0bin.net/paste/wnUMx2lG#XKm3fF9Wp8dOX03IKYazBTZaCDYN6CegUK-VW5rWjeJ is a more recent example
3132020-12-16T13:40:10 <jnewbery> argh. why do people mess with logs??
3142020-12-16T13:41:38 <Jackielove4u> If anybody is willing to share their node ip (that is running rc3), i can try to connect to yours and see if i get a connection
3152020-12-16T13:42:20 <vasild> jnewbery: in my case I left the few relevant lines to make it easier to do a high-level overview, which would be more tedious with 700+ lines of log
3162020-12-16T13:42:41 <Jackielove4u> rc3 <-> <=0.20.1 works fine
3172020-12-16T13:42:58 *** Pavlenex <Pavlenex!~Thunderbi@185.103.110.235> has joined #bitcoin-core-dev
3182020-12-16T13:43:15 <vasild> Jackielove4u: did you run with -debug=net?
3192020-12-16T13:43:42 <Jackielove4u> not yet, my kid is yelling that his nerf gun is stuck and need to fix that first
3202020-12-16T13:43:53 <vasild> :-D
3212020-12-16T13:43:53 <Jackielove4u> its lockdown in the netherlands
3222020-12-16T13:44:00 <Jackielove4u> so i have to deal with kids now also
3232020-12-16T13:44:48 <jnewbery> vasild: there's something wrong with that peer. It's also not _sending_ pings every two minutes as we'd expect from a Bitcoin Core node
3242020-12-16T13:45:47 *** Dogechain <Dogechain!~Dogechain@84.39.117.57> has joined #bitcoin-core-dev
3252020-12-16T13:46:24 <vasild> hmm, both peers do not send pings every 2 minutes
3262020-12-16T13:46:57 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
3272020-12-16T13:47:56 *** promag__ <promag__!~promag@188.250.84.129> has joined #bitcoin-core-dev
3282020-12-16T13:47:56 *** promag <promag!~promag@188.250.84.129> has quit IRC (Read error: Connection reset by peer)
3292020-12-16T13:48:14 <jnewbery> I wonder if there's a problem with that connection. The getdata/block round trip time is often over a minute
3302020-12-16T13:48:24 *** promag_ <promag_!~promag@188.250.84.129> has quit IRC (Ping timeout: 256 seconds)
3312020-12-16T13:49:03 <vasild> jnewbery: that's over i2p and is for some reason very slow
3322020-12-16T13:49:29 *** lontivero <lontivero!~lontivero@186.183.3.180> has quit IRC (Ping timeout: 265 seconds)
3332020-12-16T13:49:30 <vasild> I think I overcooked the settings on one of my i2p routers
3342020-12-16T13:49:58 <wumpus> is it a very slow CPU? i think it's possible for networking to hang on block validation if it takes very long
3352020-12-16T13:50:08 <wumpus> oh, i2p
3362020-12-16T13:50:39 <vasild> cpu should be fine (not very slow)
3372020-12-16T13:53:08 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
3382020-12-16T13:53:19 <Jackielove4u> nerf gun fixed
3392020-12-16T13:53:38 *** vincenzopalazzo <vincenzopalazzo!~vincent@2001:b07:6474:9d49:1cd0:876b:6bfb:cb4a> has joined #bitcoin-core-dev
3402020-12-16T13:53:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3412020-12-16T13:53:39 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6af8a6232b2d...a023094fc417
3422020-12-16T13:53:39 <bitcoin-git> bitcoin/master 3b064fc Michael Dietz: test: run mempool_expiry.py even with wallet disabled
3432020-12-16T13:53:40 <bitcoin-git> bitcoin/master a023094 MarcoFalke: Merge #20276: test: run mempool_expiry.py even with wallet disabled
3442020-12-16T13:53:42 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3452020-12-16T13:53:48 <jnewbery> vasild: is it possible that your router is dropping packets? I don't know anything about how i2p works. Does it have reliable delivery?
3462020-12-16T13:53:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3472020-12-16T13:53:58 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20276: test: run mempool_expiry.py even with wallet disabled (master...mempool-expiry-miniwallet) https://github.com/bitcoin/bitcoin/pull/20276
3482020-12-16T13:53:59 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3492020-12-16T13:54:04 <vasild> huh
3502020-12-16T13:54:43 <jnewbery> aj: ah I see you added fRelay logging. Great. Then the peer is misbehaving by sending those invs. I'd guess badly implemented spy nodes. I've seen issues before where peers mysteriously ignored fRelay.
3512020-12-16T13:54:45 <vasild> it has "stream" and "datagram" options, let me reread the docs..
3522020-12-16T13:54:55 <Jackielove4u> upon testing i saw that my bitcoin core rc3 client (run on a desktop) and my schildbach wallet (run on android) does not connect to my rc3 bitcoin core node (run on a server)
3532020-12-16T13:56:46 <Jackielove4u> bitcoin core rc3 client (run on a desktop) and my schildbach wallet (run on android) does connect to bitcoin core 0.20.x and lower
3542020-12-16T13:57:36 <aj> jnewbery: yeah; as per the comment i added -- i forgot to redact my ip before pasting that log snippet, then noticed my ip wasn't in the log; so those peers are definitely not pristine bitcoin core, so don't think it's our bug on the sending side either
3552020-12-16T13:58:33 <aj> Jackielove4u: what's a bitcoin core rc3 client?
3562020-12-16T13:59:16 <vasild> jnewbery: "Virtual streams are guaranteed to be sent reliably and in order..." (from https://geti2p.net/en/docs/api/samv3)
3572020-12-16T13:59:32 <Jackielove4u> with client i mean qt
3582020-12-16T13:59:37 <aj> jnewbery: also, i think that's the first example of that code actually catching a spy-ish node in the wild, yay!
3592020-12-16T13:59:39 <Jackielove4u> with node i mean bitcoind
3602020-12-16T13:59:52 <MarcoFalke> Jackielove4u: This sounds like an issue unrelated to rc3
3612020-12-16T14:00:03 <aj> Jackielove4u: sounds like the client or the node is still at rc2 rather than rc3 to me
3622020-12-16T14:00:28 <Jackielove4u> both are certainly on rc3
3632020-12-16T14:01:00 <aj> Jackielove4u: run both with -debug=net and check for a line about sendaddrv2 just prior to the disconnection
3642020-12-16T14:02:20 *** lontivero <lontivero!~lontivero@186.183.3.236> has joined #bitcoin-core-dev
3652020-12-16T14:03:38 <MarcoFalke> Yes, without the debug log we can't debug this any further
3662020-12-16T14:16:00 *** lontivero <lontivero!~lontivero@186.183.3.236> has quit IRC (Ping timeout: 256 seconds)
3672020-12-16T14:21:47 <sdaftuar> aj: i've tried to debug this same issue (where a node appears to send us inv's after we start a blocks-only connection) many times over the years, and never been able to replicate using known bitcoin core software on both ends.
3682020-12-16T14:22:21 <sdaftuar> would be good to write up your analysis on github maybe so that we have notes for the next time we look into something like this
3692020-12-16T14:22:34 <sdaftuar> (since it's one of those things where we can never quite be sure whether a peer is lying or we have a bug!)
3702020-12-16T14:29:32 *** lontivero <lontivero!~lontivero@186.183.51.4> has joined #bitcoin-core-dev
3712020-12-16T14:31:20 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:313a:ef0a:c021:651e> has joined #bitcoin-core-dev
3722020-12-16T14:39:47 <aj> sdaftuar: updated https://github.com/bitcoin/bitcoin/pull/19858#issuecomment-746312882
3732020-12-16T14:40:09 <jnewbery> If you consider BIP37 and optional standard, then it's not really a violation of the protocol to send tx INVs after receiving a version with fRelay = false
3742020-12-16T14:40:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3752020-12-16T14:40:46 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a023094fc417...2d4eeaf9c588
3762020-12-16T14:40:51 <bitcoin-git> bitcoin/master c175690 Jarol Rodriguez: doc: Update for FreeBSD 12.2, add GUI Build Instructions
3772020-12-16T14:40:51 <bitcoin-git> bitcoin/master 2d4eeaf Wladimir J. van der Laan: Merge #20601: doc: Update for FreeBSD 12.2, add GUI Build Instructions
3782020-12-16T14:41:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3792020-12-16T14:41:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3802020-12-16T14:41:08 <bitcoin-git> [bitcoin] laanwj merged pull request #20601: doc: Update for FreeBSD 12.2, add GUI Build Instructions (master...master) https://github.com/bitcoin/bitcoin/pull/20601
3812020-12-16T14:41:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3822020-12-16T14:41:28 <jnewbery> *an optional
3832020-12-16T14:42:29 <aj> jnewbery: i think if we're wanting a no-tx connection (to conserve b/w eg) then disconnecting is still the right thing to do if we receive txs on it?
3842020-12-16T14:45:09 *** lontivero_ <lontivero_!~lontivero@186.183.3.32> has joined #bitcoin-core-dev
3852020-12-16T14:47:30 <jnewbery> aj: right. Perhaps we should also disconnect peers that don't provide fRelay in their version message to make it explicit that support for fRelay is required
3862020-12-16T14:48:15 *** lontivero <lontivero!~lontivero@186.183.51.4> has quit IRC (Ping timeout: 268 seconds)
3872020-12-16T14:48:40 <aj> jnewbery: hmm, i guess i'm not logging whether these peers are sending frelay or not
3882020-12-16T14:49:12 <jnewbery> that'd be interesting. If they sent it but ignored the value that we sent
3892020-12-16T14:49:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3902020-12-16T14:49:57 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2d4eeaf9c588...9dbcd3710521
3912020-12-16T14:49:58 <bitcoin-git> bitcoin/master fa8e15f MarcoFalke: test: pep8 wallet_multiwallet.py
3922020-12-16T14:49:58 <bitcoin-git> bitcoin/master fab48da MarcoFalke: test: Fix intermittent wallet_multiwallet issue with got_loading_error
3932020-12-16T14:49:59 <aj> jnewbery: that's what i'd guess they're doing. not seeing much advantage in disconnecting 0s-15s earlier though
3942020-12-16T14:49:59 <bitcoin-git> bitcoin/master 9dbcd37 MarcoFalke: Merge #20569: test: Fix intermittent wallet_multiwallet issue with got_loa...
3952020-12-16T14:50:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3962020-12-16T14:50:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3972020-12-16T14:50:17 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20569: test: Fix intermittent wallet_multiwallet issue with got_loading_error (master...2012-testWalletInt) https://github.com/bitcoin/bitcoin/pull/20569
3982020-12-16T14:50:18 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3992020-12-16T14:50:59 <jnewbery> or maybe we should deprecate fRelay and always use a feefilter message with MAX_MONEY
4002020-12-16T14:52:23 <aj> what happened with the p2p v2 messages? did it ever even get a proper bip?
4012020-12-16T14:53:07 <jonasschnelli> aj: soon
4022020-12-16T14:53:24 <jonasschnelli> I'm currently working on the new AEAD (with internal rekeying)
4032020-12-16T14:53:40 <jonasschnelli> Which should end up in the BIP
4042020-12-16T14:54:21 <jonasschnelli> Discussion is somewhat still ongoing https://gist.github.com/jonasschnelli/c530ea8421b8d0e80c51486325587c52 (but I guess its ready to work into the BIP)
4052020-12-16T14:54:29 <jnewbery> aj: what percentage of additional block-relay-only peers are you seeing this quick disconnect from? Does this limit the effectiveness of the additional block-relay-only peer mechanism?
4062020-12-16T14:55:04 * jonasschnelli fears scope creep in v2
4072020-12-16T14:55:28 <aj> jnewbery: handwavy guess, maybe 10%?
4082020-12-16T14:56:18 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4092020-12-16T14:56:18 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20674: fuzz: Call SendMessages after ProcessMessage to increase coverage (master...2012-fuzzSendMessages) https://github.com/bitcoin/bitcoin/pull/20674
4102020-12-16T14:56:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4112020-12-16T14:56:26 <aj> jnewbery: i changed the timer to 20s (which doesn't really work because of the 30s min lifetime), which is the only reason i'm seeing lots
4122020-12-16T14:58:08 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
4132020-12-16T15:00:15 <sdaftuar> jnewbery: i think depending on your addrman, you might see a similar percentage of connections never get instantiated (because you have stale addresses that you're trying to connect to)
4142020-12-16T15:00:49 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Read error: Connection reset by peer)
4152020-12-16T15:00:59 <sdaftuar> jnewbery: but i think that is fine; if we eventually are able to find honest peers with putting low load on the network, that's much better than where we were before
4162020-12-16T15:01:05 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
4172020-12-16T15:01:05 *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has quit IRC (Read error: Connection reset by peer)
4182020-12-16T15:01:47 <sdaftuar> s/instantiated/connected/
4192020-12-16T15:01:59 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Remote host closed the connection)
4202020-12-16T15:02:34 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
4212020-12-16T15:03:22 *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has joined #bitcoin-core-dev
4222020-12-16T15:04:42 <aj> jnewbery: ~12.5% -- 366 "inv sent in violation of protocol" disconnections versus 2559 "disconnecting extra block-relay-only peer" messages. there's also a bunch of "i tried making a b-r-o extra conn, but they basically immediately disconnected me examples, which i haven't looked into at all
4232020-12-16T15:05:54 <jnewbery> sdaftuar: does that depend on whether we're making progress through all the addresses in our addrman? If we're eclipsed then maybe our peers will be able to churn our new tables and we'll only ever connect to bad peers
4242020-12-16T15:08:07 <Jackielove4u> jnewbery: you were right
4252020-12-16T15:08:26 <Jackielove4u> rc2 and rc3 dont work nicely along
4262020-12-16T15:08:36 <Jackielove4u> it seems my node was indeed still on rc2
4272020-12-16T15:08:58 <jnewbery> Jackielove4u: phew. That's good news :)
4282020-12-16T15:09:08 <Jackielove4u> sorry for wasting your times
4292020-12-16T15:09:26 <sdaftuar> jnewbery: we pull from both the new table and tried table in making these connections
4302020-12-16T15:09:37 <sdaftuar> if someone takes over the whole addrman, it's game over of course
4312020-12-16T15:10:00 *** Kiminuo <Kiminuo!~mix@141.98.103.124> has quit IRC (Ping timeout: 256 seconds)
4322020-12-16T15:13:28 <sdaftuar> i guess if somehow our only honest addrman addresses were in the same netgroups as our existing outbound connections, we would never finnd them
4332020-12-16T15:13:41 <sdaftuar> but that seems like a pretty small effect given that we only have 10 peers
4342020-12-16T15:13:45 <aj> Jackielove4u: that's okay, the "i told you so" seratonin release makes it all worthwhile ;)
4352020-12-16T15:13:56 *** rockhouse <rockhouse!~rockhouse@unaffiliated/rockhouse> has quit IRC (Quit: Ping timeout (120 seconds))
4362020-12-16T15:14:21 *** rockhouse <rockhouse!~rockhouse@unaffiliated/rockhouse> has joined #bitcoin-core-dev
4372020-12-16T15:16:17 *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
4382020-12-16T15:17:52 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
4392020-12-16T15:19:20 *** miketwen_ <miketwen_!~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com> has joined #bitcoin-core-dev
4402020-12-16T15:19:29 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
4412020-12-16T15:19:59 *** pinheadm_ <pinheadm_!~pinheadmz@71.190.30.138> has joined #bitcoin-core-dev
4422020-12-16T15:21:58 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 246 seconds)
4432020-12-16T15:23:08 *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has quit IRC (Ping timeout: 272 seconds)
4442020-12-16T15:23:28 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
4452020-12-16T15:23:45 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
4462020-12-16T15:24:46 *** shesek <shesek!~shesek@unaffiliated/shesek> has joined #bitcoin-core-dev
4472020-12-16T15:28:29 *** lontivero_ <lontivero_!~lontivero@186.183.3.32> has quit IRC (Ping timeout: 260 seconds)
4482020-12-16T15:33:55 *** kexkey <kexkey!~kexkey@static-198-54-132-94.cust.tzulo.com> has joined #bitcoin-core-dev
4492020-12-16T15:37:20 <jnewbery> I guess a more general point is that we select with replacement, so if there are only a few honest peers in our addrman, then it'll take a long time to pick them
4502020-12-16T15:38:30 <jnewbery> the new table is 4x the capacity of the tried table. I'd expect in reality the number of addresses are much more skewed towards the new table, but that's just a guess
4512020-12-16T15:40:28 *** lontivero_ <lontivero_!~lontivero@186.183.50.42> has joined #bitcoin-core-dev
4522020-12-16T15:41:16 <sdaftuar> jnewbery: i think we choose from new vs tried with 50% probability, don't we?
4532020-12-16T15:43:53 <jnewbery> oh you're right!
4542020-12-16T15:44:27 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4552020-12-16T15:44:28 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9dbcd3710521...3f205808a5f2
4562020-12-16T15:44:28 <bitcoin-git> bitcoin/master cd03513 Wladimir J. van der Laan: init: Signal-safe instant shutdown
4572020-12-16T15:44:29 <bitcoin-git> bitcoin/master 3f20580 Wladimir J. van der Laan: Merge #20605: init: Signal-safe instant shutdown
4582020-12-16T15:44:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4592020-12-16T15:44:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4602020-12-16T15:44:47 <bitcoin-git> [bitcoin] laanwj merged pull request #20605: init: Signal-safe instant shutdown (master...2020_12_instant_shutdown) https://github.com/bitcoin/bitcoin/pull/20605
4612020-12-16T15:44:48 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4622020-12-16T15:49:51 <jnewbery> sdaftuar: do you have a sense of what proportion of connection attempts fail after being selected in ThreadOpenConnections() ?
4632020-12-16T15:53:25 <sdaftuar> maybe half-ish
4642020-12-16T15:53:58 <sdaftuar> i just did a quick check to see how many successful block-relay only connections i've had, and it's about half what you'd expect if every connection succeeded and we connect to one every 5 minutes
4652020-12-16T15:54:37 <sdaftuar> but i'm sure it depends a lot on your addrman. the node i just checked is on both tor and ipv4, i'm sure there are quirks with how tor addresses are relayed, etc
4662020-12-16T15:55:16 <aj> jnewbery: could add logging for IsFeelerConn() -> fDisconect=true and cmpare that to how often we see "Making feeler connection to" log entries
4672020-12-16T15:57:30 *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
4682020-12-16T15:57:37 *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Read error: Connection reset by peer)
4692020-12-16T15:58:59 <jnewbery> aj: good idea
4702020-12-16T16:00:26 <jnewbery> I wonder if we should do the IsDiscouraged() check earlier. If you end up with some discouraged addresses in your addrman, I guess they'll just stay there and you'll sometimes select them but never be able to connect
4712020-12-16T16:08:41 *** Pavlenex <Pavlenex!~Thunderbi@185.103.110.235> has quit IRC (Quit: Pavlenex)
4722020-12-16T16:12:05 *** joelklabo <joelklabo!~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
4732020-12-16T16:17:59 *** belcher_ is now known as belcher
4742020-12-16T16:20:45 *** robert_spigler <robert_spigler!robertspig@gateway/shell/matrix.org/x-gyzoapdcugmmdwow> has quit IRC (Ping timeout: 268 seconds)
4752020-12-16T16:21:03 *** robert_spigler <robert_spigler!robertspig@gateway/shell/matrix.org/x-xnfysvtnctlvjxpj> has joined #bitcoin-core-dev
4762020-12-16T16:21:25 *** ctrlbreak <ctrlbreak!~ctrlbreak@159.2.165.130> has quit IRC (Remote host closed the connection)
4772020-12-16T16:21:54 *** ctrlbreak <ctrlbreak!~ctrlbreak@159.2.165.130> has joined #bitcoin-core-dev
4782020-12-16T16:34:00 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:313a:ef0a:c021:651e> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
4792020-12-16T16:38:01 *** promag__ is now known as promag
4802020-12-16T16:44:28 *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has joined #bitcoin-core-dev
4812020-12-16T16:45:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4822020-12-16T16:45:17 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3f205808a5f2...69f1ee1922e3
4832020-12-16T16:45:18 <bitcoin-git> bitcoin/master 6d3af3a Ivan Metlushko: wallettool: pass in DatabaseOptions into MakeWallet
4842020-12-16T16:45:18 <bitcoin-git> bitcoin/master 345e88e Ivan Metlushko: wallettool: add param to create descriptors wallet
4852020-12-16T16:45:19 <bitcoin-git> bitcoin/master 173cc9b Ivan Metlushko: test: walettool create descriptors
4862020-12-16T16:45:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4872020-12-16T16:45:23 *** davterra <davterra!~davterra@107.182.237.19> has joined #bitcoin-core-dev
4882020-12-16T16:45:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4892020-12-16T16:45:37 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20365: wallettool: add parameter to create descriptors wallet (master...wallet_tool_create_descriptors) https://github.com/bitcoin/bitcoin/pull/20365
4902020-12-16T16:45:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4912020-12-16T16:49:37 *** samuel-pedraza <samuel-pedraza!47edaff3@gateway/web/cgi-irc/kiwiirc.com/ip.71.237.175.243> has joined #bitcoin-core-dev
4922020-12-16T16:50:45 *** Kiminuo <Kiminuo!~mix@141.98.103.124> has joined #bitcoin-core-dev
4932020-12-16T16:56:22 *** lightlike <lightlike!~lightlike@p200300c7ef22ad008d562e74d2695fa7.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
4942020-12-16T16:59:57 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
4952020-12-16T17:01:09 *** Pavlenex <Pavlenex!~Thunderbi@185.103.110.235> has joined #bitcoin-core-dev
4962020-12-16T17:02:01 *** proofofkeags <proofofkeags!~proofofke@174-16-212-53.hlrn.qwest.net> has joined #bitcoin-core-dev
4972020-12-16T17:09:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4982020-12-16T17:09:36 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/69f1ee1922e3...ad3d4b3929ab
4992020-12-16T17:09:36 <bitcoin-git> bitcoin/master 83f8821 Pieter Wuille: refactor: add IsAddrCompatible() to CNode
5002020-12-16T17:09:37 <bitcoin-git> bitcoin/master 37fe80e Pieter Wuille: Only consider addrv2 peers for relay of non-addrv1 addresses
5012020-12-16T17:09:38 <bitcoin-git> bitcoin/master ad3d4b3 Wladimir J. van der Laan: Merge #20661: Only select from addrv2-capable peers for torv3 address rela...
5022020-12-16T17:09:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5032020-12-16T17:09:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5042020-12-16T17:09:56 <bitcoin-git> [bitcoin] laanwj merged pull request #20661: Only select from addrv2-capable peers for torv3 address relay (master...202012_torv2_relay_only_addrv2) https://github.com/bitcoin/bitcoin/pull/20661
5052020-12-16T17:09:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5062020-12-16T17:14:42 <MarcoFalke> Backport of this ^ conflicts with 7fabe0f359ae16ed36ce4ca2c33631d038c21448
5072020-12-16T17:15:03 <MarcoFalke> Should 7fabe0f359ae16ed36ce4ca2c33631d038c21448 also be backported?
5082020-12-16T17:15:38 <MarcoFalke> #19763
5092020-12-16T17:15:42 <gribble> https://github.com/bitcoin/bitcoin/issues/19763 | net: dont try to relay to the address originator by vasild · Pull Request #19763 · bitcoin/bitcoin · GitHub
5102020-12-16T17:15:56 *** Pavlenex <Pavlenex!~Thunderbi@185.103.110.235> has quit IRC (Quit: Pavlenex)
5112020-12-16T17:16:27 *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Quit: Leaving)
5122020-12-16T17:17:26 <vasild> it would be easy to resolve, in case it is decided not to backport 19763
5132020-12-16T17:19:39 *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
5142020-12-16T17:31:17 <sdaftuar> MarcoFalke: hm I'm not sure it's worth backporting #19763 myself. if we are concerned about addr propagation though, i would imagine that (after #20661) #20561 would be a bigger impact to get torv3 addresses to propagate quicker
5152020-12-16T17:31:20 <gribble> https://github.com/bitcoin/bitcoin/issues/19763 | net: dont try to relay to the address originator by vasild · Pull Request #19763 · bitcoin/bitcoin · GitHub
5162020-12-16T17:31:21 <gribble> https://github.com/bitcoin/bitcoin/issues/20661 | Only select from addrv2-capable peers for torv3 address relay by sipa · Pull Request #20661 · bitcoin/bitcoin · GitHub
5172020-12-16T17:31:22 <gribble> https://github.com/bitcoin/bitcoin/issues/20561 | p2p: periodically clear m_addr_known by sdaftuar · Pull Request #20561 · bitcoin/bitcoin · GitHub
5182020-12-16T17:31:51 <sdaftuar> as without 20561, self-announcements go out far less frequently
5192020-12-16T17:32:09 <sdaftuar> curious what others think though
5202020-12-16T17:32:41 <sipa> agree
5212020-12-16T17:33:36 *** Pavlenex <Pavlenex!~Thunderbi@185.103.110.235> has joined #bitcoin-core-dev
5222020-12-16T17:33:40 *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has quit IRC (Remote host closed the connection)
5232020-12-16T17:34:02 *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has joined #bitcoin-core-dev
5242020-12-16T17:36:02 <MarcoFalke> I don't feel strongly what to backport and what not, I guess one question is how much are v3 addresses considered to be supported in 0.21.0
5252020-12-16T17:37:21 <MarcoFalke> Maybe it is best to leave it for 0.21.1
5262020-12-16T17:38:03 <sdaftuar> i didn't quite understand how all this works -- is it the case that tor users who upgrade to 0.21 will suddenly switch to having a v3 address?
5272020-12-16T17:38:15 <sdaftuar> (sorry if this badly misunderstands how bitcoind and tor work together)
5282020-12-16T17:38:25 <sipa> sdaftuar: if they use tor autoconfig yes
5292020-12-16T17:38:45 <sdaftuar> thanks -- that lines up with my own experience, i didn't know if i had done something unusual
5302020-12-16T17:38:50 <luke-jr> only v3?
5312020-12-16T17:38:58 <luke-jr> or also?
5322020-12-16T17:38:59 <sdaftuar> luke-jr: yes, as far as i can tell
5332020-12-16T17:39:06 <luke-jr> not sure that's a good idea
5342020-12-16T17:39:08 <sipa> only v3
5352020-12-16T17:39:17 <luke-jr> well, I guess they can still connect to v2 peers?
5362020-12-16T17:39:32 <sipa> yes
5372020-12-16T17:39:46 <sipa> as long as tor v2 isn"t disabled network-wide
5382020-12-16T17:39:53 <sipa> in 10 months or so
5392020-12-16T17:40:02 <luke-jr> wen bitcoin-dnsseed support v3? :P
5402020-12-16T17:40:29 <sipa> luke-jr: makes little sense, as they can't be exposed through dns
5412020-12-16T17:40:43 <luke-jr> sipa: can be exposed via web :x
5422020-12-16T17:41:00 <luke-jr> pretty sure they can be on DNS too tho
5432020-12-16T17:41:10 <luke-jr> just needs to use a different record type
5442020-12-16T17:42:58 <sipa> luke-jr: then we need actual DNS client functionality, and can't just use OS resolvers
5452020-12-16T17:44:44 <luke-jr> Tor won't do it for us?
5462020-12-16T17:45:11 <sipa> tor has no DNS resolving functionality as far as i know
5472020-12-16T17:45:48 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5482020-12-16T17:45:50 <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/ad3d4b3929ab...5b6f970e3fda
5492020-12-16T17:45:50 <bitcoin-git> bitcoin/master a07910a Antoine Riard: test: Makes wtxidrelay support a generic P2PInterface option
5502020-12-16T17:45:51 <bitcoin-git> bitcoin/master 06efb31 Antoine Riard: Add functional test test_txid_inv_delay
5512020-12-16T17:45:52 <bitcoin-git> bitcoin/master d3b5eac Antoine Riard: Add mutation for functional test test_preferred_inv
5522020-12-16T17:45:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5532020-12-16T17:46:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5542020-12-16T17:46:08 <bitcoin-git> [bitcoin] laanwj merged pull request #20171: Add functional test test_txid_inv_delay (master...2020-10-txid-delay-test) https://github.com/bitcoin/bitcoin/pull/20171
5552020-12-16T17:46:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5562020-12-16T17:46:11 <sipa> there is a "connect me to this NAME" function that we use
5572020-12-16T17:46:40 <sipa> which does the resolving at an exit node and forwards the connection there
5582020-12-16T17:46:52 <sipa> but we never see the IP it resolved to
5592020-12-16T17:48:15 <wumpus> tor has DNS lookup support, however it only looks up one address, it cannot be used to get multiple results nor special records
5602020-12-16T17:48:29 <wumpus> (it's a socks5 extension which we don't use)
5612020-12-16T17:48:45 <wumpus> so indeed, DNS seeds are useless for it
5622020-12-16T17:49:23 <sipa> we could have seed nodes that are available for getaddr oneshot connections, exposed over hidden services
5632020-12-16T17:50:13 <wumpus> yes
5642020-12-16T17:50:41 <sipa> that may be a useful thing to add to my seeder
5652020-12-16T17:50:45 <sipa> PRs welcome :)
5662020-12-16T17:50:53 <sdaftuar> sipa: hm if we're relying on that we should revisit some of the issues we discussed in the last few months about how addrfetch connections work
5672020-12-16T17:51:41 <sdaftuar> actually, i think it's only an issue if the addrfetch peer you connect to is running bitcoin core, so maybe not an issue if your seeder is custom sofwtare with different behavior
5682020-12-16T17:52:09 <sipa> sdaftuar: when you run with onlynet=tor all DNS seed requests are converted into addrfetch connections to the DNS seeds
5692020-12-16T17:52:24 <sipa> which means it's doing an extra indirection
5702020-12-16T17:53:05 <sipa> this works fine, but it means seed requests do go outside of the tor network
5712020-12-16T17:54:07 <sdaftuar> when you say "we could have seed nodes that are available for getaddr one shot connections" - does that mean that we have hardcoded addresses available for that, or are you saying that there's a dns resolution that happens so that we would connect to a random bitcoin core node for the addrfetch behavior?
5722020-12-16T17:55:20 <sipa> my proposal is adding hardcoded addrfetchable hidden service addresses, which act as a seeder (and only support addrfetch), instead of as a full node
5732020-12-16T17:55:37 <sdaftuar> ah ok, that makes sense
5742020-12-16T17:56:18 <sdaftuar> i assume your seeder doesn't (eg) announce it's own address to the node that connects to it before responding to a getaddr request
5752020-12-16T17:56:50 <sdaftuar> as i think that behavior in bitcoin core causes problems with the addrfetch logic
5762020-12-16T18:00:00 <sipa> you can't connect to my seeder; its only publicly reachable interface is DNS
5772020-12-16T18:00:57 <sdaftuar> oh so "PRs welcome" meant we need to add quite a bit of functionality? :)
5782020-12-16T18:01:12 <sipa> yes :D
5792020-12-16T18:01:26 <sdaftuar> haha ok
5802020-12-16T18:01:29 <sipa> it does have support for bitcoin P2P connections though (as it uses those for crawling)
5812020-12-16T18:01:41 <sipa> but it doesn't listen
5822020-12-16T18:02:01 <sdaftuar> pretty sure if i tried to add listening support I'd end up letting your seeder get dosed in some way or other
5832020-12-16T18:02:38 <sipa> yeah... maybe it's better to do it as a patch to bitcoin core itself
5842020-12-16T18:06:20 <wumpus> sipa: i guess the first thing would be to make the crawler understand addrv2 and crawl torv3's, so that we have them in the list for hardcoded seeds
5852020-12-16T18:06:28 <sdaftuar> that seems straightforward. we basically just need a tool to manage the addrman a little more directly?
5862020-12-16T18:06:29 <sipa> yeah
5872020-12-16T18:07:14 <sipa> sdaftuar: my seeder does more than addrman, it keeps more statistics about connections and uptime
5882020-12-16T18:07:35 <sipa> but apart from that it's pretty similar
5892020-12-16T18:07:46 <sdaftuar> i was imagining that your seeder would run along side it, rather than be integrated into it?
5902020-12-16T18:07:53 <sdaftuar> but i don't know how feasible or practical that is
5912020-12-16T18:25:57 <Kiminuo> I have, out of frustration, changed CI tests from Ubuntu 18.04 to Ubuntu 20.04 and also bumped Clang (https://github.com/bitcoin/bitcoin/pull/19245/commits/cf948ffac6fc950066cd8975485a37a90d15ae07) but CI did not notice the change (https://github.com/bitcoin/bitcoin/runs/1562869764). Does CI require some sort of cache invalidation to do the build I want?
5922020-12-16T18:27:15 <Kiminuo> The idea being that I'm struggling with Ubuntu 18.04 & std::filesystem so when I upgrade to 20.04 for my https://github.com/bitcoin/bitcoin/pull/19245 I can at least move it an inch forward to have green tests.
5932020-12-16T18:28:04 <Kiminuo> And then I can attempt to lower dependencies back (clang, Ubuntu).
5942020-12-16T18:28:45 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 240 seconds)
5952020-12-16T18:30:26 <Kiminuo> I have tested locally using https://github.com/bitcoin/bitcoin/tree/master/ci#configurations before pushing that commit and it was green for Win64 test.
5962020-12-16T18:38:21 <sipa> Kiminuo: i'm very confused by the travis output
5972020-12-16T18:38:55 <sipa> where are all the travis jobs?
5982020-12-16T18:39:05 <sipa> (unrelated to your PR)
5992020-12-16T18:39:10 <sipa> i just don't know where to look anymore
6002020-12-16T18:39:12 <Kiminuo> moved to cirrus?
6012020-12-16T18:39:38 <sipa> oh?
6022020-12-16T18:39:55 <sipa> oh it seems there are more cirrus jobs now
6032020-12-16T18:39:59 <Kiminuo> https://github.com/bitcoin/bitcoin/runs/1562869764 I can see tests on the left, can you?
6042020-12-16T18:40:11 <sipa> maybe there is just one travis job left, and that's why it isn't showing a list?
6052020-12-16T18:40:56 <Kiminuo> https://github.com/bitcoin/bitcoin/pull/20658 i think this PR moves completely testing from Travis to Cirrus CI
6062020-12-16T18:41:20 <Kiminuo> but that's just my impression, I just check bitcoin core PRs but not in-depth
6072020-12-16T18:41:27 <sipa> seems i completely missed that :)
6082020-12-16T18:41:30 <wumpus> yes, travis is being phased out
6092020-12-16T18:42:19 <wumpus> they are stopping the free tier
6102020-12-16T18:43:29 <sipa> i saw they're moving to travis-ci.com, but travis-ci.com does have a free option it seems?
6112020-12-16T18:43:38 <sipa> anyway, no objecting to moving
6122020-12-16T18:46:03 <wumpus> i thought more than just the name changed but i don't know the exact details
6132020-12-16T18:46:16 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6142020-12-16T18:46:17 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5b6f970e3fda...427f8c2cff01
6152020-12-16T18:46:17 <bitcoin-git> bitcoin/master 8989577 Dmitry Petukhov: Fix length of R check in test/key_tests.cpp:key_signature_tests
6162020-12-16T18:46:18 <bitcoin-git> bitcoin/master 427f8c2 Wladimir J. van der Laan: Merge #20248: test: fix length of R check in key_signature_tests
6172020-12-16T18:46:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6182020-12-16T18:46:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6192020-12-16T18:46:34 <bitcoin-git> [bitcoin] laanwj merged pull request #20248: test: fix length of R check in key_signature_tests (master...fix-test-key-signature-low-r) https://github.com/bitcoin/bitcoin/pull/20248
6202020-12-16T18:46:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6212020-12-16T18:46:37 <sipa> Kiminuo: the failing build you link so is a mingw build; it's not compiled with gcc or clang
6222020-12-16T18:46:54 <luke-jr> eh?
6232020-12-16T18:47:11 <luke-jr> mingw = gcc
6242020-12-16T18:47:17 <sipa> at least not the usual gcc or clang packages; it's based on the gcc codebase of course
6252020-12-16T18:51:38 <Kiminuo> sipa, but how come that it builds for me locally with: FILE_ENV="./ci/test/00_setup_env_win64.sh" ./ci/test_run_all.sh ... meaning, in my Docker it seems to work but not on Cirrus CI
6262020-12-16T18:51:59 <sipa> perhaps you have a more recent mingw-w64?
6272020-12-16T18:52:24 <Kiminuo> but that's not possible, right? Docker is environment agnostic
6282020-12-16T18:52:34 <sipa> ok, then i have no clue, sorry :)
6292020-12-16T18:52:41 <sipa> i don't know anything about docker
6302020-12-16T18:52:58 <Kiminuo> well, CI tests run in Docker
6312020-12-16T18:53:14 <Kiminuo> so I'm very confused by this
6322020-12-16T18:53:47 <sipa> ping MarcoFalke?
6332020-12-16T18:55:06 <sipa> http://mingw-w64.org/doku.php/download makes me believe the latest mingw-w64 release is based on GCC 8.3.0
6342020-12-16T18:55:39 <sipa> but it's also possible i'm misinterpreting that, and mingw is really just some patchset/tooling that can be built with any underlying GCC version
6352020-12-16T18:57:04 *** samuel-pedraza <samuel-pedraza!47edaff3@gateway/web/cgi-irc/kiwiirc.com/ip.71.237.175.243> has quit IRC (Quit: Connection closed)
6362020-12-16T18:59:08 <Kiminuo> yeah
6372020-12-16T19:01:48 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6382020-12-16T19:01:48 <bitcoin-git> [bitcoin] vova557 opened pull request #20675: Vova557 (master...patch-11) https://github.com/bitcoin/bitcoin/pull/20675
6392020-12-16T19:01:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6402020-12-16T19:03:09 *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has quit IRC (Remote host closed the connection)
6412020-12-16T19:03:32 *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has joined #bitcoin-core-dev
6422020-12-16T19:04:10 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 268 seconds)
6432020-12-16T19:07:11 *** Pavlenex <Pavlenex!~Thunderbi@185.103.110.235> has quit IRC (Quit: Pavlenex)
6442020-12-16T19:07:12 <Kiminuo> sipa, I will need to find somebody who would like to finish that PR 19245. C++ building, linking and Bitcoin build system is not something I have adequate knowledge of. It takes me ages to move it an inch forward. I kind of did what I could. Can this be possibly discussed at a dev meeting?
6452020-12-16T19:08:07 <sipa> Kiminuo: sure; if you just want to leave up for grabs, no discussion necessary... but mentioning it in the meeting may help moving it forward
6462020-12-16T19:08:48 <Kiminuo> Another approach would be some "mentored approach". That is probably less ideal for me because I can help with programming side but not build side. And this PR needs the later.
6472020-12-16T19:09:10 <Kiminuo> right
6482020-12-16T19:09:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6492020-12-16T19:09:12 <bitcoin-git> [bitcoin] sdaftuar opened pull request #20676: Replace m_tx_relay/nullptr checks in net_processing.cpp (master...2020-12-refactor-m_tx_relay) https://github.com/bitcoin/bitcoin/pull/20676
6502020-12-16T19:09:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6512020-12-16T19:12:45 <jnewbery> sdaftuar: > we basically need a tool to manage the addrman a little more directly
6522020-12-16T19:13:34 <jnewbery> What are the requirements? We can add addresses to addrman using addpeeraddress. Shouldn't be too difficult to enhance that a bit more
6532020-12-16T19:13:47 <sdaftuar> jnewbery: i dunno, i might have misunderstood what sipa had in mind!
6542020-12-16T19:14:52 <sdaftuar> but the ability to add and remove addresses from addrman was what i was imagining was needed
6552020-12-16T19:16:06 <sipa> well, one option is to just integrate the dns seeder (excluding the dns serving feature and/or crawling, but at least the database part) into bitcoin core, and
6562020-12-16T19:16:16 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
6572020-12-16T19:16:18 <sipa> but that's probably not the right way
6582020-12-16T19:17:38 <sipa> another is to have a way of specifying on the command line "serve getaddr requests from data provided by $SCRIPT" or so, which would then be able to query a crawler
6592020-12-16T19:18:43 <sipa> and in either case, adding support for addrv2 to the crawler is probably a first step
6602020-12-16T19:20:19 <sdaftuar> i assume this is the code: https://github.com/sipa/bitcoin-seeder ?
6612020-12-16T19:20:27 <sipa> yes
6622020-12-16T19:30:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6632020-12-16T19:30:41 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/427f8c2cff01...ae9ee5bdb18c
6642020-12-16T19:30:41 <bitcoin-git> bitcoin/master ea36a45 John Newbery: [net] Make p2p recv buffer timeout 20 minutes for all peers
6652020-12-16T19:30:42 <bitcoin-git> bitcoin/master ae9ee5b MarcoFalke: Merge #20651: net: Make p2p recv buffer timeout 20 minutes for all peers
6662020-12-16T19:30:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6672020-12-16T19:30:59 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6682020-12-16T19:30:59 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20651: net: Make p2p recv buffer timeout 20 minutes for all peers (master...2020-12-recv-buffer-timeout) https://github.com/bitcoin/bitcoin/pull/20651
6692020-12-16T19:31:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6702020-12-16T19:32:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6712020-12-16T19:32:19 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #20675: Vova557 (master...patch-11) https://github.com/bitcoin/bitcoin/pull/20675
6722020-12-16T19:32:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6732020-12-16T19:36:32 <Kiminuo> @MarcoFalke, Hi, could you mark this https://github.com/bitcoin/bitcoin/pull/19245 PR with "up for grabs", "looking for help" or something in similar vein?
6742020-12-16T19:37:23 <Kiminuo> I have just modified the PR description to add as much as I know about the issue.
6752020-12-16T19:37:33 *** cncr04s <cncr04s!~cncr04s@unaffiliated/cncr04s> has quit IRC (*.net *.split)
6762020-12-16T19:38:26 *** cncr04s_ <cncr04s_!~cncr04s@afxr.net> has joined #bitcoin-core-dev
6772020-12-16T19:47:05 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Read error: Connection reset by peer)
6782020-12-16T19:51:35 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
6792020-12-16T19:52:34 *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Quit: peterrizzo)
6802020-12-16T19:52:44 *** Dogechain <Dogechain!~Dogechain@84.39.117.57> has quit IRC (Remote host closed the connection)
6812020-12-16T19:54:21 *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
6822020-12-16T20:00:08 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 256 seconds)
6832020-12-16T20:01:30 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Quit: Leaving)
6842020-12-16T20:01:42 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
6852020-12-16T20:02:35 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
6862020-12-16T20:11:48 *** cncr04s_ <cncr04s_!~cncr04s@afxr.net> has quit IRC (Quit: See you real soon!)
6872020-12-16T20:12:30 *** cncr04s <cncr04s!~cncr04s@unaffiliated/cncr04s> has joined #bitcoin-core-dev
6882020-12-16T20:13:25 *** Guest98077 <Guest98077!~meoblast0@217.146.82.202> has joined #bitcoin-core-dev
6892020-12-16T20:15:30 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
6902020-12-16T20:29:50 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
6912020-12-16T21:00:26 *** davterra <davterra!~davterra@107.182.237.19> has quit IRC (Remote host closed the connection)
6922020-12-16T21:01:03 *** joelklabo <joelklabo!~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: My iMac has gone to sleep. ZZZzzzâ¦)
6932020-12-16T21:05:04 *** lightlike <lightlike!~lightlike@p200300c7ef22ad008d562e74d2695fa7.dip0.t-ipconnect.de> has quit IRC (Remote host closed the connection)
6942020-12-16T21:10:04 *** davterra <davterra!~davterra@107.182.237.19> has joined #bitcoin-core-dev
6952020-12-16T21:10:12 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
6962020-12-16T21:13:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6972020-12-16T21:13:26 <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/ae9ee5bdb18c...4acbcfa97d20
6982020-12-16T21:13:27 <bitcoin-git> bitcoin/master 22437fc Carl Dong: build: Run libdmg-hfsplus's DMG tool in make deploy
6992020-12-16T21:13:28 <bitcoin-git> bitcoin/master 0df9819 fanquake: build: Replace genisoimage with xorriso
7002020-12-16T21:13:29 <bitcoin-git> bitcoin/master 7587d11 fanquake: build: remove cdrkit package from depends
7012020-12-16T21:13:36 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
7022020-12-16T21:13:40 *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has quit IRC (Ping timeout: 265 seconds)
7032020-12-16T21:13:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
7042020-12-16T21:13:50 <bitcoin-git> [bitcoin] laanwj merged pull request #20470: build: Replace genisoimage with xorriso (master...2020-11-xorriso) https://github.com/bitcoin/bitcoin/pull/20470
7052020-12-16T21:13:52 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
7062020-12-16T21:15:47 *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has joined #bitcoin-core-dev
7072020-12-16T21:17:14 *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has quit IRC (Read error: Connection reset by peer)
7082020-12-16T21:18:16 *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has joined #bitcoin-core-dev
7092020-12-16T21:23:49 *** lontivero_ <lontivero_!~lontivero@186.183.50.42> has quit IRC (Ping timeout: 265 seconds)
7102020-12-16T21:26:47 <jeremyrubin> Has anyone dealt with mysterious undeclared identifier for template functions defined within a .cpp unit? E.g., I have template<T> foo.... defined but for some reason function bar trying to call foo says no such identifier?
7112020-12-16T21:27:25 <jeremyrubin> I'm able to compile the same code on one machine and not the other
7122020-12-16T21:27:37 <jeremyrubin> maybe a build cache bug... let me distclean
7132020-12-16T21:34:15 *** Kiminuo <Kiminuo!~mix@141.98.103.124> has quit IRC (Quit: Leaving)
7142020-12-16T21:46:10 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
7152020-12-16T22:00:30 <andytoshi> is this in uint256.cpp? this has templates in a .cpp file and then "explicit instantiations" below that you need to add if you add any functions
7162020-12-16T22:00:43 <andytoshi> or more generally, if you have templates which live outside a header
7172020-12-16T22:02:00 <jeremyrubin> hmm yeah it was actually in script/interpreter with init.cpp
7182020-12-16T22:02:25 <jeremyrubin> maybe the clang on this VM can't instantiate a local method if it isn't explicit
7192020-12-16T22:02:29 *** Pavlenex <Pavlenex!~Thunderbi@185.103.110.235> has joined #bitcoin-core-dev
7202020-12-16T22:03:02 <jeremyrubin> but I feel like something that is local only and not visible from header shouldn't need explicit inst?
7212020-12-16T22:03:44 <sipa> jeremyrubin: what's the actual code?
7222020-12-16T22:04:03 <sipa> i would be very surprised if any modern compiler has a bug w.r.t. this
7232020-12-16T22:04:38 <sipa> it's possible it's something that depends on what C++ version you're using, and some compilers permit stuff from future versions
7242020-12-16T22:05:02 <jeremyrubin> let me wait on a distclean rebuild... maybe some issue with that
7252020-12-16T22:05:09 <jeremyrubin> this VPS is slow so will take a few
7262020-12-16T22:14:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
7272020-12-16T22:14:29 <bitcoin-git> [bitcoin] sdaftuar opened pull request #20677: doc: Remove shouty enums in net_processing comments (master...2020-12-remove-shouty-enums) https://github.com/bitcoin/bitcoin/pull/20677
7282020-12-16T22:14:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
7292020-12-16T22:15:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
7302020-12-16T22:15:29 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4acbcfa97d20...1811e488d53b
7312020-12-16T22:15:30 <bitcoin-git> bitcoin/master 281cf99 practicalswift: Do not run functions with necessary side-effects in assert()
7322020-12-16T22:15:30 <bitcoin-git> bitcoin/master 5021810 practicalswift: Make CanFlushToDisk a const member function
7332020-12-16T22:15:31 <bitcoin-git> bitcoin/master 1811e48 Wladimir J. van der Laan: Merge #20575: Do not run functions with necessary side-effects in assert()...
7342020-12-16T22:15:32 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
7352020-12-16T22:15:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
7362020-12-16T22:15:49 <bitcoin-git> [bitcoin] laanwj merged pull request #20575: Do not run functions with necessary side-effects in assert() (master...side-effect-free-assert) https://github.com/bitcoin/bitcoin/pull/20575
7372020-12-16T22:15:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
7382020-12-16T22:19:58 *** dgenr8 <dgenr8!~dgenr8@unaffiliated/dgenr8> has joined #bitcoin-core-dev
7392020-12-16T22:30:49 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Ping timeout: 264 seconds)
7402020-12-16T22:31:55 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
7412020-12-16T22:32:07 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
7422020-12-16T22:37:37 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Read error: Connection reset by peer)
7432020-12-16T22:39:01 *** pinheadm_ <pinheadm_!~pinheadmz@71.190.30.138> has quit IRC (Quit: pinheadm_)
7442020-12-16T22:39:39 *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has joined #bitcoin-core-dev
7452020-12-16T22:55:13 *** midnight <midnight!~midnight@unaffiliated/midnightmagic> has quit IRC (Ping timeout: 272 seconds)
7462020-12-16T22:57:00 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
7472020-12-16T22:59:21 *** midnight <midnight!~midnight@unaffiliated/midnightmagic> has joined #bitcoin-core-dev
7482020-12-16T23:08:42 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
7492020-12-16T23:15:55 *** midnight <midnight!~midnight@unaffiliated/midnightmagic> has quit IRC (Ping timeout: 258 seconds)
7502020-12-16T23:18:20 *** joelklabo <joelklabo!~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
7512020-12-16T23:18:24 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
7522020-12-16T23:19:46 *** vincenzopalazzo <vincenzopalazzo!~vincent@2001:b07:6474:9d49:1cd0:876b:6bfb:cb4a> has quit IRC (Remote host closed the connection)
7532020-12-16T23:23:04 *** Pavlenex <Pavlenex!~Thunderbi@185.103.110.235> has quit IRC (Quit: Pavlenex)
7542020-12-16T23:33:56 *** midnight <midnight!~midnight@unaffiliated/midnightmagic> has joined #bitcoin-core-dev
7552020-12-16T23:44:35 *** miketwen_ <miketwen_!~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com> has quit IRC (Remote host closed the connection)
7562020-12-16T23:53:20 *** miketwenty1 <miketwenty1!~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com> has joined #bitcoin-core-dev