12020-12-18T00:04:39 *** dgilmore1 <dgilmore1!~dgilmore@185.163.110.125> has joined #bitcoin-core-dev
22020-12-18T00:14:58 *** miketwenty1 <miketwenty1!~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com> has quit IRC ()
32020-12-18T00:26:32 *** viraltaco_ <viraltaco_!~taco@unaffiliated/d-b/x-8688605> has quit IRC (Ping timeout: 260 seconds)
42020-12-18T00:30:39 *** palazzovincenzo <palazzovincenzo!~vincent@93-35-218-68.ip56.fastwebnet.it> has joined #bitcoin-core-dev
52020-12-18T00:31:40 *** palazzovincenzo <palazzovincenzo!~vincent@93-35-218-68.ip56.fastwebnet.it> has quit IRC (Client Quit)
62020-12-18T00:33:23 *** vincenzopalazzo <vincenzopalazzo!~vincent@2001:b07:6474:9d49:7de2:ea26:22ca:4ba0> has quit IRC (Ping timeout: 268 seconds)
72020-12-18T00:52:55 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
82020-12-18T01:06:26 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:c08c:a5a2:10fd:4192> has joined #bitcoin-core-dev
92020-12-18T01:08:32 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 268 seconds)
102020-12-18T01:09:26 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
112020-12-18T01:10:38 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
122020-12-18T01:13:56 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:c08c:a5a2:10fd:4192> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
132020-12-18T01:17:03 *** proofofkeags <proofofkeags!~proofofke@2601:280:c280:e500:7ed6:f476:4ff8:2b87> has quit IRC (Remote host closed the connection)
142020-12-18T01:17:24 *** proofofkeags <proofofkeags!~proofofke@2601:280:c280:e500:61e1:6028:89f5:9f90> has joined #bitcoin-core-dev
152020-12-18T01:22:57 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:c08c:a5a2:10fd:4192> has joined #bitcoin-core-dev
162020-12-18T01:23:20 *** proofofkeags <proofofkeags!~proofofke@2601:280:c280:e500:61e1:6028:89f5:9f90> has quit IRC (Ping timeout: 268 seconds)
172020-12-18T01:36:16 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
182020-12-18T01:36:17 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
192020-12-18T01:36:19 *** vasild_ is now known as vasild
202020-12-18T01:36:27 *** instagibbs <instagibbs!~greg@061093103011.ctinets.com> has quit IRC (Ping timeout: 265 seconds)
212020-12-18T01:36:52 *** instagibbs <instagibbs!~greg@061093103011.ctinets.com> has joined #bitcoin-core-dev
222020-12-18T01:53:29 *** pentium2000 <pentium2000!~while@dsl-50-5-16-66.fuse.net> has joined #bitcoin-core-dev
232020-12-18T01:53:30 *** joelklabo <joelklabo!~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net> has quit IRC (Ping timeout: 272 seconds)
242020-12-18T01:57:32 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Quit: Leaving)
252020-12-18T02:10:20 *** andytoshi <andytoshi!~apoelstra@unaffiliated/andytoshi> has quit IRC (Remote host closed the connection)
262020-12-18T02:10:33 *** andytoshi <andytoshi!~apoelstra@unaffiliated/andytoshi> has joined #bitcoin-core-dev
272020-12-18T02:17:01 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Remote host closed the connection)
282020-12-18T02:17:15 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
292020-12-18T02:28:35 *** lontivero <lontivero!~lontivero@186.183.49.45> has quit IRC (Quit: Leaving)
302020-12-18T02:29:46 *** dgilmore1 <dgilmore1!~dgilmore@185.163.110.125> has quit IRC (Remote host closed the connection)
312020-12-18T02:37:13 *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Quit: peterrizzo)
322020-12-18T02:45:00 *** rabidus_ <rabidus_!~rabidus@dsl-olubng12-54fa17-92.dhcp.inet.fi> has joined #bitcoin-core-dev
332020-12-18T02:48:18 *** rabidus <rabidus!~rabidus@dsl-olubng12-54fa0c-1.dhcp.inet.fi> has quit IRC (Ping timeout: 260 seconds)
342020-12-18T02:49:39 *** RISCi_ATOM1 <RISCi_ATOM1!~RISCi_ATO@84.39.117.57> has joined #bitcoin-core-dev
352020-12-18T03:20:41 *** AndGee <AndGee!~AndGee1@2603-6011-cd02-9d53-3828-a03d-228e-2834.res6.spectrum.com> has joined #bitcoin-core-dev
362020-12-18T03:24:52 *** AndGee <AndGee!~AndGee1@2603-6011-cd02-9d53-3828-a03d-228e-2834.res6.spectrum.com> has quit IRC (Quit: Leaving)
372020-12-18T03:26:23 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
382020-12-18T03:37:45 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
392020-12-18T04:02:52 *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
402020-12-18T04:13:50 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Read error: Connection reset by peer)
412020-12-18T04:14:50 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
422020-12-18T04:17:58 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Remote host closed the connection)
432020-12-18T04:34:53 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Read error: Connection reset by peer)
442020-12-18T04:35:56 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
452020-12-18T05:15:44 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
462020-12-18T05:51:44 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Read error: Connection reset by peer)
472020-12-18T05:52:11 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
482020-12-18T05:57:08 *** instagibbs <instagibbs!~greg@061093103011.ctinets.com> has quit IRC (Ping timeout: 268 seconds)
492020-12-18T06:02:35 *** instagibbs <instagibbs!~greg@061093103011.ctinets.com> has joined #bitcoin-core-dev
502020-12-18T06:06:56 *** instagibbs <instagibbs!~greg@061093103011.ctinets.com> has quit IRC (Ping timeout: 240 seconds)
512020-12-18T06:18:27 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
522020-12-18T06:23:12 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 256 seconds)
532020-12-18T06:33:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
542020-12-18T06:33:51 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/816314ef0f7b...9b28bd73a33b
552020-12-18T06:33:51 <bitcoin-git> bitcoin/master 09d105e Hennadii Stepanov: ci: Drop travis_fold feature as Travis CI is no longer used
562020-12-18T06:33:52 <bitcoin-git> bitcoin/master 95487b0 Hennadii Stepanov: doc: Drop mentions of Travis CI as it is no longer used
572020-12-18T06:33:52 <bitcoin-git> bitcoin/master 9b28bd7 MarcoFalke: Merge #20691: ci, doc: Travis CI features and mentions cleanup
582020-12-18T06:33:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
592020-12-18T06:34:10 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
602020-12-18T06:34:10 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20691: ci, doc: Travis CI features and mentions cleanup (master...201217-travis) https://github.com/bitcoin/bitcoin/pull/20691
612020-12-18T06:34:11 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
622020-12-18T06:57:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
632020-12-18T06:57:30 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9b28bd73a33b...b27104dc5276
642020-12-18T06:57:31 <bitcoin-git> bitcoin/master fa7dde1 MarcoFalke: wallet: Pass ArgsManager into ExecuteWalletToolFunc instead of using global
652020-12-18T06:57:31 <bitcoin-git> bitcoin/master faf8f61 MarcoFalke: test: Add missing check for is_sqlite_compiled
662020-12-18T06:57:32 <bitcoin-git> bitcoin/master fae32f2 MarcoFalke: wallet: Add missing check for -descriptors wallet tool option
672020-12-18T06:57:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
682020-12-18T06:57:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
692020-12-18T06:57:50 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20687: wallet: Add missing check for -descriptors wallet tool option (master...2012-walletToolSqlite) https://github.com/bitcoin/bitcoin/pull/20687
702020-12-18T06:57:51 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
712020-12-18T07:01:07 *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
722020-12-18T07:10:02 *** Legousk <Legousk!~Henkie@178-84-68-9.dynamic.upc.nl> has joined #bitcoin-core-dev
732020-12-18T07:13:22 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
742020-12-18T07:13:47 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
752020-12-18T07:14:36 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Remote host closed the connection)
762020-12-18T07:16:22 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:cecf:c08c:a5a2:10fd:4192> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
772020-12-18T07:16:45 *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
782020-12-18T07:17:55 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 268 seconds)
792020-12-18T07:39:00 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
802020-12-18T07:55:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
812020-12-18T07:55:00 <bitcoin-git> [gui] MarcoFalke merged pull request #155: Fix checkbox layout in Create Wallet dialog (master...201218-i3) https://github.com/bitcoin-core/gui/pull/155
822020-12-18T07:55:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
832020-12-18T07:55:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
842020-12-18T07:55:19 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b27104dc5276...3dd3f7c0af7e
852020-12-18T07:55:20 <bitcoin-git> bitcoin/master e71b656 Hennadii Stepanov: qt: Align layout of checkboxes
862020-12-18T07:55:20 <bitcoin-git> bitcoin/master 3dd3f7c MarcoFalke: Merge bitcoin-core/gui#155: Fix checkbox layout in Create Wallet dialog
872020-12-18T07:55:22 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
882020-12-18T07:57:53 *** shesek <shesek!~shesek@unaffiliated/shesek> has joined #bitcoin-core-dev
892020-12-18T07:59:36 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
902020-12-18T08:01:19 <wumpus> jeremyrubin: correct, i think
912020-12-18T08:03:03 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
922020-12-18T08:05:03 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@49.228.254.151> has joined #bitcoin-core-dev
932020-12-18T08:16:44 *** jessepos_ <jessepos_!~jp@2601:645:200:162f:f9e7:eb3b:d9b9:fb74> has joined #bitcoin-core-dev
942020-12-18T08:19:57 *** jesseposner <jesseposner!~jp@2601:645:200:162f:a05d:e05c:c95e:bea7> has quit IRC (Ping timeout: 260 seconds)
952020-12-18T08:53:35 *** jesseposner <jesseposner!~jp@2601:645:200:162f:9cea:b906:dc79:8b94> has joined #bitcoin-core-dev
962020-12-18T08:54:53 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
972020-12-18T08:54:54 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3dd3f7c0af7e...20f4a9421ba6
982020-12-18T08:54:54 <bitcoin-git> bitcoin/master faeb40b MarcoFalke: ci: Install missing lint packages
992020-12-18T08:54:55 <bitcoin-git> bitcoin/master 20f4a94 MarcoFalke: Merge #20682: ci: Install missing lint packages
1002020-12-18T08:55:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1012020-12-18T08:55:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1022020-12-18T08:55:23 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20682: ci: Install missing lint packages (master...2012-testDel) https://github.com/bitcoin/bitcoin/pull/20682
1032020-12-18T08:55:24 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1042020-12-18T08:57:12 *** jessepos_ <jessepos_!~jp@2601:645:200:162f:f9e7:eb3b:d9b9:fb74> has quit IRC (Ping timeout: 268 seconds)
1052020-12-18T09:04:16 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1062020-12-18T09:04:17 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/20f4a9421ba6...83e4670fd7cd
1072020-12-18T09:04:17 <bitcoin-git> bitcoin/master 6d1e85f Suhas Daftuar: Clean up logging of outbound connection type
1082020-12-18T09:04:18 <bitcoin-git> bitcoin/master 83e4670 MarcoFalke: Merge #20690: Clean up logging of outbound connection type
1092020-12-18T09:04:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1102020-12-18T09:04:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1112020-12-18T09:04:36 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20690: Clean up logging of outbound connection type (master...2020-12-clean-up-outbound-logging) https://github.com/bitcoin/bitcoin/pull/20690
1122020-12-18T09:04:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1132020-12-18T09:07:31 *** Mercury_Vapor <Mercury_Vapor!~Mercury_V@174-082-166-092.res.spectrum.com> has quit IRC (Read error: Connection reset by peer)
1142020-12-18T09:09:38 *** Mercury_Vapor <Mercury_Vapor!~Mercury_V@174-082-166-092.res.spectrum.com> has joined #bitcoin-core-dev
1152020-12-18T09:11:58 <vasild> wumpus: if UPnP is "phased out", what about routers that only support UPnP?
1162020-12-18T09:20:15 *** jessepos_ <jessepos_!~jp@2601:645:200:162f:4081:3039:8161:4792> has joined #bitcoin-core-dev
1172020-12-18T09:23:34 <vasild> gleb: wrt https://github.com/bitcoin/bitcoin/pull/20685#issuecomment-747959538 -- by "non-popular overlay" do you mean I2P? What "privacy/security side-effects" side effects?
1182020-12-18T09:24:02 *** jesseposner <jesseposner!~jp@2601:645:200:162f:9cea:b906:dc79:8b94> has quit IRC (Ping timeout: 264 seconds)
1192020-12-18T09:34:23 <gleb> vasild: Yeah, if there's only a handful of I2P nodes in the network, and a user wants to run on I2P exclusively â that'd be pretty risky.
1202020-12-18T09:34:29 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1212020-12-18T09:34:55 <gleb> Consider an eclipse attack or traffic analysis
1222020-12-18T09:35:07 <gleb> On the Bitcoin p2p protocol layer I mean.
1232020-12-18T09:35:15 <vasild> ah, this one, I see
1242020-12-18T09:36:16 <vasild> yeah, running i2p _exclusively_ in the beginning (first 7 years) will may be not a good idea :)
1252020-12-18T09:37:11 <vasild> that belongs to doc/i2p.md (not existent yet)
1262020-12-18T09:37:51 *** TheRec <TheRec!~toto@drupal.org/user/146860/view> has quit IRC (Ping timeout: 265 seconds)
1272020-12-18T09:39:34 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
1282020-12-18T09:53:02 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@49.228.254.151> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
1292020-12-18T09:55:13 *** jesseposner <jesseposner!~jp@2601:645:200:162f:359d:6f20:f957:7c54> has joined #bitcoin-core-dev
1302020-12-18T09:58:32 *** jessepos_ <jessepos_!~jp@2601:645:200:162f:4081:3039:8161:4792> has quit IRC (Ping timeout: 260 seconds)
1312020-12-18T10:01:45 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Read error: Connection reset by peer)
1322020-12-18T10:02:23 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
1332020-12-18T10:04:40 *** kexkey <kexkey!~kexkey@static-198-54-132-110.cust.tzulo.com> has quit IRC (Ping timeout: 246 seconds)
1342020-12-18T10:05:30 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 256 seconds)
1352020-12-18T10:31:01 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1362020-12-18T10:33:06 *** Aaronvan_ <Aaronvan_!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1372020-12-18T10:36:30 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 256 seconds)
1382020-12-18T10:39:53 *** gh0str3c0n <gh0str3c0n!~gh0str3c0@105.112.131.33> has joined #bitcoin-core-dev
1392020-12-18T10:40:00 *** jessepos_ <jessepos_!~jp@2601:645:200:162f:b8f8:3090:90c1:84f> has joined #bitcoin-core-dev
1402020-12-18T10:40:42 *** gh0str3c0n <gh0str3c0n!~gh0str3c0@105.112.131.33> has quit IRC (Client Quit)
1412020-12-18T10:43:50 *** jesseposner <jesseposner!~jp@2601:645:200:162f:359d:6f20:f957:7c54> has quit IRC (Ping timeout: 264 seconds)
1422020-12-18T10:45:47 *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has joined #bitcoin-core-dev
1432020-12-18T10:51:04 <wumpus> vasild: how much is that really still a thing?
1442020-12-18T10:51:30 <vasild> no idea
1452020-12-18T10:52:29 <wumpus> i think UPnP is a terrible protocol, but I'm biased because the only RCE for bitcoin core that I know of used a UPnP xml parsing vulnerability
1462020-12-18T10:53:23 *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has quit IRC (Ping timeout: 240 seconds)
1472020-12-18T10:54:18 <wumpus> one advantage of NATPMP/PCP is that the protocol consists of super simple binary packets, doesn't involve that kind of parsing at all
1482020-12-18T10:54:19 *** kristapsk_ <kristapsk_!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
1492020-12-18T10:54:25 <wumpus> so we could even consider enabling it by default
1502020-12-18T10:55:02 <hebasto> ^ +1
1512020-12-18T10:55:30 *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
1522020-12-18T10:57:00 *** jesseposner <jesseposner!~jp@2601:645:200:162f:942e:52e4:5e83:4e03> has joined #bitcoin-core-dev
1532020-12-18T10:57:27 <vasild> Sure, if no downsides. What is that "random ports mapping" luke-jr mentioned (https://github.com/bitcoin/bitcoin/pull/18077#issuecomment-588484002)?
1542020-12-18T10:57:28 <wumpus> but yes that's separate from the question 'should it be supported at all', i don't think upnp support is much code to maintain and if it's disabled by default it's low risk so i don't actually feel strongly about that
1552020-12-18T10:57:46 <wumpus> i have no idea i have never heard that before
1562020-12-18T10:58:38 <wumpus> basically i just though the 'NAT PMP is a low priority protocol' was a strange comment
1572020-12-18T10:58:59 <vasild> it is
1582020-12-18T10:59:07 <vasild> (strange comment)
1592020-12-18T11:00:22 *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has joined #bitcoin-core-dev
1602020-12-18T11:00:38 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
1612020-12-18T11:00:40 *** jessepos_ <jessepos_!~jp@2601:645:200:162f:b8f8:3090:90c1:84f> has quit IRC (Ping timeout: 258 seconds)
1622020-12-18T11:00:59 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
1632020-12-18T11:03:14 <wumpus> i think the NAT PMP PR is almost ready, the code change looks good to me and it works, we should definitely have it in 0.22
1642020-12-18T11:04:27 <wumpus> discussion on whether to enable it by default or whether or not to deprecate UPnP doesn't need to be at the same time
1652020-12-18T11:05:04 <wumpus> right now it adds it as an opt-in feature just like UPnP that's a good way to get started
1662020-12-18T11:06:16 <wumpus> never delay anything on decisions that might be controversial or we'll still be waiting for it to get merged in 2025 :-)
1672020-12-18T11:13:27 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.29.10> has joined #bitcoin-core-dev
1682020-12-18T11:17:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1692020-12-18T11:17:52 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/83e4670fd7cd...f1dbf92ff047
1702020-12-18T11:17:53 <bitcoin-git> bitcoin/master 634f6ec Wladimir J. van der Laan: contrib: Parse ELF directly for symbol and security checks
1712020-12-18T11:17:53 <bitcoin-git> bitcoin/master a0a7718 Luke Dashjr: contrib: Changes to checks for PowerPC64
1722020-12-18T11:17:54 <bitcoin-git> bitcoin/master f1dbf92 Wladimir J. van der Laan: Merge #20434: contrib: Parse ELF directly for symbol and security checks
1732020-12-18T11:17:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1742020-12-18T11:18:10 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1752020-12-18T11:18:11 <bitcoin-git> [bitcoin] laanwj merged pull request #20434: contrib: Parse ELF directly for symbol and security checks (master...2020_11_pixie) https://github.com/bitcoin/bitcoin/pull/20434
1762020-12-18T11:18:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1772020-12-18T11:29:08 *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has quit IRC (Quit: Pavlenex)
1782020-12-18T11:31:09 *** RISCi_ATOM1 <RISCi_ATOM1!~RISCi_ATO@84.39.117.57> has quit IRC (Remote host closed the connection)
1792020-12-18T11:37:34 *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
1802020-12-18T11:44:37 *** jessepos_ <jessepos_!~jp@2601:645:200:162f:c4c5:f1a2:d167:ddbe> has joined #bitcoin-core-dev
1812020-12-18T11:48:12 *** jesseposner <jesseposner!~jp@2601:645:200:162f:942e:52e4:5e83:4e03> has quit IRC (Ping timeout: 260 seconds)
1822020-12-18T11:48:25 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.29.10> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
1832020-12-18T11:52:11 *** joeykrim1 <joeykrim1!~joeykrim@184.75.221.35> has joined #bitcoin-core-dev
1842020-12-18T11:57:32 *** jesseposner <jesseposner!~jp@2601:645:200:162f:b09d:272e:2a8b:923> has joined #bitcoin-core-dev
1852020-12-18T12:00:38 *** jessepos_ <jessepos_!~jp@2601:645:200:162f:c4c5:f1a2:d167:ddbe> has quit IRC (Ping timeout: 264 seconds)
1862020-12-18T12:06:29 *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has quit IRC (Read error: Connection reset by peer)
1872020-12-18T12:06:41 *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has joined #bitcoin-core-dev
1882020-12-18T12:08:38 *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has joined #bitcoin-core-dev
1892020-12-18T12:10:33 *** Pavlenex <Pavlenex!~Thunderbi@141.98.103.251> has quit IRC (Client Quit)
1902020-12-18T12:12:12 *** joeykrim1 <joeykrim1!~joeykrim@184.75.221.35> has quit IRC (Ping timeout: 256 seconds)
1912020-12-18T12:19:42 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1922020-12-18T12:19:42 <bitcoin-git> [bitcoin] hebasto opened pull request #20697: ci: Fix COMMIT_RANGE variable value (master...201218-range) https://github.com/bitcoin/bitcoin/pull/20697
1932020-12-18T12:19:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1942020-12-18T12:20:19 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1952020-12-18T12:25:06 *** jessepos_ <jessepos_!~jp@2601:645:200:162f:8920:56b:4b8c:29fc> has joined #bitcoin-core-dev
1962020-12-18T12:25:07 *** phillip <phillip!~phillip@217.146.82.202> has joined #bitcoin-core-dev
1972020-12-18T12:27:06 <promag> block kuaixbdsk3738?
1982020-12-18T12:28:43 *** jesseposner <jesseposner!~jp@2601:645:200:162f:b09d:272e:2a8b:923> has quit IRC (Ping timeout: 268 seconds)
1992020-12-18T12:33:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2002020-12-18T12:33:29 <bitcoin-git> [bitcoin] romanz opened pull request #20702: rpc: Add getblocklocations (master...locations) https://github.com/bitcoin/bitcoin/pull/20702
2012020-12-18T12:33:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2022020-12-18T12:59:56 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-10.dynamic.3bb.co.th> has joined #bitcoin-core-dev
2032020-12-18T13:03:33 *** jesseposner <jesseposner!~jp@2601:645:200:162f:5df7:4664:563e:a339> has joined #bitcoin-core-dev
2042020-12-18T13:07:12 *** jessepos_ <jessepos_!~jp@2601:645:200:162f:8920:56b:4b8c:29fc> has quit IRC (Ping timeout: 260 seconds)
2052020-12-18T13:15:40 *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
2062020-12-18T13:19:04 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 256 seconds)
2072020-12-18T13:19:16 <wumpus> promag: what did they do ?
2082020-12-18T13:28:01 *** Aaronvan_ is now known as AaronvanW
2092020-12-18T13:30:26 *** phillip <phillip!~phillip@217.146.82.202> has quit IRC (Remote host closed the connection)
2102020-12-18T13:31:28 *** Jaykul1 <Jaykul1!~Jaykul@185.103.96.147> has joined #bitcoin-core-dev
2112020-12-18T13:36:14 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
2122020-12-18T13:36:15 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
2132020-12-18T13:36:18 *** vasild_ is now known as vasild
2142020-12-18T13:36:28 <promag> wumpus: create a bunch of dumb issues afaict
2152020-12-18T13:41:04 *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-cmrzaiubcrrifiqv> has joined #bitcoin-core-dev
2162020-12-18T13:41:11 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-10.dynamic.3bb.co.th> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
2172020-12-18T13:43:03 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.29.10> has joined #bitcoin-core-dev
2182020-12-18T13:47:12 *** jessepos_ <jessepos_!~jp@2601:645:200:162f:d0d4:6fc8:58da:772f> has joined #bitcoin-core-dev
2192020-12-18T13:51:02 *** jesseposner <jesseposner!~jp@2601:645:200:162f:5df7:4664:563e:a339> has quit IRC (Ping timeout: 264 seconds)
2202020-12-18T13:52:44 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 256 seconds)
2212020-12-18T13:58:13 *** Chris_Stewart_5 <Chris_Stewart_5!~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383> has joined #bitcoin-core-dev
2222020-12-18T13:59:16 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
2232020-12-18T14:03:04 *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has quit IRC (Remote host closed the connection)
2242020-12-18T14:03:04 *** kristapsk_ <kristapsk_!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
2252020-12-18T14:03:05 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Write error: Broken pipe)
2262020-12-18T14:03:16 *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
2272020-12-18T14:03:16 *** kristapsk_ <kristapsk_!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
2282020-12-18T14:03:21 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
2292020-12-18T14:07:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2302020-12-18T14:07:30 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20715: util: Add ArgsManager::GetCommands() and use it in bitcoin-wallet (master...2012-argsCmd) https://github.com/bitcoin/bitcoin/pull/20715
2312020-12-18T14:07:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2322020-12-18T14:10:11 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
2332020-12-18T14:28:12 *** jesseposner <jesseposner!~jp@2601:645:200:162f:6dfe:6561:a145:b640> has joined #bitcoin-core-dev
2342020-12-18T14:31:17 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@171.5.29.10> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
2352020-12-18T14:31:32 *** jessepos_ <jessepos_!~jp@2601:645:200:162f:d0d4:6fc8:58da:772f> has quit IRC (Ping timeout: 260 seconds)
2362020-12-18T14:34:21 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-10.dynamic.3bb.co.th> has joined #bitcoin-core-dev
2372020-12-18T14:39:16 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-10.dynamic.3bb.co.th> has quit IRC (Ping timeout: 240 seconds)
2382020-12-18T14:41:15 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-10.dynamic.3bb.co.th> has joined #bitcoin-core-dev
2392020-12-18T14:48:23 *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has quit IRC (Ping timeout: 240 seconds)
2402020-12-18T14:50:55 *** molz_ <molz_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
2412020-12-18T14:54:13 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 264 seconds)
2422020-12-18T14:55:25 *** molz_ <molz_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 264 seconds)
2432020-12-18T14:56:31 *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
2442020-12-18T14:59:36 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 256 seconds)
2452020-12-18T15:00:24 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
2462020-12-18T15:00:25 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Remote host closed the connection)
2472020-12-18T15:00:57 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
2482020-12-18T15:01:02 *** jessepos_ <jessepos_!~jp@2601:645:200:162f:5097:9b7d:9170:ce6f> has joined #bitcoin-core-dev
2492020-12-18T15:04:28 *** jesseposner <jesseposner!~jp@2601:645:200:162f:6dfe:6561:a145:b640> has quit IRC (Ping timeout: 260 seconds)
2502020-12-18T15:07:19 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
2512020-12-18T15:07:46 *** _0x0ff <_0x0ff!~potatoe@unaffiliated/0x0ff/x-1210984> has quit IRC (Quit: into the offlines)
2522020-12-18T15:08:58 *** _0x0ff <_0x0ff!~potatoe@163.172.166.225> has joined #bitcoin-core-dev
2532020-12-18T15:31:15 *** jonatack <jonatack!~jon@213.152.186.173> has quit IRC (Ping timeout: 268 seconds)
2542020-12-18T15:40:45 *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
2552020-12-18T15:41:02 *** miketwen_ <miketwen_!~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com> has joined #bitcoin-core-dev
2562020-12-18T15:42:23 *** jesseposner <jesseposner!~jp@2601:645:200:162f:81ee:e2b7:1499:d389> has joined #bitcoin-core-dev
2572020-12-18T15:43:56 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 240 seconds)
2582020-12-18T15:46:40 *** jessepos_ <jessepos_!~jp@2601:645:200:162f:5097:9b7d:9170:ce6f> has quit IRC (Ping timeout: 268 seconds)
2592020-12-18T15:48:40 *** greypw <greypw!~greypw@unaffiliated/greypw> has quit IRC (Quit: I'll be back!)
2602020-12-18T15:49:50 *** greypw <greypw!~greypw@unaffiliated/greypw> has joined #bitcoin-core-dev
2612020-12-18T15:51:48 *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Quit: peterrizzo)
2622020-12-18T15:57:33 *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
2632020-12-18T15:58:44 *** jessepos_ <jessepos_!~jp@2601:645:200:162f:952d:242:9592:26e> has joined #bitcoin-core-dev
2642020-12-18T16:00:51 *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 268 seconds)
2652020-12-18T16:01:28 *** belcher_ is now known as belcher
2662020-12-18T16:02:26 *** jesseposner <jesseposner!~jp@2601:645:200:162f:81ee:e2b7:1499:d389> has quit IRC (Ping timeout: 264 seconds)
2672020-12-18T16:05:25 *** joelklabo <joelklabo!~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
2682020-12-18T16:06:55 *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has joined #bitcoin-core-dev
2692020-12-18T16:11:36 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
2702020-12-18T16:19:00 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@mx-ll-171.5.29-10.dynamic.3bb.co.th> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
2712020-12-18T16:20:39 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
2722020-12-18T16:28:43 *** lightningbot <lightningbot!~supybot@2400:8901::f03c:91ff:febb:bbc1> has joined #bitcoin-core-dev
2732020-12-18T16:30:58 *** jesseposner <jesseposner!~jp@2601:645:200:162f:f8ca:2dd4:5b19:c33c> has joined #bitcoin-core-dev
2742020-12-18T16:34:33 *** jessepos_ <jessepos_!~jp@2601:645:200:162f:952d:242:9592:26e> has quit IRC (Ping timeout: 258 seconds)
2752020-12-18T16:36:30 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 256 seconds)
2762020-12-18T16:47:10 *** peterrizzo <peterrizzo!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Quit: peterrizzo)
2772020-12-18T16:49:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2782020-12-18T16:49:43 <bitcoin-git> [bitcoin] hebasto opened pull request #20716: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-cloned) https://github.com/bitcoin/bitcoin/pull/20716
2792020-12-18T16:49:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2802020-12-18T16:50:41 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
2812020-12-18T16:55:28 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2822020-12-18T16:55:28 <bitcoin-git> [bitcoin] hebasto closed pull request #20716: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-cloned) https://github.com/bitcoin/bitcoin/pull/20716
2832020-12-18T16:55:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2842020-12-18T16:55:48 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2852020-12-18T16:55:48 <bitcoin-git> [bitcoin] hebasto reopened pull request #20716: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-cloned) https://github.com/bitcoin/bitcoin/pull/20716
2862020-12-18T16:55:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2872020-12-18T17:02:48 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2882020-12-18T17:02:48 <bitcoin-git> [bitcoin] hebasto closed pull request #20716: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-cloned) https://github.com/bitcoin/bitcoin/pull/20716
2892020-12-18T17:02:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2902020-12-18T17:05:26 *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has quit IRC (Remote host closed the connection)
2912020-12-18T17:05:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2922020-12-18T17:05:33 <bitcoin-git> [bitcoin] hebasto opened pull request #20717: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-clone) https://github.com/bitcoin/bitcoin/pull/20717
2932020-12-18T17:05:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2942020-12-18T17:05:40 *** Zenton <Zenton!~user@unaffiliated/vicenteh> has quit IRC (Read error: Connection reset by peer)
2952020-12-18T17:06:14 *** Zenton <Zenton!~user@unaffiliated/vicenteh> has joined #bitcoin-core-dev
2962020-12-18T17:06:48 <hebasto> cirrus builds somehow are not triggefred by new prs
2972020-12-18T17:18:04 *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
2982020-12-18T17:20:26 *** hhghhkqweaeasd <hhghhkqweaeasd!~flack@p200300d46f24de0023b487635c149e9b.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
2992020-12-18T17:27:11 *** kexkey <kexkey!~kexkey@static-198-54-132-138.cust.tzulo.com> has joined #bitcoin-core-dev
3002020-12-18T17:53:51 *** lightningbot <lightningbot!~supybot@cerulean.erisian.com.au> has joined #bitcoin-core-dev
3012020-12-18T17:59:34 <hebasto> sorry for mess with the recent prs open-close, but I have no clue why cirrus is down on the main repo, and it works fine in the gui repo
3022020-12-18T18:15:35 *** lightningbot <lightningbot!~supybot@2400:8901::f03c:91ff:febb:bbc1> has joined #bitcoin-core-dev
3032020-12-18T18:15:51 *** jeremyrubin <jeremyrubin!~jr@c-73-15-215-148.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
3042020-12-18T18:40:01 *** proofofkeags <proofofkeags!~proofofke@174-16-212-53.hlrn.qwest.net> has joined #bitcoin-core-dev
3052020-12-18T18:58:25 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC ()
3062020-12-18T19:00:42 *** jonatack <jonatack!~jon@88.124.242.136> has joined #bitcoin-core-dev
3072020-12-18T19:01:56 <jonatack> wallet meeting?
3082020-12-18T19:02:23 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
3092020-12-18T19:02:25 <jonatack> (or is it off until next year)
3102020-12-18T19:02:27 *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has quit IRC (Remote host closed the connection)
3112020-12-18T19:02:50 *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
3122020-12-18T19:03:26 <jonatack> e.g. Jan 1st, or more likely, 15th
3132020-12-18T19:03:42 <achow101> last wallet meeting of this year
3142020-12-18T19:03:47 *** kiltzman <kiltzman!~k1ltzman@195.189.99.96> has joined #bitcoin-core-dev
3152020-12-18T19:03:49 <achow101> #startmeeting
3162020-12-18T19:03:49 <core-meetingbot> Meeting started Fri Dec 18 19:03:49 2020 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
3172020-12-18T19:03:49 <core-meetingbot> Available commands: action commands idea info link nick
3182020-12-18T19:03:52 <emzy> hi
3192020-12-18T19:03:56 <jonatack> huzzah
3202020-12-18T19:04:23 <achow101> #bitcoin-core-dev Wallet Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator
3212020-12-18T19:04:23 <achow101> ryanofsky sdaftuar sipa vasild wumpus
3222020-12-18T19:04:38 <achow101> any topics?
3232020-12-18T19:06:17 <achow101> i suppose we're all focused on 0.21 right now
3242020-12-18T19:08:19 *** jonatack <jonatack!~jon@88.124.242.136> has quit IRC (Ping timeout: 260 seconds)
3252020-12-18T19:08:56 <achow101> ok then. next meeting will be Jan 15
3262020-12-18T19:09:00 <achow101> #endmeeting
3272020-12-18T19:09:00 <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
3282020-12-18T19:09:00 <core-meetingbot> Meeting ended Fri Dec 18 19:09:00 2020 UTC.
3292020-12-18T19:09:00 <core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-12-18-19.03.moin.txt
3302020-12-18T19:09:22 <sipa> that was fast
3312020-12-18T19:10:19 *** jonatack <jonatack!~jon@88.124.242.136> has joined #bitcoin-core-dev
3322020-12-18T19:10:39 <jonatack> sorry, freenode keeps kicking me off, it doesn't like my vpn
3332020-12-18T19:14:14 *** Jaykul1 <Jaykul1!~Jaykul@185.103.96.147> has quit IRC (Remote host closed the connection)
3342020-12-18T19:14:42 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
3352020-12-18T19:18:25 *** peterrizzo_ <peterrizzo_!~peterrizz@ool-44c18924.dyn.optonline.net> has quit IRC (Quit: peterrizzo_)
3362020-12-18T19:28:38 *** jonatack <jonatack!~jon@88.124.242.136> has quit IRC (Ping timeout: 272 seconds)
3372020-12-18T19:29:03 *** jonatack <jonatack!~jon@213.152.162.154> has joined #bitcoin-core-dev
3382020-12-18T19:35:02 *** RC-3004 <RC-3004!~RC-3004@84.39.117.57> has joined #bitcoin-core-dev
3392020-12-18T19:48:02 *** Chris_Stewart_5 <Chris_Stewart_5!~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383> has quit IRC (Ping timeout: 264 seconds)
3402020-12-18T19:48:47 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
3412020-12-18T19:49:04 *** Chris_Stewart_5 <Chris_Stewart_5!~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383> has joined #bitcoin-core-dev
3422020-12-18T20:02:36 *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has quit IRC (Ping timeout: 240 seconds)
3432020-12-18T20:10:51 *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-cmrzaiubcrrifiqv> has quit IRC (Quit: Connection closed for inactivity)
3442020-12-18T20:24:03 *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Ping timeout: 240 seconds)
3452020-12-18T20:47:05 *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
3462020-12-18T20:50:13 *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has joined #bitcoin-core-dev
3472020-12-18T21:01:14 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 264 seconds)
3482020-12-18T21:10:06 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
3492020-12-18T21:13:10 *** miketwen_ <miketwen_!~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com> has quit IRC (Ping timeout: 246 seconds)
3502020-12-18T21:19:18 *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-yjlujyyyfvchoyym> has joined #bitcoin-core-dev
3512020-12-18T21:30:39 *** flag <flag!~flag@net-93-66-71-105.cust.vodafonedsl.it> has quit IRC (Ping timeout: 260 seconds)
3522020-12-18T21:31:19 *** flag <flag!~flag@net-93-66-71-105.cust.vodafonedsl.it> has joined #bitcoin-core-dev
3532020-12-18T21:33:43 *** miketwen_ <miketwen_!~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com> has joined #bitcoin-core-dev
3542020-12-18T21:37:32 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 265 seconds)
3552020-12-18T21:53:09 <achow101> would it be desirable for the MacOS code signing tool to still use codesign_allocate?
3562020-12-18T21:53:50 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
3572020-12-18T21:53:58 <sipa> do you think you can easily replicate it in python?
3582020-12-18T21:54:29 <achow101> not really. it seems like macholib doesn't quite do what we need, so I would need to implement my own macho parser and modifier
3592020-12-18T21:54:35 <achow101> and that is decidely non trivial
3602020-12-18T21:54:45 <sipa> no need then, i think
3612020-12-18T21:54:51 <sipa> there is a working open-source tool that does this
3622020-12-18T21:55:23 <achow101> right, we just need the signer to also use that
3632020-12-18T21:55:34 <sipa> indeed
3642020-12-18T21:55:42 <sipa> (and the right one!)
3652020-12-18T21:56:03 <achow101> at least it's an easy problem to fix and solve since this works on non-macs too
3662020-12-18T21:56:16 <achow101> and won't enforce apple signed codesign_allocate
3672020-12-18T21:57:03 <sipa> and if you so desire, the functionality could be added to your tool later with no downsides
3682020-12-18T22:04:59 *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
3692020-12-18T22:16:18 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
3702020-12-18T22:17:15 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
3712020-12-18T22:18:52 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
3722020-12-18T22:30:49 *** filchef <filchef!~filchef@89.253.179.83> has joined #bitcoin-core-dev
3732020-12-18T22:52:54 *** filchef <filchef!~filchef@89.253.179.83> has quit IRC (Read error: Connection reset by peer)
3742020-12-18T23:09:15 <andytoshi> i'm having trouble building the fuzztests and i can't remember what i did last week that made it work
3752020-12-18T23:09:23 <andytoshi> getting stuff like
3762020-12-18T23:09:23 <andytoshi> /home/apoelstra/code/bitcoin/bitcoin/fuzz/src/./test/fuzz/fuzz.h:18: multiple definition of `FuzzFrameworkEmptyFun()'; test/fuzz/fuzz-addition_overflow.o:/home/apoelstra/code/bitcoin/bitcoin/fuzz/src/./test/fuzz/fuzz.h:18: first defined here
3772020-12-18T23:09:28 <andytoshi> lots of these "multiple definition" errosr
3782020-12-18T23:12:02 <sipa> this may be a result of #20560 being merged; does a make clean help?
3792020-12-18T23:12:05 <gribble> https://github.com/bitcoin/bitcoin/issues/20560 | fuzz: Link all targets once by MarcoFalke · Pull Request #20560 · bitcoin/bitcoin · GitHub
3802020-12-18T23:12:07 <sipa> or a re-configuree
3812020-12-18T23:12:53 <andytoshi> sipa: no, i've done lots of `make distclean` and `git clean -xf`, switching between clang and gcc, etc
3822020-12-18T23:13:03 <andytoshi> thanks, i'll take a look at 20560 and try reverting it
3832020-12-18T23:13:10 <sipa> how are you ./configure'ing?
3842020-12-18T23:13:22 <andytoshi> ./configure --with-incompatible-bdb CPPFLAGS='-DARENA_DEBUG -DDEBUG_LOCKORDER' --with-sanitizers=address,integer,undefined CC=clang CXX='clang++' --enable-fuzz --with-boost-process
3852020-12-18T23:13:38 <sipa> you need --with-sanitizers=...,fuzz if you want to build fuzz tests
3862020-12-18T23:13:47 <andytoshi> oh! thanks
3872020-12-18T23:14:05 <andytoshi> i think i was going to get there, my next thing was to grep through the CI config scripts and see what i was missing
3882020-12-18T23:14:27 <sipa> though it seems something was changed w.r.t not doing that, as dongcarl noticed: https://github.com/bitcoin/bitcoin/pull/20560#issuecomment-748339644
3892020-12-18T23:15:05 <sipa> i think we had some rudimentary support for building without specifically enabling fuzz, but the result wouldn't actually support fuzzing, just making sure stuff compiles
3902020-12-18T23:15:35 <andytoshi> yeah, i've kept half an eye on that stuff but i'm not sure where we wound up
3912020-12-18T23:15:47 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
3922020-12-18T23:16:21 <andytoshi> there is also some configuration which doesn't work with clang for me, but i can't remember what now
3932020-12-18T23:16:41 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
3942020-12-18T23:18:47 <sipa> it's --with-sanitizer=fuzzer (+ whatever other sanitizers you want to enable in the fuzz tests)
3952020-12-18T23:18:55 <sipa> * --with-sanitizers
3962020-12-18T23:19:21 <andytoshi> yep. building now. will know in 15-20 mins :)
3972020-12-18T23:19:29 <sipa> also see doc/fuzzing.md
3982020-12-18T23:25:05 <sipa> you need more CPU cores (or more RAM)
3992020-12-18T23:25:07 <sipa> :)
4002020-12-18T23:32:05 *** kristapsk_ <kristapsk_!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
4012020-12-18T23:32:28 *** kristapsk_ <kristapsk_!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
4022020-12-18T23:34:02 <andytoshi> i have them! but i am building my computer in canada and i'm not there yet (and because of weird shipping costs i have half the parts with me and half of them there)
4032020-12-18T23:34:24 <andytoshi> in a week i'll fly in, pockets full of RAM and a EPYC 7502, and i won't have to worry about this stuff
4042020-12-18T23:34:45 <andytoshi> anyway...looks like it worked, except now it's telling me that there are no test to run and to reconfigure with --with-daemon
4052020-12-18T23:34:47 <andytoshi> which definitely is new to me
4062020-12-18T23:35:12 <andytoshi> and doesn't appear in the CI scripts
4072020-12-18T23:35:18 <jonatack> so far the only change i've noticed since 20560 is how to run a fuzzer (the new way is documented in doc/fuzzing.md)
4082020-12-18T23:36:22 <jonatack> ./autogen.sh ; ./configure --enable-fuzz --with-sanitizers=address,fuzzer,undefined CC=clang CXX=clang++ && make distclean ; make -j5
4092020-12-18T23:36:32 <jonatack> is my usual for fuzzing i think
4102020-12-18T23:36:58 <andytoshi> ok that looks familiar. but when i try to run test/fuzz/test_runner.py it says i should reconfigure with --with-daemon
4112020-12-18T23:37:09 <sipa> bizarre
4122020-12-18T23:37:23 <sipa> i tested the PR before ACK'ing, including running test_runner.py
4132020-12-18T23:37:26 <jonatack> oh i never got that script to work, i thought it was for the ci
4142020-12-18T23:37:42 <jonatack> i just run individual fuzzers
4152020-12-18T23:37:54 <andytoshi> hmm, it was definitely working for me a week ago
4162020-12-18T23:38:08 <andytoshi> but i wasn't keeping track of what commit or what workdir i was in or anything, so idk what might've changed
4172020-12-18T23:38:12 <jonatack> it's been a year since i last tried tho
4182020-12-18T23:38:19 <sipa> i think you're callig test/functional/test_runner.py, not test/fuzz/test_runner.py
4192020-12-18T23:39:01 <andytoshi> haha dammit
4202020-12-18T23:39:19 <andytoshi> well i already did `make clean` so now i gotta wait another 20 minutes
4212020-12-18T23:39:23 <andytoshi> fridays..
4222020-12-18T23:39:35 <sipa> sounds like you need to install ccache
4232020-12-18T23:39:40 <andytoshi> yeah, i really should
4242020-12-18T23:40:14 <andytoshi> i installed it, is there anything else i should do? i guess reconfigure so Core detects that i have it
4252020-12-18T23:40:17 <sipa> configure will automatically make use of it; all you need to do is install it
4262020-12-18T23:40:23 <andytoshi> great thanks
4272020-12-18T23:40:42 <jonatack> oh, it does work now...yay!
4282020-12-18T23:41:21 <andytoshi> the fact that test_runner wasn't yelling at me for providing no corpus should've tipped me off that i was running the wrong script..
4292020-12-18T23:42:03 <andytoshi> sipa: also, is there a good way to run all the fuzzers, against the qa-assets corpus, with a ton of iterations
4302020-12-18T23:42:12 <andytoshi> other than editing test_runner.py runs=1 to runs=100000
4312020-12-18T23:43:20 <sipa> why would you want to do more than 1 iteration
4322020-12-18T23:43:45 *** siropushselski <siropushselski!~sirikosir@80.72.89.153.coresnet.bg> has joined #bitcoin-core-dev
4332020-12-18T23:43:50 <andytoshi> to test more mutations
4342020-12-18T23:44:02 <sipa> (i should add that i didn't even knew about the existence of this script before reviewing 20560, i've never actually used it in production)
4352020-12-18T23:44:28 <sipa> if you want mutations, you need to start it with -g
4362020-12-18T23:44:28 <andytoshi> i assume that if you increase the --runs parameter, it will start from the seeds in the qa-assets corpus, and then search from there
4372020-12-18T23:44:39 <sipa> if you don't, it'll just run the existing corpus, with no mutations
4382020-12-18T23:44:53 <andytoshi> will -g use the qa-assets corpus? it sounds from the help text like it'll just overwrite it
4392020-12-18T23:45:20 <sipa> that would be ridiculous, but let me check because i don't actually know
4402020-12-18T23:45:49 <sipa> "Create new corpus seeds (or extend the existing ones) by running"
4412020-12-18T23:45:52 <sipa> according to --help
4422020-12-18T23:45:55 <andytoshi> ok, cool, i just can't read
4432020-12-18T23:48:47 <andytoshi> hooray it's going!