12020-12-23T00:02:36 *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-mfttzpvimjezxnps> has joined #bitcoin-core-dev
22020-12-23T00:07:26 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
32020-12-23T00:09:58 <sipa> justinmoon: sorry, no experience with docker
42020-12-23T00:11:56 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 240 seconds)
52020-12-23T00:13:08 *** filchef <filchef!~filchef@89.253.179.83> has quit IRC (Read error: Connection reset by peer)
62020-12-23T00:14:55 *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
72020-12-23T00:15:43 *** ghost43_ <ghost43_!~daer@gateway/tor-sasl/daer> has quit IRC (Ping timeout: 240 seconds)
82020-12-23T00:18:07 <jonatack> justinmoon: https://github.com/jonatack/bitcoin-development/blob/master/gitian-building.md
92020-12-23T00:18:45 <jonatack> (it's docker-based)
102020-12-23T00:19:16 <phantomcircuit> MarcoFalke, btw https://github.com/bitcoin-core/qa-assets/pull/37
112020-12-23T00:19:20 <phantomcircuit> that's actually merged
122020-12-23T00:41:47 <justinmoon> jonatack: perfect, thanks
132020-12-23T00:51:13 *** jonatack <jonatack!~jon@213.152.161.30> has quit IRC (Ping timeout: 264 seconds)
142020-12-23T00:53:08 *** jonatack <jonatack!~jon@88.124.242.136> has joined #bitcoin-core-dev
152020-12-23T00:57:17 *** jesseposner <jesseposner!~jp@2601:645:200:162f:da9:1617:a616:f7bc> has quit IRC (Ping timeout: 260 seconds)
162020-12-23T00:57:25 *** jessepos_ <jessepos_!~jp@c-73-15-111-74.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
172020-12-23T01:04:08 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
182020-12-23T01:28:16 *** miketwen_ <miketwen_!~miketwent@ec2-54-235-98-1.compute-1.amazonaws.com> has quit IRC (Ping timeout: 246 seconds)
192020-12-23T01:36:16 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
202020-12-23T01:36:17 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
212020-12-23T01:36:19 *** vasild_ is now known as vasild
222020-12-23T01:37:40 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 256 seconds)
232020-12-23T01:48:30 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
242020-12-23T01:59:40 *** roconnor <roconnor!~roconnor@host-45-78-199-13.dyn.295.ca> has joined #bitcoin-core-dev
252020-12-23T02:27:37 *** instagibbs <instagibbs!~greg@061093103011.ctinets.com> has joined #bitcoin-core-dev
262020-12-23T02:28:49 *** instagibbs <instagibbs!~greg@061093103011.ctinets.com> has quit IRC (Client Quit)
272020-12-23T02:36:20 *** StopAndDecrypt <StopAndDecrypt!~StopAndDe@unaffiliated/stopanddecrypt> has quit IRC (Remote host closed the connection)
282020-12-23T03:07:22 *** jessepos_ <jessepos_!~jp@c-73-15-111-74.hsd1.ca.comcast.net> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
292020-12-23T03:07:45 *** jesseposner <jesseposner!~jp@2601:645:200:162f:1507:39f0:b918:b6c4> has joined #bitcoin-core-dev
302020-12-23T03:18:58 *** brimstone1 <brimstone1!~brimstone@185.204.1.185> has quit IRC (Remote host closed the connection)
312020-12-23T03:34:43 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
322020-12-23T04:07:16 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 256 seconds)
332020-12-23T04:13:14 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
342020-12-23T04:13:14 <bitcoin-git> [bitcoin] pstratem opened pull request #20751: [fuzzing] Use subprocess.Popen call directly, remove use of thread pool. (master...2020-12-22-fuzz-test-runner) https://github.com/bitcoin/bitcoin/pull/20751
352020-12-23T04:13:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
362020-12-23T04:46:11 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
372020-12-23T04:46:11 <bitcoin-git> [bitcoin] pstratem opened pull request #20752: [fuzzer] generate new seeds in an infinite loop with random parameters (master...2020-12-fuzz-test-runner-infinite-generate) https://github.com/bitcoin/bitcoin/pull/20752
382020-12-23T04:46:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
392020-12-23T04:48:03 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Read error: Connection reset by peer)
402020-12-23T04:48:42 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
412020-12-23T04:53:19 <phantomcircuit> sipa, ^ those seem to work nicely
422020-12-23T04:57:02 <sipa> mutate_depth uniformly up to 15, wow
432020-12-23T04:57:21 <sipa> i haven't experimented with that, but assumed that the default of 5 was pretty good
442020-12-23T04:59:15 <sipa> phantomcircuit: i believe it also makes sense to vary the -max_len parameter
452020-12-23T04:59:30 <sipa> giving proportionally more time to short inputs seems to help
462020-12-23T05:00:43 <phantomcircuit> sipa, there's already a strong bias towards smaller inputs with another parameter which is uhhh
472020-12-23T05:01:01 <phantomcircuit> len_control
482020-12-23T05:03:46 <phantomcircuit> i might need to upstream to clang a change to the max_total_time behaviour, for process_message even with 300 seconds it exits after like 100 tests
492020-12-23T05:04:23 <sipa> phantomcircuit: another possibility is just not starting with the full corpus, but just a random subset of limited size
502020-12-23T05:06:04 <sipa> phantomcircuit: the len_control isn't useful for us i think... yes, you want short and long, but you don't want that within one run... we run so long that hopefully there is good coverage on all lengths already
512020-12-23T05:06:36 <phantomcircuit> oh i forgot to add a sleep to the loop
522020-12-23T05:06:37 <phantomcircuit> heh
532020-12-23T05:07:13 <phantomcircuit> sipa, right so random max_len between like 100 and 4,000,000 ?
542020-12-23T05:07:24 <sipa> by default max_len is 4096
552020-12-23T05:07:41 <sipa> and len_control is on
562020-12-23T05:07:43 <phantomcircuit> uh no by default it guesses based on the corpus
572020-12-23T05:07:57 <phantomcircuit> which for process_message ends up being >1MiB
582020-12-23T05:07:58 <sipa> oh, ok, but if the corpus has nothing big, it's set to 4096 afaik
592020-12-23T05:08:20 <phantomcircuit> INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 1007323 bytes
602020-12-23T05:08:48 <sipa> longer term i think we want an absolutely max_len configured for every target
612020-12-23T05:08:52 <phantomcircuit> it's based on what's n the corpus and afaict the only way for it to grow is to have lots of things which are near the max and restart the process
622020-12-23T05:09:01 <phantomcircuit> it'll then guess that max_len should be longer and bump it
632020-12-23T05:19:57 <phantomcircuit> sipa, yeah agree, i suggested upto 4MiB since that's the largest valid network message, i think?
642020-12-23T05:27:47 <sipa> but fuzzing with such large inputs is super slow
652020-12-23T05:28:48 <sipa> so i think you want the max_len parameter exponentially distributed between say 64 and 4096 for most targets, and maybe forna few exceptions with a higher max
662020-12-23T05:35:49 <phantomcircuit> 2 ** random.randint(1,12)
672020-12-23T05:35:52 <phantomcircuit> maybe?
682020-12-23T05:35:59 <phantomcircuit> actually that starts too small
692020-12-23T05:36:12 <phantomcircuit> 2 ** random.randint(6,12)
702020-12-23T05:40:02 <sipa> math.round(2.0 ** random.uniform(6.0, 12.0)) ?
712020-12-23T05:41:19 <phantomcircuit> does the max length need to be uniformly within the range?
722020-12-23T05:42:13 <phantomcircuit> maybe just powers of 2 is ok?
732020-12-23T05:46:11 <sipa> that's not uniform
742020-12-23T05:47:37 <phantomcircuit> sipa, ?
752020-12-23T05:50:12 *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-mfttzpvimjezxnps> has quit IRC (Quit: Connection closed for inactivity)
762020-12-23T05:50:52 <sipa> 2**random.uniform is exponential, not uniform
772020-12-23T05:56:28 <phantomcircuit> sipa, oh no i mean like instead of powers of 2 that will also be values inbetween
782020-12-23T05:56:37 <phantomcircuit> it's still distributed exponentially
792020-12-23T05:59:18 <sipa> yeah, why restrict to just powers of 2? :)
802020-12-23T05:59:26 <sipa> (no strong opinion, i'm sure it's all fine)
812020-12-23T06:02:10 <phantomcircuit> btw the largest corpus i have is now for the bloom_filter and asmap tests which is interesting
822020-12-23T06:02:34 <phantomcircuit> i think the process message one just explodes trying to load it's corpus actually
832020-12-23T06:03:14 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
842020-12-23T06:04:18 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
852020-12-23T06:37:40 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 246 seconds)
862020-12-23T06:41:16 <phantomcircuit> sipa, yeah i tried specifying -runs instead of -max_total_time and im running into the problem i thought i would
872020-12-23T06:41:33 <phantomcircuit> all the processes are now expensive things to run cause they sort of clog up the works
882020-12-23T07:04:03 *** jessepos_ <jessepos_!~jp@2601:645:200:162f:b9d5:4819:405c:7ac5> has joined #bitcoin-core-dev
892020-12-23T07:06:13 *** jesseposner <jesseposner!~jp@2601:645:200:162f:1507:39f0:b918:b6c4> has quit IRC (Ping timeout: 258 seconds)
902020-12-23T07:37:43 *** gleb <gleb!~gleb@178.150.137.228> has quit IRC (Ping timeout: 260 seconds)
912020-12-23T07:54:30 *** dgenr8 <dgenr8!~dgenr8@unaffiliated/dgenr8> has quit IRC (Ping timeout: 268 seconds)
922020-12-23T08:06:47 *** dgenr8 <dgenr8!~dgenr8@unaffiliated/dgenr8> has joined #bitcoin-core-dev
932020-12-23T08:13:58 *** zeromus1 <zeromus1!~zeromus@84.39.117.57> has joined #bitcoin-core-dev
942020-12-23T08:26:40 *** jessepos_ <jessepos_!~jp@2601:645:200:162f:b9d5:4819:405c:7ac5> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
952020-12-23T08:27:05 *** jesseposner <jesseposner!~jp@2601:645:200:162f:b9d5:4819:405c:7ac5> has joined #bitcoin-core-dev
962020-12-23T08:27:57 <jonasschnelli> what is the reason to extend the fuzzer seeds? Catching more potential issues?
972020-12-23T08:30:20 <sipa> jonasschnelli: that's literally what fuzzing is
982020-12-23T08:30:25 <sipa> finding more seeds
992020-12-23T08:30:59 <sipa> finding more inputs that cover more code, or more potential issues
1002020-12-23T08:31:07 <jonasschnelli> I think my understanding of fuzzing is weak... I need to read more about it first
1012020-12-23T08:31:32 <jonasschnelli> I always thought its running a random stream against all possible APIs for a very long time
1022020-12-23T08:32:27 <sipa> every fuzz target is a function that takes a byte array, and uses it to decide what things to call
1032020-12-23T08:32:40 <sipa> some targets just call functions, and don't do anything elae
1042020-12-23T08:33:13 <jonasschnelli> okay. I get that.
1052020-12-23T08:33:15 <sipa> others have full simulators of what the expected behaviour is going to be and compares with it
1062020-12-23T08:33:28 <sipa> fuzzing is finding those input byte arrays, called seeds
1072020-12-23T08:33:47 <sipa> it does that by applying random mutations to existing seeds
1082020-12-23T08:33:59 <sipa> or trying new things
1092020-12-23T08:35:09 <sipa> when people spend CPU time fuzzing, the output is finding more seeds, because it somehow found something that appears either more interesting than all seeds there were before, or because it does the same but with a smaller seed
1102020-12-23T08:35:22 <jonasschnelli> so the seeds are actually not a random-stream-seeds that is used for pure fuzzing of a function(or API)? They decide what to call?
1112020-12-23T08:35:25 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1122020-12-23T08:35:41 <sipa> that's right, they are the exact input fed to the fuzz target
1132020-12-23T08:36:31 <sipa> our CI infrastructure also runs these seeds as part of the tests, but without trying to generate more
1142020-12-23T08:36:48 <jonasschnelli> you wrote "more interesting",.. does the fuzz target track to code paths (or percentage) beeing used?
1152020-12-23T08:36:54 <sipa> yes
1162020-12-23T08:36:56 <sipa> and more
1172020-12-23T08:37:08 <jonasschnelli> I see
1182020-12-23T08:37:22 <sipa> it has counters for various things; code blocks, branches, ..
1192020-12-23T08:37:56 <sipa> if you run in -use_value_profile mode it counts specific values seen in comparisons too
1202020-12-23T08:37:56 <jonasschnelli> so one can say there are "better" and "weaker" seeds?
1212020-12-23T08:38:10 <sipa> it"s the combimed corpus that matters
1222020-12-23T08:38:29 <sipa> but the goal is ultimately finding a small combined corpus with maximal coverage
1232020-12-23T08:38:44 <jonasschnelli> the more counters a seed hits the better,.. but overall, you want all "counter" to be hit by a range of seeds?
1242020-12-23T08:38:55 <sipa> right
1252020-12-23T08:39:05 <jonasschnelli> thanks. TIL
1262020-12-23T08:39:28 *** dviola <dviola!~diego@187.39.20.240> has left #bitcoin-core-dev
1272020-12-23T08:39:35 <sipa> it's annoying that you need a separate build/configure foe it
1282020-12-23T08:39:44 <sipa> i have a separate worktree for that
1292020-12-23T08:40:06 <sipa> it's fun to play with
1302020-12-23T08:40:12 <jonasschnelli> Yes. That's the reason why I haven't looked closer into it. :)
1312020-12-23T08:40:28 <sipa> just follow doc/fuzzing.md
1322020-12-23T08:40:37 <jonasschnelli> will do
1332020-12-23T08:40:54 <sipa> we have a test/fuzz/test_runner.py that lets you more easily do larger scale testing
1342020-12-23T08:41:17 <sipa> but just running a fuzzer directly will prpbably be more informative
1352020-12-23T08:41:57 <sipa> just compile with --with-sanitizers=fuzzer --enable-fuzz, and run e.g. FUZZ=asmap src/test/fuzz/fuzz
1362020-12-23T08:42:13 *** dviola <dviola!~diego@unaffiliated/dviola> has joined #bitcoin-core-dev
1372020-12-23T08:42:31 <jonasschnelli> ok
1382020-12-23T08:42:37 <sipa> it'll test you when it finds new inputs, and some metrics about coverage
1392020-12-23T08:42:54 <sipa> you need to specify a dir name to leg it save its seeds
1402020-12-23T08:43:28 <sipa> *let
1412020-12-23T08:44:16 <sipa> *tell
1422020-12-23T08:47:04 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1432020-12-23T08:58:25 *** kexkey <kexkey!~kexkey@static-198-54-132-154.cust.tzulo.com> has quit IRC (Read error: Connection reset by peer)
1442020-12-23T08:58:25 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Read error: Connection reset by peer)
1452020-12-23T08:58:49 *** brianhoffman <brianhoffman!~brianhoff@pool-71-191-34-154.washdc.fios.verizon.net> has quit IRC (Read error: Connection reset by peer)
1462020-12-23T08:58:53 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
1472020-12-23T08:59:10 *** brianhoffman <brianhoffman!~brianhoff@pool-71-191-34-154.washdc.fios.verizon.net> has joined #bitcoin-core-dev
1482020-12-23T08:59:50 *** tlev <tlev!~tlev@li120-195.members.linode.com> has joined #bitcoin-core-dev
1492020-12-23T09:02:47 *** tlev1 <tlev1!~tlev@li120-195.members.linode.com> has quit IRC (Ping timeout: 265 seconds)
1502020-12-23T09:07:49 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 246 seconds)
1512020-12-23T09:10:05 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
1522020-12-23T09:21:04 *** shesek <shesek!~shesek@164.90.217.137> has joined #bitcoin-core-dev
1532020-12-23T09:28:23 *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
1542020-12-23T09:31:23 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1552020-12-23T09:45:16 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (Ping timeout: 240 seconds)
1562020-12-23T09:47:37 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 264 seconds)
1572020-12-23T09:57:02 *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:d16a:4949:3622:4cc0> has quit IRC (Ping timeout: 264 seconds)
1582020-12-23T10:05:20 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 272 seconds)
1592020-12-23T10:29:23 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
1602020-12-23T10:31:22 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1612020-12-23T10:33:29 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Client Quit)
1622020-12-23T10:38:32 *** justan0theruser <justan0theruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 268 seconds)
1632020-12-23T10:44:05 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 240 seconds)
1642020-12-23T11:11:55 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
1652020-12-23T11:17:37 *** rmstar <rmstar!~rmstar@209.95.36.151> has joined #bitcoin-core-dev
1662020-12-23T11:18:37 *** Santa41Langosh <Santa41Langosh!~Santa41La@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
1672020-12-23T11:23:24 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
1682020-12-23T11:23:32 *** Santa41Langosh <Santa41Langosh!~Santa41La@static.57.1.216.95.clients.your-server.de> has quit IRC (Ping timeout: 256 seconds)
1692020-12-23T11:34:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1702020-12-23T11:34:41 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/98de9eb1aa84...e669c3156ff8
1712020-12-23T11:34:42 <bitcoin-git> bitcoin/master fa957f8 MarcoFalke: test: Add race:SendZmqMessage tsan suppression
1722020-12-23T11:34:42 <bitcoin-git> bitcoin/master e669c31 MarcoFalke: Merge #20748: test: Add race:SendZmqMessage tsan suppression
1732020-12-23T11:34:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1742020-12-23T11:34:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1752020-12-23T11:34:56 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20748: test: Add race:SendZmqMessage tsan suppression (master...2012-ciSuppZmq) https://github.com/bitcoin/bitcoin/pull/20748
1762020-12-23T11:34:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1772020-12-23T11:36:00 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has quit IRC (Ping timeout: 265 seconds)
1782020-12-23T11:37:40 *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
1792020-12-23T11:45:28 *** justan0theruser <justan0theruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
1802020-12-23T11:57:27 *** zeromus1 <zeromus1!~zeromus@84.39.117.57> has quit IRC (Remote host closed the connection)
1812020-12-23T12:08:53 *** pergaminho <pergaminho!~Cleber@189.26.121.248> has joined #bitcoin-core-dev
1822020-12-23T12:09:13 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Ping timeout: 264 seconds)
1832020-12-23T12:24:20 *** vosechu <vosechu!~vosechu@195.140.213.38> has joined #bitcoin-core-dev
1842020-12-23T12:36:25 *** jonatack <jonatack!~jon@88.124.242.136> has quit IRC (Ping timeout: 240 seconds)
1852020-12-23T13:32:56 *** justan0theruser <justan0theruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 240 seconds)
1862020-12-23T13:36:17 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
1872020-12-23T13:36:18 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
1882020-12-23T13:36:18 *** vasild_ is now known as vasild
1892020-12-23T13:37:11 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
1902020-12-23T13:54:25 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Read error: Connection reset by peer)
1912020-12-23T13:54:55 *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
1922020-12-23T13:57:36 *** molz_ <molz_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
1932020-12-23T14:05:47 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has joined #bitcoin-core-dev
1942020-12-23T14:31:30 *** gleb <gleb!~gleb@178.150.137.228> has joined #bitcoin-core-dev
1952020-12-23T14:35:15 *** joerodgers <joerodgers!joerodgers@gateway/vpn/mullvad/joerodgers/x-62861712> has joined #bitcoin-core-dev
1962020-12-23T14:39:28 *** joerodgers <joerodgers!joerodgers@gateway/vpn/mullvad/joerodgers/x-62861712> has quit IRC (Client Quit)
1972020-12-23T14:54:09 *** jonatack <jonatack!~jon@88.124.242.136> has joined #bitcoin-core-dev
1982020-12-23T14:54:24 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
1992020-12-23T14:58:31 *** jonatack <jonatack!~jon@88.124.242.136> has quit IRC (Ping timeout: 246 seconds)
2002020-12-23T14:58:58 *** jonatack <jonatack!~jon@213.152.162.15> has joined #bitcoin-core-dev
2012020-12-23T14:59:12 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 272 seconds)
2022020-12-23T15:11:46 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
2032020-12-23T15:13:56 *** udecker <udecker!~udecker@173.243.88.22> has quit IRC (Quit: udecker)
2042020-12-23T15:17:07 *** pmuens <pmuens!5fde1c8f@aftr-95-222-28-143.unity-media.net> has joined #bitcoin-core-dev
2052020-12-23T15:20:32 *** pmuens <pmuens!5fde1c8f@aftr-95-222-28-143.unity-media.net> has left #bitcoin-core-dev
2062020-12-23T15:27:30 *** miketwen_ <miketwen_!~miketwent@ec2-54-235-98-1.compute-1.amazonaws.com> has joined #bitcoin-core-dev
2072020-12-23T15:30:56 *** miketwenty1 <miketwenty1!~miketwent@136.55.84.49> has quit IRC (Ping timeout: 240 seconds)
2082020-12-23T15:33:56 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 240 seconds)
2092020-12-23T15:58:02 *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
2102020-12-23T16:00:06 *** awesome_doge <awesome_doge!awesome-do@gateway/shell/matrix.org/x-rnzdvvnshecmqbvf> has quit IRC (Quit: Idle for 30+ days)
2112020-12-23T16:01:10 *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 246 seconds)
2122020-12-23T16:01:45 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2132020-12-23T16:01:45 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20753: rpc: Allow to ignore specific policy reject reasons (master...2012-policyRpcIgnore) https://github.com/bitcoin/bitcoin/pull/20753
2142020-12-23T16:01:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2152020-12-23T16:03:26 *** belcher_ is now known as belcher
2162020-12-23T16:08:26 *** Zenton <Zenton!~user@unaffiliated/vicenteh> has quit IRC (Read error: Connection reset by peer)
2172020-12-23T16:19:24 *** Zenton <Zenton!~user@unaffiliated/vicenteh> has joined #bitcoin-core-dev
2182020-12-23T16:31:49 *** IGHOR <IGHOR!~quassel@176.121.4.135> has quit IRC (Quit: No Ping reply in 180 seconds.)
2192020-12-23T16:33:06 *** IGHOR <IGHOR!~quassel@176.121.4.135> has joined #bitcoin-core-dev
2202020-12-23T16:34:22 *** kristapsk_ <kristapsk_!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
2212020-12-23T16:34:57 *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
2222020-12-23T16:37:38 *** DeanWeen <DeanWeen!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
2232020-12-23T16:38:25 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
2242020-12-23T16:45:19 *** Mercury_Vapor <Mercury_Vapor!~Mercury_V@174-082-166-092.res.spectrum.com> has joined #bitcoin-core-dev
2252020-12-23T16:47:45 *** Chlorine_Vapor <Chlorine_Vapor!~Mercury_V@174-082-166-092.res.spectrum.com> has quit IRC (Ping timeout: 265 seconds)
2262020-12-23T17:05:05 <luke-jr> MarcoFalke: you know #7533 is still maintained, right? could just reopen that..
2272020-12-23T17:05:07 <gribble> https://github.com/bitcoin/bitcoin/issues/7533 | RPC: sendrawtransaction: Allow the user to ignore/override specific rejections by luke-jr · Pull Request #7533 · bitcoin/bitcoin · GitHub
2282020-12-23T17:13:32 *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-ulfmeztuqwvevqbn> has joined #bitcoin-core-dev
2292020-12-23T17:20:05 <MarcoFalke> luke-jr: Sure, happy to repoen
2302020-12-23T17:20:29 <MarcoFalke> It was tagged "up for grabs", so I implemented a minimal patch that still achieves a goal
2312020-12-23T17:21:00 <MarcoFalke> you can rebase on top of mine, if you want
2322020-12-23T17:23:03 <luke-jr> MarcoFalke: at this point, I guess it might be more productive if I just review yours and get that in first
2332020-12-23T17:25:18 <luke-jr> just seemed strange to go about it that way *shrug*
2342020-12-23T17:26:52 <MarcoFalke> Yeah, I wasn't aware that 7533 is still maintained
2352020-12-23T17:33:21 <luke-jr> ah
2362020-12-23T17:45:56 <miketwen_> looking for some clarity here.. smartfee estimator is used by default for bitcoin node correct? if you are not synced with the blockchain it will use fallbackfee if enabled. correct? In terms of priority or the decision tree I'm wondering how this relates with paytxfee.. and then I would guess settxfee would be the same logic as paytxfee but replace paytxfee?
2372020-12-23T17:49:40 *** miketwen_ is now known as miketwenty1
2382020-12-23T17:51:54 <jonatack> miketwenty1: right, settxfee overrides (global) -paytxfee setting
2392020-12-23T17:52:36 *** Mercury_Vapor <Mercury_Vapor!~Mercury_V@174-082-166-092.res.spectrum.com> has quit IRC (Ping timeout: 240 seconds)
2402020-12-23T17:53:03 <jonatack> settxfee is per-wallet
2412020-12-23T17:53:27 <miketwenty1> settxfee overrides smartfee estimate?
2422020-12-23T17:53:41 *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:d16a:4949:3622:4cc0> has joined #bitcoin-core-dev
2432020-12-23T17:56:00 <jonatack> miketwenty1: yes iirc, see: ./src/bitcoin-cli help settxfee
2442020-12-23T17:57:38 <miketwenty1> jonatack: there are many flags for targets / fees and such.. has anyone made a diagram or decision tree on what takes priority over what by any chance?
2452020-12-23T17:57:55 <miketwenty1> in terms of what fee gets paid for a tx
2462020-12-23T17:59:46 *** pergaminho <pergaminho!~Cleber@189.26.121.248> has quit IRC (Quit: Saindo)
2472020-12-23T17:59:51 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
2482020-12-23T18:04:04 <jonatack> miketwenty1: i agree that it's a bit confusing. if you want to set an explicit fee rate, know that in 0.21 and master it is now possible to pass the fee rate (not absolute fee, but the fee rate) in sat/vB with all of the various send commands (fee_rate param, see the rpc help)
2492020-12-23T18:05:01 *** sishir <sishir!465dca45@cpe-70-93-202-69.natsow.res.rr.com> has joined #bitcoin-core-dev
2502020-12-23T18:05:12 *** sishir <sishir!465dca45@cpe-70-93-202-69.natsow.res.rr.com> has quit IRC (Remote host closed the connection)
2512020-12-23T18:05:14 <jonatack> miketwenty1: i've noted your suggestion to clarify this somewhere, thanks
2522020-12-23T18:25:40 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
2532020-12-23T18:34:14 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
2542020-12-23T18:34:32 *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has quit IRC (Ping timeout: 272 seconds)
2552020-12-23T18:34:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2562020-12-23T18:34:57 <bitcoin-git> [bitcoin] amitiuttarwar opened pull request #20755: [rpc] Remove deprecated fields from getpeerinfo (master...2020-12-getpeerinfo-deprecate) https://github.com/bitcoin/bitcoin/pull/20755
2572020-12-23T18:34:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2582020-12-23T18:36:35 *** Mercury_Vapor <Mercury_Vapor!~Mercury_V@174-082-158-108.res.spectrum.com> has joined #bitcoin-core-dev
2592020-12-23T18:53:49 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
2602020-12-23T18:56:02 *** xs1 <xs1!55677ca3@85.103.124.163> has joined #bitcoin-core-dev
2612020-12-23T18:56:46 *** xs1 <xs1!55677ca3@85.103.124.163> has quit IRC (Remote host closed the connection)
2622020-12-23T18:57:53 <jonatack> miketwenty1: i've begun improving the settxfee help and (new rpc) setfeerate help in #20391 and will look at updating both helps with more info
2632020-12-23T18:57:57 <gribble> https://github.com/bitcoin/bitcoin/issues/20391 | wallet: introduce setfeerate (an improved settxfee, in sat/vB) by jonatack · Pull Request #20391 · bitcoin/bitcoin · GitHub
2642020-12-23T18:59:17 <jonatack> and will do the same for estimatesmartfee and the (new rpc) estimatefeerate helps (the new RPCs are in sat/vB)
2652020-12-23T19:01:06 <jonatack> and work to make these RPCs more user-friendly and reassuring to use
2662020-12-23T19:27:00 *** promag_ <promag_!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
2672020-12-23T19:27:32 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
2682020-12-23T19:49:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2692020-12-23T19:49:03 <bitcoin-git> [bitcoin] amitiuttarwar opened pull request #20756: [doc] Add missing field (permissions) to the getpeerinfo help (master...2020-12-getpeerinfo-permissions) https://github.com/bitcoin/bitcoin/pull/20756
2702020-12-23T19:49:04 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2712020-12-23T19:58:50 <justinmoon> FYI: jonatack's docker-based gitian guide (https://github.com/jonatack/bitcoin-development/blob/master/gitian-building.md) is much easier to follow than the official virtualbox-based docs (https://github.com/bitcoin-core/docs)
2722020-12-23T20:06:06 <jonatack> thanks! it's based on fanquake's guide
2732020-12-23T20:22:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2742020-12-23T20:22:23 <bitcoin-git> [gui] hebasto opened pull request #161: Rework RPCConsole::banSelectedNode function (master...201223-ban) https://github.com/bitcoin-core/gui/pull/161
2752020-12-23T20:22:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2762020-12-23T20:22:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2772020-12-23T20:22:49 <bitcoin-git> [bitcoin] jonatack opened pull request #20757: doc: tor.md and -onlynet helpupdate -onlynet help in src/init.cpp (master...tor-md-doc-updates) https://github.com/bitcoin/bitcoin/pull/20757
2782020-12-23T20:22:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2792020-12-23T20:23:48 <jonatack> ^ when github opens the pull before you finished typing the title
2802020-12-23T20:48:29 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
2812020-12-23T20:52:39 *** jesseposner <jesseposner!~jp@2601:645:200:162f:b9d5:4819:405c:7ac5> has quit IRC (Quit: My Mac Mini has gone to sleep. ZZZzzzâ¦)
2822020-12-23T21:01:19 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
2832020-12-23T21:01:22 *** vosechu <vosechu!~vosechu@195.140.213.38> has quit IRC (Remote host closed the connection)
2842020-12-23T21:01:34 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
2852020-12-23T21:05:02 *** rh0nj <rh0nj!~rh0nj@88.99.167.175> has quit IRC (Remote host closed the connection)
2862020-12-23T21:05:49 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
2872020-12-23T21:06:08 *** rh0nj <rh0nj!~rh0nj@88.99.167.175> has joined #bitcoin-core-dev
2882020-12-23T21:06:29 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
2892020-12-23T21:11:32 *** TheV01d <TheV01d!thev01d@2001:19c0:1:801:851:ff00:1:6> has quit IRC (Ping timeout: 246 seconds)
2902020-12-23T21:11:48 *** thrasher` <thrasher`!~thrasher@173.209.42.7> has quit IRC (Ping timeout: 256 seconds)
2912020-12-23T21:12:00 *** TheV01d <TheV01d!thev01d@2001:19c0:1:801:851:ff00:1:6> has joined #bitcoin-core-dev
2922020-12-23T21:13:49 *** thrasher` <thrasher`!~thrasher@173.209.42.7> has joined #bitcoin-core-dev
2932020-12-23T21:21:06 *** vladan1 <vladan1!~vladan@84.39.116.180> has joined #bitcoin-core-dev
2942020-12-23T21:24:06 *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has joined #bitcoin-core-dev
2952020-12-23T21:25:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2962020-12-23T21:25:38 <bitcoin-git> [bitcoin] ajtowns opened pull request #20758: net-processing refactoring -- lose globals, move implementation details from .h to .cpp (master...202012-netproc-refactor) https://github.com/bitcoin/bitcoin/pull/20758
2972020-12-23T21:25:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2982020-12-23T21:59:01 *** mdrollette <mdrollette!~mdrollett@cpe-70-123-125-237.tx.res.rr.com> has quit IRC (Quit: bye)
2992020-12-23T22:15:15 *** pbarry_ <pbarry_!~textual@2601:644:8b00:3800:f098:86ee:2e57:2479> has joined #bitcoin-core-dev
3002020-12-23T22:17:40 *** Asbestos_Vapor <Asbestos_Vapor!~Mercury_V@174-082-158-108.res.spectrum.com> has joined #bitcoin-core-dev
3012020-12-23T22:19:10 *** Mercury_Vapor <Mercury_Vapor!~Mercury_V@174-082-158-108.res.spectrum.com> has quit IRC (Ping timeout: 246 seconds)
3022020-12-23T22:24:08 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
3032020-12-23T22:24:38 *** pbarry_ <pbarry_!~textual@2601:644:8b00:3800:f098:86ee:2e57:2479> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
3042020-12-23T22:25:02 *** Lightsword <Lightsword!~Lightswor@2604:a880:1:20::1d3:9001> has joined #bitcoin-core-dev
3052020-12-23T22:27:29 *** Lightsword <Lightsword!~Lightswor@2604:a880:1:20::1d3:9001> has quit IRC (Client Quit)
3062020-12-23T22:28:33 *** pbarry_ <pbarry_!~textual@2601:644:8b00:3800:f098:86ee:2e57:2479> has joined #bitcoin-core-dev
3072020-12-23T22:29:37 *** Lightsword <Lightsword!~Lightswor@2604:a880:1:20::1d3:9001> has joined #bitcoin-core-dev
3082020-12-23T22:32:13 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
3092020-12-23T23:02:22 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
3102020-12-23T23:32:04 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
3112020-12-23T23:33:43 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
3122020-12-23T23:33:57 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
3132020-12-23T23:35:52 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Remote host closed the connection)
3142020-12-23T23:39:02 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
3152020-12-23T23:46:43 *** pbarry_ <pbarry_!~textual@2601:644:8b00:3800:f098:86ee:2e57:2479> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
3162020-12-23T23:51:56 *** pbarry_ <pbarry_!~textual@2601:644:8b00:3800:f098:86ee:2e57:2479> has joined #bitcoin-core-dev