12020-12-28T00:21:01  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Ping timeout: 272 seconds)
  22020-12-28T00:29:41  *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has quit IRC (Quit: Find me in #TheHolyRoger or https://theholyroger.com)
  32020-12-28T00:29:57  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 260 seconds)
  42020-12-28T00:30:58  *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has joined #bitcoin-core-dev
  52020-12-28T00:36:48  *** Wolfy87 <Wolfy87!~Wolfy87@5.253.204.132> has joined #bitcoin-core-dev
  62020-12-28T00:46:34  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
  72020-12-28T01:07:28  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
  82020-12-28T01:08:03  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:f14e:453d:14dc:75b2:51ff> has joined #bitcoin-core-dev
  92020-12-28T01:21:28  *** Klox <Klox!~Klox@c-24-1-131-19.hsd1.il.comcast.net> has quit IRC (Ping timeout: 256 seconds)
 102020-12-28T01:28:16  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 256 seconds)
 112020-12-28T01:28:31  *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
 122020-12-28T01:31:19  *** jeremyrubin <jeremyrubin!~jr@2607:fb90:46e:87c3:300e:3023:6b28:256b> has joined #bitcoin-core-dev
 132020-12-28T01:35:10  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Read error: Connection reset by peer)
 142020-12-28T01:35:25  *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has joined #bitcoin-core-dev
 152020-12-28T01:36:23  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
 162020-12-28T01:36:24  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
 172020-12-28T01:36:27  *** vasild_ is now known as vasild
 182020-12-28T01:40:52  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Remote host closed the connection)
 192020-12-28T01:41:27  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
 202020-12-28T01:51:38  *** jeremyrubin <jeremyrubin!~jr@2607:fb90:46e:87c3:300e:3023:6b28:256b> has quit IRC (Ping timeout: 264 seconds)
 212020-12-28T01:52:16  *** rhavar_ <rhavar_!uid237883@gateway/web/irccloud.com/x-bqjwmkompachgmex> has joined #bitcoin-core-dev
 222020-12-28T01:56:36  *** horseofanotherco <horseofanotherco!44abb378@68.171.179.120> has joined #bitcoin-core-dev
 232020-12-28T01:57:07  *** kexkey <kexkey!~kexkey@static-198-54-132-158.cust.tzulo.com> has quit IRC (Quit: Do, don't don't)
 242020-12-28T01:58:02  *** horseofanotherco <horseofanotherco!44abb378@68.171.179.120> has quit IRC (Remote host closed the connection)
 252020-12-28T01:58:50  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
 262020-12-28T02:06:34  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
 272020-12-28T02:08:08  *** jeremyrubin <jeremyrubin!~jr@2607:fb90:46e:87c3:300e:3023:6b28:256b> has joined #bitcoin-core-dev
 282020-12-28T02:13:50  *** jeremyrubin <jeremyrubin!~jr@2607:fb90:46e:87c3:300e:3023:6b28:256b> has quit IRC (Ping timeout: 264 seconds)
 292020-12-28T02:14:19  *** jonatack <jonatack!~jon@134.19.179.235> has quit IRC (Ping timeout: 246 seconds)
 302020-12-28T02:18:43  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
 312020-12-28T02:32:05  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
 322020-12-28T02:53:34  *** jesseposner <jesseposner!~jp@2601:645:200:162f:b96c:c368:5345:d4e5> has joined #bitcoin-core-dev
 332020-12-28T03:36:43  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Ping timeout: 240 seconds)
 342020-12-28T03:37:35  *** dviola <dviola!~diego@unaffiliated/dviola> has quit IRC (Read error: Connection reset by peer)
 352020-12-28T03:45:33  *** dermoth_ <dermoth_!~dermoth@unaffiliated/dermoth> has joined #bitcoin-core-dev
 362020-12-28T03:45:34  *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has quit IRC (Ping timeout: 268 seconds)
 372020-12-28T03:45:53  *** dermoth_ is now known as dermoth
 382020-12-28T03:48:46  *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has quit IRC (Quit: pinheadmz)
 392020-12-28T03:59:23  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
 402020-12-28T04:19:35  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
 412020-12-28T04:26:20  *** StopAndDecrypt <StopAndDecrypt!~StopAndDe@unaffiliated/stopanddecrypt> has joined #bitcoin-core-dev
 422020-12-28T04:56:45  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:f14e:453d:14dc:75b2:51ff> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 432020-12-28T05:26:29  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:f14e:453d:14dc:75b2:51ff> has joined #bitcoin-core-dev
 442020-12-28T05:27:11  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
 452020-12-28T05:27:23  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
 462020-12-28T05:30:53  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
 472020-12-28T05:31:17  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
 482020-12-28T05:33:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 492020-12-28T05:33:34  <bitcoin-git> [bitcoin] fanquake closed pull request #19995: log: Mitigate disk filling attacks by temporarily rate limiting LogPrintf(…) (master...mitigate-log-disk-filling-attacks) https://github.com/bitcoin/bitcoin/pull/19995
 502020-12-28T05:33:35  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 512020-12-28T05:36:58  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
 522020-12-28T05:57:30  *** ossifrage <ossifrage!~ossifrage@unaffiliated/ossifrage> has quit IRC (Remote host closed the connection)
 532020-12-28T06:03:16  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
 542020-12-28T06:08:27  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
 552020-12-28T06:12:28  *** jeremyrubin <jeremyrubin!~jr@2607:fb90:460:fdaf:300e:3023:6b28:256b> has joined #bitcoin-core-dev
 562020-12-28T06:15:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 572020-12-28T06:15:17  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0e1b57b4bb63...4a8f4ac4fc07
 582020-12-28T06:15:18  <bitcoin-git> bitcoin/master faccf8b MarcoFalke: refactor: Enable -Wswitch for FeeEstimateHorizon
 592020-12-28T06:15:18  <bitcoin-git> bitcoin/master 4a8f4ac fanquake: Merge #20771: refactor: Enable -Wswitch for FeeEstimateHorizon
 602020-12-28T06:15:26  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 612020-12-28T06:15:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 622020-12-28T06:15:46  <bitcoin-git> [bitcoin] fanquake merged pull request #20771: refactor: Enable -Wswitch for FeeEstimateHorizon (master...2012-WswitchFeeEstimateHorizon) https://github.com/bitcoin/bitcoin/pull/20771
 632020-12-28T06:15:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 642020-12-28T06:35:56  *** theChief <theChief!~Mohamed@bb121-6-182-56.singnet.com.sg> has joined #bitcoin-core-dev
 652020-12-28T06:37:15  *** theChief <theChief!~Mohamed@bb121-6-182-56.singnet.com.sg> has quit IRC (Client Quit)
 662020-12-28T06:38:05  *** theChief <theChief!~Mohamed@bb121-6-182-56.singnet.com.sg> has joined #bitcoin-core-dev
 672020-12-28T06:42:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 682020-12-28T06:42:12  <bitcoin-git> [bitcoin] fanquake opened pull request #20781: fuzz: remove no-longer-necessary packages from fuzzbuzz config (master...cleanup_fuzzbuzz) https://github.com/bitcoin/bitcoin/pull/20781
 692020-12-28T06:42:14  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 702020-12-28T07:02:36  *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-uyrfwldlnfrephmz> has quit IRC (Quit: Connection closed for inactivity)
 712020-12-28T07:21:16  *** rhavar_ <rhavar_!uid237883@gateway/web/irccloud.com/x-bqjwmkompachgmex> has quit IRC (Quit: Connection closed for inactivity)
 722020-12-28T07:44:39  *** jadi <jadi!~jadi@91.184.66.255> has joined #bitcoin-core-dev
 732020-12-28T07:46:14  *** jeremyrubin <jeremyrubin!~jr@2607:fb90:460:fdaf:300e:3023:6b28:256b> has quit IRC (Ping timeout: 264 seconds)
 742020-12-28T07:46:19  *** hidrodo <hidrodo!76c811dd@118.200.17.221> has joined #bitcoin-core-dev
 752020-12-28T07:46:32  *** jakesyl <jakesyl!sid56879@gateway/web/irccloud.com/x-ohjdexvtbvfupplm> has quit IRC (Read error: Connection reset by peer)
 762020-12-28T07:46:38  *** jeremyrubin <jeremyrubin!~jr@2607:fb90:46c:8e30:300e:3023:6b28:256b> has joined #bitcoin-core-dev
 772020-12-28T07:47:24  *** jakesyl <jakesyl!sid56879@gateway/web/irccloud.com/x-xxyfbhfpwravtvho> has joined #bitcoin-core-dev
 782020-12-28T07:48:04  *** wallet42___ <wallet42___!sid154231@gateway/web/irccloud.com/x-nsfflmahewctnkwz> has quit IRC (Ping timeout: 240 seconds)
 792020-12-28T07:49:03  *** wallet42___ <wallet42___!sid154231@gateway/web/irccloud.com/x-rqajlfifxlipbvar> has joined #bitcoin-core-dev
 802020-12-28T07:52:43  *** hidrodo <hidrodo!76c811dd@118.200.17.221> has quit IRC (Remote host closed the connection)
 812020-12-28T08:38:52  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
 822020-12-28T08:39:07  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
 832020-12-28T08:41:10  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:f14e:453d:14dc:75b2:51ff> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 842020-12-28T08:49:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 852020-12-28T08:49:13  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4a8f4ac4fc07...ddbf7a6f5051
 862020-12-28T08:49:14  <bitcoin-git> bitcoin/master 5e0dedb Hennadii Stepanov: build: Define .INTERMEDIATE target once only
 872020-12-28T08:49:14  <bitcoin-git> bitcoin/master ddbf7a6 fanquake: Merge #20684: build: Define .INTERMEDIATE target once only
 882020-12-28T08:49:16  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 892020-12-28T08:49:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 902020-12-28T08:49:33  <bitcoin-git> [bitcoin] fanquake merged pull request #20684: build: Define .INTERMEDIATE target once only (master...201217-target) https://github.com/bitcoin/bitcoin/pull/20684
 912020-12-28T08:49:34  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 922020-12-28T08:53:06  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Quit: Leaving)
 932020-12-28T09:09:07  *** udecker <udecker!~udecker@173.243.88.22> has joined #bitcoin-core-dev
 942020-12-28T09:23:17  *** udecker <udecker!~udecker@173.243.88.22> has quit IRC (Quit: udecker)
 952020-12-28T09:27:23  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
 962020-12-28T09:28:24  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
 972020-12-28T09:43:37  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
 982020-12-28T09:45:48  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
 992020-12-28T10:09:11  *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
1002020-12-28T10:20:52  *** dr-orlovsky <dr-orlovsky!~dr-orlovs@31.14.40.19> has quit IRC (Ping timeout: 260 seconds)
1012020-12-28T10:35:03  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Ping timeout: 240 seconds)
1022020-12-28T10:39:53  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:f14e:453d:14dc:75b2:51ff> has joined #bitcoin-core-dev
1032020-12-28T10:42:20  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
1042020-12-28T10:43:50  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1052020-12-28T10:54:33  *** dr-orlovsky <dr-orlovsky!~dr-orlovs@31.14.40.19> has joined #bitcoin-core-dev
1062020-12-28T11:05:09  *** prayank <prayank!~andr0irc@2402:8100:206b:9d05:c010:2b88:25e4:ed6e> has joined #bitcoin-core-dev
1072020-12-28T11:06:11  <prayank> Can someone review this PR: https://github.com/bitcoin/bitcoin/pull/20741 and maybe merge it if 2-3 ACKs are enough for this change?
1082020-12-28T11:06:31  <prayank> There is no code. Only adding some information to docs.
1092020-12-28T11:07:26  <prayank> It's an alternative to https://github.com/bitcoin/bitcoin/pull/20393 which I think is not the best solution
1102020-12-28T11:14:26  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC ()
1112020-12-28T11:17:48  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1122020-12-28T11:18:32  *** Terence17Jerde <Terence17Jerde!~Terence17@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
1132020-12-28T11:25:32  *** Terence17Jerde <Terence17Jerde!~Terence17@static.57.1.216.95.clients.your-server.de> has quit IRC (Ping timeout: 256 seconds)
1142020-12-28T11:27:05  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Quit: WeeChat 2.9)
1152020-12-28T11:30:04  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
1162020-12-28T11:44:47  *** Wolfy87 <Wolfy87!~Wolfy87@5.253.204.132> has quit IRC (Remote host closed the connection)
1172020-12-28T12:05:09  *** coppro <coppro!~coppro@185.204.1.185> has joined #bitcoin-core-dev
1182020-12-28T12:09:10  *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
1192020-12-28T12:26:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1202020-12-28T12:26:52  <bitcoin-git> [bitcoin] multisignature opened pull request #20784: doc: Typos in test README (master...master) https://github.com/bitcoin/bitcoin/pull/20784
1212020-12-28T12:26:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1222020-12-28T12:28:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1232020-12-28T12:28:02  <bitcoin-git> [bitcoin] multisignature closed pull request #20774: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/20774
1242020-12-28T12:28:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1252020-12-28T12:29:01  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1262020-12-28T12:29:02  <bitcoin-git> [gui] jonatack closed pull request #162: Add network to peers window and peer details (master...display-peer-networks) https://github.com/bitcoin-core/gui/pull/162
1272020-12-28T12:29:03  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1282020-12-28T12:29:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1292020-12-28T12:29:37  <bitcoin-git> [gui] jonatack closed pull request #163: Peer details: replace Direction with Connection Type (master...display-peer-conn-types) https://github.com/bitcoin-core/gui/pull/163
1302020-12-28T12:29:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1312020-12-28T12:33:06  *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
1322020-12-28T12:33:27  *** jonatack <jonatack!~jon@88.124.242.136> has joined #bitcoin-core-dev
1332020-12-28T12:33:49  *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
1342020-12-28T12:49:44  <michaelfolkson> prayank: I've reviewed. I'm a touch confused though on what the comment is saying. You can explain here rather than on the PR if you'd like
1352020-12-28T12:50:00  <michaelfolkson> I'm probably missing context
1362020-12-28T12:52:23  *** pergaminho <pergaminho!~Cleber@189.26.121.248> has joined #bitcoin-core-dev
1372020-12-28T12:53:25  <prayank> I hope you read the conversation in issue: https://github.com/bitcoin/bitcoin/issues/20128
1382020-12-28T13:05:40  <michaelfolkson> I looked at it. It appears reviewers were confused with the motivation in that issue too
1392020-12-28T13:07:50  <michaelfolkson> Just a pointer, if you are going to ask people to review, writing things like "I hope you did this...." isn't the best way to succeed in getting that review
1402020-12-28T13:08:26  *** prayank <prayank!~andr0irc@2402:8100:206b:9d05:c010:2b88:25e4:ed6e> has quit IRC (Ping timeout: 264 seconds)
1412020-12-28T13:13:59  *** prayank <prayank!~andr0irc@2402:8100:206b:9d05:9d48:3132:568a:cf31> has joined #bitcoin-core-dev
1422020-12-28T13:14:08  <prayank> michaelfolkson: I've replied to your questions in the PR
1432020-12-28T13:16:51  <michaelfolkson> Ok thanks. Probably better to start discussing a PoC here than on a PR for documentation if you have one
1442020-12-28T13:19:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1452020-12-28T13:19:12  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ddbf7a6f5051...7f9ae870115e
1462020-12-28T13:19:13  <bitcoin-git> bitcoin/master 1ef2138 fanquake: lint: run mypy over contrib/devtools
1472020-12-28T13:19:13  <bitcoin-git> bitcoin/master 7f9ae87 Wladimir J. van der Laan: Merge #20451: lint: run mypy over contrib/devtools
1482020-12-28T13:19:15  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1492020-12-28T13:19:32  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1502020-12-28T13:19:32  <bitcoin-git> [bitcoin] laanwj merged pull request #20451: lint: run mypy over contrib/devtools (master...contrib_devtools_mypy) https://github.com/bitcoin/bitcoin/pull/20451
1512020-12-28T13:19:33  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1522020-12-28T13:29:26  *** prayank <prayank!~andr0irc@2402:8100:206b:9d05:9d48:3132:568a:cf31> has quit IRC (Ping timeout: 264 seconds)
1532020-12-28T13:31:05  *** prayank <prayank!~andr0irc@2409:4053:2196:bd29:796e:9270:5347:3e40> has joined #bitcoin-core-dev
1542020-12-28T13:39:23  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
1552020-12-28T13:50:17  *** jeremyrubin <jeremyrubin!~jr@2607:fb90:46c:8e30:300e:3023:6b28:256b> has quit IRC (Ping timeout: 260 seconds)
1562020-12-28T13:51:00  *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
1572020-12-28T13:51:14  *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
1582020-12-28T13:56:10  *** prayank <prayank!~andr0irc@2409:4053:2196:bd29:796e:9270:5347:3e40> has quit IRC (Read error: Connection reset by peer)
1592020-12-28T13:57:50  *** glozow <glozow!uid453516@gateway/web/irccloud.com/x-krdsowlryxrnjbwu> has joined #bitcoin-core-dev
1602020-12-28T14:05:36  *** Murch <Murch!murch@2a01:4f8:141:1272::2> has joined #bitcoin-core-dev
1612020-12-28T14:08:20  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1622020-12-28T14:08:21  <bitcoin-git> [bitcoin] SkybuckFlying opened pull request #20785: Changed (char **) to (const char **) for VS2019 (master...master) https://github.com/bitcoin/bitcoin/pull/20785
1632020-12-28T14:08:22  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1642020-12-28T14:11:33  *** jadi <jadi!~jadi@91.184.66.255> has quit IRC (Ping timeout: 260 seconds)
1652020-12-28T14:25:43  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has quit IRC (Ping timeout: 240 seconds)
1662020-12-28T14:26:38  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
1672020-12-28T14:31:25  *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has joined #bitcoin-core-dev
1682020-12-28T14:33:23  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has quit IRC (Ping timeout: 240 seconds)
1692020-12-28T14:34:25  *** jonatack <jonatack!~jon@88.124.242.136> has quit IRC (Ping timeout: 264 seconds)
1702020-12-28T14:34:33  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has joined #bitcoin-core-dev
1712020-12-28T14:34:51  *** jonatack <jonatack!~jon@213.152.162.10> has joined #bitcoin-core-dev
1722020-12-28T14:45:30  *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
1732020-12-28T14:45:45  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1742020-12-28T14:45:45  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #20785: Changed (char **) to (const char **) for VS2019 (master...master) https://github.com/bitcoin/bitcoin/pull/20785
1752020-12-28T14:45:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1762020-12-28T14:46:04  *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
1772020-12-28T14:55:39  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
1782020-12-28T14:59:43  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1792020-12-28T14:59:44  <bitcoin-git> [bitcoin] jonatack closed pull request #20779: net, rpc, gui: add network to peers window and peer details (master...display-peer-networks) https://github.com/bitcoin/bitcoin/pull/20779
1802020-12-28T14:59:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1812020-12-28T15:03:17  <jonatack> too much nonsense and complication with transversal changes between the gui and the main repo. i tried to follow the contributing guide, but apparently it has to be more complicated, with preliminary pulls in one gating changes in the other. nah.
1822020-12-28T15:05:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1832020-12-28T15:05:49  <bitcoin-git> [bitcoin] jonatack closed pull request #20778: net, p2p, gui: replace direction with connection type in gui peer details window (master...display-peer-conn-types) https://github.com/bitcoin/bitcoin/pull/20778
1842020-12-28T15:05:49  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1852020-12-28T15:08:36  <jonatack> I understand the reasons for splitting the repos, but unreasonably complicating things for contributions to the gui repo to the point where opening multiple pulls and reading between tea leaves in the CONTRIBUTING guide and still being wrong surely wasn't one of them.
1862020-12-28T15:12:54  <jonatack> For simple changes like those pulls, too much bandwidth is taken by this and it's a waste of bandwidth.
1872020-12-28T15:14:59  <michaelfolkson> I think the separation between GUI and non GUI makes sense. Though I don't know what happened in this particular example. Why can't the PR in the non-GUI repo state as a motivation a future change to the GUI. And then once that is merged, open a PR in the GUI for the GUI specific changes
1882020-12-28T15:15:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1892020-12-28T15:15:39  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20786: net: [refactor] Prefer integral types in CNodeStats (master...2012-net) https://github.com/bitcoin/bitcoin/pull/20786
1902020-12-28T15:15:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1912020-12-28T15:17:03  <michaelfolkson> Sounds more of a "I am used to things how used to be done" rather than any new problem. Reviewers in the non-GUI repo will need to get used to reviewing changes that are lining up a future PR in the GUI repo
1922020-12-28T15:17:44  <michaelfolkson> But maybe I'm missing something
1932020-12-28T15:25:59  <michaelfolkson> I get it is still confusing and there are teething problems which is frustrating
1942020-12-28T15:29:27  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:f14e:453d:14dc:75b2:51ff> has quit IRC (Ping timeout: 260 seconds)
1952020-12-28T15:30:35  <jonatack> michaelfolkson: per the contributing guide, changes to the gui that are also transversal are to be opened in the main repo. the pulls were originally gui code only, to avoid this issue. reviewers asked for transversal changes with the main repo. i followed the guide and opened second pulls in the main repo. nope, new rule: you need to open one part of the them in the main repo, hope
1962020-12-28T15:30:37  <jonatack> someone will understand why it's a good idea and review it (attracting review is hard enough), then open a second pull for the gui-only changes in the gui repo. for simple changes like these, that seems unreasonably complicating things and a waste of bandwidth.
1972020-12-28T15:32:15  <jonatack> maybe if a maintainer does it, it can work, but for simple contributors it's a large increase in difficulty in making gui changes that also touch the main repo.
1982020-12-28T15:33:22  <michaelfolkson> For a traversal change the code obviously needs to be written for both the GUI and the main repo at some stage. So it isn't more code, it is just a question of process for how you get review.
1992020-12-28T15:34:39  <michaelfolkson> Go to GUI for a design/concept ACK on a visual. Go back to the non-GUI repo for an ACK on the non-GUI code. Then back to the GUI repo for review of the GUI code.
2002020-12-28T15:34:46  <jonatack> I think the contributing guide needs to be updated if this is the complicated new process to follow.
2012020-12-28T15:34:48  <MarcoFalke> I can see the point that opening two pulls is a slightly heavier process and may delay things a bit, but it shouldn't cost more review. 6 commits are still to be reviewed. It shouldn't matter if two are in main and 4 in gui or all in one.
2022020-12-28T15:36:20  <michaelfolkson> Right, that's what it seems like to me too. The bottleneck is always the actual review and getting the ACKs. Slighty heavier as you say but the biggest problem is getting the actual review
2032020-12-28T15:36:28  <jonatack> MarcoFalke: I think leaving the pulls in the gui repo was fine in this case (simple, non-dangerous changes).
2042020-12-28T15:37:11  <MarcoFalke> Yeah, maybe relaxing the rules a bit to allow simple refactors also in the gui repo might be a good solution
2052020-12-28T15:37:12  <jonatack> ISTM that getting review twice is at least twice as hard, especially for gui-motivated changes in the main repo.
2062020-12-28T15:37:35  <MarcoFalke> I was hoping that the cross-repo pulls aren't too numerous for it to matter much
2072020-12-28T15:37:56  <jonatack> This seems to be one of the first times iirc
2082020-12-28T15:46:40  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
2092020-12-28T15:47:07  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
2102020-12-28T16:00:39  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2112020-12-28T16:00:39  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20787: Use C++17 std::array deduction for OUTPUT_TYPES, ALL_FEE_ESTIMATE_HORIZONS (master...2012-WswitchFeeEstimateHorizon) https://github.com/bitcoin/bitcoin/pull/20787
2122020-12-28T16:00:40  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2132020-12-28T16:03:27  *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
2142020-12-28T16:03:43  *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
2152020-12-28T16:12:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2162020-12-28T16:12:52  <bitcoin-git> [bitcoin] vasild opened pull request #20788: net: add RAII socket and use it instead of bare SOCKET (master...sock) https://github.com/bitcoin/bitcoin/pull/20788
2172020-12-28T16:12:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2182020-12-28T16:55:48  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC ()
2192020-12-28T16:57:33  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
2202020-12-28T17:10:46  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
2212020-12-28T17:18:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2222020-12-28T17:18:46  <bitcoin-git> [bitcoin] multisignature closed pull request #20784: doc: Typos in test README (master...master) https://github.com/bitcoin/bitcoin/pull/20784
2232020-12-28T17:18:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2242020-12-28T17:26:49  *** Keele <Keele!~keele@88-115-110-150.elisa-laajakaista.fi> has joined #bitcoin-core-dev
2252020-12-28T17:30:57  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
2262020-12-28T17:39:58  *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
2272020-12-28T17:40:42  *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
2282020-12-28T17:41:49  *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
2292020-12-28T17:42:02  *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
2302020-12-28T17:46:50  *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
2312020-12-28T17:47:34  *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
2322020-12-28T18:14:31  *** joelklabo <joelklabo!~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
2332020-12-28T18:20:36  *** kexkey <kexkey!~kexkey@static-198-54-132-110.cust.tzulo.com> has joined #bitcoin-core-dev
2342020-12-28T18:21:40  *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has quit IRC (Read error: Connection reset by peer)
2352020-12-28T18:22:40  *** pinheadmz <pinheadmz!~pinheadmz@71.190.30.138> has joined #bitcoin-core-dev
2362020-12-28T18:28:09  *** kristapsk_ <kristapsk_!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
2372020-12-28T18:29:03  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Ping timeout: 240 seconds)
2382020-12-28T18:29:56  *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
2392020-12-28T18:30:12  *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
2402020-12-28T18:38:21  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Remote host closed the connection)
2412020-12-28T18:38:21  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has quit IRC (Remote host closed the connection)
2422020-12-28T18:38:22  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has quit IRC (Remote host closed the connection)
2432020-12-28T18:38:22  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
2442020-12-28T18:38:22  *** kristapsk_ <kristapsk_!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Write error: Broken pipe)
2452020-12-28T18:38:22  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has quit IRC (Remote host closed the connection)
2462020-12-28T18:38:22  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has quit IRC (Write error: Broken pipe)
2472020-12-28T18:38:22  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Write error: Broken pipe)
2482020-12-28T18:38:56  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has joined #bitcoin-core-dev
2492020-12-28T18:39:23  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
2502020-12-28T18:41:20  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
2512020-12-28T18:44:16  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
2522020-12-28T18:45:17  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has joined #bitcoin-core-dev
2532020-12-28T18:47:47  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
2542020-12-28T18:49:35  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
2552020-12-28T18:54:06  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has joined #bitcoin-core-dev
2562020-12-28T18:54:09  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
2572020-12-28T18:54:16  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
2582020-12-28T18:54:17  *** pingwindyktator <pingwindyktator!~pingwindy@pingwindyktator.me> has quit IRC (Quit: The Lounge - https://thelounge.chat)
2592020-12-28T18:54:30  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
2602020-12-28T18:54:41  *** pingwindyktator <pingwindyktator!~pingwindy@pingwindyktator.me> has joined #bitcoin-core-dev
2612020-12-28T19:02:37  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Remote host closed the connection)
2622020-12-28T19:02:41  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
2632020-12-28T19:02:59  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
2642020-12-28T19:03:09  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
2652020-12-28T19:15:34  <wumpus> jonatack: fwiw i think that's a great addition and wouldn't have minded reviewing it
2662020-12-28T19:15:59  *** quijote <quijote!~dqx@unaffiliated/dqx> has joined #bitcoin-core-dev
2672020-12-28T19:16:12  *** quijote is now known as Guest21778
2682020-12-28T19:16:49  *** joelklabo <joelklabo!~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: My iMac has gone to sleep. ZZZzzz…)
2692020-12-28T19:21:27  <wumpus> I don't want to get involved in gui design decisions I just can't do that, just too subjective and arbitrary, but adding useful information to the debug window is something that shouldn't be too difficult?
2702020-12-28T19:25:24  *** andytoshi <andytoshi!~apoelstra@unaffiliated/andytoshi> has quit IRC (Quit: leaving)
2712020-12-28T19:26:14  *** andytoshi <andytoshi!~apoelstra@wpsoftware.net> has joined #bitcoin-core-dev
2722020-12-28T19:28:44  <luke-jr> hmm, on that note I wonder if "tailing" the debug log would be a good feature for the GUI
2732020-12-28T19:29:40  <wumpus> i think a live debug log view would be awesome
2742020-12-28T19:30:40  <wumpus> though implementing it in a way that is efficient (doesn't end up logging everything to memory) is non-trivial
2752020-12-28T19:32:39  <wumpus> qt's build in stuff is really bad at handling large amounts of data in general, this is why the current 'open log' button forks out to an external editor
2762020-12-28T19:32:42  <luke-jr> well, if it only shows the last N lines, it's probably not hard
2772020-12-28T19:32:57  <luke-jr> adding a scrollbar would ofc :P
2782020-12-28T19:36:18  <wumpus> right, 'subscribe to log messages and keep the last 10' or so would be easy enough and maybe useful enough
2792020-12-28T19:37:44  <wumpus> or, last 1000, it's not like messages take that much memory :)
2802020-12-28T19:42:40  *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
2812020-12-28T19:43:23  *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
2822020-12-28T19:45:16  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 240 seconds)
2832020-12-28T19:45:42  *** jeremyrubin <jeremyrubin!~jr@2607:fb90:8062:c5e6:300e:3023:6b28:256b> has joined #bitcoin-core-dev
2842020-12-28T19:54:08  <phantomcircuit> wumpus, i've seen text boxes that compress the text that isn't being actively displayed but i cant remember anything about them except the concept
2852020-12-28T19:56:02  <wumpus> phantomcircuit: it's definitely possible to do things like that, just qt doesn't do it by default, if you want anything smart you have to implement it yourself
2862020-12-28T20:06:02  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
2872020-12-28T20:13:42  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
2882020-12-28T20:14:06  <jonatack> wumpus: yes, and both pulls were reviewed, finished, collaborated together with hebasto, had acks... but then it unraveled with the process, I followed the instructions in contributing.md but it seems to needs updating, and the new process is arduous for contributors without the social capital to garner review on two repos for one change.
2892020-12-28T20:14:47  <jonatack> (the new new process, not the new process :D)
2902020-12-28T20:18:16  <jonatack> it's hard enough to garner review in one repo alone
2912020-12-28T20:20:08  <jonatack> simple changes like that aren't worth it imho. i've resolved to concentrate on more interesting things that are worth doing that for.
2922020-12-28T20:24:42  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has joined #bitcoin-core-dev
2932020-12-28T20:34:37  *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
2942020-12-28T20:37:25  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 240 seconds)
2952020-12-28T20:39:03  <luke-jr> phantomcircuit: it would make more sense if we're goibng to that complexity, to just load it off disk as needed
2962020-12-28T20:50:03  *** pergaminho <pergaminho!~Cleber@189.26.121.248> has quit IRC (Quit: Saindo)
2972020-12-28T21:03:37  *** Aaronvan_ <Aaronvan_!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
2982020-12-28T21:04:16  <wumpus> jonatack: I hadn't noticed it, if you'd told me I'd have merged it
2992020-12-28T21:05:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3002020-12-28T21:05:53  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20789: fuzz: Rework strong and weak net enum fuzzing (master...2012-fuzzRefactor) https://github.com/bitcoin/bitcoin/pull/20789
3012020-12-28T21:05:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3022020-12-28T21:06:36  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 240 seconds)
3032020-12-28T21:07:08  <wumpus> jonatack: for changes that both involve invasive changes to the GUI and to the core code, it's probably better to do it in phases, but this isn't one of them
3042020-12-28T21:10:22  *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
3052020-12-28T21:11:12  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
3062020-12-28T21:14:12  *** Aaronvan_ <Aaronvan_!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 260 seconds)
3072020-12-28T21:20:05  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 240 seconds)
3082020-12-28T21:23:06  *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
3092020-12-28T21:32:50  *** joelklabo <joelklabo!~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
3102020-12-28T21:38:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3112020-12-28T21:38:59  <bitcoin-git> [bitcoin] jonatack opened pull request #20790: policy: create CFeeRate::FromSatB and FromBtcKb named ctors (master...CFeeRate-named-constructors) https://github.com/bitcoin/bitcoin/pull/20790
3122020-12-28T21:39:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3132020-12-28T21:42:44  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3142020-12-28T21:42:44  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/7f9ae870115e...e3dd0a56cfa7
3152020-12-28T21:42:45  <bitcoin-git> bitcoin/master 5370533 Amiti Uttarwar: [rpc] Remove deprecated "addnode" field from getpeerinfo
3162020-12-28T21:42:45  <bitcoin-git> bitcoin/master 094c3be Amiti Uttarwar: [rpc] Remove deprecated "banscore" field from getpeerinfo
3172020-12-28T21:42:46  <bitcoin-git> bitcoin/master b1a936d Amiti Uttarwar: [rpc] Remove deprecated "whitelisted" field from getpeerinfo
3182020-12-28T21:42:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3192020-12-28T21:43:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3202020-12-28T21:43:04  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20755: [rpc] Remove deprecated fields from getpeerinfo (master...2020-12-getpeerinfo-deprecate) https://github.com/bitcoin/bitcoin/pull/20755
3212020-12-28T21:43:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3222020-12-28T21:45:16  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3232020-12-28T21:45:16  <bitcoin-git> [gui] jonatack reopened pull request #163: Peer details: replace Direction with Connection Type (master...display-peer-conn-types) https://github.com/bitcoin-core/gui/pull/163
3242020-12-28T21:45:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3252020-12-28T21:46:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3262020-12-28T21:46:46  <bitcoin-git> [gui] jonatack reopened pull request #162: Add network to peers window and peer details (master...display-peer-networks) https://github.com/bitcoin-core/gui/pull/162
3272020-12-28T21:46:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3282020-12-28T21:47:28  *** ChaNn3L <ChaNn3L!~acid~335@ppp-2-85-255-192.home.otenet.gr> has left #bitcoin-core-dev
3292020-12-28T21:54:56  *** ossifrage <ossifrage!~ossifrage@unaffiliated/ossifrage> has joined #bitcoin-core-dev
3302020-12-28T22:17:06  *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
3312020-12-28T22:17:22  *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
3322020-12-28T22:18:09  <jonatack> (thanks for the guidance)
3332020-12-28T22:22:19  *** kristapsk <kristapsk!~KK@gateway/tor-sasl/kristapsk> has quit IRC (Remote host closed the connection)
3342020-12-28T22:57:09  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3352020-12-28T22:57:09  <bitcoin-git> [gui] laanwj merged pull request #162: Add network to peers window and peer details (master...display-peer-networks) https://github.com/bitcoin-core/gui/pull/162
3362020-12-28T22:57:10  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3372020-12-28T22:57:24  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3382020-12-28T22:57:24  <bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/e3dd0a56cfa7...d875bcc8f9ac
3392020-12-28T22:57:25  <bitcoin-git> bitcoin/master af9103c Jon Atack: net, rpc: change CNodeStats::m_network from string to Network
3402020-12-28T22:57:25  <bitcoin-git> bitcoin/master 0d5613f Jon Atack: gui: create GUIUtil::NetworkToQString() utility function
3412020-12-28T22:57:26  <bitcoin-git> bitcoin/master e0e5506 Jon Atack: gui: fix broken doxygen formatting in src/qt/guiutil.h
3422020-12-28T22:57:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3432020-12-28T22:59:31  *** MasterdonX <MasterdonX!~masterdon@45.9.249.244> has joined #bitcoin-core-dev
3442020-12-28T23:08:32  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Quit: Leaving)
3452020-12-28T23:09:23  *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
3462020-12-28T23:12:17  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Read error: Connection reset by peer)
3472020-12-28T23:20:09  *** zivl <zivl!~zivl@unaffiliated/zivl> has joined #bitcoin-core-dev
3482020-12-28T23:20:17  *** zivl <zivl!~zivl@unaffiliated/zivl> has quit IRC (Client Quit)
3492020-12-28T23:56:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3502020-12-28T23:56:27  <bitcoin-git> [bitcoin] jonatack opened pull request #20791: p2p: remove unused legacyWhitelisted bool variable (master...rm-unused-legacyWhitelisted) https://github.com/bitcoin/bitcoin/pull/20791
3512020-12-28T23:56:28  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev