12021-01-03T00:00:59  *** ccdle12 <ccdle12!~ccdle12@gateway/tor-sasl/ccdle12> has joined #bitcoin-core-dev
  22021-01-03T00:34:39  *** Johnny10 <Johnny10!2e07f79b@46.7.247.155> has joined #bitcoin-core-dev
  32021-01-03T00:35:27  *** Johnny10 <Johnny10!2e07f79b@46.7.247.155> has left #bitcoin-core-dev
  42021-01-03T00:37:40  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
  52021-01-03T00:40:23  *** ccdle12 <ccdle12!~ccdle12@gateway/tor-sasl/ccdle12> has quit IRC (Ping timeout: 240 seconds)
  62021-01-03T00:51:05  *** lightlike <lightlike!~lightlike@p200300c7ef39ff00a985b2151ad7bc60.dip0.t-ipconnect.de> has quit IRC (Quit: Leaving)
  72021-01-03T00:51:15  *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
  82021-01-03T00:51:51  *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
  92021-01-03T00:56:52  *** Zenton <Zenton!~user@unaffiliated/vicenteh> has quit IRC (Ping timeout: 272 seconds)
 102021-01-03T00:58:24  *** ccdle12 <ccdle12!~ccdle12@gateway/tor-sasl/ccdle12> has joined #bitcoin-core-dev
 112021-01-03T00:58:25  *** Zenton <Zenton!~user@unaffiliated/vicenteh> has joined #bitcoin-core-dev
 122021-01-03T01:03:15  *** tlev9 <tlev9!~tlev@li120-195.members.linode.com> has joined #bitcoin-core-dev
 132021-01-03T01:03:16  *** tlev <tlev!~tlev@li120-195.members.linode.com> has quit IRC (Read error: Connection reset by peer)
 142021-01-03T01:03:17  *** tlev9 is now known as tlev
 152021-01-03T01:03:47  *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
 162021-01-03T01:03:50  *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 264 seconds)
 172021-01-03T01:06:15  *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-krcbvlexiytkhjit> has quit IRC (*.net *.split)
 182021-01-03T01:06:37  *** esotericnonsense <esotericnonsense!~esotericn@unaffiliated/esotericnonsense> has quit IRC (*.net *.split)
 192021-01-03T01:06:37  *** nkuttler <nkuttler!~nkuttler@unaffiliated/nkuttler> has quit IRC (*.net *.split)
 202021-01-03T01:06:37  *** berndj <berndj!~berndj@ns2.linksynergy.co.za> has quit IRC (*.net *.split)
 212021-01-03T01:06:37  *** exhoplex <exhoplex!~echo@139.180.133.130> has quit IRC (*.net *.split)
 222021-01-03T01:06:37  *** niftynei <niftynei!~niftynei@104.131.77.55> has quit IRC (*.net *.split)
 232021-01-03T01:06:37  *** comboy <comboy!~quassel@tesuji.pl> has quit IRC (*.net *.split)
 242021-01-03T01:06:37  *** asukan <asukan!~quassel@ec2-35-180-180-58.eu-west-3.compute.amazonaws.com> has quit IRC (*.net *.split)
 252021-01-03T01:06:37  *** lio17 <lio17!~lio17@80.ip-145-239-89.eu> has quit IRC (*.net *.split)
 262021-01-03T01:06:37  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has joined #bitcoin-core-dev
 272021-01-03T01:08:02  *** esotericnonsense <esotericnonsense!~esotericn@unaffiliated/esotericnonsense> has joined #bitcoin-core-dev
 282021-01-03T01:08:02  *** nkuttler <nkuttler!~nkuttler@unaffiliated/nkuttler> has joined #bitcoin-core-dev
 292021-01-03T01:09:26  *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-krcbvlexiytkhjit> has joined #bitcoin-core-dev
 302021-01-03T01:09:26  *** berndj <berndj!~berndj@ns2.linksynergy.co.za> has joined #bitcoin-core-dev
 312021-01-03T01:09:26  *** exhoplex <exhoplex!~echo@139.180.133.130> has joined #bitcoin-core-dev
 322021-01-03T01:09:26  *** niftynei <niftynei!~niftynei@104.131.77.55> has joined #bitcoin-core-dev
 332021-01-03T01:09:26  *** comboy <comboy!~quassel@tesuji.pl> has joined #bitcoin-core-dev
 342021-01-03T01:09:26  *** asukan <asukan!~quassel@ec2-35-180-180-58.eu-west-3.compute.amazonaws.com> has joined #bitcoin-core-dev
 352021-01-03T01:09:26  *** lio17 <lio17!~lio17@80.ip-145-239-89.eu> has joined #bitcoin-core-dev
 362021-01-03T01:10:01  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 246 seconds)
 372021-01-03T01:10:10  *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-krcbvlexiytkhjit> has quit IRC (Ping timeout: 249 seconds)
 382021-01-03T01:11:22  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has joined #bitcoin-core-dev
 392021-01-03T01:12:24  *** meshcollider <meshcollider!meshcollid@gateway/shell/ircnow/x-ouuqpqzypguzxydq> has joined #bitcoin-core-dev
 402021-01-03T01:13:03  <luke-jr> #20741 looks ready for merge
 412021-01-03T01:13:05  <gribble> https://github.com/bitcoin/bitcoin/issues/20741 | doc: Update Secure string handling by prayank23 · Pull Request #20741 · bitcoin/bitcoin · GitHub
 422021-01-03T01:13:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
 432021-01-03T01:13:12  <bitcoin-git> [bitcoin] eilx2 opened pull request #20832: rpc: Better error messages for invalid addresses (master...master) https://github.com/bitcoin/bitcoin/pull/20832
 442021-01-03T01:13:13  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
 452021-01-03T01:15:09  *** ccdle12 <ccdle12!~ccdle12@gateway/tor-sasl/ccdle12> has quit IRC (Remote host closed the connection)
 462021-01-03T01:33:49  *** andytoshi <andytoshi!~apoelstra@wpsoftware.net> has joined #bitcoin-core-dev
 472021-01-03T01:34:39  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
 482021-01-03T01:35:58  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
 492021-01-03T01:36:45  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
 502021-01-03T01:36:45  *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
 512021-01-03T01:36:47  *** vasild_ is now known as vasild
 522021-01-03T01:37:04  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
 532021-01-03T01:38:30  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
 542021-01-03T02:13:40  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
 552021-01-03T02:13:58  <aj> sipa: if you're around and bored, did you want to give a hot take on the new top commit (marked DRAFT) on #19438 ?
 562021-01-03T02:14:00  <gribble> https://github.com/bitcoin/bitcoin/issues/19438 | Introduce deploymentstatus by ajtowns · Pull Request #19438 · bitcoin/bitcoin · GitHub
 572021-01-03T02:14:23  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
 582021-01-03T02:18:50  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
 592021-01-03T02:19:17  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
 602021-01-03T02:32:34  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
 612021-01-03T02:33:03  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 260 seconds)
 622021-01-03T02:38:57  *** lightningbot <lightningbot!lightningb@cerulean.erisian.com.au> has joined #bitcoin-core-dev
 632021-01-03T02:39:18  *** andytosh1 <andytosh1!~apoelstra@wpsoftware.net> has joined #bitcoin-core-dev
 642021-01-03T02:39:29  *** rc_423_ <rc_423_!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
 652021-01-03T02:42:40  *** niftynei_ <niftynei_!~niftynei@104.131.77.55> has joined #bitcoin-core-dev
 662021-01-03T02:43:52  *** andytoshi <andytoshi!~apoelstra@unaffiliated/andytoshi> has quit IRC (*.net *.split)
 672021-01-03T02:43:52  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (*.net *.split)
 682021-01-03T02:43:52  *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (*.net *.split)
 692021-01-03T02:43:53  *** queip <queip!~queip@unaffiliated/rezurus> has quit IRC (*.net *.split)
 702021-01-03T02:43:53  *** spinza <spinza!~spin@102.132.245.16> has quit IRC (*.net *.split)
 712021-01-03T02:43:54  *** MickSaunders <MickSaunders!~michael@193.105.188.215> has quit IRC (*.net *.split)
 722021-01-03T02:43:54  *** Anduck <Anduck!~anduck@unaffiliated/anduck> has quit IRC (*.net *.split)
 732021-01-03T02:43:54  *** rabidus_ <rabidus_!~rabidus@dsl-olubng12-54fa17-92.dhcp.inet.fi> has quit IRC (*.net *.split)
 742021-01-03T02:43:54  *** romanz <romanz!~romanz@93.123.196.104.bc.googleusercontent.com> has quit IRC (*.net *.split)
 752021-01-03T02:43:54  *** Nebraskka <Nebraskka!~Nebraskka@51.83.249.56> has quit IRC (*.net *.split)
 762021-01-03T02:43:54  *** so <so!~so@unaffiliated/so> has quit IRC (*.net *.split)
 772021-01-03T02:43:54  *** adam3us <adam3us!~adam3us@unaffiliated/adam3us> has quit IRC (*.net *.split)
 782021-01-03T02:43:54  *** m1rror5 <m1rror5!~cataly5m@static.65.177.203.116.clients.your-server.de> has quit IRC (*.net *.split)
 792021-01-03T02:43:55  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (*.net *.split)
 802021-01-03T02:43:56  *** berndj <berndj!~berndj@ns2.linksynergy.co.za> has quit IRC (*.net *.split)
 812021-01-03T02:43:56  *** exhoplex <exhoplex!~echo@139.180.133.130> has quit IRC (*.net *.split)
 822021-01-03T02:43:56  *** niftynei <niftynei!~niftynei@104.131.77.55> has quit IRC (*.net *.split)
 832021-01-03T02:43:56  *** comboy <comboy!~quassel@tesuji.pl> has quit IRC (*.net *.split)
 842021-01-03T02:43:56  *** asukan <asukan!~quassel@ec2-35-180-180-58.eu-west-3.compute.amazonaws.com> has quit IRC (*.net *.split)
 852021-01-03T02:43:56  *** lio17 <lio17!~lio17@80.ip-145-239-89.eu> has quit IRC (*.net *.split)
 862021-01-03T02:43:56  *** berndj-blackout is now known as berndj
 872021-01-03T02:43:57  *** queip_ is now known as queip
 882021-01-03T02:44:09  *** rc_423_ <rc_423_!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
 892021-01-03T02:44:10  *** exhoplex <exhoplex!~echo@139.180.133.130> has joined #bitcoin-core-dev
 902021-01-03T02:44:16  *** Anduck <Anduck!~anduck@unaffiliated/anduck> has joined #bitcoin-core-dev
 912021-01-03T02:44:26  *** MickSaunders <MickSaunders!~michael@193.105.188.215> has joined #bitcoin-core-dev
 922021-01-03T02:44:28  *** lio17 <lio17!~lio17@80.ip-145-239-89.eu> has joined #bitcoin-core-dev
 932021-01-03T02:44:42  *** rc_423_ <rc_423_!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
 942021-01-03T02:46:25  <sipa> aj: the goal is better compile-time guarantees you're not mixing things up?
 952021-01-03T02:47:45  *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev
 962021-01-03T02:49:40  *** shesek <shesek!~shesek@164.90.217.137> has joined #bitcoin-core-dev
 972021-01-03T02:56:23  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Quit: Leaving)
 982021-01-03T02:59:33  *** so <so!~so@unaffiliated/so> has joined #bitcoin-core-dev
 992021-01-03T03:11:29  *** windsok <windsok!~windsok@unaffiliated/windsok> has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
1002021-01-03T03:12:29  *** windsok <windsok!~windsok@unaffiliated/windsok> has joined #bitcoin-core-dev
1012021-01-03T03:16:34  *** rc_423_ <rc_423_!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
1022021-01-03T03:17:29  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
1032021-01-03T03:20:19  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has joined #bitcoin-core-dev
1042021-01-03T03:20:23  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
1052021-01-03T03:27:11  <dhruvm> Does anyone use the YouCompleteMe vim plugin for Bitcoin Core and have a .ycm_extra_conf.py they can share?
1062021-01-03T03:29:38  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1072021-01-03T03:31:11  *** paanir <paanir!49aadbbf@c-73-170-219-191.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
1082021-01-03T03:31:32  *** paanir <paanir!49aadbbf@c-73-170-219-191.hsd1.ca.comcast.net> has quit IRC (Remote host closed the connection)
1092021-01-03T03:36:05  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
1102021-01-03T03:40:19  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
1112021-01-03T03:56:39  *** zestymug <zestymug!djkoolmatr@gateway/shell/matrix.org/x-mtpsyaqhrusbkbpu> has joined #bitcoin-core-dev
1122021-01-03T04:06:56  *** zestymug <zestymug!djkoolmatr@gateway/shell/matrix.org/x-mtpsyaqhrusbkbpu> has left #bitcoin-core-dev ("User left")
1132021-01-03T04:50:43  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has quit IRC (Ping timeout: 240 seconds)
1142021-01-03T04:56:50  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has joined #bitcoin-core-dev
1152021-01-03T04:59:38  <aj> sipa: hmm, sounds like leave it as inline functions and don't template then
1162021-01-03T04:59:54  <aj> sipa: (staring at it more doesn't seem to be helping)
1172021-01-03T05:16:48  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
1182021-01-03T05:55:27  *** Implant1 <Implant1!~Implant@195.140.213.38> has quit IRC (Remote host closed the connection)
1192021-01-03T07:16:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1202021-01-03T07:16:46  <bitcoin-git> [bitcoin] glozow opened pull request #20833: rpc/validation: enable packages through testmempoolaccept (master...package-testmempoolaccept) https://github.com/bitcoin/bitcoin/pull/20833
1212021-01-03T07:16:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1222021-01-03T07:17:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1232021-01-03T07:17:37  <bitcoin-git> [bitcoin] glozow opened pull request #20834: cleanup: remove CheckInputsFromMempoolAndCache (master...2021-01-validation-cleanup) https://github.com/bitcoin/bitcoin/pull/20834
1242021-01-03T07:17:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1252021-01-03T07:40:16  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1262021-01-03T07:40:16  <bitcoin-git> [bitcoin] ppyordanov opened pull request #20835: doc: Corrected Typos in Documentation (master...documentation-fix-typos) https://github.com/bitcoin/bitcoin/pull/20835
1272021-01-03T07:40:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1282021-01-03T07:41:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1292021-01-03T07:41:36  <bitcoin-git> [bitcoin] ppyordanov opened pull request #20836: doc: Corrected Typos in Documentation (master...doc-fix-typos) https://github.com/bitcoin/bitcoin/pull/20836
1302021-01-03T07:41:38  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1312021-01-03T07:41:42  *** andy1221 <andy1221!7085fb5e@112.133.251.94> has joined #bitcoin-core-dev
1322021-01-03T07:41:56  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1332021-01-03T07:41:56  <bitcoin-git> [bitcoin] ppyordanov closed pull request #20835: doc: Corrected Typos in Documentation (master...documentation-fix-typos) https://github.com/bitcoin/bitcoin/pull/20835
1342021-01-03T07:41:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1352021-01-03T07:47:08  *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
1362021-01-03T07:47:20  *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
1372021-01-03T07:47:44  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
1382021-01-03T07:51:20  *** andy1221 <andy1221!7085fb5e@112.133.251.94> has quit IRC (Ping timeout: 245 seconds)
1392021-01-03T08:17:34  *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
1402021-01-03T08:18:04  <wumpus> provoostenator: i don't know, but we can't postpone rc4 indefinitely on it
1412021-01-03T08:18:43  <wumpus> we could have some release out and have something for people to test for weeks now, but the discussion on those takes indefinitely
1422021-01-03T08:22:39  <sipa> let's just get rc4 out
1432021-01-03T08:24:14  <aj> wumpus: if it's not going in, nack it as not being important enough a fix to justify a change? (if it is important enough to justify a change, merging it seems obvious?)
1442021-01-03T08:25:34  <aj> wumpus: (i think it's important enough; but obviously lots of people are dubious, and if someone has to make a call, might as well be a maintainer?)
1452021-01-03T09:17:54  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has joined #bitcoin-core-dev
1462021-01-03T09:36:33  <wumpus> aj: I have already given my opinion on it
1472021-01-03T09:36:44  <wumpus> I don't necesaarily want to push that
1482021-01-03T09:39:33  <wumpus> but yes I think the change is unnecessary
1492021-01-03T09:40:42  <wumpus> and in that case it's probably better to err on the side of not doing it, that said, if this blocks the release forever it'd be kind of sad
1502021-01-03T09:45:41  <wumpus> I really think it's time to do the rc
1512021-01-03T09:47:09  <wumpus> looking at #18947, 0.21 has slipped exactly a month now
1522021-01-03T09:47:10  <gribble> https://github.com/bitcoin/bitcoin/issues/18947 | Release schedule for 0.21.0 · Issue #18947 · bitcoin/bitcoin · GitHub
1532021-01-03T09:47:17  <wumpus> this is fairly normal
1542021-01-03T09:48:21  <wumpus> i'm not sure this should delay the 0.22.0 release schedule as well
1552021-01-03T10:03:28  <aj> wumpus: hmm, i appreciate the "I don't necessarily want to push that" but I also feel like "I think the change is unnecessary" should be more of a nack (concept nack? -0.5? im-not-merging-but-someone-else-might?) than a "~0" and a "review ACK"? it seems like everyone's waiting for someone else to nack it so they don't have to?
1562021-01-03T10:03:36  *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Read error: Connection reset by peer)
1572021-01-03T10:04:54  *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
1582021-01-03T10:16:46  <wumpus> "review ACK" means i think the code is correct in doing what it is stated to do
1592021-01-03T10:17:50  <wumpus> as for #20648, it can wait
1602021-01-03T10:17:52  <gribble> https://github.com/bitcoin/bitcoin/issues/20648 | chainparams: Add default fixed seeds for signet by MarcoFalke · Pull Request #20648 · bitcoin/bitcoin · GitHub
1612021-01-03T10:24:01  *** RootDet <RootDet!~Rootdet@unaffiliated/rootdet> has joined #bitcoin-core-dev
1622021-01-03T10:24:11  *** RootDet <RootDet!~Rootdet@unaffiliated/rootdet> has left #bitcoin-core-dev
1632021-01-03T10:32:52  *** jonatack <jonatack!~jon@88.124.242.136> has quit IRC (Ping timeout: 260 seconds)
1642021-01-03T10:34:58  *** jonatack <jonatack!~jon@88.124.242.136> has joined #bitcoin-core-dev
1652021-01-03T10:35:12  *** jonatack <jonatack!~jon@88.124.242.136> has quit IRC (Client Quit)
1662021-01-03T10:35:51  <wumpus> thinking of it somewhat more, I don't think minor signet-specific issues like this should really hold up a release
1672021-01-03T10:49:18  *** jonatack <jonatack!~jon@88.124.242.136> has joined #bitcoin-core-dev
1682021-01-03T10:52:54  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
1692021-01-03T10:57:54  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has joined #bitcoin-core-dev
1702021-01-03T10:57:58  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has quit IRC (Client Quit)
1712021-01-03T11:00:13  *** jonatack <jonatack!~jon@88.124.242.136> has quit IRC (Ping timeout: 264 seconds)
1722021-01-03T11:01:44  *** jonatack <jonatack!~jon@213.152.162.99> has joined #bitcoin-core-dev
1732021-01-03T11:15:23  *** jonatack <jonatack!~jon@213.152.162.99> has quit IRC (Quit: jonatack)
1742021-01-03T11:15:41  *** jonatack <jonatack!~jon@213.152.162.99> has joined #bitcoin-core-dev
1752021-01-03T11:18:46  *** Garth63Schuster <Garth63Schuster!~Garth63Sc@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
1762021-01-03T11:30:27  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has joined #bitcoin-core-dev
1772021-01-03T11:39:41  <fanquake> agree
1782021-01-03T11:45:58  *** ccdle12 <ccdle12!~ccdle12@243.222.90.149.rev.vodafone.pt> has joined #bitcoin-core-dev
1792021-01-03T11:49:50  *** ccdle12 <ccdle12!~ccdle12@243.222.90.149.rev.vodafone.pt> has quit IRC (Client Quit)
1802021-01-03T11:55:15  *** schulzemic <schulzemic!~ada@193.27.14.104> has joined #bitcoin-core-dev
1812021-01-03T12:18:44  *** Matt_P <Matt_P!~Matt_P@185.204.1.185> has joined #bitcoin-core-dev
1822021-01-03T12:21:21  *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1832021-01-03T12:22:01  *** Garth63Schuster <Garth63Schuster!~Garth63Sc@static.57.1.216.95.clients.your-server.de> has quit IRC (Ping timeout: 246 seconds)
1842021-01-03T12:24:01  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
1852021-01-03T12:26:42  *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 256 seconds)
1862021-01-03T12:28:16  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
1872021-01-03T12:42:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1882021-01-03T12:42:51  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/ac125e960f31...93ce429f0e6a
1892021-01-03T12:42:51  <bitcoin-git> bitcoin/0.21 93ce429 Wladimir J. van der Laan: qt: Pre-rc4 translations update
1902021-01-03T12:42:53  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1912021-01-03T12:43:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1922021-01-03T12:43:52  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/93ce429f0e6a...212525337eda
1932021-01-03T12:43:52  <bitcoin-git> bitcoin/0.21 2125253 Wladimir J. van der Laan: build: Bump RC to rc4
1942021-01-03T12:43:54  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1952021-01-03T12:49:30  *** Talkless <Talkless!~Talkless@m90-135-158-94.cust.tele2.lt> has joined #bitcoin-core-dev
1962021-01-03T13:01:07  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has joined #bitcoin-core-dev
1972021-01-03T13:03:04  *** worc3131 <worc3131!~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20> has joined #bitcoin-core-dev
1982021-01-03T13:06:03  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has quit IRC (Ping timeout: 240 seconds)
1992021-01-03T13:14:01  *** davterra <davterra!~davterra@86.106.143.77> has joined #bitcoin-core-dev
2002021-01-03T13:23:27  *** Talkless <Talkless!~Talkless@m90-135-158-94.cust.tele2.lt> has quit IRC (Quit: Konversation terminated!)
2012021-01-03T13:25:03  *** worc3131 <worc3131!~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20> has quit IRC (Ping timeout: 258 seconds)
2022021-01-03T13:28:44  *** davterra <davterra!~davterra@86.106.143.77> has quit IRC (Ping timeout: 260 seconds)
2032021-01-03T13:31:17  *** schulzemic <schulzemic!~ada@193.27.14.104> has quit IRC (Quit: Konversation terminated!)
2042021-01-03T13:34:35  *** davterra <davterra!~davterra@23.226.131.131> has joined #bitcoin-core-dev
2052021-01-03T13:40:23  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
2062021-01-03T13:42:28  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
2072021-01-03T14:11:12  <michaelfolkson> I'm thinking of making it clearer in the fuzzing docs that fuzzing beginners should start with libFuzzer based on these Google recommendations https://github.com/google/fuzzing/blob/master/docs/intro-to-fuzzing.md#fuzzing-tools
2082021-01-03T14:11:39  <michaelfolkson> Does anyone do any fuzzing currently with Honggfuzz, AFL?
2092021-01-03T14:12:14  <michaelfolkson> Apparently AFL isn't well maintained according to that Google doc
2102021-01-03T14:13:14  <michaelfolkson> I guess libFuzzer being first in our fuzzing doc is a subtle recommendation by itself https://github.com/bitcoin/bitcoin/blob/master/doc/fuzzing.md
2112021-01-03T14:13:26  *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…)
2122021-01-03T14:23:05  *** worc3131 <worc3131!~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20> has joined #bitcoin-core-dev
2132021-01-03T14:35:41  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
2142021-01-03T14:37:17  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
2152021-01-03T14:44:54  *** rex4539 <rex4539!~rex4539@8.40.29.14> has joined #bitcoin-core-dev
2162021-01-03T14:57:11  *** rex4539 <rex4539!~rex4539@8.40.29.14> has quit IRC ()
2172021-01-03T15:10:03  <MarcoFalke> ACK on rc4 tag
2182021-01-03T15:10:41  <MarcoFalke> #20648 isn't meant for rc4 and it only has one explict review ACK
2192021-01-03T15:10:43  <gribble> https://github.com/bitcoin/bitcoin/issues/20648 | chainparams: Add default fixed seeds for signet by MarcoFalke · Pull Request #20648 · bitcoin/bitcoin · GitHub
2202021-01-03T15:19:02  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2212021-01-03T15:19:02  <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/212525337eda...e6ad8a6220bf
2222021-01-03T15:19:02  <bitcoin-git> bitcoin/0.21 e6ad8a6 Wladimir J. van der Laan: doc: Generate manual pages for 0.21.0rc4
2232021-01-03T15:19:04  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2242021-01-03T15:48:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2252021-01-03T15:48:36  <bitcoin-git> [bitcoin] laanwj pushed tag v0.21.0rc4: https://github.com/bitcoin/bitcoin/compare/v0.21.0rc4
2262021-01-03T15:48:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2272021-01-03T15:49:13  <wumpus> ^^
2282021-01-03T16:00:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2292021-01-03T16:00:57  <bitcoin-git> [bitcoin] jonatack closed pull request #20723: p2p: improve logging in EvictExtraOutboundPeers() (master...improve-EvictExtraOutboundPeers-logging) https://github.com/bitcoin/bitcoin/pull/20723
2302021-01-03T16:00:58  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2312021-01-03T16:02:21  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Remote host closed the connection)
2322021-01-03T16:02:22  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Read error: Connection reset by peer)
2332021-01-03T16:02:22  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Read error: Connection reset by peer)
2342021-01-03T16:02:22  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has quit IRC (Read error: Connection reset by peer)
2352021-01-03T16:02:22  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has quit IRC (Write error: Connection reset by peer)
2362021-01-03T16:02:22  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Write error: Connection reset by peer)
2372021-01-03T16:02:22  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has quit IRC (Read error: Connection reset by peer)
2382021-01-03T16:05:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2392021-01-03T16:05:36  <bitcoin-git> [bitcoin] jonatack closed pull request #20546: policy, wallet, refactor: check for non-representable CFeeRates (master...non-representable-CFeeRate-check) https://github.com/bitcoin/bitcoin/pull/20546
2402021-01-03T16:05:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2412021-01-03T16:07:45  *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has joined #bitcoin-core-dev
2422021-01-03T16:08:03  *** sdaftuar <sdaftuar!~sdaftuar@gateway/tor-sasl/sdaftuar> has joined #bitcoin-core-dev
2432021-01-03T16:08:12  *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
2442021-01-03T16:08:13  *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
2452021-01-03T16:08:21  *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
2462021-01-03T16:09:07  *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has joined #bitcoin-core-dev
2472021-01-03T16:11:43  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
2482021-01-03T16:12:34  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
2492021-01-03T16:18:41  <michaelfolkson> You're not making it easy to get quick Concept ACKs jonatack with descriptions like "following up on #19858 (comment)." and not making it clear what is covered by the PR and what is covered by the series of PRs
2502021-01-03T16:18:44  <gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub
2512021-01-03T16:19:24  <michaelfolkson> Easy to give a quick Concept ACK when the description is better quality
2522021-01-03T16:19:36  <michaelfolkson> Otherwise needs some digging on behalf of the reviewer
2532021-01-03T16:21:05  <michaelfolkson> PR #20546 has a good PR description
2542021-01-03T16:21:07  <gribble> https://github.com/bitcoin/bitcoin/issues/20546 | policy, wallet, refactor: check for non-representable CFeeRates by jonatack · Pull Request #20546 · bitcoin/bitcoin · GitHub
2552021-01-03T16:28:58  *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
2562021-01-03T16:30:35  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2572021-01-03T16:30:35  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20839: fuzz: Avoid extraneous copy of input data, using Span<> (master...2101-fuzzSpan) https://github.com/bitcoin/bitcoin/pull/20839
2582021-01-03T16:30:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2592021-01-03T16:41:52  *** davterra <davterra!~davterra@23.226.131.131> has quit IRC (Remote host closed the connection)
2602021-01-03T16:42:24  *** davterra <davterra!~davterra@23.226.131.131> has joined #bitcoin-core-dev
2612021-01-03T16:42:42  *** davterra <davterra!~davterra@23.226.131.131> has quit IRC (Read error: Connection reset by peer)
2622021-01-03T16:52:36  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2632021-01-03T16:52:36  <bitcoin-git> [bitcoin] ppyordanov closed pull request #20836: doc: Corrected Typos in Documentation (master...doc-fix-typos) https://github.com/bitcoin/bitcoin/pull/20836
2642021-01-03T16:52:37  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2652021-01-03T16:52:43  <jonatack> idk if the pull descriptions are the issue. i stand by the work and am sad to close, but better to work on things reviewers are enthusiastic about...you do the work because you believe in it; after that you turn it over to reviewers and it's up to them.
2662021-01-03T16:53:52  <jonatack> there's a book about it, "review is a harsh mistress" (heinlein, 1966 :))
2672021-01-03T16:54:00  <michaelfolkson> Well I'm telling you at least from my perspective a good PR description makes a Concept ACK very quick and easy :)
2682021-01-03T16:55:42  <michaelfolkson> The more digging required, the more friction and the unlikelier it is to get quick Concept ACKs. That's my hypothesis anyway
2692021-01-03T16:58:44  <jonatack> michaelfolkson: hm, with the title "p2p: improve logging in EvictExtraOutboundPeers" and the diff being only 9 lines, i reckoned more description wasn't required on that one
2702021-01-03T16:59:28  <jonatack> maybe could have added more though, idk
2712021-01-03T16:59:44  <jonatack> onward and upward
2722021-01-03T17:03:00  <michaelfolkson> It is the problem it is solving rather than the solution only being 9 lines
2732021-01-03T17:10:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2742021-01-03T17:10:11  <bitcoin-git> [bitcoin] ppyordanov reopened pull request #20836: doc: Corrected Typos in Documentation (master...doc-fix-typos) https://github.com/bitcoin/bitcoin/pull/20836
2752021-01-03T17:10:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2762021-01-03T17:24:20  *** andytosh1 is now known as andytoshi
2772021-01-03T17:26:03  *** brianhoffman <brianhoffman!~brianhoff@pool-151-200-246-97.washdc.fios.verizon.net> has left #bitcoin-core-dev
2782021-01-03T17:28:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2792021-01-03T17:28:57  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9c3765ad7cee...6e70674cda65
2802021-01-03T17:28:57  <bitcoin-git> bitcoin/master 0dade91 fanquake: fuzz: remove no-longer-necessary packages from fuzzbuzz config
2812021-01-03T17:28:58  <bitcoin-git> bitcoin/master 6e70674 MarcoFalke: Merge #20781: fuzz: remove no-longer-necessary packages from fuzzbuzz conf...
2822021-01-03T17:28:59  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2832021-01-03T17:29:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2842021-01-03T17:29:17  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20781: fuzz: remove no-longer-necessary packages from fuzzbuzz config (master...cleanup_fuzzbuzz) https://github.com/bitcoin/bitcoin/pull/20781
2852021-01-03T17:29:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2862021-01-03T17:30:27  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2872021-01-03T17:30:27  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6e70674cda65...2dab2d239a47
2882021-01-03T17:30:28  <bitcoin-git> bitcoin/master efaf80e Michael Dietz: fuzz: check that certain script TxoutType are nonstandard
2892021-01-03T17:30:28  <bitcoin-git> bitcoin/master 2dab2d2 MarcoFalke: Merge #20765: fuzz: check that certain script TxoutType are nonstandard
2902021-01-03T17:30:30  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2912021-01-03T17:30:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2922021-01-03T17:30:47  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20765: fuzz: check that certain script TxoutType are nonstandard (master...test-fuzz-is-nonstandard) https://github.com/bitcoin/bitcoin/pull/20765
2932021-01-03T17:30:48  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2942021-01-03T17:54:49  *** alko89 <alko89!~alko89@unaffiliated/alko89> has quit IRC (Quit: ZNC 1.7.5 - https://znc.in)
2952021-01-03T17:59:44  *** alko89 <alko89!~alko89@unaffiliated/alko89> has joined #bitcoin-core-dev
2962021-01-03T18:00:22  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Remote host closed the connection)
2972021-01-03T18:00:29  *** davterra <davterra!~davterra@23.226.131.131> has joined #bitcoin-core-dev
2982021-01-03T18:00:33  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
2992021-01-03T18:07:57  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3002021-01-03T18:07:57  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2dab2d239a47...9a2400b57558
3012021-01-03T18:07:58  <bitcoin-git> bitcoin/master fad140e MarcoFalke: test: Set correct nValue for multi-op-return policy check
3022021-01-03T18:07:58  <bitcoin-git> bitcoin/master 9a2400b MarcoFalke: Merge #20760: test: Set correct nValue for multi-op-return policy check
3032021-01-03T18:08:00  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3042021-01-03T18:08:17  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3052021-01-03T18:08:17  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20760: test: Set correct nValue for multi-op-return policy check (master...2012-testNValue) https://github.com/bitcoin/bitcoin/pull/20760
3062021-01-03T18:08:18  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3072021-01-03T18:20:07  *** unauvum <unauvum!~unauvum@134.122.10.34> has joined #bitcoin-core-dev
3082021-01-03T18:32:19  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has joined #bitcoin-core-dev
3092021-01-03T18:41:12  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
3102021-01-03T18:41:37  *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
3112021-01-03T18:42:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3122021-01-03T18:42:06  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #20800: Revert "Don't send 'sendaddrv2' to pre-70016 software" (master...2012-netRevertSendaddrv2Workaround) https://github.com/bitcoin/bitcoin/pull/20800
3132021-01-03T18:42:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3142021-01-03T18:45:22  *** worc3131 <worc3131!~quassel@2a02:c7f:dcc4:6500:cf0e:3346:8766:ab20> has quit IRC (Remote host closed the connection)
3152021-01-03T18:52:30  *** virtu_ <virtu_!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
3162021-01-03T18:52:49  *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Remote host closed the connection)
3172021-01-03T18:52:51  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3182021-01-03T18:52:51  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #16398: rpc: testmempoolaccept for list of transactions (master...Mf1807-txpoolStacked) https://github.com/bitcoin/bitcoin/pull/16398
3192021-01-03T18:52:52  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3202021-01-03T18:53:11  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3212021-01-03T18:53:11  <bitcoin-git> [bitcoin] jonatack closed pull request #20483: wallet: deprecate feeRate in fundrawtransaction/walletcreatefundedpsbt (master...deprecate-feeRate-options) https://github.com/bitcoin/bitcoin/pull/20483
3222021-01-03T18:53:12  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3232021-01-03T18:56:06  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3242021-01-03T18:56:06  <bitcoin-git> [bitcoin] jonatack closed pull request #20240: script: fix linter error in test runner (master...fix-python-linter-error) https://github.com/bitcoin/bitcoin/pull/20240
3252021-01-03T18:56:07  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3262021-01-03T18:57:51  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
3272021-01-03T19:00:46  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3282021-01-03T19:00:46  <bitcoin-git> [gui] hebasto opened pull request #176: Fix TxViewDelegate layout (master...210103-delegate) https://github.com/bitcoin-core/gui/pull/176
3292021-01-03T19:00:47  *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3302021-01-03T19:03:50  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
3312021-01-03T19:04:20  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
3322021-01-03T19:10:55  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
3332021-01-03T19:15:40  *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
3342021-01-03T19:24:49  *** heyitsrama <heyitsrama!~heyitsram@c-24-6-105-253.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
3352021-01-03T19:27:13  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 264 seconds)
3362021-01-03T19:27:52  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
3372021-01-03T19:45:25  *** filchef <filchef!~filchef@89.253.179.83> has joined #bitcoin-core-dev
3382021-01-03T19:51:28  *** df3fjf <df3fjf!~df3fjf@gateway/tor-sasl/jd3i33j> has joined #bitcoin-core-dev
3392021-01-03T19:58:57  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has quit IRC (Ping timeout: 260 seconds)
3402021-01-03T20:01:34  *** df3fjf <df3fjf!~df3fjf@gateway/tor-sasl/jd3i33j> has quit IRC (Quit: leaving)
3412021-01-03T20:06:56  *** heyitsrama <heyitsrama!~heyitsram@c-24-6-105-253.hsd1.ca.comcast.net> has quit IRC (Remote host closed the connection)
3422021-01-03T20:07:41  *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
3432021-01-03T20:16:08  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
3442021-01-03T20:24:36  *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
3452021-01-03T20:29:57  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
3462021-01-03T20:44:35  <andytoshi> is there a way to call `getblock` and not receive witness data? would a PR to add this be accepted?
3472021-01-03T20:47:27  <luke-jr> the RPC? there probably shouldn't be
3482021-01-03T20:47:35  <sipa> you can run with -rpcserialversion=0 if you really need to
3492021-01-03T20:53:37  *** samuel-pedraza <samuel-pedraza!47edaff3@gateway/web/cgi-irc/kiwiirc.com/ip.71.237.175.243> has joined #bitcoin-core-dev
3502021-01-03T21:07:56  <andytoshi> oh that's a neat trick sipa, i might do that
3512021-01-03T21:08:05  <andytoshi> ok luke-jr if there's gonna be opposition i won't bother
3522021-01-03T21:08:17  <andytoshi> but it kinda annoying to haul all that witness data around if i'm not even gonna use it
3532021-01-03T21:09:11  <luke-jr> andytoshi: why haul it? just strip at your first hop?
3542021-01-03T21:09:25  <luke-jr> or rather, why get the raw block at all if you don't want that? :P
3552021-01-03T21:11:17  <andytoshi> luke-jr: i am the first hop, i'm pulling this data over localhost into an indexer, which is just scanning for TXOs that it cares about
3562021-01-03T21:11:20  <andytoshi> and inputs
3572021-01-03T21:11:50  <andytoshi> i guess if i were to drop the witness data at parse-time in the indexer, the perf hit from that would probabyl not be measurable
3582021-01-03T21:12:09  <luke-jr> right, I would expect that's the case
3592021-01-03T21:12:24  <luke-jr> libblkmaker has some cheap code to drop it IIRC
3602021-01-03T21:12:47  <andytoshi> thanks, i'll check it out
3612021-01-03T21:14:40  <phantomcircuit> andytoshi, add an rpc to use the block filters on a set of elements?
3622021-01-03T21:14:52  <luke-jr> someone has a PR for that already
3632021-01-03T21:15:13  <luke-jr> seems like it'd be less efficient tho
3642021-01-03T21:15:49  <andytoshi> luke-jr: i think it would be more efficient than what i'm doing -- i'm asking Core to serialize whole blocks, send it to a nother process, and then i'm filtering there ... if i could ask Core to just do the filtering that should be way faster
3652021-01-03T21:16:12  <andytoshi> i'll track down that PR and test it
3662021-01-03T21:17:24  <luke-jr> #20664
3672021-01-03T21:17:27  <gribble> https://github.com/bitcoin/bitcoin/issues/20664 | Add scanblockfilters RPC call by jonasschnelli · Pull Request #20664 · bitcoin/bitcoin · GitHub
3682021-01-03T21:22:36  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
3692021-01-03T21:23:17  *** ovovo <ovovo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 260 seconds)
3702021-01-03T21:27:54  *** owowo <owowo!~ovovo@unaffiliated/ovovo> has joined #bitcoin-core-dev
3712021-01-03T21:35:12  <andytoshi> thanks! yeah this looks like exactly what i want
3722021-01-03T21:36:09  <phantomcircuit> luke-jr, unfortunately that's going to be using the existing block filters, which means recalculating the hash for each block
3732021-01-03T21:36:30  <luke-jr> phantomcircuit: ?
3742021-01-03T21:37:27  <sipa> phantomcircuit: not really an issue if you're only ever going to scan the last few blocks
3752021-01-03T21:38:37  <phantomcircuit> sipa, i mean andytoshi's original approach isn't really either
3762021-01-03T21:54:25  *** tralfaz <tralfaz!~davterra@23.226.131.132> has joined #bitcoin-core-dev
3772021-01-03T21:57:04  *** davterra <davterra!~davterra@23.226.131.131> has quit IRC (Ping timeout: 246 seconds)
3782021-01-03T21:59:46  *** davterra <davterra!~davterra@23.226.131.131> has joined #bitcoin-core-dev
3792021-01-03T21:59:49  *** tralfaz <tralfaz!~davterra@23.226.131.132> has quit IRC (Read error: Connection reset by peer)
3802021-01-03T22:01:16  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Ping timeout: 246 seconds)
3812021-01-03T22:02:24  *** filchef <filchef!~filchef@89.253.179.83> has quit IRC (Read error: Connection reset by peer)
3822021-01-03T22:20:50  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
3832021-01-03T22:22:01  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
3842021-01-03T22:22:37  *** Matt_P <Matt_P!~Matt_P@185.204.1.185> has quit IRC (Remote host closed the connection)
3852021-01-03T22:22:50  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
3862021-01-03T22:23:39  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
3872021-01-03T22:25:38  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
3882021-01-03T22:26:34  *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
3892021-01-03T22:28:38  *** tralfaz <tralfaz!~davterra@23.226.131.131> has joined #bitcoin-core-dev
3902021-01-03T22:29:43  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
3912021-01-03T22:31:06  *** davterra <davterra!~davterra@23.226.131.131> has quit IRC (Ping timeout: 256 seconds)
3922021-01-03T22:31:27  *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
3932021-01-03T22:35:46  *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has joined #bitcoin-core-dev
3942021-01-03T22:42:42  *** greylica <greylica!~greylica@139.28.218.148> has joined #bitcoin-core-dev
3952021-01-03T23:20:40  *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
3962021-01-03T23:23:04  *** user__ <user__!~davterra@ool-2f14817b.dyn.optonline.net> has joined #bitcoin-core-dev
3972021-01-03T23:24:43  *** davterra <davterra!~davterra@23.226.131.131> has joined #bitcoin-core-dev
3982021-01-03T23:25:35  *** tralfaz <tralfaz!~davterra@23.226.131.131> has quit IRC (Ping timeout: 256 seconds)
3992021-01-03T23:28:04  *** user__ <user__!~davterra@ool-2f14817b.dyn.optonline.net> has quit IRC (Ping timeout: 272 seconds)
4002021-01-03T23:29:06  *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
4012021-01-03T23:51:54  *** tralfaz <tralfaz!~davterra@23.226.131.155> has joined #bitcoin-core-dev
4022021-01-03T23:54:40  *** davterra <davterra!~davterra@23.226.131.131> has quit IRC (Ping timeout: 272 seconds)