12021-01-04T00:01:18 *** samuel-pedraza <samuel-pedraza!47edaff3@gateway/web/cgi-irc/kiwiirc.com/ip.71.237.175.243> has quit IRC (Quit: Connection closed)
22021-01-04T00:11:44 *** davterra <davterra!~davterra@23.226.131.131> has joined #bitcoin-core-dev
32021-01-04T00:13:40 *** tralfaz <tralfaz!~davterra@23.226.131.155> has quit IRC (Ping timeout: 272 seconds)
42021-01-04T00:15:24 *** tralfaz <tralfaz!~davterra@23.226.131.131> has joined #bitcoin-core-dev
52021-01-04T00:17:18 *** davterra <davterra!~davterra@23.226.131.131> has quit IRC (Read error: Connection reset by peer)
62021-01-04T00:28:50 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
72021-01-04T00:29:13 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
82021-01-04T00:30:38 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has joined #bitcoin-core-dev
92021-01-04T00:53:41 *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has quit IRC (Quit: Find me in #TheHolyRoger or https://theholyroger.com)
102021-01-04T00:54:43 *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has joined #bitcoin-core-dev
112021-01-04T01:00:05 *** tralfaz <tralfaz!~davterra@23.226.131.131> has quit IRC (Quit: Leaving)
122021-01-04T01:06:10 <sipa> phantomcircuit: did you see my suggestion here: https://github.com/bitcoin/bitcoin/pull/20752#discussion_r549248791 ?
132021-01-04T01:08:03 *** samuel-pedraza <samuel-pedraza!47edaff3@gateway/web/cgi-irc/kiwiirc.com/ip.71.237.175.243> has joined #bitcoin-core-dev
142021-01-04T01:14:15 <phantomcircuit> sipa, i hadn't i've been otherwise occupied
152021-01-04T01:15:33 *** molz_ <molz_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
162021-01-04T01:17:27 <phantomcircuit> sipa, yeah that was going to be my adjustment, add a parameter that sets the runtime in wall clock time, (0 being forever)
172021-01-04T01:17:58 <phantomcircuit> also realized it should be displaying the output from each subprocess before they finish but that gets really messy so i was thinking about how to handle that
182021-01-04T01:18:09 <sipa> right
192021-01-04T01:18:16 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
202021-01-04T01:18:31 <phantomcircuit> afl just writes output from the subprocesses to logfiles which i guess is an option but also kind of hackey
212021-01-04T01:18:53 <phantomcircuit> i dont really have a better idea atm though
222021-01-04T01:36:42 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
232021-01-04T01:36:43 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
242021-01-04T01:36:43 *** vasild_ is now known as vasild
252021-01-04T01:39:36 <phantomcircuit> sipa, any ideas?
262021-01-04T01:40:09 <sipa> just send them to stderr?
272021-01-04T01:40:21 <sipa> or do you need to intercept them from python somehow?
282021-01-04T01:40:52 <phantomcircuit> the python script can read the output continuously and then write to whatever
292021-01-04T01:41:12 <phantomcircuit> writing directly to stderr is really confusing though cause none of the debug lines have any context
302021-01-04T01:41:38 <sipa> ah you want to add a prefix to indicate which fuzzer it's from?
312021-01-04T01:41:38 <phantomcircuit> i could write the PID but for long runs they won't be unique
322021-01-04T01:42:02 <phantomcircuit> i guess i could just assign each fuzzing process a longer than pid random id
332021-01-04T01:42:25 <sipa> i don't understand what the problem is or what you're trying to do
342021-01-04T01:42:33 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has quit IRC (Read error: Connection reset by peer)
352021-01-04T01:43:19 <phantomcircuit> sipa, it's just really confusing to have all the debug output from the fuzzers writing to stderr interleaved, but also it's not helpful to have it all buffered until the process exits
362021-01-04T01:43:31 <phantomcircuit> i guess that's pretty nitpickey
372021-01-04T01:46:49 <sipa> well give each some incrementally assigned id + description string (with the fuzz target name + config, if any part of it is variable)
382021-01-04T01:49:52 *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has quit IRC (Ping timeout: 258 seconds)
392021-01-04T02:29:28 *** matthewfreeze <matthewfreeze!ae7e34c0@174-126-52-192.cpe.sparklight.net> has joined #bitcoin-core-dev
402021-01-04T02:31:29 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
412021-01-04T02:32:26 *** davterra <davterra!~davterra@23.226.131.131> has joined #bitcoin-core-dev
422021-01-04T02:32:42 *** davterra <davterra!~davterra@23.226.131.131> has quit IRC (Remote host closed the connection)
432021-01-04T02:34:09 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 272 seconds)
442021-01-04T03:10:19 *** matthewfreeze <matthewfreeze!ae7e34c0@174-126-52-192.cpe.sparklight.net> has quit IRC (Remote host closed the connection)
452021-01-04T03:16:13 * fanquake descending into typo/spelling hell
462021-01-04T03:17:50 <luke-jr> fanqauke: hi
472021-01-04T03:22:21 <fanquake> ð¢
482021-01-04T03:43:59 *** hidrodo <hidrodo!76c811dd@118.200.17.221> has joined #bitcoin-core-dev
492021-01-04T03:57:08 <aj> fanquake: posting the blogs?
502021-01-04T04:06:36 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
512021-01-04T04:06:36 <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9a2400b57558...f52f427b8eec
522021-01-04T04:06:37 <bitcoin-git> bitcoin/master a0022f1 Sebastian Falbesoner: test: bump codespell linter version to 2.0.0
532021-01-04T04:06:37 <bitcoin-git> bitcoin/master da289a6 Sebastian Falbesoner: lint: update list of spelling linter false positives
542021-01-04T04:06:38 <bitcoin-git> bitcoin/master f3ba916 Sebastian Falbesoner: lint: ignore gitian keys file for spelling linter
552021-01-04T04:06:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
562021-01-04T04:06:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
572021-01-04T04:06:56 <bitcoin-git> [bitcoin] fanquake merged pull request #20817: lint: update list of spelling linter false positives, bump to codespell 2.0.0 (master...201212-lint-update-spelling-false-positives) https://github.com/bitcoin/bitcoin/pull/20817
582021-01-04T04:06:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
592021-01-04T04:09:22 <fanquake> aj: nah. That sounds much more productive
602021-01-04T04:37:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
612021-01-04T04:37:41 <bitcoin-git> [bitcoin] fanquake closed pull request #20810: doc: Update URLs to HTTPS where necessary (master...https-urls) https://github.com/bitcoin/bitcoin/pull/20810
622021-01-04T04:37:42 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
632021-01-04T04:38:11 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
642021-01-04T04:38:11 <bitcoin-git> [bitcoin] fanquake closed pull request #20836: doc: Corrected Typos in Documentation (master...doc-fix-typos) https://github.com/bitcoin/bitcoin/pull/20836
652021-01-04T04:38:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
662021-01-04T04:48:42 *** hidrodo <hidrodo!76c811dd@118.200.17.221> has quit IRC (Remote host closed the connection)
672021-01-04T05:04:27 *** mj_node <mj_node!~mj_node@202.187.154.51> has joined #bitcoin-core-dev
682021-01-04T05:11:21 *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has quit IRC (Remote host closed the connection)
692021-01-04T05:11:40 *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
702021-01-04T05:14:09 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
712021-01-04T05:22:54 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
722021-01-04T05:48:50 *** ant0x00 <ant0x00!df4676e2@223.70.118.226> has joined #bitcoin-core-dev
732021-01-04T05:49:19 *** ant0x00 <ant0x00!df4676e2@223.70.118.226> has quit IRC (Remote host closed the connection)
742021-01-04T05:59:21 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
752021-01-04T05:59:21 <bitcoin-git> [bitcoin] fanquake closed pull request #20762: doc: Fix some typos (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20762
762021-01-04T05:59:22 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
772021-01-04T06:07:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
782021-01-04T06:07:54 <bitcoin-git> [bitcoin] fanquake opened pull request #20842: docs: consolidate typo & url fixing (master...consolidate_typo_fixing) https://github.com/bitcoin/bitcoin/pull/20842
792021-01-04T06:07:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
802021-01-04T06:10:52 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
812021-01-04T06:14:55 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
822021-01-04T06:16:21 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
832021-01-04T06:27:01 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:c475:d20e:3db4:7e5b> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
842021-01-04T06:29:23 *** samuel-pedraza <samuel-pedraza!47edaff3@gateway/web/cgi-irc/kiwiirc.com/ip.71.237.175.243> has quit IRC (Quit: Connection closed)
852021-01-04T06:36:07 *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has quit IRC (Quit: Leaving)
862021-01-04T06:36:21 *** ghost43_ <ghost43_!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
872021-01-04T06:48:51 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@49.228.238.173> has joined #bitcoin-core-dev
882021-01-04T06:56:35 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 256 seconds)
892021-01-04T07:08:43 *** mj_node <mj_node!~mj_node@202.187.154.51> has quit IRC (Quit: Leaving)
902021-01-04T07:30:36 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
912021-01-04T07:33:55 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
922021-01-04T07:41:33 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
932021-01-04T07:42:24 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
942021-01-04T07:59:26 <jonasschnelli> achow101, sipa: for the 0.21.0rc4 mac signatures,... does it matter if I use the apple codesign_allocate tool for the signature? AFAIK that worked with sipas fix.
952021-01-04T08:04:31 <sipa> jonasschnelli: as far as we know, our (now patched) cctools codesign_allocate tool works identical to Apple's
962021-01-04T08:04:47 <jonasschnelli> ok
972021-01-04T08:09:28 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
982021-01-04T08:09:28 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f52f427b8eec...bc8ada1c1534
992021-01-04T08:09:28 <bitcoin-git> bitcoin/master fa749fb MarcoFalke: rpc: Replace boost::variant with std::variant for RPCArg.m_fallback
1002021-01-04T08:09:29 <bitcoin-git> bitcoin/master bc8ada1 MarcoFalke: Merge #20736: rpc: Replace boost::variant with std::variant for RPCArg.m_f...
1012021-01-04T08:09:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1022021-01-04T08:09:48 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1032021-01-04T08:09:48 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20736: rpc: Replace boost::variant with std::variant for RPCArg.m_fallback (master...2012-rpcStdVariant) https://github.com/bitcoin/bitcoin/pull/20736
1042021-01-04T08:09:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1052021-01-04T08:23:21 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 256 seconds)
1062021-01-04T08:26:19 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1072021-01-04T08:26:25 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Quit: Leaving)
1082021-01-04T08:34:57 *** virtu_ is now known as virtu
1092021-01-04T08:40:20 <jonasschnelli> sipa: we have to clear the depende cache to make your patch work,.. right? Getting an invalid signature
1102021-01-04T08:40:47 <jonasschnelli> (but I have the same hash as the others,... maybe no-one cleared the cache?)
1112021-01-04T08:40:58 <jonasschnelli> trying with empty cache
1122021-01-04T08:41:22 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
1132021-01-04T08:44:58 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@49.228.238.173> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
1142021-01-04T08:46:45 *** DeadWeen <DeadWeen!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
1152021-01-04T08:48:43 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Ping timeout: 240 seconds)
1162021-01-04T08:49:03 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Ping timeout: 240 seconds)
1172021-01-04T08:49:19 *** willcl_ark <willcl_ark!~quassel@cpc123780-trow7-2-0-cust177.18-1.cable.virginm.net> has quit IRC (Quit: Quit)
1182021-01-04T08:49:24 *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has quit IRC (Ping timeout: 240 seconds)
1192021-01-04T08:49:27 *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has joined #bitcoin-core-dev
1202021-01-04T08:50:19 *** willcl_ark <willcl_ark!~quassel@cpc123780-trow7-2-0-cust177.18-1.cable.virginm.net> has joined #bitcoin-core-dev
1212021-01-04T08:51:25 *** virtu <virtu!~virtu@gateway/tor-sasl/virtu> has joined #bitcoin-core-dev
1222021-01-04T08:52:29 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
1232021-01-04T09:03:47 <jonasschnelli> no.. it was't the cache
1242021-01-04T09:05:56 <jonasschnelli> getting invalid macOS signature
1252021-01-04T09:06:01 <jonasschnelli> What I did:
1262021-01-04T09:06:11 <jonasschnelli> - Built 0.21.0rc4 gitian macOS
1272021-01-04T09:06:47 <jonasschnelli> - Verified bitcoin-0.21.0rc4-osx-unsigned.tar.gz, got the correct 10ae57ee735cd2a894a75165082c384769da3b634eca9346b1d20585e1edfd0c
1282021-01-04T09:07:06 <jonasschnelli> Created the signature: ./detached-sig-create.sh -s "Bitcoin"
1292021-01-04T09:07:42 <jonasschnelli> used the signature to gbuild the signer: ./bin/gbuild --num-make 6 -j11 --memory 5000 --url bitcoin=/home/jonasschnelli/gitian/bitcoin --commit signature=v0.21.0rc4
1302021-01-04T09:08:30 <jonasschnelli> https://bitcoin.jonasschnelli.ch/bitcoin-osx-signed-rc4-invalid.dmg (invalid signature)
1312021-01-04T09:09:12 <jonasschnelli> https://bitcoin.jonasschnelli.ch/signature-osx-rc4-invalid.tar.gz (the detached signature)
1322021-01-04T09:09:19 <jonasschnelli> achow101, sipa ^
1332021-01-04T09:10:10 <jonasschnelli> (I upgraded to macOS 11 and updated XCode since I tested sipas fix on master)
1342021-01-04T09:10:33 <sipa> oh
1352021-01-04T09:10:45 <sipa> so things may have changed again...
1362021-01-04T09:11:12 <sipa> can you use achow"s signer and patched-cctools' codesign_allocate instead?
1372021-01-04T09:11:24 <jonasschnelli> I try that later on
1382021-01-04T09:11:46 <jonasschnelli> I'm not sure if the upgrade to macOS 11 did cause this)
1392021-01-04T09:11:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1402021-01-04T09:11:49 <bitcoin-git> [bitcoin] hebasto closed pull request #20824: build: Do not set _FORTIFY_SOURCE if it causes compiler warnings (master...210101-fortify) https://github.com/bitcoin/bitcoin/pull/20824
1412021-01-04T09:11:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1422021-01-04T09:16:14 <sipa> jonasschnelli: well, it seems likely
1432021-01-04T09:16:35 <sipa> maybe they "fixed" the issue we encountered earlier...
1442021-01-04T09:26:54 <jonasschnelli> That would mean rc3 would sign valid
1452021-01-04T09:27:33 <sipa> right
1462021-01-04T09:54:34 *** setpill <setpill!~setpill@unaffiliated/setpill> has joined #bitcoin-core-dev
1472021-01-04T09:57:10 *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f24de007b18ce44cd8d51bd.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
1482021-01-04T10:03:51 *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
1492021-01-04T10:07:19 *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 268 seconds)
1502021-01-04T10:08:46 *** belcher_ is now known as belcher
1512021-01-04T10:13:21 *** dviola <dviola!~diego@unaffiliated/dviola> has quit IRC (Quit: WeeChat 3.0)
1522021-01-04T10:18:38 *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has quit IRC (Ping timeout: 264 seconds)
1532021-01-04T10:19:23 *** dviola <dviola!~diego@unaffiliated/dviola> has joined #bitcoin-core-dev
1542021-01-04T10:33:09 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:71ff:303a:4980:438c> has joined #bitcoin-core-dev
1552021-01-04T10:34:24 *** TheRec <TheRec!~toto@drupal.org/user/146860/view> has quit IRC (Ping timeout: 256 seconds)
1562021-01-04T10:35:41 *** TheRec <TheRec!~toto@drupal.org/user/146860/view> has joined #bitcoin-core-dev
1572021-01-04T10:46:23 *** greylica <greylica!~greylica@139.28.218.148> has quit IRC (Remote host closed the connection)
1582021-01-04T10:53:43 *** Tennis <Tennis!~Tennis@unaffiliated/tennis> has joined #bitcoin-core-dev
1592021-01-04T11:07:02 *** LoRez1 <LoRez1!~LoRez@185.204.1.185> has joined #bitcoin-core-dev
1602021-01-04T11:18:29 *** Marquise70Rice <Marquise70Rice!~Marquise7@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
1612021-01-04T11:31:42 *** TheRec <TheRec!~toto@drupal.org/user/146860/view> has quit IRC (Read error: Connection reset by peer)
1622021-01-04T11:32:55 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
1632021-01-04T11:33:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1642021-01-04T11:33:08 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20844: test: Add sanitizer suppressions for AMD EPYC CPUs (master...2101-testEpycSan) https://github.com/bitcoin/bitcoin/pull/20844
1652021-01-04T11:33:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1662021-01-04T11:36:35 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:143:71ff:303a:4980:438c> has quit IRC (Read error: Connection reset by peer)
1672021-01-04T11:48:36 *** Marquise70Rice <Marquise70Rice!~Marquise7@static.57.1.216.95.clients.your-server.de> has quit IRC (Ping timeout: 240 seconds)
1682021-01-04T11:53:04 *** TheRec <TheRec!~toto@drupal.org/user/146860/view> has quit IRC (Read error: Connection reset by peer)
1692021-01-04T11:53:19 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
1702021-01-04T11:55:56 *** TheRec <TheRec!~toto@drupal.org/user/146860/view> has quit IRC (Read error: Connection reset by peer)
1712021-01-04T11:56:47 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
1722021-01-04T12:01:07 *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f24de007b18ce44cd8d51bd.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
1732021-01-04T12:02:27 *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f24de00bc904d4378a56acd.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
1742021-01-04T12:12:55 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408> has joined #bitcoin-core-dev
1752021-01-04T12:16:00 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Remote host closed the connection)
1762021-01-04T12:16:19 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
1772021-01-04T12:27:58 <jonasschnelli> signing rc3 gives me also an invalid signature
1782021-01-04T12:28:14 <jonasschnelli> (apple didn't fix the codesign_allocate difference in 11.16 then)
1792021-01-04T12:33:55 <jonasschnelli> achow101: can you also try to sign rc4 with your dummy certificate? Just to see if the error is on my end.
1802021-01-04T12:34:03 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
1812021-01-04T12:34:58 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1822021-01-04T12:43:50 *** Aaronvan_ <Aaronvan_!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1832021-01-04T12:43:57 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 268 seconds)
1842021-01-04T12:48:14 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
1852021-01-04T12:49:52 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
1862021-01-04T12:50:45 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
1872021-01-04T12:52:12 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
1882021-01-04T12:53:44 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
1892021-01-04T12:54:17 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
1902021-01-04T13:08:07 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
1912021-01-04T13:18:28 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1922021-01-04T13:19:18 *** Aaronvan_ <Aaronvan_!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 256 seconds)
1932021-01-04T13:19:46 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
1942021-01-04T13:36:36 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
1952021-01-04T13:36:37 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
1962021-01-04T13:36:39 *** vasild_ is now known as vasild
1972021-01-04T13:40:57 *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has quit IRC (Quit: Find me in #TheHolyRoger or https://theholyroger.com)
1982021-01-04T13:41:38 *** TheHoliestRoger <TheHoliestRoger!~TheHolies@unaffiliated/theholiestroger> has joined #bitcoin-core-dev
1992021-01-04T13:55:15 <jonasschnelli> achow101, sipa: still getting invalid signatures. I tried using achow101't signapple tool, which worked locally, but attaching rc4 sig does not work (invalid sig). I guess this is due to sipas patch?
2002021-01-04T14:06:30 *** qwertzlcoatl <qwertzlcoatl!~qwertzlco@unaffiliated/qwertzlcoatl> has joined #bitcoin-core-dev
2012021-01-04T14:10:29 *** qwertzlcoatl <qwertzlcoatl!~qwertzlco@unaffiliated/qwertzlcoatl> has quit IRC (Client Quit)
2022021-01-04T14:12:54 <jonasschnelli> I'm also getting an invalid signature (rc4) when using achow101 tool, then apply the signature with the codesign_allocate binary from rc3.
2032021-01-04T14:15:50 <jonasschnelli> https://bitcoin.jonasschnelli.ch/valid_0.21.0rc4_sig_signapple.zip (contains the signature.tar.gz as well as binary that has a valid signature)
2042021-01-04T14:20:33 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
2052021-01-04T14:29:50 <MarcoFalke> jonasschnelli: Can you sign rc3 with the achow101 tool?
2062021-01-04T14:30:04 <MarcoFalke> rc3 doesn't have the sipa patch
2072021-01-04T14:30:21 <jonasschnelli> MarcoFalke. Let em try
2082021-01-04T14:31:34 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
2092021-01-04T14:35:31 <jonasschnelli> MarcoFalke: yes. Signing rc3 works with achow101 tool.
2102021-01-04T14:35:48 <MarcoFalke> So let's just rever the sipa patch for rc5?
2112021-01-04T14:37:10 <jonasschnelli> I think so. Though switching to an new signing tool between rc's is not ideal but I don't see a different solution
2122021-01-04T14:38:24 <jonasschnelli> I'll try rc4 again... but I'm pretty sure I haven't made a mistake
2132021-01-04T14:38:27 <MarcoFalke> you could downgrade your mac? ;)
2142021-01-04T14:38:53 <jonasschnelli> I could,... or use a VM of my older state.
2152021-01-04T14:39:05 <jonasschnelli> But somehow I don't think it is the reason
2162021-01-04T14:40:52 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408> has joined #bitcoin-core-dev
2172021-01-04T14:40:58 <jonasschnelli> I try now on macOS 10.12.2
2182021-01-04T14:41:03 <jonasschnelli> (a VM is have ready)
2192021-01-04T14:43:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2202021-01-04T14:43:56 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20845: net: Log to net debug in MaybeDiscourageAndDisconnect except for noban and manual peers (master...2101-netLogDisconnect) https://github.com/bitcoin/bitcoin/pull/20845
2212021-01-04T14:44:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2222021-01-04T14:45:42 *** Jackielove4u <Jackielove4u!uid43977@gateway/web/irccloud.com/x-bamhammylzdpvfhb> has quit IRC (Ping timeout: 260 seconds)
2232021-01-04T14:46:17 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408> has quit IRC (Ping timeout: 260 seconds)
2242021-01-04T14:47:18 *** Jackielove4u <Jackielove4u!uid43977@gateway/web/irccloud.com/x-fqmqdesvfbargkli> has joined #bitcoin-core-dev
2252021-01-04T14:49:08 *** stackingcore21 <stackingcore21!~stackingc@2604:a880:2:d0::1bda:1001> has quit IRC (Remote host closed the connection)
2262021-01-04T14:49:58 *** stackingcore21 <stackingcore21!~stackingc@2604:a880:2:d0::1bda:1001> has joined #bitcoin-core-dev
2272021-01-04T14:51:44 *** Nee <Nee!5cc1aa0d@port-92-193-170-13.dynamic.as20676.net> has joined #bitcoin-core-dev
2282021-01-04T14:57:51 <jonasschnelli> sipa: I used a macOS 10.12 (older) VM and signed the 0.21.0rc4 there. Getting also an invalid signature after attaching the sig back in gitian.
2292021-01-04T14:59:45 <jonasschnelli> I tripple-checked bitcoin-0.21.0rc4-osx-unsigned.tar.gz that it contains your patch (verifiable here: https://bitcoin.jonasschnelli.ch/gitian/builds/388/build_osx.log)
2302021-01-04T15:09:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2312021-01-04T15:09:01 <bitcoin-git> [bitcoin] benthecarman opened pull request #20846: Add benthecarman to keys.txt (master...patch-1) https://github.com/bitcoin/bitcoin/pull/20846
2322021-01-04T15:09:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2332021-01-04T15:19:42 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2342021-01-04T15:19:42 <bitcoin-git> [bitcoin] darosior opened pull request #20847: gitian-keys: add darosior's key (master...darosior_gpg_key) https://github.com/bitcoin/bitcoin/pull/20847
2352021-01-04T15:19:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2362021-01-04T15:26:10 *** murr4y <murr4y!ali@38.95.231.35.bc.googleusercontent.com> has quit IRC (Remote host closed the connection)
2372021-01-04T15:26:40 *** murr4y <murr4y!ali@38.95.231.35.bc.googleusercontent.com> has joined #bitcoin-core-dev
2382021-01-04T15:28:44 *** alko89 <alko89!~alko89@unaffiliated/alko89> has quit IRC (Quit: ZNC 1.8.2 - https://znc.in)
2392021-01-04T15:29:24 *** alko89 <alko89!~alko89@unaffiliated/alko89> has joined #bitcoin-core-dev
2402021-01-04T15:35:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2412021-01-04T15:35:46 <bitcoin-git> [bitcoin] theStack opened pull request #20848: Add gitian PGP key for theStack (master...add_gitian_pgp_key_for_theStack) https://github.com/bitcoin/bitcoin/pull/20848
2422021-01-04T15:35:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2432021-01-04T15:37:31 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408> has joined #bitcoin-core-dev
2442021-01-04T15:37:36 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408> has quit IRC (Client Quit)
2452021-01-04T15:38:49 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408> has joined #bitcoin-core-dev
2462021-01-04T15:39:47 *** lightlike <lightlike!~lightlike@p200300c7ef0f030055ccb2e7ff848937.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
2472021-01-04T15:42:54 *** jespada <jespada!~jespada@90.254.245.49> has joined #bitcoin-core-dev
2482021-01-04T15:48:01 <wumpus> oh noo not more macos signing issues ð¢
2492021-01-04T15:50:55 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
2502021-01-04T15:58:07 <jonasschnelli> wumpus: sadly,... but I tripple checked everything. I guess sipas patch does not work for rc4 (it did for master a while ago when I tested it)
2512021-01-04T15:58:53 <jonasschnelli> I'd like achow101 and sipa to confirm that its not working and we might need to switch to achow101 signapple tool for rc5 (revert sipas codesign_allocate patch)
2522021-01-04T16:00:13 <MarcoFalke> Could you also check if rc1 on the 0.19 and 0.20 branch work
2532021-01-04T16:00:27 <MarcoFalke> I think they haven't been released either
2542021-01-04T16:01:43 <wumpus> jonasschnelli: if using achow101's tool makes the process more reliable I'm all for that tbh
2552021-01-04T16:02:22 <wumpus> it feels more like gambling than engineering at this point :)
2562021-01-04T16:03:59 <wumpus> MarcoFalke: yea I think it makes sense to be sure we can do this reliably, then move on with the other releaes, instead of spreading out the experimentation over multiple branches
2572021-01-04T16:04:52 <MarcoFalke> if it works, we can close #20738 and #20739
2582021-01-04T16:04:54 <gribble> https://github.com/bitcoin/bitcoin/issues/20738 | [0.20] final rc2 backports by MarcoFalke · Pull Request #20738 · bitcoin/bitcoin · GitHub
2592021-01-04T16:04:55 <gribble> https://github.com/bitcoin/bitcoin/issues/20739 | [0.19] final rc2 backports by MarcoFalke · Pull Request #20739 · bitcoin/bitcoin · GitHub
2602021-01-04T16:09:32 <wumpus> you mean merge?
2612021-01-04T16:09:48 <wumpus> (there's more in there than the macos signing)
2622021-01-04T16:10:19 <MarcoFalke> only some minor doc fixups in the 0.20 one
2632021-01-04T16:14:49 *** BlueMatt <BlueMatt!~BlueMatt@unaffiliated/bluematt> has joined #bitcoin-core-dev
2642021-01-04T16:14:53 <BlueMatt> is it expected that new versions of core (0.20.1, I guess?) will send tx invs even if you set fRelay to false in the version message and never send a filter?
2652021-01-04T16:15:15 <BlueMatt> I suddenly see a *ton* of nodes violating fRelay
2662021-01-04T16:15:24 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408> has joined #bitcoin-core-dev
2672021-01-04T16:21:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2682021-01-04T16:21:29 <bitcoin-git> [bitcoin] marcinja closed pull request #14053: Add address-based index (attempt 4?) (master...add-address-index) https://github.com/bitcoin/bitcoin/pull/14053
2692021-01-04T16:21:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2702021-01-04T16:24:35 <jonatack> BlueMatt: hm, iirc no except bloom filterload/clear
2712021-01-04T16:25:27 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2722021-01-04T16:25:27 <bitcoin-git> [bitcoin] vasild opened pull request #20849: net: disconnect peers by address without using a subnet (master...disconnect_by_subnet_fix) https://github.com/bitcoin/bitcoin/pull/20849
2732021-01-04T16:25:28 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2742021-01-04T16:28:35 <BlueMatt> oh, nevermind
2752021-01-04T16:35:28 *** setpill <setpill!~setpill@unaffiliated/setpill> has quit IRC (Quit: o/)
2762021-01-04T16:39:59 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2772021-01-04T16:39:59 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20850: [0.21] final rc5 backports (0.21...2101-21rc5) https://github.com/bitcoin/bitcoin/pull/20850
2782021-01-04T16:40:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2792021-01-04T16:44:33 <wumpus> that's fast for final rc5 backports :)
2802021-01-04T16:45:15 <wumpus> does this mean we should just give up rc4?
2812021-01-04T16:45:23 <MarcoFalke> probably, heh
2822021-01-04T16:46:29 <luke-jr> XD
2832021-01-04T16:46:38 *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has quit IRC (Remote host closed the connection)
2842021-01-04T16:47:02 <vasild> There is a similar issue as #20849 in banman: BanMan::Ban(const CNetAddr& net_addr, ...) { CSubNet sub_net(net_addr); Ban(sub_net, ...
2852021-01-04T16:47:04 <gribble> https://github.com/bitcoin/bitcoin/issues/20849 | net: disconnect peers by address without using a subnet by vasild · Pull Request #20849 · bitcoin/bitcoin · GitHub
2862021-01-04T16:47:06 <wumpus> it's a bit absurd, we really shouldn't have waited that long to do rc4
2872021-01-04T16:49:19 <MarcoFalke> it slipped the pre-holiday window. If the release doesn't go out before Dec 14th, it is best to wait till January
2882021-01-04T16:49:29 <wumpus> would have found this new signing issue so much faster
2892021-01-04T16:49:40 <MarcoFalke> Ok, that is true
2902021-01-04T16:49:51 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
2912021-01-04T16:49:53 <vasild> jonatack: when I extended CNetAddr to support longer-than-16-bytes addresses (as part of bip155) I also changed CSubNet to only handle ipv4 and ipv6 addresses - because it contains char netmask[16]; it makes no sense to apply it to e.g. 32 byte torv3 address
2922021-01-04T16:50:05 <jonatack> If help docs are eligible for 0.21.0rc5, #20829 targets 0.21 and has a couple acks
2932021-01-04T16:50:06 <MarcoFalke> (was referring to the -final tag)
2942021-01-04T16:50:07 <gribble> https://github.com/bitcoin/bitcoin/issues/20829 | doc: add -netinfo help by jonatack · Pull Request #20829 · bitcoin/bitcoin · GitHub
2952021-01-04T16:50:33 <jonatack> vasild: yes, thank you, that occurred to me right after checking git blame
2962021-01-04T16:50:34 <vasild> In general, subnetting only makes sense for ipv4 and ipv6
2972021-01-04T16:51:41 <wumpus> it makes sense for none of the other networks that we support at least
2982021-01-04T16:52:12 <vasild> but I failed to verify the callers of the constructor CSubNet(CNetAddr&) which used to create one-host-subnet before and would also "work" for torv2 addresses (in the code before bip155) by matching a single address
2992021-01-04T16:52:45 <wumpus> good to catch that before the release
3002021-01-04T16:53:17 <vasild> MarcoFalke: found the issue somehow :)
3012021-01-04T16:53:20 <MarcoFalke> It is not super critical, but still a nice to have fix
3022021-01-04T16:53:52 <wumpus> yes
3032021-01-04T16:53:53 <achow101> jonasschnelli: can you upload codesign's result?
3042021-01-04T16:53:54 *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has joined #bitcoin-core-dev
3052021-01-04T16:53:54 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408> has joined #bitcoin-core-dev
3062021-01-04T16:54:01 *** davterra <davterra!~davterra@23.226.131.155> has joined #bitcoin-core-dev
3072021-01-04T16:54:08 *** davterra <davterra!~davterra@23.226.131.155> has quit IRC (Remote host closed the connection)
3082021-01-04T16:54:30 <vasild> fixing banman will not be as easy as https://github.com/bitcoin/bitcoin/issues/20849
3092021-01-04T16:54:44 <achow101> given that the signapple result is giving a vmsize of 0x7b000, I think apple fixed codesign_allocate
3102021-01-04T16:54:48 <vasild> because banman uses "std::map<CSubNet, CBanEntry>" - it only bans subnets
3112021-01-04T16:56:38 *** BlueMatt <BlueMatt!~BlueMatt@unaffiliated/bluematt> has left #bitcoin-core-dev ("Ex-Chat")
3122021-01-04T17:01:32 *** da39a3ee5e6b4b0d <da39a3ee5e6b4b0d!~da39a3ee5@2403:6200:8876:12e2:f4f0:d2c0:3ecf:a408> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
3132021-01-04T17:04:40 *** kexkey <kexkey!~kexkey@static-198-54-132-155.cust.tzulo.com> has joined #bitcoin-core-dev
3142021-01-04T17:09:20 <vasild> I am inclined to restore the "nonsensical" subnetting of non-IPv[46] networks by assuming one-host-subnet for those
3152021-01-04T17:09:59 <vasild> banman only knows how to ban subnets and also de/serializes to disk CSubNet objects
3162021-01-04T17:11:04 <achow101> jonasschnelli: it seems that codesign_allocate has changed back to what we were expecting it to do
3172021-01-04T17:11:45 <vasild> ideally banman should have a list of banned subnets (CSubNet) + a list of banned hosts (CNetAddr), but that would mean changing the disk format of the banlist
3182021-01-04T17:12:04 <sipa> vasild: is this something we need to fix for 0.21?
3192021-01-04T17:12:13 <sipa> i assume so?
3202021-01-04T17:12:38 <vasild> yes, I guess so, otherwise we don't know how to ban non-ipv46 addresses
3212021-01-04T17:13:22 <MarcoFalke> If the fix is too involved, we can document it as known bug and fix in 0.21.1
3222021-01-04T17:13:26 <vasild> allowing CSubNet of non-ip addresses seems like a smaller change than banman disk format
3232021-01-04T17:13:29 <sipa> it"s not like banning tor addresses means much, as they can't occur on incoming connections
3242021-01-04T17:13:53 <vasild> that's right
3252021-01-04T17:14:03 <MarcoFalke> jup, it is even more a "just nice to have" fix
3262021-01-04T17:14:26 <sipa> what happens if you try?
3272021-01-04T17:14:44 <jonasschnelli> achow101: I also tried with MacOS 10.12 (can upload that as well). Iâm afk for 2h,... will upload more later.
3282021-01-04T17:14:55 <vasild> banlist.dat + banhosts.dat - have two separate lists and two separate files (not changing the format of banlist.dat), what about that?
3292021-01-04T17:15:13 <sipa> vasild: shouldn't be needed
3302021-01-04T17:15:35 <sipa> vasild: there was also some desire to support banning by ASN
3312021-01-04T17:15:45 <sipa> which will require further changes anyway
3322021-01-04T17:15:55 <vasild> sipa: if you try to ban a tor address it would store an invalid CSubNet in banman which matches nothing, e.g. the address will not be banned
3332021-01-04T17:16:21 <sipa> ok, not terrible... i'm ok with either
3342021-01-04T17:16:51 <sipa> if it's easy to restore csubnet support for other networks, that seems like reasonable (temporary) fix
3352021-01-04T17:16:58 <sipa> we can also leave it be
3362021-01-04T17:17:30 *** alko89 <alko89!~alko89@unaffiliated/alko89> has quit IRC (Quit: ZNC 1.8.2 - https://znc.in)
3372021-01-04T17:18:22 <achow101> jonasschnelli: I think codesign and codesign_allocate versions aren't tied to the os version
3382021-01-04T17:19:02 <achow101> at least codesign_allocate is part of some xcode command line developer tools package
3392021-01-04T17:19:06 <sipa> jonasschnelli: i can't explain why signing with applesign doesn't work though, unless you also used codesign_allocate from apple.for thaf
3402021-01-04T17:19:11 <sipa> * for that
3412021-01-04T17:20:18 *** alko89 <alko89!~alko89@unaffiliated/alko89> has joined #bitcoin-core-dev
3422021-01-04T17:25:26 *** alko89 <alko89!~alko89@unaffiliated/alko89> has quit IRC (Quit: ZNC 1.8.2 - https://znc.in)
3432021-01-04T17:25:44 *** alko89 <alko89!~alko89@unaffiliated/alko89> has joined #bitcoin-core-dev
3442021-01-04T17:32:09 <wumpus> vasild: sounds like the most generic solution to me, to define that a 'subnet' for other networks is always a single address, and keep the rest of the code the same
3452021-01-04T17:33:13 <wumpus> otherwise you'd have essentially to change all the code using subnets to be CSubnet-or-separate-address
3462021-01-04T17:33:19 <achow101> sipa: I think jonasschnelli used the macports codesign_allocate which will now behave differently to our codesign_allocate
3472021-01-04T17:34:18 <sipa> gah
3482021-01-04T17:34:25 <sipa> wumpus: indeed
3492021-01-04T17:35:36 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
3502021-01-04T17:35:52 *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f24de00bc904d4378a56acd.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
3512021-01-04T17:50:24 <achow101> sipa, jonasschnelli: If I revert the patch to cctools, I am able to attach the signature and get a valid result
3522021-01-04T17:50:36 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3532021-01-04T17:50:36 <bitcoin-git> [bitcoin] vasild opened pull request #20852: net: allow CSubNet of non-IP networks (master...non_ip_subnets) https://github.com/bitcoin/bitcoin/pull/20852
3542021-01-04T17:50:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3552021-01-04T17:50:58 <sipa> achow101: then why did jonasschnelli' rc3 signing fail too?
3562021-01-04T17:51:19 <sipa> still, let's revert my patch
3572021-01-04T17:51:43 <sipa> it shouldn't be needed anymore in the longer term anyway with applesign (using matching cctools/macports is probably easiest for codesign_allocate)
3582021-01-04T17:51:57 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
3592021-01-04T17:52:40 <achow101> sipa: jonasschnelli may have done it incorrectly. Properly getting the detached-sig-apply.sh script to use the right codesign_allocate is slightly tricky
3602021-01-04T17:53:15 <achow101> I did it wrong a few times before I figured out I needed to re-pack the tarball with the correct codesign_allocate as the script will unpack it again itself
3612021-01-04T17:53:33 <sipa> ah, ok!
3622021-01-04T17:53:35 <vasild> wumpus: indeed, here it is: https://github.com/bitcoin/bitcoin/pull/20852
3632021-01-04T17:54:02 <achow101> sipa: I think this problem just highlights the fact that signapple needs to implement this allocation stuff too
3642021-01-04T17:54:29 <achow101> but modifying macho bins to insert another load command seems to be non-trivial
3652021-01-04T17:54:43 <vasild> "if it's easy to restore csubnet support for other networks, that seems like reasonable (temporary) fix" -- sipa, done in ^ it is maybe not too complicated
3662021-01-04T17:55:00 <sipa> vasild: looks reasonable, will review in more detail
3672021-01-04T17:55:21 <vasild> ok :)
3682021-01-04T17:55:28 * vasild afk
3692021-01-04T17:57:07 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Quit: The Lounge - https://thelounge.chat)
3702021-01-04T18:01:34 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
3712021-01-04T18:01:34 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Remote host closed the connection)
3722021-01-04T18:05:01 <achow101> I think if we are going to use signapple instead of codesign, then we should build codesign_allocate for mac and include it in the tarball. That way we don't rely on the signer to remember to use macports
3732021-01-04T18:05:23 <sipa> achow101: yeah
3742021-01-04T18:05:26 <sipa> good idea
3752021-01-04T18:05:35 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
3762021-01-04T18:05:35 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Remote host closed the connection)
3772021-01-04T18:05:35 *** pergaminho <pergaminho!~Cleber@189.26.121.248> has joined #bitcoin-core-dev
3782021-01-04T18:05:59 <achow101> at least until I implement allocation
3792021-01-04T18:06:58 *** jeremyrubin <jeremyrubin!~jr@2601:645:c200:14:91a5:d8cb:fe32:d136> has joined #bitcoin-core-dev
3802021-01-04T18:07:12 *** samuel-pedraza <samuel-pedraza!a5169307@gateway/web/cgi-irc/kiwiirc.com/ip.165.22.147.7> has joined #bitcoin-core-dev
3812021-01-04T18:07:45 *** stackingcore21 <stackingcore21!~stackingc@2604:a880:2:d0::1bda:1001> has quit IRC (Remote host closed the connection)
3822021-01-04T18:08:40 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
3832021-01-04T18:08:58 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Client Quit)
3842021-01-04T18:09:22 *** niftynei_ is now known as niftynei
3852021-01-04T18:09:29 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
3862021-01-04T18:10:17 *** stackingcore21 <stackingcore21!~stackingc@2604:a880:2:d0::1bda:1001> has joined #bitcoin-core-dev
3872021-01-04T18:10:32 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Client Quit)
3882021-01-04T18:11:24 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
3892021-01-04T18:11:24 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Remote host closed the connection)
3902021-01-04T18:12:25 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
3912021-01-04T18:12:25 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has quit IRC (Remote host closed the connection)
3922021-01-04T18:16:00 *** sr_gi <sr_gi!~sr_gi@80.174.218.168.dyn.user.ono.com> has joined #bitcoin-core-dev
3932021-01-04T18:27:00 *** andytoshi <andytoshi!~apoelstra@unaffiliated/andytoshi> has quit IRC (Ping timeout: 256 seconds)
3942021-01-04T18:33:20 *** andytoshi <andytoshi!~apoelstra@unaffiliated/andytoshi> has joined #bitcoin-core-dev
3952021-01-04T18:43:45 <jonasschnelli> <achow101> sipa: jonasschnelli may have done it incorrectly. Properly getting the detached-sig-apply.sh script to use the right codesign_allocate is slightly tricky
3962021-01-04T18:44:05 <jonasschnelli> ^ the codesign_allocate is part of the bitcoin-0.21.0rc3-osx-unsigned.tar.gz? right?
3972021-01-04T18:44:40 <jonasschnelli> the detached-sig-apply.sh takes the binary in bitcoin-0.21.0rc3-osx-unsigned.tar.gz, right?
3982021-01-04T18:45:05 <sipa> hmm yes, i would expect it to
3992021-01-04T18:46:59 <jonasschnelli> As for rc4: i tried on macOS 11, verified the hash of bitcoin-0.21.0rc4-osx-unsigned.tar.gz (matched the others), verified the patched codesign_allocate, signed locally, verified the signed app (ok), gbuilt the signer with the created signature (failed)
4002021-01-04T18:47:21 <jonasschnelli> I also tried by signing on a macOS 10.12 (relative old) VM. Same result.
4012021-01-04T18:47:48 <jonasschnelli> (codesign was already installed, I think that binary is not part of XCode)
4022021-01-04T18:48:36 *** davterra <davterra!~davterra@23.226.131.131> has joined #bitcoin-core-dev
4032021-01-04T18:49:44 <jonasschnelli> [18:19:06] <sipa> jonasschnelli: i can't explain why signing with applesign doesn't work though, unless you also used codesign_allocate from apple.for thaf
4042021-01-04T18:50:02 <jonasschnelli> ^ achow101 applesign tool only worked on rc3 AFAIK
4052021-01-04T18:50:18 *** samuel-pedraza <samuel-pedraza!a5169307@gateway/web/cgi-irc/kiwiirc.com/ip.165.22.147.7> has quit IRC (Quit: Connection closed)
4062021-01-04T18:52:05 <jonasschnelli> <achow101> I think if we are going to use signapple instead of codesign, then we should build codesign_allocate for mac and include it in the tarball. That way we don't rely on the signer to remember to use macports
4072021-01-04T18:53:13 <jonasschnelli> ^ absolutely agree. Otherwise we'd likely end up again with a invalid signature. Another option would be to verify the signature before committing (or at least refuse to finalise the signed dmg if it is invalid).
4082021-01-04T18:53:37 <achow101> jonasschnelli: did you repack the tarball after changing codesign_allocate?
4092021-01-04T18:53:58 <jonasschnelli> achow101: rc3 has the unpatched codesign_allocate,.. right?
4102021-01-04T18:54:11 <achow101> yes
4112021-01-04T18:54:37 <jonasschnelli> achow101: I have tested rc4 with a manually copied codesign_allocate from rc3 (manually copy during gbuild)
4122021-01-04T18:54:49 *** mably <mably!uid99779@gateway/web/irccloud.com/x-hfgkgvehibzegecx> has joined #bitcoin-core-dev
4132021-01-04T18:55:04 <achow101> how did you manually copy it?
4142021-01-04T18:55:13 <achow101> I tested by just running the apply script locally without gitian
4152021-01-04T18:55:14 <jonasschnelli> fiddled with the gitian .yml
4162021-01-04T18:55:24 <achow101> ah
4172021-01-04T18:55:55 <achow101> so detached-sig-apply.sh will untar the unsigned.tar.gz again and use the codesign_allocate it finds when it does that
4182021-01-04T18:56:25 <jonasschnelli> I added a step to copy/overwrite the codesign_allocate taken from inputs/ in the yml
4192021-01-04T18:56:50 <sipa> this all sounds very error prone, so hard to draw any conclusions
4202021-01-04T18:56:52 <achow101> so gitian-osx-signer.yml will untar it. then it runs detached-sig-apply.sh which untars it again into another dir and uses the stuff from that second one
4212021-01-04T18:57:45 <jonasschnelli> https://gist.githubusercontent.com/jonasschnelli/d744d3946ebe18ec64a46510d5cff967/raw/49de1f5e2de9a3ead2e7fcd2a1ccfc10eb6ead40/gistfile1.txt
4222021-01-04T18:58:11 <jonasschnelli> I placed codesign_allocate_ow in inputs to test with a codesign_allocate without the patch from sipa (rc3)
4232021-01-04T18:58:30 <jonasschnelli> Its all very error prone, ... I agree sipa
4242021-01-04T18:58:39 <sipa> let's revert my patch for rc5
4252021-01-04T18:58:43 <jonasschnelli> Just tell me what I should test and i'll provide you with all the files
4262021-01-04T18:59:34 <jonasschnelli> achow101's applesign works fine for rc3
4272021-01-04T18:59:43 <jonasschnelli> we might want to use it for rc5, yes
4282021-01-04T19:00:55 <jonasschnelli> achow101: in case you want to inspect the macOS 11 created signature for rc4 (that won't produce a valid signature with sipas patch during attach): https://bitcoin.jonasschnelli.ch/signature-osx-rc4-invalid.tar.gz
4292021-01-04T19:01:15 <MarcoFalke> did someone check rc1 on 0.19 and 0.20 ?
4302021-01-04T19:01:27 <jonasschnelli> Creating the signature for rc4 is not very error prone
4312021-01-04T19:01:28 <MarcoFalke> Just to make sure and not run into issues there as well
4322021-01-04T19:01:54 <jonasschnelli> MarcoFalke: yes. We should also test those.
4332021-01-04T19:03:41 <sipa> jonasschnelli: because this is all presumably due to alignment issues, there is a 50% chance that a given binary will just work, regardless of what approach is used
4342021-01-04T19:03:42 <jonasschnelli> I do a testrun with 0.19.2rc1
4352021-01-04T19:03:59 <jonasschnelli> sipa: I also have the feeling its that
4362021-01-04T19:04:03 <sipa> so we can't conclude that something will work because it has worked for another version in the past (absent better inspection of course0
4372021-01-04T19:06:18 <achow101> jonasschnelli: my point is that your change to the gitian .yml doesn't work because it doesn't change codesign_allocate for the second untar that the apply script does
4382021-01-04T19:08:04 <achow101> sipa: we do know that macOS codesign_allocate has reverted back to rounding to 0x1000 since the vmsize on rc4 is 0x7b000
4392021-01-04T19:09:18 <sipa> achow101: ah ok
4402021-01-04T19:10:38 <jonasschnelli> achow101: I guess you're right (my gitian [not]fix).
4412021-01-04T19:10:51 *** Nee <Nee!5cc1aa0d@port-92-193-170-13.dynamic.as20676.net> has quit IRC (Remote host closed the connection)
4422021-01-04T19:11:22 <achow101> jonasschnelli: yeah, it's very unintuitive. I made the same mistake several times when trying to test that
4432021-01-04T19:12:10 <jonasschnelli> So... I'll try again to test rc4 without sipas patch (with apples codesign)
4442021-01-04T19:12:24 <jonasschnelli> I might need to rebundle the tar file with the rc3 codesign_allocate
4452021-01-04T19:12:34 <achow101> you have to
4462021-01-04T19:12:35 <jonasschnelli> or set the CODESIGN_ALLOCATE env in gitian
4472021-01-04T19:12:42 <jonasschnelli> (would that work achow101?)
4482021-01-04T19:13:06 <jonasschnelli> since detached-sig-apply.sh L34
4492021-01-04T19:13:13 <achow101> that might work
4502021-01-04T19:13:30 <achow101> I hadn't considered that
4512021-01-04T19:14:01 <jonasschnelli> will do that test asap (tomorrow)
4522021-01-04T19:26:02 <jonasschnelli> achow101, sipa: rc4 without sipas patch works (with native apple codesign)
4532021-01-04T19:26:25 <jonasschnelli> I guess the whole fixing was a unnecessary roundtrip
4542021-01-04T19:26:35 <achow101> at least it tells us we can't trust apple
4552021-01-04T19:26:42 <jonasschnelli> heh... indeed
4562021-01-04T19:34:25 <sipa> ok great to hear
4572021-01-04T19:35:05 <jonasschnelli> 0.19.2rc1 works also (with apples macOS 11 codesign)
4582021-01-04T19:35:52 <jonasschnelli> If there would just be a way to check the version of apples codesign tool
4592021-01-04T19:36:28 <jonasschnelli> however,... it got fixed by apple... suckers!
4602021-01-04T19:36:40 <achow101> too bad they don't seem to put their version numbers anywhere
4612021-01-04T19:39:03 <jonasschnelli> MarcoFalke: there is nothing open for 0.19.2. Is there even need for a rc2?
4622021-01-04T19:43:38 <jonasschnelli> achow101: I pushed the 0.19.2rc1 sig (your turn for windows and tagging)
4632021-01-04T19:51:01 *** bjr <bjr!630a55a2@99-10-85-162.lightspeed.stlsmo.sbcglobal.net> has joined #bitcoin-core-dev
4642021-01-04T20:03:19 <wumpus> oh so this was one of those cases where 'just wait' was the correct solution, but we had no idea whether Apple saw it as a problem at all
4652021-01-04T20:03:43 <wumpus> let alone urgent enough to fix so quickly
4662021-01-04T20:03:53 <sipa> maybe some of our twitter ramblings got noticed :)
4672021-01-04T20:04:04 <sipa> or maybe they knew about it since a long time, and it only now got addressed
4682021-01-04T20:04:30 <wumpus> right you never know who was paying attention
4692021-01-04T20:10:47 *** bjr <bjr!630a55a2@99-10-85-162.lightspeed.stlsmo.sbcglobal.net> has quit IRC (Remote host closed the connection)
4702021-01-04T20:14:49 <luke-jr> wumpus: thoughts on release notes encouraging upgrading sooner rather than later to demonstrate a minimum lower bound on upgrade time for Taproot?
4712021-01-04T20:15:09 <luke-jr> ie, "upgrade asap to help prove we can deploy Taproot faster safely"
4722021-01-04T20:15:49 <luke-jr> (not limited to wumpus responding :P)
4732021-01-04T20:19:32 *** pinheadm_ <pinheadm_!~pinheadmz@68.161.139.178> has joined #bitcoin-core-dev
4742021-01-04T20:20:39 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
4752021-01-04T20:22:02 *** pinheadmz <pinheadmz!~pinheadmz@68.161.139.178> has quit IRC (Ping timeout: 256 seconds)
4762021-01-04T20:25:28 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC ()
4772021-01-04T20:29:48 <wumpus> luke-jr: no problem with that, but i'm not convinced that will give very useful information, how comparable is updating to a major version versus updating to a softfork
4782021-01-04T20:32:03 <wumpus> jonasschnelli: sure, we could tag 0.19.2 final, though i guess it still needs release notes?
4792021-01-04T20:32:27 <wumpus> doc/release-notes.md currently even speaks of 0.19.1
4802021-01-04T20:34:01 <luke-jr> wumpus: well, that's the idea - to try to get closer to the latter by asking users to upgrade as if it weree
4812021-01-04T20:34:10 <wumpus> I can update that, and the authors/changelog, but if dunno anyone wants to write anything else
4822021-01-04T20:47:22 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4832021-01-04T20:47:22 <bitcoin-git> [bitcoin] amitiuttarwar opened pull request #20854: [mempool] Remove unnecessary try-block (master...2021-01-load-mempool-cleanup) https://github.com/bitcoin/bitcoin/pull/20854
4842021-01-04T20:47:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4852021-01-04T20:48:03 *** pinheadmz <pinheadmz!~pinheadmz@68.161.139.178> has joined #bitcoin-core-dev
4862021-01-04T20:49:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4872021-01-04T20:49:44 <bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/e301a9fde351...33cbedef28eb
4882021-01-04T20:49:44 <bitcoin-git> bitcoin/0.19 33cbede Wladimir J. van der Laan: doc: Update release notes for 0.19.2
4892021-01-04T20:49:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4902021-01-04T20:50:07 *** pinheadm_ <pinheadm_!~pinheadmz@68.161.139.178> has quit IRC (Ping timeout: 246 seconds)
4912021-01-04T20:54:44 <wumpus> ok, release notes updated ^^ time to tag 0.19.2 final?
4922021-01-04T20:56:04 *** pinheadm_ <pinheadm_!~pinheadmz@68.161.139.178> has joined #bitcoin-core-dev
4932021-01-04T20:56:36 *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has quit IRC (Ping timeout: 256 seconds)
4942021-01-04T20:57:13 *** pinheadmz <pinheadmz!~pinheadmz@68.161.139.178> has quit IRC (Ping timeout: 264 seconds)
4952021-01-04T20:58:02 <luke-jr> wumpus et al: I added a paragraph to https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.21.0-Release-Notes-Draft
4962021-01-04T21:08:54 *** pergaminho <pergaminho!~Cleber@189.26.121.248> has quit IRC (Quit: Saindo)
4972021-01-04T21:09:43 *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
4982021-01-04T21:17:24 *** lightlike <lightlike!~lightlike@p200300c7ef0f030055ccb2e7ff848937.dip0.t-ipconnect.de> has quit IRC (Quit: Leaving)
4992021-01-04T21:25:20 *** LoRez1 <LoRez1!~LoRez@185.204.1.185> has quit IRC (Remote host closed the connection)
5002021-01-04T21:44:50 *** leoburd <leoburd!~leoburd@84.39.116.180> has joined #bitcoin-core-dev
5012021-01-04T22:16:05 *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 240 seconds)
5022021-01-04T22:24:31 *** randy-waterhouse <randy-waterhouse!~kiwigb@180.149.231.156> has joined #bitcoin-core-dev
5032021-01-04T22:38:34 *** randy-waterhouse <randy-waterhouse!~kiwigb@180.149.231.156> has quit IRC (Quit: Leaving.)
5042021-01-04T22:39:01 *** randy-waterhouse <randy-waterhouse!~kiwigb@180.149.231.156> has joined #bitcoin-core-dev
5052021-01-04T22:43:27 *** mably <mably!uid99779@gateway/web/irccloud.com/x-hfgkgvehibzegecx> has quit IRC (Quit: Connection closed for inactivity)
5062021-01-04T22:57:03 *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has quit IRC (Ping timeout: 240 seconds)
5072021-01-04T22:58:26 *** jb55 <jb55!~jb55@gateway/tor-sasl/jb55> has joined #bitcoin-core-dev
5082021-01-04T23:10:25 *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has quit IRC (Remote host closed the connection)
5092021-01-04T23:11:07 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
5102021-01-04T23:57:55 *** shesek <shesek!~shesek@unaffiliated/shesek> has joined #bitcoin-core-dev