12021-02-23T00:00:49 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 268 seconds)
22021-02-23T00:01:51 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
32021-02-23T00:06:29 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
42021-02-23T01:00:27 <ariard> /2
52021-02-23T01:23:32 *** copumpkin <copumpkin!~copumpkin@unaffiliated/copumpkin> has quit IRC (Quit: Bye!)
62021-02-23T01:27:38 *** copumpkin <copumpkin!~copumpkin@unaffiliated/copumpkin> has joined #bitcoin-core-dev
72021-02-23T01:37:27 *** side^effects <side^effects!~al|iss@gateway/tor-sasl/aliss/x-63218493> has joined #bitcoin-core-dev
82021-02-23T01:38:15 *** side^effects <side^effects!~al|iss@gateway/tor-sasl/aliss/x-63218493> has quit IRC (Remote host closed the connection)
92021-02-23T01:51:22 *** brg444_ <brg444_!uid207215@gateway/web/irccloud.com/x-rxlsvubfdfptqvib> has quit IRC (Quit: Connection closed for inactivity)
102021-02-23T02:02:20 *** TonyStone <TonyStone!~TonyStone@cpe-74-76-58-56.nycap.res.rr.com> has joined #bitcoin-core-dev
112021-02-23T02:21:36 *** troygiorshev <troygiorshev!~troygiors@d67-193-140-136.home3.cgocable.net> has quit IRC (Ping timeout: 240 seconds)
122021-02-23T02:27:17 *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
132021-02-23T02:28:44 *** troygiorshev <troygiorshev!~troygiors@d67-193-140-136.home3.cgocable.net> has joined #bitcoin-core-dev
142021-02-23T02:28:44 *** sr_gi <sr_gi!~sr_gi@static-125-62-230-77.ipcom.comunitel.net> has quit IRC (Read error: Connection reset by peer)
152021-02-23T02:29:09 *** sr_gi <sr_gi!~sr_gi@static-125-62-230-77.ipcom.comunitel.net> has joined #bitcoin-core-dev
162021-02-23T02:30:03 *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 246 seconds)
172021-02-23T02:42:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
182021-02-23T02:42:10 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7fca189a2a9a...64343a61105e
192021-02-23T02:42:11 <bitcoin-git> bitcoin/master 5e6df11 Carl Dong: guix: Add support for powerpc64{,le}
202021-02-23T02:42:12 <bitcoin-git> bitcoin/master 95990b9 Carl Dong: guix: Update conservative space requirements
212021-02-23T02:42:12 <bitcoin-git> bitcoin/master 64343a6 fanquake: Merge #21089: guix: Add support for powerpc64{,le}
222021-02-23T02:42:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
232021-02-23T02:42:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
242021-02-23T02:42:34 <bitcoin-git> [bitcoin] fanquake merged pull request #21089: guix: Add support for powerpc64{,le} (master...2021-02-guix-ppc64-support) https://github.com/bitcoin/bitcoin/pull/21089
252021-02-23T02:42:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
262021-02-23T02:52:16 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
272021-02-23T02:52:17 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/64343a61105e...3371758af49c
282021-02-23T02:52:17 <bitcoin-git> bitcoin/master a6a1b10 fanquake: guix: only download sources for hosts being built
292021-02-23T02:52:18 <bitcoin-git> bitcoin/master 3371758 fanquake: Merge #21078: guix: only download sources for hosts being built
302021-02-23T02:52:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
312021-02-23T02:52:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
322021-02-23T02:52:37 <bitcoin-git> [bitcoin] fanquake merged pull request #21078: guix: only download sources for hosts being built (master...guix_selective_download) https://github.com/bitcoin/bitcoin/pull/21078
332021-02-23T02:52:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
342021-02-23T02:55:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
352021-02-23T02:55:47 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3371758af49c...1e7dd584a5f9
362021-02-23T02:55:48 <bitcoin-git> bitcoin/master fa1f3a2 MarcoFalke: doc: Clarify that squashing should happen before review
372021-02-23T02:55:48 <bitcoin-git> bitcoin/master 1e7dd58 fanquake: Merge #21263: doc: Clarify that squashing should happen before review
382021-02-23T02:55:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
392021-02-23T02:56:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
402021-02-23T02:56:06 <bitcoin-git> [bitcoin] fanquake merged pull request #21263: doc: Clarify that squashing should happen before review (master...2102-docSquash) https://github.com/bitcoin/bitcoin/pull/21263
412021-02-23T02:56:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
422021-02-23T03:20:39 *** ArdeshirV <ArdeshirV!~Ardeshir@178.33.67.192> has joined #bitcoin-core-dev
432021-02-23T03:51:31 *** ArdeshirV <ArdeshirV!~Ardeshir@178.33.67.192> has quit IRC (Ping timeout: 260 seconds)
442021-02-23T04:14:46 *** smartineng <smartineng!~Icedove@88.135.18.171> has joined #bitcoin-core-dev
452021-02-23T04:27:48 *** sapan <sapan!460f1e80@70.15.30.128.res-cmts.sm.ptd.net> has quit IRC (Quit: Connection closed)
462021-02-23T05:05:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
472021-02-23T05:05:09 <bitcoin-git> [bitcoin] fanquake opened pull request #21274: assumptions: Assume C++17 (master...assuming_c++17) https://github.com/bitcoin/bitcoin/pull/21274
482021-02-23T05:05:10 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
492021-02-23T05:13:28 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 268 seconds)
502021-02-23T05:13:56 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
512021-02-23T05:14:35 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
522021-02-23T05:20:57 *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has quit IRC (Ping timeout: 264 seconds)
532021-02-23T05:21:49 *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
542021-02-23T05:35:20 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC ()
552021-02-23T05:37:53 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 260 seconds)
562021-02-23T05:38:08 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
572021-02-23T05:55:32 *** vBm1 <vBm1!~vBm@195.140.213.38> has quit IRC (Remote host closed the connection)
582021-02-23T06:06:36 *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has quit IRC (Ping timeout: 240 seconds)
592021-02-23T06:09:35 *** AstroDroid <AstroDroid!~AstroDroi@178.239.168.171> has joined #bitcoin-core-dev
602021-02-23T06:19:55 *** baldur <baldur!~baldur@pool-108-30-51-126.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
612021-02-23T07:14:06 *** Zenton <Zenton!~user@unaffiliated/vicenteh> has quit IRC (Read error: Connection reset by peer)
622021-02-23T07:14:22 *** Zenton <Zenton!~user@unaffiliated/vicenteh> has joined #bitcoin-core-dev
632021-02-23T07:16:43 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC ()
642021-02-23T07:27:40 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
652021-02-23T07:34:11 *** jungly <jungly!~jungly@host-82-61-129-61.retail.telecomitalia.it> has joined #bitcoin-core-dev
662021-02-23T07:35:50 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
672021-02-23T07:48:02 *** rh0nj <rh0nj!~rh0nj@88.99.167.175> has quit IRC (Remote host closed the connection)
682021-02-23T07:49:16 *** rh0nj <rh0nj!~rh0nj@88.99.167.175> has joined #bitcoin-core-dev
692021-02-23T07:51:28 *** dr-orlovsky <dr-orlovsky!~dr-orlovs@31.14.40.19> has joined #bitcoin-core-dev
702021-02-23T08:05:49 *** bsm1175321 <bsm1175321!~mcelrath@50-192-147-253-static.hfc.comcastbusiness.net> has quit IRC (Ping timeout: 256 seconds)
712021-02-23T08:08:17 <MarcoFalke> Time to block the spammer?
722021-02-23T08:08:47 <fanquake> âï¸
732021-02-23T08:09:19 <sipa> it is already done
742021-02-23T08:25:25 *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has quit IRC (Ping timeout: 240 seconds)
752021-02-23T08:26:24 *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
762021-02-23T08:36:27 *** AstroDroid <AstroDroid!~AstroDroi@178.239.168.171> has quit IRC (Remote host closed the connection)
772021-02-23T08:39:11 *** ddss3219 <ddss3219!2ff13e8f@47.241.62.143> has joined #bitcoin-core-dev
782021-02-23T08:39:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
792021-02-23T08:39:58 <bitcoin-git> [bitcoin] 4po opened pull request #21276: Update bitcoin.conf (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21276
802021-02-23T08:39:59 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
812021-02-23T08:40:18 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
822021-02-23T08:40:18 <bitcoin-git> [bitcoin] 4po closed pull request #21276: Update bitcoin.conf (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21276
832021-02-23T08:40:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
842021-02-23T08:40:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
852021-02-23T08:40:38 <bitcoin-git> [bitcoin] 4po reopened pull request #21276: Update bitcoin.conf (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21276
862021-02-23T08:40:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
872021-02-23T08:41:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
882021-02-23T08:41:03 <bitcoin-git> [bitcoin] fanquake closed pull request #21276: Update bitcoin.conf (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21276
892021-02-23T08:41:04 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
902021-02-23T08:49:55 <wumpus> spam spam spam
912021-02-23T08:52:32 <fanquake> wumpus: heh. I just opened this
922021-02-23T08:52:36 <fanquake> https://0bin.net/paste/nsxaCiHF#PmLBoAqCwaVai-q2YHbRY++8fXG1PFQuLWXaKzHNY7M
932021-02-23T08:53:22 <wumpus> fanquake: hehe good
942021-02-23T08:53:48 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
952021-02-23T08:54:03 <wumpus> it took the spammers quite long to discover the trick with using review comments, but unfortunately they're on to it now
962021-02-23T08:57:38 *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f1aca00533dd9f79e77799f.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
972021-02-23T09:02:16 *** Guest39974 <Guest39974!~ToBeFree@217.146.82.202> has joined #bitcoin-core-dev
982021-02-23T09:03:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
992021-02-23T09:03:37 <bitcoin-git> [bitcoin] S3RK opened pull request #21277: wallet: listdescriptors uses normalized descriptor form (master...listdescriptors_normalized) https://github.com/bitcoin/bitcoin/pull/21277
1002021-02-23T09:03:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1012021-02-23T09:12:07 *** jungly <jungly!~jungly@host-82-61-129-61.retail.telecomitalia.it> has quit IRC (Ping timeout: 256 seconds)
1022021-02-23T09:17:09 *** jungly <jungly!~jungly@host-82-61-129-61.retail.telecomitalia.it> has joined #bitcoin-core-dev
1032021-02-23T09:18:51 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
1042021-02-23T09:25:10 *** ddss3219 <ddss3219!2ff13e8f@47.241.62.143> has quit IRC (Quit: Connection closed)
1052021-02-23T09:26:58 *** queip <queip!~queip@unaffiliated/rezurus> has quit IRC (Remote host closed the connection)
1062021-02-23T09:30:13 *** queip <queip!~queip@unaffiliated/rezurus> has joined #bitcoin-core-dev
1072021-02-23T09:44:37 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 260 seconds)
1082021-02-23T09:59:49 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
1092021-02-23T10:02:19 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1102021-02-23T10:02:42 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1112021-02-23T10:07:30 *** elector <elector!~elector@gateway/tor-sasl/elector> has quit IRC (Remote host closed the connection)
1122021-02-23T10:07:41 *** elector <elector!~elector@gateway/tor-sasl/elector> has joined #bitcoin-core-dev
1132021-02-23T10:07:56 *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has quit IRC (Ping timeout: 240 seconds)
1142021-02-23T10:10:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1152021-02-23T10:10:35 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1e7dd584a5f9...d386b5423987
1162021-02-23T10:10:36 <bitcoin-git> bitcoin/master e348d7e Jarol Rodriguez: qt: Add Copy Address Action to Payment Requests
1172021-02-23T10:10:37 <bitcoin-git> bitcoin/master d386b54 MarcoFalke: Merge bitcoin-core/gui#213: qt: Add Copy Address Action to Payment Request...
1182021-02-23T10:10:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1192021-02-23T10:10:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1202021-02-23T10:10:55 <bitcoin-git> [gui] MarcoFalke merged pull request #213: qt: Add Copy Address Action to Payment Requests (master...add-copyaddress-requestedpayments) https://github.com/bitcoin-core/gui/pull/213
1212021-02-23T10:10:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1222021-02-23T10:16:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1232021-02-23T10:16:05 <bitcoin-git> [bitcoin] laanwj pushed 11 commits to master: https://github.com/bitcoin/bitcoin/compare/d386b5423987...c263c3d7d2a4
1242021-02-23T10:16:05 <bitcoin-git> bitcoin/master 19db590 gzhao408: [test] remove unnecessary OP_1s from CSV and CLTV tests
1252021-02-23T10:16:06 <bitcoin-git> bitcoin/master 0a76a39 gzhao408: [test] fix CSV test missing OP_ADD
1262021-02-23T10:16:07 <bitcoin-git> bitcoin/master 158a0b2 gzhao408: Apply maximal validation flags to tx_valid tests
1272021-02-23T10:16:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1282021-02-23T10:16:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1292021-02-23T10:16:23 <bitcoin-git> [bitcoin] laanwj merged pull request #19698: test: apply strict verification flags for transaction tests and assert backwards compatibility (master...test-verify-flags) https://github.com/bitcoin/bitcoin/pull/19698
1302021-02-23T10:16:24 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1312021-02-23T10:27:49 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
1322021-02-23T10:27:50 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
1332021-02-23T10:27:50 *** vasild_ is now known as vasild
1342021-02-23T10:33:26 <aj> jnewbery: hmm, wondering if i should add dandelion to the p2p topics or leave it 'til the next one
1352021-02-23T10:34:46 *** midnight <midnight!~midnight@unaffiliated/midnightmagic> has quit IRC (Ping timeout: 244 seconds)
1362021-02-23T10:39:32 *** midnight <midnight!~midnight@unaffiliated/midnightmagic> has joined #bitcoin-core-dev
1372021-02-23T10:45:54 *** nsh <nsh!~lol@wikipedia/nsh> has quit IRC (Quit: ZNC - http://znc.in)
1382021-02-23T10:47:32 *** nsh <nsh!~lol@wikipedia/nsh> has joined #bitcoin-core-dev
1392021-02-23T10:56:58 <jnewbery> aj: throw it on there. If we don't have time we can push it to the next meeting. We can also push one of my two back.
1402021-02-23T11:00:13 <hebasto> going to add a separate developer notes for Qt specific issues; which place is more appropriate doc/ or src/qt/ ?
1412021-02-23T11:08:32 <michaelfolkson> hebasto: I'd say doc. Where the developer notes are
1422021-02-23T11:09:08 <hebasto> michaelfolkson: thanks
1432021-02-23T11:09:45 <michaelfolkson> hebasto: Maybe call it developer-notes-qt.md ?
1442021-02-23T11:09:56 <michaelfolkson> That way they are next to eachother
1452021-02-23T11:10:47 <michaelfolkson> (alphabetically)
1462021-02-23T11:11:04 <hebasto> I see
1472021-02-23T11:11:57 *** Kiminuo <Kiminuo!~Kiminuo@141.98.103.212> has joined #bitcoin-core-dev
1482021-02-23T11:18:35 *** Madisyn13Rath <Madisyn13Rath!~Madisyn13@static.57.1.216.95.clients.your-server.de> has joined #bitcoin-core-dev
1492021-02-23T11:22:50 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1502021-02-23T11:36:47 <Kiminuo> wumpus, MarcoFalke: Hi, could you have a look if this PR https://github.com/bitcoin/bitcoin/pull/21244 is of any use?
1512021-02-23T11:40:09 *** Madisyn13Rath <Madisyn13Rath!~Madisyn13@static.57.1.216.95.clients.your-server.de> has quit IRC (Ping timeout: 264 seconds)
1522021-02-23T12:11:31 *** smartineng <smartineng!~Icedove@88.135.18.171> has quit IRC (Quit: smartineng)
1532021-02-23T12:15:18 *** smartineng <smartineng!~Icedove@88.135.18.171> has joined #bitcoin-core-dev
1542021-02-23T12:25:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1552021-02-23T12:25:57 <bitcoin-git> [gui] hebasto opened pull request #219: qt: Prevent the main window popup menu (master...210223-toolbar) https://github.com/bitcoin-core/gui/pull/219
1562021-02-23T12:25:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1572021-02-23T12:38:26 *** ghost43_ <ghost43_!~daer@gateway/tor-sasl/daer> has quit IRC (Remote host closed the connection)
1582021-02-23T12:38:44 *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
1592021-02-23T12:50:45 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
1602021-02-23T12:54:48 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 272 seconds)
1612021-02-23T12:59:45 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
1622021-02-23T13:02:58 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
1632021-02-23T13:04:22 *** belcher_ is now known as belcher
1642021-02-23T13:04:52 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1652021-02-23T13:04:54 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c263c3d7d2a4...84f6c695c6a2
1662021-02-23T13:04:55 <bitcoin-git> bitcoin/master c7b4648 fanquake: assumptions: assume a C++17 compiler
1672021-02-23T13:04:56 <bitcoin-git> bitcoin/master 5e531e6 fanquake: assumptions: check C++17 assumption with MSVC
1682021-02-23T13:04:57 <bitcoin-git> bitcoin/master 84f6c69 MarcoFalke: Merge #21274: assumptions: Assume C++17
1692021-02-23T13:04:59 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1702021-02-23T13:05:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1712021-02-23T13:05:17 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #21274: assumptions: Assume C++17 (master...assuming_c++17) https://github.com/bitcoin/bitcoin/pull/21274
1722021-02-23T13:05:18 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1732021-02-23T13:08:54 *** prayank <prayank!~andr0irc@2402:8100:2068:610a:e46a:56ed:5797:affc> has joined #bitcoin-core-dev
1742021-02-23T13:25:33 *** stevenro- <stevenro-!~steven@2001:19f0:6801:83a:40ba:67e:5c24:ed71> has quit IRC (Quit: ZNC 1.7.4 - https://znc.in)
1752021-02-23T13:26:19 *** stevenroose <stevenroose!~steven@2001:19f0:6801:83a:8d6a:4d01:704c:29f0> has joined #bitcoin-core-dev
1762021-02-23T13:30:27 *** Guest39974 <Guest39974!~ToBeFree@217.146.82.202> has quit IRC (Remote host closed the connection)
1772021-02-23T13:38:00 *** jonatack <jonatack!~jon@37.172.15.119> has joined #bitcoin-core-dev
1782021-02-23T13:38:24 *** bsm1175321 <bsm1175321!~mcelrath@50-192-147-253-static.hfc.comcastbusiness.net> has joined #bitcoin-core-dev
1792021-02-23T13:47:40 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Quit: Leaving)
1802021-02-23T13:50:51 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 268 seconds)
1812021-02-23T13:55:00 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
1822021-02-23T13:59:08 *** rex4539_ <rex4539_!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
1832021-02-23T13:59:44 *** rex4539_ <rex4539_!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Client Quit)
1842021-02-23T14:01:57 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 268 seconds)
1852021-02-23T14:08:41 *** tomkap1 <tomkap1!~tomkap@178.239.168.171> has joined #bitcoin-core-dev
1862021-02-23T14:09:05 *** esotericnonsense <esotericnonsense!~esotericn@unaffiliated/esotericnonsense> has quit IRC (Ping timeout: 240 seconds)
1872021-02-23T14:24:12 <gleb> jnewbery: Could you give me a slot at the start to talk about erlay update? No discussion, just updating folks. I can only attend only the first half of the meeting that's why asking in advance
1882021-02-23T14:26:01 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
1892021-02-23T14:27:47 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
1902021-02-23T14:27:55 *** realname192 <realname192!~real@37.160.35.244> has joined #bitcoin-core-dev
1912021-02-23T14:30:18 *** realname192 <realname192!~real@37.160.35.244> has quit IRC (Client Quit)
1922021-02-23T14:30:26 *** realnam193 <realnam193!~real@37.160.35.244> has joined #bitcoin-core-dev
1932021-02-23T14:34:50 *** prayank <prayank!~andr0irc@2402:8100:2068:610a:e46a:56ed:5797:affc> has quit IRC (Ping timeout: 264 seconds)
1942021-02-23T14:40:17 <jnewbery> gleb: of course
1952021-02-23T14:40:25 <gleb> thank you!
1962021-02-23T14:41:35 *** realname194 <realname194!~real@37.160.35.244> has joined #bitcoin-core-dev
1972021-02-23T14:45:21 *** realnam193 <realnam193!~real@37.160.35.244> has quit IRC (Ping timeout: 265 seconds)
1982021-02-23T14:46:17 <wumpus> fanquake: AKZ98 is a new spammer? (what a coincidence just after banning the last one)
1992021-02-23T14:56:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2002021-02-23T14:56:39 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #21279: scripted-diff: Regenerate key_io data deterministically (master...2102-testDetGen) https://github.com/bitcoin/bitcoin/pull/21279
2012021-02-23T14:56:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2022021-02-23T14:59:09 *** jonatack <jonatack!~jon@37.172.15.119> has quit IRC (Quit: jonatack)
2032021-02-23T14:59:09 *** sr_gi <sr_gi!~sr_gi@static-125-62-230-77.ipcom.comunitel.net> has quit IRC (Read error: Connection reset by peer)
2042021-02-23T14:59:23 <wumpus> it follows the same naming scheme as PS113, so i guess it's the same spammer and it's coordinated somehow, we might want to contact github admin adbout this
2052021-02-23T14:59:43 *** sr_gi <sr_gi!~sr_gi@static-125-62-230-77.ipcom.comunitel.net> has joined #bitcoin-core-dev
2062021-02-23T15:04:07 <gleb> Wait, p2p meeting is not now?
2072021-02-23T15:04:48 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2082021-02-23T15:04:49 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/84f6c695c6a2...78effb37f35f
2092021-02-23T15:04:49 <bitcoin-git> bitcoin/master faf48f2 MarcoFalke: log: Clarify log message when file does not exist
2102021-02-23T15:04:50 <bitcoin-git> bitcoin/master 78effb3 MarcoFalke: Merge #21222: log: Clarify log message when file does not exist
2112021-02-23T15:04:52 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2122021-02-23T15:05:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2132021-02-23T15:05:08 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #21222: log: Clarify log message when file does not exist (master...2102-logFile) https://github.com/bitcoin/bitcoin/pull/21222
2142021-02-23T15:05:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2152021-02-23T15:08:08 <ariard> gleb: I think we're trying a different schedule (21utc) to fit folks on the other side of the earth
2162021-02-23T15:09:13 <gleb> ariard: ah okay I wasnât aware.
2172021-02-23T15:18:14 *** jonatack <jonatack!~jon@37.172.15.119> has joined #bitcoin-core-dev
2182021-02-23T15:19:26 *** prayank <prayank!~andr0irc@2402:8100:2068:610a:e46a:56ed:5797:affc> has joined #bitcoin-core-dev
2192021-02-23T15:24:02 *** prayank <prayank!~andr0irc@2402:8100:2068:610a:e46a:56ed:5797:affc> has quit IRC (Ping timeout: 264 seconds)
2202021-02-23T15:28:14 *** realname194 <realname194!~real@37.160.35.244> has quit IRC (Remote host closed the connection)
2212021-02-23T15:28:38 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
2222021-02-23T15:30:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2232021-02-23T15:30:26 <bitcoin-git> [gui] hebasto opened pull request #220: qt: Do not translate file extensions (master...210223-fileext) https://github.com/bitcoin-core/gui/pull/220
2242021-02-23T15:30:27 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2252021-02-23T15:31:43 <Norrin> ariard, gleb what are the meeting details?
2262021-02-23T15:32:05 <Norrin> its a public meeting that anyone can join, perhaps with mute locked on?
2272021-02-23T15:43:09 <michaelfolkson> Norrin: Open to all on P2P. This channel at 21:00 UTC https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings. No mute required (be respectful obviously)
2282021-02-23T15:44:14 <Norrin> michaelfolkson Thanks!
2292021-02-23T15:52:14 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2302021-02-23T15:52:14 <bitcoin-git> [bitcoin] glozow opened pull request #21280: test / bug fix in transaction_tests (master...2021-02-test-bug) https://github.com/bitcoin/bitcoin/pull/21280
2312021-02-23T15:52:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2322021-02-23T15:54:52 *** stortz <stortz!bb3fa187@187.63.161.135> has joined #bitcoin-core-dev
2332021-02-23T15:55:36 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
2342021-02-23T16:17:17 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has quit IRC (Remote host closed the connection)
2352021-02-23T16:17:42 *** DeanGuss <DeanGuss!~dean@gateway/tor-sasl/deanguss> has joined #bitcoin-core-dev
2362021-02-23T16:25:45 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 264 seconds)
2372021-02-23T16:33:18 *** Cory <Cory!~Cory@unaffiliated/cory> has quit IRC (Ping timeout: 272 seconds)
2382021-02-23T16:41:31 *** linkrage <linkrage!~linkrage@77-85-62-127.ip.btc-net.bg> has joined #bitcoin-core-dev
2392021-02-23T16:43:55 *** esotericnonsense <esotericnonsense!~esotericn@unaffiliated/esotericnonsense> has joined #bitcoin-core-dev
2402021-02-23T16:44:25 *** harrigan <harrigan!~harrigan@ptr-93-89-242-202.ip.airwire.ie> has quit IRC (Read error: Connection reset by peer)
2412021-02-23T16:44:59 <linkrage> Hi, I've just compiled bitcoin-0.8.6 from source on Ubuntu 14.04 (on purpose). It doesn't build bitcoin-cli and looks like that's on purpose ? How dow I communicate with bitcoind to set a passphrase on wallet etc. - curl only ?
2422021-02-23T16:46:26 *** harrigan <harrigan!~harrigan@ptr-93-89-242-202.ip.airwire.ie> has joined #bitcoin-core-dev
2432021-02-23T16:51:06 *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
2442021-02-23T16:53:17 <linkrage> got it, no worries :)
2452021-02-23T16:53:26 *** linkrage <linkrage!~linkrage@77-85-62-127.ip.btc-net.bg> has left #bitcoin-core-dev ("Leaving")
2462021-02-23T16:57:18 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2472021-02-23T16:57:19 <bitcoin-git> [bitcoin] laanwj pushed 16 commits to master: https://github.com/bitcoin/bitcoin/compare/78effb37f35f...a9335e4f129c
2482021-02-23T16:57:20 <bitcoin-git> bitcoin/master 87a9794 Sjors Provoost: configure: add --enable-external-signer
2492021-02-23T16:57:21 <bitcoin-git> bitcoin/master f7eb7ec Sjors Provoost: test: framework: add skip_if_no_external_signer
2502021-02-23T16:57:21 <bitcoin-git> bitcoin/master 8cf543f Sjors Provoost: wallet: add -signer argument for external signer command
2512021-02-23T16:57:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2522021-02-23T16:57:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2532021-02-23T16:57:38 <bitcoin-git> [bitcoin] laanwj merged pull request #16546: External signer support - Wallet Box edition (master...2019/08/hww-box2) https://github.com/bitcoin/bitcoin/pull/16546
2542021-02-23T16:57:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2552021-02-23T16:57:58 <luke-jr> woo
2562021-02-23T16:59:28 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
2572021-02-23T17:12:27 *** Cory <Cory!~Cory@unaffiliated/cory> has joined #bitcoin-core-dev
2582021-02-23T17:23:35 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
2592021-02-23T17:23:46 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
2602021-02-23T17:27:35 *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f1aca00533dd9f79e77799f.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
2612021-02-23T17:28:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2622021-02-23T17:28:19 <bitcoin-git> [gui] jonatack opened pull request #221: qt, refactor: rpcconsole translatable string fixes and improvements (master...qt-rpcconsole-translation-improvements) https://github.com/bitcoin-core/gui/pull/221
2632021-02-23T17:28:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2642021-02-23T17:29:34 <achow101> yay hardware wallets
2652021-02-23T17:29:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2662021-02-23T17:29:50 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a9335e4f129c...1b045b5eef9a
2672021-02-23T17:29:50 <bitcoin-git> bitcoin/master ba7e17e Sebastian Falbesoner: rpc, test: document {previous,next}blockhash as optional
2682021-02-23T17:29:51 <bitcoin-git> bitcoin/master 1b045b5 MarcoFalke: Merge #21053: rpc, test: document {previous,next}blockhash as optional
2692021-02-23T17:29:53 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2702021-02-23T17:30:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2712021-02-23T17:30:09 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #21053: rpc, test: document {previous,next}blockhash as optional (master...2021-rpc-test-document-previousnextblockhash-as-optional) https://github.com/bitcoin/bitcoin/pull/21053
2722021-02-23T17:30:10 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2732021-02-23T17:31:26 <jonatack> congrats provoostenator
2742021-02-23T17:33:42 *** Henry151 <Henry151!~bishop@ns3007530.ip-151-80-44.eu> has quit IRC (Read error: Connection reset by peer)
2752021-02-23T17:47:06 <jb55> awesome
2762021-02-23T17:57:09 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
2772021-02-23T17:57:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2782021-02-23T17:57:23 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1b045b5eef9a...2e8116149ca4
2792021-02-23T17:57:24 <bitcoin-git> bitcoin/master 584fd91 Sebastian Falbesoner: init: only use pipe2 if availabile, check in configure
2802021-02-23T17:57:24 <bitcoin-git> bitcoin/master 9bac713 Sebastian Falbesoner: build: make HAVE_O_CLOEXEC available outside LevelDB (bugfix)
2812021-02-23T17:57:25 <bitcoin-git> bitcoin/master 2e81161 Wladimir J. van der Laan: Merge #21250: build: make HAVE_O_CLOEXEC available outside LevelDB (bugfix...
2822021-02-23T17:57:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2832021-02-23T17:57:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2842021-02-23T17:57:43 <bitcoin-git> [bitcoin] laanwj merged pull request #21250: build: make HAVE_O_CLOEXEC available outside LevelDB (bugfix) (master...2021-02-build-pass-have_o_cloexec) https://github.com/bitcoin/bitcoin/pull/21250
2852021-02-23T17:57:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2862021-02-23T18:04:20 *** harrigan <harrigan!~harrigan@ptr-93-89-242-202.ip.airwire.ie> has quit IRC (Read error: Connection reset by peer)
2872021-02-23T18:06:04 *** harrigan <harrigan!~harrigan@ptr-93-89-242-202.ip.airwire.ie> has joined #bitcoin-core-dev
2882021-02-23T18:09:14 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 268 seconds)
2892021-02-23T18:13:03 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
2902021-02-23T18:14:55 *** eoin <eoin!4e98f210@78.152.242.16> has joined #bitcoin-core-dev
2912021-02-23T18:18:43 *** eoin <eoin!4e98f210@78.152.242.16> has quit IRC (Client Quit)
2922021-02-23T18:21:29 *** stortz <stortz!bb3fa187@187.63.161.135> has quit IRC (Quit: Connection closed)
2932021-02-23T18:24:08 *** jungly <jungly!~jungly@host-82-61-129-61.retail.telecomitalia.it> has quit IRC (Ping timeout: 272 seconds)
2942021-02-23T18:29:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2952021-02-23T18:29:35 <bitcoin-git> [bitcoin] achow101 opened pull request #21283: Implement BIP 370 PSBTv2 (master...psbt2) https://github.com/bitcoin/bitcoin/pull/21283
2962021-02-23T18:29:36 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2972021-02-23T18:46:53 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2982021-02-23T18:46:53 <bitcoin-git> [bitcoin] danben opened pull request #21284: rpc: add the add_inputs option to bumpfee/psbtbumpfee (master...add-add-inputs-option-to-bumpfee) https://github.com/bitcoin/bitcoin/pull/21284
2992021-02-23T18:46:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3002021-02-23T18:56:00 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
3012021-02-23T18:57:48 *** Cairop <Cairop!d51f06f8@213.31.6.248> has joined #bitcoin-core-dev
3022021-02-23T18:59:14 *** Cairop <Cairop!d51f06f8@213.31.6.248> has quit IRC (Client Quit)
3032021-02-23T19:07:14 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3042021-02-23T19:07:14 <bitcoin-git> [bitcoin] jb55 opened pull request #21285: wallet: fix doc typo in signer option (master...signer-typo) https://github.com/bitcoin/bitcoin/pull/21285
3052021-02-23T19:07:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3062021-02-23T19:31:13 <provoostenator> YES
3072021-02-23T19:31:24 <provoostenator> The past is here!
3082021-02-23T19:33:56 *** lightlike <lightlike!~lightlike@p200300c7ef179100a4f011ef5e24615f.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
3092021-02-23T19:37:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3102021-02-23T19:37:19 <bitcoin-git> [bitcoin] hebasto opened pull request #21286: build: Bump minimum Qt version to 5.9.5 (master...210223-qtmin) https://github.com/bitcoin/bitcoin/pull/21286
3112021-02-23T19:37:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3122021-02-23T19:40:39 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 272 seconds)
3132021-02-23T19:45:39 <provoostenator> I rebased the GUI PR: https://github.com/bitcoin-core/gui/pull/4
3142021-02-23T19:45:57 <provoostenator> I think it's ready for testing and some initial review, but it's still a bit rough around the edges.
3152021-02-23T19:46:23 <provoostenator> ryanofsky added a suggestion on how to make asyncrhonous, though I might punt that to a new PR
3162021-02-23T19:47:17 <provoostenator> I also find that it crashes on (my) macOS when I use the "make deploy" version, probably some Python environment can of worms.
3172021-02-23T19:47:39 <provoostenator> But other than that it does actually work. Go play with it :-)
3182021-02-23T19:53:22 *** jungly <jungly!~jungly@host-82-61-129-61.retail.telecomitalia.it> has joined #bitcoin-core-dev
3192021-02-23T19:54:52 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Read error: Connection reset by peer)
3202021-02-23T19:56:55 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
3212021-02-23T20:00:12 *** criley88 <criley88!49e07d3a@c-73-224-125-58.hsd1.fl.comcast.net> has joined #bitcoin-core-dev
3222021-02-23T20:07:49 *** ogo <ogo!~ogo@gateway/tor-sasl/ogo> has quit IRC (Quit: Leaving)
3232021-02-23T20:10:56 *** criley88 <criley88!49e07d3a@c-73-224-125-58.hsd1.fl.comcast.net> has quit IRC (Quit: Connection closed)
3242021-02-23T20:12:47 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
3252021-02-23T20:19:11 <jnewbery> Reminder that the p2p meeting starts in 40 minutes (2100 UTC)
3262021-02-23T20:21:25 *** smartineng <smartineng!~Icedove@88.135.18.171> has quit IRC (Ping timeout: 240 seconds)
3272021-02-23T20:45:47 *** prayank <prayank!~Prayank@2409:4053:2d08:b361:ad7a:5d0c:7e74:e825> has joined #bitcoin-core-dev
3282021-02-23T20:46:53 *** harrigan <harrigan!~harrigan@ptr-93-89-242-202.ip.airwire.ie> has quit IRC (Read error: Connection reset by peer)
3292021-02-23T20:48:22 *** harrigan <harrigan!~harrigan@ptr-93-89-242-202.ip.airwire.ie> has joined #bitcoin-core-dev
3302021-02-23T20:55:24 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 260 seconds)
3312021-02-23T20:55:44 *** harrigan <harrigan!~harrigan@ptr-93-89-242-202.ip.airwire.ie> has quit IRC (Read error: Connection reset by peer)
3322021-02-23T21:00:18 <jnewbery> #startmeeting
3332021-02-23T21:00:18 <core-meetingbot> Meeting started Tue Feb 23 21:00:18 2021 UTC. The chair is jnewbery. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
3342021-02-23T21:00:18 <core-meetingbot> Available commands: action commands idea info link nick
3352021-02-23T21:00:22 <amiti> hi!
3362021-02-23T21:00:24 *** harrigan <harrigan!~harrigan@ptr-93-89-242-202.ip.airwire.ie> has joined #bitcoin-core-dev
3372021-02-23T21:00:26 *** mariorz <mariorz!sid490@gateway/web/irccloud.com/x-rklvsgzeyabamhpu> has quit IRC (Ping timeout: 240 seconds)
3382021-02-23T21:00:26 <jnewbery> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
3392021-02-23T21:00:32 <jnewbery> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus
3402021-02-23T21:00:33 <glozow> hi
3412021-02-23T21:00:35 <gleb> hi!
3422021-02-23T21:00:46 <sipa> hi
3432021-02-23T21:00:46 <ariard> hi
3442021-02-23T21:01:03 <hebasto> hi
3452021-02-23T21:01:05 *** fjahr <fjahr!sid374480@gateway/web/irccloud.com/x-wtgxofjmyomzqblb> has quit IRC (Ping timeout: 272 seconds)
3462021-02-23T21:01:25 <aj> hola
3472021-02-23T21:01:33 <lightlike> hi
3482021-02-23T21:01:36 <jnewbery> hi folks. Proposed meeting topics are here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#23-feb-2021. Current priorities are here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities
3492021-02-23T21:01:39 <gribble> https://github.com/bitcoin/bitcoin/issues/23 | CORS support by gavinandresen · Pull Request #23 · bitcoin/bitcoin · GitHub
3502021-02-23T21:01:55 <jnewbery> buenos dias aj!
3512021-02-23T21:01:59 *** mariorz <mariorz!sid490@gateway/web/irccloud.com/x-nmciwajewsvvqoif> has joined #bitcoin-core-dev
3522021-02-23T21:02:04 *** endogenic <endogenic!sid145991@gateway/web/irccloud.com/x-fyulhxfzswxbetxf> has quit IRC (Ping timeout: 265 seconds)
3532021-02-23T21:02:14 <jnewbery> #topic erlay update (gleb)
3542021-02-23T21:02:14 <core-meetingbot> topic: erlay update (gleb)
3552021-02-23T21:02:35 <gleb> Iâm grateful to all folks pushed me to refactor #18261 in a similar way to txrequest.cpp.
3562021-02-23T21:02:38 <gribble> https://github.com/bitcoin/bitcoin/issues/18261 | Erlay: bandwidth-efficient transaction relay protocol by naumenkogs · Pull Request #18261 · bitcoin/bitcoin · GitHub
3572021-02-23T21:02:42 <gleb> Iâm almost done with that, just need to split cpp/header, split into commits, and add a bit more comments. Gonna be ready in the next couple days.
3582021-02-23T21:02:55 <gleb> jnewbery jonatack amiti I recall you mentioned youâd prefer a more modular appoach. Would any of you be able to take a look during this week, before I update the main PR?
3592021-02-23T21:02:55 <aj> jnewbery: good nachos to you too!
3602021-02-23T21:03:00 <gleb> I would really appreciate initial feedback on the new modularity, and I think this would also help to save review time of those folks focusing on other aspects of the PR.
3612021-02-23T21:03:06 *** fjahr <fjahr!sid374480@gateway/web/irccloud.com/x-piyhmzkmzjdkkqyq> has joined #bitcoin-core-dev
3622021-02-23T21:03:08 <gleb> Itâs just that if this new approach is also not really good (for now I personally think it is good), Iâd prefer us realizing it earlier, and re-shaping it again.
3632021-02-23T21:03:25 <prayank> jnewbery: TIL aj is working on Dandelion
3642021-02-23T21:03:45 *** endogenic <endogenic!sid145991@gateway/web/irccloud.com/x-jbdkflfwulatoesk> has joined #bitcoin-core-dev
3652021-02-23T21:03:51 <jnewbery> gleb: sure, I'm happy to take a look at it
3662021-02-23T21:04:12 <gleb> jnewbery. Great, thanks. If anyone else is willing to join john, please let me know :)
3672021-02-23T21:04:26 <gleb> Otherwise, that's it.
3682021-02-23T21:04:38 <jnewbery> where is it? how do you want me to leave review?
3692021-02-23T21:05:02 <amiti> gleb: I'm also down
3702021-02-23T21:05:02 <gleb> It's under naumenkogs/bitcoin/tree/erlay_refactored, but it's currently not ready yet, as I said.
3712021-02-23T21:05:26 <jnewbery> I also still think PRing minisketch separately would help move things forward
3722021-02-23T21:05:29 <sipa> perhaps leave a comment on the PR when you're done with the refactoring and want comments?
3732021-02-23T21:05:48 <ariard> or leave a message on irc here
3742021-02-23T21:05:59 <gleb> jnewbery: yeah, since c++ headers is merged, we can probably PR minisketch
3752021-02-23T21:06:37 <gleb> sipa: I'm wondering if you'd be a better candidate for merging minisketch? Just realistically, discussing the code and such
3762021-02-23T21:06:48 <gleb> Or you'd rather me do it?
3772021-02-23T21:07:01 <gleb> Not merging but creating PR I mean.
3782021-02-23T21:07:04 *** jungly <jungly!~jungly@host-82-61-129-61.retail.telecomitalia.it> has quit IRC (Ping timeout: 260 seconds)
3792021-02-23T21:07:09 <sipa> i'll open a PR to fix the issue that the current minisketch tests run forever (which is unexpected and confuses people)
3802021-02-23T21:07:16 <sipa> i think after that we could
3812021-02-23T21:07:25 <sipa> i
3822021-02-23T21:07:30 <sipa> i'm happy to PR it
3832021-02-23T21:07:34 <gleb> Great, thank you.
3842021-02-23T21:07:39 <gleb> I'll focus on the erlay part then
3852021-02-23T21:07:56 <jnewbery> would minisketch tests run with `make check` in the bitcoin core?
3862021-02-23T21:08:18 <sipa> they probably should
3872021-02-23T21:08:32 <sipa> (and that makes it a blocker to not have them run forever...)
3882021-02-23T21:08:38 <gleb> jnewbery amiti: Let's figure the best way you can help with my erlay refactor in personal messages once I'm ready
3892021-02-23T21:08:59 <jnewbery> gleb: just leave a comment on the PR when it's ready and I'll take a look at the branch
3902021-02-23T21:09:06 <amiti> +1
3912021-02-23T21:09:11 <sipa> +1
3922021-02-23T21:09:13 <gleb> alright
3932021-02-23T21:09:59 <jnewbery> that PR is a bit unwieldly at this point. If you're changing the approach and minisketch is going to be split out of it, it might make sense to start a new PR, but you can decide that later
3942021-02-23T21:10:21 <gleb> jnewbery: I totally agree.
3952021-02-23T21:10:26 <aj> (+1 on a new PR to avoid all the load mores)
3962021-02-23T21:10:27 <sipa> yeah
3972021-02-23T21:10:39 <jnewbery> ok, we have three other topics:
3982021-02-23T21:10:41 <jnewbery> - Orphan reprocessing (jnewbery)
3992021-02-23T21:10:49 <jnewbery> - Peer rate-limiting (jnewbery)
4002021-02-23T21:10:54 <jnewbery> - Dandelion update (ajtowns)
4012021-02-23T21:11:11 <jnewbery> anyone want to add any quick updates or other topics before we move onto those?
4022021-02-23T21:11:40 *** elichai2 <elichai2!sid212594@gateway/web/irccloud.com/x-lopkrozptkoybihj> has quit IRC (Read error: Connection reset by peer)
4032021-02-23T21:11:51 *** wangchun_ <wangchun_!sid444603@gateway/web/irccloud.com/x-wctqlxoztrxlnilq> has quit IRC (Ping timeout: 272 seconds)
4042021-02-23T21:11:51 *** wangchun <wangchun!sid444603@gateway/web/irccloud.com/x-fqdszhcdxzjlowom> has quit IRC (Ping timeout: 272 seconds)
4052021-02-23T21:11:51 <jnewbery> Dandelion update sounds like it might be the quickest, so maybe we do that first
4062021-02-23T21:11:58 *** elichai2 <elichai2!sid212594@gateway/web/irccloud.com/x-gkofmiznfvtcdhdl> has joined #bitcoin-core-dev
4072021-02-23T21:11:59 <jnewbery> #topic dandelion update (ajtowns)
4082021-02-23T21:11:59 <core-meetingbot> topic: dandelion update (ajtowns)
4092021-02-23T21:12:01 *** jakesyl <jakesyl!sid56879@gateway/web/irccloud.com/x-iztdehhgiceanbhh> has quit IRC (Ping timeout: 265 seconds)
4102021-02-23T21:12:12 <aj> oh, i was happy for it to be the if-we-had-time
4112021-02-23T21:12:14 <aj> anyhoo
4122021-02-23T21:12:49 *** wangchun_ <wangchun_!sid444603@gateway/web/irccloud.com/x-dywaualargxrvjui> has joined #bitcoin-core-dev
4132021-02-23T21:12:56 *** wangchun <wangchun!sid444603@gateway/web/irccloud.com/x-xkvtmjtertvocryp> has joined #bitcoin-core-dev
4142021-02-23T21:12:58 <aj> we were talking about dandelion last week, and maybe have some ideas about how to do it without needing a separate stempool. but it was pointed out there was an idea to do a -lite variant, that only stems for a single hop
4152021-02-23T21:13:26 <aj> that has weaker privacy support, but doesn't need new p2p messages or a separate mempool, so should be much easier to implement
4162021-02-23T21:13:41 *** jakesyl <jakesyl!sid56879@gateway/web/irccloud.com/x-vcdpnxclfrimarst> has joined #bitcoin-core-dev
4172021-02-23T21:13:45 <glozow> does one-hop work? couldn't you tell where a tx originates if you knew they were one-hopping to you?
4182021-02-23T21:14:01 <glozow> idk if i'm missing something
4192021-02-23T21:14:02 <aj> i've been chatting on twitter with gulia and she's updated her sims
4202021-02-23T21:14:03 <gleb> do you make a new connection for one-hop, or pick from existing conns?
4212021-02-23T21:14:54 <jnewbery> I think if an attacker made multiple connections to you, they could tell if you're only relaying a transaction to a single peer
4222021-02-23T21:14:58 <aj> glozow: one-hop stem == pick one or two outbound peers and send your tx to them; when you receive a tx always flood it to everyone. so you don't immediately know if a tx was stemmed/flooded to you (and hence don't need different messages)
4232021-02-23T21:15:18 <aj> jnewbery: if an outbound connects back to you as an inbound, yeah
4242021-02-23T21:15:31 <aj> jnewbery: (you don't stem to inbounds to make that harder, i think)
4252021-02-23T21:15:57 <jnewbery> ah, only choose from outbounds
4262021-02-23T21:16:02 <aj> https://twitter.com/giuliacfanti/status/1362963585471815680 is the twitter thread, and has some graphs
4272021-02-23T21:16:38 <aj> it looks to me like -lite is a signficant enough improvement that it's probably worth tryng, and dandelion++ proper is enough of an improvement on that that it's still worth thinking about if we can make it feasible
4282021-02-23T21:16:38 <prayank> aj: I am also trying to resolve conflicts and add Dandelion code (from BIP implementation link) in current master branch. I wasn't even aware you are working on it because nobody informed on IRC, Github or SE when we discussed Dandelion. I will read the Twitter thread and DM you later.
4292021-02-23T21:17:00 <sipa> prayank: dandelion lite has basically nothing to do with dandelion (in terms of implementation complexity)
4302021-02-23T21:17:08 <aj> prayank: there's a link in that twitter thread to the irc conversation last week
4312021-02-23T21:17:10 <gleb> aj: Erlay does something really similar to lite, actually.
4322021-02-23T21:17:12 <glozow> i don't think the bip is updated for dandelion++
4332021-02-23T21:17:14 <glozow> is it?
4342021-02-23T21:17:21 <prayank> sipa: Okay
4352021-02-23T21:17:21 <sipa> the bip is dandelion++ afaik
4362021-02-23T21:17:36 <sipa> my impression from dandelion lite is that it's basically 1% of the work to get 80% of the benefits (under vaguely reasonable assumptions)
4372021-02-23T21:18:10 <aj> sipa: looks more like 40%-50% of the benefits to me
4382021-02-23T21:18:16 <sipa> okay.
4392021-02-23T21:18:16 <ariard> so the model is alice initial-broadcast to bob, it's testmempoolaccepted to not let any fingerprint in bob's mempool and stems to caroll, an outbound?
4402021-02-23T21:18:39 <glozow> i think bob floods, no?
4412021-02-23T21:18:50 <lightlike> would it be either dandelion or erlay, or would both work together?
4422021-02-23T21:18:51 <aj> for lite, bob floods
4432021-02-23T21:18:58 <sipa> there is no stempool in lite, right? you just remember in the wallet itself, and the rebroadcast uses the full broadcast
4442021-02-23T21:18:59 <ariard> okay gotcha
4452021-02-23T21:19:06 <gleb> lightlike: they should work together just fine
4462021-02-23T21:19:16 <glozow> what if bob black-holes it?
4472021-02-23T21:19:22 <glozow> doesn't relay it, i mean
4482021-02-23T21:19:40 <sipa> glozow: rebroadcast takes care of it, just like in dandelion (correct me if i'm wrong, aj, i'm going from very vague memory)
4492021-02-23T21:19:49 <aj> glozow: you hit the wallet rebroadcast timer and do a flood, probably
4502021-02-23T21:19:56 <glozow> doesn't rebroadcast not run for 12 hours at least?
4512021-02-23T21:19:58 <jnewbery> can you summarise what the 40-50% benefit is?
4522021-02-23T21:20:01 <aj> sipa: i don't think those details are really specced anywhere
4532021-02-23T21:20:20 <gleb> black holes also can be detected and disconnected after one occasion.
4542021-02-23T21:20:34 <aj> jnewbery: the statistics used are "precision" and "recall" which measure how likely an attacker is to be able to pinpoint the originator of a tx
4552021-02-23T21:20:45 *** btc_thc <btc_thc!annalee@kosher.marriageiguana.com> has quit IRC (Ping timeout: 240 seconds)
4562021-02-23T21:21:18 <jnewbery> why is relaying to one outbound peer better than relaying to 2, or 8?
4572021-02-23T21:21:30 <sipa> glozow: that'd need to be adjusted then; iirc dandelion has a delay of just a few seconds
4582021-02-23T21:22:05 <gleb> jnewbery: other 7 of your conns + inbounds have worse idea that it originated from you
4592021-02-23T21:22:15 <gleb> Rather than when you relay to all of them
4602021-02-23T21:22:28 <amiti> I think an implementation of dandelion lite would want to add logic for checking if the txn successfully relayed / a quicker rebroadcast if not.
4612021-02-23T21:22:35 <aj> jnewbery: stemming to one outbound peer is what's modelled in the sim and paper; i don't think it's clear if there's a best value to use
4622021-02-23T21:22:42 <glozow> sipa: sorry i meant, i think currently rebroadcast is on 12-hour-ish timer, but dandelion++ spec has a several second timer. trying to wrap my head around what needs to be implemented for dandelion lite, perhaps would need to have a timer for rebroadcast-just-incase
4632021-02-23T21:23:07 <ariard> amiti: quite easy by probing your own mempool to see if you get an announcement back?
4642021-02-23T21:23:15 <amiti> yup, exactly
4652021-02-23T21:23:17 <gleb> jnewbery: oh sorry, I guess you ask about the exact choice, yeah, 2 could be better than 1..
4662021-02-23T21:23:25 <amiti> that just doesn't exist yet
4672021-02-23T21:23:56 <gleb> glozow: I was also wondering if rebroadcast here should happen in 10 seconds
4682021-02-23T21:24:07 <sipa> glozow: this would be a separate rebroadcast mechanism i believe
4692021-02-23T21:24:09 <gleb> I don't see why we should wait 12 hours?
4702021-02-23T21:24:24 <amiti> aj: is it easy to run the simulation with 2 outbounds and compare?
4712021-02-23T21:24:26 <sipa> because the dandelion lite "stem" relay can't insert into the mempool
4722021-02-23T21:24:51 <glozow> gleb: I mean the current rebroadcast behavior on master, without adding any dandelion stuff
4732021-02-23T21:25:10 <ariard> i think the rebroadcast should be considered in function of opening a one-shot for the connection
4742021-02-23T21:25:29 <aj> amiti: the sim chooses an anonymity graph with 4 outbounds for each node, and selects one of those outbounds for relay. changing 4 to 2 or 8 is easy, but selecting more than one outbound requires code changes...
4752021-02-23T21:25:39 <gleb> ariard: one shot wouldn't work at all, unless nodes don't do that for foreign transactions?
4762021-02-23T21:25:48 <gleb> because it's obvious one-shot is a tx source
4772021-02-23T21:25:51 <gleb> unless tor
4782021-02-23T21:26:17 <aj> gleb: yeah, tor or i2p for oneshot
4792021-02-23T21:26:45 <amiti> aj: gotcha
4802021-02-23T21:27:00 <gleb> aj: sorry, is this relevant? Are we talking about oneshot over tor as a way to do d lite?
4812021-02-23T21:27:22 <ariard> gleb: don't we already assume bob has an easier job to guess alice is the source if you mass-connect?
4822021-02-23T21:27:53 <gleb> ariard: Sure, but lite would help against that even without one-shot tor
4832021-02-23T21:28:13 <aj> gleb: i thnk the idea is dandelion-lite should work even if your node doesn't do tor/i2p at least. (people talk about lots of things :)
4842021-02-23T21:28:37 <gleb> aj: without oneshot then. oneshot without tor doesn't work.
4852021-02-23T21:28:43 <aj> gleb: yep
4862021-02-23T21:29:26 <jnewbery> aj: do you need help with anything? Would you like people to review a proposal or something else?
4872021-02-23T21:30:05 <aj> jnewbery: no, just wanted to update people on what's going on. i don't have a particular plan on what's next at this point
4882021-02-23T21:30:15 <ariard> gleb: could you do one shot without tor for a low % of foreign transactions ?
4892021-02-23T21:30:18 <amiti> aj: so do I have this right that your current impression that we could implement lite without any protocol changes, code not being too invasive, and get ~40-50% of benefits? what are next steps?
4902021-02-23T21:30:34 <amiti> oh, you just answered part of that
4912021-02-23T21:30:35 <gleb> I'd be willing to help. And as a separate thing, aj, we should see how to marry it with erlay in practice, once you reach that point.
4922021-02-23T21:31:27 <gleb> ariard: that's something was never discussed. I see that as a measure *on top*, but I'd not rely on this solo.
4932021-02-23T21:31:42 <aj> amiti: yes, i think that's right. not sure if more sims are worth doing first; otherwise figuring out how to be able to stem to some peers without contaminating how you respond to the peers you don't stem too would probably be the first bit of implementation
4942021-02-23T21:32:56 <jnewbery> aj: hopefully shouldn't be too difficult to update FindTxForGetData. We've done something similar before
4952021-02-23T21:33:25 <aj> jnewbery: i think working out the spec would be harder than implementing it...
4962021-02-23T21:33:41 <sipa> haha
4972021-02-23T21:33:42 <gleb> ariard: that's a cool idea to add noise against any kind of spying. But i think the problem with oneshot-no-tor is that it's success is a function of how ready we are to dos our own network :)
4982021-02-23T21:33:43 <jnewbery> yup
4992021-02-23T21:33:51 <amiti> jnewbery: something similar? what are you thinking of?
5002021-02-23T21:34:57 *** Neostrada <Neostrada!~neostrada@213.152.188.95> has joined #bitcoin-core-dev
5012021-02-23T21:35:30 <jnewbery> m_recently_announced_invs
5022021-02-23T21:35:52 <jnewbery> maybe it just works already
5032021-02-23T21:35:58 <ariard> gleb: yeah I know...kinda some trade-offs we're hitting with new rebroadcast, more noise, more bandwidth
5042021-02-23T21:37:11 *** Neostrada <Neostrada!~neostrada@213.152.188.95> has quit IRC (Client Quit)
5052021-02-23T21:37:37 *** harrigan <harrigan!~harrigan@ptr-93-89-242-202.ip.airwire.ie> has quit IRC (Read error: Connection reset by peer)
5062021-02-23T21:37:44 <jnewbery> move on to the next topic?
5072021-02-23T21:37:48 <aj> sounds good
5082021-02-23T21:38:04 <jnewbery> #topic Orphan reprocessing (jnewbery)
5092021-02-23T21:38:04 <core-meetingbot> topic: Orphan reprocessing (jnewbery)
5102021-02-23T21:38:20 <jnewbery> This is something that recently came up again in #21224
5112021-02-23T21:38:22 <gribble> https://github.com/bitcoin/bitcoin/issues/21224 | [p2p] Halt processing of unrequested transactions by ariard · Pull Request #21224 · bitcoin/bitcoin · GitHub
5122021-02-23T21:38:38 <jnewbery> we currently reprocess orphan transactions in the context of the node that provided the parent
5132021-02-23T21:39:09 <jnewbery> ie node A sends us an orphan transaction, node B sends us its parent, we later process the orphan transaction next time we call ProcessMessages() for node B
5142021-02-23T21:39:28 *** harrigan <harrigan!~harrigan@ptr-93-89-242-202.ip.airwire.ie> has joined #bitcoin-core-dev
5152021-02-23T21:39:45 <jnewbery> it seems a bit strange that we do this, and aj was proposing we change that as part of, or after, orphan handling is split into txorphange
5162021-02-23T21:40:25 <ariard> idea would be to assign orphan processing to A only?
5172021-02-23T21:40:52 <sipa> so that means we may punish the peer that provided parent for an invalid orphan received from someone else?
5182021-02-23T21:41:06 <jnewbery> that seems like a reasonable change to me. We should either process orphan reprocessing in the context of node A, or in some global context (i.e. call PeerManager.DoGenericWork())
5192021-02-23T21:41:16 <aj> today, we still lookup the original peer when figuring out who to punish
5202021-02-23T21:41:29 <jnewbery> sipa: no, we already punish the peer who provided the orphan if it's consensus invalid
5212021-02-23T21:41:53 <sipa> then what do you mean by "in the context of" ?
5222021-02-23T21:41:58 <ariard> hmmm I would rather avoid global context where you can trace back and punish dosy peers
5232021-02-23T21:42:06 <jnewbery> see OrphanTx.frompeer (https://github.com/bitcoin/bitcoin/blob/78effb37f35ff09733e79497bd6b06d355272d79/src/net_processing.cpp#L151-L154)
5242021-02-23T21:42:24 <jnewbery> sipa: we process the transaction the next time we call ProcessMessages(node B)
5252021-02-23T21:42:29 <ariard> *can't
5262021-02-23T21:42:33 <aj> sipa: we process the tx when we call ProcessMessages for peer B at present (because the child tx goes into the orphan work set of whoever provided the parent)
5272021-02-23T21:42:37 <amiti> I think "in the context of" refers to which node we allocate ProcessMessage time to
5282021-02-23T21:42:48 <sipa> ah, i see
5292021-02-23T21:44:24 <aj> the idea would be to move the orphan work sets out of the Peer mapping and into a new map in the txorphanage, which can just be sorted by the frompeer, and an entry selected from it during frompeer's ProcessMessages
5302021-02-23T21:44:37 <jnewbery> sipa: last time this kind of change was proposed you had concerns about the fact it wouldn't be observationally equivalent: http://www.erisian.com.au/bitcoin-core-dev/log-2020-07-02.html#l-325
5312021-02-23T21:44:53 <aj> moving the orphan work sets out of Peer also allows g_cs_orphans to be moved into txorphanage and stop being a global
5322021-02-23T21:45:10 <jnewbery> aj: I like this change a lot :)
5332021-02-23T21:46:53 <jnewbery> my last proposal was to move orphan reprocessing to a global work queue: ttps://github.com/bitcoin/bitcoin/pull/19364 , but moving it to the work queue of the peer who sent it also seems fine
5342021-02-23T21:47:05 <amiti> is the core reasoning to prevent the sorta attack mentioned in this comment: https://github.com/bitcoin/bitcoin/pull/21224#issuecomment-781741925, where a peer who sends a valid txn that activates lots of invalid orphans would take up our CPU time instead of the one who will eventually be punished?
5352021-02-23T21:47:47 <ariard> amiti: I'm not sure the peer who sends a valid txn can be actually the culprit for it
5362021-02-23T21:48:12 <amiti> ariard: what?
5372021-02-23T21:48:13 <ariard> a malicious peer, if knowledgeable of tx-relay link between two peers might provoke mempool conflicts to trigger this scenario...
5382021-02-23T21:48:47 <ariard> le'ts say you have alice connected to bob, and mallory to both of them, you send tx A to alice, tx A' to bob
5392021-02-23T21:48:58 <sipa> jnewbery: i haven't paid attention to the latest discussion; i just hope the motivation is more than "this results in cleaner code for us" if changes observable behavior
5402021-02-23T21:49:20 <ariard> you send a set of childrens from tx A, will be relayed to bob and stored as orphan
5412021-02-23T21:50:54 <ariard> receiving orphans on bob side, should trigger him to fetch again tx A and thus do the work on alice account
5422021-02-23T21:51:06 *** dbr <dbr!62e945dd@c-98-233-69-221.hsd1.dc.comcast.net> has joined #bitcoin-core-dev
5432021-02-23T21:51:54 <aj> (i think it's "add latency to Alice's transactions" more than "use up Alice's CPU time")
5442021-02-23T21:52:13 <amiti> aj: ok, yeah, that makes sense
5452021-02-23T21:52:42 <amiti> ariard: I think you're saying that an honest peer can send a parent to invalid orphans received from a different peer?
5462021-02-23T21:52:49 *** dbr <dbr!62e945dd@c-98-233-69-221.hsd1.dc.comcast.net> has quit IRC (Client Quit)
5472021-02-23T21:53:02 <ariard> aj: do we actually have this notion of peer CPU time? I don't think so...
5482021-02-23T21:53:39 <jnewbery> ariard: not yet. That maybe leads nicely into the next topic
5492021-02-23T21:53:59 <jnewbery> #topic Peer rate-limiting (jnewbery)
5502021-02-23T21:54:00 <core-meetingbot> topic: Peer rate-limiting (jnewbery)
5512021-02-23T21:54:15 <ariard> amiti: orphans can be valid there too, and it can work as received from a different peer but not exactly the scenario I was describing
5522021-02-23T21:54:18 <jnewbery> Again, this came up in the discussion of #21224
5532021-02-23T21:54:19 <aj> ariard: Mallort constructs tx A, and invalid children of A: B1, B2, B3, B4, ... Mallory relays B1..Bn to Bob. Mallory relays A to Alice. Once Bob receives A from Alice, he'll have high latency for the next tx from Alice
5542021-02-23T21:54:19 <gribble> https://github.com/bitcoin/bitcoin/issues/21224 | [p2p] Halt processing of unrequested transactions by ariard · Pull Request #21224 · bitcoin/bitcoin · GitHub
5552021-02-23T21:55:23 <ariard> amiti: the scenario described by aj is the one you were thinking of, mine orphans are announced to alice (note they're considered as orphan but valid txn by alice)
5562021-02-23T21:55:29 <ariard> AFAICT
5572021-02-23T21:56:01 <jnewbery> aj: I agree. It makes perfect sense that we don't slow down processing for Alice because of transactions that Bob relayed
5582021-02-23T21:56:12 <ariard> *are not considred as orphan (damn english)
5592021-02-23T21:56:18 <jnewbery> *that Mallory relayed
5602021-02-23T21:56:22 <aj> ariard: bob and alice will relay A and A' to each other, reject them as double spends, and then Alice will reject the children rather than treat them as orphans because they have a rejected parent, i think?
5612021-02-23T21:57:01 <ariard> aj: at first sight but you can play with rbf and add a grandparent to A and A' to make it work
5622021-02-23T21:58:02 <amiti> yeah, the scenario aj described is my understanding of the reasoning behind why we would change which peer context we process a parent in.
5632021-02-23T21:58:46 <ariard> aj: or if A' has been announced through wtxid-relay are we going to add to rejection filter its txid? orphan parent are fetched through txid
5642021-02-23T22:00:55 <jnewbery> ok, that's time!
5652021-02-23T22:00:58 <ariard> aj: I should craft a functional test with the scenario, easier way to debate about it :)
5662021-02-23T22:01:03 <jnewbery> thanks everyone!
5672021-02-23T22:01:07 <jnewbery> #endmeeting
5682021-02-23T22:01:07 <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
5692021-02-23T22:01:07 <core-meetingbot> Meeting ended Tue Feb 23 22:01:06 2021 UTC.
5702021-02-23T22:01:07 <core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-02-23-21.00.moin.txt
5712021-02-23T22:02:16 <aj> ariard: we don't reject a tx until we've received it (the tx, not its w/txid), and we add both txid and wtxid to recentRejects?
5722021-02-23T22:04:06 <aj> or rather we add the txid to recentRejects as well when we know it will fail no matter the witness. maybe that's not the case for double-spends, because theoretically there could be a smaller valid witness that would meet RBF rules?
5732021-02-23T22:05:23 <ariard> aj: nope smaller witness valid are bounce back by current mempool logic, see #19645
5742021-02-23T22:05:25 <gribble> https://github.com/bitcoin/bitcoin/issues/19645 | Allow updating mempool-txn with cheaper witnesses by ariard · Pull Request #19645 · bitcoin/bitcoin · GitHub
5752021-02-23T22:07:10 <sipa> jnewbery: fwiw, i think that arguments about the ability for bad latency for processing of messages from unexpecting peers is a totally valid reason to change behavior
5762021-02-23T22:07:31 <sipa> sorry for the kneejerk reaction when this was brought up again
5772021-02-23T22:07:48 <aj> ariard: no, i mean if you've got tx A, and want to RBF it to tx B, but B's fee isn't high enough, then tx B' with the same txid but smaller witness data might still be accepted. If you did accept B, you won't accept B' as you point out
5782021-02-23T22:08:34 <aj> sipa: sounds like it needs a PR so we can do less hand-wavy review though
5792021-02-23T22:10:01 *** aferreira44 <aferreira44!~andre@2001:1284:f013:e991:e5ae:4270:cdb:4daa> has joined #bitcoin-core-dev
5802021-02-23T22:16:05 <ariard> aj: okay thinking further, my naive scenario don't seem to hold but yours where mallory directly announce B1,...,Bn to Bob and relay A to Alice should work
5812021-02-23T22:16:14 <ariard> we do AlreadyHave() at orphan parent fetching
5822021-02-23T22:25:14 <hebasto> https://github.com/google/leveldb/releases/tag/1.23
5832021-02-23T22:27:53 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
5842021-02-23T22:27:53 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
5852021-02-23T22:27:56 *** vasild_ is now known as vasild
5862021-02-23T22:30:46 *** nbdD <nbdD!~nb@193.201.175.17> has joined #bitcoin-core-dev
5872021-02-23T22:32:38 *** nbdD <nbdD!~nb@193.201.175.17> has quit IRC (Remote host closed the connection)
5882021-02-23T22:33:08 *** boltFY <boltFY!~bolt@182.189.223.70> has joined #bitcoin-core-dev
5892021-02-23T22:33:36 *** boltFY <boltFY!~bolt@182.189.223.70> has quit IRC (Remote host closed the connection)
5902021-02-23T22:34:44 *** ovovo <ovovo!~ovovo@2a02:29b8:dc01:1881::2e> has joined #bitcoin-core-dev
5912021-02-23T22:35:12 *** kieraHa <kieraHa!~kiera@WGPON-3952-85.wateen.net> has joined #bitcoin-core-dev
5922021-02-23T22:35:36 *** kieraHa <kieraHa!~kiera@WGPON-3952-85.wateen.net> has quit IRC (K-Lined)
5932021-02-23T22:35:57 *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 264 seconds)
5942021-02-23T22:40:09 *** Kiminuo <Kiminuo!~Kiminuo@141.98.103.212> has quit IRC (Ping timeout: 264 seconds)
5952021-02-23T22:41:31 *** ogo <ogo!~ogo@gateway/tor-sasl/ogo> has joined #bitcoin-core-dev
5962021-02-23T22:43:25 *** egp_ <egp_!~egp_@2.95.74.168> has joined #bitcoin-core-dev
5972021-02-23T22:43:26 *** prayank <prayank!~Prayank@2409:4053:2d08:b361:ad7a:5d0c:7e74:e825> has left #bitcoin-core-dev
5982021-02-23T22:45:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5992021-02-23T22:45:09 <bitcoin-git> [bitcoin] abdullahnazar opened pull request #21287: Create arabmarketcap (master...abdullahnazar-patch-1-1) https://github.com/bitcoin/bitcoin/pull/21287
6002021-02-23T22:45:10 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6012021-02-23T22:45:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6022021-02-23T22:45:44 <bitcoin-git> [bitcoin] fanquake closed pull request #21287: Create arabmarketcap (master...abdullahnazar-patch-1-1) https://github.com/bitcoin/bitcoin/pull/21287
6032021-02-23T22:45:45 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6042021-02-23T22:45:51 *** doaks <doaks!~doaks@122.49.214.91> has joined #bitcoin-core-dev
6052021-02-23T22:46:22 *** doaks <doaks!~doaks@122.49.214.91> has quit IRC (Remote host closed the connection)
6062021-02-23T22:47:57 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
6072021-02-23T22:47:58 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
6082021-02-23T22:47:58 *** vasild_ is now known as vasild
6092021-02-23T22:48:02 *** dkrm <dkrm!~dkrm@2001:41d0:8:3f7b::1> has quit IRC (Ping timeout: 264 seconds)
6102021-02-23T22:49:09 *** prusnak <prusnak!sid403625@gateway/web/irccloud.com/x-etmwllgrdxlhyjsd> has quit IRC (Ping timeout: 264 seconds)
6112021-02-23T22:49:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6122021-02-23T22:49:44 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2e8116149ca4...587c986ccf88
6132021-02-23T22:49:44 <bitcoin-git> bitcoin/master da30c1b William Casarin: wallet: fix doc typo in signer option
6142021-02-23T22:49:45 <bitcoin-git> bitcoin/master 587c986 fanquake: Merge #21285: wallet: fix doc typo in signer option
6152021-02-23T22:49:48 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6162021-02-23T22:50:01 *** prusnak <prusnak!sid403625@gateway/web/irccloud.com/x-omecvxcysclpvrhk> has joined #bitcoin-core-dev
6172021-02-23T22:50:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6182021-02-23T22:50:03 <bitcoin-git> [bitcoin] fanquake merged pull request #21285: wallet: fix doc typo in signer option (master...signer-typo) https://github.com/bitcoin/bitcoin/pull/21285
6192021-02-23T22:50:04 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6202021-02-23T22:51:18 *** vansEU <vansEU!~vans@185.214.223.36> has joined #bitcoin-core-dev
6212021-02-23T22:51:32 *** vansEU <vansEU!~vans@185.214.223.36> has quit IRC (K-Lined)
6222021-02-23T23:06:53 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6232021-02-23T23:06:53 <bitcoin-git> [bitcoin] abdullahnazar opened pull request #21288: Create arabmarketcap (master...abdullahnazar-patch-1) https://github.com/bitcoin/bitcoin/pull/21288
6242021-02-23T23:06:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6252021-02-23T23:07:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6262021-02-23T23:07:23 <bitcoin-git> [bitcoin] fanquake closed pull request #21288: Create arabmarketcap (master...abdullahnazar-patch-1) https://github.com/bitcoin/bitcoin/pull/21288
6272021-02-23T23:07:24 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6282021-02-23T23:19:04 *** lightlike <lightlike!~lightlike@p200300c7ef179100a4f011ef5e24615f.dip0.t-ipconnect.de> has quit IRC (Quit: Leaving)
6292021-02-23T23:19:59 *** vasild_ <vasild_!~vd@gateway/tor-sasl/vasild> has joined #bitcoin-core-dev
6302021-02-23T23:20:00 *** vasild <vasild!~vd@gateway/tor-sasl/vasild> has quit IRC (Disconnected by services)
6312021-02-23T23:20:00 *** vasild_ is now known as vasild
6322021-02-23T23:28:03 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 268 seconds)
6332021-02-23T23:28:54 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
6342021-02-23T23:32:26 *** aferreira44 <aferreira44!~andre@2001:1284:f013:e991:e5ae:4270:cdb:4daa> has quit IRC (Ping timeout: 264 seconds)
6352021-02-23T23:39:46 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 268 seconds)
6362021-02-23T23:42:34 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
6372021-02-23T23:49:26 *** common <common!~common@unaffiliated/common> has joined #bitcoin-core-dev
6382021-02-23T23:51:47 *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
6392021-02-23T23:52:11 *** shesek <shesek!~shesek@164.90.217.137> has joined #bitcoin-core-dev
6402021-02-23T23:57:22 *** TonyStone <TonyStone!~TonyStone@cpe-74-76-58-56.nycap.res.rr.com> has quit IRC (Remote host closed the connection)