12021-03-10T00:02:28 <phantomcircuit> sdaftuar, sort of, if you have inbound connections from a peer that is itself in sync and announcing blocks then you will get headers, but won't call FindNextBlocksToDownload and thus won't get blocks
22021-03-10T00:02:48 <phantomcircuit> but if you're a listening node in ibd then you don't announce your address so you won't get inbound connections at all
32021-03-10T00:03:10 <phantomcircuit> seems like there's a number of things that should be changed but im unsure of why they're all restricted in the first place
42021-03-10T00:03:28 <phantomcircuit> well the bad headers one i am, but the no address relay im not
52021-03-10T00:04:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
62021-03-10T00:04:44 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ee0dc02c6f93...bca5ee6f38f0
72021-03-10T00:04:45 <bitcoin-git> bitcoin/master ffdd7de Hennadii Stepanov: build, qt: Fix regression introduced in #21363
82021-03-10T00:04:45 <bitcoin-git> bitcoin/master bca5ee6 fanquake: Merge #21400: build: Fix regression introduced in #21363
92021-03-10T00:04:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
102021-03-10T00:05:16 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
112021-03-10T00:05:16 <bitcoin-git> [bitcoin] fanquake merged pull request #21400: build: Fix regression introduced in #21363 (master...210309-regression) https://github.com/bitcoin/bitcoin/pull/21400
122021-03-10T00:05:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
132021-03-10T00:21:00 <sdaftuar> if you're a listening node in ibd, getting incoming connections doesn't really help you much? really what you want is to find a node that has the honest chain. since the way you bootstrap yourself is by relaying your address to outbound peers and hoping that other people get it, you're implicitly assuming the network graph is already connected
142021-03-10T00:21:52 <sdaftuar> so i think it's sufficient for our purposes to just fix relay at the local level, and we can extrapolate out that the network will avoid getting stuck as a result
152021-03-10T00:24:17 <phantomcircuit> sdaftuar, if you're a listening node in ibd and you get an inbound connection and that inbound connection broadcasts a block then you will send the getheaders to that peer which will trigger the full headers sync logic from that peer
162021-03-10T00:24:34 <sdaftuar> right, agreed
172021-03-10T00:24:39 <phantomcircuit> but then you won't request blocks from them and you'll still be screwed, but marginally less screwed
182021-03-10T00:24:46 <sdaftuar> also agreed
192021-03-10T00:24:51 <sdaftuar> so we should fix that
202021-03-10T00:25:10 <phantomcircuit> yes, we should *also* fix that
212021-03-10T00:25:27 <phantomcircuit> but we need to broadcast our address to outbound peers in the first place to get any inbound
222021-03-10T00:25:31 *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
232021-03-10T00:25:51 <sdaftuar> while i don't think that harms anything, for the reasons i gave above, i think that is a minor consideration
242021-03-10T00:26:08 <sdaftuar> look at it this way - the miner who produced that block presumably made outbound connections to the network
252021-03-10T00:26:10 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
262021-03-10T00:26:11 <phantomcircuit> thinking about it that might have been why i was able to just rig IBD=false and have my node sync, i instantly got hundreds of inbound connections
272021-03-10T00:26:15 <aj> can you make it so that you start broadcasting your address once you're tip is >= all your outbound peers' tips?
282021-03-10T00:26:26 <sdaftuar> as long as that miner's blocks propagate one hop, we should be able to reason that the blocks will propagate to the rest of the network
292021-03-10T00:26:34 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
302021-03-10T00:26:42 <sdaftuar> or else nothing we do will work, if the network is partitioned
312021-03-10T00:28:08 <sdaftuar> aj: using the block count they give us in their version message?
322021-03-10T00:29:13 <sdaftuar> aj: i think that's more complicated than it needs to be. it should be okay by now to just always advertise ourselves, i think
332021-03-10T00:29:31 <sdaftuar> because peers have logic to disconnect nodes that aren't keeping up
342021-03-10T00:29:55 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC ()
352021-03-10T00:31:11 <sdaftuar> phantomcircuit: i would hesitate to try to learn too many lessons about addr relay in Bitcoin based on observations on altcoins
362021-03-10T00:31:48 <sdaftuar> my perspective for now at least is that the heuristics we use mostly seem to work, but whether they work on vastly different looking network graphs is totally unclear
372021-03-10T00:32:51 <sdaftuar> (mostly an aside, i think the gating of addr relay on IBD is not too significant either way)
382021-03-10T00:33:50 <aj> sdaftuar: yeah, i guess block count would be fine as a heuristic. probably right that advertising all the time is fine though
392021-03-10T00:34:07 <phantomcircuit> sdaftuar, well for sure if we don't advertise our address we're unlikely to get inbound connections
402021-03-10T00:36:40 *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has quit IRC (Quit: Leaving)
412021-03-10T00:38:21 <sdaftuar> phantomcircuit: of course. i think that is solving a distinctly different problem than block sync not working, and its worth noting that fixing block sync causes nodes to leave IBD, which mitigates these other IBD-related issues
422021-03-10T00:38:31 <sdaftuar> that said i'm all in favor of pulling out the IBD gating wherever we don't need it
432021-03-10T00:42:33 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 245 seconds)
442021-03-10T00:50:55 *** LRSN <LRSN!d41dd2e6@212.29.210.230> has joined #bitcoin-core-dev
452021-03-10T00:54:46 <phantomcircuit> sdaftuar, actually it looks like we might? call FindNextBlocksToDownload
462021-03-10T00:54:51 <phantomcircuit> (fFetch && !pto->m_limited_node) || !::ChainstateActive().IsInitialBlockDownload()
472021-03-10T00:55:05 <phantomcircuit> fFetch is the 'nice' node logic
482021-03-10T00:57:56 *** zivl <zivl!~zivl@unaffiliated/zivl> has joined #bitcoin-core-dev
492021-03-10T00:58:01 *** zivl <zivl!~zivl@unaffiliated/zivl> has quit IRC (Client Quit)
502021-03-10T01:01:46 <sdaftuar> fFetch will be false for inbound peers, if you have any outbound peers
512021-03-10T01:05:37 *** cltrbreak_MAD2 <cltrbreak_MAD2!~ctrlbreak@159.2.165.130> has quit IRC (Ping timeout: 276 seconds)
522021-03-10T01:06:30 <sipa> indeed
532021-03-10T01:06:49 *** ctrlbreak <ctrlbreak!~ctrlbreak@159.2.165.130> has joined #bitcoin-core-dev
542021-03-10T01:08:49 *** lightlike <lightlike!~lightlike@p200300c7ef188100a44b6800926d040e.dip0.t-ipconnect.de> has quit IRC (Remote host closed the connection)
552021-03-10T01:15:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
562021-03-10T01:15:05 <bitcoin-git> [gui] jarolrod opened pull request #243: qt: fix issue when disabling the auto-enabled blank wallet checkbox (master...create-wallet) https://github.com/bitcoin-core/gui/pull/243
572021-03-10T01:15:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
582021-03-10T01:15:11 *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
592021-03-10T01:18:36 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 272 seconds)
602021-03-10T01:19:09 *** ctrlbreak <ctrlbreak!~ctrlbreak@159.2.165.130> has quit IRC (Ping timeout: 264 seconds)
612021-03-10T01:21:45 *** ctrlbreak <ctrlbreak!~ctrlbreak@159.2.165.130> has joined #bitcoin-core-dev
622021-03-10T01:23:50 *** Artea <Artea!~Lufia@artea.com.pt> has quit IRC (Ping timeout: 260 seconds)
632021-03-10T01:24:14 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
642021-03-10T01:24:14 <bitcoin-git> [bitcoin] sdaftuar closed pull request #20726: p2p: Add DISABLETX message for negotiating block-relay-only connections (master...2020-12-negotiate-block-relay) https://github.com/bitcoin/bitcoin/pull/20726
652021-03-10T01:24:16 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
662021-03-10T01:30:44 <sipa> sdaftuar: :(
672021-03-10T01:34:09 *** proofofkeags <proofofkeags!~proofofke@205.209.28.54> has quit IRC (Ping timeout: 264 seconds)
682021-03-10T01:34:21 <phantomcircuit> sdaftuar, indeed
692021-03-10T01:39:01 *** robert_spigler <robert_spigler!robertspig@gateway/shell/matrix.org/x-tujdfngeuievwcwa> has quit IRC (*.net *.split)
702021-03-10T01:39:03 *** maop <maop!~maop@37.120.211.188> has quit IRC (Remote host closed the connection)
712021-03-10T01:40:02 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
722021-03-10T01:40:46 *** spinza <spinza!~spin@102.132.245.16> has quit IRC (Quit: Coyote finally caught up with me...)
732021-03-10T01:40:59 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
742021-03-10T01:45:46 *** Guest77068 <Guest77068!~justin@2605:a601:a0ca:2e00:4d1a:a05a:6265:94e8> has quit IRC (Quit: Leaving)
752021-03-10T01:46:04 *** justin <justin!~justin@2605:a601:a0ca:2e00:4d1a:a05a:6265:94e8> has joined #bitcoin-core-dev
762021-03-10T01:46:27 *** justin is now known as Guest43272
772021-03-10T01:51:43 *** smctwo <smctwo!~smctwo@86.98.5.100> has joined #bitcoin-core-dev
782021-03-10T01:56:58 *** smctwo <smctwo!~smctwo@86.98.5.100> has quit IRC (Ping timeout: 276 seconds)
792021-03-10T01:58:57 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
802021-03-10T02:02:20 *** robert_spigler <robert_spigler!robertspig@gateway/shell/matrix.org/x-fqzdcayiqboawwcs> has joined #bitcoin-core-dev
812021-03-10T02:05:09 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
822021-03-10T02:06:02 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
832021-03-10T02:23:04 *** awesome_doge <awesome_doge!~Thunderbi@2001-b011-4010-3ce4-30e6-360b-d3b0-71b5.dynamic-ip6.hinet.net> has joined #bitcoin-core-dev
842021-03-10T02:23:45 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has quit IRC (Remote host closed the connection)
852021-03-10T02:24:15 *** rc_423 <rc_423!~r_423@cpe-75-185-100-189.cinci.res.rr.com> has joined #bitcoin-core-dev
862021-03-10T02:24:17 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
872021-03-10T02:26:18 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 245 seconds)
882021-03-10T02:30:18 *** awesome_doge <awesome_doge!~Thunderbi@2001-b011-4010-3ce4-30e6-360b-d3b0-71b5.dynamic-ip6.hinet.net> has quit IRC (Ping timeout: 260 seconds)
892021-03-10T02:33:31 *** spinza <spinza!~spin@102.132.245.16> has joined #bitcoin-core-dev
902021-03-10T02:34:14 *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has quit IRC (Ping timeout: 265 seconds)
912021-03-10T02:35:08 *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has joined #bitcoin-core-dev
922021-03-10T02:41:34 *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
932021-03-10T02:51:37 *** tvn <tvn!~tvn@37.120.211.188> has joined #bitcoin-core-dev
942021-03-10T02:52:52 *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has quit IRC (Ping timeout: 268 seconds)
952021-03-10T02:58:00 *** awesome_doge <awesome_doge!~Thunderbi@118-163-120-175.HINET-IP.hinet.net> has joined #bitcoin-core-dev
962021-03-10T02:58:34 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
972021-03-10T02:58:49 *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
982021-03-10T03:00:52 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
992021-03-10T03:01:13 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
1002021-03-10T03:42:23 *** jespada <jespada!~jespada@90.254.243.187> has quit IRC (Ping timeout: 265 seconds)
1012021-03-10T03:44:00 *** jespada <jespada!~jespada@90.254.243.187> has joined #bitcoin-core-dev
1022021-03-10T03:52:29 *** smctwo <smctwo!~smctwo@86.98.5.100> has joined #bitcoin-core-dev
1032021-03-10T03:57:33 *** smctwo <smctwo!~smctwo@86.98.5.100> has quit IRC (Ping timeout: 264 seconds)
1042021-03-10T04:00:44 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 260 seconds)
1052021-03-10T04:02:58 *** awesome_doge <awesome_doge!~Thunderbi@118-163-120-175.HINET-IP.hinet.net> has quit IRC (Ping timeout: 260 seconds)
1062021-03-10T04:03:10 *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has quit IRC (Ping timeout: 265 seconds)
1072021-03-10T04:05:03 *** awesome_doge <awesome_doge!~Thunderbi@118-163-120-175.HINET-IP.hinet.net> has joined #bitcoin-core-dev
1082021-03-10T04:07:40 *** jesseposner <jesseposner!~jp@2601:645:200:162f:d38:a5c2:980:75b0> has quit IRC (Remote host closed the connection)
1092021-03-10T04:08:33 *** jesseposner <jesseposner!~jp@2601:645:200:162f:d38:a5c2:980:75b0> has joined #bitcoin-core-dev
1102021-03-10T04:09:26 *** pox <pox!~pox@gateway/tor-sasl/pox> has quit IRC (Remote host closed the connection)
1112021-03-10T04:10:27 *** LRSN <LRSN!d41dd2e6@212.29.210.230> has quit IRC (Quit: Connection closed)
1122021-03-10T04:25:42 *** pox <pox!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
1132021-03-10T04:25:51 *** pox <pox!~pox@gateway/tor-sasl/pox> has quit IRC (Remote host closed the connection)
1142021-03-10T04:26:33 *** pox <pox!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
1152021-03-10T04:46:41 *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
1162021-03-10T04:47:06 *** shesek <shesek!~shesek@unaffiliated/shesek> has joined #bitcoin-core-dev
1172021-03-10T04:57:35 *** jasonzhouu <jasonzhouu!~jasonzhou@112.10.159.239> has left #bitcoin-core-dev
1182021-03-10T04:57:49 *** jasonzhouu <jasonzhouu!~jasonzhou@112.10.159.239> has joined #bitcoin-core-dev
1192021-03-10T05:12:22 *** smctwo <smctwo!~smctwo@86.98.5.100> has joined #bitcoin-core-dev
1202021-03-10T05:17:07 *** smctwo <smctwo!~smctwo@86.98.5.100> has quit IRC (Ping timeout: 265 seconds)
1212021-03-10T05:29:38 <shesek> do you think that regularly polling `getblockchaininfo` (say, every 5 seconds) to track syncing progress could have a noticeable effect on syncing times? it appears that it needs to lock cs_main
1222021-03-10T05:34:47 <sipa> it does, but i don't think it will affect sync progress
1232021-03-10T05:35:06 <sipa> it'll just block while it can't grab the lock, but that won't interfere with actual syncing
1242021-03-10T05:38:43 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Read error: Connection reset by peer)
1252021-03-10T05:40:44 *** roconnor <roconnor!~roconnor@host-45-58-192-182.dyn.295.ca> has quit IRC (Remote host closed the connection)
1262021-03-10T05:41:21 *** roconnor <roconnor!~roconnor@host-45-58-192-182.dyn.295.ca> has joined #bitcoin-core-dev
1272021-03-10T05:43:39 <shesek> sipa, thanks for clarifying
1282021-03-10T05:44:52 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
1292021-03-10T05:50:06 <phantomcircuit> shesek, getbestblockhash is a better target to see if you need to call getblockchaininfo
1302021-03-10T05:52:42 <shesek> phantomcircuit, this is to display progress to the user, I'm polling getblockchaininfo until headers==blocks && !ibd
1312021-03-10T05:56:53 <phantomcircuit> shesek, ah ok
1322021-03-10T06:01:06 <shesek> has a pruneuntil=<height/time> config option been discussed before?
1332021-03-10T06:01:09 <shesek> one currently has to start syncing, wait until the chain is indexed sufficiently, then issue `pruneblockchain`. it would be nice if this could be configured from the get-go without ongoing interaction, and also if it could prune before the height is reached to keep the peak disk usage down
1342021-03-10T06:02:19 <luke-jr> shesek: you could accomplish that with prune locks
1352021-03-10T06:03:04 <luke-jr> #19463
1362021-03-10T06:03:06 <gribble> https://github.com/bitcoin/bitcoin/issues/19463 | Prune locks by luke-jr · Pull Request #19463 · bitcoin/bitcoin · GitHub
1372021-03-10T06:03:10 <luke-jr> also related #20827
1382021-03-10T06:03:11 <gribble> https://github.com/bitcoin/bitcoin/issues/20827 | During IBD, prune as much as possible until we get close to where we will eventually keep blocks by luke-jr · Pull Request #20827 · bitcoin/bitcoin · GitHub
1392021-03-10T06:06:24 *** smctwo <smctwo!~smctwo@94.204.225.231> has joined #bitcoin-core-dev
1402021-03-10T06:06:47 <shesek> nice, they both seem pretty useful
1412021-03-10T06:06:47 *** sr_gi <sr_gi!~sr_gi@static-57-159-230-77.ipcom.comunitel.net> has quit IRC (Read error: Connection reset by peer)
1422021-03-10T06:07:22 *** sr_gi <sr_gi!~sr_gi@static-57-159-230-77.ipcom.comunitel.net> has joined #bitcoin-core-dev
1432021-03-10T06:10:21 <shesek> I think that users would typically want to specify a timestamp though, while prune locks works in terms of block heights
1442021-03-10T06:10:38 <sipa> i don't understand why you'd want a timestamp?
1452021-03-10T06:10:39 <shesek> it is possible to somehow ask bitcoind for the height around some timestamp?
1462021-03-10T06:10:48 *** smctwo <smctwo!~smctwo@94.204.225.231> has quit IRC (Ping timeout: 246 seconds)
1472021-03-10T06:12:13 <shesek> sipa, I want to let users choose how much unpruned data they want to save to enable wallet rescans, they'll typically be thinking about this in terms of a date rather than height
1482021-03-10T06:13:55 <sipa> ah, ok
1492021-03-10T06:14:07 <shesek> I made bitcoin wallet tracker support both, users can either `--prune-until 2021-03-10` or `--prune-until 673960` (this is with trying `pruneblockchain` repeatedly until it doesn't fail)
1502021-03-10T06:15:00 <shesek> could this have a negative effect on syncing times, btw? `pruneblockchain` also has to scan headers to translate the timestamp into an height
1512021-03-10T06:17:07 <luke-jr> shesek: well, the idea is that when you make a new backup, you'd update the prune lock for that wallet's backup
1522021-03-10T06:17:09 <luke-jr> shesek: so it won't prune until all your wallets have a backup recent enough
1532021-03-10T06:17:10 <luke-jr> and if a reorg occurs, it will shift backward prune lock start heights
1542021-03-10T06:17:11 <luke-jr> so in theory, this should avoid pruning ever pruning too much
1552021-03-10T06:19:34 <shesek> this is also about enabling the future possibility of doing wallet rescans, say a user could choose to keep around everything since '18, when they first joined bitcoin, so it'll cover all their wallets for sure
1562021-03-10T06:23:33 <shesek> basically just trying to offer some middleground between not being able to rescan at all and keeping everything
1572021-03-10T06:27:15 *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
1582021-03-10T06:33:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1592021-03-10T06:33:30 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bca5ee6f38f0...ceb6df391f28
1602021-03-10T06:33:31 <bitcoin-git> bitcoin/master fad0ae6 MarcoFalke: doc: Rename fuzz seed_dir to corpus_dir
1612021-03-10T06:33:31 <bitcoin-git> bitcoin/master ceb6df3 MarcoFalke: Merge #21388: doc: Rename fuzz seed_dir to corpus_dir
1622021-03-10T06:33:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1632021-03-10T06:33:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1642021-03-10T06:33:55 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #21388: doc: Rename fuzz seed_dir to corpus_dir (master...2103-docInputDir) https://github.com/bitcoin/bitcoin/pull/21388
1652021-03-10T06:33:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1662021-03-10T06:46:16 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC ()
1672021-03-10T06:47:46 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
1682021-03-10T06:57:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1692021-03-10T06:57:38 <bitcoin-git> [bitcoin] fanquake opened pull request #21403: build: set --build when configuring packages in depends (master...explicitly_set_depends_build) https://github.com/bitcoin/bitcoin/pull/21403
1702021-03-10T06:57:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1712021-03-10T07:01:20 *** talbtcha <talbtcha!58e26d9d@88.226.109.157> has joined #bitcoin-core-dev
1722021-03-10T07:07:33 *** T73 <T73!6d4000ac@bzq-109-64-0-172.red.bezeqint.net> has joined #bitcoin-core-dev
1732021-03-10T07:08:34 *** T73 <T73!6d4000ac@bzq-109-64-0-172.red.bezeqint.net> has quit IRC (Client Quit)
1742021-03-10T07:26:02 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1752021-03-10T07:26:03 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ceb6df391f28...eea6196c3d80
1762021-03-10T07:26:04 <bitcoin-git> bitcoin/master 4866934 fanquake: rpc: remove calls to CWallet.get()
1772021-03-10T07:26:05 <bitcoin-git> bitcoin/master 7c90c67 fanquake: rpc: refactor rpc wallet functions to take references instead of pointers
1782021-03-10T07:26:06 <bitcoin-git> bitcoin/master eea6196 MarcoFalke: Merge #21331: rpc: replace wallet raw pointers with references (#18592 reb...
1792021-03-10T07:26:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1802021-03-10T07:26:21 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1812021-03-10T07:26:21 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #21331: rpc: replace wallet raw pointers with references (#18592 rebased) (master...18592_rebased) https://github.com/bitcoin/bitcoin/pull/21331
1822021-03-10T07:26:22 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1832021-03-10T07:37:28 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
1842021-03-10T07:42:45 *** jungly <jungly!~jungly@host-79-55-185-171.retail.telecomitalia.it> has joined #bitcoin-core-dev
1852021-03-10T07:53:18 *** rex4539_ <rex4539_!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
1862021-03-10T07:56:16 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 268 seconds)
1872021-03-10T07:57:45 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1882021-03-10T07:58:45 *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has quit IRC (Ping timeout: 264 seconds)
1892021-03-10T08:11:23 *** roconnor <roconnor!~roconnor@host-45-58-192-182.dyn.295.ca> has quit IRC (Remote host closed the connection)
1902021-03-10T08:11:55 *** roconnor <roconnor!~roconnor@host-45-58-192-182.dyn.295.ca> has joined #bitcoin-core-dev
1912021-03-10T08:17:32 *** Victorsueca <Victorsueca!~Victorsue@unaffiliated/victorsueca> has joined #bitcoin-core-dev
1922021-03-10T08:50:52 *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f1aca00801e2ec5d2a57b1b.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
1932021-03-10T08:53:49 *** circ-user-JiP1n <circ-user-JiP1n!~circuser-@net-5-94-23-208.cust.vodafonedsl.it> has joined #bitcoin-core-dev
1942021-03-10T08:57:39 *** grubles <grubles!~unknown@unaffiliated/grubles> has quit IRC (Ping timeout: 260 seconds)
1952021-03-10T09:07:27 *** tvn <tvn!~tvn@37.120.211.188> has quit IRC (Remote host closed the connection)
1962021-03-10T09:12:48 *** CubicEarth <CubicEarth!~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net> has quit IRC (Ping timeout: 260 seconds)
1972021-03-10T09:14:32 *** CubicEarth <CubicEarth!~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net> has joined #bitcoin-core-dev
1982021-03-10T09:18:39 *** sr_gi <sr_gi!~sr_gi@static-57-159-230-77.ipcom.comunitel.net> has quit IRC (Read error: Connection reset by peer)
1992021-03-10T09:19:34 *** grubles <grubles!~unknown@96.30.199.172> has joined #bitcoin-core-dev
2002021-03-10T09:20:51 *** sr_gi <sr_gi!~sr_gi@static-57-159-230-77.ipcom.comunitel.net> has joined #bitcoin-core-dev
2012021-03-10T09:43:02 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2022021-03-10T09:43:02 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/eea6196c3d80...7cdadf91d513
2032021-03-10T09:43:03 <bitcoin-git> bitcoin/master a6b0fe2 John Newbery: [net processing] Remove unused CNode.address member
2042021-03-10T09:43:03 <bitcoin-git> bitcoin/master 7cdadf9 MarcoFalke: Merge #21395: Net processing: Remove unused CNode.address member
2052021-03-10T09:43:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2062021-03-10T09:43:22 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2072021-03-10T09:43:22 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #21395: Net processing: Remove unused CNode.address member (master...2021-03-remove-address) https://github.com/bitcoin/bitcoin/pull/21395
2082021-03-10T09:43:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2092021-03-10T09:49:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2102021-03-10T09:49:05 <bitcoin-git> [bitcoin] fanquake opened pull request #21404: refactor: Remove MakeUnique<T>() (master...remove_makeunique) https://github.com/bitcoin/bitcoin/pull/21404
2112021-03-10T09:49:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2122021-03-10T09:49:45 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2132021-03-10T09:49:45 <bitcoin-git> [bitcoin] fanquake opened pull request #21405: compat: remove memcpy -> memmove backwards compatibility alias (master...remove_memcpy_back_compat) https://github.com/bitcoin/bitcoin/pull/21405
2142021-03-10T09:49:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2152021-03-10T09:50:28 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
2162021-03-10T09:57:11 *** talbtcha <talbtcha!58e26d9d@88.226.109.157> has quit IRC (Quit: Connection closed)
2172021-03-10T10:04:01 *** ishaqm <ishaqm!~ishaqm@79-66-4-138.dynamic.dsl.as9105.com> has joined #bitcoin-core-dev
2182021-03-10T10:08:50 *** talbtcha <talbtcha!58e26d9d@88.226.109.157> has joined #bitcoin-core-dev
2192021-03-10T10:09:17 *** talbtcha <talbtcha!58e26d9d@88.226.109.157> has quit IRC (Client Quit)
2202021-03-10T10:12:48 *** ishaqm <ishaqm!~ishaqm@79-66-4-138.dynamic.dsl.as9105.com> has quit IRC (Remote host closed the connection)
2212021-03-10T10:27:45 *** jonatack <jonatack!~jon@37.173.131.107> has joined #bitcoin-core-dev
2222021-03-10T10:31:12 *** circ-user-JiP1n <circ-user-JiP1n!~circuser-@net-5-94-23-208.cust.vodafonedsl.it> has quit IRC (Remote host closed the connection)
2232021-03-10T10:31:23 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
2242021-03-10T10:33:08 *** jonatack <jonatack!~jon@37.173.131.107> has quit IRC (Read error: Connection reset by peer)
2252021-03-10T10:34:05 *** jonatack <jonatack!~jon@37.173.131.107> has joined #bitcoin-core-dev
2262021-03-10T10:35:42 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
2272021-03-10T10:35:53 *** awesome_doge <awesome_doge!~Thunderbi@118-163-120-175.HINET-IP.hinet.net> has quit IRC (Ping timeout: 245 seconds)
2282021-03-10T10:36:20 *** chrisguidaOld[m] <chrisguidaOld[m]!chrisguida@gateway/shell/matrix.org/x-hfxpptthejaixdjs> has quit IRC (Quit: Bridge terminating on SIGTERM)
2292021-03-10T10:36:21 *** zeropoint[m] <zeropoint[m]!zeropointi@gateway/shell/matrix.org/x-zyplrbiamqpmyscg> has quit IRC (Quit: Bridge terminating on SIGTERM)
2302021-03-10T10:36:29 *** iridis[m] <iridis[m]!iridismatr@gateway/shell/matrix.org/x-wadheebfwaipgxpm> has quit IRC (Quit: Bridge terminating on SIGTERM)
2312021-03-10T10:36:29 *** leanbarba[m] <leanbarba[m]!leanbarbam@gateway/shell/matrix.org/x-tajbpoyrpojyixfp> has quit IRC (Quit: Bridge terminating on SIGTERM)
2322021-03-10T10:36:34 *** robert_spigler <robert_spigler!robertspig@gateway/shell/matrix.org/x-fqzdcayiqboawwcs> has quit IRC (Quit: Bridge terminating on SIGTERM)
2332021-03-10T10:36:38 *** vdero133[m] <vdero133[m]!vdero133ma@gateway/shell/matrix.org/x-xfimriyqxcowcdwz> has quit IRC (Quit: Bridge terminating on SIGTERM)
2342021-03-10T10:36:38 *** vadorovsky <vadorovsky!vadorovsky@gateway/shell/matrix.org/x-gbovdylruzlmumqk> has quit IRC (Quit: Bridge terminating on SIGTERM)
2352021-03-10T10:36:40 *** suzziminer[m] <suzziminer[m]!suzziminer@gateway/shell/matrix.org/x-cjfslzsmnrrmyqsw> has quit IRC (Quit: Bridge terminating on SIGTERM)
2362021-03-10T10:36:41 *** Thomas[m]1 <Thomas[m]1!thomaseizi@gateway/shell/matrix.org/x-pgbrmczgdgpzqsbb> has quit IRC (Quit: Bridge terminating on SIGTERM)
2372021-03-10T10:38:54 *** CubicEarth <CubicEarth!~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net> has quit IRC (Ping timeout: 246 seconds)
2382021-03-10T10:41:39 *** CubicEarth <CubicEarth!~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net> has joined #bitcoin-core-dev
2392021-03-10T10:47:42 *** robert_spigler <robert_spigler!robertspig@gateway/shell/matrix.org/x-xaqdenlnphxppscx> has joined #bitcoin-core-dev
2402021-03-10T10:52:53 *** jonatack <jonatack!~jon@37.173.131.107> has quit IRC (Read error: Connection reset by peer)
2412021-03-10T10:53:55 *** jonatack <jonatack!~jon@37.173.131.107> has joined #bitcoin-core-dev
2422021-03-10T10:55:44 *** suzziminer[m] <suzziminer[m]!suzziminer@gateway/shell/matrix.org/x-xasxzzuophihqkpo> has joined #bitcoin-core-dev
2432021-03-10T11:13:48 *** Thomas[m]1 <Thomas[m]1!thomaseizi@gateway/shell/matrix.org/x-rdgxtsmgipijqlhr> has joined #bitcoin-core-dev
2442021-03-10T11:13:49 *** vadorovsky <vadorovsky!vadorovsky@gateway/shell/matrix.org/x-cjsaltgrfbcsdfya> has joined #bitcoin-core-dev
2452021-03-10T11:13:54 *** iridis[m] <iridis[m]!iridismatr@gateway/shell/matrix.org/x-huodujsloxbpbzyi> has joined #bitcoin-core-dev
2462021-03-10T11:13:54 *** leanbarba[m] <leanbarba[m]!leanbarbam@gateway/shell/matrix.org/x-kecnhwmogrrujpxt> has joined #bitcoin-core-dev
2472021-03-10T11:13:54 *** vdero133[m] <vdero133[m]!vdero133ma@gateway/shell/matrix.org/x-fleuddsxfjecosyb> has joined #bitcoin-core-dev
2482021-03-10T11:13:55 *** chrisguidaOld[m] <chrisguidaOld[m]!chrisguida@gateway/shell/matrix.org/x-npwltavnodeqbewh> has joined #bitcoin-core-dev
2492021-03-10T11:13:56 *** zeropoint[m] <zeropoint[m]!zeropointi@gateway/shell/matrix.org/x-mlwgvotlnvdoubwh> has joined #bitcoin-core-dev
2502021-03-10T11:28:07 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
2512021-03-10T11:32:14 *** jungly <jungly!~jungly@host-79-55-185-171.retail.telecomitalia.it> has quit IRC (Ping timeout: 260 seconds)
2522021-03-10T11:32:48 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 246 seconds)
2532021-03-10T11:33:58 *** queip <queip!~queip@unaffiliated/rezurus> has joined #bitcoin-core-dev
2542021-03-10T11:39:58 *** jungly <jungly!~jungly@host-79-55-185-171.retail.telecomitalia.it> has joined #bitcoin-core-dev
2552021-03-10T11:59:25 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
2562021-03-10T12:04:43 *** avii <avii!51a74997@151.81-167-73.customer.lyse.net> has joined #bitcoin-core-dev
2572021-03-10T12:05:21 *** jungly <jungly!~jungly@host-79-55-185-171.retail.telecomitalia.it> has quit IRC (Ping timeout: 264 seconds)
2582021-03-10T12:43:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2592021-03-10T12:43:20 <bitcoin-git> [bitcoin] vasild opened pull request #21407: i2p: limit the size of incoming messages (master...limit_RecvUntilTerminator) https://github.com/bitcoin/bitcoin/pull/21407
2602021-03-10T12:43:21 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2612021-03-10T12:56:07 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
2622021-03-10T12:56:39 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
2632021-03-10T13:01:06 <vasild> jonatack: how big is ./oom-da39a3ee5e6b4b0d3255bfef95601890afd80709? Can I get it in order to reproduce?
2642021-03-10T13:03:21 <vasild> "base unit: 0000000000000000000000000000000000000000", does it contain just a bunch of zeros? I tried with a file that contains 20 zero bytes, but it executed without errors
2652021-03-10T13:10:22 *** wenyi <wenyi!8be26a10@139.226.106.16> has joined #bitcoin-core-dev
2662021-03-10T13:18:28 *** awesome_doge <awesome_doge!~Thunderbi@2001-b400-e272-0349-b938-37a3-0138-72fb.emome-ip6.hinet.net> has joined #bitcoin-core-dev
2672021-03-10T13:30:02 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 264 seconds)
2682021-03-10T13:33:45 *** wenyi <wenyi!8be26a10@139.226.106.16> has quit IRC (Quit: Connection closed)
2692021-03-10T13:39:28 *** jungly <jungly!~jungly@host-79-55-185-171.retail.telecomitalia.it> has joined #bitcoin-core-dev
2702021-03-10T13:39:37 *** very_sneaky <very_sneaky!~very_snea@45.67.96.42> has quit IRC (Ping timeout: 276 seconds)
2712021-03-10T13:45:48 *** awesome_doge <awesome_doge!~Thunderbi@2001-b400-e272-0349-b938-37a3-0138-72fb.emome-ip6.hinet.net> has quit IRC (Ping timeout: 260 seconds)
2722021-03-10T14:00:18 <jonatack> vasild: it is an empty file.... -rw-r--r-- 1 0 Mar 10 13:20 oom-da39a3ee5e6b4b0d3255bfef95601890afd80709
2732021-03-10T14:01:11 <vasild> executes without issues here: Executed /tmp/oom in 1 ms
2742021-03-10T14:01:28 <vasild> can you reproduce?
2752021-03-10T14:01:33 <jonatack> do you also get OOM with? src/test/fuzz/fuzz ../qa-assets/fuzz_seed_corpus/
2762021-03-10T14:01:46 <jonatack> FUZZ=i2p src/test/fuzz/fuzz ../qa-assets/fuzz_seed_corpus/
2772021-03-10T14:02:25 <jonatack> (i don't have the fuzz build anymore, testing another PR, will re-check a bit later)
2782021-03-10T14:05:44 <vasild> I did not try but this usage looks strange: ../qa-assets/fuzz_seed_corpus/ does not contain any seeds, just subdirectories, shouldn't that be ../qa-assets/fuzz_seed_corpus/i2p/ ?
2792021-03-10T14:06:39 <vasild> I run it like "src/test/fuzz/fuzz /some/new/empty/directory"
2802021-03-10T14:07:27 <vasild> anyway, I ran it over the weekend (~2 days) without seeing any issues
2812021-03-10T14:34:30 *** leonardo_ <leonardo_!sid489830@gateway/web/irccloud.com/x-hewqwxmrmupgkqpa> has joined #bitcoin-core-dev
2822021-03-10T14:35:24 *** ishaqm <ishaqm!~ishaqm@79-66-4-138.dynamic.dsl.as9105.com> has joined #bitcoin-core-dev
2832021-03-10T14:44:22 *** jonatack <jonatack!~jon@37.173.131.107> has quit IRC (Read error: Connection reset by peer)
2842021-03-10T14:44:31 *** scedastik <scedastik!~scedastik@c-68-58-168-96.hsd1.mi.comcast.net> has joined #bitcoin-core-dev
2852021-03-10T14:45:14 *** scedastik <scedastik!~scedastik@c-68-58-168-96.hsd1.mi.comcast.net> has left #bitcoin-core-dev
2862021-03-10T14:45:18 *** scedastik <scedastik!~scedastik@c-68-58-168-96.hsd1.mi.comcast.net> has joined #bitcoin-core-dev
2872021-03-10T14:45:48 *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has quit IRC (Remote host closed the connection)
2882021-03-10T14:46:11 *** jonatack <jonatack!~jon@37.173.131.107> has joined #bitcoin-core-dev
2892021-03-10T14:59:01 *** gribble <gribble!~gribble@unaffiliated/nanotube/bot/gribble> has joined #bitcoin-core-dev
2902021-03-10T15:09:13 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
2912021-03-10T15:11:58 *** IGHOR <IGHOR!~quassel@176.121.4.135> has quit IRC (Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.)
2922021-03-10T15:12:44 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 260 seconds)
2932021-03-10T15:14:02 *** kabaum <kabaum!~kabaum@h-13-35.A163.priv.bahnhof.se> has quit IRC (Ping timeout: 260 seconds)
2942021-03-10T15:16:28 *** promag <promag!~promag@188.250.84.129> has quit IRC (Read error: Connection reset by peer)
2952021-03-10T15:16:40 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
2962021-03-10T15:17:05 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
2972021-03-10T15:18:30 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Remote host closed the connection)
2982021-03-10T15:21:31 *** kabaum <kabaum!~kabaum@h-13-35.A163.priv.bahnhof.se> has joined #bitcoin-core-dev
2992021-03-10T15:23:14 *** IGHOR <IGHOR!~quassel@176.121.4.135> has joined #bitcoin-core-dev
3002021-03-10T15:24:09 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
3012021-03-10T15:26:10 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 260 seconds)
3022021-03-10T15:26:38 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
3032021-03-10T15:30:05 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
3042021-03-10T15:30:23 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
3052021-03-10T15:31:18 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 260 seconds)
3062021-03-10T15:32:39 *** Eagle[TM] <Eagle[TM]!~EagleTM@unaffiliated/eagletm> has quit IRC (Remote host closed the connection)
3072021-03-10T15:35:19 <luke-jr> jnewbery: CI is supposed to merge PRs to master before running tests.. it should never require a rebase O.o
3082021-03-10T15:35:51 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has joined #bitcoin-core-dev
3092021-03-10T15:37:43 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
3102021-03-10T15:44:14 <jnewbery> luke-jr: hmmm, i'm not sure that's working on #19391. It doesn't look like _any_ Cirrus CI jobs have been run on it
3112021-03-10T15:44:15 <gribble> https://github.com/bitcoin/bitcoin/issues/19391 | RPC/Mining: Clean out pre-Segwit miner compatibility code by luke-jr · Pull Request #19391 · bitcoin/bitcoin · GitHub
3122021-03-10T15:44:50 <jnewbery> only travis and appveyor. I guess that's because the branch is from before cirrus was a thing
3132021-03-10T15:45:15 <aj> i think it's just that the last update to the PR was before cirrus was a thing?
3142021-03-10T15:47:30 <jnewbery> I think it's generally useful for reviewers to rebase on master fairly regularly. If you don't then they either have to rebase it themselves, or building takes forever since everything needs to be recompiled
3152021-03-10T15:49:36 <aj> you don't have to rebase, just "git checkout origin/master; git merge pull/origin/12345"
3162021-03-10T15:51:03 *** rex4539_ <rex4539_!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Remote host closed the connection)
3172021-03-10T15:52:19 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
3182021-03-10T16:02:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3192021-03-10T16:02:30 <bitcoin-git> [gui] MarcoFalke merged pull request #229: Fix regression with initial sorting after pr205 (master...210227-sort) https://github.com/bitcoin-core/gui/pull/229
3202021-03-10T16:02:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3212021-03-10T16:02:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3222021-03-10T16:02:50 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7cdadf91d513...63314b8211d7
3232021-03-10T16:02:51 <bitcoin-git> bitcoin/master c524dc5 Hennadii Stepanov: qt: Fix regression with initial sorting after pr205
3242021-03-10T16:02:52 <bitcoin-git> bitcoin/master 63314b8 MarcoFalke: Merge bitcoin-core/gui#229: Fix regression with initial sorting after pr20...
3252021-03-10T16:02:53 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3262021-03-10T16:05:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3272021-03-10T16:05:58 <bitcoin-git> [bitcoin] luke-jr closed pull request #19391: RPC/Mining: Clean out pre-Segwit miner compatibility code (master...gbt_rm_versionforce) https://github.com/bitcoin/bitcoin/pull/19391
3282021-03-10T16:05:59 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3292021-03-10T16:06:09 <luke-jr> hmm, surely there's some way to trigger a CI re-run
3302021-03-10T16:06:18 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3312021-03-10T16:06:18 <bitcoin-git> [bitcoin] luke-jr reopened pull request #19391: RPC/Mining: Clean out pre-Segwit miner compatibility code (master...gbt_rm_versionforce) https://github.com/bitcoin/bitcoin/pull/19391
3322021-03-10T16:06:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3332021-03-10T16:07:07 <MarcoFalke> EDITOR=true git commit --amend && git push ... ... -f
3342021-03-10T16:07:47 <luke-jr> MarcoFalke: yeah, but that's ugly :P
3352021-03-10T16:08:21 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 268 seconds)
3362021-03-10T16:08:25 <MarcoFalke> git commit --allow-empty -m empty && git push ... ... && sleep 15 && git push ... HEAD~:... -f
3372021-03-10T16:08:37 <luke-jr> >_<
3382021-03-10T16:08:48 <hebasto> nice progress with #21376 -- 2 ACKs already :)
3392021-03-10T16:08:51 <gribble> https://github.com/bitcoin/bitcoin/issues/21376 | depends: Qt 5.12.10 by fanquake · Pull Request #21376 · bitcoin/bitcoin · GitHub
3402021-03-10T16:08:51 <luke-jr> I thought DrahtBot did it somehow
3412021-03-10T16:09:35 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
3422021-03-10T16:14:33 *** jonatack <jonatack!~jon@37.173.131.107> has quit IRC (Ping timeout: 246 seconds)
3432021-03-10T16:15:01 *** jonatack <jonatack!~jon@37.173.131.107> has joined #bitcoin-core-dev
3442021-03-10T16:15:02 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 264 seconds)
3452021-03-10T16:15:50 *** proofofkeags <proofofkeags!~proofofke@205.209.28.54> has joined #bitcoin-core-dev
3462021-03-10T16:26:51 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
3472021-03-10T16:32:15 *** pox <pox!~pox@gateway/tor-sasl/pox> has quit IRC (Quit: pox)
3482021-03-10T16:32:50 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Read error: Connection reset by peer)
3492021-03-10T16:33:01 *** pox <pox!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
3502021-03-10T16:33:16 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
3512021-03-10T16:36:34 <jnewbery> aj: good tip with the git merge. As a reviewer though, I want the thing I review to be as close as possible to the thing that master would be if the branch is merged, which for this project is the branch rebased on master. Probably doesn't make that much difference though
3522021-03-10T16:38:07 <hebasto> jnewbery: also `git fetch origin pull/12345/merge`
3532021-03-10T16:40:06 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 246 seconds)
3542021-03-10T16:40:28 <luke-jr> jnewbery: actually, what aj suggested is the closest thing (aside from the commit message and PGP sig)
3552021-03-10T16:44:55 <queip> anyone knowing wallet code around? if you don't mind I wanted to confirm, is Core quaranteed to correctly load and show history/ballance if you load many wallet files, of which some are the same wallet but older backup of it. does the fact same key exists in many wallets is not bugging out some assumptions in code
3562021-03-10T16:45:09 <queip> (if you load it all at once)
3572021-03-10T16:45:44 <luke-jr> queip: you can't load more than one at a time
3582021-03-10T16:47:07 <queip> luke-jr: you mean, loading older backup -wallet=wallet1.dat while also loading new version of it -wallet=wallet2.dat is not allowed?
3592021-03-10T16:47:11 <luke-jr> right
3602021-03-10T16:47:21 <queip> is it safe (detected and refused)?
3612021-03-10T16:47:23 <jnewbery> luke-jr: oh yes, you're right
3622021-03-10T16:47:34 <luke-jr> queip: yes, for bdb wallets
3632021-03-10T16:47:51 <queip> luke-jr: do the wallets contain some internal UUID set on creation?
3642021-03-10T16:47:57 <luke-jr> queip: yes
3652021-03-10T16:48:01 <queip> oh great
3662021-03-10T16:48:17 <luke-jr> the experimetnal descriptor wallets / sqlite are missing this at the moment
3672021-03-10T16:48:18 <queip> including old (but post 2011) versions?
3682021-03-10T16:48:24 <luke-jr> see #20205
3692021-03-10T16:48:27 <gribble> https://github.com/bitcoin/bitcoin/issues/20205 | wallet: Properly support a wallet id by achow101 · Pull Request #20205 · bitcoin/bitcoin · GitHub
3702021-03-10T16:48:31 <queip> interesting
3712021-03-10T16:48:39 <luke-jr> queip: I'm not sure when the safe detection was added
3722021-03-10T16:48:42 *** pox <pox!~pox@gateway/tor-sasl/pox> has quit IRC (Quit: pox)
3732021-03-10T16:50:56 *** pox <pox!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
3742021-03-10T16:51:03 *** pox <pox!~pox@gateway/tor-sasl/pox> has quit IRC (Client Quit)
3752021-03-10T16:51:44 *** infernix <infernix!nix@unaffiliated/infernix> has quit IRC (Remote host closed the connection)
3762021-03-10T16:52:26 *** infernix <infernix!~nix@unaffiliated/infernix> has joined #bitcoin-core-dev
3772021-03-10T16:53:01 <MarcoFalke> I generally merge/rebase a pull before review if I want to test it. My ccache is populated with latest master, so applying changes on top of master will make it compile faster
3782021-03-10T16:53:56 <luke-jr> nice tip, I should do that
3792021-03-10T16:54:33 <luke-jr> gcmw() { git checkout --detach origin/master && git merge "$@"; } ? :p
3802021-03-10T16:55:07 <sipsorcery>
3812021-03-10T16:55:30 <MarcoFalke> just git rebase/merge bitcoin/master (not a lot to type with auto-complete)
3822021-03-10T16:56:19 *** jespada <jespada!~jespada@90.254.243.187> has quit IRC (Ping timeout: 245 seconds)
3832021-03-10T16:58:34 *** eoin <eoin!332556a5@51.37.86.165> has joined #bitcoin-core-dev
3842021-03-10T16:58:45 *** lightlike <lightlike!~lightlike@p200300c7ef13e3001907dbbcf7a603f5.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
3852021-03-10T16:59:25 *** jespada <jespada!~jespada@90.254.243.187> has joined #bitcoin-core-dev
3862021-03-10T16:59:56 <jnewbery> MarcoFalke: yes, same
3872021-03-10T17:04:42 <jonatack> same, I usually rebase unless it was just rebased
3882021-03-10T17:08:55 *** ishaqm <ishaqm!~ishaqm@79-66-4-138.dynamic.dsl.as9105.com> has quit IRC (Remote host closed the connection)
3892021-03-10T17:20:37 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
3902021-03-10T17:21:09 *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f1aca00801e2ec5d2a57b1b.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
3912021-03-10T17:21:47 *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
3922021-03-10T17:31:23 <jeremyrubin> Who runs drahbot?
3932021-03-10T17:32:27 <jeremyrubin> it might be nice to add an annotation when drahbot lists conflicts for last commented date (was looking at #21404 for this)
3942021-03-10T17:32:29 <gribble> https://github.com/bitcoin/bitcoin/issues/21404 | refactor: Remove MakeUnique () by fanquake · Pull Request #21404 · bitcoin/bitcoin · GitHub
3952021-03-10T17:32:45 <sipa> MarcoFalke: ^
3962021-03-10T17:33:31 <MarcoFalke> What is an "annotation"?
3972021-03-10T17:34:14 <jeremyrubin> when drahbot comments with the lists of PRs conflicting, a label that shows when the PR was last updated
3982021-03-10T17:34:34 <MarcoFalke> There is a dropdown "edited <". For example: https://github.com/bitcoin/bitcoin/pull/21244#issuecomment-782685008
3992021-03-10T17:34:42 <MarcoFalke> It shows the last time the comment was edited
4002021-03-10T17:34:59 <jeremyrubin> no I'm saying that for every PR listed
4012021-03-10T17:35:10 <jeremyrubin> it might be convenient to show if it's something that's stale or not
4022021-03-10T17:35:35 <jeremyrubin> If you look at https://github.com/bitcoin/bitcoin/pull/21404#issuecomment-795722299
4032021-03-10T17:35:45 *** ovovo <ovovo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 246 seconds)
4042021-03-10T17:35:58 <jeremyrubin> + jnewbery's comment: Concept ACK, although I agree with Marco that we should wait for drahtbot to tell us how many PRs this conflicts with, and hold back if any of those are important and close to being merged.
4052021-03-10T17:36:53 <jeremyrubin> recency of PR update as a proxy for importance
4062021-03-10T17:37:44 <MarcoFalke> Oh you mean each conflict pr in the list would have a (last updated: date). That is certainly possible, but would need to be updated on probably every run
4072021-03-10T17:37:58 <MarcoFalke> you mean inverse proxy? ;)
4082021-03-10T17:38:21 <jeremyrubin> 'heuristic'
4092021-03-10T17:39:17 <MarcoFalke> For example #20966 is important, but it doesn't have any comments (apart from "Needs rebase" and "Rebased")
4102021-03-10T17:39:18 <jeremyrubin> it's not super important, I've found myself wanting this before though when I get random conflicts. I could see how it would be annoying to have to go back through and filter updates by drahbot/non drahbot etc
4112021-03-10T17:39:19 <gribble> https://github.com/bitcoin/bitcoin/issues/20966 | banman: save the banlist in a JSON format on disk by vasild · Pull Request #20966 · bitcoin/bitcoin · GitHub
4122021-03-10T17:40:27 <jeremyrubin> MarcoFalke: is drahbot open source somewhere?
4132021-03-10T17:40:38 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
4142021-03-10T17:40:56 <MarcoFalke> The code is too ugly to make open source
4152021-03-10T17:41:11 <MarcoFalke> You'd be able to write nicer code in less than 5 minutes
4162021-03-10T17:41:13 <jeremyrubin> invite me to the repo I could take a look...
4172021-03-10T17:41:30 <jeremyrubin> Maybe counting commit tagged ACKs for the current git tip could be a good heuristic too?
4182021-03-10T17:42:07 <jeremyrubin> MarcoFalke: not the hugest fan of devops-y stuff so it would probably take me > 5 mins :)
4192021-03-10T17:42:48 <MarcoFalke> Yeah, the ACK would be a good idea
4202021-03-10T17:42:56 <MarcoFalke> *ACKs
4212021-03-10T17:43:23 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
4222021-03-10T17:43:53 <jeremyrubin> Maybe also adding the ability for maintainers / PR author to comment clearack if they think the acks need to be invalidated (e.g., someone finds a bug)
4232021-03-10T17:43:59 <jeremyrubin> don't need to get too fancy
4242021-03-10T17:44:21 <jeremyrubin> but I think improving the tooling a bit could help deduplicate a lot of replicated manual work
4252021-03-10T17:44:28 <MarcoFalke> heh, all I know about devops is how to write a loop in bash. DrahtBot is basically a `while true; ./label_rebase.py ; done`, where the python script just imports a github api library and then tags all pulls needing rebase...
4262021-03-10T17:45:01 <MarcoFalke> That's what NACK is for
4272021-03-10T17:47:37 <jeremyrubin> I think NACK is ambiguous between NACK this and all bugfixes of this v.s. "the current ACKs should be invalidated"
4282021-03-10T17:47:47 <jeremyrubin> But I guess it's not too important
4292021-03-10T17:48:11 <MarcoFalke> Concept NACK / Approach NACK are about the concept/Approach
4302021-03-10T17:48:20 <MarcoFalke> NACK commit_id is about a specific id
4312021-03-10T17:48:32 <MarcoFalke> (at least that's how I use it)
4322021-03-10T17:48:41 <sipa> yes
4332021-03-10T17:48:41 <MarcoFalke> Probably should be documented as such
4342021-03-10T17:48:45 <jeremyrubin> yeah
4352021-03-10T17:49:53 <jeremyrubin> Could be nice to have an @admiralackbot that has a documented ACKs API to better collate and style conform what ACKs have been used... GH also has builtin "approved changes" but I don't find it explicit enough for my tastes
4362021-03-10T17:50:29 <jeremyrubin> Maybe I'll hack one together if people like the idea of having something like that
4372021-03-10T17:53:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4382021-03-10T17:53:12 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #21408: doc: Explain how NACK commit_id works (master...2103-docNack) https://github.com/bitcoin/bitcoin/pull/21408
4392021-03-10T17:53:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4402021-03-10T17:53:13 <MarcoFalke> sipa: jeremyrubin: ^
4412021-03-10T17:55:24 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has quit IRC (Remote host closed the connection)
4422021-03-10T18:02:27 <jeremyrubin> MarcoFalke: there's some annoying things with how git works that it probably makes sense to clarify around e.g., rebase + push -f that would make NACK id stale that we should clarify NACK <id> becomes NACK untill explicitly lifted
4432021-03-10T18:02:34 <jeremyrubin> I made a comment as such but it feels... overkill
4442021-03-10T18:03:29 <MarcoFalke> jeremyrubin: You can re-NACK (just like a re-ACK)
4452021-03-10T18:04:03 <jeremyrubin> I think on the balance it's safer to require re-ack, but not to require re-nack
4462021-03-10T18:04:07 <MarcoFalke> Also, if you use the GitHub NACK feature, the merge button will turn red (instead of green)
4472021-03-10T18:04:17 <MarcoFalke> Even after rebase
4482021-03-10T18:05:28 <MarcoFalke> I think it is safe to assume a NACK is "sticky" until unsticked (no need to document that)
4492021-03-10T18:05:43 *** eoin <eoin!332556a5@51.37.86.165> has quit IRC (Ping timeout: 240 seconds)
4502021-03-10T18:05:45 <achow101> queip: if you load multiple wallets with the same keys, it will handle them independently. It will show all of the same transactions, although the timestamps of those transactions may differ. If you copy the wallet file, for bdb wallets, we don't allow you to load the copies due to caching (and other) issues with bdb itself. There is no other reason that loading duplicate wallets would be disallowed.
4512021-03-10T18:05:46 <MarcoFalke> Obviously to be on the safe side, I'd still encourage to re-NACK if needed.
4522021-03-10T18:06:11 <MarcoFalke> If the documentation is too verbose, chances are less people will read it
4532021-03-10T18:10:06 *** jonatack <jonatack!~jon@37.173.131.107> has quit IRC (Quit: jonatack)
4542021-03-10T18:10:23 *** jonatack <jonatack!~jon@37.173.131.107> has joined #bitcoin-core-dev
4552021-03-10T18:10:24 *** jonatack <jonatack!~jon@37.173.131.107> has quit IRC (Read error: Connection reset by peer)
4562021-03-10T18:11:00 *** jonatack <jonatack!~jon@37.173.131.107> has joined #bitcoin-core-dev
4572021-03-10T18:11:34 *** jonatack <jonatack!~jon@37.173.131.107> has quit IRC (Client Quit)
4582021-03-10T18:11:48 *** jonatack <jonatack!~jon@37.173.131.107> has joined #bitcoin-core-dev
4592021-03-10T18:12:40 *** jonatack <jonatack!~jon@37.173.131.107> has quit IRC (Client Quit)
4602021-03-10T18:13:00 *** jonatack <jonatack!~jon@37.173.131.107> has joined #bitcoin-core-dev
4612021-03-10T18:15:57 <MarcoFalke> what about adding labels to denote the number of ACKs?
4622021-03-10T18:16:11 *** nathanael <nathanael!~nathanael@unaffiliated/nathanael> has joined #bitcoin-core-dev
4632021-03-10T18:16:30 *** avii <avii!51a74997@151.81-167-73.customer.lyse.net> has quit IRC (Quit: Connection closed)
4642021-03-10T18:16:43 <MarcoFalke> which color are ACKs?
4652021-03-10T18:17:52 <MarcoFalke> https://github.com/bitcoin/bitcoin/labels/1%20ACK
4662021-03-10T18:22:02 <jeremyrubin> love that idea, it's simple
4672021-03-10T18:23:49 <jeremyrubin> if people abuse it we can make it only count ACKs on a list (just for the tooling, people could add themselves) but I think ACK labels are great
4682021-03-10T18:24:08 <luke-jr> MarcoFalke: the label should be coloured lime green /s
4692021-03-10T18:24:19 *** copumpkin <copumpkin!~copumpkin@unaffiliated/copumpkin> has quit IRC (Remote host closed the connection)
4702021-03-10T18:24:41 <MarcoFalke> luke-jr: Did that
4712021-03-10T18:24:43 <luke-jr> lol
4722021-03-10T18:24:49 <jeremyrubin> a different shade though
4732021-03-10T18:24:59 <jeremyrubin> (jk)
4742021-03-10T18:25:14 *** copumpkin <copumpkin!~copumpkin@unaffiliated/copumpkin> has joined #bitcoin-core-dev
4752021-03-10T18:25:54 <luke-jr> jeremyrubin: wait, you mean it should be key-lime green?
4762021-03-10T18:26:35 <jeremyrubin> Mmm was thinking chartreuse actually
4772021-03-10T18:26:42 *** cguida <cguida!~Adium@2806:2f0:51c1:5cee:111d:a146:4654:4a12> has joined #bitcoin-core-dev
4782021-03-10T18:27:53 <luke-jr> wut
4792021-03-10T18:28:16 <jeremyrubin> it comes from the french liquor chartreuse, which comes from "charter house", where a charter can be a conferrence of privilege.
4802021-03-10T18:30:41 *** mol_ <mol_!mol@gateway/vpn/protonvpn/molly> has joined #bitcoin-core-dev
4812021-03-10T18:32:46 *** jungly <jungly!~jungly@host-79-55-185-171.retail.telecomitalia.it> has quit IRC (Ping timeout: 276 seconds)
4822021-03-10T18:33:40 *** ccdle12 <ccdle12!955adef3@243.222.90.149.rev.vodafone.pt> has joined #bitcoin-core-dev
4832021-03-10T18:34:15 <jonatack> nah, these liquors usually were made by monks or nuns
4842021-03-10T18:34:42 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 260 seconds)
4852021-03-10T18:34:53 <jonatack> this one by carthusian monks located in the chartreuse mountains near the french alps
4862021-03-10T18:38:35 *** pox <pox!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
4872021-03-10T18:38:46 *** Chris_Stewart_5 <Chris_Stewart_5!~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383> has joined #bitcoin-core-dev
4882021-03-10T18:45:13 *** roconnor <roconnor!~roconnor@host-45-58-192-182.dyn.295.ca> has quit IRC (Ping timeout: 256 seconds)
4892021-03-10T18:46:44 *** jonatack <jonatack!~jon@37.173.131.107> has quit IRC (Read error: Connection reset by peer)
4902021-03-10T18:47:12 *** jonatack <jonatack!~jon@37.173.131.107> has joined #bitcoin-core-dev
4912021-03-10T18:51:39 *** az0re <az0re!~az0re@gateway/tor-sasl/az0re> has joined #bitcoin-core-dev
4922021-03-10T18:54:50 *** smctwo <smctwo!~smctwo@86.98.5.100> has joined #bitcoin-core-dev
4932021-03-10T18:58:12 *** jonatack <jonatack!~jon@37.173.131.107> has quit IRC (Quit: jonatack)
4942021-03-10T19:28:40 *** jonatack <jonatack!~jon@37.173.131.107> has joined #bitcoin-core-dev
4952021-03-10T19:32:39 *** justan0theruser <justan0theruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
4962021-03-10T19:34:14 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Ping timeout: 264 seconds)
4972021-03-10T19:34:30 *** tlev6 <tlev6!~tlev@li120-195.members.linode.com> has joined #bitcoin-core-dev
4982021-03-10T19:34:51 *** rockhouse1 <rockhouse1!~rockhouse@unaffiliated/rockhouse> has joined #bitcoin-core-dev
4992021-03-10T19:35:39 *** Emcy_ <Emcy_!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
5002021-03-10T19:35:40 *** pinheadmz_ <pinheadmz_!~pinheadmz@hns-contributor.dev> has joined #bitcoin-core-dev
5012021-03-10T19:35:59 *** Emcy_ <Emcy_!~Emcy@unaffiliated/emcy> has quit IRC (Remote host closed the connection)
5022021-03-10T19:36:30 *** Emcy_ <Emcy_!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
5032021-03-10T19:37:01 *** justinmoon_ <justinmoon_!~quassel@157.245.122.126> has joined #bitcoin-core-dev
5042021-03-10T19:37:53 *** IGHOR_ <IGHOR_!~quassel@176.121.4.135> has joined #bitcoin-core-dev
5052021-03-10T19:38:07 *** Chris_St1 <Chris_St1!~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383> has joined #bitcoin-core-dev
5062021-03-10T19:38:10 *** grubles_ <grubles_!~unknown@96.30.199.172> has joined #bitcoin-core-dev
5072021-03-10T19:38:20 *** harrigan <harrigan!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has joined #bitcoin-core-dev
5082021-03-10T19:38:25 *** dhruvm_ <dhruvm_!~dhruv@165.227.49.220> has joined #bitcoin-core-dev
5092021-03-10T19:39:13 *** mekster9 <mekster9!~mekster@139.180.192.79> has joined #bitcoin-core-dev
5102021-03-10T19:39:40 *** Setherson <Setherson!~Setherson@108-255-110-61.lightspeed.tukrga.sbcglobal.net> has quit IRC (Ping timeout: 256 seconds)
5112021-03-10T19:41:49 *** smctwo <smctwo!~smctwo@86.98.5.100> has quit IRC (Remote host closed the connection)
5122021-03-10T19:42:06 *** thrasher`_ <thrasher`_!~thrasher@173.209.42.7> has joined #bitcoin-core-dev
5132021-03-10T19:42:43 *** Chris_Stewart_5 <Chris_Stewart_5!~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383> has quit IRC (*.net *.split)
5142021-03-10T19:42:43 *** IGHOR <IGHOR!~quassel@176.121.4.135> has quit IRC (*.net *.split)
5152021-03-10T19:42:43 *** grubles <grubles!~unknown@unaffiliated/grubles> has quit IRC (*.net *.split)
5162021-03-10T19:42:43 *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (*.net *.split)
5172021-03-10T19:42:43 *** pinheadmz <pinheadmz!~pinheadmz@hns-contributor.dev> has quit IRC (*.net *.split)
5182021-03-10T19:42:44 *** nickler <nickler!~nickler@static.219.205.69.159.clients.your-server.de> has quit IRC (*.net *.split)
5192021-03-10T19:42:44 *** adiabat_ <adiabat_!~adiabat@63.209.32.102> has quit IRC (*.net *.split)
5202021-03-10T19:42:44 *** thrasher` <thrasher`!~thrasher@173.209.42.7> has quit IRC (*.net *.split)
5212021-03-10T19:42:44 *** rockhouse <rockhouse!~rockhouse@unaffiliated/rockhouse> has quit IRC (*.net *.split)
5222021-03-10T19:42:44 *** harrigan- <harrigan-!~harrigan@ptr-93-89-242-235.ip.airwire.ie> has quit IRC (*.net *.split)
5232021-03-10T19:42:44 *** Evel-Knievel <Evel-Knievel!~Evel-Knie@d5152f744.static.telenet.be> has quit IRC (*.net *.split)
5242021-03-10T19:42:44 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (*.net *.split)
5252021-03-10T19:42:45 *** marcoagn1 <marcoagn1!~user@bl19-147-149.dsl.telepac.pt> has quit IRC (*.net *.split)
5262021-03-10T19:42:45 *** mekster <mekster!~mekster@139.180.192.79> has quit IRC (*.net *.split)
5272021-03-10T19:42:45 *** tlev <tlev!~tlev@li120-195.members.linode.com> has quit IRC (*.net *.split)
5282021-03-10T19:42:45 *** dhruvm <dhruvm!~dhruv@165.227.49.220> has quit IRC (*.net *.split)
5292021-03-10T19:42:45 *** justinmoon <justinmoon!~quassel@157.245.122.126> has quit IRC (*.net *.split)
5302021-03-10T19:42:46 *** rockhouse1 is now known as rockhouse
5312021-03-10T19:42:46 *** tlev6 is now known as tlev
5322021-03-10T19:42:46 *** mekster9 is now known as mekster
5332021-03-10T19:43:25 *** Evel-Knievel <Evel-Knievel!~Evel-Knie@d5152f744.static.telenet.be> has joined #bitcoin-core-dev
5342021-03-10T19:43:48 *** GankMove <GankMove!~GankMove@unaffiliated/gankmove> has joined #bitcoin-core-dev
5352021-03-10T19:43:52 *** smctwo <smctwo!~smctwo@86.98.5.100> has joined #bitcoin-core-dev
5362021-03-10T19:45:06 *** nickler <nickler!~nickler@static.219.205.69.159.clients.your-server.de> has joined #bitcoin-core-dev
5372021-03-10T19:45:15 *** jespada <jespada!~jespada@90.254.243.187> has quit IRC (Ping timeout: 246 seconds)
5382021-03-10T19:45:45 *** spinza <spinza!~spin@102.132.245.16> has quit IRC (Read error: Connection reset by peer)
5392021-03-10T19:45:57 *** CubicEarth <CubicEarth!~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net> has quit IRC (Ping timeout: 246 seconds)
5402021-03-10T19:46:23 *** spinza <spinza!~spin@102.132.245.16> has joined #bitcoin-core-dev
5412021-03-10T19:46:51 *** Chris_St1 <Chris_St1!~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383> has quit IRC (Quit: WeeChat 2.8)
5422021-03-10T19:47:06 *** Chris_Stewart_5 <Chris_Stewart_5!~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383> has joined #bitcoin-core-dev
5432021-03-10T19:47:16 *** pinheadmz_ <pinheadmz_!~pinheadmz@hns-contributor.dev> has quit IRC (Quit: ZNC 1.8.2+deb1+bionic2 - https://znc.in)
5442021-03-10T19:48:05 *** jespada <jespada!~jespada@90.254.243.187> has joined #bitcoin-core-dev
5452021-03-10T19:48:23 *** CubicEarth <CubicEarth!~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net> has joined #bitcoin-core-dev
5462021-03-10T19:48:59 *** adiabat_ <adiabat_!~adiabat@63.209.32.102> has joined #bitcoin-core-dev
5472021-03-10T19:49:49 *** shesek <shesek!~shesek@unaffiliated/shesek> has joined #bitcoin-core-dev
5482021-03-10T19:50:18 *** pinheadmz <pinheadmz!~pinheadmz@hns-contributor.dev> has joined #bitcoin-core-dev
5492021-03-10T19:50:21 *** marcoagn1 <marcoagn1!~user@2001:8a0:ffc6:8700:fbe1:d95d:7692:d3c7> has joined #bitcoin-core-dev
5502021-03-10T19:56:28 *** jungly <jungly!~jungly@host-79-55-185-171.retail.telecomitalia.it> has joined #bitcoin-core-dev
5512021-03-10T19:58:43 *** ccdle12 <ccdle12!955adef3@243.222.90.149.rev.vodafone.pt> has quit IRC (Ping timeout: 240 seconds)
5522021-03-10T20:01:50 *** TheRec_ <TheRec_!~toto@drupal.org/user/146860/view> has quit IRC ()
5532021-03-10T20:04:19 *** ctrlbreak_MAD <ctrlbreak_MAD!~ctrlbreak@159.2.165.130> has joined #bitcoin-core-dev
5542021-03-10T20:07:34 *** ctrlbreak <ctrlbreak!~ctrlbreak@159.2.165.130> has quit IRC (Ping timeout: 260 seconds)
5552021-03-10T20:19:28 <wumpus> it's an interesting idea but i'm not really sure using labels for something like counting acks is a good idea, it really goes aside of the idea of labeling
5562021-03-10T20:20:20 <wumpus> there are already so many labels
5572021-03-10T20:21:39 <wumpus> ui-wise it's basically a more limited version of what bitcoinacks is doing but without the names
5582021-03-10T20:23:28 <wumpus> (and no- please don't create acked-by-wumpus acked-by-sipa etc labels xD)
5592021-03-10T20:26:02 <sipa> ACK
5602021-03-10T20:26:05 <sipa> (no such labels)
5612021-03-10T20:38:50 <wumpus> just 'number of acks' is also such an easy metric to game, if you're going to merge it's probably more important to pay attention to the rest
5622021-03-10T20:40:47 *** Jackielove4u <Jackielove4u!uid43977@gateway/web/irccloud.com/x-vulfyaligsvkvsgx> has quit IRC ()
5632021-03-10T20:41:03 *** Jackielove4u <Jackielove4u!uid43977@gateway/web/irccloud.com/x-lbtetyyqbzzbklbc> has joined #bitcoin-core-dev
5642021-03-10T20:50:21 *** jungly <jungly!~jungly@host-79-55-185-171.retail.telecomitalia.it> has quit IRC (Ping timeout: 264 seconds)
5652021-03-10T20:55:26 *** TheRec <TheRec!~toto@drupal.org/user/146860/view> has joined #bitcoin-core-dev
5662021-03-10T21:00:47 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Remote host closed the connection)
5672021-03-10T21:02:06 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
5682021-03-10T21:04:27 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5692021-03-10T21:04:27 <bitcoin-git> [bitcoin] jonatack opened pull request #21410: test: increase rpc_timeout for fundrawtx test_transaction_too_large (master...give-test_transaction_too_large-more-time) https://github.com/bitcoin/bitcoin/pull/21410
5702021-03-10T21:04:28 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5712021-03-10T21:05:29 *** bosma <bosma!sid103570@gateway/web/irccloud.com/x-qkfgcmheeavarutv> has quit IRC ()
5722021-03-10T21:05:45 *** bosma <bosma!sid103570@gateway/web/irccloud.com/x-jlshhtkcwznyecfy> has joined #bitcoin-core-dev
5732021-03-10T21:13:43 *** smctwo_ <smctwo_!~smctwo@86.98.5.100> has joined #bitcoin-core-dev
5742021-03-10T21:14:34 *** roconnor <roconnor!~roconnor@host-45-58-192-182.dyn.295.ca> has joined #bitcoin-core-dev
5752021-03-10T21:17:30 *** smctwo <smctwo!~smctwo@86.98.5.100> has quit IRC (Ping timeout: 272 seconds)
5762021-03-10T21:18:00 *** smctwo_ <smctwo_!~smctwo@86.98.5.100> has quit IRC (Ping timeout: 246 seconds)
5772021-03-10T21:18:12 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
5782021-03-10T21:19:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5792021-03-10T21:19:23 <bitcoin-git> [bitcoin] jonatack opened pull request #21411: test: add logging, reduce blocks generated in wallet groups test (master...wallet_groups-test) https://github.com/bitcoin/bitcoin/pull/21411
5802021-03-10T21:19:23 *** very_sneaky <very_sneaky!~very_snea@45.67.96.24> has joined #bitcoin-core-dev
5812021-03-10T21:19:24 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5822021-03-10T21:23:52 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
5832021-03-10T21:25:03 *** eragmus <eragmus!sid136308@gateway/web/irccloud.com/x-uddttftymtbhneef> has quit IRC ()
5842021-03-10T21:25:20 *** eragmus <eragmus!sid136308@gateway/web/irccloud.com/x-gtdiviqjvshbjmlo> has joined #bitcoin-core-dev
5852021-03-10T21:31:19 *** jonatack_ <jonatack_!~jon@37.171.231.252> has joined #bitcoin-core-dev
5862021-03-10T21:34:00 *** jonatack_ <jonatack_!~jon@37.171.231.252> has quit IRC (Client Quit)
5872021-03-10T21:34:20 *** jonatack_ <jonatack_!~jon@37.171.231.252> has joined #bitcoin-core-dev
5882021-03-10T21:35:21 *** jonatack <jonatack!~jon@37.173.131.107> has quit IRC (Ping timeout: 264 seconds)
5892021-03-10T21:51:43 *** nathanael <nathanael!~nathanael@unaffiliated/nathanael> has quit IRC (Quit: nathanael)
5902021-03-10T21:53:49 *** jonatack_ <jonatack_!~jon@37.171.231.252> has quit IRC (Quit: jonatack_)
5912021-03-10T21:54:11 *** jonatack <jonatack!~jon@37.171.231.252> has joined #bitcoin-core-dev
5922021-03-10T21:56:45 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
5932021-03-10T21:58:39 *** GankMove <GankMove!~GankMove@unaffiliated/gankmove> has quit IRC (Quit: GankMove)
5942021-03-10T22:04:51 <fanquake> I agree with wumpus, not sure about the value of ân ACKsâ labels.
5952021-03-10T22:05:44 <fanquake> Also, please donât have drahtbot start adding and removing ACK labels because some spam/unknown accounts drive by and drop ACKs on things. Thatâs just more noise.
5962021-03-10T22:07:17 <fanquake> I think jeremyrubin idea of having some sort of last updated time in the conflict comment is a good one.
5972021-03-10T22:13:00 *** scedastik <scedastik!~scedastik@c-68-58-168-96.hsd1.mi.comcast.net> has quit IRC (Quit: scedastik)
5982021-03-10T22:16:21 *** brg444 <brg444!uid207215@gateway/web/irccloud.com/x-nimakvacfthwvsmg> has quit IRC ()
5992021-03-10T22:16:37 *** brg444 <brg444!sid207215@gateway/web/irccloud.com/x-xnuuimdvztgcwauq> has joined #bitcoin-core-dev
6002021-03-10T22:32:21 *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
6012021-03-10T22:42:02 *** roconnor <roconnor!~roconnor@host-45-58-192-182.dyn.295.ca> has quit IRC (Ping timeout: 264 seconds)
6022021-03-10T22:42:54 *** jungly <jungly!~jungly@host-79-55-185-171.retail.telecomitalia.it> has joined #bitcoin-core-dev
6032021-03-10T22:49:12 *** nathanael <nathanael!~nathanael@unaffiliated/nathanael> has joined #bitcoin-core-dev
6042021-03-10T22:57:33 *** jungly <jungly!~jungly@host-79-55-185-171.retail.telecomitalia.it> has quit IRC (Ping timeout: 245 seconds)
6052021-03-10T23:02:14 <phantomcircuit> wumpus, thoughts on removing zmq? afaict 100% of the users of it are using it in a way that is either dangerous or requires low interval polling anyways
6062021-03-10T23:04:10 *** Nebraskka <Nebraskka!~Nebraskka@51.83.249.56> has quit IRC (Remote host closed the connection)
6072021-03-10T23:04:13 *** queip <queip!~queip@unaffiliated/rezurus> has quit IRC (Remote host closed the connection)
6082021-03-10T23:05:05 *** Nebraskka <Nebraskka!~Nebraskka@51.83.249.56> has joined #bitcoin-core-dev
6092021-03-10T23:06:10 *** queip <queip!~queip@unaffiliated/rezurus> has joined #bitcoin-core-dev
6102021-03-10T23:09:49 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
6112021-03-10T23:10:27 *** valwal_ <valwal_!sid334773@gateway/web/irccloud.com/x-ulxywzaegjotuyuq> has quit IRC ()
6122021-03-10T23:10:47 *** valwal_ <valwal_!sid334773@gateway/web/irccloud.com/x-afzpjvgfuispbzys> has joined #bitcoin-core-dev
6132021-03-10T23:17:38 *** roconnor <roconnor!~roconnor@host-45-58-192-182.dyn.295.ca> has joined #bitcoin-core-dev
6142021-03-10T23:31:42 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6152021-03-10T23:31:42 <bitcoin-git> [bitcoin] glozow opened pull request #21413: [rfc] add option to bypass contextual timelocks in testmempoolaccept? (master...2021-03-bypass-timelocks) https://github.com/bitcoin/bitcoin/pull/21413
6162021-03-10T23:31:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6172021-03-10T23:40:04 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 245 seconds)
6182021-03-10T23:44:57 *** EagleTM <EagleTM!~EagleTM@unaffiliated/eagletm> has quit IRC (Ping timeout: 264 seconds)
6192021-03-10T23:48:27 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev