12021-04-07T00:09:11 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
22021-04-07T00:29:56 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
32021-04-07T00:30:44 *** jungly_ <jungly_!~jungly@host-95-248-128-75.retail.telecomitalia.it> has joined #bitcoin-core-dev
42021-04-07T00:33:21 *** luke-jr <luke-jr!~luke-jr@unaffiliated/luke-jr> has joined #bitcoin-core-dev
52021-04-07T00:33:41 *** jungly <jungly!~jungly@host-79-35-197-175.retail.telecomitalia.it> has quit IRC (Ping timeout: 240 seconds)
62021-04-07T00:39:35 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 260 seconds)
72021-04-07T00:46:04 *** ogo <ogo!~ogo@gateway/tor-sasl/ogo> has quit IRC (Remote host closed the connection)
82021-04-07T01:05:08 *** meinwolf <meinwolf!~meinwolf@unaffiliated/meinwolf> has quit IRC (Quit: meinwolf)
92021-04-07T01:09:32 *** Thomaz <Thomaz!62e57e13@c-98-229-126-19.hsd1.ma.comcast.net> has joined #bitcoin-core-dev
102021-04-07T01:12:13 *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
112021-04-07T01:12:31 *** Thomaz <Thomaz!62e57e13@c-98-229-126-19.hsd1.ma.comcast.net> has quit IRC (Client Quit)
122021-04-07T01:16:42 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 268 seconds)
132021-04-07T01:16:55 *** shaunapps <shaunapps!shaunsun@gateway/vpn/privateinternetaccess/shaunsun> has quit IRC (Ping timeout: 260 seconds)
142021-04-07T01:19:52 *** meinwolf <meinwolf!~meinwolf@unaffiliated/meinwolf> has joined #bitcoin-core-dev
152021-04-07T01:24:22 *** mkarrer <mkarrer!~mkarrer@170.247.155.66> has joined #bitcoin-core-dev
162021-04-07T01:26:23 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
172021-04-07T01:29:11 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 240 seconds)
182021-04-07T01:53:10 *** willl <willl!8a7642d4@138-118-66-212.virtualinformatica.inf.br> has joined #bitcoin-core-dev
192021-04-07T01:53:40 *** willl <willl!8a7642d4@138-118-66-212.virtualinformatica.inf.br> has quit IRC (Client Quit)
202021-04-07T02:11:00 *** stortz <stortz!bb3fbd57@unaffiliated/stortz> has joined #bitcoin-core-dev
212021-04-07T02:21:16 *** mkarrer <mkarrer!~mkarrer@170.247.155.66> has quit IRC ()
222021-04-07T02:26:41 <jamesob> wumpus: whenever is convenient, would you mind swapping my high-prio PR for #21523? I think it should be a pretty uncontroversial change
232021-04-07T02:26:42 <gribble> https://github.com/bitcoin/bitcoin/issues/21523 | validation: run VerifyDB on all chainstates by jamesob · Pull Request #21523 · bitcoin/bitcoin · GitHub
242021-04-07T02:27:25 <fanquake> jamesob: have done
252021-04-07T02:27:36 <jamesob> fanquake: tyty
262021-04-07T02:34:41 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
272021-04-07T02:34:54 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
282021-04-07T02:36:42 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
292021-04-07T02:38:31 *** dermoth_ <dermoth_!~dermoth@unaffiliated/dermoth> has joined #bitcoin-core-dev
302021-04-07T02:38:47 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
312021-04-07T02:39:48 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
322021-04-07T02:41:36 *** dermoth <dermoth!~dermoth@unaffiliated/dermoth> has quit IRC (Ping timeout: 260 seconds)
332021-04-07T03:09:28 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 265 seconds)
342021-04-07T03:22:07 *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
352021-04-07T03:24:41 *** belcher <belcher!~belcher@unaffiliated/belcher> has quit IRC (Ping timeout: 252 seconds)
362021-04-07T03:32:07 *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has quit IRC (Remote host closed the connection)
372021-04-07T03:35:21 *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
382021-04-07T03:48:51 *** stortz <stortz!bb3fbd57@unaffiliated/stortz> has quit IRC (Quit: Connection closed)
392021-04-07T04:07:30 *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has quit IRC (Remote host closed the connection)
402021-04-07T04:07:51 *** ghost43 <ghost43!~daer@gateway/tor-sasl/daer> has joined #bitcoin-core-dev
412021-04-07T04:09:54 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
422021-04-07T04:24:44 *** justanotheruser <justanotheruser!justanothe@gateway/vpn/protonvpn/justanotheruser> has joined #bitcoin-core-dev
432021-04-07T04:27:05 *** Eprom <Eprom!~Eprom@185.169.233.10> has quit IRC (Remote host closed the connection)
442021-04-07T04:43:09 *** dougvann <dougvann!~dougvann@217.146.82.202> has joined #bitcoin-core-dev
452021-04-07T04:48:27 *** bitcoin-git <bitcoin-git!~bitcoin-g@51.15.8.174> has joined #bitcoin-core-dev
462021-04-07T04:48:28 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/9be7fe484931...245a5cd5604a
472021-04-07T04:48:29 <bitcoin-git> bitcoin/master 6965456 Andrew Chow: Introduce DeferringSignatureChecker and inherit with SignatureExtractor
482021-04-07T04:48:29 <bitcoin-git> bitcoin/master a97a929 Andrew Chow: Test that signrawtx works when a signed CSV and CLTV inputs are present
492021-04-07T04:48:30 <bitcoin-git> bitcoin/master 245a5cd fanquake: Merge #21166: Introduce DeferredSignatureChecker and have SignatureExtract...
502021-04-07T04:48:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@51.15.8.174> has left #bitcoin-core-dev
512021-04-07T04:48:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
522021-04-07T04:48:48 <bitcoin-git> [bitcoin] fanquake merged pull request #21166: Introduce DeferredSignatureChecker and have SignatureExtractorClass subclass it (master...fix-sig-extractor-checker) https://github.com/bitcoin/bitcoin/pull/21166
532021-04-07T04:48:48 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
542021-04-07T04:51:10 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (Ping timeout: 260 seconds)
552021-04-07T04:54:20 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
562021-04-07T04:55:09 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (Remote host closed the connection)
572021-04-07T05:04:26 *** smartineng <smartineng!~Icedove@88.135.18.171> has joined #bitcoin-core-dev
582021-04-07T05:06:41 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
592021-04-07T05:10:22 *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
602021-04-07T05:14:26 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 260 seconds)
612021-04-07T05:22:48 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
622021-04-07T05:25:01 <fanquake> Am I misremembering or did someone recently report seeing terrible performance with sqlite based wallets?
632021-04-07T05:26:51 <sipa> i think phantomcircuit was complaining about that a while ago
642021-04-07T05:27:47 <fanquake> I'm currently seeing a 100x performance difference in the wallet tests
652021-04-07T05:28:31 <fanquake> 202536866us to run CreateWallet with sqlite vs 2037701us with bdb.
662021-04-07T05:29:52 <sipa> that's no good
672021-04-07T05:33:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
682021-04-07T05:33:57 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #21616: [0.21] build: link against -lsocket if required for *ifaddrs (0.21...backport_21486) https://github.com/bitcoin/bitcoin/pull/21616
692021-04-07T05:33:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
702021-04-07T05:34:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
712021-04-07T05:34:47 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/245a5cd5604a...41a8d2b96ff5
722021-04-07T05:34:48 <bitcoin-git> bitcoin/master fa8fffe MarcoFalke: refactor: Prefer clean assert over UB in coinstats
732021-04-07T05:34:48 <bitcoin-git> bitcoin/master fa9b74f MarcoFalke: Fix assumeutxo crash due to missing base_blockhash
742021-04-07T05:34:49 <bitcoin-git> bitcoin/master 41a8d2b MarcoFalke: Merge #21582: Fix assumeutxo crash due to missing base_blockhash
752021-04-07T05:34:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
762021-04-07T05:35:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
772021-04-07T05:35:07 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #21582: Fix assumeutxo crash due to missing base_blockhash (master...2104-assumeutxoCrash01) https://github.com/bitcoin/bitcoin/pull/21582
782021-04-07T05:35:18 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
792021-04-07T05:40:07 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 260 seconds)
802021-04-07T05:46:23 *** Emcy_ <Emcy_!~Emcy@unaffiliated/emcy> has joined #bitcoin-core-dev
812021-04-07T05:47:07 *** Emcy <Emcy!~Emcy@unaffiliated/emcy> has quit IRC (Ping timeout: 260 seconds)
822021-04-07T06:01:48 <fanquake> Thought it might be some dumb macOS thing, but looks like it's happening on Linux too, althought not as bad. Only 27x difference
832021-04-07T06:18:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
842021-04-07T06:18:19 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/41a8d2b96ff5...c0160ea52ea8
852021-04-07T06:18:20 <bitcoin-git> bitcoin/master 9a36709 Sebastian Falbesoner: wallet: refactor: dedup sqlite statement preparations
862021-04-07T06:18:20 <bitcoin-git> bitcoin/master ea19cc8 Sebastian Falbesoner: wallet: refactor: dedup sqlite statement deletions
872021-04-07T06:18:21 <bitcoin-git> bitcoin/master c0160ea fanquake: Merge #21540: wallet: refactor: dedup sqlite statement preparations/deleti...
882021-04-07T06:18:22 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
892021-04-07T06:18:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
902021-04-07T06:18:39 <bitcoin-git> [bitcoin] fanquake merged pull request #21540: wallet: refactor: dedup sqlite statement preparations/deletions (master...2021-wallet-dedup_setupsqlstatements) https://github.com/bitcoin/bitcoin/pull/21540
912021-04-07T06:18:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
922021-04-07T06:57:54 *** p0x <p0x!~pox@gateway/tor-sasl/pox> has quit IRC (Quit: p0x)
932021-04-07T06:58:39 *** pox <pox!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
942021-04-07T07:02:13 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 246 seconds)
952021-04-07T07:07:46 *** kiltzman <kiltzman!~k1ltzman@195.189.99.96> has quit IRC (Ping timeout: 240 seconds)
962021-04-07T07:08:04 *** kiltzman <kiltzman!~k1ltzman@195.189.99.96> has joined #bitcoin-core-dev
972021-04-07T07:13:14 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
982021-04-07T07:13:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
992021-04-07T07:13:29 <bitcoin-git> [gui] hebasto opened pull request #274: [PoC] [do not merge]: Support runtime appearance adjustment on macOS (master...210407-dark-poc) https://github.com/bitcoin-core/gui/pull/274
1002021-04-07T07:13:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1012021-04-07T07:29:55 *** rny <rny!~rny@gateway/tor-sasl/renlord> has quit IRC (Remote host closed the connection)
1022021-04-07T07:31:41 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
1032021-04-07T07:31:57 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
1042021-04-07T07:32:02 *** rny <rny!~rny@gateway/tor-sasl/renlord> has joined #bitcoin-core-dev
1052021-04-07T07:37:25 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1062021-04-07T07:40:37 *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 265 seconds)
1072021-04-07T08:05:19 *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f1b88003757d419354f4ff2.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
1082021-04-07T08:08:21 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
1092021-04-07T08:09:35 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 252 seconds)
1102021-04-07T08:13:09 *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
1112021-04-07T08:13:35 *** shesek <shesek!~shesek@unaffiliated/shesek> has joined #bitcoin-core-dev
1122021-04-07T08:19:45 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
1132021-04-07T08:29:58 *** Zenton <Zenton!~user@unaffiliated/vicenteh> has quit IRC (Read error: Connection reset by peer)
1142021-04-07T08:30:18 *** Zenton <Zenton!~user@unaffiliated/vicenteh> has joined #bitcoin-core-dev
1152021-04-07T08:37:29 *** vv8 <vv8!~egp_@128-71-69-136.broadband.corbina.ru> has quit IRC (Remote host closed the connection)
1162021-04-07T08:41:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1172021-04-07T08:41:12 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c0160ea52ea8...6154291cf9ab
1182021-04-07T08:41:13 <bitcoin-git> bitcoin/master 3333375 MarcoFalke: fuzz: Fix uninitialized read in test
1192021-04-07T08:41:13 <bitcoin-git> bitcoin/master 6154291 MarcoFalke: Merge #21617: fuzz: Fix uninitialized read in i2p test
1202021-04-07T08:41:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1212021-04-07T08:41:32 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1222021-04-07T08:41:32 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #21617: fuzz: Fix uninitialized read in i2p test (master...2104-fuzzValgrind) https://github.com/bitcoin/bitcoin/pull/21617
1232021-04-07T08:41:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1242021-04-07T08:43:05 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1252021-04-07T08:48:07 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1262021-04-07T08:48:08 <bitcoin-git> [bitcoin] fanquake opened pull request #21629: build: fix configuring when building depends with NO_BDB=1 (master...fixup_depends_sqlite_only_build) https://github.com/bitcoin/bitcoin/pull/21629
1272021-04-07T08:48:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1282021-04-07T08:50:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1292021-04-07T08:50:28 <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/6154291cf9ab...2b3e5bf4c0dc
1302021-04-07T08:50:28 <bitcoin-git> bitcoin/master c6edcf1 fanquake: build: suppress libevent warnings if supressing external warnings
1312021-04-07T08:50:28 *** robert_spigler <robert_spigler!robertspig@gateway/shell/matrix.org/x-woodfzmugqmuzqvh> has quit IRC (Ping timeout: 248 seconds)
1322021-04-07T08:50:28 *** elichai2 <elichai2!sid212594@gateway/web/irccloud.com/x-jfgygubnaewcijny> has quit IRC (Ping timeout: 248 seconds)
1332021-04-07T08:50:28 <bitcoin-git> bitcoin/master 3b0078f fanquake: doc: fixup -Wdocumentation issues
1342021-04-07T08:50:28 <bitcoin-git> bitcoin/master a4e970a fanquake: build: enable -Wdocumentation if suppressing external warnings
1352021-04-07T08:50:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1362021-04-07T08:50:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1372021-04-07T08:50:47 <bitcoin-git> [bitcoin] fanquake merged pull request #21613: build: enable -Wdocumentation (master...enable_wdocumentation) https://github.com/bitcoin/bitcoin/pull/21613
1382021-04-07T08:50:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1392021-04-07T08:50:51 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
1402021-04-07T08:51:28 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
1412021-04-07T08:51:32 *** dkrm <dkrm!~dkrm@2001:41d0:8:3f7b::1> has quit IRC (Ping timeout: 248 seconds)
1422021-04-07T08:51:32 *** arik__ <arik__!sid402902@gateway/web/irccloud.com/x-bekvcgslnzojdxtd> has quit IRC (Ping timeout: 248 seconds)
1432021-04-07T08:51:32 *** rocket_fuel_ <rocket_fuel_!sid2662@gateway/web/irccloud.com/x-gbafcogwenhlmykz> has quit IRC (Ping timeout: 248 seconds)
1442021-04-07T08:52:47 *** elichai2 <elichai2!sid212594@gateway/web/irccloud.com/x-ezuxkekmentqtzba> has joined #bitcoin-core-dev
1452021-04-07T08:53:45 *** dkrm <dkrm!~dkrm@2001:41d0:8:3f7b::1> has joined #bitcoin-core-dev
1462021-04-07T08:54:22 *** rocket_fuel_ <rocket_fuel_!sid2662@gateway/web/irccloud.com/x-wxchqqfzdgrxfazm> has joined #bitcoin-core-dev
1472021-04-07T08:54:41 *** arik__ <arik__!sid402902@gateway/web/irccloud.com/x-zooiexohjqornpgx> has joined #bitcoin-core-dev
1482021-04-07T08:54:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1492021-04-07T08:54:55 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2b3e5bf4c0dc...aa69471ecd55
1502021-04-07T08:54:55 <bitcoin-git> bitcoin/master 937fd4a Russell Yanofsky: Fix wrong wallet RPC context set after #21366
1512021-04-07T08:54:56 <bitcoin-git> bitcoin/master aa69471 MarcoFalke: Merge #21572: Fix wrong wallet RPC context set after #21366
1522021-04-07T08:54:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1532021-04-07T08:55:14 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1542021-04-07T08:55:14 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #21572: Fix wrong wallet RPC context set after #21366 (master...pr/fixref) https://github.com/bitcoin/bitcoin/pull/21572
1552021-04-07T08:55:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1562021-04-07T09:00:28 *** promag <promag!~promag@188.250.84.129> has quit IRC (Read error: Connection reset by peer)
1572021-04-07T09:00:35 *** promag_ <promag_!~promag@188.250.84.129> has joined #bitcoin-core-dev
1582021-04-07T09:00:43 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1592021-04-07T09:05:25 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 246 seconds)
1602021-04-07T09:11:57 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
1612021-04-07T09:12:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1622021-04-07T09:12:34 <bitcoin-git> [bitcoin] vasild opened pull request #21630: fuzz: split FuzzedSock interface and implementation (master...FuzzedSock_move) https://github.com/bitcoin/bitcoin/pull/21630
1632021-04-07T09:12:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1642021-04-07T09:20:24 *** promag <promag!~promag@188.251.225.32> has joined #bitcoin-core-dev
1652021-04-07T09:29:35 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
1662021-04-07T09:37:09 *** midnight <midnight!~midnight@unaffiliated/midnightmagic> has quit IRC (Ping timeout: 252 seconds)
1672021-04-07T09:40:20 *** midnight <midnight!~midnight@unaffiliated/midnightmagic> has joined #bitcoin-core-dev
1682021-04-07T09:42:11 *** robert_spigler <robert_spigler!robertspig@gateway/shell/matrix.org/x-fdusfcurhpiuyhtr> has joined #bitcoin-core-dev
1692021-04-07T09:45:50 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1702021-04-07T09:54:26 *** qubenix <qubenix!~qubenix@66.172.11.228> has quit IRC (Quit: quit)
1712021-04-07T09:59:51 *** qubenix <qubenix!~qubenix@66.172.11.228> has joined #bitcoin-core-dev
1722021-04-07T10:03:58 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 240 seconds)
1732021-04-07T10:20:45 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
1742021-04-07T10:28:47 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
1752021-04-07T10:29:44 *** pox <pox!~pox@gateway/tor-sasl/pox> has quit IRC (Quit: pox)
1762021-04-07T10:32:02 *** pox <pox!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
1772021-04-07T10:56:09 *** ogo <ogo!~ogo@gateway/tor-sasl/ogo> has joined #bitcoin-core-dev
1782021-04-07T10:57:46 *** jake <jake!97b15dd9@c151-177-93-217.bredband.comhem.se> has joined #bitcoin-core-dev
1792021-04-07T11:06:31 *** rny <rny!~rny@gateway/tor-sasl/renlord> has quit IRC (Remote host closed the connection)
1802021-04-07T11:17:46 *** vv8 <vv8!~egp_@128-71-69-136.broadband.corbina.ru> has joined #bitcoin-core-dev
1812021-04-07T11:19:02 *** shaunapps <shaunapps!shaunsun@gateway/vpn/privateinternetaccess/shaunsun> has joined #bitcoin-core-dev
1822021-04-07T11:34:03 *** shaunapps <shaunapps!shaunsun@gateway/vpn/privateinternetaccess/shaunsun> has quit IRC (Quit: Leaving)
1832021-04-07T11:38:03 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 260 seconds)
1842021-04-07T11:38:13 *** promag <promag!~promag@188.251.225.32> has quit IRC (Remote host closed the connection)
1852021-04-07T11:40:34 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
1862021-04-07T11:44:35 *** belcher_ is now known as belcher
1872021-04-07T11:49:21 *** owowo <owowo!~ovovo@unaffiliated/ovovo> has joined #bitcoin-core-dev
1882021-04-07T12:01:29 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
1892021-04-07T12:01:33 *** pox <pox!~pox@gateway/tor-sasl/pox> has quit IRC (Ping timeout: 240 seconds)
1902021-04-07T12:07:56 *** promag_ <promag_!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
1912021-04-07T12:08:12 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
1922021-04-07T12:10:35 *** jake <jake!97b15dd9@c151-177-93-217.bredband.comhem.se> has quit IRC (Quit: Connection closed)
1932021-04-07T12:17:49 *** pox <pox!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
1942021-04-07T12:19:28 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1952021-04-07T12:19:28 <bitcoin-git> [bitcoin] vasild opened pull request #21631: i2p: always check the return value of Sock::Wait() (master...SockWait_usage_fix) https://github.com/bitcoin/bitcoin/pull/21631
1962021-04-07T12:19:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1972021-04-07T12:23:23 *** rny <rny!~rny@gateway/tor-sasl/renlord> has joined #bitcoin-core-dev
1982021-04-07T12:34:00 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 265 seconds)
1992021-04-07T12:40:27 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
2002021-04-07T12:54:11 *** biteskola <biteskola!~biteskola@170.76.76.188.dynamic.jazztel.es> has joined #bitcoin-core-dev
2012021-04-07T12:56:21 *** eoin <eoin!33253cfd@51.37.60.253> has joined #bitcoin-core-dev
2022021-04-07T13:04:01 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
2032021-04-07T13:04:34 *** Pablo1981 <Pablo1981!~Pablo1981@156.146.62.55> has joined #bitcoin-core-dev
2042021-04-07T13:04:59 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
2052021-04-07T13:13:17 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
2062021-04-07T13:13:33 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
2072021-04-07T13:18:06 *** promag_ <promag_!~promag@188.250.84.129> has joined #bitcoin-core-dev
2082021-04-07T13:22:23 *** eoin <eoin!33253cfd@51.37.60.253> has quit IRC (Quit: Connection closed)
2092021-04-07T13:23:45 *** promag_ <promag_!~promag@188.250.84.129> has quit IRC (Ping timeout: 268 seconds)
2102021-04-07T13:30:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2112021-04-07T13:30:12 <bitcoin-git> [bitcoin] luke-jr reopened pull request #19573: Replace unused BIP 9 logic with draft BIP 8 (master...bip8) https://github.com/bitcoin/bitcoin/pull/19573
2122021-04-07T13:30:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2132021-04-07T13:30:27 *** dougvann <dougvann!~dougvann@217.146.82.202> has quit IRC (Remote host closed the connection)
2142021-04-07T13:36:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2152021-04-07T13:36:57 <bitcoin-git> [bitcoin] fanquake opened pull request #21633: refactor: add [[noreturn]] attribute where applicable (master...build_with_noreturn) https://github.com/bitcoin/bitcoin/pull/21633
2162021-04-07T13:36:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2172021-04-07T13:40:11 *** Pablo1981 <Pablo1981!~Pablo1981@156.146.62.55> has quit IRC (Ping timeout: 260 seconds)
2182021-04-07T13:47:47 *** de6df1re <de6df1re!~igloo@h184-60-25-110.mdtnwixa.dsl.dynamic.tds.net> has joined #bitcoin-core-dev
2192021-04-07T13:53:08 *** de6df1re <de6df1re!~igloo@h184-60-25-110.mdtnwixa.dsl.dynamic.tds.net> has quit IRC (Read error: No route to host)
2202021-04-07T13:54:10 *** guilhermeblanco <guilhermeblanco!~guilherme@185.204.1.185> has joined #bitcoin-core-dev
2212021-04-07T13:55:22 *** de6df1re <de6df1re!~igloo@h184-60-25-110.mdtnwixa.dsl.dynamic.tds.net> has joined #bitcoin-core-dev
2222021-04-07T13:56:53 *** de6df1re <de6df1re!~igloo@h184-60-25-110.mdtnwixa.dsl.dynamic.tds.net> has quit IRC (Client Quit)
2232021-04-07T14:11:29 *** biteskola <biteskola!~biteskola@170.76.76.188.dynamic.jazztel.es> has quit IRC (Ping timeout: 252 seconds)
2242021-04-07T14:11:30 *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has quit IRC (Remote host closed the connection)
2252021-04-07T14:16:43 *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has joined #bitcoin-core-dev
2262021-04-07T14:16:56 *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has quit IRC (Ping timeout: 246 seconds)
2272021-04-07T14:17:22 *** jeremyrubin <jeremyrubin!~jr@024-176-247-182.res.spectrum.com> has joined #bitcoin-core-dev
2282021-04-07T14:25:56 *** pergaminho <pergaminho!~Cleber@189.26.121.248> has joined #bitcoin-core-dev
2292021-04-07T14:31:09 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
2302021-04-07T14:37:53 *** mol <mol!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
2312021-04-07T14:41:43 *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f1b88003757d419354f4ff2.dip0.t-ipconnect.de> has quit IRC (Ping timeout: 258 seconds)
2322021-04-07T14:42:00 *** molz_ <molz_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
2332021-04-07T14:42:04 *** mol_ <mol_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 268 seconds)
2342021-04-07T14:45:11 *** mol <mol!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 260 seconds)
2352021-04-07T14:53:30 *** Aaronvan_ <Aaronvan_!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev
2362021-04-07T14:56:51 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Ping timeout: 260 seconds)
2372021-04-07T14:57:32 *** Aaronvan_ is now known as AaronvanW
2382021-04-07T14:59:50 *** promag_ <promag_!~promag@188.250.84.129> has joined #bitcoin-core-dev
2392021-04-07T15:04:52 *** promag_ <promag_!~promag@188.250.84.129> has quit IRC (Ping timeout: 268 seconds)
2402021-04-07T15:13:57 *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has quit IRC (Ping timeout: 240 seconds)
2412021-04-07T15:13:58 *** proofofkeags <proofofkeags!~proofofke@97-118-239-55.hlrn.qwest.net> has quit IRC (Ping timeout: 240 seconds)
2422021-04-07T15:14:01 *** sipa_ <sipa_!~pw@gateway/tor-sasl/sipa1024> has joined #bitcoin-core-dev
2432021-04-07T15:21:10 *** endogenic <endogenic!sid145991@gateway/web/irccloud.com/x-wqvwosqhcwtlffts> has quit IRC (Ping timeout: 260 seconds)
2442021-04-07T15:22:03 *** fjahr <fjahr!sid374480@gateway/web/irccloud.com/x-ilpsykelulslvhrl> has quit IRC (Ping timeout: 260 seconds)
2452021-04-07T15:22:31 *** digi_james <digi_james!sid281632@gateway/web/irccloud.com/x-qyguvkvdfjgkmxpb> has quit IRC (Ping timeout: 260 seconds)
2462021-04-07T15:23:44 *** dunk <dunk!sid16@gateway/web/irccloud.com/x-yncoxniiqqzmrfol> has quit IRC (Read error: Connection reset by peer)
2472021-04-07T15:24:07 *** mmitech___ <mmitech___!sid446259@gateway/web/irccloud.com/x-yimsbtjvmjtkgxju> has quit IRC (Ping timeout: 246 seconds)
2482021-04-07T15:24:42 *** fjahr <fjahr!sid374480@gateway/web/irccloud.com/x-bvvkqfeiyvkgcmqm> has joined #bitcoin-core-dev
2492021-04-07T15:24:47 *** dunk <dunk!sid16@gateway/web/irccloud.com/x-uormkwsivnlskjak> has joined #bitcoin-core-dev
2502021-04-07T15:24:50 *** endogenic <endogenic!sid145991@gateway/web/irccloud.com/x-dekakcbszucbyikq> has joined #bitcoin-core-dev
2512021-04-07T15:24:59 *** digi_james <digi_james!sid281632@gateway/web/irccloud.com/x-gjrjamphazsicukr> has joined #bitcoin-core-dev
2522021-04-07T15:25:18 *** mmitech___ <mmitech___!sid446259@gateway/web/irccloud.com/x-hnsnvhnchaiyacsp> has joined #bitcoin-core-dev
2532021-04-07T15:27:01 <wumpus> fanquake: that sounds bad, i wonder what costs so much time, it's not like we're using any of sqlite's advanced features
2542021-04-07T15:35:46 <jeremyrubin> is this about fuzzing timeouts?
2552021-04-07T15:40:20 *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f16910067045a99545b2c4f.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
2562021-04-07T15:48:00 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
2572021-04-07T15:48:58 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
2582021-04-07T15:50:00 *** proofofkeags <proofofkeags!~proofofke@205.209.24.233> has joined #bitcoin-core-dev
2592021-04-07T16:07:20 *** asdlkfjwerpoicvx <asdlkfjwerpoicvx!~flack@p200300d46f16910067045a99545b2c4f.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
2602021-04-07T16:19:59 *** joerodgers <joerodgers!~joerodger@c-76-125-83-191.hsd1.ar.comcast.net> has joined #bitcoin-core-dev
2612021-04-07T16:22:36 *** lightlike <lightlike!~lightlike@p200300c7ef15af00f19cdf24a57643ec.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
2622021-04-07T16:26:46 *** Thomaz <Thomaz!62e57e13@c-98-229-126-19.hsd1.ma.comcast.net> has joined #bitcoin-core-dev
2632021-04-07T16:27:48 *** luiz_thomaz <luiz_thomaz!~luiz_thom@2601:18f:680:b040:5178:3ca1:6e53:69f0> has joined #bitcoin-core-dev
2642021-04-07T16:28:48 *** luiz_thomaz <luiz_thomaz!~luiz_thom@2601:18f:680:b040:5178:3ca1:6e53:69f0> has quit IRC (Client Quit)
2652021-04-07T16:31:15 *** cec47 <cec47!aedb819a@154.sub-174-219-129.myvzw.com> has joined #bitcoin-core-dev
2662021-04-07T16:33:02 *** justanotheruser <justanotheruser!justanothe@gateway/vpn/protonvpn/justanotheruser> has quit IRC (Ping timeout: 260 seconds)
2672021-04-07T16:36:59 *** shaunapps <shaunapps!shaunsun@gateway/vpn/privateinternetaccess/shaunsun> has joined #bitcoin-core-dev
2682021-04-07T16:40:31 *** pergaminho <pergaminho!~Cleber@189.26.121.248> has quit IRC (Quit: Saindo)
2692021-04-07T16:45:04 *** proofofkeags_ <proofofkeags_!~proofofke@205.209.28.54> has joined #bitcoin-core-dev
2702021-04-07T16:47:11 *** proofofkeags <proofofkeags!~proofofke@205.209.24.233> has quit IRC (Ping timeout: 240 seconds)
2712021-04-07T16:53:42 *** ccdle12 <ccdle12!955adef3@243.222.90.149.rev.vodafone.pt> has joined #bitcoin-core-dev
2722021-04-07T16:56:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2732021-04-07T16:56:47 <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/aa69471ecd55...cb79cabdd9d9
2742021-04-07T16:56:48 <bitcoin-git> bitcoin/master 3bb6e7b Jon Atack: rpc: add network field to rpc getnodeaddresses
2752021-04-07T16:56:48 <bitcoin-git> bitcoin/master 1b91898 Jon Atack: rpc: simplify/constify getnodeaddresses code
2762021-04-07T16:56:49 <bitcoin-git> bitcoin/master 5c44678 Jon Atack: rpc: improve getnodeaddresses help
2772021-04-07T16:56:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2782021-04-07T16:57:07 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2792021-04-07T16:57:07 <bitcoin-git> [bitcoin] laanwj merged pull request #21594: rpc: add network field to getnodeaddresses (master...getnodeaddresses-network) https://github.com/bitcoin/bitcoin/pull/21594
2802021-04-07T16:57:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2812021-04-07T16:59:10 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
2822021-04-07T17:00:29 *** rr1618 <rr1618!4972c670@c-73-114-198-112.hsd1.ma.comcast.net> has joined #bitcoin-core-dev
2832021-04-07T17:01:21 *** rr1618 <rr1618!4972c670@c-73-114-198-112.hsd1.ma.comcast.net> has quit IRC (Quit: Connection closed)
2842021-04-07T17:01:38 *** rr1618 <rr1618!4972c670@c-73-114-198-112.hsd1.ma.comcast.net> has joined #bitcoin-core-dev
2852021-04-07T17:05:53 *** justanotheruser <justanotheruser!justanothe@gateway/vpn/protonvpn/justanotheruser> has joined #bitcoin-core-dev
2862021-04-07T17:09:41 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
2872021-04-07T17:09:57 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
2882021-04-07T17:14:42 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
2892021-04-07T17:15:27 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
2902021-04-07T17:18:44 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
2912021-04-07T17:18:56 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
2922021-04-07T17:20:28 *** larryruane_ <larryruane_!uid473749@gateway/web/irccloud.com/x-owttibdjsvfioccp> has joined #bitcoin-core-dev
2932021-04-07T17:22:09 *** Evel-Knievel <Evel-Knievel!~Evel-Knie@d5152f744.static.telenet.be> has quit IRC ()
2942021-04-07T17:26:41 *** Evel-Knievel <Evel-Knievel!~Evel-Knie@d5152f744.static.telenet.be> has joined #bitcoin-core-dev
2952021-04-07T17:32:33 *** Thomaz <Thomaz!62e57e13@c-98-229-126-19.hsd1.ma.comcast.net> has quit IRC (Quit: Connection closed)
2962021-04-07T17:32:55 *** Thomaz <Thomaz!62e57e13@c-98-229-126-19.hsd1.ma.comcast.net> has joined #bitcoin-core-dev
2972021-04-07T17:35:38 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
2982021-04-07T17:36:35 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
2992021-04-07T17:39:12 *** Thomaz <Thomaz!62e57e13@c-98-229-126-19.hsd1.ma.comcast.net> has quit IRC (Quit: Connection closed)
3002021-04-07T17:43:22 *** rr1618 <rr1618!4972c670@c-73-114-198-112.hsd1.ma.comcast.net> has quit IRC (Ping timeout: 240 seconds)
3012021-04-07T17:44:34 *** zak <zak!ac3a6f22@172.58.111.34> has joined #bitcoin-core-dev
3022021-04-07T17:45:34 *** zak <zak!ac3a6f22@172.58.111.34> has quit IRC (Client Quit)
3032021-04-07T17:46:24 *** ccdle12 <ccdle12!955adef3@243.222.90.149.rev.vodafone.pt> has quit IRC (Quit: Connection closed)
3042021-04-07T17:47:35 <wumpus> jeremyrubin: from what i understand, it is about simply running the wallet tests with sqlite, don't think fuzzing is involved here
3052021-04-07T17:47:55 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
3062021-04-07T17:48:44 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
3072021-04-07T18:01:14 *** cec47 <cec47!aedb819a@154.sub-174-219-129.myvzw.com> has quit IRC (Quit: Connection closed)
3082021-04-07T18:19:49 *** stanstandard <stanstandard!~stanstand@172.58.76.52> has joined #bitcoin-core-dev
3092021-04-07T18:22:33 *** DFBAFD <DFBAFD!~stanstand@ip68-104-2-250.lv.lv.cox.net> has joined #bitcoin-core-dev
3102021-04-07T18:22:40 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Remote host closed the connection)
3112021-04-07T18:22:42 *** stanstandard <stanstandard!~stanstand@172.58.76.52> has quit IRC (Disconnected by services)
3122021-04-07T18:23:03 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
3132021-04-07T18:23:25 *** DFBAFD <DFBAFD!~stanstand@ip68-104-2-250.lv.lv.cox.net> has left #bitcoin-core-dev
3142021-04-07T18:26:33 *** stanstandard <stanstandard!~stanstand@ip68-104-2-250.lv.lv.cox.net> has joined #bitcoin-core-dev
3152021-04-07T18:27:41 *** justanotheruser <justanotheruser!justanothe@gateway/vpn/protonvpn/justanotheruser> has quit IRC (Ping timeout: 240 seconds)
3162021-04-07T18:32:02 *** biteskola <biteskola!~biteskola@170.76.76.188.dynamic.jazztel.es> has joined #bitcoin-core-dev
3172021-04-07T18:39:49 *** sipa_ <sipa_!~pw@gateway/tor-sasl/sipa1024> has quit IRC (Quit: Lost terminal)
3182021-04-07T18:50:17 *** sipa <sipa!~pw@gateway/tor-sasl/sipa1024> has joined #bitcoin-core-dev
3192021-04-07T18:53:12 *** belcher is now known as belcher_
3202021-04-07T19:05:19 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
3212021-04-07T19:08:45 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
3222021-04-07T19:09:09 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
3232021-04-07T19:09:37 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
3242021-04-07T19:09:49 *** belcher_ <belcher_!~belcher@unaffiliated/belcher> has quit IRC (Quit: Leaving)
3252021-04-07T19:12:51 *** molz_ <molz_!~mol@unaffiliated/molly> has quit IRC (Ping timeout: 248 seconds)
3262021-04-07T19:15:59 *** mol_ <mol_!~mol@unaffiliated/molly> has joined #bitcoin-core-dev
3272021-04-07T19:17:36 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Read error: Connection reset by peer)
3282021-04-07T19:31:07 *** kiltzman <kiltzman!~k1ltzman@195.189.99.96> has quit IRC (Ping timeout: 265 seconds)
3292021-04-07T19:36:02 *** kiltzman <kiltzman!~k1ltzman@5.206.224.243> has joined #bitcoin-core-dev
3302021-04-07T19:36:17 *** promag_ <promag_!~promag@188.250.84.129> has joined #bitcoin-core-dev
3312021-04-07T19:37:09 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has joined #bitcoin-core-dev
3322021-04-07T19:40:35 *** promag_ <promag_!~promag@188.250.84.129> has quit IRC (Ping timeout: 248 seconds)
3332021-04-07T19:45:41 *** stanstandard <stanstandard!~stanstand@ip68-104-2-250.lv.lv.cox.net> has quit IRC (Ping timeout: 240 seconds)
3342021-04-07T19:50:21 *** justanotheruser <justanotheruser!~justanoth@unaffiliated/justanotheruser> has quit IRC (Read error: Connection reset by peer)
3352021-04-07T19:52:39 *** stortz <stortz!c8b9c69a@unaffiliated/stortz> has joined #bitcoin-core-dev
3362021-04-07T19:55:47 *** smctwo <smctwo!~smctwo@bba597217.alshamil.net.ae> has joined #bitcoin-core-dev
3372021-04-07T20:01:07 *** smctwo <smctwo!~smctwo@bba597217.alshamil.net.ae> has quit IRC (Remote host closed the connection)
3382021-04-07T20:01:40 *** smctwo <smctwo!~smctwo@bba597217.alshamil.net.ae> has joined #bitcoin-core-dev
3392021-04-07T20:02:17 <achow101> maybe it's a performance regression in some version? I don't see this issue on my syste with sqlite 3.35.4
3402021-04-07T20:06:26 *** smctwo <smctwo!~smctwo@bba597217.alshamil.net.ae> has quit IRC (Ping timeout: 268 seconds)
3412021-04-07T20:07:36 *** stanstandard <stanstandard!~stanstand@ip68-104-2-250.lv.lv.cox.net> has joined #bitcoin-core-dev
3422021-04-07T20:08:13 <sipa> achow101: perhaps it is related to disk i/o speed?
3432021-04-07T20:08:30 <achow101> I'm thinking it is related to that
3442021-04-07T20:08:41 <achow101> I just tried 3.34.1 and did not see the same performance issue
3452021-04-07T20:09:03 <sipa> if it"s doing lots of fsyncs, it may be super slow on network-connected spinning disk storage, but barely noticable on fast nvme ssd
3462021-04-07T20:09:11 <wumpus> i remember some issues with fsyncing being really slow when used inside VMs
3472021-04-07T20:09:13 <wumpus> yes that
3482021-04-07T20:09:43 <wumpus> maybe it's doing a lot of write transactions separately
3492021-04-07T20:09:44 <achow101> well the test datadir is /tmp, which IIRC is a ramdisk
3502021-04-07T20:09:49 <achow101> *is in /tmp
3512021-04-07T20:09:54 <sipa> not on my system
3522021-04-07T20:09:56 <achow101> so disk shouldn't matter there?
3532021-04-07T20:10:09 <achow101> hmm
3542021-04-07T20:10:12 <sipa> hmm
3552021-04-07T20:10:24 <wumpus> /tmp is definitely not a ramdisk on all linux distros
3562021-04-07T20:10:36 <sipa> as soon as descriotor wallets were merged, the parallellism i could run the tests with dramatically reduced
3572021-04-07T20:10:50 <sipa> went from 60 without problems to 10 or so
3582021-04-07T20:11:17 <sipa> and i often still see a few time out that i need to rerun manually
3592021-04-07T20:11:18 <achow101> I will try this on a slower drive
3602021-04-07T20:12:46 <sipa> it's always descriptor wallet tests that time out for me
3612021-04-07T20:13:14 <achow101> being disk i/o bound does make sense to me
3622021-04-07T20:13:16 <sipa> (not all of them, and not deterministically, so i nevrr thought too much about it)
3632021-04-07T20:14:45 <phantomcircuit> sipa, the performance issue i saw wasn't in a vm btw
3642021-04-07T20:14:56 <phantomcircuit> wait actually it was im dumb
3652021-04-07T20:15:08 <sipa> so if this is related, i don't think it's a regression
3662021-04-07T20:15:24 <achow101> how do I make test_bitcoin use a different datadir?
3672021-04-07T20:15:43 <sipa> chroot? :p
3682021-04-07T20:16:28 <sipa> or just moujt another fs over /tmp
3692021-04-07T20:17:13 <sipa> mkdir /non-tmpfs-tmp && sudo mount --bind /non-tmpfs-tmp /tmp
3702021-04-07T20:18:20 <sipa> achow101: oh it's the functional tests that time out for m; unit tests are never a problrm
3712021-04-07T20:18:57 <achow101> I have other things appear to be using tmp, so I'd rather not mount over it. I think I'll just modify the code
3722021-04-07T20:19:07 <wumpus> or pass a different TMPDIR
3732021-04-07T20:19:29 <achow101> it seems like the the unit tests can reliably show the performance issue, so I'll go with that
3742021-04-07T20:19:43 <wumpus> (assuming nothing is hardcoding /tmp which would be bad)
3752021-04-07T20:21:10 <wumpus> alternatively a chroot with everything bind-mounted execept tmp, but that seems overkill in this case
3762021-04-07T20:21:24 <achow101> hard coding the path was easier
3772021-04-07T20:21:26 *** smartineng <smartineng!~Icedove@88.135.18.171> has quit IRC (Quit: smartineng)
3782021-04-07T20:21:50 <wumpus> i think setting TMPDIR should work i had to do it once for a system with only a small /tmp partition
3792021-04-07T20:22:49 <achow101> definitely appears to be disk io
3802021-04-07T20:23:13 <achow101> 100% disk utilization and the CreateWallet test is now taking a very long time
3812021-04-07T20:23:45 <achow101> we may be using sqlite subotimally
3822021-04-07T20:24:51 *** stanstandard <stanstandard!~stanstand@ip68-104-2-250.lv.lv.cox.net> has quit IRC (Ping timeout: 248 seconds)
3832021-04-07T20:26:02 <jonatack> "it's always descriptor wallet tests that time out for me" --> same (apart from other timeouts/races)
3842021-04-07T20:27:04 <sipa> achow101: i can give you ssh access on my system if that helps, but it sounds like you're already able to reproduce?
3852021-04-07T20:27:18 <achow101> yes, I believe I have reproduced it
3862021-04-07T20:37:59 *** biteskola <biteskola!~biteskola@170.76.76.188.dynamic.jazztel.es> has quit IRC (Ping timeout: 260 seconds)
3872021-04-07T20:40:48 <jeremyrubin> can you just pass a ramdisk in for where to create the DB for testing lol
3882021-04-07T20:41:52 <jeremyrubin> ah i guess this is already discussed above my b
3892021-04-07T20:41:52 <achow101> the functional tests let you specify the tempdir the datadirs are made in
3902021-04-07T20:50:39 *** guilhermeblanco <guilhermeblanco!~guilherme@185.204.1.185> has quit IRC (Remote host closed the connection)
3912021-04-07T20:57:21 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
3922021-04-07T20:57:37 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
3932021-04-07T20:57:46 *** lightlike <lightlike!~lightlike@p200300c7ef15af00f19cdf24a57643ec.dip0.t-ipconnect.de> has quit IRC (Ping timeout: 258 seconds)
3942021-04-07T21:07:00 *** ovovo <ovovo!~ovovo@179.43.152.51> has joined #bitcoin-core-dev
3952021-04-07T21:09:07 *** owowo <owowo!~ovovo@unaffiliated/ovovo> has quit IRC (Ping timeout: 248 seconds)
3962021-04-07T21:10:13 <wumpus> that does require a lot of memory though, the bitcoin functional tests (especially with high parallelism) tend to create many files
3972021-04-07T21:24:31 <sipa> with tmpfs /tmp, functional tests at -j60: 126 s runtime, all tests pass
3982021-04-07T21:29:56 <phantomcircuit> sipa, through the magic of fsync() {}
3992021-04-07T21:33:03 <sipa> with normal /tmp, the same takes 488 s, and 3 tests fail
4002021-04-07T21:33:29 <sipa> (this is a 16-core/32-thread system with 32G RAM)
4012021-04-07T21:33:56 <phantomcircuit> there's a bunch of functional tests that randomly timeout iirc
4022021-04-07T21:34:54 *** pmuir <pmuir!~pmuir@185.204.1.185> has joined #bitcoin-core-dev
4032021-04-07T21:37:37 <achow101> We are currently enabling fullfsync (someone suggested we do this to ensure that everything is truly flushed), but the sqlite docs says this "But the implementation of fullfsync involves resetting the disk controller. And so not only is it profoundly slow, it also slows down other unrelated disk I/O. So its use is not recommended."
4042021-04-07T21:38:03 <achow101> but that would only affect macs
4052021-04-07T21:41:15 *** shesek <shesek!~shesek@unaffiliated/shesek> has quit IRC (Remote host closed the connection)
4062021-04-07T21:41:59 *** shesek <shesek!~shesek@unaffiliated/shesek> has joined #bitcoin-core-dev
4072021-04-07T21:42:00 <achow101> I would guess that the slow down is because sqlite does an (or two) fsync per write
4082021-04-07T21:43:16 <luke-jr> doesn't fsync on Linux also wait for everything else writing to get to disk too?
4092021-04-07T21:43:21 <luke-jr> or at least things queued before you
4102021-04-07T21:46:15 *** stortz <stortz!c8b9c69a@unaffiliated/stortz> has quit IRC (Quit: Connection closed)
4112021-04-07T21:47:23 <phantomcircuit> achow101, performance sensitive sqlite requires using the write ahead log
4122021-04-07T21:47:50 <achow101> and a write ahead log is why we don't want bdb
4132021-04-07T21:48:06 <phantomcircuit> luke-jr, yes, fsync and fdatasync are for the entire filesystem despite being called on a file or directory
4142021-04-07T21:49:10 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
4152021-04-07T21:50:48 <phantomcircuit> achow101, which journal mode are we using?
4162021-04-07T21:50:55 <achow101> rollback
4172021-04-07T21:51:47 <phantomcircuit> achow101, you mean DELETE ?
4182021-04-07T21:52:19 <achow101> we use the rollback journal in PERSIST mode
4192021-04-07T21:52:36 <achow101> PERSIST is because that's what it does when locking_mode=EXCLUSIVE
4202021-04-07T21:53:43 <phantomcircuit> achow101, i guess the real issue is that there basically two categories of 'written' we care about, key material and not-key material
4212021-04-07T21:54:18 <phantomcircuit> i don't think with PERSIST requires using synchronous=FULL, but can be NORMAL instead
4222021-04-07T21:54:49 <sipa> if it's just creation that's painful, these paranoid modes could also just be enabled after creation
4232021-04-07T21:54:52 <phantomcircuit> there's also these flags https://sqlite.org/c3ref/c_sync_dataonly.html
4242021-04-07T21:55:06 <phantomcircuit> which are separate from the journal_mode and the synchronous pragmas
4252021-04-07T21:55:06 <sipa> but i suspect it's a more general sign of a i/o boundness issue
4262021-04-07T21:55:40 <luke-jr> achow101: well, corruption is the reason we don't want bdb⦠is sqlite's WAL just as prone to loss?
4272021-04-07T21:56:15 <phantomcircuit> sipa, everywhere that key material is written could be sandwiched in a bunch of flushing logic, but also that's kinda of asking for missing that somewhere
4282021-04-07T21:56:41 <phantomcircuit> luke-jr, if you lose the WAL you lose what was written, but don't corrupt the database
4292021-04-07T21:56:55 <achow101> luke-jr: WAL (in general) means we have to do the thing where we constantly flush the log back to the db file. this adds additional overhead, another thread, and is just kind of a pain. It's one of the things bdb does that results in a lot of complexity in that code
4302021-04-07T21:57:42 <achow101> sipa: I think if we did all of setup as a single transaction a large part of this would go away.
4312021-04-07T21:58:16 <achow101> and doing setup as a single transaction is probably safe
4322021-04-07T21:58:44 <luke-jr> achow101: but so long as it doesn't corrupt, it's tolerable IMO
4332021-04-07T21:58:56 <phantomcircuit> yes sqlite performance is almost entirely based on commits
4342021-04-07T21:59:17 <phantomcircuit> a thousand writes with one commit is going to be faster than hundreds of writes with 10 commits
4352021-04-07T21:59:48 <achow101> luke-jr: WAL has the risk of losing data if that log is lost, and I think that isn't tolerable for a completely new db system
4362021-04-07T22:00:58 <phantomcircuit> achow101, wrapping the entire setup in a transaction has the issue of making the logic tied more closely to the data layer so
4372021-04-07T22:01:03 <phantomcircuit> iono options etc
4382021-04-07T22:02:17 <sipa> a right; is that hard to do?
4392021-04-07T22:03:17 <achow101> shouldn't be hard to transaction-ize large portions of setup
4402021-04-07T22:03:28 <achow101> especially the parts that write a few thousand records
4412021-04-07T22:04:18 <luke-jr> won't break abstractions?
4422021-04-07T22:04:37 <achow101> no, WalletBatch already has transaction create and commit
4432021-04-07T22:05:38 <achow101> although now that I think about it, descriptor wallets don't have a whole lot of records to write
4442021-04-07T22:05:57 <achow101> unless the test is making a legacy wallet with sqlite
4452021-04-07T22:06:19 <phantomcircuit> do they not pregenerate a bunch of keys?
4462021-04-07T22:06:34 <achow101> they're generated on the fly and kept in memory only
4472021-04-07T22:06:55 *** stanstandard <stanstandard!~stanstand@ip68-104-2-250.lv.lv.cox.net> has joined #bitcoin-core-dev
4482021-04-07T22:07:01 <sipa> what?
4492021-04-07T22:07:08 <sipa> the key cache isn't written?
4502021-04-07T22:07:19 <achow101> Only the parent xpub is written
4512021-04-07T22:07:26 <sipa> oh, right
4522021-04-07T22:07:32 <sipa> that's nice
4532021-04-07T22:07:42 <sipa> is that recent?
4542021-04-07T22:07:55 <achow101> that was in the original
4552021-04-07T22:08:10 <sipa> interesting
4562021-04-07T22:08:42 <sipa> what if you have a blabla/*h descriptor?
4572021-04-07T22:09:00 <achow101> then it stores all of the derived keys
4582021-04-07T22:09:10 <sipa> i see, ok
4592021-04-07T22:09:23 <achow101> but you have to import such a descriptor explicitly, so the CreateWallet test shouldn't be doing that
4602021-04-07T22:09:28 *** pox <pox!~pox@gateway/tor-sasl/pox> has quit IRC (Remote host closed the connection)
4612021-04-07T22:09:29 <sipa> right
4622021-04-07T22:10:38 *** pox <pox!~pox@gateway/tor-sasl/pox> has joined #bitcoin-core-dev
4632021-04-07T22:11:12 <sipa> still, a 1000x slowdown... kind of suggests it's more than a few records?
4642021-04-07T22:11:26 *** biteskola <biteskola!~biteskola@170.76.76.188.dynamic.jazztel.es> has joined #bitcoin-core-dev
4652021-04-07T22:11:59 <achow101> ... it's making a legacy wallet with sqlite
4662021-04-07T22:12:35 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
4672021-04-07T22:12:37 <achow101> sipa: which descriptor wallet functional tests timeout?
4682021-04-07T22:12:47 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
4692021-04-07T22:12:48 <achow101> the functional tests shouldn't be making legacy wallets with sqlite
4702021-04-07T22:18:08 <sipa> ha.
4712021-04-07T22:20:47 <sipa> rpc_fundrawtransaction.py --descriptors | â Failed | 488 s
4722021-04-07T22:20:50 <sipa> wallet_create_tx.py --descriptors | â Failed | 94 s
4732021-04-07T22:20:53 <sipa> wallet_keypool.py --descriptors | â Failed | 116 s
4742021-04-07T22:21:06 <sipa> what about phantomcircuit's slow test?
4752021-04-07T22:22:33 <phantomcircuit> i was definitely using a descriptor wallet
4762021-04-07T22:23:38 <phantomcircuit> yeah format sqlite descriptors true
4772021-04-07T22:25:38 <achow101> phantomcircuit: what were you testing specifcally that was slow?
4782021-04-07T22:26:25 *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has quit IRC (Remote host closed the connection)
4792021-04-07T22:26:41 <phantomcircuit> achow101, just creating the wallet took a very long time
4802021-04-07T22:26:52 *** davterra <davterra!~davterra@gateway/tor-sasl/tralfaz> has joined #bitcoin-core-dev
4812021-04-07T22:27:24 <achow101> ok..
4822021-04-07T22:28:27 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has quit IRC (Remote host closed the connection)
4832021-04-07T22:40:35 *** biteskola <biteskola!~biteskola@170.76.76.188.dynamic.jazztel.es> has quit IRC (Ping timeout: 265 seconds)
4842021-04-07T22:40:35 *** stanstandard <stanstandard!~stanstand@ip68-104-2-250.lv.lv.cox.net> has quit IRC (Ping timeout: 246 seconds)
4852021-04-07T22:54:28 *** biteskola <biteskola!~biteskola@170.76.76.188.dynamic.jazztel.es> has joined #bitcoin-core-dev
4862021-04-07T22:56:02 <achow101> sipa: do those timeout on a createwallet call or something else?
4872021-04-07T22:56:33 <achow101> phantomcircuit: were you using an older version of the descriptor wallet pr? there was an iteration that wrote a few thousand records.
4882021-04-07T22:57:31 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 260 seconds)
4892021-04-07T22:58:45 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has quit IRC (Ping timeout: 240 seconds)
4902021-04-07T22:59:34 *** belcher <belcher!~belcher@unaffiliated/belcher> has joined #bitcoin-core-dev
4912021-04-07T23:01:21 *** TheRec_ <TheRec_!~toto@drupal.org/user/146860/view> has joined #bitcoin-core-dev
4922021-04-07T23:02:20 *** TheRec <TheRec!~toto@drupal.org/user/146860/view> has quit IRC (Read error: Connection reset by peer)
4932021-04-07T23:05:08 *** braydonf <braydonf!~braydon@gateway/tor-sasl/braydonf> has joined #bitcoin-core-dev
4942021-04-07T23:06:39 <achow101> it seems like functional test timeout might be from writing all of the transactions that generatetoaddress produces
4952021-04-07T23:13:42 <wumpus> if it's only a performance problem in the tests, what about disabling the fsyncing in the tests?
4962021-04-07T23:14:38 <wumpus> i'm not sure there is any real life scenario where the wallet would generate so many writes
4972021-04-07T23:14:52 <wumpus> it's not like lightning: https://github.com/lightningnetwork/lnd/issues/5186
4982021-04-07T23:15:04 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
4992021-04-07T23:16:28 <achow101> wumpus: this could be an issue for wallets that receive a lot of transactions
5002021-04-07T23:17:13 <achow101> if they are all in one block, it can be optimized to use a db transaction there, but if a lot of unconfirmed txs, that might be a problem
5012021-04-07T23:17:15 <wumpus> nah, i doubt any single wallet will receive enough on-network transactions for that to really add up enough
5022021-04-07T23:18:47 *** promag <promag!~promag@188.250.84.129> has quit IRC (Remote host closed the connection)
5032021-04-07T23:19:42 *** promag <promag!~promag@188.250.84.129> has joined #bitcoin-core-dev
5042021-04-07T23:40:26 *** AaronvanW <AaronvanW!~AaronvanW@unaffiliated/aaronvanw> has joined #bitcoin-core-dev