12021-06-02T00:08:22 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
22021-06-02T00:53:06 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 264 seconds)
32021-06-02T01:18:34 *** jarthur_ <jarthur_!~jarthur@2603-8080-1540-002d-1dc8-ad8e-06d0-f812.res6.spectrum.com> has joined #bitcoin-core-dev
42021-06-02T01:21:33 *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-55bf-0755-4786-625d.res6.spectrum.com> has quit IRC (Ping timeout: 265 seconds)
52021-06-02T01:40:37 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 252 seconds)
62021-06-02T01:46:06 *** klement <klement!~klement@218.212.21.21> has joined #bitcoin-core-dev
72021-06-02T02:04:36 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
82021-06-02T02:40:35 *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has joined #bitcoin-core-dev
92021-06-02T02:41:56 *** kvs <kvs!~root@175.102.16.34> has joined #bitcoin-core-dev
102021-06-02T02:45:56 *** kvs <kvs!~root@175.102.16.34> has left #bitcoin-core-dev (WeeChat 3.1)
112021-06-02T02:46:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
122021-06-02T02:46:17 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7e83e74e7fca...0a3b8ea11ad2
132021-06-02T02:46:17 <bitcoin-git> bitcoin/master 610151f fanquake: validation: change ProcessNewBlock() to take a CBlock reference
142021-06-02T02:46:17 <bitcoin-git> bitcoin/master e12f287 fanquake: net: cleanup newly added PeerManagerImpl::ProcessNewBlock
152021-06-02T02:46:17 <bitcoin-git> bitcoin/master 0a3b8ea fanquake: Merge bitcoin/bitcoin#22106: refactor: address ProcessNewBlock comments fr...
162021-06-02T02:46:17 *** kvs <kvs!~root@175.102.16.34> has joined #bitcoin-core-dev
172021-06-02T02:46:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
182021-06-02T02:46:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
192021-06-02T02:46:34 <bitcoin-git> [bitcoin] fanquake merged pull request #22106: refactor: address ProcessNewBlock comments from #21713 (master...fixup_21713) https://github.com/bitcoin/bitcoin/pull/22106
202021-06-02T02:46:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
212021-06-02T02:48:03 *** kvs <kvs!~root@175.102.16.34> has left #bitcoin-core-dev (WeeChat 3.1)
222021-06-02T02:52:31 *** kvs <kvs!~root@175.102.16.34> has joined #bitcoin-core-dev
232021-06-02T03:32:20 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
242021-06-02T03:35:49 *** Xr <Xr!~Eos@85.99.196.166> has joined #bitcoin-core-dev
252021-06-02T03:35:51 <Xr> Her geli�menin ve kurtulu�un anas� H�rriyettir. Mustafa Gurur, Kemal Onur, Atat�rk �ereftir!
262021-06-02T03:39:50 *** Xr <Xr!~Eos@85.99.196.166> has quit IRC ()
272021-06-02T03:41:03 *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has quit IRC (Ping timeout: 268 seconds)
282021-06-02T03:50:23 *** achow101 <achow101!~achow101@user/achow101> has quit IRC (Remote host closed the connection)
292021-06-02T03:51:47 *** achow101 <achow101!~achow101@user/achow101> has joined #bitcoin-core-dev
302021-06-02T04:12:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
312021-06-02T04:12:57 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0a3b8ea11ad2...a83bbf02c762
322021-06-02T04:12:57 <bitcoin-git> bitcoin/master fa416ce Hennadii Stepanov: depends: Bump Qt version to 5.12.11
332021-06-02T04:12:57 <bitcoin-git> bitcoin/master a83bbf0 fanquake: Merge bitcoin/bitcoin#22054: depends: Bump Qt version to 5.12.11
342021-06-02T04:12:59 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
352021-06-02T04:13:14 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
362021-06-02T04:13:14 <bitcoin-git> [bitcoin] fanquake merged pull request #22054: depends: Bump Qt version to 5.12.11 (master...210525-bump) https://github.com/bitcoin/bitcoin/pull/22054
372021-06-02T04:13:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
382021-06-02T04:22:33 *** EPiSKiNG- <EPiSKiNG-!~EPiSKiNG-@episking.com> has joined #bitcoin-core-dev
392021-06-02T04:33:00 *** belcher_ <belcher_!~belcher@user/belcher> has joined #bitcoin-core-dev
402021-06-02T04:35:51 *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 265 seconds)
412021-06-02T04:56:42 *** DeanGuss <DeanGuss!~dean@nonplayercharacter.me> has joined #bitcoin-core-dev
422021-06-02T05:46:19 *** goatpig <goatpig!~goat@h-94-254-2-155.A498.priv.bahnhof.se> has quit IRC (Quit: Konversation terminated!)
432021-06-02T05:47:32 *** klement <klement!~klement@218.212.21.21> has quit IRC (Ping timeout: 250 seconds)
442021-06-02T05:56:38 *** jarthur_ <jarthur_!~jarthur@2603-8080-1540-002d-1dc8-ad8e-06d0-f812.res6.spectrum.com> has quit IRC (Ping timeout: 272 seconds)
452021-06-02T05:57:01 *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-c9ff-b6a0-236c-2bdd.res6.spectrum.com> has joined #bitcoin-core-dev
462021-06-02T05:59:41 *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has joined #bitcoin-core-dev
472021-06-02T06:05:53 *** kvs <kvs!~root@175.102.16.34> has left #bitcoin-core-dev (WeeChat 3.1)
482021-06-02T06:09:16 *** calvinalvin <calvinalvin!~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com> has joined #bitcoin-core-dev
492021-06-02T06:09:21 *** kcalvinalvin <kcalvinalvin!~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com> has quit IRC (Ping timeout: 272 seconds)
502021-06-02T06:09:48 *** calvinalvin is now known as kcalvinalvin
512021-06-02T06:10:34 *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has quit IRC (Ping timeout: 272 seconds)
522021-06-02T06:25:24 *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has joined #bitcoin-core-dev
532021-06-02T06:25:39 *** jarthur_ <jarthur_!~jarthur@2603-8080-1540-002d-f41b-1ba7-b2bc-ba31.res6.spectrum.com> has joined #bitcoin-core-dev
542021-06-02T06:29:06 *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-c9ff-b6a0-236c-2bdd.res6.spectrum.com> has quit IRC (Ping timeout: 264 seconds)
552021-06-02T06:35:05 *** jarthur_ <jarthur_!~jarthur@2603-8080-1540-002d-f41b-1ba7-b2bc-ba31.res6.spectrum.com> has quit IRC (Quit: jarthur_)
562021-06-02T06:53:56 *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has joined #bitcoin-core-dev
572021-06-02T06:59:53 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
582021-06-02T07:03:54 *** dvd <dvd!~dvd@nat-pool-rdu-t.redhat.com> has quit IRC (Read error: Connection reset by peer)
592021-06-02T07:04:13 *** dvd <dvd!~dvd@nat-pool-rdu-t.redhat.com> has joined #bitcoin-core-dev
602021-06-02T07:21:42 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
612021-06-02T07:21:42 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a83bbf02c762...2fccd9cf3036
622021-06-02T07:21:42 <bitcoin-git> bitcoin/master e3c866e Martin Ankerl: test: update nanobench from release 4.0.0 to 4.3.4
632021-06-02T07:21:42 <bitcoin-git> bitcoin/master 44d05d0 Martin Ankerl: test: remove sanitizer suppression for nanobench
642021-06-02T07:21:42 <bitcoin-git> bitcoin/master 2fccd9c MarcoFalke: Merge bitcoin/bitcoin#22082: test: update nanobench from release 4.0.0 to ...
652021-06-02T07:21:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
662021-06-02T07:21:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
672021-06-02T07:21:58 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22082: test: update nanobench from release 4.0.0 to 4.3.4 (master...2021-05-update-nanobench) https://github.com/bitcoin/bitcoin/pull/22082
682021-06-02T07:21:59 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
692021-06-02T07:33:03 *** morcos <morcos!~morcos@gateway/tor-sasl/morcos> has quit IRC (Remote host closed the connection)
702021-06-02T07:33:22 *** morcos <morcos!~morcos@gateway/tor-sasl/morcos> has joined #bitcoin-core-dev
712021-06-02T07:33:43 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 252 seconds)
722021-06-02T07:42:09 *** linuxgeek <linuxgeek!linuxgeek@14-203-172-78.tpgi.com.au> has joined #bitcoin-core-dev
732021-06-02T07:44:44 *** Kiminuo <Kiminuo!~Kiminuo@141.98.103.180> has joined #bitcoin-core-dev
742021-06-02T07:49:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
752021-06-02T07:49:30 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22121: doc: Various validation doc fixups (master...2106-docVal) https://github.com/bitcoin/bitcoin/pull/22121
762021-06-02T07:49:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
772021-06-02T07:52:57 *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f03bc00450477d61102fa6c.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
782021-06-02T08:04:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
792021-06-02T08:04:34 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22122: ci: Bump macOS image to big-sur-xcode-12.5 (master...2106-ciMac) https://github.com/bitcoin/bitcoin/pull/22122
802021-06-02T08:04:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
812021-06-02T08:25:57 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has joined #bitcoin-core-dev
822021-06-02T08:31:14 <hebasto> gh did not update a pr after force pushing my local branch -- any advice?
832021-06-02T08:32:45 <_aj_> push the parent commit, then re-push the commit you actually want
842021-06-02T08:33:17 <hebasto> _aj_: thanks, will try it
852021-06-02T08:33:37 <jnewbery> github doesn't seem to be letting me leave comments right now. Maybe they're having a partial outage?
862021-06-02T08:33:42 <_aj_> (or make a dummy child commit, then get rid of it)
872021-06-02T08:35:57 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
882021-06-02T08:36:41 <jnewbery> yeah, github is having lots of issues right now
892021-06-02T08:37:33 <hebasto> indeed, https://www.githubstatus.com/incidents/76nv9h8pmkv4?utm_ts=1622622945
902021-06-02T08:41:46 *** smartin <smartin!~Icedove@88.135.18.171> has joined #bitcoin-core-dev
912021-06-02T09:06:01 *** evias <evias!~evias__@196.red-88-6-131.staticip.rima-tde.net> has joined #bitcoin-core-dev
922021-06-02T09:06:35 <promag> yup, issues downloading archives for depends build
932021-06-02T09:07:58 <jnewbery> I'm able to leave comments again, so it's at least partially resolved
942021-06-02T09:10:57 <hebasto> works for me too
952021-06-02T09:11:39 <promag> #22123 fixes depends for m1
962021-06-02T09:11:40 <gribble> https://github.com/bitcoin/bitcoin/issues/22123 | depends: Fix qt.mk for mac arm64 by promag · Pull Request #22123 · bitcoin/bitcoin · GitHub
972021-06-02T09:27:32 *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has quit IRC (Ping timeout: 272 seconds)
982021-06-02T09:28:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
992021-06-02T09:28:44 <bitcoin-git> [bitcoin] promag opened pull request #22123: depends: Fix qt.mk for mac arm64 (master...2021-06-fix-aarch64_darwin) https://github.com/bitcoin/bitcoin/pull/22123
1002021-06-02T09:28:45 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1012021-06-02T09:30:41 *** hendi <hendi!sid489601@id-489601.tooting.irccloud.com> has joined #bitcoin-core-dev
1022021-06-02T09:30:42 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has quit IRC (Ping timeout: 272 seconds)
1032021-06-02T09:36:37 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has joined #bitcoin-core-dev
1042021-06-02T09:41:02 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Quit: Ping timeout (120 seconds))
1052021-06-02T09:41:13 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has quit IRC (Ping timeout: 244 seconds)
1062021-06-02T09:43:25 *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has joined #bitcoin-core-dev
1072021-06-02T09:56:37 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has joined #bitcoin-core-dev
1082021-06-02T10:05:32 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has quit IRC (Ping timeout: 272 seconds)
1092021-06-02T10:16:25 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
1102021-06-02T10:16:51 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has joined #bitcoin-core-dev
1112021-06-02T10:18:12 *** belcher_ <belcher_!~belcher@user/belcher> has quit IRC (Ping timeout: 272 seconds)
1122021-06-02T10:24:42 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1132021-06-02T10:24:42 <bitcoin-git> [gui] laanwj merged pull request #351: Translations update (master...210601-tr) https://github.com/bitcoin-core/gui/pull/351
1142021-06-02T10:24:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1152021-06-02T10:25:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1162021-06-02T10:25:01 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2fccd9cf3036...e3d644a127e1
1172021-06-02T10:25:01 <bitcoin-git> bitcoin/master 0680460 Hennadii Stepanov: qt: Translations update
1182021-06-02T10:25:01 <bitcoin-git> bitcoin/master e3d644a W. J. van der Laan: Merge bitcoin-core/gui#351: Translations update
1192021-06-02T10:25:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1202021-06-02T10:28:21 *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
1212021-06-02T10:29:05 <fanquake> promag: what's wrong with it now. I thought that line had already been added to fix it
1222021-06-02T10:29:57 <fanquake> I wouldn't have to ask if that PR, or even the commit had a useful description
1232021-06-02T10:30:43 <fanquake> Why does this trend of opening description-less, or just very poorly explained PRs seem to be becoming more frequent
1242021-06-02T10:32:51 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has quit IRC (Ping timeout: 245 seconds)
1252021-06-02T10:35:09 <laanwj> yes lets encourage PRs to have useful descriptions
1262021-06-02T10:36:10 <laanwj> at the least: what does it change, what does it fix, even more helpful "how to test" "how to review"
1272021-06-02T10:40:46 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has joined #bitcoin-core-dev
1282021-06-02T10:45:17 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has quit IRC (Ping timeout: 244 seconds)
1292021-06-02T10:46:30 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has joined #bitcoin-core-dev
1302021-06-02T10:50:05 <fanquake> laanwj: Yes. I've tried to summarize something similar here: https://github.com/bitcoin/bitcoin/pull/21570#issuecomment-819220600
1312021-06-02T10:50:58 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has quit IRC (Ping timeout: 244 seconds)
1322021-06-02T10:51:58 *** Guest64 <Guest64!~Guest64@184.75.221.35> has joined #bitcoin-core-dev
1332021-06-02T10:52:20 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has joined #bitcoin-core-dev
1342021-06-02T10:55:27 <_aj_> yay for descriptive PR descriptions
1352021-06-02T10:56:58 <michaelfolkson> Is this worth putting in CONTRIBUTING.md? (the fanquake guidance)
1362021-06-02T10:57:28 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has quit IRC (Ping timeout: 272 seconds)
1372021-06-02T10:57:45 <laanwj> definitely (if there isn't anything like that in there yet)
1382021-06-02T10:58:11 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has joined #bitcoin-core-dev
1392021-06-02T10:59:58 <michaelfolkson> OK happy to add this to my to do list (assuming fanquake doesn't want to open the PR)
1402021-06-02T11:02:01 <fanquake> I'm not fussed. I'd like to think it's obvious that when you open a PR, you should take 2 minutes to summarize your change, including relevant / useful info, and save reviewers having to ask dumb things like "what is the bug", "how does it fix it" etc.
1412021-06-02T11:02:50 *** belcher <belcher!~belcher@user/belcher> has quit IRC (Quit: Leaving)
1422021-06-02T11:05:46 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has quit IRC (Ping timeout: 245 seconds)
1432021-06-02T11:06:08 <laanwj> i agree, but mentioning it explicitly in a document might be useful to point people to instead of having to type it out time after time
1442021-06-02T11:06:51 <michaelfolkson> fanquake: Right but sometimes people struggle with what needs explaining to others when it is obvious to them. Guidance often helps as a reminder not to take shortcuts with explanations
1452021-06-02T11:09:58 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has joined #bitcoin-core-dev
1462021-06-02T11:10:19 <michaelfolkson> I'll open the PR adding fanquake as a co-author then
1472021-06-02T11:10:53 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1482021-06-02T11:10:53 <bitcoin-git> [bitcoin] hebasto opened pull request #22124: 0.20: Update translations after closing 0.20.x on Transifex (0.20...210602-0.20-tr) https://github.com/bitcoin/bitcoin/pull/22124
1492021-06-02T11:10:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1502021-06-02T11:14:32 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has quit IRC (Ping timeout: 252 seconds)
1512021-06-02T11:15:49 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has joined #bitcoin-core-dev
1522021-06-02T11:43:35 *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
1532021-06-02T11:57:05 *** belcher <belcher!~belcher@user/belcher> has quit IRC (Quit: Leaving)
1542021-06-02T11:57:24 *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
1552021-06-02T12:01:15 <hebasto> the Transifex.com labeled 33 languages with the "no translators" label. Those languages look abandoned as zero strings are translated for all versions. Suggesting to remove them to keep our repository tide. Or is this a topic for a weekly meeting?
1562021-06-02T12:02:19 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1572021-06-02T12:03:54 <laanwj> hebasto: the transifex import script is supposed to strip empty translations, doesn't it do this anymore?
1582021-06-02T12:06:03 <laanwj> that would be the place to solve it, i think it's okay to leave the languages on transifex so that people who want to translate them can do so
1592021-06-02T12:06:04 <hebasto> ah, right -- no empty translations in the repo, it works
1602021-06-02T12:07:25 <laanwj> i tend to universally accept requests to add base languages (e.g. "nl"), but careful about adding dialects "nl_EN", too easy to come up with nonsense ones and i don't have time to investigate this
1612021-06-02T12:07:56 <hebasto> sounds reasonable to me
1622021-06-02T12:12:37 <laanwj> though i wish the language requests came with a description field so people can provide more information about the language they want to translate to, this would make it easier to recognize non-flippant requests
1632021-06-02T12:15:24 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1642021-06-02T12:15:24 <bitcoin-git> [bitcoin] dgoncharov opened pull request #22126: build: Disable make builtin rules. (master...disable_builtin_rules) https://github.com/bitcoin/bitcoin/pull/22126
1652021-06-02T12:15:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1662021-06-02T12:15:26 <laanwj> unfortunately translations provide a fairly easy vandalism angle for people that want to mess with things, because it's inherently hard to check for language you don't know
1672021-06-02T12:27:51 <hebasto> as usually in open-source, translationss are done and kept in a good state by people who care about it. If nobody cares, the result is unpredicted
1682021-06-02T12:28:04 <hebasto> *translations
1692021-06-02T12:30:50 <laanwj> right, it's just even more complicated by language barriers
1702021-06-02T12:34:22 *** Kiminuo <Kiminuo!~Kiminuo@141.98.103.180> has quit IRC (Ping timeout: 272 seconds)
1712021-06-02T12:47:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1722021-06-02T12:47:42 <bitcoin-git> [bitcoin] Vaultbank opened pull request #22128: Create Lil* (master...patch-1) https://github.com/bitcoin/bitcoin/pull/22128
1732021-06-02T12:47:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1742021-06-02T12:48:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1752021-06-02T12:48:21 <bitcoin-git> [bitcoin] fanquake closed pull request #22128: Create Lil* (master...patch-1) https://github.com/bitcoin/bitcoin/pull/22128
1762021-06-02T12:48:22 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1772021-06-02T12:48:52 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 252 seconds)
1782021-06-02T12:48:58 <laanwj> that was fast :)
1792021-06-02T13:06:31 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1802021-06-02T13:18:20 <ufotofu> are the build instructions for linux slightly out of date? the past couple of times i've attempted building have resulted in a libboost related error that was resolved by installing libboost-all-dev (on ubuntu).
1812021-06-02T13:18:50 <laanwj> as far as i know they are up to date, which version of ubuntu are you using
1822021-06-02T13:19:03 <ufotofu> not sure which package it needed specifically, out of the many libboost-all-dev installs
1832021-06-02T13:19:06 <ufotofu> 21.04
1842021-06-02T13:19:14 <laanwj> libboost-all-dev is al extreme sledgehammer so we would like to avoid that
1852021-06-02T13:19:22 <ufotofu> yeah understood
1862021-06-02T13:20:31 <ufotofu> this occurred on ppc64le and now on riscv64 too. can't remember if i ran into it on x86_64.
1872021-06-02T13:22:49 <promag> fanquake: yup my bad
1882021-06-02T13:23:04 <laanwj> that might explain things, i suppose most people following the instrucitons will be using x86_64, ppc and risc-v are usually cross-compiled, anyhow let us know if you figure out which package is missing
1892021-06-02T13:24:11 <laanwj> it might also be a bug in the platform-specific parts of the boost detection am scripting (vaguely remember that a architecture-specific path is injected somewhere)
1902021-06-02T13:31:46 <ufotofu> pretty sure i ran into it on arm64 too so you're probably right
1912021-06-02T13:34:06 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has quit IRC (Ping timeout: 245 seconds)
1922021-06-02T13:36:03 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has joined #bitcoin-core-dev
1932021-06-02T13:48:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1942021-06-02T13:48:08 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/55631547ea88...8b5c83b4aa8c
1952021-06-02T13:48:08 <bitcoin-git> bitcoin/0.20 56baeba Hennadii Stepanov: 0.20: Update translations after closing 0.20.x on Transifex
1962021-06-02T13:48:08 <bitcoin-git> bitcoin/0.20 8b5c83b W. J. van der Laan: Merge bitcoin/bitcoin#22124: 0.20: Finalize translations after closing 0.2...
1972021-06-02T13:48:10 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1982021-06-02T13:48:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1992021-06-02T13:48:25 <bitcoin-git> [bitcoin] laanwj merged pull request #22124: 0.20: Finalize translations after closing 0.20.x on Transifex (0.20...210602-0.20-tr) https://github.com/bitcoin/bitcoin/pull/22124
2002021-06-02T13:48:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2012021-06-02T13:53:34 *** thedragon <thedragon!~thedragon@user/thedragon> has quit IRC (Quit: Leaving)
2022021-06-02T13:58:30 *** davterra <davterra!~davterra@178.128.106.205> has quit IRC (Ping timeout: 264 seconds)
2032021-06-02T13:58:53 <laanwj> ufotofu: see also #17010
2042021-06-02T13:58:55 <gribble> https://github.com/bitcoin/bitcoin/issues/17010 | Missing Boost::System on ARM Ubuntu 18.04 · Issue #17010 · bitcoin/bitcoin · GitHub
2052021-06-02T13:59:43 <laanwj> might need a similar change like #18558 for ppc and risc-v
2062021-06-02T13:59:45 <gribble> https://github.com/bitcoin/bitcoin/issues/18558 | build: Fix boost detection for arch armv7l by hebasto · Pull Request #18558 · bitcoin/bitcoin · GitHub
2072021-06-02T13:59:52 *** davterra <davterra!~davterra@178.128.106.205> has joined #bitcoin-core-dev
2082021-06-02T14:00:14 <laanwj> unfortunately there's all kinds of variability in directory names and it needs to be handled per platform...
2092021-06-02T14:02:59 <ufotofu> hm might be related. i'm running into it after running `make`.
2102021-06-02T14:03:18 <laanwj> okay that seems to be a different issue
2112021-06-02T14:03:20 <ufotofu> configure doesn't seem to catch that it's missing
2122021-06-02T14:10:16 <laanwj> i'd be very interested to know t he exact error you are getting
2132021-06-02T14:15:51 <ufotofu> https://pastebin.com/raw/GfvaFpXG
2142021-06-02T14:15:57 <ufotofu> that's all that was still in my buffer
2152021-06-02T14:19:15 <laanwj> thanks-that looks like boost_thread isn't linked correctly, which is weird, i guess this is for 0.21? fwiw the master branch no longer uses boost thread at all so might have solved this issue
2162021-06-02T14:19:19 *** thedragon <thedragon!~thedragon@user/thedragon> has joined #bitcoin-core-dev
2172021-06-02T14:19:29 <ufotofu> v0.21.1
2182021-06-02T14:23:30 *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has quit IRC (Quit: Konversation terminated!)
2192021-06-02T14:24:24 <hebasto> ufotofu: https://github.com/bitcoin/bitcoin/blob/0.21/doc/build-unix.md mentions the `libboost-thread-dev` package
2202021-06-02T14:25:08 <promag> fanquake: added details
2212021-06-02T14:26:51 <ufotofu> hebasto: hmm not under the ubuntu & debian dependency build instructions though
2222021-06-02T14:28:11 <ufotofu> i don't see where it specifically mentions libboost-thread-dev either
2232021-06-02T14:28:44 <hebasto> have you followed the link https://github.com/bitcoin/bitcoin/blob/0.21/doc/build-unix.md ?
2242021-06-02T14:29:12 <ufotofu> oh, right
2252021-06-02T14:29:13 <laanwj> it might be that you followed the instructions on the master branch, which don't mention installing boost-thread-dev because it is no longer needed
2262021-06-02T14:29:23 <ufotofu> aha ok that makes sense
2272021-06-02T14:32:47 <ufotofu> ok sorry for wasting your time >_>
2282021-06-02T14:33:30 <hebasto> np, happy your problem is solved
2292021-06-02T14:33:52 <laanwj> no problem, i think it's a bug that configure doesn't report the missing library but it fails at link time, though probably not worth fixing anymore
2302021-06-02T14:53:42 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2312021-06-02T14:53:43 <bitcoin-git> [bitcoin] laanwj pushed 17 commits to master: https://github.com/bitcoin/bitcoin/compare/e3d644a127e1...a7d17daa5cd8
2322021-06-02T14:53:43 <bitcoin-git> bitcoin/master 883a5c7 fanquake: test: remove BasicTestingSetup from allocator unit tests
2332021-06-02T14:53:43 <bitcoin-git> bitcoin/master 0559065 fanquake: test: remove BasicTestingSetup from amount unit tests
2342021-06-02T14:53:43 <bitcoin-git> bitcoin/master 4c389ba fanquake: test: remove BasicTestingSetup from arith_uint256 unit tests
2352021-06-02T14:53:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2362021-06-02T14:53:59 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2372021-06-02T14:54:00 <bitcoin-git> [bitcoin] laanwj merged pull request #22086: test: remove BasicTestingSetup from unit tests that don't need it (master...remove_unneeded_test_setup) https://github.com/bitcoin/bitcoin/pull/22086
2382021-06-02T14:54:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2392021-06-02T15:01:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2402021-06-02T15:01:35 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a7d17daa5cd8...1186910b6b7b
2412021-06-02T15:01:35 <bitcoin-git> bitcoin/master dafab2b Jarol Rodriguez: doc: improve note on choosing posix mingw32
2422021-06-02T15:01:35 <bitcoin-git> bitcoin/master 1186910 W. J. van der Laan: Merge bitcoin/bitcoin#22088: doc: improve note on choosing posix mingw32
2432021-06-02T15:01:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2442021-06-02T15:01:52 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2452021-06-02T15:01:52 <bitcoin-git> [bitcoin] laanwj merged pull request #22088: doc: improve note on choosing posix mingw32 (master...windows-ubuntu-note) https://github.com/bitcoin/bitcoin/pull/22088
2462021-06-02T15:01:53 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2472021-06-02T15:25:15 *** Guest64 <Guest64!~Guest64@184.75.221.35> has quit IRC (Quit: Client closed)
2482021-06-02T15:26:56 *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
2492021-06-02T15:50:51 *** jarthur <jarthur!~jarthur@2603-8080-1540-002d-f5de-bb6e-193b-06d2.res6.spectrum.com> has joined #bitcoin-core-dev
2502021-06-02T15:59:05 *** jonatack <jonatack!jonatack@user/jonatack> has left #bitcoin-core-dev
2512021-06-02T16:18:00 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
2522021-06-02T16:20:59 <hebasto> achow101: meshcollider: how we could get debugging info about wallet load crash in a way safe for users? (context -- #22083)
2532021-06-02T16:21:00 <gribble> https://github.com/bitcoin/bitcoin/issues/22083 | Bitcoin-Qt crashes on OS X · Issue #22083 · bitcoin/bitcoin · GitHub
2542021-06-02T16:25:36 *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f03bc00450477d61102fa6c.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
2552021-06-02T16:28:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2562021-06-02T16:28:57 <bitcoin-git> [bitcoin] theStack opened pull request #22130: test: refactor: dedup utility function chain_transaction() (master...20210601-test-dedup_chain_transaction) https://github.com/bitcoin/bitcoin/pull/22130
2572021-06-02T16:28:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2582021-06-02T16:40:21 *** ksprd2 <ksprd2!~ksprd@212.14.60.132> has quit IRC (Ping timeout: 245 seconds)
2592021-06-02T16:42:59 *** evias <evias!~evias__@user/evias> has quit IRC (Quit: Leaving)
2602021-06-02T16:54:21 <hebasto> laanwj: could you have a look at https://github.com/bitcoin/bitcoin/pull/21654#issuecomment-839428062, please?
2612021-06-02T16:56:54 <achow101> hebasto: the best way would be to get them to be able to replicate the crash on testnet or regtest and then send us the offending wallet file
2622021-06-02T17:01:31 *** lightlike <lightlike!~lightlike@user/lightlike> has joined #bitcoin-core-dev
2632021-06-02T17:13:25 *** b10c <b10c!uid500648@id-500648.charlton.irccloud.com> has joined #bitcoin-core-dev
2642021-06-02T17:16:11 *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has quit IRC (Ping timeout: 245 seconds)
2652021-06-02T17:23:44 *** AaronvanW <AaronvanW!~AaronvanW@12.174.108.202> has joined #bitcoin-core-dev
2662021-06-02T17:23:57 *** AaronvanW <AaronvanW!~AaronvanW@12.174.108.202> has quit IRC (Remote host closed the connection)
2672021-06-02T17:25:42 *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has joined #bitcoin-core-dev
2682021-06-02T17:30:52 *** sagi <sagi!~sagi@bzq-79-178-136-188.red.bezeqint.net> has quit IRC (Ping timeout: 244 seconds)
2692021-06-02T17:43:29 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 272 seconds)
2702021-06-02T17:43:54 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
2712021-06-02T18:08:07 *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has joined #bitcoin-core-dev
2722021-06-02T18:24:10 *** AaronvanW <AaronvanW!~AaronvanW@207.200.214.109> has joined #bitcoin-core-dev
2732021-06-02T18:31:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2742021-06-02T18:31:03 <bitcoin-git> [bitcoin] hebasto opened pull request #22133: build, qt: Make QWindowsVistaStylePlugin available again (regression) (master...210602-style) https://github.com/bitcoin/bitcoin/pull/22133
2752021-06-02T18:31:04 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2762021-06-02T18:37:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2772021-06-02T18:37:50 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1186910b6b7b...2aab8a6dd0b5
2782021-06-02T18:37:50 <bitcoin-git> bitcoin/master 9a09695 Fu Yong Quah: build: Add /opt/homebrew to path to look for boost libraries
2792021-06-02T18:37:50 <bitcoin-git> bitcoin/master 2aab8a6 W. J. van der Laan: Merge bitcoin/bitcoin#21231: Add /opt/homebrew to path to look for boost l...
2802021-06-02T18:37:52 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2812021-06-02T18:38:07 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2822021-06-02T18:38:07 <bitcoin-git> [bitcoin] laanwj merged pull request #21231: Add /opt/homebrew to path to look for boost libraries (master...modify-boost-path-for-m1-macs) https://github.com/bitcoin/bitcoin/pull/21231
2832021-06-02T18:38:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2842021-06-02T18:38:51 *** roconnor_ <roconnor_!~roconnor@host-45-58-218-136.dyn.295.ca> has joined #bitcoin-core-dev
2852021-06-02T18:39:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2862021-06-02T18:39:49 <bitcoin-git> [gui] hebasto closed pull request #322: Improve Overview tab look on Windows (master...210508-frame) https://github.com/bitcoin-core/gui/pull/322
2872021-06-02T18:39:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2882021-06-02T18:41:08 *** roconnor <roconnor!~roconnor@host-184-164-3-109.dyn.295.ca> has quit IRC (Ping timeout: 252 seconds)
2892021-06-02T18:41:58 *** powerjungle <powerjungle!~powerjung@h081217087223.dyn.cm.kabsi.at> has quit IRC (Quit: ZNC - https://znc.in)
2902021-06-02T18:52:59 *** roconnor_ is now known as roconnor
2912021-06-02T19:02:24 *** powerjungle <powerjungle!~powerjung@h081217087223.dyn.cm.kabsi.at> has joined #bitcoin-core-dev
2922021-06-02T19:29:13 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
2932021-06-02T19:57:19 *** smartin <smartin!~Icedove@88.135.18.171> has quit IRC (Quit: smartin)
2942021-06-02T20:23:06 *** b10c <b10c!uid500648@id-500648.charlton.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
2952021-06-02T20:42:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2962021-06-02T20:42:01 <bitcoin-git> [bitcoin] kiminuo opened pull request #22135: CRegTestParams: Use `args` instead of `gArgs`. (master...feature/2021-06-02-chainparams-n-gArgs) https://github.com/bitcoin/bitcoin/pull/22135
2972021-06-02T20:42:02 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2982021-06-02T20:52:59 *** AaronvanW <AaronvanW!~AaronvanW@207.200.214.109> has quit IRC (Remote host closed the connection)
2992021-06-02T21:02:49 *** evias <evias!~evias__@196.red-88-6-131.staticip.rima-tde.net> has joined #bitcoin-core-dev
3002021-06-02T22:43:08 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 252 seconds)
3012021-06-02T22:58:46 *** evias <evias!~evias__@user/evias> has quit IRC (Quit: This computer has gone to sleep)
3022021-06-02T23:07:08 *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
3032021-06-02T23:31:40 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev