12021-06-10T00:16:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
22021-06-10T00:16:41 <bitcoin-git> [bitcoin] theStack opened pull request #22204: doc: remove obsolete `okSafeMode` RPC guideline from developer notes (master...202106-doc-remove_obsolete_okSafeMode_hints) https://github.com/bitcoin/bitcoin/pull/22204
32021-06-10T00:16:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
42021-06-10T00:18:05 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
52021-06-10T00:18:22 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 244 seconds)
62021-06-10T00:20:33 *** Legion <Legion!~Pack@195-154-181-208.rev.poneytelecom.eu> has quit IRC ()
72021-06-10T00:27:19 *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has quit IRC (Quit: aллилѹÑа!)
82021-06-10T01:36:08 *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
92021-06-10T01:41:33 *** evias <evias!~evias__@user/evias> has quit IRC (Quit: This computer has gone to sleep)
102021-06-10T01:45:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
112021-06-10T01:45:39 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/46424e943c0b...92584d29cee3
122021-06-10T01:45:39 <bitcoin-git> bitcoin/master d1d1cc9 Hennadii Stepanov: build, qt: Fix compiling qt package in depends with GCC 11
132021-06-10T01:45:39 <bitcoin-git> bitcoin/master 92584d2 fanquake: Merge bitcoin/bitcoin#22186: build, qt: Fix compiling qt package in depend...
142021-06-10T01:45:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
152021-06-10T01:45:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
162021-06-10T01:45:55 <bitcoin-git> [bitcoin] fanquake merged pull request #22186: build, qt: Fix compiling qt package in depends with GCC 11 (master...210608-limits) https://github.com/bitcoin/bitcoin/pull/22186
172021-06-10T01:45:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
182021-06-10T01:46:58 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
192021-06-10T01:52:11 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 252 seconds)
202021-06-10T02:01:31 *** murch <murch!~murch@user/murch> has quit IRC (Quit: WeeChat 1.9.1)
212021-06-10T02:18:38 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
222021-06-10T02:22:54 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 252 seconds)
232021-06-10T03:05:19 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has quit IRC (Remote host closed the connection)
242021-06-10T03:10:31 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has joined #bitcoin-core-dev
252021-06-10T03:10:31 *** ChanServ sets mode: +o gribble
262021-06-10T03:43:21 *** dermoth <dermoth!~dermoth@dsl-66-36-157-80.mtl.aei.ca> has quit IRC (Quit: Leaving)
272021-06-10T03:43:31 *** dermoth <dermoth!~dermoth@dsl-66-36-157-80.mtl.aei.ca> has joined #bitcoin-core-dev
282021-06-10T03:43:35 *** earnestly <earnestly!~earnest@user/earnestly> has quit IRC (Quit: WeeChat 3.1)
292021-06-10T04:19:29 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
302021-06-10T04:23:47 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 244 seconds)
312021-06-10T04:29:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
322021-06-10T04:29:00 <bitcoin-git> [bitcoin] brownit89 opened pull request #22205: Condensed bitcoin core integration/staging tree (master...master) https://github.com/bitcoin/bitcoin/pull/22205
332021-06-10T04:29:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
342021-06-10T04:29:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
352021-06-10T04:29:38 <bitcoin-git> [bitcoin] fanquake closed pull request #22205: Condensed bitcoin core integration/staging tree (master...master) https://github.com/bitcoin/bitcoin/pull/22205
362021-06-10T04:29:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
372021-06-10T04:29:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
382021-06-10T04:29:57 <bitcoin-git> [bitcoin] fanquake reopened pull request #22205: Condensed bitcoin core integration/staging tree (master...master) https://github.com/bitcoin/bitcoin/pull/22205
392021-06-10T04:29:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
402021-06-10T04:33:24 *** belcher_ <belcher_!~belcher@user/belcher> has joined #bitcoin-core-dev
412021-06-10T04:37:07 *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 268 seconds)
422021-06-10T04:47:10 *** tutwidi[m] <tutwidi[m]!~tutwidima@2001:470:69fc:105::ead> has quit IRC (Read error: Connection reset by peer)
432021-06-10T04:47:11 *** dongcarl[m] <dongcarl[m]!~dongcarlm@2001:470:69fc:105::82> has quit IRC (Write error: Connection reset by peer)
442021-06-10T04:47:11 *** vincenzopalazzo <vincenzopalazzo!~vincenzop@2001:470:69fc:105::a67> has quit IRC (Read error: Connection reset by peer)
452021-06-10T04:47:11 *** devrandom <devrandom!~devrandom@2001:470:69fc:105::d4d> has quit IRC (Remote host closed the connection)
462021-06-10T04:47:11 *** kvaciral[m] <kvaciral[m]!~kvaciralx@2001:470:69fc:105::17b> has quit IRC (Read error: Connection reset by peer)
472021-06-10T04:47:11 *** mrjumper[m] <mrjumper[m]!~mr-jumper@2001:470:69fc:105::7f1> has quit IRC (Read error: Connection reset by peer)
482021-06-10T04:47:11 *** prusnak[m] <prusnak[m]!~stickmatr@2001:470:69fc:105::98c> has quit IRC (Read error: Connection reset by peer)
492021-06-10T04:47:11 *** orionwl[m] <orionwl[m]!~orionwlx0@2001:470:69fc:105::80> has quit IRC (Remote host closed the connection)
502021-06-10T04:47:45 *** orionwl[m] <orionwl[m]!~orionwlx0@2001:470:69fc:105::80> has joined #bitcoin-core-dev
512021-06-10T04:48:32 *** devrandom <devrandom!~devrandom@2001:470:69fc:105::d4d> has joined #bitcoin-core-dev
522021-06-10T04:48:32 *** vincenzopalazzo <vincenzopalazzo!~vincenzop@2001:470:69fc:105::a67> has joined #bitcoin-core-dev
532021-06-10T04:48:32 *** prusnak[m] <prusnak[m]!~stickmatr@2001:470:69fc:105::98c> has joined #bitcoin-core-dev
542021-06-10T04:48:43 *** dongcarl[m] <dongcarl[m]!~dongcarlm@2001:470:69fc:105::82> has joined #bitcoin-core-dev
552021-06-10T04:48:43 *** mrjumper[m] <mrjumper[m]!~mr-jumper@2001:470:69fc:105::7f1> has joined #bitcoin-core-dev
562021-06-10T04:48:43 *** tutwidi[m] <tutwidi[m]!~tutwidima@2001:470:69fc:105::ead> has joined #bitcoin-core-dev
572021-06-10T04:48:44 *** kvaciral[m] <kvaciral[m]!~kvaciralx@2001:470:69fc:105::17b> has joined #bitcoin-core-dev
582021-06-10T05:04:08 *** _dvd <_dvd!~dvd@nat-pool-rdu-t.redhat.com> has joined #bitcoin-core-dev
592021-06-10T05:05:43 *** dvd <dvd!~dvd@nat-pool-rdu-t.redhat.com> has quit IRC (Ping timeout: 272 seconds)
602021-06-10T05:05:44 *** _dvd is now known as dvd
612021-06-10T05:34:34 *** TallTim <TallTim!~TallTim@184-83-248-206-dynamic.midco.net> has quit IRC (Ping timeout: 244 seconds)
622021-06-10T05:40:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
632021-06-10T05:40:08 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/92584d29cee3...356f421fb0bb
642021-06-10T05:40:08 <bitcoin-git> bitcoin/master 6780a09 Sebastian Falbesoner: doc: remove obsolete `okSafeMode` RPC guideline from developer notes
652021-06-10T05:40:08 <bitcoin-git> bitcoin/master 356f421 MarcoFalke: Merge bitcoin/bitcoin#22204: doc: remove obsolete `okSafeMode` RPC guideli...
662021-06-10T05:40:10 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
672021-06-10T05:40:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
682021-06-10T05:40:25 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22204: doc: remove obsolete `okSafeMode` RPC guideline from developer notes (master...202106-doc-remove_obsolete_okSafeMode_hints) https://github.com/bitcoin/bitcoin/pull/22204
692021-06-10T05:40:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
702021-06-10T06:20:22 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
712021-06-10T06:25:31 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 272 seconds)
722021-06-10T06:30:38 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
732021-06-10T07:05:03 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
742021-06-10T07:15:01 *** Alina-malina <Alina-malina!~Alina-mal@user/alina-malina> has joined #bitcoin-core-dev
752021-06-10T07:25:41 *** goatpig <goatpig!~goat@h-94-254-2-155.A498.priv.bahnhof.se> has quit IRC (Quit: Konversation terminated!)
762021-06-10T07:26:08 *** jespada <jespada!~jespada@90.254.242.55> has quit IRC (Ping timeout: 264 seconds)
772021-06-10T07:28:39 *** jespada <jespada!~jespada@90.254.242.55> has joined #bitcoin-core-dev
782021-06-10T07:34:30 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 272 seconds)
792021-06-10T07:35:50 *** evias <evias!~evias__@196.red-88-6-131.staticip.rima-tde.net> has joined #bitcoin-core-dev
802021-06-10T07:49:46 *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f03bc005f84d6bcc9a14b60.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
812021-06-10T08:05:27 <fanquake> wumpus / sipa: can you block https://github.com/www-myetherwallet-com from the bitcoin-core and bitcoin orgs
822021-06-10T08:07:14 *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has joined #bitcoin-core-dev
832021-06-10T08:54:52 <laanwj> fanquake: done
842021-06-10T09:00:24 *** sagi <sagi!~sagi@bzq-79-183-156-48.red.bezeqint.net> has joined #bitcoin-core-dev
852021-06-10T09:00:44 <Alina-malina> does anyone have a guide on step by step how to create my own crypto coin very similiar to bitcoin? lol
862021-06-10T09:02:53 <laanwj> Alina-malina: off topic here, this channel is about bitcoin development, not altcoin development
872021-06-10T09:03:20 <Alina-malina> i never say altcoin, i need to run my own bitcoin core but with my own blockchain, not sure how to do though
882021-06-10T09:05:26 <laanwj> in any case the question is too aspecific
892021-06-10T09:07:13 *** davterra <davterra!~davterra@178.128.106.205> has quit IRC (Ping timeout: 268 seconds)
902021-06-10T09:10:14 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
912021-06-10T09:10:14 <bitcoin-git> [bitcoin] practicalswift opened pull request #22208: Update `REVIEWERS` (master...drahtbot-2021-06) https://github.com/bitcoin/bitcoin/pull/22208
922021-06-10T09:10:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
932021-06-10T09:18:09 *** belcher_ is now known as belcher
942021-06-10T09:27:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
952021-06-10T09:27:13 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/356f421fb0bb...e87fbee4026b
962021-06-10T09:27:13 <bitcoin-git> bitcoin/master 3636d9b practicalswift: Update REVIEWERS: I've found that I keep track of PRs in need of review wi...
972021-06-10T09:27:13 <bitcoin-git> bitcoin/master e87fbee MarcoFalke: Merge bitcoin/bitcoin#22208: doc: Update `REVIEWERS`
982021-06-10T09:27:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
992021-06-10T09:27:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1002021-06-10T09:27:30 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22208: doc: Update `REVIEWERS` (master...drahtbot-2021-06) https://github.com/bitcoin/bitcoin/pull/22208
1012021-06-10T09:27:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1022021-06-10T09:34:21 <jnewbery> laanwj MarcoFalke fanquake: I think #22141 is ready for merge. Three ACKs
1032021-06-10T09:34:23 <gribble> https://github.com/bitcoin/bitcoin/issues/22141 | net processing: Remove hash and fValidatedHeaders from QueuedBlock by jnewbery · Pull Request #22141 · bitcoin/bitcoin · GitHub
1042021-06-10T09:52:25 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
1052021-06-10T09:55:04 *** Alina-malina <Alina-malina!~Alina-mal@user/alina-malina> has quit IRC (Ping timeout: 245 seconds)
1062021-06-10T09:59:35 <laanwj> jnewbery: will take a look, thanks
1072021-06-10T10:10:33 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has quit IRC (Remote host closed the connection)
1082021-06-10T10:15:18 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has joined #bitcoin-core-dev
1092021-06-10T10:15:18 *** ChanServ sets mode: +o gribble
1102021-06-10T10:45:06 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Remote host closed the connection)
1112021-06-10T10:49:12 <glozow> ditto for #22084 - 3 ACKs, i've added the nits into a followup
1122021-06-10T10:49:14 <gribble> https://github.com/bitcoin/bitcoin/issues/22084 | package testmempoolaccept followups by glozow · Pull Request #22084 · bitcoin/bitcoin · GitHub
1132021-06-10T11:05:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1142021-06-10T11:05:50 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22210: test: Use MiniWallet in test_no_inherited_signaling RBF test (master...2106-testMiniWallet) https://github.com/bitcoin/bitcoin/pull/22210
1152021-06-10T11:05:51 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1162021-06-10T11:10:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1172021-06-10T11:10:25 <bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/e87fbee4026b...ef8f2966ac8e
1182021-06-10T11:10:25 <bitcoin-git> bitcoin/master 6c5f19d glozow: [package] static_assert max package size >= max tx size
1192021-06-10T11:10:25 <bitcoin-git> bitcoin/master 7d91442 glozow: [rpc] reserve space in txns
1202021-06-10T11:10:25 <bitcoin-git> bitcoin/master e8ecc62 glozow: [refactor] comment/naming improvements
1212021-06-10T11:10:27 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1222021-06-10T11:10:42 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1232021-06-10T11:10:42 <bitcoin-git> [bitcoin] fanquake merged pull request #22084: package testmempoolaccept followups (master...20833-followups) https://github.com/bitcoin/bitcoin/pull/22084
1242021-06-10T11:10:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1252021-06-10T11:18:12 *** Alina-malina <Alina-malina!~Alina-mal@user/alina-malina> has joined #bitcoin-core-dev
1262021-06-10T11:22:15 *** smartin <smartin!~Icedove@88.135.18.171> has joined #bitcoin-core-dev
1272021-06-10T11:36:45 *** jespada <jespada!~jespada@90.254.242.55> has quit IRC (Ping timeout: 244 seconds)
1282021-06-10T11:39:00 *** jespada <jespada!~jespada@90.254.242.55> has joined #bitcoin-core-dev
1292021-06-10T11:59:15 *** Guest47 <Guest47!~Guest47@116.75.109.82> has joined #bitcoin-core-dev
1302021-06-10T12:02:18 *** Guest47 <Guest47!~Guest47@116.75.109.82> has quit IRC (Client Quit)
1312021-06-10T12:07:34 *** kabaum <kabaum!~kabaum@h-46-59-13-35.A163.priv.bahnhof.se> has quit IRC (Ping timeout: 252 seconds)
1322021-06-10T12:09:30 *** Bullitje_enable <Bullitje_enable!~Bullit01@042-236-158-163.dynamic.caiway.nl> has joined #bitcoin-core-dev
1332021-06-10T12:09:34 *** Bullitje <Bullitje!~Bullit01@042-236-158-163.dynamic.caiway.nl> has quit IRC (Read error: Connection reset by peer)
1342021-06-10T12:25:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1352021-06-10T12:25:55 <bitcoin-git> [bitcoin] vasild opened pull request #22211: net: relay I2P addresses even if not reachable (by us) (master...i2p_IsRelayable) https://github.com/bitcoin/bitcoin/pull/22211
1362021-06-10T12:25:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1372021-06-10T12:31:11 *** davterra <davterra!~davterra@178.128.106.205> has joined #bitcoin-core-dev
1382021-06-10T12:43:27 *** copumpkin <copumpkin!~woohoo@user/copumpkin> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
1392021-06-10T12:44:17 *** Alina-malina <Alina-malina!~Alina-mal@user/alina-malina> has quit IRC (Ping timeout: 268 seconds)
1402021-06-10T12:46:57 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
1412021-06-10T13:06:45 *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has quit IRC (Quit: Konversation terminated!)
1422021-06-10T13:10:54 *** sagi <sagi!~sagi@bzq-79-183-156-48.red.bezeqint.net> has quit IRC (Ping timeout: 245 seconds)
1432021-06-10T13:16:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1442021-06-10T13:16:18 <bitcoin-git> [bitcoin] amadeuszpawlik opened pull request #22212: Guard `fHavePruned` to avoid potential data race (master...fix_guard_fhavepruned) https://github.com/bitcoin/bitcoin/pull/22212
1452021-06-10T13:16:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1462021-06-10T13:18:49 *** sagi <sagi!~sagi@bzq-79-183-156-48.red.bezeqint.net> has joined #bitcoin-core-dev
1472021-06-10T13:36:01 *** copumpkin <copumpkin!~woohoo@user/copumpkin> has joined #bitcoin-core-dev
1482021-06-10T13:54:59 *** evanlinjin <evanlinjin!~evanlinji@218-35-179-62.cm.dynamic.apol.com.tw> has joined #bitcoin-core-dev
1492021-06-10T14:02:34 *** evanlinjin <evanlinjin!~evanlinji@218-35-179-62.cm.dynamic.apol.com.tw> has quit IRC (Ping timeout: 245 seconds)
1502021-06-10T14:08:34 *** reez <reez!~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net> has joined #bitcoin-core-dev
1512021-06-10T14:24:09 *** Alina-malina <Alina-malina!~Alina-mal@user/alina-malina> has joined #bitcoin-core-dev
1522021-06-10T14:59:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1532021-06-10T14:59:26 <bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/ef8f2966ac8e...1704bbf2263f
1542021-06-10T14:59:26 <bitcoin-git> bitcoin/master 85e058b John Newbery: [net processing] Remove unnecessary hash arg from MarkBlockAsInFlight()
1552021-06-10T14:59:26 <bitcoin-git> bitcoin/master b4e29f2 John Newbery: [net processing] Remove QueuedBlock.fValidatedHeaders
1562021-06-10T14:59:26 <bitcoin-git> bitcoin/master b03de9c John Newbery: [net processing] Remove CNodeState.nBlocksInFlightValidHeaders
1572021-06-10T14:59:28 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1582021-06-10T14:59:45 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1592021-06-10T14:59:45 <bitcoin-git> [bitcoin] laanwj merged pull request #22141: net processing: Remove hash and fValidatedHeaders from QueuedBlock (master...2021-06-blocks-in-flight) https://github.com/bitcoin/bitcoin/pull/22141
1602021-06-10T14:59:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1612021-06-10T15:23:13 *** doubleqp <doubleqp!~doubleqp@162.55.6.42> has joined #bitcoin-core-dev
1622021-06-10T15:37:10 *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f03bc005f84d6bcc9a14b60.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
1632021-06-10T16:08:15 *** Guest50 <Guest50!~Guest50@218.212.21.21> has joined #bitcoin-core-dev
1642021-06-10T16:19:26 *** TallTim <TallTim!~TallTim@184-83-248-206-dynamic.midco.net> has joined #bitcoin-core-dev
1652021-06-10T16:38:20 *** jeremyrubin <jeremyrubin!~jeremyrub@38.32.116.74> has joined #bitcoin-core-dev
1662021-06-10T17:02:29 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
1672021-06-10T17:12:40 *** lightlike <lightlike!~lightlike@user/lightlike> has joined #bitcoin-core-dev
1682021-06-10T17:18:38 <jamesob> you know what would be an awesome attack: if someone did a giant commit that *looked like* a scripted diff, but was slightly off in the headers (like "~BEGIN VERIFY SCRIPT-") and contained some subtle malicious change
1692021-06-10T17:18:46 *** dhruv <dhruv!~dhruv@165.227.49.220> has quit IRC (Remote host closed the connection)
1702021-06-10T17:19:28 <jamesob> would probably get caught but I guess worth keeping in mind
1712021-06-10T17:20:16 <sipa> jamesob: they'd also need to have a commit title that looked bit wasn't quite "scripted-diff:"
1722021-06-10T17:20:46 <jamesob> scripted~diff?
1732021-06-10T17:20:51 *** dhruv <dhruv!~dhruv@165.227.49.220> has joined #bitcoin-core-dev
1742021-06-10T17:21:32 <sipa> scripted diffs need both a marker in the commit title and in the body
1752021-06-10T17:21:42 <sipa> and iirc when it only has one of the two, it fails validation
1762021-06-10T17:21:57 <jamesob> maybe you're proving my point - I wrote "scripted~diff" and not "scripted-diff"!
1772021-06-10T17:22:08 <laanwj> i think it's a good reason (apart from breaking other PRs) to keep the number of all-over-the-tree changes to a lot of files to a minimum, even as scripted diffs
1782021-06-10T17:22:20 <sipa> jamesob: hahaha
1792021-06-10T17:31:42 *** martinus <martinus!~martinus@212095005140.public.telering.at> has quit IRC (Ping timeout: 244 seconds)
1802021-06-10T17:34:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1812021-06-10T17:34:31 <bitcoin-git> [gui] ryanofsky opened pull request #360: gui: Unregister wallet notifications before unloading wallets (master...pr/qtwd) https://github.com/bitcoin-core/gui/pull/360
1822021-06-10T17:34:32 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1832021-06-10T17:37:46 *** Crypt9a2e <Crypt9a2e!~Crypt9a2e@157.51.21.223> has joined #bitcoin-core-dev
1842021-06-10T17:40:10 <jnewbery> I hope that reviewers are reviewing the code changes in scripted diff commits and not just the commit log
1852021-06-10T17:50:20 <MarcoFalke> I could imagine a subtle change like "+" -> "-" easily getting missed in review of a massive scripted diff
1862021-06-10T17:50:32 <MarcoFalke> "scripted~diff"
1872021-06-10T17:51:27 <MarcoFalke> Would be good to run the script locally (or at least check the ci log that it was run)
1882021-06-10T17:58:31 <laanwj> that was my point, kind of, if large scripted diffs are rare then it's more likely people will review them properly, less so if it becomes a run of the mill thing; smaller ones are easy to review anyhow
1892021-06-10T17:59:13 *** mekster <mekster!~mekster@li1564-239.members.linode.com> has joined #bitcoin-core-dev
1902021-06-10T18:00:55 <sipa> often with scripted diffs it's easy to ask yourself what's the worst that can happen if it's not
1912021-06-10T18:01:28 <sipa> e.g. something that renames a variable/function name.. if if's wrong in a non-obvious way it just won't compile
1922021-06-10T18:02:20 <laanwj> right, but the sneaky thing would be to change something else on a line with the variable name change, if there's hundreds something like that is easier to hide
1932021-06-10T18:06:24 <sipa> fair
1942021-06-10T18:06:43 *** Guest50 <Guest50!~Guest50@218.212.21.21> has quit IRC (Quit: Client closed)
1952021-06-10T18:11:48 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 244 seconds)
1962021-06-10T18:46:41 *** reez <reez!~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
1972021-06-10T18:57:54 *** smartin <smartin!~Icedove@88.135.18.171> has quit IRC (Quit: smartin)
1982021-06-10T18:59:03 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
1992021-06-10T19:00:04 <laanwj> #startmeeting
2002021-06-10T19:00:05 <core-meetingbot> Meeting started Thu Jun 10 19:00:04 2021 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
2012021-06-10T19:00:05 <core-meetingbot> Available commands: action commands idea info link nick
2022021-06-10T19:00:11 <laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos
2032021-06-10T19:00:13 <laanwj> nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
2042021-06-10T19:00:13 <hebasto> hi
2052021-06-10T19:00:14 <achow101> hi
2062021-06-10T19:00:15 <jonatack> hi
2072021-06-10T19:00:17 <sipsorcery> hi
2082021-06-10T19:00:33 <meshcollider> hi
2092021-06-10T19:00:34 <laanwj> no proposed meeting topics this week
2102021-06-10T19:00:52 <sipa> hi
2112021-06-10T19:01:02 <laanwj> i guess it makes sense to discuss what would be good to focus review on for the 22.0 feature freeze
2122021-06-10T19:01:22 <laanwj> which is june 15th
2132021-06-10T19:02:29 <sipa> lots of things tagged for 22.0
2142021-06-10T19:02:30 <laanwj> any last minute topics?
2152021-06-10T19:02:31 <sipa> https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+sort%3Aupdated-desc+milestone%3A22.0
2162021-06-10T19:02:54 <meshcollider> There's a few taproot alley PRs that would be very nice to have in
2172021-06-10T19:02:55 <dongcarl> My personal hope is that we can finish the last g_chainman deglobalization bundle and the guix.sigs layout change PR
2182021-06-10T19:02:59 <meshcollider> Wallet*
2192021-06-10T19:03:02 <laanwj> yes, might make sense to untag some
2202021-06-10T19:03:59 <michaelfolkson> hi
2212021-06-10T19:04:24 <sipa> #18722 seems RFM
2222021-06-10T19:04:27 <gribble> https://github.com/bitcoin/bitcoin/issues/18722 | addrman: improve performance by using more suitable containers by vasild · Pull Request #18722 · bitcoin/bitcoin · GitHub
2232021-06-10T19:05:26 <laanwj> dongcarl: tagged both
2242021-06-10T19:05:30 <jeremyrubin> hallo
2252021-06-10T19:05:35 <sipa> #22156 is pretty important to have in i think to avoid footguns
2262021-06-10T19:05:36 <gribble> https://github.com/bitcoin/bitcoin/issues/22156 | Allow tr() import to privkey wallets only when Taproot is active by achow101 · Pull Request #22156 · bitcoin/bitcoin · GitHub
2272021-06-10T19:05:38 <dongcarl> laanwj: Thanks!
2282021-06-10T19:05:50 <jonatack> Am about to push an update to the inbound eviction protection one. I was hoping to get back to the BTC/kvB-to-sat/vB transition in time for the release but that's unfeasible so just concentrating on finishing up https://github.com/bitcoin/bitcoin/pull/21261
2292021-06-10T19:05:58 <laanwj> sipa: seems more like a bugfix than a feature anyhow
2302021-06-10T19:06:31 <jonatack> and then reviewing the other PRs tagged for v22
2312021-06-10T19:06:37 <achow101> I would consider #22156 and #22154 to be bug fixes rather than features, especially if #21365 is merged
2322021-06-10T19:06:38 <gribble> https://github.com/bitcoin/bitcoin/issues/22156 | Allow tr() import to privkey wallets only when Taproot is active by achow101 · Pull Request #22156 · bitcoin/bitcoin · GitHub
2332021-06-10T19:06:39 <gribble> https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
2342021-06-10T19:06:41 <gribble> https://github.com/bitcoin/bitcoin/issues/21365 | Basic Taproot signing support for descriptor wallets by sipa · Pull Request #21365 · bitcoin/bitcoin · GitHub
2352021-06-10T19:08:20 <jonatack> Planning to revew the two PRs fixing the I2P ports issue after FF
2362021-06-10T19:08:35 <sipa> yeah i will also try to go through the 22.0 tag list
2372021-06-10T19:08:54 <laanwj> great!
2382021-06-10T19:10:06 <achow101> #21935 and #18964 are both still drafts, should they still be tagged for 22.0?
2392021-06-10T19:10:08 <gribble> https://github.com/bitcoin/bitcoin/issues/21935 | Enable external signer support for GUI builds, reduce #ifdef by Sjors · Pull Request #21935 · bitcoin/bitcoin · GitHub
2402021-06-10T19:10:09 <gribble> https://github.com/bitcoin/bitcoin/issues/18964 | rpc, wallet: Scan mempool after import* by promag · Pull Request #18964 · bitcoin/bitcoin · GitHub
2412021-06-10T19:10:21 <laanwj> achow101: no, probably not, good point
2422021-06-10T19:10:31 <hebasto> hope 21935 will be in 22.0
2432021-06-10T19:11:09 <laanwj> ah yes sjors' gui PR would be nice to have ein
2442021-06-10T19:11:47 <hebasto> sjors gui4 is already in master
2452021-06-10T19:12:06 <laanwj> oh, good
2462021-06-10T19:13:09 <meshcollider> Yep :)
2472021-06-10T19:13:24 *** Crypt9a2e <Crypt9a2e!~Crypt9a2e@157.51.21.223> has quit IRC (Ping timeout: 268 seconds)
2482021-06-10T19:13:54 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
2492021-06-10T19:14:15 <jonatack> meshcollider: taproot alley sounded good too
2502021-06-10T19:15:04 <sipa> right up my alley
2512021-06-10T19:15:42 <michaelfolkson> With the Taproot descriptor stuff I'm assuming that it is only a standard that could be updated/changed post being included in 22.0
2522021-06-10T19:16:10 <michaelfolkson> The discussion on notation/syntax was interesting
2532021-06-10T19:16:26 <michaelfolkson> It isn't final for 22.0 basically
2542021-06-10T19:16:32 <sipa> ?
2552021-06-10T19:16:42 <achow101> michaelfolkson: I expect it will be mostly final
2562021-06-10T19:16:58 <achow101> as soon as someone includes a tr() descriptor in a wallet, we have to support it ~forever
2572021-06-10T19:16:59 <sipa> features can be added, but if we include it in 22.0, it will be very hard to back out
2582021-06-10T19:17:49 <michaelfolkson> Ok so you are convinced the current notation is preferable sipa? You were convinced by roconnor arguments
2592021-06-10T19:18:05 <sipa> well i changed the PR in response to them!
2602021-06-10T19:18:08 <sipa> so yes
2612021-06-10T19:18:37 <michaelfolkson> Ok just checking that *that* is final ;) Thanks
2622021-06-10T19:19:06 <sipa> it's also already merged, fwiw
2632021-06-10T19:19:32 *** powerjungle <powerjungle!~powerjung@h081217087223.dyn.cm.kabsi.at> has joined #bitcoin-core-dev
2642021-06-10T19:19:33 <michaelfolkson> #21365 isn't?
2652021-06-10T19:19:35 <gribble> https://github.com/bitcoin/bitcoin/issues/21365 | Basic Taproot signing support for descriptor wallets by sipa · Pull Request #21365 · bitcoin/bitcoin · GitHub
2662021-06-10T19:19:52 <sipa> yes but that doesn't change anything w.r.t. the descripotrs
2672021-06-10T19:19:58 <sipa> *descriptors
2682021-06-10T19:20:04 <achow101> michaelfolkson: #22051 implemented the descriptors
2692021-06-10T19:20:07 <gribble> https://github.com/bitcoin/bitcoin/issues/22051 | Basic Taproot derivation support for descriptors by sipa · Pull Request #22051 · bitcoin/bitcoin · GitHub
2702021-06-10T19:20:30 <michaelfolkson> Hmm I'm confused. roconnor's argument was on #22051
2712021-06-10T19:20:33 <gribble> https://github.com/bitcoin/bitcoin/issues/22051 | Basic Taproot derivation support for descriptors by sipa · Pull Request #22051 · bitcoin/bitcoin · GitHub
2722021-06-10T19:20:34 <michaelfolkson> Doesn't matter
2732021-06-10T19:21:11 <michaelfolkson> *on #21365
2742021-06-10T19:21:13 <gribble> https://github.com/bitcoin/bitcoin/issues/21365 | Basic Taproot signing support for descriptor wallets by sipa · Pull Request #21365 · bitcoin/bitcoin · GitHub
2752021-06-10T19:21:50 <meshcollider> michaelfolkson: 22051 was split out of 21365
2762021-06-10T19:22:40 <michaelfolkson> Ah ok, thanks
2772021-06-10T19:23:01 <laanwj> any other topics for today?
2782021-06-10T19:23:48 <laanwj> #endmeeting
2792021-06-10T19:23:49 <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
2802021-06-10T19:23:49 <core-meetingbot> Meeting ended Thu Jun 10 19:23:48 2021 UTC.
2812021-06-10T19:23:49 <core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-06-10-19.00.moin.txt
2822021-06-10T19:33:32 *** evias <evias!~evias__@user/evias> has quit IRC (Quit: This computer has gone to sleep)
2832021-06-10T19:38:04 <MarcoFalke> hi
2842021-06-10T20:04:36 *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has joined #bitcoin-core-dev
2852021-06-10T20:06:31 *** powerjungle <powerjungle!~powerjung@h081217087223.dyn.cm.kabsi.at> has quit IRC (Ping timeout: 272 seconds)
2862021-06-10T20:07:09 *** Alina-malina <Alina-malina!~Alina-mal@user/alina-malina> has quit IRC (Ping timeout: 245 seconds)
2872021-06-10T20:09:20 *** powerjungle <powerjungle!~powerjung@h081217087223.dyn.cm.kabsi.at> has joined #bitcoin-core-dev
2882021-06-10T20:11:50 *** powerjungle <powerjungle!~powerjung@h081217087223.dyn.cm.kabsi.at> has quit IRC (Client Quit)
2892021-06-10T20:35:48 *** reez <reez!~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net> has joined #bitcoin-core-dev
2902021-06-10T20:38:54 *** jeremyrubin <jeremyrubin!~jeremyrub@38.32.116.74> has quit IRC ()
2912021-06-10T20:50:15 *** reez <reez!~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
2922021-06-10T20:52:14 *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Quit: Connection closed)
2932021-06-10T20:53:59 *** jesseposner <jesseposner!~jesse@2601:647:0:89:790f:8501:a950:6a94> has quit IRC (Ping timeout: 252 seconds)
2942021-06-10T21:01:52 *** powerjungle <powerjungle!~powerjung@h081217087223.dyn.cm.kabsi.at> has joined #bitcoin-core-dev
2952021-06-10T21:42:26 *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
2962021-06-10T21:43:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2972021-06-10T21:43:38 <bitcoin-git> [bitcoin] ryanofsky opened pull request #22214: refactor: Rearrange fillPSBT arguments (master...pr/ipc-fill) https://github.com/bitcoin/bitcoin/pull/22214
2982021-06-10T21:43:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2992021-06-10T21:47:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3002021-06-10T21:47:06 <bitcoin-git> [bitcoin] ryanofsky opened pull request #22215: refactor: Add FoundBlock.found member (master...pr/ipc-found) https://github.com/bitcoin/bitcoin/pull/22215
3012021-06-10T21:47:07 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3022021-06-10T22:03:11 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3032021-06-10T22:03:11 <bitcoin-git> [bitcoin] ryanofsky opened pull request #22216: refactor: Make SetupServerArgs callable without NodeContext (master...pr/ipc-sargs) https://github.com/bitcoin/bitcoin/pull/22216
3042021-06-10T22:03:12 *** ratelius <ratelius!ratelius@gateway/vpn/protonvpn/ratelius> has quit IRC (Quit: WeeChat 3.2-rc1)
3052021-06-10T22:03:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3062021-06-10T22:09:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3072021-06-10T22:09:59 <bitcoin-git> [bitcoin] ryanofsky opened pull request #22217: refactor: Avoid wallet code writing node settings file (master...pr/ipc-wset) https://github.com/bitcoin/bitcoin/pull/22217
3082021-06-10T22:09:59 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3092021-06-10T22:12:26 *** poucatreta[m] <poucatreta[m]!~poucatret@2001:470:69fc:105::20ae> has joined #bitcoin-core-dev
3102021-06-10T22:13:24 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3112021-06-10T22:13:24 <bitcoin-git> [bitcoin] ryanofsky opened pull request #22218: multiprocess: Add ipc::Context and ipc::capnp::Context structs (master...pr/ipc-ctx) https://github.com/bitcoin/bitcoin/pull/22218
3122021-06-10T22:13:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3132021-06-10T22:19:16 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3142021-06-10T22:19:17 <bitcoin-git> [bitcoin] ryanofsky opened pull request #22219: multiprocess: Start using init makeNode, makeChain, etc methods (master...pr/ipc-make) https://github.com/bitcoin/bitcoin/pull/22219
3152021-06-10T22:19:18 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3162021-06-10T22:22:01 <sipa> m-m-m-mega pullrequest
3172021-06-10T22:26:48 *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has quit IRC (Quit: aллилѹÑа!)
3182021-06-10T23:08:29 *** evias <evias!~evias__@user/evias> has joined #bitcoin-core-dev
3192021-06-10T23:17:32 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 272 seconds)
3202021-06-10T23:23:34 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
3212021-06-10T23:38:24 *** jespada <jespada!~jespada@90.254.242.55> has quit IRC (Ping timeout: 245 seconds)
3222021-06-10T23:40:56 *** jespada <jespada!~jespada@90.254.242.55> has joined #bitcoin-core-dev
3232021-06-10T23:48:46 *** Bullitje_enable is now known as Bullit
3242021-06-10T23:49:52 *** lightlike <lightlike!~lightlike@user/lightlike> has quit IRC (Quit: Leaving)
3252021-06-10T23:52:00 *** Guest93 <Guest93!~Guest93@unnamed177.orphaned.faa.gov> has joined #bitcoin-core-dev
3262021-06-10T23:58:24 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 245 seconds)