12021-06-18T00:04:54 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
22021-06-18T00:05:20 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
32021-06-18T00:06:37 *** belcher_ <belcher_!~belcher@user/belcher> has joined #bitcoin-core-dev
42021-06-18T00:09:42 *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 244 seconds)
52021-06-18T00:29:03 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 268 seconds)
62021-06-18T00:46:32 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Read error: Connection reset by peer)
72021-06-18T00:47:28 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
82021-06-18T00:47:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
92021-06-18T00:47:46 <bitcoin-git> [bitcoin] sipa opened pull request #22275: A few follow-ups for taproot signing (master...202106_taproot_sign_followup) https://github.com/bitcoin/bitcoin/pull/22275
102021-06-18T00:47:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
112021-06-18T01:32:09 *** Guest45 <Guest45!~Guest45@2804:388:502d:ef7c:8055:59bb:65e0:5637> has joined #bitcoin-core-dev
122021-06-18T01:32:25 *** Guest45 <Guest45!~Guest45@2804:388:502d:ef7c:8055:59bb:65e0:5637> has quit IRC (Client Quit)
132021-06-18T01:32:53 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 244 seconds)
142021-06-18T01:50:41 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
152021-06-18T02:26:16 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
162021-06-18T02:31:42 <fanquake> yea unfortunately it is non-trivial to get into, or out of, Australia the moment
172021-06-18T02:37:42 <sipa> i think that's generally true...
182021-06-18T02:38:01 <sipa> too much water on all sides
192021-06-18T02:38:20 <hebasto> :D
202021-06-18T02:59:02 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 252 seconds)
212021-06-18T03:04:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
222021-06-18T03:04:09 <bitcoin-git> [bitcoin] Nishikoh closed pull request #18838: test: Check header hash in wait_for_getheaders (master...fix-wait_for_getheaders) https://github.com/bitcoin/bitcoin/pull/18838
232021-06-18T03:04:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
242021-06-18T04:04:49 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has quit IRC (Remote host closed the connection)
252021-06-18T04:05:07 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has joined #bitcoin-core-dev
262021-06-18T04:47:12 *** gene <gene!~gene@gateway/tor-sasl/gene> has joined #bitcoin-core-dev
272021-06-18T04:53:51 *** gene <gene!~gene@gateway/tor-sasl/gene> has quit IRC (Quit: gene)
282021-06-18T04:55:53 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
292021-06-18T05:03:16 *** gene <gene!~ferneau.l@b9c17fec.host.njalla.net> has joined #bitcoin-core-dev
302021-06-18T05:10:39 *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has joined #bitcoin-core-dev
312021-06-18T05:16:58 *** gene <gene!~ferneau.l@b9c17fec.host.njalla.net> has quit IRC (Quit: drained and gutted)
322021-06-18T05:17:18 *** gene <gene!~gene@b9c17fec.host.njalla.net> has joined #bitcoin-core-dev
332021-06-18T05:21:04 *** gene <gene!~gene@b9c17fec.host.njalla.net> has quit IRC (Client Quit)
342021-06-18T05:21:20 *** gene <gene!~gene@2a0a:3840:1337:127:0:b9c1:7fec:1337> has joined #bitcoin-core-dev
352021-06-18T05:29:11 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 252 seconds)
362021-06-18T05:40:43 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has quit IRC (Remote host closed the connection)
372021-06-18T05:48:02 *** goatpig <goatpig!~goat@h-94-254-2-155.A498.priv.bahnhof.se> has quit IRC (Quit: Konversation terminated!)
382021-06-18T05:51:32 <amiti> vasild: thanks for your replies, some follow ups-
392021-06-18T05:51:38 <amiti> âI wasn't aware of your work before yesterday. I think late concerns are normal annoyance in software development, not specific to Bitcoin Core or decentralized projects (I worked 10 years in Oracle, I know!). It is annoying, but being late does not make the concerns automatically less valid.â - Iâm not suggesting that being late means the concerns are invalid. I am asking how we can pause to reflect on the disconnect.
402021-06-18T05:51:39 <amiti> Rather than resign ourselves to the idea that this is just the way things are, Iâm asking if we can communicate about how we can improve the way we collaborate as a team.
412021-06-18T05:51:45 <amiti> For example, some things I wonder are - what are your main information streams for learning about ongoing work? (Also applies to the others who said they only recently learned about the work.) Do you usually read meeting logs and missing these ones were an outlier, or are meetings not something you usually pay attention to? My primary methods of communication were via the IRC meetings and the mailing list, so itâs useful
422021-06-18T05:51:45 <amiti> information to know if these arenât reaching the intended audience. I opened the PR and kept it in a draft state as I researched other clients, do you think this impacted your likelihood of noticing the work? Anyway, the point is, there was clearly a disconnect and Iâm interested in understanding how we can learn from it.
432021-06-18T05:51:52 <amiti> vasild: âIn the same way you seem to be unaware of previous attempts to fix the black holdes problem and explicit signaling for address
442021-06-18T05:51:52 <amiti> relay.. [examples]â - hm actually, I have seen these conversations, many of them were shared with me during the irc meetings. I reread them and donât see anything that conflicts with what Iâm proposing, so Iâm not sure why you are making this claim. Please let me know if thereâs something specific you think I am missing.
452021-06-18T05:52:00 <amiti> In regards to the technical concerns of #21528, Iâve responded on the PR in an attempt to keep the conversation a bit cohesive.
462021-06-18T05:52:02 <gribble> https://github.com/bitcoin/bitcoin/issues/21528 | [p2p] Reduce addr blackholes by amitiuttarwar · Pull Request #21528 · bitcoin/bitcoin · GitHub
472021-06-18T06:09:27 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has joined #bitcoin-core-dev
482021-06-18T06:09:58 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has quit IRC (Remote host closed the connection)
492021-06-18T06:16:09 *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has joined #bitcoin-core-dev
502021-06-18T06:31:47 *** chaotic_good <chaotic_good!~chaotic_g@149.28.165.232> has joined #bitcoin-core-dev
512021-06-18T06:33:50 *** evias <evias!~evias__@196.red-88-6-131.staticip.rima-tde.net> has joined #bitcoin-core-dev
522021-06-18T06:40:48 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
532021-06-18T06:47:40 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has joined #bitcoin-core-dev
542021-06-18T06:48:38 *** chrysanthematic <chrysanthematic!~chrysanth@82.2.21.4> has joined #bitcoin-core-dev
552021-06-18T06:58:15 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
562021-06-18T07:07:05 *** chrysanthematic <chrysanthematic!~chrysanth@82.2.21.4> has quit IRC (Quit: chrysanthematic)
572021-06-18T07:14:56 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
582021-06-18T07:15:26 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
592021-06-18T07:16:23 *** bomben <bomben!~benjamin@ip5f5a4754.dynamic.kabel-deutschland.de> has joined #bitcoin-core-dev
602021-06-18T07:17:02 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
612021-06-18T07:17:03 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5c2e2afe990a...ad0c8f356ee8
622021-06-18T07:17:03 <bitcoin-git> bitcoin/master 8f7704d fanquake: build: improve detection of eBPF support
632021-06-18T07:17:03 <bitcoin-git> bitcoin/master ad0c8f3 fanquake: Merge bitcoin/bitcoin#22238: build: improve detection of eBPF support
642021-06-18T07:17:04 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
652021-06-18T07:17:18 *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has quit IRC (Ping timeout: 272 seconds)
662021-06-18T07:17:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
672021-06-18T07:17:20 <bitcoin-git> [bitcoin] fanquake merged pull request #22238: build: improve detection of eBPF support (master...no_probes_darwin_for_now) https://github.com/bitcoin/bitcoin/pull/22238
682021-06-18T07:17:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
692021-06-18T07:17:36 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has quit IRC (Remote host closed the connection)
702021-06-18T07:20:16 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has joined #bitcoin-core-dev
712021-06-18T07:20:17 *** ChanServ sets mode: +o gribble
722021-06-18T07:22:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
732021-06-18T07:22:40 <bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/ad0c8f356ee8...da69d9965a11
742021-06-18T07:22:40 <bitcoin-git> bitcoin/master 8732f7b fanquake: scripts: LIEF 0.11.5
752021-06-18T07:22:40 <bitcoin-git> bitcoin/master 29615ae fanquake: scripts: check minimum required macOS vesion is set
762021-06-18T07:22:40 <bitcoin-git> bitcoin/master c972345 fanquake: scripts: check minimum required Windows version is set
772021-06-18T07:22:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
782021-06-18T07:22:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
792021-06-18T07:22:57 <bitcoin-git> [bitcoin] fanquake merged pull request #21871: scripts: add checks for minimum required OS versions (master...new_tests_on_lief) https://github.com/bitcoin/bitcoin/pull/21871
802021-06-18T07:22:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
812021-06-18T07:23:03 *** belcher_ is now known as belcher
822021-06-18T07:23:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
832021-06-18T07:23:30 <bitcoin-git> [bitcoin] fanquake closed pull request #22142: build: split depends Qt into native and target builds (master...split_qt_again) https://github.com/bitcoin/bitcoin/pull/22142
842021-06-18T07:23:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
852021-06-18T07:27:28 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has quit IRC (Remote host closed the connection)
862021-06-18T07:27:48 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has joined #bitcoin-core-dev
872021-06-18T07:29:07 *** powerjungle <powerjungle!~powerjung@h081217087223.dyn.cm.kabsi.at> has quit IRC (Quit: ZNC - https://znc.in)
882021-06-18T07:29:27 *** major1 <major1!~major@gateway/tor-sasl/major> has quit IRC (Remote host closed the connection)
892021-06-18T07:29:56 *** major1 <major1!~major@gateway/tor-sasl/major> has joined #bitcoin-core-dev
902021-06-18T07:39:32 *** rich- is now known as PaulTroon
912021-06-18T07:42:52 *** PaulTroon is now known as yakshaver
922021-06-18T07:43:42 *** yakshaver is now known as remyers
932021-06-18T07:48:54 *** laanwj <laanwj!~laanwj@user/laanwj> has quit IRC (Read error: Connection reset by peer)
942021-06-18T07:50:31 *** laanwj <laanwj!~laanwj@user/laanwj> has joined #bitcoin-core-dev
952021-06-18T07:50:47 *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f03bc006a84494ddc6e0025.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
962021-06-18T08:08:39 *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has quit IRC (Ping timeout: 244 seconds)
972021-06-18T08:31:54 *** bomben <bomben!~benjamin@ip5f5a4754.dynamic.kabel-deutschland.de> has quit IRC (Ping timeout: 268 seconds)
982021-06-18T08:37:18 *** kabaum <kabaum!~kabaum@host-78-77-216-135.mobileonline.telia.com> has joined #bitcoin-core-dev
992021-06-18T08:39:55 *** smartin <smartin!~Icedove@88.135.18.171> has joined #bitcoin-core-dev
1002021-06-18T08:42:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1012021-06-18T08:42:45 <bitcoin-git> [bitcoin] SpicaLab opened pull request #22276: gui: update text to eliminate safety hazards (0.21...0.21) https://github.com/bitcoin/bitcoin/pull/22276
1022021-06-18T08:42:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1032021-06-18T08:47:11 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1042021-06-18T08:47:12 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22277: test: Properly set BIP34 height in CreateNewBlock_validity unit test (master...2106-test34) https://github.com/bitcoin/bitcoin/pull/22277
1052021-06-18T08:47:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1062021-06-18T08:51:39 <vasild> amiti: Hello! One sure way to bring my attention is to mention my nick on IRC or on github. But I realize that you could not have pinged personally everybody that could be interested. I should read meeting logs, but I dont always do, which is my bad.
1072021-06-18T08:53:02 <vasild> Following everything that is going on would be a near-full time experience, just to keep up to date. I don't do it.
1082021-06-18T08:56:46 <vasild> I said that "you *seem* to be unaware of previous" works because there are no comments from you on those discussion threads. I think it would have helped if you posted a comment on e.g. https://github.com/bitcoin/bitcoin/pull/17194 "this (or similar) problem is addressed by other means in https://github.com/bitcoin/bitcoin/pull/21528"
1092021-06-18T09:00:44 <vasild> gleb: Your input on https://github.com/bitcoin/bitcoin/pull/21528 would be very valuable.
1102021-06-18T09:02:53 *** kexkey_ <kexkey_!~kexkey@static-198-54-132-110.cust.tzulo.com> has joined #bitcoin-core-dev
1112021-06-18T09:03:47 *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Quit: Connection closed)
1122021-06-18T09:04:18 *** kexkey <kexkey!~kexkey@static-198-54-132-142.cust.tzulo.com> has quit IRC (Ping timeout: 240 seconds)
1132021-06-18T09:22:27 *** kabaum <kabaum!~kabaum@host-78-77-216-135.mobileonline.telia.com> has quit IRC (Read error: Connection reset by peer)
1142021-06-18T09:27:34 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has quit IRC (Remote host closed the connection)
1152021-06-18T09:28:23 *** dunxen <dunxen!dunxen@gateway/vpn/protonvpn/dunxen> has joined #bitcoin-core-dev
1162021-06-18T09:29:14 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has joined #bitcoin-core-dev
1172021-06-18T09:29:14 *** ChanServ sets mode: +o gribble
1182021-06-18T09:38:57 *** kabaum <kabaum!~kabaum@host-78-77-216-135.mobileonline.telia.com> has joined #bitcoin-core-dev
1192021-06-18T09:47:44 *** Guest6988 <Guest6988!~Guest69@182.69.199.37> has joined #bitcoin-core-dev
1202021-06-18T09:48:00 *** Guest6988 <Guest6988!~Guest69@182.69.199.37> has left #bitcoin-core-dev
1212021-06-18T09:54:01 *** dunxen <dunxen!dunxen@gateway/vpn/protonvpn/dunxen> has quit IRC (Quit: Leaving...)
1222021-06-18T10:10:00 *** mamilis <mamilis!uid502224@id-502224.tinside.irccloud.com> has joined #bitcoin-core-dev
1232021-06-18T10:11:11 <michaelfolkson> amiti: My two cents. I don't think you could have done any more to ensure everyone was aware of the PR and I can see why you're frustrated. A Bitcoin Core PR review club, bringing it up in P2P meeting(s), bringing it up in Core dev meeting, mailing list post etc
1242021-06-18T10:12:30 <michaelfolkson> Hence I'm surprised anyone who follows Core P2P development wasn't aware of the PR. However, I think this is just an unfortunate circumstance where one specific detail of the PR didn't become obvious until very late
1252021-06-18T10:13:59 <michaelfolkson> I don't think you could have done any more or that the process needs improving. Just hopefully won't happen again with any kind of regularity
1262021-06-18T10:18:50 <michaelfolkson> The vasild suggestion to refer to or post on old related PRs is a good one but a minor improvement on what you've already done
1272021-06-18T10:18:58 <michaelfolkson> (imo)
1282021-06-18T10:20:24 <vasild> +1
1292021-06-18T10:21:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1302021-06-18T10:21:18 <bitcoin-git> [bitcoin] glozow closed pull request #22253: validation: distinguish between same tx and same-nonwitness-data tx in mempool (master...2021-06-same-txid-diff-wtxid) https://github.com/bitcoin/bitcoin/pull/22253
1312021-06-18T10:21:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1322021-06-18T10:23:39 *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has joined #bitcoin-core-dev
1332021-06-18T10:36:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1342021-06-18T10:36:09 <bitcoin-git> [bitcoin] glozow reopened pull request #22253: validation: distinguish between same tx and same-nonwitness-data tx in mempool (master...2021-06-same-txid-diff-wtxid) https://github.com/bitcoin/bitcoin/pull/22253
1352021-06-18T10:36:10 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1362021-06-18T10:42:11 *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
1372021-06-18T10:57:47 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
1382021-06-18T11:11:01 *** emcy <emcy!~emcy@user/emcy> has quit IRC (Quit: Leaving)
1392021-06-18T11:11:07 *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has quit IRC (Ping timeout: 268 seconds)
1402021-06-18T11:12:17 *** Guest2359 <Guest2359!~Guest23@145.40.166.209> has joined #bitcoin-core-dev
1412021-06-18T11:12:42 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has quit IRC (Ping timeout: 240 seconds)
1422021-06-18T11:14:44 *** Guest2359 <Guest2359!~Guest23@145.40.166.209> has quit IRC (Client Quit)
1432021-06-18T11:24:48 *** emcy <emcy!~emcy@user/emcy> has joined #bitcoin-core-dev
1442021-06-18T11:36:46 *** emcy <emcy!~emcy@user/emcy> has quit IRC (Remote host closed the connection)
1452021-06-18T11:45:19 *** emcy <emcy!~emcy@user/emcy> has joined #bitcoin-core-dev
1462021-06-18T11:57:15 *** kabaum <kabaum!~kabaum@host-78-77-216-135.mobileonline.telia.com> has quit IRC (Ping timeout: 268 seconds)
1472021-06-18T12:01:32 *** Pree <Pree!~Pree@43.224.1.253> has joined #bitcoin-core-dev
1482021-06-18T12:13:08 <Pree> Hello everyone myself Preeti Sharma. I'm new to this organization but have a decent knowledge in blockchain domain. While exploring the repo I was quite overwhelmed with the work and want to contribute but need someone to colab with on issues. If anyone up for collaboration or can guide me feel free to connect
1492021-06-18T12:13:09 <Pree> :https://www.linkedin.com/in/preeti-sharma-155a85181/
1502021-06-18T12:17:20 <laanwj> re: #22250 i've had quite a lot of stability issues with i2pd (~monthly segfaults), running git master version now (to get tracebacks) and it hasn't crashed yet, but would be careful to recommend using it
1512021-06-18T12:17:22 <gribble> https://github.com/bitcoin/bitcoin/issues/22250 | doc: add basic I2P documentation by vasild · Pull Request #22250 · bitcoin/bitcoin · GitHub
1522021-06-18T12:17:56 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has quit IRC (Remote host closed the connection)
1532021-06-18T12:18:12 <laanwj> linking only the official client probably makes sense for now
1542021-06-18T12:18:14 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has joined #bitcoin-core-dev
1552021-06-18T12:19:56 *** Alina-malina <Alina-malina!~Alina-mal@user/alina-malina> has joined #bitcoin-core-dev
1562021-06-18T12:25:04 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1572021-06-18T12:25:04 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/da69d9965a11...0844084c13af
1582021-06-18T12:25:04 <bitcoin-git> bitcoin/master 451b96f S3RK: test: kill process group to avoid dangling processes
1592021-06-18T12:25:04 <bitcoin-git> bitcoin/master 0844084 MarcoFalke: Merge bitcoin/bitcoin#22249: test: kill process group to avoid dangling pr...
1602021-06-18T12:25:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1612021-06-18T12:25:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1622021-06-18T12:25:20 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22249: test: kill process group to avoid dangling processes when using `--failfast` (master...test_kill_process_group) https://github.com/bitcoin/bitcoin/pull/22249
1632021-06-18T12:25:21 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1642021-06-18T12:25:54 *** bomben <bomben!~benjamin@ip5f5a4754.dynamic.kabel-deutschland.de> has joined #bitcoin-core-dev
1652021-06-18T12:28:13 *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has joined #bitcoin-core-dev
1662021-06-18T12:37:40 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6981:7880::3> has joined #bitcoin-core-dev
1672021-06-18T12:40:53 <vasild> laanwj: "~monthly segfaults" -- I hope you mean i2pd, not bitcoin core
1682021-06-18T12:41:35 <vasild> https://github.com/PurpleI2P/i2pd/issues/1568 Use after free in SAM
1692021-06-18T12:42:38 <vasild> if you are on freebsd, setting MALLOC_CONF=junk:true,abort:true in the environment helps to get crashes more often :)
1702021-06-18T12:44:31 <vasild> Because on Linux and on FreeBSD without this setting, reading a memory soon after it is free()'d seems to work and get the data which was there before the free(), as if free() did not happen.
1712021-06-18T12:46:30 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1722021-06-18T12:49:44 *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has quit IRC (Ping timeout: 252 seconds)
1732021-06-18T12:50:48 <laanwj> vasild: i2pd
1742021-06-18T12:50:57 <vasild> phew ;)
1752021-06-18T12:51:10 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1762021-06-18T12:51:10 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #19281: test: fix dangling bitcoind in functional tests (master...test_terminate_gracefully) https://github.com/bitcoin/bitcoin/pull/19281
1772021-06-18T12:51:11 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1782021-06-18T12:51:55 <laanwj> vasild: and thanks i'll try that :)
1792021-06-18T12:53:01 <vasild> malloc.conf(3) man has some explanation what those settings do
1802021-06-18T12:54:26 <laanwj> in any case, as long as this issue isn't resolved, we probably shouldn't be recommending it
1812021-06-18T12:54:55 <laanwj> (so I think your document is okay as-is in that regard)
1822021-06-18T12:57:34 *** bomben <bomben!~benjamin@ip5f5a4754.dynamic.kabel-deutschland.de> has quit IRC (Quit: Konversation terminated!)
1832021-06-18T13:06:08 <vasild> I deliberately refrained from recommending any particular i2p router. I have no reason to assume that the java one is better.
1842021-06-18T13:06:29 <laanwj> java at least doesn't have use after free problems
1852021-06-18T13:06:35 <vasild> yes :)
1862021-06-18T13:07:16 <laanwj> but this was in the context of jonatack mentioning a minimal version to use
1872021-06-18T13:07:27 <laanwj> which would make sense in itself
1882021-06-18T13:07:32 <vasild> and also I did not want to turn the bitcoin doc i2p.md into "how to install and configure i2p router", which obviously belongs to that i2p router docs
1892021-06-18T13:07:49 <laanwj> sure
1902021-06-18T13:08:50 <laanwj> though I also think being helpful in things like that can help to get more I2P nodes running
1912021-06-18T13:09:27 <laanwj> unlike tor, i2p is still quite unknown and the existing documentation isn't that great in my experience... not that it means we need to maintain it of course
1922021-06-18T13:30:33 *** goatpig <goatpig!~goat@blocksettle-gw.cust.31173.se> has quit IRC (Quit: Konversation terminated!)
1932021-06-18T13:33:16 *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1942021-06-18T13:34:29 <jonatack> yes, i was thinking of adding a section that describes some issues to be aware of...in the case of i2pd, there are three, maybe four different ones AFAICT
1952021-06-18T13:34:40 <jonatack> can be done later
1962021-06-18T13:35:40 <laanwj> i'm somewhat worried they don't take https://github.com/PurpleI2P/i2pd/issues/1568 more seriously
1972021-06-18T13:36:29 <laanwj> use-after-free can be a serious expoitable issue
1982021-06-18T13:36:32 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 268 seconds)
1992021-06-18T13:37:41 <jonatack> (a) minimum version on debian reported by sdaftuar v2.33 no go, 2.35 ok (b) use after free bug report by vasild, (c) crashes on freebsd seen by laanwj, (d) 2.36 stops working for me after 2-3 bitcoind restarts on debian
2002021-06-18T13:41:10 <laanwj> do I get it right (regarding #20234) that it's not possible to not bind a P2P port at all?
2012021-06-18T13:41:13 <gribble> https://github.com/bitcoin/bitcoin/issues/20234 | net: dont extra bind for Tor if binds are restricted by vasild · Pull Request #20234 · bitcoin/bitcoin · GitHub
2022021-06-18T13:42:10 <laanwj> I'm a bit confused about the assert(connOptions.bind_on_any)
2032021-06-18T13:42:35 <laanwj> if it gets there and there are no binds at all it will crash with an assertion error, so that's supposed to be impossible
2042021-06-18T13:44:28 <provoostenator> Re Core Dev meetup in autumn: good idea. Prague would be nice. Not in North Korea please.
2052021-06-18T13:47:43 <jonatack> iirc connOptions.bind_on_any == true means there are no binds
2062021-06-18T13:48:11 <laanwj> my interpretation is that it means "bind on all interfaces"
2072021-06-18T13:48:30 <jonatack> seems it could use a comment
2082021-06-18T13:48:36 <laanwj> if it means no binds, it's not a good name imo
2092021-06-18T13:48:52 <laanwj> please make it something like bind_on_none
2102021-06-18T13:49:23 <vasild> ah, the Core Dev meeting, if it is in Europe I will most likely attend
2112021-06-18T13:50:00 <vasild> laanwj: I have completely forgotten what that does, neet to refresh my memory... :)
2122021-06-18T13:52:12 <laanwj> bitcoind -nobind -noconnect still works so it must be that I'm misunderstanding the code
2132021-06-18T13:52:19 *** goatpig <goatpig!~goat@h-94-254-2-155.A498.priv.bahnhof.se> has joined #bitcoin-core-dev
2142021-06-18T13:53:00 *** Pree <Pree!~Pree@43.224.1.253> has quit IRC (Quit: Client closed)
2152021-06-18T13:53:08 *** Guest45 <Guest45!~Guest45@177.172.15.104> has joined #bitcoin-core-dev
2162021-06-18T13:53:21 *** Guest45 <Guest45!~Guest45@177.172.15.104> has quit IRC (Client Quit)
2172021-06-18T13:58:58 <laanwj> it does seem bind_on_any is true in that case
2182021-06-18T14:00:16 <laanwj> clearly it is not binding on "any" though :)
2192021-06-18T14:04:45 <laanwj> oh I mixed it up with -nolisten maybe?
2202021-06-18T14:08:17 *** lightlike <lightlike!~lightlike@user/lightlike> has joined #bitcoin-core-dev
2212021-06-18T14:09:11 <laanwj> right: -nobind isn't actually a thing, -nolisten is ... the behavior for -nolisten/listen=0 is different in that things still get added to binds they just don't get actually bound
2222021-06-18T14:09:24 <laanwj> so it works out
2232021-06-18T14:10:12 <laanwj> (albeit the execution flow might be confusing to some people in that case)
2242021-06-18T14:12:38 <jonatack> ah nice (was away responding to ariard's coredev email)
2252021-06-18T14:15:09 <vasild> actually what does -nofoo mean if the foo argument is not a boolean but is supposed to take string arguments? e.g. -foo="askjdh"
2262021-06-18T14:16:43 <laanwj> it used to be that -nofoo is always equivalent to -foo=0 , so -nobind would be -bind=0 which is senseless, but i don't think that is the case anymore? i didn't see any bind arguments passed in
2272021-06-18T14:18:31 <lightlike> there is this user/bot "mostafarahimifard" who goes over PRs and likes every post in them (e.g. in 22261, 22253, 15228 etc.). i guess it's harmless, but distracting.
2282021-06-18T14:19:22 <lightlike> havent seen any actual contribution by them
2292021-06-18T14:19:59 <laanwj> lightlike: thanks, let's see
2302021-06-18T14:20:56 <jonatack> lightlike: laanwj: yes, see my review comments in 20234 for example
2312021-06-18T14:22:09 <laanwj> we have a fan !
2322021-06-18T14:22:28 <jonatack> it's cute :)
2332021-06-18T14:35:39 <jamesob> Reading over old docs... remember when we had things called pcoinsTip and chainActive lol
2342021-06-18T14:37:53 <lightlike> to add to the confusion, the combination "-nobind=0" will get converted to "-bind=1" by the ParameterParser. E.g. "-noconnect=0" results in the node trying to connect to a peer with IP "1".
2352021-06-18T14:38:03 <sipa> haha
2362021-06-18T14:38:30 <laanwj> i've argued in the past that -noXXX shouldn't be allowed to have arguments because it's just confusing
2372021-06-18T14:39:11 <sipa> yeah
2382021-06-18T14:39:32 *** emcy <emcy!~emcy@user/emcy> has quit IRC (Quit: Leaving)
2392021-06-18T14:39:58 <laanwj> i think it was kept out of some backward compatibility concern but i dunno, seems more confusing than is worth it
2402021-06-18T14:40:53 <jonatack> agree. i don't use them. at least on startup the debug log begins by printing the passed config options (thanks larryruane!) and i sometimes look at what it parsed
2412021-06-18T14:41:42 <laanwj> in any case it think the distinction between "what to bind" and "whether to bind at all" makes sense in this case, and is definitely not something that should be changed in #20234, i was just confused for a minute how it could possibly work
2422021-06-18T14:41:50 <gribble> https://github.com/bitcoin/bitcoin/issues/20234 | net: dont extra bind for Tor if binds are restricted by vasild · Pull Request #20234 · bitcoin/bitcoin · GitHub
2432021-06-18T14:42:33 <sipa> are there options where a "0" value is a legitimate input that doesn't usefully mean "absense" ?
2442021-06-18T14:43:17 <laanwj> no ideaa, there are so many options!
2452021-06-18T14:43:42 <jonatack> lightlike: indeed, -noonion=0 -> debug log: "Command-line arg: onion=true"
2462021-06-18T14:46:46 <jonatack> and noconnect=0 -> Command-line arg: connect=true ... Binding RPC on address ::1 port 38332 failed. (no connections at all)
2472021-06-18T14:47:00 <vasild> we should add support for multiple negations, like -nonofoo should mean -foo
2482021-06-18T14:47:16 <laanwj> -nonononononononono
2492021-06-18T14:47:20 <vasild> :-D
2502021-06-18T14:49:30 <sipa> i think we should add a -nonogram=file option that dumps a pixelated image representing your config
2512021-06-18T14:49:39 <laanwj> i think another reason that we've been very loose with that is that option parsing used to be very loose, e.g. as in there didn't even use to be a path for reporting parse errors from downstream, with the new framework it should be possible
2522021-06-18T14:49:42 <sipa> which can of course be disabled using -nogram
2532021-06-18T14:49:54 <laanwj> lol!
2542021-06-18T14:56:56 <vasild> laanwj: "it's not possible to not bind a P2P port at all" -- https://github.com/bitcoin/bitcoin/pull/20234 is not supposed to change this behavior which is - no, you can't specify "don't bind at all" using -bind=... if -bind is not given then we bind on 0.0.0.0, if -bind=foo is given then we bind on foo
2552021-06-18T14:57:10 <laanwj> vasild: I realize this now
2562021-06-18T14:57:12 <vasild> however -listen=0 would achieve that
2572021-06-18T14:58:11 <vasild> I just tried what would happen if I provide invalid arg to bind like -bind=1.2.3.4:1234 and it quit with this useful message: Error: Unable to bind to 1.2.3.4:1234 on this computer (bind returned error Can't assign requested address (49)) ... Failed to listen on any port. Use -listen=0 if you want this.
2582021-06-18T14:58:22 <laanwj> I was right in the sense it's not possible to do that with -bind, but yes, there's -listen for that, so it's fine
2592021-06-18T14:59:06 <vasild> so, is https://github.com/bitcoin/bitcoin/pull/20234 ok? any concerns or comments needed?
2602021-06-18T14:59:12 <laanwj> yes, it's nice that the error reporting works there
2612021-06-18T14:59:15 <vasild> (in this aspect)
2622021-06-18T14:59:43 <laanwj> no, not really
2632021-06-18T15:00:11 <vasild> ok, the logic in that assert is if -bind= is not given then assert we are going to bind on 0.0.0.0 (any)
2642021-06-18T15:00:50 <laanwj> that makes sense, it is true, the interaction with -listen doesn't really matter there i guess
2652021-06-18T15:01:25 <laanwj> if you don't want to listen at all, then listening on tor makes no sense either
2662021-06-18T15:03:29 <vasild> should we use the seeds to establish at least one I2P connection, makes sense if the user has bothered setting up an I2P/SAM proxy? Came from https://github.com/bitcoin/bitcoin/pull/22250#discussion_r654480480
2672021-06-18T15:04:53 <laanwj> vasild: do you mean 'there should always be at least one outgoing I2P connection if the user has set up I2P' (similar for Tor)?
2682021-06-18T15:05:09 <vasild> no actually, it is a broader question: should we try to establish at least one I2P (or Tor) connection if the user has bothered to setup the relevant proxy which includes two things: put the seeds in addrman (I am not sure if they are not put by default?) and then take such an address from addrman and try to connect to it
2692021-06-18T15:05:23 <vasild> yes, this is what I mean
2702021-06-18T15:05:36 <vasild> or well, if there are already incoming ones, then maybe not bother
2712021-06-18T15:05:58 <laanwj> I'm not actually sure about that, maybe from a 'don't become isolated' point of view it makes sense
2722021-06-18T15:06:02 <vasild> laanwj: s/outgoing/ in your comment
2732021-06-18T15:06:06 <vasild> s/outgoing//
2742021-06-18T15:06:31 <laanwj> if you set up all overlay networks then making sure there is a conenction to all of them makes eclipse harder
2752021-06-18T15:06:38 <sipa> i think a "protect at least one peer of each network" is probably less invasive
2762021-06-18T15:06:43 <laanwj> but there might be drawbacks too
2772021-06-18T15:06:45 <laanwj> yes
2782021-06-18T15:07:27 <vasild> sipa: we already protect existent connections (per network), the thing is, if we dont have any (to a given network).
2792021-06-18T15:07:46 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
2802021-06-18T15:07:50 <sipa> yes, i understand the difference
2812021-06-18T15:08:14 <laanwj> vasild: i guess that applies only to the case where the user adds an overlay network later, while not having addresses for them yet
2822021-06-18T15:08:29 <laanwj> which should be relatively rare (except now in the beginning)
2832021-06-18T15:08:33 <vasild> I am not sure either, but it just does not seem right if a user has bothered to setup I2P proxy and configure bitcoin core to use it and to have 0 i2p connections (same for tor)
2842021-06-18T15:09:02 <laanwj> yes, though adding such functionality for 0.22 is going to be too late anyway, is this still a concern by 0.23?
2852021-06-18T15:10:31 <vasild> maybe not, if it always happens to have some tor connections and having 0 connections is only issue for i2p, then we can assume that in the future it will get better and we can do nothing
2862021-06-18T15:10:53 <vasild> was just a random thought
2872021-06-18T15:11:04 <laanwj> but regarding seeding per network, might make sense, i dunno
2882021-06-18T15:11:46 * vasild afk
2892021-06-18T15:12:35 <laanwj> to be clar, 'we have zero I2P peers and want to connect to I2P so connect to the seed nodes for them' (also s/I2P/Tor) sound somewhat sensible to me
2902021-06-18T15:13:08 <laanwj> especially as I2P peers are more likely to know about other I2P peers than general ones
2912021-06-18T15:13:20 <laanwj> it's not a bad idea
2922021-06-18T15:14:07 <jonatack> yes, this reviewer encountered that issue IIUC: https://github.com/bitcoin/bitcoin/pull/22250#issuecomment-861824184
2932021-06-18T15:14:32 <laanwj> what will also be important is to keep our I2P and TOrV3 hardcoded seeds up to date (also a 23.0 issue, for 22.0 we're fine)
2942021-06-18T15:14:33 <jonatack> set it up but then no I2P peers
2952021-06-18T15:14:43 <laanwj> right
2962021-06-18T15:15:47 <jonatack> was planning to (maybe) propose an update to the I2P seeds before -final, as the I2P ones are evolving, a couple seem unreliable and i am seeing more choice)
2972021-06-18T15:16:15 <laanwj> sgtm
2982021-06-18T15:42:15 *** javi404 <javi404!~quassel@pool-173-63-15-246.nwrknj.fios.verizon.net> has joined #bitcoin-core-dev
2992021-06-18T15:51:11 *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f03bc006a84494ddc6e0025.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
3002021-06-18T16:05:47 *** Guest8 <Guest8!~Guest8@fin-vz1.gullo.me> has joined #bitcoin-core-dev
3012021-06-18T16:09:23 *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
3022021-06-18T16:11:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3032021-06-18T16:11:09 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0844084c13af...da1e6d5911f0
3042021-06-18T16:11:09 <bitcoin-git> bitcoin/master 511a5af sanket1729: Fixed inconsistencies between code and comments
3052021-06-18T16:11:09 <bitcoin-git> bitcoin/master 5531119 sanket1729: Added new test for future blocks reacceptance
3062021-06-18T16:11:09 <bitcoin-git> bitcoin/master da1e6d5 MarcoFalke: Merge bitcoin/bitcoin#14604: tests: Add test and refactor feature_block.py...
3072021-06-18T16:11:11 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3082021-06-18T16:11:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3092021-06-18T16:11:25 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #14604: tests: Add test and refactor feature_block.py (master...feature-block-test) https://github.com/bitcoin/bitcoin/pull/14604
3102021-06-18T16:11:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3112021-06-18T16:22:16 *** Guest58 <Guest58!~Guest58@202.78.236.183> has joined #bitcoin-core-dev
3122021-06-18T16:22:34 *** Guest58 <Guest58!~Guest58@202.78.236.183> has quit IRC (Client Quit)
3132021-06-18T16:25:47 *** Guest13 <Guest13!~Guest13@173.208.98.184> has joined #bitcoin-core-dev
3142021-06-18T16:25:56 <Guest13> hi
3152021-06-18T16:26:54 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
3162021-06-18T16:34:56 *** lightlike <lightlike!~lightlike@user/lightlike> has quit IRC (Quit: Leaving)
3172021-06-18T16:39:24 *** evias <evias!~evias__@user/evias> has quit IRC (Quit: This computer has gone to sleep)
3182021-06-18T16:39:53 *** mamilis <mamilis!uid502224@id-502224.tinside.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
3192021-06-18T16:46:04 *** lightlike <lightlike!~lightlike@user/lightlike> has joined #bitcoin-core-dev
3202021-06-18T16:46:58 *** Guest13 <Guest13!~Guest13@173.208.98.184> has quit IRC (Quit: Client closed)
3212021-06-18T16:49:41 *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
3222021-06-18T17:32:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3232021-06-18T17:32:40 <bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/da1e6d5911f0...0f47e01d7d49
3242021-06-18T17:32:40 <bitcoin-git> bitcoin/master 1a45cd2 Anthony Towns: contrib/signet: Fix typos
3252021-06-18T17:32:40 <bitcoin-git> bitcoin/master a383ce5 Anthony Towns: contrib/signet/miner: --grind-cmd is required for calibrate
3262021-06-18T17:32:40 <bitcoin-git> bitcoin/master e665438 Anthony Towns: contrib/signet/miner: Automatic timestamp for first block
3272021-06-18T17:32:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3282021-06-18T17:32:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3292021-06-18T17:32:58 <bitcoin-git> [bitcoin] laanwj merged pull request #20923: signet miner followups (master...202101-signet-tweak) https://github.com/bitcoin/bitcoin/pull/20923
3302021-06-18T17:32:59 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3312021-06-18T17:55:58 *** Guest32 <Guest32!~Guest32@182.69.199.37> has joined #bitcoin-core-dev
3322021-06-18T17:56:44 *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has joined #bitcoin-core-dev
3332021-06-18T18:07:29 *** Guest8 <Guest8!~Guest8@fin-vz1.gullo.me> has quit IRC (Quit: Client closed)
3342021-06-18T18:15:58 *** l3kk0 <l3kk0!~l3kk0@c-73-22-213-40.hsd1.il.comcast.net> has quit IRC (Read error: Connection reset by peer)
3352021-06-18T18:16:11 *** l3kk0 <l3kk0!~l3kk0@TASTYWORKS.ear2.Chicago2.Level3.net> has joined #bitcoin-core-dev
3362021-06-18T18:32:36 *** Guest8 <Guest8!~Guest8@fin-vz1.gullo.me> has joined #bitcoin-core-dev
3372021-06-18T18:33:31 *** Guest8 <Guest8!~Guest8@fin-vz1.gullo.me> has quit IRC (Client Quit)
3382021-06-18T18:36:20 *** emcy <emcy!~emcy@user/emcy> has joined #bitcoin-core-dev
3392021-06-18T18:42:07 *** Aaronvan_ <Aaronvan_!~AaronvanW@45.133.192.68> has joined #bitcoin-core-dev
3402021-06-18T18:45:02 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has quit IRC (Ping timeout: 252 seconds)
3412021-06-18T18:54:58 *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has joined #bitcoin-core-dev
3422021-06-18T18:58:46 *** AaronvanW <AaronvanW!~AaronvanW@71pc74.sshunet.nl> has joined #bitcoin-core-dev
3432021-06-18T19:00:53 <achow101> wallet meeting?
3442021-06-18T19:01:11 <achow101> #startmeeting
3452021-06-18T19:01:11 <core-meetingbot> Meeting started Fri Jun 18 19:01:11 2021 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
3462021-06-18T19:01:11 <core-meetingbot> Available commands: action commands idea info link nick
3472021-06-18T19:01:26 <achow101> #bitcoin-core-dev wallet Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd
3482021-06-18T19:01:27 <achow101> phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
3492021-06-18T19:01:34 <michaelfolkson> hi
3502021-06-18T19:01:49 <cold> hi!
3512021-06-18T19:02:15 <achow101> any meeting topics for today? none that I see in the log
3522021-06-18T19:02:16 *** sagi <sagi!~sagi@bzq-79-180-140-8.red.bezeqint.net> has quit IRC (Ping timeout: 268 seconds)
3532021-06-18T19:02:38 *** Aaronvan_ <Aaronvan_!~AaronvanW@45.133.192.68> has quit IRC (Ping timeout: 252 seconds)
3542021-06-18T19:02:54 <michaelfolkson> #21365 got merged
3552021-06-18T19:02:57 <gribble> https://github.com/bitcoin/bitcoin/issues/21365 | Basic Taproot signing support for descriptor wallets by sipa · Pull Request #21365 · bitcoin/bitcoin · GitHub
3562021-06-18T19:03:14 <michaelfolkson> #22154 still to be merged
3572021-06-18T19:03:16 <gribble> https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
3582021-06-18T19:03:20 <sipa> and #22166
3592021-06-18T19:03:24 <gribble> https://github.com/bitcoin/bitcoin/issues/22166 | Add support for inferring tr() descriptors by sipa · Pull Request #22166 · bitcoin/bitcoin · GitHub
3602021-06-18T19:03:33 <sipa> 22166 is less critical to have for 22.0 i think
3612021-06-18T19:03:50 <achow101> For the 22.0 milstone, wallet PRs are #22166, #22154, #21329, and #19651
3622021-06-18T19:03:52 <gribble> https://github.com/bitcoin/bitcoin/issues/22166 | Add support for inferring tr() descriptors by sipa · Pull Request #22166 · bitcoin/bitcoin · GitHub
3632021-06-18T19:03:53 <gribble> https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
3642021-06-18T19:03:56 <gribble> https://github.com/bitcoin/bitcoin/issues/21329 | descriptor wallet: Cache last hardened xpub and use in normalized descriptors by achow101 · Pull Request #21329 · bitcoin/bitcoin · GitHub
3652021-06-18T19:03:57 <gribble> https://github.com/bitcoin/bitcoin/issues/19651 | wallet: importdescriptors update existing by S3RK · Pull Request #19651 · bitcoin/bitcoin · GitHub
3662021-06-18T19:04:11 <michaelfolkson> They are all included in feature freeze right?
3672021-06-18T19:04:23 <michaelfolkson> I didn't follow when the feature freeze was extended to
3682021-06-18T19:04:36 <achow101> I don't think we gave a hard deadline for feature freeze
3692021-06-18T19:04:39 <sipa> feature freeze is always a bit of a fuzzy concept
3702021-06-18T19:04:57 <sipa> as the boundary between bug and feature isn't always clear either
3712021-06-18T19:05:12 <michaelfolkson> Ok cool
3722021-06-18T19:05:43 <achow101> istm #22154 and #19651 are more bugfix-ish and can be merged after feature freeze
3732021-06-18T19:05:46 <gribble> https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
3742021-06-18T19:05:47 <gribble> https://github.com/bitcoin/bitcoin/issues/19651 | wallet: importdescriptors update existing by S3RK · Pull Request #19651 · bitcoin/bitcoin · GitHub
3752021-06-18T19:06:39 <michaelfolkson> So priority is #22154 it appears
3762021-06-18T19:06:41 <gribble> https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
3772021-06-18T19:07:59 <achow101> I would rather we focus on #22166 and #21329 for feature freeze
3782021-06-18T19:08:02 <gribble> https://github.com/bitcoin/bitcoin/issues/22166 | Add support for inferring tr() descriptors by sipa · Pull Request #22166 · bitcoin/bitcoin · GitHub
3792021-06-18T19:08:04 <gribble> https://github.com/bitcoin/bitcoin/issues/21329 | descriptor wallet: Cache last hardened xpub and use in normalized descriptors by achow101 · Pull Request #21329 · bitcoin/bitcoin · GitHub
3802021-06-18T19:10:00 <achow101> anything else to discuss?
3812021-06-18T19:10:17 <michaelfolkson> Ok and #22275 is pretty small
3822021-06-18T19:10:18 <gribble> https://github.com/bitcoin/bitcoin/issues/22275 | A few follow-ups for taproot signing by sipa · Pull Request #22275 · bitcoin/bitcoin · GitHub
3832021-06-18T19:10:51 <michaelfolkson> Nope, that's it I think
3842021-06-18T19:11:06 <achow101> #endmeeting
3852021-06-18T19:11:06 <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
3862021-06-18T19:11:06 <core-meetingbot> Meeting ended Fri Jun 18 19:11:06 2021 UTC.
3872021-06-18T19:11:06 <core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-06-18-19.01.moin.txt
3882021-06-18T19:15:49 *** chrysanthematic <chrysanthematic!~chrysanth@109.70.150.245> has joined #bitcoin-core-dev
3892021-06-18T19:38:01 *** jespada <jespada!~jespada@90.254.247.46> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
3902021-06-18T19:41:47 *** chrysanthematic <chrysanthematic!~chrysanth@109.70.150.245> has quit IRC (Quit: chrysanthematic)
3912021-06-18T19:47:08 *** kabaum <kabaum!~kabaum@host-78-77-216-135.mobileonline.telia.com> has joined #bitcoin-core-dev
3922021-06-18T19:58:43 *** chrysanthematic <chrysanthematic!~chrysanth@89.38.69.171> has joined #bitcoin-core-dev
3932021-06-18T20:03:24 *** chrysanthematic <chrysanthematic!~chrysanth@user/chrysanthematic> has quit IRC (Quit: chrysanthematic)
3942021-06-18T20:04:22 *** chrysanthematic <chrysanthematic!~chrysanth@user/chrysanthematic> has joined #bitcoin-core-dev
3952021-06-18T20:07:34 *** brcolow <brcolow!~brcolow@ip68-0-136-132.tc.ph.cox.net> has joined #bitcoin-core-dev
3962021-06-18T20:25:01 *** kabaum <kabaum!~kabaum@host-78-77-216-135.mobileonline.telia.com> has quit IRC (Ping timeout: 272 seconds)
3972021-06-18T20:36:02 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3982021-06-18T20:36:02 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22278: Add LIFETIMEBOUND to CScript where needed (master...2106-scriptBound) https://github.com/bitcoin/bitcoin/pull/22278
3992021-06-18T20:36:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4002021-06-18T20:37:15 *** Guest436 <Guest436!~Guest4@2001:1970:539d:6200:35ab:7b5b:70fa:4926> has joined #bitcoin-core-dev
4012021-06-18T20:40:00 *** Guest436 <Guest436!~Guest4@2001:1970:539d:6200:35ab:7b5b:70fa:4926> has quit IRC (Client Quit)
4022021-06-18T20:42:00 *** Guest48 <Guest48!~Guest48@2001:1970:539d:6200:35ab:7b5b:70fa:4926> has joined #bitcoin-core-dev
4032021-06-18T20:42:16 *** Guest48 <Guest48!~Guest48@2001:1970:539d:6200:35ab:7b5b:70fa:4926> has quit IRC (Client Quit)
4042021-06-18T20:59:32 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
4052021-06-18T21:22:56 *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
4062021-06-18T21:28:24 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
4072021-06-18T21:29:56 *** smartin <smartin!~Icedove@88.135.18.171> has quit IRC (Quit: smartin)
4082021-06-18T21:46:35 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
4092021-06-18T21:46:53 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
4102021-06-18T21:47:03 *** l3kk0 <l3kk0!~l3kk0@TASTYWORKS.ear2.Chicago2.Level3.net> has quit IRC (Ping timeout: 244 seconds)
4112021-06-18T21:47:25 *** l3kk0 <l3kk0!~l3kk0@8.6.144.228> has joined #bitcoin-core-dev
4122021-06-18T22:14:32 *** l3kk0 <l3kk0!~l3kk0@8.6.144.228> has quit IRC (Ping timeout: 268 seconds)
4132021-06-18T22:23:06 *** chrysanthematic <chrysanthematic!~chrysanth@user/chrysanthematic> has quit IRC (Ping timeout: 264 seconds)
4142021-06-18T22:32:04 *** lightlike <lightlike!~lightlike@user/lightlike> has quit IRC (Quit: Leaving)
4152021-06-18T22:32:46 *** Guest32 <Guest32!~Guest32@182.69.199.37> has quit IRC (Ping timeout: 250 seconds)
4162021-06-18T22:34:57 *** l3kk0 <l3kk0!~l3kk0@c-73-22-213-40.hsd1.il.comcast.net> has joined #bitcoin-core-dev
4172021-06-18T22:44:40 *** chrysanthematic <chrysanthematic!~chrysanth@user/chrysanthematic> has joined #bitcoin-core-dev
4182021-06-18T23:02:43 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 252 seconds)
4192021-06-18T23:18:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4202021-06-18T23:18:12 <bitcoin-git> [bitcoin] apoelstra opened pull request #22279: fuzz: add missing ECCVerifyHandle to base_encode_decode (master...2021-06--fuzztestix) https://github.com/bitcoin/bitcoin/pull/22279
4212021-06-18T23:18:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4222021-06-18T23:20:22 *** chrysanthematic <chrysanthematic!~chrysanth@user/chrysanthematic> has quit IRC (Quit: chrysanthematic)
4232021-06-18T23:24:26 *** chrysanthematic <chrysanthematic!~chrysanth@user/chrysanthematic> has joined #bitcoin-core-dev
4242021-06-18T23:27:33 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
4252021-06-18T23:32:28 *** major1 <major1!~major@gateway/tor-sasl/major> has quit IRC (Remote host closed the connection)
4262021-06-18T23:32:30 <ariard> glozow: have a look on my last comment in #22252 but also on my mail published today highlighting my thinking and the context we should consider, here https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-June/019084.html
4272021-06-18T23:32:32 <gribble> https://github.com/bitcoin/bitcoin/issues/22252 | policy: Trim Packages when transaction with same txid exists in mempool by glozow · Pull Request #22252 · bitcoin/bitcoin · GitHub
4282021-06-18T23:32:48 *** major1 <major1!~major@gateway/tor-sasl/major> has joined #bitcoin-core-dev
4292021-06-18T23:33:34 <ariard> hope it'll clear up miscommunications among us, and yes we can exchange on it during tuesday's meeting :) (actually quite a resource pointer for it)
4302021-06-18T23:34:06 *** chrysanthematic <chrysanthematic!~chrysanth@user/chrysanthematic> has quit IRC (Ping timeout: 268 seconds)
4312021-06-18T23:34:15 <ariard> it might be a good weekend read for anyone interested by L2 devs making all this noise about the mempool :p
4322021-06-18T23:45:11 *** chrysanthematic <chrysanthematic!~chrysanth@user/chrysanthematic> has joined #bitcoin-core-dev
4332021-06-18T23:50:13 *** chrysanthematic <chrysanthematic!~chrysanth@user/chrysanthematic> has quit IRC (Ping timeout: 272 seconds)