12021-08-23T00:04:25 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
22021-08-23T00:06:52 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
32021-08-23T00:18:12 <robertspigler> I wouldn't use umbrel in production yet https://github.com/getumbrel/umbrel/blob/master/SECURITY.md
42021-08-23T00:59:06 *** michagogo <michagogo!uid14316@user/michagogo> has quit IRC (Quit: Connection closed for inactivity)
52021-08-23T01:01:48 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has quit IRC (Remote host closed the connection)
62021-08-23T01:09:37 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has joined #bitcoin-core-dev
72021-08-23T01:12:23 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
82021-08-23T01:12:56 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
92021-08-23T01:14:10 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has quit IRC (Ping timeout: 240 seconds)
102021-08-23T01:17:28 *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has quit IRC (Ping timeout: 252 seconds)
112021-08-23T01:22:58 *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 252 seconds)
122021-08-23T01:32:41 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has joined #bitcoin-core-dev
132021-08-23T01:34:49 *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
142021-08-23T02:06:25 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has quit IRC (Ping timeout: 248 seconds)
152021-08-23T02:13:45 *** tripleslash <tripleslash!~triplesla@user/tripleslash> has joined #bitcoin-core-dev
162021-08-23T02:36:38 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has joined #bitcoin-core-dev
172021-08-23T02:44:19 *** Yihen <Yihen!~textual@103.138.75.117> has joined #bitcoin-core-dev
182021-08-23T02:44:43 *** Yihen <Yihen!~textual@103.138.75.117> has left #bitcoin-core-dev
192021-08-23T02:44:50 *** Yihen <Yihen!~textual@103.138.75.117> has joined #bitcoin-core-dev
202021-08-23T02:50:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
212021-08-23T02:50:38 <bitcoin-git> [bitcoin] ben-kaufman opened pull request #22775: rpc: Add option to list transactions from oldest to newest in `listtransactions` RPC command (master...listtransactions-set-order) https://github.com/bitcoin/bitcoin/pull/22775
222021-08-23T02:50:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
232021-08-23T03:09:07 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has quit IRC (Ping timeout: 252 seconds)
242021-08-23T03:40:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
252021-08-23T03:40:44 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e9d6eb1b8071...a93e7a442250
262021-08-23T03:40:44 <bitcoin-git> bitcoin/master 2f01903 Pieter Wuille: Avoid temporary vectors/uint256s in VerifyTaprootCommitment
272021-08-23T03:40:44 <bitcoin-git> bitcoin/master a93e7a4 fanquake: Merge bitcoin/bitcoin#22748: refactor: Avoid temporary vectors/uint256s in...
282021-08-23T03:40:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
292021-08-23T03:41:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
302021-08-23T03:41:01 <bitcoin-git> [bitcoin] fanquake merged pull request #22748: refactor: Avoid temporary vectors/uint256s in VerifyTaprootCommitment (master...202108_xonlyspan) https://github.com/bitcoin/bitcoin/pull/22748
312021-08-23T03:41:04 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
322021-08-23T04:00:39 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has joined #bitcoin-core-dev
332021-08-23T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
342021-08-23T04:01:09 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
352021-08-23T04:11:25 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 246 seconds)
362021-08-23T04:13:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
372021-08-23T04:13:35 <bitcoin-git> [bitcoin] kallewoof opened pull request #22776: rpc/wallet: add optional transaction to getbalances (master...202108-getbalances-tx) https://github.com/bitcoin/bitcoin/pull/22776
382021-08-23T04:13:36 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
392021-08-23T04:16:53 *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
402021-08-23T04:26:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
412021-08-23T04:26:15 <bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/a93e7a442250...e826b22da252
422021-08-23T04:26:15 <bitcoin-git> bitcoin/master addb9b5 Pieter Wuille: Improve comments in taproot signing logic
432021-08-23T04:26:15 <bitcoin-git> bitcoin/master c7048aa Pieter Wuille: Simplify SignTransaction precomputation loop
442021-08-23T04:26:15 <bitcoin-git> bitcoin/master d8f4b97 Pieter Wuille: Remove default nHashTypeIn arguments to MutableTransactionSignatureCreator...
452021-08-23T04:26:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
462021-08-23T04:26:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
472021-08-23T04:26:31 <bitcoin-git> [bitcoin] fanquake merged pull request #22275: A few follow-ups for taproot signing (master...202106_taproot_sign_followup) https://github.com/bitcoin/bitcoin/pull/22275
482021-08-23T04:26:32 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
492021-08-23T04:34:09 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has quit IRC (Ping timeout: 248 seconds)
502021-08-23T04:35:44 *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
512021-08-23T04:45:33 *** dr_orlovsky <dr_orlovsky!~dr-orlovs@31.14.40.18> has joined #bitcoin-core-dev
522021-08-23T04:45:34 *** fanquake_ <fanquake_!sid369002@user/fanquake> has joined #bitcoin-core-dev
532021-08-23T04:45:35 *** ariard__ <ariard__!~ariard@167.99.46.220> has joined #bitcoin-core-dev
542021-08-23T04:45:35 *** andytosh1 <andytosh1!~apoelstra@s66-183-0-205.bc.hsia.telus.net> has joined #bitcoin-core-dev
552021-08-23T04:45:37 *** ariard <ariard!~ariard@167.99.46.220> has quit IRC (*.net *.split)
562021-08-23T04:45:37 *** andytoshi <andytoshi!~apoelstra@s66-183-0-205.bc.hsia.telus.net> has quit IRC (*.net *.split)
572021-08-23T04:45:37 *** yakshaver <yakshaver!yakshaver@2600:3c00::f03c:92ff:fe8e:dce6> has quit IRC (*.net *.split)
582021-08-23T04:45:37 *** dr-orlovsky <dr-orlovsky!~dr-orlovs@31.14.40.18> has quit IRC (*.net *.split)
592021-08-23T04:45:37 *** gwillen <gwillen!gwillen@user/gwillen> has quit IRC (*.net *.split)
602021-08-23T04:45:37 *** fanquake <fanquake!sid369002@user/fanquake> has quit IRC (*.net *.split)
612021-08-23T04:45:37 *** yakshaver123 <yakshaver123!yakshaver@2600:3c00::f03c:92ff:fe8e:dce6> has joined #bitcoin-core-dev
622021-08-23T04:45:38 *** fanquake_ is now known as fanquake
632021-08-23T04:45:50 *** gwillen1 <gwillen1!gwillen@user/gwillen> has joined #bitcoin-core-dev
642021-08-23T04:47:45 *** stratospher_ <stratospher_!uid514069@id-514069.charlton.irccloud.com> has joined #bitcoin-core-dev
652021-08-23T04:48:50 *** paairs <paairs!~rabidus@user/paairs> has quit IRC (*.net *.split)
662021-08-23T04:48:50 *** chaotic_good_ <chaotic_good_!~chaotic_g@irc.chaoticgood.sh> has quit IRC (*.net *.split)
672021-08-23T04:48:50 *** takinbo <takinbo!~takinbo@user/takinbo> has quit IRC (*.net *.split)
682021-08-23T04:48:50 *** Neojack- <Neojack-!Neojack@pear.bnc4free.com> has quit IRC (*.net *.split)
692021-08-23T04:48:50 *** ravish0007 <ravish0007!~quassel@ec2-65-0-45-121.ap-south-1.compute.amazonaws.com> has quit IRC (*.net *.split)
702021-08-23T04:48:50 *** da2ce7 <da2ce7!~da2ce7@user/da2ce7> has quit IRC (*.net *.split)
712021-08-23T04:49:06 *** ravish0007 <ravish0007!~quassel@ec2-65-0-45-121.ap-south-1.compute.amazonaws.com> has joined #bitcoin-core-dev
722021-08-23T04:49:13 *** chaotic_good <chaotic_good!~chaotic_g@irc.chaoticgood.sh> has joined #bitcoin-core-dev
732021-08-23T04:49:13 *** Neojack <Neojack!Neojack@pear.bnc4free.com> has joined #bitcoin-core-dev
742021-08-23T04:49:26 *** takinbo <takinbo!~takinbo@user/takinbo> has joined #bitcoin-core-dev
752021-08-23T04:54:00 *** paairs <paairs!~rabidus@user/paairs> has joined #bitcoin-core-dev
762021-08-23T04:55:08 *** da2ce7 <da2ce7!~da2ce7@user/da2ce7> has joined #bitcoin-core-dev
772021-08-23T05:11:11 *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has joined #bitcoin-core-dev
782021-08-23T05:25:08 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has joined #bitcoin-core-dev
792021-08-23T05:48:55 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has quit IRC (Ping timeout: 244 seconds)
802021-08-23T05:57:21 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has quit IRC (Ping timeout: 248 seconds)
812021-08-23T06:10:21 *** dr_orlovsky <dr_orlovsky!~dr-orlovs@31.14.40.18> has quit IRC (Quit: ZNC 1.8.0 - https://znc.in)
822021-08-23T06:32:11 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
832021-08-23T06:48:25 *** huskycoding <huskycoding!~huskycodi@2607:fb90:2ed8:d400:f95f:d19:fd65:fc55> has joined #bitcoin-core-dev
842021-08-23T06:48:45 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has joined #bitcoin-core-dev
852021-08-23T06:48:53 *** huskycoding <huskycoding!~huskycodi@2607:fb90:2ed8:d400:f95f:d19:fd65:fc55> has quit IRC (Client Quit)
862021-08-23T07:03:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
872021-08-23T07:03:08 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e826b22da252...58b559fab025
882021-08-23T07:03:08 <bitcoin-git> bitcoin/master a381374 Jadi: net: do not advertise address where nobody is listening
892021-08-23T07:03:08 <bitcoin-git> bitcoin/master 58b559f MarcoFalke: Merge bitcoin/bitcoin#20769: net: fixes #20657 - Advertised address where ...
902021-08-23T07:03:10 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
912021-08-23T07:03:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
922021-08-23T07:03:25 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20769: net: fixes #20657 - Advertised address where nobody is listening (master...fixes-issue-20657) https://github.com/bitcoin/bitcoin/pull/20769
932021-08-23T07:03:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
942021-08-23T07:11:27 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 240 seconds)
952021-08-23T07:22:10 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has quit IRC (Ping timeout: 240 seconds)
962021-08-23T07:31:40 *** johnzwen- <johnzwen-!~johnzweng@zweng.at> has quit IRC (Quit: Leaving...)
972021-08-23T07:32:31 *** johnzweng <johnzweng!~johnzweng@zweng.at> has joined #bitcoin-core-dev
982021-08-23T07:35:36 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
992021-08-23T07:35:36 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/58b559fab025...489beb39842f
1002021-08-23T07:35:36 <bitcoin-git> bitcoin/master a3b559c Shubhankar Gambhir: test: added test for disabled wallet
1012021-08-23T07:35:36 <bitcoin-git> bitcoin/master 489beb3 MarcoFalke: Merge bitcoin/bitcoin#22641: test: Split rpc_signmessage test for disabled...
1022021-08-23T07:35:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1032021-08-23T07:35:53 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1042021-08-23T07:35:53 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22641: test: Split rpc_signmessage test for disabled wallet (master...master) https://github.com/bitcoin/bitcoin/pull/22641
1052021-08-23T07:35:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1062021-08-23T07:39:38 *** babasancheti <babasancheti!~babasanch@43.249.232.30> has joined #bitcoin-core-dev
1072021-08-23T07:47:18 *** SpellChecker <SpellChecker!~SpellChec@gateway/tor-sasl/spellchecker> has quit IRC (Remote host closed the connection)
1082021-08-23T07:51:50 *** SpellChecker <SpellChecker!~SpellChec@gateway/tor-sasl/spellchecker> has joined #bitcoin-core-dev
1092021-08-23T07:52:38 *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f3896001a375f77d20536e4.dip0.t-ipconnect.de> has joined #bitcoin-core-dev
1102021-08-23T08:13:23 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has joined #bitcoin-core-dev
1112021-08-23T08:24:59 *** Henrik <Henrik!~textual@84.212.107.177> has joined #bitcoin-core-dev
1122021-08-23T08:46:00 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has quit IRC (Ping timeout: 250 seconds)
1132021-08-23T09:20:55 *** johnzweng <johnzweng!~johnzweng@zweng.at> has quit IRC (Quit: Leaving...)
1142021-08-23T09:23:50 *** johnzweng <johnzweng!~johnzweng@zweng.at> has joined #bitcoin-core-dev
1152021-08-23T09:37:20 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has joined #bitcoin-core-dev
1162021-08-23T09:50:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1172021-08-23T09:50:19 <bitcoin-git> [bitcoin] jnewbery opened pull request #22777: net processing: don't request tx relay on feeler connections (master...2021-08-feeler-no-frelay) https://github.com/bitcoin/bitcoin/pull/22777
1182021-08-23T09:50:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1192021-08-23T10:01:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1202021-08-23T10:01:19 <bitcoin-git> [bitcoin] glozow closed pull request #22252: policy: Trim Packages when transaction with same txid exists in mempool (master...2021-06-mempool-matches) https://github.com/bitcoin/bitcoin/pull/22252
1212021-08-23T10:01:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1222021-08-23T10:02:38 *** Henrik <Henrik!~textual@84.212.107.177> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
1232021-08-23T10:03:03 *** Henrik <Henrik!~textual@84.212.107.177> has joined #bitcoin-core-dev
1242021-08-23T10:09:47 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has quit IRC (Ping timeout: 240 seconds)
1252021-08-23T10:14:24 *** Henrik <Henrik!~textual@84.212.107.177> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzzâ¦)
1262021-08-23T10:25:21 *** dr-orlovsky <dr-orlovsky!~dr-orlovs@31.14.40.18> has joined #bitcoin-core-dev
1272021-08-23T10:28:45 *** Henrik <Henrik!~textual@84.212.107.177> has joined #bitcoin-core-dev
1282021-08-23T10:48:41 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1292021-08-23T10:48:53 *** kabaum <kabaum!~kabaum@h-46-59-13-35.A163.priv.bahnhof.se> has joined #bitcoin-core-dev
1302021-08-23T10:48:56 *** kabaum_ <kabaum_!~kabaum@h-46-59-13-35.A163.priv.bahnhof.se> has joined #bitcoin-core-dev
1312021-08-23T10:52:40 *** kabaum_ <kabaum_!~kabaum@h-46-59-13-35.A163.priv.bahnhof.se> has left #bitcoin-core-dev
1322021-08-23T10:59:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1332021-08-23T10:59:35 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/489beb39842f...f6f7a12462b3
1342021-08-23T10:59:35 <bitcoin-git> bitcoin/master 6bb5470 nthumann: util: Check if specified config file cannot be opened
1352021-08-23T10:59:35 <bitcoin-git> bitcoin/master 127b460 nthumann: test: Check if specified config file cannot be opened
1362021-08-23T10:59:35 <bitcoin-git> bitcoin/master f6f7a12 MarcoFalke: Merge bitcoin/bitcoin#22622: util: Check if specified config file cannot b...
1372021-08-23T10:59:36 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1382021-08-23T10:59:51 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1392021-08-23T10:59:52 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22622: util: Check if specified config file cannot be opened (master...check_conf_file) https://github.com/bitcoin/bitcoin/pull/22622
1402021-08-23T10:59:53 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1412021-08-23T11:01:36 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has joined #bitcoin-core-dev
1422021-08-23T11:01:58 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 246 seconds)
1432021-08-23T11:02:40 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1442021-08-23T11:22:59 *** babasancheti <babasancheti!~babasanch@43.249.232.30> has quit IRC (Quit: Client closed)
1452021-08-23T11:24:39 *** b10c <b10c!uid500648@id-500648.charlton.irccloud.com> has joined #bitcoin-core-dev
1462021-08-23T11:32:16 <laanwj> robertspigler: good to see at least they're honest about it--a web ui stack imports so many dependencies, through different package managers, etc, it's very hard to minimize the risk of a third-party compromise affecting the software supply chain
1472021-08-23T11:33:06 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
1482021-08-23T11:33:42 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has quit IRC (Ping timeout: 250 seconds)
1492021-08-23T11:34:18 *** vysn <vysn!~vysn@user/vysn> has quit IRC (Remote host closed the connection)
1502021-08-23T11:34:53 <laanwj> qt's dependendency management is delightfully dumb and simple in comparison
1512021-08-23T11:42:03 <fanquake> you're only one npm install away from downloading a malicious left-pad
1522021-08-23T12:04:08 *** Yihen <Yihen!~textual@103.138.75.117> has quit IRC (Remote host closed the connection)
1532021-08-23T12:20:13 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
1542021-08-23T12:20:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1552021-08-23T12:20:34 <bitcoin-git> [bitcoin] jnewbery opened pull request #22778: net processing: Reduce resource usage for inbound block-relay-only connections (master...2021-02-tx-relay-init) https://github.com/bitcoin/bitcoin/pull/22778
1562021-08-23T12:20:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1572021-08-23T12:25:35 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has joined #bitcoin-core-dev
1582021-08-23T12:27:45 *** muhblockchain <muhblockchain!~muhblockc@user/muhblockchain> has quit IRC (Ping timeout: 248 seconds)
1592021-08-23T12:31:24 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 244 seconds)
1602021-08-23T12:34:23 *** Henrik <Henrik!~textual@84.212.107.177> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzzâ¦)
1612021-08-23T12:43:30 *** Henrik <Henrik!~textual@84.212.107.177> has joined #bitcoin-core-dev
1622021-08-23T12:58:10 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has quit IRC (Ping timeout: 252 seconds)
1632021-08-23T13:08:40 <michaelfolkson> Has anyone in the past tried to add encryption to the RPC interface? Or is there a particular reason why that shouldn't be done?
1642021-08-23T13:09:35 <michaelfolkson> Couldn't find anything from a cursory PR search
1652021-08-23T13:14:49 *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
1662021-08-23T13:14:56 <sipa> there used to be!
1672021-08-23T13:15:04 <sipa> it was deleted because it's pointless complexity
1682021-08-23T13:15:21 <sipa> it's intended for communication with trusted, local software
1692021-08-23T13:15:34 <sipa> there is documentation on how to ssl wrap
1702021-08-23T13:15:36 <sipa> it
1712021-08-23T13:19:29 *** NorrinRadd <NorrinRadd!~username@154.6.20.210> has quit IRC (Ping timeout: 248 seconds)
1722021-08-23T13:35:32 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1732021-08-23T13:35:32 <bitcoin-git> [gui] Saibato opened pull request #407: bugfix: initialize IsHDEnabled correctly. (master...icon_update) https://github.com/bitcoin-core/gui/pull/407
1742021-08-23T13:35:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1752021-08-23T13:41:10 *** AaronvanW <AaronvanW!~AaronvanW@190.150.30.183> has joined #bitcoin-core-dev
1762021-08-23T13:42:39 <michaelfolkson> sipa: Thanks
1772021-08-23T13:48:23 *** Randolf <Randolf!~randolf@184.70.10.188> has joined #bitcoin-core-dev
1782021-08-23T13:57:36 *** videre_e <videre_e!~videre_e@159.242.234.75> has joined #bitcoin-core-dev
1792021-08-23T13:58:07 <videre_e> is it possible to do mining bitcoins on a nvidia card?
1802021-08-23T13:59:25 <Randolf> videre_e: This is the development channel. For mining questions, please ask in the #bitcoin-mining channel instead: /join #bitcoin-mining
1812021-08-23T14:00:11 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1822021-08-23T14:01:56 *** Henrik <Henrik!~textual@84.212.107.177> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzzâ¦)
1832021-08-23T14:07:23 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1842021-08-23T14:08:23 *** vnogueira <vnogueira!~vnogueira@user/vnogueira> has joined #bitcoin-core-dev
1852021-08-23T14:08:42 <laanwj> bitcoind's control socket is supposed to be local-only, i wish we'd used a UNIX socket from the beginning (as clightning does)
1862021-08-23T14:09:32 <laanwj> and encryption is pointless when communicating to a local service, the OS can intercept everything anyhow
1872021-08-23T14:12:17 <laanwj> fanquake: unfortunately, rust has the same problem, i guess it's possible to use it without cargo almost everything uses that, it's possible to keep dependencies to a minimum but the indirect dep tree blows up fast
1882021-08-23T14:13:39 <Randolf> Is there a serious interest in adding UNIX sockets support?
1892021-08-23T14:14:19 <Randolf> I do like the idea of using this because it's more efficient -- I find with SMTP server milters that UNIX sockets perform better than TCP/IP connections (even through localhost).
1902021-08-23T14:16:08 <laanwj> i have some ancient PRs where i implemented UNIX socket support, it's easy for RPC at the server side, at the client side it is blocked on a libevent issue in libevent http, which is still not solved upstream
1912021-08-23T14:16:45 <laanwj> so we basically cannot do it, at least in bitcoin-cli, without some really ugly hacks around libevent
1922021-08-23T14:16:55 <Randolf> Yuck.
1932021-08-23T14:17:08 <Randolf> So this seems more like a libevent issue.
1942021-08-23T14:17:15 <laanwj> if you don't care about bitcoin-cli (e.g. use it from python) server-side might be enough thogh
1952021-08-23T14:17:48 <Randolf> Perhaps it should be implemented on the server-side anyway, and then eventually the cli could be fixed over time?
1962021-08-23T14:17:53 <laanwj> yes, i filed a PR to implement the necessary support in libevent but it was never merged
1972021-08-23T14:18:06 <Randolf> Which PR?
1982021-08-23T14:18:13 <laanwj> it's kind of an annoyance for me so i don't really want to go back to it
1992021-08-23T14:18:19 <Randolf> Oh.
2002021-08-23T14:18:24 <Randolf> I'm sorry to hear that.
2012021-08-23T14:18:30 <laanwj> feel free to pick it up ofc
2022021-08-23T14:19:47 <laanwj> https://github.com/libevent/libevent/pull/479 https://github.com/libevent/libevent/issues/907
2032021-08-23T14:20:16 <Randolf> Thanks.
2042021-08-23T14:20:42 <Randolf> I want to follow it, at least. I don't know if I can pick it up though as I'm not a seasoned C/C++ developer yet.
2052021-08-23T14:21:07 <laanwj> i did suggest doing only the server side at the time, but this made it controversial somehow
2062021-08-23T14:21:52 <laanwj> i'm actually really bad at getting my own PRs in open source projects merged
2072021-08-23T14:21:59 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2082021-08-23T14:21:59 <bitcoin-git> [bitcoin] darosior opened pull request #22779: policy: correct (lower) the dust threshold for Taproot outputs (master...taproot_dust_limit) https://github.com/bitcoin/bitcoin/pull/22779
2092021-08-23T14:22:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2102021-08-23T14:28:25 <laanwj> another reason why i wish we had used it from the beginning because in that case, support for UNIX sockets in the HTTP lib would have been a hard requirement so we'd never have chosen libevent's in the first place-
2112021-08-23T14:28:27 <sipa> iirc, my suggestion at the time was just dropping libevent for bitcoin-cli, as bitcoind-compatible-httpd should be very simple to implement by hand :)
2122021-08-23T14:29:24 <sipa> of course, suggestions are easy if you don't follow up with code
2132021-08-23T14:30:14 <laanwj> i dread getting into implementing a HTTP client, it sounds easy in theory but also i have enough experience with the avalanche of inadvertent complexity involved in such projects by now
2142021-08-23T14:31:15 *** videre_e <videre_e!~videre_e@159.242.234.75> has left #bitcoin-core-dev (leave!)
2152021-08-23T14:32:08 <Randolf> laanwj: Even with Qt5's libraries that take care of various tedious aspects of the implementation details, it's still hard (so I agree with you).
2162021-08-23T14:32:08 <laanwj> can't we just use libcurl *ducks*
2172021-08-23T14:32:15 * Randolf laughs
2182021-08-23T14:33:39 <sipa> laanwj: a fully compliant HTTP client sounds terrible, but my point is that we don't actually need that, just something that's compatible with bitcoind. but also, i'm not actually volunteering to write this :)
2192021-08-23T14:34:56 <laanwj> sipa: yeah, true, it's just that we now have squashed most of the usability issues in bitcoin-cli (after the libevent switch), that would basically start over
2202021-08-23T14:35:46 <laanwj> most actual work will subtle things like error handling, timeouts, etc
2212021-08-23T14:35:56 <laanwj> then again, if someone wants to take this on, i'm not exactly stopping them
2222021-08-23T14:36:14 <Randolf> That doesn't sound like a minor undertaking.
2232021-08-23T14:40:17 <sipa> we could use boost::beast *ducks*
2242021-08-23T14:40:52 <laanwj> it doesn't, and seeing that it's not been picked up after so many years, it probably isn't really that much "serious interest" in it (the original question), just a would-be-nice thing
2252021-08-23T14:41:01 <laanwj> sipa: hah
2262021-08-23T14:46:22 <Randolf> Boost created so many problems for me that I avoid it as if it were the plague -- they keep breaking backward compatibility, and then on some systems it's not possible to run different software that each depend on versions of the Boost libraries that aren't compatible.
2272021-08-23T14:47:04 <sipa> i think our current effort is reducing boost usage to the extent possible to headers-only libraries
2282021-08-23T14:47:23 <sipa> which at least avoid all the runtime build/link/compatibility issues
2292021-08-23T14:47:58 <Randolf> I remember -- I was part of the meetings where that was decided.
2302021-08-23T14:48:58 <Randolf> As I recall, it wasn't a difficult decision.
2312021-08-23T14:50:33 <laanwj> right, the impulse has been to move away from boost, long, long ago it used boost::asio for the RPC socket it was one of the first things
2322021-08-23T14:51:43 <laanwj> there were a lot of stability issues and from what i remember it had a high overhead, there's zero chance of going back to that
2332021-08-23T14:52:46 <laanwj> libevent is good performance-wise but the HTTP library is very, very limited
2342021-08-23T14:54:57 <laanwj> but we deemed it'd be enough for our use for RPC (which is also quite limited)
2352021-08-23T14:56:30 <Randolf> Ah.
2362021-08-23T14:57:43 *** Henrik <Henrik!~textual@84.212.107.177> has joined #bitcoin-core-dev
2372021-08-23T15:04:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2382021-08-23T15:04:23 <bitcoin-git> [gui] MarcoFalke closed pull request #407: bugfix: initialize IsHDEnabled correctly. (master...icon_update) https://github.com/bitcoin-core/gui/pull/407
2392021-08-23T15:04:24 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2402021-08-23T15:15:45 <laanwj> which, everything considered, it mostly also is-we have run into some limitations around streaming data (without buffering it all in memory) and UNIX sockets
2412021-08-23T15:36:41 *** Henrik <Henrik!~textual@84.212.107.177> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzzâ¦)
2422021-08-23T15:49:15 *** Guest65 <Guest65!~Guest65@net-93-144-79-2.cust.vodafonedsl.it> has joined #bitcoin-core-dev
2432021-08-23T15:49:25 *** Randolf <Randolf!~randolf@184.70.10.188> has quit IRC (Quit: Leaving)
2442021-08-23T15:49:36 *** Guest65 <Guest65!~Guest65@net-93-144-79-2.cust.vodafonedsl.it> has quit IRC (Client Quit)
2452021-08-23T16:06:27 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 240 seconds)
2462021-08-23T16:10:52 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
2472021-08-23T16:12:56 *** lkqwejhhgasdjhgn <lkqwejhhgasdjhgn!~kljkljklk@p200300d46f3896001a375f77d20536e4.dip0.t-ipconnect.de> has quit IRC (Quit: Konversation terminated!)
2482021-08-23T16:21:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2492021-08-23T16:21:03 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f6f7a12462b3...dbcb5742c48f
2502021-08-23T16:21:03 <bitcoin-git> bitcoin/master 5d47860 Pieter Wuille: refactor: move CAddress-without-nTime logic to net_processing
2512021-08-23T16:21:03 <bitcoin-git> bitcoin/master 75290ae Pieter Wuille: Drop us=... message in net debug for sending version message
2522021-08-23T16:21:03 <bitcoin-git> bitcoin/master dbcb574 MarcoFalke: Merge bitcoin/bitcoin#20541: Move special CAddress-without-nTime logic to ...
2532021-08-23T16:21:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2542021-08-23T16:21:19 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2552021-08-23T16:21:19 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20541: Move special CAddress-without-nTime logic to net_processing (master...202012_addr_without_time_is_no_addr) https://github.com/bitcoin/bitcoin/pull/20541
2562021-08-23T16:21:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2572021-08-23T16:32:47 <theStack> could one of the maintainers take a look at #22565? with seven ACKs (including one by kallewoof, the original author of the script), this PR should be ripe for merging
2582021-08-23T16:32:50 <gribble> https://github.com/bitcoin/bitcoin/issues/22565 | [script] signets getcoins.py improvements by NikhilBartwal · Pull Request #22565 · bitcoin/bitcoin · GitHub
2592021-08-23T16:54:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2602021-08-23T16:54:43 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22780: doc: Remove incorrect INIT_PROTO_VERSION from nTime comment (master...2108-docFix) https://github.com/bitcoin/bitcoin/pull/22780
2612021-08-23T16:54:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2622021-08-23T17:01:28 *** lightlike <lightlike!~lightlike@user/lightlike> has joined #bitcoin-core-dev
2632021-08-23T17:12:02 <jonatack> 2021-08-23T17:08:07Z [opencon] ADDRMAN CONSISTENCY CHECK FAILED!!! err=-17 bitcoind: ./addrman.h:707: void CAddrMan::Check() const: Assertion `false' failed. Aborted
2642021-08-23T17:12:57 <jonatack> seeing addrman check failures for the first time, since the merge of #20541
2652021-08-23T17:13:00 <gribble> https://github.com/bitcoin/bitcoin/issues/20541 | Move special CAddress-without-nTime logic to net_processing by sipa · Pull Request #20541 · bitcoin/bitcoin · GitHub
2662021-08-23T17:13:36 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2672021-08-23T17:13:36 <bitcoin-git> [bitcoin] Saibato opened pull request #22781: wallet: fix the behavior of IsHDEnabled, return false in case of a blank hd wallet. (master...fix_ishdenabled) https://github.com/bitcoin/bitcoin/pull/22781
2682021-08-23T17:13:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2692021-08-23T17:14:10 <jonatack> maybe it's just my peers.dat or a coincidence
2702021-08-23T17:19:52 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2712021-08-23T17:19:52 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dbcb5742c48f...1bbe289f201c
2722021-08-23T17:19:52 <bitcoin-git> bitcoin/master 1c612b2 NikhilBartwal: [script] Update signet getcoins.py for custom network
2732021-08-23T17:19:52 <bitcoin-git> bitcoin/master b0c8246 NikhilBartwal: Add cleaner errors for unsuccessful faucet transactions
2742021-08-23T17:19:52 <bitcoin-git> bitcoin/master 1bbe289 W. J. van der Laan: Merge bitcoin/bitcoin#22565: [script] signet's getcoins.py improvements
2752021-08-23T17:19:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2762021-08-23T17:20:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2772021-08-23T17:20:09 <bitcoin-git> [bitcoin] laanwj merged pull request #22565: [script] signet's getcoins.py improvements (master...update_signet_getcoins) https://github.com/bitcoin/bitcoin/pull/22565
2782021-08-23T17:20:10 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2792021-08-23T17:26:53 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2802021-08-23T17:26:53 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #22782: Remove unused MaybeSetAddrName (master...2108-noMaybeSetAddrName) https://github.com/bitcoin/bitcoin/pull/22782
2812021-08-23T17:26:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2822021-08-23T17:27:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2832021-08-23T17:27:55 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1bbe289f201c...b1c4a4ed395e
2842021-08-23T17:27:55 <bitcoin-git> bitcoin/master 2b3d8f3 Hennadii Stepanov: qt: Handle new added plurals in bitcoin_en.ts
2852021-08-23T17:27:55 <bitcoin-git> bitcoin/master b1c4a4e W. J. van der Laan: Merge bitcoin-core/gui#406: Handle new added plurals in bitcoin_en.ts
2862021-08-23T17:27:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2872021-08-23T17:28:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2882021-08-23T17:28:12 <bitcoin-git> [gui] laanwj merged pull request #406: Handle new added plurals in bitcoin_en.ts (master...210821-plurals) https://github.com/bitcoin-core/gui/pull/406
2892021-08-23T17:28:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2902021-08-23T17:37:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2912021-08-23T17:37:00 <bitcoin-git> [bitcoin] hebasto opened pull request #22783: build: Cleanup depends build system (master...210823-pkg) https://github.com/bitcoin/bitcoin/pull/22783
2922021-08-23T17:37:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2932021-08-23T17:37:36 <jonatack> hm, i haven't been able to reproduce the issue on the other chain, only on mainnet. but it's the first time the addrman check failed for me (five times out of five restarts) after a couple of months of running it
2942021-08-23T17:37:52 <jonatack> *chains
2952021-08-23T17:40:14 <jonatack> "2021-08-23T17:25:48Z [init] addrman lost 22813 new and 2 tried addresses due to collisions or invalid addresses"
2962021-08-23T17:46:50 <jonatack> it had been about a week since the previous restart
2972021-08-23T17:59:04 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2982021-08-23T17:59:04 <bitcoin-git> [gui] ShaMan239 opened pull request #408: Add missing mnemonics in menu bar options (master...mnemonic-shortcuts) https://github.com/bitcoin-core/gui/pull/408
2992021-08-23T17:59:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3002021-08-23T18:08:07 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 240 seconds)
3012021-08-23T18:18:15 *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
3022021-08-23T18:19:33 <jonatack> ok, addrman check failed again on restart after a fresh recreated peers.dat...will open an issue
3032021-08-23T18:20:42 <sipa> jonatack: by "check failed" do you mean consistency check, or that message about lost addresses above?
3042021-08-23T18:23:15 <jonatack> sipa: both, in succession
3052021-08-23T18:23:53 <jonatack> 2021-08-23T18:12:24Z [init] Bucketing method was updated, re-bucketing addrman entries from disk
3062021-08-23T18:23:53 <jonatack> 2021-08-23T18:12:24Z [init] addrman lost 2216 new and 0 tried addresses due to collisions or invalid addresses
3072021-08-23T18:24:09 <jonatack> 2021-08-23T18:14:06Z [opencon] Addrman checks started: new 10626, tried 16, total 10642
3082021-08-23T18:24:09 <jonatack> 2021-08-23T18:14:06Z [opencon] ADDRMAN CONSISTENCY CHECK FAILED!!! err=-17 bitcoind: ./addrman.h:707: void CAddrMan::Check() const: Assertion `false' failed. Aborted
3092021-08-23T18:24:16 <jonatack> (sorry for all the lines)
3102021-08-23T18:24:18 <sipa> jonatack: what codebase version?
3112021-08-23T18:24:52 <sipa> and it's actually a cleanly created peers.dat, or something from a possibly older version of the codebase?
3122021-08-23T18:26:19 <jonatack> sipa: first with a well-used peers.dat. a couple days ago i noticed that it strangely lost about 30k addresses. then today the check failed. i then renamed the corrupt peers.dat and restarted. all well. i then restarted a few minutes later. re-fail.
3132021-08-23T18:27:09 <jonatack> on current master dbcb5742c48f
3142021-08-23T18:28:19 <MarcoFalke> So it doesn't happen on previous master commits?
3152021-08-23T18:28:45 <jonatack> i was also testing #21879 rebased to master just before. let me reverify that it's not that.
3162021-08-23T18:28:47 <gribble> https://github.com/bitcoin/bitcoin/issues/21879 | Wrap accept() and extend usage of Sock by vasild · Pull Request #21879 · bitcoin/bitcoin · GitHub
3172021-08-23T18:29:20 <jonatack> will rinse and repeat
3182021-08-23T18:31:24 <sipa> jonatack: ok, let me know
3192021-08-23T18:32:51 <jonatack> MarcoFalke: am retrying on master and on, say, f5a406f003a0603251 from saturday
3202021-08-23T18:33:40 *** gleb7 <gleb7!~gleb@178.150.137.228> has quit IRC (Ping timeout: 252 seconds)
3212021-08-23T18:43:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3222021-08-23T18:43:26 <bitcoin-git> [gui] ShaMan239 opened pull request #409: Fix window title of wallet loading window (master...wallet-window-title) https://github.com/bitcoin-core/gui/pull/409
3232021-08-23T18:43:27 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3242021-08-23T18:51:08 *** Henrik <Henrik!~textual@84.212.107.177> has joined #bitcoin-core-dev
3252021-08-23T18:52:39 <jonatack> i've re-reproduced on current master and on saturday, now trying just before the addrman#clear change
3262021-08-23T18:58:23 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3272021-08-23T18:58:23 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b1c4a4ed395e...ec6db8e85838
3282021-08-23T18:58:23 <bitcoin-git> bitcoin/master faa5fa9 MarcoFalke: fuzz: Use LIMITED_WHILE instead of limit_max_ops
3292021-08-23T18:58:23 <bitcoin-git> bitcoin/master ec6db8e MarcoFalke: Merge bitcoin/bitcoin#22769: fuzz: Use LIMITED_WHILE instead of limit_max_...
3302021-08-23T18:58:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3312021-08-23T18:58:39 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3322021-08-23T18:58:39 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #22769: fuzz: Use LIMITED_WHILE instead of limit_max_ops (master...2108-fuzzRefactor) https://github.com/bitcoin/bitcoin/pull/22769
3332021-08-23T18:58:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3342021-08-23T18:58:56 *** gleb7 <gleb7!~gleb@178.150.137.228> has joined #bitcoin-core-dev
3352021-08-23T19:04:19 <jonatack> update: the issue appears to be in one of the addrman#clear commits, e35c4a3 works, 4d2fa97 fails
3362021-08-23T19:08:13 <laanwj> jonatack: great catch!
3372021-08-23T19:12:16 <jonatack> laanwj: thanks! ok the issue begins appearing for me with 181a1207ba "[addrman] Move peers.dat parsing to init.cpp"
3382021-08-23T19:12:58 <laanwj> that's a pure code move-maybe something with initialization order?
3392021-08-23T19:13:34 *** nathanael <nathanael!~nathanael@user/nathanael> has quit IRC (Quit: connection reset by purr)
3402021-08-23T19:15:08 <jonatack> double checking; it's the *second* restart that sees the issue, so it's a bit weird
3412021-08-23T19:16:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3422021-08-23T19:16:00 <bitcoin-git> [gui] hebasto merged pull request #408: Add missing mnemonics in menu bar options (master...mnemonic-shortcuts) https://github.com/bitcoin-core/gui/pull/408
3432021-08-23T19:16:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3442021-08-23T19:16:18 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3452021-08-23T19:16:19 <bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ec6db8e85838...d3203a99d886
3462021-08-23T19:16:19 <bitcoin-git> bitcoin/master 7c33e3a Shashwat: qt: Add missing mnemonics in menu bar options
3472021-08-23T19:16:19 <bitcoin-git> bitcoin/master d3203a9 Hennadii Stepanov: Merge bitcoin-core/gui#408: Add missing mnemonics in menu bar options
3482021-08-23T19:16:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3492021-08-23T19:16:55 <MarcoFalke> jonatack: The crash happens after "Loading P2P addressesâ¦" or later?
3502021-08-23T19:20:05 *** Henrik <Henrik!~textual@84.212.107.177> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzzâ¦)
3512021-08-23T19:20:57 <jonatack> re-reproduced 3 times at that commit.
3522021-08-23T19:21:07 <jonatack> 2021-08-23T19:18:27Z [init] init message: Loading P2P addressesâ¦
3532021-08-23T19:21:07 <jonatack> 2021-08-23T19:18:27Z [init] Bucketing method was updated, re-bucketing addrman entries from disk
3542021-08-23T19:21:08 <jonatack> 2021-08-23T19:18:27Z [init] addrman lost 677 new and 0 tried addresses due to collisions or invalid addresses
3552021-08-23T19:21:08 <jonatack> 2021-08-23T19:18:27Z [init] Addrman checks started: new 5013, tried 8, total 5021
3562021-08-23T19:21:09 <jonatack> 2021-08-23T19:18:27Z [init] Addrman checks completed successfully
3572021-08-23T19:21:09 <jonatack> 2021-08-23T19:18:27Z [init] Loaded 5021 addresses from peers.dat 201m
3582021-08-23T19:21:14 <jonatack> -> the first check passes
3592021-08-23T19:21:17 *** nathanael <nathanael!~nathanael@user/nathanael> has joined #bitcoin-core-dev
3602021-08-23T19:21:28 <MarcoFalke> Oh I found the issue. It is asmap related.
3612021-08-23T19:21:36 <MarcoFalke> jonatack: Are you using asmap?
3622021-08-23T19:21:40 <jonatack> yes
3632021-08-23T19:22:01 <jonatack> the second check fails after addcon thread start / opencon thread start
3642021-08-23T19:22:33 <MarcoFalke> The asmap must be loaded before addrman
3652021-08-23T19:22:56 <jonatack> ah. init order as laanwj suggested
3662021-08-23T19:23:00 <MarcoFalke> 181a1207ba made it load in the wrong order
3672021-08-23T19:24:54 <MarcoFalke> I won't be working on a fix (bed time)
3682021-08-23T19:25:21 <MarcoFalke> Unless it is still unfixed tomorrow, heh
3692021-08-23T19:25:34 <jonatack> makes sense. i'll have a look as i'm now used to reproducing it :D
3702021-08-23T19:29:30 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
3712021-08-23T19:29:59 <jonatack> that explains why i was only seeing it on mainnet, too
3722021-08-23T19:34:18 *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has joined #bitcoin-core-dev
3732021-08-23T19:35:47 <sipa> jonatack: nice catch
3742021-08-23T19:36:07 <sipa> loading asmap after loading addrman would explain it
3752021-08-23T19:36:19 <sipa> both the lost addresses and the consistency check
3762021-08-23T19:48:31 <jnewbery> jonatack: MarcoFalke: good catch. Thank you - I'll work on a fix tomorrow.
3772021-08-23T20:00:31 <jnewbery> I didn't realise that connman was reaching into addrman to modify its internal data after construction. I think the fix is to pass asmap as a parameter to addrman's ctor, set it in the intializer list and make it const.
3782021-08-23T20:01:18 <sipa> that sounds cleaner
3792021-08-23T20:05:05 <jnewbery> Eventually asmap probably shouldn't be part of addrman at all, but that can wait until later
3802021-08-23T20:07:17 <laanwj> while reviewing i noticed the ordering change but didn't realize this interaction was there
3812021-08-23T20:40:58 *** TheCharlatan <TheCharlatan!~drgrid@2a01:4f9:4a:2adc::2> has quit IRC (Ping timeout: 240 seconds)
3822021-08-23T20:41:18 <jonatack> jnewbery: agree, improving separation and less reaching into other class internals will avoid future hard-to-spot issues
3832021-08-23T20:42:03 *** TheCharlatan <TheCharlatan!~drgrid@2a01:4f9:4a:2adc::2> has joined #bitcoin-core-dev
3842021-08-23T20:43:23 <jonatack> a test wouldn't have caught this unless it ran both -asmap and -checkaddrman...best to make the code cleaner
3852021-08-23T21:01:50 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3862021-08-23T21:01:50 <bitcoin-git> [gui] benthecarman opened pull request #410: gui: Uppercase 'bitcoin:' in QR code URI (master...uppercase-uri) https://github.com/bitcoin-core/gui/pull/410
3872021-08-23T21:01:51 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3882021-08-23T21:08:03 *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
3892021-08-23T21:08:48 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Read error: Connection reset by peer)
3902021-08-23T21:08:54 *** Guyver2_ is now known as Guyver2
3912021-08-23T21:20:07 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 240 seconds)
3922021-08-23T21:29:31 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
3932021-08-23T21:47:19 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
3942021-08-23T21:49:15 *** gene <gene!~gene@gateway/tor-sasl/gene> has joined #bitcoin-core-dev
3952021-08-23T22:01:37 *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
3962021-08-23T22:03:51 *** ExEric3 <ExEric3!~exeric3@178.132.3.92> has quit IRC (Read error: Connection reset by peer)
3972021-08-23T22:04:13 *** ExEric3 <ExEric3!~exeric3@178.132.3.92> has joined #bitcoin-core-dev
3982021-08-23T22:38:27 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 240 seconds)
3992021-08-23T22:45:47 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
4002021-08-23T22:54:00 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
4012021-08-23T22:55:40 *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has joined #bitcoin-core-dev
4022021-08-23T23:02:26 *** b10c <b10c!uid500648@id-500648.charlton.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
4032021-08-23T23:03:42 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
4042021-08-23T23:04:06 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
4052021-08-23T23:06:02 *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has quit IRC (Quit: aллилѹÑа!)
4062021-08-23T23:20:07 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 240 seconds)
4072021-08-23T23:27:27 *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 240 seconds)
4082021-08-23T23:27:32 <robertspigler> laanwj: yes, refreshingly honest!
4092021-08-23T23:30:41 *** lightlike <lightlike!~lightlike@user/lightlike> has quit IRC (Quit: Leaving)
4102021-08-23T23:45:20 *** gene <gene!~gene@gateway/tor-sasl/gene> has quit IRC (Quit: gene)