12021-09-20T00:01:49 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
22021-09-20T00:01:56 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
32021-09-20T00:07:48 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
42021-09-20T00:07:55 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
52021-09-20T00:11:55 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
62021-09-20T00:12:02 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
72021-09-20T00:16:54 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
82021-09-20T00:17:01 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
92021-09-20T00:24:04 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
102021-09-20T00:24:12 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
112021-09-20T00:29:10 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
122021-09-20T00:29:17 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
132021-09-20T00:34:45 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
142021-09-20T00:34:53 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
152021-09-20T00:38:53 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
162021-09-20T00:39:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
172021-09-20T00:46:13 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
182021-09-20T00:46:20 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
192021-09-20T00:50:20 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
202021-09-20T00:50:27 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
212021-09-20T00:54:27 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
222021-09-20T00:54:36 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
232021-09-20T00:59:36 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
242021-09-20T00:59:43 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
252021-09-20T01:05:07 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
262021-09-20T01:05:14 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
272021-09-20T01:09:14 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
282021-09-20T01:09:22 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
292021-09-20T01:12:07 *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Ping timeout: 245 seconds)
302021-09-20T01:16:07 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
312021-09-20T01:16:16 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
322021-09-20T01:17:09 *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 265 seconds)
332021-09-20T01:18:59 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
342021-09-20T01:20:03 *** earnestly <earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 265 seconds)
352021-09-20T01:24:02 *** grndslm <grndslm!~grndslm@24-117-77-48.cpe.sparklight.net> has quit IRC (Read error: Connection reset by peer)
362021-09-20T01:29:43 *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
372021-09-20T01:33:43 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
382021-09-20T01:33:51 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
392021-09-20T01:37:51 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
402021-09-20T01:37:58 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
412021-09-20T01:39:05 *** vysn <vysn!~vysn@user/vysn> has quit IRC (Remote host closed the connection)
422021-09-20T01:39:12 *** grndslm <grndslm!~grndslm@24-117-77-48.cpe.sparklight.net> has joined #bitcoin-core-dev
432021-09-20T01:43:58 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
442021-09-20T01:44:05 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
452021-09-20T01:48:05 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
462021-09-20T01:48:13 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
472021-09-20T01:56:05 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
482021-09-20T01:56:12 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
492021-09-20T02:00:12 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
502021-09-20T02:00:20 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
512021-09-20T02:08:12 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
522021-09-20T02:08:19 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
532021-09-20T02:16:45 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
542021-09-20T02:16:54 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
552021-09-20T02:19:01 *** TheRec <TheRec!~toto@user/therec> has quit IRC ()
562021-09-20T02:26:51 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
572021-09-20T02:26:58 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
582021-09-20T02:30:58 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
592021-09-20T02:31:05 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
602021-09-20T02:35:05 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
612021-09-20T02:35:14 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
622021-09-20T02:37:35 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
632021-09-20T02:38:42 *** TheRec <TheRec!~toto@user/therec> has quit IRC (Client Quit)
642021-09-20T02:39:42 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
652021-09-20T02:43:43 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
662021-09-20T02:43:50 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
672021-09-20T02:45:19 *** mersible <mersible!~mersible@92.119.17.211> has quit IRC (Quit: Leaving)
682021-09-20T02:46:07 *** TheRec <TheRec!~toto@user/therec> has quit IRC ()
692021-09-20T02:46:22 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
702021-09-20T02:51:41 *** TheRec <TheRec!~toto@user/therec> has quit IRC ()
712021-09-20T02:51:56 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
722021-09-20T02:54:12 *** TheRec <TheRec!~toto@user/therec> has quit IRC (Client Quit)
732021-09-20T02:54:27 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
742021-09-20T02:55:12 *** TheRec <TheRec!~toto@user/therec> has quit IRC (Client Quit)
752021-09-20T02:55:26 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
762021-09-20T02:58:27 *** TheRec <TheRec!~toto@user/therec> has quit IRC (Client Quit)
772021-09-20T02:58:43 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
782021-09-20T03:03:41 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
792021-09-20T03:03:50 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
802021-09-20T03:06:58 *** TheRec <TheRec!~toto@user/therec> has quit IRC ()
812021-09-20T03:07:18 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
822021-09-20T03:07:32 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
832021-09-20T03:07:32 <bitcoin-git> [bitcoin] fanquake closed pull request #22373: doc: Improve notes on installing WSL on windows 10 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/22373
842021-09-20T03:07:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
852021-09-20T03:10:39 *** TheRec <TheRec!~toto@user/therec> has quit IRC (Client Quit)
862021-09-20T03:10:59 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
872021-09-20T03:15:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
882021-09-20T03:15:07 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
892021-09-20T03:19:07 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
902021-09-20T03:19:14 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
912021-09-20T03:20:26 *** TheRec <TheRec!~toto@user/therec> has quit IRC ()
922021-09-20T03:20:43 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
932021-09-20T03:22:41 *** TheRec <TheRec!~toto@user/therec> has quit IRC (Client Quit)
942021-09-20T03:22:57 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
952021-09-20T03:24:12 *** TheRec <TheRec!~toto@user/therec> has quit IRC (Client Quit)
962021-09-20T03:24:26 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
972021-09-20T03:24:26 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has quit IRC (Client Quit)
982021-09-20T03:24:52 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
992021-09-20T03:24:59 *** TheRec <TheRec!~toto@user/therec> has quit IRC (Client Quit)
1002021-09-20T03:28:45 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
1012021-09-20T03:32:45 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1022021-09-20T03:32:53 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1032021-09-20T03:36:07 *** grndslm <grndslm!~grndslm@24-117-77-48.cpe.sparklight.net> has quit IRC (Quit: Leaving)
1042021-09-20T03:40:07 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1052021-09-20T03:40:15 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1062021-09-20T03:43:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1072021-09-20T03:43:58 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/de2af19dc8e8...2560b6862b40
1082021-09-20T03:43:58 <bitcoin-git> bitcoin/master f58f697 fanquake: doc: remove WSL install instructions and point to upstream
1092021-09-20T03:43:58 <bitcoin-git> bitcoin/master 2560b68 fanquake: Merge bitcoin/bitcoin#23007: doc: remove WSL install instructions and poin...
1102021-09-20T03:44:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1112021-09-20T03:44:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1122021-09-20T03:44:15 <bitcoin-git> [bitcoin] fanquake merged pull request #23007: doc: remove WSL install instructions and point to upstream (master...remove_verbose_WSL_instructions) https://github.com/bitcoin/bitcoin/pull/23007
1132021-09-20T03:44:16 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1142021-09-20T03:48:16 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1152021-09-20T03:48:23 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1162021-09-20T03:56:29 *** grndslm <grndslm!~grndslm@24-117-77-48.cpe.sparklight.net> has joined #bitcoin-core-dev
1172021-09-20T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
1182021-09-20T04:01:08 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
1192021-09-20T04:05:09 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1202021-09-20T04:05:18 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1212021-09-20T04:09:18 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1222021-09-20T04:09:25 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1232021-09-20T04:13:25 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1242021-09-20T04:13:33 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1252021-09-20T04:19:44 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1262021-09-20T04:19:52 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1272021-09-20T04:24:48 *** saranshsharma <saranshsharma!~saranshsh@202.142.70.13> has joined #bitcoin-core-dev
1282021-09-20T04:26:15 *** grndslm <grndslm!~grndslm@24-117-77-48.cpe.sparklight.net> has quit IRC (Quit: Leaving)
1292021-09-20T04:29:22 *** saranshsharma <saranshsharma!~saranshsh@202.142.70.13> has quit IRC (Ping timeout: 260 seconds)
1302021-09-20T04:29:57 *** robertspigler <robertspigler!~robertspi@2001:470:69fc:105::2d53> has quit IRC (*.net *.split)
1312021-09-20T04:29:58 *** cdecker[m] <cdecker[m]!~cdeckerma@2001:470:69fc:105::2e8e> has quit IRC (*.net *.split)
1322021-09-20T04:29:58 *** glix <glix!~glix@user/glix> has quit IRC (*.net *.split)
1332021-09-20T04:29:58 *** sipa <sipa!~pw@user/sipa> has quit IRC (*.net *.split)
1342021-09-20T04:29:58 *** S3RK <S3RK!~S3RK@user/s3rk> has quit IRC (*.net *.split)
1352021-09-20T04:29:58 *** cncr04s <cncr04s!~cncr04s@afxr.net> has quit IRC (*.net *.split)
1362021-09-20T04:30:06 *** S3RK <S3RK!~S3RK@user/s3rk> has joined #bitcoin-core-dev
1372021-09-20T04:30:08 *** sipa <sipa!~pw@user/sipa> has joined #bitcoin-core-dev
1382021-09-20T04:30:21 *** glix <glix!~glix@152.67.8.183> has joined #bitcoin-core-dev
1392021-09-20T04:30:29 *** cncr04s <cncr04s!~cncr04s@afxr.net> has joined #bitcoin-core-dev
1402021-09-20T04:30:51 *** saranshsharma <saranshsharma!~saranshsh@202.142.70.13> has joined #bitcoin-core-dev
1412021-09-20T04:34:56 *** cdecker[m] <cdecker[m]!~cdeckerma@2001:470:69fc:105::2e8e> has joined #bitcoin-core-dev
1422021-09-20T04:37:57 *** robertspigler <robertspigler!~robertspi@2001:470:69fc:105::2d53> has joined #bitcoin-core-dev
1432021-09-20T04:41:38 *** ajonas <ajonas!sid385278@id-385278.helmsley.irccloud.com> has quit IRC (*.net *.split)
1442021-09-20T04:41:39 *** moneyball_ <moneyball_!sid299869@id-299869.helmsley.irccloud.com> has quit IRC (*.net *.split)
1452021-09-20T04:41:39 *** bw <bw!sid2730@user/betawaffle> has quit IRC (*.net *.split)
1462021-09-20T04:41:39 *** stick[m] <stick[m]!~stickmatr@2001:470:69fc:105::98c> has quit IRC (*.net *.split)
1472021-09-20T04:41:39 *** pinheadmz <pinheadmz!~pinheadmz@hns-contributor.dev> has quit IRC (*.net *.split)
1482021-09-20T04:41:39 *** jrawsthorne <jrawsthorne!~jrawsthor@static.235.41.217.95.clients.your-server.de> has quit IRC (*.net *.split)
1492021-09-20T04:41:52 *** jrawsthorne <jrawsthorne!~jrawsthor@static.235.41.217.95.clients.your-server.de> has joined #bitcoin-core-dev
1502021-09-20T04:42:19 *** ajonas <ajonas!sid385278@id-385278.helmsley.irccloud.com> has joined #bitcoin-core-dev
1512021-09-20T04:42:21 *** moneyball_ <moneyball_!sid299869@2a03:5180:f:1::4:935d> has joined #bitcoin-core-dev
1522021-09-20T04:42:43 *** bw <bw!sid2730@user/betawaffle> has joined #bitcoin-core-dev
1532021-09-20T04:44:28 *** pinheadmz <pinheadmz!~pinheadmz@hns-contributor.dev> has joined #bitcoin-core-dev
1542021-09-20T04:48:06 *** stick[m] <stick[m]!~stickmatr@2001:470:69fc:105::98c> has joined #bitcoin-core-dev
1552021-09-20T04:52:07 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1562021-09-20T04:52:14 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1572021-09-20T04:56:14 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1582021-09-20T04:56:21 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1592021-09-20T05:00:21 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1602021-09-20T05:00:29 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1612021-09-20T05:07:08 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1622021-09-20T05:07:16 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1632021-09-20T05:16:30 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1642021-09-20T05:16:39 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1652021-09-20T05:20:39 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1662021-09-20T05:20:47 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1672021-09-20T05:25:43 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1682021-09-20T05:25:50 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1692021-09-20T05:33:30 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1702021-09-20T05:33:38 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1712021-09-20T05:36:24 *** saranshsharma <saranshsharma!~saranshsh@202.142.70.13> has quit IRC (Remote host closed the connection)
1722021-09-20T05:46:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1732021-09-20T05:46:08 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1742021-09-20T05:50:08 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1752021-09-20T05:50:16 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1762021-09-20T05:58:05 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1772021-09-20T05:58:12 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1782021-09-20T06:01:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1792021-09-20T06:01:35 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2560b6862b40...226731ac1144
1802021-09-20T06:01:35 <bitcoin-git> bitcoin/master ebe49b5 Sebastian Falbesoner: test: fix confusing off-by-one nValue in feature_coinstatsindex.py
1812021-09-20T06:01:35 <bitcoin-git> bitcoin/master 226731a merge-script: Merge bitcoin/bitcoin#23037: test: fix confusing off-by-one nValue in feat...
1822021-09-20T06:01:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1832021-09-20T06:01:52 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1842021-09-20T06:01:52 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #23037: test: fix confusing off-by-one nValue in feature_coinstatsindex.py (master...202109-test-fix_namount_offbyone_in_coinstatsindex) https://github.com/bitcoin/bitcoin/pull/23037
1852021-09-20T06:01:53 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1862021-09-20T06:04:09 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
1872021-09-20T06:08:09 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1882021-09-20T06:08:17 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1892021-09-20T06:15:58 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1902021-09-20T06:16:06 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1912021-09-20T06:16:49 *** _aj_ <_aj_!aj@user/aj/x-5857768> has quit IRC (Ping timeout: 265 seconds)
1922021-09-20T06:16:56 *** _aj_ <_aj_!aj@cerulean.erisian.com.au> has joined #bitcoin-core-dev
1932021-09-20T06:21:06 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1942021-09-20T06:21:13 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1952021-09-20T06:27:08 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1962021-09-20T06:27:17 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1972021-09-20T06:31:17 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
1982021-09-20T06:31:26 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
1992021-09-20T06:36:56 *** AaronvanW <AaronvanW!~AaronvanW@190.242.161.186> has quit IRC (Remote host closed the connection)
2002021-09-20T06:39:53 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 246 seconds)
2012021-09-20T06:42:15 *** dviola <dviola!~diego@user/dviola> has quit IRC (Quit: WeeChat 3.2.1)
2022021-09-20T06:48:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2032021-09-20T06:48:08 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2042021-09-20T06:52:08 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2052021-09-20T06:52:16 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2062021-09-20T06:56:16 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2072021-09-20T06:56:24 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2082021-09-20T07:08:17 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2092021-09-20T07:08:25 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2102021-09-20T07:08:53 *** earnestly <earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
2112021-09-20T07:08:59 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2122021-09-20T07:09:00 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #23041: test: Add addrman deserialization error tests (master...2109-testAddrmanDeser) https://github.com/bitcoin/bitcoin/pull/23041
2132021-09-20T07:09:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2142021-09-20T07:13:01 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2152021-09-20T07:13:08 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2162021-09-20T07:17:08 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2172021-09-20T07:17:16 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2182021-09-20T07:21:29 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2192021-09-20T07:21:37 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2202021-09-20T07:24:14 *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
2212021-09-20T07:24:50 *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
2222021-09-20T07:24:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2232021-09-20T07:24:54 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #23042: net: Avoid logging AlreadyHaveTx when disconneting misbehaving peer (master...2109-netLogDisconnect) https://github.com/bitcoin/bitcoin/pull/23042
2242021-09-20T07:24:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2252021-09-20T07:28:55 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2262021-09-20T07:29:03 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2272021-09-20T07:32:58 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
2282021-09-20T07:40:38 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2292021-09-20T07:40:45 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2302021-09-20T07:42:54 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2312021-09-20T07:42:54 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #23043: ci: Set --nocleanup for Windows functional tests (master...2109-ciWinCleanup) https://github.com/bitcoin/bitcoin/pull/23043
2322021-09-20T07:42:55 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2332021-09-20T07:46:55 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2342021-09-20T07:47:02 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2352021-09-20T07:52:10 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2362021-09-20T07:52:18 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2372021-09-20T07:56:18 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2382021-09-20T07:56:26 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2392021-09-20T08:01:52 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2402021-09-20T08:01:59 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2412021-09-20T08:05:59 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2422021-09-20T08:06:07 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2432021-09-20T08:11:39 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2442021-09-20T08:11:46 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2452021-09-20T08:15:46 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2462021-09-20T08:15:54 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2472021-09-20T08:19:54 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2482021-09-20T08:20:02 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2492021-09-20T08:24:02 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2502021-09-20T08:24:10 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2512021-09-20T08:26:43 *** vysn <vysn!~vysn@user/vysn> has quit IRC (Remote host closed the connection)
2522021-09-20T08:30:43 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2532021-09-20T08:30:51 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2542021-09-20T08:34:51 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2552021-09-20T08:34:59 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2562021-09-20T08:42:36 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2572021-09-20T08:42:44 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2582021-09-20T08:45:49 *** smartin <smartin!~Icedove@88.135.18.171> has joined #bitcoin-core-dev
2592021-09-20T08:59:33 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2602021-09-20T08:59:41 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2612021-09-20T09:00:09 <darosior> achow101: thanks for raising #22949 during the meeting. FWIW another round of review and hacking around with the `tx_pool` fuzzing target gave me more confidence this is not a policy change.
2622021-09-20T09:00:11 <gribble> https://github.com/bitcoin/bitcoin/issues/22949 | fee: Round up fee calculation to avoid a lower than expected feerate by achow101 · Pull Request #22949 · bitcoin/bitcoin · GitHub
2632021-09-20T09:04:11 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2642021-09-20T09:04:19 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2652021-09-20T09:09:49 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2662021-09-20T09:09:57 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2672021-09-20T09:13:57 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2682021-09-20T09:14:05 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2692021-09-20T09:21:37 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2702021-09-20T09:21:49 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2712021-09-20T09:25:49 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2722021-09-20T09:26:02 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2732021-09-20T09:30:02 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2742021-09-20T09:30:16 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2752021-09-20T09:34:16 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2762021-09-20T09:34:24 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2772021-09-20T09:38:24 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2782021-09-20T09:38:32 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2792021-09-20T09:43:12 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2802021-09-20T09:43:19 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2812021-09-20T09:46:47 <laanwj> luke-jr: is this for the distribution binaries or self-built?
2822021-09-20T09:48:49 <laanwj> will try it out on my armhf hw, but useful to know what the build conditions were ... it's weird, i don't think the 32-bit ARM is supposed to do 64-bit loads for crc, because it doesn't have a 64 bit crc isntruction
2832021-09-20T09:51:53 *** Henrik <Henrik!~textual@84.212.107.177> has joined #bitcoin-core-dev
2842021-09-20T09:55:00 <laanwj> so does HAVE_ARM64_CRC32C get set when building for armhf
2852021-09-20T09:58:54 <laanwj> These built-in intrinsics for the ARMv8-A CRC32 extension are available when the -march=armv8-a+crc switch is used "uint32_t __crc32d (uint32_t, uint64_t)" Form of expected instruction(s): Two crc32w r0, r0, r0 instructions for AArch32
2862021-09-20T09:59:19 <laanwj> so: no, unless somehow that flag is passed to the autoconf test, i think the distro binary is fine
2872021-09-20T10:00:21 <laanwj> but it is sneaky that gcc will 'emulate' the 64-bit intrinsic on ARM32
2882021-09-20T10:01:29 <laanwj> in any case we need to explicitly check for 64-bit ARM in your build system, the crc32c code is not ARM-specific it is ARM64-specific
2892021-09-20T10:08:45 <laanwj> oh crap--I think our detection is entirely wrong, we're detecting 32-bit ARM CRC32 instead of 64-bit?
2902021-09-20T10:10:30 <laanwj> configure:17553: checking for ARM CRC32 intrinsics" fails for me on
2912021-09-20T10:11:08 <laanwj> arm-unknown-linux-gnueabihf-gcc 10.2.0
2922021-09-20T10:15:09 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
2932021-09-20T10:15:21 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
2942021-09-20T10:16:13 <laanwj> PHEW-22.0 armhf distro doesn't contain the instructions: arm-unknown-linux-gnueabihf-objdump -d bitcoind|grep crc32
2952021-09-20T10:16:32 <laanwj> and the aarch64 one does
2962021-09-20T10:18:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2972021-09-20T10:18:40 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #23044: refactor: Remove unused validation includes (master...2109-valInc) https://github.com/bitcoin/bitcoin/pull/23044
2982021-09-20T10:18:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2992021-09-20T10:22:42 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3002021-09-20T10:22:49 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3012021-09-20T10:26:49 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3022021-09-20T10:26:56 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3032021-09-20T10:28:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3042021-09-20T10:28:07 <bitcoin-git> [bitcoin] laanwj opened pull request #23045: build: Restrict check for CRC32C intrinsic to aarch64 (master...2021-09-arm64-crc32) https://github.com/bitcoin/bitcoin/pull/23045
3052021-09-20T10:28:07 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3062021-09-20T10:34:52 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3072021-09-20T10:35:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3082021-09-20T10:39:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3092021-09-20T10:39:08 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3102021-09-20T10:40:22 *** jespada <jespada!~jespada@2803:9800:9842:7a62:edd5:5e74:3ec2:1b19> has joined #bitcoin-core-dev
3112021-09-20T10:44:30 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3122021-09-20T10:44:37 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3132021-09-20T10:45:49 *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
3142021-09-20T10:49:49 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3152021-09-20T10:49:56 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3162021-09-20T10:53:56 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3172021-09-20T10:54:11 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3182021-09-20T11:01:05 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3192021-09-20T11:01:13 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3202021-09-20T11:07:23 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3212021-09-20T11:07:31 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3222021-09-20T11:11:31 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3232021-09-20T11:11:38 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3242021-09-20T11:15:38 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3252021-09-20T11:15:45 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3262021-09-20T11:16:08 *** Henrik <Henrik!~textual@84.212.107.177> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzzâ¦)
3272021-09-20T11:19:04 *** Henrik <Henrik!~textual@84.212.107.177> has joined #bitcoin-core-dev
3282021-09-20T11:23:48 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3292021-09-20T11:23:56 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3302021-09-20T11:27:56 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3312021-09-20T11:28:04 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3322021-09-20T11:32:05 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3332021-09-20T11:32:14 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3342021-09-20T11:39:02 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3352021-09-20T11:39:10 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3362021-09-20T11:45:52 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3372021-09-20T11:45:59 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3382021-09-20T11:50:02 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3392021-09-20T11:50:10 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3402021-09-20T11:54:10 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3412021-09-20T11:54:18 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3422021-09-20T11:58:18 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3432021-09-20T11:58:26 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3442021-09-20T12:02:26 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3452021-09-20T12:02:34 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3462021-09-20T12:06:34 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3472021-09-20T12:06:41 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3482021-09-20T12:07:25 *** davterra <davterra!~davterra@143.198.56.186> has quit IRC (Ping timeout: 260 seconds)
3492021-09-20T12:13:13 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3502021-09-20T12:13:21 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3512021-09-20T12:17:21 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3522021-09-20T12:17:28 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3532021-09-20T12:21:28 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3542021-09-20T12:21:36 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3552021-09-20T12:26:18 <sipa> laanwj: ok good
3562021-09-20T12:27:02 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3572021-09-20T12:27:02 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #23046: test: Add txindex migration test (master...2109-txindexMigrate) https://github.com/bitcoin/bitcoin/pull/23046
3582021-09-20T12:27:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3592021-09-20T12:29:56 *** bodhi <bodhi!~bodhi@c-73-93-87-220.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
3602021-09-20T12:34:42 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3612021-09-20T12:34:51 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3622021-09-20T12:38:51 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3632021-09-20T12:38:59 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3642021-09-20T12:42:59 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3652021-09-20T12:43:07 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3662021-09-20T12:47:41 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3672021-09-20T12:47:49 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3682021-09-20T12:49:30 <laanwj> the issue must have been there since we first introduced crc32c, afaik its ARM code has always been the same, and so was our build system check, and it's never been reported before (it's a clear immediate crash) so the conditions where it is accidentally enabled on armhf must be rare
3692021-09-20T12:52:26 *** prayank <prayank!~andr0irc@51.158.144.32> has joined #bitcoin-core-dev
3702021-09-20T12:53:58 *** yyaac <yyaac!~andirc@2400:4052:8383:5c00:f8b8:504:5fa0:6a48> has joined #bitcoin-core-dev
3712021-09-20T12:54:57 *** yyaac <yyaac!~andirc@2400:4052:8383:5c00:f8b8:504:5fa0:6a48> has quit IRC (Client Quit)
3722021-09-20T12:58:26 <prayank> laanwj: Waiting for your response about proxies https://github.com/bitcoin/bitcoin/pull/22959#issuecomment-921094779
3732021-09-20T12:58:33 <prayank> My understanding with an example: Consider I am using 127.0.0.1:8080 as proxy, onlynet is not used, proxy remains for all networks but may not work for one or more depending on different things. If onlynet is used, only those networks will be tried to reach via proxy but proxy still remains for all networks. 127.0.0.1:7656 is only used for i2p.
3742021-09-20T13:02:21 <sipa> prayank: i don't understand the question
3752021-09-20T13:04:33 <prayank> sipa: if an IP address and PORT is mentioned in proxy by user, does it make sense to classify it as only applicable for some networks? 127.0.0.1:7656 being an exception
3762021-09-20T13:06:12 <laanwj> prayank: i think that's how it's supposed to be: if you configure a proxy for a certain network and the proxy doesn't work for that network, it will try to use it when connecting out on that, then fail--it definitely shouldn't try connecting outside the proxy, that would be some kind of leak
3772021-09-20T13:06:53 <laanwj> a 'the proxy doesn't work let's connect directly' fallback would be really bad. but maybe i'm misunderstanding
3782021-09-20T13:07:01 <sipa> prayank: you can configure which network it is for
3792021-09-20T13:07:29 <prayank> laanwj: agree
3802021-09-20T13:08:12 <ryanofsky> Can add #22976 to high prio since I don't have on there right now?
3812021-09-20T13:08:14 <gribble> https://github.com/bitcoin/bitcoin/issues/22976 | scripted-diff: Rename overloaded int GetArg to GetIntArg by ryanofsky · Pull Request #22976 · bitcoin/bitcoin · GitHub
3822021-09-20T13:08:16 <sipa> oh, seems i'm wrong
3832021-09-20T13:08:19 <prayank> sipa: I guess that would require more things in config
3842021-09-20T13:08:59 <sipa> there is just -proxy and -onion; i thought i saw something to restrict which networks -proxy is for
3852021-09-20T13:13:31 *** Yihen <Yihen!~textual@153.122.173.2> has joined #bitcoin-core-dev
3862021-09-20T13:14:11 <laanwj> prayank: btw please don't take my IRC posts out of context on github this is very stressful
3872021-09-20T13:16:42 <prayank> It's not completely out of context. Sorry if it looks wrong but things were related and discussed at several places in which I finally had this conclusion proxies are just proxies and should be used for all networks if possible.
3882021-09-20T13:18:29 <laanwj> yes, sure, I understand how it can be somewhat confusing: that's true *if* specified with -proxy, then it's intended to be used as cover-all proxy for all networks (including DNS names), however, network-specific proxies are applied to addresses of a specific network
3892021-09-20T13:18:47 <laanwj> and that's the information you get with getnetworkinfo
3902021-09-20T13:20:19 <laanwj> name connections (where the network isn't known) are a special case that's outside of the normal per-network proxy handling, names never come from the P2P network but only in special cases (as mentioned in https://github.com/bitcoin/bitcoin/pull/22959#issuecomment-922915197)
3912021-09-20T13:25:26 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
3922021-09-20T13:25:33 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
3932021-09-20T13:27:23 <prayank> I think I still believe saying proxy 1 is used for ipv4 only can be misleading. Because it's used for only ipv4 either because you restricted outgoing to ipv4 only or used externalip in config. Proxy can still be used for other networks if user changes config. This might give false information that proxy only works for some networks.
3942021-09-20T13:27:45 <laanwj> sipa: there's not currently a way to only set a proxy for ipv4 and not ipv6 or vice versa, theoretically it'd be easy to implement, but the use case doesn't really come up, what almost everyone wants is to set a proxy for everything
3952021-09-20T13:28:17 <laanwj> (sometimes including or excluding onion)
3962021-09-20T13:29:05 <laanwj> prayank: i don't follow you here, the information returned is exactly what the network code uses
3972021-09-20T13:29:38 <sipa> prayank: externalip is completely unrelated; that's about advertising an address for incoming connections
3982021-09-20T13:29:51 <sipa> -proxy and -onion are purely about outgoing connections
3992021-09-20T13:30:04 <laanwj> all that -getinfo does is format it in a nice way, but it's simply the internal proxy information it gets from getnetworkinfo, that is used by the P2P code
4002021-09-20T13:30:22 <jonatack> prayank: also, remember that -getinfo is only a wrapper for a batch of RPCs, including getnetworkinfo, so the relevant discussion there is on how to present the data they provide.
4012021-09-20T13:30:33 <prayank> laanwj: As a user what would you prefer 1. Proxy 127.0.0.1:9150 (ipv4) 2. Proxy 127.0.0.1:9150 (onlynet=ipv4)
4022021-09-20T13:30:37 <jonatack> laanwj: right
4032021-09-20T13:31:01 <sipa> prayank: i don't understand what you're trying to convey
4042021-09-20T13:31:26 <sipa> onlynet is about which automatic connections are made
4052021-09-20T13:31:48 <sipa> proxy is about how to make connections in general, including non-automatic ones
4062021-09-20T13:34:53 <prayank> sipa: Networks being associated with a proxy looked incorrect to me but at this point it looks like I am more confused than before so will take some time to try things and comeback in few days with fresh thoughts.
4072021-09-20T13:35:12 <prayank> Also it was related to this PR as well: https://github.com/bitcoin-core/gui/pull/421
4082021-09-20T13:37:35 <sipa> prayank: internally, every network can have a proxy associated with (plus a separate one for name-based connections). -proxy sets all of them. -onion sets the one for tor hidden services only.
4092021-09-20T13:38:45 *** Henrik <Henrik!~textual@84.212.107.177> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzzâ¦)
4102021-09-20T13:43:07 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4112021-09-20T13:43:15 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4122021-09-20T13:44:56 <prayank> sipa: externalip assumption was based on the command shared in end of 'manual' section here which says you can use this if proxy should only work for onion and not ipv4
4132021-09-20T13:45:01 <prayank> https://github.com/bitcoin/bitcoin/blob/master/doc/tor.md#3-manually-create-a-bitcoin-core-onion-service
4142021-09-20T13:45:03 <gribble> https://github.com/bitcoin/bitcoin/issues/3 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub
4152021-09-20T13:46:43 <sipa> prayank: section 1 is about outgoing connections; 2 and 3 are about incoming
4162021-09-20T13:49:20 <prayank> Okay so this is proxy for incoming
4172021-09-20T13:50:21 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4182021-09-20T13:50:21 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #23047: test: Use MiniWallet in mempool_persist (master...2109-testMempool) https://github.com/bitcoin/bitcoin/pull/23047
4192021-09-20T13:50:22 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4202021-09-20T13:53:04 <sipa> prayank: there is no such thing as a "proxy for incoming"
4212021-09-20T13:53:34 <sipa> -externalip is just telling bitcoind on which address it can be reached, so it can.rumour that address to other peers
4222021-09-20T13:53:49 *** mersible <mersible!~mersible@92.119.17.211> has joined #bitcoin-core-dev
4232021-09-20T13:56:00 *** Yihen <Yihen!~textual@153.122.173.2> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
4242021-09-20T13:56:03 <sipa> because if you manually configure your tor node to have a hidden service for your bitcoind, bitcoind has no way of figuring out what its hidden service address is
4252021-09-20T14:00:04 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
4262021-09-20T14:00:11 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
4272021-09-20T14:01:27 <laanwj> right, or when your node is behind a NAT, it's not a proxy-specific option
4282021-09-20T14:01:48 <laanwj> (+and manually port-forwarded)
4292021-09-20T14:04:09 <sipa> prayank: are you confused about the mention of -proxy in the example in section 3? that's just setting the proxy for outbound connections
4302021-09-20T14:05:02 <luke-jr> laanwj: is the 2x crc32w worse for performance?
4312021-09-20T14:05:54 <luke-jr> laanwj: and again, 0.21 built and ran tests fine :/
4322021-09-20T14:06:43 <laanwj> luke-jr: yes, i think all the instructions execute in the same number of cycles, so doing 64 bits at once is twice as fast
4332021-09-20T14:07:16 <sipa> (because it's an example of all the tor related settings to use in such an example)
4342021-09-20T14:07:19 <sipa> i guess.i comfused.you by saying section 3 is purely about inbound... the example are about the whole thing
4352021-09-20T14:09:03 <luke-jr> laanwj: but ARM won't be doing 64 bits; if we disable this, it will use plain C?
4362021-09-20T14:09:25 <laanwj> luke-jr: it has always used plain C on ARM32, your case is really a strnge misdetection
4372021-09-20T14:09:49 <laanwj> the code in crc32c is for 64 bit ARM, it doesn't work for 32-bit
4382021-09-20T14:12:26 <laanwj> (it even queries the wrong getauxval bit for the instruction set in src/crc32c/src/crc32c_arm64_check.h if you manage to compile that code for 32-bit, it's all in all, pretty bad)
4392021-09-20T14:12:43 <luke-jr> laanwj: crc32c itself doesn't check for aarch64
4402021-09-20T14:13:01 <luke-jr> ah, I wonder if that's why it detected it at runtime
4412021-09-20T14:13:13 <laanwj> luke-jr: maybe it's an upstream bug then
4422021-09-20T14:13:23 <laanwj> in any case, we need to fix itin our own build system, as we don't use theirs
4432021-09-20T14:13:34 <luke-jr> right
4442021-09-20T14:15:53 <sipa> laanwj: do ARM32 implementations (with necessary extensions) have the same instructions, actually? (perhaps without the 64-bits at once one)?
4452021-09-20T14:16:16 <sipa> because maybe it's less work to make (upstream) crc32c actually work propertly on arm32 then
4462021-09-20T14:16:19 <laanwj> sipa: yes, but they are extremely rare in the first place
4472021-09-20T14:16:29 *** Henrik <Henrik!~textual@84.212.107.177> has joined #bitcoin-core-dev
4482021-09-20T14:16:35 <sipa> i guess the relevant question is: does any raspberry pi have them>
4492021-09-20T14:16:51 <laanwj> crc32c extension was introduced with arm8, which tend to be 64 bit
4502021-09-20T14:17:16 <laanwj> luke-jr: does your hardware actually list crc32c in /proc/cpuinfo?
4512021-09-20T14:17:17 <prayank> sipa: yes
4522021-09-20T14:18:48 <sipa> laanwj: but rpi4 is actually aarch64, but with (iirc) typically a 32-bit OS on it
4532021-09-20T14:19:03 <laanwj> sipa: ok well for that case it could work
4542021-09-20T14:19:21 <sipa> but apparently with misaligned input...
4552021-09-20T14:19:49 <laanwj> if anyone actually has hardware to test i'm happy with making crc32c work on 32-bit ARM instead
4562021-09-20T14:20:48 <sipa> i have access to an aarch64 machine (developerbox); i can easily compile in 32-bit mode and test on that
4572021-09-20T14:20:52 <laanwj> you'd need to specialize for __arm__: a) getauxval linux bit b) make sure the 64 bit path is ifdef'ed out
4582021-09-20T14:22:19 <laanwj> (pretty much exactly like the x86/x86_64 distinction)
4592021-09-20T14:23:15 <sipa> yeah
4602021-09-20T14:23:46 <sipa> it seems there are a lot of analogies between arm32/aarch64 on the one hand and x86/x86_64 on the other hand
4612021-09-20T14:23:48 <luke-jr> laanwj: it will take me hours to find out, but I will check
4622021-09-20T14:24:58 <luke-jr> I would expect to find it's aarch64-capable running a 32-bit VM or container
4632021-09-20T14:24:59 <laanwj> luke-jr: ok no hurry
4642021-09-20T14:25:48 <luke-jr> in any case, separating the bugfix from the feature of adding 32-bit support to it, seem like two different tasks/PRs
4652021-09-20T14:26:57 *** davterra <davterra!~davterra@143.198.56.186> has joined #bitcoin-core-dev
4662021-09-20T14:27:11 <sipa> luke-jr: agree
4672021-09-20T14:27:12 <laanwj> luke-jr: in any case the /proc/cpuinfo 'features' will be what getauxval(AT_HWCAP*) returns, if there is no crc32c in there then it shouldn't even have tried to go into the hw-accelerated code path
4682021-09-20T14:27:50 <laanwj> it's probing the wrong bit which means something completely different on a different architecture
4692021-09-20T14:28:09 <laanwj> luke-jr: yes
4702021-09-20T14:30:00 <laanwj> my PR (disabling it where we know it's not going to work) is the safe baseline
4712021-09-20T14:30:24 <luke-jr> oh, got it faster than expected! http://dpaste.com/5CR5SYJPZ
4722021-09-20T14:31:39 <laanwj> Features : half thumb fastmult vfp edsp neon vfpv3 tls vfpv4 idiva idivt lpae evtstrm -- no crc32 :/
4732021-09-20T14:32:17 * luke-jr wonders how crc32w is normally detected
4742021-09-20T14:32:56 <sipa> getauxval is the correct approach, i think
4752021-09-20T14:33:18 *** Guest3749 <Guest3749!~Guest37@109.128.22.109.rev.sfr.net> has joined #bitcoin-core-dev
4762021-09-20T14:33:29 <laanwj> it's a bit in HWCAP2
4772021-09-20T14:33:40 <laanwj> looking it up now
4782021-09-20T14:34:08 <sipa> Note ID_ISAR5.CRC32 indicates whether this instruction is supported in the T32 and A32 instruction sets.
4792021-09-20T14:34:26 <laanwj> HWCAP2_CRC32
4802021-09-20T14:34:47 <laanwj> in getauxval(AT_HWCAP2)
4812021-09-20T14:35:19 <luke-jr> strange that /proc/cpuinfo lacks it
4822021-09-20T14:35:40 <Guest3749> Hello, I was wondering if the BTCC is on sale and if so where can I buy some? thank you
4832021-09-20T14:36:28 <luke-jr> Guest3749: wrong channel. (and note that "BTCC" may be a scam, not related to Bitcoin) further discussion somewhere else please
4842021-09-20T14:37:04 <laanwj> in aarch64 it's in AT_HWCAP instead and a different bit (HWCAP_CRC32 = 1<<7) .. that same bit would on ARM32 be HWCAP_EDSP (1 << 7)
4852021-09-20T14:37:17 <laanwj> as you have edsp, that checks out... :)
4862021-09-20T14:37:53 <sipa> laanwj: but that doesn't mean the same machine binary opcode is used for edsp and crc32?
4872021-09-20T14:38:12 <laanwj> sipa: oh definitely not
4882021-09-20T14:38:32 <sipa> right, so it's strange luke is getting a misaligned error
4892021-09-20T14:38:49 <sipa> i'd expect an "unknown instruction" or so instead
4902021-09-20T14:38:56 <laanwj> wait, the crc* instructions don't access memory at all
4912021-09-20T14:39:02 <laanwj> it's the memory fetch before it that gets a SIGBUS
4922021-09-20T14:39:05 <sipa> ah
4932021-09-20T14:39:07 <laanwj> it doesn't even get to the instruction
4942021-09-20T14:39:18 <sipa> right, it's 3 registry operands
4952021-09-20T14:40:00 <laanwj> right, i think the code, right now, makes the assumption pointers are 64-bit aligned, which isn't true on 32-bit ARM, so it bolts out even before getting to the instruction itself
4962021-09-20T14:40:28 <sipa> 17:07:22 < luke-jr> crc32c/src/crc32c_arm64.cc:101:20: runtime error: load of misaligned address 0x06d96d36 for type 'uint64_t', which requires 8 byte
4972021-09-20T14:40:37 <sipa> that's not even 4-byte aligned!
4982021-09-20T14:40:43 <laanwj> heeh
4992021-09-20T14:40:49 <luke-jr> XD
5002021-09-20T14:40:54 <Guest3749> no answer to my question? must we mine BTCC OR can we buy it somewhere? Thank you for answering me.
5012021-09-20T14:41:02 <sipa> Guest3749: off topic, sorry
5022021-09-20T14:45:02 <prayank> Guest3749: Where did you get the link for this IRC channel?
5032021-09-20T14:48:47 <Guest3749> I am also a developer. there is the irc on the website, then i dont know why even if it is not the right place why no one just answers my question. or buy BTCC, simple question.
5042021-09-20T14:50:13 <sipa> Guest3749: this channel is about the development of the bitcoin core software; anything else is off-topic; last warning
5052021-09-20T14:50:30 <luke-jr> Guest3749: even if someone knows, they respect the topic of the channel and won't answer here.
5062021-09-20T14:52:44 *** Henrik <Henrik!~textual@84.212.107.177> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzzâ¦)
5072021-09-20T14:53:33 <Guest3749> so you are idiots ... in the street if someone asks you the time when you are going to buy bread i hope you will answer him anyway .. not like saying no i am going to get my bread there is none report. answer a simple question and move on. anyway, the mentality is pretty low for dev.
5082021-09-20T14:55:20 *** ChanServ sets mode: +b Guest3749!*@*
5092021-09-20T14:55:20 *** Guest3749 was kicked by ChanServ (Banned: off-topic)
5102021-09-20T15:01:39 *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has joined #bitcoin-core-dev
5112021-09-20T15:08:37 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
5122021-09-20T15:08:44 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5132021-09-20T15:13:06 <laanwj> that escalated quickly
5142021-09-20T15:19:46 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
5152021-09-20T15:19:53 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5162021-09-20T15:24:59 *** davterra <davterra!~davterra@143.198.56.186> has quit IRC (Quit: Leaving)
5172021-09-20T15:24:59 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
5182021-09-20T15:25:07 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5192021-09-20T15:34:11 *** dunxen <dunxen!~dunxen@gateway/tor-sasl/dunxen> has joined #bitcoin-core-dev
5202021-09-20T15:34:52 *** dunxen <dunxen!~dunxen@gateway/tor-sasl/dunxen> has quit IRC (Client Quit)
5212021-09-20T15:35:21 *** dunxen <dunxen!~dunxen@gateway/tor-sasl/dunxen> has joined #bitcoin-core-dev
5222021-09-20T15:39:52 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
5232021-09-20T15:39:59 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5242021-09-20T15:46:45 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
5252021-09-20T15:46:53 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5262021-09-20T15:49:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5272021-09-20T15:49:09 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/226731ac1144...d809d8bf1264
5282021-09-20T15:49:09 <bitcoin-git> bitcoin/master 7c3712f klementtan: cli: Display all proxies in -getinfo
5292021-09-20T15:49:09 <bitcoin-git> bitcoin/master d809d8b W. J. van der Laan: Merge bitcoin/bitcoin#22959: cli: Display all proxies in -getinfo
5302021-09-20T15:49:11 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5312021-09-20T15:49:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5322021-09-20T15:49:26 <bitcoin-git> [bitcoin] laanwj merged pull request #22959: cli: Display all proxies in -getinfo (master...getinfo-multiple-proxies) https://github.com/bitcoin/bitcoin/pull/22959
5332021-09-20T15:49:27 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5342021-09-20T15:49:48 <luke-jr> laanwj: why couldn't it have worked previously? O.o
5352021-09-20T15:50:06 <luke-jr> if you had edsp and crc32 stuff?
5362021-09-20T15:51:50 <laanwj> because the code is broken for ARM64
5372021-09-20T15:51:59 <laanwj> eh, for ARM32, it works only for ARM64
5382021-09-20T15:53:12 <luke-jr> depends on the source of the unalignment? :P
5392021-09-20T15:53:53 <laanwj> come on... it's clear from various things that that code was never qualified for ARM32 in any way
5402021-09-20T15:54:21 <luke-jr> sure, but it did apparently work in 0.21
5412021-09-20T15:54:32 <laanwj> why do you think that?
5422021-09-20T15:54:48 <luke-jr> I didn't encounter this failure until 22.0
5432021-09-20T15:55:00 <luke-jr> noteworthy, only on Ubuntu impish
5442021-09-20T15:55:02 <laanwj> because the check worked before, something changed in your build environment
5452021-09-20T15:55:31 <luke-jr> I suppose it's possible
5462021-09-20T15:55:36 <laanwj> for the release binaries and everyone else's build env, it failed that build system check on armhf so the issue never comes up
5472021-09-20T15:55:59 <laanwj> crc32 doesn't even *work* on your CPU, it's not in /proc/cpusinfo
5482021-09-20T15:56:18 <laanwj> even separately from the architecture misdetection
5492021-09-20T15:57:16 <laanwj> if it'd actually execute one of the crc32c* instructions it'd give SIGILL, if it wouldn't have failed on the alignment issue before
5502021-09-20T15:58:18 <luke-jr> you're right
5512021-09-20T15:58:28 <luke-jr> grepped the 0.21 binaries for crc32 yielded nothing
5522021-09-20T15:59:18 *** klementtan <klementtan!~klementta@218.212.82.3> has joined #bitcoin-core-dev
5532021-09-20T15:59:31 <luke-jr> eh, but neither do the arm64 bins
5542021-09-20T16:00:29 <laanwj> interesting
5552021-09-20T16:01:37 <sipa> did we recently update libcrc32c?
5562021-09-20T16:01:45 <laanwj> or maybe the compiler used previously didn't know the intrinsics
5572021-09-20T16:02:35 <luke-jr> found _ZN6crc32c11ExtendArm64EjPKhm in arm64 debug symbol file, but absent in armhf
5582021-09-20T16:02:46 <luke-jr> laanwj: hard to be sure, since impish is still evolving
5592021-09-20T16:02:57 <luke-jr> sipa: yes, but nothing significant in there from what I saw
5602021-09-20T16:04:03 <luke-jr> laanwj: anyway, my ACK is simply waiting on the build to finish ;)
5612021-09-20T16:04:59 <luke-jr> might be nice to get ARM32 supported since it seems reasonably common, but I don't have a Pi4 to try with at the moment
5622021-09-20T16:11:05 *** davterra <davterra!~davterra@143.198.56.186> has joined #bitcoin-core-dev
5632021-09-20T16:13:59 *** AaronvanW <AaronvanW!~AaronvanW@190.242.161.186> has joined #bitcoin-core-dev
5642021-09-20T16:15:49 *** SpellChecker <SpellChecker!~SpellChec@gateway/tor-sasl/spellchecker> has joined #bitcoin-core-dev
5652021-09-20T16:17:05 *** Henrik <Henrik!~textual@84.212.107.177> has joined #bitcoin-core-dev
5662021-09-20T16:21:16 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
5672021-09-20T16:21:24 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5682021-09-20T16:24:04 *** gene <gene!~gene@gateway/tor-sasl/gene> has joined #bitcoin-core-dev
5692021-09-20T16:27:28 *** Henrik <Henrik!~textual@84.212.107.177> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzzâ¦)
5702021-09-20T16:28:26 *** lightlike <lightlike!~lightlike@user/lightlike> has joined #bitcoin-core-dev
5712021-09-20T16:32:26 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
5722021-09-20T16:32:33 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5732021-09-20T16:36:50 <luke-jr> fanquake: found a bug in your merged PR https://github.com/bitcoin/bitcoin/pull/22859#discussion_r712334971 maybe fix?
5742021-09-20T16:37:00 *** Henrik <Henrik!~textual@84.212.107.177> has joined #bitcoin-core-dev
5752021-09-20T16:39:56 <laanwj> does Rpi4 have CRC32 instructions? i don't have one
5762021-09-20T16:41:56 <sipa> it does: https://www.raspberrypi.org/forums/viewtopic.php?t=243882
5772021-09-20T16:42:34 <laanwj> wait i do have a Odroid-C2 which has them, but it's used for something important i can't just install another OS on it, does 32-bit software run on 64-bit ARM? i don't remember
5782021-09-20T16:42:58 <sipa> it does
5792021-09-20T16:43:51 <sipa> either by having a full 32-bit OS only, or if you have 32-bit userspace libraries installed
5802021-09-20T16:43:59 <sipa> same as with x86_64/x86
5812021-09-20T16:44:31 <laanwj> right, i didn't know for sure because it's not like that for riscv32/64
5822021-09-20T16:46:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5832021-09-20T16:46:46 <bitcoin-git> [bitcoin] Fi3 opened pull request #23049: net: implement a StratumV2 Template Provider in core (master...add_sv2) https://github.com/bitcoin/bitcoin/pull/23049
5842021-09-20T16:46:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5852021-09-20T16:53:31 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
5862021-09-20T16:53:39 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5872021-09-20T16:58:46 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
5882021-09-20T16:58:54 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5892021-09-20T16:59:40 *** achow101 <achow101!~achow101@user/achow101> has quit IRC (Quit: Bye)
5902021-09-20T16:59:58 <laanwj> it indeed looks like "dpkg --add-architecture armhf && apt update && apt install libc6:armhf" is enough to run armhf release bitcoin-cli on aarch64 host
5912021-09-20T17:01:06 *** achow101 <achow101!~achow101@user/achow101> has joined #bitcoin-core-dev
5922021-09-20T17:02:26 <laanwj> no need to install a 32-bit OS
5932021-09-20T17:03:29 <laanwj> although i haven't checked yet what the AT_HWCAP flags look like, i'd guess they'd be passed correctly to 32-bit userspace though, and that the same extension instruction sets are available
5942021-09-20T17:07:52 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
5952021-09-20T17:08:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
5962021-09-20T17:10:04 <luke-jr> #12677 & #22974 look rtm
5972021-09-20T17:10:07 <gribble> https://github.com/bitcoin/bitcoin/issues/12677 | RPC: Add ancestor{count,size,fees} to listunspent output by luke-jr · Pull Request #12677 · bitcoin/bitcoin · GitHub
5982021-09-20T17:10:09 <gribble> https://github.com/bitcoin/bitcoin/issues/22974 | addrman: Improve performance of Good by mzumsande · Pull Request #22974 · bitcoin/bitcoin · GitHub
5992021-09-20T17:13:55 *** Henrik <Henrik!~textual@84.212.107.177> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzzâ¦)
6002021-09-20T17:16:08 <laanwj> ... getauxval(AT_HWCAP2)=0x00000010 looks like it, as expected, getauxval in a 32-bit binary on 64-bit ARM returns the correct value for 32-bit ARM, and also, 1<<4 (HWCAP2_CRC32) is available in 32-bit mode
6012021-09-20T17:18:05 <laanwj> luke-jr: will take a look
6022021-09-20T17:22:05 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6032021-09-20T17:22:14 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6042021-09-20T17:26:14 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6052021-09-20T17:26:16 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6062021-09-20T17:26:16 <bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/d809d8bf1264...488e7455608d
6072021-09-20T17:26:16 <bitcoin-git> bitcoin/master 3f77dfd Luke Dashjr: Expose ancestorsize and ancestorfees via getTransactionAncestry
6082021-09-20T17:26:16 <bitcoin-git> bitcoin/master 6966e80 Luke Dashjr: RPC: Add ancestor{count,size,fees} to listunspent output
6092021-09-20T17:26:16 <bitcoin-git> bitcoin/master 0be2f17 Luke Dashjr: QA: Add tests for listunspent ancestor{count,size,fees} to mempool_packages
6102021-09-20T17:26:18 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6112021-09-20T17:26:22 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6122021-09-20T17:26:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6132021-09-20T17:26:33 <bitcoin-git> [bitcoin] laanwj merged pull request #12677: RPC: Add ancestor{count,size,fees} to listunspent output (master...listunspent_ancestorinfo) https://github.com/bitcoin/bitcoin/pull/12677
6142021-09-20T17:26:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6152021-09-20T17:27:31 *** first_mersible <first_mersible!~mersible@92.119.17.210> has joined #bitcoin-core-dev
6162021-09-20T17:29:10 *** dongcarl <dongcarl!~dongcarl@70.107.207.192> has quit IRC (Ping timeout: 260 seconds)
6172021-09-20T17:29:27 *** dongcarl <dongcarl!~dongcarl@70.107.207.192> has joined #bitcoin-core-dev
6182021-09-20T17:29:50 *** mersible <mersible!~mersible@92.119.17.211> has quit IRC (Ping timeout: 246 seconds)
6192021-09-20T17:31:25 *** dongcarl1 <dongcarl1!~dongcarl@70.107.207.192> has joined #bitcoin-core-dev
6202021-09-20T17:34:02 *** dongcarl <dongcarl!~dongcarl@70.107.207.192> has quit IRC (Ping timeout: 246 seconds)
6212021-09-20T17:34:02 *** dongcarl1 is now known as dongcarl
6222021-09-20T17:35:14 *** jesseposner <jesseposner!~jesse@c-24-5-105-39.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 260 seconds)
6232021-09-20T17:40:17 *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has quit IRC (Ping timeout: 264 seconds)
6242021-09-20T17:44:17 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6252021-09-20T17:44:24 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6262021-09-20T17:45:46 *** Jackielove4u <Jackielove4u!uid43977@user/jackielove4u> has quit IRC (Quit: Connection closed for inactivity)
6272021-09-20T17:48:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6282021-09-20T17:48:20 <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/488e7455608d...7f7bd3111cdc
6292021-09-20T17:48:20 <bitcoin-git> bitcoin/master eb2e113 Martin Zumsande: addrman: Improve performance of Good
6302021-09-20T17:48:20 <bitcoin-git> bitcoin/master acf656d Martin Zumsande: fuzz: Use public interface to fill addrman tried tables
6312021-09-20T17:48:20 <bitcoin-git> bitcoin/master 57ce203 Martin Zumsande: fuzz: allow lower number of sources
6322021-09-20T17:48:22 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6332021-09-20T17:48:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6342021-09-20T17:48:37 <bitcoin-git> [bitcoin] laanwj merged pull request #22974: addrman: Improve performance of Good (master...202109_goodspeed) https://github.com/bitcoin/bitcoin/pull/22974
6352021-09-20T17:48:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6362021-09-20T17:51:16 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6372021-09-20T17:51:16 <bitcoin-git> [bitcoin] jb55 closed pull request #18985: bloom: use Span instead of std::vector for `insert` and `contains` [ZAP3] (master...2020-05-bloom-span) https://github.com/bitcoin/bitcoin/pull/18985
6382021-09-20T17:51:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6392021-09-20T17:51:32 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6402021-09-20T17:51:32 <bitcoin-git> [bitcoin] jb55 closed pull request #18849: The Zero Allocations project (master...zeroalloc) https://github.com/bitcoin/bitcoin/pull/18849
6412021-09-20T17:51:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6422021-09-20T17:53:26 *** kinlo <kinlo!~peter@user/kinlo> has quit IRC (Ping timeout: 260 seconds)
6432021-09-20T17:55:43 *** AaronvanW <AaronvanW!~AaronvanW@190.242.161.186> has quit IRC (Ping timeout: 265 seconds)
6442021-09-20T17:59:43 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6452021-09-20T17:59:52 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6462021-09-20T18:03:52 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6472021-09-20T18:04:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6482021-09-20T18:06:37 *** kinlo <kinlo!~peter@user/kinlo> has joined #bitcoin-core-dev
6492021-09-20T18:11:05 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6502021-09-20T18:11:12 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6512021-09-20T18:15:06 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Quit: Konversation terminated!)
6522021-09-20T18:19:07 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6532021-09-20T18:19:14 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6542021-09-20T18:19:46 *** gene <gene!~gene@gateway/tor-sasl/gene> has quit IRC (Quit: gene)
6552021-09-20T18:20:30 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
6562021-09-20T18:24:30 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6572021-09-20T18:24:37 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6582021-09-20T18:28:38 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6592021-09-20T18:28:46 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6602021-09-20T18:32:46 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6612021-09-20T18:32:53 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6622021-09-20T18:36:53 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6632021-09-20T18:37:01 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6642021-09-20T18:38:12 *** klementtan <klementtan!~klementta@218.212.82.3> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
6652021-09-20T18:42:12 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6662021-09-20T18:42:19 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6672021-09-20T18:44:44 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has quit IRC (Ping timeout: 246 seconds)
6682021-09-20T18:44:45 *** Henrik <Henrik!~textual@84.212.107.177> has joined #bitcoin-core-dev
6692021-09-20T18:45:05 *** gnaf <gnaf!~gnaf@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
6702021-09-20T18:45:53 *** Henrik <Henrik!~textual@84.212.107.177> has quit IRC (Client Quit)
6712021-09-20T18:49:53 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6722021-09-20T18:50:01 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6732021-09-20T18:57:44 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6742021-09-20T18:57:52 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6752021-09-20T19:01:54 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6762021-09-20T19:02:01 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6772021-09-20T19:04:58 *** prayank <prayank!~andr0irc@51.158.144.32> has quit IRC (Read error: Connection reset by peer)
6782021-09-20T19:05:42 *** SpellChecker <SpellChecker!~SpellChec@gateway/tor-sasl/spellchecker> has quit IRC (Ping timeout: 276 seconds)
6792021-09-20T19:06:42 *** SpellChecker <SpellChecker!~SpellChec@gateway/tor-sasl/spellchecker> has joined #bitcoin-core-dev
6802021-09-20T19:14:29 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6812021-09-20T19:14:36 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6822021-09-20T19:17:44 *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
6832021-09-20T19:19:44 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 246 seconds)
6842021-09-20T19:19:45 *** Guyver2_ is now known as Guyver2
6852021-09-20T19:23:46 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6862021-09-20T19:23:53 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6872021-09-20T19:25:11 *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has joined #bitcoin-core-dev
6882021-09-20T19:26:04 *** AaronvanW <AaronvanW!~AaronvanW@190.242.161.186> has joined #bitcoin-core-dev
6892021-09-20T19:30:04 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6902021-09-20T19:30:13 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6912021-09-20T19:34:13 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6922021-09-20T19:34:21 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6932021-09-20T19:38:21 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6942021-09-20T19:38:29 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
6952021-09-20T19:39:44 *** Henrik <Henrik!~textual@84.212.107.177> has joined #bitcoin-core-dev
6962021-09-20T19:40:52 *** Henrik <Henrik!~textual@84.212.107.177> has quit IRC (Client Quit)
6972021-09-20T19:44:06 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
6982021-09-20T19:48:06 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
6992021-09-20T19:48:13 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
7002021-09-20T19:50:10 *** Kiminuo <Kiminuo!~Kiminuo@141.98.103.197> has joined #bitcoin-core-dev
7012021-09-20T19:50:30 <Kiminuo> Hi, would anyone know an answer for this https://github.com/bitcoin/bitcoin/pull/12677#discussion_r711712521?
7022021-09-20T19:54:31 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
7032021-09-20T19:54:38 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
7042021-09-20T19:57:04 <laanwj> Kiminuo: I think you're right
7052021-09-20T19:57:30 <sipa> just commented; i think ancestorfees should just use ValueFromAmount()?
7062021-09-20T19:57:45 <sipa> (i haven't followed the PR, perhaps there are reasons to deviate?)
7072021-09-20T19:58:07 <laanwj> i don't really understand it either
7082021-09-20T19:58:50 <laanwj> i think it's good practice to use ValueFromAmount unless there's good reason to deviate, like consistency within a RPC call
7092021-09-20T19:58:59 <sipa> right
7102021-09-20T19:59:05 *** Guyver2_ <Guyver2_!~Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
7112021-09-20T19:59:52 <laanwj> as listunspent uses btc-denominated amounts everywhere else it should there too
7122021-09-20T20:00:36 <laanwj> sorry for missing that before merge
7132021-09-20T20:01:02 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 246 seconds)
7142021-09-20T20:01:06 *** Guyver2_ is now known as Guyver2
7152021-09-20T20:06:21 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
7162021-09-20T20:06:28 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
7172021-09-20T20:08:08 *** smartin <smartin!~Icedove@88.135.18.171> has quit IRC (Quit: smartin)
7182021-09-20T20:12:09 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
7192021-09-20T20:12:16 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
7202021-09-20T20:17:00 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
7212021-09-20T20:17:07 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
7222021-09-20T20:17:49 <laanwj> (otoh this PR has been open since 2018, i'm sure it was good to move forward with it and fix some things in a follow-up)
7232021-09-20T20:17:59 <Kiminuo> laanwj: Finally, I found it https://github.com/bitcoin/bitcoin/pull/20484#issuecomment-734786305
7242021-09-20T20:18:57 <sipa> Kiminuo: but that's about feerate; this is a fee, not a feerate
7252021-09-20T20:18:57 <Kiminuo> This is a PR where I got the impression that "fee (rate)" is fine in sat/vB
7262021-09-20T20:19:24 <Kiminuo> sipa: ok, then
7272021-09-20T20:23:17 <Kiminuo> So just to have some conclusion here: Should I try to create a follow-up PR for the Luke's one to change `ancestorfees` to BTC denomination? Or is anyone calling dibs? :)
7282021-09-20T20:23:39 <laanwj> right, this is not per vB
7292021-09-20T20:24:12 <laanwj> well if you're going to change it, it needs to be changed before the release, once it's in a release for better or worse we're stuck with this inconsistency
7302021-09-20T20:24:39 <Kiminuo> how long till the next release?
7312021-09-20T20:24:57 <laanwj> #22969
7322021-09-20T20:24:58 <gribble> https://github.com/bitcoin/bitcoin/issues/22969 | Release schedule for 23.0 · Issue #22969 · bitcoin/bitcoin · GitHub
7332021-09-20T20:26:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
7342021-09-20T20:26:46 <bitcoin-git> [bitcoin] jonatack opened pull request #23050: log: change an incorrect fee to fee rate, and vice-versa (master...fee-vs-feerate) https://github.com/bitcoin/bitcoin/pull/23050
7352021-09-20T20:26:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
7362021-09-20T20:26:58 <Kiminuo> haha
7372021-09-20T20:27:26 <Kiminuo> I thought that Jon has just created the PR :)
7382021-09-20T20:27:29 <jonatack> hehe, thought this would be a good time to open this silly patch I've had on the side for a while
7392021-09-20T20:29:11 <jonatack> Kiminuo: confusion is normal....until Murch[m] opened my eyes to it a year ago, I didn't realize how often fees are mixed with fee rates/feerates
7402021-09-20T20:30:34 <Kiminuo> I should really check it here https://github.com/bitcoin/bitcoin/pull/21422 then :)
7412021-09-20T20:31:07 <Kiminuo> but you probably have discovered all invalid cases already
7422021-09-20T20:32:32 <jonatack> it was just something I wondered about during review of another pull, didn't look anywhere else
7432021-09-20T20:32:52 <Kiminuo> jonatack: https://github.com/bitcoin/bitcoin/pull/12677#pullrequestreview-759043318 - I don't really want to try to beat somebody in addressing these but I should have some time over the coming days to address that so I'll do it, ok? Saying that just because I don't want to compete with somebody
7442021-09-20T20:34:53 <jonatack> Kiminuo: sure. I don't plan to
7452021-09-20T20:38:46 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Quit: ZNC - http://znc.sourceforge.net)
7462021-09-20T20:39:50 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
7472021-09-20T20:40:53 *** jesseposner <jesseposner!~jesse@c-24-5-105-39.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
7482021-09-20T20:43:24 <luke-jr> Kiminuo: laanwj: all other ancestorfees use satoshis
7492021-09-20T20:44:45 <sipa> oh, that's a good reason
7502021-09-20T20:45:00 <luke-jr> I'm not sure about the doc type tho. Maybe it should be NUM or such
7512021-09-20T20:46:21 <sipa> right
7522021-09-20T20:50:18 <jonatack> luke-jr: not sure it's related, but in #22689 (open) the four mempool rpcs are returning the ancestor fee fields and others in BTC, maybe have a look
7532021-09-20T20:50:21 <gribble> https://github.com/bitcoin/bitcoin/issues/22689 | rpc: deprecate top-level fee fields in getmempool RPCs by josibake · Pull Request #22689 · bitcoin/bitcoin · GitHub
7542021-09-20T20:51:04 <jonatack> where some were previously in satoshis
7552021-09-20T20:53:11 <laanwj> listunspent is a wallet RPC call, i think it's strange to have the amount in BTC and then the fees in satoshis
7562021-09-20T20:54:26 *** Jackielove4u <Jackielove4u!uid43977@user/jackielove4u> has joined #bitcoin-core-dev
7572021-09-20T20:54:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
7582021-09-20T20:54:42 <bitcoin-git> [bitcoin] gruve-p closed pull request #22961: Update zmq to 4.3.4 (master...zmq-update) https://github.com/bitcoin/bitcoin/pull/22961
7592021-09-20T20:54:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
7602021-09-20T20:54:47 <laanwj> if you have quantities that you could plausibly compare it makes sense to use the same unit
7612021-09-20T20:55:26 <laanwj> fee*rate* and amount are clearly different units of course
7622021-09-20T20:55:40 <laanwj> i don't think you can say the same for fee and amount
7632021-09-20T20:57:30 <laanwj> but i'm sure this is very controversial for some reason, sorry for merging something that makes things even more of a mess
7642021-09-20T20:59:37 <jonatack> "this PR has been open since 2018, i'm sure it was good to move forward with it and fix some things in a follow-up" ... agree :) admirable patience by luke, too
7652021-09-20T21:00:35 *** jesseposner <jesseposner!~jesse@c-24-5-105-39.hsd1.ca.comcast.net> has quit IRC (Ping timeout: 252 seconds)
7662021-09-20T21:02:08 *** jesseposner <jesseposner!~jesse@c-24-5-105-39.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
7672021-09-20T21:02:34 <laanwj> yes exactly
7682021-09-20T21:02:55 *** jeremyrubin <jeremyrubin!~jeremyrub@047-025-087-245.res.spectrum.com> has joined #bitcoin-core-dev
7692021-09-20T21:05:48 *** jeremyrubin <jeremyrubin!~jeremyrub@047-025-087-245.res.spectrum.com> has quit IRC (Client Quit)
7702021-09-20T21:07:18 *** jeremy <jeremy!~jeremy@ec2-44-199-24-18.compute-1.amazonaws.com> has joined #bitcoin-core-dev
7712021-09-20T21:07:37 <jeremy> ð finally got my IRC setup working again, I hope :)
7722021-09-20T21:07:56 <jeremy> Can folks see this?
7732021-09-20T21:08:00 <laanwj> jeremy: welcome!
7742021-09-20T21:15:56 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
7752021-09-20T21:16:04 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
7762021-09-20T21:16:46 <luke-jr> Libera working is easy. Try getting on freenode these days otoh⦠>_<
7772021-09-20T21:18:11 *** jeremy <jeremy!~jeremy@ec2-44-199-24-18.compute-1.amazonaws.com> has quit IRC (Quit: The Lounge - https://thelounge.chat)
7782021-09-20T21:18:50 *** jeremy <jeremy!~jeremy@ec2-44-199-24-18.compute-1.amazonaws.com> has joined #bitcoin-core-dev
7792021-09-20T21:23:09 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
7802021-09-20T21:23:17 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
7812021-09-20T21:28:41 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
7822021-09-20T21:28:49 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
7832021-09-20T21:30:42 <achow101> sipa: I had left the same comment during review: https://github.com/bitcoin/bitcoin/pull/12677#discussion_r707609663
7842021-09-20T21:32:25 <achow101> ancestorfees in satoshis is used everywhere we have mempool entries in the RPC. except that that format is deprecated and has been replaced with one that has the fees in BTC
7852021-09-20T21:33:58 *** Henrik <Henrik!~textual@84.212.107.177> has joined #bitcoin-core-dev
7862021-09-20T21:42:03 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
7872021-09-20T21:42:11 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
7882021-09-20T21:47:14 *** Henrik <Henrik!~textual@84.212.107.177> has quit IRC (Quit: My MacBook Air has gone to sleep. ZZZzzzâ¦)
7892021-09-20T21:47:22 *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
7902021-09-20T21:51:22 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
7912021-09-20T21:51:31 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
7922021-09-20T21:58:35 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
7932021-09-20T21:58:43 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
7942021-09-20T22:00:40 <luke-jr> should we just drop ancestorfees and replace it with â? then?
7952021-09-20T22:04:40 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
7962021-09-20T22:04:48 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
7972021-09-20T22:10:22 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
7982021-09-20T22:10:30 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
7992021-09-20T22:22:21 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8002021-09-20T22:22:28 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8012021-09-20T22:26:14 *** gene <gene!~gene@gateway/tor-sasl/gene> has joined #bitcoin-core-dev
8022021-09-20T22:26:24 *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has joined #bitcoin-core-dev
8032021-09-20T22:37:16 *** stonefox <stonefox!~stonefox@user/stonefox> has quit IRC (Ping timeout: 252 seconds)
8042021-09-20T22:40:41 *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has quit IRC (Remote host closed the connection)
8052021-09-20T22:40:55 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
8062021-09-20T22:44:55 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8072021-09-20T22:45:03 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8082021-09-20T22:52:32 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8092021-09-20T22:52:40 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8102021-09-20T22:56:40 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8112021-09-20T22:56:49 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8122021-09-20T22:57:05 *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
8132021-09-20T23:01:06 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8142021-09-20T23:01:14 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8152021-09-20T23:05:14 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8162021-09-20T23:05:22 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8172021-09-20T23:09:23 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8182021-09-20T23:09:30 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8192021-09-20T23:15:38 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 246 seconds)
8202021-09-20T23:19:38 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8212021-09-20T23:19:39 *** gene <gene!~gene@gateway/tor-sasl/gene> has quit IRC (Remote host closed the connection)
8222021-09-20T23:19:46 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8232021-09-20T23:20:09 *** gene <gene!~gene@gateway/tor-sasl/gene> has joined #bitcoin-core-dev
8242021-09-20T23:24:11 *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has joined #bitcoin-core-dev
8252021-09-20T23:26:42 *** gene <gene!~gene@gateway/tor-sasl/gene> has quit IRC (Quit: gene)
8262021-09-20T23:31:30 *** bomb-on <bomb-on!~bomb-on@194.144.47.113> has quit IRC (Quit: aллилѹÑа!)
8272021-09-20T23:35:31 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8282021-09-20T23:35:39 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8292021-09-20T23:40:51 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8302021-09-20T23:40:58 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8312021-09-20T23:44:04 *** Jackielove4u <Jackielove4u!uid43977@user/jackielove4u> has quit IRC (Quit: Connection closed for inactivity)
8322021-09-20T23:48:04 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8332021-09-20T23:48:12 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8342021-09-20T23:52:12 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8352021-09-20T23:52:20 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev
8362021-09-20T23:56:20 *** c_arc <c_arc!~c_arc@4.53.92.114> has quit IRC (Remote host closed the connection)
8372021-09-20T23:56:28 *** c_arc <c_arc!~c_arc@4.53.92.114> has joined #bitcoin-core-dev