12021-12-17T00:09:48 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Remote host closed the connection)
22021-12-17T00:10:22 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
32021-12-17T00:17:13 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 268 seconds)
42021-12-17T00:35:47 *** gnaf <gnaf!~pi@86-91-224-60.opennet.kpn.net> has quit IRC (Quit: Konversation terminated!)
52021-12-17T00:48:20 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
62021-12-17T00:52:37 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
72021-12-17T00:54:34 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
82021-12-17T01:00:04 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
92021-12-17T01:07:04 *** bomb-on_ <bomb-on_!~bomb-on@213.220.127.153> has quit IRC (Quit: aллилѹÑа!)
102021-12-17T01:08:49 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC ()
112021-12-17T01:13:48 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
122021-12-17T01:24:58 *** ZeroMaster <ZeroMaster!~webirc@95-42-105-42.ip.btc-net.bg> has quit IRC (Ping timeout: 260 seconds)
132021-12-17T01:59:37 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
142021-12-17T02:08:16 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
152021-12-17T02:08:16 <bitcoin-git> [bitcoin] fanquake closed pull request #23793: validation: Revert "de-duplicate package transactions already in mempool" (master...2021-12-revert-package-dedup) https://github.com/bitcoin/bitcoin/pull/23793
162021-12-17T02:08:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
172021-12-17T02:15:10 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
182021-12-17T02:15:33 *** jtrag is now known as Guest5903
192021-12-17T02:15:58 *** jtrag_ is now known as jtrag
202021-12-17T02:17:38 *** masta`` <masta``!~oyster@user/masta/x-2645138> has quit IRC (Remote host closed the connection)
212021-12-17T02:18:41 *** Guest5903 <Guest5903!~jtrag@user/jtrag> has quit IRC (Ping timeout: 256 seconds)
222021-12-17T02:19:27 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
232021-12-17T02:26:40 *** An0rak <An0rak!An0rak@user/an0rak> has joined #bitcoin-core-dev
242021-12-17T02:27:57 *** earnestly <earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 240 seconds)
252021-12-17T02:52:32 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
262021-12-17T02:54:29 *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has quit IRC (Quit: ZzzZ)
272021-12-17T02:56:56 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 268 seconds)
282021-12-17T03:18:11 *** jb55 <jb55!~jb55@S010660e327dca171.vc.shawcable.net> has quit IRC (Ping timeout: 256 seconds)
292021-12-17T03:21:02 *** jespada <jespada!~jespada@87.74.33.157> has quit IRC (Ping timeout: 240 seconds)
302021-12-17T03:23:04 *** jespada <jespada!~jespada@87.74.33.157> has joined #bitcoin-core-dev
312021-12-17T03:25:32 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
322021-12-17T03:38:01 *** mikehu44 <mikehu44!~quassel@206.189.41.250> has joined #bitcoin-core-dev
332021-12-17T03:38:46 *** jtrag_ is now known as jtrag
342021-12-17T03:42:30 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
352021-12-17T03:45:37 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
362021-12-17T03:47:37 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
372021-12-17T03:51:53 *** mikehu44 <mikehu44!~quassel@206.189.41.250> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
382021-12-17T03:52:11 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 256 seconds)
392021-12-17T03:53:50 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
402021-12-17T04:02:52 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has joined #bitcoin-core-dev
412021-12-17T04:07:29 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has quit IRC (Ping timeout: 256 seconds)
422021-12-17T04:13:04 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has joined #bitcoin-core-dev
432021-12-17T04:24:20 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has quit IRC (Remote host closed the connection)
442021-12-17T04:35:28 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Remote host closed the connection)
452021-12-17T04:40:22 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
462021-12-17T04:41:09 *** jtrag_ is now known as jtrag
472021-12-17T04:41:50 *** mikehu44 <mikehu44!~quassel@183.36.228.41> has joined #bitcoin-core-dev
482021-12-17T04:44:37 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
492021-12-17T04:47:49 *** mikehu44 <mikehu44!~quassel@183.36.228.41> has quit IRC (Ping timeout: 240 seconds)
502021-12-17T04:48:19 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
512021-12-17T05:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
522021-12-17T05:01:24 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
532021-12-17T05:08:19 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
542021-12-17T05:12:32 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
552021-12-17T05:15:31 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
562021-12-17T05:19:06 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 245 seconds)
572021-12-17T05:28:06 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 276 seconds)
582021-12-17T05:37:48 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
592021-12-17T05:44:54 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
602021-12-17T05:45:57 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
612021-12-17T05:52:00 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
622021-12-17T05:52:44 *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has joined #bitcoin-core-dev
632021-12-17T05:55:02 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
642021-12-17T05:56:08 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
652021-12-17T05:57:26 *** jtrag_ is now known as Anubiset
662021-12-17T05:59:17 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
672021-12-17T05:59:27 *** MattCorallo[m] <MattCorallo[m]!~mattbitco@2001:470:69fc:105::1:5092> has joined #bitcoin-core-dev
682021-12-17T05:59:31 *** Anubiset is now known as jtrag
692021-12-17T06:06:51 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
702021-12-17T06:16:08 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
712021-12-17T06:20:17 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
722021-12-17T06:28:13 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has joined #bitcoin-core-dev
732021-12-17T06:33:47 *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has quit IRC (Quit: ZzzZ)
742021-12-17T06:43:55 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
752021-12-17T06:46:57 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
762021-12-17T06:51:33 *** jtrag_ is now known as jtrag
772021-12-17T06:52:04 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
782021-12-17T06:56:13 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
792021-12-17T07:00:37 *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has joined #bitcoin-core-dev
802021-12-17T07:01:00 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has quit IRC (Remote host closed the connection)
812021-12-17T07:02:05 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has joined #bitcoin-core-dev
822021-12-17T07:06:32 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has quit IRC (Ping timeout: 240 seconds)
832021-12-17T07:21:58 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has joined #bitcoin-core-dev
842021-12-17T07:25:18 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
852021-12-17T07:29:37 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
862021-12-17T07:39:57 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has quit IRC (Ping timeout: 240 seconds)
872021-12-17T07:40:17 *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has quit IRC (Quit: ZzzZ)
882021-12-17T07:46:33 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 276 seconds)
892021-12-17T07:55:45 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
902021-12-17T07:58:26 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
912021-12-17T08:02:51 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 245 seconds)
922021-12-17T08:07:19 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
932021-12-17T08:10:37 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
942021-12-17T08:12:01 *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has joined #bitcoin-core-dev
952021-12-17T08:19:40 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has joined #bitcoin-core-dev
962021-12-17T08:24:20 <vasild> ACK achow101 wallet maintainer
972021-12-17T08:35:49 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has quit IRC (Ping timeout: 240 seconds)
982021-12-17T08:44:04 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
992021-12-17T08:44:13 *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
1002021-12-17T08:46:04 *** earnestly <earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
1012021-12-17T08:48:17 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
1022021-12-17T08:49:03 *** gleb74 <gleb74!~gleb@178.150.137.228> has quit IRC (Ping timeout: 268 seconds)
1032021-12-17T08:50:03 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
1042021-12-17T08:51:10 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
1052021-12-17T08:52:51 *** Guest7824 <Guest7824!~Guest78@183.233.81.228> has joined #bitcoin-core-dev
1062021-12-17T08:52:57 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
1072021-12-17T08:53:20 *** Guest7824 <Guest7824!~Guest78@183.233.81.228> has quit IRC (Client Quit)
1082021-12-17T09:06:51 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has joined #bitcoin-core-dev
1092021-12-17T09:15:41 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
1102021-12-17T09:20:30 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 260 seconds)
1112021-12-17T09:25:23 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has quit IRC (Ping timeout: 256 seconds)
1122021-12-17T09:27:46 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has joined #bitcoin-core-dev
1132021-12-17T09:31:57 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has quit IRC (Ping timeout: 240 seconds)
1142021-12-17T09:32:14 <darosior> ACK achow101 maintainer
1152021-12-17T09:37:28 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
1162021-12-17T09:39:39 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
1172021-12-17T09:41:29 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 268 seconds)
1182021-12-17T09:44:37 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
1192021-12-17T09:49:50 *** gnaf <gnaf!~pi@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
1202021-12-17T09:56:08 *** jtrag_ is now known as jtrag
1212021-12-17T10:03:20 *** kexkey <kexkey!~kexkey@static-198-54-132-121.cust.tzulo.com> has quit IRC (Ping timeout: 252 seconds)
1222021-12-17T10:04:35 *** kexkey <kexkey!~kexkey@static-198-54-132-105.cust.tzulo.com> has joined #bitcoin-core-dev
1232021-12-17T10:11:53 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has joined #bitcoin-core-dev
1242021-12-17T10:20:20 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
1252021-12-17T10:24:37 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
1262021-12-17T10:30:33 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has quit IRC (Ping timeout: 256 seconds)
1272021-12-17T10:34:34 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
1282021-12-17T10:38:12 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 268 seconds)
1292021-12-17T10:38:34 *** jtrag__ <jtrag__!~jtrag@user/jtrag> has joined #bitcoin-core-dev
1302021-12-17T10:38:59 *** jtrag__ is now known as jtrag
1312021-12-17T10:39:27 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 276 seconds)
1322021-12-17T10:42:10 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has quit IRC (Ping timeout: 260 seconds)
1332021-12-17T10:47:14 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Read error: Connection reset by peer)
1342021-12-17T10:47:38 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
1352021-12-17T10:48:52 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
1362021-12-17T10:52:05 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 256 seconds)
1372021-12-17T10:52:13 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has joined #bitcoin-core-dev
1382021-12-17T10:53:15 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
1392021-12-17T10:56:37 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 256 seconds)
1402021-12-17T10:57:38 *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has quit IRC (Quit: ZzzZ)
1412021-12-17T10:59:12 <glozow> ACK giving fanquake permission to block accounts posting spam. Framing it as a "power" is a misrepresentation; it's always just cleaning up meaningless gibberish afaict. Requiring him to ask someone else does nothing but slow progress on the repo.
1422021-12-17T10:59:58 *** jtrag_ is now known as jtrag
1432021-12-17T11:02:07 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Read error: Connection reset by peer)
1442021-12-17T11:02:18 <glozow> ACK achow101 wallet maintainer, imo it's very appropriate for someone with extensive knowledge+authorship of the wallet codebase to maintain it
1452021-12-17T11:03:55 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
1462021-12-17T11:04:49 <earnestly> glozow: ('accounts posting spam' don't exist as a category external to 'accounts posting not-spam' and so the power to block accounts encompasses both)
1472021-12-17T11:06:31 <glozow> earnestly: it would be extremely obvious if an account posting not-spam was blocked, so I see no risk of anybody abusing the privilege.
1482021-12-17T11:06:55 <earnestly> Yeah I don't disagree, but the framing isn't wrong
1492021-12-17T11:07:24 <earnestly> (More a limitation of github really)
1502021-12-17T11:07:36 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
1512021-12-17T11:13:57 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
1522021-12-17T11:14:53 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Read error: Connection reset by peer)
1532021-12-17T11:14:53 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has quit IRC (Read error: Connection reset by peer)
1542021-12-17T11:15:49 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
1552021-12-17T11:17:48 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 276 seconds)
1562021-12-17T11:21:49 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
1572021-12-17T11:22:52 <glozow> earnestly: yeah it'd be nice if github could automatically block when obvious spam is obvious
1582021-12-17T11:25:41 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has quit IRC (Ping timeout: 268 seconds)
1592021-12-17T11:26:09 <earnestly> glozow: Hm, I was thinking more about multiple confirmations needed for an action
1602021-12-17T11:26:19 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
1612021-12-17T11:27:02 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
1622021-12-17T11:27:12 *** jtrag is now known as Guest9045
1632021-12-17T11:27:57 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
1642021-12-17T11:28:26 <laanwj> the goal was be to speed things up, not slow them down even further
1652021-12-17T11:28:26 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has joined #bitcoin-core-dev
1662021-12-17T11:29:21 <glozow> laanwj: +1
1672021-12-17T11:30:13 *** Guest9045 <Guest9045!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
1682021-12-17T11:30:48 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
1692021-12-17T11:30:57 <laanwj> i'm not sure what the fear here is, it seems to me the community around bitcoin dev is sufficiently diffuse and loosely organized that there's ton of ways for someone who is banned in error to have recourse
1702021-12-17T11:31:58 *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has joined #bitcoin-core-dev
1712021-12-17T11:32:53 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has quit IRC (Ping timeout: 256 seconds)
1722021-12-17T11:33:36 <laanwj> like just that fanquake has disagreed with you on an issue once or refused to merge it doesn't mean he'll just ban you now instead, that was definitely not the idea, there's quite some arguing in bad faith going on
1732021-12-17T11:37:30 <fanquake> i guess people are concerned that after 8-9 years of reputation building and project contributions, for some reason I'm going to undermine it all by abusing the ability to block people on GitHub
1742021-12-17T11:37:38 <laanwj> yessss
1752021-12-17T11:37:42 <laanwj> block block block you're all blocked
1762021-12-17T11:37:46 <fanquake> At this point I really don't care, this discussion has already wasted too much bandwidth.
1772021-12-17T11:37:52 <fanquake> I'd much prefer it if people spent that time scrutinising the code I write, and merge. The build system & related code is an area that could always use more eyes over it.
1782021-12-17T11:37:57 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 276 seconds)
1792021-12-17T11:38:13 <laanwj> agree
1802021-12-17T11:38:17 <earnestly> fanquake: If it matters, I already trust your pgp for signed commits
1812021-12-17T11:38:36 <laanwj> it's really a distortion of what matters
1822021-12-17T11:38:56 <earnestly> So the ability to block accounts is pretty minor compared to that
1832021-12-17T11:40:24 <laanwj> and what the risks are
1842021-12-17T11:46:07 <michaelfolkson> Sorry, unrelated question. Where's the dev wiki gone in the Core repo?
1852021-12-17T11:46:42 <laanwj> thanks for the easy question. it's at https://github.com/bitcoin-core/bitcoin-devwiki/wiki
1862021-12-17T11:47:07 <michaelfolkson> Thanks, the tab has disappeared :)
1872021-12-17T11:48:05 <laanwj> i haven't noticed anything different in that regard
1882021-12-17T11:48:45 <michaelfolkson> I thought it was this new Projects thing moving the tab
1892021-12-17T11:49:15 <laanwj> the new projects thing did make me worry yesterday, it looked like all the projects were gone
1902021-12-17T11:49:51 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
1912021-12-17T11:49:56 <laanwj> i don't understand why there's Projects [beta] and Projects now it confuses me but i'm sure it will seem normal soon enough
1922021-12-17T11:51:32 <michaelfolkson> On the permissions thing, it is more than just blocking right? An owner could say remove you as a co-owner right laanwj?
1932021-12-17T11:51:51 <michaelfolkson> I'm using "owner" as the GitHub definition
1942021-12-17T11:52:03 <laanwj> michaelfolkson: yes. sometimes i wish they did
1952021-12-17T11:53:33 <michaelfolkson> I don't think there's an argument against fanquake whatsoever but I think we generally all trust laanwj's stewardship after all these years and so adding someone new makes some people uncomfortable
1962021-12-17T11:54:07 <michaelfolkson> But if someone is to be added fanquake ticks all the boxes imo
1972021-12-17T11:54:14 *** Guest52 <Guest52!~Guest52@188.134.84.205> has joined #bitcoin-core-dev
1982021-12-17T11:55:30 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 276 seconds)
1992021-12-17T11:57:52 *** Guest52 <Guest52!~Guest52@188.134.84.205> has quit IRC (Client Quit)
2002021-12-17T11:58:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2012021-12-17T11:58:01 <bitcoin-git> [bitcoin] shaavan opened pull request #23801: Refactor: Change time variable type from int64_t to std::chrono::seconds in net_processing.cpp (master...time_in_seconds_refactor) https://github.com/bitcoin/bitcoin/pull/23801
2022021-12-17T11:58:04 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2032021-12-17T11:58:28 <laanwj> michaelfolkson: agree
2042021-12-17T11:59:03 *** jtrag_ is now known as jtrag
2052021-12-17T11:59:31 <glozow> laanwj: do you have any objections to it? you're the person who would grant permissions right?
2062021-12-17T11:59:36 <michaelfolkson> But yeah it is a credit to yourself laanwj that we generally all trust your stewardship :)
2072021-12-17T12:00:18 <michaelfolkson> (I guess I shouldn't project my views on others without confirming but I'm sure that's the case)
2082021-12-17T12:00:20 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
2092021-12-17T12:03:43 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has joined #bitcoin-core-dev
2102021-12-17T12:07:32 <laanwj> glozow: no objections myself, but i do think it's important that people developing bitcoin core widely agree on it (which seems to be the case)
2112021-12-17T12:08:01 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has quit IRC (Ping timeout: 256 seconds)
2122021-12-17T12:08:40 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
2132021-12-17T12:14:21 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 276 seconds)
2142021-12-17T12:15:03 <michaelfolkson> In normal times I'm sure it will be an irrelevance. It is just those stressful, strained times when under pressure someone could do something they later regret
2152021-12-17T12:17:03 <michaelfolkson> But thankfully/hopefully they seem to occur very rarely
2162021-12-17T12:19:45 <MarcoFalke> I don't think fanquake has ever done something they regretted later. I also hope no one is stressed. Taking time off might fix stress.
2172021-12-17T12:22:09 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 276 seconds)
2182021-12-17T12:22:43 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
2192021-12-17T12:23:19 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has joined #bitcoin-core-dev
2202021-12-17T12:24:10 <glozow> laanwj: indeed!
2212021-12-17T12:25:37 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
2222021-12-17T12:26:02 *** bomb-on <bomb-on!~bomb-on@213.220.127.153> has joined #bitcoin-core-dev
2232021-12-17T12:27:41 *** jtrag_ is now known as jtrag
2242021-12-17T12:28:55 <michaelfolkson> There's no rush, take some time off and hopefully come back refreshed in the new year laanwj :)
2252021-12-17T12:29:49 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
2262021-12-17T12:30:13 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
2272021-12-17T12:31:10 *** jtrag__ <jtrag__!~jtrag@user/jtrag> has joined #bitcoin-core-dev
2282021-12-17T12:33:31 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 256 seconds)
2292021-12-17T12:34:37 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
2302021-12-17T12:36:43 *** jtrag__ is now known as jtrag
2312021-12-17T12:39:02 *** bomb-on <bomb-on!~bomb-on@213.220.127.153> has quit IRC (Read error: Connection reset by peer)
2322021-12-17T12:43:26 <provoostenator> ack en congrats achow101 wallet maintainer
2332021-12-17T12:44:59 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
2342021-12-17T12:45:16 <michaelfolkson> +1
2352021-12-17T12:46:37 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has quit IRC (Ping timeout: 240 seconds)
2362021-12-17T12:46:44 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has quit IRC (Client Quit)
2372021-12-17T12:46:51 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Read error: Connection reset by peer)
2382021-12-17T12:51:18 <provoostenator> fanquake: carefully building a reputation over many years and then suddenly destroying it, is a common theme in this industry. But usually not by blocking spammers on Github :-)
2392021-12-17T13:01:23 *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
2402021-12-17T13:05:21 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 245 seconds)
2412021-12-17T13:08:29 <meshcollider> Why block spammers, they're some of our most active PR and issue reviewers :)
2422021-12-17T13:10:37 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has joined #bitcoin-core-dev
2432021-12-17T13:14:15 <meshcollider> Also I have no idea why Luke's lone objection is still holding things up re: fanquake. Just ignore him and do it, his opinion should not outweigh literally every other dev here...
2442021-12-17T13:15:01 <meshcollider> Consensus does not mean absolute agreement
2452021-12-17T13:19:02 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
2462021-12-17T13:19:56 <michaelfolkson> I don't think it would just be Luke with concerns on granting co-owner privileges on the repo to an additional person(s) ignoring who that person is
2472021-12-17T13:20:53 <michaelfolkson> GitHub causes all sorts of unnecessary aggro
2482021-12-17T13:21:58 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
2492021-12-17T13:22:57 *** masta`` <masta``!~oyster@user/masta/x-2645138> has joined #bitcoin-core-dev
2502021-12-17T13:23:09 <meshcollider> I thought those same people argue against putting any trust into GitHub and this specific repo anyway ...
2512021-12-17T13:24:06 <meshcollider> michaelfolkson: it is very clear that everyone speaking out is in favour except Luke and prayank, both for unrelated personal reasons
2522021-12-17T13:24:40 <michaelfolkson> You minimize trust in GitHub but it can't go to zero during high pressure scenarios
2532021-12-17T13:25:25 <meshcollider> ...
2542021-12-17T13:25:36 <michaelfolkson> And similarly with the Core repo I guess
2552021-12-17T13:25:40 *** gleb74 <gleb74!~gleb@178.150.137.228> has joined #bitcoin-core-dev
2562021-12-17T13:26:00 <laanwj> i mean in the end the github structure is contingent, it's not a representation of any formal power structure within bitcoin, if someone would really mess up the onus of development would simply move somewhere else
2572021-12-17T13:26:37 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has quit IRC (Ping timeout: 240 seconds)
2582021-12-17T13:27:03 <meshcollider> Exactly, and that's a negligible chance anyway when the only people in question are some of the longest-standing and trusted contributors...
2592021-12-17T13:27:07 <michaelfolkson> Right but it would be messy
2602021-12-17T13:27:22 <meshcollider> michaelfolkson: stop fearmongering
2612021-12-17T13:27:48 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 276 seconds)
2622021-12-17T13:28:32 <michaelfolkson> I guess the elephant in the room is that some people wanted to remove Luke as a BIP editor earlier in the year. And rightly in my view laanwj didn't succumb to that pressure as there should be separation between Core and BIPs
2632021-12-17T13:28:42 <michaelfolkson> So I'm not deliberately fearmongering
2642021-12-17T13:29:04 <laanwj> it would but the same has to happen if we can't function efficiently and all project-level decisions are delayed or postponed indefinitely of course
2652021-12-17T13:29:23 <meshcollider> But along the same lines, kalle was added despite Luke's objections there. Luke is almost always the only one objecting to these things
2662021-12-17T13:29:24 <michaelfolkson> Maybe an additional owner of the repo would have acted differently in that scenario
2672021-12-17T13:30:17 <michaelfolkson> A BIP editor who had been performing that role on his own for what 5+ years?
2682021-12-17T13:32:35 <laanwj> that the bips repository is in the same organization is somewhat questionable in any case
2692021-12-17T13:33:14 <meshcollider> A single BIP editor is also not very decentralised so that's not a good thing.
2702021-12-17T13:33:45 <michaelfolkson> Right, we've got an additional one now which is great. But still people wanted to remove Luke
2712021-12-17T13:34:40 <michaelfolkson> [12:15:03] <michaelfolkson> In normal times I'm sure it will be an irrelevance. It is just those stressful, strained times when under pressure someone could do something they later regret
2722021-12-17T13:35:53 <meshcollider> Also, admin perms on bitcoin/bitcoin doesn't require admin on bitcoin/BIPs
2732021-12-17T13:35:54 <MarcoFalke> I don't think anyone wanted to *remove* luke? I understood it as *adding* kalle, but I am not interested in rehashing the discussion here, so I probably shouldn't comment.
2742021-12-17T13:36:41 <meshcollider> michaelfolkson: anyway, please don't perpetuate this discussion when apparently you're not actually objecting, and please leave it to dev consensus
2752021-12-17T13:36:44 <laanwj> i'm not aware of anying asking to remove Luke either-just to add kallewoof
2762021-12-17T13:38:36 <earnestly> (In disagreements focus hard on creating a set of measurable steps to solve whatever problem is causing it, sideline much of the purposeless discussion)
2772021-12-17T13:40:17 <earnestly> From my lurking here I've not really seen anyone lay out a clear rationale for disagrement, usually because the other side refuses to acknowledge any aspect of it (and is quickly derailed into useless details), or because they don't have one.
2782021-12-17T13:40:46 <michaelfolkson> meshcollider: I'm not objecting to fanquake as an additional owner of the repo if we get an additional owner of the repo. Just thinking through long term implications and being told that is fearmongering
2792021-12-17T13:41:01 <michaelfolkson> But I'm repeating myself so I'll leave
2802021-12-17T13:41:12 <meshcollider> There is no problem. fanquake should be given permissions because the supermajority of devs agree and those against have no valid objections. That's it.
2812021-12-17T13:41:49 <jnewbery> meshcollider: +1
2822021-12-17T13:41:53 <earnestly> > there is no problem if we redefine the problem to exclude the problem
2832021-12-17T13:42:05 <earnestly> redefine the solution*
2842021-12-17T13:42:43 <michaelfolkson> Happy to provide links to attempts to remove Luke as a BIP editor if they are needed though
2852021-12-17T13:42:57 <earnestly> (Tbh, I've never seen a clear rationale given as to why fanquake shouldn't have permission to block accounts, usually because those against it don't explain themselves and there is no dialog with those who disagree. But I could easily have missed it too)
2862021-12-17T13:44:11 <laanwj> so about reviewing PRs...
2872021-12-17T13:49:16 <_aj_> laanwj: awww, mum, do we have to?
2882021-12-17T13:50:28 <MarcoFalke> (Ok, some people might have asked for luke to be removed, but I hope my memory doesn't fail me telling me I was not one of them)
2892021-12-17T13:51:05 <laanwj> _aj_: hehehe yess u should all review a PR and then if you still have energy to argue u can get back to discussion here
2902021-12-17T13:54:21 *** littlesh <littlesh!~Username@bras-base-clwdon2201w-grc-49-174-89-151-72.dsl.bell.ca> has joined #bitcoin-core-dev
2912021-12-17T13:56:48 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has joined #bitcoin-core-dev
2922021-12-17T14:01:21 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has quit IRC (Ping timeout: 256 seconds)
2932021-12-17T14:05:10 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
2942021-12-17T14:14:00 *** arythmetic <arythmetic!~arythmeti@2607:fea8:85c1:db00:91ca:42ff:4987:327> has quit IRC (Remote host closed the connection)
2952021-12-17T14:14:46 *** sirdigby727 <sirdigby727!uid523338@id-523338.lymington.irccloud.com> has joined #bitcoin-core-dev
2962021-12-17T14:16:41 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has joined #bitcoin-core-dev
2972021-12-17T14:16:53 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
2982021-12-17T14:18:21 *** littlesh <littlesh!~Username@bras-base-clwdon2201w-grc-49-174-89-151-72.dsl.bell.ca> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
2992021-12-17T14:19:24 *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has quit IRC (Read error: Connection reset by peer)
3002021-12-17T14:21:13 *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has joined #bitcoin-core-dev
3012021-12-17T14:28:05 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
3022021-12-17T14:31:18 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has quit IRC (Ping timeout: 268 seconds)
3032021-12-17T14:47:45 *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has quit IRC (Quit: ZzzZ)
3042021-12-17T14:50:16 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
3052021-12-17T14:50:53 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
3062021-12-17T14:53:17 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
3072021-12-17T14:54:02 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
3082021-12-17T14:55:49 *** jtrag__ <jtrag__!~jtrag@user/jtrag> has joined #bitcoin-core-dev
3092021-12-17T14:57:50 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has quit IRC (Ping timeout: 268 seconds)
3102021-12-17T14:59:09 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 256 seconds)
3112021-12-17T15:00:25 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has joined #bitcoin-core-dev
3122021-12-17T15:03:47 *** roconnor <roconnor!~roconnor@coq/roconnor> has quit IRC (Quit: Konversation terminated!)
3132021-12-17T15:04:49 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has quit IRC (Ping timeout: 256 seconds)
3142021-12-17T15:14:07 *** evbo <evbo!~bosats@2601:47:4383:560:c4f4:19bb:83c5:f3a3> has joined #bitcoin-core-dev
3152021-12-17T15:14:44 *** arythmetic <arythmetic!~arythmeti@2607:fea8:85c1:db00:281c:2687:8a9e:e263> has joined #bitcoin-core-dev
3162021-12-17T15:18:57 *** arythmetic <arythmetic!~arythmeti@2607:fea8:85c1:db00:281c:2687:8a9e:e263> has quit IRC (Ping timeout: 240 seconds)
3172021-12-17T15:19:35 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has joined #bitcoin-core-dev
3182021-12-17T15:21:02 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Remote host closed the connection)
3192021-12-17T15:21:10 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
3202021-12-17T15:21:36 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
3212021-12-17T15:22:02 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
3222021-12-17T15:22:19 *** jtrag__ is now known as jtrag
3232021-12-17T15:26:11 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 268 seconds)
3242021-12-17T15:30:04 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
3252021-12-17T15:34:17 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
3262021-12-17T15:35:26 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has quit IRC (Ping timeout: 268 seconds)
3272021-12-17T15:38:58 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
3282021-12-17T15:41:57 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
3292021-12-17T15:47:33 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3302021-12-17T15:47:33 <bitcoin-git> [bitcoin] laanwj closed pull request #22786: Fix ScriptNum Tests (master...fix_scriptnum_test) https://github.com/bitcoin/bitcoin/pull/22786
3312021-12-17T15:47:34 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3322021-12-17T15:48:14 *** zonemix <zonemix!~zonemix@216.16.35.204> has joined #bitcoin-core-dev
3332021-12-17T15:49:17 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
3342021-12-17T15:52:13 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
3352021-12-17T15:53:52 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
3362021-12-17T15:56:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3372021-12-17T15:56:43 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8c0bd871fcf6...4ad59042b359
3382021-12-17T15:56:43 <bitcoin-git> bitcoin/master 65ef932 stratospher: [fuzz] Add D. J. Bernstein's implementation of ChaCha20
3392021-12-17T15:56:43 <bitcoin-git> bitcoin/master 4d0ac72 stratospher: [fuzz] Add fuzzing harness to compare both implementations of ChaCha20
3402021-12-17T15:56:43 <bitcoin-git> bitcoin/master 4ad5904 W. J. van der Laan: Merge bitcoin/bitcoin#22704: fuzz: Differential fuzzing to compare Bitcoin...
3412021-12-17T15:56:45 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3422021-12-17T15:56:57 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
3432021-12-17T15:57:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3442021-12-17T15:57:00 <bitcoin-git> [bitcoin] laanwj merged pull request #22704: fuzz: Differential fuzzing to compare Bitcoin Core's and D. J. Bernstein's implementation of ChaCha20 (master...diff-fuzz-chacha20) https://github.com/bitcoin/bitcoin/pull/22704
3452021-12-17T15:57:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3462021-12-17T16:05:47 *** arythmetic <arythmetic!~arythmeti@2607:fea8:85c1:db00:281c:2687:8a9e:e263> has joined #bitcoin-core-dev
3472021-12-17T16:08:01 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
3482021-12-17T16:08:17 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 256 seconds)
3492021-12-17T16:09:45 *** nanotube <nanotube!~nanotube@user/nanotube> has quit IRC (Ping timeout: 250 seconds)
3502021-12-17T16:09:57 *** arythmetic <arythmetic!~arythmeti@2607:fea8:85c1:db00:281c:2687:8a9e:e263> has quit IRC (Ping timeout: 240 seconds)
3512021-12-17T16:10:35 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3522021-12-17T16:10:35 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #23803: ci: Disable s390x gui tests for now (master...2112-ciGUIs390x) https://github.com/bitcoin/bitcoin/pull/23803
3532021-12-17T16:10:36 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3542021-12-17T16:11:11 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has quit IRC (Ping timeout: 245 seconds)
3552021-12-17T16:13:59 *** arythmetic <arythmetic!~arythmeti@2607:fea8:85c1:db00:281c:2687:8a9e:e263> has joined #bitcoin-core-dev
3562021-12-17T16:16:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3572021-12-17T16:16:02 <bitcoin-git> [bitcoin] glozow opened pull request #23804: validation: followups for de-duplication of packages (master...2021-12-dedup-packages) https://github.com/bitcoin/bitcoin/pull/23804
3582021-12-17T16:16:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3592021-12-17T16:16:11 *** arythmetic <arythmetic!~arythmeti@2607:fea8:85c1:db00:281c:2687:8a9e:e263> has quit IRC (Remote host closed the connection)
3602021-12-17T16:18:14 *** gnaf <gnaf!~pi@86-91-224-60.opennet.kpn.net> has quit IRC (Quit: Konversation terminated!)
3612021-12-17T16:18:48 *** Guyver2_ <Guyver2_!~Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
3622021-12-17T16:19:17 *** Guyver2 <Guyver2!Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 240 seconds)
3632021-12-17T16:19:20 *** Guyver2_ is now known as Guyver2
3642021-12-17T16:20:29 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has joined #bitcoin-core-dev
3652021-12-17T16:21:50 *** noonien <noonien!~noonien@user/noonien> has quit IRC (Quit: The Lounge - https://thelounge.chat)
3662021-12-17T16:22:14 *** noonien <noonien!~noonien@user/noonien> has joined #bitcoin-core-dev
3672021-12-17T16:24:30 *** sirdigby727 <sirdigby727!uid523338@id-523338.lymington.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
3682021-12-17T16:26:04 *** arythmetic <arythmetic!~arythmeti@2607:fea8:85c1:db00:281c:2687:8a9e:e263> has joined #bitcoin-core-dev
3692021-12-17T16:28:49 *** arythmetic <arythmetic!~arythmeti@2607:fea8:85c1:db00:281c:2687:8a9e:e263> has quit IRC (Remote host closed the connection)
3702021-12-17T16:31:30 *** arythmetic <arythmetic!~arythmeti@2607:fea8:85c1:db00:281c:2687:8a9e:e263> has joined #bitcoin-core-dev
3712021-12-17T16:35:09 *** arythmetic <arythmetic!~arythmeti@2607:fea8:85c1:db00:281c:2687:8a9e:e263> has quit IRC (Remote host closed the connection)
3722021-12-17T16:35:24 *** arythmetic <arythmetic!~arythmeti@2607:fea8:85c1:db00:281c:2687:8a9e:e263> has joined #bitcoin-core-dev
3732021-12-17T16:37:37 *** saranshsharma <saranshsharma!~saranshsh@59.93.229.54> has quit IRC (Ping timeout: 240 seconds)
3742021-12-17T16:43:31 <jeremyrubin> my bad on pushing if_unset_then_unset, can someone delete that branch from core? on a new laptop forgot to make my origin remote https
3752021-12-17T16:44:11 *** noonien <noonien!~noonien@user/noonien> has quit IRC (Quit: The Lounge - https://thelounge.chat)
3762021-12-17T16:44:35 *** noonien <noonien!~noonien@user/noonien> has joined #bitcoin-core-dev
3772021-12-17T16:44:54 <jeremyrubin> `git remote set-url --push origin no_push` won't happen again :p
3782021-12-17T16:51:25 *** zonemix <zonemix!~zonemix@216.16.35.204> has quit IRC (Ping timeout: 240 seconds)
3792021-12-17T16:51:29 *** secondl1ght[m] <secondl1ght[m]!~secondl1g@2001:470:69fc:105::1:4fee> has joined #bitcoin-core-dev
3802021-12-17T16:59:21 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
3812021-12-17T17:02:59 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 252 seconds)
3822021-12-17T17:04:27 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3832021-12-17T17:04:27 <bitcoin-git> [gui] hebasto opened pull request #509: Respect dialog modality and fix a regression in wallet unlock (master...211217-unlock) https://github.com/bitcoin-core/gui/pull/509
3842021-12-17T17:04:28 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3852021-12-17T17:05:18 *** zxrqmz88 <zxrqmz88!~private@2603-7000-1302-b6f3-99b9-c40f-27d9-40cb.res6.spectrum.com> has joined #bitcoin-core-dev
3862021-12-17T17:13:05 *** jtrag_ is now known as jtrag
3872021-12-17T17:13:11 *** jtrag is now known as methhead
3882021-12-17T17:13:18 *** methhead is now known as Anubishit
3892021-12-17T17:13:33 *** Anubishit is now known as trag
3902021-12-17T17:13:40 *** trag is now known as jtrag
3912021-12-17T17:20:20 *** gnaf <gnaf!~pi@86-91-224-60.opennet.kpn.net> has joined #bitcoin-core-dev
3922021-12-17T17:40:54 *** jb55 <jb55!~jb55@S010660e327dca171.vc.shawcable.net> has joined #bitcoin-core-dev
3932021-12-17T17:55:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3942021-12-17T17:55:56 <bitcoin-git> [bitcoin] stratospher opened pull request #23806: fuzz: follow up for #22704 (master...follow-up-diff-fuzz-chacha20) https://github.com/bitcoin/bitcoin/pull/23806
3952021-12-17T17:55:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3962021-12-17T18:00:35 <laanwj> jeremyrubin: done
3972021-12-17T18:06:23 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
3982021-12-17T18:08:42 *** jtrag__ <jtrag__!~jtrag@user/jtrag> has joined #bitcoin-core-dev
3992021-12-17T18:08:57 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
4002021-12-17T18:10:20 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
4012021-12-17T18:11:57 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
4022021-12-17T18:13:17 *** jtrag__ <jtrag__!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
4032021-12-17T18:16:48 *** ZeroMaster <ZeroMaster!~webirc@95-42-105-42.ip.btc-net.bg> has joined #bitcoin-core-dev
4042021-12-17T18:17:22 *** ZeroMaster <ZeroMaster!~webirc@95-42-105-42.ip.btc-net.bg> has quit IRC (Client Quit)
4052021-12-17T18:17:58 *** ZeroMaster <ZeroMaster!~webirc@95-42-105-42.ip.btc-net.bg> has joined #bitcoin-core-dev
4062021-12-17T18:21:54 *** jb55 <jb55!~jb55@user/jb55> has quit IRC (Quit: jb55)
4072021-12-17T18:22:08 *** jb55 <jb55!~jb55@S010660e327dca171.vc.shawcable.net> has joined #bitcoin-core-dev
4082021-12-17T18:33:22 *** Alexander10 <Alexander10!~Alexander@76-233-25-130.lightspeed.snantx.sbcglobal.net> has joined #bitcoin-core-dev
4092021-12-17T18:39:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4102021-12-17T18:39:14 <bitcoin-git> [bitcoin] w0xlt opened pull request #23807: Remove GetAdjustedTime() from AddrMan (master...remove_adjusted_time_addrman) https://github.com/bitcoin/bitcoin/pull/23807
4112021-12-17T18:39:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4122021-12-17T18:42:05 *** Alexander10 <Alexander10!~Alexander@76-233-25-130.lightspeed.snantx.sbcglobal.net> has quit IRC (Quit: Client closed)
4132021-12-17T18:46:09 *** alexander97 <alexander97!~alexander@2600:1700:6a00:2ea0:3590:45c0:876a:bb8c> has joined #bitcoin-core-dev
4142021-12-17T18:46:27 *** alexander97 <alexander97!~alexander@2600:1700:6a00:2ea0:3590:45c0:876a:bb8c> has quit IRC (Quit: Leaving)
4152021-12-17T18:49:56 *** grettke <grettke!~grettke@cpe-65-29-228-30.wi.res.rr.com> has joined #bitcoin-core-dev
4162021-12-17T18:50:51 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
4172021-12-17T18:53:57 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
4182021-12-17T19:00:18 <achow101> #startmeeting
4192021-12-17T19:00:18 <core-meetingbot> Meeting started Fri Dec 17 19:00:18 2021 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
4202021-12-17T19:00:18 <core-meetingbot> Available commands: action commands idea info link nick
4212021-12-17T19:00:28 <achow101> #bitcoin-core-dev Wallet Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd
4222021-12-17T19:00:29 <achow101> phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild S3RK
4232021-12-17T19:00:38 <S3RK> hi
4242021-12-17T19:00:40 <sipa> hi
4252021-12-17T19:00:46 <achow101> any topics?
4262021-12-17T19:01:00 <sipa> none from me
4272021-12-17T19:01:02 <S3RK> bnb upper limit?
4282021-12-17T19:01:19 <achow101> #topic bnb upper limit (S3RK)
4292021-12-17T19:01:20 <core-meetingbot> topic: bnb upper limit (S3RK)
4302021-12-17T19:01:25 <sipa> i invoke murch
4312021-12-17T19:01:27 <Murch[m]> Hi
4322021-12-17T19:01:31 <S3RK> oh nice
4332021-12-17T19:01:55 <S3RK> so the current upper limit for bnb is not optimal
4342021-12-17T19:02:15 *** ZeroMaster_ <ZeroMaster_!~webirc@95-42-105-42.ip.btc-net.bg> has joined #bitcoin-core-dev
4352021-12-17T19:02:27 <S3RK> it's economically better to drop more than the current upper limit for fees rather than add an extra input and create change output
4362021-12-17T19:02:37 <S3RK> we can either 1) increase the limit or 2) drop the limit
4372021-12-17T19:02:38 <Murch[m]> Yeah, we ran some experiments removing the upper bound for the exact match window and that resulted in an overall lower cost
4382021-12-17T19:02:45 <michaelfolkson> hi
4392021-12-17T19:03:08 *** ZeroMaster_ <ZeroMaster_!~webirc@95-42-105-42.ip.btc-net.bg> has quit IRC (Client Quit)
4402021-12-17T19:03:09 *** prayank <prayank!~Prayank@103.211.191.71> has joined #bitcoin-core-dev
4412021-12-17T19:03:10 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Quit: Leaving)
4422021-12-17T19:03:17 <Murch[m]> S3RK: My current position would be that I'd be apprehensive about dropping the limit altogether.
4432021-12-17T19:03:18 *** ZeroMaster <ZeroMaster!~webirc@95-42-105-42.ip.btc-net.bg> has quit IRC (Quit: излезна Ð¾Ñ ÑаÑа)
4442021-12-17T19:03:25 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
4452021-12-17T19:03:26 <achow101> if our calculation for the upper bound is incorrect, I would prefer to fix it rather than drop the limit entirely
4462021-12-17T19:03:36 <Murch[m]> If both Knapsack and SRD find very bad solutions, we may drop a ton of money to fees.
4472021-12-17T19:03:51 *** ZeroMaster <ZeroMaster!~webirc@95-42-105-42.ip.btc-net.bg> has joined #bitcoin-core-dev
4482021-12-17T19:03:56 <S3RK> it's a bit tricky to calculate exact upper limit
4492021-12-17T19:03:59 <achow101> but IIRC part of the issue is that our drop to fees handling is independent of the selection algorithm
4502021-12-17T19:04:46 <Murch[m]> Right, but without an upper bound, BnB may end up returning a result that has a larger remainder than what's dropped and our transaction building ends up building a tx with a minuscule change
4512021-12-17T19:04:49 <S3RK> hm... I'd say that's a related but separate issue. Would love to discuss it as well, but let's talk about the bnb limit first
4522021-12-17T19:05:02 <Murch[m]> So, we could just post-filter BnB solutions to not use such a solution
4532021-12-17T19:05:32 <S3RK> Murch, why do you think knapsack wouldn't find the same solution but with change?
4542021-12-17T19:05:47 <achow101> the min change target
4552021-12-17T19:05:58 <Murch[m]> Because Knapsack minimizes the overshoot past minChange
4562021-12-17T19:05:59 <S3RK> hm...
4572021-12-17T19:06:08 <Murch[m]> It doesn't prefer input sets with lower waste
4582021-12-17T19:06:49 <S3RK> what about SRD?
4592021-12-17T19:06:54 <S3RK> ah.. also min change
4602021-12-17T19:07:05 <Murch[m]> SRD only runs once and also aims to create at least minChange
4612021-12-17T19:07:16 <S3RK> yes, that's a bit of problem
4622021-12-17T19:07:16 <Murch[m]> So you could have solutions on Knapsack and SRD that each have 10+ inputs
4632021-12-17T19:07:29 <Murch[m]> and BnB finds a solution with a single input that ends up dropping 20k sats
4642021-12-17T19:07:49 <Murch[m]> Or let's say 1k sats
4652021-12-17T19:08:05 <Murch[m]> and we end up creating a transaction with a 750 sat output
4662021-12-17T19:09:06 <S3RK> doesn't mean that right now we would say "insufficient funds" for such a tx?
4672021-12-17T19:09:12 <S3RK> sorry
4682021-12-17T19:09:15 <S3RK> does it mean taht ...
4692021-12-17T19:09:41 <Murch[m]> So, right now, BnB would not find that solution, and it wuold use one of the Knapsack or SRD
4702021-12-17T19:09:54 <achow101> actually knapsack should find the solution but with change
4712021-12-17T19:10:00 <achow101> even if min change is not met
4722021-12-17T19:10:18 <achow101> srd wouldn't
4732021-12-17T19:10:23 <S3RK> I have to confess I don't know the details how knapsack works right now
4742021-12-17T19:10:39 <Murch[m]> Right, but the scenario wasn't that we didn't have enough funds, but just that the solutions that Knapsack and SRD propose have huge input sets
4752021-12-17T19:10:58 <Murch[m]> achow101: Do I misremember that Knapsack prefers the solution that overshoots the minchange the least?
4762021-12-17T19:11:44 <achow101> that sounds right
4772021-12-17T19:12:15 <achow101> it also prefers the solution that meets min change, but will produce a solution that does not if min change cannot be met
4782021-12-17T19:12:41 <Murch[m]> Right
4792021-12-17T19:13:10 <S3RK> It seems we should codify this scenarious in tests
4802021-12-17T19:13:11 <Murch[m]> I guess we could amend Knapsack to compare the 1,000 trials via the waste metric instead of minimizing the excess, and then I'd agree.
4812021-12-17T19:13:33 <achow101> so if bnb without limit found a solution that throws away lots to fees, knapsack should find the same thing but with change
4822021-12-17T19:13:49 <achow101> the excess should dominate the waste calculation
4832021-12-17T19:13:49 <Murch[m]> Yes
4842021-12-17T19:13:54 <S3RK> achow101 +1 that was my understanding as well
4852021-12-17T19:13:55 <Murch[m]> Correct
4862021-12-17T19:14:19 <Murch[m]> That's why I painted a scenario in which they find different solutions because they optimize for different metrics in their selection ;)
4872021-12-17T19:14:53 <Murch[m]> But yeah, if we use the waste metric internally to compare input sets on Knapsack as well, it would be pretty safe to drop the limit on BnB
4882021-12-17T19:15:13 <achow101> however knapsack may also find a different solution that spends more inputs as it tries to meet min change. this would still be less waste on the knapsack side since excess dominates the bnb solution's waste
4892021-12-17T19:15:23 <Murch[m]> But it would also kinda be pointless, because then Knapsack is very similar to BnB just for a solution that targets a +minchange larger target
4902021-12-17T19:15:33 <Murch[m]> Yes
4912021-12-17T19:15:34 <achow101> even if the knapsack fees are higher
4922021-12-17T19:16:15 <Murch[m]> Knapsack and BnB are very similar in approach, except that Knapsack quasirandomly explores the binary UTXO tree, while BnB does it deterministically.
4932021-12-17T19:16:36 <achow101> I think we need to change how we drop things to fees, and then run simulations
4942021-12-17T19:17:03 <achow101> and see if bnb without limit causes some scenarios where we drop ridiculous amounts to fees
4952021-12-17T19:17:20 <S3RK> you can test on #23367 i guess
4962021-12-17T19:17:21 <gribble> https://github.com/bitcoin/bitcoin/issues/23367 | Optimize coin selection by dropping BnB upper limit by S3RK · Pull Request #23367 · bitcoin/bitcoin · GitHub
4972021-12-17T19:17:40 <Murch[m]> Well, in the experiment you ran for us, the numbers showed that we had more BnB solutions used than changeless transactions.
4982021-12-17T19:17:47 <Murch[m]> So, essentially, you've shown that already.
4992021-12-17T19:18:19 <S3RK> it doesn't mean we drop ridiculous amounts to fees
5002021-12-17T19:18:27 <S3RK> just more than we currently drop
5012021-12-17T19:18:38 <S3RK> which I argue could still be more economical
5022021-12-17T19:18:44 <Murch[m]> Yes, agreed
5032021-12-17T19:19:13 <S3RK> what if we introduce a safeguard?
5042021-12-17T19:19:25 <S3RK> put a limit on what is "ridiculous" to drop to fees?
5052021-12-17T19:19:26 <Murch[m]> But it also breaks a lot of assumptions about BnB, because previously we assumed that BnB never creates change, and when we find a really large excess, the transaction we build actually does result in a change output
5062021-12-17T19:19:50 <achow101> time for "absurdly-high-fee" errors again :p
5072021-12-17T19:19:52 <Murch[m]> Isn't that equivalent to just updating our upper bound for the exact match window? ;)
5082021-12-17T19:19:52 <S3RK> my PR does exactly this. BnB never creates change
5092021-12-17T19:20:18 <achow101> yes, we do need to look at 23367 and also run simulations on it
5102021-12-17T19:20:50 <S3RK> hm... yes we can also extend upper bound by the "absurdly-high-fee"
5112021-12-17T19:21:33 <achow101> (there used to be a mempool policy reject error named absurdly-high-fee)
5122021-12-17T19:21:52 <achow101> I think the fee had to be 0.1 or thereabouts
5132021-12-17T19:22:04 <S3RK> there is still some limit. 0.1 sounds about right
5142021-12-17T19:23:21 <S3RK> if you can write in plain english scenarios that concerns you, I can codify them as tests
5152021-12-17T19:23:38 <prayank> AI
5162021-12-17T19:23:57 <S3RK> I take it as a compliment :)
5172021-12-17T19:24:26 <achow101> one thing that concerns me is that it's probably going to hit the iteration limit very quickly
5182021-12-17T19:24:28 <S3RK> constexpr CAmount DEFAULT_TRANSACTION_MAXFEE{COIN / 10};
5192021-12-17T19:24:45 <S3RK> BnB iter limit?
5202021-12-17T19:24:53 <achow101> since we are removing one of the bounds that allow BnB to be called Branch and _Bound_
5212021-12-17T19:25:04 <S3RK> it shouldn't because there will be no branching
5222021-12-17T19:25:12 *** MattCorallo[m] is now known as BlueMatt[m]
5232021-12-17T19:25:22 <S3RK> so it's linear to the amount of coins higher than the target
5242021-12-17T19:25:52 <Murch[m]> achow101: No, finding a valid solution backtracks just like overshooting the window does
5252021-12-17T19:26:58 <Murch[m]> Once you find a solution, it next explores the omission branch of the last included UTXO, the same as when it overshoots and stops searching the subtree because it already has too much
5262021-12-17T19:27:09 <achow101> oh right
5272021-12-17T19:27:50 <achow101> overshoot == finding a solution without limit, and both backtrack
5282021-12-17T19:30:08 <achow101> anything else to discuss?
5292021-12-17T19:30:12 <Murch[m]> It would be great if we had a test that does produce selections for which BnB without an upper bound on the exact match window breaks down
5302021-12-17T19:30:40 <S3RK> what do you mean by breaks down
5312021-12-17T19:32:19 <S3RK> I have a crazy idea. What if we create a test that iterates sending value from 1sat to 10^8sat and verifies fees
5322021-12-17T19:32:20 <Murch[m]> Well, something were SRD and BnB would be highly likely to produce an input set with a large count of inputs, while BnB finds one that overshoots the exact match window severely and the BnB input set scores best according to the waste metric
5332021-12-17T19:33:21 <Murch[m]> S3RK: I think that would be interesting, but probably the source of the issue would probably be found in the UTXO pool rather than the target amount
5342021-12-17T19:33:58 <Murch[m]> E.g. a wallet that has 1,000 UTXOs that have the same size, and one that is larger
5352021-12-17T19:34:08 <S3RK> true
5362021-12-17T19:34:53 <Murch[m]> And 100 UTXOs match the target plus minChange plus fees by the satoshi, but the one large input is just enough for the target without change but has a large excess
5372021-12-17T19:34:54 <S3RK> if we agreed that the waste metric is a good metric, than there is no problem with dropping more to fees no?
5382021-12-17T19:35:33 <S3RK> I'll try to create some interesting test scenarios. Including one where current coin selectio fails
5392021-12-17T19:35:47 <Murch[m]> Mh, I guess the fees would still be lower overall on the BnB solution in what I describe, but you'd not get the benefit of consolidating 100 UTXOs, so it feels like you paid more for less
5402021-12-17T19:36:27 <S3RK> the benefit of consolidating only works if the fees are lower than "long term fee"
5412021-12-17T19:36:33 <S3RK> if that's the case that would lower the waste
5422021-12-17T19:36:48 <S3RK> i.e. consolidating value is counted in waste
5432021-12-17T19:37:39 <S3RK> achow101 Murch what would be a good place for such tests?
5442021-12-17T19:37:40 <achow101> if fees are high, the 100 utxos might have a larger fee than the bnb excess
5452021-12-17T19:38:04 <S3RK> coinselection_test or some new/existing functional test?
5462021-12-17T19:38:07 <Murch[m]> yes, to both
5472021-12-17T19:38:17 <Murch[m]> but it still feels a bit icky, if you know what I mean
5482021-12-17T19:38:29 <S3RK> yes :)
5492021-12-17T19:38:34 <achow101> S3RK: usually rpc_fundrawtransaction
5502021-12-17T19:38:46 <achow101> and coinselection_tests
5512021-12-17T19:40:01 <S3RK> so in conclusion 1) I work on the tests
5522021-12-17T19:40:14 <S3RK> achow101 could run simulations
5532021-12-17T19:40:38 <S3RK> and you can also take a look at the PR
5542021-12-17T19:40:58 <achow101> yes
5552021-12-17T19:41:04 <Murch[m]> Yes
5562021-12-17T19:41:14 <S3RK> thanks
5572021-12-17T19:42:16 <achow101> any other topics?
5582021-12-17T19:42:40 <S3RK> congrats, it looks like you'll be wallet maintainer soon :)
5592021-12-17T19:42:53 <prayank> achow101: yes
5602021-12-17T19:44:49 <achow101> prayank: you have a topic?
5612021-12-17T19:45:09 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
5622021-12-17T19:45:10 <prayank> Not sure if this can be discussed. Wanted to understand why isnt this better approach? https://github.com/bitcoin/bitcoin/pull/22776
5632021-12-17T19:45:46 <prayank> RPC would respond with balance and getbalances already does that but we add a condition so parameter
5642021-12-17T19:45:53 <achow101> #topic add optional transaction(s) to getbalances (prayank)
5652021-12-17T19:45:53 <core-meetingbot> topic: add optional transaction(s) to getbalances (prayank)
5662021-12-17T19:46:07 <achow101> prayank: because such an RPC can be expanded to be much more than just balance fetching
5672021-12-17T19:46:17 <prayank> like?
5682021-12-17T19:47:01 <achow101> the reason I asked for simulaterawtransaction is because we can do things like seeing if a transaction has conflicts with the wallet, and if it does, what gets replaced
5692021-12-17T19:47:51 <prayank> hmm
5702021-12-17T19:47:57 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
5712021-12-17T19:48:25 <prayank> I liked the idea of having such params in few other RPC to simulate things
5722021-12-17T19:48:33 <prayank> You don't like the idea to add similar parameter in getmempool and see how mempool looks if some txs get added?
5732021-12-17T19:48:43 <achow101> IMO it's better to have simulating things in one spot, rather than spread in many different places
5742021-12-17T19:48:57 <prayank> yes its one param
5752021-12-17T19:49:08 <achow101> prayank: no, I think that should be its own RPC
5762021-12-17T19:49:42 <achow101> I don't think it makes sense to have a fetching function do simulation things
5772021-12-17T19:49:47 <prayank> ah okay then I guess we have different opinion. No problem. But the wallet conflicts thing makes sense.
5782021-12-17T19:51:17 <achow101> anything else?
5792021-12-17T19:51:40 <prayank> No. Thanks for sharing your opinion.
5802021-12-17T19:52:02 <achow101> #endmeeting
5812021-12-17T19:52:02 <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
5822021-12-17T19:52:02 <core-meetingbot> Meeting ended Fri Dec 17 19:52:02 2021 UTC.
5832021-12-17T19:52:02 <core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-12-17-19.00.moin.txt
5842021-12-17T19:53:15 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 276 seconds)
5852021-12-17T19:59:40 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
5862021-12-17T20:00:44 *** arythmetic <arythmetic!~arythmeti@2607:fea8:85c1:db00:281c:2687:8a9e:e263> has quit IRC (Remote host closed the connection)
5872021-12-17T20:00:54 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
5882021-12-17T20:08:33 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
5892021-12-17T20:12:19 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 268 seconds)
5902021-12-17T20:18:00 *** arythmetic <arythmetic!~arythmeti@2605:8d80:682:9829:2966:13f4:b430:ab9> has joined #bitcoin-core-dev
5912021-12-17T20:33:18 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
5922021-12-17T20:35:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5932021-12-17T20:35:15 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4ad59042b359...784a21d35466
5942021-12-17T20:35:15 <bitcoin-git> bitcoin/master 8494dca Dmitry Goncharov: Replace $(AT) with .SILENCE.
5952021-12-17T20:35:15 <bitcoin-git> bitcoin/master 784a21d W. J. van der Laan: Merge bitcoin/bitcoin#22283: build: Replace $(AT) with .SILENT
5962021-12-17T20:35:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
5972021-12-17T20:35:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
5982021-12-17T20:35:31 <bitcoin-git> [bitcoin] laanwj merged pull request #22283: build: Replace $(AT) with .SILENT (master...replace_AT_with_dotsilence) https://github.com/bitcoin/bitcoin/pull/22283
5992021-12-17T20:35:32 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6002021-12-17T20:36:32 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
6012021-12-17T20:45:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6022021-12-17T20:45:41 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/784a21d35466...14ba286556fa
6032021-12-17T20:45:41 <bitcoin-git> bitcoin/master fa1dc9b MarcoFalke: p2p: Always serialize local timestamp for version msg
6042021-12-17T20:45:41 <bitcoin-git> bitcoin/master 14ba286 W. J. van der Laan: Merge bitcoin/bitcoin#23695: p2p: Always serialize local timestamp for ver...
6052021-12-17T20:45:42 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6062021-12-17T20:45:56 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
6072021-12-17T20:45:57 <bitcoin-git> [bitcoin] laanwj merged pull request #23695: p2p: Always serialize local timestamp for version msg (master...2112-p2pTime) https://github.com/bitcoin/bitcoin/pull/23695
6082021-12-17T20:45:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
6092021-12-17T21:30:09 <prayank> Any thoughts on this? especially people who understand p2p, tor etc. https://github.com/bitcoin/bitcoin/pull/18988#issuecomment-646564853
6102021-12-17T21:31:17 <prayank> ryanofsky: had asked to create an issue which was never created
6112021-12-17T21:31:23 <prayank> I was thinking to create one
6122021-12-17T21:32:12 <sipa> I don't understanding anything about node-tor, or why you'd want to use a separate tor network for just bitcoin traffic. That completely defeats the purpose.
6132021-12-17T21:34:42 <sipa> I conceptually like having more mechanisms for connecting bitcoin nodes though, so if there were a viable network like that to use as an additional one - sure why not.
6142021-12-17T21:35:04 <sipa> But it feels to me like the discussion there is too far removed from anything concrete.
6152021-12-17T21:35:24 <prayank> hmm tbh I am not the best person to comment anything on this. I liked the idea and his follow up on mailing list. What I understand is: we do bitcoin nodes from browsers similar to one PoC by bcoin but its not safe for production. And this guy wants to make it interesting by using tor protocol for everything. I have issues with JS and WebRTC but if it can help bitcoin nodes usage I dont mind and maybe not full nodes or somethin
6162021-12-17T21:35:25 <prayank> g like neurino idk
6172021-12-17T21:36:04 <sipa> I don't understand what you're talking about.
6182021-12-17T21:37:16 <prayank> wait
6192021-12-17T21:37:47 <prayank> https://bcoin.io/browser/
6202021-12-17T21:37:53 <prayank> This is PoC
6212021-12-17T21:38:13 <prayank> He wants to do something similar but use different ways to achieve it
6222021-12-17T21:38:57 <prayank> and tor 'protocol' will be used not browser
6232021-12-17T21:39:05 <prayank> or their network
6242021-12-17T21:41:53 <sipa> I don't think that's at all what he's talking about. He's saying that the communication between bitcoin core and node-tor (if it were to use node-tor rather than actual tor) would not use SOCKS.
6252021-12-17T21:42:25 *** masta`` <masta``!~oyster@user/masta/x-2645138> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
6262021-12-17T21:42:47 <sipa> But again, while I conceptually agree with making it easier to connect bitcoin nodes in more different ways with eachother, I don't understand the point of node-tor.
6272021-12-17T21:47:04 <prayank> sipa: what I understood based on his emails. he likes browsers, js and world around it. so webtorrents kind of things for bitcoin nodes. He is from france, he is good with his project but unable to express or get funding. IDK just wanted to share it here once so that people like you who know better would be able to see if it helps bitcoin at some point. Everything is moving to browsers tbh and this is not about altcoins. I work
6282021-12-17T21:47:05 <prayank> ed at microsoft when I was in college and even that had started moving from desktop applications to web apps. Core can remain same but we need a world around it.
6292021-12-17T21:49:03 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has joined #bitcoin-core-dev
6302021-12-17T21:52:37 *** jtrag <jtrag!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
6312021-12-17T21:53:02 *** roconnor <roconnor!~roconnor@coq/roconnor> has joined #bitcoin-core-dev
6322021-12-17T21:55:44 *** prayank <prayank!~Prayank@103.211.191.71> has left #bitcoin-core-dev
6332021-12-17T21:57:23 <jb55> so basically a way to feed network messages in and out as plaintext, turn bitcoin into a pure function?
6342021-12-17T21:58:58 <sipa> prayank: I conceptually agree with that, but it seems all unrelated to this discussion. He wants to build his own network that uses the tor protocol, but separate from the real one. I don't understand the reasons for that, or what there is to be gained, as directly shrinking the anonimity set for no reason as far as I can tell.
6352021-12-17T21:59:14 *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has joined #bitcoin-core-dev
6362021-12-17T21:59:44 *** prayank <prayank!~Prayank@103.211.191.71> has joined #bitcoin-core-dev
6372021-12-17T22:00:45 <roconnor> reducing the anonymity set seems pretty bad.
6382021-12-17T22:00:48 <prayank> sipa: Reason IIUC he doesn't like the way Tor project uses Tor protocol and its flaws etc. but wants to make a better to for different projects and bitcoin is one of them
6392021-12-17T22:01:28 <sipa> jb55 The P2P protocol is stateful, so it's not that easy. Just having ways of routing messages over some other links has some limited use (e.g. it's done by Blockstream satellite), but really supporting many networks in a full way is a lot harder, as you need the ability to discover connections and automatically create them etc.
6402021-12-17T22:02:58 <prayank> roconnor: Tor is anyways centralized directory servers so i2p is better even if less nodes
6412021-12-17T22:04:13 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
6422021-12-17T22:04:42 *** arythmetic <arythmetic!~arythmeti@2605:8d80:682:9829:2966:13f4:b430:ab9> has quit IRC (Remote host closed the connection)
6432021-12-17T22:06:15 <prayank> The part I am interested in this project actually was not Tor. It was browser. Because I want to see people running pruned nodes or at least some neturino type nodes running from mobile and browser.
6442021-12-17T22:06:51 <sipa> That's all very reasonable, but I don't think that has much to do with Bitcoin Core.
6452021-12-17T22:07:25 <prayank> Hmm but he commented in that PR so I thought some changes are required or that PR is related
6462021-12-17T22:10:34 <sipa> Yes, he needs a way to communicate with Bitcoin Core. The altnet stuff goes in the direction of providing that functionality. As I said, I conceptually agree with that. I still don't see the point of node-tor, but if there is more functionality for interacting with separate networks, and someone makes it work with node-tor, sure...
6472021-12-17T22:11:27 <sipa> But Bitcoin Core works fine with tor itself, and tor itself also works with browsers.
6482021-12-17T22:11:37 <jb55> btw satellite doesn't need to be a bitcoin fork right? couldn't it just be a block-from-space decoder + call submitblock? or is there more to it?
6492021-12-17T22:11:48 <sipa> I don't know.
6502021-12-17T22:12:02 <sipa> I think it may rely on the node's mempool to do fast reconstruction.
6512021-12-17T22:12:08 <jb55> hmm
6522021-12-17T22:13:45 *** prayank <prayank!~Prayank@103.211.191.71> has left #bitcoin-core-dev
6532021-12-17T22:30:29 *** ZeroMaster <ZeroMaster!~webirc@95-42-105-42.ip.btc-net.bg> has quit IRC (Remote host closed the connection)
6542021-12-17T22:39:41 *** jtrag <jtrag!~jtrag@user/jtrag> has joined #bitcoin-core-dev
6552021-12-17T22:42:17 *** jtrag_ <jtrag_!~jtrag@user/jtrag> has quit IRC (Ping timeout: 240 seconds)
6562021-12-17T22:56:25 *** arythmetic <arythmetic!~arythmeti@2605:8d80:680:d8c0:d55d:fe52:b1de:e1c3> has joined #bitcoin-core-dev
6572021-12-17T22:57:51 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 276 seconds)
6582021-12-17T22:59:55 *** arythmetic <arythmetic!~arythmeti@2605:8d80:680:d8c0:d55d:fe52:b1de:e1c3> has quit IRC (Remote host closed the connection)
6592021-12-17T23:01:05 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
6602021-12-17T23:02:06 *** zxrqmz88 <zxrqmz88!~private@2603-7000-1302-b6f3-99b9-c40f-27d9-40cb.res6.spectrum.com> has quit IRC (Quit: Quit)
6612021-12-17T23:10:23 *** masta`` <masta``!~oyster@user/masta/x-2645138> has joined #bitcoin-core-dev
6622021-12-17T23:12:37 *** masta`` <masta``!~oyster@user/masta/x-2645138> has quit IRC (Client Quit)
6632021-12-17T23:26:28 *** Guyver2_ <Guyver2_!Guyver@guyver2.xs4all.nl> has joined #bitcoin-core-dev
6642021-12-17T23:27:07 *** baldur <baldur!~baldur@71.183.150.231> has joined #bitcoin-core-dev
6652021-12-17T23:28:09 *** sdfgsdfg <sdfgsdfg!~sdfgsdfg@user/sdfgsdfg> has quit IRC (Quit: ZzzZ)
6662021-12-17T23:29:09 *** Guyver2 <Guyver2!~Guyver@guyver2.xs4all.nl> has quit IRC (Ping timeout: 256 seconds)
6672021-12-17T23:29:10 *** Guyver2_ is now known as Guyver2
6682021-12-17T23:34:32 *** jrawsthorne <jrawsthorne!~jrawsthor@static.235.41.217.95.clients.your-server.de> has quit IRC (Quit: ZNC 1.8.1 - https://znc.in)
6692021-12-17T23:39:14 *** jrawsthorne <jrawsthorne!~jrawsthor@static.235.41.217.95.clients.your-server.de> has joined #bitcoin-core-dev
6702021-12-17T23:43:57 *** jrawsthorne <jrawsthorne!~jrawsthor@static.235.41.217.95.clients.your-server.de> has quit IRC (Client Quit)
6712021-12-17T23:45:36 *** arythmetic <arythmetic!~arythmeti@cpe08a7c0990817-cm08a7c0990815.cpe.net.cable.rogers.com> has joined #bitcoin-core-dev
6722021-12-17T23:46:12 *** jrawsthorne <jrawsthorne!~jrawsthor@static.235.41.217.95.clients.your-server.de> has joined #bitcoin-core-dev
6732021-12-17T23:54:32 *** gnaf <gnaf!~pi@86-91-224-60.opennet.kpn.net> has quit IRC (Quit: Konversation terminated!)
6742021-12-17T23:54:45 *** ZeroMaster <ZeroMaster!~webirc@95-42-105-42.ip.btc-net.bg> has joined #bitcoin-core-dev
6752021-12-17T23:59:53 *** arythmetic <arythmetic!~arythmeti@cpe08a7c0990817-cm08a7c0990815.cpe.net.cable.rogers.com> has quit IRC (Remote host closed the connection)