12022-04-08T00:14:10 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
22022-04-08T00:23:05 *** meshcollider <meshcollider!meshcollid@meshcollider.jujube.ircnow.org> has quit IRC (Ping timeout: 250 seconds)
32022-04-08T00:25:45 *** meshcollider <meshcollider!meshcollid@meshcollider.jujube.ircnow.org> has joined #bitcoin-core-dev
42022-04-08T00:36:36 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 240 seconds)
52022-04-08T00:38:12 *** dviola <dviola!~diego@user/dviola> has quit IRC (Ping timeout: 260 seconds)
62022-04-08T00:45:58 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c86d:3b33:52f1:a0c4> has quit IRC (Ping timeout: 260 seconds)
72022-04-08T00:47:45 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has joined #bitcoin-core-dev
82022-04-08T00:52:09 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has quit IRC (Ping timeout: 248 seconds)
92022-04-08T00:53:41 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
102022-04-08T00:53:50 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has joined #bitcoin-core-dev
112022-04-08T00:58:36 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 240 seconds)
122022-04-08T01:06:58 *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
132022-04-08T01:22:51 *** dviola <dviola!~diego@187.39.20.187> has joined #bitcoin-core-dev
142022-04-08T02:00:12 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Quit: 404)
152022-04-08T02:02:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
162022-04-08T02:02:08 <bitcoin-git> [bitcoin] aureleoules opened pull request #24804: Sanity assert GetAncestor() != nullptr where appropriate (master...assert_get_ancestor_rebase) https://github.com/bitcoin/bitcoin/pull/24804
172022-04-08T02:02:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
182022-04-08T02:09:33 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
192022-04-08T02:14:16 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC (Ping timeout: 240 seconds)
202022-04-08T02:27:56 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
212022-04-08T02:32:53 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
222022-04-08T02:34:49 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has joined #bitcoin-core-dev
232022-04-08T02:50:50 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
242022-04-08T02:54:56 *** rex4539 <rex4539!~rex4539@gateway/tor-sasl/rex4539> has quit IRC ()
252022-04-08T02:58:58 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has quit IRC (Ping timeout: 260 seconds)
262022-04-08T03:00:18 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has joined #bitcoin-core-dev
272022-04-08T03:04:25 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has quit IRC (Ping timeout: 248 seconds)
282022-04-08T03:06:06 *** mekster66949 <mekster66949!~mekster@user/mekster> has quit IRC (Ping timeout: 246 seconds)
292022-04-08T03:06:24 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has joined #bitcoin-core-dev
302022-04-08T03:07:43 *** mekster66949 <mekster66949!~mekster@user/mekster> has joined #bitcoin-core-dev
312022-04-08T03:23:53 *** dviola <dviola!~diego@187.39.20.187> has quit IRC (Ping timeout: 256 seconds)
322022-04-08T03:46:12 *** Guest64 <Guest64!~Guest64@2601:81:c301:1470::8593> has joined #bitcoin-core-dev
332022-04-08T03:48:10 *** Guest64 <Guest64!~Guest64@2601:81:c301:1470::8593> has quit IRC (Client Quit)
342022-04-08T03:51:52 *** hashfunc14a0 <hashfunc14a0!~user@2601:5c0:c280:7090:4533:6252:8e32:243> has joined #bitcoin-core-dev
352022-04-08T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
362022-04-08T04:01:32 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
372022-04-08T04:11:28 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has quit IRC (Ping timeout: 260 seconds)
382022-04-08T04:17:35 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has joined #bitcoin-core-dev
392022-04-08T04:21:48 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has quit IRC (Ping timeout: 240 seconds)
402022-04-08T04:23:39 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has joined #bitcoin-core-dev
412022-04-08T05:28:36 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has quit IRC (Ping timeout: 240 seconds)
422022-04-08T05:30:43 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has joined #bitcoin-core-dev
432022-04-08T06:02:43 *** hashfunc14a0 <hashfunc14a0!~user@2601:5c0:c280:7090:4533:6252:8e32:243> has quit IRC (Ping timeout: 260 seconds)
442022-04-08T06:34:15 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
452022-04-08T06:36:09 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has quit IRC (Ping timeout: 248 seconds)
462022-04-08T06:42:33 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 248 seconds)
472022-04-08T06:44:24 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has joined #bitcoin-core-dev
482022-04-08T06:44:56 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
492022-04-08T06:45:55 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Max SendQ exceeded)
502022-04-08T06:46:28 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
512022-04-08T06:52:01 *** dougefish <dougefish!~dougefish@2a00:a040:19e:67b8:8ed1:c610:9029:1239> has quit IRC (Ping timeout: 250 seconds)
522022-04-08T07:20:20 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
532022-04-08T07:22:47 *** vysn <vysn!~vysn@user/vysn> has quit IRC (Quit: WeeChat 3.4)
542022-04-08T07:23:04 *** dougefish <dougefish!~dougefish@77.137.78.42> has joined #bitcoin-core-dev
552022-04-08T07:27:42 <vasild> timediff stats from my node: almost all are +/- a few seconds, and 6 peers are +/- ~60 seconds
562022-04-08T07:29:29 *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Ping timeout: 272 seconds)
572022-04-08T07:38:45 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 246 seconds)
582022-04-08T07:40:16 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
592022-04-08T07:45:29 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 248 seconds)
602022-04-08T07:46:51 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
612022-04-08T07:52:29 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
622022-04-08T07:53:51 <fanquake> have invited https://github.com/t-bast to the orgs, so it's easier to requests package related reviews
632022-04-08T07:59:17 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Ping timeout: 256 seconds)
642022-04-08T08:02:33 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 248 seconds)
652022-04-08T08:05:13 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 248 seconds)
662022-04-08T08:06:42 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
672022-04-08T08:12:43 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Remote host closed the connection)
682022-04-08T08:13:14 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
692022-04-08T08:20:03 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 246 seconds)
702022-04-08T08:26:52 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has quit IRC (Remote host closed the connection)
712022-04-08T08:30:18 *** jonatack <jonatack!~jonatack@37.164.140.49> has joined #bitcoin-core-dev
722022-04-08T08:30:42 *** jonatack is now known as Guest7037
732022-04-08T08:33:13 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has joined #bitcoin-core-dev
742022-04-08T08:33:14 *** ChanServ sets mode: +o gribble
752022-04-08T08:38:09 *** z3r0day <z3r0day!~z3r0day@yal.riseup.net> has joined #bitcoin-core-dev
762022-04-08T08:38:16 <z3r0day> kanzure: biggest attack on bitcoin is gatekeepers like you
772022-04-08T08:38:27 *** z3r0day <z3r0day!~z3r0day@yal.riseup.net> has left #bitcoin-core-dev
782022-04-08T08:42:12 *** Guest7037 <Guest7037!~jonatack@37.164.140.49> has quit IRC (Quit: Connection closed)
792022-04-08T08:44:04 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
802022-04-08T08:58:18 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
812022-04-08T08:58:28 <laanwj> fanquake: sgtm
822022-04-08T09:10:02 <MarcoFalke> Hi, catching up on yesterdays meeting. My thinking is that removing network time from addrman is largely not risky, as it shouldn't affect your node's ability to connect to peers and sync blocks and txs.
832022-04-08T09:10:40 <MarcoFalke> I didn't open a consensus change for adjusted time, as I want to think more about it and collect data points.
842022-04-08T09:12:04 <MarcoFalke> Maybe we can open a data-point collection issue to share findings? Obviously taking into account #23695 to filter the data appropriately.
852022-04-08T09:12:05 <gribble> https://github.com/bitcoin/bitcoin/issues/23695 | p2p: Always serialize local timestamp for version msg by MarcoFalke · Pull Request #23695 · bitcoin/bitcoin · GitHub
862022-04-08T09:21:25 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 268 seconds)
872022-04-08T09:22:36 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
882022-04-08T09:26:25 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Max SendQ exceeded)
892022-04-08T09:30:03 <vasild> What about environments where the user running bitcoind does not have root access on the machine and thus not in control of the system clock / fixing ntp?
902022-04-08T09:31:52 <vasild> some limited hosting may be like that, but also most smartphones? Maybe too exotic to worry about...
912022-04-08T09:32:07 <_aj_> vasild: they also can't email someone with root access?
922022-04-08T09:32:17 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
932022-04-08T09:33:22 <vasild> _aj_: yeah, probably one could ask the admin/root user to fix the clock
942022-04-08T09:35:21 <_aj_> vasild: or find a new hosting provider, or find an LD_PRELOAD shim that corrects the time
952022-04-08T09:35:33 <vasild> :)
962022-04-08T09:37:24 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 246 seconds)
972022-04-08T09:39:11 <jonatack> planning to add a timeoffset column to the -netinfo dashboard (for my own use, at least) to get more of an idea of behavior
982022-04-08T09:39:45 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
992022-04-08T09:40:44 <jonatack> most all my inbounds have offsets
1002022-04-08T09:45:04 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
1012022-04-08T09:45:06 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 246 seconds)
1022022-04-08T09:47:03 *** Guest57 <Guest57!~Guest57@103.82.4.112> has joined #bitcoin-core-dev
1032022-04-08T09:47:53 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
1042022-04-08T09:49:27 *** greypw2546 <greypw2546!~greypw254@grey.pw> has quit IRC (Quit: I'll be back!)
1052022-04-08T09:49:38 *** greypw2546 <greypw2546!~greypw254@grey.pw> has joined #bitcoin-core-dev
1062022-04-08T09:54:58 <_aj_> jonatack: really? i have 17x -1 offset, and 43x 0 offset, for currently connected peers
1072022-04-08T09:56:09 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 248 seconds)
1082022-04-08T09:56:27 *** Guest57 <Guest57!~Guest57@103.82.4.112> has quit IRC (Quit: Client closed)
1092022-04-08T09:57:18 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
1102022-04-08T10:02:33 <_aj_> get occassional connections that have the date hardcoded to 2019-12-12T01:57+00:00
1112022-04-08T10:03:16 <jonatack> 25 of 27 yesterday after the meeting, 24 of 27 now, various ip/tor/i2p/cjdns, some of them are peers that i know. but i'd like to look at it in more detail, e.g. breakdown by network or peers that i know versus unknown ones
1122022-04-08T10:04:02 <_aj_> tor/etc probably should have a few seconds offset just due to lag?
1132022-04-08T10:04:39 <jonatack> possibly yes but i haven't looked further than the jq
1142022-04-08T10:05:21 <_aj_> bitcoin-cli getpeerinfo | jq '.[] | select(.inbound) | (.timeoffset | fabs)' | sort -n
1152022-04-08T10:06:46 <MarcoFalke> It is expected that the time offset is non-zero for almost all peers
1162022-04-08T10:07:38 <MarcoFalke> It is also expected that the time offset is large for some peers. For example -reindex will set the time offest to the duration of the reindex: https://github.com/bitcoin/bitcoin/commit/0ac42c49f7bfc1e158a83c6d98bc465b06894e8a
1172022-04-08T10:08:23 <MarcoFalke> fun fact: 2015 was 7 years ago
1182022-04-08T10:08:34 <_aj_> bitcoin-cli getpeerinfo | jq '.[] | select(.inbound) | select(.timeoffset | fabs > 30) | .timeoffset'
1192022-04-08T10:08:45 <_aj_> (offsets > 30seconds)
1202022-04-08T10:14:47 <MarcoFalke> #24805
1212022-04-08T10:14:48 <gribble> https://github.com/bitcoin/bitcoin/issues/24805 | [meta] Collect time offset samples · Issue #24805 · bitcoin/bitcoin · GitHub
1222022-04-08T10:15:11 *** bfsfhkacjzgcytf9 <bfsfhkacjzgcytf9!~bfsfhkacj@user/bfsfhkacjzgcytf> has joined #bitcoin-core-dev
1232022-04-08T10:16:18 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 268 seconds)
1242022-04-08T10:17:11 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
1252022-04-08T10:20:16 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
1262022-04-08T10:29:49 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1272022-04-08T10:35:16 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
1282022-04-08T10:38:56 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1292022-04-08T10:41:29 <laanwj> jonatack: heh, i don't think we should put that in a release, adding the timeoffset to netinfo gives the wrong idea that this information is important (beyond this particular survery)
1302022-04-08T10:41:33 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 260 seconds)
1312022-04-08T10:42:23 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
1322022-04-08T10:42:45 <jonatack> laanwj: yes, just a patch branch for myself and anyone else
1332022-04-08T10:46:36 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
1342022-04-08T10:47:45 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Ping timeout: 246 seconds)
1352022-04-08T10:49:51 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 246 seconds)
1362022-04-08T10:50:15 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
1372022-04-08T10:54:05 <laanwj> vasild: smartphones tend to have various time sync sources (GSM, GPS, ...), if anything they're probably more precise in timekeeping on average than consumer PCs
1382022-04-08T10:57:40 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Quit: Connection closed)
1392022-04-08T10:59:43 <laanwj> as for VPSes and containers that don't allow setting the time, and have it drift, that's a really lousy VPS and it's probably a bad idea to run a bitcoin node on it, expecting user-space software to work around kernel level problems is pretty unreasonable
1402022-04-08T11:00:33 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1412022-04-08T11:16:41 <vasild> laanwj: right
1422022-04-08T11:21:01 <laanwj> dhruv: #24792 bumping secp256k1 probably helps with BIP324? (i see it conflicts with about every BIP324 PR but don't know if they're the same changes)
1432022-04-08T11:21:02 <gribble> https://github.com/bitcoin/bitcoin/issues/24792 | Update libsecp256k1 subtree to current master by fanquake · Pull Request #24792 · bitcoin/bitcoin · GitHub
1442022-04-08T11:23:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1452022-04-08T11:23:31 <bitcoin-git> [bitcoin] MarcoFalke reopened pull request #24697: refactor: Use type-safe time for address relay (master...2203-refactor-addr-relay-time-ð¦) https://github.com/bitcoin/bitcoin/pull/24697
1462022-04-08T11:23:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1472022-04-08T11:24:43 *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
1482022-04-08T11:25:12 <fanquake> laanwj: thereâs a shared commit for fixing the MSVC build. Otherwise mine is some build cleanups
1492022-04-08T11:26:23 *** mekster66949 <mekster66949!~mekster@user/mekster> has quit IRC (Quit: Ping timeout (120 seconds))
1502022-04-08T11:26:44 *** mekster66949 <mekster66949!~mekster@user/mekster> has joined #bitcoin-core-dev
1512022-04-08T11:33:29 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 256 seconds)
1522022-04-08T11:34:03 <MarcoFalke> Is it time to tag rc4? I think all known bugs are fixed?
1532022-04-08T11:34:33 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
1542022-04-08T11:34:36 <MarcoFalke> If nothing else comes up, we could tag final on April 20th or so
1552022-04-08T11:35:52 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Max SendQ exceeded)
1562022-04-08T11:37:38 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
1572022-04-08T11:52:36 <laanwj> yes, sgtm
1582022-04-08T11:54:27 <laanwj> though I think it would benice to have #24770 in
1592022-04-08T11:54:28 <gribble> https://github.com/bitcoin/bitcoin/issues/24770 | Put lock logging behind DEBUG_LOCKCONTENTION preprocessor directive by jonatack · Pull Request #24770 · bitcoin/bitcoin · GitHub
1602022-04-08T11:55:07 <laanwj> i'm still not comfortable with the try_lock/lock on every lock in the release
1612022-04-08T11:56:25 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
1622022-04-08T11:56:26 <fanquake> I think you aren't the only one
1632022-04-08T11:56:41 <fanquake> We could have that in as the last backport, baring no other issues. The other 2 PRs could be removed from the 23.0 milestone.
1642022-04-08T11:56:58 <laanwj> so let's review that quickly and merge it and backport it and do rc4
1652022-04-08T11:57:09 <laanwj> agree
1662022-04-08T11:58:22 <laanwj> i suppose we just didn't get agreement (or even enough people to care to be for or against) on #24294
1672022-04-08T11:58:23 <gribble> https://github.com/bitcoin/bitcoin/issues/24294 | RPC: Switch getblockfrompeer back to standard param names blockhash and nodeid by luke-jr · Pull Request #24294 · bitcoin/bitcoin · GitHub
1682022-04-08T11:58:38 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC (Client Quit)
1692022-04-08T12:00:35 <fanquake> I think it was bought up quite late, and the "new" names are probably fine. There's a weak NACK, and also a NACK for the usage of nodeid
1702022-04-08T12:02:15 <laanwj> right
1712022-04-08T12:02:50 <_aj_> no response to the nodeid comments. could open an alternate PR to just change block_hash
1722022-04-08T12:04:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1732022-04-08T12:04:29 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #24294: RPC: Switch getblockfrompeer back to standard param names blockhash and nodeid (master...getblockfrompeer_param_names) https://github.com/bitcoin/bitcoin/pull/24294
1742022-04-08T12:04:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1752022-04-08T12:04:51 <laanwj> that's ok, but i don't think we want to block rc4 on that
1762022-04-08T12:04:59 *** mekster66949 <mekster66949!~mekster@user/mekster> has quit IRC (Ping timeout: 272 seconds)
1772022-04-08T12:05:04 <MarcoFalke> So all places that consume a block hash are named blockhash?
1782022-04-08T12:05:12 <_aj_> yeah
1792022-04-08T12:06:25 <_aj_> MarcoFalke: (btw, re #24697 it would probably be even better to use std:chrono:clocks so that we have type checking on whether we're using mockable time or a steady clock (for scheduling eg). better to get rid of adjustedtime first though imo)
1802022-04-08T12:06:26 <gribble> https://github.com/bitcoin/bitcoin/issues/24697 | refactor: Use type-safe time for address relay by MarcoFalke · Pull Request #24697 · bitcoin/bitcoin · GitHub
1812022-04-08T12:08:09 <MarcoFalke> Eh, I don't know what to do. One is saying I should change adjusted time before, another is saying I should do it after the refactors. Guess I'll open two conflicting pulls and let reviewers decide?
1822022-04-08T12:08:27 <jonatack> yes wrt blockhash, the block_hash arg came about from my getblockfrompeer review feedback, based on how I read the RPC interface guidelines in the developer notes. maybe they could be clarified (i don't plan to tho :)
1832022-04-08T12:08:28 <MarcoFalke> Personally I find it easier after the refactors, as it can be done with a scripted-diff
1842022-04-08T12:08:40 <MarcoFalke> We also have nblocks and num_blocks
1852022-04-08T12:08:46 <_aj_> MarcoFalke: std:chrono:clock != std:chrono:duration
1862022-04-08T12:08:56 <MarcoFalke> Yes, I can look into that
1872022-04-08T12:09:23 <laanwj> MarcoFalke: if this is the first introdcutino of a new parameter name for an existing thing it makes sense to avoid it
1882022-04-08T12:10:03 <MarcoFalke> ok, maybe someone can open a pull for that?
1892022-04-08T12:10:11 <laanwj> but only if we can just agree on it, not if it's going to be bikeshedding all the way
1902022-04-08T12:12:42 <laanwj> ah yes the only other occurence of block_hash on the RPC interface is "window_final_block_hash" in a result
1912022-04-08T12:13:08 <_aj_> MarcoFalke: not sure if i'm confused because of multiple threads; so will restate. using "std::chrono::microseconds now" is great, but having "mockable_time::now()" generating a std::chrono::time_point would be even better, so that we have type checking to differentiate "now" that's a mocktime and "now" that's used for the scheduler.
1922022-04-08T12:14:01 <MarcoFalke> _aj_: The "Eh, ..." was in reply to "better to get rid of adjustedtime first though imo"
1932022-04-08T12:14:03 <jonatack> https://en.cppreference.com/w/cpp/chrono/steady_clock seems to be the monotonic one, at a quick look
1942022-04-08T12:14:29 <MarcoFalke> _aj_: I will look into chrono::clock
1952022-04-08T12:14:30 <_aj_> MarcoFalke: but the std::chrono::*seconds stuff now is fine, and getting rid of adjustedtime now so we don't have 3+ different clocks to try to implement seems sensible
1962022-04-08T12:15:23 *** Guest2213 <Guest2213!~Guest22@g118017.upc-g.chello.nl> has joined #bitcoin-core-dev
1972022-04-08T12:15:29 <MarcoFalke> I mean, if we change to ::clock, it might be better to do it right away. Rather than changing all 300 lines twice
1982022-04-08T12:15:57 <_aj_> let me see if i can find the old branch i had
1992022-04-08T12:16:21 *** mekster66949 <mekster66949!~mekster@user/mekster> has joined #bitcoin-core-dev
2002022-04-08T12:17:40 <laanwj> is monotonic time appropriate here at all? it's only used for durations, not to compare against absolute time values?
2012022-04-08T12:17:52 <MarcoFalke> Don't we have arg aliases? Can do blockhash|block_hash
2022022-04-08T12:18:01 <laanwj> MarcoFalke: but why
2032022-04-08T12:18:13 <MarcoFalke> sorry, wasn't serious
2042022-04-08T12:18:24 <_aj_> laanwj: we need monotonic-ish time for the scheduler and iirc some low-level net things
2052022-04-08T12:18:38 <laanwj> _aj_: oh for the scheduler ! yes
2062022-04-08T12:18:49 <fanquake> if no-one else wants to, i'll just cherry-pick the commit and drop the nodeid change
2072022-04-08T12:18:55 <fanquake> then we can merge than and the lock change
2082022-04-08T12:18:58 <fanquake> and tag rc4
2092022-04-08T12:19:04 <_aj_> ack
2102022-04-08T12:19:22 <fanquake> great
2112022-04-08T12:19:35 <laanwj> _aj_: i don't think monotonic time makes sense in the places adjusted time is used right now, which are timestamps coming from the network, but sure that makes sense
2122022-04-08T12:19:37 <laanwj> ack
2132022-04-08T12:20:08 <jonatack> mentioned it, as adjustedtime() being non-monotonic was an argument advanced for moving away from it, iirc
2142022-04-08T12:20:11 <_aj_> laanwj: what? no, monotonic and adjusted are oil and water
2152022-04-08T12:20:33 <_aj_> i couldn't think of two things that don't go together as badly as adjusted time and monotonic time
2162022-04-08T12:20:45 <laanwj> i'm really confused never mind
2172022-04-08T12:21:29 <_aj_> we need two clocks, monotonic-ish for the schedule, mockable for most things; and if we still have adjusted time, we need a third clock for that, and three is too many
2182022-04-08T12:22:30 <MarcoFalke> _aj_: Currently there is *no* clock in the codebase, only durations. The clocks part is implicit
2192022-04-08T12:22:37 <_aj_> MarcoFalke: yeah
2202022-04-08T12:22:48 <MarcoFalke> I think it is fine to add one clock for addrman time
2212022-04-08T12:23:06 <MarcoFalke> and then figure out the other clocks in a later release or later commit
2222022-04-08T12:23:16 <_aj_> MarcoFalke: oh, that's a clever idea!
2232022-04-08T12:25:42 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2242022-04-08T12:25:42 <bitcoin-git> [bitcoin] fanquake opened pull request #24806: RPC: Switch getblockfrompeer back to standard param name blockhash (master...use_bloch_hash) https://github.com/bitcoin/bitcoin/pull/24806
2252022-04-08T12:25:42 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2262022-04-08T12:26:24 <jonatack> laanwj: MarcoFalke: ok seems clear, will write an update to the developer note rpc guideline
2272022-04-08T12:26:52 <_aj_> MarcoFalke: https://github.com/ajtowns/bitcoin/blob/201908-systime/src/util/time.h was what i was playing with last time; was digging through net/processing which made things complicated
2282022-04-08T12:27:49 *** Guest2213 <Guest2213!~Guest22@g118017.upc-g.chello.nl> has quit IRC (Quit: Client closed)
2292022-04-08T12:28:42 <laanwj> jonatack: thanks! i guess we need something like "please consider whether there is already a convention for an argument or return field name in the RPC API, if so, try to use that"
2302022-04-08T12:29:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2312022-04-08T12:29:15 <bitcoin-git> [bitcoin] fanquake opened pull request #24807: [23.x] Final rc4 backports (23.x...final_rc4_backports) https://github.com/bitcoin/bitcoin/pull/24807
2322022-04-08T12:29:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2332022-04-08T12:30:25 <laanwj> i'm sure we don't achieve perfect consistency in the RPC API, ever, but on a best-effort basis when introducing new RPC calls or arguments makes sense
2342022-04-08T12:30:45 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2352022-04-08T12:30:45 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/38d3d0bfc4ca...c1059c9fef18
2362022-04-08T12:30:45 <bitcoin-git> bitcoin/master 39a34b6 Jon Atack: Put lock logging behind DEBUG_LOCKCONTENTION preprocessor directive
2372022-04-08T12:30:45 <bitcoin-git> bitcoin/master 4394733 Jon Atack: Add DEBUG_LOCKCONTENTION documentation to the developer notes
2382022-04-08T12:30:45 <bitcoin-git> bitcoin/master c1059c9 fanquake: Merge bitcoin/bitcoin#24770: Put lock logging behind DEBUG_LOCKCONTENTION ...
2392022-04-08T12:30:45 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2402022-04-08T12:30:51 <jonatack> laanwj: sgtm (and maybe mention blockhash as an example for clarity)
2412022-04-08T12:30:59 <laanwj> jonatack: yess
2422022-04-08T12:31:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2432022-04-08T12:31:01 <bitcoin-git> [bitcoin] fanquake merged pull request #24770: Put lock logging behind DEBUG_LOCKCONTENTION preprocessor directive (master...change-lock-logging-to-DEBUG_LOCKCONTENTION-one-commit) https://github.com/bitcoin/bitcoin/pull/24770
2442022-04-08T12:31:01 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2452022-04-08T12:31:59 <laanwj> if there are already two or more spellings, well, i guess it's something that needs to be decided on case by case basis
2462022-04-08T12:32:15 <laanwj> the author can just propose something
2472022-04-08T12:33:55 <laanwj> (but please not another new spelling hehe)
2482022-04-08T12:36:09 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
2492022-04-08T12:37:40 <laanwj> (XKCD 927 moment)
2502022-04-08T12:38:32 <jonatack> laanwj: thanks! those are helpful ideas
2512022-04-08T12:44:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2522022-04-08T12:44:00 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c1059c9fef18...e0680bbce8b8
2532022-04-08T12:44:00 <bitcoin-git> bitcoin/master 88917f9 Luke Dashjr: RPC: Switch getblockfrompeer back to standard param name blockhash
2542022-04-08T12:44:00 <bitcoin-git> bitcoin/master e0680bb fanquake: Merge bitcoin/bitcoin#24806: RPC: Switch getblockfrompeer back to standard...
2552022-04-08T12:44:00 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2562022-04-08T12:44:14 <fanquake> ok
2572022-04-08T12:44:16 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2582022-04-08T12:44:16 <bitcoin-git> [bitcoin] fanquake merged pull request #24806: RPC: Switch getblockfrompeer back to standard param name blockhash (master...use_bloch_hash) https://github.com/bitcoin/bitcoin/pull/24806
2592022-04-08T12:44:16 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2602022-04-08T12:44:23 <fanquake> if someone else wants to merge the backports
2612022-04-08T12:44:28 <fanquake> we could just about do an rc4
2622022-04-08T12:45:26 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
2632022-04-08T12:45:26 <laanwj> i'll do
2642022-04-08T12:46:03 <laanwj> though it might make sense to wait for CI first
2652022-04-08T12:48:43 <willcl_ark> Is there any documentation for building for macOS-arm64? installed a few brew deps with `arch -arm64 brew install...` but the linker still complains about building for x86_64 but using macOS-arm64 deps. Do i need to use `--host=HOST`?
2662022-04-08T12:50:49 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Quit: Leaving...)
2672022-04-08T12:50:54 <fanquake> building on m1 or x86
2682022-04-08T12:51:25 <willcl_ark> m1
2692022-04-08T12:51:52 <fanquake> you shouldn't have to do anything special. either for our build or when installing brew deps
2702022-04-08T12:52:04 <fanquake> it just works
2712022-04-08T12:52:42 <fanquake> not sure how you'd end up in a situation where the linker thinks you're cross-compiling for x86_64 if you haven't told it too
2722022-04-08T12:53:33 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
2732022-04-08T12:53:42 <willcl_ark> interesting, thanks. It's not my machine so I am remote debugging but it certainly didn't seem to like a pretty standard build sequence: https://pastebin.com/76QQ3XXK
2742022-04-08T12:54:53 <willcl_ark> Hmmm re-reading that, perhaps the linker is just notifying that it is going to use the right file, and the error is something else?
2752022-04-08T12:54:54 <fanquake> That looks like they are trying to cross-compile for x86_64 while building on arm64 (M1)
2762022-04-08T12:55:33 <willcl_ark> OK, but that shouldn't happen unless `--host` was configured, right? I will check their configure output now anyway...
2772022-04-08T12:55:35 <fanquake> Can you confirm what they are actually trying to do, and the ./configure invocation they are using
2782022-04-08T12:56:46 <willcl_ark> My understanding was simply following doc/build-osx.md on a M1 macbook (although we changed configure to `./configure --without-bdb --with-gui=no` I think), but will confirm
2792022-04-08T12:57:44 <fanquake> Yes, that will work fine, if they are building for M1, on M1, or for x86_64 on x86_64.
2802022-04-08T12:58:04 <willcl_ark> gotcha, thanks. Will see if this is somehow not the case
2812022-04-08T12:58:41 <fanquake> However it looks like they are trying to cross-compile, for x86_64, while on M1, in which case, they should do a depends build for HOST=arm64-apple-darwin, and then CONFIG_SITE=/blah/blah ./configure
2822022-04-08T12:59:03 <fanquake> ahh
2832022-04-08T12:59:10 <fanquake> HOST=x86_64-apple-darwin
2842022-04-08T13:00:37 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Remote host closed the connection)
2852022-04-08T13:00:56 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
2862022-04-08T13:02:13 <willcl_ark> We are not trying to cross compile, just get a native build on an M1
2872022-04-08T13:02:21 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
2882022-04-08T13:03:50 <fanquake> Which branch?
2892022-04-08T13:05:27 <willcl_ark> Can I PM you a config.log?
2902022-04-08T13:05:41 <fanquake> sure
2912022-04-08T13:08:19 *** mekster66949 <mekster66949!~mekster@user/mekster> has quit IRC (Ping timeout: 272 seconds)
2922022-04-08T13:11:41 *** mekster66949 <mekster66949!~mekster@user/mekster> has joined #bitcoin-core-dev
2932022-04-08T13:14:03 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
2942022-04-08T13:20:21 *** mekster66949 <mekster66949!~mekster@user/mekster> has quit IRC (Ping timeout: 272 seconds)
2952022-04-08T13:30:26 *** mekster66949 <mekster66949!~mekster@user/mekster> has joined #bitcoin-core-dev
2962022-04-08T13:30:33 *** mekster66949 <mekster66949!~mekster@user/mekster> has quit IRC (Client Quit)
2972022-04-08T13:32:24 *** mekster66949 <mekster66949!~mekster@user/mekster> has joined #bitcoin-core-dev
2982022-04-08T13:39:14 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
2992022-04-08T13:39:46 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
3002022-04-08T13:40:19 *** whitehorse[m] <whitehorse[m]!~whitehors@2001:470:69fc:105::1:f3cf> has joined #bitcoin-core-dev
3012022-04-08T13:49:25 <achow101> There's a wallet meeting later today, but I'm going to be unable to attend. Someone else can chair it, or we can skip this week.
3022022-04-08T13:52:04 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3032022-04-08T13:52:04 <bitcoin-git> [bitcoin] jonatack opened pull request #24808: doc: update RPC argument and field naming guideline in developer notes (master...update-developer-notes-rpc-argument-and-field-naming-guideline) https://github.com/bitcoin/bitcoin/pull/24808
3042022-04-08T13:52:04 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3052022-04-08T13:53:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3062022-04-08T13:53:46 <bitcoin-git> [bitcoin] laanwj pushed 4 commits to 23.x: https://github.com/bitcoin/bitcoin/compare/1ea76767d081...308a2022c0f4
3072022-04-08T13:53:46 <bitcoin-git> bitcoin/23.x 6374e24 Jon Atack: Put lock logging behind DEBUG_LOCKCONTENTION preprocessor directive
3082022-04-08T13:53:46 <bitcoin-git> bitcoin/23.x 69cc83d Jon Atack: Add DEBUG_LOCKCONTENTION documentation to the developer notes
3092022-04-08T13:53:46 <bitcoin-git> bitcoin/23.x e3e4be9 Luke Dashjr: RPC: Switch getblockfrompeer back to standard param name blockhash
3102022-04-08T13:53:46 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3112022-04-08T13:53:58 <jonatack> achow101: fwiw i won't be available either
3122022-04-08T13:54:02 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3132022-04-08T13:54:02 <bitcoin-git> [bitcoin] laanwj merged pull request #24807: [23.x] Final rc4 backports (23.x...final_rc4_backports) https://github.com/bitcoin/bitcoin/pull/24807
3142022-04-08T13:54:02 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3152022-04-08T13:55:42 <laanwj> let's cancel the wallet meeting for this week then
3162022-04-08T14:09:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3172022-04-08T14:09:47 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to 23.x: https://github.com/bitcoin/bitcoin/compare/308a2022c0f4...b6253829c182
3182022-04-08T14:09:47 <bitcoin-git> bitcoin/23.x 5f86355 laanwj: build: Bump rc to 23.0rc4
3192022-04-08T14:09:47 <bitcoin-git> bitcoin/23.x d37081e laanwj: qt: 23.0rc4 translations update
3202022-04-08T14:09:47 <bitcoin-git> bitcoin/23.x b625382 laanwj: doc: Update manual pages for 23.0rc4
3212022-04-08T14:09:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3222022-04-08T14:09:56 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
3232022-04-08T14:10:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3242022-04-08T14:10:03 <bitcoin-git> [bitcoin] laanwj pushed tag v23.0rc4: https://github.com/bitcoin/bitcoin/compare/v23.0rc4
3252022-04-08T14:10:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3262022-04-08T14:10:06 <laanwj> ^^
3272022-04-08T14:12:15 <fanquake> ð
3282022-04-08T14:17:03 <jonatack> \,o,/
3292022-04-08T14:21:16 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
3302022-04-08T14:21:35 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
3312022-04-08T14:25:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
3322022-04-08T14:25:43 <bitcoin-git> [gui] laanwj closed pull request #575: qt: Remove dbus notification code (master...2022-04-qt-implicit-dbus) https://github.com/bitcoin-core/gui/pull/575
3332022-04-08T14:25:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
3342022-04-08T14:30:31 <jonatack> see https://github.com/bitcoin/bitcoin/issues/24805#issuecomment-1092917376 in "[meta] Collect time offset samples" for a patch that adds getpeerinfo timeoffset to -netinfo, if helpful to anyone
3352022-04-08T14:38:23 *** davterra <davterra!~davterra@143.198.56.186> has quit IRC (Quit: Leaving)
3362022-04-08T14:42:45 *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Ping timeout: 256 seconds)
3372022-04-08T14:44:11 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
3382022-04-08T14:51:41 <MarcoFalke> Would also be good to include if the uaagent is 23.x or not
3392022-04-08T14:53:00 <MarcoFalke> at least for the outgoing connections
3402022-04-08T14:53:45 <MarcoFalke> Mabye also for incoming to see if they are running on a mobile device or server
3412022-04-08T14:55:14 <dhruv> laanwj: #24792 brings in secp master, but BIP324 depends on secp/#979 and scp/#982 which are still pending review. The conflict is likely because the tree changes iiuc.
3422022-04-08T14:55:15 <gribble> https://github.com/bitcoin/bitcoin/issues/24792 | Update libsecp256k1 subtree to current master by fanquake · Pull Request #24792 · bitcoin/bitcoin · GitHub
3432022-04-08T14:55:16 <gribble> https://github.com/bitcoin/bitcoin/issues/979 | Move WALLET_UPDATE_DEBUG output to normal debug.log by luke-jr · Pull Request #979 · bitcoin/bitcoin · GitHub
3442022-04-08T14:55:17 <gribble> https://github.com/bitcoin/bitcoin/issues/982 | Startup blocks on mutex at "Loading Addresses" · Issue #982 · bitcoin/bitcoin · GitHub
3452022-04-08T14:55:22 <lightlike> wouldn't logging be more suitable for gathering data over an extended time? Such as the added line by aj in https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2022-04-07#801100;
3462022-04-08T14:55:22 <gribble> https://github.com/bitcoin/bitcoin/issues/801100 | HTTP Error 404: Not Found
3472022-04-08T14:56:45 <sipa> building v23.0rc4
3482022-04-08T14:58:37 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 256 seconds)
3492022-04-08T15:02:32 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
3502022-04-08T15:07:48 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 246 seconds)
3512022-04-08T15:09:56 *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
3522022-04-08T15:12:20 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
3532022-04-08T15:14:11 *** jonatack92 <jonatack92!jonatack@user/jonatack> has joined #bitcoin-core-dev
3542022-04-08T15:15:24 *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Ping timeout: 268 seconds)
3552022-04-08T15:17:49 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 240 seconds)
3562022-04-08T15:23:54 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 246 seconds)
3572022-04-08T15:27:00 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
3582022-04-08T15:33:02 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Remote host closed the connection)
3592022-04-08T15:33:15 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
3602022-04-08T15:33:52 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
3612022-04-08T15:56:33 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 260 seconds)
3622022-04-08T15:57:37 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
3632022-04-08T16:00:12 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
3642022-04-08T16:02:36 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 240 seconds)
3652022-04-08T16:04:10 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
3662022-04-08T16:05:51 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
3672022-04-08T16:07:05 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has quit IRC (Remote host closed the connection)
3682022-04-08T16:07:33 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
3692022-04-08T16:08:14 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Client Quit)
3702022-04-08T16:10:05 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
3712022-04-08T16:23:38 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has joined #bitcoin-core-dev
3722022-04-08T16:53:09 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 272 seconds)
3732022-04-08T16:57:33 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
3742022-04-08T17:03:48 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
3752022-04-08T17:05:09 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 268 seconds)
3762022-04-08T17:07:56 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
3772022-04-08T17:13:47 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 268 seconds)
3782022-04-08T17:14:23 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
3792022-04-08T17:19:43 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 256 seconds)
3802022-04-08T17:26:15 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
3812022-04-08T17:27:01 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
3822022-04-08T17:27:49 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has quit IRC (Ping timeout: 240 seconds)
3832022-04-08T17:41:06 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 246 seconds)
3842022-04-08T17:43:22 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has joined #bitcoin-core-dev
3852022-04-08T17:46:22 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
3862022-04-08T17:50:11 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Max SendQ exceeded)
3872022-04-08T17:52:51 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
3882022-04-08T18:33:23 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 256 seconds)
3892022-04-08T18:34:19 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
3902022-04-08T18:35:37 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 248 seconds)
3912022-04-08T18:37:17 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
3922022-04-08T18:40:14 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Remote host closed the connection)
3932022-04-08T18:45:45 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has quit IRC (Ping timeout: 248 seconds)
3942022-04-08T18:45:53 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
3952022-04-08T18:48:39 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
3962022-04-08T19:01:53 *** NovaCoiner <NovaCoiner!~NovaCoine@15.64.114.89.rev.vodafone.pt> has joined #bitcoin-core-dev
3972022-04-08T19:02:27 <S3RK> wallet meeting?
3982022-04-08T19:04:26 <S3RK> ok, I see it's canceled
3992022-04-08T19:17:05 *** NovaCoiner <NovaCoiner!~NovaCoine@15.64.114.89.rev.vodafone.pt> has quit IRC (Quit: Client closed)
4002022-04-08T19:23:18 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 246 seconds)
4012022-04-08T19:25:46 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4022022-04-08T19:27:10 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Max SendQ exceeded)
4032022-04-08T19:31:22 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has joined #bitcoin-core-dev
4042022-04-08T19:37:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4052022-04-08T19:37:10 <bitcoin-git> [bitcoin] Empact opened pull request #24811: refactor: Prepare for moving ArgsManager out of util/system (master...2022-03-util-args-manager-prep) https://github.com/bitcoin/bitcoin/pull/24811
4062022-04-08T19:37:10 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4072022-04-08T19:39:35 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4082022-04-08T19:44:47 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 256 seconds)
4092022-04-08T19:46:45 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
4102022-04-08T19:47:40 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4112022-04-08T19:49:48 *** _flood <_flood!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Ping timeout: 268 seconds)
4122022-04-08T19:50:41 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Max SendQ exceeded)
4132022-04-08T19:51:24 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
4142022-04-08T19:56:47 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4152022-04-08T20:02:01 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 248 seconds)
4162022-04-08T20:03:08 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4172022-04-08T20:03:56 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Max SendQ exceeded)
4182022-04-08T20:04:25 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Ping timeout: 272 seconds)
4192022-04-08T20:04:48 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4202022-04-08T20:52:33 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 272 seconds)
4212022-04-08T20:54:33 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4222022-04-08T21:00:09 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 272 seconds)
4232022-04-08T21:01:08 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4242022-04-08T21:06:57 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 256 seconds)
4252022-04-08T21:08:31 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4262022-04-08T21:13:53 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 260 seconds)
4272022-04-08T21:15:45 *** metallicc <metallicc!~metallicc@c-73-217-34-231.hsd1.co.comcast.net> has quit IRC (Quit: Leaving)
4282022-04-08T21:16:16 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
4292022-04-08T21:16:34 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4302022-04-08T21:20:22 *** hashfunc14a0 <hashfunc14a0!~user@2601:5c0:c280:7090:4533:6252:8e32:243> has joined #bitcoin-core-dev
4312022-04-08T21:21:12 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Max SendQ exceeded)
4322022-04-08T21:27:33 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4332022-04-08T21:33:01 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 256 seconds)
4342022-04-08T21:36:44 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4352022-04-08T21:41:54 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 246 seconds)
4362022-04-08T21:44:34 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4372022-04-08T21:56:53 *** Lightsword <Lightsword!~Lightswor@user/lightsword> has quit IRC (Quit: ZNC)
4382022-04-08T21:59:46 *** Lightsword <Lightsword!~Lightswor@user/lightsword> has joined #bitcoin-core-dev
4392022-04-08T22:01:35 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
4402022-04-08T22:03:05 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 248 seconds)
4412022-04-08T22:03:37 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 256 seconds)
4422022-04-08T22:04:33 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4432022-04-08T22:07:19 *** hashfunc14a0 <hashfunc14a0!~user@2601:5c0:c280:7090:4533:6252:8e32:243> has quit IRC (Ping timeout: 268 seconds)
4442022-04-08T22:09:51 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 256 seconds)
4452022-04-08T22:15:25 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
4462022-04-08T22:18:50 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4472022-04-08T22:23:28 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
4482022-04-08T22:24:57 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹÑа!)
4492022-04-08T22:26:30 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
4502022-04-08T22:31:57 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Ping timeout: 256 seconds)
4512022-04-08T22:33:13 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
4522022-04-08T22:33:39 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 256 seconds)
4532022-04-08T22:45:59 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
4542022-04-08T22:49:06 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4552022-04-08T22:55:02 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Remote host closed the connection)
4562022-04-08T22:56:09 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4572022-04-08T22:57:56 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
4582022-04-08T22:58:33 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 248 seconds)
4592022-04-08T23:02:11 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Remote host closed the connection)
4602022-04-08T23:04:13 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4612022-04-08T23:10:08 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Remote host closed the connection)
4622022-04-08T23:11:14 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4632022-04-08T23:13:42 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
4642022-04-08T23:17:00 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 268 seconds)
4652022-04-08T23:18:51 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Ping timeout: 268 seconds)
4662022-04-08T23:27:48 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98c4:22d:b481:63b4> has quit IRC (Remote host closed the connection)
4672022-04-08T23:33:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4682022-04-08T23:33:57 <bitcoin-git> [gui] hebasto opened pull request #577: Getting ready to Qt 6 (1/n) (master...220409-qt6) https://github.com/bitcoin-core/gui/pull/577
4692022-04-08T23:33:57 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4702022-04-08T23:36:47 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC ()
4712022-04-08T23:43:13 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4722022-04-08T23:43:58 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
4732022-04-08T23:48:17 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4742022-04-08T23:48:18 <bitcoin-git> [bitcoin] aureleoules opened pull request #24812: util/check: Add CheckNonFatal identity function and use it in src/rpc (master...check_non_fatal_identity) https://github.com/bitcoin/bitcoin/pull/24812
4752022-04-08T23:48:18 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
4762022-04-08T23:49:04 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 268 seconds)
4772022-04-08T23:51:51 *** dviola <dviola!~diego@189.35.230.120> has quit IRC (Ping timeout: 256 seconds)
4782022-04-08T23:54:33 *** dviola <dviola!~diego@189.35.230.120> has joined #bitcoin-core-dev
4792022-04-08T23:59:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
4802022-04-08T23:59:44 <bitcoin-git> [gui] hebasto opened pull request #579: Getting ready to Qt 6 (2/n). Remove `QApplication::globalStrut()` (master...220409-strut) https://github.com/bitcoin-core/gui/pull/579
4812022-04-08T23:59:44 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev