12022-04-12T00:03:47 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
22022-04-12T00:08:57 *** dougefish <dougefish!~dougefish@5.29.11.69> has joined #bitcoin-core-dev
32022-04-12T00:29:33 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
42022-04-12T01:04:20 *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
52022-04-12T01:42:43 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
62022-04-12T01:45:02 *** ronoaldo <ronoaldo!~ronoaldo@187.75.45.227> has quit IRC (Quit: Konversation terminated!)
72022-04-12T02:21:16 *** ronoaldo <ronoaldo!~ronoaldo@187.75.45.227> has joined #bitcoin-core-dev
82022-04-12T03:37:49 *** Flow <Flow!~none@gentoo/developer/flow> has quit IRC (Ping timeout: 240 seconds)
92022-04-12T04:01:32 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
102022-04-12T04:19:36 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
112022-04-12T04:21:46 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
122022-04-12T05:10:32 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Quit: 404)
132022-04-12T05:21:42 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Read error: Connection reset by peer)
142022-04-12T05:24:23 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
152022-04-12T05:33:25 *** livestradamus <livestradamus!~quassel@user/livestradamus> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
162022-04-12T05:34:01 *** livestradamus <livestradamus!~quassel@user/livestradamus> has joined #bitcoin-core-dev
172022-04-12T06:48:34 *** Guest4795 <Guest4795!~Guest47@cpe-172-116-148-127.socal.res.rr.com> has joined #bitcoin-core-dev
182022-04-12T06:50:15 *** Guest4795 <Guest4795!~Guest47@cpe-172-116-148-127.socal.res.rr.com> has quit IRC (Client Quit)
192022-04-12T06:52:10 *** aleggg <aleggg!~aleggg@187.113.238.146> has joined #bitcoin-core-dev
202022-04-12T07:08:30 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
212022-04-12T07:15:59 *** vysn <vysn!~vysn@user/vysn> has quit IRC (Quit: WeeChat 3.4)
222022-04-12T07:21:07 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
232022-04-12T07:21:07 <bitcoin-git> [bitcoin] ryanofsky opened pull request #24830: init: Allow -noproxy and -proxy="" setting values (master...pr/proxy) https://github.com/bitcoin/bitcoin/pull/24830
242022-04-12T07:21:07 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
252022-04-12T07:35:17 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
262022-04-12T07:41:44 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
272022-04-12T07:48:36 *** An0rak <An0rak!An0rak@user/an0rak> has quit IRC (Ping timeout: 250 seconds)
282022-04-12T07:57:10 *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
292022-04-12T08:26:39 *** bw <bw!sid2730@user/betawaffle> has quit IRC (Ping timeout: 272 seconds)
302022-04-12T08:27:58 *** bw <bw!sid2730@user/betawaffle> has joined #bitcoin-core-dev
312022-04-12T08:33:00 *** bw <bw!sid2730@user/betawaffle> has quit IRC (Max SendQ exceeded)
322022-04-12T08:33:50 *** bw <bw!sid2730@user/betawaffle> has joined #bitcoin-core-dev
332022-04-12T08:35:50 *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Ping timeout: 250 seconds)
342022-04-12T08:58:18 *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
352022-04-12T09:04:27 *** kexkey <kexkey!~kexkey@178.249.214.10> has quit IRC (Ping timeout: 240 seconds)
362022-04-12T09:05:45 *** kexkey <kexkey!~kexkey@static-198-54-132-110.cust.tzulo.com> has joined #bitcoin-core-dev
372022-04-12T09:13:40 *** morcos <morcos!~morcos@gateway/tor-sasl/morcos> has quit IRC (Remote host closed the connection)
382022-04-12T09:14:00 *** morcos <morcos!~morcos@gateway/tor-sasl/morcos> has joined #bitcoin-core-dev
392022-04-12T10:03:08 *** jespada <jespada!~jespada@2a0c:5c84:1:4000::8dad> has quit IRC (Remote host closed the connection)
402022-04-12T10:08:32 *** jespada <jespada!~jespada@2a0c:5c84:1:3000::3b58> has joined #bitcoin-core-dev
412022-04-12T10:32:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
422022-04-12T10:32:38 <bitcoin-git> [bitcoin] fanquake opened pull request #24831: [POC] tidy: add include-what-you-use (master...include_what_you_use) https://github.com/bitcoin/bitcoin/pull/24831
432022-04-12T10:32:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
442022-04-12T10:34:11 <fanquake> moar automation
452022-04-12T10:38:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
462022-04-12T10:38:41 <bitcoin-git> [bitcoin] kcalvinalvin opened pull request #24832: index: Verify the block filter hash when reading the filter from disk. (master...2020-06-14-blockfilterindex-checksums) https://github.com/bitcoin/bitcoin/pull/24832
472022-04-12T10:38:41 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
482022-04-12T10:39:20 <jonatack> fanquake: nice, this could save a bunch of review time if it works well
492022-04-12T10:47:08 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
502022-04-12T10:47:09 <bitcoin-git> [bitcoin] jonatack opened pull request #24833: refactor: consensus/tx_verify.{h,cpp} fixups (master...consensus-tx_verify-fixups) https://github.com/bitcoin/bitcoin/pull/24833
512022-04-12T10:47:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
522022-04-12T10:53:18 *** meshcollider <meshcollider!meshcollid@jujube.rpblc.net> has quit IRC (Ping timeout: 246 seconds)
532022-04-12T10:54:56 *** meshcollider <meshcollider!meshcollid@meshcollider.jujube.ircnow.org> has joined #bitcoin-core-dev
542022-04-12T11:12:41 *** aleggg <aleggg!~aleggg@187.113.238.146> has quit IRC (Ping timeout: 256 seconds)
552022-04-12T11:27:11 *** aleggg <aleggg!~aleggg@189.114.88.236> has joined #bitcoin-core-dev
562022-04-12T11:34:07 *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 240 seconds)
572022-04-12T11:50:32 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
582022-04-12T11:52:30 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
592022-04-12T11:59:56 *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Ping timeout: 250 seconds)
602022-04-12T12:22:13 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
612022-04-12T12:23:34 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has joined #bitcoin-core-dev
622022-04-12T12:41:25 *** gnaf <gnaf!~gnaf@195-154-105-157.rev.poneytelecom.eu> has joined #bitcoin-core-dev
632022-04-12T13:15:14 *** bfsfhkacjzgcytf9 <bfsfhkacjzgcytf9!~bfsfhkacj@user/bfsfhkacjzgcytf> has joined #bitcoin-core-dev
642022-04-12T13:17:30 *** b10c <b10c!~quassel@user/b10c> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
652022-04-12T13:19:58 *** b10c <b10c!~quassel@static.33.106.217.95.clients.your-server.de> has joined #bitcoin-core-dev
662022-04-12T13:28:56 *** aleggg <aleggg!~aleggg@189.114.88.236> has quit IRC (Ping timeout: 248 seconds)
672022-04-12T13:33:27 *** aleggg <aleggg!~aleggg@177.204.24.152.dynamic.adsl.gvt.net.br> has joined #bitcoin-core-dev
682022-04-12T13:44:40 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
692022-04-12T13:46:24 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
702022-04-12T13:46:59 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Client Quit)
712022-04-12T13:48:42 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
722022-04-12T13:49:27 *** greypw2546 <greypw2546!~greypw254@grey.pw> has quit IRC (Quit: I'll be back!)
732022-04-12T13:49:38 *** greypw2546 <greypw2546!~greypw254@grey.pw> has joined #bitcoin-core-dev
742022-04-12T14:24:54 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
752022-04-12T14:26:20 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
762022-04-12T14:26:21 <bitcoin-git> [bitcoin] JhonZuluaga007 opened pull request #24834: Chaincode Labs Bitcoin Seminar (master...feature/Chaincode_Labs_Bitcoin_Seminar) https://github.com/bitcoin/bitcoin/pull/24834
772022-04-12T14:26:21 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
782022-04-12T14:27:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
792022-04-12T14:27:09 <bitcoin-git> [bitcoin] fanquake closed pull request #24834: Chaincode Labs Bitcoin Seminar (master...feature/Chaincode_Labs_Bitcoin_Seminar) https://github.com/bitcoin/bitcoin/pull/24834
802022-04-12T14:27:09 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
812022-04-12T14:35:05 *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
822022-04-12T14:40:02 <b10c> sipa: re avg messages sizes: I think this is what you are looking for based on the fields you added to getnettotals: https://bitcoind.observer/d/6xeklJU7z/sipa-average-message-size-per-connection-type?orgId=1&from=now-4d&to=now
832022-04-12T14:40:14 <b10c> avg size of outbound msgs by connection type: block-relay-only: 67.3 bytes, feeler: 27.9 bytes, inbound: 708 bytes, outbound-full-relay: 194 bytes
842022-04-12T14:40:21 <b10c> avg size of inbound msgs by connection type: block-relay-only: 358 bytes, feeler: 103 bytes, inbound: 280 bytes, outbound-full-relay: 502 bytes
852022-04-12T14:41:14 <sipa> b10c: Oh, awesome, I should have thought about looking into the tracepoints mechanism for that!
862022-04-12T14:41:30 <sipa> And interesting, those numbers are pretty different from mine.
872022-04-12T14:42:31 <sipa> (currently at 426 B for inbound, 237 for outbound-full-relay, 29 for feeler, 118 for block-relay-only)
882022-04-12T14:43:13 <sipa> actually, if you look at in/out combined, those could feasible be pretty similar
892022-04-12T14:44:31 <b10c> are your numbers combined?
902022-04-12T14:44:55 <sipa> yeah, i'm doing (payload_in+payload_out)/(msg_in+msg_out)
912022-04-12T14:46:30 <lightlike> would the difference between inbound/outbound full relay avg size be mostly GETADDR responses? or anything else I'm forgetting?
922022-04-12T14:47:15 <sipa> depending on your location the topology, it may also be that most block data is more coming in through outbound connections than inbound ones
932022-04-12T14:54:05 <b10c> added a graph for combined too, but numbers are still pretty different
942022-04-12T14:54:18 <b10c> combined: block-relay-only: 228 (sipa 118), feeler: 41.3 (sipa 29), inbound: 554 (sipa 426), outbound-full-relay: 363 (sipa 237)
952022-04-12T14:56:21 <jonatack> receiving blocks from outbounds seems to be the most common case for me, at least (i.e. topology in https://github.com/bitcoin/bitcoin/issues/24805#issuecomment-1092917376)
962022-04-12T14:57:37 <sipa> I guess all those differences can be explained due to differences in topology, I think.
972022-04-12T14:57:43 <jonatack> b10c: awesome. i need to try using tracepoints
982022-04-12T14:59:32 <lightlike> what do you mean with "topology" here?
992022-04-12T14:59:55 <sipa> where in the network connectivity graph you are located
1002022-04-12T15:00:00 <sipa> as in: who your peers are
1012022-04-12T15:02:25 <b10c> maybe also how many peers you have? more peers means e.g. more inbound INVs for blocks and tx, but you hopefully download the block/tx only once
1022022-04-12T15:02:42 <sipa> right
1032022-04-12T15:17:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1042022-04-12T15:17:38 <bitcoin-git> [bitcoin] Xekyo closed pull request #24712: wallet: reduce coin selection iterations (master...2022-03-reduce-coin-selection-iterations) https://github.com/bitcoin/bitcoin/pull/24712
1052022-04-12T15:17:38 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1062022-04-12T15:44:16 <_aj_> sipa: (my combined numbers: 409 inbound, 270 outbound, 26 feeler, 312 block-relay)
1072022-04-12T15:47:14 <_aj_> sipa: (node with only outbounds: 423 outbound, 358 manual, 33 feeler, 17 block-relay-only)
1082022-04-12T15:50:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1092022-04-12T15:50:40 <bitcoin-git> [bitcoin] dergoegge opened pull request #24835: Revert "Do not consider blocked networks local" (master...2022-04-revert-1653f97c) https://github.com/bitcoin/bitcoin/pull/24835
1102022-04-12T15:50:40 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1112022-04-12T15:57:43 *** theStack <theStack!~honeybadg@vps1648322.vs.webtropia-customer.com> has left #bitcoin-core-dev
1122022-04-12T15:59:28 *** theStack <theStack!~honeybadg@vps1648322.vs.webtropia-customer.com> has joined #bitcoin-core-dev
1132022-04-12T16:00:00 *** Guest69 <Guest69!~Guest69@5.2.196.49> has joined #bitcoin-core-dev
1142022-04-12T16:00:00 <theStack> sipa: does it matter for the statistics whether are non-pruned or pruned node is used? happy to run your patch for a few days and report back, but i only have a pruned node available right now
1152022-04-12T16:00:31 *** Guest69 <Guest69!~Guest69@5.2.196.49> has quit IRC (Client Quit)
1162022-04-12T16:00:52 *** Guest69 <Guest69!~Guest69@5.2.196.49> has joined #bitcoin-core-dev
1172022-04-12T16:01:19 *** Guest69 <Guest69!~Guest69@5.2.196.49> has quit IRC (Client Quit)
1182022-04-12T16:01:34 *** Guest69 <Guest69!~Guest69@5.2.196.49> has joined #bitcoin-core-dev
1192022-04-12T16:01:40 <sipa> Both are interesting actually; the context is for BIP324 it'd be good to have an idea of how much per-message CPU cost overhead has. If most of the bandwidth on the network is due to large messages, this doesn't matter as much, for example.
1202022-04-12T16:03:47 *** Guest69 <Guest69!~Guest69@5.2.196.49> has quit IRC (Client Quit)
1212022-04-12T16:04:08 *** Guest69 <Guest69!~Guest69@5.2.196.49> has joined #bitcoin-core-dev
1222022-04-12T16:16:06 *** An0rak <An0rak!An0rak@user/an0rak> has joined #bitcoin-core-dev
1232022-04-12T16:17:26 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
1242022-04-12T16:19:11 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
1252022-04-12T16:19:40 <jamesob> b10c: very cool!
1262022-04-12T16:25:53 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
1272022-04-12T16:30:23 *** Guest69 <Guest69!~Guest69@5.2.196.49> has quit IRC (Quit: Client closed)
1282022-04-12T16:30:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1292022-04-12T16:30:25 <bitcoin-git> [bitcoin] glozow opened pull request #24836: add RPC (-regtest only) for testing package policy (master...client-submitpackage) https://github.com/bitcoin/bitcoin/pull/24836
1302022-04-12T16:30:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1312022-04-12T16:30:53 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1322022-04-12T16:49:17 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
1332022-04-12T16:54:35 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
1342022-04-12T16:55:01 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
1352022-04-12T16:59:00 *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Ping timeout: 272 seconds)
1362022-04-12T17:00:55 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
1372022-04-12T17:29:51 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
1382022-04-12T17:34:47 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 240 seconds)
1392022-04-12T17:56:07 *** orville <orville!~orville@50-242-118-141-static.hfc.comcastbusiness.net> has joined #bitcoin-core-dev
1402022-04-12T18:04:20 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
1412022-04-12T18:14:17 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
1422022-04-12T18:16:03 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1432022-04-12T18:16:04 <bitcoin-git> [bitcoin] ryanofsky opened pull request #24837: init: Prevent -noproxy and -proxy=0 from interacting with other settings (master...pr/proxyi) https://github.com/bitcoin/bitcoin/pull/24837
1442022-04-12T18:16:04 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1452022-04-12T18:17:27 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
1462022-04-12T18:22:03 *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
1472022-04-12T18:51:49 *** orville <orville!~orville@50-242-118-141-static.hfc.comcastbusiness.net> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
1482022-04-12T18:53:20 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 250 seconds)
1492022-04-12T18:58:47 *** Kaizen_K_ <Kaizen_K_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
1502022-04-12T19:02:30 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 272 seconds)
1512022-04-12T19:08:23 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1522022-04-12T19:13:12 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
1532022-04-12T19:21:14 *** Kaizen_K_ <Kaizen_K_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
1542022-04-12T19:23:29 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
1552022-04-12T19:28:00 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 250 seconds)
1562022-04-12T19:31:57 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
1572022-04-12T19:36:36 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
1582022-04-12T19:45:29 <jamesob> Can we reopen this PR or is it truly not open for reconsideration? #14635 cc ryanofsky _aj_ jonatack
1592022-04-12T19:45:31 <gribble> https://github.com/bitcoin/bitcoin/issues/14635 | developer-notes: allow lowerCamelCase by ryanofsky · Pull Request #14635 · bitcoin/bitcoin · GitHub
1602022-04-12T19:45:41 *** Kaizen_K_ <Kaizen_K_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
1612022-04-12T19:46:18 <fanquake> unlocked the discussion
1622022-04-12T19:46:37 <jamesob> fanquake: thanks
1632022-04-12T19:47:10 <fanquake> For anyone wondering, it had only been locked by the Draht bot, due to age
1642022-04-12T19:47:36 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 248 seconds)
1652022-04-12T19:50:54 *** Kaizen_K_ <Kaizen_K_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
1662022-04-12T19:52:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1672022-04-12T19:52:49 <bitcoin-git> [bitcoin] hebasto opened pull request #24838: build, windows: Use Direct2D plugin (master...220412-d2d) https://github.com/bitcoin/bitcoin/pull/24838
1682022-04-12T19:52:49 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1692022-04-12T19:56:34 *** bfsfhkacjzgcytf9 <bfsfhkacjzgcytf9!~bfsfhkacj@user/bfsfhkacjzgcytf> has quit IRC (Quit: The Lounge - https://thelounge.chat)
1702022-04-12T20:04:08 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Ping timeout: 248 seconds)
1712022-04-12T20:04:38 *** bfsfhkacjzgcytf9 <bfsfhkacjzgcytf9!~bfsfhkacj@user/bfsfhkacjzgcytf> has joined #bitcoin-core-dev
1722022-04-12T20:04:47 *** real_or_random <real_or_random!~real_or_r@user/real-or-random/x-4440763> has quit IRC (Ping timeout: 256 seconds)
1732022-04-12T20:07:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1742022-04-12T20:07:31 <bitcoin-git> [bitcoin] theStack opened pull request #24839: test: use MiniWallet for mining_prioritisetransaction.py (master...202204-test-use_MiniWallet_for_mining_prioritisetransaction) https://github.com/bitcoin/bitcoin/pull/24839
1752022-04-12T20:07:31 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1762022-04-12T20:20:53 <jamesob> Anyone know if we have docs on translations (e.g. using `_(...)`)? I'm wondering if the argument to _(...) has to be a raw string in order for whatever translation script to pick up on its contents
1772022-04-12T20:22:04 <fanquake> If no docs probably best to ask hebasto / laanwj
1782022-04-12T20:24:35 *** real_or_random <real_or_random!~real_or_r@user/real-or-random/x-4440763> has joined #bitcoin-core-dev
1792022-04-12T20:25:28 <hebasto> jamesob: yes
1802022-04-12T20:26:17 <hebasto> strings to be translated being extracted from the sources
1812022-04-12T20:27:10 <jamesob> hebasto: do the raw strings need to be on a single line?
1822022-04-12T20:27:20 <hebasto> no
1832022-04-12T20:27:31 <jamesob> okay great, thanks hebasto
1842022-04-12T20:27:36 <hebasto> yw
1852022-04-12T20:27:46 <jamesob> do we have docs somewhere or should I make a note to add to developer-notes?
1862022-04-12T20:28:31 <hebasto> `share/qt/extract_strings_qt.py`
1872022-04-12T20:28:55 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
1882022-04-12T20:30:10 <hebasto> and `doc/translation_strings_policy.md`
1892022-04-12T20:33:00 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 250 seconds)
1902022-04-12T20:35:53 *** dunxen <dunxen!~dunxen@gateway/tor-sasl/dunxen> has joined #bitcoin-core-dev
1912022-04-12T20:36:47 <jonatack> jamesob: i was thinking of maybe writing an update to the developer notes that at least explains what that style is (what, why, where) to provide context for reviewers
1922022-04-12T20:37:27 <jonatack> the idea was that regardless of consensus on using it, in any case reviewers need context
1932022-04-12T20:39:14 <jonatack> said update wouldn't propose the style change
1942022-04-12T20:52:28 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:6832:85dc:85dc:6f36> has quit IRC (Remote host closed the connection)
1952022-04-12T20:57:38 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
1962022-04-12T21:01:47 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 240 seconds)
1972022-04-12T21:08:27 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
1982022-04-12T21:20:29 <jamesob> jonatack: I think it's worth just proposing the change again, since I think there's a good chance that no one materially opposes it
1992022-04-12T21:29:14 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
2002022-04-12T21:56:55 *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 260 seconds)
2012022-04-12T22:06:05 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Remote host closed the connection)
2022022-04-12T22:06:14 *** ronoaldo <ronoaldo!~ronoaldo@187.75.45.227> has quit IRC (Quit: Konversation terminated!)
2032022-04-12T22:11:15 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
2042022-04-12T22:15:53 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 248 seconds)
2052022-04-12T22:22:03 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
2062022-04-12T22:26:33 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 248 seconds)
2072022-04-12T22:28:08 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
2082022-04-12T22:33:03 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 260 seconds)
2092022-04-12T22:38:55 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
2102022-04-12T22:40:10 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
2112022-04-12T22:43:05 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 248 seconds)
2122022-04-12T22:45:05 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
2132022-04-12T22:45:45 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 248 seconds)
2142022-04-12T22:49:24 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 246 seconds)
2152022-04-12T23:00:22 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
2162022-04-12T23:01:45 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
2172022-04-12T23:06:01 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 248 seconds)
2182022-04-12T23:13:04 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2192022-04-12T23:13:04 <bitcoin-git> [gui] hebasto merged pull request #543: peers-tab: add connection duration column to tableview (master...1643853831-peers-tab-add-duration-column) https://github.com/bitcoin-core/gui/pull/543
2202022-04-12T23:13:04 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2212022-04-12T23:13:21 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2222022-04-12T23:13:21 <bitcoin-git> [bitcoin] hebasto pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/2b5a741e98f1...0f46e73c740e
2232022-04-12T23:13:21 <bitcoin-git> bitcoin/master 127de22 Jon Atack: gui: add FormatPeerAge() utility helper
2242022-04-12T23:13:21 <bitcoin-git> bitcoin/master 209301a randymcmillan: gui: add Age column to peers tab
2252022-04-12T23:13:21 <bitcoin-git> bitcoin/master 51708c4 randymcmillan: gui: peersWidget - ResizeToContents Age and IP/Netmask columns
2262022-04-12T23:13:21 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2272022-04-12T23:17:45 *** ronoaldo <ronoaldo!~ronoaldo@187.75.45.227> has joined #bitcoin-core-dev
2282022-04-12T23:20:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2292022-04-12T23:20:43 <bitcoin-git> [gui] hebasto merged pull request #576: Add qt unit test runner summary (master...gui-test-runner-summary) https://github.com/bitcoin-core/gui/pull/576
2302022-04-12T23:20:43 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2312022-04-12T23:20:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2322022-04-12T23:20:58 <bitcoin-git> [bitcoin] hebasto pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/0f46e73c740e...f50976002645
2332022-04-12T23:20:58 <bitcoin-git> bitcoin/master ba44aae Jon Atack: gui: add test runner summary
2342022-04-12T23:20:58 <bitcoin-git> bitcoin/master 2489b6f Jon Atack: gui: count test failures in test runner summary
2352022-04-12T23:20:58 <bitcoin-git> bitcoin/master d025d7f Jon Atack: gui, refactor: rename fInvalid to num_test_failures in test_main.cpp
2362022-04-12T23:20:58 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2372022-04-12T23:27:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2382022-04-12T23:27:37 <bitcoin-git> [bitcoin] hebasto pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/f50976002645...f60a63cc5f16
2392022-04-12T23:27:37 <bitcoin-git> bitcoin/master 6f1e162 Hennadii Stepanov: qt: Fix headers
2402022-04-12T23:27:37 <bitcoin-git> bitcoin/master c7add88 Hennadii Stepanov: qt: Use `|` instead of `+` for key modifiers
2412022-04-12T23:27:37 <bitcoin-git> bitcoin/master 6312575 Hennadii Stepanov: qt: Update deprecated enum value
2422022-04-12T23:27:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2432022-04-12T23:27:51 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2442022-04-12T23:27:51 <bitcoin-git> [gui] hebasto merged pull request #577: Getting ready to Qt 6 (1/n) (master...220409-qt6) https://github.com/bitcoin-core/gui/pull/577
2452022-04-12T23:27:51 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2462022-04-12T23:29:30 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
2472022-04-12T23:33:47 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 240 seconds)
2482022-04-12T23:35:53 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 248 seconds)
2492022-04-12T23:39:39 *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
2502022-04-12T23:46:42 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
2512022-04-12T23:47:49 *** Willtech <Willtech!~Willtech@user/Willtech> has joined #bitcoin-core-dev
2522022-04-12T23:54:35 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Remote host closed the connection)
2532022-04-12T23:59:44 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev