12022-04-13T00:04:02 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 250 seconds)
22022-04-13T00:10:32 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
32022-04-13T00:14:48 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 248 seconds)
42022-04-13T00:16:36 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
52022-04-13T00:20:56 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 250 seconds)
62022-04-13T00:24:13 *** Jackielove4u <Jackielove4u!uid43977@user/jackielove4u> has quit IRC (Quit: Connection closed for inactivity)
72022-04-13T00:26:45 *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
82022-04-13T00:27:24 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
92022-04-13T00:31:53 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 248 seconds)
102022-04-13T00:33:28 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
112022-04-13T00:35:10 *** ronoaldo <ronoaldo!~ronoaldo@187.75.45.227> has quit IRC (Quit: Konversation terminated!)
122022-04-13T00:37:55 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 260 seconds)
132022-04-13T00:42:06 *** An0rak <An0rak!An0rak@user/an0rak> has quit IRC (Ping timeout: 246 seconds)
142022-04-13T00:44:16 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
152022-04-13T00:48:57 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 248 seconds)
162022-04-13T00:50:23 *** NorrinRadd <NorrinRadd!~username@102.67.16.112> has quit IRC (Ping timeout: 256 seconds)
172022-04-13T01:14:28 *** geyaeb2 <geyaeb2!~geyaeb@gateway/tor-sasl/geyaeb> has quit IRC (Quit: WeeChat 3.4.1)
182022-04-13T01:14:46 *** geyaeb <geyaeb!~geyaeb@gateway/tor-sasl/geyaeb> has joined #bitcoin-core-dev
192022-04-13T01:18:02 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
202022-04-13T01:22:32 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 248 seconds)
212022-04-13T01:25:53 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Quit: Leaving...)
222022-04-13T01:28:50 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
232022-04-13T01:33:12 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 248 seconds)
242022-04-13T01:34:54 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
252022-04-13T01:39:22 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 250 seconds)
262022-04-13T01:45:41 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
272022-04-13T01:50:17 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 248 seconds)
282022-04-13T01:51:52 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
292022-04-13T01:52:55 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
302022-04-13T01:56:33 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 256 seconds)
312022-04-13T02:04:43 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
322022-04-13T02:15:15 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
332022-04-13T02:15:15 <bitcoin-git> [bitcoin] whiteh0rse opened pull request #24840: test: port 'lint-shell.sh' to python (master...24783-port-lint-shell-to-python) https://github.com/bitcoin/bitcoin/pull/24840
342022-04-13T02:15:16 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
352022-04-13T03:01:06 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
362022-04-13T03:07:04 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 248 seconds)
372022-04-13T03:13:31 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has joined #bitcoin-core-dev
382022-04-13T03:30:24 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
392022-04-13T03:34:35 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 256 seconds)
402022-04-13T03:42:33 *** NorrinRadd <NorrinRadd!~username@102.67.16.112> has joined #bitcoin-core-dev
412022-04-13T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
422022-04-13T04:01:35 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
432022-04-13T04:06:26 *** Willtech <Willtech!~Willtech@user/Willtech> has quit IRC (Read error: Connection reset by peer)
442022-04-13T04:07:03 *** Willtech <Willtech!~Willtech@user/Willtech> has joined #bitcoin-core-dev
452022-04-13T04:18:50 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:f416:3ef:aed2:fa46> has quit IRC (Ping timeout: 250 seconds)
462022-04-13T04:25:20 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9> has joined #bitcoin-core-dev
472022-04-13T06:14:21 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
482022-04-13T06:14:51 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
492022-04-13T06:54:08 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 260 seconds)
502022-04-13T06:55:53 *** nanotube <nanotube!~nanotube@user/nanotube> has quit IRC (Ping timeout: 260 seconds)
512022-04-13T06:57:21 *** nanotube <nanotube!~nanotube@user/nanotube> has joined #bitcoin-core-dev
522022-04-13T06:57:52 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 250 seconds)
532022-04-13T07:01:59 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
542022-04-13T07:04:55 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has joined #bitcoin-core-dev
552022-04-13T07:06:37 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 240 seconds)
562022-04-13T07:15:30 *** Jackielove4u <Jackielove4u!uid43977@user/jackielove4u> has joined #bitcoin-core-dev
572022-04-13T07:22:21 *** gnaf <gnaf!~gnaf@195-154-105-157.rev.poneytelecom.eu> has quit IRC (Quit: Konversation terminated!)
582022-04-13T07:33:50 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Ping timeout: 250 seconds)
592022-04-13T07:36:01 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
602022-04-13T07:40:31 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 256 seconds)
612022-04-13T07:44:14 *** bfsfhkacjzgcytf9 <bfsfhkacjzgcytf9!~bfsfhkacj@user/bfsfhkacjzgcytf> has quit IRC (Ping timeout: 250 seconds)
622022-04-13T07:44:50 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
632022-04-13T08:44:35 *** Willtech <Willtech!~Willtech@user/Willtech> has quit IRC (Remote host closed the connection)
642022-04-13T09:00:25 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
652022-04-13T09:04:27 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 240 seconds)
662022-04-13T09:04:31 *** kexkey <kexkey!~kexkey@static-198-54-132-110.cust.tzulo.com> has quit IRC (Ping timeout: 256 seconds)
672022-04-13T09:05:40 *** kexkey <kexkey!~kexkey@178.249.214.27> has joined #bitcoin-core-dev
682022-04-13T09:12:39 *** goatpig <goatpig!~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2> has joined #bitcoin-core-dev
692022-04-13T09:15:24 *** meshcollider <meshcollider!meshcollid@meshcollider.jujube.ircnow.org> has quit IRC (Ping timeout: 240 seconds)
702022-04-13T09:21:10 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
712022-04-13T09:45:25 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
722022-04-13T09:49:27 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 240 seconds)
732022-04-13T10:05:29 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has joined #bitcoin-core-dev
742022-04-13T10:10:58 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
752022-04-13T10:30:22 *** dougefish2 <dougefish2!~dougefish@2a00:a040:19e:67b8:8ed1:c610:9029:1239> has joined #bitcoin-core-dev
762022-04-13T10:37:44 *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Ping timeout: 248 seconds)
772022-04-13T10:39:12 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Read error: Connection reset by peer)
782022-04-13T10:40:07 *** realies <realies!~realies@user/realies> has quit IRC (Quit: Ping timeout (120 seconds))
792022-04-13T10:40:21 *** realies <realies!~realies@user/realies> has joined #bitcoin-core-dev
802022-04-13T10:42:00 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
812022-04-13T10:47:15 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
822022-04-13T10:51:52 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 250 seconds)
832022-04-13T10:57:05 <fanquake> hebasto / laanwj: I've added another GCC patch to our Guix build, that may fix https://github.com/bitcoin-core/gui/issues/582: https://github.com/fanquake/bitcoin/tree/guix_fix_windows_longjmp, if you wanted to test
842022-04-13T10:57:38 <hebasto> fanquake: thanks!
852022-04-13T10:57:46 <fanquake> unlike the vmov fix, this isn't being backported by distros as far as I can tell.
862022-04-13T10:57:58 <fanquake> Bit of a stab in the dark based on GCC commits
872022-04-13T11:10:36 *** TheRec <TheRec!~toto@user/therec> has quit IRC ()
882022-04-13T11:19:02 *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
892022-04-13T11:47:40 <hebasto> fanquake: I've applied your patch into the 23.x branch, and tested it on Windows 11 Pro and in `wine` on Ubuntu 22.04
902022-04-13T11:47:54 <hebasto> everything works flawlessly
912022-04-13T11:48:52 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
922022-04-13T11:48:52 <bitcoin-git> [bitcoin] hebasto closed pull request #24838: build, windows: Use Direct2D plugin (master...220412-d2d) https://github.com/bitcoin/bitcoin/pull/24838
932022-04-13T11:48:52 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
942022-04-13T11:57:38 *** ronoaldo <ronoaldo!~ronoaldo@191.19.24.11> has joined #bitcoin-core-dev
952022-04-13T11:58:53 <fanquake> I guess I should turn that into a considerable patch
962022-04-13T11:58:56 <laanwj> fanquake: that's absolutely great
972022-04-13T12:00:58 <laanwj> fixing SEH is the right way to fix this
982022-04-13T12:03:12 <laanwj> better than a freetype/qt specific workaround, it potentially affects other uses of frame unwinding as well liee C++ exceptions
992022-04-13T12:04:11 <fanquake> I'll write a proper commit message, split it out of the vmov patch handling, and open a PR
1002022-04-13T12:04:58 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
1012022-04-13T12:07:49 <laanwj> thank you
1022022-04-13T12:10:51 *** dougefish2 <dougefish2!~dougefish@2a00:a040:19e:67b8:8ed1:c610:9029:1239> has quit IRC (Quit: Client closed)
1032022-04-13T12:15:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1042022-04-13T12:15:47 <bitcoin-git> [bitcoin] chinggg opened pull request #24841: test: fix connman UB by calling derived constructor (master...fix-test-connman-ub) https://github.com/bitcoin/bitcoin/pull/24841
1052022-04-13T12:15:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1062022-04-13T12:18:02 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
1072022-04-13T12:36:21 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1082022-04-13T12:36:21 <bitcoin-git> [bitcoin] fanquake opened pull request #24842: guix: fix GCC 10.3.0 + mingw-w64 setjmp/longjmp issues (master...guix_fix_windows_longjmp) https://github.com/bitcoin/bitcoin/pull/24842
1092022-04-13T12:36:21 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1102022-04-13T13:02:34 *** An0rak <An0rak!An0rak@user/an0rak> has joined #bitcoin-core-dev
1112022-04-13T13:04:30 *** Flow <Flow!~none@gentoo/developer/flow> has joined #bitcoin-core-dev
1122022-04-13T13:08:47 *** An0rak <An0rak!An0rak@user/an0rak> has quit IRC ()
1132022-04-13T13:09:28 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1142022-04-13T13:09:29 <bitcoin-git> [bitcoin] fanquake opened pull request #24843: [23.x] rc5 backports (23.x...rc5_backports) https://github.com/bitcoin/bitcoin/pull/24843
1152022-04-13T13:09:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1162022-04-13T13:11:42 *** meshcollider <meshcollider!meshcollid@meshcollider.jujube.ircnow.org> has joined #bitcoin-core-dev
1172022-04-13T13:25:45 *** An0rak <An0rak!An0rak@user/an0rak> has joined #bitcoin-core-dev
1182022-04-13T14:14:53 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
1192022-04-13T14:19:00 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 250 seconds)
1202022-04-13T14:33:51 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
1212022-04-13T14:34:06 *** mekster66949 <mekster66949!~mekster@user/mekster> has quit IRC (Quit: mekster66949)
1222022-04-13T14:34:27 *** mekster66949 <mekster66949!~mekster@user/mekster> has joined #bitcoin-core-dev
1232022-04-13T14:46:23 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
1242022-04-13T14:50:06 <hebasto> #24157 looks good, maybe final review and merge it?
1252022-04-13T14:50:08 <gribble> https://github.com/bitcoin/bitcoin/issues/24157 | p2p: Replace RecursiveMutex `cs_totalBytesSent` with Mutex and rename it by w0xlt · Pull Request #24157 · bitcoin/bitcoin · GitHub
1262022-04-13T14:59:57 *** Nekorand <Nekorand!~Random@cm-188-171-200-176.telecable.es> has joined #bitcoin-core-dev
1272022-04-13T15:00:51 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9> has quit IRC (Remote host closed the connection)
1282022-04-13T15:01:00 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
1292022-04-13T15:02:46 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
1302022-04-13T15:03:33 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Client Quit)
1312022-04-13T15:05:16 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
1322022-04-13T15:06:00 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9> has joined #bitcoin-core-dev
1332022-04-13T15:06:07 *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Ping timeout: 240 seconds)
1342022-04-13T15:10:07 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9> has quit IRC (Ping timeout: 240 seconds)
1352022-04-13T15:11:56 *** Nekorand <Nekorand!~Random@cm-188-171-200-176.telecable.es> has quit IRC (Quit: Leaving)
1362022-04-13T15:14:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1372022-04-13T15:14:37 <bitcoin-git> [gui] hebasto closed pull request #108: WIP: mempool stats chart (master...2020/03/mempool_graph) https://github.com/bitcoin-core/gui/pull/108
1382022-04-13T15:14:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1392022-04-13T15:15:27 *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
1402022-04-13T15:16:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1412022-04-13T15:16:05 <bitcoin-git> [gui] hebasto closed pull request #305: Display send/recv in Bps instead of totals in the debug window (master...SendRecvSpeed-gui) https://github.com/bitcoin-core/gui/pull/305
1422022-04-13T15:16:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1432022-04-13T15:16:49 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9> has joined #bitcoin-core-dev
1442022-04-13T15:21:07 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9> has quit IRC (Ping timeout: 240 seconds)
1452022-04-13T15:22:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1462022-04-13T15:22:06 <bitcoin-git> [gui] hebasto closed pull request #494: Replace testnet with signet as a default network for Android (master...211201-signet) https://github.com/bitcoin-core/gui/pull/494
1472022-04-13T15:22:06 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1482022-04-13T15:22:59 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
1492022-04-13T15:27:27 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 256 seconds)
1502022-04-13T15:29:03 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9> has joined #bitcoin-core-dev
1512022-04-13T15:33:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1522022-04-13T15:33:05 <bitcoin-git> [gui] w0xlt opened pull request #583: Add translator comments to `TransactionDesc::FormatTxStatus` (master...translator_comments_transactiondesc) https://github.com/bitcoin-core/gui/pull/583
1532022-04-13T15:33:05 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1542022-04-13T15:42:14 *** TheRec <TheRec!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
1552022-04-13T16:16:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1562022-04-13T16:16:26 <bitcoin-git> [bitcoin] Kvaciral opened pull request #24844: lint: Convert lint-whitespace.sh to Python (master...lint-whitespace-port) https://github.com/bitcoin/bitcoin/pull/24844
1572022-04-13T16:16:26 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1582022-04-13T16:21:36 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1592022-04-13T16:21:36 <bitcoin-git> [gui] hebasto opened pull request #584: Getting ready to Qt 6 (5/n). Do not assume `qDBusRegisterMetaType` return type (master...220413-metatype) https://github.com/bitcoin-core/gui/pull/584
1602022-04-13T16:21:36 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1612022-04-13T16:25:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1622022-04-13T16:25:30 <bitcoin-git> [bitcoin] furszy opened pull request #24845: wallet: createTransaction, return proper error description for "too-long-mempool-chain" + introduce generic Result classes (master...2022_wallet_operationresult) https://github.com/bitcoin/bitcoin/pull/24845
1632022-04-13T16:25:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1642022-04-13T16:25:47 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
1652022-04-13T16:40:49 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
1662022-04-13T16:45:07 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 240 seconds)
1672022-04-13T16:47:01 *** Skyz <Skyz!~Skyz@user/skyz> has joined #bitcoin-core-dev
1682022-04-13T16:48:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1692022-04-13T16:48:29 <bitcoin-git> [bitcoin] jamesob opened pull request #24846: developer-notes: allow lowerCamelCase for methods (master...jamesob-22-04-dev-notes-methods) https://github.com/bitcoin/bitcoin/pull/24846
1702022-04-13T16:48:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1712022-04-13T17:05:59 *** Skyz <Skyz!~Skyz@user/skyz> has quit IRC (Quit: Client closed)
1722022-04-13T17:40:47 *** vysn <vysn!~vysn@user/vysn> has quit IRC (Ping timeout: 240 seconds)
1732022-04-13T17:47:24 *** goatpig <goatpig!~goat@2001:861:3241:fa40:e5f5:f5bf:43db:45e2> has quit IRC (Remote host closed the connection)
1742022-04-13T17:51:27 *** An0rak <An0rak!An0rak@user/an0rak> has quit IRC (Ping timeout: 240 seconds)
1752022-04-13T18:18:28 *** Earnestly <Earnestly!~earnest@user/earnestly> has quit IRC (Read error: Connection reset by peer)
1762022-04-13T18:19:56 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 250 seconds)
1772022-04-13T18:21:18 *** Earnestly <Earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
1782022-04-13T18:29:54 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
1792022-04-13T18:38:19 *** lowhope <lowhope!~lowhope@2602:fffa:fff:108a:0:16:3e86:c70e> has quit IRC (Ping timeout: 256 seconds)
1802022-04-13T18:51:44 *** jarthur_ is now known as jarthur
1812022-04-13T19:07:36 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
1822022-04-13T19:08:55 *** An0rak <An0rak!An0rak@user/an0rak> has joined #bitcoin-core-dev
1832022-04-13T19:16:59 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
1842022-04-13T19:17:36 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
1852022-04-13T19:36:46 *** lowhope <lowhope!~lowhope@cow9.org> has joined #bitcoin-core-dev
1862022-04-13T19:47:16 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
1872022-04-13T19:47:31 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
1882022-04-13T19:50:21 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1892022-04-13T19:50:21 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f60a63cc5f16...3bbc46ddafb6
1902022-04-13T19:50:21 <bitcoin-git> bitcoin/master 0cea7b1 /dev/fd0: print `(none)` if no warnings in -getinfo
1912022-04-13T19:50:21 <bitcoin-git> bitcoin/master 3bbc46d laanwj: Merge bitcoin/bitcoin#24632: add `(none)` in -getinfo `Warnings:` if no wa...
1922022-04-13T19:50:21 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1932022-04-13T19:50:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
1942022-04-13T19:50:37 <bitcoin-git> [bitcoin] laanwj merged pull request #24632: add `(none)` in -getinfo `Warnings:` if no warning returned (master...getinfo-warning) https://github.com/bitcoin/bitcoin/pull/24632
1952022-04-13T19:50:37 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
1962022-04-13T19:51:08 <sipa> laanwj: I think you left https://github.com/bitcoin/bitcoin/pull/24846#issuecomment-1098420896 in the wrong PR
1972022-04-13T19:51:32 <sipa> Ah, it's gone.
1982022-04-13T19:53:51 <laanwj> sipa: hehe i noticed, it was for #24632
1992022-04-13T19:53:53 <gribble> https://github.com/bitcoin/bitcoin/issues/24632 | add `(none)` in -getinfo `Warnings:` if no warning returned by 1440000bytes · Pull Request #24632 · bitcoin/bitcoin · GitHub
2002022-04-13T19:56:51 <laanwj> it's good that we have the commit id in the ACK message or it could be a dangerous mistake :<
2012022-04-13T20:03:59 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Ping timeout: 256 seconds)
2022022-04-13T20:04:00 *** Guest60 <Guest60!~Guest60@2001:861:3204:e660:1425:6fd1:eb83:c179> has joined #bitcoin-core-dev
2032022-04-13T20:25:40 *** Saloframes <Saloframes!~Saloframe@user/Saloframes> has joined #bitcoin-core-dev
2042022-04-13T20:26:53 *** Guest60 <Guest60!~Guest60@2001:861:3204:e660:1425:6fd1:eb83:c179> has quit IRC (Quit: Client closed)
2052022-04-13T20:28:28 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2062022-04-13T20:28:28 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3bbc46ddafb6...9b7eb584ade2
2072022-04-13T20:28:28 <bitcoin-git> bitcoin/master e644591 Hennadii Stepanov: build, refactor: Drop useless `call` Make function
2082022-04-13T20:28:28 <bitcoin-git> bitcoin/master 9b7eb58 laanwj: Merge bitcoin/bitcoin#24285: build, refactor: Drop useless `call` Make fun...
2092022-04-13T20:28:30 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2102022-04-13T20:28:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2112022-04-13T20:28:47 <bitcoin-git> [bitcoin] laanwj merged pull request #24285: build, refactor: Drop useless `call` Make function (master...220207-call) https://github.com/bitcoin/bitcoin/pull/24285
2122022-04-13T20:28:47 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2132022-04-13T20:45:44 <laanwj> re: #24559 how does a functional test explicitly request a bdb wallet?
2142022-04-13T20:45:45 <gribble> https://github.com/bitcoin/bitcoin/issues/24559 | test: add test for signet miner script by theStack · Pull Request #24559 · bitcoin/bitcoin · GitHub
2152022-04-13T20:46:57 <laanwj> it would be better not to, but it makes use of importprivkey at the moment
2162022-04-13T20:47:09 *** kexkey <kexkey!~kexkey@178.249.214.27> has quit IRC (Ping timeout: 246 seconds)
2172022-04-13T20:47:57 <laanwj> maybe someone has a better idea
2182022-04-13T20:48:56 *** kexkey <kexkey!~kexkey@178.249.214.10> has joined #bitcoin-core-dev
2192022-04-13T20:53:12 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9> has quit IRC (Remote host closed the connection)
2202022-04-13T20:58:23 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:64b8:125d:e5cc:33b9> has joined #bitcoin-core-dev
2212022-04-13T21:00:12 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2222022-04-13T21:00:13 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9b7eb584ade2...decde9bba6f9
2232022-04-13T21:00:13 <bitcoin-git> bitcoin/master 1633f5e Hennadii Stepanov: util, refactor: Add UNIQUE_NAME helper macro
2242022-04-13T21:00:13 <bitcoin-git> bitcoin/master decde9b laanwj: Merge bitcoin/bitcoin#24355: util, refactor: Add UNIQUE_NAME helper macro
2252022-04-13T21:00:13 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2262022-04-13T21:00:28 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2272022-04-13T21:00:29 <bitcoin-git> [bitcoin] laanwj merged pull request #24355: util, refactor: Add UNIQUE_NAME helper macro (master...220216-unique) https://github.com/bitcoin/bitcoin/pull/24355
2282022-04-13T21:00:29 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2292022-04-13T21:05:12 *** hashfuncb3b <hashfuncb3b!~user@2601:5c0:c280:7090:fd34:28ad:6238:526d> has joined #bitcoin-core-dev
2302022-04-13T21:07:56 *** geyaeb <geyaeb!~geyaeb@gateway/tor-sasl/geyaeb> has quit IRC (Ping timeout: 240 seconds)
2312022-04-13T21:09:15 *** geyaeb <geyaeb!~geyaeb@gateway/tor-sasl/geyaeb> has joined #bitcoin-core-dev
2322022-04-13T21:11:37 <theStack> laanwj: i just noticed that our functional test framework maps `importprivkey` to `importdescriptors` for descriptor wallets (class RPCOverloadWrapper)
2332022-04-13T21:12:05 <theStack> so maybe my assumption that it only works for legacy wallets is just wrong... i will try in a bit
2342022-04-13T21:31:24 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has joined #bitcoin-core-dev
2352022-04-13T21:31:25 <bitcoin-git> [bitcoin] hebasto opened pull request #24847: ci: Bump vcpkg to the latest version `2022.04.12` (master...220413-vcpkg) https://github.com/bitcoin/bitcoin/pull/24847
2362022-04-13T21:31:25 *** bitcoin-git <bitcoin-git!~bitcoin-g@x0f.org> has left #bitcoin-core-dev
2372022-04-13T21:31:54 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 250 seconds)
2382022-04-13T21:33:52 <laanwj> theStack: that would explain things
2392022-04-13T21:34:40 <laanwj> i mean after all it's passing, it doesn't explicitly request a bdb wallet, and descriptor wallets are the default nowadays?
2402022-04-13T21:36:02 <laanwj> this really confused me, but yes, that it maps the method could well be the explanation
2412022-04-13T21:36:10 <theStack> right now it does explicitly request bdb, there is a call to "self.skip_if_no_bdb()"
2422022-04-13T21:36:20 <theStack> would be nice if it works with both legacy and descriptor wallets though
2432022-04-13T21:38:36 <theStack> oh wait, skip_if_no_bdb doesn't mean that a run with descriptor wallets is prevented right... hm
2442022-04-13T21:40:07 <theStack> (locally calling the test with --descriptors fails for me, so i'm even more confused :D)
2452022-04-13T21:40:27 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
2462022-04-13T21:42:40 <laanwj> skip_if_no_bdb means 'skip if bitcoind is not built with bdb', it does not do amnything else
2472022-04-13T21:43:09 *** shesek <shesek!~shesek@user/shesek> has joined #bitcoin-core-dev
2482022-04-13T21:45:26 <laanwj> that's very strange as --descriptors defaults to true
2492022-04-13T21:49:07 <laanwj> you're right though, it does
2502022-04-13T21:49:49 <laanwj> can't we make this test work without wallet?
2512022-04-13T21:51:49 <laanwj> it doesn't ever check the wallet, what does it use it for
2522022-04-13T21:51:58 <theStack> looks like the default used is BDB, ("# Prefer BDB unless it isn't available"), see test_framework.py:216 oO probably this should be changed to default to descriptor wallets
2532022-04-13T21:53:13 <theStack> the signet mining script calls the `walletprocesspsbt` RPC, that's why a wallet is needed on the node
2542022-04-13T21:53:16 <laanwj> that's super surprising after first defaulting the other way around
2552022-04-13T21:53:36 <laanwj> ohh it's internal to the script, that makes sense
2562022-04-13T21:56:08 <theStack> and that seems also to be the call that fails if a descriptor wallet is used, i'm trying to find out why...
2572022-04-13T22:00:12 <laanwj> but the answer to my initial question "how does a functional test explicitly request a bdb wallet?" seems to be "it doesn't", it's decided from outside, all it can do is skip the test if self.options.descriptors==True
2582022-04-13T22:03:52 *** ExEric3 <ExEric3!~exeric3@mail.miners-zone.net> has quit IRC (Read error: Connection reset by peer)
2592022-04-13T22:04:14 *** ExEric3 <ExEric3!~exeric3@mail.miners-zone.net> has joined #bitcoin-core-dev
2602022-04-13T22:04:33 <theStack> yes, i agree
2612022-04-13T22:05:08 <theStack> interesting that the CI didn't fail, i thought we have a target that only has descriptor wallet support but not legacy wallet (didn't check though)
2622022-04-13T22:05:40 <theStack> ah, but then the test is skipped due to bdb missing
2632022-04-13T22:05:42 *** An0rak <An0rak!An0rak@user/an0rak> has quit IRC (Ping timeout: 250 seconds)
2642022-04-13T22:15:32 <laanwj> yes, if bdb is available it will apparently run with that, if bdb is missing it skips due to skip_if_no_bdb
2652022-04-13T22:16:55 *** shesek <shesek!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
2662022-04-13T22:17:19 *** shesek <shesek!~shesek@user/shesek> has joined #bitcoin-core-dev
2672022-04-13T22:19:37 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 248 seconds)
2682022-04-13T22:23:23 <theStack> so, it seems that the problem is that the descriptor wallet can't sign the 1-of-1 multisig script
2692022-04-13T22:23:41 <theStack> if i change the signetchallenge to a p2wpkh script, it works with both legacy and descriptor wallet
2702022-04-13T22:24:03 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
2712022-04-13T22:24:14 <theStack> (1-of-1 multisig doesn't make sense of course, but for some reason i wrongly assumed that signet requests a multisig challenge)
2722022-04-13T22:29:24 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
2732022-04-13T22:35:10 *** hashfuncb3b <hashfuncb3b!~user@2601:5c0:c280:7090:fd34:28ad:6238:526d> has quit IRC (Ping timeout: 250 seconds)
2742022-04-13T22:41:24 *** shesek <shesek!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
2752022-04-13T22:41:49 *** shesek <shesek!~shesek@user/shesek> has joined #bitcoin-core-dev
2762022-04-13T22:49:34 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹÑа!)
2772022-04-13T22:57:25 *** shesek <shesek!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
2782022-04-13T22:57:49 *** shesek <shesek!~shesek@user/shesek> has joined #bitcoin-core-dev
2792022-04-13T23:03:21 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 248 seconds)
2802022-04-13T23:16:25 *** shesek <shesek!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
2812022-04-13T23:16:49 *** shesek <shesek!~shesek@user/shesek> has joined #bitcoin-core-dev
2822022-04-13T23:25:32 <laanwj> 1-of-1 multisig heh
2832022-04-13T23:26:55 *** shesek <shesek!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
2842022-04-13T23:27:19 *** shesek <shesek!~shesek@user/shesek> has joined #bitcoin-core-dev
2852022-04-13T23:27:51 <sipa> Trivia: is 0-of-0 OP_CHECKMULTISIG-based multisig allowed?
2862022-04-13T23:34:50 *** shesek_ <shesek_!~shesek@user/shesek> has joined #bitcoin-core-dev
2872022-04-13T23:35:41 <theStack> i would have guessed no, but looking at the code it seems like it is allowed by consensus rules, but we don't treat it as standard?
2882022-04-13T23:36:15 *** shesek <shesek!~shesek@user/shesek> has quit IRC (Remote host closed the connection)
2892022-04-13T23:38:16 <theStack> (if that is true, i wonder how many 0-of-0 multisig outputs can be found on the main chain :D)