12022-05-05T01:07:48 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751> has quit IRC (Remote host closed the connection)
22022-05-05T01:12:58 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751> has joined #bitcoin-core-dev
32022-05-05T01:17:25 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751> has quit IRC (Ping timeout: 256 seconds)
42022-05-05T01:19:08 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
52022-05-05T01:24:00 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 276 seconds)
62022-05-05T01:24:40 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751> has joined #bitcoin-core-dev
72022-05-05T01:27:05 *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Remote host closed the connection)
82022-05-05T01:27:45 *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
92022-05-05T01:28:57 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751> has quit IRC (Ping timeout: 248 seconds)
102022-05-05T01:30:02 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
112022-05-05T01:35:36 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 250 seconds)
122022-05-05T01:40:46 *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Remote host closed the connection)
132022-05-05T01:41:34 *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
142022-05-05T01:44:24 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751> has joined #bitcoin-core-dev
152022-05-05T02:00:00 *** upekkha <upekkha!~Advanced@2a01:4f8:1c0c:49df::1> has quit IRC (Quit: upekkha)
162022-05-05T02:00:36 *** upekkha <upekkha!~Advanced@2a01:4f8:1c0c:49df::1> has joined #bitcoin-core-dev
172022-05-05T02:11:18 *** metallicc <metallicc!~metallicc@c-73-217-34-231.hsd1.co.comcast.net> has quit IRC (Remote host closed the connection)
182022-05-05T02:15:32 *** SpellChecker_ <SpellChecker_!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
192022-05-05T02:15:53 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
202022-05-05T02:28:04 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
212022-05-05T02:28:36 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
222022-05-05T02:45:57 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751> has quit IRC (Ping timeout: 252 seconds)
232022-05-05T02:47:28 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751> has joined #bitcoin-core-dev
242022-05-05T02:48:44 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Quit: jarthur)
252022-05-05T02:51:34 *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Ping timeout: 240 seconds)
262022-05-05T02:56:13 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has joined #bitcoin-core-dev
272022-05-05T03:02:34 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
282022-05-05T03:03:17 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
292022-05-05T03:13:58 *** hashfunc65d <hashfunc65d!~user@2601:5c0:c280:7090:7c25:cf68:625f:614f> has quit IRC (Ping timeout: 250 seconds)
302022-05-05T03:17:34 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Ping timeout: 240 seconds)
312022-05-05T03:21:29 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
322022-05-05T03:29:55 *** kobie <kobie!~kobie@2601:285:0:e5c0:b9d9:22aa:d271:35e7> has quit IRC (Remote host closed the connection)
332022-05-05T03:42:55 *** a1ph4byte20 <a1ph4byte20!~a1ph4byte@2600:1700:22f0:a7c0:98c8:7ecc:94f9:578a> has joined #bitcoin-core-dev
342022-05-05T03:51:10 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751> has quit IRC (Ping timeout: 260 seconds)
352022-05-05T03:52:32 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751> has joined #bitcoin-core-dev
362022-05-05T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
372022-05-05T04:01:32 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
382022-05-05T04:08:40 *** PaperSwordAlt <PaperSwordAlt!~PaperSwor@50.126.96.22> has quit IRC (Read error: Connection reset by peer)
392022-05-05T04:10:25 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has quit IRC (Ping timeout: 260 seconds)
402022-05-05T04:20:04 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
412022-05-05T04:34:52 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has joined #bitcoin-core-dev
422022-05-05T04:39:00 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has quit IRC (Ping timeout: 246 seconds)
432022-05-05T04:40:38 *** mikehu44_ <mikehu44_!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
442022-05-05T04:42:15 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 276 seconds)
452022-05-05T04:57:51 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:6038:a7a0:3eb4:8751> has quit IRC (Ping timeout: 256 seconds)
462022-05-05T04:59:42 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
472022-05-05T05:06:01 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:30f1:b53f:1710:51d7> has joined #bitcoin-core-dev
482022-05-05T05:10:28 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:30f1:b53f:1710:51d7> has quit IRC (Ping timeout: 248 seconds)
492022-05-05T05:17:56 *** a1ph4byte20 <a1ph4byte20!~a1ph4byte@2600:1700:22f0:a7c0:98c8:7ecc:94f9:578a> has quit IRC (Quit: Client closed)
502022-05-05T05:43:21 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:30f1:b53f:1710:51d7> has joined #bitcoin-core-dev
512022-05-05T06:04:48 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 276 seconds)
522022-05-05T06:08:30 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
532022-05-05T06:19:40 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
542022-05-05T06:40:14 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d4475ea7ae70...0d080a183bfc
552022-05-05T06:40:14 <bitcoin-git> bitcoin/master 2b09593 Shashwat: scripted-diff: Rename message command to message type
562022-05-05T06:40:14 <bitcoin-git> bitcoin/master e71c51b Shashwat: refactor: rename command -> message type in comments in the src/net* files
572022-05-05T06:40:14 <bitcoin-git> bitcoin/master 0d080a1 MacroFake: Merge bitcoin/bitcoin#24141: Rename message_command variables in src/net* ...
582022-05-05T06:40:21 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24141: Rename message_command variables in src/net* and src/rpc/net.cpp (master...220124-message) https://github.com/bitcoin/bitcoin/pull/24141
592022-05-05T06:46:48 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:30f1:b53f:1710:51d7> has quit IRC (Ping timeout: 260 seconds)
602022-05-05T06:47:01 *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has joined #bitcoin-core-dev
612022-05-05T07:05:33 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has joined #bitcoin-core-dev
622022-05-05T07:11:15 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has quit IRC (Ping timeout: 260 seconds)
632022-05-05T07:20:18 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:30f1:b53f:1710:51d7> has joined #bitcoin-core-dev
642022-05-05T07:21:53 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 256 seconds)
652022-05-05T07:22:13 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
662022-05-05T07:23:45 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has joined #bitcoin-core-dev
672022-05-05T07:26:52 *** djb27__ <djb27__!~djb27@user/djb27> has joined #bitcoin-core-dev
682022-05-05T07:39:34 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
692022-05-05T07:51:28 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
702022-05-05T08:02:18 *** jetpack <jetpack!~jetpack@2605:2700:1:100e:ddb4:196e:c17a:3b92> has quit IRC (Quit: ZNC 1.7.2+deb3 - https://znc.in)
712022-05-05T08:04:40 *** jetpack <jetpack!~jetpack@2605:2700:1:100e:ddb4:196e:c17a:3b92> has joined #bitcoin-core-dev
722022-05-05T08:21:38 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:30f1:b53f:1710:51d7> has quit IRC (Ping timeout: 250 seconds)
732022-05-05T08:29:09 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has quit IRC (Ping timeout: 252 seconds)
742022-05-05T08:29:24 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
752022-05-05T08:30:58 *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
762022-05-05T08:36:18 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:30f1:b53f:1710:51d7> has joined #bitcoin-core-dev
772022-05-05T08:37:14 <bitcoin-git> [bitcoin] fanquake pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/0d080a183bfc...1ad5d5088d69
782022-05-05T08:37:14 <bitcoin-git> bitcoin/master a4fd440 Hennadii Stepanov: build: Pass missed `strip` tool via `config.site`
792022-05-05T08:37:14 <bitcoin-git> bitcoin/master 80cd993 Hennadii Stepanov: scripted-diff: Rename INSTALLNAMETOOL -> INSTALL_NAME_TOOL
802022-05-05T08:37:14 <bitcoin-git> bitcoin/master f87594d Hennadii Stepanov: build: No need to provide defaults for darwin-specific tools
812022-05-05T08:37:19 <bitcoin-git> [bitcoin] fanquake merged pull request #24866: build: No longer need to hack the `PATH` variable in `config.site` (master...220415-tools) https://github.com/bitcoin/bitcoin/pull/24866
822022-05-05T08:39:27 *** Guyver2_ <Guyver2_!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
832022-05-05T08:41:13 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Ping timeout: 256 seconds)
842022-05-05T08:45:49 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has joined #bitcoin-core-dev
852022-05-05T08:53:08 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
862022-05-05T09:02:04 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
872022-05-05T09:03:54 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
882022-05-05T09:14:38 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
892022-05-05T09:14:59 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
902022-05-05T09:41:24 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:30f1:b53f:1710:51d7> has quit IRC (Ping timeout: 240 seconds)
912022-05-05T09:41:34 *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Ping timeout: 240 seconds)
922022-05-05T09:47:05 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has quit IRC (Ping timeout: 248 seconds)
932022-05-05T09:56:44 *** belcher <belcher!~belcher@user/belcher> has quit IRC (Ping timeout: 272 seconds)
942022-05-05T09:58:34 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
952022-05-05T10:01:47 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has joined #bitcoin-core-dev
962022-05-05T10:06:53 *** ZeroMaster <ZeroMaster!~webirc@90-154-206-39.ip.btc-net.bg> has quit IRC (Ping timeout: 260 seconds)
972022-05-05T10:11:34 *** belcher <belcher!~belcher@user/belcher> has joined #bitcoin-core-dev
982022-05-05T10:16:32 *** ZeroMaster <ZeroMaster!~webirc@90-154-206-39.ip.btc-net.bg> has joined #bitcoin-core-dev
992022-05-05T10:17:06 *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has quit IRC (Ping timeout: 246 seconds)
1002022-05-05T10:21:59 *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has joined #bitcoin-core-dev
1012022-05-05T10:26:03 <bitcoin-git> [bitcoin] jonatack opened pull request #25067: validation, refactor: make MainSignalsInstance() a class, move to h (master...make-MainSignalsInstance-a-class-and-move-to-header-file) https://github.com/bitcoin/bitcoin/pull/25067
1022022-05-05T10:56:21 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has joined #bitcoin-core-dev
1032022-05-05T11:03:20 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has quit IRC (Ping timeout: 248 seconds)
1042022-05-05T11:04:52 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has joined #bitcoin-core-dev
1052022-05-05T11:09:02 *** Zenton <Zenton!~user@user/zenton> has joined #bitcoin-core-dev
1062022-05-05T11:09:12 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has quit IRC (Ping timeout: 252 seconds)
1072022-05-05T11:09:23 *** ZeroMaster <ZeroMaster!~webirc@90-154-206-39.ip.btc-net.bg> has quit IRC (Remote host closed the connection)
1082022-05-05T11:10:56 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has joined #bitcoin-core-dev
1092022-05-05T11:27:45 *** remyers[m] <remyers[m]!~richshind@2001:470:69fc:105::1:6f78> has joined #bitcoin-core-dev
1102022-05-05T11:49:49 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has quit IRC (Ping timeout: 256 seconds)
1112022-05-05T12:08:30 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
1122022-05-05T12:09:21 *** Guyver2__ <Guyver2__!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
1132022-05-05T12:11:55 *** Guyver2_ <Guyver2_!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Ping timeout: 256 seconds)
1142022-05-05T12:15:20 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has quit IRC (Ping timeout: 248 seconds)
1152022-05-05T12:16:17 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
1162022-05-05T12:17:45 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:30f1:b53f:1710:51d7> has joined #bitcoin-core-dev
1172022-05-05T12:23:00 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:30f1:b53f:1710:51d7> has quit IRC (Ping timeout: 240 seconds)
1182022-05-05T12:26:51 *** Guyver2__ <Guyver2__!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev
1192022-05-05T12:29:14 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has joined #bitcoin-core-dev
1202022-05-05T12:37:12 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has joined #bitcoin-core-dev
1212022-05-05T12:38:23 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
1222022-05-05T13:04:26 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC ()
1232022-05-05T13:09:46 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Quit: bye)
1242022-05-05T13:10:35 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
1252022-05-05T13:38:37 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has quit IRC (Ping timeout: 256 seconds)
1262022-05-05T13:40:03 *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
1272022-05-05T13:59:27 <dongcarl> sipa: https://i.kym-cdn.com/entries/icons/original/000/013/306/2dd.jpg
1282022-05-05T14:07:30 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1cfd:b332:6287:5945> has joined #bitcoin-core-dev
1292022-05-05T14:12:04 *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Ping timeout: 240 seconds)
1302022-05-05T14:16:32 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1cfd:b332:6287:5945> has quit IRC (Ping timeout: 250 seconds)
1312022-05-05T14:19:10 *** antonleviathan <antonleviathan!~antonlevi@199.68.125.214> has joined #bitcoin-core-dev
1322022-05-05T14:25:42 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1ad5d5088d69...7cc1860b12a5
1332022-05-05T14:25:42 <bitcoin-git> bitcoin/master a0e2a31 Hennadii Stepanov: build: Drop redundant checks for ranlib and strip tools
1342022-05-05T14:25:42 <bitcoin-git> bitcoin/master 7cc1860 fanquake: Merge bitcoin/bitcoin#24566: build: Drop redundant checks for ranlib and s...
1352022-05-05T14:25:48 <bitcoin-git> [bitcoin] fanquake merged pull request #24566: build: Drop redundant checks for ranlib and strip tools (master...220314-conf) https://github.com/bitcoin/bitcoin/pull/24566
1362022-05-05T14:30:28 *** antonleviathan <antonleviathan!~antonlevi@199.68.125.214> has quit IRC (Quit: Client closed)
1372022-05-05T14:30:35 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1cfd:b332:6287:5945> has joined #bitcoin-core-dev
1382022-05-05T14:30:40 *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
1392022-05-05T14:35:20 <instagibbs> sipa, I was too afraid to ask
1402022-05-05T14:37:43 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #25068: Wrap boost::replace_all (master...2205-util-string-ð) https://github.com/bitcoin/bitcoin/pull/25068
1412022-05-05T14:40:37 <achow101> Can someone block uvhw on github?
1422022-05-05T14:41:08 *** mikehu44_ <mikehu44_!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 248 seconds)
1432022-05-05T14:43:57 <sipa> Done.
1442022-05-05T14:48:32 <fanquake> I think I did earlier this morning
1452022-05-05T14:48:40 <fanquake> cleaned up all the spam PRs and other crap
1462022-05-05T14:49:01 <achow101> fanquake: I noticed some wiki vandalism from that user
1472022-05-05T14:49:04 <sipa> They were already blocked on the bitcoin org; I also blocked them from the bitcoin-core org.
1482022-05-05T14:49:24 <achow101> bips wiki specifically
1492022-05-05T14:50:07 <fanquake> I haven't seen anything in the wiki other than spam as of late. Mostly randoms/spammers creating pages. It'd be good to try and lock that down in some way?
1502022-05-05T14:50:32 <fanquake> *bips wiki
1512022-05-05T14:50:43 *** Guest42 <Guest42!~Guest42@154.70.62.111> has joined #bitcoin-core-dev
1522022-05-05T14:51:46 <lightlike> could also cleanup after Miminlaili (24410)
1532022-05-05T14:55:57 *** xyephy <xyephy!~xyephy@154.70.62.111> has joined #bitcoin-core-dev
1542022-05-05T14:58:43 *** Guest42 <Guest42!~Guest42@154.70.62.111> has quit IRC (Quit: Ping timeout (120 seconds))
1552022-05-05T15:01:14 *** xyephy <xyephy!~xyephy@154.70.62.111> has quit IRC (Remote host closed the connection)
1562022-05-05T15:04:57 *** xyephy <xyephy!~xyephy@154.70.62.111> has joined #bitcoin-core-dev
1572022-05-05T15:07:11 *** xyephy <xyephy!~xyephy@154.70.62.111> has quit IRC (Client Quit)
1582022-05-05T15:08:57 *** xyephy <xyephy!~xyephy@154.70.62.111> has joined #bitcoin-core-dev
1592022-05-05T15:10:07 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7cc1860b12a5...c367736f85ac
1602022-05-05T15:10:08 <bitcoin-git> bitcoin/master bd6ceb4 whiteh0rse: test: port 'lint-shell.sh' to python
1612022-05-05T15:10:08 <bitcoin-git> bitcoin/master c367736 MacroFake: Merge bitcoin/bitcoin#24840: test: port 'lint-shell.sh' to python
1622022-05-05T15:10:12 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24840: test: port 'lint-shell.sh' to python (master...24783-port-lint-shell-to-python) https://github.com/bitcoin/bitcoin/pull/24840
1632022-05-05T15:11:36 <fanquake> lightlike: is that the right PR number?
1642022-05-05T15:11:47 <sipa> #24410
1652022-05-05T15:11:49 <gribble> https://github.com/bitcoin/bitcoin/issues/24410 | [kernel 2a/n] Split hashing/index `GetUTXOStats` codepaths, decouple from `coinstatsindex` by dongcarl · Pull Request #24410 · bitcoin/bitcoin · GitHub
1662022-05-05T15:11:53 <fanquake> oh right I see
1672022-05-05T15:12:02 <fanquake> I have blocked them, and minimized the comments
1682022-05-05T15:12:10 <fanquake> but we can't delete reviews unfortunately
1692022-05-05T15:15:40 *** baldur <baldur!~baldur@pool-74-108-229-157.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
1702022-05-05T15:20:20 *** xyephy <xyephy!~xyephy@154.70.62.111> has quit IRC (Remote host closed the connection)
1712022-05-05T15:23:07 *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has quit IRC (Ping timeout: 240 seconds)
1722022-05-05T15:25:12 *** xyephy <xyephy!~xyephy@154.70.62.111> has joined #bitcoin-core-dev
1732022-05-05T15:25:40 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
1742022-05-05T15:30:32 <bitcoin-git> [bitcoin] hunglun opened pull request #25069: test: Add a new unit test for chain.cpp (master...master) https://github.com/bitcoin/bitcoin/pull/25069
1752022-05-05T15:33:05 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1cfd:b332:6287:5945> has quit IRC (Ping timeout: 256 seconds)
1762022-05-05T15:35:32 *** xyephy <xyephy!~xyephy@154.70.62.111> has quit IRC (Remote host closed the connection)
1772022-05-05T15:41:14 *** seejee <seejee!~seejee@pool-96-236-195-138.pitbpa.fios.verizon.net> has joined #bitcoin-core-dev
1782022-05-05T15:45:08 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c367736f85ac...e4478d312f90
1792022-05-05T15:45:08 <bitcoin-git> bitcoin/master dcad5f7 fanquake: guix: consolidate kernel headers to 5.15
1802022-05-05T15:45:09 <bitcoin-git> bitcoin/master eb02713 fanquake: doc: add minimum required kernel version to dependencies.md
1812022-05-05T15:45:09 <bitcoin-git> bitcoin/master e4478d3 fanquake: Merge bitcoin/bitcoin#25006: guix: consolidate kernel headers to 5.15, spe...
1822022-05-05T15:45:11 <bitcoin-git> [bitcoin] fanquake merged pull request #25006: guix: consolidate kernel headers to 5.15, specify 3.2.0 as minimum supported (master...specify_minimum_kernel) https://github.com/bitcoin/bitcoin/pull/25006
1832022-05-05T15:50:34 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
1842022-05-05T15:52:22 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
1852022-05-05T15:54:47 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Client Quit)
1862022-05-05T15:56:31 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
1872022-05-05T15:57:48 *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has quit IRC (Ping timeout: 240 seconds)
1882022-05-05T16:01:43 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has joined #bitcoin-core-dev
1892022-05-05T16:12:49 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
1902022-05-05T16:19:08 <fanquake> Looks like #24993 has broken the linter ?
1912022-05-05T16:19:09 <gribble> https://github.com/bitcoin/bitcoin/issues/24993 | test, contrib, refactor: use `with` when opening a file by brunoerg · Pull Request #24993 · bitcoin/bitcoin · GitHub
1922022-05-05T16:19:40 <fanquake> i.e: https://github.com/bitcoin/bitcoin/runs/6309423255
1932022-05-05T16:25:17 *** martinus <martinus!~martinus@212095005133.public.telering.at> has joined #bitcoin-core-dev
1942022-05-05T16:27:54 <bitcoin-git> [bitcoin] brunoerg opened pull request #25070: contrib: fix dirname on `verify-commits` (master...2022-05-ci-fix) https://github.com/bitcoin/bitcoin/pull/25070
1952022-05-05T16:34:10 *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Ping timeout: 260 seconds)
1962022-05-05T16:35:38 *** cotsuka <cotsuka!~cotsuka@user/cotsuka> has quit IRC (Quit: Ping timeout (120 seconds))
1972022-05-05T16:35:59 *** cotsuka <cotsuka!~cotsuka@user/cotsuka> has joined #bitcoin-core-dev
1982022-05-05T16:38:47 *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has joined #bitcoin-core-dev
1992022-05-05T16:42:03 *** gnaf <gnaf!~gnaf@163-172-58-132.rev.poneytelecom.eu> has joined #bitcoin-core-dev
2002022-05-05T16:45:38 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e4478d312f90...460450836304
2012022-05-05T16:45:38 <bitcoin-git> bitcoin/master ded915e brunoerg: contrib: fix dirname on `verify-commits`
2022022-05-05T16:45:39 <bitcoin-git> bitcoin/master 4604508 fanquake: Merge bitcoin/bitcoin#25070: contrib: fix dirname on `verify-commits`
2032022-05-05T16:45:40 <bitcoin-git> [bitcoin] fanquake merged pull request #25070: contrib: fix dirname on `verify-commits` (master...2022-05-ci-fix) https://github.com/bitcoin/bitcoin/pull/25070
2042022-05-05T16:46:06 <fanquake> thanks
2052022-05-05T16:58:49 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
2062022-05-05T16:59:56 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
2072022-05-05T17:11:03 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has quit IRC (Ping timeout: 276 seconds)
2082022-05-05T17:18:56 *** seejee <seejee!~seejee@pool-96-236-195-138.pitbpa.fios.verizon.net> has quit IRC (Ping timeout: 252 seconds)
2092022-05-05T17:30:01 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has joined #bitcoin-core-dev
2102022-05-05T17:34:17 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has quit IRC (Ping timeout: 248 seconds)
2112022-05-05T17:36:16 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1cfd:b332:6287:5945> has joined #bitcoin-core-dev
2122022-05-05T17:41:55 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1cfd:b332:6287:5945> has quit IRC (Ping timeout: 260 seconds)
2132022-05-05T17:44:06 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1cfd:b332:6287:5945> has joined #bitcoin-core-dev
2142022-05-05T17:46:33 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 248 seconds)
2152022-05-05T17:48:48 *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
2162022-05-05T17:57:49 *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
2172022-05-05T18:17:58 *** csknk <csknk!~csknk@88.87.164.26> has joined #bitcoin-core-dev
2182022-05-05T18:47:32 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1cfd:b332:6287:5945> has quit IRC (Ping timeout: 248 seconds)
2192022-05-05T18:47:40 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
2202022-05-05T18:49:10 <theStack> are there currently any alternative concepts availabe or for discussion for BIP322? i'd like to focus more on generic signing support and wonder if there's a reason why the BIP322 PR (#24058) didn't get more traction yet
2212022-05-05T18:49:13 <gribble> https://github.com/bitcoin/bitcoin/issues/24058 | BIP-322 basic support by kallewoof · Pull Request #24058 · bitcoin/bitcoin · GitHub
2222022-05-05T18:51:31 *** jonatack <jonatack!jonatack@user/jonatack> has quit IRC (Ping timeout: 256 seconds)
2232022-05-05T18:53:55 *** jonatack <jonatack!jonatack@user/jonatack> has joined #bitcoin-core-dev
2242022-05-05T19:01:17 <laanwj> #startmeeting
2252022-05-05T19:01:17 <core-meetingbot> Meeting started Thu May 5 19:01:17 2022 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
2262022-05-05T19:01:17 <core-meetingbot> Available commands: action commands idea info link nick
2272022-05-05T19:01:28 <josibake> hi
2282022-05-05T19:01:33 <glozow> hi
2292022-05-05T19:01:34 <jonatack> hi
2302022-05-05T19:01:36 <dongcarl> hi
2312022-05-05T19:01:37 <achow101> hi
2322022-05-05T19:01:53 <laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball
2332022-05-05T19:01:55 <laanwj> morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
2342022-05-05T19:02:02 <instagibbs> :wave:
2352022-05-05T19:02:24 <theStack> hi
2362022-05-05T19:02:26 <laanwj> there's been one pre-proposed meeting topic for today: package relay updates (glozow)
2372022-05-05T19:02:39 <laanwj> any last minute topics?
2382022-05-05T19:02:47 <lightlike> hi
2392022-05-05T19:02:59 <laanwj> (you can propose meeting topics with #proposedmeetingtopic <topic> during any time of the week)
2402022-05-05T19:03:42 *** jonhbit <jonhbit!~jonhbit@130.44.168.202> has joined #bitcoin-core-dev
2412022-05-05T19:03:42 <kanzure> hi
2422022-05-05T19:03:50 <kvaciral> hi
2432022-05-05T19:03:54 <MarcoFalke> #proposedmeetingtopic LIFETIMEBOUND
2442022-05-05T19:04:03 <laanwj> ack
2452022-05-05T19:04:40 <laanwj> #topic High priority for review
2462022-05-05T19:04:40 <core-meetingbot> topic: High priority for review
2472022-05-05T19:05:01 <laanwj> there's 12 blockers and 1 labaled chasing concept ACK in https://github.com/bitcoin/bitcoin/projects/8
2482022-05-05T19:05:10 <laanwj> anything to add/remove?
2492022-05-05T19:05:37 <sipa> hi
2502022-05-05T19:06:00 <ajonas> hi
2512022-05-05T19:06:41 <theStack> may i ask for #23662 to add (should be easy to review and fixes a significant slowdown of RPC calls that some users were reporting)
2522022-05-05T19:06:44 <gribble> https://github.com/bitcoin/bitcoin/issues/23662 | rpc: improve `getreceivedby{address,label}` performance by theStack · Pull Request #23662 · bitcoin/bitcoin · GitHub
2532022-05-05T19:06:56 <b10c> hi
2542022-05-05T19:08:20 <laanwj> theStack: added!
2552022-05-05T19:09:03 <theStack> thanks
2562022-05-05T19:09:43 <laanwj> anything else? anything on that list that is (almost) ready for merge?
2572022-05-05T19:11:31 <laanwj> seems not, time for next topic then
2582022-05-05T19:11:47 <laanwj> #topic Package relay updates (glozow)
2592022-05-05T19:11:47 <core-meetingbot> topic: Package relay updates (glozow)
2602022-05-05T19:11:59 <glozow> Hi! I originally planned to propose a proposal + roadmap, but I haven't had as much time to prepare for expected questions as I hoped, so I'll defer that to another week.
2612022-05-05T19:11:59 <glozow> I can give updates on what Iâm working on, but no proposal this week. So my apologies for the disappointment if anybody came specifically expecting to see a proposal.
2622022-05-05T19:12:52 <glozow> Iâve split the project into two groups: mempool logic and p2p relay stuff. Since all the mempool logic apart from package RBF is done, Iâm working on a p2p package relay BIP + implementation.
2632022-05-05T19:13:08 <laanwj> no problem, we can bring back the topic next week if you prefer that
2642022-05-05T19:13:27 <glozow> that would be lovely, thanks so much
2652022-05-05T19:13:43 <glozow> #24836 is the PR open for review if anybody wants to help out. #25038 is also open for browsing as well. Unfortunately there is a pinning attack that it doesnât fix, so I am working out what to do about it. Thatâs why itâs a draft.
2662022-05-05T19:13:45 <gribble> https://github.com/bitcoin/bitcoin/issues/24836 | add RPC (-regtest only) for testing package policy by glozow · Pull Request #24836 · bitcoin/bitcoin · GitHub
2672022-05-05T19:13:46 <gribble> https://github.com/bitcoin/bitcoin/issues/25038 | BIP125-based Package RBF by glozow · Pull Request #25038 · bitcoin/bitcoin · GitHub
2682022-05-05T19:14:08 <glozow> that's all I wanted to share for today, thanks!
2692022-05-05T19:15:22 <instagibbs> if I may glozow, which pinning are you referring to? there are so many to choose from
2702022-05-05T19:15:57 <instagibbs> or just discuss on thread, nevermind!
2712022-05-05T19:16:01 <glozow> instagibbs: yeah good question. it's Rule #3 https://usercontent.irccloud-cdn.com/file/CoG1SqvV/image.png
2722022-05-05T19:16:02 <laanwj> thanks for the quick update, i'll take a look at #24836 some time this week
2732022-05-05T19:16:03 <gribble> https://github.com/bitcoin/bitcoin/issues/3 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub
2742022-05-05T19:16:05 <gribble> https://github.com/bitcoin/bitcoin/issues/24836 | add RPC (-regtest only) for testing package policy by glozow · Pull Request #24836 · bitcoin/bitcoin · GitHub
2752022-05-05T19:16:18 <glozow> yeah we can discuss offline ð
2762022-05-05T19:16:18 <instagibbs> ok on same page :+1:
2772022-05-05T19:16:47 <laanwj> #topic LIFETIMEBOUND (MarcoFalke)
2782022-05-05T19:16:47 <core-meetingbot> topic: LIFETIMEBOUND (MarcoFalke)
2792022-05-05T19:17:08 <MarcoFalke> hi, so the attribute is used in some places
2802022-05-05T19:17:33 <MarcoFalke> Though, while it does catch some errors (temporaries), it doesn't catch most other issues
2812022-05-05T19:17:41 <MarcoFalke> (lifetime-related issues)
2822022-05-05T19:17:55 <jonatack> link for info: https://releases.llvm.org/12.0.0/tools/clang/docs/AttributeReference.html#lifetimebound
2832022-05-05T19:18:01 <MarcoFalke> And #20493
2842022-05-05T19:18:02 <gribble> https://github.com/bitcoin/bitcoin/issues/20493 | lifetimebound compile attribute · Issue #20493 · bitcoin/bitcoin · GitHub
2852022-05-05T19:18:04 <laanwj> is there anything better?
2862022-05-05T19:18:17 <sipa> I'd expect cases where temporaries are accidentally passed to be the ones that are most likely to be missed through code review.
2872022-05-05T19:18:20 <MarcoFalke> Only at run time: valgrind, msan, asan, etc
2882022-05-05T19:18:26 <laanwj> (besides switching to another programming language)
2892022-05-05T19:18:41 <laanwj> so i'd say this is the "Better than nothing" category then
2902022-05-05T19:18:45 <laanwj> combine it with run-time approaches
2912022-05-05T19:18:52 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
2922022-05-05T19:18:57 <sipa> And even if the analysis isn't all that strong, they're still useful as developer documentation.
2932022-05-05T19:19:28 <laanwj> and don't add functions that are clearly dangerous like return string views *ducks*
2942022-05-05T19:19:45 <MarcoFalke> I think it can be applied pretty broadly, basically everywhere where a pointer/reference is passed and the pointer/reference lifes on after the functions returns
2952022-05-05T19:20:21 <laanwj> yes
2962022-05-05T19:20:35 <MarcoFalke> So I think if we start applying them, the code will become a bit more verbose
2972022-05-05T19:20:48 <MarcoFalke> Just wanted to see if anyone would want to object that
2982022-05-05T19:20:55 *** csknk <csknk!~csknk@88.87.164.26> has quit IRC (Quit: leaving)
2992022-05-05T19:21:11 <sipa> Just in function/constructor declarations, rights?
3002022-05-05T19:21:11 <laanwj> it depends on how much more verbose
3012022-05-05T19:21:35 <jonatack> I don't think it's too bad, see https://github.com/bitcoin/bitcoin/pull/25060/files for an example
3022022-05-05T19:22:06 <MarcoFalke> #20493 has a list, but it is not complete
3032022-05-05T19:22:07 <gribble> https://github.com/bitcoin/bitcoin/issues/20493 | lifetimebound compile attribute · Issue #20493 · bitcoin/bitcoin · GitHub
3042022-05-05T19:22:07 <laanwj> i mean there's clearly some degree of verbosity where it just becomes silly make-work and isn't worth it compared that what is gained
3052022-05-05T19:22:15 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1cfd:b332:6287:5945> has joined #bitcoin-core-dev
3062022-05-05T19:22:54 <MarcoFalke> I think it is missing any stuff that was recently added at least: m_params references, and potentially more CBlockIndex passing
3072022-05-05T19:23:33 <laanwj> jonatack: that doesn't look bad
3082022-05-05T19:23:39 <laanwj> sipa: seems so then?
3092022-05-05T19:24:16 <MarcoFalke> Right, it only attaches to functions or function parameters
3102022-05-05T19:24:37 <laanwj> also important is how difficult it is to maintain, e.g. can we expect a lot of false positives when people compile with a different compiler
3112022-05-05T19:24:40 <sipa> Yeah, I don't mind adding them. I don't think we go start hunting down every last place where such an attribute could be added, but there seem to be very little downsides to adding them where appropriate.
3122022-05-05T19:25:02 <laanwj> (remembers -Wshadow)
3132022-05-05T19:25:02 <sipa> it preprocesses to nothing on non-clang compilers
3142022-05-05T19:25:43 <laanwj> right
3152022-05-05T19:25:58 <MarcoFalke> When I added it in #22278 for CScript I actually ran into the bug before, but for other places, I am less sure if it will be equally useful
3162022-05-05T19:26:00 <gribble> https://github.com/bitcoin/bitcoin/issues/22278 | Add LIFETIMEBOUND to CScript where needed by MarcoFalke · Pull Request #22278 · bitcoin/bitcoin · GitHub
3172022-05-05T19:26:02 <laanwj> well i think it's fine to add them then
3182022-05-05T19:26:33 <sipa> which bug?
3192022-05-05T19:26:53 <MarcoFalke> I did some odd CScript{ stuff } in tests and broke valgrind
3202022-05-05T19:26:59 <josibake> if it's encouraged to add them where appropriate, can we add something to the developer docs? perhaps a brief explanation of why to use them?
3212022-05-05T19:27:01 <sipa> hmm
3222022-05-05T19:27:32 <josibake> s/them/it
3232022-05-05T19:27:54 <MarcoFalke> Probably was []{return CScript{} << 1;}()
3242022-05-05T19:29:18 <MarcoFalke> Ah no, []-> decltype(auto) {return CScript{} << 1;}()
3252022-05-05T19:29:23 <MarcoFalke> Pretty obscure
3262022-05-05T19:29:41 <sipa> Is that returning a `CScript` or a (const) `CScript&`?
3272022-05-05T19:30:17 <sipa> (the latter would actually be a lifetime issue)
3282022-05-05T19:30:18 <MarcoFalke> operator<< returns &
3292022-05-05T19:30:30 <MarcoFalke> sipa: Yeah, that was the reason I added LIFETIMEBOUND
3302022-05-05T19:30:41 <sipa> Yes, but doesn't `-> decltype(auto)` return a non-reference?
3312022-05-05T19:30:57 <MarcoFalke> no, IIRC
3322022-05-05T19:31:17 <sipa> ok
3332022-05-05T19:31:29 <sipa> Sounds like the lifetimebound is doing its job then.
3342022-05-05T19:32:06 <jonatack> josibake: good point. i'll propose a doc along with another (non-contentious) developer notes improvement i have in mind
3352022-05-05T19:32:28 <MarcoFalke> https://github.com/bitcoin/bitcoin/pull/20495#issuecomment-734236027
3362022-05-05T19:33:55 <sipa> decltype(auto) apparently can indeed deduce a reference type
3372022-05-05T19:34:36 <laanwj> that's quite a footgun in itself
3382022-05-05T19:36:22 <josibake> jonatack: ty!
3392022-05-05T19:36:59 <laanwj> any other topics?
3402022-05-05T19:38:15 <laanwj> seems like not; time to close the meeting, thanks for attending everyone
3412022-05-05T19:38:19 <laanwj> #endmeeting
3422022-05-05T19:38:19 <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
3432022-05-05T19:38:19 <core-meetingbot> Meeting ended Thu May 5 19:38:19 2022 UTC.
3442022-05-05T19:38:19 <core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2022/bitcoin-core-dev.2022-05-05-19.01.moin.txt
3452022-05-05T19:38:55 <jonatack> MarcoFalke: i've misplaced the url to your online test coverage report by codebase area
3462022-05-05T19:39:18 <jonatack> can you please remind me of the link?
3472022-05-05T19:39:24 <MarcoFalke> https://marcofalke.github.io/btc_cov/total.coverage/index.html
3482022-05-05T19:39:28 <jonatack> ty!
3492022-05-05T19:39:36 <MarcoFalke> https://marcofalke.github.io/btc_cov/fuzz.coverage/index.html
3502022-05-05T19:39:51 <MarcoFalke> heh, index: https://marcofalke.github.io/btc_cov/
3512022-05-05T19:40:15 <jonatack> purrfect
3522022-05-05T19:43:04 *** evanlinjin <evanlinjin!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Ping timeout: 240 seconds)
3532022-05-05T19:50:24 *** djb27__ <djb27__!~djb27@user/djb27> has quit IRC (Ping timeout: 246 seconds)
3542022-05-05T19:51:11 *** djb27__ <djb27__!~djb27@user/djb27> has joined #bitcoin-core-dev
3552022-05-05T19:54:19 *** roconnor <roconnor!~roconnor@coq/roconnor> has quit IRC (Ping timeout: 240 seconds)
3562022-05-05T20:04:36 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Ping timeout: 276 seconds)
3572022-05-05T20:08:25 <bitcoin-git> [bitcoin] Crypt-iQ closed pull request #24901: mempool: reduce lookups, insertions to cache in UpdateForDescendants (master...mempool_desc_patch) https://github.com/bitcoin/bitcoin/pull/24901
3582022-05-05T20:08:32 *** jonhbit <jonhbit!~jonhbit@130.44.168.202> has quit IRC (Quit: Client closed)
3592022-05-05T20:25:48 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1cfd:b332:6287:5945> has quit IRC (Remote host closed the connection)
3602022-05-05T20:32:40 *** xyephy <xyephy!~xyephy@154.70.62.111> has joined #bitcoin-core-dev
3612022-05-05T20:34:12 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1cfd:b332:6287:5945> has joined #bitcoin-core-dev
3622022-05-05T20:36:36 *** xyephy <xyephy!~xyephy@154.70.62.111> has quit IRC (Ping timeout: 240 seconds)
3632022-05-05T20:38:36 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1cfd:b332:6287:5945> has quit IRC (Ping timeout: 240 seconds)
3642022-05-05T20:46:16 *** Victorsueca <Victorsueca!~Victorsue@user/victorsueca> has quit IRC (Ping timeout: 248 seconds)
3652022-05-05T20:51:18 *** Victorsueca <Victorsueca!~Victorsue@user/victorsueca> has joined #bitcoin-core-dev
3662022-05-05T20:52:14 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
3672022-05-05T21:07:46 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:79ba:e0a8:d054:36dc> has joined #bitcoin-core-dev
3682022-05-05T21:09:04 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:79ba:e0a8:d054:36dc> has quit IRC (Remote host closed the connection)
3692022-05-05T21:11:14 *** Earnestly <Earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 272 seconds)
3702022-05-05T21:12:28 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC ()
3712022-05-05T21:17:52 *** utzig <utzig!d5d7f726e3@2604:bf00:561:2000::71> has joined #bitcoin-core-dev
3722022-05-05T21:29:22 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Read error: Connection reset by peer)
3732022-05-05T21:31:54 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
3742022-05-05T21:33:54 <jonatack> The "Safer Usage Of C++" document mentioned by MarcoFalke in https://github.com/bitcoin/bitcoin/issues/20493#issuecomment-1113589139, and in particular the "Annotate Lifetimes" section, seems quite good.
3752022-05-05T21:38:05 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has joined #bitcoin-core-dev
3762022-05-05T21:42:45 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@ip72-194-104-106.oc.oc.cox.net> has quit IRC (Ping timeout: 276 seconds)
3772022-05-05T21:50:04 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Quit: Leaving...)
3782022-05-05T21:52:02 *** salvatoshi <salvatoshi!~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr> has joined #bitcoin-core-dev
3792022-05-05T21:55:35 *** Earnestly <Earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
3802022-05-05T22:03:08 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has quit IRC (Remote host closed the connection)
3812022-05-05T22:03:35 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has joined #bitcoin-core-dev
3822022-05-05T22:09:11 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has quit IRC (Remote host closed the connection)
3832022-05-05T22:14:22 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has joined #bitcoin-core-dev
3842022-05-05T22:18:49 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has quit IRC (Ping timeout: 256 seconds)
3852022-05-05T22:20:26 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has joined #bitcoin-core-dev
3862022-05-05T22:24:36 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has quit IRC (Ping timeout: 248 seconds)
3872022-05-05T22:28:15 *** salvatoshi <salvatoshi!~salvatosh@lfbn-idf3-1-717-163.w86-252.abo.wanadoo.fr> has quit IRC (Ping timeout: 276 seconds)
3882022-05-05T22:28:18 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
3892022-05-05T22:31:13 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has joined #bitcoin-core-dev
3902022-05-05T22:35:49 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has quit IRC (Ping timeout: 256 seconds)
3912022-05-05T22:37:18 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has joined #bitcoin-core-dev
3922022-05-05T22:41:40 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has quit IRC (Ping timeout: 260 seconds)
3932022-05-05T22:43:22 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:3d2a:9b75:86f3:13e9> has joined #bitcoin-core-dev
3942022-05-05T22:46:16 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1cfd:b332:6287:5945> has joined #bitcoin-core-dev
3952022-05-05T22:49:34 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
3962022-05-05T22:51:25 *** Guest33 <Guest33!~Guest33@182.253.132.155> has joined #bitcoin-core-dev
3972022-05-05T22:54:36 *** Guest33 <Guest33!~Guest33@182.253.132.155> has quit IRC (Client Quit)
3982022-05-05T22:59:05 *** hashfunc65d <hashfunc65d!~user@2601:5c0:c280:7090:7c25:cf68:625f:614f> has joined #bitcoin-core-dev
3992022-05-05T23:24:09 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 248 seconds)
4002022-05-05T23:26:18 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹÑа!)
4012022-05-05T23:28:12 *** cotsuka <cotsuka!~cotsuka@user/cotsuka> has quit IRC (Quit: The Lounge - https://thelounge.chat)
4022022-05-05T23:34:46 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
4032022-05-05T23:36:15 *** cameron[m] <cameron[m]!~cotsuka@user/cotsuka> has joined #bitcoin-core-dev
4042022-05-05T23:54:54 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:1cfd:b332:6287:5945> has quit IRC (Remote host closed the connection)