12022-05-20T00:08:22 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c> has joined #bitcoin-core-dev
22022-05-20T00:12:40 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c> has quit IRC (Ping timeout: 260 seconds)
32022-05-20T00:12:40 *** NorrinRadd <NorrinRadd!~username@154.6.21.39> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzzâ¦)
42022-05-20T00:28:36 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹÑа!)
52022-05-20T00:41:09 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
62022-05-20T00:45:42 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
72022-05-20T00:47:19 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
82022-05-20T00:50:12 *** bytes1440000 <bytes1440000!~bytes1440@garza.riseup.net> has joined #bitcoin-core-dev
92022-05-20T00:50:44 <bytes1440000> I wish github had advanced search filters to find pull requests merged by someone with some NACKs in reviews.
102022-05-20T00:50:49 <bytes1440000> Tried this: is:pr is:merged involves:fanquake NACK in:comment
112022-05-20T00:50:59 <bytes1440000> But it has lot of false positives.
122022-05-20T00:51:30 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 240 seconds)
132022-05-20T00:53:14 *** Kaizen___ <Kaizen___!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
142022-05-20T01:05:11 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
152022-05-20T01:09:37 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
162022-05-20T01:10:11 *** bytes1440000 <bytes1440000!~bytes1440@garza.riseup.net> has left #bitcoin-core-dev
172022-05-20T01:14:32 *** Earnestly <Earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 272 seconds)
182022-05-20T01:31:02 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
192022-05-20T01:31:39 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
202022-05-20T01:32:56 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 250 seconds)
212022-05-20T01:33:08 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
222022-05-20T01:35:33 *** hashfunc1204 <hashfunc1204!~user@2601:5c0:c280:7090:6cc7:34d7:ac5c:899e> has joined #bitcoin-core-dev
232022-05-20T01:36:27 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 260 seconds)
242022-05-20T01:37:50 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
252022-05-20T01:38:25 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
262022-05-20T01:44:43 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 244 seconds)
272022-05-20T01:50:47 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
282022-05-20T02:00:58 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
292022-05-20T02:05:45 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 276 seconds)
302022-05-20T02:06:13 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
312022-05-20T02:10:44 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 248 seconds)
322022-05-20T02:17:00 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
332022-05-20T02:21:22 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
342022-05-20T02:23:10 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
352022-05-20T02:27:21 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 246 seconds)
362022-05-20T02:32:15 *** realies <realies!~realies@user/realies> has quit IRC (Ping timeout: 246 seconds)
372022-05-20T02:33:57 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
382022-05-20T02:35:45 *** realies <realies!~realies@user/realies> has joined #bitcoin-core-dev
392022-05-20T02:38:52 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
402022-05-20T02:44:50 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
412022-05-20T02:46:55 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
422022-05-20T02:49:22 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 260 seconds)
432022-05-20T02:49:31 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 256 seconds)
442022-05-20T02:50:54 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
452022-05-20T02:55:47 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
462022-05-20T02:56:14 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
472022-05-20T03:00:40 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 244 seconds)
482022-05-20T03:07:02 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
492022-05-20T03:11:42 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 272 seconds)
502022-05-20T03:13:07 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c> has joined #bitcoin-core-dev
512022-05-20T03:17:19 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:253d:46d1:6253:dc0c> has quit IRC (Ping timeout: 240 seconds)
522022-05-20T03:23:53 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
532022-05-20T03:28:03 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 244 seconds)
542022-05-20T03:29:59 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
552022-05-20T03:34:19 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 240 seconds)
562022-05-20T03:58:37 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
572022-05-20T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
582022-05-20T04:01:32 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
592022-05-20T04:02:53 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
602022-05-20T04:07:06 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 246 seconds)
612022-05-20T04:08:46 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
622022-05-20T04:13:40 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
632022-05-20T04:15:20 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
642022-05-20T04:18:02 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
652022-05-20T04:19:45 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
662022-05-20T04:21:53 <david-bakin> I just got a linker error from `ld`which ld
672022-05-20T04:22:03 <david-bakin> oops
682022-05-20T04:23:54 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 246 seconds)
692022-05-20T04:24:32 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 272 seconds)
702022-05-20T04:24:57 <david-bakin> I just got a linker error from `ld`: "DWARF error: invalid or unhandled FORM value: 0x25" - now, web search tells me this happens when clang's using dwarf v5 and some tool isn't set up for it. I see in 00_setup_env_native_valgrind.h that they had this problem with valgrind so they set `CXXFLAGS=-fdebug-default-version=4` to get around this. BUT!
712022-05-20T04:25:34 <david-bakin> 1) if I pass that to configure then all the _other_ CXXFLAGS are overridden - none show up. So how do I set configure to ADD this to the CXXFLAGS?
722022-05-20T04:26:13 <david-bakin> and 2) should I be doing this anyway? If I go through with this in this PR won't it change everyone's build? So ... do I simply need to avoid the C++ construct that triggers this?
732022-05-20T04:26:51 <david-bakin> I'm using clang 15.0.0 and GNU ld 2.37. Should I be using a different toolchain?
742022-05-20T04:30:32 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
752022-05-20T04:34:57 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
762022-05-20T04:36:42 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
772022-05-20T04:40:54 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 244 seconds)
782022-05-20T04:44:49 *** chinggg <chinggg!~chinggg@198.16.63.47> has joined #bitcoin-core-dev
792022-05-20T04:53:28 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
802022-05-20T04:58:17 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
812022-05-20T05:02:23 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
822022-05-20T05:06:36 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 246 seconds)
832022-05-20T05:11:58 *** dongcarl <dongcarl!~dongcarl@pool-108-6-233-95.nycmny.fios.verizon.net> has quit IRC (Ping timeout: 260 seconds)
842022-05-20T05:12:11 *** dongcarl <dongcarl!~dongcarl@pool-108-6-233-95.nycmny.fios.verizon.net> has joined #bitcoin-core-dev
852022-05-20T05:32:55 *** hashfunc1204 <hashfunc1204!~user@2601:5c0:c280:7090:6cc7:34d7:ac5c:899e> has quit IRC (Ping timeout: 260 seconds)
862022-05-20T05:35:46 <david-bakin> NVM I just rewrote C++ code until the problem went away.
872022-05-20T05:37:51 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
882022-05-20T05:42:28 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 248 seconds)
892022-05-20T05:48:44 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
902022-05-20T05:53:14 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 244 seconds)
912022-05-20T05:59:37 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
922022-05-20T06:04:36 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 272 seconds)
932022-05-20T06:05:41 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
942022-05-20T06:10:15 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
952022-05-20T06:27:38 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
962022-05-20T06:32:12 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
972022-05-20T06:33:45 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
982022-05-20T06:36:16 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 250 seconds)
992022-05-20T06:38:11 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 244 seconds)
1002022-05-20T06:42:41 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
1012022-05-20T06:43:16 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
1022022-05-20T06:45:28 *** Guest4630 <Guest4630!~Guest46@94.155.240.227> has joined #bitcoin-core-dev
1032022-05-20T06:48:10 <laanwj> from what i've seen uusally if you get DWARF errors it means you have to clean your tree, it means object files from different compilers are used together in a way they shouldn't
1042022-05-20T06:48:22 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0de36941eca1...6407c0e8a33f
1052022-05-20T06:48:22 <bitcoin-git> bitcoin/master fa305fd MarcoFalke: Add mockable clock type and TicksSinceEpoch helper
1062022-05-20T06:48:23 <bitcoin-git> bitcoin/master 6407c0e fanquake: Merge bitcoin/bitcoin#25101: Add mockable clock type
1072022-05-20T06:48:26 <bitcoin-git> [bitcoin] fanquake merged pull request #25101: Add mockable clock type (master...2205-mock-clock-ð) https://github.com/bitcoin/bitcoin/pull/25101
1082022-05-20T06:48:49 *** Guest4630 <Guest4630!~Guest46@94.155.240.227> has quit IRC (Client Quit)
1092022-05-20T06:50:44 <laanwj> oh, yes, it could also mean your linker is not compatible with the debug information your compiler generates
1102022-05-20T06:51:59 <laanwj> it shouldn't be related to anything you wrote at the C++ level, nothing you do at that level should (unless a bug in the toolchain) result in a DWARF error
1112022-05-20T06:55:54 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
1122022-05-20T06:58:03 <laanwj> jonatack ran into a similar error with clang 15 recently #25120
1132022-05-20T06:58:04 <gribble> https://github.com/bitcoin/bitcoin/issues/25120 | test: fix DWARF string_view linker error in blockfilter_tests by jonatack · Pull Request #25120 · bitcoin/bitcoin · GitHub
1142022-05-20T06:58:16 <laanwj> his solution was to clear ccache
1152022-05-20T07:00:12 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
1162022-05-20T07:08:23 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
1172022-05-20T07:10:59 *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has joined #bitcoin-core-dev
1182022-05-20T07:11:53 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 256 seconds)
1192022-05-20T07:13:34 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
1202022-05-20T07:19:39 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6407c0e8a33f...d433f59f1eb8
1212022-05-20T07:19:39 <bitcoin-git> bitcoin/master 055d94d brunoerg: test: add coverage for unknown network in -onlynet
1222022-05-20T07:19:39 <bitcoin-git> bitcoin/master d433f59 MacroFake: Merge bitcoin/bitcoin#25173: test: add coverage for unknown network in -on...
1232022-05-20T07:19:41 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25173: test: add coverage for unknown network in -onlynet (master...2022-05-unknown-onlynet) https://github.com/bitcoin/bitcoin/pull/25173
1242022-05-20T07:28:45 *** Earnestly <Earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
1252022-05-20T07:28:51 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
1262022-05-20T07:29:47 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d433f59f1eb8...4a8709821e64
1272022-05-20T07:29:47 <bitcoin-git> bitcoin/master 1d4122d Ryan Ofsky: init: Allow -proxy="" setting values
1282022-05-20T07:29:47 <bitcoin-git> bitcoin/master 4a87098 MacroFake: Merge bitcoin/bitcoin#24830: init: Allow -proxy="" setting values
1292022-05-20T07:29:50 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24830: init: Allow -proxy="" setting values (master...pr/proxy) https://github.com/bitcoin/bitcoin/pull/24830
1302022-05-20T07:33:13 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 248 seconds)
1312022-05-20T07:34:56 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
1322022-05-20T07:36:13 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4a8709821e64...a39002e0c642
1332022-05-20T07:36:13 <bitcoin-git> bitcoin/master fafae67 MacroFake: build: Enable RPC_DOC_CHECK on --enable-debug
1342022-05-20T07:36:13 <bitcoin-git> bitcoin/master a39002e fanquake: Merge bitcoin/bitcoin#25170: build: Enable RPC_DOC_CHECK on --enable-debug
1352022-05-20T07:36:13 <bitcoin-git> [bitcoin] fanquake merged pull request #25170: build: Enable RPC_DOC_CHECK on --enable-debug (master...2205-enable-rpc-doc-check-on-debug-ð¿) https://github.com/bitcoin/bitcoin/pull/25170
1362022-05-20T07:39:36 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 272 seconds)
1372022-05-20T07:40:36 <jonatack> #24150 might be RFM
1382022-05-20T07:40:37 <gribble> https://github.com/bitcoin/bitcoin/issues/24150 | refactor: move index class members from protected to private by jonatack · Pull Request #24150 · bitcoin/bitcoin · GitHub
1392022-05-20T07:43:44 *** Cory <Cory!~Cory@user/pasha> has joined #bitcoin-core-dev
1402022-05-20T07:49:42 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a39002e0c642...a7e3afb22136
1412022-05-20T07:49:42 <bitcoin-git> bitcoin/master ef0aa74 Sebastian Falbesoner: rpc: wallet: remove `-deprecatedrpc=exclude_coinbase` logic
1422022-05-20T07:49:42 <bitcoin-git> bitcoin/master a4703ce Sebastian Falbesoner: doc: add release notes about removal of the `deprecatedrpc=exclude_coinbas...
1432022-05-20T07:49:43 <bitcoin-git> bitcoin/master a7e3afb MacroFake: Merge bitcoin/bitcoin#25171: rpc: wallet: remove `-deprecatedrpc=exclude_c...
1442022-05-20T07:49:44 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25171: rpc: wallet: remove `-deprecatedrpc=exclude_coinbase` logic (master...202205-rpc-remove_deprecated_include_coinbase_option) https://github.com/bitcoin/bitcoin/pull/25171
1452022-05-20T07:58:42 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
1462022-05-20T07:59:28 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
1472022-05-20T08:07:46 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
1482022-05-20T08:12:32 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
1492022-05-20T08:15:37 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1502022-05-20T08:18:13 *** Aaronvan_ <Aaronvan_!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1512022-05-20T08:21:52 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 260 seconds)
1522022-05-20T08:23:56 *** david-bakin <david-bakin!~david-bak@c-174-61-163-5.hsd1.wa.comcast.net> has quit IRC (Ping timeout: 272 seconds)
1532022-05-20T08:31:46 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has joined #bitcoin-core-dev
1542022-05-20T08:32:59 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 240 seconds)
1552022-05-20T08:36:36 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Ping timeout: 246 seconds)
1562022-05-20T08:38:16 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
1572022-05-20T08:39:59 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
1582022-05-20T08:42:41 *** kouloumos <kouloumos!uid539228@id-539228.tinside.irccloud.com> has joined #bitcoin-core-dev
1592022-05-20T08:44:50 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 260 seconds)
1602022-05-20T08:46:47 <laanwj> jonatack: yes
1612022-05-20T08:47:49 <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a7e3afb22136...0cd1a2eff9e0
1622022-05-20T08:47:49 <bitcoin-git> bitcoin/master fabdf81 MarcoFalke: test: Add test for embedded null in hex string
1632022-05-20T08:47:50 <bitcoin-git> bitcoin/master facd1fb MarcoFalke: refactor: Use Span of std::byte in CExtKey::SetSeed
1642022-05-20T08:47:56 <bitcoin-git> [bitcoin] laanwj merged pull request #23595: util: Add ParseHexstd::byte() helper (master...2111-utilHexByte) https://github.com/bitcoin/bitcoin/pull/23595
1652022-05-20T08:52:41 <laanwj> jonatack: wait, i don't get it, why make CDBWrapper a struct instead of a class?
1662022-05-20T08:54:17 <laanwj> i don't really know what the guidance is for making something a struct or a class but anything that *inherits* from a parent class seems definitely in class territory to me
1672022-05-20T08:54:44 <laanwj> i mean, DB
1682022-05-20T08:55:37 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 244 seconds)
1692022-05-20T08:55:54 <laanwj> CDBWrapper is a class, BaseIndex::DB is derived from it, so should imo be a class too
1702022-05-20T09:00:59 *** Aaronvan_ <Aaronvan_!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
1712022-05-20T09:03:21 *** kexkey <kexkey!~kexkey@178.249.214.10> has quit IRC (Ping timeout: 248 seconds)
1722022-05-20T09:03:53 *** kexkey <kexkey!~kexkey@178.249.214.10> has joined #bitcoin-core-dev
1732022-05-20T09:11:25 <laanwj> this PR keeps confusing me on small c++ details
1742022-05-20T09:12:38 <laanwj> i'm sorry to say but i'm not sure it's really worth it or just a very marginal improvement
1752022-05-20T09:15:25 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1762022-05-20T09:30:36 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has joined #bitcoin-core-dev
1772022-05-20T09:34:47 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:20cc:2e05:bb48:c8dd> has quit IRC (Ping timeout: 240 seconds)
1782022-05-20T09:39:36 <vasild> https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes has some meaningful guidelines on struct VS class
1792022-05-20T09:42:58 <jonatack> was offline, now catching up on the discussion
1802022-05-20T09:44:48 <bitcoin-git> [gui] hebasto merged pull request #594: scripted-diff: replace deprecated Q_OS_MAC with Q_OS_MACOS (master...q_os_macos) https://github.com/bitcoin-core/gui/pull/594
1812022-05-20T09:45:27 <bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0cd1a2eff9e0...8118970c869f
1822022-05-20T09:45:27 <bitcoin-git> bitcoin/master e3daeca João Barbosa: scripted-diff: replace deprecated Q_OS_MAC with Q_OS_MACOS
1832022-05-20T09:45:27 <bitcoin-git> bitcoin/master 8118970 Hennadii Stepanov: Merge bitcoin-core/gui#594: scripted-diff: replace deprecated Q_OS_MAC wit...
1842022-05-20T09:49:47 <jonatack> laanwj: will drop that accessory change in the last commit
1852022-05-20T09:53:40 *** greypw2546 <greypw2546!~greypw254@grey.pw> has quit IRC (Quit: I'll be back!)
1862022-05-20T09:53:49 *** greypw2546 <greypw2546!~greypw254@grey.pw> has joined #bitcoin-core-dev
1872022-05-20T10:01:21 *** bfsfhkacjzgcytf9 <bfsfhkacjzgcytf9!~bfsfhkacj@user/bfsfhkacjzgcytf> has joined #bitcoin-core-dev
1882022-05-20T10:07:30 *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has quit IRC (Ping timeout: 240 seconds)
1892022-05-20T10:12:29 <jonatack> Done. I think it's a good simplification, encapsulation improvement, and code clarification that helps new virtual functions be added in the right place rather than by default next to existing ones (that were misplaced). This came up in review feedback over several PRs.
1902022-05-20T10:14:14 <hebasto> has bitcoin-git bot just got another holiday?
1912022-05-20T10:25:46 <laanwj> jonatack: thanks!
1922022-05-20T10:25:54 <laanwj> hebasto: i didn't give if time off i'll check
1932022-05-20T10:27:10 <hebasto> laanwj: thank you
1942022-05-20T10:33:48 <bitcoin-git> [gui] hebasto merged pull request #581: refactor: Revamp `ClientModel` code to handle core signals (master...220410-invoke) https://github.com/bitcoin-core/gui/pull/581
1952022-05-20T10:35:23 <laanwj> i'm not entirely sure what happened (the matrix side was throwing an error resolving the room alias), restarting the bot seems to have solved it
1962022-05-20T10:37:00 <hebasto> thanks!
1972022-05-20T11:10:36 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1982022-05-20T11:16:16 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
1992022-05-20T11:18:48 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 250 seconds)
2002022-05-20T11:40:16 <bitcoin-git> [bitcoin] hebasto opened pull request #25175: refactor: Improve thread safety analysis by propagating some negative capabilities (master...220520-nega) https://github.com/bitcoin/bitcoin/pull/25175
2012022-05-20T11:41:28 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Ping timeout: 244 seconds)
2022022-05-20T11:42:05 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
2032022-05-20T11:53:31 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
2042022-05-20T11:58:38 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Ping timeout: 272 seconds)
2052022-05-20T12:00:04 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Ping timeout: 240 seconds)
2062022-05-20T12:00:59 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
2072022-05-20T12:01:22 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
2082022-05-20T12:18:50 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
2092022-05-20T12:23:10 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 240 seconds)
2102022-05-20T12:37:17 <bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/8c61374ba782...4d0c00dffd13
2112022-05-20T12:37:17 <bitcoin-git> bitcoin/master fa4ee53 MacroFake: Do not pass time getter to Chainstate helpers
2122022-05-20T12:37:17 <bitcoin-git> bitcoin/master faf012b MacroFake: Do not pass Consensus::Params& to Chainstate helpers
2132022-05-20T12:37:17 <bitcoin-git> bitcoin/master fafe5c0 MacroFake: Do not pass CChainParams& to BlockAssembler constructor
2142022-05-20T12:37:21 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25168: refactor: Avoid passing params where not needed (master...2205-remove-bloat-ð®) https://github.com/bitcoin/bitcoin/pull/25168
2152022-05-20T12:42:09 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
2162022-05-20T12:48:10 <bitcoin-git> [bitcoin] jonatack opened pull request #25176: Fix frequent -netinfo JSON errors from missing getpeerinfo#relaytxes (master...fix-netinfo-json-errors-from-null-getpeerinfo-relaytxes-field) https://github.com/bitcoin/bitcoin/pull/25176
2172022-05-20T12:48:18 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
2182022-05-20T12:51:45 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
2192022-05-20T13:03:34 *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 240 seconds)
2202022-05-20T13:29:25 *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
2212022-05-20T13:55:18 <bitcoin-git> [bitcoin] theStack opened pull request #25178: doc: remove passing `--disable-external-signer` in OpenBSD build guide (master...202205-doc-update_openbsd_build_docs_71) https://github.com/bitcoin/bitcoin/pull/25178
2222022-05-20T14:05:36 *** furszy <furszy!~furszy@user/furszy> has joined #bitcoin-core-dev
2232022-05-20T14:11:08 *** noonien <noonien!~noonien@user/noonien> has joined #bitcoin-core-dev
2242022-05-20T14:16:24 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
2252022-05-20T14:20:30 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 240 seconds)
2262022-05-20T15:13:18 *** Guyver2_ <Guyver2_!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
2272022-05-20T15:16:02 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Ping timeout: 260 seconds)
2282022-05-20T15:27:16 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
2292022-05-20T15:28:19 *** david-bakin <david-bakin!~david-bak@c-174-61-163-5.hsd1.wa.comcast.net> has joined #bitcoin-core-dev
2302022-05-20T15:31:07 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 256 seconds)
2312022-05-20T15:41:15 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
2322022-05-20T16:09:55 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
2332022-05-20T16:10:30 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 240 seconds)
2342022-05-20T16:11:24 *** Common <Common!~Common@096-033-221-075.res.spectrum.com> has joined #bitcoin-core-dev
2352022-05-20T16:12:29 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
2362022-05-20T16:12:53 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
2372022-05-20T16:28:44 *** Kaizen_K_ <Kaizen_K_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
2382022-05-20T16:32:51 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 276 seconds)
2392022-05-20T16:33:17 *** furszy <furszy!~furszy@user/furszy> has quit IRC (Remote host closed the connection)
2402022-05-20T16:34:38 <david-bakin> hmm, clear ccache - i'll try that next time - but I don't rule out an incompatibility in the toolchain because it _did_ go away when I changed the code
2412022-05-20T17:06:15 *** furszy <furszy!~furszy@user/furszy> has joined #bitcoin-core-dev
2422022-05-20T17:38:02 *** furszy <furszy!~furszy@user/furszy> has quit IRC ()
2432022-05-20T18:17:23 *** Kaizen_K_ <Kaizen_K_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC ()
2442022-05-20T18:40:18 <bitcoin-git> [gui] ryanofsky opened pull request #603: Add settings.json prune-prev, proxy-prev, onion-prev settings (master...pr/qtkeep) https://github.com/bitcoin-core/gui/pull/603
2452022-05-20T18:41:09 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:f8a2:49f0:843c:1b6d> has joined #bitcoin-core-dev
2462022-05-20T18:41:37 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@2600:8802:3806:c200:f8a2:49f0:843c:1b6d> has quit IRC (Remote host closed the connection)
2472022-05-20T18:41:56 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/aac99faa66e2...640eb772e556
2482022-05-20T18:41:57 <bitcoin-git> bitcoin/master dbe45c3 Carl Dong: Add ChainstateManagerOpts, using as ::Options
2492022-05-20T18:41:57 <bitcoin-git> bitcoin/master 04c31c1 Carl Dong: Add ChainstateManager::m_adjusted_time_callback
2502022-05-20T18:41:57 <bitcoin-git> bitcoin/master 53494bc Carl Dong: validation: Have ChainstateManager own m_chainparams
2512022-05-20T18:41:59 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25064: [kernel 2b/n] Add `ChainstateManager::m_adjusted_time_callback` (master...2022-05-libbitcoinkernel-adjtime) https://github.com/bitcoin/bitcoin/pull/25064
2522022-05-20T18:42:12 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
2532022-05-20T18:43:44 *** gnaf <gnaf!~gnaf@195-154-105-157.rev.poneytelecom.eu> has quit IRC (Quit: Konversation terminated!)
2542022-05-20T19:01:43 <achow101> #startmeeting
2552022-05-20T19:01:44 <core-meetingbot> Meeting started Fri May 20 19:01:43 2022 UTC. The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
2562022-05-20T19:01:44 <core-meetingbot> Available commands: action commands idea info link nick
2572022-05-20T19:01:46 <achow101> #bitcoin-core-dev Wallet Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos Murch nehan NicolasDorier paveljanik
2582022-05-20T19:01:46 <achow101> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar S3RK sipa vasild
2592022-05-20T19:02:06 <achow101> we haven't had a wallet meeting in a while
2602022-05-20T19:02:27 <sipa> hi
2612022-05-20T19:02:32 <achow101> there aren't any pre-proposed wallet meeting topics. Does anyone have anything to discuss?
2622022-05-20T19:03:15 <Murch> hi
2632022-05-20T19:04:35 <kanzure> hi
2642022-05-20T19:04:37 <achow101> or any PRs to shill?
2652022-05-20T19:04:43 <Murch> I don't have anything from the top of my head
2662022-05-20T19:04:58 <Murch> https://github.com/bitcoin/bitcoin/pull/25083
2672022-05-20T19:05:15 <Murch> I think it's almost ready to go, could use another review or two
2682022-05-20T19:06:13 <achow101> I think #24649 and #25122 are close as well
2692022-05-20T19:06:14 <gribble> https://github.com/bitcoin/bitcoin/issues/24649 | wallet: do not count wallet utxos as external by S3RK · Pull Request #24649 · bitcoin/bitcoin · GitHub
2702022-05-20T19:06:15 <gribble> https://github.com/bitcoin/bitcoin/issues/25122 | rpc: getreceivedbylabel, return early if no addresses were found in the address book by furszy · Pull Request #25122 · bitcoin/bitcoin · GitHub
2712022-05-20T19:06:57 <Murch> Oh, I should look at #25122
2722022-05-20T19:06:58 <gribble> https://github.com/bitcoin/bitcoin/issues/25122 | rpc: getreceivedbylabel, return early if no addresses were found in the address book by furszy · Pull Request #25122 · bitcoin/bitcoin · GitHub
2732022-05-20T19:07:02 <Murch> I have reviewed the other already
2742022-05-20T19:08:13 <achow101> It looks like there have been a lot of proposed changes to AvailableCoins that conflict with each other, but all look nice to get in
2752022-05-20T19:08:29 <Murch> Yeah, that's right
2762022-05-20T19:09:00 <achow101> e.g. #25005 #25118 #25083 #24699 #24584
2772022-05-20T19:09:01 <gribble> https://github.com/bitcoin/bitcoin/issues/25005 | wallet: remove extra wtx lookup in AvailableCoins + several code cleanups. by furszy · Pull Request #25005 · bitcoin/bitcoin · GitHub
2782022-05-20T19:09:02 <gribble> https://github.com/bitcoin/bitcoin/issues/25118 | wallet: unify âallow/block other inputsâ concept by furszy · Pull Request #25118 · bitcoin/bitcoin · GitHub
2792022-05-20T19:09:03 <gribble> https://github.com/bitcoin/bitcoin/issues/25083 | Set effective_value when initializing a COutput by ishaanam · Pull Request #25083 · bitcoin/bitcoin · GitHub
2802022-05-20T19:09:04 <gribble> https://github.com/bitcoin/bitcoin/issues/24699 | wallet: Improve AvailableCoins performance by reducing duplicated operations by achow101 · Pull Request #24699 · bitcoin/bitcoin · GitHub
2812022-05-20T19:09:06 <achow101> any thoughts on what to prioritize?
2822022-05-20T19:09:07 <gribble> https://github.com/bitcoin/bitcoin/issues/24584 | wallet: avoid mixing different `OutputTypes` during coin selection by josibake · Pull Request #24584 · bitcoin/bitcoin · GitHub
2832022-05-20T19:09:42 <Murch> I don't think Josi's is close to getting merged.
2842022-05-20T19:09:54 <Murch> I haven't looked at #25005, so I can't comment on that
2852022-05-20T19:09:55 <gribble> https://github.com/bitcoin/bitcoin/issues/25005 | wallet: remove extra wtx lookup in AvailableCoins + several code cleanups. by furszy · Pull Request #25005 · bitcoin/bitcoin · GitHub
2862022-05-20T19:10:20 <achow101> 25083 and 25118 both are pretty simple
2872022-05-20T19:10:20 <Murch> How useful is 24699 now that we use different keys?
2882022-05-20T19:10:24 <achow101> so I think they can go in soon
2892022-05-20T19:11:06 *** kouloumos <kouloumos!uid539228@id-539228.tinside.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
2902022-05-20T19:11:15 <Murch> I'm biased, one of my PRs is building on #25083 ^^
2912022-05-20T19:11:16 <gribble> https://github.com/bitcoin/bitcoin/issues/25083 | Set effective_value when initializing a COutput by ishaanam · Pull Request #25083 · bitcoin/bitcoin · GitHub
2922022-05-20T19:11:21 <achow101> I think 24699 is still a worthwhile promovement. it improves more than just the reused addresses case
2932022-05-20T19:12:02 <achow101> *improvement
2942022-05-20T19:12:24 <Murch> okay
2952022-05-20T19:12:33 <Murch> I'll put all of the above on my review list
2962022-05-20T19:13:27 <Murch> I think just in the order that they're ready is fine
2972022-05-20T19:13:44 <Murch> I don't think rebasing would get too bad for any
2982022-05-20T19:14:23 <Murch> You should add josibake to your ping list ^^
2992022-05-20T19:14:47 <achow101> I think 24584 might have a larger conflict with the others
3002022-05-20T19:14:53 <achow101> but it's also not ready imo
3012022-05-20T19:15:27 <Murch> Yeah, and it is also the biggest one
3022022-05-20T19:15:49 <achow101> anything else look ready or nearly ready?
3032022-05-20T19:15:51 <jonatack> hi (...reading up)
3042022-05-20T19:17:25 <achow101> anything else to discuss?
3052022-05-20T19:17:43 <Murch> Not from the top of my head. Really curious to see some simulation results for #24584
3062022-05-20T19:17:47 <gribble> https://github.com/bitcoin/bitcoin/issues/24584 | wallet: avoid mixing different `OutputTypes` during coin selection by josibake · Pull Request #24584 · bitcoin/bitcoin · GitHub
3072022-05-20T19:18:17 <Murch> I'm wondering how splitting the UTXO pool in multiple ways will affect the tx costs
3082022-05-20T19:18:34 <Murch> Oh one more
3092022-05-20T19:18:55 <Murch> There is this very tight testing corset that S3RK proposed
3102022-05-20T19:19:12 <Murch> So far you and I reviewed it, achow101
3112022-05-20T19:19:41 <Murch> Yours sounded like a soft concept nack or approach nack
3122022-05-20T19:20:09 <achow101> #24580?
3132022-05-20T19:20:10 <gribble> https://github.com/bitcoin/bitcoin/issues/24580 | test: coinselection edge cases by S3RK · Pull Request #24580 · bitcoin/bitcoin · GitHub
3142022-05-20T19:20:19 <Murch> I think maintaining the test when we start changing the coin selection algos will be annoying, but it's also kinda nice to see the exact boundaries
3152022-05-20T19:20:26 <Murch> yeah thanks!
3162022-05-20T19:20:59 <Murch> I think that S3RK might be a bit stuck there, no way forward not really shot down either
3172022-05-20T19:21:40 <achow101> perhaps more people should look at it
3182022-05-20T19:21:59 <Murch> Could we perhaps give more input how it should be developed to address maintainability concerns?
3192022-05-20T19:23:36 <achow101> maybe more programmatic math rather than hardcoded math
3202022-05-20T19:23:59 <Murch> Yeah
3212022-05-20T19:24:28 <Murch> Do you know what the status with Bruno's "Prefer changeless" PR is?
3222022-05-20T19:24:29 <Murch> That also seemed a bit stuck
3232022-05-20T19:24:29 <instagibbs> woof, lots of magic numbers
3242022-05-20T19:24:41 <instagibbs> re: #24580
3252022-05-20T19:24:42 <gribble> https://github.com/bitcoin/bitcoin/issues/24580 | test: coinselection edge cases by S3RK · Pull Request #24580 · bitcoin/bitcoin · GitHub
3262022-05-20T19:26:19 <Murch> https://github.com/bitcoin/bitcoin/pull/23475
3272022-05-20T19:26:23 <achow101> Murch: it seems like it needs conceptual review as to whether that's a good idea?
3282022-05-20T19:27:03 <Murch> achow101: I think I'd be "concept ack, approach nack", wasn't sure whether that came out clearly
3292022-05-20T19:27:33 <Murch> Is brunoerg here?
3302022-05-20T19:27:48 <jonatack> having good boundary testing of expected behavior in place before making big changes can be good if the testing is of the right kind... maybe hoist the magic numbers up to constants or derive them programmatically as mentioned
3312022-05-20T19:28:16 <Murch> jonatack: that sounds like a good idea
3322022-05-20T19:28:39 <jonatack> might be good for people to weigh in on https://github.com/bitcoin/bitcoin/issues/25130
3332022-05-20T19:28:39 <instagibbs> derive please, don't make follow-on contributors hate life
3342022-05-20T19:29:23 <instagibbs> can even be done and merged piece by piece
3352022-05-20T19:29:24 <achow101> #23475 would interact pretty poorly with #24752
3362022-05-20T19:29:26 <gribble> https://github.com/bitcoin/bitcoin/issues/23475 | wallet: add config to prioritize a solution that doesnt create change in coin selection by brunoerg · Pull Request #23475 · bitcoin/bitcoin · GitHub
3372022-05-20T19:29:27 <gribble> https://github.com/bitcoin/bitcoin/issues/24752 | wallet: increase BnB upper limit by S3RK · Pull Request #24752 · bitcoin/bitcoin · GitHub
3382022-05-20T19:29:45 <Murch> instagibbs, jonatack: I think one issue is also that it sorta depends on the current selection of algorithms we use, and sort of tests whether the outcome was Knapsack, or BnB at times
3392022-05-20T19:30:09 <instagibbs> Murch, yeah I'm not wading in on the overall thrust, deferring on that
3402022-05-20T19:30:34 <Murch> Yeah, #23475 needs some sanity limit, similar to the avoid_partial_spend approach
3412022-05-20T19:30:35 <gribble> https://github.com/bitcoin/bitcoin/issues/23475 | wallet: add config to prioritize a solution that doesnt create change in coin selection by brunoerg · Pull Request #23475 · bitcoin/bitcoin · GitHub
3422022-05-20T19:31:27 <Murch> Okay, I guess the overall result is, we could all take another glance at these and perhaps be a bit more direct with feedback? ;)
3432022-05-20T19:31:40 <achow101> yes
3442022-05-20T19:31:44 *** lukedashjr <lukedashjr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
3452022-05-20T19:31:45 <jonatack> instagibbs: Murch: agree, may need more abstraction
3462022-05-20T19:32:53 <achow101> anything else to discuss?
3472022-05-20T19:33:50 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 240 seconds)
3482022-05-20T19:33:56 *** lukedashjr is now known as luke-jr
3492022-05-20T19:34:11 <Murch> No, just ⦠by the way, I'm of the opinion that Knapsack needs to die
3502022-05-20T19:34:12 <Murch> :D
3512022-05-20T19:34:16 <achow101> #endmeeting
3522022-05-20T19:34:16 <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
3532022-05-20T19:34:16 <core-meetingbot> Meeting ended Fri May 20 19:34:16 2022 UTC.
3542022-05-20T19:34:16 <core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2022/bitcoin-core-dev.2022-05-20-19.01.moin.txt
3552022-05-20T19:34:20 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
3562022-05-20T19:35:00 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
3572022-05-20T19:35:15 <Murch> Thanks for hosting
3582022-05-20T19:36:11 <sipa> @Murch channels his inner cato?
3592022-05-20T19:36:37 <Murch> Ceterum censeo Knapsackinem esse delendam.
3602022-05-20T19:39:09 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 246 seconds)
3612022-05-20T19:39:15 <Murch> Keeps me focused on the important stuff ð¤ª
3622022-05-20T19:43:07 <instagibbs> what change size does SRD shoot for these days
3632022-05-20T19:43:13 <instagibbs> if any
3642022-05-20T19:49:53 <Murch> äääääässogzonbbclnreolrägnweenagcapshwhlhräl
3652022-05-20T19:49:56 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
3662022-05-20T19:50:02 <Murch> oops
3672022-05-20T19:50:41 <Murch> SRD uses the lower bound of the random change introduced by #24494 as a minimum now
3682022-05-20T19:50:45 <gribble> https://github.com/bitcoin/bitcoin/issues/24494 | wallet: generate random change target for each tx for better privacy by glozow · Pull Request #24494 · bitcoin/bitcoin · GitHub
3692022-05-20T19:50:57 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
3702022-05-20T19:53:36 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 250 seconds)
3712022-05-20T19:57:18 <Murch> And that's 50,000â¯á¹©
3722022-05-20T20:02:56 <instagibbs> oh wow great to see
3732022-05-20T20:04:45 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Ping timeout: 276 seconds)
3742022-05-20T20:14:09 *** bfsfhkacjzgcytf9 <bfsfhkacjzgcytf9!~bfsfhkacj@user/bfsfhkacjzgcytf> has quit IRC (Ping timeout: 246 seconds)
3752022-05-20T20:14:53 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
3762022-05-20T20:25:07 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC ()
3772022-05-20T20:38:16 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
3782022-05-20T20:40:48 *** MiranDaniel <MiranDaniel!~MiranDani@46-13-162-93.customers.tmcz.cz> has joined #bitcoin-core-dev
3792022-05-20T20:53:08 *** Kaizen_K_ <Kaizen_K_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
3802022-05-20T20:55:20 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 244 seconds)
3812022-05-20T21:04:29 *** Kaizen_K_ <Kaizen_K_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Remote host closed the connection)
3822022-05-20T21:05:06 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
3832022-05-20T21:07:35 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Read error: Connection reset by peer)
3842022-05-20T21:10:39 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
3852022-05-20T21:22:26 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
3862022-05-20T21:35:36 *** MiranDaniel <MiranDaniel!~MiranDani@46-13-162-93.customers.tmcz.cz> has quit IRC (Quit: Client closed)
3872022-05-20T21:35:56 *** MiranDaniel <MiranDaniel!~MiranDani@46-13-162-93.customers.tmcz.cz> has joined #bitcoin-core-dev
3882022-05-20T21:50:41 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
3892022-05-20T21:51:32 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has quit IRC (Ping timeout: 248 seconds)
3902022-05-20T21:52:31 <bitcoin-git> [bitcoin] MiranDaniel opened pull request #25182: doc: Fix Markdown formatting (master...master) https://github.com/bitcoin/bitcoin/pull/25182
3912022-05-20T21:54:18 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
3922022-05-20T22:03:03 *** Guyver2_ <Guyver2_!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Ping timeout: 276 seconds)
3932022-05-20T22:13:48 *** MiranDaniel <MiranDaniel!~MiranDani@46-13-162-93.customers.tmcz.cz> has quit IRC (Quit: Client closed)
3942022-05-20T22:26:54 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 272 seconds)
3952022-05-20T22:38:28 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
3962022-05-20T23:03:04 *** chinggg <chinggg!~chinggg@198.16.63.47> has quit IRC (Quit: Client closed)
3972022-05-20T23:21:28 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Remote host closed the connection)
3982022-05-20T23:26:44 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
3992022-05-20T23:30:51 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 244 seconds)
4002022-05-20T23:37:37 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
4012022-05-20T23:39:54 *** Guest6 <Guest6!~Guest6@120.29.77.62> has joined #bitcoin-core-dev
4022022-05-20T23:42:13 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 244 seconds)
4032022-05-20T23:42:30 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 240 seconds)
4042022-05-20T23:43:41 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc> has joined #bitcoin-core-dev
4052022-05-20T23:44:10 *** Guest6 <Guest6!~Guest6@120.29.77.62> has quit IRC (Client Quit)
4062022-05-20T23:48:25 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev
4072022-05-20T23:48:36 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:d919:f52d:939e:99bc> has quit IRC (Ping timeout: 272 seconds)
4082022-05-20T23:50:21 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
4092022-05-20T23:53:16 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
4102022-05-20T23:53:30 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has quit IRC (Ping timeout: 240 seconds)
4112022-05-20T23:56:41 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 244 seconds)
4122022-05-20T23:59:20 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!Kaizen_Kin@gateway/vpn/protonvpn/kaizenkintsugi/x-74018745> has joined #bitcoin-core-dev