12022-05-30T00:07:55 *** div72 <div72!~div72@user/div72> has quit IRC (Quit: Konversation terminated!)
22022-05-30T00:08:26 *** div72 <div72!~div72@user/div72> has joined #bitcoin-core-dev
32022-05-30T00:16:07 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has quit IRC (Ping timeout: 260 seconds)
42022-05-30T00:39:05 *** div72 <div72!~div72@user/div72> has quit IRC (Quit: Konversation terminated!)
52022-05-30T00:39:34 *** div72 <div72!~div72@user/div72> has joined #bitcoin-core-dev
62022-05-30T00:44:45 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has joined #bitcoin-core-dev
72022-05-30T00:48:45 *** div72 <div72!~div72@user/div72> has quit IRC (Remote host closed the connection)
82022-05-30T00:50:00 *** div72 <div72!~div72@user/div72> has joined #bitcoin-core-dev
92022-05-30T01:33:34 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
102022-05-30T01:35:48 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
112022-05-30T01:38:24 *** Guest58 <Guest58!~Guest58@2804:14d:78a6:90b8:6820:7554:44a9:92e3> has joined #bitcoin-core-dev
122022-05-30T01:39:17 *** Guest58 <Guest58!~Guest58@2804:14d:78a6:90b8:6820:7554:44a9:92e3> has quit IRC (Client Quit)
132022-05-30T01:47:59 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has quit IRC (Ping timeout: 258 seconds)
142022-05-30T02:11:27 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Ping timeout: 240 seconds)
152022-05-30T02:17:55 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has joined #bitcoin-core-dev
162022-05-30T02:18:15 *** ronoaldo <ronoaldo!~ronoaldo@177.68.61.49> has quit IRC (Quit: Konversation terminated!)
172022-05-30T02:22:27 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has quit IRC (Ping timeout: 244 seconds)
182022-05-30T02:51:35 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has joined #bitcoin-core-dev
192022-05-30T02:56:08 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has quit IRC (Ping timeout: 255 seconds)
202022-05-30T03:09:56 <bitcoin-git> [bitcoin] 1440000bytes closed pull request #25236: wallet: use vector instead of list for transactions (master...listtx-memory) https://github.com/bitcoin/bitcoin/pull/25236
212022-05-30T03:24:58 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has joined #bitcoin-core-dev
222022-05-30T03:26:19 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
232022-05-30T03:29:10 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 250 seconds)
242022-05-30T03:42:20 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
252022-05-30T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
262022-05-30T04:01:47 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
272022-05-30T04:04:34 *** bairen <bairen!~bairen@gateway/tor-sasl/bairen> has quit IRC (Ping timeout: 240 seconds)
282022-05-30T04:04:46 *** bairen <bairen!~bairen@gateway/tor-sasl/bairen> has joined #bitcoin-core-dev
292022-05-30T04:18:37 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
302022-05-30T04:25:28 *** Saloframes <Saloframes!~Saloframe@user/Saloframes> has quit IRC (Quit: Leaving)
312022-05-30T04:29:07 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has quit IRC (Ping timeout: 240 seconds)
322022-05-30T04:29:47 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net> has quit IRC (Ping timeout: 240 seconds)
332022-05-30T04:42:34 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net> has joined #bitcoin-core-dev
342022-05-30T04:43:31 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
352022-05-30T04:54:40 *** Saloframes <Saloframes!~Saloframe@user/Saloframes> has joined #bitcoin-core-dev
362022-05-30T05:13:33 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has joined #bitcoin-core-dev
372022-05-30T05:25:32 *** bfsfhkacjzgcytf9 <bfsfhkacjzgcytf9!~bfsfhkacj@user/bfsfhkacjzgcytf> has quit IRC (Ping timeout: 255 seconds)
382022-05-30T05:51:18 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
392022-05-30T06:00:33 *** Guest967 <Guest967!~Guest96@194.8.128.212> has joined #bitcoin-core-dev
402022-05-30T06:00:52 *** Guest967 <Guest967!~Guest96@194.8.128.212> has quit IRC (Client Quit)
412022-05-30T06:08:34 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
422022-05-30T06:09:20 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
432022-05-30T06:16:09 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has joined #bitcoin-core-dev
442022-05-30T06:16:50 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has quit IRC (Ping timeout: 255 seconds)
452022-05-30T06:19:27 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 240 seconds)
462022-05-30T06:32:34 *** Earnestly <Earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 272 seconds)
472022-05-30T06:46:33 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has joined #bitcoin-core-dev
482022-05-30T06:52:34 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
492022-05-30T06:53:01 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
502022-05-30T06:54:34 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/fb7437f66f9d...b6ab45ae5c91
512022-05-30T06:54:34 <bitcoin-git> bitcoin/master 387ae8b Sebastian Falbesoner: rpc: remove deprecated fee fields from mempool entries
522022-05-30T06:54:35 <bitcoin-git> bitcoin/master 885694d Sebastian Falbesoner: doc: add release note about removal of `deprecatedrpc=fees` flag
532022-05-30T06:54:36 <bitcoin-git> bitcoin/master b6ab45a MacroFake: Merge bitcoin/bitcoin#25204: rpc: remove deprecated top-level fee fields f...
542022-05-30T06:54:38 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25204: rpc: remove deprecated top-level fee fields from mempool entries (master...202205-rpc-remove_deprecated_top_level_fee_fields) https://github.com/bitcoin/bitcoin/pull/25204
552022-05-30T07:10:15 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 246 seconds)
562022-05-30T07:10:42 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has joined #bitcoin-core-dev
572022-05-30T07:33:49 *** Guest83 <Guest83!~Guest83@110.235.227.100> has joined #bitcoin-core-dev
582022-05-30T07:34:29 *** Guest83 <Guest83!~Guest83@110.235.227.100> has quit IRC (Client Quit)
592022-05-30T07:37:50 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
602022-05-30T07:40:43 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 244 seconds)
612022-05-30T07:43:04 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
622022-05-30T07:51:10 *** z9z0b3t1c <z9z0b3t1c!~z9z0b3t1c@145.224.65.211> has joined #bitcoin-core-dev
632022-05-30T07:52:17 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has quit IRC (Ping timeout: 260 seconds)
642022-05-30T07:54:00 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 246 seconds)
652022-05-30T07:56:49 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
662022-05-30T07:59:03 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net> has quit IRC (Ping timeout: 256 seconds)
672022-05-30T08:01:12 *** dougefish <dougefish!~dougefish@2a00:a040:19e:67b8:8ed1:c610:9029:1239> has quit IRC (Read error: Connection reset by peer)
682022-05-30T08:01:25 *** dougefish <dougefish!~dougefish@2a00:a040:19e:67b8:8ed1:c610:9029:1239> has joined #bitcoin-core-dev
692022-05-30T08:06:51 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has joined #bitcoin-core-dev
702022-05-30T08:09:42 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has quit IRC (Quit: jarthur_)
712022-05-30T08:10:42 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net> has joined #bitcoin-core-dev
722022-05-30T08:15:11 <laanwj> div72: how do you even get a foreign key into that function? i don't think it's considered an issue because afaik, that function is only used for loading wallets, and it only supports the keys generated by bitcoin core itself
732022-05-30T08:15:55 *** Earnestly <Earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
742022-05-30T08:16:21 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b6ab45ae5c91...e3b7f10b1066
752022-05-30T08:16:21 <bitcoin-git> bitcoin/master 20ff499 Martin Zumsande: rpc: Capture potentially large UniValue by ref for rpcdoccheck
762022-05-30T08:16:22 <bitcoin-git> bitcoin/master e3b7f10 fanquake: Merge bitcoin/bitcoin#25237: rpc: Capture UniValue by ref for rpcdoccheck
772022-05-30T08:16:25 <bitcoin-git> [bitcoin] fanquake merged pull request #25237: rpc: Capture UniValue by ref for rpcdoccheck (master...202205_rpcdoc_capture) https://github.com/bitcoin/bitcoin/pull/25237
782022-05-30T08:17:23 <laanwj> e.g. it only needs to roundtrip with ec_seckey_export_der
792022-05-30T08:25:18 <laanwj> but maybe i'm missing something, or this is an ancient wallet from the time bitcoin's wallet still used openssl?
802022-05-30T08:27:57 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net> has quit IRC (Ping timeout: 246 seconds)
812022-05-30T08:42:27 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e3b7f10b1066...8779adbdda76
822022-05-30T08:42:27 <bitcoin-git> bitcoin/master cc61bc2 fanquake: compat: remove glibcxx sanity checks
832022-05-30T08:42:28 <bitcoin-git> bitcoin/master 8779adb MacroFake: Merge bitcoin/bitcoin#25233: compat: remove glibcxx sanity checks
842022-05-30T08:42:29 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25233: compat: remove glibcxx sanity checks (master...remove_glibcxx_sanity) https://github.com/bitcoin/bitcoin/pull/25233
852022-05-30T08:47:33 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #25241: [23.x] rpc: Capture potentially large UniValue by ref for rpcdoccheck (23.x...2205-uni-no-copy-ð) https://github.com/bitcoin/bitcoin/pull/25241
862022-05-30T08:47:39 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #25242: [22.x] rpc: Capture potentially large UniValue by ref for rpcdoccheck (22.x...2205-uni-no-copy-ð) https://github.com/bitcoin/bitcoin/pull/25242
872022-05-30T08:50:52 <luke-jr> guix builds please * [new tag] v23.0.knots20220529 -> v23.0.knots20220529
882022-05-30T08:51:51 *** Guyver2_ <Guyver2_!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
892022-05-30T08:54:47 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Ping timeout: 255 seconds)
902022-05-30T09:00:48 <laanwj> luke-jr: building
912022-05-30T09:01:54 *** goatpig <goatpig!~goat@h-94-254-2-155.A498.priv.bahnhof.se> has joined #bitcoin-core-dev
922022-05-30T09:04:25 *** kexkey <kexkey!~kexkey@178.249.214.25> has quit IRC (Ping timeout: 244 seconds)
932022-05-30T09:06:05 *** kexkey <kexkey!~kexkey@178.249.214.10> has joined #bitcoin-core-dev
942022-05-30T09:08:26 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has quit IRC (Ping timeout: 258 seconds)
952022-05-30T09:21:55 *** Guyver2_ <Guyver2_!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev
962022-05-30T09:33:08 <bitcoin-git> [bitcoin] suhailsaqan opened pull request #25243: test: autogenerate bash completion (master...bash-completion) https://github.com/bitcoin/bitcoin/pull/25243
972022-05-30T09:38:07 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
982022-05-30T09:38:44 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Quit: bye)
992022-05-30T09:44:55 *** donor <donor!~donor@2409:4043:2c10:6f6c:61b7:7fd3:7714:ddca> has joined #bitcoin-core-dev
1002022-05-30T09:49:39 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
1012022-05-30T10:04:34 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 240 seconds)
1022022-05-30T10:05:51 <luke-jr> laanwj: thanks
1032022-05-30T10:16:24 <hebasto> theStack: II've tested the master branch at 0be1dc1f56f611bebb4204a3f3221f425f156bcf, and it does not seem that #20640 changed behavior. Not being a wallet expert, I'm afraid I just failed to create the right testing transaction. Do you have an example of a tx which fires the `WalletModel::AmountWithFeeExceedsBalance` error (pre-20640)?
1042022-05-30T10:16:27 <gribble> https://github.com/bitcoin/bitcoin/issues/20640 | wallet, refactor: return out-params of CreateTransaction() as optional struct by theStack · Pull Request #20640 · bitcoin/bitcoin · GitHub
1052022-05-30T10:32:20 <bitcoin-git> [bitcoin] fanquake opened pull request #25244: build: pass bdb cppflags only where needed (master...use_bdb_cppflags_needed) https://github.com/bitcoin/bitcoin/pull/25244
1062022-05-30T10:37:41 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #25245: refactor: Remove no-op TIME_INIT on deser (master...2205-no-time-deser-ð) https://github.com/bitcoin/bitcoin/pull/25245
1072022-05-30T10:41:38 *** donor <donor!~donor@2409:4043:2c10:6f6c:61b7:7fd3:7714:ddca> has quit IRC (Ping timeout: 250 seconds)
1082022-05-30T10:42:10 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 240 seconds)
1092022-05-30T10:43:44 <bitcoin-git> [bitcoin] fanquake opened pull request #25246: Revert "build: more robustly check for fcf-protection support" (master...remove_clang_7_note) https://github.com/bitcoin/bitcoin/pull/25246
1102022-05-30T10:55:55 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net> has joined #bitcoin-core-dev
1112022-05-30T10:57:38 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 255 seconds)
1122022-05-30T11:00:09 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net> has quit IRC (Ping timeout: 244 seconds)
1132022-05-30T11:02:15 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1142022-05-30T11:06:34 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
1152022-05-30T11:25:34 *** bairen <bairen!~bairen@gateway/tor-sasl/bairen> has quit IRC (Remote host closed the connection)
1162022-05-30T11:26:29 *** bairen <bairen!~bairen@gateway/tor-sasl/bairen> has joined #bitcoin-core-dev
1172022-05-30T11:28:08 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has joined #bitcoin-core-dev
1182022-05-30T11:34:06 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 258 seconds)
1192022-05-30T11:54:34 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 240 seconds)
1202022-05-30T12:08:09 *** erwanor <erwanor!sid556324@id-556324.ilkley.irccloud.com> has joined #bitcoin-core-dev
1212022-05-30T12:14:44 <erwanor> Hey, I've been trying to find a design doc summarizing the different binary wallet formats / compatibility graph but so far no dice. Does anyone have a lead? if there isn't one, I'll try to write it myself (if you can point me to important release tags I should look at, that'd be extra cool!)
1222022-05-30T12:16:31 <sipa> there are two database formats (bdb and sqlite), and two type ways to encode "the set of watched addresses" in a wallet (legacy and descriptor). Old wallets are bdb/legacy, new wallets are sqlite/descriptor.
1232022-05-30T12:18:56 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net> has joined #bitcoin-core-dev
1242022-05-30T12:21:46 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
1252022-05-30T12:21:50 *** ronoaldo <ronoaldo!~ronoaldo@187.75.64.116> has joined #bitcoin-core-dev
1262022-05-30T12:24:04 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net> has quit IRC (Ping timeout: 272 seconds)
1272022-05-30T12:24:21 *** ronoaldo <ronoaldo!~ronoaldo@187.75.64.116> has quit IRC (Client Quit)
1282022-05-30T12:28:04 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 240 seconds)
1292022-05-30T12:31:11 *** bytes1440000 <bytes1440000!~bytes1440@garza.riseup.net> has joined #bitcoin-core-dev
1302022-05-30T12:32:52 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has quit IRC (Ping timeout: 260 seconds)
1312022-05-30T12:33:25 <bytes1440000> hebasto: I followed everything from https://github.com/bitcoin/bitcoin/blob/master/doc/build-android.md but still get the same error as shared by achow101 in https://github.com/bitcoin/bitcoin/issues/22522 when compiling with https://github.com/bitcoin/bitcoin/pull/22555
1322022-05-30T12:33:55 <bitcoin-git> [gui] hebasto opened pull request #611: test, refactor: Use the same shutdown path as in bitcoin-qt binary (master...220530-exec2) https://github.com/bitcoin-core/gui/pull/611
1332022-05-30T12:35:37 <hebasto> bytes1440000: could you post your exact steps in a pr comment?
1342022-05-30T12:36:10 <bytes1440000> Sure
1352022-05-30T12:36:13 <hebasto> ty
1362022-05-30T12:36:22 *** bytes1440000 <bytes1440000!~bytes1440@garza.riseup.net> has left #bitcoin-core-dev
1372022-05-30T12:37:44 *** ronoaldo <ronoaldo!~ronoaldo@187.75.64.116> has joined #bitcoin-core-dev
1382022-05-30T12:57:48 *** Guest6727 <Guest6727!~Guest67@197.210.54.229> has joined #bitcoin-core-dev
1392022-05-30T12:58:02 *** Guest6727 <Guest6727!~Guest67@197.210.54.229> has quit IRC (Client Quit)
1402022-05-30T13:01:50 *** ronoaldo <ronoaldo!~ronoaldo@187.75.64.116> has quit IRC (Ping timeout: 240 seconds)
1412022-05-30T13:03:08 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has joined #bitcoin-core-dev
1422022-05-30T13:08:19 *** ronoaldo <ronoaldo!~ronoaldo@200-171-83-35.dsl.telesp.net.br> has joined #bitcoin-core-dev
1432022-05-30T13:19:51 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
1442022-05-30T13:20:44 <luke-jr> 23.0 just isn't the version for release notes. I messed up and put Core's 23.0 notes in Knots instead >_<
1452022-05-30T13:23:45 *** ronoaldo <ronoaldo!~ronoaldo@200-171-83-35.dsl.telesp.net.br> has quit IRC (Ping timeout: 256 seconds)
1462022-05-30T13:51:03 *** z9z0b3t1c <z9z0b3t1c!~z9z0b3t1c@145.224.65.211> has quit IRC (Remote host closed the connection)
1472022-05-30T13:51:39 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
1482022-05-30T13:51:47 *** ronoaldo <ronoaldo!~ronoaldo@200-171-83-164.dsl.telesp.net.br> has joined #bitcoin-core-dev
1492022-05-30T13:52:39 <b10c> theStack: not sure if you've seen https://bip324.com/sections/code-review/ (RE https://github.com/bitcoin/bitcoin/pull/24545#issuecomment-1141148561) also not sure if that's up-to-date
1502022-05-30T13:52:53 <b10c> dhruv ^
1512022-05-30T13:53:19 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1522022-05-30T13:55:37 <bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/8779adbdda76...ad9e5eaf77bf
1532022-05-30T13:55:38 <bitcoin-git> bitcoin/master 318655c Jon Atack: Add missing references to signet in the release process
1542022-05-30T13:55:38 <bitcoin-git> bitcoin/master b4d2d74 Jon Atack: Release process: specify blockchain/chain_state units, reduce repetition
1552022-05-30T13:55:38 <bitcoin-git> bitcoin/master e538ead laanwj: Release process: exclude huge files for mainnet m_assumed_blockchain_size
1562022-05-30T13:55:43 <bitcoin-git> [bitcoin] laanwj merged pull request #24424: doc: release process chainparams updates (master...release-process-chainparams-updates) https://github.com/bitcoin/bitcoin/pull/24424
1572022-05-30T14:03:50 *** kouloumos <kouloumos!uid539228@id-539228.tinside.irccloud.com> has joined #bitcoin-core-dev
1582022-05-30T14:05:05 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
1592022-05-30T14:25:04 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 240 seconds)
1602022-05-30T14:27:06 <theStack> hebasto: Thanks for taking a look! To my understanding, the error should be thrown if coin selection / fee calculation fails due to not having enough funds to cover the fees (if "fSubtractFeeFromAmount" is not set). The simplest transaction I can think of is one that simply spends _all_ funds of a wallet. Not sure though if the GUI is allowing that, maybe there is no possibility and throwing `AmountWithFeeExceedsBalance` was already dead code b
1612022-05-30T14:27:06 <theStack> efore #20640 was merged.
1622022-05-30T14:27:10 <gribble> https://github.com/bitcoin/bitcoin/issues/20640 | wallet, refactor: return out-params of CreateTransaction() as optional struct by theStack · Pull Request #20640 · bitcoin/bitcoin · GitHub
1632022-05-30T14:27:45 *** mikehu44 <mikehu44!~quassel@gateway/vpn/pia/mikehu44-jc> has quit IRC (Ping timeout: 246 seconds)
1642022-05-30T14:28:06 <theStack> b10c: (RE BIP324 link) That seems to be very useful, thanks! Indeed I wasn't aware that there is a dedicated webpage for BIP324
1652022-05-30T14:29:24 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #25248: refactor: Add LIFETIMEBOUND / -Wdangling-gsl to Assert() (master...2205-assert-lifetime-ð) https://github.com/bitcoin/bitcoin/pull/25248
1662022-05-30T14:41:03 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 246 seconds)
1672022-05-30T14:43:18 *** furszy <furszy!~furszy@user/furszy> has joined #bitcoin-core-dev
1682022-05-30T14:50:20 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #25249: Bump univalue subtree (master...2205-univalue-ð) https://github.com/bitcoin/bitcoin/pull/25249
1692022-05-30T14:53:45 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net> has joined #bitcoin-core-dev
1702022-05-30T14:59:55 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ad9e5eaf77bf...269fa667f248
1712022-05-30T14:59:55 <bitcoin-git> bitcoin/master e93046c Daniela Brozzoni: MOVEONLY: Move signrawtransactionwithwallet test
1722022-05-30T14:59:55 <bitcoin-git> bitcoin/master e895900 Daniela Brozzoni: test: Use MiniWallet in rpc_rawtransaction.py
1732022-05-30T14:59:56 <bitcoin-git> bitcoin/master 269fa66 MacroFake: Merge bitcoin/bitcoin#25044: test: Use MiniWallet in rpc_rawtransaction.py
1742022-05-30T15:00:01 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25044: test: Use MiniWallet in rpc_rawtransaction.py (master...test_rawtransaction_miniwallet) https://github.com/bitcoin/bitcoin/pull/25044
1752022-05-30T15:10:35 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
1762022-05-30T15:19:21 <div72> laanwj: You're right, I've encountered the issue in a downstream where OpenSSL was still being used. The chances of this affecting Bitcoin is pretty slim as a wallet from a 7y old version which needs to be compiled with a pre 3 recent OpenSSL version is needed.
1772022-05-30T15:19:34 <div72> That's why I've come to ask instead of just making a PR.
1782022-05-30T15:20:46 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has quit IRC (Remote host closed the connection)
1792022-05-30T15:23:27 *** furszy <furszy!~furszy@user/furszy> has quit IRC (Ping timeout: 240 seconds)
1802022-05-30T15:23:52 *** furszy <furszy!~furszy@user/furszy> has joined #bitcoin-core-dev
1812022-05-30T15:36:22 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has joined #bitcoin-core-dev
1822022-05-30T15:37:47 <davidbakin> so that means someone with such a wallet can't in fact use a newer bitcoin core to read it?
1832022-05-30T15:40:27 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has quit IRC (Ping timeout: 240 seconds)
1842022-05-30T15:42:33 <sipa> it's not clear to me whether this is an issue for the bitcoin core codebase at all (includin historical versions)
1852022-05-30T15:42:43 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #25250: [22.x] test: replace hashlib.ripemd160 with an own implementation (22.x...2205-backport-ripemd160-ð¥) https://github.com/bitcoin/bitcoin/pull/25250
1862022-05-30T15:43:13 <sipa> there are certainly DER private key encodings that are valid but bitcoin core today wouldn't be able to parse, as it doesn't have a full DER parser
1872022-05-30T15:43:32 <sipa> but i believe that no version of bitcoin core (including very old ones) would emit such encodings
1882022-05-30T15:48:46 <div72> I am not sure on the exact conditions which can cause this, but pre-libsecp256k1 uses i2d_ECPrivateKey which can.
1892022-05-30T15:57:11 <sipa> Well, it didn't happen with Bitcoin Core versions from 2014 linked against OpenSSL from 2014 and before.
1902022-05-30T15:57:44 <sipa> And Bitcoin Core from back then cannot be used unmodified against today's OpenSSL's versions.
1912022-05-30T15:58:23 *** evanlinjin_ <evanlinjin_!~evanlinji@gateway/tor-sasl/evanlinjin> has joined #bitcoin-core-dev
1922022-05-30T15:58:28 <div72> Fair point.
1932022-05-30T15:59:48 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net> has quit IRC (Ping timeout: 276 seconds)
1942022-05-30T16:01:42 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
1952022-05-30T16:05:53 <laanwj> "This repository contains Python scripts for allele-specific mapping. They were used to map ATAC-seq, RNA-seq and Hi-C reads in a mouse" heh apparently there's another "asmap" project on github with a quite different purpose
1962022-05-30T16:06:31 <sipa> Sorry, I'm not good at naming things.
1972022-05-30T16:06:32 <sipa> ;(
1982022-05-30T16:07:01 <laanwj> it would be hard to confuse them!
1992022-05-30T16:07:54 <sipa> I recently discovered that the code we were using to gather BGP dumps to extract ASN mapping data from was accessing the archive using "latest" file names rather than date-based ones.
2002022-05-30T16:08:10 <sipa> Now, some of the collectors in the archive have been offline for a while.
2012022-05-30T16:08:23 <sipa> Which meant that those "latest" dumps were in some cases from 2004.
2022022-05-30T16:08:51 <sipa> Dropping those reduced the resulting compressed asmap file size by 300 kB.
2032022-05-30T16:09:33 <sipa> e.g. https://data.ris.ripe.net/rrc08/
2042022-05-30T16:11:18 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
2052022-05-30T16:12:05 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net> has joined #bitcoin-core-dev
2062022-05-30T16:13:41 *** ubba <ubba!uid552050@user/ubba> has joined #bitcoin-core-dev
2072022-05-30T16:15:47 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 255 seconds)
2082022-05-30T16:27:37 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2092022-05-30T16:32:20 *** furszy <furszy!~furszy@user/furszy> has quit IRC ()
2102022-05-30T16:39:34 *** evanlinjin_ <evanlinjin_!~evanlinji@gateway/tor-sasl/evanlinjin> has quit IRC (Ping timeout: 240 seconds)
2112022-05-30T16:41:04 <theStack> bip324 question about handshake: in older slides (from breaking bitcoin 2019) i saw it was proposed that only odd pubkeys (i.e. starting with 0x03) are allowed, but the current BIP states only even pubkeys (i.e. starting with 0x02) are. any specific reason for this change?
2122022-05-30T16:42:12 <sipa> which spec draft are you looking at?
2132022-05-30T16:42:41 <theStack> https://gist.github.com/dhruv/5b1275751bc98f3b64bcafce7876b489 (not sure if that's the right one)
2142022-05-30T16:42:53 <sipa> the latest spec we're working on used elligator squared pubkeys, which are 64 byte uniform
2152022-05-30T16:43:34 <sipa> but that may not be published yet
2162022-05-30T16:46:48 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has joined #bitcoin-core-dev
2172022-05-30T16:47:19 <theStack> sipa: thanks, good to know. that explains why there are PRs around implementing elligator squared pubkeys (both in secp256k1 and bitcoin core), but no mention of it in the (obviously outdated) spec i read
2182022-05-30T16:51:07 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has quit IRC (Ping timeout: 240 seconds)
2192022-05-30T16:52:43 *** ronoaldo <ronoaldo!~ronoaldo@200-171-83-164.dsl.telesp.net.br> has quit IRC (Quit: Konversation terminated!)
2202022-05-30T16:55:32 *** ronoaldo <ronoaldo!~ronoaldo@200-171-83-164.dsl.telesp.net.br> has joined #bitcoin-core-dev
2212022-05-30T16:55:54 *** ronoaldo <ronoaldo!~ronoaldo@200-171-83-164.dsl.telesp.net.br> has quit IRC (Client Quit)
2222022-05-30T16:56:20 *** bitcoinboi <bitcoinboi!~Jason@098-147-176-043.res.spectrum.com> has joined #bitcoin-core-dev
2232022-05-30T16:56:43 *** ronoaldo <ronoaldo!~ronoaldo@200-171-83-164.dsl.telesp.net.br> has joined #bitcoin-core-dev
2242022-05-30T17:00:24 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
2252022-05-30T17:08:28 <sipa> @theStack So elligator square is an encoding for public keys that encodes points as 64-byte, but *every* 64 byte sequence corresponds to a point, and the encoder picks a random one. So the result is that you get bytes that are indistinguishable from uniform.
2262022-05-30T17:09:37 <sipa> I have a writeup on the implementation/math here: https://github.com/sipa/writeups/tree/main/elligator-square-for-bn
2272022-05-30T17:15:59 <theStack> sipa: so if i understand this correctly, we want the p2p-v2 handshake messages to look like an uniform byte string in order to disguise the fact that a (ecdh) handshake is happening in the first place?
2282022-05-30T17:16:14 <sipa> exactly!
2292022-05-30T17:17:04 <theStack> wouldn't an observer still have a high chance of concluding this by the fact that the messages have exactly 64 bytes in size?
2302022-05-30T17:20:57 <sipa> well after that the rest of the protocol follows, which also sends bytes indistinguishable from uniform
2312022-05-30T17:21:21 <sipa> there may be some information that can be inferred from timing and tcp boundaries
2322022-05-30T17:21:39 <sipa> but tcp doesn't have a concept of messages per se
2332022-05-30T17:24:22 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
2342022-05-30T17:25:02 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
2352022-05-30T17:30:02 *** donor <donor!~donor@157.34.159.173> has joined #bitcoin-core-dev
2362022-05-30T17:32:08 <theStack> right. though i'd assume that in a packet analyzer (like tcpdump or wireshark) one would see the initial pubkeys as messages of 64 bytes (given that we an observation spot both routes from A->B and B->A pass through), no?
2372022-05-30T17:32:19 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
2382022-05-30T17:32:28 <theStack> (if not, then nevermind, i heave to read up on tcp/ip again :D)
2392022-05-30T17:35:42 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
2402022-05-30T17:39:54 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 246 seconds)
2412022-05-30T17:42:23 <sipa> you'd see a 64 byte message in one direction, then a 64+N message in the other direction (because it'll be a concatenation of the ECDH response + the next part of the protocol that follows)
2422022-05-30T17:44:07 <bitcoin-git> [gui] hebasto opened pull request #612: refactor: Drop unused `QFrame`s in `SendCoinsEntry` (master...220530-sendcoins) https://github.com/bitcoin-core/gui/pull/612
2432022-05-30T17:47:59 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 23.x: https://github.com/bitcoin/bitcoin/compare/fcf6c8f4eb21...c3936cc53dab
2442022-05-30T17:48:00 <bitcoin-git> bitcoin/23.x 7fcac96 Martin Zumsande: rpc: Capture potentially large UniValue by ref for rpcdoccheck
2452022-05-30T17:48:00 <bitcoin-git> bitcoin/23.x c3936cc laanwj: Merge bitcoin/bitcoin#25241: [23.x] rpc: Capture potentially large UniValu...
2462022-05-30T17:48:01 <bitcoin-git> [bitcoin] laanwj merged pull request #25241: [23.x] rpc: Capture potentially large UniValue by ref for rpcdoccheck (23.x...2205-uni-no-copy-ð) https://github.com/bitcoin/bitcoin/pull/25241
2472022-05-30T17:48:22 <bitcoin-git> [bitcoin] laanwj pushed 2 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/04fdd644b43a...34cb63e89597
2482022-05-30T17:48:23 <bitcoin-git> bitcoin/22.x 7fcac96 Martin Zumsande: rpc: Capture potentially large UniValue by ref for rpcdoccheck
2492022-05-30T17:48:24 <bitcoin-git> bitcoin/22.x 34cb63e laanwj: Merge bitcoin/bitcoin#25242: [22.x] rpc: Capture potentially large UniValu...
2502022-05-30T17:48:24 <bitcoin-git> [bitcoin] laanwj merged pull request #25242: [22.x] rpc: Capture potentially large UniValue by ref for rpcdoccheck (22.x...2205-uni-no-copy-ð) https://github.com/bitcoin/bitcoin/pull/25242
2512022-05-30T17:52:13 *** Guest18 <Guest18!~Guest18@105.112.185.248> has joined #bitcoin-core-dev
2522022-05-30T17:53:42 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
2532022-05-30T17:55:17 *** Guest18 <Guest18!~Guest18@105.112.185.248> has quit IRC (Client Quit)
2542022-05-30T17:55:25 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
2552022-05-30T17:56:05 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Client Quit)
2562022-05-30T17:57:49 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has joined #bitcoin-core-dev
2572022-05-30T17:58:51 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
2582022-05-30T18:01:45 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 244 seconds)
2592022-05-30T18:12:53 <laanwj> sipa: oops, good find, yes it's good to have a smaller file and i doubt that including data from 2004 was at all helpful
2602022-05-30T18:13:32 *** donor <donor!~donor@157.34.159.173> has quit IRC (Ping timeout: 258 seconds)
2612022-05-30T18:14:42 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net> has quit IRC (Ping timeout: 260 seconds)
2622022-05-30T18:28:04 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net> has joined #bitcoin-core-dev
2632022-05-30T18:28:46 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
2642022-05-30T18:30:25 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
2652022-05-30T18:32:50 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 240 seconds)
2662022-05-30T18:35:04 *** javi404 <javi404!~quassel@pool-173-63-15-246.nwrknj.fios.verizon.net> has quit IRC (Ping timeout: 248 seconds)
2672022-05-30T18:38:36 <theStack> sipa: i would have expected that the node initiating the handshake is also the one sending the next part of the protocol first (likely, a version message?), and one could see 64 byte messages in both directions
2682022-05-30T18:42:24 <sipa> @theStack That'd be gratuitously adding a (half) roundtrip. The responder can do the next step instead (indeed, a version message) first, avoiding the need for waiting for the message to be received.
2692022-05-30T18:43:13 <sipa> In any case, there is definitely still identifying information in the sizes and pattern of traffic sent. But it's not nearly as detectable as looking for certain magic bytes anymore.
2702022-05-30T18:51:25 <theStack> combining the handshake reponse with the version message seems like a good idea, wasn't aware that this is planned to be implemented that way (maybe it isn't yet, i will in any case keep that in the back of my head for reviewing concrete PRs)
2712022-05-30T18:54:11 <sipa> @theStack Oh, this isn't the *bitcoin* version message, but the version of the transport protocol I'm talking about.
2722022-05-30T18:54:31 <sipa> I don't know to what extent all these things are reflected in the spec and the implementation. The spec might not even have this versioning messge at all yet.
2732022-05-30T18:54:44 <theStack> and yes, agree that with elligator square identifying is harder. i was wondering if it's worth it to add random sized data to the initial handshake to make it even harder (but probably not)
2742022-05-30T18:55:07 <theStack> sipa: oh! i guess it definitely makes sense to wait for the new spec then :)
2752022-05-30T19:00:31 <sipa> @theStack It's not a crazy idea, but the problem is that it can't actually be random. There is no shared secret established yet, so whatever size of stuffing is chosen, if it is to be skippable by the other party, it will also have to be known to third parties.
2762022-05-30T19:01:42 <sipa> So we could decide to change it from 64 to say 256 bytes, and send part before and part after the first message by the other side.
2772022-05-30T19:02:02 <sipa> But that would mean a fixed 192 bytes wasted, and leads to questions like how much waste is acceptable etc
2782022-05-30T19:02:39 <instagibbs> does core currently have issues with computing bip125 inherited signaling? Lost track of this
2792022-05-30T19:04:17 <theStack> i see. at least the waste argument shouldn't matter though, considering we are talking about messages that are only sent once at the beginning of a connection?
2802022-05-30T19:04:46 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
2812022-05-30T19:05:27 <sipa> right... but if you pick e.g. 256 bytes, you've only introduced a variability of the first message size between 64 and 256; if you can observe many messages, and the first message is always within that range, you arguably still learn something
2822022-05-30T19:05:42 <sipa> so how much is enough? 256 bytes? 4 kilobytes? 1 megabyte?
2832022-05-30T19:06:16 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
2842022-05-30T19:06:30 <sipa> maybe it's worth having some bikeshedding over after publishing
2852022-05-30T19:07:18 <theStack> yeah, good question, how to pick the range
2862022-05-30T19:08:32 <_aj_> instagibbs: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-31876 ; i don't think it's fixed?
2872022-05-30T19:09:02 <theStack> also sending messages with a random size just feels like a strange thing to do (not sure if there are any wide-known protocols doing this)
2882022-05-30T19:09:09 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 246 seconds)
2892022-05-30T19:09:36 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has joined #bitcoin-core-dev
2902022-05-30T19:09:54 <instagibbs> _aj_, https://github.com/bitcoin/bitcoin/issues/22028 dun dun dunn
2912022-05-30T19:09:56 *** Guest78 <Guest78!~Guest78@84-112-57-216.cable.dynamic.surfer.at> has joined #bitcoin-core-dev
2922022-05-30T19:10:55 <instagibbs> oh, purple made it seem like "merge", this is the only place I can find the issue
2932022-05-30T19:12:21 <_aj_> you want a /pull/ url for merge to be an option? :)
2942022-05-30T19:18:10 <bitcoin-git> [bitcoin] fanquake opened pull request #25251: Consolidate Windows ASLR workarounds for upstream secp256k1 changes (master...libsecp256k1_no_more_static_export) https://github.com/bitcoin/bitcoin/pull/25251
2952022-05-30T19:20:35 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net> has quit IRC (Remote host closed the connection)
2962022-05-30T19:20:43 *** Guest78 <Guest78!~Guest78@84-112-57-216.cable.dynamic.surfer.at> has quit IRC (Quit: Client closed)
2972022-05-30T19:20:50 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net> has joined #bitcoin-core-dev
2982022-05-30T19:34:14 <bitcoin-git> [gui] hebasto merged pull request #609: wallet, refactor: Drop unused `WalletModel::PaymentRequestExpired` (master...220529-expired) https://github.com/bitcoin-core/gui/pull/609
2992022-05-30T19:34:15 <bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/269fa667f248...b9ef5a10e2fa
3002022-05-30T19:34:16 <bitcoin-git> bitcoin/master 151009c Hennadii Stepanov: qt, wallet, refactor: Drop unused `WalletModel::PaymentRequestExpired`
3012022-05-30T19:34:16 <bitcoin-git> bitcoin/master b9ef5a1 Hennadii Stepanov: Merge bitcoin-core/gui#609: wallet, refactor: Drop unused `WalletModel::Pa...
3022022-05-30T20:03:41 *** ___nick___ <___nick___!~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net> has quit IRC (Ping timeout: 244 seconds)
3032022-05-30T20:11:37 *** Saloframes <Saloframes!~Saloframe@user/Saloframes> has quit IRC (Quit: Leaving)
3042022-05-30T20:35:33 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
3052022-05-30T20:39:30 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC (Client Quit)
3062022-05-30T20:53:25 *** kouloumos <kouloumos!uid539228@id-539228.tinside.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
3072022-05-30T20:55:19 <bitcoin-git> [bitcoin] brunoerg opened pull request #25253: test: add coverage for non-hex value to -minimumchainwork (master...2022-05-minimumchainwork-nonhex) https://github.com/bitcoin/bitcoin/pull/25253
3082022-05-30T20:58:37 *** bitcoinboi <bitcoinboi!~Jason@098-147-176-043.res.spectrum.com> has quit IRC (Quit: WeeChat 3.2)
3092022-05-30T21:00:27 *** Saloframes <Saloframes!~Saloframe@user/Saloframes> has joined #bitcoin-core-dev
3102022-05-30T21:40:18 *** emcy <emcy!~emcy@user/emcy> has quit IRC (Quit: Leaving)
3112022-05-30T21:40:41 *** emcy <emcy!~emcy@user/emcy> has joined #bitcoin-core-dev
3122022-05-30T21:48:08 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
3132022-05-30T22:00:17 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹÑа!)
3142022-05-30T22:11:52 *** z9z0b3t1c <z9z0b3t1c!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has joined #bitcoin-core-dev
3152022-05-30T22:15:17 *** z9z0b3t1_ <z9z0b3t1_!z9z0b3t1c@gateway/vpn/protonvpn/z9z0b3t1c> has quit IRC (Ping timeout: 256 seconds)
3162022-05-30T22:37:46 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 272 seconds)
3172022-05-30T22:55:43 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
3182022-05-30T22:56:08 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 272 seconds)
3192022-05-30T23:13:39 *** javi404 <javi404!~quassel@2001:470:1f07:298:bbc3:e231:c6b5:16f9> has joined #bitcoin-core-dev
3202022-05-30T23:20:16 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:c1e:eba7:fa28:1e61> has quit IRC (Remote host closed the connection)
3212022-05-30T23:23:11 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470> has joined #bitcoin-core-dev
3222022-05-30T23:24:29 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470> has quit IRC (Remote host closed the connection)
3232022-05-30T23:30:06 *** ronoaldo <ronoaldo!~ronoaldo@200-171-83-164.dsl.telesp.net.br> has quit IRC (Remote host closed the connection)
3242022-05-30T23:30:52 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net> has quit IRC (Remote host closed the connection)
3252022-05-30T23:32:15 *** ronoaldo <ronoaldo!~ronoaldo@200-171-83-164.dsl.telesp.net.br> has joined #bitcoin-core-dev
3262022-05-30T23:39:56 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470> has joined #bitcoin-core-dev
3272022-05-30T23:44:52 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:bdd7:5f7c:80d:1470> has quit IRC (Ping timeout: 260 seconds)
3282022-05-30T23:46:32 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net> has joined #bitcoin-core-dev
3292022-05-30T23:58:36 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@wsip-98-190-210-152.oc.oc.cox.net> has quit IRC (Ping timeout: 246 seconds)