12022-07-20T00:01:04 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Quit: Leaving...)
22022-07-20T00:05:11 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca> has joined #bitcoin-core-dev
32022-07-20T00:06:44 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
42022-07-20T00:06:45 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
52022-07-20T00:10:38 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
62022-07-20T00:12:02 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
72022-07-20T00:14:46 *** test_ <test_!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
82022-07-20T00:17:35 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Ping timeout: 268 seconds)
92022-07-20T00:22:27 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:b9c0:1f6e:6823:c082> has quit IRC (Ping timeout: 276 seconds)
102022-07-20T00:31:52 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca> has quit IRC (Remote host closed the connection)
112022-07-20T00:33:19 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca> has joined #bitcoin-core-dev
122022-07-20T00:39:58 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
132022-07-20T00:40:18 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca> has quit IRC (Ping timeout: 255 seconds)
142022-07-20T00:59:10 *** roconnor <roconnor!~roconnor@coq/roconnor> has quit IRC (Ping timeout: 240 seconds)
152022-07-20T01:05:51 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has joined #bitcoin-core-dev
162022-07-20T01:06:26 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca> has joined #bitcoin-core-dev
172022-07-20T01:16:09 *** test__ <test__!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
182022-07-20T01:20:33 *** test_ <test_!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Ping timeout: 268 seconds)
192022-07-20T01:22:09 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
202022-07-20T01:27:30 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
212022-07-20T01:27:57 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca> has quit IRC (Remote host closed the connection)
222022-07-20T01:40:04 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has quit IRC (Remote host closed the connection)
232022-07-20T01:40:31 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has joined #bitcoin-core-dev
242022-07-20T01:45:10 *** aurele <aurele!~aurele@82-64-162-213.subs.proxad.net> has quit IRC (Ping timeout: 240 seconds)
252022-07-20T01:47:15 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has quit IRC (Ping timeout: 260 seconds)
262022-07-20T02:01:30 *** zxrqmz88 <zxrqmz88!~private@2603-7000-1302-b6f3-300f-f968-ac52-6133.res6.spectrum.com> has joined #bitcoin-core-dev
272022-07-20T02:02:06 *** zxrqmz88 <zxrqmz88!~private@2603-7000-1302-b6f3-300f-f968-ac52-6133.res6.spectrum.com> has quit IRC (Remote host closed the connection)
282022-07-20T02:02:24 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
292022-07-20T02:03:37 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
302022-07-20T02:05:56 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
312022-07-20T02:12:31 *** zxrqmz88 <zxrqmz88!~private@2603-7000-1302-b6f3-300f-f968-ac52-6133.res6.spectrum.com> has joined #bitcoin-core-dev
322022-07-20T02:17:35 *** PaperSword <PaperSword!~qrsnap@50.126.96.22> has quit IRC (Ping timeout: 260 seconds)
332022-07-20T02:22:23 *** zxrqmz88 <zxrqmz88!~private@2603-7000-1302-b6f3-300f-f968-ac52-6133.res6.spectrum.com> has quit IRC (Quit: Quit)
342022-07-20T03:10:52 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 268 seconds)
352022-07-20T03:11:20 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has joined #bitcoin-core-dev
362022-07-20T03:15:38 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has quit IRC (Ping timeout: 240 seconds)
372022-07-20T03:17:31 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
382022-07-20T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
392022-07-20T04:01:42 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
402022-07-20T04:20:38 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 240 seconds)
412022-07-20T04:22:41 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
422022-07-20T04:27:20 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 268 seconds)
432022-07-20T04:40:08 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has joined #bitcoin-core-dev
442022-07-20T05:19:54 *** zeropoint <zeropoint!~alex@c-67-169-157-130.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
452022-07-20T05:22:23 *** zeropoint <zeropoint!~alex@c-67-169-157-130.hsd1.ca.comcast.net> has quit IRC (Client Quit)
462022-07-20T05:43:18 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has quit IRC (Ping timeout: 240 seconds)
472022-07-20T05:45:12 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has joined #bitcoin-core-dev
482022-07-20T05:51:03 <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/5560682a4464...0897b189e424
492022-07-20T05:51:03 <bitcoin-git> bitcoin/master 3b91d4b Russell Yanofsky: refactor: Reduce number of LoadChainstate parameters
502022-07-20T05:51:03 <bitcoin-git> bitcoin/master b3e7de7 Russell Yanofsky: refactor: Reduce number of LoadChainstate return values
512022-07-20T05:51:03 <bitcoin-git> bitcoin/master 6db6552 Ryan Ofsky: refactor: Reduce number of SanityChecks return values
522022-07-20T05:51:08 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25308: refactor: Reduce number of LoadChainstate parameters and return values (master...pr/retcode) https://github.com/bitcoin/bitcoin/pull/25308
532022-07-20T06:35:48 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Ping timeout: 272 seconds)
542022-07-20T06:50:00 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has quit IRC (Ping timeout: 260 seconds)
552022-07-20T06:56:00 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has joined #bitcoin-core-dev
562022-07-20T07:00:54 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has quit IRC (Ping timeout: 276 seconds)
572022-07-20T07:04:44 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
582022-07-20T07:05:24 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
592022-07-20T07:06:07 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has joined #bitcoin-core-dev
602022-07-20T07:08:11 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
612022-07-20T07:55:02 <bitcoin-git> [bitcoin] S3RK opened pull request #25647: wallet: return change from SelectionResult (master...coin_selection_get_change) https://github.com/bitcoin/bitcoin/pull/25647
622022-07-20T07:55:13 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
632022-07-20T08:05:21 *** brunoerg <brunoerg!~brunoerg@187.183.43.40> has quit IRC (Ping timeout: 255 seconds)
642022-07-20T08:07:12 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has joined #bitcoin-core-dev
652022-07-20T08:11:18 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has quit IRC (Ping timeout: 240 seconds)
662022-07-20T08:13:16 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has joined #bitcoin-core-dev
672022-07-20T08:32:30 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0897b189e424...895937edb2cc
682022-07-20T08:32:30 <bitcoin-git> bitcoin/master 6666803 MacroFake: streams: Add AutoFile without ser-type and ser-version
692022-07-20T08:32:30 <bitcoin-git> bitcoin/master facc2fa MacroFake: Use AutoFile where possible
702022-07-20T08:32:30 <bitcoin-git> bitcoin/master 895937e fanquake: Merge bitcoin/bitcoin#25285: Add AutoFile without ser-type and ser-version...
712022-07-20T08:32:35 <bitcoin-git> [bitcoin] fanquake merged pull request #25285: Add AutoFile without ser-type and ser-version and use it where possible (master...2206-autofile-ð) https://github.com/bitcoin/bitcoin/pull/25285
722022-07-20T08:36:27 *** Cory <Cory!~Cory@user/pasha> has joined #bitcoin-core-dev
732022-07-20T08:37:37 <fanquake> Google signaling it's abandonment of leveldb: https://github.com/google/leveldb/commit/7b650f85de0b785596cc145a3dd28a54cb73bb50
742022-07-20T08:38:06 <fanquake> I think the likelyhood of us getting PRs merged upstream is approaching zero
752022-07-20T08:41:48 <_aj_> yay google
762022-07-20T08:44:06 <laanwj> assuming we don't want to look for a replacement, may be another thing to fuse and dissolve over time like univalue
772022-07-20T08:46:30 <laanwj> at some point we experimented using sqlite for the utxo db and it was noticably slower (especially updates), also it may be risky from a consensus point of view to switch it
782022-07-20T08:51:20 *** emcy_ <emcy_!~emcy@user/emcy> has joined #bitcoin-core-dev
792022-07-20T08:52:17 *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has quit IRC (Read error: Connection reset by peer)
802022-07-20T08:52:42 *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has joined #bitcoin-core-dev
812022-07-20T08:52:44 *** Eric3 <Eric3!~exeric3@dbox.miners-zone.net> has joined #bitcoin-core-dev
822022-07-20T08:52:53 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has quit IRC (Remote host closed the connection)
832022-07-20T08:53:04 *** darosior6 <darosior6!~darosior@194.36.189.246> has joined #bitcoin-core-dev
842022-07-20T08:53:38 *** lowhope <lowhope!~lowhope@2602:fffa:fff:108a:0:16:3e86:c70e> has quit IRC (Ping timeout: 240 seconds)
852022-07-20T08:54:01 *** koolazer <koolazer!~koo@user/koolazer> has quit IRC (Ping timeout: 256 seconds)
862022-07-20T08:54:02 *** darosior <darosior!~darosior@194.36.189.246> has quit IRC (Ping timeout: 256 seconds)
872022-07-20T08:54:02 *** darosior6 is now known as darosior
882022-07-20T08:54:35 *** emcy <emcy!~emcy@user/emcy> has quit IRC (Ping timeout: 256 seconds)
892022-07-20T08:54:36 *** ExEric3 <ExEric3!~exeric3@dbox.miners-zone.net> has quit IRC (Ping timeout: 256 seconds)
902022-07-20T08:54:36 *** infernix <infernix!nix@spirit.infernix.net> has quit IRC (Ping timeout: 256 seconds)
912022-07-20T08:56:08 *** koolazer <koolazer!~koo@user/koolazer> has joined #bitcoin-core-dev
922022-07-20T08:56:27 *** lowhope <lowhope!~lowhope@2602:fffa:fff:108a:0:16:3e86:c70e> has joined #bitcoin-core-dev
932022-07-20T08:57:01 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has joined #bitcoin-core-dev
942022-07-20T08:57:02 *** ChanServ sets mode: +o gribble
952022-07-20T09:02:57 *** kexkey <kexkey!~kexkey@178.249.214.23> has quit IRC (Ping timeout: 255 seconds)
962022-07-20T09:04:06 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
972022-07-20T09:05:41 *** kexkey <kexkey!~kexkey@static-198-54-132-138.cust.tzulo.com> has joined #bitcoin-core-dev
982022-07-20T09:17:26 *** infernix <infernix!nix@spirit.infernix.net> has joined #bitcoin-core-dev
992022-07-20T09:18:47 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has quit IRC (Remote host closed the connection)
1002022-07-20T09:19:45 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has joined #bitcoin-core-dev
1012022-07-20T09:19:45 *** ChanServ sets mode: +o gribble
1022022-07-20T09:21:33 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has quit IRC (Ping timeout: 268 seconds)
1032022-07-20T09:27:31 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has joined #bitcoin-core-dev
1042022-07-20T09:28:32 *** Guest92 <Guest92!~Guest92@103.82.4.244> has joined #bitcoin-core-dev
1052022-07-20T09:29:49 *** Guest92 <Guest92!~Guest92@103.82.4.244> has quit IRC (Client Quit)
1062022-07-20T09:59:52 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
1072022-07-20T10:14:09 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1082022-07-20T10:31:38 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has quit IRC (Ping timeout: 240 seconds)
1092022-07-20T10:40:48 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has joined #bitcoin-core-dev
1102022-07-20T11:43:09 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has quit IRC (Ping timeout: 255 seconds)
1112022-07-20T11:44:51 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:799b:1288:ff0f:633e> has joined #bitcoin-core-dev
1122022-07-20T11:55:46 <jonatack> noticed that CI tasks that time out are now signaled as "neutral" rather than failing, nice
1132022-07-20T12:12:13 <vasild> I guess a custom in-house replacement of leveldb can be created that is both faster and smaller (src/leveldb is 30k lines)
1142022-07-20T12:12:32 <sipa> I very much doubt that.
1152022-07-20T12:12:37 <fanquake> yea very unlikely
1162022-07-20T12:13:17 <vasild> That is a provocation!
1172022-07-20T12:13:40 <vasild> but anyway, maintenance cost will be much higher than present which is close to zero
1182022-07-20T12:13:42 <sipa> Creating something functional is one thing, but having it work reliably on many platforms is one challenge, and just gaining enough confidence that it works would be one hell of a job.
1192022-07-20T12:14:28 <sipa> RocksDB is still being maintained.
1202022-07-20T12:14:30 <vasild> true
1212022-07-20T12:14:31 <sipa> Which started as a fork of LevelDB.
1222022-07-20T12:15:44 <vasild> IMO maintenace cost trumps speed, unless the in-house one is times faster, but I guess that is not likely
1232022-07-20T12:17:26 <fanquake> Maybe first figure out if leveldb is "slow", before worrying about writing something in house that is "faster"
1242022-07-20T12:18:43 <TheCharlatan> laanwj didn't you do benchmarks with lmdb as well? IIRC leveldb was faster in those.
1252022-07-20T12:19:05 <sipa> IIRC we benchmarked sqlite at some point, which is enormously slower.
1262022-07-20T12:19:32 <sipa> lmdb we discarded as an option as it only realistically worked on 64-bit systems IIRC
1272022-07-20T12:20:02 <_aj_> on disk format is platform dependent, apparently?
1282022-07-20T12:20:14 <sipa> Right; that too.
1292022-07-20T12:21:14 <TheCharlatan> it was discussed here for the wallet db format: https://github.com/bitcoin/bitcoin/issues/18916#issuecomment-670132247
1302022-07-20T12:25:00 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
1312022-07-20T12:25:31 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1322022-07-20T12:31:29 <sipa> The benchmarking with other database layers for the chainstate was much earlier... maybe 2015-2016 somewhere.
1332022-07-20T12:31:34 <_aj_> rocksdb doesn't sound terrible?
1342022-07-20T12:31:50 <josie[m]> fwiw, i have noticed rocksDB popping up in a lot of other open source projects. seems to be gaining adoption
1352022-07-20T12:32:22 <_aj_> https://pastebin.com/raw/evx62gak was jonasschnelli's reindex test for lmdb with laanwj's patches i think?
1362022-07-20T12:32:37 <sipa> I'd need to look into it, but it being a fork of LevelDB, with a number of improvements over it, and actively maintained it seems, may make most sense.
1372022-07-20T12:35:09 <vasild> +1 and probably easiest to transition to, I guess, if it has same or similar api
1382022-07-20T12:37:14 <TheCharlatan> _aj_ yes, that was the one I was looking for.
1392022-07-20T12:37:41 *** Guest60 <Guest60!~Guest60@60.241.9.31> has joined #bitcoin-core-dev
1402022-07-20T12:39:12 <vasild> what is the downside of having the db library as an external dependency instead of in src/? We cannot patch it (do we need to)? Users have to install it separately? Is that really a problem if it is something like "apt install rocksdb"? they already have to install other stuff too, e.g. sqlite
1412022-07-20T12:41:11 *** Guest60 <Guest60!~Guest60@60.241.9.31> has quit IRC (Client Quit)
1422022-07-20T12:41:55 <sipa> It depends on the use case, but for LevelDB I think there are two main ones: (a) we have our own fork of LevelDB already with a few patches (for a while this was needed to get windows support, though that later changed), and (b) the UTXO database is so consensus critical that if a bug were to be found in it, we may be forced to perpetuate the bug (until it can be changed through a coordinated consensus rule change)
1432022-07-20T12:46:47 <vasild> (b)
1442022-07-20T12:48:58 <josie[m]> iinm, doesn't electrs use rocksdb? might be worth asking if they have any complaints with it. im sure the use cases for the db are very different, but there could be some overlap and some insights from them
1452022-07-20T12:53:09 *** Guest56 <Guest56!~Guest56@124-182-146-85.ftth.glasoperator.nl> has joined #bitcoin-core-dev
1462022-07-20T12:53:49 *** Guest56 <Guest56!~Guest56@124-182-146-85.ftth.glasoperator.nl> has quit IRC (Client Quit)
1472022-07-20T12:57:16 <sipa> Also... it doesn't look like LevelDB is dead.
1482022-07-20T12:57:50 <sipa> Just a "critical maintenance only" state, which probably doesn't predict much good for its long-term future, but on the other hand... it does just work.
1492022-07-20T12:59:08 <fanquake> Yea, and we've patched a few things we need in our subtree already, like c++20 support
1502022-07-20T12:59:38 <fanquake> I cannot imagine we're ever going to end up in a state were users apt install leveldb/rocks/db/whatever
1512022-07-20T12:59:55 <fanquake> That sounds terrible.
1522022-07-20T13:00:41 <sipa> fanquake vasild There is also a big difference between subtree vs compile-time dependency on the one hand, and compiled-in vs runtime dependency on the other hand.
1532022-07-20T13:00:56 <sipa> I have the impression we're conflating them.
1542022-07-20T13:01:14 <sipa> sqlite is a compile-time dependency but not a runtime dependency
1552022-07-20T13:01:48 <fanquake> sqlite is also not required to use bitcoind
1562022-07-20T13:01:57 <_aj_> sipa: ? my bitcoind is dynamically linked to libsqlite3.so.0?
1572022-07-20T13:02:27 <Earnestly> (If users were able to install leveldb/rock/db/whatever it would imply that bitcoin-core has matured enough to decouple the db from consensus
1582022-07-20T13:02:32 <fanquake> if anything i hope we continue to reduce the runtime dependencies in our release binaries
1592022-07-20T13:02:34 <sipa> _aj_: Oh, only in release build then I guess.
1602022-07-20T13:02:44 <_aj_> sipa: ah, sure
1612022-07-20T13:09:02 *** OneLzx <OneLzx!~OneLzx@141.164.59.188> has joined #bitcoin-core-dev
1622022-07-20T13:10:32 *** OneLzx <OneLzx!~OneLzx@141.164.59.188> has quit IRC (Client Quit)
1632022-07-20T13:11:47 <vasild> sipa: I was talking about subtree vs compile-time dependency. That is - not include it in our source code, but ask users to have it installed separtely (like sqlite) then it can be dynamically linked, meaning it is needed at runtime too or statically linked, meaning no need to have an external libfoodb.so all the time. But I think (b) just means it is best to have it in a subtree
1642022-07-20T13:12:42 <vasild> well, actually subtree library can also be statically or dynamically linked
1652022-07-20T13:19:50 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
1662022-07-20T13:25:06 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #25648: refactor: Remove ::fRequireStandard global (master...2207-burn-globals-ð¶) https://github.com/bitcoin/bitcoin/pull/25648
1672022-07-20T13:29:32 <bitcoin-git> [bitcoin] Chres-SC opened pull request #25649: Src crypto (master...src_crypto) https://github.com/bitcoin/bitcoin/pull/25649
1682022-07-20T13:29:41 <bitcoin-git> [bitcoin] fanquake closed pull request #25649: Src crypto (master...src_crypto) https://github.com/bitcoin/bitcoin/pull/25649
1692022-07-20T13:30:57 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/895937edb2cc...1eedde157f2e
1702022-07-20T13:30:58 <bitcoin-git> bitcoin/master fa32b1b MacroFake: refactor: Use chainman() helper consistently in ChainImpl
1712022-07-20T13:30:58 <bitcoin-git> bitcoin/master 1eedde1 MacroFake: Merge bitcoin/bitcoin#25638: refactor: Use chainman() helper consistently ...
1722022-07-20T13:31:04 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25638: refactor: Use chainman() helper consistently in ChainImpl (master...2207-chainman-ð) https://github.com/bitcoin/bitcoin/pull/25638
1732022-07-20T13:32:41 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
1742022-07-20T13:47:35 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Quit: 404)
1752022-07-20T13:47:55 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
1762022-07-20T13:48:26 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Client Quit)
1772022-07-20T13:48:52 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
1782022-07-20T13:50:35 *** kouloumos <kouloumos!uid539228@id-539228.tinside.irccloud.com> has joined #bitcoin-core-dev
1792022-07-20T13:52:45 <bitcoin-git> [bitcoin] MarcoFalke pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/1eedde157f2e...5c82ca3365f6
1802022-07-20T13:52:45 <bitcoin-git> bitcoin/master cc7b2fd fanquake: refactor: move compat.h into compat/
1812022-07-20T13:52:45 <bitcoin-git> bitcoin/master 7c3df5e fanquake: compat: document FD_SETSIZE redefinition for WIN32
1822022-07-20T13:52:45 <bitcoin-git> bitcoin/master b63ddb7 fanquake: compat: remove unused WSA* definitions
1832022-07-20T13:52:48 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25493: compat: document code in compat.h (master...document_compat_code) https://github.com/bitcoin/bitcoin/pull/25493
1842022-07-20T14:00:51 <bitcoin-git> [bitcoin] josibake opened pull request #25650: script: default to necessary tags in `test/get_previous_releases.py` (master...josibake-update-get-previous-releases-script) https://github.com/bitcoin/bitcoin/pull/25650
1852022-07-20T14:31:15 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
1862022-07-20T15:02:01 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
1872022-07-20T15:29:30 *** jespada <jespada!~jespada@200.123.140.126> has quit IRC (Ping timeout: 240 seconds)
1882022-07-20T15:33:30 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
1892022-07-20T15:33:30 *** jespada <jespada!~jespada@45.162.228.190> has joined #bitcoin-core-dev
1902022-07-20T15:47:09 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca> has joined #bitcoin-core-dev
1912022-07-20T15:58:39 *** MacroFake <MacroFake!~none@72.5.34.65> has joined #bitcoin-core-dev
1922022-07-20T16:01:46 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca> has quit IRC (Remote host closed the connection)
1932022-07-20T16:04:36 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca> has joined #bitcoin-core-dev
1942022-07-20T16:09:25 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca> has quit IRC (Remote host closed the connection)
1952022-07-20T16:15:04 <josie[m]> is there any special steps that need to be taken when making a ci change in a PR, mixed with other changes? or is it better to have them as separate PRs ?
1962022-07-20T16:21:44 <josie[m]> s/is there/are there/
1972022-07-20T16:31:08 <bitcoin-git> [bitcoin] jonatack opened pull request #25651: refactor: make ChainImpl::m_node data member private (master...make-ChainImpl-m_node-data-member-private) https://github.com/bitcoin/bitcoin/pull/25651
1982022-07-20T16:32:06 <sipa> josie â¡ï¸: I'd say separate commits (which ideally all pass CI individually), but within the same PR.
1992022-07-20T16:32:58 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
2002022-07-20T16:33:22 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
2012022-07-20T16:34:42 <sipa> (assuming it's related at all, of course)
2022022-07-20T16:38:29 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@70.49.167.252> has joined #bitcoin-core-dev
2032022-07-20T16:42:16 <josie[m]> Pieter: cool, thx!
2042022-07-20T17:01:00 *** Lov3r_Of_Bitcoin <Lov3r_Of_Bitcoin!~Lov3r_Of_@45-27-31-99.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
2052022-07-20T17:02:41 *** michaelfolkson2 is now known as michaelfolkson
2062022-07-20T17:18:26 <kanzure> openssl has removed ripemd160? https://github.com/petertodd/python-bitcoinlib/pull/276
2072022-07-20T17:18:41 <kanzure> s/removed/moved to a non-default configuration
2082022-07-20T17:18:54 <sipa> yes
2092022-07-20T17:19:53 <sipa> lol, that PR copies the "embit" pure python implementation, which is apparently copied from the one I wrote for Bitcoin Corr.
2102022-07-20T17:19:57 <sipa> full circle
2112022-07-20T17:21:49 <kanzure> sounds like an ACK to me!
2122022-07-20T17:24:34 <sipa> They seem to have remove the warning not to use it for anything but testing..m
2132022-07-20T17:25:48 <sipa> https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/ripemd160.py
2142022-07-20T17:28:19 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@70.49.167.252> has quit IRC (Remote host closed the connection)
2152022-07-20T18:02:42 *** Lov3r_Of_Bitcoin <Lov3r_Of_Bitcoin!~Lov3r_Of_@45-27-31-99.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: Connection closed)
2162022-07-20T19:15:06 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 264 seconds)
2172022-07-20T19:17:49 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2182022-07-20T19:20:09 *** hirish <hirish!~hirish@ip251.ip-178-33-19.eu> has quit IRC (Read error: Connection reset by peer)
2192022-07-20T19:22:00 *** hirish <hirish!~hirish@ip251.ip-178-33-19.eu> has joined #bitcoin-core-dev
2202022-07-20T20:25:38 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 268 seconds)
2212022-07-20T20:39:52 *** ronoaldo <ronoaldo!~ronoaldo@179.100.0.45> has quit IRC (Quit: Konversation terminated!)
2222022-07-20T20:40:41 *** ronoaldo <ronoaldo!~ronoaldo@2804:1b3:a8c1:9ecb:cae2:65ff:fe9b:69e6> has joined #bitcoin-core-dev
2232022-07-20T20:47:05 <bitcoin-git> [bitcoin] achow101 pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/5c82ca3365f6...d67f89bd9577
2242022-07-20T20:47:06 <bitcoin-git> bitcoin/master 597a4b3 Sebastian Falbesoner: scripted-diff: rename `FromBinary` helper to `from_binary` (signet miner)
2252022-07-20T20:47:06 <bitcoin-git> bitcoin/master 7c0dfec Sebastian Falbesoner: refactor: move `from_binary` helper from signet miner to test framework
2262022-07-20T20:47:07 <bitcoin-git> bitcoin/master 1b035c0 Sebastian Falbesoner: refactor: move PSBT(Map) helpers from signet miner to test framework
2272022-07-20T20:47:10 <bitcoin-git> [bitcoin] achow101 merged pull request #25625: test: add test for decoding PSBT with per-input preimage types (master...202207-test-add_more_decodepsbt_tests) https://github.com/bitcoin/bitcoin/pull/25625
2282022-07-20T20:47:19 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca> has joined #bitcoin-core-dev
2292022-07-20T20:50:30 *** kexkey <kexkey!~kexkey@static-198-54-132-138.cust.tzulo.com> has quit IRC (Ping timeout: 264 seconds)
2302022-07-20T20:52:42 *** kexkey <kexkey!~kexkey@178.249.214.23> has joined #bitcoin-core-dev
2312022-07-20T20:55:27 *** ronoaldo <ronoaldo!~ronoaldo@2804:1b3:a8c1:9ecb:cae2:65ff:fe9b:69e6> has quit IRC (Quit: Konversation terminated!)
2322022-07-20T20:57:27 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca> has quit IRC (Remote host closed the connection)
2332022-07-20T20:58:32 *** ronoaldo <ronoaldo!~ronoaldo@2804:1b3:a8c1:9ecb:cae2:65ff:fe9b:69e6> has joined #bitcoin-core-dev
2342022-07-20T20:59:59 <bitcoin-git> [bitcoin] achow101 pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/d67f89bd9577...d1e42659bbdd
2352022-07-20T21:00:00 <bitcoin-git> bitcoin/master da8f62d furszy: wallet: remove always true 'fUseCache' from CachedTxGetImmatureCredit
2362022-07-20T21:00:00 <bitcoin-git> bitcoin/master 47b1012 furszy: wallet: remove always true 'fUseCache' from CachedTxGetImmatureWatchOnlyCr...
2372022-07-20T21:00:00 <bitcoin-git> bitcoin/master 4f0ca9b furszy: wallet: remove always false 'recalculate' arg from GetCachableAmount
2382022-07-20T21:00:01 <bitcoin-git> [bitcoin] achow101 merged pull request #25543: wallet: cleanup cached amount and input mine check code (master...2022_wallet_cleanup_1) https://github.com/bitcoin/bitcoin/pull/25543
2392022-07-20T21:04:57 *** hotbeat <hotbeat!~hotbeat@64.145.93.205> has joined #bitcoin-core-dev
2402022-07-20T21:09:05 *** afmencken <afmencken!~afmencken@static-198-54-131-158.cust.tzulo.com> has joined #bitcoin-core-dev
2412022-07-20T21:17:38 *** Guyver2_ <Guyver2_!Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
2422022-07-20T21:20:20 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Ping timeout: 260 seconds)
2432022-07-20T21:21:02 *** ronoaldo <ronoaldo!~ronoaldo@2804:1b3:a8c1:9ecb:cae2:65ff:fe9b:69e6> has quit IRC (Quit: Konversation terminated!)
2442022-07-20T21:21:13 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2452022-07-20T21:51:34 <bitcoin-git> [bitcoin] real-or-random opened pull request #25655: build: remove left-over pkgconfig vars in config.site.in (master...202207-pkgconfig-leftovers) https://github.com/bitcoin/bitcoin/pull/25655
2462022-07-20T21:52:08 *** Guyver2_ <Guyver2_!Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
2472022-07-20T21:53:54 *** Guest2517 <Guest2517!~Guest25@76-242-124-26.lightspeed.lsvlky.sbcglobal.net> has joined #bitcoin-core-dev
2482022-07-20T21:54:48 *** Guest2517 <Guest2517!~Guest25@76-242-124-26.lightspeed.lsvlky.sbcglobal.net> has quit IRC (Client Quit)
2492022-07-20T21:55:21 *** Guest25 <Guest25!~Guest25@76-242-124-26.lightspeed.lsvlky.sbcglobal.net> has joined #bitcoin-core-dev
2502022-07-20T22:00:09 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
2512022-07-20T22:00:09 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
2522022-07-20T22:00:32 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
2532022-07-20T22:05:28 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
2542022-07-20T22:11:52 *** deadslug <deadslug!~enno@2600:1010:b044:c772:dd00:61da:c511:49bb> has joined #bitcoin-core-dev
2552022-07-20T22:16:52 <bitcoin-git> [bitcoin] theStack opened pull request #25656: refactor: wallet: return BResult from `GetReservedDestination` methods (master...202207-refactor-wallet_use_bresult_for_getreserveddestination) https://github.com/bitcoin/bitcoin/pull/25656
2562022-07-20T22:19:46 *** Guest45 <Guest45!~Guest45@2a01:4b00:82a3:df00:42d:b064:5c7a:3bc2> has joined #bitcoin-core-dev
2572022-07-20T22:20:27 <bitcoin-git> [bitcoin] real-or-random closed pull request #25655: build: remove left-over pkgconfig vars in config.site.in (master...202207-pkgconfig-leftovers) https://github.com/bitcoin/bitcoin/pull/25655
2582022-07-20T22:21:07 *** Guest45 <Guest45!~Guest45@2a01:4b00:82a3:df00:42d:b064:5c7a:3bc2> has quit IRC (Client Quit)
2592022-07-20T22:25:12 *** Guest25 <Guest25!~Guest25@76-242-124-26.lightspeed.lsvlky.sbcglobal.net> has quit IRC (Quit: Client closed)
2602022-07-20T22:39:56 *** kouloumos <kouloumos!uid539228@id-539228.tinside.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
2612022-07-20T22:52:09 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
2622022-07-20T22:52:32 *** yanmaani <yanmaani!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
2632022-07-20T23:04:18 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹÑа!)
2642022-07-20T23:25:36 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca> has joined #bitcoin-core-dev
2652022-07-20T23:26:49 *** Kaizen_Kintsugi_ <Kaizen_Kintsugi_!~Kaizen_Ki@bras-base-notlon0902w-grc-22-70-49-167-252.dsl.bell.ca> has quit IRC (Remote host closed the connection)
2662022-07-20T23:42:10 *** hotbeat <hotbeat!~hotbeat@64.145.93.205> has quit IRC (Ping timeout: 240 seconds)
2672022-07-20T23:47:03 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 272 seconds)