12022-09-22T00:02:54 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
22022-09-22T00:03:52 *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
32022-09-22T00:04:24 *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
42022-09-22T00:05:14 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Ping timeout: 258 seconds)
52022-09-22T00:09:11 *** outfox <outfox!~outfox@user/outfox> has quit IRC (Ping timeout: 255 seconds)
62022-09-22T00:10:52 *** halosghost <halosghost!~halosghos@user/halosghost> has joined #bitcoin-core-dev
72022-09-22T00:24:24 *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 258 seconds)
82022-09-22T00:25:30 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
92022-09-22T00:25:46 *** outfox <outfox!~outfox@user/outfox> has joined #bitcoin-core-dev
102022-09-22T00:27:14 *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
112022-09-22T00:30:18 *** amovfx_ <amovfx_!~amovfx@d75-156-179-9.abhsia.telus.net> has joined #bitcoin-core-dev
122022-09-22T00:32:39 *** amovfx_ <amovfx_!~amovfx@d75-156-179-9.abhsia.telus.net> has quit IRC (Remote host closed the connection)
132022-09-22T00:33:12 *** amovfx_ <amovfx_!~amovfx@d75-156-179-9.abhsia.telus.net> has joined #bitcoin-core-dev
142022-09-22T00:34:00 *** jespada <jespada!~jespada@cpc121060-nmal24-2-0-cust249.19-2.cable.virginm.net> has quit IRC (Ping timeout: 264 seconds)
152022-09-22T00:34:06 *** amovfx <amovfx!~amovfx@node-1w7jr9yi65te5rzb5c6wwxbur.ipv6.telus.net> has quit IRC (Ping timeout: 260 seconds)
162022-09-22T00:37:36 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
172022-09-22T00:59:34 *** jespada <jespada!~jespada@cpc121060-nmal24-2-0-cust249.19-2.cable.virginm.net> has joined #bitcoin-core-dev
182022-09-22T01:03:55 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
192022-09-22T01:05:45 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
202022-09-22T01:05:46 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Write error: Connection reset by peer)
212022-09-22T01:05:46 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
222022-09-22T01:05:46 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Write error: Connection reset by peer)
232022-09-22T01:05:46 *** vasild <vasild!~vd@user/vasild> has quit IRC (Read error: Connection reset by peer)
242022-09-22T01:06:22 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
252022-09-22T01:06:26 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
262022-09-22T01:06:40 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
272022-09-22T01:07:06 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
282022-09-22T01:10:57 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
292022-09-22T01:19:21 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
302022-09-22T01:19:58 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
312022-09-22T01:21:11 *** fjMSX <fjMSX!~hypni2p@2.92.213.55> has quit IRC (Remote host closed the connection)
322022-09-22T02:05:58 *** fjMSX <fjMSX!~hypni2p@2.92.213.55> has joined #bitcoin-core-dev
332022-09-22T02:44:33 *** hashfunc <hashfunc!~user@2601:5c0:c280:7090:fdb7:fb0b:e6eb:287> has joined #bitcoin-core-dev
342022-09-22T02:54:36 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 265 seconds)
352022-09-22T02:55:54 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
362022-09-22T03:00:53 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 265 seconds)
372022-09-22T03:07:44 *** hashfunc <hashfunc!~user@2601:5c0:c280:7090:fdb7:fb0b:e6eb:287> has quit IRC (Ping timeout: 244 seconds)
382022-09-22T03:35:18 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 258 seconds)
392022-09-22T03:37:45 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
402022-09-22T03:41:00 *** gleb10689249 <gleb10689249!~gleb@178.150.137.228> has quit IRC (Ping timeout: 265 seconds)
412022-09-22T03:42:36 *** Guest99 <Guest99!~Guest99@156.146.54.85> has joined #bitcoin-core-dev
422022-09-22T03:57:29 *** Guest99 <Guest99!~Guest99@156.146.54.85> has quit IRC (Quit: Client closed)
432022-09-22T04:01:01 *** cmirror <cmirror!~cmirror@rrcs-184-74-240-156.nyc.biz.rr.com> has quit IRC (Remote host closed the connection)
442022-09-22T04:01:34 *** cmirror <cmirror!~cmirror@rrcs-184-74-240-156.nyc.biz.rr.com> has joined #bitcoin-core-dev
452022-09-22T04:02:01 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
462022-09-22T04:02:49 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
472022-09-22T04:04:21 *** dermoth <dermoth!~dermoth@user/dermoth> has quit IRC (Quit: Leaving)
482022-09-22T04:04:33 *** dermoth <dermoth!~dermoth@user/dermoth> has joined #bitcoin-core-dev
492022-09-22T04:07:54 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
502022-09-22T04:12:52 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 260 seconds)
512022-09-22T04:24:01 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
522022-09-22T04:31:57 *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
532022-09-22T04:33:11 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Ping timeout: 258 seconds)
542022-09-22T05:01:31 *** halosghost <halosghost!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 3.6)
552022-09-22T06:08:44 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
562022-09-22T06:13:36 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 264 seconds)
572022-09-22T06:36:59 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 244 seconds)
582022-09-22T06:44:40 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
592022-09-22T06:46:24 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
602022-09-22T07:12:34 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
612022-09-22T07:22:58 *** dongcarl4 <dongcarl4!~dongcarl@cpe-66-65-184-36.nyc.res.rr.com> has quit IRC (Quit: Ping timeout (120 seconds))
622022-09-22T07:23:23 *** dongcarl <dongcarl!~dongcarl@cpe-66-65-184-36.nyc.res.rr.com> has joined #bitcoin-core-dev
632022-09-22T07:49:04 *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 258 seconds)
642022-09-22T07:51:34 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
652022-09-22T07:52:19 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
662022-09-22T07:53:25 *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
672022-09-22T08:09:35 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
682022-09-22T08:14:12 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 264 seconds)
692022-09-22T08:25:00 <bitcoin-git> [bitcoin] yancyribbens opened pull request #26154: refactor: move coin_control variable to test setup section (master...move-coin-control-setup) https://github.com/bitcoin/bitcoin/pull/26154
702022-09-22T08:29:47 *** Earnestly <Earnestly!~earnest@user/earnestly> has quit IRC (Quit: WeeChat 3.6)
712022-09-22T08:31:50 *** Earnestly <Earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
722022-09-22T08:49:42 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
732022-09-22T08:54:41 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 265 seconds)
742022-09-22T09:00:43 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
752022-09-22T09:02:29 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
762022-09-22T09:03:24 *** kexkey <kexkey!~kexkey@static-198-54-132-156.cust.tzulo.com> has quit IRC (Ping timeout: 264 seconds)
772022-09-22T09:05:54 *** kexkey <kexkey!~kexkey@178.249.214.10> has joined #bitcoin-core-dev
782022-09-22T09:21:30 *** kouloumos <kouloumos!uid539228@id-539228.tinside.irccloud.com> has joined #bitcoin-core-dev
792022-09-22T09:21:48 *** Guest842 <Guest842!~Guest84@183.91.7.244> has joined #bitcoin-core-dev
802022-09-22T09:22:37 *** Guest842 <Guest842!~Guest84@183.91.7.244> has quit IRC (Client Quit)
812022-09-22T09:22:41 *** quannn <quannn!~quannn@222.254.34.75> has joined #bitcoin-core-dev
822022-09-22T09:36:22 *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
832022-09-22T09:37:20 *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
842022-09-22T09:41:59 *** quannn <quannn!~quannn@222.254.34.75> has quit IRC (Quit: Client closed)
852022-09-22T09:42:32 *** Bejita <Bejita!~Bejita@120.159.133.140> has joined #bitcoin-core-dev
862022-09-22T09:48:00 *** Bejita <Bejita!~Bejita@120.159.133.140> has quit IRC (Quit: Client closed)
872022-09-22T09:56:25 *** NorrinRadd <NorrinRadd!~me@188.215.95.37> has quit IRC (Ping timeout: 250 seconds)
882022-09-22T09:56:29 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
892022-09-22T10:01:10 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 268 seconds)
902022-09-22T10:16:42 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
912022-09-22T10:27:29 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
922022-09-22T10:29:16 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
932022-09-22T10:48:18 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
942022-09-22T10:53:32 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 268 seconds)
952022-09-22T11:39:49 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Quit: Leaving...)
962022-09-22T11:47:36 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
972022-09-22T12:05:08 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Ping timeout: 258 seconds)
982022-09-22T12:06:59 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
992022-09-22T12:12:53 *** youranonnima <youranonnima!~youranonn@2a02-a453-293-1-d0f3-eeeb-9065-3762.fixed6.kpn.net> has joined #bitcoin-core-dev
1002022-09-22T12:16:11 *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
1012022-09-22T12:17:58 *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1022022-09-22T12:21:10 <youranonnima> https://twitter.com/_n1rna/status/1572915224319234052
1032022-09-22T12:22:06 <youranonnima> We are asking all communities to spread the word and help us - Iranians, to be heard by the world! There is an all out war happening on the streets of Iran.
1042022-09-22T12:22:07 <youranonnima> Stand with Iranians. We need you to help us get our Country back from Mullahs!
1052022-09-22T12:22:07 <youranonnima> #OpIran
1062022-09-22T12:22:08 <youranonnima> #MahsaAmini
1072022-09-22T12:26:43 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1082022-09-22T12:30:10 *** NorrinRadd <NorrinRadd!~me@188.215.95.184> has joined #bitcoin-core-dev
1092022-09-22T12:31:53 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:48:2dd4:18bc:454c> has joined #bitcoin-core-dev
1102022-09-22T12:49:09 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
1112022-09-22T12:53:48 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 264 seconds)
1122022-09-22T13:13:48 *** halosghost <halosghost!~halosghos@user/halosghost> has joined #bitcoin-core-dev
1132022-09-22T13:14:56 *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
1142022-09-22T13:15:12 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
1152022-09-22T13:17:58 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
1162022-09-22T13:21:23 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
1172022-09-22T13:32:38 *** youranonnima <youranonnima!~youranonn@2a02-a453-293-1-d0f3-eeeb-9065-3762.fixed6.kpn.net> has quit IRC (Ping timeout: 252 seconds)
1182022-09-22T13:42:59 *** Guest8336 <Guest8336!~Guest83@207.38.129.117> has joined #bitcoin-core-dev
1192022-09-22T13:45:40 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2b2c970627f7...590d20644458
1202022-09-22T13:45:40 <bitcoin-git> bitcoin/master 55aad5f fanquake: build: remove stdio.h from header checks
1212022-09-22T13:45:40 <bitcoin-git> bitcoin/master 590d206 fanquake: Merge bitcoin/bitcoin#26150: build: remove stdio.h from header checks
1222022-09-22T13:45:41 <bitcoin-git> [bitcoin] fanquake merged pull request #26150: build: remove stdio.h from header checks (master...remove_stdio_h) https://github.com/bitcoin/bitcoin/pull/26150
1232022-09-22T13:47:17 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
1242022-09-22T13:52:50 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
1252022-09-22T13:53:05 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
1262022-09-22T13:53:11 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1272022-09-22T13:56:03 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/590d20644458...100949af0e25
1282022-09-22T13:56:03 <bitcoin-git> bitcoin/master fa64228 MacroFake: fuzz: Avoid timeout in bitdeque fuzz target
1292022-09-22T13:56:04 <bitcoin-git> bitcoin/master fa4ba04 MacroFake: fuzz: Remove no-op call to get()
1302022-09-22T13:56:06 <bitcoin-git> bitcoin/master 100949a fanquake: Merge bitcoin/bitcoin#26012: fuzz: Avoid timeout in bitdeque fuzz target
1312022-09-22T13:56:12 <bitcoin-git> [bitcoin] fanquake merged pull request #26012: fuzz: Avoid timeout in bitdeque fuzz target (master...2209-fuzz-timeout-ðº) https://github.com/bitcoin/bitcoin/pull/26012
1322022-09-22T13:56:28 *** Guest8336 <Guest8336!~Guest83@207.38.129.117> has quit IRC (Ping timeout: 252 seconds)
1332022-09-22T14:04:38 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1342022-09-22T14:06:46 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
1352022-09-22T14:17:51 *** Guyver2 <Guyver2!Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
1362022-09-22T14:37:22 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1372022-09-22T14:49:59 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
1382022-09-22T14:54:43 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 252 seconds)
1392022-09-22T15:02:30 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
1402022-09-22T15:07:03 *** Guyver2 <Guyver2!Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
1412022-09-22T15:18:08 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 268 seconds)
1422022-09-22T15:31:46 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1432022-09-22T15:36:40 *** gleb10689249 <gleb10689249!~gleb@178.150.137.228> has joined #bitcoin-core-dev
1442022-09-22T15:47:50 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Quit: Leaving...)
1452022-09-22T16:24:39 *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
1462022-09-22T16:25:25 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Ping timeout: 258 seconds)
1472022-09-22T16:36:29 *** kexkey <kexkey!~kexkey@178.249.214.10> has quit IRC (Ping timeout: 268 seconds)
1482022-09-22T16:37:51 *** kexkey <kexkey!~kexkey@178.249.214.10> has joined #bitcoin-core-dev
1492022-09-22T16:40:05 *** amovfx_ <amovfx_!~amovfx@d75-156-179-9.abhsia.telus.net> has quit IRC (Remote host closed the connection)
1502022-09-22T16:40:19 *** amovfx <amovfx!~amovfx@d75-156-179-9.abhsia.telus.net> has joined #bitcoin-core-dev
1512022-09-22T16:45:42 *** amovfx <amovfx!~amovfx@d75-156-179-9.abhsia.telus.net> has left #bitcoin-core-dev
1522022-09-22T16:46:09 *** amovfx <amovfx!~amovfx@d75-156-179-9.abhsia.telus.net> has joined #bitcoin-core-dev
1532022-09-22T16:55:54 *** gleb <gleb!sid306870@id-306870.lymington.irccloud.com> has quit IRC ()
1542022-09-22T16:56:12 *** gleb10689249 <gleb10689249!~gleb@178.150.137.228> has left #bitcoin-core-dev
1552022-09-22T16:56:18 *** gleb10689249 <gleb10689249!~gleb@178.150.137.228> has joined #bitcoin-core-dev
1562022-09-22T16:56:48 *** gleb10689249 <gleb10689249!~gleb@178.150.137.228> has left #bitcoin-core-dev
1572022-09-22T16:58:57 *** gleb <gleb!~gleb@178.150.137.228> has joined #bitcoin-core-dev
1582022-09-22T16:59:10 <gleb> testing
1592022-09-22T17:05:06 <laanwj> dongcarl: i don't think so; though i'm not 100% sure how the permissions for the new kind of project board are handled, for the old kind of project board the only way is write access to the entire repo
1602022-09-22T17:05:33 <achow101> #proposedmeetingtopic: acceptable runtimes of new benchmarks
1612022-09-22T17:06:59 <laanwj> contrats on the 24.0 splitoff/tag btw
1622022-09-22T17:09:21 <laanwj> i've added the 24.x branch to the bot so it will show merges there too
1632022-09-22T17:12:50 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
1642022-09-22T17:12:54 <_aj_> laanwj, dongcarl: you're meant to be able to give individuals access to classic project boards https://docs.github.com/en/organizations/managing-access-to-your-organizations-project-boards/managing-an-individuals-access-to-an-organization-project-board
1652022-09-22T17:20:06 <instagibbs> gleb, testong
1662022-09-22T17:22:03 <laanwj> _aj_: thanks, will try
1672022-09-22T17:25:56 <laanwj> so it seems to work for project boards at organization level
1682022-09-22T17:26:37 <laanwj> going to the settings of a project board at repository level just gets me the repository permissions
1692022-09-22T17:26:52 <laanwj> can migrate it ofcourse
1702022-09-22T17:30:50 <laanwj> dongcdd
1712022-09-22T17:30:57 <_aj_> laanwj: but the projects are at organiztion level?
1722022-09-22T17:31:09 <laanwj> dongcarl: migrated the project to https://github.com/orgs/bitcoin/projects/3 and added TheCharlatan explicitly with write access
1732022-09-22T17:31:38 <_aj_> laanwj: migrating seems fine too though!
1742022-09-22T17:31:44 <laanwj> _aj_: only two of the, now https://github.com/orgs/bitcoin/projects
1752022-09-22T17:31:58 <laanwj> the others are at repository level
1762022-09-22T17:32:20 <laanwj> i'm happy to migrate them too if someone asks
1772022-09-22T17:33:22 <_aj_> laanwj: oh :( github tricked me
1782022-09-22T17:34:47 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1792022-09-22T17:35:32 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1802022-09-22T17:40:51 <amovfx> test
1812022-09-22T17:40:59 <instagibbs> amovfx, you got it
1822022-09-22T17:41:07 <amovfx> ah sweet! thanks _aj_ that worked
1832022-09-22T17:41:20 <_aj_> amovfx: cool; it's an anti-spam thing on some bitcoin channels
1842022-09-22T17:41:26 <amovfx> yea makes sense
1852022-09-22T17:41:38 <amovfx> meeting is in an hour 20 right?
1862022-09-22T17:41:47 <amovfx> just want to make sure I'm timezoning correctly
1872022-09-22T17:42:56 <instagibbs> believe so
1882022-09-22T17:44:03 <amovfx> osom,
1892022-09-22T17:46:25 <bitcoin-git> [bitcoin] theStack opened pull request #26156: test: check that `listdescriptors` descriptor strings are sorted (master...202209-test-rpc-check_sorted_listdescriptors_strings) https://github.com/bitcoin/bitcoin/pull/26156
1902022-09-22T17:46:26 <laanwj> yes
1912022-09-22T17:47:40 <amovfx> I don't suppose I could grab some guidance on what to focus on to be a core dev. I'm noob, right now I'm doing the blockchain commons learn bitcoin by the commandline, reviewing prs, and doing the pr review club
1922022-09-22T17:48:21 <amovfx> I guess I'm looking for a goal, or a pre defined task, of "the project needs this"
1932022-09-22T17:48:39 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
1942022-09-22T17:48:53 <sipa> https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
1952022-09-22T17:49:03 <sipa> There are issues label "good first issue".
1962022-09-22T17:49:18 <bitcoin-git> [bitcoin] dhruv closed pull request #25354: [crypto] Reduce wasted pseudorandom bytes in ChaCha20 (master...chacha20-partial-blocks) https://github.com/bitcoin/bitcoin/pull/25354
1972022-09-22T17:49:24 <amovfx> ah yes, those are hard to swipe, Ill keep my eye on those closer, ty
1982022-09-22T17:49:33 <instagibbs> especially test-enhacement issues, those are always very appreciated
1992022-09-22T17:51:15 <_aj_> https://github.com/bitcoin/bitcoin/issues?q=label%3A%22Up+for+grabs%22 -- maybe too
2002022-09-22T18:07:35 *** aleggg <aleggg!~aleggg@179.178.112.239> has quit IRC (Ping timeout: 252 seconds)
2012022-09-22T18:11:13 <bitcoin-git> [bitcoin] benthecarman opened pull request #26157: rpc: Fix ordering of arguments in listtransactions help message (master...fix-list-txs-help) https://github.com/bitcoin/bitcoin/pull/26157
2022022-09-22T18:11:36 <bitcoin-git> [bitcoin] benthecarman closed pull request #26157: rpc: Fix ordering of arguments in listtransactions help message (master...fix-list-txs-help) https://github.com/bitcoin/bitcoin/pull/26157
2032022-09-22T18:12:59 <amovfx> Is there a conflict when configureing with sanitizers
2042022-09-22T18:13:01 <amovfx> ?
2052022-09-22T18:13:15 <amovfx> I'm running ../configure --without-bdb --without-gui --enable-c++17 --enable-fuzz --with-sanitizers=address,fuzzer,undefined CC=clang CXX=clang++
2062022-09-22T18:13:17 <amovfx> and it works
2072022-09-22T18:13:24 <amovfx> but if I add thread, it doesnt
2082022-09-22T18:13:45 <amovfx> ../configure --without-bdb --without-gui --enable-c++17 --enable-fuzz --with-sanitizers=address,fuzzer,undefined,thread CC=clang CXX=clang++
2092022-09-22T18:14:11 <amovfx> checking whether C++ compiler accepts -fsanitize=address,fuzzer,undefined,thread... no
2102022-09-22T18:14:11 <amovfx> configure: error: compiler did not accept requested flags
2112022-09-22T18:14:12 <sipa> yes, you cannot combine the thread sanitizer with most other sanitizers
2122022-09-22T18:14:17 <amovfx> ahhh okay
2132022-09-22T18:14:36 <amovfx> so I have to alternate the config for what I want
2142022-09-22T18:14:45 <amovfx> okay thats cool, cause thread by itself worked
2152022-09-22T18:20:37 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:48:2dd4:18bc:454c> has quit IRC (Ping timeout: 268 seconds)
2162022-09-22T18:23:34 *** amovfx <amovfx!~amovfx@d75-156-179-9.abhsia.telus.net> has quit IRC (Remote host closed the connection)
2172022-09-22T18:23:55 *** amovfx <amovfx!amovfx@gateway/vpn/protonvpn/amovfx> has joined #bitcoin-core-dev
2182022-09-22T18:25:00 *** amovfx_ <amovfx_!amovfx@gateway/vpn/protonvpn/amovfx> has joined #bitcoin-core-dev
2192022-09-22T18:27:29 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2202022-09-22T18:28:53 *** amovfx <amovfx!amovfx@gateway/vpn/protonvpn/amovfx> has quit IRC (Ping timeout: 265 seconds)
2212022-09-22T18:36:40 <fanquake> laanwj: thanks for updating the bot
2222022-09-22T18:38:31 *** Guest48 <Guest48!~Guest48@38.96.179.198> has joined #bitcoin-core-dev
2232022-09-22T18:40:16 *** Guest48 <Guest48!~Guest48@38.96.179.198> has quit IRC (Client Quit)
2242022-09-22T18:43:33 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
2252022-09-22T18:44:57 *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 258 seconds)
2262022-09-22T18:47:52 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 246 seconds)
2272022-09-22T18:54:58 *** yanmaani2 <yanmaani2!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
2282022-09-22T18:55:40 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ade2:76d3:1280:3ac0> has joined #bitcoin-core-dev
2292022-09-22T18:56:43 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
2302022-09-22T19:00:08 <laanwj> #startmeeting
2312022-09-22T19:00:08 <core-meetingbot> Meeting started Thu Sep 22 19:00:08 2022 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
2322022-09-22T19:00:08 <core-meetingbot> Available commands: action commands idea info link nick
2332022-09-22T19:00:24 <Murch> Hi
2342022-09-22T19:00:24 <hebasto> hi
2352022-09-22T19:00:25 <fanquake> hi
2362022-09-22T19:00:35 <luke-jr> hi
2372022-09-22T19:00:45 <laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard b10c BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo
2382022-09-22T19:00:46 <furszy> hi
2392022-09-22T19:00:47 <laanwj> moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
2402022-09-22T19:00:49 <laanwj> hi
2412022-09-22T19:00:52 <achow101> hi
2422022-09-22T19:01:04 <lightlike> hi
2432022-09-22T19:01:12 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC (Client Quit)
2442022-09-22T19:01:35 <glozow> hi
2452022-09-22T19:01:38 <amovfx_> hi
2462022-09-22T19:01:43 <laanwj> welcome to the weekly general bitcoin-core-dev meeting
2472022-09-22T19:02:02 <laanwj> on topic has been proposed: acceptable runtimes of new benchmarks (achow101)
2482022-09-22T19:02:06 <sipa> hi
2492022-09-22T19:02:10 <sipsorcery> hi
2502022-09-22T19:02:10 <laanwj> any lastminute ones?
2512022-09-22T19:03:04 <fanquake> rc1 bins!
2522022-09-22T19:03:08 <warren> hi
2532022-09-22T19:03:12 <laanwj> 24.0 was split off a few days ago, and v24.0rc1, so if you haven't yet please start your guix builder
2542022-09-22T19:03:27 <jonatack> hi
2552022-09-22T19:03:49 <amovfx_> is guix builder, just building with gui?
2562022-09-22T19:03:50 <fanquake> ~10 builders submitted sigs so far, and detached sigs are up for codesigning
2572022-09-22T19:03:50 <emzy> hi
2582022-09-22T19:04:23 <sipa> amovfx: guix is the build environment we use for deterministic/reproducible release binaries
2592022-09-22T19:04:32 <sipa> it is entirely unrelated to the gui
2602022-09-22T19:04:38 <laanwj> i think we'll want to go back to discussing high priority for review now that the branch was split off
2612022-09-22T19:04:43 <amovfx_> ty
2622022-09-22T19:04:43 <luke-jr> well, it does build the gui, but what sipa said otherwise ;p
2632022-09-22T19:04:56 *** Zenton <Zenton!~user@user/zenton> has quit IRC (Read error: Connection reset by peer)
2642022-09-22T19:05:03 <sipa> it also builds the non-gui!
2652022-09-22T19:05:06 <luke-jr> right
2662022-09-22T19:05:40 <sipa> https://github.com/bitcoin/bitcoin/blob/master/contrib/guix/README.md for more information
2672022-09-22T19:05:55 <jonatack> amovfx_: see contrib/guix/README.md
2682022-09-22T19:05:58 <laanwj> #topic High priority for review
2692022-09-22T19:05:58 <core-meetingbot> topic: High priority for review
2702022-09-22T19:06:08 <amovfx_> looking at that now, ty
2712022-09-22T19:06:10 <laanwj> https://github.com/orgs/bitcoin/projects/1 has 5 blockers, 3 chasing concept ACK
2722022-09-22T19:06:19 <laanwj> probably needs update
2732022-09-22T19:07:26 <laanwj> anything to add/remove?
2742022-09-22T19:07:29 *** Zenton <Zenton!~user@user/zenton> has joined #bitcoin-core-dev
2752022-09-22T19:07:36 <jonatack> #23433 may be getting close
2762022-09-22T19:07:36 <gribble> https://github.com/bitcoin/bitcoin/issues/23433 | Addrman unit test failures · Issue #23433 · bitcoin/bitcoin · GitHub
2772022-09-22T19:08:06 <jonatack> #23443 sorry
2782022-09-22T19:08:09 <gribble> https://github.com/bitcoin/bitcoin/issues/23443 | p2p: Erlay support signaling by naumenkogs · Pull Request #23443 · bitcoin/bitcoin · GitHub
2792022-09-22T19:08:19 <laanwj> great!!!
2802022-09-22T19:09:31 <fanquake> I'll probably throw #25391 back in now that we're branched off
2812022-09-22T19:09:33 <gribble> https://github.com/bitcoin/bitcoin/issues/25391 | guix: Use LTO to build releases by fanquake · Pull Request #25391 · bitcoin/bitcoin · GitHub
2822022-09-22T19:09:35 <fanquake> Most toolchain stuff is sorted now. The windows build is still a bit hairy, but otherwise this works, and is ready for more thoughts (in regards to release use) / benchmarking / review.
2832022-09-22T19:10:00 <laanwj> makes sense
2842022-09-22T19:10:14 <glozow> #25038 for me please!
2852022-09-22T19:10:17 <gribble> https://github.com/bitcoin/bitcoin/issues/25038 | policy: nVersion=3 and Package RBF by glozow · Pull Request #25038 · bitcoin/bitcoin · GitHub
2862022-09-22T19:10:26 <achow101> #23417 for me
2872022-09-22T19:10:28 <gribble> https://github.com/bitcoin/bitcoin/issues/23417 | wallet, spkm: Move key management from DescriptorScriptPubKeyMan to wallet level KeyManager by achow101 · Pull Request #23417 · bitcoin/bitcoin · GitHub
2882022-09-22T19:11:28 <laanwj> glozow: added-should it be for blockers or chasing concept ACK?
2892022-09-22T19:11:53 <glozow> laanwj: chasing concept ACK i think
2902022-09-22T19:12:04 *** Zenton <Zenton!~user@user/zenton> has quit IRC (Read error: Connection reset by peer)
2912022-09-22T19:12:05 <glozow> thanks :)
2922022-09-22T19:12:24 *** Zenton <Zenton!~user@user/zenton> has joined #bitcoin-core-dev
2932022-09-22T19:12:39 <laanwj> achow101: looks like it was already on the list?
2942022-09-22T19:13:15 <fanquake> laanwj: i may have just added it
2952022-09-22T19:13:38 <laanwj> okay!
2962022-09-22T19:14:51 <laanwj> anything else for high prio?
2972022-09-22T19:14:59 <laanwj> if not we'll go to next topic
2982022-09-22T19:15:26 <warren> (do I ask questions at the end?)
2992022-09-22T19:15:43 <laanwj> #topic acceptable runtimes of new benchmarks (achow101)
3002022-09-22T19:15:44 <core-meetingbot> topic: acceptable runtimes of new benchmarks (achow101)
3012022-09-22T19:16:25 <laanwj> warren: depends on the kind of question?
3022022-09-22T19:16:42 <laanwj> i mean if it's a big one then it'd make sense to make it a separate topic
3032022-09-22T19:16:51 <achow101> We've been adding some benchmarks for the wallet which run some pretty slow behavior. Since we run all of the benchmarks in make check, there's been some questions on how slow an entire benchmark can be, including setup and teardown
3042022-09-22T19:17:28 <sipa> we could run the make-check benchmarks with a lower -min-time ?
3052022-09-22T19:17:44 <sipa> Because we don't really care about the benchmarking aspect, just that the code gets exercised.
3062022-09-22T19:17:57 <lightlike> we only run one iteration already within "make check", right?
3072022-09-22T19:17:59 <laanwj> sipa: we already run them for one iteration
3082022-09-22T19:17:59 <sipa> I vaguely recall a PR that added an option for this actually.
3092022-09-22T19:18:09 <laanwj> sipa: the problem is that some tests take significant time per iteration
3102022-09-22T19:18:14 <sipa> oh
3112022-09-22T19:18:24 <sipa> i see
3122022-09-22T19:18:25 <achow101> there's the time per iteration, and also time for setting up the wallet
3132022-09-22T19:18:44 <achow101> e.g. a benchmark for a wallet with many txs also requires spending time before the benchmark making those txs
3142022-09-22T19:18:53 <laanwj> the original idea of the benchmarks was that iterations would take neglible time by themselves
3152022-09-22T19:19:13 *** amovfx_ <amovfx_!amovfx@gateway/vpn/protonvpn/amovfx> has quit IRC (Read error: Connection reset by peer)
3162022-09-22T19:19:24 <laanwj> but yes, that's different for the wallet ones
3172022-09-22T19:19:28 <sipa> right, the one-time setup cost per benchmark
3182022-09-22T19:19:40 <furszy> I think that achow101 refers to benchmarks that require time consuming setups, and not the process that gets timed.
3192022-09-22T19:20:05 *** amovfx <amovfx!amovfx@gateway/vpn/protonvpn/amovfx> has joined #bitcoin-core-dev
3202022-09-22T19:20:19 <furszy> message got out late :p..
3212022-09-22T19:20:59 <fanquake> If benches are going to be considerably more expensive than the others, and not necessarily valuable for everyone to run every make check, we should gate them behind some flag / option
3222022-09-22T19:21:02 <lightlike> maybe have a set of "extended" benchmarks that are not part of "make check", similar to the existing solution for long-running functional tests?
3232022-09-22T19:21:10 <fanquake> I don't think we want to add more weight to make check itself
3242022-09-22T19:21:28 <fanquake> There are already expensive things run there that ideally could be split out. i.e running libsecp test suite every time on never-changing code
3252022-09-22T19:21:30 <achow101> what's the purpose of running benchmarks in make check?
3262022-09-22T19:21:51 <sipa> making sure the benchmarks actually run
3272022-09-22T19:22:31 <sipa> i guess the policy (intentional or not) we have is that "make check" runs all compiled code we have?
3282022-09-22T19:22:45 <sipa> it doesn't run functional tests, but does run unit tests
3292022-09-22T19:22:49 <laanwj> right, there have been crashes in the benchmarks in the past, running them for one iteration makes sure thre are no obvious crashes at least
3302022-09-22T19:22:51 <_aj_> doesn't run the fuzz tests?
3312022-09-22T19:22:53 <sipa> and bitcoin-tx tests
3322022-09-22T19:23:15 <sipa> hmm, it doesn't run the fuzz tests, good point
3332022-09-22T19:23:20 <achow101> that could also be achieved with another ci job
3342022-09-22T19:23:48 <laanwj> the fuzz tests would reqiire external data (e.g. corpuses) so it's not very practical
3352022-09-22T19:23:50 <_aj_> would be nice to have 'make check' run the cheap benchmarks, at any rate?
3362022-09-22T19:23:54 <sipa> yeah the most important thing is that CI at least occasionally runs all benchmark code
3372022-09-22T19:24:48 <furszy> isn't the CI running in debug mode? (which makes benchmarks run much slower)
3382022-09-22T19:26:19 <achow101> yes, but slow CI is nothing new
3392022-09-22T19:28:15 <achow101> anyways, seems like the consensus is to have make check just not run all of the benchmarks
3402022-09-22T19:28:49 <laanwj> i think that's the only proposed solution, too
3412022-09-22T19:29:06 <sipa> i think that's reasonable
3422022-09-22T19:29:16 <warren> sounds like there should be different levels of "check"?
3432022-09-22T19:29:38 <jonatack> yes, as long as a CI task does run them
3442022-09-22T19:30:09 <warren> Somewhat related, when Fedora packaged bitcoin core they insisted on running "make check" during every package build. I tried to argue even Bitcoin Core's own binary distribution process doesn't do that because it's way too slow?
3452022-09-22T19:30:21 <furszy> if we have to run some of the benchmarks, couldn't we just run them in a different CI job without debug mode?
3462022-09-22T19:30:51 <warren> I didn't check for a year but at some point I had "make check" succeed on only faster machines but fail on slow machines due to a timeout of some sort, which would cause the Fedora package build to fail.
3472022-09-22T19:31:03 <achow101> furszy: I think we would still want debug enabled as debug will also execute code that we may care about
3482022-09-22T19:31:20 <achow101> (since the purpose is to look for crashes/programming errors rather than actually benchmarking)
3492022-09-22T19:31:34 <warren> I suppose "make check" failing on a slow machine with a timeout should be considered a bug?
3502022-09-22T19:31:38 <jonatack> at least benchmarks ran last, so on my slow laptop, i would halt the make check run at the benchmark step
3512022-09-22T19:31:43 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
3522022-09-22T19:31:51 <furszy> achow101: hmm k
3532022-09-22T19:32:06 <laanwj> warren: yes, imo
3542022-09-22T19:32:16 <laanwj> warren: but it would be fixed by the same solution proposed now
3552022-09-22T19:32:21 <warren> nice
3562022-09-22T19:32:41 <achow101> I don't think guix runs any of the tests or benchmarks?
3572022-09-22T19:32:59 <achow101> other than symbol and security checks
3582022-09-22T19:33:01 <laanwj> no, guix doesn't
3592022-09-22T19:33:03 <sipa> really?
3602022-09-22T19:33:09 <laanwj> it woudn't make much sense with cross compiling
3612022-09-22T19:33:14 <warren> yeah, can we have an official recommendation for distros "we don't recommend using make check since we don't use it in our own binary distro procedure"?
3622022-09-22T19:33:15 <sipa> we don't run the tests in guix builds?
3632022-09-22T19:33:28 <sipa> ah, yeah, cross compilation is an issue
3642022-09-22T19:34:01 <sipa> @warren as far as i'm concerned, that's up to them
3652022-09-22T19:34:02 <laanwj> wait, we absolutely recommend runing make check
3662022-09-22T19:34:04 <laanwj> if you can
3672022-09-22T19:34:09 <warren> i argue it isn't worth adding hours (?) of build time for distributors. it could be separately tested in their case.
3682022-09-22T19:34:17 <laanwj> we do ship test_bitcoin fwiw
3692022-09-22T19:34:24 <sipa> if they don't mind the time it takes on their builders to run all the tests (even ones beyond make check), so much the better
3702022-09-22T19:34:26 <laanwj> so people can run it *on their own machine* before running bitcoind
3712022-09-22T19:34:27 <laanwj> if they want
3722022-09-22T19:34:38 <fanquake> guix build targets: https://github.com/bitcoin/bitcoin/blob/master/contrib/guix/libexec/build.sh#L261-L285
3732022-09-22T19:34:57 <laanwj> that's the unit tests and most important part; they could also run the benchmarks, ofc
3742022-09-22T19:35:15 <warren> with this proposed benchmarks change "make check" would become a lot faster?
3752022-09-22T19:35:20 <sipa> wouldn't it make sense to run unit tests in guix on platforms where host=target ?
3762022-09-22T19:35:40 <laanwj> sipa: i'm not sure
3772022-09-22T19:35:40 <achow101> warren: yes
3782022-09-22T19:35:49 <warren> excellent
3792022-09-22T19:36:14 <_aj_> warren: (are you sure that was make check / unit tests, and not the functional tests? make check should be minutes, not hours)
3802022-09-22T19:36:15 <laanwj> you could always run the generated test_bitcoin if you want to check the result
3812022-09-22T19:36:47 <laanwj> i'm not sure running the code it generates is within the scope of deterministic building
3822022-09-22T19:36:48 <warren> that's what I argued
3832022-09-22T19:37:12 <warren> _aj_: I haven't looked in over a year
3842022-09-22T19:37:33 <sipa> @laanwj True
3852022-09-22T19:38:01 <warren> at the moment I'm part of a rebel group trying to encourage the entire distro to take build reproducibility seriously. we need to demonstrate such a bootstrap outside their infra. will take a while.
3862022-09-22T19:38:35 <laanwj> sipa: i mean i'm not strongly against it either, but making behavior depend on the host platform, for example, is a potential source of non-determinism
3872022-09-22T19:39:16 <sipa> fair enough
3882022-09-22T19:40:37 <laanwj> we've drifted from the topic a bit :) any other topics?
3892022-09-22T19:41:08 <warren> I was curious if anyone knows what's going on with BIP324?
3902022-09-22T19:41:23 <sipa> yes
3912022-09-22T19:41:44 <sipa> we've been working on updating the draft in private (dhruv, real-or-random, me)
3922022-09-22T19:41:48 *** gossie <gossie!~gossie@2001:1c02:11e:3500:df25:6321:8260:d9be> has quit IRC (Ping timeout: 264 seconds)
3932022-09-22T19:41:53 <sipa> should have something to show very soon
3942022-09-22T19:42:25 <warren> Will it end up using the same p2p port as current day clearnet connections?
3952022-09-22T19:42:37 <warren> Will it have a different connection limit bucket?
3962022-09-22T19:42:55 <warren> anyhow excited to see the next draft!
3972022-09-22T19:43:04 <sipa> well, port 8333 is no longer preferred for outbound connections, though it's still the default for listening
3982022-09-22T19:43:14 <laanwj> dhruv was asking about testing #24545 a few days ago
3992022-09-22T19:43:15 <gribble> https://github.com/bitcoin/bitcoin/issues/24545 | BIP324: Enable v2 P2P encrypted transport by dhruv · Pull Request #24545 · bitcoin/bitcoin · GitHub
4002022-09-22T19:43:39 <sipa> the interaction with bip324 i'd say is an implementation detail; the spec doesn't care about what port it runs on, and bip324 capable listeners can accept both on the same port
4012022-09-22T19:44:22 *** dougefish_ <dougefish_!~dougefish@2a00:a041:3c18:b400:1ac0:4dff:fe34:3985> has quit IRC (Remote host closed the connection)
4022022-09-22T19:44:28 <sipa> dhruv's implementation seems to work, i'm running it on bitcoin.sipa.be and there are a few other nodes running it
4032022-09-22T19:44:45 <sipa> i've personally focused more on the spec than the implementation though
4042022-09-22T19:44:46 <sipa> so far
4052022-09-22T19:46:03 <warren> thank you
4062022-09-22T19:46:08 <laanwj> yes i think that's the important point, they can share the same port
4072022-09-22T19:47:35 <laanwj> the connection limit bucket is not affected at all by the kind of connection, whether it should is something for discussion but probably not for the initial implementation
4082022-09-22T19:47:43 <sipa> yeah
4092022-09-22T19:47:53 <warren> right
4102022-09-22T19:48:22 <laanwj> any other topics for today?
4112022-09-22T19:49:20 <fanquake> Just making the rc1 bins available shortly, given we've had a good number of builds. Will be good to get some people testing rc1
4122022-09-22T19:49:46 <sipa> are the only rc2 backported fixes test things so far?
4132022-09-22T19:49:51 <laanwj> i'll get building
4142022-09-22T19:50:26 <fanquake> a couple bug fixes, 1 in the wallet, 1 config option related
4152022-09-22T19:50:35 <sipa> ok
4162022-09-22T19:51:09 <laanwj> #endmeeting
4172022-09-22T19:51:09 <core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
4182022-09-22T19:51:09 <core-meetingbot> Meeting ended Thu Sep 22 19:51:09 2022 UTC.
4192022-09-22T19:51:09 <core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2022/bitcoin-core-dev.2022-09-22-19.00.moin.txt
4202022-09-22T19:51:13 *** dougefish <dougefish!~dougefish@2a00:a041:3c18:b400:1ac0:4dff:fe34:3985> has joined #bitcoin-core-dev
4212022-09-22T19:51:29 <fanquake> the miniscript fix needs backporting, maybe the fuzz fix for the bitdeque
4222022-09-22T19:51:44 <fanquake> we'll keep collecting for rc2
4232022-09-22T19:51:57 <achow101> fyi I will be unavailable for the wallet meeting tomorrow, if someone else would like to run it, that'd be great.
4242022-09-22T19:52:23 <amovfx> Thanks everyone, are there any other meetings I should be aware of, i do this, and pr review club
4252022-09-22T19:52:23 <glozow> it would also be good to get #25858 if people are willing to review?
4262022-09-22T19:52:25 <gribble> https://github.com/bitcoin/bitcoin/issues/25858 | psbt: Only include PSBT_OUT_TAP_TREE when the output has a script path by achow101 · Pull Request #25858 · bitcoin/bitcoin · GitHub
4272022-09-22T19:52:27 <amovfx> and just learned of the wallet
4282022-09-22T19:52:31 <amovfx> is that here?
4292022-09-22T19:52:51 <achow101> amovfx: yes, we have a wallet meeting here every other friday
4302022-09-22T19:52:57 <amovfx> cool
4312022-09-22T19:56:42 <amovfx> Is there a good resource where I can learn about taproot? I'm reading over #25858 and I have some stuff to learn
4322022-09-22T19:56:44 <gribble> https://github.com/bitcoin/bitcoin/issues/25858 | psbt: Only include PSBT_OUT_TAP_TREE when the output has a script path by achow101 · Pull Request #25858 · bitcoin/bitcoin · GitHub
4332022-09-22T19:57:44 <sipa> amovfx: Have you read the BIPs (341 and 342 mostly)? There are more high-level explainers on various online media too. I've done one or two talks about it too.
4342022-09-22T19:58:20 <amovfx> I've seen a few videos, Ill read over the BIPS today thanks
4352022-09-22T19:58:41 <jonatack> amovfx: another suggestion would be to git clone the bitcoin optech and the bitcoin core pr reviews repositories locally and then search them for the terms you are interested in
4362022-09-22T19:59:05 <amovfx> ah thats a good idea, ty
4372022-09-22T19:59:44 <jonatack> also just https://bitcoinops.org/en/topics/
4382022-09-22T20:00:21 <jonatack> (idem for git cloning the bips repository locally)
4392022-09-22T20:00:33 <amovfx> yea makes them a bit more searchable
4402022-09-22T20:09:09 *** jamesob <jamesob!~jamesob@151.200.19.227> has quit IRC (Quit: The Lounge - https://thelounge.chat)
4412022-09-22T20:11:38 *** jamesob <jamesob!~jamesob@151.200.19.227> has joined #bitcoin-core-dev
4422022-09-22T20:26:06 *** amovfx <amovfx!amovfx@gateway/vpn/protonvpn/amovfx> has quit IRC (Remote host closed the connection)
4432022-09-22T20:26:50 *** amovfx <amovfx!amovfx@gateway/vpn/protonvpn/amovfx> has joined #bitcoin-core-dev
4442022-09-22T20:26:58 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
4452022-09-22T20:27:19 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
4462022-09-22T20:30:30 <kouloumos> amovfx: regarding optech resources, this might be useful https://bitcoinops.org/en/preparing-for-taproot/
4472022-09-22T20:40:13 *** PasiveIncomeGirl <PasiveIncomeGirl!~PasiveInc@183.83.137.201> has joined #bitcoin-core-dev
4482022-09-22T20:44:13 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
4492022-09-22T20:46:23 *** PasiveIncomeGirl <PasiveIncomeGirl!~PasiveInc@183.83.137.201> has left #bitcoin-core-dev
4502022-09-22T20:48:55 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 252 seconds)
4512022-09-22T21:22:38 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:ade2:76d3:1280:3ac0> has quit IRC ()
4522022-09-22T21:38:56 <Murch> We also have the Optech Workshop for Taproot with the Jupiter notebooks which should help people get their hands a bit dirty trying to understand how Taproot fits together under the hood
4532022-09-22T21:39:21 <Murch> https://bitcoinops.org/en/schorr-taproot-workshop/
4542022-09-22T21:39:48 <Murch> It may be slightly outdated on some minor details, but still useful
4552022-09-22T21:59:32 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 268 seconds)
4562022-09-22T22:00:18 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Quit: jarthur)
4572022-09-22T22:09:39 *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Ping timeout: 258 seconds)
4582022-09-22T22:11:56 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
4592022-09-22T22:12:09 *** aleggg <aleggg!~aleggg@189.114.69.95> has joined #bitcoin-core-dev
4602022-09-22T22:13:40 <luke-jr> fanquake: can you un-rebase #25964 so it cleanly merges into 24.x too?
4612022-09-22T22:13:41 <gribble> https://github.com/bitcoin/bitcoin/issues/25964 | build: fix mingw miniupnpc cflags by fanquake · Pull Request #25964 · bitcoin/bitcoin · GitHub
4622022-09-22T22:33:56 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
4632022-09-22T22:40:53 *** kouloumos <kouloumos!uid539228@id-539228.tinside.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
4642022-09-22T22:45:12 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has joined #bitcoin-core-dev
4652022-09-22T22:49:55 *** _apex2_ <_apex2_!~apex@dynamic-acs-24-144-190-15.zoominternet.net> has quit IRC (Ping timeout: 252 seconds)
4662022-09-22T22:54:22 <bitcoin-git> [bitcoin] furszy opened pull request #26158: bench: add "priority level" to the benchmark framework (master...2022_bench_priority_level) https://github.com/bitcoin/bitcoin/pull/26158
4672022-09-22T23:16:40 *** amovfx <amovfx!amovfx@gateway/vpn/protonvpn/amovfx> has quit IRC (Ping timeout: 246 seconds)
4682022-09-22T23:17:43 *** amovfx <amovfx!amovfx@gateway/vpn/protonvpn/amovfx> has joined #bitcoin-core-dev
4692022-09-22T23:18:25 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 246 seconds)