12022-11-15T00:04:32 *** halosghost <halosghost!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 3.7.1)
22022-11-15T00:17:01 *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has joined #bitcoin-core-dev
32022-11-15T00:18:29 *** brunoerg_ <brunoerg_!~brunoerg@2804:14d:5281:8ae2:38f0:59e5:a1e4:87a5> has quit IRC ()
42022-11-15T00:32:24 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
52022-11-15T00:33:13 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
62022-11-15T00:51:40 *** sipsorcery <sipsorcery!~sipsorcer@37.228.225.67> has quit IRC (Ping timeout: 268 seconds)
72022-11-15T00:55:23 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 255 seconds)
82022-11-15T00:57:26 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
92022-11-15T00:58:17 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
102022-11-15T01:00:01 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
112022-11-15T01:19:49 *** Guest62 <Guest62!~Guest62@2a02:c7c:5a2e:1000:b94d:588c:ea20:cf74> has joined #bitcoin-core-dev
122022-11-15T01:19:50 *** Guest62 <Guest62!~Guest62@2a02:c7c:5a2e:1000:b94d:588c:ea20:cf74> has quit IRC (Write error: Broken pipe)
132022-11-15T01:28:24 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
142022-11-15T01:29:07 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
152022-11-15T01:38:07 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
162022-11-15T01:38:41 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
172022-11-15T01:45:04 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
182022-11-15T01:45:55 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
192022-11-15T01:57:55 *** Zenton <Zenton!~user@user/zenton> has joined #bitcoin-core-dev
202022-11-15T02:00:40 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
212022-11-15T02:02:57 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
222022-11-15T02:18:16 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
232022-11-15T02:19:10 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
242022-11-15T02:43:50 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 255 seconds)
252022-11-15T02:53:18 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
262022-11-15T03:15:35 *** generatecoll <generatecoll!~generatec@2600:1700:1c35:2bb0:162:fa8c:faf2:3565> has joined #bitcoin-core-dev
272022-11-15T03:24:33 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
282022-11-15T03:25:27 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
292022-11-15T03:28:24 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
302022-11-15T03:29:17 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
312022-11-15T03:30:09 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 268 seconds)
322022-11-15T03:31:51 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
332022-11-15T03:46:16 *** chipxxx <chipxxx!~chip@2001:8a0:f61c:9200:9c3d:d55a:c1aa:516e> has joined #bitcoin-core-dev
342022-11-15T03:52:52 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has joined #bitcoin-core-dev
352022-11-15T04:15:07 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
362022-11-15T04:15:33 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
372022-11-15T04:16:37 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
382022-11-15T04:42:32 *** Guest56 <Guest56!~Guest56@c-76-23-205-252.hsd1.ct.comcast.net> has joined #bitcoin-core-dev
392022-11-15T04:42:49 *** Guest56 <Guest56!~Guest56@c-76-23-205-252.hsd1.ct.comcast.net> has quit IRC (Client Quit)
402022-11-15T04:45:50 *** enel <enel!~enel@c-76-23-205-252.hsd1.ct.comcast.net> has joined #bitcoin-core-dev
412022-11-15T04:54:30 *** enel <enel!~enel@c-76-23-205-252.hsd1.ct.comcast.net> has quit IRC (Quit: Client closed)
422022-11-15T05:00:02 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
432022-11-15T05:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
442022-11-15T05:01:05 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Ping timeout: 255 seconds)
452022-11-15T05:01:33 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
462022-11-15T05:10:33 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Quit: 404)
472022-11-15T06:48:33 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
482022-11-15T06:49:29 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
492022-11-15T07:19:29 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
502022-11-15T07:47:20 *** gnaf <gnaf!~gnaf@212-83-165-160.rev.poneytelecom.eu> has joined #bitcoin-core-dev
512022-11-15T07:47:23 *** gnaf <gnaf!~gnaf@212-83-165-160.rev.poneytelecom.eu> has quit IRC (Client Quit)
522022-11-15T07:47:39 *** gnaf <gnaf!~gnaf@212-83-165-160.rev.poneytelecom.eu> has joined #bitcoin-core-dev
532022-11-15T07:52:16 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
542022-11-15T08:12:55 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
552022-11-15T08:13:30 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
562022-11-15T08:15:20 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
572022-11-15T08:16:10 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
582022-11-15T08:17:39 *** dermoth <dermoth!~dermoth@user/dermoth> has quit IRC (Ping timeout: 255 seconds)
592022-11-15T08:18:36 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
602022-11-15T08:19:44 *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has joined #bitcoin-core-dev
612022-11-15T08:23:41 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 268 seconds)
622022-11-15T08:43:34 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
632022-11-15T08:45:33 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
642022-11-15T08:48:58 *** Guyver2 <Guyver2!~Guyver@77.174.98.73> has joined #bitcoin-core-dev
652022-11-15T08:52:37 *** Guyver2 <Guyver2!~Guyver@77.174.98.73> has left #bitcoin-core-dev
662022-11-15T09:01:00 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
672022-11-15T09:05:03 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
682022-11-15T09:09:31 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
692022-11-15T09:10:26 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has joined #bitcoin-core-dev
702022-11-15T09:27:23 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
712022-11-15T09:44:46 *** gnaf <gnaf!~gnaf@212-83-165-160.rev.poneytelecom.eu> has quit IRC (Quit: Konversation terminated!)
722022-11-15T10:03:19 *** kexkey <kexkey!~kexkey@static-198-54-132-138.cust.tzulo.com> has quit IRC (Ping timeout: 260 seconds)
732022-11-15T10:03:59 *** kexkey <kexkey!~kexkey@static-198-54-132-138.cust.tzulo.com> has joined #bitcoin-core-dev
742022-11-15T10:04:04 <MacroFake> I've made some last edits to the release notes draft
752022-11-15T10:04:05 <MacroFake> https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Notes-draft
762022-11-15T10:04:22 <MacroFake> Unless there are objections, I think it can be merged back for 24.0-final
772022-11-15T10:07:59 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 260 seconds)
782022-11-15T10:08:00 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
792022-11-15T10:13:14 <vasild> LarryRuane: "Can `CChain::Next()` be called without holding `cs_main`?" -- In general, one has to check every variable that is read or written by CChain::Next() (directly or through other functions) -- how that variable is accessed in all other places.
802022-11-15T10:15:06 <vasild> The number of things to check could explode quite quickly. Proper thread annotations would help with that. Next() is quite small :)
812022-11-15T10:18:33 <vasild> It does access CChain::vChain in such a way that it expects it will not change between the reads. If it can be modified concurrently by other threads then that would be a problem.
822022-11-15T10:44:28 <bitcoin-git> [bitcoin] fanquake opened pull request #26503: [24.x] bump version to v24.0 (24.x...24_0_final) https://github.com/bitcoin/bitcoin/pull/26503
832022-11-15T10:55:08 *** midnight <midnight!~midnight@user/midnight> has quit IRC (Ping timeout: 252 seconds)
842022-11-15T10:55:16 *** cold <cold!~cold@user/cold> has quit IRC (Ping timeout: 248 seconds)
852022-11-15T10:56:52 *** cold <cold!~cold@user/cold> has joined #bitcoin-core-dev
862022-11-15T10:57:22 *** midnight <midnight!~midnight@user/midnight> has joined #bitcoin-core-dev
872022-11-15T11:05:10 *** yanmaani3 <yanmaani3!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
882022-11-15T11:06:13 *** yanmaani3 <yanmaani3!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
892022-11-15T11:16:08 *** Victorsueca <Victorsueca!~Victorsue@user/victorsueca> has quit IRC (Quit: Gone frying asparagus or my Windows had a BSOD)
902022-11-15T11:16:55 *** NorrinRadd <NorrinRadd!~me@185.238.231.8> has quit IRC (Ping timeout: 260 seconds)
912022-11-15T11:18:53 *** NorrinRadd <NorrinRadd!~me@185.238.231.63> has joined #bitcoin-core-dev
922022-11-15T11:19:31 *** dermoth <dermoth!~dermoth@user/dermoth> has joined #bitcoin-core-dev
932022-11-15T11:26:09 *** NorrinRadd <NorrinRadd!~me@185.238.231.63> has quit IRC (Ping timeout: 260 seconds)
942022-11-15T11:27:16 *** NorrinRadd <NorrinRadd!~me@185.238.231.12> has joined #bitcoin-core-dev
952022-11-15T12:05:49 *** NorrinRadd <NorrinRadd!~me@185.238.231.12> has quit IRC (Ping timeout: 260 seconds)
962022-11-15T12:06:41 *** NorrinRadd <NorrinRadd!~me@185.238.231.12> has joined #bitcoin-core-dev
972022-11-15T12:07:37 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
982022-11-15T12:22:21 *** test__ is now known as _flood
992022-11-15T12:27:50 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:4820:4336:135:32d2> has joined #bitcoin-core-dev
1002022-11-15T12:34:50 *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
1012022-11-15T12:35:08 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Ping timeout: 255 seconds)
1022022-11-15T12:37:11 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 260 seconds)
1032022-11-15T12:47:09 <bitcoin-git> [bitcoin] hebasto opened pull request #26504: Add `UNREACHABLE` macro and drop `-Wreturn-type`/`C4715` warnings suppressions (master...221115-enum) https://github.com/bitcoin/bitcoin/pull/26504
1042022-11-15T13:15:11 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 255 seconds)
1052022-11-15T13:16:17 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
1062022-11-15T13:17:33 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
1072022-11-15T13:21:26 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
1082022-11-15T13:27:51 *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
1092022-11-15T13:29:40 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
1102022-11-15T13:44:46 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
1112022-11-15T13:45:09 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
1122022-11-15T13:48:17 *** darosior <darosior!~darosior@194.36.189.246> has quit IRC (Ping timeout: 246 seconds)
1132022-11-15T13:51:06 *** darosior <darosior!~darosior@194.36.189.246> has joined #bitcoin-core-dev
1142022-11-15T13:53:26 *** yanmaani3 <yanmaani3!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 255 seconds)
1152022-11-15T13:54:20 *** yanmaani3 <yanmaani3!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1162022-11-15T13:54:42 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
1172022-11-15T14:01:22 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
1182022-11-15T14:04:21 *** ziggie <ziggie!uid521459@user/ziggie> has quit IRC (Quit: Connection closed for inactivity)
1192022-11-15T14:07:01 *** gleb0712250 <gleb0712250!~gleb@178.150.137.228> has joined #bitcoin-core-dev
1202022-11-15T14:07:08 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1212022-11-15T14:08:39 *** gleb071225 <gleb071225!~gleb@178.150.137.228> has quit IRC (Ping timeout: 260 seconds)
1222022-11-15T14:12:23 *** gleb0712250 <gleb0712250!~gleb@178.150.137.228> has quit IRC (Ping timeout: 260 seconds)
1232022-11-15T14:13:55 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
1242022-11-15T14:17:56 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
1252022-11-15T14:26:17 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1262022-11-15T14:26:52 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1272022-11-15T14:28:31 <fanquake> Can everyone check / comment in regards to their attribution in the release notes: #26503
1282022-11-15T14:28:32 <gribble> https://github.com/bitcoin/bitcoin/issues/26503 | [24.x] bump version to v24.0 by fanquake · Pull Request #26503 · bitcoin/bitcoin · GitHub
1292022-11-15T14:28:42 <fanquake> I know in past releases contributors have preferred real-names over GH handles, or no attribution etc
1302022-11-15T14:31:32 <luke-jr> what's the status of jonatack's backport PR? slipping 24.0?
1312022-11-15T14:33:07 <instagibbs> github unicorn, havent seen that in a while
1322022-11-15T14:34:55 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1332022-11-15T14:35:02 <luke-jr> #26457
1342022-11-15T14:35:04 <gribble> https://github.com/bitcoin/bitcoin/issues/26457 | [24.x] backports for tx relay changes in getpeerinfo/netinfo/gui by jonatack · Pull Request #26457 · bitcoin/bitcoin · GitHub
1352022-11-15T14:44:03 <fanquake> luke-jr: That pr contains changes that haven't even been merged into master, and would also be a last-minute change to translation strings, which as far as I'm aware, we avoid. So at this stage, no, it's not going to make it in.
1362022-11-15T14:44:23 <bitcoin-git> [bitcoin] RandyMcMillan opened pull request #26505: src/bitcoin-cli.cpp: -getinfo help - grammar correction (master...1668522832/59e00c7e03/48174c0f28-getinfo) https://github.com/bitcoin/bitcoin/pull/26505
1372022-11-15T14:46:26 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1382022-11-15T14:47:18 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1392022-11-15T14:50:34 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1402022-11-15T14:51:16 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1412022-11-15T14:52:37 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1422022-11-15T14:53:06 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1432022-11-15T15:17:57 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
1442022-11-15T15:43:17 *** halosghost <halosghost!~halosghos@user/halosghost> has joined #bitcoin-core-dev
1452022-11-15T15:53:05 *** halosghost <halosghost!~halosghos@user/halosghost> has quit IRC (Read error: Connection reset by peer)
1462022-11-15T16:04:38 <jon_atack> fanquake: The PR those backports depend on seems mergeable, along with the backports (thank you luke-jr for mentioning it).
1472022-11-15T16:06:38 <stevenroose> Does Core store old blocks by height (i.e. sequentially)?
1482022-11-15T16:09:48 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Quit: WeeChat 3.7.1)
1492022-11-15T16:10:25 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1502022-11-15T16:12:12 <stickies-v> stevenroose: no, see e.g. https://github.com/bitcoin/bitcoin/pull/16981 for context
1512022-11-15T16:13:58 <jonatack> Those backports may appear minor, but without them v24 will break user space. For example, the CashApp crypto team informed me that v24 will break their production systems if they upgrade without those patches.
1522022-11-15T16:16:59 <stickies-v> jonatack: perhaps it would be useful if they could comment/create issue with a bit more detail on how this would break their stuff?
1532022-11-15T16:17:16 <stevenroose> stickies-v: aha, thanks
1542022-11-15T16:17:23 <jonatack> I've been proposing to fix these since August before v24 branch-off. If we go forward as-is, it seems to me the v24 release notes ought to warn about the changes (last I looked a few days ago, there was no mention of it).
1552022-11-15T16:17:39 <stevenroose> stickies-v: and that holds for the entire chain, not just for the latest section of unprocessed blocks?
1562022-11-15T16:19:15 <stickies-v> yeah, blocks just get serialized to disk when they're received and basically not touched afterwards, and receiving blocks is never guaranteed to be sequential
1572022-11-15T16:23:10 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1582022-11-15T16:23:31 <stickies-v> jonatack: i know you've raised it a while ago but i think there is some unclarity on how these changes break user space? Hence having direct and specific user input could be helpful?
1592022-11-15T16:23:59 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1602022-11-15T16:24:58 <jonatack> stickies-v: they use the endpoint for sanity checks in their CI and deployment. It's also common sense that a field always present since a number of years in the API shouldn't become sometimes present, sometimes absent, without a deeply compelling reason to do so -- in which case user space ought to be warned in that case.
1612022-11-15T16:26:14 <jonatack> I've stated that case a number of times over months and need to sign off to present at a conf. Up to you all.
1622022-11-15T16:27:07 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
1632022-11-15T16:27:10 <willcl_ark> stevenroose: there is a script in contrib/linearize which can construct a linear block chain locally, if you require :)
1642022-11-15T16:27:57 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Quit: WeeChat 3.7.1)
1652022-11-15T16:29:52 <stevenroose> Things like Riccardo Casatta's block_iterator that iterates through the blockchain on disk would be significantly faster I presume if they would be sequential. As would a hypothetical streamblockchain RPC of some kind
1662022-11-15T16:46:51 *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has quit IRC (Ping timeout: 260 seconds)
1672022-11-15T16:51:58 *** halosghost <halosghost!~halosghos@user/halosghost> has joined #bitcoin-core-dev
1682022-11-15T16:55:35 <bitcoin-git> [bitcoin] brunoerg opened pull request #26507: test: remove unused vars in `feature_block` (master...2022-11-unused-feature-block-test) https://github.com/bitcoin/bitcoin/pull/26507
1692022-11-15T17:07:13 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
1702022-11-15T17:09:50 *** ___nick___ <___nick___!~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net> has joined #bitcoin-core-dev
1712022-11-15T17:18:17 *** generatecoll <generatecoll!~generatec@2600:1700:1c35:2bb0:162:fa8c:faf2:3565> has quit IRC (Quit: Client closed)
1722022-11-15T17:19:39 *** NorrinRadd <NorrinRadd!~me@185.238.231.12> has quit IRC (Ping timeout: 260 seconds)
1732022-11-15T17:22:13 *** NorrinRadd <NorrinRadd!~me@185.238.231.8> has joined #bitcoin-core-dev
1742022-11-15T17:24:35 *** ___nick___ <___nick___!~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
1752022-11-15T17:25:23 *** salvatoshi <salvatoshi!~salvatosh@lfbn-idf3-1-330-185.w83-199.abo.wanadoo.fr> has joined #bitcoin-core-dev
1762022-11-15T17:26:22 *** ___nick___ <___nick___!~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net> has joined #bitcoin-core-dev
1772022-11-15T17:26:55 *** ___nick___ <___nick___!~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net> has quit IRC (Client Quit)
1782022-11-15T17:28:45 *** ___nick___ <___nick___!~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net> has joined #bitcoin-core-dev
1792022-11-15T17:39:23 <bitcoin-git> [gui] john-moffett opened pull request #680: Fixes MacOS 13 segfault by preventing certain notifications after main window is destroyed (master...202211MacSegfaultOnQuit) https://github.com/bitcoin-core/gui/pull/680
1802022-11-15T17:41:43 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
1812022-11-15T17:43:47 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
1822022-11-15T18:00:09 *** salvatoshi <salvatoshi!~salvatosh@lfbn-idf3-1-330-185.w83-199.abo.wanadoo.fr> has quit IRC (Remote host closed the connection)
1832022-11-15T18:00:25 *** salvatoshi <salvatoshi!~salvatosh@lfbn-idf3-1-330-185.w83-199.abo.wanadoo.fr> has joined #bitcoin-core-dev
1842022-11-15T18:37:20 *** Zenton <Zenton!~user@user/zenton> has quit IRC (Read error: Connection reset by peer)
1852022-11-15T18:53:05 *** Zenton <Zenton!~user@user/zenton> has joined #bitcoin-core-dev
1862022-11-15T19:02:12 *** bytes1440000 <bytes1440000!~bytes1440@212-83-165-160.rev.poneytelecom.eu> has joined #bitcoin-core-dev
1872022-11-15T19:04:05 <bytes1440000> michaelfolkson: dont try to police what people write in any repo on github, time you spend on twitter or stackexchange, if spent on github and some testing maybe you could review some PR without bias
1882022-11-15T19:04:05 <bytes1440000> or write some code at some point
1892022-11-15T19:08:43 *** salvatoshi <salvatoshi!~salvatosh@lfbn-idf3-1-330-185.w83-199.abo.wanadoo.fr> has quit IRC (Ping timeout: 268 seconds)
1902022-11-15T19:12:25 *** bytes1440000 <bytes1440000!~bytes1440@212-83-165-160.rev.poneytelecom.eu> has left #bitcoin-core-dev
1912022-11-15T19:54:45 <lightlike> jonatack: it's not clear to me what exactly breaks user space and should be mentioned in release notes. Do you mean the order change in getpeerinfo JSON output? Or that some fields can be reported differently very rarely during a specific moment during connection initialisation? Or something else?
1922022-11-15T20:00:05 <harding> lightlike: did you see: "<jonatack> [...] a field always present since a number of years in the API shouldn't become sometimes present, sometimes absent, without a deeply compelling reason to do so -- in which case user space ought to be warned in that case." and https://github.com/bitcoin/bitcoin/pull/26457/commits/5c03df1fce744fbc357e32f66f9a50b8e609c386 ?
1932022-11-15T20:10:16 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
1942022-11-15T20:10:54 <lightlike> harding: yes, i saw that. I was asking about the "sometimes", to better understand how this affects user experience. Can this happen in a split second during connection initialization, and you'd need an extremely well-timed getpeerinfo call to evoke it? Can this happen in other circumstances?
1952022-11-15T20:16:23 <lightlike> I just tried to add a sleep during various points in initialization with v24.0rc3 and tried to get a getpeerinfo reponse without minfeefilter present, but didn't succeed (but maybe I missed the right spot for the sleep).
1962022-11-15T20:28:21 *** gleb0712250 <gleb0712250!~gleb@178.150.137.228> has joined #bitcoin-core-dev
1972022-11-15T20:29:26 <harding> lightlike: I see. However, if we expect statestats to be available but we include an extra if statement just in case it isn't available, shouldn't we also expect downstream users to want to include their own if statements in their code case the minfeefilter RPC result isn't available?
1982022-11-15T20:35:59 *** NorrinRadd <NorrinRadd!~me@185.238.231.8> has quit IRC (Ping timeout: 260 seconds)
1992022-11-15T20:39:16 <lightlike> harding: Not sure if it makes sense to accomodate this particular situation if it's really just for an extremely short period during connection setup - maybe we could just not answer getpeerinfo until statestats is available? But to answer this (and to get an opinion whether this needs to be backported / mentioned in the release notes) the missing info for me is how exactly can it occur that statestats is not available.
2002022-11-15T20:41:58 <lightlike> (I meant not include the particular peer in getpeerinfo, of course we should answer it)
2012022-11-15T20:47:20 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
2022022-11-15T20:47:20 *** yanmaani3 <yanmaani3!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
2032022-11-15T20:47:46 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
2042022-11-15T20:48:16 *** yanmaani3 <yanmaani3!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
2052022-11-15T20:50:35 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/48174c0f287b...547a96362888
2062022-11-15T20:50:36 <bitcoin-git> bitcoin/master fa4ec1b MacroFake: test: Split overly large util_tests.cpp file
2072022-11-15T20:50:36 <bitcoin-git> bitcoin/master 547a963 MacroFake: Merge bitcoin/bitcoin#26489: test: Split overly large util_tests.cpp file
2082022-11-15T20:50:42 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #26489: test: Split overly large util_tests.cpp file (master...2211-test-split-ð) https://github.com/bitcoin/bitcoin/pull/26489
2092022-11-15T20:52:28 *** NorrinRadd <NorrinRadd!~me@185.238.231.65> has joined #bitcoin-core-dev
2102022-11-15T21:04:14 *** ___nick___ <___nick___!~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net> has quit IRC (Ping timeout: 260 seconds)
2112022-11-15T21:08:51 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:4820:4336:135:32d2> has quit IRC ()
2122022-11-15T21:10:23 *** hg <hg!~halosghos@user/halosghost> has joined #bitcoin-core-dev
2132022-11-15T21:11:10 *** halosghost <halosghost!~halosghos@user/halosghost> has quit IRC (Ping timeout: 240 seconds)
2142022-11-15T21:45:32 *** generatecoll <generatecoll!~generatec@2600:1700:1c35:2bb0:162:fa8c:faf2:3565> has joined #bitcoin-core-dev
2152022-11-15T21:46:01 *** shiza <shiza!~admin@ec2-52-208-131-13.eu-west-1.compute.amazonaws.com> has quit IRC (Remote host closed the connection)
2162022-11-15T22:13:40 *** generatecoll <generatecoll!~generatec@2600:1700:1c35:2bb0:162:fa8c:faf2:3565> has quit IRC (Quit: Client closed)
2172022-11-15T22:38:54 <lightlike> harding, jonatack: I looked a bit more into this and wrote up my conclusions in #26457 - tldr is that I think the fields can only be missing if there is a race between a peer disconnecting and the getpeerinfo RPC.
2182022-11-15T22:38:55 <gribble> https://github.com/bitcoin/bitcoin/issues/26457 | [24.x] backports for tx relay changes in getpeerinfo/netinfo/gui by jonatack · Pull Request #26457 · bitcoin/bitcoin · GitHub
2192022-11-15T22:38:59 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
2202022-11-15T22:41:18 <harding> lightlike: whatever the outcome, thanks for the careful research!
2212022-11-15T22:52:36 *** hg <hg!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 3.7.1)
2222022-11-15T23:16:32 <luke-jr> ++lightlike
2232022-11-15T23:17:28 <luke-jr> I think that means the fixes done are actually wrong, since it was assuming the opposite? (that it only occurs during connection setup)
2242022-11-15T23:34:07 *** NorrinRadd <NorrinRadd!~me@185.238.231.65> has quit IRC (Ping timeout: 256 seconds)
2252022-11-15T23:42:20 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
2262022-11-15T23:57:00 <lightlike> luke-jr: I think they'd still fix the part where clients that would expect a field like "minfeefilter" to be always there won't crash - they'd just get incorrect data for these fields now. But the actual root cause that we'd sometimes report a mix of correct (but outdated) and wrong (default-initialized) data for an Peer that should be atomic is not fixed by this.