12022-11-16T00:02:50 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
22022-11-16T00:03:11 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Ping timeout: 255 seconds)
32022-11-16T00:03:57 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
42022-11-16T00:13:18 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Quit: Leaving...)
52022-11-16T00:24:44 <bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/547a96362888...5602cc7ccf4a
62022-11-16T00:24:44 <bitcoin-git> bitcoin/master 48a6890 Larry Ruane: Add LoadExternalBlockFile() benchmark
72022-11-16T00:24:45 <bitcoin-git> bitcoin/master c72de99 Larry Ruane: util: add CBufferedFile::SkipTo() to move ahead in the stream
82022-11-16T00:24:45 <bitcoin-git> bitcoin/master db92989 Larry Ruane: Faster -reindex by initially deserializing only headers
92022-11-16T00:24:59 <bitcoin-git> [bitcoin] achow101 merged pull request #16981: Improve runtime performance of --reindex (master...reindex-speedup) https://github.com/bitcoin/bitcoin/pull/16981
102022-11-16T00:26:31 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 260 seconds)
112022-11-16T00:27:57 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
122022-11-16T00:46:30 <bitcoin-git> [bitcoin] luke-jr opened pull request #26508: RPC/Blockchain: Minor improvements for scanblocks & scantxoutset docs/errors (master...rpc_scanblocks_scantxoutset_doc_improvements) https://github.com/bitcoin/bitcoin/pull/26508
132022-11-16T00:53:28 <bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/5602cc7ccf4a...f0c646f026e6
142022-11-16T00:53:28 <bitcoin-git> bitcoin/master f0f6a35 furszy: RPC: listunspent, add "include immature coinbase" flag
152022-11-16T00:53:28 <bitcoin-git> bitcoin/master 61c2265 furszy: wallet: group AvailableCoins filtering parameters in a single struct
162022-11-16T00:53:29 <bitcoin-git> bitcoin/master fa84df1 furszy: scripted-diff: wallet: rename AvailableCoinsParams members to snake_case
172022-11-16T00:53:33 <bitcoin-git> [bitcoin] achow101 merged pull request #25730: RPC: listunspent, add "include immature coinbase" flag (master...2022_RPC_listunspent_include_immature_coinbase) https://github.com/bitcoin/bitcoin/pull/25730
182022-11-16T00:56:00 <luke-jr> lightlike: incorrect data is worse than crashing
192022-11-16T01:05:34 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Remote host closed the connection)
202022-11-16T01:39:46 <bitcoin-git> [bitcoin] Kuplynx opened pull request #26509: fix the network (master...master) https://github.com/bitcoin/bitcoin/pull/26509
212022-11-16T01:44:16 <luke-jr> ^ spammer fanquake sipa laanwj
222022-11-16T02:00:35 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
232022-11-16T02:04:32 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
242022-11-16T02:10:32 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 255 seconds)
252022-11-16T02:12:58 *** NorrinRadd <NorrinRadd!~me@185.238.231.45> has joined #bitcoin-core-dev
262022-11-16T02:15:59 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
272022-11-16T02:25:50 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Ping timeout: 255 seconds)
282022-11-16T02:26:45 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
292022-11-16T03:07:00 *** jespada <jespada!~jespada@82.36.38.229> has quit IRC (Ping timeout: 248 seconds)
302022-11-16T03:09:42 *** jespada <jespada!~jespada@nmal-24-b2-v4wan-166357-cust1764.vm24.cable.virginm.net> has joined #bitcoin-core-dev
312022-11-16T03:53:16 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has joined #bitcoin-core-dev
322022-11-16T03:58:35 *** mikehu44 <mikehu44!~quassel@159.65.11.175> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
332022-11-16T04:13:06 <bitcoin-git> [bitcoin] glozow closed pull request #26509: fix the network (master...master) https://github.com/bitcoin/bitcoin/pull/26509
342022-11-16T04:59:30 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
352022-11-16T04:59:48 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
362022-11-16T05:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
372022-11-16T05:01:33 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
382022-11-16T05:46:54 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has quit IRC (Quit: 404)
392022-11-16T06:21:54 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
402022-11-16T06:27:20 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
412022-11-16T06:55:47 *** Guest34 <Guest34!~Guest34@2607:fb90:3f25:2c68:f40a:4bc6:8e33:2d13> has joined #bitcoin-core-dev
422022-11-16T07:01:39 *** Guest34 <Guest34!~Guest34@2607:fb90:3f25:2c68:f40a:4bc6:8e33:2d13> has quit IRC (Quit: Client closed)
432022-11-16T07:24:17 *** dviola <dviola!~diego@user/dviola> has joined #bitcoin-core-dev
442022-11-16T07:34:59 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Ping timeout: 255 seconds)
452022-11-16T07:38:10 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
462022-11-16T07:47:50 *** NorrinRadd <NorrinRadd!~me@185.238.231.45> has quit IRC (Ping timeout: 268 seconds)
472022-11-16T08:01:37 *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has joined #bitcoin-core-dev
482022-11-16T08:34:16 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Quit: jarthur)
492022-11-16T08:40:31 *** TheRec_ <TheRec_!~toto@84-75-225-47.dclient.hispeed.ch> has joined #bitcoin-core-dev
502022-11-16T08:41:32 *** TheRec <TheRec!~toto@user/therec> has quit IRC (Ping timeout: 246 seconds)
512022-11-16T08:47:48 *** stratospher[m] <stratospher[m]!~stratosph@2001:470:69fc:105::2:728e> has quit IRC (Read error: Software caused connection abort)
522022-11-16T08:48:01 *** stratospher[m] <stratospher[m]!~stratosph@2001:470:69fc:105::2:728e> has joined #bitcoin-core-dev
532022-11-16T08:57:38 *** takinbo <takinbo!~takinbo@user/takinbo> has quit IRC (Read error: Software caused connection abort)
542022-11-16T08:57:55 *** takinbo <takinbo!~takinbo@user/takinbo> has joined #bitcoin-core-dev
552022-11-16T09:05:56 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
562022-11-16T09:06:43 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
572022-11-16T09:15:56 *** ziggie <ziggie!uid521459@user/ziggie> has joined #bitcoin-core-dev
582022-11-16T09:21:58 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
592022-11-16T09:23:16 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
602022-11-16T09:23:56 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
612022-11-16T09:27:25 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
622022-11-16T09:30:08 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
632022-11-16T09:30:33 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
642022-11-16T09:54:39 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
652022-11-16T10:02:51 *** kexkey <kexkey!~kexkey@static-198-54-132-138.cust.tzulo.com> has quit IRC (Ping timeout: 260 seconds)
662022-11-16T10:05:47 *** kexkey <kexkey!~kexkey@static-198-54-132-138.cust.tzulo.com> has joined #bitcoin-core-dev
672022-11-16T10:07:46 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
682022-11-16T10:09:59 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
692022-11-16T10:10:57 *** steve__ <steve__!steve@2600:3c01::f03c:93ff:feaa:dd16> has joined #bitcoin-core-dev
702022-11-16T10:13:19 <fanquake> lightlike: thanks for investigating further. So it seems the changes in #26328 are probably overcomplicated, given it's basically impossible to hit the third state (and not something we should have to worry about in -netinfo)?
712022-11-16T10:13:21 <gribble> https://github.com/bitcoin/bitcoin/issues/26328 | netinfo: fix relaytxes doc, display 3 relaytxes states by jonatack · Pull Request #26328 · bitcoin/bitcoin · GitHub
722022-11-16T10:13:35 <fanquake> and the rpc/release notes doc, "not available while peer connection is still being set up" are also incorrect?
732022-11-16T10:21:31 <MacroFake> PSA: DrahtBot will now collect review comments and link to all of them in a summary comment. Example: https://github.com/bitcoin/bitcoin/pull/26508#issuecomment-1316749699
742022-11-16T10:21:43 <MacroFake> Let me know if there are any issues
752022-11-16T10:22:10 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
762022-11-16T10:22:45 <MacroFake> Code was contributed by aureleoules :)
772022-11-16T10:27:56 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
782022-11-16T10:34:39 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
792022-11-16T10:36:32 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
802022-11-16T10:36:49 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev
812022-11-16T10:37:54 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
822022-11-16T10:41:29 <fanquake> I guess this means we should also partially revert https://github.com/bitcoin-core/gui/pull/676, which contained the same "(not available while the peer connection is being set up)"
832022-11-16T10:51:45 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
842022-11-16T10:52:17 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
852022-11-16T11:06:56 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 255 seconds)
862022-11-16T11:07:09 <fanquake> > and need to sign off to present at a conf. Up to you all.
872022-11-16T11:07:16 <fanquake> jonatack: When you're done presenting, please clarify exactly what is going to "break user space and production systems", and which specific change(s) need backporting.
882022-11-16T11:07:33 <fanquake> I'm assuming it's only minfeefilter (setting aside whether this should be handled downstream), in which case, only 5c03df1fce744fbc357e32f66f9a50b8e609c386 from 26457 would be a last-minute blocker?
892022-11-16T11:10:29 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
902022-11-16T11:36:03 *** steve__ <steve__!steve@2600:3c01::f03c:93ff:feaa:dd16> has quit IRC (Quit: Leaving)
912022-11-16T11:36:29 *** steve__ <steve__!steve@2600:3c01::f03c:93ff:feaa:dd16> has joined #bitcoin-core-dev
922022-11-16T11:42:24 *** NorrinRadd <NorrinRadd!~me@185.238.231.65> has joined #bitcoin-core-dev
932022-11-16T11:45:51 <aureleoules> thanks MacroFake for reviewing the code!
942022-11-16T11:46:21 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
952022-11-16T11:46:23 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
962022-11-16T11:47:19 *** yanmaani3 <yanmaani3!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
972022-11-16T11:47:24 *** NorrinRadd <NorrinRadd!~me@185.238.231.65> has quit IRC (Ping timeout: 260 seconds)
982022-11-16T11:47:35 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
992022-11-16T11:48:38 *** NorrinRadd <NorrinRadd!~me@185.238.231.54> has joined #bitcoin-core-dev
1002022-11-16T11:48:53 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
1012022-11-16T11:49:05 *** yanmaani3 <yanmaani3!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1022022-11-16T11:56:53 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 255 seconds)
1032022-11-16T11:58:57 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
1042022-11-16T12:09:18 *** NorrinRadd <NorrinRadd!~me@185.238.231.54> has quit IRC (Ping timeout: 268 seconds)
1052022-11-16T12:29:06 *** NorrinRadd <NorrinRadd!~me@185.238.231.54> has joined #bitcoin-core-dev
1062022-11-16T12:33:06 *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
1072022-11-16T12:33:22 *** Guest95 <Guest95!~Guest95@185.173.181.70.mixvoip.solutions> has joined #bitcoin-core-dev
1082022-11-16T12:33:24 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
1092022-11-16T12:33:29 *** Guest5 <Guest5!~Guest5@185.173.181.70.mixvoip.solutions> has joined #bitcoin-core-dev
1102022-11-16T12:33:44 *** Guest95 <Guest95!~Guest95@185.173.181.70.mixvoip.solutions> has quit IRC (Client Quit)
1112022-11-16T12:33:45 *** Guest5 <Guest5!~Guest5@185.173.181.70.mixvoip.solutions> has quit IRC (Client Quit)
1122022-11-16T12:42:33 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:98f8:37c3:cbdf:e0a0> has joined #bitcoin-core-dev
1132022-11-16T12:43:41 *** yanmaani3 <yanmaani3!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 255 seconds)
1142022-11-16T12:45:04 *** yanmaani3 <yanmaani3!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1152022-11-16T12:54:16 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1162022-11-16T13:12:25 *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
1172022-11-16T13:12:56 *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
1182022-11-16T13:24:27 *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
1192022-11-16T13:25:52 *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
1202022-11-16T13:30:50 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1212022-11-16T13:33:52 *** MeA_BzZz <MeA_BzZz!~MeA_BzZz@adsl-84-227-13-96.adslplus.ch> has joined #bitcoin-core-dev
1222022-11-16T13:34:30 <harding> Is it expected that there are no 24.0 RC4 binaries at https://bitcoincore.org/bin/bitcoin-core-24.0/ ?
1232022-11-16T13:51:27 *** sudoforge <sudoforge!~sudoforge@wireguard/tunneler/sudoforge> has joined #bitcoin-core-dev
1242022-11-16T13:54:48 *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
1252022-11-16T13:54:51 *** MeA_BzZz <MeA_BzZz!~MeA_BzZz@adsl-84-227-13-96.adslplus.ch> has quit IRC (Quit: Client closed)
1262022-11-16T13:55:55 *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
1272022-11-16T14:01:00 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1282022-11-16T14:02:06 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1292022-11-16T14:06:25 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f0c646f026e6...6863ad79a658
1302022-11-16T14:06:26 <bitcoin-git> bitcoin/master 2222ec7 MacroFake: util: Move error message formatting of NonFatalCheckError to cpp
1312022-11-16T14:06:26 <bitcoin-git> bitcoin/master 6863ad7 MacroFake: Merge bitcoin/bitcoin#25112: util: Move error message formatting of NonFat...
1322022-11-16T14:06:38 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #25112: util: Move error message formatting of NonFatalCheckError to cpp (master...2205-err-impl-ð¡) https://github.com/bitcoin/bitcoin/pull/25112
1332022-11-16T14:06:54 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
1342022-11-16T14:07:45 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
1352022-11-16T14:08:07 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1362022-11-16T14:08:12 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1372022-11-16T14:09:20 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1382022-11-16T14:09:38 <bitcoin-git> [bitcoin] willcl-ark opened pull request #26512: init: Evaluate sysperms before config file (master...2022_13371_sysperms) https://github.com/bitcoin/bitcoin/pull/26512
1392022-11-16T14:10:10 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1402022-11-16T14:12:46 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1412022-11-16T14:13:15 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1422022-11-16T14:18:29 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1432022-11-16T14:19:04 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1442022-11-16T14:22:05 *** stevenroose <stevenroose!~steven@2001:19f0:6801:83a:5e1a:89e5:c5fb:d631> has quit IRC (Remote host closed the connection)
1452022-11-16T14:22:22 *** stevenroose <stevenroose!~steven@irc.roose.io> has joined #bitcoin-core-dev
1462022-11-16T14:28:24 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1472022-11-16T14:29:03 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1482022-11-16T14:31:07 *** gnaf <gnaf!~gnaf@212-83-144-108.rev.poneytelecom.eu> has joined #bitcoin-core-dev
1492022-11-16T14:53:29 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
1502022-11-16T14:53:53 *** Guyver2_ <Guyver2_!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
1512022-11-16T15:04:22 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
1522022-11-16T15:06:28 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1532022-11-16T15:07:31 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1542022-11-16T15:15:47 *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 255 seconds)
1552022-11-16T15:18:27 *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
1562022-11-16T15:20:41 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1572022-11-16T15:21:13 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1582022-11-16T15:24:39 *** Guyver2_ <Guyver2_!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev
1592022-11-16T15:30:37 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1602022-11-16T15:32:42 *** ziggie <ziggie!uid521459@user/ziggie> has quit IRC (Quit: Connection closed for inactivity)
1612022-11-16T15:33:47 *** test_ <test_!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
1622022-11-16T15:37:07 *** _flood <_flood!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Ping timeout: 268 seconds)
1632022-11-16T15:49:08 *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
1642022-11-16T15:51:06 *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
1652022-11-16T15:56:00 *** test_ is now known as _flood
1662022-11-16T16:05:44 *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 255 seconds)
1672022-11-16T16:08:14 *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
1682022-11-16T16:15:43 *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has quit IRC (Quit: Leaving)
1692022-11-16T16:22:25 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1702022-11-16T16:34:44 *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
1712022-11-16T16:35:08 *** Guest10 <Guest10!~Guest10@2600:4040:b487:6e00:9953:4ee1:2a4a:58c2> has joined #bitcoin-core-dev
1722022-11-16T16:35:23 *** Guest10 <Guest10!~Guest10@2600:4040:b487:6e00:9953:4ee1:2a4a:58c2> has quit IRC (Client Quit)
1732022-11-16T16:37:02 *** halosghost <halosghost!~halosghos@user/halosghost> has joined #bitcoin-core-dev
1742022-11-16T16:50:43 *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
1752022-11-16T16:50:55 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1762022-11-16T16:56:57 <bitcoin-git> [bitcoin] aureleoules opened pull request #26513: Make static nLastFlush and nLastWrite Chainstate members (master...2022-11-remove-static-chainstate) https://github.com/bitcoin/bitcoin/pull/26513
1772022-11-16T16:57:29 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
1782022-11-16T16:59:51 *** pablomartin <pablomartin!~pablomart@192.145.124.100> has joined #bitcoin-core-dev
1792022-11-16T17:00:29 *** Lov3r_Of_Bitcoin <Lov3r_Of_Bitcoin!~Lov3r_Of_@45-27-31-99.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
1802022-11-16T17:01:57 <jonatack> lightlike: cf yesterday's discussion on the breaking getpeerinfo API, the v24 changes also broke our own code, see #25176
1812022-11-16T17:01:59 <gribble> https://github.com/bitcoin/bitcoin/issues/25176 | Fix frequent -netinfo JSON errors from missing getpeerinfo#relaytxes by jonatack · Pull Request #25176 · bitcoin/bitcoin · GitHub
1822022-11-16T17:04:18 <jonatack> lightlike: this was also trivially visible by observing the GUI peers details during new connections, or by testing #26328
1832022-11-16T17:04:20 <gribble> https://github.com/bitcoin/bitcoin/issues/26328 | netinfo: fix relaytxes doc, display 3 relaytxes states by jonatack · Pull Request #26328 · bitcoin/bitcoin · GitHub
1842022-11-16T17:05:01 <jonatack> after my last talk today, i'll reverify with 24rc4
1852022-11-16T17:08:28 <jonatack> these weren't rare occurences, at least in my testing, they were frequent. note that i use a vpn, have tor/i2p/cjdns peers, and some addnode manual peers with colleagues on the other side of the world.
1862022-11-16T17:08:37 <fanquake> > please clarify exactly what is going to "break user space and production systems", and which specific change(s) need backporting.
1872022-11-16T17:09:46 <lightlike> jonatack: are you sure that the errors in #25176 happened during connection setup for a new peer - and not during disconnection of a peer? Because I can't see how this would be possible from looking at the code.
1882022-11-16T17:09:47 <gribble> https://github.com/bitcoin/bitcoin/issues/25176 | Fix frequent -netinfo JSON errors from missing getpeerinfo#relaytxes by jonatack · Pull Request #25176 · bitcoin/bitcoin · GitHub
1892022-11-16T17:11:13 <jonatack> lightlike: yes, i read your comments (thanks for looking!), and will reverify, but the manual testing methods above showed it happening on connection. i will recheck to be sure.
1902022-11-16T17:15:23 <jonatack> fanquake: messages forwarded to me by the CashApp PM from two of their developers: "we have layers of bitcoin core nodes and use that endpoint [getpeerinfo] .. if we upgraded our production systems without Jon's patch, it would break our production systems and we'd get paged"
1912022-11-16T17:15:57 <jonatack> another dev: "and related, we need to update our core nodes"
1922022-11-16T17:16:31 <jonatack> first dev: "if you want to link the github issue/PR, I can comment directly and ack the proposed changes"
1932022-11-16T17:16:51 <fanquake> Ok. So what is "johns patch" in this scenerio? I'm sure it doesn't include doc changes, rpc help changes, netinfo changes, qt changes etc
1942022-11-16T17:17:01 <fanquake> What is the specific commit or change they are talking about
1952022-11-16T17:18:13 <fanquake> From the investigation here, it's not clear what is broken, or how it's broken, or, aslo, why cashapp couldn't work around this on their side, even temporarily.
1962022-11-16T17:18:55 <jonatack> i had similar feedback from a dev at Block a month or so ago regarding their deployment pipeline. the cashapp messages were a week ago
1972022-11-16T17:19:13 <dergoegge> jonatack: why can't they upgrade their handling of the getpeerinfo call to support missing fields?
1982022-11-16T17:19:13 <dergoegge> This would have all been much simpler if they (CashApp devs) would have just opened an issue explaining their exact problem tbh
1992022-11-16T17:19:19 <jonatack> fanquake: the fields that became optional
2002022-11-16T17:20:05 *** emzy <emzy!~quassel@user/emzy> has quit IRC (Quit: http://quassel-irc.org - Chat comfortably. Anywhere.)
2012022-11-16T17:20:25 <jonatack> dergoegge: the Block dev contacted me after reading the discussion in my first proposal and found some of the reactions too intimidating to comment
2022022-11-16T17:20:58 <jonatack> dergoegge: sure, everyone can patch it on their own, but that doesn't seem ideal
2032022-11-16T17:22:31 <fanquake> jonatack: which fields are you talking about?
2042022-11-16T17:22:41 <fanquake> My understanding is that only minfeefilter has changed in terms of being optional
2052022-11-16T17:23:35 <fanquake> The presence of relaytxes is unchanged in 26457
2062022-11-16T17:23:43 <jonatack> fanquake: and relaytxes, which i proposed to also patch but their was resistance. If we leave the change to make it optional in v24 (after 8 years of being always present, it would introduced in 2015), it would be good to mention that change in the release notes
2072022-11-16T17:24:39 <fanquake> sorry, I'm misunderstanding, 26457 does nothing in regards to changing wether relaytxes is present on not. It's just moved to a different fStateStats conditional
2082022-11-16T17:25:36 <fanquake> and martins comment here: https://github.com/bitcoin/bitcoin/pull/26457/files#r1024158792, suggests that it's always available in any case
2092022-11-16T17:26:37 <jonatack> fanquake: https://github.com/bitcoin/bitcoin/pull/26109#discussion_r973091972
2102022-11-16T17:27:57 <jonatack> it's not always available, and that is trivially testing by reverting #25176 or the two other methods i mentioned above in this convo
2112022-11-16T17:27:59 <gribble> https://github.com/bitcoin/bitcoin/issues/25176 | Fix frequent -netinfo JSON errors from missing getpeerinfo#relaytxes by jonatack · Pull Request #25176 · bitcoin/bitcoin · GitHub
2122022-11-16T17:28:05 <jonatack> *testable
2132022-11-16T17:28:36 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
2142022-11-16T17:30:03 * jonatack back in a few hours
2152022-11-16T17:34:28 *** john-moffett <john-moffett!~john-moff@pool-108-24-170-15.cmdnnj.fios.verizon.net> has joined #bitcoin-core-dev
2162022-11-16T17:35:37 <fanquake> so, to clarify, the current PR, which just shifts relaytxes from one fStateStats conditional, to another, doesn't actually fix the cashapp issue in any case?
2172022-11-16T17:37:05 *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 255 seconds)
2182022-11-16T17:38:15 <fanquake> but does make minfeefilter non-optional, by giving it a value of 0 if there is no fstatestats
2192022-11-16T17:39:58 <fanquake> however the current question / understanding is that it's only possible for there to be no fstatestats if you're racing a getpeerinfo call, and a peer disconnection
2202022-11-16T17:40:11 <fanquake> and this can't happen during connection setup
2212022-11-16T17:44:00 *** ___nick___ <___nick___!~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net> has joined #bitcoin-core-dev
2222022-11-16T17:47:52 <jonatack> i doubt that, but if it were true then we could make relaytxes always present as before with no downside
2232022-11-16T17:48:01 <jonatack> will check in a few hours, thanks
2242022-11-16T17:48:38 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
2252022-11-16T17:57:44 *** darosior <darosior!~darosior@194.36.189.246> has quit IRC (Read error: Connection reset by peer)
2262022-11-16T17:58:05 *** darosior <darosior!~darosior@194.36.189.246> has joined #bitcoin-core-dev
2272022-11-16T18:00:06 *** steve__ <steve__!steve@2600:3c01::f03c:93ff:feaa:dd16> has quit IRC (Quit: Leaving)
2282022-11-16T18:01:54 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 260 seconds)
2292022-11-16T18:03:30 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
2302022-11-16T18:05:28 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
2312022-11-16T18:05:55 *** darosior <darosior!~darosior@194.36.189.246> has quit IRC (Ping timeout: 256 seconds)
2322022-11-16T18:06:23 *** Lov3r_Of_Bitcoin <Lov3r_Of_Bitcoin!~Lov3r_Of_@45-27-31-99.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: Connection closed)
2332022-11-16T18:14:35 *** darosior <darosior!~darosior@194.36.189.246> has joined #bitcoin-core-dev
2342022-11-16T18:15:27 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
2352022-11-16T18:30:05 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
2362022-11-16T18:34:00 <bitcoin-git> [bitcoin] aureleoules opened pull request #26514: Improve address decoding errors (master...2022-11-improve-address-decode-errors) https://github.com/bitcoin/bitcoin/pull/26514
2372022-11-16T19:04:10 *** ___nick___ <___nick___!~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
2382022-11-16T19:05:55 *** ___nick___ <___nick___!~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net> has joined #bitcoin-core-dev
2392022-11-16T19:06:15 *** ___nick___ <___nick___!~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net> has quit IRC (Client Quit)
2402022-11-16T19:08:03 *** ___nick___ <___nick___!~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net> has joined #bitcoin-core-dev
2412022-11-16T19:35:01 *** stickies-v <stickies-v!sid544753@id-544753.uxbridge.irccloud.com> has quit IRC (Ping timeout: 252 seconds)
2422022-11-16T19:38:00 *** stickies-v <stickies-v!sid544753@id-544753.uxbridge.irccloud.com> has joined #bitcoin-core-dev
2432022-11-16T19:40:50 *** jarolrod <jarolrod!sid475272@id-475272.uxbridge.irccloud.com> has quit IRC (Ping timeout: 260 seconds)
2442022-11-16T19:43:52 *** jarolrod <jarolrod!sid475272@id-475272.uxbridge.irccloud.com> has joined #bitcoin-core-dev
2452022-11-16T19:49:37 *** jarolrod <jarolrod!sid475272@id-475272.uxbridge.irccloud.com> has quit IRC (Ping timeout: 256 seconds)
2462022-11-16T19:55:35 *** jarolrod <jarolrod!sid475272@id-475272.uxbridge.irccloud.com> has joined #bitcoin-core-dev
2472022-11-16T20:01:09 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
2482022-11-16T20:27:54 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
2492022-11-16T20:28:33 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev
2502022-11-16T20:31:49 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 260 seconds)
2512022-11-16T20:36:37 *** emzy <emzy!~quassel@user/emzy> has joined #bitcoin-core-dev
2522022-11-16T20:36:44 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
2532022-11-16T21:04:20 *** ___nick___ <___nick___!~quassel@cpc68289-cdif17-2-0-cust317.5-1.cable.virginm.net> has quit IRC (Ping timeout: 248 seconds)
2542022-11-16T21:16:06 *** Guest7 <Guest7!~Guest7@2405:201:5c0b:4998:966:8d70:ae57:60> has joined #bitcoin-core-dev
2552022-11-16T21:28:41 <BlueMatt[m]> jonatack - you seem to indicate its not a regression anyway at https://github.com/bitcoin/bitcoin/pull/26457/#discussion_r1014670159 ? if that's true I don't see why this is a candidate for backport this late in an rc cycle at all.
2562022-11-16T21:36:09 *** chipxxx <chipxxx!~chip@2001:8a0:f61c:9200:9c3d:d55a:c1aa:516e> has quit IRC (Ping timeout: 256 seconds)
2572022-11-16T21:37:17 *** PaperSword <PaperSword!~PaperSwor@50.126.96.22> has quit IRC (Read error: Connection reset by peer)
2582022-11-16T21:38:10 *** NorrinRadd <NorrinRadd!~me@185.238.231.54> has quit IRC (Ping timeout: 240 seconds)
2592022-11-16T21:39:43 *** Guest7 <Guest7!~Guest7@2405:201:5c0b:4998:966:8d70:ae57:60> has quit IRC (Ping timeout: 260 seconds)
2602022-11-16T21:40:07 *** NorrinRadd <NorrinRadd!~me@185.238.231.42> has joined #bitcoin-core-dev
2612022-11-16T21:44:14 *** Guest7 <Guest7!~Guest7@2405:201:5c0b:4998:966:8d70:ae57:60> has joined #bitcoin-core-dev
2622022-11-16T21:45:42 <luke-jr> jonatack: during peer disconnection, we can't know what the correct value was, so how could it be present?
2632022-11-16T21:46:01 <luke-jr> returning incorrect data is IMO worse than omitting it
2642022-11-16T21:53:15 *** Guest7 <Guest7!~Guest7@2405:201:5c0b:4998:966:8d70:ae57:60> has quit IRC (Quit: Client closed)
2652022-11-16T22:10:10 *** Zenton <Zenton!~user@user/zenton> has quit IRC (Read error: Connection reset by peer)
2662022-11-16T22:10:26 *** Zenton <Zenton!~user@user/zenton> has joined #bitcoin-core-dev
2672022-11-16T22:14:07 <bitcoin-git> [bitcoin] mzumsande opened pull request #26515: rpc: skip getpeerinfo for a peer without CNodeStateStats, make its fields non-optional (master...202211_getpeerinfo_allornothing) https://github.com/bitcoin/bitcoin/pull/26515
2682022-11-16T22:27:58 *** zeropoint <zeropoint!~alex@c-67-169-157-130.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
2692022-11-16T22:29:15 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
2702022-11-16T22:36:14 <lightlike> I opened 26515 as a more general proposal to deal with this long-term.
2712022-11-16T23:02:19 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 260 seconds)
2722022-11-16T23:04:14 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 255 seconds)
2732022-11-16T23:04:52 *** theStack <theStack!~theStack@95.179.145.232> has quit IRC (Ping timeout: 248 seconds)
2742022-11-16T23:09:35 <jonatack> BlueMatt[m]: the comment you linked to refers to a doc update proposed two months ago and is not the regression in question. at the time, it was within the window, as was the backports pull.
2752022-11-16T23:09:40 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
2762022-11-16T23:10:24 *** Zenton <Zenton!~user@user/zenton> has quit IRC (Ping timeout: 256 seconds)
2772022-11-16T23:10:56 <BlueMatt[m]> jonatack: so, iiuc, the issue here is that one field (minfeefilter) was always present in 23 and prior releases, and now there's some (absurdly, apparently?) rare race condition where it may not be while a peer is disconnecting?
2782022-11-16T23:11:10 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
2792022-11-16T23:12:27 <BlueMatt[m]> is that correct?
2802022-11-16T23:12:44 <jonatack> BlueMatt[m]: two fields in getpeerinfo, relaytxes and minfeefilter. no, it's not rare. we had to patch our own code for the former in #25176
2812022-11-16T23:12:46 <gribble> https://github.com/bitcoin/bitcoin/issues/25176 | Fix frequent -netinfo JSON errors from missing getpeerinfo#relaytxes by jonatack · Pull Request #25176 · bitcoin/bitcoin · GitHub
2822022-11-16T23:12:49 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Remote host closed the connection)
2832022-11-16T23:12:51 <BlueMatt[m]> (fwiw its not at all clear from the current pr, the previous pr, or any commit message - none of them describe the concrete issue here, just trying to make sure I get what's going on)
2842022-11-16T23:13:08 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
2852022-11-16T23:13:20 <BlueMatt[m]> okay, so 26457 does not re-add relaytxes, its still missing in the same set of cases as before?
2862022-11-16T23:13:31 <BlueMatt[m]> is there some second pr to make it always present?
2872022-11-16T23:13:59 *** NorrinRadd <NorrinRadd!~me@185.238.231.42> has quit IRC (Ping timeout: 260 seconds)
2882022-11-16T23:14:29 <jonatack> BlueMatt[m]: i wanted to make it always present as before, see https://github.com/bitcoin/bitcoin/pull/26109#discussion_r973091972
2892022-11-16T23:14:55 <BlueMatt[m]> btw who is "we" here? You're saying in some deployment of yours you had an issue because of this? I assume it's because something was deserializing the response into a struct that expects the field to be present?
2902022-11-16T23:15:32 *** NorrinRadd <NorrinRadd!~me@185.238.231.34> has joined #bitcoin-core-dev
2912022-11-16T23:15:58 <jonatack> and the original discussion at the start of #25923
2922022-11-16T23:16:00 <gribble> https://github.com/bitcoin/bitcoin/issues/25923 | p2p: always provide CNodeStateStats and getpeerinfo/netinfo/gui updates by jonatack · Pull Request #25923 · bitcoin/bitcoin · GitHub
2932022-11-16T23:16:13 <BlueMatt[m]> jonatack: right, I'm not really trying to understand what did or didnt happen, just trying to make sure I understand where we sit today.
2942022-11-16T23:17:54 <jonatack> BlueMatt[m]: some out-of-date docs that don't cause a regression and two longstanding getpeerinfo fields (relaytxes since 2015 and mifeefilter since 2018 or 2019 iirc) that in v24 are no longer always present
2952022-11-16T23:17:58 <BlueMatt[m]> (am I still correct that rpc changes are supposed to go through the announced-in-one-release-changed/removed-in-the-next two-step process thing?)
2962022-11-16T23:20:43 <BlueMatt[m]> jonatack: right, okay, so then I'm a bit confused why a release is being held up for a non-fix? Irrespective of whether Marco was right to argue against it or not, I don't see why fixing the removal of one field, and not another, makes sense this late in rc?
2972022-11-16T23:20:44 <BlueMatt[m]> like, if removal of a field is an issue (again, not taking a stance here), then fix both, if its not, then ship?
2982022-11-16T23:21:06 <BlueMatt[m]> again irrespective of if it should have landed before now, it is where it is
2992022-11-16T23:23:32 <jonatack> BlueMatt[m]: we had to patch -netinfo that doesn't null check fields that are always present. given the number of fields returned by getpeerinfo, and given feedback from some companies in the space, this needlessly breaks their software as well while being trivial on our end to fix once, rather than each of them patching it. in any case, this has been proposed for months now. it's not
3002022-11-16T23:23:33 <jonatack> holding up the release. it could have been merged but was not. that is not in my control. however, we should also warn user space in the release notes if we leave it as is.
3012022-11-16T23:24:57 <BlueMatt[m]> (fwiw I asked the cash app folks - they have no idea what the patch does or what the specific issue is, and dont know if it would actually cause them pain, they were only told that "if you use getpeerinfo this may break your stuff" and they said "yea, we use that")
3022022-11-16T23:24:58 <BlueMatt[m]> hence why I'm here asking trying to understand exactly where things sit
3032022-11-16T23:24:59 <BlueMatt[m]> what is "-netinfo" that you had to patch? You saw the missing fields in prod?
3042022-11-16T23:25:51 <jonatack> BlueMatt[m]: see my irc comments earlier today for what was forwaded to me
3052022-11-16T23:26:04 <jonatack> i don't have direct access to them
3062022-11-16T23:26:10 <BlueMatt[m]> again, I'm not taking a position on if it should be merged or not, but trying to understand (a) if its a regression (sounds like yes), (b) how likely it is that you can even observe the fields being missing (you seem to say they can be and are in prod, others have said they basically cant be), and (c) if its an issue that merits last-minute fixes.
3072022-11-16T23:26:29 <jonatack> BlueMatt[m]: re -netinfo, see the patch PR i linked to above
3082022-11-16T23:26:31 <BlueMatt[m]> yes, I know, that was a game of telephone, that's why I went and asked ryan directly :)
3092022-11-16T23:26:48 <BlueMatt[m]> he said he's happy to get on a call, if you'd like, but he's busy dealing with mempool growth today :)
3102022-11-16T23:27:43 <jonatack> i'm free any time for a call
3112022-11-16T23:28:40 <jonatack> i've just finished a bunch of stuff and will re-verify but the issues have been trivial to reproduce in at least three ways
3122022-11-16T23:28:53 <jonatack> - observing our GUI peers details
3132022-11-16T23:28:58 <BlueMatt[m]> okay, by "frequently" there in your comment about netinfo I'm a bit confused - fanquake seemed to indicate that in tests others had noted they weren't able to reproduce this at all unless they added some sleeps in the code, implying its an incredibly rare race?
3142022-11-16T23:29:03 <jonatack> - reverting the -netinfo patch
3152022-11-16T23:29:58 <jonatack> - and by testing #26328
3162022-11-16T23:29:59 <gribble> https://github.com/bitcoin/bitcoin/issues/26328 | netinfo: fix relaytxes doc, display 3 relaytxes states by jonatack · Pull Request #26328 · bitcoin/bitcoin · GitHub
3172022-11-16T23:30:10 <BlueMatt[m]> oh, and, finally, it seems pretty obvious that if we think this is a major breaking issue worth backporting, we should make sure both fields are always present, even in a 24-only PR.
3182022-11-16T23:30:37 *** pablomartin_ <pablomartin_!~pablomart@181.228.255.13> has joined #bitcoin-core-dev
3192022-11-16T23:30:48 <jonatack> BlueMatt[m]: I prefer making both present for v24 as it's more prudent and then figuring out the best path for the next releases
3202022-11-16T23:30:49 <BlueMatt[m]> because obviously just fixing it for one field wont help.
3212022-11-16T23:31:03 <BlueMatt[m]> is there a pr for that?
3222022-11-16T23:31:04 <jonatack> agree
3232022-11-16T23:31:29 *** pablomartin <pablomartin!~pablomart@192.145.124.100> has quit IRC (Ping timeout: 260 seconds)
3242022-11-16T23:31:52 <jonatack> #26109 did that before dropping the relaytxes change. i'll open one to re-propose and re-verify the recent feedback
3252022-11-16T23:31:54 <gribble> https://github.com/bitcoin/bitcoin/issues/26109 | rpc, doc: getpeerinfo updates by jonatack · Pull Request #26109 · bitcoin/bitcoin · GitHub
3262022-11-16T23:34:52 <jonatack> BlueMatt[m]: I think you are referring to https://github.com/bitcoin/bitcoin/pull/26457#pullrequestreview-1181641835 which doesn't appear to be end-to-end user-facing testing but will re-check now to be sure
3272022-11-16T23:34:56 <BlueMatt[m]> may be worth re-testing, to make sure it still makes sense holding up a release on it.
3282022-11-16T23:35:39 *** pablomartin_ <pablomartin_!~pablomart@181.228.255.13> has quit IRC (Ping timeout: 268 seconds)
3292022-11-16T23:35:50 <jonatack> BlueMatt[m]: it's sure that it happens frequently though. Looking at the GUI peers details makes that clear. But going to re-check indeed.
3302022-11-16T23:36:17 <jonatack> -netinfo would break several times a minute without the patch
3312022-11-16T23:36:51 <jonatack> with a watch interval of 1 second or 2
3322022-11-16T23:36:52 <BlueMatt[m]> thanks
3332022-11-16T23:47:26 *** yanmaani3 <yanmaani3!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 255 seconds)
3342022-11-16T23:47:30 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 240 seconds)
3352022-11-16T23:51:51 *** yanmaani3 <yanmaani3!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
3362022-11-16T23:52:34 *** justache is now known as justGrit
3372022-11-16T23:53:56 <lightlike> jonatack: for the gui peer details , fetching the statestats can fail for completely unrelated reasons (locking issues, see https://github.com/bitcoin/bitcoin/blob/6863ad79a65842504ab6f5584fac3d1de7ecf87e/src/qt/rpcconsole.cpp#L1200-L1201 ) that don't apply to the RPC.