12022-12-05T00:01:12 *** orville <orville!~orville@c-71-202-253-228.hsd1.ca.comcast.net> has quit IRC (Quit: <exit all I/O streams / EOF>)
22022-12-05T00:03:24 *** b_101 <b_101!~robert@95.211.187.223.adsl.inet-telecom.org> has quit IRC (Ping timeout: 260 seconds)
32022-12-05T00:16:34 *** b_101 <b_101!~robert@95.211.187.223.adsl.inet-telecom.org> has joined #bitcoin-core-dev
42022-12-05T00:18:20 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
52022-12-05T00:18:20 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
62022-12-05T00:21:08 *** b_101 <b_101!~robert@95.211.187.223.adsl.inet-telecom.org> has quit IRC (Ping timeout: 248 seconds)
72022-12-05T00:25:03 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
82022-12-05T00:25:14 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 255 seconds)
92022-12-05T00:25:43 *** b_101 <b_101!~robert@95.211.187.223.adsl.inet-telecom.org> has joined #bitcoin-core-dev
102022-12-05T00:28:28 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
112022-12-05T00:31:28 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
122022-12-05T00:31:37 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
132022-12-05T00:36:29 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Ping timeout: 255 seconds)
142022-12-05T00:46:31 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Quit: Leaving)
152022-12-05T00:50:23 *** halosghost <halosghost!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 3.7.1)
162022-12-05T00:54:02 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
172022-12-05T00:54:15 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
182022-12-05T01:02:14 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
192022-12-05T01:10:55 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has quit IRC (Ping timeout: 252 seconds)
202022-12-05T01:16:31 *** b_101 <b_101!~robert@95.211.187.223.adsl.inet-telecom.org> has quit IRC (Ping timeout: 268 seconds)
212022-12-05T01:18:12 *** b_101 <b_101!~robert@189.236.40.220> has joined #bitcoin-core-dev
222022-12-05T01:18:52 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
232022-12-05T01:19:18 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
242022-12-05T01:23:12 *** b_101_ <b_101_!~robert@189.236.40.220> has joined #bitcoin-core-dev
252022-12-05T01:23:12 *** b_101_ <b_101_!~robert@189.236.40.220> has quit IRC (Client Quit)
262022-12-05T01:23:18 *** b_101 <b_101!~robert@189.236.40.220> has quit IRC (Ping timeout: 268 seconds)
272022-12-05T01:55:12 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
282022-12-05T01:57:13 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
292022-12-05T03:11:45 *** lowhope <lowhope!~lowhope@2602:fffa:fff:108a:0:16:3e86:c70e> has quit IRC (Remote host closed the connection)
302022-12-05T03:15:01 *** lowhope <lowhope!~lowhope@2602:fffa:fff:108a:0:16:3e86:c70e> has joined #bitcoin-core-dev
312022-12-05T05:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
322022-12-05T05:01:32 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
332022-12-05T05:32:09 *** metallicc <metallicc!metallicc@gateway/vpn/protonvpn/metallicc> has quit IRC (Quit: Leaving)
342022-12-05T06:20:22 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Quit: bye)
352022-12-05T06:22:25 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
362022-12-05T06:32:16 <bitcoin-git> [bitcoin] miles170 opened pull request #26637: ci: Use pyenv for the lint task (master...ci-use-pyenv-for-lint) https://github.com/bitcoin/bitcoin/pull/26637
372022-12-05T06:35:35 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 255 seconds)
382022-12-05T07:30:35 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
392022-12-05T07:51:24 <bitcoin-git> [bitcoin] miles170 closed pull request #26637: ci: Use pyenv for the lint task (master...ci-use-pyenv-for-lint) https://github.com/bitcoin/bitcoin/pull/26637
402022-12-05T07:57:25 *** aureleoules <aureleoules!~aureleoul@82-64-162-213.subs.proxad.net> has quit IRC (Ping timeout: 260 seconds)
412022-12-05T08:01:01 *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has joined #bitcoin-core-dev
422022-12-05T08:02:24 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
432022-12-05T08:10:31 *** aureleoules <aureleoules!~aureleoul@82-64-162-213.subs.proxad.net> has joined #bitcoin-core-dev
442022-12-05T08:16:19 <vasild> lightlike: I stared at that code and didn't see any bug because I thought that the intention of that function was to delete the first element only. I would even consider that it is not a bug unless it is explicitly documented somewhere that CoinsResult::Erase() deletes all matches.
452022-12-05T08:17:27 <vasild> the comment says that Erase() (and other methods) are to mimic vector, and std::vector::erase() deletes just a single element.
462022-12-05T08:41:35 *** gnaf <gnaf!~gnaf@93-190-140-117.hosted-by-worldstream.net> has joined #bitcoin-core-dev
472022-12-05T08:49:07 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
482022-12-05T08:53:53 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC (Client Quit)
492022-12-05T08:56:11 <bitcoin-git> [bitcoin] S3RK opened pull request #26638: test: prefer sqlite for wallet tests (master...wallet_test_prefer_sqlite) https://github.com/bitcoin/bitcoin/pull/26638
502022-12-05T09:10:26 *** someone235 <someone235!uid419897@id-419897.ilkley.irccloud.com> has joined #bitcoin-core-dev
512022-12-05T09:32:29 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/9182b2fbae7b...1b05169c321d
522022-12-05T09:32:29 <bitcoin-git> bitcoin/22.x 28fc72f BlackcoinDev: depends: update qt 5.12 url to archive location
532022-12-05T09:32:29 <bitcoin-git> bitcoin/22.x 1b05169 fanquake: Merge bitcoin/bitcoin#26633: depends: update qt 5.12 url to archive locati...
542022-12-05T09:32:32 <bitcoin-git> [bitcoin] fanquake merged pull request #26633: depends: update qt 5.12 url to archive location (22.x...patch-1) https://github.com/bitcoin/bitcoin/pull/26633
552022-12-05T09:33:21 <bitcoin-git> [bitcoin] fanquake closed pull request #26623: contrib: Add CFLAG env variable when MacOS version 11.0.0 (master...update_install_db4) https://github.com/bitcoin/bitcoin/pull/26623
562022-12-05T09:35:06 *** ExEric3 <ExEric3!~exeric3@mail.miners-zone.net> has quit IRC (Read error: Connection reset by peer)
572022-12-05T09:35:29 *** ExEric3 <ExEric3!~exeric3@mail.miners-zone.net> has joined #bitcoin-core-dev
582022-12-05T09:37:15 *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has quit IRC (Ping timeout: 268 seconds)
592022-12-05T09:38:17 *** Evel-Knievel <Evel-Knievel!~Evel-Knie@user/evel-knievel> has joined #bitcoin-core-dev
602022-12-05T09:38:42 *** bitcoinerrorlog <bitcoinerrorlog!~Adium@2001:8a0:6cc3:5a00:d573:4bd7:535c:39a1> has joined #bitcoin-core-dev
612022-12-05T09:42:06 <bitcoin-git> [bitcoin] fanquake closed pull request #26634: builder-keys: add vertiond (master...builder-key-vertion) https://github.com/bitcoin/bitcoin/pull/26634
622022-12-05T09:42:18 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
632022-12-05T09:55:59 <bitcoin-git> [bitcoin] fanquake opened pull request #26639: [22.x] bump version to v22.1 (22.x...22_1_final) https://github.com/bitcoin/bitcoin/pull/26639
642022-12-05T10:06:25 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
652022-12-05T10:38:26 *** gnaf <gnaf!~gnaf@93-190-140-117.hosted-by-worldstream.net> has quit IRC (Quit: Konversation terminated!)
662022-12-05T10:42:58 *** Guest70 <Guest70!~Guest70@49.228.234.38> has joined #bitcoin-core-dev
672022-12-05T10:44:53 *** Guest70 <Guest70!~Guest70@49.228.234.38> has quit IRC (Client Quit)
682022-12-05T11:05:16 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Write error: Connection reset by peer)
692022-12-05T11:06:15 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
702022-12-05T11:16:13 <bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fe8d15c907d0...8b796866b493
712022-12-05T11:16:14 <bitcoin-git> bitcoin/master 1984db1 Hennadii Stepanov: refactor: Rename local variable to distinguish it from type alias
722022-12-05T11:16:14 <bitcoin-git> bitcoin/master 8b79686 glozow: Merge bitcoin/bitcoin#26624: refactor: Rename local variable to distinguis...
732022-12-05T11:16:21 <bitcoin-git> [bitcoin] glozow merged pull request #26624: refactor: Rename local variable to distinguish it from type alias (master...221202-name) https://github.com/bitcoin/bitcoin/pull/26624
742022-12-05T11:16:43 <bitcoin-git> [bitcoin] fanquake closed pull request #26393: build: make configure --enable-debug override CXXFLAGS from depends (master...build_depends_debug_flags) https://github.com/bitcoin/bitcoin/pull/26393
752022-12-05T11:17:30 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #26640: test: Run mempool_compatibility.py with MiniWallet (master...2212-test-mini-wallet-mempool-ð) https://github.com/bitcoin/bitcoin/pull/26640
762022-12-05T11:19:14 <bitcoin-git> [bitcoin] fanquake closed pull request #25695: tidy: add modernize-use-using (master...tidy_modernize_use_using) https://github.com/bitcoin/bitcoin/pull/25695
772022-12-05T11:28:17 <bitcoin-git> [bitcoin] fanquake closed pull request #25172: refactor: use std:: prefix for std lib funcs (master...use_std_variants) https://github.com/bitcoin/bitcoin/pull/25172
782022-12-05T11:41:08 <bitcoin-git> [bitcoin] hebasto closed pull request #24798: [POC] build: Hello Qt 6 (master...220406-qt6) https://github.com/bitcoin/bitcoin/pull/24798
792022-12-05T11:43:27 <bitcoin-git> [bitcoin] fanquake closed pull request #19860: p2p: Improve diversification of new connections (master...2020-09-diverse-new-conn-fixes) https://github.com/bitcoin/bitcoin/pull/19860
802022-12-05T11:45:33 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8b796866b493...71abee86dba8
812022-12-05T11:45:34 <bitcoin-git> bitcoin/master 874c861 willcl-ark: doc: Add I2P bandwidth guidance to i2p.md
822022-12-05T11:45:34 <bitcoin-git> bitcoin/master 71abee8 fanquake: Merge bitcoin/bitcoin#25993: doc: Add I2P guidance related to bandwidth an...
832022-12-05T11:45:44 <bitcoin-git> [bitcoin] fanquake merged pull request #25993: doc: Add I2P guidance related to bandwidth and i2pd software version (master...i2pd_bandwidth) https://github.com/bitcoin/bitcoin/pull/25993
842022-12-05T11:51:50 <bitcoin-git> [bitcoin] fanquake closed pull request #25893: doc: Clarify multiple wallets for same signer (final) (master...external_signer) https://github.com/bitcoin/bitcoin/pull/25893
852022-12-05T12:15:02 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has joined #bitcoin-core-dev
862022-12-05T13:03:22 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/71abee86dba8...5b3f05b7eb76
872022-12-05T13:03:22 <bitcoin-git> bitcoin/master f39d926 Sjors Provoost: rpc: warn that nodes ignore requests for old stale blocks
882022-12-05T13:03:23 <bitcoin-git> bitcoin/master 5b3f05b MarcoFalke: Merge bitcoin/bitcoin#24226: rpc: warn that nodes ignore requests for old ...
892022-12-05T13:03:36 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24226: rpc: warn that nodes ignore requests for old stale blocks (master...2022/02/dontfetcholdblocks) https://github.com/bitcoin/bitcoin/pull/24226
902022-12-05T13:28:25 *** greypw2546002 <greypw2546002!~greypw254@grey.pw> has quit IRC (Quit: I'll be back!)
912022-12-05T13:28:59 *** greypw2546002 <greypw2546002!~greypw254@grey.pw> has joined #bitcoin-core-dev
922022-12-05T13:43:28 *** robertnielsen <robertnielsen!~robertnie@c-67-164-56-127.hsd1.ca.comcast.net> has quit IRC (Quit: Ping timeout (120 seconds))
932022-12-05T14:30:54 <bitcoin-git> [gui] john-moffett opened pull request #684: Improve 'Requested Payments History' Multiselect (master...2022_12_FixReceiveCoinsMultiselect) https://github.com/bitcoin-core/gui/pull/684
942022-12-05T14:54:41 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has quit IRC (Remote host closed the connection)
952022-12-05T14:55:08 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has joined #bitcoin-core-dev
962022-12-05T14:55:17 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
972022-12-05T14:57:00 *** halosghost <halosghost!~halosghos@user/halosghost> has joined #bitcoin-core-dev
982022-12-05T15:00:02 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has quit IRC (Ping timeout: 265 seconds)
992022-12-05T15:05:55 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has joined #bitcoin-core-dev
1002022-12-05T15:10:23 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has quit IRC (Ping timeout: 264 seconds)
1012022-12-05T15:13:29 *** ziggie <ziggie!uid521459@user/ziggie> has joined #bitcoin-core-dev
1022022-12-05T15:16:33 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1032022-12-05T15:19:23 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Ping timeout: 255 seconds)
1042022-12-05T15:24:04 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5b3f05b7eb76...38cbf43dee92
1052022-12-05T15:24:04 <bitcoin-git> bitcoin/master 0b78110 kouloumos: test: Move tx creation to create_self_transfer_multi
1062022-12-05T15:24:04 <bitcoin-git> bitcoin/master 38cbf43 MarcoFalke: Merge bitcoin/bitcoin#26414: test: Move tx creation to create_self_transfe...
1072022-12-05T15:24:14 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #26414: test: Move tx creation to create_self_transfer_multi (master...modify-create_self_transfer) https://github.com/bitcoin/bitcoin/pull/26414
1082022-12-05T15:26:24 <bitcoin-git> [bitcoin] fanquake pushed 4 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/1b05169c321d...6fd35e2cb18d
1092022-12-05T15:26:24 <bitcoin-git> bitcoin/22.x 99e0ccc fanquake: build: bump version to 22.1 final
1102022-12-05T15:26:24 <bitcoin-git> bitcoin/22.x 45355ec fanquake: doc: update manual pages for 22.1
1112022-12-05T15:26:25 <bitcoin-git> bitcoin/22.x 8cc07f7 fanquake: doc: update release notes for 22.1
1122022-12-05T15:26:26 <bitcoin-git> [bitcoin] fanquake merged pull request #26639: [22.x] bump version to v22.1 (22.x...22_1_final) https://github.com/bitcoin/bitcoin/pull/26639
1132022-12-05T15:27:39 <bitcoin-git> [bitcoin] fanquake closed pull request #26238: clang-tidy: fixup named argument comments (master...fix_named_argument_cmnts) https://github.com/bitcoin/bitcoin/pull/26238
1142022-12-05T15:27:56 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 255 seconds)
1152022-12-05T15:28:55 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
1162022-12-05T15:30:40 <bitcoin-git> [bitcoin] fanquake pushed tag v22.1: https://github.com/bitcoin/bitcoin/compare/v22.1
1172022-12-05T15:30:48 <fanquake> well belated, but we've made it to a v22.1
1182022-12-05T15:31:03 <fanquake> ð
1192022-12-05T15:32:07 *** sturles <sturles!~sturles@smaug.uio.no> has quit IRC (Read error: Connection reset by peer)
1202022-12-05T15:35:01 *** sturles <sturles!~sturles@smaug.uio.no> has joined #bitcoin-core-dev
1212022-12-05T15:50:43 <bitcoin-git> [bitcoin] fanquake reopened pull request #26238: clang-tidy: fixup named argument comments (master...fix_named_argument_cmnts) https://github.com/bitcoin/bitcoin/pull/26238
1222022-12-05T15:51:01 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has joined #bitcoin-core-dev
1232022-12-05T15:54:44 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1242022-12-05T15:55:34 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has quit IRC (Ping timeout: 256 seconds)
1252022-12-05T16:01:47 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has joined #bitcoin-core-dev
1262022-12-05T16:02:40 *** Cory <Cory!~Cory@user/pasha> has quit IRC (Ping timeout: 268 seconds)
1272022-12-05T16:03:13 *** Cory <Cory!~Cory@068-187-125-109.res.spectrum.com> has joined #bitcoin-core-dev
1282022-12-05T16:06:19 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has quit IRC (Ping timeout: 252 seconds)
1292022-12-05T16:08:13 *** Cory <Cory!~Cory@068-187-125-109.res.spectrum.com> has quit IRC (Ping timeout: 268 seconds)
1302022-12-05T16:14:12 *** Cory <Cory!~Cory@068-187-125-109.res.spectrum.com> has joined #bitcoin-core-dev
1312022-12-05T16:18:44 *** brunoerg <brunoerg!~brunoerg@187.183.43.178> has joined #bitcoin-core-dev
1322022-12-05T16:23:05 *** brunoerg <brunoerg!~brunoerg@187.183.43.178> has quit IRC (Ping timeout: 246 seconds)
1332022-12-05T16:29:31 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has joined #bitcoin-core-dev
1342022-12-05T16:30:55 *** john-moffett <john-moffett!~john-moff@pool-108-24-170-15.cmdnnj.fios.verizon.net> has joined #bitcoin-core-dev
1352022-12-05T16:34:23 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has quit IRC (Ping timeout: 264 seconds)
1362022-12-05T16:34:45 *** zeropoint <zeropoint!~alex@c-67-169-157-130.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
1372022-12-05T16:57:20 *** salvatoshi <salvatoshi!~salvatosh@genymobile-2-6-86.fib.nerim.net> has quit IRC (Ping timeout: 256 seconds)
1382022-12-05T16:57:45 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has joined #bitcoin-core-dev
1392022-12-05T17:01:30 <bitcoin-git> [bitcoin] achow101 pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/38cbf43dee92...f0c4807a6a9b
1402022-12-05T17:01:31 <bitcoin-git> bitcoin/master f930aef furszy: wallet: bugfix, 'CoinsResult::Erase' is erasing only one output of the set
1412022-12-05T17:01:31 <bitcoin-git> bitcoin/master 341ba7f furszy: test: wallet, coverage for CoinsResult::Erase function
1422022-12-05T17:01:31 <bitcoin-git> bitcoin/master cf79384 furszy: test: Coin Selection, duplicated preset inputs selection
1432022-12-05T17:01:40 <bitcoin-git> [bitcoin] achow101 merged pull request #26560: wallet: bugfix, invalid CoinsResult cached total amount (master...2022_wallet_bugfix_coinsresult) https://github.com/bitcoin/bitcoin/pull/26560
1442022-12-05T17:02:19 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has quit IRC (Ping timeout: 265 seconds)
1452022-12-05T17:12:22 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
1462022-12-05T17:14:23 *** salvatoshi <salvatoshi!~salvatosh@lfbn-idf3-1-330-185.w83-199.abo.wanadoo.fr> has joined #bitcoin-core-dev
1472022-12-05T17:17:53 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has joined #bitcoin-core-dev
1482022-12-05T17:22:19 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has quit IRC (Ping timeout: 248 seconds)
1492022-12-05T17:28:41 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has joined #bitcoin-core-dev
1502022-12-05T17:33:04 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has quit IRC (Ping timeout: 260 seconds)
1512022-12-05T17:35:17 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Ping timeout: 255 seconds)
1522022-12-05T17:36:42 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
1532022-12-05T17:39:20 *** halosghost <halosghost!~halosghos@user/halosghost> has quit IRC (Read error: Connection reset by peer)
1542022-12-05T17:39:27 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f0c4807a6a9b...7734a0160deb
1552022-12-05T17:39:28 <bitcoin-git> bitcoin/master fa43f60 MarcoFalke: test: Run mempool_compatibility.py with MiniWallet
1562022-12-05T17:39:28 <bitcoin-git> bitcoin/master 7734a01 Andrew Chow: Merge bitcoin/bitcoin#26640: test: Run mempool_compatibility.py with MiniW...
1572022-12-05T17:39:34 <bitcoin-git> [bitcoin] achow101 merged pull request #26640: test: Run mempool_compatibility.py with MiniWallet (master...2212-test-mini-wallet-mempool-ð) https://github.com/bitcoin/bitcoin/pull/26640
1582022-12-05T17:42:30 *** halosghost <halosghost!~halosghos@user/halosghost> has joined #bitcoin-core-dev
1592022-12-05T17:43:41 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
1602022-12-05T17:49:21 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has joined #bitcoin-core-dev
1612022-12-05T17:51:07 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
1622022-12-05T17:51:29 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
1632022-12-05T18:04:32 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Ping timeout: 255 seconds)
1642022-12-05T18:04:47 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC ()
1652022-12-05T18:08:39 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1662022-12-05T18:17:06 <bitcoin-git> [bitcoin] fanquake closed pull request #26559: [24.x] wallet: bugfix, double-counted preset inputs during Coin Selection (24.x...2022_v24_wallet_sad) https://github.com/bitcoin/bitcoin/pull/26559
1672022-12-05T18:25:56 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
1682022-12-05T18:33:19 *** sipsorcery <sipsorcery!~sipsorcer@2a02:8084:6180:500::12b> has joined #bitcoin-core-dev
1692022-12-05T18:35:07 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8ae2:982c:cc52:1229:b1a3> has quit IRC ()
1702022-12-05T18:40:45 *** salvatoshi <salvatoshi!~salvatosh@lfbn-idf3-1-330-185.w83-199.abo.wanadoo.fr> has quit IRC (Quit: Leaving)
1712022-12-05T18:40:49 <bitcoin-git> [bitcoin] hebasto opened pull request #26642: clang-tidy: Add more `performance-*` checks and related fixes (master...221205-ci-tidy) https://github.com/bitcoin/bitcoin/pull/26642
1722022-12-05T18:52:01 *** halosghost <halosghost!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 3.7.1)
1732022-12-05T19:07:14 <achow101> guix builders: 22.1 code signatures are pushed
1742022-12-05T19:11:27 *** berndj <berndj!~berndj@197.189.254.139> has quit IRC (Quit: ZNC - http://znc.in)
1752022-12-05T19:15:56 *** berndj <berndj!~berndj@197.189.254.139> has joined #bitcoin-core-dev
1762022-12-05T19:20:09 *** someone235 <someone235!uid419897@id-419897.ilkley.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
1772022-12-05T19:29:17 <furszy> fanquake: shouldn't we add some release-notes for the wallet's bug on the 24.x branch?
1782022-12-05T19:30:39 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has quit IRC (Remote host closed the connection)
1792022-12-05T19:30:46 <fanquake> We could add a note, but that doesnât need to be part of that backport PR.
1802022-12-05T19:32:31 *** yanmaani1 <yanmaani1!~yanmaani@gateway/tor-sasl/yanmaani> has joined #bitcoin-core-dev
1812022-12-05T19:33:19 <furszy> hmm, would make sense to target master with that?
1822022-12-05T19:33:30 <fanquake> What do you mean
1832022-12-05T19:34:04 <furszy> open a PR targeting master that adds a small release-notes for v24.0.1
1842022-12-05T19:34:14 <fanquake> Thatâs not required
1852022-12-05T19:34:42 <fanquake> Iâll deal with release notes and version bumping tomorrow, after the backports have actually been reviewed.
1862022-12-05T19:34:43 <achow101> We can just update the draft for 24.0 in the dev wiki and copy that over during the final release process
1872022-12-05T19:36:45 <fanquake> Thereâs not really much that needs updating in any case. We can add a note that 24.0 was a no-op. Thatâs about it.
1882022-12-05T19:37:30 <furszy> ok great. The PR master targeting master wasn't making much sense in my head. While we add a note/warning for users who upgraded to 24 and use the manual input selection functionality, we are golden.
1892022-12-05T20:10:46 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
1902022-12-05T20:41:42 <bitcoin-git> [bitcoin] achow101 opened pull request #26643: wallet: Move fee underpayment check to after all fee has been set (master...move-fee-underpay-check) https://github.com/bitcoin/bitcoin/pull/26643
1912022-12-05T20:42:53 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
1922022-12-05T21:41:14 *** metallicc <metallicc!metallicc@gateway/vpn/protonvpn/metallicc> has joined #bitcoin-core-dev
1932022-12-05T21:45:03 <bitcoin-git> [bitcoin] furszy opened pull request #26644: wallet: bugfix, 'wallet_load_ckey' unit test fails with bdb (master...2022_walletdb_fix_bdb_deadlock) https://github.com/bitcoin/bitcoin/pull/26644
1942022-12-05T22:09:02 *** robertnielsen <robertnielsen!~robertnie@c-67-164-56-127.hsd1.ca.comcast.net> has joined #bitcoin-core-dev
1952022-12-05T22:09:12 *** metallicc <metallicc!metallicc@gateway/vpn/protonvpn/metallicc> has quit IRC (Quit: Leaving)
1962022-12-05T22:16:05 *** metallicc <metallicc!metallicc@gateway/vpn/protonvpn/metallicc> has joined #bitcoin-core-dev
1972022-12-05T22:35:09 *** rozehnal_paul <rozehnal_paul!~rozehnal_@bras-base-barion1858w-grc-72-70-49-87-200.dsl.bell.ca> has joined #bitcoin-core-dev
1982022-12-05T22:38:02 <bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7734a0160deb...2ce3d26757ed
1992022-12-05T22:38:03 <bitcoin-git> bitcoin/master 349ed2a Sebastian Falbesoner: wallet: throw error if legacy entries are present on loading descriptor wa...
2002022-12-05T22:38:03 <bitcoin-git> bitcoin/master 3198e42 Sebastian Falbesoner: test: check that loading descriptor wallet with legacy entries throws error
2012022-12-05T22:38:03 <bitcoin-git> bitcoin/master 2ce3d26 Andrew Chow: Merge bitcoin/bitcoin#26462: wallet: fix crash on loading descriptor walle...
2022022-12-05T22:38:10 <bitcoin-git> [bitcoin] achow101 merged pull request #26462: wallet: fix crash on loading descriptor wallet containing legacy key type entries (master...202211-wallet_fix_crash_on_descriptor_wallet_load) https://github.com/bitcoin/bitcoin/pull/26462
2032022-12-05T22:46:55 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
2042022-12-05T22:47:07 <bitcoin-git> [bitcoin] achow101 pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/2ce3d26757ed...5d9b5305af4a
2052022-12-05T22:47:08 <bitcoin-git> bitcoin/master cb94db1 Fabian Jahr: validation, index: Add unspendable coinbase helper functions
2062022-12-05T22:47:08 <bitcoin-git> bitcoin/master 2ca5a49 Fabian Jahr: rpc: Improve getblockstats
2072022-12-05T22:47:09 <bitcoin-git> bitcoin/master ba9d288 Fabian Jahr: test: Fix getblockstats test data generator
2082022-12-05T22:47:18 <bitcoin-git> [bitcoin] achow101 merged pull request #19888: rpc, test: Improve getblockstats for unspendables (master...genesisblockstats) https://github.com/bitcoin/bitcoin/pull/19888
2092022-12-05T23:07:05 *** rozehnal_paul <rozehnal_paul!~rozehnal_@bras-base-barion1858w-grc-72-70-49-87-200.dsl.bell.ca> has quit IRC (Quit: Connection closed)
2102022-12-05T23:09:03 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Remote host closed the connection)
2112022-12-05T23:12:25 *** metallicc <metallicc!metallicc@gateway/vpn/protonvpn/metallicc> has quit IRC (Quit: Leaving)
2122022-12-05T23:14:54 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
2132022-12-05T23:20:05 *** metallicc <metallicc!metallicc@gateway/vpn/protonvpn/metallicc> has joined #bitcoin-core-dev