12023-04-14T00:06:48 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has joined #bitcoin-core-dev
22023-04-14T00:11:05 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has quit IRC (Ping timeout: 246 seconds)
32023-04-14T00:43:00 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
42023-04-14T00:47:49 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 276 seconds)
52023-04-14T00:49:36 *** vysn <vysn!~vysn@user/vysn> has quit IRC (Quit: WeeChat 3.8)
62023-04-14T00:58:23 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: leaving)
72023-04-14T01:00:48 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 250 seconds)
82023-04-14T01:04:16 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has joined #bitcoin-core-dev
92023-04-14T01:09:36 *** b_101 <b_101!~robert@189.217.89.101> has joined #bitcoin-core-dev
102023-04-14T01:27:39 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
112023-04-14T01:32:30 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Remote host closed the connection)
122023-04-14T01:32:56 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has joined #bitcoin-core-dev
132023-04-14T01:39:10 *** pablomartin <pablomartin!~pablomart@89.38.69.214> has quit IRC (Ping timeout: 276 seconds)
142023-04-14T01:40:23 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has quit IRC (Ping timeout: 264 seconds)
152023-04-14T01:44:27 *** Earnestly <Earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 255 seconds)
162023-04-14T02:11:08 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has joined #bitcoin-core-dev
172023-04-14T02:15:41 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has quit IRC (Ping timeout: 265 seconds)
182023-04-14T02:51:26 <sipa> @real_or_random Seems your guess about what was wrong was indeed right, though I had to also prevent some Bitcoin Core CI linters from checking the libsecp python script.
192023-04-14T02:52:44 <sipa> I think that's correct in that core's CI shouldn't enforce its lint standards on subtrees, but also independently... it'd probably be better quality python code if we did address some of the lint findings.
202023-04-14T02:54:01 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has joined #bitcoin-core-dev
212023-04-14T02:57:29 *** Guest40 <Guest40!~Guest40@174.34.8.234.reverse.socket.net> has joined #bitcoin-core-dev
222023-04-14T02:57:47 *** Guest40 <Guest40!~Guest40@174.34.8.234.reverse.socket.net> has quit IRC (Client Quit)
232023-04-14T02:58:42 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has quit IRC (Ping timeout: 265 seconds)
242023-04-14T03:04:45 *** Guest6337 <Guest6337!~Guest63@2600:4040:93a6:d00:641e:59a9:4d9f:a661> has joined #bitcoin-core-dev
252023-04-14T03:04:56 *** Guest6337 <Guest6337!~Guest63@2600:4040:93a6:d00:641e:59a9:4d9f:a661> has quit IRC (Client Quit)
262023-04-14T03:09:47 *** mikehu44 <mikehu44!~quassel@mail.micro-contiuum.info> has joined #bitcoin-core-dev
272023-04-14T03:19:25 *** b_101 <b_101!~robert@189.217.89.101> has quit IRC (Ping timeout: 240 seconds)
282023-04-14T03:27:28 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has joined #bitcoin-core-dev
292023-04-14T03:29:06 *** mikehu44 <mikehu44!~quassel@mail.micro-contiuum.info> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
302023-04-14T03:31:55 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has quit IRC (Ping timeout: 252 seconds)
312023-04-14T03:35:04 *** Wellhungwguy73 <Wellhungwguy73!~Wellhungw@n58-108-72-119.meb1.vic.optusnet.com.au> has joined #bitcoin-core-dev
322023-04-14T03:35:18 *** Wellhungwguy73 <Wellhungwguy73!~Wellhungw@n58-108-72-119.meb1.vic.optusnet.com.au> has quit IRC (Client Quit)
332023-04-14T03:45:15 *** b_101 <b_101!~robert@189.217.89.101> has joined #bitcoin-core-dev
342023-04-14T03:50:25 *** b_101 <b_101!~robert@189.217.89.101> has quit IRC (Ping timeout: 265 seconds)
352023-04-14T03:52:27 *** test_ <test_!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
362023-04-14T03:55:47 *** flooded <flooded!~flooded@169.150.254.33> has quit IRC (Ping timeout: 246 seconds)
372023-04-14T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
382023-04-14T04:01:33 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
392023-04-14T04:12:04 *** ryanofsky <ryanofsky!~russ@jumpy.yanofsky.org> has quit IRC (Ping timeout: 252 seconds)
402023-04-14T04:12:15 *** ryanofsky <ryanofsky!russ@jumpy.yanofsky.org> has joined #bitcoin-core-dev
412023-04-14T04:14:51 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
422023-04-14T04:15:53 <bitcoin-git> [bitcoin] 1440000bytes closed pull request #27454: doc: remove incorrect line from example (master...walletcreatefundedpsbt-example) https://github.com/bitcoin/bitcoin/pull/27454
432023-04-14T04:19:16 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 250 seconds)
442023-04-14T04:47:55 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
452023-04-14T04:52:33 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 255 seconds)
462023-04-14T05:03:17 <real_or_random> makes sense
472023-04-14T05:23:54 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has joined #bitcoin-core-dev
482023-04-14T05:28:32 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has quit IRC (Ping timeout: 265 seconds)
492023-04-14T05:49:26 <fanquake> the python lint stuff doesnât need to be a blocker, we can just exclude the subtree
502023-04-14T06:00:31 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has quit IRC (Quit: jarthur_)
512023-04-14T06:05:31 *** b_101 <b_101!~robert@187.202.174.64> has joined #bitcoin-core-dev
522023-04-14T06:07:01 <real_or_random> https://github.com/bitcoin-core/secp256k1/pull/1276 is a hotfix that fixes the build issue
532023-04-14T06:11:44 *** b_101 <b_101!~robert@187.202.174.64> has quit IRC (Ping timeout: 252 seconds)
542023-04-14T06:20:40 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
552023-04-14T06:24:48 *** nanotube <nanotube!~nanotube@user/nanotube> has quit IRC (Ping timeout: 255 seconds)
562023-04-14T06:25:05 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 240 seconds)
572023-04-14T06:28:54 *** puchka <puchka!~puchka@185.203.122.136> has joined #bitcoin-core-dev
582023-04-14T06:38:06 *** nanotube <nanotube!~nanotube@user/nanotube> has joined #bitcoin-core-dev
592023-04-14T07:11:11 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has joined #bitcoin-core-dev
602023-04-14T07:15:46 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has quit IRC (Ping timeout: 252 seconds)
612023-04-14T07:17:21 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
622023-04-14T07:17:32 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Read error: Connection reset by peer)
632023-04-14T07:26:47 *** Earnestly <Earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
642023-04-14T07:43:11 *** aielima <aielima!~aielima@user/aielima> has joined #bitcoin-core-dev
652023-04-14T07:43:12 *** martinus_ <martinus_!~martinus@046125249120.public.t-mobile.at> has quit IRC (Remote host closed the connection)
662023-04-14T07:43:52 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has joined #bitcoin-core-dev
672023-04-14T07:44:40 *** martinus <martinus!~martinus@046125249120.public.t-mobile.at> has joined #bitcoin-core-dev
682023-04-14T07:48:08 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has quit IRC (Ping timeout: 246 seconds)
692023-04-14T07:55:57 *** martinus <martinus!~martinus@046125249120.public.t-mobile.at> has quit IRC (Remote host closed the connection)
702023-04-14T07:57:38 *** martinus <martinus!~martinus@046125249120.public.t-mobile.at> has joined #bitcoin-core-dev
712023-04-14T08:02:04 *** martinus_ <martinus_!~martinus@046125249120.public.t-mobile.at> has joined #bitcoin-core-dev
722023-04-14T08:02:04 *** martinus <martinus!~martinus@046125249120.public.t-mobile.at> has quit IRC (Read error: Connection reset by peer)
732023-04-14T08:03:07 *** martinus_ <martinus_!~martinus@046125249120.public.t-mobile.at> has quit IRC (Remote host closed the connection)
742023-04-14T08:04:15 *** martinus <martinus!~martinus@046125249120.public.t-mobile.at> has joined #bitcoin-core-dev
752023-04-14T08:15:59 *** b_101 <b_101!~robert@187.202.174.64> has joined #bitcoin-core-dev
762023-04-14T08:18:01 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
772023-04-14T08:21:31 *** b_101 <b_101!~robert@187.202.174.64> has quit IRC (Ping timeout: 276 seconds)
782023-04-14T08:22:55 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 260 seconds)
792023-04-14T08:39:31 *** pablomartin <pablomartin!~pablomart@89.38.69.212> has joined #bitcoin-core-dev
802023-04-14T09:10:02 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has joined #bitcoin-core-dev
812023-04-14T09:14:35 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has quit IRC (Ping timeout: 264 seconds)
822023-04-14T09:24:01 *** pablomartin <pablomartin!~pablomart@89.38.69.212> has quit IRC (Ping timeout: 240 seconds)
832023-04-14T09:30:25 *** Earnestly <Earnestly!~earnest@user/earnestly> has quit IRC (Ping timeout: 276 seconds)
842023-04-14T09:45:02 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has joined #bitcoin-core-dev
852023-04-14T09:50:31 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has quit IRC (Ping timeout: 260 seconds)
862023-04-14T09:56:35 *** b_101 <b_101!~robert@187.202.174.64> has joined #bitcoin-core-dev
872023-04-14T09:59:40 *** greypw25460021 <greypw25460021!~greypw254@grey.pw> has quit IRC (Quit: I'll be back!)
882023-04-14T09:59:50 *** greypw25460021 <greypw25460021!~greypw254@grey.pw> has joined #bitcoin-core-dev
892023-04-14T10:00:54 *** b_101 <b_101!~robert@187.202.174.64> has quit IRC (Ping timeout: 252 seconds)
902023-04-14T10:04:50 <bitcoin-git> [bitcoin] fanquake opened pull request #27462: depends: fix compiling bdb with clang-16 (master...fix_bdb_clang_16) https://github.com/bitcoin/bitcoin/pull/27462
912023-04-14T10:05:33 <fanquake> real_or_random: great. also, it makes no difference to us wether you make an new release with the fix or not, as we'll just pull master into our subtree
922023-04-14T10:13:12 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has joined #bitcoin-core-dev
932023-04-14T10:14:20 *** plvicente <plvicente!~plvicente@a109-49-55-159.cpe.netcabo.pt> has joined #bitcoin-core-dev
942023-04-14T10:18:05 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has quit IRC (Ping timeout: 265 seconds)
952023-04-14T10:37:50 *** vysn <vysn!~vysn@user/vysn> has joined #bitcoin-core-dev
962023-04-14T10:42:34 *** dviola <dviola!~diego@user/dviola> has joined #bitcoin-core-dev
972023-04-14T10:44:25 *** pablomartin <pablomartin!~pablomart@109.70.150.217> has joined #bitcoin-core-dev
982023-04-14T10:45:28 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has joined #bitcoin-core-dev
992023-04-14T10:47:55 *** b_101 <b_101!~robert@187.202.174.64> has joined #bitcoin-core-dev
1002023-04-14T10:50:01 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has quit IRC (Ping timeout: 240 seconds)
1012023-04-14T10:52:05 *** b_101 <b_101!~robert@187.202.174.64> has quit IRC (Ping timeout: 240 seconds)
1022023-04-14T11:18:06 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has joined #bitcoin-core-dev
1032023-04-14T11:19:20 *** pakaro <pakaro!~quassel@cst2-172-111.cust.vodafone.cz> has joined #bitcoin-core-dev
1042023-04-14T11:19:20 *** realies <realies!~realies@user/realies> has quit IRC (Read error: Connection reset by peer)
1052023-04-14T11:19:30 *** pakaro <pakaro!~quassel@cst2-172-111.cust.vodafone.cz> has quit IRC (Client Quit)
1062023-04-14T11:21:34 *** realies <realies!~realies@user/realies> has joined #bitcoin-core-dev
1072023-04-14T11:22:51 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:48f3:2d3e:54a0:acfa> has quit IRC (Ping timeout: 248 seconds)
1082023-04-14T11:22:53 *** Guest67 <Guest67!~Guest67@2a02:cb80:420a:a22:dd70:c65a:e53:2351> has joined #bitcoin-core-dev
1092023-04-14T11:42:48 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
1102023-04-14T11:57:28 *** Guest67 <Guest67!~Guest67@2a02:cb80:420a:a22:dd70:c65a:e53:2351> has quit IRC (Ping timeout: 260 seconds)
1112023-04-14T12:16:12 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
1122023-04-14T12:22:21 <real_or_random> yep, we're not planning to make a new release. that bug in the build system is pretty obscure and probably affects only core's ci
1132023-04-14T13:15:00 *** b_101 <b_101!~robert@187.202.174.64> has joined #bitcoin-core-dev
1142023-04-14T13:18:46 *** Guest40 <Guest40!~Guest40@2607:fb90:db85:9d00:5c53:6023:91bb:c78d> has joined #bitcoin-core-dev
1152023-04-14T13:19:24 *** Guest40 <Guest40!~Guest40@2607:fb90:db85:9d00:5c53:6023:91bb:c78d> has quit IRC (Client Quit)
1162023-04-14T13:20:03 *** b_101 <b_101!~robert@187.202.174.64> has quit IRC (Ping timeout: 260 seconds)
1172023-04-14T13:27:08 *** xeno5 <xeno5!~xeno@2a00:23c4:6885:e401:4081:52b2:c6bb:284f> has joined #bitcoin-core-dev
1182023-04-14T13:27:36 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2bfe43db164d...69460bd8bc56
1192023-04-14T13:27:37 <bitcoin-git> bitcoin/master 1fefcf2 Cory Fields: verify-commits: error and exit cleanly when git is too old.
1202023-04-14T13:27:37 <bitcoin-git> bitcoin/master 69460bd Andrew Chow: Merge bitcoin/bitcoin#27461: verify-commits: error and exit cleanly when g...
1212023-04-14T13:27:41 <bitcoin-git> [bitcoin] achow101 merged pull request #27461: verify-commits: error and exit cleanly when git is too old. (master...verify-commits-git-version-error) https://github.com/bitcoin/bitcoin/pull/27461
1222023-04-14T13:29:31 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #27464: fuzz: re-enable prioritisetransaction RPC (master...2304-fuzz-rpc-) https://github.com/bitcoin/bitcoin/pull/27464
1232023-04-14T13:43:21 *** Earnestly <Earnestly!~earnest@user/earnestly> has joined #bitcoin-core-dev
1242023-04-14T13:44:30 *** xeno5 <xeno5!~xeno@2a00:23c4:6885:e401:4081:52b2:c6bb:284f> has quit IRC (Quit: Client closed)
1252023-04-14T14:13:20 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
1262023-04-14T14:13:42 *** jamesob9 <jamesob9!~jamesob@141.156.173.67> has quit IRC (Quit: The Lounge - https://thelounge.chat)
1272023-04-14T14:13:42 *** jamesob <jamesob!~jamesob@141.156.173.67> has quit IRC (Quit: The Lounge - https://thelounge.chat)
1282023-04-14T14:24:12 *** jamesob9 <jamesob9!~jamesob@141.156.173.67> has joined #bitcoin-core-dev
1292023-04-14T14:24:12 *** jamesob <jamesob!~jamesob@141.156.173.67> has joined #bitcoin-core-dev
1302023-04-14T14:30:26 *** b_101 <b_101!~robert@187.202.174.64> has joined #bitcoin-core-dev
1312023-04-14T14:34:22 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
1322023-04-14T14:39:21 *** b_101 <b_101!~robert@187.202.174.64> has quit IRC (Ping timeout: 255 seconds)
1332023-04-14T14:40:20 *** b_101 <b_101!~robert@187.202.174.64> has joined #bitcoin-core-dev
1342023-04-14T14:44:06 *** preimage <preimage!~halosghos@user/halosghost> has joined #bitcoin-core-dev
1352023-04-14T14:44:45 *** b_101 <b_101!~robert@187.202.174.64> has quit IRC (Ping timeout: 240 seconds)
1362023-04-14T15:04:20 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
1372023-04-14T15:07:25 *** test_ is now known as _flood
1382023-04-14T15:17:13 *** jamesob9 <jamesob9!~jamesob@141.156.173.67> has quit IRC (Quit: The Lounge - https://thelounge.chat)
1392023-04-14T15:17:14 *** jamesob <jamesob!~jamesob@141.156.173.67> has quit IRC (Quit: The Lounge - https://thelounge.chat)
1402023-04-14T15:18:57 *** jamesob9 <jamesob9!~jamesob@141.156.173.67> has joined #bitcoin-core-dev
1412023-04-14T15:18:57 *** jamesob <jamesob!~jamesob@141.156.173.67> has joined #bitcoin-core-dev
1422023-04-14T15:37:54 <pinheadmz> I have an open PR to add UNIX sockets to bitcoin, at first just for onion and proxy:
1432023-04-14T15:37:55 <pinheadmz> https://github.com/bitcoin/bitcoin/pull/27375
1442023-04-14T15:38:05 <pinheadmz> prior work in this area (https://github.com/bitcoin/bitcoin/pull/9979)
1452023-04-14T15:38:14 <pinheadmz> set up unix sockets for p2p as well
1462023-04-14T15:38:29 <pinheadmz> so, re: vasild comment: https://github.com/bitcoin/bitcoin/pull/27375#pullrequestreview-1382786000
1472023-04-14T15:38:41 <vasild> 9979 didn't have objections, was closed, I guess, due to lack of interest/too much effort
1482023-04-14T15:38:50 <pinheadmz> fair 'nuff
1492023-04-14T15:39:04 <pinheadmz> my approach is just to start with proxy bc i think its cool Tor supports unix sockets
1502023-04-14T15:39:34 <pinheadmz> so the big Q is... will unix sockets ever be used for P2P? does it need to live in CNetAddr? Or is that just setting up abig mess for networking
1512023-04-14T15:41:16 <vasild> yeah
1522023-04-14T15:41:34 <pinheadmz> I guess the alternative is modifying ConnectSocketDirectly() so it doesnt need a CService for the first arg?
1532023-04-14T15:41:39 <pinheadmz> but some other generic socket container ?
1542023-04-14T15:41:50 <pinheadmz> s/the/one
1552023-04-14T15:42:09 *** ___nick___ <___nick___!~quassel@2a00:23c6:8d9f:f501:cf4f:85c2:2fd4:3b2d> has joined #bitcoin-core-dev
1562023-04-14T15:44:48 <vasild> I played a bit with the Proxy class and changed it so it looks like this: https://www.paste.sh/JckBQgY0#_XZdilNO_CKjwU0FO12Lb-pD
1572023-04-14T15:45:45 <vasild> then adjusting the rest of the code to work with that Proxy is mechanical
1582023-04-14T15:46:09 <vasild> and UNIX socket stuff may be done just inside that Proxy class
1592023-04-14T15:49:42 <vasild> if we would be doing p2p over unix sockets, then maybe this is not necessary
1602023-04-14T15:57:45 <vasild> pinheadmz: I guess that, at the bottom of this, it would be necessary to change the prototype of
1612023-04-14T15:57:48 <vasild> extern std::function<std::unique_ptr<Sock>(const CService&)> CreateSock;
1622023-04-14T15:59:26 <vasild> to have something that creates Sock either from CService or from something else (that tells it to create unix socket)
1632023-04-14T16:02:51 <vasild> or like in https://github.com/bitcoin/bitcoin/pull/27375 have a CService of type "UNIX socket"
1642023-04-14T16:19:18 *** ___nick___ <___nick___!~quassel@2a00:23c6:8d9f:f501:cf4f:85c2:2fd4:3b2d> has quit IRC (Quit: https://quassel-irc.org - Chat comfortably. Anywhere.)
1652023-04-14T16:20:08 *** aielima <aielima!~aielima@user/aielima> has quit IRC (Ping timeout: 255 seconds)
1662023-04-14T16:20:19 *** aielima <aielima!~aielima@user/aielima> has joined #bitcoin-core-dev
1672023-04-14T16:21:20 *** ___nick___ <___nick___!~quassel@2a00:23c6:8d9f:f501:cf4f:85c2:2fd4:3b2d> has joined #bitcoin-core-dev
1682023-04-14T16:22:11 *** ___nick___ <___nick___!~quassel@2a00:23c6:8d9f:f501:cf4f:85c2:2fd4:3b2d> has quit IRC (Client Quit)
1692023-04-14T16:24:09 *** ___nick___ <___nick___!~quassel@2a00:23c6:8d9f:f501:cf4f:85c2:2fd4:3b2d> has joined #bitcoin-core-dev
1702023-04-14T16:30:40 *** b_101 <b_101!~robert@187.202.174.64> has joined #bitcoin-core-dev
1712023-04-14T16:31:47 <pinheadmz> I did add https://github.com/bitcoin/bitcoin/pull/27375/files#diff-3499e52d708f04ebd0bfeec799dd26464ca6bd26a802c700460227c4f41ec4b5R47
1722023-04-14T16:32:07 <pinheadmz> in last push, gives Proxy a bit more personality with its own GetSock()
1732023-04-14T16:35:39 <pinheadmz> another feature this could lead to is unix sockets for RPC ( i think this is mentioned in an open issue too)
1742023-04-14T16:36:06 <pinheadmz> even before going as far as p2p, if we ever want bitcoin to listen to a unix socket (even just for rpc)
1752023-04-14T16:36:24 <vasild> sounds good for rpc
1762023-04-14T16:36:48 <pinheadmz> does rpc even use CService or is it just libevent stuff?
1772023-04-14T16:37:25 *** b_101 <b_101!~robert@187.202.174.64> has quit IRC (Ping timeout: 240 seconds)
1782023-04-14T16:37:47 <vasild> that Proxy::GetSock() needs to go somehow via the CreateSock variable, so that it can be mockable - tests replace CreateSock with some dummy one and then it is certain that no matter which code gets called the test will never create a real socket, e.g.: https://github.com/bitcoin/bitcoin/blob/69460bd8bc56762513b20218b9839c2ae4c40aaf/src/test/fuzz/i2p.cpp#L27-L29
1792023-04-14T16:39:43 <vasild> pinheadmz: I am not sure, but I think the rpc does not use CService to bind and listen on the rpc port
1802023-04-14T16:41:26 <vasild> right: https://github.com/bitcoin/bitcoin/blob/69460bd8bc56762513b20218b9839c2ae4c40aaf/src/httpserver.cpp#L338
1812023-04-14T16:43:53 <bitcoin-git> [bitcoin] Riahiamirreza opened pull request #27465: Fix typo in developer-notes.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/27465
1822023-04-14T16:54:05 *** pablomartin <pablomartin!~pablomart@109.70.150.217> has quit IRC (Ping timeout: 240 seconds)
1832023-04-14T17:08:23 <pinheadmz> vasild if we construct Proxy with string, then Proxy would call Lookup() / LookipNumeric() ? and create the CService internally if its not a UNIX socket
1842023-04-14T17:09:14 <vasild> yes!
1852023-04-14T17:09:57 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has joined #bitcoin-core-dev
1862023-04-14T17:10:00 <vasild> pinheadmz: this was my intention with https://www.paste.sh/JckBQgY0#_XZdilNO_CKjwU0FO12Lb-pD
1872023-04-14T17:10:26 <pinheadmz> yeah im looking at that and then following around where we create Proxy's
1882023-04-14T17:10:42 <vasild> I changed Proxy to look like that and made the code compile with dummy methods that do nothing, but at least it compiles :)
1892023-04-14T17:10:45 <pinheadmz> (init, torcontrol and optionsdialog)
1902023-04-14T17:10:56 <pinheadmz> ha!
1912023-04-14T17:11:18 <vasild> wait, I should push the patch somewhere visible...
1922023-04-14T17:12:11 <pinheadmz> ok and if we did want to connect p2p via unix sockets then it *would* make sense to keep NET_UNIX as a CNetAddr option?
1932023-04-14T17:14:13 <vasild> it is here: https://github.com/vasild/bitcoin/commit/fd6baa3d727f378e4b4023062c7422c5cf00cd84 (the Proxy mods)
1942023-04-14T17:15:00 <vasild> yes, if we do P2P over unix sockets, then we have to expand `enum Network` and CNetAddr with the unix stuff
1952023-04-14T17:18:55 <pinheadmz> so the Q is - follow through with all these proxy mods /vs/ have another Network value
1962023-04-14T17:19:32 <pinheadmz> im not clear on why the latter is techdebt-y ? we have NET_INTERNAL we have to deal with already ...
1972023-04-14T17:23:33 *** pablomartin <pablomartin!~pablomart@109.70.150.218> has joined #bitcoin-core-dev
1982023-04-14T17:24:35 <vasild> "follow through with all these proxy mods /vs/ have another Network value" -- right. Would be nice to get some feedback from people. I guess this mainly depends on our desire to do p2p over unix sockets.
1992023-04-14T17:26:22 <vasild> pinheadmz: I have to look more into it, could be missing something, but it looks to me that adding another NET_UNIX just to tell CreateSock (via CService of type NET_UNIX) to create a different type of socket is a bit too much.
2002023-04-14T17:26:45 <pinheadmz> okie doke
2012023-04-14T17:27:06 <vasild> and now I am starting to think that those Proxy changes (https://github.com/vasild/bitcoin/commit/fd6baa3d727f378e4b4023062c7422c5cf00cd84) make sense on their own, even if we don't do anything with unix sockets
2022023-04-14T17:27:58 <vasild> Lets see if I still think so on Monday... ;-D
2032023-04-14T17:28:20 * vasild afk
2042023-04-14T17:28:27 <sipa> Always good to get a second opinion from your future self.
2052023-04-14T17:31:20 <hebasto> :D
2062023-04-14T17:43:39 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
2072023-04-14T17:47:27 *** pablomartin <pablomartin!~pablomart@109.70.150.218> has quit IRC (Ping timeout: 255 seconds)
2082023-04-14T17:47:37 *** aielima <aielima!~aielima@user/aielima> has quit IRC (Quit: Ciao)
2092023-04-14T17:56:06 *** b_101 <b_101!~robert@187.202.174.64> has joined #bitcoin-core-dev
2102023-04-14T18:44:31 *** re101-canaan-30 <re101-canaan-30!~re101-can@93.175.28.132> has joined #bitcoin-core-dev
2112023-04-14T19:05:56 *** puchka <puchka!~puchka@185.203.122.136> has quit IRC (Quit: leaving)
2122023-04-14T19:18:56 <bitcoin-git> [bitcoin] jonatack opened pull request #27467: p2p: skip netgroup diversity follow-up (master...2023-04-outbound-peer-netgroup-diversity-followups) https://github.com/bitcoin/bitcoin/pull/27467
2132023-04-14T19:28:21 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
2142023-04-14T19:33:12 *** re101-canaan-30 <re101-canaan-30!~re101-can@93.175.28.132> has quit IRC (Quit: Client closed)
2152023-04-14T19:38:25 *** flooded <flooded!~flooded@146.70.202.51> has joined #bitcoin-core-dev
2162023-04-14T19:42:11 *** _flood <_flood!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Ping timeout: 264 seconds)
2172023-04-14T19:47:02 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
2182023-04-14T20:04:23 *** ___nick___ <___nick___!~quassel@2a00:23c6:8d9f:f501:cf4f:85c2:2fd4:3b2d> has quit IRC (Ping timeout: 264 seconds)
2192023-04-14T20:21:20 *** plvicente <plvicente!~plvicente@a109-49-55-159.cpe.netcabo.pt> has quit IRC (Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/)
2202023-04-14T20:59:43 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
2212023-04-14T21:00:02 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
2222023-04-14T21:04:37 *** pablomartin <pablomartin!~pablomart@109.70.150.218> has joined #bitcoin-core-dev
2232023-04-14T21:51:09 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
2242023-04-14T21:51:45 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Quit: Leaving)
2252023-04-14T21:56:08 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Remote host closed the connection)
2262023-04-14T21:56:34 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:6d4c:649b:83aa:4b84> has joined #bitcoin-core-dev
2272023-04-14T22:01:20 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:6d4c:649b:83aa:4b84> has quit IRC (Ping timeout: 260 seconds)
2282023-04-14T22:07:34 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Quit: aллилѹÑа!)
2292023-04-14T22:09:50 *** Guest45 <Guest45!~Guest45@67.6.24.20> has joined #bitcoin-core-dev
2302023-04-14T22:12:22 *** preimage <preimage!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 3.8)
2312023-04-14T22:26:27 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
2322023-04-14T22:29:45 *** pablomartin <pablomartin!~pablomart@109.70.150.218> has quit IRC (Ping timeout: 240 seconds)
2332023-04-14T22:30:50 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 250 seconds)
2342023-04-14T22:34:10 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Read error: Connection reset by peer)
2352023-04-14T22:34:37 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
2362023-04-14T22:36:32 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Client Quit)
2372023-04-14T22:42:45 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:6d4c:649b:83aa:4b84> has joined #bitcoin-core-dev
2382023-04-14T22:47:35 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:6d4c:649b:83aa:4b84> has quit IRC (Ping timeout: 264 seconds)
2392023-04-14T22:49:36 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
2402023-04-14T22:53:52 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has quit IRC (Ping timeout: 248 seconds)
2412023-04-14T22:54:05 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
2422023-04-14T22:56:36 *** in3rsha <in3rsha!~in3rsha@193.32.127.138> has joined #bitcoin-core-dev
2432023-04-14T22:58:25 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 240 seconds)
2442023-04-14T23:03:31 *** in3rsha <in3rsha!~in3rsha@193.32.127.138> has quit IRC (Remote host closed the connection)
2452023-04-14T23:11:13 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:6d4c:649b:83aa:4b84> has joined #bitcoin-core-dev
2462023-04-14T23:16:00 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:6d4c:649b:83aa:4b84> has quit IRC (Ping timeout: 260 seconds)
2472023-04-14T23:17:18 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:6d4c:649b:83aa:4b84> has joined #bitcoin-core-dev
2482023-04-14T23:22:23 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:6d4c:649b:83aa:4b84> has quit IRC (Ping timeout: 264 seconds)
2492023-04-14T23:22:51 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:6d4c:649b:83aa:4b84> has joined #bitcoin-core-dev
2502023-04-14T23:31:23 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:6d4c:649b:83aa:4b84> has quit IRC (Ping timeout: 246 seconds)
2512023-04-14T23:37:58 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:6d4c:649b:83aa:4b84> has joined #bitcoin-core-dev
2522023-04-14T23:42:47 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:6d4c:649b:83aa:4b84> has quit IRC (Ping timeout: 264 seconds)
2532023-04-14T23:45:19 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:6d4c:649b:83aa:4b84> has joined #bitcoin-core-dev
2542023-04-14T23:48:27 <bitcoin-git> [bitcoin] pablomartin4btc opened pull request #27468: bugfix: rest: avoid segfault for invalid URI (master...http-rest-fix-segfault-for-25.0) https://github.com/bitcoin/bitcoin/pull/27468
2552023-04-14T23:49:38 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:6d4c:649b:83aa:4b84> has quit IRC (Ping timeout: 246 seconds)
2562023-04-14T23:57:02 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has joined #bitcoin-core-dev
2572023-04-14T23:59:23 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 246 seconds)