12023-10-05T00:00:54 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
22023-10-05T00:09:22 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
32023-10-05T00:12:21 *** qxs <qxs!~qxs@gateway/tor-sasl/qxs> has quit IRC (Ping timeout: 252 seconds)
42023-10-05T00:13:35 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 240 seconds)
52023-10-05T00:14:17 *** qxs <qxs!~qxs@gateway/tor-sasl/qxs> has joined #bitcoin-core-dev
62023-10-05T00:25:43 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
72023-10-05T00:30:15 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 240 seconds)
82023-10-05T00:30:42 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
92023-10-05T00:35:43 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 264 seconds)
102023-10-05T00:39:49 *** Guest64 <Guest64!~Guest64@2404:3100:188e:9b7d:1:0:ea8:be5a> has joined #bitcoin-core-dev
112023-10-05T00:41:39 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
122023-10-05T00:42:58 *** Guest64 <Guest64!~Guest64@2404:3100:188e:9b7d:1:0:ea8:be5a> has quit IRC (Client Quit)
132023-10-05T00:46:04 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 248 seconds)
142023-10-05T00:53:02 *** Davidson <Davidson!~erik@gateway/tor-sasl/erik-etsuji-kato> has joined #bitcoin-core-dev
152023-10-05T00:53:34 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
162023-10-05T00:55:00 *** Davidson <Davidson!~erik@gateway/tor-sasl/erik-etsuji-kato> has quit IRC (Quit: Davidson)
172023-10-05T00:58:16 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 272 seconds)
182023-10-05T01:16:29 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
192023-10-05T01:21:00 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 240 seconds)
202023-10-05T01:27:16 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
212023-10-05T01:32:01 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 258 seconds)
222023-10-05T01:49:10 *** preimage <preimage!~halosghos@user/halosghost> has joined #bitcoin-core-dev
232023-10-05T01:52:21 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
242023-10-05T01:57:10 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 272 seconds)
252023-10-05T01:59:30 <bitcoin-git> [bitcoin] ajtowns opened pull request #28592: p2p: Increase tx relay rate (master...202310-txrelayrate) https://github.com/bitcoin/bitcoin/pull/28592
262023-10-05T02:07:17 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
272023-10-05T02:09:06 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
282023-10-05T02:11:23 *** realies9 <realies9!~realies@user/realies> has joined #bitcoin-core-dev
292023-10-05T02:13:38 *** realies <realies!~realies@user/realies> has quit IRC (Ping timeout: 272 seconds)
302023-10-05T02:13:39 *** MatrixBot1234561 <MatrixBot1234561!~matrixbot@2001:bc8:1824:bc3::1> has quit IRC (Ping timeout: 272 seconds)
312023-10-05T02:13:39 *** realies9 is now known as realies
322023-10-05T02:14:07 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 264 seconds)
332023-10-05T02:26:38 *** boris- <boris-!~boris@186.106.163.145> has joined #bitcoin-core-dev
342023-10-05T02:27:47 *** boris <boris!~boris@user/boris> has quit IRC (Ping timeout: 255 seconds)
352023-10-05T02:30:15 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
362023-10-05T02:31:11 *** MatrixBot1234561 <MatrixBot1234561!~matrixbot@2001:bc8:1824:bc3::1> has joined #bitcoin-core-dev
372023-10-05T02:36:36 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 240 seconds)
382023-10-05T02:40:55 *** Guest1927 <Guest1927!~diego@187.39.28.74> has left #bitcoin-core-dev
392023-10-05T02:41:17 *** dviola <dviola!~diego@user/dviola> has joined #bitcoin-core-dev
402023-10-05T02:44:04 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
412023-10-05T02:48:05 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 240 seconds)
422023-10-05T03:05:59 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
432023-10-05T03:11:16 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 272 seconds)
442023-10-05T03:11:49 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
452023-10-05T03:16:51 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 260 seconds)
462023-10-05T03:17:18 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
472023-10-05T03:21:51 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 240 seconds)
482023-10-05T03:23:15 *** Guest64 <Guest64!~Guest64@103.118.50.224> has joined #bitcoin-core-dev
492023-10-05T03:23:38 *** Guest64 <Guest64!~Guest64@103.118.50.224> has quit IRC (Client Quit)
502023-10-05T03:28:05 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
512023-10-05T03:32:35 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 240 seconds)
522023-10-05T03:34:10 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
532023-10-05T03:38:31 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 258 seconds)
542023-10-05T03:38:53 *** dviola <dviola!~diego@user/dviola> has quit IRC (Ping timeout: 255 seconds)
552023-10-05T03:39:29 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
562023-10-05T03:40:14 *** diego <diego!~diego@187.39.28.74> has joined #bitcoin-core-dev
572023-10-05T03:40:43 *** diego is now known as Guest8898
582023-10-05T03:42:30 *** Guest8898 <Guest8898!~diego@187.39.28.74> has left #bitcoin-core-dev
592023-10-05T03:42:46 *** dviola <dviola!~diego@user/dviola> has joined #bitcoin-core-dev
602023-10-05T03:48:00 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 272 seconds)
612023-10-05T03:48:28 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
622023-10-05T03:53:05 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 240 seconds)
632023-10-05T03:54:32 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
642023-10-05T03:59:24 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 272 seconds)
652023-10-05T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
662023-10-05T04:01:36 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
672023-10-05T04:22:00 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
682023-10-05T04:26:57 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 260 seconds)
692023-10-05T04:32:02 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
702023-10-05T04:36:29 *** preimage <preimage!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 4.0.5)
712023-10-05T04:36:47 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 258 seconds)
722023-10-05T04:54:22 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
732023-10-05T04:59:27 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 240 seconds)
742023-10-05T05:00:05 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
752023-10-05T05:01:17 *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Ping timeout: 252 seconds)
762023-10-05T05:01:26 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
772023-10-05T05:06:32 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 272 seconds)
782023-10-05T05:07:05 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
792023-10-05T05:12:23 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 255 seconds)
802023-10-05T05:13:55 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
812023-10-05T05:14:25 *** pablomartin <pablomartin!~pablomart@217.146.93.19> has quit IRC (Ping timeout: 255 seconds)
822023-10-05T05:20:36 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 240 seconds)
832023-10-05T05:38:56 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
842023-10-05T05:43:29 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 258 seconds)
852023-10-05T05:45:00 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
862023-10-05T05:50:24 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 258 seconds)
872023-10-05T05:55:42 *** bob_x1 <bob_x1!~bob_x@user/bob-x1/x-8934932> has quit IRC (Remote host closed the connection)
882023-10-05T05:56:08 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
892023-10-05T05:56:08 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
902023-10-05T05:56:26 *** bob_x1 <bob_x1!~bob_x@user/bob-x1/x-8934932> has joined #bitcoin-core-dev
912023-10-05T05:56:26 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
922023-10-05T05:56:34 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
932023-10-05T06:03:20 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
942023-10-05T06:07:35 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 240 seconds)
952023-10-05T06:08:35 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
962023-10-05T06:11:41 *** salvatoshi__ <salvatoshi__!~salvatosh@genymobile-2-6-86.fib.nerim.net> has joined #bitcoin-core-dev
972023-10-05T06:12:47 *** salvatoshi <salvatoshi!~salvatosh@ip-165.net-89-3-198.rev.numericable.fr> has quit IRC (Ping timeout: 255 seconds)
982023-10-05T06:13:00 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 246 seconds)
992023-10-05T06:19:37 *** bob_x1 <bob_x1!~bob_x@user/bob-x1/x-8934932> has quit IRC (Remote host closed the connection)
1002023-10-05T06:19:59 *** bob_x1 <bob_x1!~bob_x@user/bob-x1/x-8934932> has joined #bitcoin-core-dev
1012023-10-05T06:25:06 *** upekkha <upekkha!~Advanced@2a01:4f8:1c0c:49df::1> has quit IRC ()
1022023-10-05T06:25:21 *** upekkha <upekkha!~Advanced@2a01:4f8:1c0c:49df::1> has joined #bitcoin-core-dev
1032023-10-05T06:31:06 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
1042023-10-05T06:35:50 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 272 seconds)
1052023-10-05T07:11:19 *** Guest99 <Guest99!~Guest99@ec2-35-72-149-104.ap-northeast-1.compute.amazonaws.com> has joined #bitcoin-core-dev
1062023-10-05T07:17:04 *** Guest46 <Guest46!~Guest99@ec2-35-72-149-104.ap-northeast-1.compute.amazonaws.com> has joined #bitcoin-core-dev
1072023-10-05T07:18:11 *** salvatoshi__ <salvatoshi__!~salvatosh@genymobile-2-6-86.fib.nerim.net> has quit IRC (Quit: Leaving)
1082023-10-05T07:19:10 *** Guest99 <Guest99!~Guest99@ec2-35-72-149-104.ap-northeast-1.compute.amazonaws.com> has quit IRC (Quit: Client closed)
1092023-10-05T07:19:20 *** Guest46 <Guest46!~Guest99@ec2-35-72-149-104.ap-northeast-1.compute.amazonaws.com> has quit IRC (Client Quit)
1102023-10-05T07:26:39 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
1112023-10-05T07:31:12 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 258 seconds)
1122023-10-05T07:33:46 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
1132023-10-05T07:39:30 <bitcoin-git> [bitcoin] hebasto pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5b4478418b24...0e3de3b83e99
1142023-10-05T07:39:31 <bitcoin-git> bitcoin/master f08adec Hennadii Stepanov: qt: Add "Transport" label to peer details
1152023-10-05T07:39:32 <bitcoin-git> bitcoin/master d9c4e34 Hennadii Stepanov: qt: Add "Session id" label to peer details
1162023-10-05T07:39:32 <bitcoin-git> bitcoin/master 0e3de3b Hennadii Stepanov: Merge bitcoin-core/gui#754: Add BIP324-specific labels to peer details
1172023-10-05T07:39:37 <bitcoin-git> [gui] hebasto merged pull request #754: Add BIP324-specific labels to peer details (master...230911-bip324-peer-details) https://github.com/bitcoin-core/gui/pull/754
1182023-10-05T07:43:04 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
1192023-10-05T07:48:12 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 260 seconds)
1202023-10-05T07:48:39 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
1212023-10-05T07:53:16 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 248 seconds)
1222023-10-05T08:00:11 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
1232023-10-05T08:02:28 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
1242023-10-05T08:04:15 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 240 seconds)
1252023-10-05T08:05:22 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
1262023-10-05T08:10:12 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 272 seconds)
1272023-10-05T08:10:41 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
1282023-10-05T08:27:19 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
1292023-10-05T08:28:18 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC ()
1302023-10-05T08:31:48 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 240 seconds)
1312023-10-05T08:33:11 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
1322023-10-05T08:55:11 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
1332023-10-05T08:59:46 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 258 seconds)
1342023-10-05T09:01:14 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
1352023-10-05T09:06:34 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 272 seconds)
1362023-10-05T09:10:52 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
1372023-10-05T09:21:08 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 272 seconds)
1382023-10-05T09:27:23 *** MatrixBot1234561 <MatrixBot1234561!~matrixbot@2001:bc8:1824:bc3::1> has quit IRC (Quit: Bridge terminating on SIGTERM)
1392023-10-05T09:33:07 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
1402023-10-05T09:43:18 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 272 seconds)
1412023-10-05T09:45:15 <fanquake> To github.com:bitcoin-core/bitcoin-detached-sigs.git
1422023-10-05T09:45:17 <fanquake> * [new tag] v25.1rc1 -> v25.1rc1
1432023-10-05T09:55:23 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
1442023-10-05T09:56:17 *** johnzweng <johnzweng!~johnzweng@zweng.at> has quit IRC (Quit: Leaving...)
1452023-10-05T09:59:20 *** johnzweng <johnzweng!~johnzweng@zweng.at> has joined #bitcoin-core-dev
1462023-10-05T09:59:35 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 240 seconds)
1472023-10-05T10:11:51 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
1482023-10-05T10:16:15 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 240 seconds)
1492023-10-05T10:28:44 <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/0e3de3b83e99...2eacc61ad74c
1502023-10-05T10:28:45 <bitcoin-git> bitcoin/master 7899402 Pieter Wuille: Add headerssync-params.py script to the repository
1512023-10-05T10:28:45 <bitcoin-git> bitcoin/master 53d7d35 Pieter Wuille: Update parameters in headerssync.cpp
1522023-10-05T10:28:46 <bitcoin-git> bitcoin/master 3d420d8 Pieter Wuille: Add instructions for headerssync-params.py to release-process.md
1532023-10-05T10:28:51 <bitcoin-git> [bitcoin] fanquake merged pull request #25970: Add headerssync tuning parameters optimization script to repo (master...202208_headerssync_script) https://github.com/bitcoin/bitcoin/pull/25970
1542023-10-05T11:03:05 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2eacc61ad74c...78fd3c267240
1552023-10-05T11:03:06 <bitcoin-git> bitcoin/master e130896 Sebastian Falbesoner: test: BIP324: add checks for v1 prefix matching / wrong network magic dete...
1562023-10-05T11:03:06 <bitcoin-git> bitcoin/master 78fd3c2 fanquake: Merge bitcoin/bitcoin#28588: test: BIP324: add checks for v1 prefix matchi...
1572023-10-05T11:03:09 *** benwestgate <benwestgate!~BenWestga@035-146-116-090.res.spectrum.com> has joined #bitcoin-core-dev
1582023-10-05T11:03:12 <bitcoin-git> [bitcoin] fanquake merged pull request #28588: test: BIP324: add checks for v1 prefix matching / wrong network magic detection (master...202310-test-add_v1_prefix_detection_wrong_network_magic_check) https://github.com/bitcoin/bitcoin/pull/28588
1592023-10-05T11:13:24 <fanquake> Chasing some eyes over #27609
1602023-10-05T11:13:27 <gribble`> https://github.com/bitcoin/bitcoin/issues/27609 | rpc: allow submitpackage to be called outside of regtest by glozow · Pull Request #27609 · bitcoin/bitcoin · GitHub
1612023-10-05T11:25:51 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
1622023-10-05T11:28:59 *** benwestgate <benwestgate!~BenWestga@035-146-116-090.res.spectrum.com> has quit IRC (Quit: Leaving.)
1632023-10-05T11:30:23 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Ping timeout: 255 seconds)
1642023-10-05T11:30:24 <darosior> I'll have another look
1652023-10-05T11:33:51 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
1662023-10-05T11:35:40 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has joined #bitcoin-core-dev
1672023-10-05T11:41:47 *** pablomartin <pablomartin!~pablomart@217.146.93.22> has joined #bitcoin-core-dev
1682023-10-05T11:51:35 *** pablomartin <pablomartin!~pablomart@217.146.93.22> has quit IRC (Ping timeout: 240 seconds)
1692023-10-05T11:58:08 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #28595: ci: Avoid cache depends/build (master...2310-ci-built-) https://github.com/bitcoin/bitcoin/pull/28595
1702023-10-05T12:06:50 *** benwestgate <benwestgate!~BenWestga@035-146-116-090.res.spectrum.com> has joined #bitcoin-core-dev
1712023-10-05T12:16:53 *** pablomartin <pablomartin!~pablomart@185.216.146.240> has joined #bitcoin-core-dev
1722023-10-05T12:53:52 *** pablomartin <pablomartin!~pablomart@185.216.146.240> has quit IRC (Ping timeout: 255 seconds)
1732023-10-05T13:05:39 *** johnzweng <johnzweng!~johnzweng@zweng.at> has quit IRC (Ping timeout: 246 seconds)
1742023-10-05T13:06:55 <bitcoin-git> [bitcoin] fanquake pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/78fd3c267240...52c6904c7891
1752023-10-05T13:06:56 <bitcoin-git> bitcoin/master 87c7067 dergoegge: [net processing] PeerManager holds a FastRandomContext
1762023-10-05T13:06:56 <bitcoin-git> bitcoin/master a648dd7 dergoegge: [net processing] PushAddress uses PeerManager's rng
1772023-10-05T13:06:56 <bitcoin-git> bitcoin/master 77506f4 dergoegge: [net processing] Addr shuffle uses PeerManager's rng
1782023-10-05T13:07:02 <bitcoin-git> [bitcoin] fanquake merged pull request #28558: Make PeerManager own a FastRandomContext (master...2023-10-peerman-rng) https://github.com/bitcoin/bitcoin/pull/28558
1792023-10-05T13:17:25 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
1802023-10-05T13:20:13 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:e128:5bce:e46a:8007> has quit IRC (Remote host closed the connection)
1812023-10-05T13:39:40 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has joined #bitcoin-core-dev
1822023-10-05T13:41:33 *** brunoerg <brunoerg!~brunoerg@2804:1600:115:e500:70c4:8bf5:6e57:a222> has joined #bitcoin-core-dev
1832023-10-05T13:50:24 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #28597: wallet: No BDB creation, unless -deprecatedrpc=create_bdb (master...2310-less-bdb-) https://github.com/bitcoin/bitcoin/pull/28597
1842023-10-05T13:53:56 *** Guest26 <Guest26!~Guest26@103.114.193.8> has joined #bitcoin-core-dev
1852023-10-05T13:54:24 *** Guest26 <Guest26!~Guest26@103.114.193.8> has quit IRC (Client Quit)
1862023-10-05T14:00:21 <achow101> #startmeeting
1872023-10-05T14:00:31 <gleb> Hi
1882023-10-05T14:00:32 <achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa theStack TheCharlatan vasild
1892023-10-05T14:00:36 <hebasto> hi
1902023-10-05T14:00:36 <pinheadmz> hi!
1912023-10-05T14:00:39 <darosior> hi
1922023-10-05T14:00:39 <stickies-v> hi
1932023-10-05T14:00:45 <brunoerg> hi
1942023-10-05T14:00:47 <laanwj> hii
1952023-10-05T14:00:49 <achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add?
1962023-10-05T14:00:52 <dergoegge> hi
1972023-10-05T14:00:53 <Sjors[m]> Hi
1982023-10-05T14:00:55 <Murch[m]> Hi
1992023-10-05T14:00:56 <glozow> hi
2002023-10-05T14:00:59 <gleb> I have something on erlay
2012023-10-05T14:00:59 <luke-jr> hi
2022023-10-05T14:01:01 <_aj_> hi
2032023-10-05T14:01:02 <lightlike> Hi
2042023-10-05T14:01:07 <furszy> hi
2052023-10-05T14:01:16 <achow101> #topic package relay updates (glozow)
2062023-10-05T14:01:19 <fjahr> hi
2072023-10-05T14:01:29 <sipa> hi
2082023-10-05T14:01:32 <sdaftuar> hi
2092023-10-05T14:01:50 <glozow> #26711 is the blocker PR. I've been trying to address feedback very quickly
2102023-10-05T14:01:53 <gribble`> https://github.com/bitcoin/bitcoin/issues/26711 | validate package transactions with their in-package ancestor sets by glozow · Pull Request #26711 · bitcoin/bitcoin · GitHub
2112023-10-05T14:02:15 <glozow> If people are interested in #27609 for 26.0, please review
2122023-10-05T14:02:18 <gribble`> https://github.com/bitcoin/bitcoin/issues/27609 | rpc: allow submitpackage to be called outside of regtest by glozow · Pull Request #27609 · bitcoin/bitcoin · GitHub
2132023-10-05T14:02:53 <glozow> I've also been working on the p2p changes, making progress on TxDownloadMan fuzzing. But as discussed at coredev, waiting until the mempool stuff is finished before opening
2142023-10-05T14:03:13 <theStack> hi
2152023-10-05T14:03:45 <josie> hi
2162023-10-05T14:03:53 <glozow> Same thing with v3 stuff - waiting until after 26711 is in
2172023-10-05T14:04:19 <glozow> That's it for my updates
2182023-10-05T14:04:28 <Murch[m]> glozow: Iâll start reviewing that today
2192023-10-05T14:04:39 <glozow> Murch: awesome thanks :D
2202023-10-05T14:04:57 <achow101> #topic BIP 324 updates (sipa)
2212023-10-05T14:05:16 <sipa> hi!
2222023-10-05T14:05:23 <sipa> big stuff done
2232023-10-05T14:05:33 <glozow> \o/
2242023-10-05T14:05:34 <achow101> what's left to do? a few followups and the tests?
2252023-10-05T14:05:53 <laanwj> congrats!
2262023-10-05T14:06:03 <sipa> indeed
2272023-10-05T14:06:08 <sipa> and enabling by default
2282023-10-05T14:07:59 <laanwj> what's the plan for that? will the first release with it will have it disabled by default?
2292023-10-05T14:08:48 <sipa> laanwj: i think so
2302023-10-05T14:09:10 <achow101> The tests pr is #28374? are there any open followup prs (I know the 16 byte prefix stuff was merged yesterday)?
2312023-10-05T14:09:13 <gribble`> https://github.com/bitcoin/bitcoin/issues/28374 | test: python cryptography required for BIP 324 functional tests by stratospher · Pull Request #28374 · bitcoin/bitcoin · GitHub
2322023-10-05T14:09:22 <laanwj> makes sense
2332023-10-05T14:09:27 <sipa> there is work to be done with functional tests among other things, and we shouldn't enable things by default before that
2342023-10-05T14:09:34 <cfields> hi
2352023-10-05T14:09:49 <achow101> laanwj: 26.0 (in a few weeks) will have it disabled. hopefully we can enable it for 27.0?
2362023-10-05T14:09:56 <sipa> yeah, exactly
2372023-10-05T14:09:58 <fanquake> the tests pr is #24748
2382023-10-05T14:10:01 <gribble`> https://github.com/bitcoin/bitcoin/issues/24748 | test/BIP324: functional tests for v2 P2P encryption by stratospher · Pull Request #24748 · bitcoin/bitcoin · GitHub
2392023-10-05T14:10:28 <sipa> there are no open PRs beyond that, i think
2402023-10-05T14:10:41 <lightlike> #28374 first I think (which has the crypto part of the tests)
2412023-10-05T14:10:42 <sipa> and #28374
2422023-10-05T14:10:43 <gribble`> https://github.com/bitcoin/bitcoin/issues/28374 | test: python cryptography required for BIP 324 functional tests by stratospher · Pull Request #28374 · bitcoin/bitcoin · GitHub
2432023-10-05T14:10:44 <gribble`> https://github.com/bitcoin/bitcoin/issues/28374 | test: python cryptography required for BIP 324 functional tests by stratospher · Pull Request #28374 · bitcoin/bitcoin · GitHub
2442023-10-05T14:10:47 <achow101> cool
2452023-10-05T14:11:41 <achow101> #topic libbitcoinkernel updates (TheCharlatan)
2462023-10-05T14:11:51 <laanwj> @achow101 yea imo, it's good to have it in 26.0 so enthousiasts can test it, then when there's confidence in it (likely enough to be in another 6 months) it makes sense to enable it by default
2472023-10-05T14:12:26 <theStack> laanwj: +1
2482023-10-05T14:13:18 <achow101> I think nothing has really changed for kernel this week, and TheCharlatan appears to not be here
2492023-10-05T14:13:42 <achow101> #topic assumeutxo updates (jamesob)
2502023-10-05T14:14:04 <fjahr> Not sure if jamesob is here for his victory lab ;) The big one was merged here too.
2512023-10-05T14:14:12 <fjahr> There is a list of follow-ups in #28562 I will address feedback and rebase shortly.
2522023-10-05T14:14:14 <gribble`> https://github.com/bitcoin/bitcoin/issues/28562 | AssumeUTXO follow-ups by fjahr · Pull Request #28562 · bitcoin/bitcoin · GitHub
2532023-10-05T14:14:22 <fjahr> And there is #28590 from ryan which we should try to get into 26. It changes the RPC
2542023-10-05T14:14:24 <luke-jr> still needs something so it doesn't display transactions as confirmed prematurely, right?
2552023-10-05T14:14:24 <gribble`> https://github.com/bitcoin/bitcoin/issues/28590 | assumeutxo: change getchainstates RPC to return a list of chainstates by ryanofsky · Pull Request #28590 · bitcoin/bitcoin · GitHub
2562023-10-05T14:14:38 <luke-jr> or did that get in somewhere already?
2572023-10-05T14:15:14 <fjahr> luke-jr: I don't think so, I don't know what PRs we have open on that off the top of my head
2582023-10-05T14:15:49 <Sjors[m]> luke-jr: it can't be used on mainnet without recompile
2592023-10-05T14:16:00 <fanquake> fjahr: were you planning on including all the post-merge review from 27596 in that PR? Or will be following up with other changes?
2602023-10-05T14:16:10 <fanquake> Quite a lot of post-merge review comments have been left
2612023-10-05T14:16:52 <fjahr> Yeah, I will comment in 27596 and not keep adding more stuff afterwards, so it says reviewable
2622023-10-05T14:16:53 <Sjors[m]> I plan to continue reviewing the original PR and then look at the followup PRs.
2632023-10-05T14:17:37 <fjahr> *so that 28562 stays reviewable, it already has 9 commits, I don't want to grow it much further
2642023-10-05T14:17:55 <Sjors[m]> Seems fine to have multiple followup PRs.
2652023-10-05T14:18:14 <luke-jr> Sjors[m]: I assume that's the goal, though, right?
2662023-10-05T14:18:21 <fjahr> There will surely be more follow-ups
2672023-10-05T14:18:25 <achow101> luke-jr: can you open an issue for that problem?
2682023-10-05T14:18:48 <fanquake> I think we also need to follow up with the release notes/rpc helps, and comparison to assumevalid etc Decide on exactly how this is presented.
2692023-10-05T14:18:55 <luke-jr> ok
2702023-10-05T14:19:03 <Sjors[m]> I haven't really tested GUI behavior for assumeutxo recently, but we should - at least before this becomes easier to use.
2712023-10-05T14:19:16 <fanquake> Multiple followups is fine, as long as we don't make post-branch-off changes to things like the rpc interface
2722023-10-05T14:19:57 <fanquake> Lets make sure most of that is done, if we're going to keep changing it
2732023-10-05T14:20:18 <abubakarsadiq> Hi
2742023-10-05T14:21:06 <achow101> #topic Ad-hoc high priority for review
2752023-10-05T14:21:13 <achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
2762023-10-05T14:22:12 <cfields> last minute topic proposal: cmake pings
2772023-10-05T14:22:16 <achow101> Also reminder that 26.0 feature freeze is this Sunday.
2782023-10-05T14:22:26 <achow101> I don't think there's any need to push it back again
2792023-10-05T14:22:40 *** test_ <test_!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
2802023-10-05T14:22:50 <sipa> i'm continuing to review #27255
2812023-10-05T14:22:53 <gribble`> https://github.com/bitcoin/bitcoin/issues/27255 | MiniTapscript: port Miniscript to Tapscript by darosior · Pull Request #27255 · bitcoin/bitcoin · GitHub
2822023-10-05T14:23:12 <darosior> ð
2832023-10-05T14:23:18 <fanquake> I can't see a reason to. Most stuff on https://github.com/bitcoin/bitcoin/milestone/60 will likely get in
2842023-10-05T14:23:19 <willcl-ark> hi
2852023-10-05T14:23:27 <achow101> sipa: hoping to get that in this weekend too
2862023-10-05T14:24:02 <fanquake> Not sure about #28037. We seem to keep finding bugs in the migration code
2872023-10-05T14:24:03 <gribble`> https://github.com/bitcoin/bitcoin/issues/28037 | rpc: Drop migratewallet experimental warning by achow101 · Pull Request #28037 · bitcoin/bitcoin · GitHub
2882023-10-05T14:24:45 <fanquake> but we do need to get the wallet upgrade path open
2892023-10-05T14:25:08 <achow101> fanquake: no money losing bugs, just weird wallets that aren't migrating
2902023-10-05T14:25:43 <sipa> by "aren't migrating", you mean migration gives a error code, and the migration doesn't happen?
2912023-10-05T14:25:48 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Ping timeout: 246 seconds)
2922023-10-05T14:26:02 <achow101> at least it's in the gui now so more people will be using it
2932023-10-05T14:26:14 <fanquake> more like a segfault
2942023-10-05T14:26:18 <achow101> sipa: more like hitting an assert
2952023-10-05T14:26:29 <fanquake> i.e #28057
2962023-10-05T14:26:30 <gribble`> https://github.com/bitcoin/bitcoin/issues/28057 | migratewallet crashes (wallet/scriptpubkeyman.cpp:1915: std::optional wallet::LegacyScriptPubKeyMan::MigrateToDescriptor(): Assertion `IsMine(desc_spk) != ISMINE_NO failed.) · Issue #28057 · bitcoin/bitcoin · GitHub
2972023-10-05T14:26:31 <luke-jr> fanquake: it's still open, even with a warning
2982023-10-05T14:26:48 <sipa> fanquake: i guess that qualifies as an error code!
2992023-10-05T14:26:49 <_aj_> an assert in the gui is a bit obnoxious?
3002023-10-05T14:27:15 <_aj_> (or is it caught?)
3012023-10-05T14:27:33 <luke-jr> I don't think it's caught at least
3022023-10-05T14:27:39 <achow101> it's at least an attended process (the user had to be there to start it, and is presumably still there)
3032023-10-05T14:28:23 <achow101> for the vast majority of people, it should work correctly
3042023-10-05T14:28:33 <fanquake> luke-jr: yea, i just assume some people are going to avoid it with real funds, while it's still marked experimental
3052023-10-05T14:30:28 <achow101> #topic erlay (gleb)
3062023-10-05T14:30:41 <gleb> I wanted to share that i'm back to work after some absence. Amiti told me she saw some interest in Erlay at core dev, so that makes sense to continue moving it forward
3072023-10-05T14:31:01 <sipa> gleb: great to hear!
3082023-10-05T14:31:02 <gleb> It is already reviewable (#26283 and 21515), and a couple places with data and benchmarking results. I intend to make reviewing it easier. One thing is a tracking issue with FAQ.
3092023-10-05T14:31:05 <gribble`> https://github.com/bitcoin/bitcoin/issues/26283 | p2p: Fill reconciliation sets and request reconciliation (Erlay) by naumenkogs · Pull Request #26283 · bitcoin/bitcoin · GitHub
3102023-10-05T14:31:12 <gleb> Do you have any initial thoughts on it? Anything particular that prevents you from reviewing to be covered?
3112023-10-05T14:31:25 <achow101> tracking issue would be good
3122023-10-05T14:31:33 <gleb> esp. sipa dergoegge brunoerg aureleoules ariard glozow mzumsande â those who already looked at the current PR piece.
3132023-10-05T14:31:46 <josie> gleb: welcome back!
3142023-10-05T14:32:01 <sipa> gleb: i'll review again after 26 branch-off
3152023-10-05T14:32:20 <cfields> ð
3162023-10-05T14:32:39 *** pablomartin <pablomartin!~pablomart@217.146.93.22> has joined #bitcoin-core-dev
3172023-10-05T14:32:41 <gleb> Thank you.
3182023-10-05T14:33:10 <gleb> For others â Itâs not to late to jump on this train. Later on it might be harder to start following it
3192023-10-05T14:33:11 <glozow> Nice that you're back gleb! Yeah I think a tracking issue would be great
3202023-10-05T14:33:29 <luke-jr> harder in what sense?
3212023-10-05T14:34:03 <gleb> Luke-jr youâll have to review previous pr parts which are already merged.
3222023-10-05T14:34:08 <glozow> I suppose a tracking issue would help with that too - people would be able to review the merged PRs if they need to catch up
3232023-10-05T14:34:55 <gleb> Yeah
3242023-10-05T14:35:02 <lightlike> same - I plan to get back to reviewing it in the next weeks!
3252023-10-05T14:35:20 <brunoerg> same here
3262023-10-05T14:36:12 <gleb> Alright, we can move on if there are no comments. Feel free to text me later on â say if you need a call to discuss the code or whatever
3272023-10-05T14:36:26 <gleb> Thank you for your commitments to review.
3282023-10-05T14:36:27 <achow101> #topic cmake pings (cfields)
3292023-10-05T14:36:44 <cfields> Hi all. Sorry for being away for the last 2 weeks, I'll be back at my computer starting tomorrow.
3302023-10-05T14:36:49 <cfields> A quick CMake announcement: At coredev we discussed pinging people individually to test CMake before merge (still a few weeks away at minimum). Not necessarily to get individual ACKS, but to do a rough check to see if your build setup will have any problems post-merge.
3312023-10-05T14:37:00 <cfields> So, once hebasto and I suspect that things are in decent shape, we'll start doing pings for feedback. This is in addition to the PR review itself.
3322023-10-05T14:37:14 <cfields> The goal here is to try to address developers' concerns specifically, since we tend to build with the most non-standard configs. As a random example, if you're building libbitcoinkernel on FreeBSD x86-64 for Linux risc-v, you might run into an edge-case we haven't seen yet.
3332023-10-05T14:37:25 <cfields> tl;dr: if you get a ping request to try your day-to-day workflow with CMake, via IRC, Github, Signals, whatever, please please try to do so. That is a good chance to complain, not after merge :)
3342023-10-05T14:37:29 <luke-jr> cfields: my build system is quite abnormal now, so I'll plan on it (might need a reminder)
3352023-10-05T14:37:48 <cfields> luke-jr: ack, you'll get a ping for sure :)
3362023-10-05T14:37:48 *** Chris_Stewart_5 <Chris_Stewart_5!~Chris_Ste@37.19.200.133> has quit IRC (Ping timeout: 272 seconds)
3372023-10-05T14:38:22 <luke-jr> where is the current codebase btw?
3382023-10-05T14:38:23 <cfields> still a few weeks out. Just wanted to everyone to know it's coming.
3392023-10-05T14:38:43 <sipa> cfields: what is the minimum supported cmake version (assuming there are no additional build dependencies or changes to minimum versions of existing one)?
3402023-10-05T14:38:46 *** brunoerg <brunoerg!~brunoerg@2804:1600:115:e500:70c4:8bf5:6e57:a222> has quit IRC (Remote host closed the connection)
3412023-10-05T14:39:04 *** Chris_Stewart_5 <Chris_Stewart_5!~Chris_Ste@66.63.167.149> has joined #bitcoin-core-dev
3422023-10-05T14:39:16 <hebasto> 3.13
3432023-10-05T14:39:29 <cfields> luke-jr: review is currently happening at hebasto's repo. There's an ubrella PR open in the core repo, but i'm not sure if it's current (sorry, I've been away this week)
3442023-10-05T14:39:32 <cfields> current: https://github.com/hebasto/bitcoin/pull/31
3452023-10-05T14:39:43 <sipa> hebasto: cool
3462023-10-05T14:39:46 <fanquake> If branch of is Sunday, do we have a cut off for how long we are willing to wait, before merging something? i.e 1 month post, then we push it again?
3472023-10-05T14:39:55 <hebasto> however, I will suggest 3.16 considering the time of merging
3482023-10-05T14:40:01 <fanquake> We don't want to do this too deep into the new release cycle.
3492023-10-05T14:40:12 <cfields> sipa: ^^. Definitely up for discussion if it turns out a newer vers would have big benefits though.
3502023-10-05T14:40:22 <achow101> branch off is scheduled for 2 weeks
3512023-10-05T14:40:29 <cfields> fanquake: ack.
3522023-10-05T14:40:42 <hebasto> umbrella pr -- https://github.com/bitcoin/bitcoin/pull/25797
3532023-10-05T14:40:45 <fanquake> I assume people are also already working on all the downstream intregrations etc. So that we don't end up with broken downstreams for too long.
3542023-10-05T14:40:46 <sipa> the oldest system i regularly build on is an ubuntu 20.04, which has cmake 3.16
3552023-10-05T14:41:02 <cfields> at coredev we said ~2 weeks after would be reasonable. That puts us about a month from now.
3562023-10-05T14:41:19 <hebasto> sipa: exactly!
3572023-10-05T14:41:22 <fanquake> Ok.
3582023-10-05T14:42:10 <cfields> That seems reasonable to me, but I must admit I'd hoped to have this week for review and wasn't able, so I'm personally a week behind. But I'll try to catch up next week.
3592023-10-05T14:42:57 <achow101> Any other topics to discuss?
3602023-10-05T14:43:02 <fanquake> Yea
3612023-10-05T14:43:09 <cfields> So say 4 weeks from now we decide to merge, short extension, or punt?
3622023-10-05T14:43:15 <luke-jr> (on that note, should I just close #28564 or does anyone care to give it a quick review to fix current versions?)
3632023-10-05T14:43:16 <gribble`> https://github.com/bitcoin/bitcoin/issues/28564 | Bugfix: configure: Correct check for fuzz binary needing a main function by luke-jr · Pull Request #28564 · bitcoin/bitcoin · GitHub
3642023-10-05T14:43:30 <achow101> cfields: ack
3652023-10-05T14:43:40 <fanquake> cfields: that sounds ok, just don't want scope for this to start dragging out
3662023-10-05T14:43:41 <hebasto> ack :)
3672023-10-05T14:44:10 <fanquake> luke-jr: all build PRs are still relevant, it's not like cmake fixes the bugs in the branches we have to maintain for the next few years
3682023-10-05T14:44:30 <fanquake> so changes to the current build system are still needed, and useful
3692023-10-05T14:44:36 <_aj_> were we going to start polling for priority projects?
3702023-10-05T14:44:39 <cfields> fanquake: ack.
3712023-10-05T14:44:48 <cfields> _aj_: ah, right.
3722023-10-05T14:44:55 <luke-jr> ok, but absent additional changes, this bug amounts to a minor configure output thing IIUC
3732023-10-05T14:45:08 * luke-jr shrugs
3742023-10-05T14:45:12 <achow101> _aj_: next week I think
3752023-10-05T14:45:24 <achow101> I guess I can put up the issue for collecting possible projects
3762023-10-05T14:45:45 <_aj_> sounds good; seems like cmake is already a priority project :)
3772023-10-05T14:46:29 <fanquake> _aj_: if we have to pick 3, I'd kinda hope not. We have bitcoin problems to solve heh
3782023-10-05T14:47:13 <_aj_> well, if it's finished in four weeks time, nbd :)
3792023-10-05T14:47:28 <luke-jr> >finished
3802023-10-05T14:47:29 <luke-jr> o.o
3812023-10-05T14:47:38 <fanquake> I have one other quick topic
3822023-10-05T14:48:02 <fanquake> A 25.1rc1 has been tagged: https://github.com/bitcoin/bitcoin/releases/tag/v25.1rc1
3832023-10-05T14:48:04 <fanquake> So time to Guix build & test the bins.
3842023-10-05T14:48:10 <fanquake> Check out the release notes, and if you think there's something missing that should have been backported, let me know.
3852023-10-05T14:48:20 <luke-jr> I'm still struggling with bootstrapping guix x.x
3862023-10-05T14:48:23 <fanquake> Ideally 25.1 is released some time not long after feature freeze.
3872023-10-05T14:48:29 <fanquake> Note there are also PRs for 24.x & 23.x backports open at the moment (both reviewable).
3882023-10-05T14:49:05 <fanquake> luke-jr: if you can point me to the issues you've opened upstream, I can follow up
3892023-10-05T14:49:35 <luke-jr> fanquake: upstream just doesn't support it at all
3902023-10-05T14:49:51 <luke-jr> their answer is that it's impossible
3912023-10-05T14:49:58 <achow101> #28599 for gathering projects to vote on
3922023-10-05T14:49:59 <gribble`> https://github.com/bitcoin/bitcoin/issues/28599 | Gathering Priorities for 27.0 · Issue #28599 · bitcoin/bitcoin · GitHub
3932023-10-05T14:50:16 <fanquake> luke-jr: ok, can you link me to the issue/mailing list thread where the discussion happned
3942023-10-05T14:50:26 <luke-jr> fanquake: just IRC
3952023-10-05T14:50:37 <fanquake> cool, link me to the logs?
3962023-10-05T14:50:55 <luke-jr> #guix isn't logged ...
3972023-10-05T14:51:01 <achow101> Any other topics?
3982023-10-05T14:51:15 <luke-jr> nm, found log link
3992023-10-05T14:51:18 <dergoegge> achow101: maybe mention that the vote is only relevant for frequent contributors?
4002023-10-05T14:52:22 <sipa> we could also just do the discussion in a frequent contributor discussion, instead of a public issue
4012023-10-05T14:52:52 <achow101> sipa: github seems to have removed the feature for team discussions
4022023-10-05T14:53:06 <sipa> oh!
4032023-10-05T14:53:40 <sipa> indeed, there is just an json archive dump
4042023-10-05T14:55:03 <achow101> #endmeeting
4052023-10-05T14:55:37 <_aj_> could setup a private repo limit to freq-contrib and setup Discussions on that?
4062023-10-05T14:56:04 <luke-jr> fanquake: https://logs.guix.gnu.org/guix/2023-07-31.log and https://logs.guix.gnu.org/guix/2023-09-09.log mainly
4072023-10-05T14:56:26 <achow101> I think it's fine to leave it open unless there's actually a problem? we can more aggressively moderate if need be
4082023-10-05T14:57:46 <sipa> achow101: yeah
4092023-10-05T15:00:46 <fanquake> luke-jr: will read through
4102023-10-05T15:19:15 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/52c6904c7891...db19a7e89d19
4112023-10-05T15:19:16 <bitcoin-git> bitcoin/master fa28f5a MarcoFalke: test: Bump walletpassphrase timeouts to avoid intermittent issues
4122023-10-05T15:19:16 <bitcoin-git> bitcoin/master db19a7e Andrew Chow: Merge bitcoin/bitcoin#28403: test: Bump walletpassphrase timeouts to avoid...
4132023-10-05T15:19:57 <bitcoin-git> [bitcoin] achow101 merged pull request #28403: test: Bump walletpassphrase timeouts to avoid intermittent issues (master...2309-ci-bump-timeout-) https://github.com/bitcoin/bitcoin/pull/28403
4142023-10-05T15:27:17 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
4152023-10-05T15:33:15 <achow101> darosior: sipa: any thoughts on how to deal with migrating a legacy wallet that has a hybrid pubkey?
4162023-10-05T15:33:41 <darosior> Error cleanly, tell the user they must create a new descriptor wallet and send the funds there?
4172023-10-05T15:33:42 <achow101> I'm leaning towards just giving an error that tells them to open an issue. it shouldn't be something that anyone actually uses
4182023-10-05T15:33:45 <josie> achow101: dont
4192023-10-05T15:35:30 <sipa> achow101: you'd need to have imported a hybrid pubkey manually, as watch-only (as there is no corresponding private key for it, in the CKey sense)
4202023-10-05T15:35:51 <darosior> instagibbs: https://github.com/bitcoin/bitcoin/pull/27609#issuecomment-1749112324 should it? I just modified rpc_packages.py to 'submitpackage' a parent with `DEFAULT_FEE * 10`Â and a child with `DEFAULT_FEE` and both were accepted. Maybe i just made a mistake.
4212023-10-05T15:36:13 <darosior> Oh right it's only watchonly
4222023-10-05T15:36:20 <darosior> So they don't even have to send any funds
4232023-10-05T15:36:41 <_aj_> as long as DEFAULT_FEE > mempool min fee, that's okay though
4242023-10-05T15:36:46 <darosior> Yes
4252023-10-05T15:37:07 <_aj_> at leat in my tests, when mempool min fee > child feerate, i get a reject
4262023-10-05T15:37:29 <darosior> That's what i was thinking from reading the code, so `submitpackage` can be used with a package that is not a CPFP. That's what i was telling Murch[m]
4272023-10-05T15:38:02 <glozow> I think some of us are thinking about the "child lower than package feerate and mempool minimum feerate" case, and some of us are just thinking about the "child lower than package feerate in general"
4282023-10-05T15:38:27 <sipa> what if the child has higher feerate than the mempool, but after submitting the parent, the mempool feerate increases to be higher than the child's?
4292023-10-05T15:38:44 <darosior> glozow: yes
4302023-10-05T15:39:05 <glozow> sipa: LimitMempoolSize() is not called until the end of `AcceptPackage`
4312023-10-05T15:39:18 <glozow> so that should not happen
4322023-10-05T15:40:36 <darosior> achow101: Maybe proceed with migrating all the rest and return a warning in the command result / log about how imported hybrid keys couldn't be migrated. In my opinion this should be so rare that it's not worth going out of your way. As long as there is a clear warning / error somewhere. Worst case it's in the log they don't notice it but no funds
4332023-10-05T15:40:36 <darosior> is actually lost.
4342023-10-05T15:44:34 <darosior> glozow: so the TrimToSize() pushing up the feerate by 1sat/vb you described in https://github.com/bitcoin/bitcoin/pull/27609#issuecomment-1542695316 can still happen right?
4352023-10-05T15:45:15 <glozow> darosior: not with `IsTree`, you can't have diamonds like that
4362023-10-05T15:46:04 <darosior> Yes i'm saying without the diamond, just with a child that ... Oooh ok got it :)
4372023-10-05T15:50:51 *** pablomartin4btc <pablomartin4btc!~pablomart@185.216.146.241> has joined #bitcoin-core-dev
4382023-10-05T15:51:27 *** pablomartin <pablomartin!~pablomart@217.146.93.22> has quit IRC (Ping timeout: 240 seconds)
4392023-10-05T15:51:28 <bitcoin-git> [bitcoin] fanquake pushed 11 commits to master: https://github.com/bitcoin/bitcoin/compare/db19a7e89d19...d9c1cc5f1f54
4402023-10-05T15:51:29 <bitcoin-git> bitcoin/master 5d84693 Andrew Chow: test: Add helper functions for checking node versions
4412023-10-05T15:51:30 <bitcoin-git> bitcoin/master 313d665 Andrew Chow: test: Fix 0.16 wallet paths and downgrade test
4422023-10-05T15:51:30 <bitcoin-git> bitcoin/master 53f35d0 Andrew Chow: test: Remove w1_v18 from wallet backwards compatibility
4432023-10-05T15:51:48 <bitcoin-git> [bitcoin] fanquake merged pull request #28027: test: Fixes and updates to wallet_backwards_compatibility.py for 25.0 and descriptor wallets (master...2023-07-test-wallet-back-compat-updates) https://github.com/bitcoin/bitcoin/pull/28027
4442023-10-05T15:57:55 *** pablomartin4btc <pablomartin4btc!~pablomart@185.216.146.241> has quit IRC (Ping timeout: 255 seconds)
4452023-10-05T15:58:23 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d9c1cc5f1f54...6e5cf8e95391
4462023-10-05T15:58:24 <bitcoin-git> bitcoin/master c1e6c54 Pieter Wuille: descriptors: disallow hybrid public keys
4472023-10-05T15:58:25 <bitcoin-git> bitcoin/master 6e5cf8e Andrew Chow: Merge bitcoin/bitcoin#28587: descriptors: disallow hybrid public keys
4482023-10-05T15:59:09 <bitcoin-git> [bitcoin] achow101 merged pull request #28587: descriptors: disallow hybrid public keys (master...202310_no_hybrid_descriptors) https://github.com/bitcoin/bitcoin/pull/28587
4492023-10-05T16:00:36 <darosior> glozow: could you expand on your answer to sipa? How is it that you can't have a very large parent (say your mempool is 280MB, parent is 20MB) and a child whose feerate would position it at the very bottom of the mempool before accepting the parent, such as when you reach LimitMempoolSize() the child would get dropped and the minimum mempool
4502023-10-05T16:00:37 <darosior> feerate increased by 1sat/vb?
4512023-10-05T16:02:24 <_aj_> can't have parent/ancestors more than 400k weight?
4522023-10-05T16:05:07 <darosior> The example works with smaller sizes.
4532023-10-05T16:05:15 * darosior afk
4542023-10-05T16:08:49 <vasild> hebasto, cfields: so, to test my workflow with cmake, should I merge hebasto/cmake-staging into some local branch of mine and then "work as usual"?
4552023-10-05T16:09:19 <vasild> well, "work as usual" / modulo using cmake instead of autotools of course
4562023-10-05T16:10:06 <hebasto> vasild: no, merging will cause silent conflicts
4572023-10-05T16:10:29 <vasild> hum?
4582023-10-05T16:11:11 <vasild> conflicts between what? there is no cmake files in master now
4592023-10-05T16:11:13 <hebasto> there were changes in source file organisation
4602023-10-05T16:11:44 <hebasto> right now, the longest chain of reviewed commits is here -- https://github.com/hebasto/bitcoin/pull/31
4612023-10-05T16:11:55 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
4622023-10-05T16:12:21 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev
4632023-10-05T16:13:10 <vasild> ok, this is the hebasto/230916-linear branch
4642023-10-05T16:13:19 <hebasto> correct
4652023-10-05T16:13:25 <vasild> is this the one to test?
4662023-10-05T16:13:30 <glozow> darosior: so walking through the scenario. I assume in this situation the large parent is higher feerate than the child. Parent gets in by itself, and we exceed the 300mb maximum temporarily. If we were to do a `TrimToSize()` perhaps the minimum feerate would change, but we're not. So we submit the child, and then we call `TrimToSize` at the end and evict by worst descendant score.
4672023-10-05T16:13:46 <vasild> shouldn't I also test unreviewed commits?
4682023-10-05T16:13:59 <glozow> iiuc sipa's question was whether the mempool minimum feerate can change in the middle of `AcceptPackage`, and the answer is no since #28251
4692023-10-05T16:14:03 <gribble`> https://github.com/bitcoin/bitcoin/issues/28251 | validation: fix coins disappearing mid-package evaluation by glozow · Pull Request #28251 · bitcoin/bitcoin · GitHub
4702023-10-05T16:14:27 <hebasto> vasild: yes. that branch is a rebase of reviewed commits
4712023-10-05T16:14:58 <hebasto> and it is supposed to be new staging branch after acking
4722023-10-05T16:17:44 <vasild> hebasto: ok, I can test directly hebasto/230916-linear but this is a bit boring. I want to test it together with my PR, for this I guess I should merge one way or another. git diff --stat origin/master...hebasto/230916-linear looks pretty innocent wrt to merge conflics - just ++++ lines adding cmake stuff.
4732023-10-05T16:18:29 <_aj_> hebasto: what do you do to build that branch?
4742023-10-05T16:18:52 <hebasto> vasild: any conflict will and a cmake error. I'll make a fresh rebase for you
4752023-10-05T16:19:27 *** cryptapus <cryptapus!~cryptapus@user/cryptapus> has quit IRC (Ping timeout: 258 seconds)
4762023-10-05T16:19:55 <hebasto> _aj_: examples are here -- https://github.com/hebasto/bitcoin/pull/31#issuecomment-1722338779
4772023-10-05T16:20:31 <hebasto> is that what you meant?
4782023-10-05T16:21:14 <vasild> hebasto: So, hebasto/230916-linear is based on master from Sep 12. You are worried that if there were build related changed in master after Sep 12 that are included in my local branch, then hebasto/230916-linear will not be adapted to that?
4792023-10-05T16:21:36 <hebasto> correct
4802023-10-05T16:21:40 <vasild> I see
4812023-10-05T16:23:19 <_aj_> hebasto: how do i enable debug, Werror and c++20?
4822023-10-05T16:23:56 <vasild> ok, for now I will play with hebasto/230916-linear only
4832023-10-05T16:25:29 <hebasto> _aj_: `-DCXX20 -DCMAKE_BUILD_TYPE=Debug` ; Werror not implemented yet
4842023-10-05T16:26:04 <hebasto> full list of options is here --https://github.com/bitcoin/bitcoin/pull/25797#issue-1330985812 (near bottom of the comment)
4852023-10-05T16:26:33 <vasild> _aj_: running ccmake gives some list of the options in a test/console ui, I find it useful
4862023-10-05T16:26:47 <vasild> s/test/text/
4872023-10-05T16:26:49 <hebasto> ^ indeed
4882023-10-05T16:27:16 <hebasto> also adding `-LH` will print options as well
4892023-10-05T16:30:56 *** brunoerg <brunoerg!~brunoerg@2001:12d0:2080:2800:172:26:b:f00a> has joined #bitcoin-core-dev
4902023-10-05T16:33:41 <_aj_> hebasto: that table says -DWERROR should do Werror?
4912023-10-05T16:34:28 <_aj_> ah, but it doesn't actually work
4922023-10-05T16:34:47 <hebasto> yes. but it is not implemented in the staging branch where commit-by-commit reviewing happens
4932023-10-05T16:35:40 <hebasto> the branch in the umbrella PR was fully-fledged with all options implemented
4942023-10-05T16:37:47 <bitcoin-git> [bitcoin] Retropex closed pull request #28217: set `DEFAULT_PERMIT_BAREMULTISIG` to false (master...Permitbaremultisig) https://github.com/bitcoin/bitcoin/pull/28217
4952023-10-05T16:43:31 <_aj_> so `cd build; cmake -S ..; cd ../src; touch net.h; cmake --build ../build -j 20` seems like it works okay
4962023-10-05T16:45:10 <_aj_> ccmake is pretty great
4972023-10-05T16:45:18 <vasild> well, hebasto/230916-linear compiles on freebsd
4982023-10-05T16:45:32 <hebasto> cool
4992023-10-05T16:46:17 <_aj_> how do i tell ctest where to look if i'm in src/ rather than build/ ?
5002023-10-05T16:57:22 *** dberkelmans <dberkelmans!~dberkelma@2001:1c03:530d:8100:e1b1:e648:f55b:1feb> has joined #bitcoin-core-dev
5012023-10-05T16:57:30 <hebasto> `--test-dir`
5022023-10-05T16:58:35 <_aj_> -test-dir ../build ?
5032023-10-05T16:59:29 <_aj_> seems to work, also seems like it orders the test by whichever took longest last time?
5042023-10-05T17:00:44 <hebasto> did not check the order
5052023-10-05T17:01:29 <_aj_> seems very nice, anyway
5062023-10-05T17:01:52 <hebasto> thanks!
5072023-10-05T17:04:45 *** brunoerg <brunoerg!~brunoerg@2001:12d0:2080:2800:172:26:b:f00a> has quit IRC (Remote host closed the connection)
5082023-10-05T17:17:25 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
5092023-10-05T17:25:58 <Murch[m]> <darosior> "feerate increased by 1sat/vb?" <- If the child gets dropped, _if_ that child had a higher feerate than the package, the parent would then also be below the dynamic minimum feerate and would also get dropped?
5102023-10-05T17:27:03 <Murch[m]> Thatâs why I was asking whether we generally restricted to packages where the child has a higher feerate than the package
5112023-10-05T17:28:43 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
5122023-10-05T17:29:11 <glozow> ^it's more that the parent would have a lower descendant score than the child, so parent+child would be selected before child for eviction. We don't proactively trim everything below our new minimum.
5132023-10-05T17:29:46 <glozow> No we don't explicitly enforce that
5142023-10-05T17:30:58 <instagibbs> darosior in general we will be gossiping packages that arent necessarily CPFPs, and we have to handle them in a good way
5152023-10-05T17:32:46 <Murch[m]> But I thought we were talking about the more narrow functionality of #27609?
5162023-10-05T17:32:49 <gribble`> https://github.com/bitcoin/bitcoin/issues/27609 | rpc: allow submitpackage to be called outside of regtest by glozow · Pull Request #27609 · bitcoin/bitcoin · GitHub
5172023-10-05T17:34:39 <instagibbs> Murch[m] feel free to recap your question to me, think I missed something
5182023-10-05T17:34:57 <Murch[m]> If the intended purpose for making the submitpackage RPC available in this release is to give to Lightning users with commitment transactions stuck on feerates below the dynamic minimum feerate an avenue for submitting their commitment tx and a bumping child to a node, why would we care in this context about packages where the child has a lower feerate than the package?
5192023-10-05T17:36:12 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
5202023-10-05T17:36:32 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC (Client Quit)
5212023-10-05T17:37:14 <Murch[m]> I guess you could have a construction where a grandparent tx has a high feerate, a parent tx has a low feerate, and the child has a medium feerate that is lower than the package, but then the grandparent would have been eligible by itself in the first place
5222023-10-05T17:37:52 *** Guest36 <Guest36!~Guest23@111.65.60.231> has joined #bitcoin-core-dev
5232023-10-05T17:37:54 <Murch[m]> And then you could only submit parent and child which would fulfill the criteria of the child having a higher feerate than the package
5242023-10-05T17:38:10 *** Guest36 <Guest36!~Guest23@111.65.60.231> has quit IRC (Client Quit)
5252023-10-05T17:38:11 <instagibbs> it's not important for the rpc per se I guess, but when gossiping we need to support arbitrary things where a node comes back online, gets the low fee child, is missing the parent, and fetches the ancestors
5262023-10-05T17:38:34 <Murch[m]> Sure, but thatâs #27611, which I gather is not slated to be in v26
5272023-10-05T17:38:35 <instagibbs> with a LN wallet "of course" the child will be high feerate, that's the point of the wallet logic
5282023-10-05T17:38:36 <gribble`> https://github.com/bitcoin/bitcoin/issues/27611 | refactor: Use ChainType enum exhaustively by TheCharlatan · Pull Request #27611 · bitcoin/bitcoin · GitHub
5292023-10-05T17:38:38 <glozow> are you proposing to add this restriction to packages that are submitted via submitpackage? because that's not something you can easily check prior to calling `AcceptPackage`
5302023-10-05T17:39:06 <Murch[m]> errrr #26711
5312023-10-05T17:39:09 <gribble`> https://github.com/bitcoin/bitcoin/issues/26711 | validate package transactions with their in-package ancestor sets by glozow · Pull Request #26711 · bitcoin/bitcoin · GitHub
5322023-10-05T17:39:16 <instagibbs> 26711 "merely" makes the logic for acceptance smarter to avoid edge cases, and make it safe for non-tree
5332023-10-05T17:39:37 <Murch[m]> right
5342023-10-05T17:40:38 <Murch[m]> And from staring a bunch at packages in the context of candidate sets and miniminer in the last year, my suspicion would be that even a lot of the edge cases with diamonds mostly trigger around situations where a parent pays for a child
5352023-10-05T17:41:40 <Murch[m]> If the lowest descendant has a higher feerate than the package, wouldnât that already preclude many/most/all of these edge cases, i.e. perhaps a decent way to shore up submitpackage for early release?
5362023-10-05T17:42:11 <instagibbs> ah, you mean master + check child for higher feerate? that's not sufficient
5372023-10-05T17:42:22 <instagibbs> it's in the graveyard of ideas in the tree PR IIRC
5382023-10-05T17:43:03 <glozow> my point is also that this is way more involved to check than a simple topology restriction
5392023-10-05T17:43:26 <glozow> you don't know what the feerates are until you pass it to validation
5402023-10-05T17:43:28 <instagibbs> yeah, that too. checking topo is very cheap + easy to remove later
5412023-10-05T17:43:42 <instagibbs> you need PreChecks to get fee info
5422023-10-05T17:43:48 <Murch[m]> I thought packages were topologically restricted to having a single transaction descending from all other package members?
5432023-10-05T17:44:02 <glozow> correct, they have to be a child with unconfirmed parents
5442023-10-05T17:44:46 <Murch[m]> So wouldnât it just amount to adding up the total package size and total package fees, and comparing that to the individual feerate of the latest descendant?
5452023-10-05T17:45:01 <glozow> how are you getting the fees though
5462023-10-05T17:45:13 <instagibbs> you can have weird fee structures in the subpackages
5472023-10-05T17:45:23 <instagibbs> that master + child check won't catch iirc
5482023-10-05T17:46:05 <Murch[m]> You mean a sub-ancestry that is self-sufficient and has a higher feerate by itself?
5492023-10-05T17:47:42 <Murch[m]> glozow: Child with unconfirmed parents, or child with all unconfirmed ancestors?
5502023-10-05T17:47:53 <glozow> parents
5512023-10-05T17:48:07 <instagibbs> maybe not, I've been focusing on 26711 and the comments look pretty stale unfortunately. things are really non-obvious
5522023-10-05T17:48:36 <Murch[m]> So the problem case would be if you had two parents and one has a high feerate and the other has a low feerate, and the child would have a lower feerate than the package?
5532023-10-05T17:49:23 <glozow> did you take a look at this example? https://github.com/bitcoin/bitcoin/pull/27609#issuecomment-1542695316
5542023-10-05T17:49:44 <Murch[m]> And weâd reject the package because the child fails the criteria, even though the high-feerate parent would be self-sufficient and then from the remainder the child would be of course higher feerate than the secnd parent?
5552023-10-05T17:50:27 <instagibbs> no, we'd accept the high feerate parent first in individual evaluation
5562023-10-05T17:50:35 <glozow> No I think worst case scenario is accepting a below-minfeerate child (as illustrated in that example)
5572023-10-05T17:51:07 <Murch[m]> Great example
5582023-10-05T17:51:32 <instagibbs> based on https://github.com/bitcoin/bitcoin/pull/27609#issuecomment-1544414801 it seems we had reasons why the last-child-feerate wasn't enough
5592023-10-05T17:51:33 <glozow> Another example, which is not as bad, is this one where we miss out on 2 transactions that have good fees: https://github.com/bitcoin/bitcoin/pull/26711/commits/40bab000936bf1573824644a0e08020e63d73e51#diff-98ca28aa44cf84d5a29e4ce7eddbabf495a51154b02a6703a78977b80e19b17aR1297-R1364
5602023-10-05T17:51:51 <Murch[m]> My suggestion would be that the example you linked would be rejected because the child has a lower feerate than the package
5612023-10-05T17:52:00 <glozow> (that's not something we need to solve for the RPC imo, which I think people agree with)
5622023-10-05T17:52:50 <instagibbs> I'm not sure that would be sufficient, is my point. Tree topo is, and 26711 subsumes it
5632023-10-05T17:53:44 <sipa> So is the idea that 26711 only changes things for non-tree topologies?
5642023-10-05T17:54:33 <glozow> Well, 26711 also allows all ancestor packages, so a 3-generation tree is now permitted when it wasn't before
5652023-10-05T17:54:44 <instagibbs> for tree topos, the eval should be very close yes
5662023-10-05T17:54:55 <instagibbs> parents evaluaated one by one, then child, if all parents succeeded
5672023-10-05T17:55:18 <instagibbs> or all parents didnt get disallowed*
5682023-10-05T17:56:32 <instagibbs> s/succeed/dont fail for non-fee related reasons/
5692023-10-05T17:57:19 <sipa> i have a slightly uncomfortable feeling that this RPC access is being rushed, and i'd like to just see 26711 make it in instead
5702023-10-05T17:57:34 <Murch[m]> I see, so the point that Iâm missing is that even in the experimental submitpackage RPC we want to support situations in which subsets of the package are eligible
5712023-10-05T17:58:03 <sipa> but i'm still trying to wrap my head around what the additional restrictions in 27609 mean... if it's the case that 26711 only changes things for things that 27609 doesn't permit anyway, then it obviously doesn't matter
5722023-10-05T17:58:36 <instagibbs> hm?
5732023-10-05T17:58:52 <glozow> Murch: I don't think your suggestion is a restriction that we can easily tack on / remove later, as you'd need to do it within validation. I also don't think it's sufficient as you can still add another tx under the diamond with the same feerate as the package
5742023-10-05T18:00:52 <glozow> 26711 would not change things for a child-with-parents package that is tree-shaped
5752023-10-05T18:01:18 <sipa> glozow: ok, thanks
5762023-10-05T18:01:55 <Murch[m]> aah, I see what I was missing
5772023-10-05T18:01:59 <bitcoin-git> [bitcoin] achow101 opened pull request #28602: descriptors: Disallow hybrid and uncompressed keys when inferring (master...migrate-hybrid-keys) https://github.com/bitcoin/bitcoin/pull/28602
5782023-10-05T18:02:05 <glozow> that being said I wouldn't want to propose the RPC if it makes people uncomfortable
5792023-10-05T18:02:31 <Murch[m]> We have the topology of the package because we see the outpoints being spent by descendants of other transactinos, but we donât know the amounts of the spent UTXOs because weâd have to first look up the UTXOs and thus we canât get the fees
5802023-10-05T18:02:49 * Murch[m] facepalms
5812023-10-05T18:02:52 <_aj_> trying to think about 26711 at the same time doesn't seem super helpful; the rpc just takes a super simple case (some unreleated parents and a child) and allows them to be added as a package. all the complex topologies are just disallowed
5822023-10-05T18:02:58 <instagibbs> Murch[m] yeah you need `PreCheck`s for that
5832023-10-05T18:03:06 <instagibbs> deep in eval territory
5842023-10-05T18:03:24 <glozow> Murch: ð
5852023-10-05T18:03:40 <Murch[m]> So itâs easy to restrict to parents + child, or only tree but no diamond, but not easy to check for the feerate
5862023-10-05T18:03:44 <Murch[m]> gotcha
5872023-10-05T18:04:03 <glozow> Yeah to be clear, the restriction of child+parents only is already in there
5882023-10-05T18:04:35 <glozow> However, given the fact that parents can spend parents, child-with-parents is not that much simpler than tx-with-ancestors when thinking about edge cases.
5892023-10-05T18:04:53 <glozow> That's why 26711 is so big, haha
5902023-10-05T18:05:54 <Murch[m]> Yeah, but in #27609 we do not allow parents to spend other parents, right?
5912023-10-05T18:05:57 <gribble`> https://github.com/bitcoin/bitcoin/issues/27609 | rpc: allow submitpackage to be called outside of regtest by glozow · Pull Request #27609 · bitcoin/bitcoin · GitHub
5922023-10-05T18:06:34 <instagibbs> parents, which are only spent by a single child
5932023-10-05T18:06:35 <glozow> yes exactly
5942023-10-05T18:08:27 <_aj_> so if you had minfee=10sat/vb, p1=30sat/vb, p2=6sat/vb, child=12sat/vb, #27609 would be wrong, i think? (p1 accept; but p2+child = 9sat/vb)
5952023-10-05T18:08:30 <gribble`> https://github.com/bitcoin/bitcoin/issues/27609 | rpc: allow submitpackage to be called outside of regtest by glozow · Pull Request #27609 · bitcoin/bitcoin · GitHub
5962023-10-05T18:09:29 <glozow> _aj_: is p1+p2+child a tree?
5972023-10-05T18:09:40 <_aj_> glozow: child spends p1 and p2, no other relationships
5982023-10-05T18:09:44 <glozow> why wrong? you shouldn't take p2 and child
5992023-10-05T18:10:09 <_aj_> glozow: oh does p1 already get pre-accepted on its own?
6002023-10-05T18:10:18 <instagibbs> yeah
6012023-10-05T18:10:22 <glozow> yeah it's first tried by itself
6022023-10-05T18:10:23 <instagibbs> one by one eval first
6032023-10-05T18:10:27 <instagibbs> then "rest of package"
6042023-10-05T18:10:30 <instagibbs> is master
6052023-10-05T18:11:14 <_aj_> so after that phase, all remaining parents should be below minfee or they would already be accepted?
6062023-10-05T18:11:48 <glozow> correct
6072023-10-05T18:13:04 *** dberkelmans <dberkelmans!~dberkelma@2001:1c03:530d:8100:e1b1:e648:f55b:1feb> has quit IRC (Quit: Client closed)
6082023-10-05T18:19:47 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6e5cf8e95391...0b2c93bc560c
6092023-10-05T18:19:48 <bitcoin-git> bitcoin/master a9ef702 Ryan Ofsky: assumeutxo: change getchainstates RPC to return a list of chainstates
6102023-10-05T18:19:48 <bitcoin-git> bitcoin/master 0b2c93b Andrew Chow: Merge bitcoin/bitcoin#28590: assumeutxo: change getchainstates RPC to retu...
6112023-10-05T18:19:53 <bitcoin-git> [bitcoin] achow101 merged pull request #28590: assumeutxo: change getchainstates RPC to return a list of chainstates (master...pr/getchain) https://github.com/bitcoin/bitcoin/pull/28590
6122023-10-05T18:27:53 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
6132023-10-05T18:38:57 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC ()
6142023-10-05T19:01:47 *** OP_NOP <OP_NOP!~OP_NOP@206.217.205.41> has joined #bitcoin-core-dev
6152023-10-05T19:18:15 *** OP_NOP <OP_NOP!~OP_NOP@206.217.205.41> has quit IRC (Ping timeout: 240 seconds)
6162023-10-05T19:19:50 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 255 seconds)
6172023-10-05T19:21:12 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
6182023-10-05T19:21:30 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
6192023-10-05T19:27:14 *** nanotube <nanotube!~nanotube@user/nanotube> has quit IRC (Ping timeout: 272 seconds)
6202023-10-05T19:36:52 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0b2c93bc560c...cf553e3ab7b3
6212023-10-05T19:36:53 <bitcoin-git> bitcoin/master fa071ae MarcoFalke: wallet: No BDB creation, unless -deprecatedrpc=create_bdb
6222023-10-05T19:36:53 <bitcoin-git> bitcoin/master cf553e3 Andrew Chow: Merge bitcoin/bitcoin#28597: wallet: No BDB creation, unless -deprecatedrp...
6232023-10-05T19:36:53 <bitcoin-git> [bitcoin] achow101 merged pull request #28597: wallet: No BDB creation, unless -deprecatedrpc=create_bdb (master...2310-less-bdb-) https://github.com/bitcoin/bitcoin/pull/28597
6242023-10-05T19:56:09 <bitcoin-git> [bitcoin] achow101 closed pull request #20892: tests: Run both descriptor and legacy tests within a single test invocation (master...better-descriptor-tests) https://github.com/bitcoin/bitcoin/pull/20892
6252023-10-05T19:56:44 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has joined #bitcoin-core-dev
6262023-10-05T20:03:32 *** pablomartin4btc <pablomartin4btc!~pablomart@217.146.93.23> has joined #bitcoin-core-dev
6272023-10-05T20:16:36 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
6282023-10-05T20:21:54 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Remote host closed the connection)
6292023-10-05T20:22:21 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:c597:597b:acf7:98cd> has joined #bitcoin-core-dev
6302023-10-05T20:41:12 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:c597:597b:acf7:98cd> has quit IRC (Remote host closed the connection)
6312023-10-05T20:57:05 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:c597:597b:acf7:98cd> has joined #bitcoin-core-dev
6322023-10-05T21:03:48 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:c597:597b:acf7:98cd> has quit IRC (Ping timeout: 240 seconds)
6332023-10-05T21:05:30 *** Zenton <Zenton!~user@user/zenton> has joined #bitcoin-core-dev
6342023-10-05T21:26:12 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:c597:597b:acf7:98cd> has joined #bitcoin-core-dev
6352023-10-05T21:38:45 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 246 seconds)
6362023-10-05T21:44:21 *** vysn <vysn!~vysn@user/vysn> has quit IRC (Remote host closed the connection)
6372023-10-05T21:45:02 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:8a:c597:597b:acf7:98cd> has quit IRC (Remote host closed the connection)
6382023-10-05T21:46:35 *** jQrgen <jQrgen!~jQrgen@2001:8c0:ea04:37:208f:fbf5:f48b:bc67> has joined #bitcoin-core-dev
6392023-10-05T22:19:19 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8c2e:351d:bb23:4f6a:30c3> has joined #bitcoin-core-dev
6402023-10-05T22:36:52 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8c2e:351d:bb23:4f6a:30c3> has quit IRC (Remote host closed the connection)
6412023-10-05T22:41:14 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Quit: Leaving)
6422023-10-05T22:47:38 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8c2e:351d:bb23:4f6a:30c3> has joined #bitcoin-core-dev
6432023-10-05T22:50:55 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
6442023-10-05T22:51:48 *** brunoerg <brunoerg!~brunoerg@2804:14d:5281:8c2e:351d:bb23:4f6a:30c3> has quit IRC (Ping timeout: 240 seconds)
6452023-10-05T23:00:09 *** brunoerg <brunoerg!~brunoerg@187.183.43.149> has joined #bitcoin-core-dev
6462023-10-05T23:08:47 <bitcoin-git> [bitcoin] achow101 pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/cf553e3ab7b3...54bdb6e07459
6472023-10-05T23:08:48 <bitcoin-git> bitcoin/master b4f28cc glozow: [doc] parent pay for child in aggregate CheckFeeRate
6482023-10-05T23:08:48 <bitcoin-git> bitcoin/master e32ba15 glozow: [txpackages] IsChildWithParentsTree()
6492023-10-05T23:08:48 <bitcoin-git> bitcoin/master 5b9087a glozow: [rpc] require package to be a tree in submitpackage
6502023-10-05T23:08:54 <bitcoin-git> [bitcoin] achow101 merged pull request #27609: rpc: allow submitpackage to be called outside of regtest (master...open-submitpackage) https://github.com/bitcoin/bitcoin/pull/27609
6512023-10-05T23:19:15 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
6522023-10-05T23:20:55 *** benwestgate <benwestgate!~BenWestga@035-146-116-090.res.spectrum.com> has quit IRC (Quit: Leaving.)
6532023-10-05T23:21:50 *** brunoerg <brunoerg!~brunoerg@187.183.43.149> has quit IRC (Remote host closed the connection)
6542023-10-05T23:23:09 <bitcoin-git> [bitcoin] achow101 opened pull request #28604: test: Use feerate higher than minrelay fee in wallet_fundraw (master...fix-fundraw-test-intermittent) https://github.com/bitcoin/bitcoin/pull/28604
6552023-10-05T23:42:50 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Quit: jarthur)