12024-01-08T00:04:06 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has quit IRC (Ping timeout: 245 seconds)
22024-01-08T00:04:18 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
32024-01-08T00:10:25 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Remote host closed the connection)
42024-01-08T00:15:40 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
52024-01-08T00:20:38 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 260 seconds)
62024-01-08T00:35:07 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has joined #bitcoin-core-dev
72024-01-08T00:40:43 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has quit IRC (Ping timeout: 276 seconds)
82024-01-08T00:55:15 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has joined #bitcoin-core-dev
92024-01-08T01:00:28 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has quit IRC (Ping timeout: 268 seconds)
102024-01-08T01:13:10 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has joined #bitcoin-core-dev
112024-01-08T01:17:41 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has quit IRC (Ping timeout: 240 seconds)
122024-01-08T01:25:51 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
132024-01-08T01:27:42 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
142024-01-08T01:29:07 *** test_ <test_!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Ping timeout: 255 seconds)
152024-01-08T01:31:32 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has joined #bitcoin-core-dev
162024-01-08T01:36:11 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has quit IRC (Ping timeout: 245 seconds)
172024-01-08T01:37:45 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 256 seconds)
182024-01-08T01:40:14 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has joined #bitcoin-core-dev
192024-01-08T01:40:52 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has quit IRC (Read error: Connection reset by peer)
202024-01-08T01:42:33 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has joined #bitcoin-core-dev
212024-01-08T01:55:52 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Quit: jarthur)
222024-01-08T02:00:54 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
232024-01-08T02:05:32 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 268 seconds)
242024-01-08T02:11:15 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has quit IRC (Remote host closed the connection)
252024-01-08T02:17:32 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
262024-01-08T02:22:26 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 260 seconds)
272024-01-08T02:29:33 *** kevkevin <kevkevin!~kevkevin@98.226.43.69> has joined #bitcoin-core-dev
282024-01-08T02:41:19 <bitcoin-git> [bitcoin] jonatack opened pull request #29202: Remove no-longer-needed NOLINTNEXTLINE since C++20 upgrade (master...2024-01-rm-unneeded-NOLINTNEXTLINE) https://github.com/bitcoin/bitcoin/pull/29202
292024-01-08T02:47:42 <jon_atack> I wonder if there is an issue with the test-each-commit tidy CI check. It was red for a failing unit test in an intermediairy commit, but after the author force-pushed an update for the last 2 commits of the PR that didn't update the commit with test failure, the CI was green. See https://github.com/bitcoin/bitcoin/pull/29198#issuecomment-1880180224
302024-01-08T02:53:48 <_aj_> jon_atack: the each-commit test isn't listed in the 13-successful-checks? is it the 1-workflow-awaiting-approval maybe?
312024-01-08T02:54:28 <jon_atack> looks like the task was skipped
322024-01-08T02:54:40 <jon_atack> https://github.com/bitcoin/bitcoin/actions/runs/7442569023/job/20246189896?pr=29202
332024-01-08T02:55:49 <_aj_> https://github.com/bitcoin/bitcoin/actions/runs/7440886701
342024-01-08T02:56:48 <jon_atack> ah hm, ty. time for bed.
352024-01-08T02:56:52 <_aj_> it gets skipped if there's only one commit in the PR
362024-01-08T02:57:37 <jon_atack> if only one fresh commit in the push, didn't look
372024-01-08T02:57:53 <_aj_> no, your PR that you linked has only one commit, which is why it was skipped
382024-01-08T02:58:00 <_aj_> the other one is waiting for approval
392024-01-08T02:59:07 <jon_atack> i mixed up the two pulls. thanks for looking
402024-01-08T02:59:31 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
412024-01-08T02:59:57 *** Guest36 <Guest36!~Guest96@2001:ee0:4001:aeb1:4d34:e880:42e2:741d> has joined #bitcoin-core-dev
422024-01-08T03:01:13 *** Guest36 <Guest36!~Guest96@2001:ee0:4001:aeb1:4d34:e880:42e2:741d> has quit IRC (Client Quit)
432024-01-08T03:02:04 *** test_ <test_!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
442024-01-08T03:03:54 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 256 seconds)
452024-01-08T03:05:33 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Ping timeout: 252 seconds)
462024-01-08T03:12:20 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
472024-01-08T03:18:45 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 252 seconds)
482024-01-08T03:42:31 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has quit IRC (Quit: PaperSword)
492024-01-08T03:59:11 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
502024-01-08T04:03:55 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 255 seconds)
512024-01-08T04:11:18 <bitcoin-git> [bitcoin] jonatack closed pull request #29202: refactor: use push_back in TaprootBuilder::Add(), rm NOLINTNEXTLINE and comment (master...2024-01-rm-unneeded-NOLINTNEXTLINE) https://github.com/bitcoin/bitcoin/pull/29202
522024-01-08T04:16:41 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
532024-01-08T04:17:34 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has joined #bitcoin-core-dev
542024-01-08T04:21:22 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 260 seconds)
552024-01-08T04:33:22 *** kevkevin <kevkevin!~kevkevin@98.226.43.69> has quit IRC (Remote host closed the connection)
562024-01-08T04:50:01 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
572024-01-08T04:55:15 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has joined #bitcoin-core-dev
582024-01-08T05:00:43 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 276 seconds)
592024-01-08T05:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
602024-01-08T05:01:33 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
612024-01-08T05:28:52 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
622024-01-08T05:33:07 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has quit IRC (Remote host closed the connection)
632024-01-08T05:33:46 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 260 seconds)
642024-01-08T05:59:01 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has joined #bitcoin-core-dev
652024-01-08T06:01:16 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
662024-01-08T06:05:46 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 245 seconds)
672024-01-08T06:17:28 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
682024-01-08T06:22:14 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 256 seconds)
692024-01-08T06:26:57 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
702024-01-08T06:29:28 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 268 seconds)
712024-01-08T06:37:02 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
722024-01-08T06:41:36 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 245 seconds)
732024-01-08T07:05:42 *** not_reserved <not_reserved!~not_reser@185.153.177.190> has joined #bitcoin-core-dev
742024-01-08T07:27:53 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
752024-01-08T07:31:59 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has joined #bitcoin-core-dev
762024-01-08T07:32:19 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has quit IRC (Remote host closed the connection)
772024-01-08T07:32:29 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 256 seconds)
782024-01-08T07:49:21 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
792024-01-08T07:52:11 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 264 seconds)
802024-01-08T07:57:01 *** puchka <puchka!~puchka@185.203.122.51> has quit IRC (Ping timeout: 245 seconds)
812024-01-08T07:58:52 *** puchka <puchka!~puchka@185.203.122.43> has joined #bitcoin-core-dev
822024-01-08T08:05:08 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
832024-01-08T08:09:03 *** test_ <test_!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Ping timeout: 268 seconds)
842024-01-08T08:10:44 *** Guest61 <Guest61!~Guest61@149.36.50.228> has joined #bitcoin-core-dev
852024-01-08T08:11:12 *** Guest61 <Guest61!~Guest61@149.36.50.228> has quit IRC (Client Quit)
862024-01-08T08:15:50 *** javi404 <javi404!~quassel@2601:582:0:2c41:91ca:6895:2072:3474> has quit IRC (Ping timeout: 268 seconds)
872024-01-08T08:17:13 *** javi404 <javi404!~quassel@2601:582:0:2c41:91ca:6895:2072:3474> has joined #bitcoin-core-dev
882024-01-08T08:17:52 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
892024-01-08T08:22:21 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 252 seconds)
902024-01-08T08:29:11 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
912024-01-08T08:33:42 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 256 seconds)
922024-01-08T09:06:33 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
932024-01-08T09:09:13 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
942024-01-08T09:11:07 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 246 seconds)
952024-01-08T09:28:20 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
962024-01-08T09:32:55 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 268 seconds)
972024-01-08T09:43:42 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
982024-01-08T09:47:51 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Remote host closed the connection)
992024-01-08T09:48:34 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
1002024-01-08T09:53:35 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 268 seconds)
1012024-01-08T10:12:40 *** not_reserved98 <not_reserved98!~not_reser@185.153.177.190> has joined #bitcoin-core-dev
1022024-01-08T10:16:06 *** not_reserved <not_reserved!~not_reser@185.153.177.190> has quit IRC (Ping timeout: 250 seconds)
1032024-01-08T10:16:18 *** not_reserved98 is now known as not_reserved
1042024-01-08T10:27:58 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
1052024-01-08T10:32:44 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 256 seconds)
1062024-01-08T10:33:27 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
1072024-01-08T10:36:43 *** test_ <test_!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
1082024-01-08T10:37:55 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 246 seconds)
1092024-01-08T10:39:09 <bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/82ba0f80a0b5...04b9df0f9fd9
1102024-01-08T10:39:10 <bitcoin-git> bitcoin/master 5779010 Luke Dashjr: RPC/Blockchain: scanblocks: Accept named param for filter_false_positives
1112024-01-08T10:39:11 <bitcoin-git> bitcoin/master 04b9df0 glozow: Merge bitcoin/bitcoin#29184: RPC/Blockchain: scanblocks: Accept named para...
1122024-01-08T10:39:18 <bitcoin-git> [bitcoin] glozow merged pull request #29184: RPC/Blockchain: scanblocks: Accept named param for filter_false_positives (master...rpc_scanblocks_ffp_named) https://github.com/bitcoin/bitcoin/pull/29184
1132024-01-08T10:40:40 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Ping timeout: 276 seconds)
1142024-01-08T11:00:53 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
1152024-01-08T11:05:42 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 252 seconds)
1162024-01-08T11:23:22 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
1172024-01-08T11:28:46 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 276 seconds)
1182024-01-08T11:29:19 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
1192024-01-08T11:30:12 *** not_reserved <not_reserved!~not_reser@185.153.177.190> has quit IRC (Ping timeout: 250 seconds)
1202024-01-08T11:34:09 *** bomb-on <bomb-on!~bomb-on@user/bomb-on> has joined #bitcoin-core-dev
1212024-01-08T11:40:28 *** not_reserved <not_reserved!~not_reser@185.153.177.190> has joined #bitcoin-core-dev
1222024-01-08T11:56:12 *** zato <zato!~zato@user/zato> has joined #bitcoin-core-dev
1232024-01-08T11:57:49 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has joined #bitcoin-core-dev
1242024-01-08T12:02:28 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has quit IRC (Ping timeout: 268 seconds)
1252024-01-08T12:21:27 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1262024-01-08T12:23:37 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 246 seconds)
1272024-01-08T12:32:11 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1282024-01-08T12:34:10 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 260 seconds)
1292024-01-08T12:36:06 *** test_ is now known as _flood
1302024-01-08T13:26:00 *** pablomartin <pablomartin!~pablomart@176.227.242.246> has joined #bitcoin-core-dev
1312024-01-08T13:35:17 *** Guest56 <Guest56!~Guest2@159.146.95.199> has joined #bitcoin-core-dev
1322024-01-08T13:35:46 *** Guest56 <Guest56!~Guest2@159.146.95.199> has quit IRC (Client Quit)
1332024-01-08T13:40:25 *** preimage <preimage!~halosghos@user/halosghost> has joined #bitcoin-core-dev
1342024-01-08T13:51:50 *** bitdex_ <bitdex_!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
1352024-01-08T13:59:07 *** cryptapus_ <cryptapus_!~cryptapus@user/cryptapus> has quit IRC (Quit: Konversation terminated!)
1362024-01-08T14:01:05 *** cryptapus <cryptapus!~cryptapus@user/cryptapus> has joined #bitcoin-core-dev
1372024-01-08T14:03:36 *** not_reserved <not_reserved!~not_reser@185.153.177.190> has quit IRC (Ping timeout: 250 seconds)
1382024-01-08T14:15:29 *** Guest28 <Guest28!~Guest86@ppp-27-55-72-81.revip3.asianet.co.th> has joined #bitcoin-core-dev
1392024-01-08T14:15:50 *** Guest28 <Guest28!~Guest86@ppp-27-55-72-81.revip3.asianet.co.th> has quit IRC (Client Quit)
1402024-01-08T14:35:06 *** puchka <puchka!~puchka@185.203.122.43> has quit IRC (Ping timeout: 260 seconds)
1412024-01-08T14:45:07 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/04b9df0f9fd9...c2d04f1319a6
1422024-01-08T14:45:07 <bitcoin-git> bitcoin/master 406b71a Andrew Chow: wallet: Migrate entire address book entries
1432024-01-08T14:45:08 <bitcoin-git> bitcoin/master c2d04f1 fanquake: Merge bitcoin/bitcoin#28610: wallet: Migrate entire address book entries t...
1442024-01-08T14:45:14 <bitcoin-git> [bitcoin] fanquake merged pull request #28610: wallet: Migrate entire address book entries to watchonly and solvables too (master...migrate-avoidreuse) https://github.com/bitcoin/bitcoin/pull/28610
1452024-01-08T15:02:30 <bitcoin-git> [bitcoin] hebasto opened pull request #29203: build: Drop `ALLOW_HOST_PACKAGES` support in depends (master...240108-allow) https://github.com/bitcoin/bitcoin/pull/29203
1462024-01-08T15:05:35 <bitcoin-git> [bitcoin] furszy opened pull request #29204: test: wallet migration, add coverage for tx extra data (master...2023_test_wallet_txs_comments_migration) https://github.com/bitcoin/bitcoin/pull/29204
1472024-01-08T15:11:01 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has joined #bitcoin-core-dev
1482024-01-08T15:11:58 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has quit IRC (Remote host closed the connection)
1492024-01-08T15:22:15 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has joined #bitcoin-core-dev
1502024-01-08T15:50:14 *** bob_x2 <bob_x2!~bob_x@user/bob-x1/x-8934932> has quit IRC (Remote host closed the connection)
1512024-01-08T15:50:51 *** bob_x2 <bob_x2!~bob_x@user/bob-x1/x-8934932> has joined #bitcoin-core-dev
1522024-01-08T15:51:50 <bitcoin-git> [gui] achow101 closed pull request #747: Open fully encrypted wallets (master...gui-fully-encrypted-wallets) https://github.com/bitcoin-core/gui/pull/747
1532024-01-08T16:05:22 *** puchka <puchka!~puchka@185.203.122.49> has joined #bitcoin-core-dev
1542024-01-08T16:06:39 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
1552024-01-08T16:16:23 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC ()
1562024-01-08T16:50:10 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
1572024-01-08T16:56:42 <bitcoin-git> [bitcoin] fanquake opened pull request #29205: build: always set `-g -O2` in `CORE_CXXFLAGS` (master...core_cxxflags_always_O2) https://github.com/bitcoin/bitcoin/pull/29205
1582024-01-08T17:01:36 <bitcoin-git> [bitcoin] yancyribbens opened pull request #29206: test: Add algo assert to bnb_search_test (master...add-algo-assert-to-bnb-tests) https://github.com/bitcoin/bitcoin/pull/29206
1592024-01-08T17:02:00 *** not_reserved <not_reserved!~not_reser@185.153.177.190> has joined #bitcoin-core-dev
1602024-01-08T17:33:57 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
1612024-01-08T17:35:28 *** _flood <_flood!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Ping timeout: 256 seconds)
1622024-01-08T18:05:27 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
1632024-01-08T18:05:55 *** puchka <puchka!~puchka@185.203.122.49> has quit IRC (Ping timeout: 246 seconds)
1642024-01-08T18:15:08 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Ping timeout: 256 seconds)
1652024-01-08T18:36:17 *** not_reserved <not_reserved!~not_reser@185.153.177.190> has quit IRC (Quit: Client closed)
1662024-01-08T18:43:08 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
1672024-01-08T18:46:34 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
1682024-01-08T18:55:24 *** freesprung512 <freesprung512!~freesprun@user/freesprung> has quit IRC (Ping timeout: 252 seconds)
1692024-01-08T19:02:21 *** freesprung512 <freesprung512!~freesprun@user/freesprung> has joined #bitcoin-core-dev
1702024-01-08T19:11:05 *** GregTonoski <GregTonoski!~GregTonos@2a02:a31a:4049:ea80:ed69:72d4:69a:f069> has joined #bitcoin-core-dev
1712024-01-08T19:23:03 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Quit: Leaving)
1722024-01-08T19:32:46 *** freesprung512 <freesprung512!~freesprun@user/freesprung> has quit IRC (Ping timeout: 256 seconds)
1732024-01-08T19:39:55 *** GregTonoski <GregTonoski!~GregTonos@2a02:a31a:4049:ea80:ed69:72d4:69a:f069> has quit IRC (Quit: Client closed)
1742024-01-08T19:46:28 *** GregTonoski <GregTonoski!~GregTonos@2a02:a31a:4049:ea80:ed69:72d4:69a:f069> has joined #bitcoin-core-dev
1752024-01-08T19:54:34 *** freesprung512 <freesprung512!~freesprun@user/freesprung> has joined #bitcoin-core-dev
1762024-01-08T19:58:09 *** GregTonoski <GregTonoski!~GregTonos@2a02:a31a:4049:ea80:ed69:72d4:69a:f069> has quit IRC (Quit: Client closed)
1772024-01-08T20:02:13 *** GregTonoski <GregTonoski!~GregTonos@2a02:a31a:4049:ea80:ed69:72d4:69a:f069> has joined #bitcoin-core-dev
1782024-01-08T20:08:57 <GregTonoski> #proposedmeetingtopic SPAM threats and protection in Bitcoin Core
1792024-01-08T20:10:01 *** GregTonoski <GregTonoski!~GregTonos@2a02:a31a:4049:ea80:ed69:72d4:69a:f069> has quit IRC (Quit: Client closed)
1802024-01-08T20:10:15 *** GregTonoski <GregTonoski!~GregTonos@2a02:a31a:4049:ea80:ed69:72d4:69a:f069> has joined #bitcoin-core-dev
1812024-01-08T20:10:56 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1822024-01-08T20:11:49 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 256 seconds)
1832024-01-08T20:18:28 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
1842024-01-08T20:18:39 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
1852024-01-08T20:24:39 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has quit IRC (Remote host closed the connection)
1862024-01-08T20:25:24 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:6991:fbec:aa44:24c7> has joined #bitcoin-core-dev
1872024-01-08T20:25:55 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
1882024-01-08T20:28:40 <sr_gi[m]> brunoerg: I came across #27114 and considered giving it a review but I'm really missing context here. Why would you want to whitelist an outbound connection? (the issue being linked has a broken reference to the code so I'm really missing the point)
1892024-01-08T20:28:43 <gribble> https://github.com/bitcoin/bitcoin/issues/27114 | p2p: Allow whitelisting outgoing connections by brunoerg · Pull Request #27114 · bitcoin/bitcoin · GitHub
1902024-01-08T20:35:23 <instagibbs> sr_gi[m] if you follow the other issue that was closed, looks like it's so you don't DoS ban a node you connect to intentionally
1912024-01-08T20:38:10 <sr_gi[m]> instagibbs: but that's a bit odd, isn't it? Outbounds are picked at random, so whitelisting a random peer does not seem like a good practice to begin with. If you happen to want to whitelist a manually added outbound that would be different, but then the anti DoS motivation doesn't make much sense (you are not going to DoS yourself)
1922024-01-08T20:38:54 <brunoerg> Hi
1932024-01-08T20:38:58 <sr_gi[m]> I could see this being somewhat useful if we were talking about manual outbound for any other case but anti DoS, that is, you want to whitelist with forcerelay for instance, or mempool
1942024-01-08T20:39:09 <brunoerg> there are other reasons: https://github.com/bitcoin/bitcoin/pull/17167#issuecomment-1168606032
1952024-01-08T20:40:11 <brunoerg> it also can be used to speed up tx relay/mempool sync in the tests
1962024-01-08T20:40:31 <brunoerg> one more reason maybe: https://github.com/bitcoin/bitcoin/pull/29058#issuecomment-1865155764
1972024-01-08T20:42:09 <sr_gi[m]> brunoerg: Thanks! I think adding this to the PR description as motivation would be helpful, both for future reference reasons but also for reviewers that may find themselves in the same spot I'm atm
1982024-01-08T20:43:43 <brunoerg> Sure, will add! Thank you!
1992024-01-08T20:52:05 *** GregTonoski <GregTonoski!~GregTonos@2a02:a31a:4049:ea80:ed69:72d4:69a:f069> has quit IRC (Quit: Client closed)
2002024-01-08T21:47:35 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Remote host closed the connection)
2012024-01-08T21:48:35 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
2022024-01-08T21:53:36 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 252 seconds)
2032024-01-08T21:59:29 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
2042024-01-08T22:04:30 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 260 seconds)
2052024-01-08T22:09:44 *** preimage <preimage!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 4.1.1)
2062024-01-08T22:24:28 *** DarrylTheFish <DarrylTheFish!~DarrylThe@2804:14d:5c32:5e6f::2000> has joined #bitcoin-core-dev
2072024-01-08T22:38:16 *** DarrylTheFish <DarrylTheFish!~DarrylThe@user/DarrylTheFish> has quit IRC (Remote host closed the connection)
2082024-01-08T22:39:08 *** DarrylTheFish <DarrylTheFish!~DarrylThe@2804:14d:5c32:5e6f::2000> has joined #bitcoin-core-dev
2092024-01-08T22:52:05 *** Guest38 <Guest38!~Guest38@140.213.171.253> has joined #bitcoin-core-dev
2102024-01-08T22:54:23 *** Guest38 <Guest38!~Guest38@140.213.171.253> has quit IRC (Client Quit)
2112024-01-08T23:04:26 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
2122024-01-08T23:15:33 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 268 seconds)
2132024-01-08T23:16:06 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
2142024-01-08T23:21:10 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 276 seconds)
2152024-01-08T23:27:50 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Quit: Leaving)
2162024-01-08T23:31:10 *** zato <zato!~zato@user/zato> has quit IRC (Quit: Om mani padme hum)
2172024-01-08T23:38:36 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
2182024-01-08T23:43:19 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 256 seconds)
2192024-01-08T23:55:32 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev