12024-03-28T00:13:21 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
22024-03-28T00:21:07 *** noonien808310429 <noonien808310429!~noonien@86.125.147.232> has quit IRC (Ping timeout: 268 seconds)
32024-03-28T00:31:09 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
42024-03-28T00:40:11 *** asher <asher!~ash3y@216.98.225.36> has quit IRC (Ping timeout: 264 seconds)
52024-03-28T01:02:14 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
62024-03-28T01:06:31 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: leaving)
72024-03-28T01:17:54 *** asher <asher!~ash3y@216.98.225.36> has joined #bitcoin-core-dev
82024-03-28T01:22:13 *** pablomartin <pablomartin!~pablomart@217.146.93.18> has quit IRC (Remote host closed the connection)
92024-03-28T01:22:29 *** pablomartin <pablomartin!~pablomart@217.146.93.18> has joined #bitcoin-core-dev
102024-03-28T01:28:58 *** preimage <preimage!~halosghos@user/halosghost> has joined #bitcoin-core-dev
112024-03-28T01:35:59 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 264 seconds)
122024-03-28T02:45:43 *** Guest5 <Guest5!~Guest5@2806:2a0:1030:3e29:348a:1acd:4059:6fe7> has joined #bitcoin-core-dev
132024-03-28T02:51:05 *** Guest5 <Guest5!~Guest5@2806:2a0:1030:3e29:348a:1acd:4059:6fe7> has quit IRC (Quit: Client closed)
142024-03-28T03:05:39 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has quit IRC (Ping timeout: 256 seconds)
152024-03-28T03:12:52 *** preimage <preimage!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 4.2.1)
162024-03-28T03:13:37 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
172024-03-28T03:14:01 *** pablomartin <pablomartin!~pablomart@217.146.93.18> has quit IRC (Remote host closed the connection)
182024-03-28T03:14:26 *** pablomartin <pablomartin!~pablomart@217.146.93.18> has joined #bitcoin-core-dev
192024-03-28T03:21:11 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 268 seconds)
202024-03-28T03:33:32 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
212024-03-28T03:36:35 *** pablomartin <pablomartin!~pablomart@217.146.93.18> has quit IRC (Ping timeout: 264 seconds)
222024-03-28T03:52:38 *** asher <asher!~ash3y@216.98.225.36> has quit IRC (Ping timeout: 268 seconds)
232024-03-28T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
242024-03-28T04:01:32 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
252024-03-28T04:05:35 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 268 seconds)
262024-03-28T04:28:37 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
272024-03-28T05:43:47 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Quit: jarthur)
282024-03-28T06:03:00 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
292024-03-28T06:35:53 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 256 seconds)
302024-03-28T07:40:54 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
312024-03-28T08:18:51 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has joined #bitcoin-core-dev
322024-03-28T08:26:41 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
332024-03-28T08:28:44 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 260 seconds)
342024-03-28T08:33:17 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
352024-03-28T09:10:49 *** aleggg <aleggg!~aleggg@177.204.243.50.dynamic.adsl.gvt.net.br> has quit IRC (Remote host closed the connection)
362024-03-28T09:13:30 *** aleggg <aleggg!~aleggg@177.204.243.50.dynamic.adsl.gvt.net.br> has joined #bitcoin-core-dev
372024-03-28T09:15:07 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
382024-03-28T09:18:01 *** instagibbs <instagibbs!~instagibb@pool-100-15-116-202.washdc.fios.verizon.net> has quit IRC (Ping timeout: 255 seconds)
392024-03-28T09:18:56 *** instagibbs <instagibbs!~instagibb@pool-100-15-116-202.washdc.fios.verizon.net> has joined #bitcoin-core-dev
402024-03-28T09:20:19 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
412024-03-28T09:28:59 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Quit: Leaving...)
422024-03-28T09:44:06 *** lbia <lbia!~lbia@user/lbia> has quit IRC (Quit: lbia)
432024-03-28T10:13:37 *** asher <asher!~ash3y@216.98.225.36> has joined #bitcoin-core-dev
442024-03-28T10:15:52 *** aleggg <aleggg!~aleggg@177.204.243.50.dynamic.adsl.gvt.net.br> has quit IRC (Remote host closed the connection)
452024-03-28T10:35:51 *** asher <asher!~ash3y@216.98.225.36> has quit IRC (Ping timeout: 255 seconds)
462024-03-28T10:55:13 *** lbia <lbia!~lbia@user/lbia> has joined #bitcoin-core-dev
472024-03-28T11:27:57 *** BrandonOdiwuor <BrandonOdiwuor!~BrandonOd@41.80.113.148> has joined #bitcoin-core-dev
482024-03-28T11:35:43 *** the_mariner <the_mariner!~Thunderbi@177.37.233.227> has joined #bitcoin-core-dev
492024-03-28T11:43:20 <bitcoin-git> [bitcoin] hebasto opened pull request #29756: doc: Override `-g` properly to skip debugging information (master...240328-debug) https://github.com/bitcoin/bitcoin/pull/29756
502024-03-28T11:43:51 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
512024-03-28T11:44:21 <bitcoin-git> [bitcoin] glozow pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c8e397811471...d1e9a0212663
522024-03-28T11:44:22 <bitcoin-git> bitcoin/master b9f04be kevkevin: mempool: Log added for dumping mempool transactions to disk
532024-03-28T11:44:23 <bitcoin-git> bitcoin/master 4d5b557 kevkevin: log: renamed disk to file so wording was more accurate
542024-03-28T11:44:23 <bitcoin-git> bitcoin/master d1e9a02 glozow: Merge bitcoin/bitcoin#29402: mempool: Log added for dumping mempool transa...
552024-03-28T11:44:30 <bitcoin-git> [bitcoin] glozow merged pull request #29402: mempool: Log added for dumping mempool transactions to disk (master...dumpmempoollogsfeb2024) https://github.com/bitcoin/bitcoin/pull/29402
562024-03-28T11:56:26 *** lbia <lbia!~lbia@user/lbia> has quit IRC (Quit: lbia)
572024-03-28T11:59:21 *** lbia <lbia!~lbia@user/lbia> has joined #bitcoin-core-dev
582024-03-28T12:23:23 *** cbergqvist <cbergqvist!~chris@84-216-185-21.customers.ownit.se> has quit IRC (Ping timeout: 272 seconds)
592024-03-28T12:43:55 <vasild> I wonder why nBind is present on this line https://github.com/bitcoin/bitcoin/blob/c8e3978114716bb8fb10695b9d187652f3ab4926/src/init.cpp#L990 but not on https://github.com/bitcoin/bitcoin/blob/c8e3978114716bb8fb10695b9d187652f3ab4926/src/init.cpp#L993
602024-03-28T12:45:22 <vasild> The original version of this code is https://github.com/bitcoin/bitcoin/blob/ba29a5590bc4479d74454f0b9fdaf007d9d80221/src/init.cpp#L533 (line 533 and 538)
612024-03-28T12:46:49 <vasild> sipa: in case you remember, that is from 2013, not too long ago. To my understanding nBind should be present in both expressions
622024-03-28T12:57:10 *** aleggg <aleggg!~aleggg@177.204.243.50.dynamic.adsl.gvt.net.br> has joined #bitcoin-core-dev
632024-03-28T12:58:06 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:eda9:cf5e:34be:6b67> has joined #bitcoin-core-dev
642024-03-28T13:08:49 <bitcoin-git> [bitcoin] sipa opened pull request #29757: feefrac: avoid explicitly computing diagram; compare based on chunks (master...202403_implicit_diagram) https://github.com/bitcoin/bitcoin/pull/29757
652024-03-28T13:16:27 *** pablomartin <pablomartin!~pablomart@185.216.146.241> has joined #bitcoin-core-dev
662024-03-28T13:19:13 <sipa> vasild: i have no memory of that code
672024-03-28T13:20:05 <vasild> ;-)
682024-03-28T13:20:51 <vasild> ok, maybe I will PR some simplification of that
692024-03-28T13:34:02 <_aj_> vasild: fd_max - nbind -- so you can have an fd for each interface you're listening on would be my guess?
702024-03-28T13:35:21 <vasild> yes, for example -bind=1.2.3.4:1234 -bind=[2001::234]:2837 -bind=... would need 3 file descriptors for bind/listening
712024-03-28T13:36:14 <vasild> it is properly accounted for on line 990 in the latest code but is missing from line 993 and I wonder why, I think it should be present on line 993 as well
722024-03-28T13:36:52 <darosior> a story of a bug in one part "Not sure i understand this code. I will refactor it to make it simpler." :p
732024-03-28T13:37:25 <vasild> darosior: been there done that :) or also "s/refactor/delete/" ;_)
742024-03-28T13:37:45 <_aj_> vasild: it's mentioned in line 981, so seems like it should appear in 993 as well to me too, fwiw
752024-03-28T13:41:15 <vasild> to be honest this nMaxConnections tweaking around those lines gives me a headache, it could be that I misunderstand it. darosior _aj_ sipa I will poke you for review if I gather enough bravery to simplify it (aka break it)
762024-03-28T13:42:08 <darosior> is this the best use of everyone's time? Did you find a bug related to this or are you just trying to make it "look nicer"?
772024-03-28T13:42:45 <_aj_> vasild: i think the main value is (a) to give an error in the logs if your system can't support the connections you want, and (b) to ensure enough fds are reserved for manual addnode connections
782024-03-28T13:45:22 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
792024-03-28T13:48:14 <vasild> darosior: I think this piece is complicated enough to warrant a simplification. If I have troubles understanding it then others may as well. The code is read many times by many people, so that multiples. Also, I am now adding a new metric to that, similar to nBind and if there is a bug in the existent code, then should I do as in nBind, repeat the bug in the new code or not? This arised in
802024-03-28T13:48:20 <vasild> https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1539858047. Your or any other reviewer's judgement could vary of course. In this case you are free to ignore a PR if you view it as not important enough.
812024-03-28T13:49:25 <darosior> sure, just asking cause you wanted me to review.
822024-03-28T13:50:32 <vasild> ok, just "poke", feel free to ignore any review request. And I still have not opened any PR for that, maybe I will put it somewhere lower on my TODO and will never get to it...
832024-03-28T13:53:23 *** pablomartin <pablomartin!~pablomart@185.216.146.241> has quit IRC (Ping timeout: 264 seconds)
842024-03-28T13:54:26 *** BrandonOdiwuor <BrandonOdiwuor!~BrandonOd@41.80.113.148> has quit IRC (Ping timeout: 250 seconds)
852024-03-28T14:00:13 *** Guest42 <Guest42!~Guest42@212.129.75.125> has joined #bitcoin-core-dev
862024-03-28T14:00:25 <achow101> #startmeeting
872024-03-28T14:00:29 <darosior> hi
882024-03-28T14:00:34 <dergoegge> hi
892024-03-28T14:00:37 <Murch[m]> hi
902024-03-28T14:00:39 <pinheadmz> hi
912024-03-28T14:00:41 <achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa theStack TheCharlatan vasild
922024-03-28T14:00:50 <hebasto> hi
932024-03-28T14:00:51 <glozow> hi
942024-03-28T14:00:52 <TheCharlatan> hi
952024-03-28T14:00:55 <furszy> hi
962024-03-28T14:01:02 <vasild> hi
972024-03-28T14:01:09 <achow101> There are 2 pre proposed meeting topics this week, and last minute ones to add
982024-03-28T14:01:37 <sdaftuar> hi
992024-03-28T14:01:39 <theStack> hi
1002024-03-28T14:01:55 <luke-jr_> hi
1012024-03-28T14:02:06 <kevkevin> hi
1022024-03-28T14:02:07 <lightlike> Hi
1032024-03-28T14:02:23 <achow101> #topic package relay updates (glozow)
1042024-03-28T14:02:31 <stickies-v> hi
1052024-03-28T14:02:34 <glozow> #28970 is my priority. Also, #29242 was merged. a followup is open (#29724) and I think the next PR is ready for review (#28984).
1062024-03-28T14:02:35 <LarryRuane> Hi
1072024-03-28T14:02:37 <gribble> https://github.com/bitcoin/bitcoin/issues/28970 | p2p: opportunistically accept 1-parent-1-child packages by glozow · Pull Request #28970 · bitcoin/bitcoin · GitHub
1082024-03-28T14:02:40 <gribble> https://github.com/bitcoin/bitcoin/issues/29242 | Mempool util: Add RBF diagram checks for single chunks against clusters of size 2 by instagibbs · Pull Request #29242 · bitcoin/bitcoin · GitHub
1092024-03-28T14:02:42 <gribble> https://github.com/bitcoin/bitcoin/issues/29724 | 29242 Diagram check followups by instagibbs · Pull Request #29724 · bitcoin/bitcoin · GitHub
1102024-03-28T14:02:43 <gribble> https://github.com/bitcoin/bitcoin/issues/28984 | Cluster size 2 package rbf by instagibbs · Pull Request #28984 · bitcoin/bitcoin · GitHub
1112024-03-28T14:02:54 <glozow> Thats it from me
1122024-03-28T14:03:01 <b10c> hi
1132024-03-28T14:03:25 <achow101> #topic cluster mempool updates (sdaftuar)
1142024-03-28T14:03:30 <sdaftuar> hi--
1152024-03-28T14:03:35 <sdaftuar> Hi -- I found a memory accounting bug in the draft PR this week, which I think I've figured out and have a fix for, but haven't yet pushed. I'm verifying my fix now on my historical data and will push once I'm done.
1162024-03-28T14:03:41 <sdaftuar> Also, the draft PR is now badly in need of a rebase, which I probably won't get to in the next week -- I'm prioritizing trying to do research on historical data with the branch that I have.
1172024-03-28T14:03:51 <sdaftuar> My hope is to put together some kind of summary of the changes to transaction acceptance that would have occurred with the new mempool, based on last year's transaction data. (This includes redoing the preliminary performance benchmarks that I'd previously done which need to be re-done with the above-mentioned bugfix in place.)
1182024-03-28T14:04:03 <sdaftuar> So I'm planning to tackle the rebase and re-working of the draft PR after that research is complete.
1192024-03-28T14:04:10 <sdaftuar> Excitingly (for me), today I discovered over 1000 examples of RBFs that took place in January 2023 which were accepted by the old mempool logic but would have been rejected by the new feerate diagram check, which I'm in the process of exploring further.
1202024-03-28T14:04:16 <sdaftuar> If anyone has any questions that I can answer, please let me know!
1212024-03-28T14:04:22 <sdaftuar> (that's it for me)
1222024-03-28T14:04:57 <glozow> cool! (the RBFs)
1232024-03-28T14:05:25 <achow101> Is there anything that can be reviewed right now?
1242024-03-28T14:06:20 <kanzure> hi
1252024-03-28T14:06:23 *** luke-jr_ is now known as luke-jr
1262024-03-28T14:07:14 <sdaftuar> achow101: well, i'm going to start asking people for help with the wallet and mini_miner changes soon. probably not a lot of useful review to be done now on the implementation itself, but i think reviewing the test changes could be helpful--
1272024-03-28T14:07:31 <sdaftuar> really i think it would be helpful if anyone is interested in writing better/more comprehensive tests which i could take in the PR
1282024-03-28T14:07:38 <sdaftuar> but that can also come later, of course
1292024-03-28T14:08:56 <achow101> #topic legacy wallet removal updates (achow101)
1302024-03-28T14:09:05 <vasild> "last year's transaction data" - do you take that from the blockchain or did you run some recorder that saves each tx that makes it to your mempool. E.g. if a transaction was accepted in the mempool but never mined, would it be in that historical data you tested with?
1312024-03-28T14:09:55 <sdaftuar> vasild: i have a data logging system that records every transaction and block that my node sees, and a patch set that allows me to play that data back through our validation logic
1322024-03-28T14:10:37 <vasild> cool :)
1332024-03-28T14:10:38 <achow101> Hasn't been much activity in the last week so the thing to review is still #26606. Also been reviewing #28574, hoping to get that in soon
1342024-03-28T14:10:40 <gribble> https://github.com/bitcoin/bitcoin/issues/26606 | wallet: Implement independent BDB parser by achow101 · Pull Request #26606 · bitcoin/bitcoin · GitHub
1352024-03-28T14:10:41 <gribble> https://github.com/bitcoin/bitcoin/issues/28574 | wallet: optimize migration process, batch db transactions by furszy · Pull Request #28574 · bitcoin/bitcoin · GitHub
1362024-03-28T14:11:16 <achow101> #topic Ad-hoc high priority for review
1372024-03-28T14:11:24 <achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
1382024-03-28T14:13:23 <achow101> #topic enable misc-no-recursion: #29690 (proposing on behalf of @dergoegge) (stickies-v)
1392024-03-28T14:13:25 <gribble> https://github.com/bitcoin/bitcoin/issues/29690 | clang-tidy: Enable misc-no-recursion by dergoegge · Pull Request #29690 · bitcoin/bitcoin · GitHub
1402024-03-28T14:13:37 <dergoegge> i have a pr open to discourage the use of recursion (and to make it obvious when we introduce it) using the "misc-no-recursion" clang-tidy plugin #29690
1412024-03-28T14:13:37 <gribble> https://github.com/bitcoin/bitcoin/issues/29690 | clang-tidy: Enable misc-no-recursion by dergoegge · Pull Request #29690 · bitcoin/bitcoin · GitHub
1422024-03-28T14:13:57 <dergoegge> if anyone has an issue with that please comment on the PR :)
1432024-03-28T14:14:18 <vasild> Is recursion frowned upon? :-O
1442024-03-28T14:15:00 <luke-jr> there's some arguments made, but I think the point here is to make it explicit
1452024-03-28T14:15:35 <luke-jr> contrasted with (eg) calling the same function with a different signature
1462024-03-28T14:15:54 <dergoegge> there is nuance to that question, i'd frown upon it in our repo but it's mostly about making it explicit
1472024-03-28T14:16:56 <achow101> The suggestion is that if a function is recursive, just mark it as such, rather than avoiding it entirely?
1482024-03-28T14:17:29 <achow101> iirc it's used quite a bit in wallet related things (descriptors, signing, etc.)
1492024-03-28T14:17:32 <lightlike> Is this an actual problem? Are there too many (or any) PRs that attempt to introduce recursion?
1502024-03-28T14:18:00 <luke-jr> lightlike: introducing recursion shouldn't be forbidden.. that's a different thing from making it explicit
1512024-03-28T14:18:02 <fjahr> I think itâs not going to be doing much for us because itâs not like inexperienced developers include recursion in their PRs by accident very often. But since this also wonât affect ~99% all PRs anyway, I wonât stand in the way if enough others see value in this.
1522024-03-28T14:18:30 <sipa> there have been some cases of recursive functions in the codebase that could be triggered to cause stack overfloe
1532024-03-28T14:18:49 <sipa> (including ones introduced by me)
1542024-03-28T14:19:01 <luke-jr> I guess the real question is, would this have helped catch those? ;)
1552024-03-28T14:19:18 <sipa> i doubt it
1562024-03-28T14:20:13 <sipa> but it's hard to say, having the explicit marker in the codebase permanently may cause some people to occasionslly just look over all of them
1572024-03-28T14:20:26 <achow101> I suppose if you have opinions, go comment on the PR?
1582024-03-28T14:20:50 <luke-jr> is it the function that gets marked, or the call?
1592024-03-28T14:20:51 <sipa> ok
1602024-03-28T14:20:54 <luke-jr> achow101: k
1612024-03-28T14:20:55 <dergoegge> ð
1622024-03-28T14:21:00 <vasild> In my experience some problems are recursive in nature and the recursive solution is neat an tidy and easy to follow and review and thus unlikely to have bugs. Iterative solutions for those on the other hand could be messy and easier to get wrong. I don't think a blanket ban on recursion makes sense in any project. Explicitly flagging a function "this is recursive" to avoid accidental recursion
1632024-03-28T14:21:00 <achow101> #topic writeups and disclosure of historical bugs reported but were never published (darosior)
1642024-03-28T14:21:05 <vasild> is another thing. +1 on that.
1652024-03-28T14:21:06 <sipa> luke-jr: in recursive functions, those two are the same :)
1662024-03-28T14:21:22 <darosior> So last time a group of us met in person, Niklas and i volunteered to make a few writeups about historical vulnerabilities which were reported to the project. So we did that. Thanks to fanquake for sharing with us the old reports.
1672024-03-28T14:21:22 <luke-jr> sipa: not really, the call site may be a page or two away
1682024-03-28T14:21:31 <darosior> We only have two though, looks like there were not that many in the end.
1692024-03-28T14:21:32 <sipa> luke-jr: the function gets marked
1702024-03-28T14:21:39 <darosior> We think we could write a blog post at bitcoincore.org about them, and maybe announce them on the ML. Does anyone has any feedback / opinion / objection to us doing this? (remember we are talking about very old vulnerabilities which were just never disclosed)
1712024-03-28T14:21:57 <achow101> darosior: I think putting them on bitcoincore.org is fine
1722024-03-28T14:21:59 <sdaftuar> seems like a good idea to me, thanks for doing this!
1732024-03-28T14:22:14 <instagibbs> +1
1742024-03-28T14:22:20 <luke-jr> darosior: there's definitely more than 2?
1752024-03-28T14:22:40 <darosior> luke-jr: we can only put so much pressure on fanquake to spit historical reports
1762024-03-28T14:23:05 <b10c> +1 on publishing
1772024-03-28T14:23:14 <darosior> cool, also maybe as a teaser: we want to animate a discussion at the next about how to handle disclosures moving forward
1782024-03-28T14:23:20 <achow101> we can talk offline if there are any more to write
1792024-03-28T14:23:28 <darosior> s/at the next/at the next in-person meeting/
1802024-03-28T14:24:03 <sipa> yeah i think i can help with more old ones too
1812024-03-28T14:24:11 <achow101> yes, I think bringing up this discussion at the next coredev would be good
1822024-03-28T14:24:19 <darosior> sipa: cool, will reach out
1832024-03-28T14:24:35 <luke-jr> k
1842024-03-28T14:24:44 <vasild> What's the point in publishing those? To get people running vulnerable versions to upgrade?
1852024-03-28T14:25:22 <dergoegge> vasild: yes and to give credit to the people that find the bugs
1862024-03-28T14:25:27 <darosior> I don't think anybody runs the affected versions anymore
1872024-03-28T14:25:31 <achow101> vasild: transparency, and it's also generally useful to have old vulns published so people can talk about them
1882024-03-28T14:25:38 <sdaftuar> vasild: i think it can also be instructive to contributors to learn from the past
1892024-03-28T14:25:41 <sipa> and also for ourselves, i think it's good to have a culture of keeping track of tjedr
1902024-03-28T14:25:45 <sipa> *these
1912024-03-28T14:26:13 <darosior> and there is also maybe a point to communicate to the larger Bitcoin community that this kind of thing does happen
1922024-03-28T14:26:13 <vasild> Good! I did not think about those
1932024-03-28T14:26:15 <kanzure> is there any existing disclosure content on bitcoincore.org? i don't want to see a "policy"
1942024-03-28T14:26:23 <luke-jr> darosior: there's at least a few trying to encourage downgrading to 0.12 :/
1952024-03-28T14:26:27 <achow101> kanzure: pretty sure there's a few older things
1962024-03-28T14:26:31 <sdaftuar> kanzure: isnt' the inflation bug on there?
1972024-03-28T14:26:39 <harding> kanzure: year, duplicate inputs bug is there
1982024-03-28T14:26:41 <darosior> sdaftuar: yes it it
1992024-03-28T14:26:54 <dergoegge> kanzure: e.g. https://bitcoincore.org/en/2019/11/08/CVE-2017-18350/
2002024-03-28T14:26:58 <achow101> they're buried deep in the blog section
2012024-03-28T14:27:12 <luke-jr> not-time-sensitive stuff has historically been published elsewhere tho
2022024-03-28T14:27:29 <luke-jr> maybe we can add a page of links to the menus somewhere so they're easy to find
2032024-03-28T14:27:35 <kanzure> there needs to be room to maneuver with respect to responsible disclosure and the unique nature of each incident. historical should be fine to document, but i wouldn't want it to be misinterpreted as an expectation on any specific timeline.
2042024-03-28T14:27:45 <achow101> luke-jr: it does make sense to have one place with/linking to all of them though
2052024-03-28T14:28:07 <achow101> kanzure: I don't think we're going to be setting a policy with hard deadlines
2062024-03-28T14:28:17 <darosior> kanzure: yes this topic was only about historical reports. Disclosure of more recent reports will be discussed at the next in-person meeting.
2072024-03-28T14:28:26 <sipa> kanzure: agreed, but i also think the number of bugs that require unusual treatment i a tiny fraction only
2082024-03-28T14:28:44 <kanzure> sipa: glad to hear that.
2092024-03-28T14:28:55 <darosior> Alright i think that's all we had to share, dergoegge anything to add?
2102024-03-28T14:29:04 <sipa> i assume darosior and dergoegge are talking about the few very serious ones we've had, and for those, we need ad-hoc proceddes
2112024-03-28T14:29:44 *** Guest42 <Guest42!~Guest42@212.129.75.125> has quit IRC (Quit: Client closed)
2122024-03-28T14:29:51 <dergoegge> darosior: no :)
2132024-03-28T14:29:54 <fjahr> some old fork based altcoins could be affected still right? Not saying that means we shouldn't do it, just a thought. Maybe you could grep for the affected lines in github?
2142024-03-28T14:30:01 *** Guest42 <Guest42!~Guest42@212.129.75.125> has joined #bitcoin-core-dev
2152024-03-28T14:30:41 <darosior> fjahr: it's a decade old, i don't think anything remotely sane still running would be on these versions anymore
2162024-03-28T14:30:55 <achow101> darosior: there are plenty of insane people :p
2172024-03-28T14:30:56 <b10c> fjahr: if they haven't cherry-picked commits in 10 years, they won't start now?
2182024-03-28T14:31:00 <kanzure> fjahr: yes this has been discussed on the mailing list in the past as an issue with responsible disclosure (do i personally owe any responsibility to disclose to altcoins that forked and didn't provide developer resources back? what about their users...?) etc
2192024-03-28T14:31:13 <luke-jr> b10c: maybe they have, just didn't know about the relevant ones?
2202024-03-28T14:31:41 <luke-jr> kanzure: even if they had provided resources back, they wouldn't necessarily know
2212024-03-28T14:31:56 <fjahr> b10c: yeah, still a heads up a few days before publishing would be nice, but no strong feelings either way...
2222024-03-28T14:32:03 <kanzure> (and there are also security issues with disclosing to altcoins: many of these projects are acting as adversarial entities! why would you disclose weapons or vulnerabilities or whatever?)
2232024-03-28T14:32:18 <luke-jr> there's only a small few legit altcoins tho, and I don't see why we should care about the scams
2242024-03-28T14:32:27 <achow101> as usual, I think it needs to be evaluated on a case by case basis
2252024-03-28T14:32:31 <luke-jr> the legit ones are likely already rebased anyway
2262024-03-28T14:32:37 <darosior> fjahr: for recent disclosure i agree out of courtesy we could be reaching to a few of the main altcoins a few days before publishing. For historical ones, meh
2272024-03-28T14:32:42 <kanzure> sure, sure. this is an old topic, and not much has changed.
2282024-03-28T14:33:06 <achow101> anything else to discuss?
2292024-03-28T14:33:08 <dergoegge> i think i'd be irresponsible not to give them a heads up but only after we've decided it is safe to publish anyway
2302024-03-28T14:35:38 <achow101> #endmeeting
2312024-03-28T14:36:32 *** lbia <lbia!~lbia@user/lbia> has quit IRC (Quit: lbia)
2322024-03-28T14:37:03 *** cguida <cguida!~cguida@2806:2f0:55e1:f7b9:99d9:91ae:74e5:e68d> has quit IRC (Ping timeout: 255 seconds)
2332024-03-28T14:37:36 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Read error: Connection reset by peer)
2342024-03-28T14:39:30 *** Guest42 <Guest42!~Guest42@212.129.75.125> has quit IRC (Quit: Client closed)
2352024-03-28T14:41:24 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
2362024-03-28T14:43:25 *** pablomartin <pablomartin!~pablomart@217.146.93.18> has joined #bitcoin-core-dev
2372024-03-28T14:45:00 *** pablomartin <pablomartin!~pablomart@217.146.93.18> has quit IRC (Read error: Connection reset by peer)
2382024-03-28T14:45:05 *** pablomartin4btc <pablomartin4btc!~pablomart@217.146.93.18> has joined #bitcoin-core-dev
2392024-03-28T14:48:33 *** preimage <preimage!~halosghos@user/halosghost> has joined #bitcoin-core-dev
2402024-03-28T14:49:18 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
2412024-03-28T15:18:35 *** puchka <puchka!~puchka@185.203.122.201> has quit IRC (Ping timeout: 264 seconds)
2422024-03-28T15:23:21 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has quit IRC (Ping timeout: 252 seconds)
2432024-03-28T15:31:46 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:37:6c35:c8b5:c6df:6686> has quit IRC (Remote host closed the connection)
2442024-03-28T15:33:13 <bitcoin-git> [bitcoin] sipa opened pull request #29758: feefrac: 128-bit multiply support in MSVC (master...202403_feefrac128_msvc) https://github.com/bitcoin/bitcoin/pull/29758
2452024-03-28T15:33:39 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has joined #bitcoin-core-dev
2462024-03-28T15:35:43 *** Guest7 <Guest7!~Guest7@2001:1c06:1b15:2100:6c20:d7fc:cadc:9f09> has joined #bitcoin-core-dev
2472024-03-28T15:39:26 *** Guest7 <Guest7!~Guest7@2001:1c06:1b15:2100:6c20:d7fc:cadc:9f09> has quit IRC (Client Quit)
2482024-03-28T15:41:48 *** brunoerg <brunoerg!~brunoerg@187.183.43.117> has quit IRC (Ping timeout: 268 seconds)
2492024-03-28T15:48:02 *** BrandonOdiwuor <BrandonOdiwuor!~BrandonOd@41.80.116.39> has joined #bitcoin-core-dev
2502024-03-28T15:50:54 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
2512024-03-28T15:53:51 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
2522024-03-28T15:56:36 *** pablomartin4btc <pablomartin4btc!~pablomart@217.146.93.18> has quit IRC (Ping timeout: 268 seconds)
2532024-03-28T16:00:31 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
2542024-03-28T16:00:39 *** luke-jr <luke-jr!~luke-jr@user/luke-jr> has joined #bitcoin-core-dev
2552024-03-28T16:01:50 *** BrandonOdiwuor <BrandonOdiwuor!~BrandonOd@41.80.116.39> has quit IRC (Ping timeout: 250 seconds)
2562024-03-28T16:04:16 *** lbia <lbia!~lbia@user/lbia> has joined #bitcoin-core-dev
2572024-03-28T16:22:42 *** preimage <preimage!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 4.2.1)
2582024-03-28T16:29:25 *** puchka <puchka!~puchka@185.203.122.46> has joined #bitcoin-core-dev
2592024-03-28T16:39:30 *** asher <asher!~ash3y@216.98.225.36> has joined #bitcoin-core-dev
2602024-03-28T16:39:55 *** ppisati_ <ppisati_!~flag@81.56.89.175> has quit IRC (Ping timeout: 255 seconds)
2612024-03-28T16:41:52 *** ppisati <ppisati!~flag@81.56.89.175> has joined #bitcoin-core-dev
2622024-03-28T16:59:22 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Remote host closed the connection)
2632024-03-28T17:05:23 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 264 seconds)
2642024-03-28T17:08:10 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2652024-03-28T17:17:00 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 260 seconds)
2662024-03-28T17:53:28 *** asher <asher!~ash3y@216.98.225.36> has quit IRC (Ping timeout: 268 seconds)
2672024-03-28T17:56:08 *** pablomartin <pablomartin!~pablomart@217.146.93.22> has joined #bitcoin-core-dev
2682024-03-28T17:56:50 *** Guest71 <Guest71!~Guest71@177.245.194.2> has joined #bitcoin-core-dev
2692024-03-28T18:07:04 *** Guest71 <Guest71!~Guest71@177.245.194.2> has quit IRC (Ping timeout: 250 seconds)
2702024-03-28T18:27:31 *** ___nick___ <___nick___!~quassel@82-132-213-79.dab.02.net> has joined #bitcoin-core-dev
2712024-03-28T18:30:47 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
2722024-03-28T18:38:03 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
2732024-03-28T18:41:01 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
2742024-03-28T18:43:50 *** Guest29 <Guest29!~Guest29@84-87-86-87.fixed.kpn.net> has joined #bitcoin-core-dev
2752024-03-28T18:44:25 *** Guest29 <Guest29!~Guest29@84-87-86-87.fixed.kpn.net> has quit IRC (Client Quit)
2762024-03-28T18:53:15 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:eda9:cf5e:34be:6b67> has quit IRC (Remote host closed the connection)
2772024-03-28T19:11:02 *** core-meetingbot` <core-meetingbot`!~meetingbo@2a01:4f9:3081:504d::2> has quit IRC (Quit: 2021.06.15)
2782024-03-28T19:11:15 *** core-meetingbot <core-meetingbot!~meetingbo@2a01:4f9:3081:504d::2> has joined #bitcoin-core-dev
2792024-03-28T19:13:56 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 268 seconds)
2802024-03-28T19:14:30 *** preimage <preimage!~halosghos@user/halosghost> has joined #bitcoin-core-dev
2812024-03-28T19:15:57 *** preimage <preimage!~halosghos@user/halosghost> has quit IRC (Client Quit)
2822024-03-28T19:25:30 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Ping timeout: 255 seconds)
2832024-03-28T19:29:45 *** pablomartin <pablomartin!~pablomart@217.146.93.22> has quit IRC (Ping timeout: 252 seconds)
2842024-03-28T20:01:44 *** Zenton <Zenton!~user@user/zenton> has quit IRC (Ping timeout: 268 seconds)
2852024-03-28T20:11:19 *** asher <asher!~ash3y@216.98.225.36> has joined #bitcoin-core-dev
2862024-03-28T20:12:47 *** preimage <preimage!~halosghos@user/halosghost> has joined #bitcoin-core-dev
2872024-03-28T20:25:24 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
2882024-03-28T20:28:00 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC (Client Quit)
2892024-03-28T20:30:25 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2902024-03-28T20:44:48 *** cguida <cguida!~cguida@2806:2f0:55e1:f7b9:a3f6:5e1b:55e:6614> has joined #bitcoin-core-dev
2912024-03-28T21:04:19 *** ___nick___ <___nick___!~quassel@82-132-213-79.dab.02.net> has quit IRC (Ping timeout: 268 seconds)
2922024-03-28T21:05:53 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Quit: WeeChat 4.2.1)
2932024-03-28T21:12:25 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
2942024-03-28T21:15:48 *** aleggg <aleggg!~aleggg@177.204.243.50.dynamic.adsl.gvt.net.br> has quit IRC (Remote host closed the connection)
2952024-03-28T21:23:26 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has joined #bitcoin-core-dev
2962024-03-28T21:24:44 *** pablomartin <pablomartin!~pablomart@217.146.93.23> has joined #bitcoin-core-dev
2972024-03-28T21:41:02 <bitcoin-git> [bitcoin] hebasto opened pull request #29761: build: Consider `SOURCE_DATE_EPOCH` in Guix environment only (master...240328-epoch) https://github.com/bitcoin/bitcoin/pull/29761
2982024-03-28T21:43:16 *** preimage <preimage!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 4.2.1)
2992024-03-28T21:44:24 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 268 seconds)
3002024-03-28T21:54:36 *** brunoerg <brunoerg!~brunoerg@186.204.61.58> has joined #bitcoin-core-dev
3012024-03-28T21:55:33 *** kevkevin <kevkevin!~kevkevin@2601:243:197e:8f10:64e7:e72c:8cfb:6f46> has joined #bitcoin-core-dev
3022024-03-28T21:59:22 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Quit: Leaving)
3032024-03-28T21:59:41 *** kevkevin <kevkevin!~kevkevin@2601:243:197e:8f10:64e7:e72c:8cfb:6f46> has quit IRC (Ping timeout: 240 seconds)
3042024-03-28T22:01:20 *** preimage <preimage!~halosghos@user/halosghost> has joined #bitcoin-core-dev
3052024-03-28T22:02:30 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has joined #bitcoin-core-dev
3062024-03-28T22:03:39 *** Guest1 <Guest1!~Guest1@193.124.92.119> has joined #bitcoin-core-dev
3072024-03-28T22:07:15 *** Guest1 <Guest1!~Guest1@193.124.92.119> has quit IRC (Client Quit)
3082024-03-28T22:07:22 *** brunoerg <brunoerg!~brunoerg@186.204.61.58> has quit IRC (Remote host closed the connection)
3092024-03-28T22:08:19 *** brunoerg <brunoerg!~brunoerg@186.204.61.58> has joined #bitcoin-core-dev
3102024-03-28T22:17:42 *** pablomartin <pablomartin!~pablomart@217.146.93.23> has quit IRC (Ping timeout: 268 seconds)
3112024-03-28T22:30:54 *** pablomartin <pablomartin!~pablomart@217.146.93.21> has joined #bitcoin-core-dev
3122024-03-28T22:31:41 *** AaronvanW <AaronvanW!~AaronvanW@user/AaronvanW> has quit IRC (Ping timeout: 240 seconds)
3132024-03-28T22:44:02 *** aleggg <aleggg!~aleggg@177.204.243.50.dynamic.adsl.gvt.net.br> has joined #bitcoin-core-dev
3142024-03-28T22:54:32 *** brunoerg <brunoerg!~brunoerg@186.204.61.58> has quit IRC (Remote host closed the connection)
3152024-03-28T23:06:32 *** brunoerg <brunoerg!~brunoerg@186.204.61.58> has joined #bitcoin-core-dev
3162024-03-28T23:12:02 *** vasild <vasild!~vd@user/vasild> has quit IRC (Ping timeout: 260 seconds)
3172024-03-28T23:13:41 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
3182024-03-28T23:46:54 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Quit: jarthur)
3192024-03-28T23:54:21 *** brunoerg <brunoerg!~brunoerg@186.204.61.58> has quit IRC (Remote host closed the connection)