12024-05-09T00:07:03 *** pablomartin <pablomartin!~pablomart@194.35.123.29> has quit IRC (Remote host closed the connection)
22024-05-09T00:20:00 *** brunoerg <brunoerg!~brunoerg@2804:14c:8782:84bd:958e:2164:feed:9194> has joined #bitcoin-core-dev
32024-05-09T00:32:14 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: leaving)
42024-05-09T01:05:00 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
52024-05-09T02:24:49 <bitcoin-git> [bitcoin] kevkevinpal opened pull request #30068: test: assert can't activate snapshot based chainstate more than once (master...assumeutxoActivateTwice) https://github.com/bitcoin/bitcoin/pull/30068
62024-05-09T02:51:48 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Quit: jarthur)
72024-05-09T03:12:16 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/43003255c00f...6f1d9064381d
82024-05-09T03:12:16 <bitcoin-git> bitcoin/master 189d0da Hennadii Stepanov: build, test: Remove unused `TIMEOUT` environment variable
92024-05-09T03:12:17 <bitcoin-git> bitcoin/master 6f1d906 merge-script: Merge bitcoin/bitcoin#30063: build, test: Remove unused `TIMEOUT` environm...
102024-05-09T03:12:23 <bitcoin-git> [bitcoin] fanquake merged pull request #30063: build, test: Remove unused `TIMEOUT` environment variable (master...240508-timeout) https://github.com/bitcoin/bitcoin/pull/30063
112024-05-09T03:55:41 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has joined #bitcoin-core-dev
122024-05-09T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
132024-05-09T04:01:31 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
142024-05-09T05:06:41 *** Lockesmith <Lockesmith!~user@gateway/tor-sasl/lockesmith> has quit IRC (Remote host closed the connection)
152024-05-09T05:07:20 *** Lockesmith <Lockesmith!~user@gateway/tor-sasl/lockesmith> has joined #bitcoin-core-dev
162024-05-09T05:18:35 *** brunoerg <brunoerg!~brunoerg@2804:14c:8782:84bd:958e:2164:feed:9194> has quit IRC (Ping timeout: 272 seconds)
172024-05-09T05:19:01 *** brunoerg <brunoerg!~brunoerg@191.177.193.233> has joined #bitcoin-core-dev
182024-05-09T05:21:18 *** brunoerg <brunoerg!~brunoerg@191.177.193.233> has quit IRC (Read error: Connection reset by peer)
192024-05-09T05:22:10 *** brunoerg <brunoerg!~brunoerg@191.177.193.233> has joined #bitcoin-core-dev
202024-05-09T05:56:30 *** msc <msc!~msc@user/msc> has joined #bitcoin-core-dev
212024-05-09T06:02:47 *** koolazer <koolazer!~koo@user/koolazer> has quit IRC (Remote host closed the connection)
222024-05-09T06:37:55 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
232024-05-09T07:46:43 <bitcoin-git> [bitcoin] threewebcode opened pull request #30071: chore: fix some typos (master...patch-2) https://github.com/bitcoin/bitcoin/pull/30071
242024-05-09T08:41:05 *** msc <msc!~msc@user/msc> has quit IRC (Remote host closed the connection)
252024-05-09T08:41:42 *** msc <msc!~msc@user/msc> has joined #bitcoin-core-dev
262024-05-09T09:09:09 *** vyHamii <vyHamii!~vyHamii@123.25.30.77> has quit IRC (Quit: Leaving)
272024-05-09T09:21:19 <bitcoin-git> [bitcoin] glozow closed pull request #30071: chore: fix some typos (master...patch-2) https://github.com/bitcoin/bitcoin/pull/30071
282024-05-09T09:38:04 *** BrandonOdiwuor <BrandonOdiwuor!~BrandonOd@105.163.0.162> has joined #bitcoin-core-dev
292024-05-09T09:44:39 *** aleggg <aleggg!~aleggg@189.114.80.232> has quit IRC (Ping timeout: 268 seconds)
302024-05-09T09:45:15 *** aleggg <aleggg!~aleggg@149.78.184.201> has joined #bitcoin-core-dev
312024-05-09T09:49:00 <bitcoin-git> [bitcoin] fanquake closed pull request #30068: test: assert can't activate snapshot based chainstate more than once (master...assumeutxoActivateTwice) https://github.com/bitcoin/bitcoin/pull/30068
322024-05-09T10:49:18 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has joined #bitcoin-core-dev
332024-05-09T11:21:09 *** aleggg <aleggg!~aleggg@149.78.184.201> has quit IRC (Ping timeout: 268 seconds)
342024-05-09T11:21:28 *** aleggg <aleggg!~aleggg@189.114.80.232> has joined #bitcoin-core-dev
352024-05-09T12:14:06 *** brunoerg <brunoerg!~brunoerg@191.177.193.233> has quit IRC (Remote host closed the connection)
362024-05-09T12:15:47 *** brunoerg <brunoerg!~brunoerg@2804:14c:8782:84bd:c58:56c5:958c:a142> has joined #bitcoin-core-dev
372024-05-09T12:20:06 *** brunoerg <brunoerg!~brunoerg@2804:14c:8782:84bd:c58:56c5:958c:a142> has quit IRC (Ping timeout: 256 seconds)
382024-05-09T12:31:24 <hebasto> are there any `fork()`specific issues for `lcov`? It seems that child code branches for `if(0 == fork())` are marked as not executed, which is untrue (for example, https://maflcko.github.io/b-c-cov/total.coverage/src/util/subprocess.h.gcov.html
392024-05-09T12:35:11 <sipa> hebasto: is there an exec in the fork?
402024-05-09T12:35:49 <sipa> if so, that's expected, because the child process gets replaced with the other binary, and never gets a chance to report its coverage
412024-05-09T12:36:15 <hebasto> there is a execvp()
422024-05-09T12:36:27 <hebasto> ah, I see
432024-05-09T12:36:47 *** vincenzopalazzo <vincenzopalazzo!~vincenzop@static.14.246.108.65.clients.your-server.de> has quit IRC (Quit: ZNC 1.8.2+deb2+b1 - https://znc.in)
442024-05-09T12:37:35 <hebasto> sipa: ty
452024-05-09T12:39:00 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
462024-05-09T12:49:08 *** brunoerg <brunoerg!~brunoerg@2001:1284:f502:90d0:bd3b:b65:328f:4ef2> has joined #bitcoin-core-dev
472024-05-09T13:02:44 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
482024-05-09T13:02:55 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev
492024-05-09T13:03:10 *** brunoerg <brunoerg!~brunoerg@2001:1284:f502:90d0:bd3b:b65:328f:4ef2> has quit IRC (Remote host closed the connection)
502024-05-09T13:04:53 *** brunoerg <brunoerg!~brunoerg@2001:1284:f502:90d0:bd3b:b65:328f:4ef2> has joined #bitcoin-core-dev
512024-05-09T13:10:05 *** brunoerg <brunoerg!~brunoerg@2001:1284:f502:90d0:bd3b:b65:328f:4ef2> has quit IRC (Ping timeout: 240 seconds)
522024-05-09T13:20:50 *** brunoerg <brunoerg!~brunoerg@2001:1284:f502:90d0:bd3b:b65:328f:4ef2> has joined #bitcoin-core-dev
532024-05-09T13:34:51 *** pablomartin <pablomartin!~pablomart@89.35.25.30> has joined #bitcoin-core-dev
542024-05-09T13:58:33 <bitcoin-git> [bitcoin] instagibbs opened pull request #30072: refactor prep for package rbf (master...2024-05-package_rbf_prep) https://github.com/bitcoin/bitcoin/pull/30072
552024-05-09T13:59:00 *** Emc99 <Emc99!~Emc99@212.129.87.22> has joined #bitcoin-core-dev
562024-05-09T14:00:13 <achow101> #startmeeting
572024-05-09T14:00:19 <TheCharlatan> hi
582024-05-09T14:00:20 <achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr-gi[m] theStack TheCharlatan vasild
592024-05-09T14:00:22 <josie> hiya
602024-05-09T14:00:23 <cfields> hi
612024-05-09T14:00:25 <hebasto> hi
622024-05-09T14:00:26 <brunoerg> hi
632024-05-09T14:00:27 <pinheadmz> yoyoyo
642024-05-09T14:00:28 <instagibbs> hi
652024-05-09T14:00:29 <furszy> hi
662024-05-09T14:00:30 <tdb3> hi
672024-05-09T14:00:31 <sipa> hi
682024-05-09T14:00:32 <willcl-ark> hi
692024-05-09T14:00:34 <sdaftuar> hi
702024-05-09T14:00:35 <_aj_> hi
712024-05-09T14:00:36 <achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add?
722024-05-09T14:00:38 <Sjors[m]> Hi
732024-05-09T14:00:44 <lightlike> Hi
742024-05-09T14:01:08 <sr_gi[m]> Hi
752024-05-09T14:01:10 <Murch[m]> hi
762024-05-09T14:01:13 <glozow> hi
772024-05-09T14:01:18 <achow101> #topic package relay updates (glozow)
782024-05-09T14:01:24 <abubakarsadiq> hi
792024-05-09T14:01:44 <glozow> I've been on holiday so will update #30000 in a bit. Currently reviewing #28984 which is the priority PR rn.
802024-05-09T14:01:46 <gribble> https://github.com/bitcoin/bitcoin/issues/28984 | Cluster size 2 package rbf by instagibbs · Pull Request #28984 · bitcoin/bitcoin · GitHub
812024-05-09T14:01:48 <gribble> https://github.com/bitcoin/bitcoin/issues/30000 | p2p: index TxOrphanage by wtxid, allow entries with same txid by glozow · Pull Request #30000 · bitcoin/bitcoin · GitHub
822024-05-09T14:02:25 <glozow> That's all, not much to report this week
832024-05-09T14:02:25 <dergoegge> hi
842024-05-09T14:02:28 <stickies-v> hi
852024-05-09T14:02:30 <achow101> #topic cluster mempool updates (sdaftuar)
862024-05-09T14:03:11 <sdaftuar> not much of an update from me this week either. i did push a rebase up to the draft PR, and i'm working on some slightly esoteric things right now. still planning to udpate the branch with better benchmarks and tests in the near future.
872024-05-09T14:03:36 <sipa> i'm getting close to having some PR'able low-level cluster linearization code.
882024-05-09T14:04:14 <sdaftuar> i think as glozow said, #28984 is probably the best thing to be reviewing/working on as a next PR
892024-05-09T14:04:16 <gribble> https://github.com/bitcoin/bitcoin/issues/28984 | Cluster size 2 package rbf by instagibbs · Pull Request #28984 · bitcoin/bitcoin · GitHub
902024-05-09T14:04:31 <josie> sipa: too bad close only counts in horseshoes and hand grenades *ducks*
912024-05-09T14:04:42 <sdaftuar> josie: be careful what you wish for!
922024-05-09T14:04:59 <kanzure> hi
932024-05-09T14:05:04 <instagibbs> please reach out if you have any questions or want a walktrhough on how tx processing works today(non-trivial!)
942024-05-09T14:05:58 <achow101> #topic legacy wallet removal updates (achow101)
952024-05-09T14:06:10 <glozow> *hurriedly generates epic handshake meme
962024-05-09T14:06:27 <abubakarsadiq> #30072 was opened recently, can review happen asynchronously for #28984 and #30072 or there is dependency?
972024-05-09T14:06:28 <gribble> https://github.com/bitcoin/bitcoin/issues/30072 | refactor prep for package rbf by instagibbs · Pull Request #30072 · bitcoin/bitcoin · GitHub
982024-05-09T14:06:29 <gribble> https://github.com/bitcoin/bitcoin/issues/28984 | Cluster size 2 package rbf by instagibbs · Pull Request #28984 · bitcoin/bitcoin · GitHub
992024-05-09T14:06:30 <gribble> https://github.com/bitcoin/bitcoin/issues/30072 | refactor prep for package rbf by instagibbs · Pull Request #30072 · bitcoin/bitcoin · GitHub
1002024-05-09T14:06:40 <achow101> #26606 is still the pr to review, and it looks like a few people are still looking at it
1012024-05-09T14:06:42 <gribble> https://github.com/bitcoin/bitcoin/issues/26606 | wallet: Implement independent BDB parser by achow101 · Pull Request #26606 · bitcoin/bitcoin · GitHub
1022024-05-09T14:06:57 <instagibbs> glozow suggested it, people can yell at me to close if they don't think it's necessary, whatever aids review
1032024-05-09T14:07:20 <josie> achow101: started with it, was curious if there were any bdb wallets from when you and murch were doing wallet simulations?
1042024-05-09T14:07:37 <josie> or more generally, if anyone here has old bdb wallets that can be used for testing that PR
1052024-05-09T14:07:42 <achow101> josie: I might've deleted them
1062024-05-09T14:07:42 <glozow> I think there would be a conflict. I just figured it might make the PR smaller
1072024-05-09T14:08:37 <achow101> josie: since it uses the test framework, they all get cleaned up at the end of the script
1082024-05-09T14:09:17 <achow101> but yes, if anyone has old bdb wallets, testing them on 26606 would be useful
1092024-05-09T14:09:40 <josie> yeah was more just curious to try it on a variety of wallets in the wild. i remembered the simulation wallets actually had some interesting txs and behavior, which is what made me think of them
1102024-05-09T14:09:41 <Murch[m]> josie: Sorry, also donât have any
1112024-05-09T14:10:15 *** brunoerg <brunoerg!~brunoerg@2001:1284:f502:90d0:bd3b:b65:328f:4ef2> has quit IRC (Remote host closed the connection)
1122024-05-09T14:10:16 <cfields> achow101: current test failure relevant? It's wallet-related.
1132024-05-09T14:10:35 <sipa> josie: i think expected issues would be more due to being created with old versions, having gone through many (but maybe not all) version upgrades, ...; not so much the content (in terms of addresses/transactions) of the wallet
1142024-05-09T14:10:52 <sipa> maybe very large wallets might trigger edge cases
1152024-05-09T14:10:57 <achow101> cfields: i probably have to rebase. that ci task is the one that tells us about silent merge conflicts
1162024-05-09T14:11:13 <fanquake> cfields: a number of wallet tests just fail semi-regularly, looks like one of those
1172024-05-09T14:12:05 <furszy> IIRC, there is a PR seeking to fix that
1182024-05-09T14:12:13 <furszy> 29982
1192024-05-09T14:12:16 <sipa> #29982
1202024-05-09T14:12:18 <gribble> https://github.com/bitcoin/bitcoin/issues/29982 | test: Fix intermittent issue in wallet_backwards_compatibility.py by Randy808 · Pull Request #29982 · bitcoin/bitcoin · GitHub
1212024-05-09T14:12:25 <josie> sipa: yeah, iirc we were simulating with very large wallets and some of them had been around forever, which is why i was hoping for old versions/upgrades etc. agree that the tx content itself isnt that important for the bdb parser
1222024-05-09T14:12:39 <sipa> josie: oh, i see
1232024-05-09T14:13:13 *** Emc99 <Emc99!~Emc99@212.129.87.22> has quit IRC (Quit: Client closed)
1242024-05-09T14:13:30 <cfields> roger, thanks.
1252024-05-09T14:13:55 <achow101> #topic Ad-hoc high priority for review
1262024-05-09T14:14:01 <achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
1272024-05-09T14:14:36 *** Emc99 <Emc99!~Emc99@212.129.87.22> has joined #bitcoin-core-dev
1282024-05-09T14:14:46 <achow101> or any other topics to discuss this week?
1292024-05-09T14:14:48 <fanquake> I'll add #29739. Would like to get that done soon, so we can finish with #21778
1302024-05-09T14:14:50 <gribble> https://github.com/bitcoin/bitcoin/issues/29739 | build: swap cctools otool for llvm-objdump by fanquake · Pull Request #29739 · bitcoin/bitcoin · GitHub
1312024-05-09T14:14:51 <gribble> https://github.com/bitcoin/bitcoin/issues/21778 | build: LLD based macOS toolchain by fanquake · Pull Request #21778 · bitcoin/bitcoin · GitHub
1322024-05-09T14:15:16 <achow101> fanquake: added
1332024-05-09T14:15:43 <fanquake> re other topics, the current round of backports for 27.x are reviewable/mergable. Would like to get that in shortly too
1342024-05-09T14:16:12 <achow101> #29888
1352024-05-09T14:16:13 <gribble> https://github.com/bitcoin/bitcoin/issues/29888 | [27.x] Backports by fanquake · Pull Request #29888 · bitcoin/bitcoin · GitHub
1362024-05-09T14:17:18 <achow101> #endmeeting
1372024-05-09T14:18:00 *** Emc99 <Emc99!~Emc99@212.129.87.22> has quit IRC (Client Quit)
1382024-05-09T14:24:28 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
1392024-05-09T14:28:15 <theStack> achow101: the bdb parser in the test framework assumes a pagesize of 4096 bytes. i wondered where does number comes from? did earlier versions of bitcoin core set a fixed pagesize? (is this even possible?)
1402024-05-09T14:28:51 <achow101> It's the bdb default
1412024-05-09T14:31:08 <theStack> ah, i see. IIRC it was 16K on my machine using the depends build when i last checked
1422024-05-09T14:46:01 *** brunoerg <brunoerg!~brunoerg@2804:14c:8782:84bd:b822:ffab:ab4e:3cbf> has joined #bitcoin-core-dev
1432024-05-09T14:46:19 <Sjors[m]> sipa: IIRC you mentioned a while ago that you have a WIP improvement to the Transport class and friends
1442024-05-09T14:47:05 <sipa> Sjors[m]: i do not recall
1452024-05-09T14:47:08 <Sjors[m]> For Stratum v2 I'd really like to kill its dependency on CNetMessage
1462024-05-09T14:47:26 <Sjors[m]> (and CSerializedNetMsg)
1472024-05-09T14:47:33 <sipa> oh, i had an idea for an improvement, but never implemented
1482024-05-09T14:51:07 *** brunoerg <brunoerg!~brunoerg@2804:14c:8782:84bd:b822:ffab:ab4e:3cbf> has quit IRC (Ping timeout: 272 seconds)
1492024-05-09T14:52:58 <achow101> theStack: the page size is stored in the wallet, so if it's different, we'll be able to handle it
1502024-05-09T14:55:50 <Sjors[m]> sipa: can you project these thoughts as a comment on #29432 or a new Github issue? I might take a stab at it if you don't have time.
1512024-05-09T14:55:52 <gribble> https://github.com/bitcoin/bitcoin/issues/29432 | Stratum v2 Template Provider (take 3) by Sjors · Pull Request #29432 · bitcoin/bitcoin · GitHub
1522024-05-09T15:01:38 <fjahr> #29973 and #28793 might be RFM, 3 ACKs each. Would be great if someone could take a look, thanks a lot!
1532024-05-09T15:01:39 <gribble> https://github.com/bitcoin/bitcoin/issues/29973 | test: Assumeutxo: ensure failure when importing a snapshot twice by alfonsoromanz · Pull Request #29973 · bitcoin/bitcoin · GitHub
1542024-05-09T15:01:41 <gribble> https://github.com/bitcoin/bitcoin/issues/28793 | contrib: Add asmap-tool by fjahr · Pull Request #28793 · bitcoin/bitcoin · GitHub
1552024-05-09T15:04:30 <_aj_> sipa: i didn't have anything to add to your comment in #27795 ; hadn't noticed the PR had updated after marco's comment either
1562024-05-09T15:04:31 <gribble> https://github.com/bitcoin/bitcoin/issues/27795 | Remove Ambiguity of Script ASM Hex and Decimal Integer Representations · Issue #27795 · bitcoin/bitcoin · GitHub
1572024-05-09T15:11:17 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1582024-05-09T15:11:50 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
1592024-05-09T15:17:22 *** brunoerg <brunoerg!~brunoerg@2804:14c:8782:84bd:b822:ffab:ab4e:3cbf> has joined #bitcoin-core-dev
1602024-05-09T15:19:11 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC ()
1612024-05-09T15:36:54 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
1622024-05-09T15:39:36 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1632024-05-09T15:41:42 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 268 seconds)
1642024-05-09T15:52:12 *** BrandonOdiwuor <BrandonOdiwuor!~BrandonOd@105.163.0.162> has quit IRC (Ping timeout: 250 seconds)
1652024-05-09T15:55:39 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6f1d9064381d...921c61e9a5c8
1662024-05-09T15:55:40 <bitcoin-git> bitcoin/master b259b0e Alfonso Roman Zubeldia: [Test] Assumeutxo: ensure failure when importing a snapshot twice
1672024-05-09T15:55:41 <bitcoin-git> bitcoin/master 921c61e Ava Chow: Merge bitcoin/bitcoin#29973: test: Assumeutxo: ensure failure when importi...
1682024-05-09T15:55:48 <bitcoin-git> [bitcoin] achow101 merged pull request #29973: test: Assumeutxo: ensure failure when importing a snapshot twice (master...assumeutxo-test-import-snapshot-twice) https://github.com/bitcoin/bitcoin/pull/29973
1692024-05-09T15:57:49 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/921c61e9a5c8...ceb1e078f8c0
1702024-05-09T15:57:49 <bitcoin-git> bitcoin/master 6abe772 Fabian Jahr: contrib: Add asmap-tool
1712024-05-09T15:57:50 <bitcoin-git> bitcoin/master ceb1e07 Ava Chow: Merge bitcoin/bitcoin#28793: contrib: Add asmap-tool
1722024-05-09T15:57:56 <bitcoin-git> [bitcoin] achow101 merged pull request #28793: contrib: Add asmap-tool (master...2023-11-asmap-tool-nextgen) https://github.com/bitcoin/bitcoin/pull/28793
1732024-05-09T16:19:35 <bitcoin-git> [bitcoin] fanquake opened pull request #30074: contrib: use ENV flags in get_arch (master...get_arch_env_flags) https://github.com/bitcoin/bitcoin/pull/30074
1742024-05-09T16:27:41 *** preimage <preimage!~halosghos@user/halosghost> has joined #bitcoin-core-dev
1752024-05-09T16:35:53 *** S3RK_ <S3RK_!~S3RK@user/s3rk> has joined #bitcoin-core-dev
1762024-05-09T16:38:54 *** S3RK <S3RK!~S3RK@user/s3rk> has quit IRC (Ping timeout: 252 seconds)
1772024-05-09T16:46:15 *** pablomartin <pablomartin!~pablomart@89.35.25.30> has quit IRC (Remote host closed the connection)
1782024-05-09T17:00:36 <bitcoin-git> [bitcoin] hebasto opened pull request #30075: test, subprocess: Improve coverage report correctness (master...240509-coverage) https://github.com/bitcoin/bitcoin/pull/30075
1792024-05-09T17:03:05 <cfields> josie: want me to fix up the KeyPair changes?
1802024-05-09T17:03:41 <cfields> also, should probably double-check with sipa that the cast is safe and future-proof..
1812024-05-09T17:04:05 <sipa> hi!
1822024-05-09T17:05:09 <josie> cfields: sure! if not, no worries, i was going to take a crack at it tomorrow morning
1832024-05-09T17:05:46 <josie> "double-check" -> "summon"
1842024-05-09T17:06:19 <cfields> summoning sipa for a sanity-check on https://github.com/theuni/bitcoin/commit/db1d199bf93eae046a62245db8f7782a94f25e9d line 416
1852024-05-09T17:07:41 <cfields> quick context: adds a wrapper for keypair using dumb bytes for storage, then blindly casts to the secp type.
1862024-05-09T17:12:33 <sipa> cfields: maybe add a static_assert that KeyPair::size() == sizeof(secp256k1_keypair) ?
1872024-05-09T17:13:03 <sipa> the cast seems fine to me
1882024-05-09T17:13:25 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
1892024-05-09T17:13:31 <cfields> ð
1902024-05-09T17:14:21 <cfields> thanks
1912024-05-09T17:14:28 <josie> sipa: cheers!
1922024-05-09T17:16:29 *** msc_ <msc_!~msc@user/msc> has joined #bitcoin-core-dev
1932024-05-09T17:17:53 *** msc <msc!~msc@user/msc> has quit IRC (Remote host closed the connection)
1942024-05-09T17:33:36 *** the_mariner1 <the_mariner1!~Thunderbi@191-247-26-197.3g.claro.net.br> has joined #bitcoin-core-dev
1952024-05-09T17:36:46 *** Guest75 <Guest75!~Guest75@183.81.46.133> has joined #bitcoin-core-dev
1962024-05-09T17:37:21 *** Guest75 <Guest75!~Guest75@183.81.46.133> has quit IRC (Client Quit)
1972024-05-09T17:37:31 *** the_mariner <the_mariner!~Thunderbi@177.37.233.11> has quit IRC (Ping timeout: 256 seconds)
1982024-05-09T17:38:33 *** the_mariner1 <the_mariner1!~Thunderbi@191-247-26-197.3g.claro.net.br> has quit IRC (Ping timeout: 268 seconds)
1992024-05-09T17:38:41 *** the_mariner <the_mariner!~Thunderbi@2804:389:7116:f73a:71a0:fa31:5858:e969> has joined #bitcoin-core-dev
2002024-05-09T17:42:27 *** the_mariner1 <the_mariner1!~Thunderbi@177.37.233.11> has joined #bitcoin-core-dev
2012024-05-09T17:45:10 *** the_mariner <the_mariner!~Thunderbi@2804:389:7116:f73a:71a0:fa31:5858:e969> has quit IRC (Ping timeout: 255 seconds)
2022024-05-09T17:45:11 *** the_mariner1 is now known as the_mariner
2032024-05-09T18:56:37 *** MatrixBot123 <MatrixBot123!~matrixbot@2001:bc8:1820:284::1> has quit IRC (Quit: Bridge terminating on SIGTERM)
2042024-05-09T18:59:19 *** MatrixBot123 <MatrixBot123!~matrixbot@2001:bc8:1820:284::1> has joined #bitcoin-core-dev
2052024-05-09T19:16:55 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
2062024-05-09T19:52:16 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
2072024-05-09T20:21:06 <bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ceb1e078f8c0...012e540acee4
2082024-05-09T20:21:07 <bitcoin-git> bitcoin/master a8d9a0e Sergi Delgado Segura: test: adds outbound eviction functional tests, updates comment in Consider...
2092024-05-09T20:21:08 <bitcoin-git> bitcoin/master d53d848 Sergi Delgado Segura: test: adds outbound eviction tests for non outbound-full-relay peers
2102024-05-09T20:21:08 <bitcoin-git> bitcoin/master 012e540 Ava Chow: Merge bitcoin/bitcoin#29122: test: adds outbound eviction functional tests...
2112024-05-09T20:21:14 <bitcoin-git> [bitcoin] achow101 merged pull request #29122: test: adds outbound eviction functional tests, updates comment in ConsiderEviction (master...2023-12-20-eviction-tests) https://github.com/bitcoin/bitcoin/pull/29122
2122024-05-09T20:48:08 *** brunoerg <brunoerg!~brunoerg@2804:14c:8782:84bd:b822:ffab:ab4e:3cbf> has quit IRC (Remote host closed the connection)
2132024-05-09T20:53:33 *** Guest96 <Guest96!~Guest96@bba-86-99-35-107.alshamil.net.ae> has joined #bitcoin-core-dev
2142024-05-09T20:54:42 <bitcoin-git> [bitcoin] achow101 pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/012e540acee4...24572cf76816
2152024-05-09T20:54:43 <bitcoin-git> bitcoin/master 4f34714 Sebastian Falbesoner: test: refactor: move fill_mempool to new module mempool_util
2162024-05-09T20:54:44 <bitcoin-git> bitcoin/master c8e6d08 Sebastian Falbesoner: test: refactor: eliminate COINBASE_MATURITY magic number in fill_mempool
2172024-05-09T20:54:44 <bitcoin-git> bitcoin/master b2037ad Sebastian Falbesoner: test: add MiniWallet tagging support to avoid UTXO mixing
2182024-05-09T20:54:49 <bitcoin-git> [bitcoin] achow101 merged pull request #29939: test: add MiniWallet tagging support to avoid UTXO mixing, use in `fill_mempool` (master...202404-test-support_MiniWallet_tags) https://github.com/bitcoin/bitcoin/pull/29939
2192024-05-09T20:56:14 *** msc_ <msc_!~msc@user/msc> has quit IRC (Ping timeout: 260 seconds)
2202024-05-09T21:16:54 *** msc <msc!~msc@user/msc> has joined #bitcoin-core-dev
2212024-05-09T21:20:01 *** preimage <preimage!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 4.2.2)
2222024-05-09T21:38:44 *** brunoerg <brunoerg!~brunoerg@200.192.114.19> has joined #bitcoin-core-dev
2232024-05-09T21:39:40 *** brunoerg_ <brunoerg_!~brunoerg@200.192.114.19> has joined #bitcoin-core-dev
2242024-05-09T21:40:28 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Quit: Leaving)
2252024-05-09T21:43:36 *** brunoerg <brunoerg!~brunoerg@200.192.114.19> has quit IRC (Ping timeout: 252 seconds)
2262024-05-09T21:43:50 *** msc <msc!~msc@user/msc> has quit IRC (Ping timeout: 260 seconds)
2272024-05-09T22:08:54 *** Guest96 <Guest96!~Guest96@bba-86-99-35-107.alshamil.net.ae> has quit IRC (Quit: Client closed)
2282024-05-09T22:09:20 *** brunoerg_ <brunoerg_!~brunoerg@200.192.114.19> has quit IRC (Remote host closed the connection)
2292024-05-09T22:12:42 *** brunoerg <brunoerg!~brunoerg@200.192.114.19> has joined #bitcoin-core-dev
2302024-05-09T22:13:43 *** brunoerg_ <brunoerg_!~brunoerg@200.192.114.19> has joined #bitcoin-core-dev
2312024-05-09T22:17:49 *** conman <conman!~con@180-150-21-3.b49615.mel.static.aussiebb.net> has quit IRC (Quit: Konversation terminated!)
2322024-05-09T22:17:54 *** brunoerg <brunoerg!~brunoerg@200.192.114.19> has quit IRC (Ping timeout: 268 seconds)
2332024-05-09T22:31:34 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/24572cf76816...98dd4e712efa
2342024-05-09T22:31:34 <bitcoin-git> bitcoin/master fd6a7d3 Matthew Zipkin: test: use sleepy wait-for-log in reindex readonly
2352024-05-09T22:31:35 <bitcoin-git> bitcoin/master 98dd4e7 Ava Chow: Merge bitcoin/bitcoin#30006: test: use sleepy wait-for-log in reindex read...
2362024-05-09T22:31:41 <bitcoin-git> [bitcoin] achow101 merged pull request #30006: test: use sleepy wait-for-log in reindex readonly (master...sleepy-wait) https://github.com/bitcoin/bitcoin/pull/30006
2372024-05-09T22:33:11 *** infernix <infernix!nix@spirit.infernix.net> has quit IRC (Ping timeout: 260 seconds)
2382024-05-09T22:46:22 *** dviola <dviola!~diego@user/dviola> has quit IRC (Quit: WeeChat 4.2.2)
2392024-05-09T22:52:47 <bitcoin-git> [bitcoin] theStack opened pull request #30076: test: fix MiniWallet script-path spend (missing parity bit in leaf version) (master...202405-MiniWallet-fix_script_path_spend_missing_sign_bit) https://github.com/bitcoin/bitcoin/pull/30076
2402024-05-09T22:57:27 *** brunoerg_ <brunoerg_!~brunoerg@200.192.114.19> has quit IRC (Remote host closed the connection)
2412024-05-09T22:59:26 *** brunoerg <brunoerg!~brunoerg@200.192.114.19> has joined #bitcoin-core-dev
2422024-05-09T23:00:30 *** brunoerg_ <brunoerg_!~brunoerg@200.192.114.19> has joined #bitcoin-core-dev
2432024-05-09T23:04:24 *** brunoerg <brunoerg!~brunoerg@200.192.114.19> has quit IRC (Ping timeout: 256 seconds)
2442024-05-09T23:06:57 *** infernix <infernix!nix@spirit.infernix.net> has joined #bitcoin-core-dev
2452024-05-09T23:23:17 *** the_mariner <the_mariner!~Thunderbi@177.37.233.11> has quit IRC (Ping timeout: 240 seconds)
2462024-05-09T23:38:25 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
2472024-05-09T23:39:10 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev