12024-06-26T00:42:29 *** Guest28 <Guest28!~Guest28@2620:15c:2c1:200:35e2:a5a5:4c6:f8ad> has joined #bitcoin-core-dev
22024-06-26T00:44:27 *** szkl <szkl!uid110435@id-110435.uxbridge.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
32024-06-26T00:55:00 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: leaving)
42024-06-26T01:02:35 <bitcoin-git> [bitcoin] kevkevinpal opened pull request #30340: test: Added coverage to Block not found error using gettxoutsetinfo (master...testBlockNotFoundUsingGetTxOutSetInfo) https://github.com/bitcoin/bitcoin/pull/30340
52024-06-26T01:21:49 *** Guest28 <Guest28!~Guest28@2620:15c:2c1:200:35e2:a5a5:4c6:f8ad> has quit IRC (Quit: Client closed)
62024-06-26T01:54:18 *** Randolf <Randolf!~randolf@184.70.10.188> has joined #bitcoin-core-dev
72024-06-26T02:31:58 *** Randolf <Randolf!~randolf@184.70.10.188> has quit IRC (Quit: Leaving)
82024-06-26T02:46:08 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Remote host closed the connection)
92024-06-26T02:58:10 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 246 seconds)
102024-06-26T02:58:16 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
112024-06-26T03:08:45 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC ()
122024-06-26T03:16:38 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
132024-06-26T03:23:33 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 268 seconds)
142024-06-26T03:24:06 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
152024-06-26T03:27:54 *** tibocin <tibocin!~tibocin@2600:387:16:11b::1> has joined #bitcoin-core-dev
162024-06-26T03:30:46 *** tibocin <tibocin!~tibocin@2600:387:16:11b::1> has quit IRC (Client Quit)
172024-06-26T03:37:30 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
182024-06-26T03:55:18 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Remote host closed the connection)
192024-06-26T03:58:08 *** kevkevin <kevkevin!~kevkevin@98.226.206.182> has joined #bitcoin-core-dev
202024-06-26T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
212024-06-26T04:01:34 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
222024-06-26T04:04:19 *** Guest61 <Guest61!~Guest61@2a00:79e1:abc:133:7058:a299:e451:82a9> has joined #bitcoin-core-dev
232024-06-26T04:08:08 *** Guest66 <Guest66!~Guest66@2607:fb90:3596:5852:cd0f:5f00:3e1e:a74c> has joined #bitcoin-core-dev
242024-06-26T04:09:45 *** Guest66 <Guest66!~Guest66@2607:fb90:3596:5852:cd0f:5f00:3e1e:a74c> has quit IRC (Client Quit)
252024-06-26T04:40:59 *** kevkevin <kevkevin!~kevkevin@98.226.206.182> has quit IRC (Remote host closed the connection)
262024-06-26T04:55:06 *** Guest61 <Guest61!~Guest61@2a00:79e1:abc:133:7058:a299:e451:82a9> has quit IRC (Quit: Client closed)
272024-06-26T05:00:26 *** mcey <mcey!~emcy@85.255.234.170> has quit IRC (Read error: Connection reset by peer)
282024-06-26T05:01:24 *** mcey <mcey!~emcy@85.255.234.170> has joined #bitcoin-core-dev
292024-06-26T05:11:28 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
302024-06-26T05:17:01 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 268 seconds)
312024-06-26T05:32:35 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
322024-06-26T05:44:18 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 256 seconds)
332024-06-26T05:45:49 *** Guest69 <Guest69!~Guest69@host-81-178-223-212.as13285.net> has joined #bitcoin-core-dev
342024-06-26T05:47:05 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Read error: Connection reset by peer)
352024-06-26T05:47:21 *** Guest69 <Guest69!~Guest69@host-81-178-223-212.as13285.net> has quit IRC (Client Quit)
362024-06-26T05:49:10 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
372024-06-26T05:59:56 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
382024-06-26T06:06:21 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 268 seconds)
392024-06-26T06:20:33 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
402024-06-26T06:25:47 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 268 seconds)
412024-06-26T06:39:47 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
422024-06-26T06:44:29 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 240 seconds)
432024-06-26T06:58:17 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
442024-06-26T07:03:42 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 268 seconds)
452024-06-26T07:18:00 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
462024-06-26T07:22:31 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 268 seconds)
472024-06-26T07:27:30 *** aleggg <aleggg!~aleggg@187.113.240.17> has quit IRC (Remote host closed the connection)
482024-06-26T07:40:03 *** puchka <puchka!~puchka@185.203.122.217> has quit IRC (Ping timeout: 252 seconds)
492024-06-26T07:53:56 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:c895:b80d:ef2e:3fd9> has joined #bitcoin-core-dev
502024-06-26T07:59:03 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:c895:b80d:ef2e:3fd9> has quit IRC (Ping timeout: 264 seconds)
512024-06-26T08:12:33 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
522024-06-26T08:17:24 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 268 seconds)
532024-06-26T08:26:16 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has joined #bitcoin-core-dev
542024-06-26T08:31:35 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
552024-06-26T08:36:49 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 268 seconds)
562024-06-26T08:37:57 *** puchka <puchka!~puchka@185.203.122.223> has joined #bitcoin-core-dev
572024-06-26T08:44:40 <laanwj> can anyone tell me what is going wrong in this CI run? https://github.com/bitcoin/bitcoin/actions/runs/9659726764/job/26666104563?pr=30043. to me it looks like it succesfully builds everything then suddenly goes "false" and fails, no clear error message
582024-06-26T08:48:42 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
592024-06-26T08:53:42 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 255 seconds)
602024-06-26T09:05:55 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
612024-06-26T09:06:19 <TheCharlatan> laanwj looks like it failed with a clang segmentation fault and then the verbose rebuild succeeded.
622024-06-26T09:08:10 <laanwj> oh! that's slightly worrying
632024-06-26T09:08:30 <laanwj> it's in netgroup.o, not even a file i touched
642024-06-26T09:10:51 <laanwj> will try to re-run it and see if it's reproducible
652024-06-26T09:11:21 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 268 seconds)
662024-06-26T09:19:42 <fanquake> yikes yea "clang: error: unable to execute command: Segmentation fault: 11"
672024-06-26T09:23:56 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:c895:b80d:ef2e:3fd9> has joined #bitcoin-core-dev
682024-06-26T09:24:31 <laanwj> thanks, it seems after a re-run it goes past that point, so it was probably a hardware issue
692024-06-26T09:29:02 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/323b0acfcb93...be4df59696a4
702024-06-26T09:29:03 <bitcoin-git> bitcoin/master 4289dd0 fanquake: contrib: add R(UN)PATH check to ELF symbol-check
712024-06-26T09:29:03 <bitcoin-git> bitcoin/master be4df59 merge-script: Merge bitcoin/bitcoin#30312: contrib: add R(UN)PATH check to ELF symbol-ch...
722024-06-26T09:29:10 <bitcoin-git> [bitcoin] fanquake merged pull request #30312: contrib: add R(UN)PATH check to ELF symbol-check (master...add_runpath_check) https://github.com/bitcoin/bitcoin/pull/30312
732024-06-26T09:29:19 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/be4df59696a4...2cd7c6bd939e
742024-06-26T09:29:19 <bitcoin-git> bitcoin/master 3ab2520 Ben Westgate: contrib: Fixup verify-binaries OS platform parsing
752024-06-26T09:29:20 <bitcoin-git> bitcoin/master 2cd7c6b merge-script: Merge bitcoin/bitcoin#30147: contrib: Fixup verify-binaries OS platform pa...
762024-06-26T09:29:28 <bitcoin-git> [bitcoin] fanquake merged pull request #30147: contrib: Fixup verify-binaries OS platform parsing (master...30145-parse-os-version-correctly) https://github.com/bitcoin/bitcoin/pull/30147
772024-06-26T09:29:39 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:c895:b80d:ef2e:3fd9> has quit IRC (Ping timeout: 264 seconds)
782024-06-26T09:40:35 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
792024-06-26T09:45:22 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
802024-06-26T09:52:03 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 268 seconds)
812024-06-26T10:05:28 *** kevkevin <kevkevin!~kevkevin@98.226.206.182> has joined #bitcoin-core-dev
822024-06-26T10:10:27 *** kevkevin <kevkevin!~kevkevin@98.226.206.182> has quit IRC (Ping timeout: 264 seconds)
832024-06-26T10:25:02 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
842024-06-26T10:30:17 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 268 seconds)
852024-06-26T10:40:20 <bitcoin-git> [bitcoincore.org] fanquake pushed 2 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/df7c05c66fc1...26adfd6d323b
862024-06-26T10:40:21 <bitcoin-git> bitcoincore.org/master fe698a1 Ava Chow: release: Update 27.1 magnet url
872024-06-26T10:40:22 <bitcoin-git> bitcoincore.org/master 26adfd6 merge-script: Merge bitcoin-core/bitcoincore.org#1032: release: Update 27.1 magnet url
882024-06-26T10:40:29 <bitcoin-git> [bitcoincore.org] fanquake merged pull request #1032: release: Update 27.1 magnet url (master...27.1-fixed-torrent) https://github.com/bitcoin-core/bitcoincore.org/pull/1032
892024-06-26T10:42:15 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
902024-06-26T10:42:17 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2cd7c6bd939e...b4b98543945e
912024-06-26T10:42:18 <bitcoin-git> bitcoin/master 1556d21 Roman Zeyde: rest: don't copy data when sending binary response
922024-06-26T10:42:19 <bitcoin-git> bitcoin/master b4b9854 merge-script: Merge bitcoin/bitcoin#30321: rest: don't copy data when sending binary res...
932024-06-26T10:42:26 <bitcoin-git> [bitcoin] fanquake merged pull request #30321: rest: don't copy data when sending binary response (master...http-string-view) https://github.com/bitcoin/bitcoin/pull/30321
942024-06-26T10:44:16 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b4b98543945e...3f0ee7655b5c
952024-06-26T10:44:17 <bitcoin-git> bitcoin/master 2721d64 Ava Chow: chainparams: Add achow101 DNS seeder
962024-06-26T10:44:18 <bitcoin-git> bitcoin/master 3f0ee76 merge-script: Merge bitcoin/bitcoin#30007: chainparams: Add achow101 DNS seeder
972024-06-26T10:44:24 <bitcoin-git> [bitcoin] fanquake merged pull request #30007: chainparams: Add achow101 DNS seeder (master...my-dns-seed) https://github.com/bitcoin/bitcoin/pull/30007
982024-06-26T10:47:33 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 268 seconds)
992024-06-26T11:01:19 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
1002024-06-26T11:01:57 <bitcoin-git> [bitcoin] willcl-ark opened pull request #30341: WIP: Permit Combiner to strip bip32_deriv information (master...psbt-strip-derivs-combine) https://github.com/bitcoin/bitcoin/pull/30341
1012024-06-26T11:06:00 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 255 seconds)
1022024-06-26T11:19:23 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
1032024-06-26T11:24:33 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 268 seconds)
1042024-06-26T11:29:12 <bitcoin-git> [bitcoin] maflcko closed pull request #30337: Docs improvements (master...docs-improvements) https://github.com/bitcoin/bitcoin/pull/30337
1052024-06-26T11:37:14 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
1062024-06-26T11:39:04 *** ThePlebRoad <ThePlebRoad!~analiser@user/ThePlebRoad> has joined #bitcoin-core-dev
1072024-06-26T11:43:07 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 272 seconds)
1082024-06-26T11:54:57 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:c895:b80d:ef2e:3fd9> has joined #bitcoin-core-dev
1092024-06-26T12:00:51 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:c895:b80d:ef2e:3fd9> has quit IRC (Ping timeout: 264 seconds)
1102024-06-26T12:17:52 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
1112024-06-26T12:48:12 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1122024-06-26T12:49:19 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 246 seconds)
1132024-06-26T12:51:52 *** BrandonOdiwuor <BrandonOdiwuor!~BrandonOd@105.163.158.53> has joined #bitcoin-core-dev
1142024-06-26T12:57:37 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Remote host closed the connection)
1152024-06-26T13:00:03 *** preimage <preimage!~halosghos@user/halosghost> has joined #bitcoin-core-dev
1162024-06-26T13:19:07 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1172024-06-26T13:20:09 <bitcoin-git> [bitcoincore.org] fanquake opened pull request #1033: pages: add Disclosures (master...add_disclosures_page) https://github.com/bitcoin-core/bitcoincore.org/pull/1033
1182024-06-26T13:24:08 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
1192024-06-26T13:34:04 *** ThePlebRoad <ThePlebRoad!~analiser@user/ThePlebRoad> has quit IRC (Ping timeout: 256 seconds)
1202024-06-26T13:35:34 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 260 seconds)
1212024-06-26T13:36:38 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
1222024-06-26T13:53:47 *** jespada <jespada!~jespada@cpc121308-nmal25-2-0-cust15.19-2.cable.virginm.net> has quit IRC (Ping timeout: 268 seconds)
1232024-06-26T13:55:34 *** jespada <jespada!~jespada@148.252.129.210> has joined #bitcoin-core-dev
1242024-06-26T14:04:23 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
1252024-06-26T14:05:54 *** jespada <jespada!~jespada@148.252.129.210> has quit IRC (Read error: Connection reset by peer)
1262024-06-26T14:08:11 *** jespada <jespada!~jespada@cpc121308-nmal25-2-0-cust15.19-2.cable.virginm.net> has joined #bitcoin-core-dev
1272024-06-26T14:22:00 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3f0ee7655b5c...0c57a798b50b
1282024-06-26T14:22:01 <bitcoin-git> bitcoin/master b5fc6d4 fanquake: guix: use glibc 2.31
1292024-06-26T14:22:01 <bitcoin-git> bitcoin/master 0c57a79 merge-script: Merge bitcoin/bitcoin#29987: guix: build with glibc 2.31
1302024-06-26T14:22:08 <bitcoin-git> [bitcoin] fanquake merged pull request #29987: guix: build with glibc 2.31 (master...build_with_glibc_2_31) https://github.com/bitcoin/bitcoin/pull/29987
1312024-06-26T14:25:59 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0c57a798b50b...d3d2bbf576d0
1322024-06-26T14:26:00 <bitcoin-git> bitcoin/master c0b5ea5 Hennadii Stepanov: build: Drop redundant `sys/sysctl.h` header check
1332024-06-26T14:26:01 <bitcoin-git> bitcoin/master d3d2bbf merge-script: Merge bitcoin/bitcoin#30327: build: Drop redundant `sys/sysctl.h` header c...
1342024-06-26T14:26:07 <bitcoin-git> [bitcoin] fanquake merged pull request #30327: build: Drop redundant `sys/sysctl.h` header check (master...240624-sysctl) https://github.com/bitcoin/bitcoin/pull/30327
1352024-06-26T14:36:17 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1362024-06-26T14:36:32 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1372024-06-26T14:49:56 *** jespada_ <jespada_!~jespada@cpc121308-nmal25-2-0-cust15.19-2.cable.virginm.net> has joined #bitcoin-core-dev
1382024-06-26T14:51:17 *** jespada <jespada!~jespada@cpc121308-nmal25-2-0-cust15.19-2.cable.virginm.net> has quit IRC (Ping timeout: 240 seconds)
1392024-06-26T14:53:01 *** preimage <preimage!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 4.3.2)
1402024-06-26T15:24:36 *** BrandonOdiwuor <BrandonOdiwuor!~BrandonOd@105.163.158.53> has quit IRC (Ping timeout: 250 seconds)
1412024-06-26T15:39:58 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
1422024-06-26T15:41:50 *** preimage <preimage!~halosghos@user/halosghost> has joined #bitcoin-core-dev
1432024-06-26T15:50:54 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1442024-06-26T15:51:23 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1452024-06-26T16:02:41 *** jespada <jespada!~jespada@cpc121308-nmal25-2-0-cust15.19-2.cable.virginm.net> has joined #bitcoin-core-dev
1462024-06-26T16:05:15 *** jespada_ <jespada_!~jespada@cpc121308-nmal25-2-0-cust15.19-2.cable.virginm.net> has quit IRC (Ping timeout: 255 seconds)
1472024-06-26T16:16:54 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d3d2bbf576d0...1d00601b9b55
1482024-06-26T16:16:55 <bitcoin-git> bitcoin/master 72b2268 furszy: wallet: notify when preset + automatic inputs exceed max weight
1492024-06-26T16:16:56 <bitcoin-git> bitcoin/master 1d00601 Ava Chow: Merge bitcoin/bitcoin#30309: wallet: notify when preset + automatic inputs...
1502024-06-26T16:17:03 <bitcoin-git> [bitcoin] achow101 merged pull request #30309: wallet: notify when preset + automatic inputs exceed max weight (master...2024_wallet_max_weight) https://github.com/bitcoin/bitcoin/pull/30309
1512024-06-26T16:36:51 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:37:b148:113f:e72b:71bd> has quit IRC (Read error: Connection reset by peer)
1522024-06-26T16:36:59 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:37:c8d:35e8:3619:2de4> has joined #bitcoin-core-dev
1532024-06-26T16:37:51 <bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1d00601b9b55...9ac4f69ec24b
1542024-06-26T16:37:52 <bitcoin-git> bitcoin/master 1408944 fanquake: Squashed 'src/secp256k1/' changes from 06bff6dec8..4af241b320
1552024-06-26T16:37:53 <bitcoin-git> bitcoin/master cc58e95 fanquake: Update secp256k1 subtree to latest master
1562024-06-26T16:37:53 <bitcoin-git> bitcoin/master 9ac4f69 Ava Chow: Merge bitcoin/bitcoin#30334: Update libsecp256k1 subtree to latest master
1572024-06-26T16:37:59 <bitcoin-git> [bitcoin] achow101 merged pull request #30334: Update libsecp256k1 subtree to latest master (master...update_secp256k1_subtree) https://github.com/bitcoin/bitcoin/pull/30334
1582024-06-26T16:43:46 *** _andrewtoth_ <_andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Remote host closed the connection)
1592024-06-26T16:43:54 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
1602024-06-26T17:03:29 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
1612024-06-26T17:25:19 *** cornfeedhobo <cornfeedhobo!~cornfeedh@user/cornfeedhobo> has quit IRC (Quit: ZNC - https://znc.in)
1622024-06-26T17:25:54 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Remote host closed the connection)
1632024-06-26T17:26:28 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
1642024-06-26T17:30:51 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 268 seconds)
1652024-06-26T17:38:44 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
1662024-06-26T17:41:35 *** cm <cm!~chaz@user/cm> has quit IRC (Ping timeout: 272 seconds)
1672024-06-26T17:42:24 *** cm <cm!~chaz@user/cm> has joined #bitcoin-core-dev
1682024-06-26T17:52:37 <bitcoin-git> [bitcoin] ryanofsky opened pull request #30342: kernel, logging: Pass Logger instances to kernel objects (master...pr/gklog) https://github.com/bitcoin/bitcoin/pull/30342
1692024-06-26T17:57:25 <bitcoin-git> [bitcoin] ryanofsky opened pull request #30343: wallet, logging: Replace WalletLogPrintf() with LogInfo() (master...pr/gwlog) https://github.com/bitcoin/bitcoin/pull/30343
1702024-06-26T18:17:13 <cfields> ryanofsky: heh, thanks!
1712024-06-26T18:23:22 <cfields> ryanofsky: I had been working on the same thing locally, but it was just hacking so I hadn't pushed it anywhere. Just pushed for comparison: https://github.com/theuni/bitcoin/commits/instance-log/
1722024-06-26T18:23:53 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: leaving)
1732024-06-26T18:24:19 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
1742024-06-26T18:24:36 <cfields> ryanofsky: I'll begin reviewing your draft and comparing it to mine while it's all fresh in my head, with the understanding that it still requires concept (n)acks from others.
1752024-06-26T18:24:54 <cfields> personally I'm find with your approach. Whatever gets the job done.
1762024-06-26T18:27:16 <cfields> ryanofsky: see also my questions to sipa above. At a quick glance, it looks like your branch isn't enough to completely get rid of the global logger, only from the major subsystems? Asking because I don't see changes to (for ex) random.cpp.
1772024-06-26T18:27:33 <cfields> *get rid of the global logger from the kernel
1782024-06-26T18:42:02 <cfields> TheCharlatan: is there any reason mempool_persist exists in the kernel?
1792024-06-26T18:42:38 <cfields> It can be safely removed. Will PR the removal unless you left it in there to support loading/dumping for some reason.
1802024-06-26T18:52:42 *** Guest50 <Guest50!~Guest50@ip-037-024-021-071.um08.pools.vodafone-ip.de> has joined #bitcoin-core-dev
1812024-06-26T19:04:04 <bitcoin-git> [bitcoin] theuni opened pull request #30344: kernel: remove mempool_persist (master...kernel-no-mempool-persist) https://github.com/bitcoin/bitcoin/pull/30344
1822024-06-26T19:04:17 <cfields> TheCharlatan: ^^
1832024-06-26T19:05:49 *** preimage <preimage!~halosghos@user/halosghost> has quit IRC (Ping timeout: 268 seconds)
1842024-06-26T19:07:31 *** preimage <preimage!~halosghos@user/halosghost> has joined #bitcoin-core-dev
1852024-06-26T19:10:49 *** Guest50 <Guest50!~Guest50@ip-037-024-021-071.um08.pools.vodafone-ip.de> has quit IRC (Quit: Client closed)
1862024-06-26T19:12:36 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Remote host closed the connection)
1872024-06-26T19:28:42 <bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/9ac4f69ec24b...b27afb7fb774
1882024-06-26T19:28:43 <bitcoin-git> bitcoin/master 3d3a83f brunoerg: i2p: log errors properly according to their severity
1892024-06-26T19:28:43 <bitcoin-git> bitcoin/master 7d3662f brunoerg: i2p: fix log when an interruption happens during `Accept`
1902024-06-26T19:28:44 <bitcoin-git> bitcoin/master b27afb7 Ava Chow: Merge bitcoin/bitcoin#29833: i2p: fix and improve logs
1912024-06-26T19:28:50 <bitcoin-git> [bitcoin] achow101 merged pull request #29833: i2p: fix and improve logs (master...2024-04-i2p-log) https://github.com/bitcoin/bitcoin/pull/29833
1922024-06-26T19:35:40 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
1932024-06-26T19:40:11 <ryanofsky> cfields, interesting that branch is using source_location. But think the biggest difference between approaches is #30342 is trying to be incremental and not do a global search and replace of all log statements.
1942024-06-26T19:40:11 <ryanofsky> I hadn't looked at random.cpp, but it seems like we could add a pointer to RNGState there.
1952024-06-26T19:40:11 <ryanofsky> In general I don't think we should get rid of log statements. Being able to conveniently log from any part of the codebase is too important for debugging.
1962024-06-26T19:40:12 <gribble> https://github.com/bitcoin/bitcoin/issues/30342 | kernel, logging: Pass Logger instances to kernel objects by ryanofsky · Pull Request #30342 · bitcoin/bitcoin · GitHub
1972024-06-26T19:41:53 <cfields> ryanofsky: yeah, that branch using source_location was before I realized the macros were necessary for avoiding evaluating the params, so I abandoned it. But the passing around of the log struct works the same with either approach.
1982024-06-26T19:42:32 <cfields> agree about not getting rid of log statements. Random is just kinda a special case because it's so low-level and is setup so early.
1992024-06-26T19:43:16 <ryanofsky> yeah the parts just passing the Logger are the same
2002024-06-26T19:45:49 <cfields> ryanofsky: not to restart the war, but I do agree with aj about not removing category grep-ability from the code
2012024-06-26T19:45:51 * cfields ducks
2022024-06-26T19:47:33 <ryanofsky> interesting, i'm surpised anyone has grepped for log categories since they are not used very much
2032024-06-26T19:52:56 <ryanofsky> also, the new LogInfo LogWarning LogError macros do not even accept categories, so things you can find searching for constants is pretty limited
2042024-06-26T19:56:40 <ryanofsky> anyway, you could look into it, and say what api you do prefer, if not this one, which is basically similar to python's, supporting categories but logging through objects
2052024-06-26T20:01:22 <cfields> will comment on the PR. I don't feel strongly enough to argue, just figured it was worth a comment here. The only thing I _do_ care about is being able to use an instance. I have a slight preference for explicitness of the instance in every call rather than hiding it sometimes (hence the huge scripted-diff in my PR), but again, whatever gets the job done is good enough for me.
2062024-06-26T20:03:25 <gmaxwell> category grepability is also useful in reverse, making it easy to see "which category to I need to set to get this log I see in the code"-- particularly because the people doing that are sometimes non-developer ops staff and so their comfort reading code is pretty limited.
2072024-06-26T20:06:42 <ryanofsky> that's a good point, but I don't think it is difficult to find categories in my PR. if you look at at code each source file has one category
2082024-06-26T20:07:57 <ryanofsky> for the unusual cases where a single source file logs to multiple categories there are objects like log_mempool and log_reindex, which are named after the category
2092024-06-26T20:08:05 <ryanofsky> or you can grep them and see the category
2102024-06-26T20:10:24 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Remote host closed the connection)
2112024-06-26T20:10:25 <ryanofsky> anyway do agree with you (cfields) that just having ability to specify instances and categories is the main thing, doesn't matter to me if they are optional or required or how they are written
2122024-06-26T20:10:58 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
2132024-06-26T20:26:35 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has joined #bitcoin-core-dev
2142024-06-26T21:00:43 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Remote host closed the connection)
2152024-06-26T21:03:32 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
2162024-06-26T21:05:21 *** preimage <preimage!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 4.3.2)
2172024-06-26T21:09:53 *** cornfeedhobo <cornfeedhobo!~cornfeedh@user/cornfeedhobo> has joined #bitcoin-core-dev
2182024-06-26T21:34:27 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
2192024-06-26T21:37:42 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC (Client Quit)
2202024-06-26T21:43:38 *** Torr <Torr!~Torr@user/torr> has joined #bitcoin-core-dev
2212024-06-26T21:47:12 *** mudsip <mudsip!~mudsip@user/mudsip> has joined #bitcoin-core-dev
2222024-06-26T21:47:48 *** mudsip <mudsip!~mudsip@user/mudsip> has quit IRC (Client Quit)
2232024-06-26T21:53:59 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Remote host closed the connection)
2242024-06-26T22:00:04 *** kevkevin <kevkevin!~kevkevin@98.226.206.182> has joined #bitcoin-core-dev
2252024-06-26T22:03:42 *** saffi48 <saffi48!~saffi@user/saffi48> has joined #bitcoin-core-dev
2262024-06-26T22:03:46 <bitcoin-git> [bitcoin] maflcko closed pull request #30084: lint/contrib/doc updates (master...2024-05-lief-update) https://github.com/bitcoin/bitcoin/pull/30084
2272024-06-26T22:03:53 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
2282024-06-26T22:05:03 *** kevkevin <kevkevin!~kevkevin@98.226.206.182> has quit IRC (Ping timeout: 264 seconds)
2292024-06-26T22:10:34 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
2302024-06-26T22:28:16 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Quit: Leaving)
2312024-06-26T22:37:22 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Remote host closed the connection)
2322024-06-26T23:00:27 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has joined #bitcoin-core-dev
2332024-06-26T23:05:39 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:1014:97ff:f1d5:823e> has quit IRC (Ping timeout: 264 seconds)
2342024-06-26T23:14:02 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:c895:b80d:ef2e:3fd9> has joined #bitcoin-core-dev
2352024-06-26T23:33:58 *** kevkevin <kevkevin!~kevkevin@2601:241:8703:7b30:c895:b80d:ef2e:3fd9> has quit IRC (Remote host closed the connection)
2362024-06-26T23:35:32 *** kevkevin <kevkevin!~kevkevin@98.226.206.182> has joined #bitcoin-core-dev
2372024-06-26T23:40:12 *** kevkevin <kevkevin!~kevkevin@98.226.206.182> has quit IRC (Ping timeout: 255 seconds)