12024-08-29T00:06:42 *** jlest <jlest!~jlest@2804:7f1:eb00:cf36:2af3:4066:f002:b65a> has joined #bitcoin-core-dev
22024-08-29T00:22:45 *** jlest <jlest!~jlest@user/jlest> has quit IRC (Ping timeout: 246 seconds)
32024-08-29T00:54:20 *** twistedline <twistedline!~bitcoin@c-73-172-209-62.hsd1.md.comcast.net> has quit IRC ()
42024-08-29T01:14:07 *** lbia <lbia!~lbia@user/lbia> has quit IRC (Quit: lbia)
52024-08-29T01:52:39 *** twistedline <twistedline!~bitcoin@185.193.125.44> has joined #bitcoin-core-dev
62024-08-29T02:32:25 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:37:dde1:46d2:9082:9f54> has quit IRC (Ping timeout: 260 seconds)
72024-08-29T02:33:34 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:37:18bc:7a7e:4a16:a7ea> has joined #bitcoin-core-dev
82024-08-29T02:38:39 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:37:18bc:7a7e:4a16:a7ea> has quit IRC (Ping timeout: 260 seconds)
92024-08-29T02:41:59 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:37:18bc:7a7e:4a16:a7ea> has joined #bitcoin-core-dev
102024-08-29T02:49:06 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Ping timeout: 260 seconds)
112024-08-29T02:58:20 *** flag <flag!~flag@81.56.89.175> has quit IRC (Ping timeout: 255 seconds)
122024-08-29T03:00:10 *** flag <flag!~flag@81.56.89.175> has joined #bitcoin-core-dev
132024-08-29T04:01:02 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
142024-08-29T04:01:33 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
152024-08-29T05:01:16 *** mcey_ <mcey_!~emcy@85.255.234.171> has quit IRC (Remote host closed the connection)
162024-08-29T05:01:46 *** mcey_ <mcey_!~emcy@85.255.234.171> has joined #bitcoin-core-dev
172024-08-29T05:05:02 <maflcko> Looks like a rebase on top of cmake *has* to be done before every push to a pull request, otherwise the GHA CI will be failing.
182024-08-29T05:06:09 <maflcko> The reason is that the "test each commit" task is using the cmake invocation, but it is running on the non-rebased commits, which may be lacking CMakeLists.txt
192024-08-29T05:07:23 <maflcko> but doing a rebase should be harmless and may otherwise be useful anyway
202024-08-29T05:25:46 <maflcko> I've removed the "Needs CMake port" label from pull requests that fail CI or otherwise need a rebase. The CI failure should be self-explanatory.
212024-08-29T05:27:59 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has joined #bitcoin-core-dev
222024-08-29T05:35:18 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: leaving)
232024-08-29T06:22:09 *** dermoth <dermoth!~dermoth@user/dermoth> has quit IRC (Read error: Connection reset by peer)
242024-08-29T06:26:01 *** dermoth <dermoth!~dermoth@user/dermoth> has joined #bitcoin-core-dev
252024-08-29T06:37:07 <bitcoin-git> [bitcoin] l0rinc closed pull request #29847: test: add a few more base32/64 calculation corner cases (master...paplorinc/base-32-64-padding-simplification) https://github.com/bitcoin/bitcoin/pull/29847
262024-08-29T06:58:45 <bitcoin-git> [bitcoin] l0rinc opened pull request #30746: Add base32 and base64 roundtrip random padding tests (master...l0rinc/roundtrip-tests-base32-base64) https://github.com/bitcoin/bitcoin/pull/30746
272024-08-29T07:16:40 <maflcko> Looks like "make --keep-going" now aborts early in cmake, whereas previously it really did try to compile everything
282024-08-29T07:18:59 <maflcko> This makes code search and static analysis using a compiler harder
292024-08-29T07:47:20 <TheCharlatan> maflcko I think the recommendation is to use cmake instead of make and passing any arguments you would normally give make after `--` to cmake.
302024-08-29T07:47:43 <fanquake> instagibbs: why did you need to disable asm? Sounds like something that should be fixed (not sure how CMake would have fixed your compiler)
312024-08-29T07:48:16 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
322024-08-29T07:48:54 <maflcko> TheCharlatan: I know. I was trying to say the the "-k" behavior changed. I used "cmake --build ./bld-cmake --parallel $( nproc ) -- --keep-going"
332024-08-29T07:50:18 <maflcko> For example, if libtest_util can not be compiled, cmake aborts early, whereas autotools compiled everything else as well.
342024-08-29T08:01:21 <TheCharlatan> ah, I see, looks like any dependents on the library won't be built. I was previously checking a broken bitcoind.cpp, which would still allow the tests to compile with `--keep-going`
352024-08-29T08:01:41 <bitcoin-git> [bitcoin] maflcko opened pull request #30748: test: Pin and document TEST_DIR_PATH_ELEMENT, SeedRand::FIXED_SEED (master...2408-test) https://github.com/bitcoin/bitcoin/pull/30748
362024-08-29T08:34:01 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4ee1940e849e...4ae3be772d06
372024-08-29T08:34:02 <bitcoin-git> bitcoin/master e78551b Hennadii Stepanov: doc: Fix typo in `build-unix.md`
382024-08-29T08:34:02 <bitcoin-git> bitcoin/master 4ae3be7 merge-script: Merge bitcoin/bitcoin#30744: doc: Fix typo in `build-unix.md`
392024-08-29T08:34:05 <bitcoin-git> [bitcoin] fanquake merged pull request #30744: doc: Fix typo in `build-unix.md` (master...240828-typo) https://github.com/bitcoin/bitcoin/pull/30744
402024-08-29T08:36:40 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4ae3be772d06...0e0de9484600
412024-08-29T08:36:41 <bitcoin-git> bitcoin/master f9a08f3 LÅrinc: doc: fix a few simple codespell warnings
422024-08-29T08:36:41 <bitcoin-git> bitcoin/master 837fbca LÅrinc: Update spelling.ignore-words
432024-08-29T08:36:41 <bitcoin-git> bitcoin/master 0e0de94 merge-script: Merge bitcoin/bitcoin#30700: doc: fix CI codespell warnings
442024-08-29T08:36:43 <bitcoin-git> [bitcoin] fanquake merged pull request #30700: doc: fix CI codespell warnings (master...l0rinc/lint-typos) https://github.com/bitcoin/bitcoin/pull/30700
452024-08-29T08:53:17 *** lbia <lbia!~lbia@user/lbia> has joined #bitcoin-core-dev
462024-08-29T08:59:28 *** dermoth <dermoth!~dermoth@user/dermoth> has quit IRC (Read error: Connection reset by peer)
472024-08-29T09:03:47 *** dermoth <dermoth!~dermoth@user/dermoth> has joined #bitcoin-core-dev
482024-08-29T09:07:52 *** dermoth <dermoth!~dermoth@user/dermoth> has quit IRC (Read error: Connection reset by peer)
492024-08-29T09:11:32 *** dermoth <dermoth!~dermoth@user/dermoth> has joined #bitcoin-core-dev
502024-08-29T09:23:08 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0e0de9484600...00ad716c2b6a
512024-08-29T09:23:09 <bitcoin-git> bitcoin/master fa80d39 MarcoFalke: ci: Re-add configs removed in cmake migration
522024-08-29T09:23:09 <bitcoin-git> bitcoin/master 00ad716 merge-script: Merge bitcoin/bitcoin#30740: ci: Re-add configs removed in cmake migration
532024-08-29T09:23:10 <bitcoin-git> [bitcoin] fanquake merged pull request #30740: ci: Re-add configs removed in cmake migration (master...2408-ci-cmake) https://github.com/bitcoin/bitcoin/pull/30740
542024-08-29T09:24:44 <bitcoin-git> [bitcoin] fanquake opened pull request #30749: Remove bsdmainutils from doc/ci (master...no_bsd_main_utils) https://github.com/bitcoin/bitcoin/pull/30749
552024-08-29T09:34:01 <bitcoin-git> [bitcoin] maflcko opened pull request #30750: scripted-diff: LogPrint - LogDebug (master...2408-log) https://github.com/bitcoin/bitcoin/pull/30750
562024-08-29T09:40:48 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has quit IRC (Remote host closed the connection)
572024-08-29T09:45:41 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has joined #bitcoin-core-dev
582024-08-29T09:45:41 *** ChanServ sets mode: +o gribble
592024-08-29T09:53:18 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/00ad716c2b6a...8f761ea742e6
602024-08-29T09:53:19 <bitcoin-git> bitcoin/master 7de0c99 fanquake: doc: update dev note examples for CMake
612024-08-29T09:53:19 <bitcoin-git> bitcoin/master 8f761ea merge-script: Merge bitcoin/bitcoin#30739: doc: update dev note examples for CMake
622024-08-29T09:53:20 <bitcoin-git> [bitcoin] fanquake merged pull request #30739: doc: update dev note examples for CMake (master...dev_notes_cmake) https://github.com/bitcoin/bitcoin/pull/30739
632024-08-29T09:54:49 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8f761ea742e6...d08bedd81f18
642024-08-29T09:54:50 <bitcoin-git> bitcoin/master fa053ab MarcoFalke: build: Add Centos Stream 9 EOL URL
652024-08-29T09:54:50 <bitcoin-git> bitcoin/master fac587e MarcoFalke: ci: Use C++23 once for testing
662024-08-29T09:54:50 <bitcoin-git> bitcoin/master d08bedd merge-script: Merge bitcoin/bitcoin#30735: ci: Use C++23 in one task
672024-08-29T09:54:53 <bitcoin-git> [bitcoin] fanquake merged pull request #30735: ci: Use C++23 in one task (master...2408-23) https://github.com/bitcoin/bitcoin/pull/30735
682024-08-29T10:31:52 *** deborah59 <deborah59!~deborah@2600:387:f:7431::6> has joined #bitcoin-core-dev
692024-08-29T10:33:01 *** deborah59 <deborah59!~deborah@2600:387:f:7431::6> has quit IRC (Client Quit)
702024-08-29T10:40:33 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d08bedd81f18...7a226eb4d97b
712024-08-29T10:40:34 <bitcoin-git> bitcoin/master c7fb80a Hennadii Stepanov: guix: Drop unused module from manifest
722024-08-29T10:40:34 <bitcoin-git> bitcoin/master 7a226eb merge-script: Merge bitcoin/bitcoin#30653: guix: Drop unused module from manifest
732024-08-29T10:40:36 <bitcoin-git> [bitcoin] fanquake merged pull request #30653: guix: Drop unused module from manifest (master...240814-guix-gnu) https://github.com/bitcoin/bitcoin/pull/30653
742024-08-29T10:52:46 <bitcoin-git> [bitcoin] hebasto opened pull request #30752: guix: Drop unused autotools packages (master...240829-guix-clean) https://github.com/bitcoin/bitcoin/pull/30752
752024-08-29T11:02:37 *** toys <toys!~toys@user/toys> has left #bitcoin-core-dev (WeeChat 4.4.1)
762024-08-29T11:30:21 <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/7a226eb4d97b...5c7d4b9dec79
772024-08-29T11:30:21 <bitcoin-git> bitcoin/master 36ff336 fanquake: ci: remove bsdmainutils
782024-08-29T11:30:22 <bitcoin-git> bitcoin/master a2b1d2c fanquake: doc: remove bsdmainutils
792024-08-29T11:30:22 <bitcoin-git> bitcoin/master 78358ce fanquake: ci: add libzmq3-dev to test-each-commit job
802024-08-29T11:30:23 <bitcoin-git> [bitcoin] fanquake merged pull request #30749: Remove bsdmainutils from doc/ci (master...no_bsd_main_utils) https://github.com/bitcoin/bitcoin/pull/30749
812024-08-29T11:37:16 *** jlest <jlest!~jlest@user/jlest> has joined #bitcoin-core-dev
822024-08-29T11:52:45 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
832024-08-29T11:53:25 *** jlest <jlest!~jlest@user/jlest> has quit IRC (Ping timeout: 248 seconds)
842024-08-29T12:12:48 <instagibbs> fanquake autotool's based builds seemed to require it (asked here a long time ago on how to avoid issues), cmake based doesn't need it ð¤·
852024-08-29T12:13:35 <instagibbs> one less problem, I am not complaining
862024-08-29T12:35:38 <fanquake> instagibbs: if that's true then there's a bug in the cmake build
872024-08-29T12:36:59 <fanquake> i.e you're no-longer actually getting asm, when you should be, thus no-longer need to disable it to work around the compilation issue
882024-08-29T12:38:08 <fanquake> if you care enough you could retry 28.x, without --disable-asm, and see if it still fails
892024-08-29T12:39:32 <fanquake> possible you were hitting #29801, which got fixed
902024-08-29T12:39:34 <gribble> https://github.com/bitcoin/bitcoin/issues/29801 | Compilation failure with `-O0` + `-fsanitize=address` due to inline asm · Issue #29801 · bitcoin/bitcoin · GitHub
912024-08-29T12:49:35 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 272 seconds)
922024-08-29T12:54:49 <fanquake> If anyone happened to "guix pull" yesterday, and your guix is now segfaulting, "guix pull --roll-back" and then a "guix pull" should fix your guix
932024-08-29T13:16:15 <bitcoin-git> [bitcoin] hebasto opened pull request #30753: build: Drop no longer needed workaround (master...240829-zmg-mingw) https://github.com/bitcoin/bitcoin/pull/30753
942024-08-29T13:16:29 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
952024-08-29T13:16:53 <instagibbs> fanquake ok looks like an old issue that must have been fixed since April
962024-08-29T13:17:54 <fanquake> huge
972024-08-29T13:18:29 <instagibbs> looks like my complaining paid off ð
982024-08-29T13:43:13 *** midnight <midnight!~midnight@user/midnight> has quit IRC (Quit: quit)
992024-08-29T13:43:35 *** midnight <midnight!~midnight@user/midnight> has joined #bitcoin-core-dev
1002024-08-29T14:00:01 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1012024-08-29T14:00:19 <Murch[m]> hi
1022024-08-29T14:00:26 <achow101> #startmeeting
1032024-08-29T14:00:32 <TheCharlatan> hi
1042024-08-29T14:00:35 <theStack> hi
1052024-08-29T14:00:41 <fjahr> hi
1062024-08-29T14:00:45 <achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild
1072024-08-29T14:00:50 <brunoerg> hi
1082024-08-29T14:00:50 <furszy> hi
1092024-08-29T14:01:00 <virtu> hi
1102024-08-29T14:01:07 <willcl-ark> hi
1112024-08-29T14:01:15 <lightlike> Hi
1122024-08-29T14:01:16 <achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add?
1132024-08-29T14:01:21 <hebasto> hi
1142024-08-29T14:01:39 <instagibbs> hi
1152024-08-29T14:02:14 <achow101> #topic 28.0 release priorities
1162024-08-29T14:02:22 <achow101> 28.0rc1 was posted yesterday. please test
1172024-08-29T14:02:30 <achow101> any prs that should be backported yet?
1182024-08-29T14:02:57 <fanquake> #30743
1192024-08-29T14:02:58 <gribble> https://github.com/bitcoin/bitcoin/issues/30743 | depends: build libevent with `-D_GNU_SOURCE` by fanquake · Pull Request #30743 · bitcoin/bitcoin · GitHub
1202024-08-29T14:03:10 <fanquake> building depends on alpine and similar is broken, so this'll need to go in
1212024-08-29T14:03:44 <theStack> #30714, if anyone out there uses TestShell
1222024-08-29T14:03:46 <gribble> https://github.com/bitcoin/bitcoin/issues/30714 | test: fix `TestShell` initialization (late follow-up for #30463) by theStack · Pull Request #30714 · bitcoin/bitcoin · GitHub
1232024-08-29T14:04:01 <fanquake> also need to fix #30751 in some way, otherwise builds with new clang and old boost are broken
1242024-08-29T14:04:01 <gribble> https://github.com/bitcoin/bitcoin/issues/30751 | build: Boost 1.74.0 incompatible with Clang 18 · Issue #30751 · bitcoin/bitcoin · GitHub
1252024-08-29T14:04:21 <achow101> theStack: added to the milestone
1262024-08-29T14:04:28 <fanquake> looks like clang 18 with boost < 1.81.0, which is annoying, because debian stable and similar ships with 1.76 etc
1272024-08-29T14:04:42 <furszy> probably #30684. To v28 and previous releases.
1282024-08-29T14:04:44 <gribble> https://github.com/bitcoin/bitcoin/issues/30684 | init: fix init fatal error on invalid negated option value by furszy · Pull Request #30684 · bitcoin/bitcoin · GitHub
1292024-08-29T14:05:22 <fanquake> not sure about that, given it's a real edgecase, and nobody has ever reported it
1302024-08-29T14:05:50 <achow101> fanquake: boost issues aren't really our problem? unless we're requiring clang 18?
1312024-08-29T14:06:06 <fanquake> achow101: they are if we claim to support 1.73+
1322024-08-29T14:06:38 <fanquake> and if the boost libs shipped on the distro don't work with the default compiler
1332024-08-29T14:06:49 <fanquake> unless we are telling everyone to use depends
1342024-08-29T14:07:24 <achow101> hmm ok
1352024-08-29T14:07:53 <Sjors[m]11> hi
1362024-08-29T14:08:14 <achow101> furszy: since that is
1372024-08-29T14:08:20 <fanquake> https://github.com/bitcoin-core/bitcoin-devwiki/wiki/28.0-Release-Notes-Draft - please contribute anything missing to the release note
1382024-08-29T14:08:25 <hebasto> debian stable default clang is 14
1392024-08-29T14:08:34 <achow101> since that issue has existed for a while, I think it's fine to skip for this release
1402024-08-29T14:08:55 <achow101> (based entirely on looking at the title)
1412024-08-29T14:09:03 *** Guest40 <Guest40!~Guest40@2401:4900:51f7:7237:568:1443:c04d:536e> has joined #bitcoin-core-dev
1422024-08-29T14:09:12 <furszy> sure, np there.
1432024-08-29T14:10:12 <achow101> #topic Ad-hoc high priority for review
1442024-08-29T14:10:18 <achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
1452024-08-29T14:10:40 <achow101> i guess everything needs rebase now because of cmake
1462024-08-29T14:10:48 <jonatack> hi
1472024-08-29T14:10:54 <fjahr> #28792 for me, rebased already
1482024-08-29T14:10:55 <gribble> https://github.com/bitcoin/bitcoin/issues/28792 | Embed default ASMap as binary dump header file by fjahr · Pull Request #28792 · bitcoin/bitcoin · GitHub
1492024-08-29T14:11:06 <fanquake> my suggestion during rebasing would be to drop any autotools changes, unless you just want to rebase again
1502024-08-29T14:11:23 <fanquake> or force everyone to review two sets of the same change
1512024-08-29T14:11:26 <fjahr> editing some stuff on the build system too so interested in feedback from competent reviewers ;)
1522024-08-29T14:12:03 <Sjors[m]11> What's the ETA for kill autotools?
1532024-08-29T14:12:16 <achow101> also, i guess if people don't rebase their stuff soon, those prs are gonna be closed
1542024-08-29T14:12:17 <Sjors[m]11> Or does it not matter if you merge something that doesn't work with it?
1552024-08-29T14:12:18 <cfields> hi
1562024-08-29T14:12:39 <fanquake> what do you mean not work with? Nothing like that will be merged
1572024-08-29T14:12:49 <fanquake> autotools is going to be entirely removed very soon
1582024-08-29T14:12:58 <fanquake> CI is only using cmake, guix is only using cmake etc
1592024-08-29T14:13:13 <fanquake> so anything doing stuff in autotools wont even be tested properly at this point
1602024-08-29T14:13:18 <fjahr> I kept the autotools stuff in so far, I felt like for me it would be easier to review both side by side but I am happy to remove it if that is the policy we want to follow generally
1612024-08-29T14:13:25 <Sjors[m]11> E.g. #30409 adds a header, so it touches Makefile.am.
1622024-08-29T14:13:27 <gribble> https://github.com/bitcoin/bitcoin/issues/30409 | Introduce waitTipChanged() mining interface, replace RPCNotifyBlockChange, drop CRPCSignals & g_best_block by Sjors · Pull Request #30409 · bitcoin/bitcoin · GitHub
1632024-08-29T14:13:42 <Sjors[m]11> I can drop that, but then if it's merged before autotools goes away, it won't compile.
1642024-08-29T14:13:49 <fjahr> (easier to review as a cmake noob)
1652024-08-29T14:14:04 <Sjors[m]11> My other PRs are probably not getting merged before that time anyway, so I made them cmake-only.
1662024-08-29T14:14:13 <fanquake> Sjors I don't understand. Just make the change in cmake, and drop the autotools parts
1672024-08-29T14:14:27 <fanquake> everything will compile fine, regardless of if autotools exists or not
1682024-08-29T14:14:43 <fanquake> and then you don't have to worry about when it's removed
1692024-08-29T14:14:48 <fanquake> and your changes will be tested in the CI
1702024-08-29T14:15:05 *** Guest40 <Guest40!~Guest40@2401:4900:51f7:7237:568:1443:c04d:536e> has quit IRC (Quit: Client closed)
1712024-08-29T14:15:11 <cfields> Any reason not to nuke autotools today? To moot this conversation entirely?
1722024-08-29T14:15:47 <fanquake> cfields: that would be my preference, so we don't waste time with all this, but cmake is still lacking working features, like coverage, so it's a little bit of a blocker
1732024-08-29T14:16:34 <cfields> We discussed exactly this issue for exactly this reason and came to the conclusion that (at the very least) configure.ac+Makefile.* should be removed asap.
1742024-08-29T14:16:46 <cfields> Seems we can live without coverage for a few days?
1752024-08-29T14:17:08 <maflcko> Can I plz haz 24 more hours?
1762024-08-29T14:17:12 <fanquake> I would have preferred to at least have a change ready for review / testing, but it's not clear who is working on it
1772024-08-29T14:17:28 <maflcko> fanquake: I think the change is there, but no current acks
1782024-08-29T14:17:48 <fanquake> is there a pr in bitcoin/bitcoin?
1792024-08-29T14:17:48 <maflcko> I'll try to review it later today or tomorrow
1802024-08-29T14:18:10 <cfields> maflcko: for coverage? or something else?
1812024-08-29T14:18:22 <maflcko> fanquake: it is #30664
1822024-08-29T14:18:24 <gribble> https://github.com/bitcoin/bitcoin/issues/30664 | build: Remove Autotools-based build system by hebasto · Pull Request #30664 · bitcoin/bitcoin · GitHub
1832024-08-29T14:18:35 <fanquake> How does that fix coverage?
1842024-08-29T14:19:30 <maflcko> fanquake: I don't want to block something, based on missing coverage reports
1852024-08-29T14:19:51 <fanquake> Ok. I'm very happy to merge that by EOD tomorrow, if no other blockers come up
1862024-08-29T14:19:56 <maflcko> cfields: Just so that I can run some legacy scripts without having to modify them to pull an old commit
1872024-08-29T14:19:58 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
1882024-08-29T14:21:14 <jonatack> end of day tomorrow sgtm
1892024-08-29T14:21:39 <cfields> ok
1902024-08-29T14:22:51 <achow101> any other topics to discuss?
1912024-08-29T14:24:33 <achow101> #endmeeting
1922024-08-29T14:36:01 *** preimage <preimage!~halosghos@user/halosghost> has joined #bitcoin-core-dev
1932024-08-29T14:38:17 *** marcofleon <marcofleon!~marcofleo@82.163.218.33> has joined #bitcoin-core-dev
1942024-08-29T14:46:39 <bitcoin-git> [bitcoin] glozow pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5c7d4b9dec79...7349d572c34e
1952024-08-29T14:46:40 <bitcoin-git> bitcoin/master 1f4cdb3 Martin Saposnic: Replace custom funding tx creation with MiniWallet.
1962024-08-29T14:46:40 <bitcoin-git> bitcoin/master a563f41 Martin Saposnic: Remove second node since only 1 is needed for the test
1972024-08-29T14:46:40 <bitcoin-git> bitcoin/master 7349d57 glozow: Merge bitcoin/bitcoin#30701: Use MiniWallet in functional test rpc_signraw...
1982024-08-29T14:46:42 <bitcoin-git> [bitcoin] glozow merged pull request #30701: Use MiniWallet in functional test rpc_signrawtransactionwithkey. (master...test-miniwallet-on-rpc-signrawtransactionwithkey) https://github.com/bitcoin/bitcoin/pull/30701
1992024-08-29T14:48:55 <bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7349d572c34e...1e4823870054
2002024-08-29T14:48:56 <bitcoin-git> bitcoin/master bd7ce05 Sebastian Falbesoner: test: fix `TestShell` initialization (late follow-up for #30463)
2012024-08-29T14:48:56 <bitcoin-git> bitcoin/master 1e48238 glozow: Merge bitcoin/bitcoin#30714: test: fix `TestShell` initialization (late fo...
2022024-08-29T14:48:58 <bitcoin-git> [bitcoin] glozow merged pull request #30714: test: fix `TestShell` initialization (late follow-up for #30463) (master...202408-test-fix_testshell_instantiation) https://github.com/bitcoin/bitcoin/pull/30714
2032024-08-29T14:51:48 <bitcoin-git> [bitcoin] fanquake opened pull request #30754: misc: Autotools - CMake changes (master...deps_now_cmake) https://github.com/bitcoin/bitcoin/pull/30754
2042024-08-29T14:55:06 *** BlueMatt <BlueMatt!~BlueMatt@ircb.bluematt.me> has quit IRC (Ping timeout: 276 seconds)
2052024-08-29T14:55:07 *** BlueMatt_ <BlueMatt_!~BlueMatt@ircb.bluematt.me> has joined #bitcoin-core-dev
2062024-08-29T14:55:45 *** preimage <preimage!~halosghos@user/halosghost> has quit IRC (Ping timeout: 276 seconds)
2072024-08-29T14:56:03 *** preimage <preimage!~halosghos@user/halosghost> has joined #bitcoin-core-dev
2082024-08-29T15:02:50 *** conman <conman!~con@180-150-21-3.b49615.mel.static.aussiebb.net> has joined #bitcoin-core-dev
2092024-08-29T15:07:14 <bitcoin-git> [bitcoin] fanquake closed pull request #30462: utils: replace boost::date_time usage with c++20 std::chrono (master...nuke-date-time) https://github.com/bitcoin/bitcoin/pull/30462
2102024-08-29T15:11:07 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
2112024-08-29T15:13:06 <bitcoin-git> [bitcoin] hebasto opened pull request #30755: ci: Add missed configuration options to "Win64 native" job (master...240829-ci-win) https://github.com/bitcoin/bitcoin/pull/30755
2122024-08-29T15:35:50 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
2132024-08-29T16:17:20 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
2142024-08-29T16:25:00 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
2152024-08-29T16:33:56 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
2162024-08-29T16:34:42 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1e4823870054...ffdc3d6060f6
2172024-08-29T16:34:43 <bitcoin-git> bitcoin/master b02f29e fanquake: doc: replace Autotools with CMake
2182024-08-29T16:34:43 <bitcoin-git> bitcoin/master a865494 fanquake: lint: remove autotools packages
2192024-08-29T16:34:43 <bitcoin-git> bitcoin/master ffdc3d6 merge-script: Merge bitcoin/bitcoin#30754: misc: Autotools -> CMake changes
2202024-08-29T16:34:44 <bitcoin-git> [bitcoin] fanquake merged pull request #30754: misc: Autotools - CMake changes (master...deps_now_cmake) https://github.com/bitcoin/bitcoin/pull/30754
2212024-08-29T16:38:26 <sdaftuar> is there anything special we need to do -- such as rerunning cmake -B -- if we add a new functional test?
2222024-08-29T16:38:51 <sdaftuar> i ran into an issue with a functional test not appearing in my build directory that I think I eventually fixed by doing that, but i'm not sure if i understand correctly
2232024-08-29T16:39:09 <sdaftuar> (this was while i was just rebasing #28676)
2242024-08-29T16:39:12 <gribble> https://github.com/bitcoin/bitcoin/issues/28676 | [WIP] Cluster mempool implementation by sdaftuar · Pull Request #28676 · bitcoin/bitcoin · GitHub
2252024-08-29T16:40:25 <instagibbs> worked normally for my PR that adds a functional test
2262024-08-29T16:42:54 <sdaftuar> i'll do some experiments maybe...
2272024-08-29T16:46:08 <sdaftuar> ok if i copy an existing test to a new file (and add it to test_runner.py for good measure), and then run cmake --build build, it does not appear in the build/ directory. but if i run cmake -B and then cmake --build, it shows up...
2282024-08-29T16:46:21 <sdaftuar> so maybe the right thing to do is always run cmake -B first when kicking off a build?
2292024-08-29T16:46:54 <instagibbs> oh maybe, I'm running a small script that does that
2302024-08-29T16:47:37 <hebasto> `cmake -B` creates symlinks for test files in source dir to a build tree
2312024-08-29T16:48:33 <hebasto> and tests run from the build directory
2322024-08-29T16:50:03 <sdaftuar> hebasto: i see, so that means that if a test is changed, we don't need to rerun cmake -B, but if a test is added then we should?
2332024-08-29T16:50:32 <hebasto> correct
2342024-08-29T16:50:52 <hebasto> I'd say that something like `rm -rf build && cmake -B build` is the safest way
2352024-08-29T16:51:15 <sdaftuar> sounds good, thanks!
2362024-08-29T16:51:22 <hebasto> yw
2372024-08-29T17:12:04 *** flag <flag!~flag@81.56.89.175> has quit IRC (Ping timeout: 252 seconds)
2382024-08-29T17:12:06 <sdaftuar> am i right in thinking that a commit like https://github.com/bitcoin/bitcoin/pull/28676/commits/ec1b0d53d9eeda8610e2cca2a1cff265891a54af is no longer going to work now that we are using cmake?
2392024-08-29T17:13:48 *** flag <flag!~flag@81.56.89.175> has joined #bitcoin-core-dev
2402024-08-29T17:46:04 <maflcko> yes, autotools isn't used for anything anymore in the CI or otherwise, so modifying it will serve no purpose
2412024-08-29T17:47:12 <maflcko> The recommendation is to move the autotools modifications to cmake in the pull request
2422024-08-29T17:47:29 <maflcko> Not sure where the boost build issue is coming from in your pull request :eyes:
2432024-08-29T17:48:48 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
2442024-08-29T18:07:58 *** marcofleon <marcofleon!~marcofleo@82.163.218.33> has quit IRC (Quit: Connection closed)
2452024-08-29T18:14:46 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
2462024-08-29T18:19:38 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2472024-08-29T18:24:11 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Quit: Leaving)
2482024-08-29T18:32:05 <bitcoin-git> [qa-assets] maflcko opened pull request #204: Delete nonreduced inputs (main...main) https://github.com/bitcoin-core/qa-assets/pull/204
2492024-08-29T18:32:45 *** Randolf <Randolf!~randolf@184.70.10.188> has joined #bitcoin-core-dev
2502024-08-29T18:57:49 <sdaftuar> maflcko: any idea what the equivalent thing to do would be in the cmake build system? (i also don't understand why the build change was needed but it seemed to work)
2512024-08-29T18:58:22 <hebasto> sdaftuar: what is the failure?
2522024-08-29T18:58:58 <sdaftuar> hebasto: see eg https://github.com/bitcoin/bitcoin/actions/runs/10618840214/job/29435022797
2532024-08-29T18:59:19 <sdaftuar> the commit i linked before seemed to fix the issue for autotools, but now that i'm rebasing i'm trying to figure out how to fix it with cmake
2542024-08-29T18:59:36 <hebasto> I'll comment in the PR shortly
2552024-08-29T18:59:43 <sdaftuar> however i don't really understand the issue or why the fix works, so if you have a better wya of doing things i'd appreciate it! thanks
2562024-08-29T19:02:39 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Quit: jarthur)
2572024-08-29T19:26:32 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Remote host closed the connection)
2582024-08-29T19:32:26 *** Randolf <Randolf!~randolf@184.70.10.188> has quit IRC (Quit: Leaving)
2592024-08-29T19:43:18 <achow101> what is the equivalent for `make check`?
2602024-08-29T19:43:41 <hebasto> `ctest --test-dir build`
2612024-08-29T19:43:59 <achow101> that will also build if not built?
2622024-08-29T19:44:16 <hebasto> no, it won't
2632024-08-29T19:44:50 <achow101> 'make check' was build and test, i'd like to do the same with minimal verbosity
2642024-08-29T19:45:09 <hebasto> sdaftuar: your change is correct (I just was waiting finishing my own builds)
2652024-08-29T19:45:49 <sdaftuar> ok great, i just decided to guess :) watching the ci now to see if it works (for whatever reason, i can't reproduce the build error i was seeing locally)
2662024-08-29T19:51:22 <achow101> how do i make compiler errors and warnings be colorized as they were previously?
2672024-08-29T19:54:55 <hebasto> achow101: you could try https://cmake.org/cmake/help/latest/manual/ctest.1.html#build-and-test-mode
2682024-08-29T19:59:55 <achow101> seems to be more verbose than chaining cmake --build and ctest
2692024-08-29T20:00:58 <achow101> and that's more verbose than 'make check'
2702024-08-29T20:01:58 <hebasto> achow101: on Ubuntu 24.04, with systems GCC and CMake, error messages are colorized
2712024-08-29T20:02:11 <hebasto> what is your system/compiler ?
2722024-08-29T20:02:45 <achow101> arch and gcc
2732024-08-29T20:03:19 <hebasto> and cmake version?
2742024-08-29T20:03:42 <achow101> 3.30.2
2752024-08-29T20:05:47 <hebasto> what if you set `CMAKE_COLOR_DIAGNOSTICS` environment variable to `TRUE`?
2762024-08-29T20:06:16 <achow101> no difference
2772024-08-29T20:11:53 <bitcoin-git> [bitcoin] luke-jr opened pull request #30756: run_command: Close non-std fds when execing slave processes (master...subproc_closefds) https://github.com/bitcoin/bitcoin/pull/30756
2782024-08-29T20:16:47 *** aleggg <aleggg!~aleggg@187.112.95.77> has quit IRC (Remote host closed the connection)
2792024-08-29T20:17:20 <instagibbs> that option may be pretty new, I don't think my cmake is new enough
2802024-08-29T20:28:47 *** Guest93 <Guest93!~Guest93@host-78-129-36-41.dynamic.voo.be> has joined #bitcoin-core-dev
2812024-08-29T20:30:43 *** Guest93 <Guest93!~Guest93@host-78-129-36-41.dynamic.voo.be> has quit IRC (Client Quit)
2822024-08-29T20:35:14 <achow101> it looks like building with clang is colorized
2832024-08-29T20:45:22 *** aleggg <aleggg!~aleggg@187.112.95.77> has joined #bitcoin-core-dev
2842024-08-29T20:51:39 *** Yuvraj <Yuvraj!~Yuvraj@117.250.64.129> has joined #bitcoin-core-dev
2852024-08-29T20:51:42 *** Yuvraj <Yuvraj!~Yuvraj@117.250.64.129> has quit IRC (Client Quit)
2862024-08-29T22:05:16 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Ping timeout: 260 seconds)
2872024-08-29T22:48:04 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
2882024-08-29T22:49:25 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Client Quit)
2892024-08-29T23:24:23 *** preimage <preimage!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 4.4.1)