12024-10-10T00:01:41 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5fb94550638d...9909a34d7946
22024-10-10T00:01:42 <bitcoin-git> bitcoin/master 36a6d4b Mackain: doc: update IBD requirements in doc/README.md
32024-10-10T00:01:42 <bitcoin-git> bitcoin/master 9909a34 Ava Chow: Merge bitcoin/bitcoin#30992: doc: update IBD requirements in doc/README.md
42024-10-10T00:01:43 <bitcoin-git> [bitcoin] achow101 merged pull request #30992: doc: update IBD requirements in doc/README.md (master...docs-wording-update) https://github.com/bitcoin/bitcoin/pull/30992
52024-10-10T00:20:20 <bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9909a34d7946...0c2c3bb3f5c6
62024-10-10T00:20:20 <bitcoin-git> bitcoin/master 63d6ad7 Sjors Provoost: Move BlockMerkleBranch back to merkle.{h,cpp}
72024-10-10T00:20:20 <bitcoin-git> bitcoin/master 47b4875 Sjors Provoost: Add getCoinbaseMerklePath() to Mining interface
82024-10-10T00:20:20 <bitcoin-git> bitcoin/master 525e9dc Sjors Provoost: Add submitSolution to BlockTemplate interface
92024-10-10T00:20:22 <bitcoin-git> [bitcoin] achow101 merged pull request #30955: Mining interface: getCoinbaseMerklePath() and submitSolution() (master...2024/07/merkle_path) https://github.com/bitcoin/bitcoin/pull/30955
102024-10-10T00:32:22 *** hashfunc <hashfunc!~user@2601:5c0:c280:7090:c055:1a2b:98ea:e133> has joined #bitcoin-core-dev
112024-10-10T00:46:25 *** Guest28 <Guest28!~Guest28@65.181.17.108> has joined #bitcoin-core-dev
122024-10-10T00:47:44 *** Guest78 <Guest78!~Guest28@65.181.17.108> has joined #bitcoin-core-dev
132024-10-10T00:47:57 *** Guest78 <Guest78!~Guest28@65.181.17.108> has quit IRC (Client Quit)
142024-10-10T00:53:56 *** Guest68 <Guest68!~Guest28@65.181.17.108> has joined #bitcoin-core-dev
152024-10-10T00:54:11 *** Guest68 <Guest68!~Guest28@65.181.17.108> has quit IRC (Client Quit)
162024-10-10T00:54:52 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Remote host closed the connection)
172024-10-10T00:55:25 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
182024-10-10T00:56:17 *** Guest28 <Guest28!~Guest28@65.181.17.108> has quit IRC (Ping timeout: 256 seconds)
192024-10-10T02:14:10 <bitcoin-git> [bitcoincore.org] azuchi opened pull request #1075: Add japanese translations for security advisories fixed in v25.0 (master...ja-translate-security-advisories-25.0) https://github.com/bitcoin-core/bitcoincore.org/pull/1075
202024-10-10T02:16:52 *** dermoth_ <dermoth_!~dermoth@user/dermoth> has joined #bitcoin-core-dev
212024-10-10T02:17:08 *** dermoth <dermoth!~dermoth@user/dermoth> has quit IRC (Remote host closed the connection)
222024-10-10T02:21:44 *** dermoth_ is now known as dermoth
232024-10-10T04:00:37 <vasild_> Chris_Stewart_5: jonatack: lightlike: sipa: Using port=11222 rpcport=22333 listenonion=0 bitcoind would still try to bind on 127.0.0.1:18445 (for regtest) and listen there for incoming onion connections.
242024-10-10T04:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
252024-10-10T04:01:11 <vasild_> thus the conflicting port 18445 when you start more than one bitcoind on the same machine
262024-10-10T04:01:14 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Read error: Connection reset by peer)
272024-10-10T04:01:33 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
282024-10-10T04:02:17 <vasild_> this was the case before 28.0 as well, but there the bind error from the second bitcoind did not cause startup failure and most likely remained unnoticed
292024-10-10T04:03:28 <vasild_> the functional tests all had that bind errors but they did not matter because no test is using or needs that 127.0.0.1:18445, now the functional testing framework was tweaked a bit to avoid trying to bind on conflicting ports.
302024-10-10T04:05:17 <vasild_> to avoid the bind on 127.0.0.1:18445 use bind=127.0.0.1:11222 instead of port=11222 (listenonion is irrelevant, can be 0 or 1)
312024-10-10T04:06:15 <vasild_> or bind=0.0.0.0:11222 if you want to listen on all interfaces, but I guess this is not the case with regtest
322024-10-10T04:11:25 <vasild_> What listenonion=1 does is to automatically create the hidden service with the tor daemon, so that users don't have to manually add HiddenServiceDir and HiddenServicePort in their torrc. But it does not control where bitcoind listens, I think a name like -autotorservice would be more appropriate than -listenonion.
332024-10-10T04:13:44 *** achow101 <achow101!~achow101@user/achow101> has quit IRC (Ping timeout: 260 seconds)
342024-10-10T04:13:58 *** achow101 <achow101!~achow101@user/achow101> has joined #bitcoin-core-dev
352024-10-10T04:17:34 <vasild_> A real problem with <28.0 that could happen is this: if two bitcoinds are started on the same machine with "port=10833 rpcport=10832 listenonion=1" and "port=20833 rpcport=20832 listenonion=1", then only the first would manage to bind on 127.0.0.1:8334. The second would "think" it did because the bind error was ignored. Due to listenonion=1 both will create a tor service, telling the tor daemon
362024-10-10T04:17:40 <vasild_> to redirect incoming connections to that service to 127.0.0.1:8334. For example first.onion:8333 -> 127.0.0.1:8334 and second.onion:8333 -> 127.0.0.1:8334.
372024-10-10T04:20:23 <vasild_> So all incoming tor connections for the second bitcoind would be redirected to the first bitcoind :/
382024-10-10T04:21:39 *** achow101_ <achow101_!~achow101@user/achow101> has joined #bitcoin-core-dev
392024-10-10T04:21:54 *** achow101 <achow101!~achow101@user/achow101> has quit IRC (Ping timeout: 276 seconds)
402024-10-10T04:22:19 *** vasild_ <vasild_!~vd@user/vasild> has quit IRC (Quit: leaving)
412024-10-10T04:22:32 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
422024-10-10T05:11:09 *** emcy__ <emcy__!~emcy@148.252.146.89> has joined #bitcoin-core-dev
432024-10-10T05:13:57 *** mcey_ <mcey_!~emcy@185.69.145.134> has quit IRC (Ping timeout: 248 seconds)
442024-10-10T05:23:00 *** PatBoy <PatBoy!xyz@cryption.cn> has quit IRC (Ping timeout: 276 seconds)
452024-10-10T05:23:18 *** PatBoy <PatBoy!xyz@cryption.cn> has joined #bitcoin-core-dev
462024-10-10T05:29:30 *** JTL <JTL!~jtl@user/jtl> has quit IRC (Ping timeout: 276 seconds)
472024-10-10T05:36:54 *** JTL <JTL!~jtl@user/jtl> has joined #bitcoin-core-dev
482024-10-10T05:36:54 *** JTL <JTL!~jtl@user/jtl> has quit IRC (Excess Flood)
492024-10-10T05:44:17 *** JTL <JTL!~jtl@user/jtl> has joined #bitcoin-core-dev
502024-10-10T05:49:46 <darosior> Chris_Stewart_5: i faced the same issue when upgrading Liana's functional test framework to 28.0. I fixed it by simply using `-bind` in place of `-port`: https://github.com/wizardsardine/liana/pull/1269/commits/ba553e9ddb104af454d9eff9969c0e37a1f3061a.
512024-10-10T05:49:46 <darosior> Others: i initially wanted to report it here but since it had a release note and a simple fix, i figured the breakage was known and intentional.
522024-10-10T06:00:22 *** hashfunc <hashfunc!~user@2601:5c0:c280:7090:c055:1a2b:98ea:e133> has quit IRC (Remote host closed the connection)
532024-10-10T06:21:33 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has joined #bitcoin-core-dev
542024-10-10T06:29:56 *** emcy__ <emcy__!~emcy@148.252.146.89> has quit IRC (Quit: Leaving)
552024-10-10T06:31:16 *** mcey <mcey!~emcy@148.252.146.89> has joined #bitcoin-core-dev
562024-10-10T06:47:29 *** javi404 <javi404!~quassel@2601:582:0:2c41:91ca:6895:2072:3474> has quit IRC (Ping timeout: 272 seconds)
572024-10-10T07:14:37 *** ion- <ion-!~ion-@user/ion-> has quit IRC (Remote host closed the connection)
582024-10-10T07:19:36 *** ion- <ion-!~ion-@user/ion-> has joined #bitcoin-core-dev
592024-10-10T07:55:06 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
602024-10-10T08:19:39 <bitcoin-git> [bitcoincore.org] fanquake pushed 2 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/b601352e42a7...7ca5a79820e3
612024-10-10T08:19:39 <bitcoin-git> bitcoincore.org/master 4ead85a azuchi: Add japanese translations for security advisories fixed in v25.0
622024-10-10T08:19:40 <bitcoin-git> bitcoincore.org/master 7ca5a79 merge-script: Merge bitcoin-core/bitcoincore.org#1075: Add japanese translations for sec...
632024-10-10T08:19:40 <bitcoin-git> [bitcoincore.org] fanquake merged pull request #1075: Add japanese translations for security advisories fixed in v25.0 (master...ja-translate-security-advisories-25.0) https://github.com/bitcoin-core/bitcoincore.org/pull/1075
642024-10-10T08:27:29 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Read error: Connection reset by peer)
652024-10-10T08:27:29 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
662024-10-10T08:27:41 *** vasild <vasild!~vd@user/vasild> has joined #bitcoin-core-dev
672024-10-10T08:27:51 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
682024-10-10T08:36:03 *** ion- <ion-!~ion-@user/ion-> has quit IRC (Remote host closed the connection)
692024-10-10T08:36:38 *** ion- <ion-!ion-@user/ion-> has joined #bitcoin-core-dev
702024-10-10T08:54:35 *** Artea <Artea!~Lufia@artea.pt> has joined #bitcoin-core-dev
712024-10-10T09:01:16 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
722024-10-10T09:03:49 *** ppisati <ppisati!~flag@81.56.89.175> has quit IRC (Ping timeout: 248 seconds)
732024-10-10T09:05:50 *** ppisati <ppisati!~flag@81.56.89.175> has joined #bitcoin-core-dev
742024-10-10T09:08:35 *** SpellChecker_ <SpellChecker_!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
752024-10-10T09:09:26 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Ping timeout: 260 seconds)
762024-10-10T10:02:57 <bitcoin-git> [bitcoin] fanquake closed pull request #31023: Add -pausebackgroundsync startup option (master...2024/10/pause-background-sync) https://github.com/bitcoin/bitcoin/pull/31023
772024-10-10T10:08:12 *** PaperSword1 <PaperSword1!~Thunderbi@securemail.qrsnap.io> has joined #bitcoin-core-dev
782024-10-10T10:08:17 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has quit IRC (Ping timeout: 248 seconds)
792024-10-10T10:08:18 *** PaperSword1 is now known as PaperSword
802024-10-10T10:47:44 *** mcey <mcey!~emcy@148.252.146.89> has quit IRC (Read error: Connection reset by peer)
812024-10-10T10:48:04 *** mcey <mcey!~emcy@148.252.146.89> has joined #bitcoin-core-dev
822024-10-10T10:56:41 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
832024-10-10T11:00:48 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Ping timeout: 246 seconds)
842024-10-10T11:19:25 *** mcey_ <mcey_!~emcy@85.255.233.39> has joined #bitcoin-core-dev
852024-10-10T11:22:27 *** mcey <mcey!~emcy@148.252.146.89> has quit IRC (Ping timeout: 252 seconds)
862024-10-10T11:32:39 *** ion-_ <ion-_!ion-@user/ion-> has joined #bitcoin-core-dev
872024-10-10T11:34:45 *** ion- <ion-!ion-@user/ion-> has quit IRC (Ping timeout: 248 seconds)
882024-10-10T11:53:08 *** ion-_ <ion-_!ion-@user/ion-> has quit IRC (Remote host closed the connection)
892024-10-10T12:02:40 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
902024-10-10T12:08:24 *** ion- <ion-!ion-@user/ion-> has joined #bitcoin-core-dev
912024-10-10T12:18:05 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
922024-10-10T12:23:48 *** ion- <ion-!ion-@user/ion-> has quit IRC (Remote host closed the connection)
932024-10-10T12:29:36 *** ion- <ion-!ion-@user/ion-> has joined #bitcoin-core-dev
942024-10-10T12:33:48 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0c2c3bb3f5c6...9f45062b9b06
952024-10-10T12:33:49 <bitcoin-git> bitcoin/master 1786be7 Sebastian Falbesoner: scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin...
962024-10-10T12:33:49 <bitcoin-git> bitcoin/master 882f736 Sebastian Falbesoner: doc: lint: correct outdated comment (s/Makefile.am/CMakeLists.txt/)
972024-10-10T12:33:49 <bitcoin-git> bitcoin/master 9f45062 merge-script: Merge bitcoin/bitcoin#30937: build: scripted-diff: drop config/ subdir for...
982024-10-10T12:33:51 <bitcoin-git> [bitcoin] fanquake merged pull request #30937: build: scripted-diff: drop config/ subdir for bitcoin-config.h (master...202409-build-drop_config_subdir) https://github.com/bitcoin/bitcoin/pull/30937
992024-10-10T12:46:51 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Remote host closed the connection)
1002024-10-10T12:50:24 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1012024-10-10T13:15:37 *** furszy <furszy!~furszy@user/furszy> has quit IRC (Quit: ZNC - https://znc.in)
1022024-10-10T13:17:55 *** furszy <furszy!~furszy@104.128.239.93> has joined #bitcoin-core-dev
1032024-10-10T13:22:19 <Chris_Stewart_5> vasild: Definitely agree this was the behavior pre-28 and likely was silently failing.
1042024-10-10T13:23:32 <Chris_Stewart_5> vasild: Kind of unexpected behavior imo that if -listenonion=0 we are still attempting to allocate resources for tor. I'm not an expert on the topic though so i'll defer i guess.
1052024-10-10T13:24:23 <Chris_Stewart_5> vasild: Is there any way to keep 18445 from being bound besides using the 'bind' configuration setting?
1062024-10-10T13:24:52 <Chris_Stewart_5> your point is taken though with the silent binding failure then redirecting tor traffic to the 1st bitcoind. Thats not good.
1072024-10-10T13:25:21 *** ion- <ion-!ion-@user/ion-> has quit IRC (Remote host closed the connection)
1082024-10-10T13:25:56 *** ion- <ion-!ion-@user/ion-> has joined #bitcoin-core-dev
1092024-10-10T13:28:59 *** ion-_ <ion-_!ion-@user/ion-> has joined #bitcoin-core-dev
1102024-10-10T13:30:26 *** ion- <ion-!ion-@user/ion-> has quit IRC (Ping timeout: 252 seconds)
1112024-10-10T13:33:22 *** ion-_ <ion-_!ion-@user/ion-> has quit IRC (Ping timeout: 252 seconds)
1122024-10-10T13:43:43 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
1132024-10-10T13:45:03 *** ion- <ion-!ion-@user/ion-> has joined #bitcoin-core-dev
1142024-10-10T14:00:16 <achow101_> #startmeeting
1152024-10-10T14:00:19 <TheCharlatan> hi
1162024-10-10T14:00:23 <achow101_> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild
1172024-10-10T14:00:29 <brunoerg> hi
1182024-10-10T14:00:30 <b10c> hi
1192024-10-10T14:00:37 <achow101_> There are no pre-proposed meeting topics this week. Any last minute ones to add?
1202024-10-10T14:00:39 <furszy> hi
1212024-10-10T14:00:41 <dergoegge> hi
1222024-10-10T14:00:43 <pinheadmz> gm
1232024-10-10T14:00:44 <stickies-v> hi
1242024-10-10T14:00:46 <Chris_Stewart_5> hi
1252024-10-10T14:00:54 <gleb> Hi
1262024-10-10T14:01:05 <instagibbs> hi
1272024-10-10T14:01:37 <achow101_> #topic Ad-hoc high priority for review
1282024-10-10T14:01:37 <achow101_> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
1292024-10-10T14:02:29 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has joined #bitcoin-core-dev
1302024-10-10T14:03:08 <abubakarsadiq> hi
1312024-10-10T14:03:27 <maxedw> hi
1322024-10-10T14:03:40 <achow101_> I guess nothing to talk about this week
1332024-10-10T14:03:44 <achow101_> no meeting next week
1342024-10-10T14:03:47 <achow101_> #endmeeting
1352024-10-10T14:03:57 <instagibbs> saving it up for next week
1362024-10-10T14:07:37 <emzy> hi
1372024-10-10T14:09:16 <jonatack> hi
1382024-10-10T14:14:23 <jonatack> vasild: thank for looking into it. ping me if you open an improvement (agree with you offline that -listenonion is confusingly named. maybe a better named alias?)
1392024-10-10T14:21:41 <sipa> hi
1402024-10-10T14:27:13 <bitcoin-git> [qa-assets] maflcko merged pull request #208: Add Murchâs inputs (main...2024-10-07-add-murchs-october-inputs) https://github.com/bitcoin-core/qa-assets/pull/208
1412024-10-10T14:27:15 <bitcoin-git> [qa-assets] maflcko pushed 2 commits to main: https://github.com/bitcoin-core/qa-assets/compare/84cea7068728...2e546edde267
1422024-10-10T14:27:16 <bitcoin-git> qa-assets/main 1ace70e Murch: Add Murchâs October input harvest
1432024-10-10T14:27:16 <bitcoin-git> qa-assets/main 2e546ed maflcko: Merge pull request #208 from murchandamus/2024-10-07-add-murchs-october-in...
1442024-10-10T14:33:23 *** vstoyanov <vstoyanov!~vstoyanov@151.251.253.63> has joined #bitcoin-core-dev
1452024-10-10T14:36:28 <bitcoin-git> [bitcoin] danielabrozzoni opened pull request #31065: rest: Support transaction broadcast in REST interface (master...20241008_rest_broadcast) https://github.com/bitcoin/bitcoin/pull/31065
1462024-10-10T14:37:09 *** aleggg <aleggg!~aleggg@186.213.138.13> has quit IRC (Remote host closed the connection)
1472024-10-10T14:41:23 <bitcoin-git> [bitcoin] glozow pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/9f45062b9b06...489e5aa3a299
1482024-10-10T14:41:24 <bitcoin-git> bitcoin/master 5901cf7 Pieter Wuille: clusterlin: abstract out DepGraph::GetReduced{Parents,Children}
1492024-10-10T14:41:25 <bitcoin-git> bitcoin/master eaab55f Pieter Wuille: clusterlin: rework DepGraphFormatter::Unser
1502024-10-10T14:41:25 <bitcoin-git> bitcoin/master abf5064 Pieter Wuille: clusterlin: simplify DepGraphFormatter::Ser
1512024-10-10T14:41:26 <bitcoin-git> [bitcoin] glozow merged pull request #30857: cluster mempool: extend DepGraph functionality (master...202409_clusterlin_partialdep) https://github.com/bitcoin/bitcoin/pull/30857
1522024-10-10T14:41:42 <instagibbs> sdaftuar1 I think the 3 ACKs really pushed it over the line, thanks ^
1532024-10-10T14:45:17 *** aleggg <aleggg!~aleggg@186.213.138.13> has joined #bitcoin-core-dev
1542024-10-10T14:45:33 <sipa> and double approval
1552024-10-10T14:46:39 *** ___nick___ <___nick___!~quassel@82-132-213-140.dab.02.net> has joined #bitcoin-core-dev
1562024-10-10T14:47:31 *** ___nick___ <___nick___!~quassel@82-132-213-140.dab.02.net> has quit IRC (Client Quit)
1572024-10-10T14:48:35 <instagibbs> yes, very powerful
1582024-10-10T14:49:47 *** ___nick___ <___nick___!~quassel@82-132-213-140.dab.02.net> has joined #bitcoin-core-dev
1592024-10-10T14:52:38 *** sdaftuar1 is now known as sdaftuar
1602024-10-10T14:52:53 <sdaftuar> ack ack ack
1612024-10-10T15:17:38 <vasild> < Chris_Stewart_5> vasild: Is there any way to keep 18445 from being bound besides using the 'bind' configuration setting? -- you mean to avoid the bind on 18445? Before 28.0 it was not possible. With 28.0 it is possible if you explicitly specify bind=
1622024-10-10T15:19:23 <vasild> < Chris_Stewart_5> vasild: Kind of unexpected behavior imo that if -listenonion=0 we are still attempting to allocate resources for tor. -- If the hidden service is configured in the torrc then you need listenonion=0 to avoid auto creating another one
1632024-10-10T15:19:34 <vasild> see "## 3. Manually create a Bitcoin Core onion service" in doc/tor.md
1642024-10-10T15:23:11 <Chris_Stewart_5> vasild: cool, thanks!
1652024-10-10T15:30:48 <lightlike> @vasild but why is it necessary for simple clearnet nodes that are not interested in Tor at all to stop startup if that port is not available? Wouldn't it be possible to detect if an onion service is running and only bind to the port if that is the case?
1662024-10-10T15:35:05 *** ion- <ion-!ion-@user/ion-> has quit IRC (Remote host closed the connection)
1672024-10-10T15:35:20 *** ion- <ion-!ion-@user/ion-> has joined #bitcoin-core-dev
1682024-10-10T15:38:28 *** Guest82 <Guest82!~Guest82@2a09:bac3:3941:1c46::2d1:60> has joined #bitcoin-core-dev
1692024-10-10T15:38:34 *** Guest82 <Guest82!~Guest82@2a09:bac3:3941:1c46::2d1:60> has quit IRC (Client Quit)
1702024-10-10T15:48:51 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:37:d180:8445:e492:6834> has quit IRC (Remote host closed the connection)
1712024-10-10T15:50:11 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:37:d172:5837:9f3d:18c7> has joined #bitcoin-core-dev
1722024-10-10T15:54:57 *** brunoerg <brunoerg!~brunoerg@2804:14c:3bfb:37:d172:5837:9f3d:18c7> has quit IRC (Ping timeout: 248 seconds)
1732024-10-10T16:16:29 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 265 seconds)
1742024-10-10T16:20:44 *** preimage <preimage!~halosghos@user/halosghost> has joined #bitcoin-core-dev
1752024-10-10T16:20:50 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1762024-10-10T16:29:04 <bitcoin-git> [bitcoin] maflcko opened pull request #31067: test: Print CompletedProcess object on error (master...2410-test-print-err) https://github.com/bitcoin/bitcoin/pull/31067
1772024-10-10T16:36:14 <vasild> lightlike: by default bitcoind binds on 0.0.0.0:8333 and 127.0.0.1:8334
1782024-10-10T16:36:44 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 264 seconds)
1792024-10-10T16:36:47 <vasild> maybe your question should be rather "why is it necessary for simple clearnet nodes that are not interested in Tor at all to bind by default on 127.0.0.1:8334"?
1802024-10-10T16:37:35 *** ion- <ion-!ion-@user/ion-> has quit IRC (Remote host closed the connection)
1812024-10-10T16:37:42 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1822024-10-10T16:38:50 <vasild> "Wouldn't it be possible to detect if an onion service is running..." - that would probably involve finding the torrc, parsing it and seeing if some hidden service is redirected to 127.0.0.1:8334; and then the tor daemon and its torrc may be on a different computer
1832024-10-10T16:42:55 *** ___nick___ <___nick___!~quassel@82-132-213-140.dab.02.net> has quit IRC (Ping timeout: 252 seconds)
1842024-10-10T16:43:49 *** yuvic <yuvic!~yuvic@2409:40e0:1043:e5b3:2d48:f327:9a96:104> has joined #bitcoin-core-dev
1852024-10-10T16:44:01 *** yuvic <yuvic!~yuvic@user/yuvic> has quit IRC (Remote host closed the connection)
1862024-10-10T16:51:26 *** ___nick___ <___nick___!~quassel@82-132-215-148.dab.02.net> has joined #bitcoin-core-dev
1872024-10-10T16:53:19 *** jespada <jespada!~jespada@cpc121308-nmal25-2-0-cust15.19-2.cable.virginm.net> has quit IRC (Quit: My Mac has gone to sleep. ZZZzzzâ¦)
1882024-10-10T16:53:25 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
1892024-10-10T16:53:42 *** ion- <ion-!ion-@user/ion-> has joined #bitcoin-core-dev
1902024-10-10T16:58:25 *** ion- <ion-!ion-@user/ion-> has quit IRC (Ping timeout: 248 seconds)
1912024-10-10T17:00:45 *** ion- <ion-!ion-@user/ion-> has joined #bitcoin-core-dev
1922024-10-10T17:02:59 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Remote host closed the connection)
1932024-10-10T17:11:17 <lightlike> Yes, that seems non-trivial. I'm just not convinced that the mere possibility of an onion service, that might be running or not, is reason enough to make long-established -port=x -port=y two-node setups impossible.
1942024-10-10T17:11:33 <lightlike> Another option could be to disable the stricter bind failure for a DefaultOnionServiceTarget() derived address that was not provided by the user explicitly, and just display a warning in this case.
1952024-10-10T17:46:33 *** kevkevin <kevkevin!~kevkevin@64.107.3.138> has joined #bitcoin-core-dev
1962024-10-10T17:47:44 *** kevkevin_ <kevkevin_!~kevkevin@64.107.3.138> has joined #bitcoin-core-dev
1972024-10-10T17:47:45 *** kevkevin <kevkevin!~kevkevin@64.107.3.138> has quit IRC (Read error: Connection reset by peer)
1982024-10-10T17:52:58 *** kevkevin_ <kevkevin_!~kevkevin@64.107.3.138> has quit IRC (Ping timeout: 252 seconds)
1992024-10-10T18:12:25 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
2002024-10-10T18:32:12 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has quit IRC (Quit: Connection closed for inactivity)
2012024-10-10T18:32:12 *** SpellChecker_ is now known as SpellChecker
2022024-10-10T18:52:53 *** ion-_ <ion-_!ion-@user/ion-> has joined #bitcoin-core-dev
2032024-10-10T18:56:02 *** ion- <ion-!ion-@user/ion-> has quit IRC (Ping timeout: 252 seconds)
2042024-10-10T18:59:32 *** vstoyanov <vstoyanov!~vstoyanov@151.251.253.63> has quit IRC (Ping timeout: 264 seconds)
2052024-10-10T19:01:09 *** darosior <darosior!~darosior@109.205.214.46> has quit IRC (Ping timeout: 248 seconds)
2062024-10-10T19:08:03 *** brunoerg <brunoerg!~brunoerg@187.183.60.117> has joined #bitcoin-core-dev
2072024-10-10T19:11:57 *** abubakarsadiq <abubakarsadiq!uid602234@id-602234.hampstead.irccloud.com> has joined #bitcoin-core-dev
2082024-10-10T19:26:15 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
2092024-10-10T19:29:00 <achow101_> how do i use a secp (or other subtree) header in a header file? autotools had no issue with this.. not sure what to do in cmake.
2102024-10-10T19:29:09 *** achow101_ is now known as achow101
2112024-10-10T19:31:18 <sipa> just #include <secp256k1.h> doesn't work?
2122024-10-10T19:31:41 <achow101> doesn't seem to
2132024-10-10T19:31:43 <sipa> it works in key.cpp, i'd be surprised it doesn't work in a .h file
2142024-10-10T19:32:19 <achow101> /home/ava/bitcoin/bitcoin/musig2/src/pubkey.h:12:10: fatal error: secp256k1_musig.h: No such file or directory
2152024-10-10T19:33:12 <sipa> you will need to confer with the Build People
2162024-10-10T19:33:38 <achow101> fanquake: hebasto: ^
2172024-10-10T19:34:37 <achow101> (and this branch has an updated secp256k1 subtree with the musig header)
2182024-10-10T19:42:11 <TheCharlatan> wfm when I include <secp256k1.h> in pubkey.h
2192024-10-10T19:43:29 <achow101> try any other secp header
2202024-10-10T19:43:51 <achow101> `#include <secp256k1/include/secp256k1_musig.h>` works, but that seems wrong
2212024-10-10T19:49:56 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Read error: Connection reset by peer)
2222024-10-10T19:50:05 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
2232024-10-10T19:56:39 <theStack> this sounds like a similar problem at least: https://www.reddit.com/r/cpp_questions/comments/14ube17/cmake_cant_include_external_header_in_h_file/ (but not sure how to apply the proposed solution exactly, we have a lot of target_link_library instances...)
2242024-10-10T20:04:14 *** ___nick___ <___nick___!~quassel@82-132-215-148.dab.02.net> has quit IRC (Ping timeout: 252 seconds)
2252024-10-10T20:13:16 *** ion-_ <ion-_!ion-@user/ion-> has quit IRC (Remote host closed the connection)
2262024-10-10T20:29:44 *** ion- <ion-!ion-@user/ion-> has joined #bitcoin-core-dev
2272024-10-10T20:34:56 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Read error: Connection reset by peer)
2282024-10-10T20:36:04 *** ion- <ion-!ion-@user/ion-> has quit IRC (Ping timeout: 252 seconds)
2292024-10-10T20:39:49 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2302024-10-10T20:49:08 *** ion- <ion-!ion-@user/ion-> has joined #bitcoin-core-dev
2312024-10-10T20:53:44 *** ion- <ion-!ion-@user/ion-> has quit IRC (Ping timeout: 252 seconds)
2322024-10-10T21:06:59 *** ion- <ion-!ion-@user/ion-> has joined #bitcoin-core-dev
2332024-10-10T21:16:33 *** ion- <ion-!ion-@user/ion-> has quit IRC (Ping timeout: 276 seconds)
2342024-10-10T21:27:30 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Quit: Leaving)
2352024-10-10T21:28:03 *** ion- <ion-!ion-@user/ion-> has joined #bitcoin-core-dev
2362024-10-10T21:55:03 <hebasto> achow101: mind sharing a branch?
2372024-10-10T21:55:12 <achow101> hebasto: still working on it
2382024-10-10T21:55:37 <achow101> it'll be the musig2 pr #29675
2392024-10-10T21:55:39 <gribble`> https://github.com/bitcoin/bitcoin/issues/29675 | wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys by achow101 · Pull Request #29675 · bitcoin/bitcoin · GitHub
2402024-10-10T21:58:25 <hebasto> usage requirements of a library, say libsecp256k1, are propagated to a consumers via `target_link_library` command. So try to link `secp256k1` to the failed target
2412024-10-10T21:59:56 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Remote host closed the connection)
2422024-10-10T22:00:02 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Remote host closed the connection)
2432024-10-10T22:00:20 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
2442024-10-10T22:00:50 <achow101> it should already be linked? pubkey.cpp already includes secp256k1 headers without issue
2452024-10-10T22:01:13 <achow101> you can replicate by adding `#include <secp256k1_ecdh.h>` to pubkey.h
2462024-10-10T22:01:33 <achow101> for some reason, adding `#include <secp256k1.h>` to pubkey.h works fine though
2472024-10-10T22:09:56 *** preimage <preimage!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 4.4.2)
2482024-10-10T22:23:49 <hebasto> achow101: consider this https://github.com/hebasto/bitcoin/commit/a4f5c2033f5ef8f8a291f471e8decfce5e9b9218
2492024-10-10T22:26:22 <hebasto> re "for some reason, adding `#include <secp256k1.h>` to pubkey.h works fine though" -- sure about that?
2502024-10-10T22:28:45 <achow101> it compiles at least
2512024-10-10T22:28:57 <hebasto> not for me
2522024-10-10T22:29:03 <achow101> and my workaround of `#include <secp256k1/include/secp256k1_musig.h>` seems to too
2532024-10-10T22:29:38 <hebasto> ^ this hack will always work :)
2542024-10-10T22:30:35 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
2552024-10-10T22:30:39 <achow101> idk, just tried again and `#include <secp256k1.h>` seems fine
2562024-10-10T22:32:43 <hebasto> for me -- https://anonpaste.io/share/6c95d0707d
2572024-10-10T22:33:28 *** ion- <ion-!ion-@user/ion-> has quit IRC (Ping timeout: 252 seconds)
2582024-10-10T22:33:54 <achow101> it seems a bit wrong to me to have to add secp256k1 to every target when adding it to the header. shouldn't all of those targets already link with secp?
2592024-10-10T22:35:46 <hebasto> why to link if no symbols are referred directly?
2602024-10-10T22:36:15 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Ping timeout: 246 seconds)
2612024-10-10T22:39:28 <achow101> they don't?
2622024-10-10T22:42:07 <hebasto> for example, for the `bitcoind` target, non of its sources, `bitcoind.cpp` and `init/bitcoind.cpp` refers to symbols from libsecp256k1
2632024-10-10T22:42:31 <hebasto> ... directly
2642024-10-10T22:43:43 <achow101> hmm ok
2652024-10-10T22:44:25 <achow101> perhaps pubkey.h is not the right place to put this stuff since it seems that it would add secp to a bunch of libraries that otherwise don't directly use secp
2662024-10-10T22:45:42 *** ion- <ion-!ion-@user/ion-> has joined #bitcoin-core-dev
2672024-10-10T22:50:13 *** ion- <ion-!ion-@user/ion-> has quit IRC (Remote host closed the connection)
2682024-10-10T22:50:28 *** ion- <ion-!ion-@user/ion-> has joined #bitcoin-core-dev
2692024-10-10T23:08:19 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
2702024-10-10T23:13:48 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Ping timeout: 252 seconds)
2712024-10-10T23:36:18 *** gribble` <gribble`!~gribble@bitcoin/bot/gribble> has quit IRC (Remote host closed the connection)
2722024-10-10T23:38:11 *** gribble <gribble!~gribble@bitcoin/bot/gribble> has joined #bitcoin-core-dev
2732024-10-10T23:38:11 *** ChanServ sets mode: +o gribble
2742024-10-10T23:57:16 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Ping timeout: 260 seconds)