12024-11-14T00:00:16 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
22024-11-14T00:04:34 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2131:2631:b6c5:e524> has quit IRC (Ping timeout: 265 seconds)
32024-11-14T00:05:21 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Ping timeout: 272 seconds)
42024-11-14T00:11:00 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
52024-11-14T00:14:42 <bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/36f5effa1783...422825929437
62024-11-14T00:14:43 <bitcoin-git> bitcoin/master ad9c2cc furszy: test, bench: specialize working directory name
72024-11-14T00:14:44 <bitcoin-git> bitcoin/master fa66e08 furszy: bench: add support for custom data directory
82024-11-14T00:14:44 <bitcoin-git> bitcoin/master 4228259 Ava Chow: Merge bitcoin/bitcoin#31000: bench: add support for custom data directory
92024-11-14T00:14:46 <bitcoin-git> [bitcoin] achow101 merged pull request #31000: bench: add support for custom data directory (master...2024_bench_custom_datadir) https://github.com/bitcoin/bitcoin/pull/31000
102024-11-14T00:24:55 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has quit IRC (Remote host closed the connection)
112024-11-14T00:25:59 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has joined #bitcoin-core-dev
122024-11-14T00:30:01 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has quit IRC (Ping timeout: 244 seconds)
132024-11-14T00:30:21 *** PaperSword <PaperSword!~Thunderbi@ec2-3-129-110-246.us-east-2.compute.amazonaws.com> has joined #bitcoin-core-dev
142024-11-14T01:34:37 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
152024-11-14T01:42:41 *** __DuBPiRaTe__ <__DuBPiRaTe__!~E_bomb@2600:6c50:7f7f:d89a:530c:7c67:8a82:d244> has joined #bitcoin-core-dev
162024-11-14T02:24:58 *** __DuBPiRaTe__ <__DuBPiRaTe__!~E_bomb@2600:6c50:7f7f:d89a:530c:7c67:8a82:d244> has quit IRC (Quit: Leaving)
172024-11-14T02:27:44 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: leaving)
182024-11-14T02:48:38 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has joined #bitcoin-core-dev
192024-11-14T02:49:31 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has quit IRC (Client Quit)
202024-11-14T02:49:44 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 260 seconds)
212024-11-14T02:54:13 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
222024-11-14T03:10:52 *** adil <adil!~Thunderbi@2402:d000:8134:2758:b840:f9aa:1c8a:fd6d> has joined #bitcoin-core-dev
232024-11-14T03:33:12 *** pablomartin <pablomartin!~pablomart@155.133.17.19> has joined #bitcoin-core-dev
242024-11-14T03:46:04 *** pablomartin <pablomartin!~pablomart@155.133.17.19> has quit IRC (Quit: Leaving)
252024-11-14T04:09:25 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
262024-11-14T04:25:40 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 252 seconds)
272024-11-14T04:49:50 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
282024-11-14T04:54:34 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 265 seconds)
292024-11-14T04:55:27 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
302024-11-14T05:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
312024-11-14T05:01:32 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
322024-11-14T05:08:33 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
332024-11-14T06:01:16 *** mcey_ <mcey_!~emcy@85.255.234.203> has quit IRC (Remote host closed the connection)
342024-11-14T06:01:39 *** mcey_ <mcey_!~emcy@85.255.234.203> has joined #bitcoin-core-dev
352024-11-14T06:12:55 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 260 seconds)
362024-11-14T06:21:35 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 252 seconds)
372024-11-14T06:21:55 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
382024-11-14T06:23:14 *** PaperSword1 <PaperSword1!~Thunderbi@ec2-3-129-110-246.us-east-2.compute.amazonaws.com> has joined #bitcoin-core-dev
392024-11-14T06:24:49 *** PaperSword <PaperSword!~Thunderbi@ec2-3-129-110-246.us-east-2.compute.amazonaws.com> has quit IRC (Ping timeout: 248 seconds)
402024-11-14T06:27:28 *** PaperSword1 <PaperSword1!~Thunderbi@ec2-3-129-110-246.us-east-2.compute.amazonaws.com> has quit IRC (Ping timeout: 252 seconds)
412024-11-14T06:29:25 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 252 seconds)
422024-11-14T06:43:56 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
432024-11-14T07:15:22 *** adil <adil!~Thunderbi@2402:d000:8134:2758:b840:f9aa:1c8a:fd6d> has quit IRC (Quit: adil)
442024-11-14T07:47:31 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 252 seconds)
452024-11-14T08:01:57 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
462024-11-14T08:11:37 <vasild> ryanofsky: wrt #31011, it says "Move util/pcp.cpp and util/netif.cpp to common/ because they depend on netaddress.cpp", does it mean anything that depends on netaddress.cpp has to be in common/ ?
472024-11-14T08:11:39 <gribble> https://github.com/bitcoin/bitcoin/issues/31011 | refactor: move util/pcp and util/netif to common/ by ryanofsky · Pull Request #31011 · bitcoin/bitcoin · GitHub
482024-11-14T08:13:49 <vasild> and how to determine if something depends on netaddress.cpp? I guess "#include <netaddress.h>" is not quite the same since it may only need netaddress.h for e.g. 'enum Network'
492024-11-14T08:21:44 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 264 seconds)
502024-11-14T08:22:13 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
512024-11-14T08:41:00 *** eval-exec <eval-exec!~Thunderbi@96.45.190.137.16clouds.com> has quit IRC (Quit: eval-exec)
522024-11-14T08:41:18 *** eval-exec <eval-exec!~Thunderbi@96.45.189.92.16clouds.com> has joined #bitcoin-core-dev
532024-11-14T08:45:31 *** spynxic <spynxic!~spynxic@spynxic.powered.by.lunarbnc.net> has quit IRC (Quit: Free ZNC ~ Powered by LunarBNC: https://LunarBNC.net)
542024-11-14T08:45:52 *** spynxic <spynxic!~spynxic@spynxic.powered.by.lunarbnc.net> has joined #bitcoin-core-dev
552024-11-14T09:03:41 *** l0rinc <l0rinc!~l0rinc@95C84685.dsl.pool.telekom.hu> has joined #bitcoin-core-dev
562024-11-14T09:19:03 *** gmaxwell <gmaxwell!~gmaxwell@user/gmaxwell> has quit IRC (Ping timeout: 252 seconds)
572024-11-14T09:34:56 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 264 seconds)
582024-11-14T09:35:40 *** gmaxwell <gmaxwell!~gmaxwell@user/gmaxwell> has joined #bitcoin-core-dev
592024-11-14T09:44:10 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/422825929437...69c031344404
602024-11-14T09:44:11 <bitcoin-git> bitcoin/master e80e4c6 TheCharlatan: validation: Remove RECENT_CONSENSUS_CHANGE validation result
612024-11-14T09:44:11 <bitcoin-git> bitcoin/master 69c0313 merge-script: Merge bitcoin/bitcoin#31269: validation: Remove RECENT_CONSENSUS_CHANGE va...
622024-11-14T09:44:12 <bitcoin-git> [bitcoin] fanquake merged pull request #31269: validation: Remove RECENT_CONSENSUS_CHANGE validation result (master...rmRecentConsensusChange) https://github.com/bitcoin/bitcoin/pull/31269
632024-11-14T09:47:53 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
642024-11-14T10:07:39 *** eval-exec <eval-exec!~Thunderbi@96.45.189.92.16clouds.com> has quit IRC (Ping timeout: 272 seconds)
652024-11-14T10:14:03 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has joined #bitcoin-core-dev
662024-11-14T10:18:50 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/69c031344404...f44e39c9d0da
672024-11-14T10:18:51 <bitcoin-git> bitcoin/master 184f34f Ryan Ofsky: util: Support dynamic width & precision in ConstevalFormatString
682024-11-14T10:18:51 <bitcoin-git> bitcoin/master fe39acf Ryan Ofsky: tinyformat: Add compile-time checking for literal format strings
692024-11-14T10:18:51 <bitcoin-git> bitcoin/master f44e39c merge-script: Merge bitcoin/bitcoin#31174: tinyformat: Add compile-time checking for lit...
702024-11-14T10:18:52 <bitcoin-git> [bitcoin] fanquake merged pull request #31174: tinyformat: Add compile-time checking for literal format strings (master...pr/tcheck) https://github.com/bitcoin/bitcoin/pull/31174
712024-11-14T10:26:04 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f44e39c9d0da...e546b4e1a0c5
722024-11-14T10:26:04 <bitcoin-git> bitcoin/master ac286e0 secp512k2: doc: Fix grammatical errors in multisig-tutorial.md
732024-11-14T10:26:05 <bitcoin-git> bitcoin/master e546b4e merge-script: Merge bitcoin/bitcoin#31225: doc: Fix grammatical errors in multisig-tutor...
742024-11-14T10:26:06 <bitcoin-git> [bitcoin] fanquake merged pull request #31225: doc: Fix grammatical errors in multisig-tutorial.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/31225
752024-11-14T11:03:14 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 260 seconds)
762024-11-14T11:08:27 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
772024-11-14T11:09:36 <laanwj> vasild: i think any use of netaddress.h is considered "use of netaddress.cpp" in this context, we don't distinguish header versus implementation usage because it further complicates dependency tracking
782024-11-14T11:10:11 <vasild> ok, easy ;)
792024-11-14T11:29:19 *** Guest82 <Guest82!~Guest82@176.59.102.56> has joined #bitcoin-core-dev
802024-11-14T11:35:17 *** Guest82 <Guest82!~Guest82@176.59.102.56> has quit IRC (Quit: Client closed)
812024-11-14T11:35:49 *** Dmitri <Dmitri!~Dmitri@176.59.102.56> has joined #bitcoin-core-dev
822024-11-14T11:36:32 *** Dmitri <Dmitri!~Dmitri@176.59.102.56> has quit IRC (Client Quit)
832024-11-14T11:37:54 *** Dmitri <Dmitri!~Dmitri@176.59.102.56> has joined #bitcoin-core-dev
842024-11-14T11:39:24 *** Dmitri <Dmitri!~Dmitri@176.59.102.56> has quit IRC (Client Quit)
852024-11-14T11:47:14 <bitcoin-git> [bitcoin] maflcko opened pull request #31287: refactor: Avoid std::string format strings (master...2411-check-fmt) https://github.com/bitcoin/bitcoin/pull/31287
862024-11-14T12:08:04 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
872024-11-14T12:18:03 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 276 seconds)
882024-11-14T12:23:42 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
892024-11-14T12:30:21 *** l0rinc <l0rinc!~l0rinc@95C84685.dsl.pool.telekom.hu> has quit IRC (Quit: Client closed)
902024-11-14T12:31:45 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 248 seconds)
912024-11-14T12:34:02 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
922024-11-14T12:44:56 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
932024-11-14T13:28:07 *** eval-exec <eval-exec!~Thunderbi@96.45.190.137.16clouds.com> has joined #bitcoin-core-dev
942024-11-14T13:33:50 *** pablomartin <pablomartin!~pablomart@155.133.17.140> has joined #bitcoin-core-dev
952024-11-14T13:36:16 <bitcoin-git> [bitcoin] Sjors closed pull request #31003: Add waitFeesChanged() to Mining interface (master...2024/07/mining-fees-changed) https://github.com/bitcoin/bitcoin/pull/31003
962024-11-14T13:52:33 <bitcoin-git> [bitcoin] Sjors opened pull request #31288: Add destroy to BlockTemplate schema (master...2024/11/destroy) https://github.com/bitcoin/bitcoin/pull/31288
972024-11-14T13:52:53 <bitcoin-git> [bitcoin] hodlinator closed pull request #30737: test: Fix RANDOM_CTX_SEED use with parallel tests (master...2024-08/RANDOM_CTX_SEED_jobs_fix_alt) https://github.com/bitcoin/bitcoin/pull/30737
982024-11-14T13:56:06 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
992024-11-14T13:58:13 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 252 seconds)
1002024-11-14T13:58:56 *** sliv3r__ <sliv3r__!~sliv3r__@user/sliv3r-:76883> has joined #bitcoin-core-dev
1012024-11-14T14:00:12 *** nymius <nymius!~nymius@169.150.198.86> has joined #bitcoin-core-dev
1022024-11-14T14:00:20 <achow101> #startmeeting
1032024-11-14T14:00:23 <tdb3> hi
1042024-11-14T14:00:26 <abubakarsadiq> hi
1052024-11-14T14:00:26 <josie> hi
1062024-11-14T14:00:28 <achow101> #bitcoin-core-dev Meeting: abubakarsadiq achow101 _aj_ ajonas b10c brunoerg cfields darosior dergoegge fanquake fjahr furszy gleb glozow hebasto instagibbs jarolrod jonatack josibake kanzure laanwj LarryRuane lightlike luke-jr maflcko maxedw Murch pinheadmz provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi tdb3 theStack TheCharlatan vasild willcl-ark
1072024-11-14T14:00:29 <sipa> hi
1082024-11-14T14:00:32 <sliv3r__> hi
1092024-11-14T14:00:32 <theStack> hi
1102024-11-14T14:00:33 <TheCharlatan> hi
1112024-11-14T14:00:36 <vasild> hi
1122024-11-14T14:00:40 <b10c> hi
1132024-11-14T14:00:43 <kevkevin> hi
1142024-11-14T14:00:46 <sdaftuar> hi
1152024-11-14T14:00:47 <willcl-ark> hi
1162024-11-14T14:00:53 <achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add?
1172024-11-14T14:00:54 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Quit: Leaving...)
1182024-11-14T14:01:03 <gleb> Hi
1192024-11-14T14:01:03 <BlueMatt[m]> Is Sjors here?
1202024-11-14T14:01:07 <maxedw> hi
1212024-11-14T14:01:09 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
1222024-11-14T14:01:17 <kevkevin> hi
1232024-11-14T14:01:32 <achow101> BlueMatt[m]: doesn't seem like it yet
1242024-11-14T14:01:56 <brunoerg> hi
1252024-11-14T14:02:12 <achow101> #topic Erlay WG Update (sr_gi, gleb, marcofleon)
1262024-11-14T14:02:24 <stickies-v> hi
1272024-11-14T14:02:42 *** nymius <nymius!~nymius@169.150.198.86> has quit IRC (Client Quit)
1282024-11-14T14:02:46 <gleb> On erlay side I guess thatâs me
1292024-11-14T14:03:24 <kanzure> hi
1302024-11-14T14:03:31 <gleb> Weâre having some productive discussions on moving forward in the WG chat, especially how to think of spy nodes; and how to think of the efficiency
1312024-11-14T14:04:07 *** nymius <nymius!~nymius@169.150.198.86> has joined #bitcoin-core-dev
1322024-11-14T14:04:09 <gleb> In-pr sergi is reviewing a lot of my comments. I know several contributors are waiting for that to resolve first
1332024-11-14T14:04:40 <gleb> Iâm spinning up test nodes for others to connect to. Thinking Warnet or not
1342024-11-14T14:04:45 <gleb> Thatâs it!
1352024-11-14T14:05:01 <achow101> #topic Kernel WG Update (TheCharlatan)
1362024-11-14T14:05:05 <josie> gleb: feel free to reach out if you want a warnet onboarding / crash course
1372024-11-14T14:05:10 <TheCharlatan> Nothing new today, thank you for the quick reviews on #31269
1382024-11-14T14:05:14 <gribble> https://github.com/bitcoin/bitcoin/issues/31269 | validation: Remove RECENT_CONSENSUS_CHANGE validation result by TheCharlatan · Pull Request #31269 · bitcoin/bitcoin · GitHub
1392024-11-14T14:05:29 <achow101> #topic Benchmarking WG Update (josie, l0rinc)
1402024-11-14T14:05:33 <josie> made progress on getting a mainnet assumeutxo bench running automatically when a PR is opened. the benchmark now automatically does benchcoin master vs PR branch (h/t willcl-ark)
1412024-11-14T14:05:40 <josie> the final results are published to a github page, with flamegraphs included (h/t davidgumberg)
1422024-11-14T14:05:45 <josie> Novo___ and i will be using the new setup this next week to investigate the batch validatoin PR
1432024-11-14T14:05:51 <josie> we are also at the stage where having extra dedicated runners would be helpful. was planning to purchase some more hetzner boxes and add them, but a few people mentioned having some resources that could be used for this, planning to follow up on that this week
1442024-11-14T14:06:01 <josie> thats all!
1452024-11-14T14:06:06 <achow101> #topic Silent Payments WG Update (josie, RubenSomsen)
1462024-11-14T14:06:09 <josie> slow and steady, working through all the feedback on the libsecp256k1 module
1472024-11-14T14:06:15 <josie> i do remember on the musig2 PR, there was a suggestion on how we type arrays of unsigned char where it is expected to be an exact size. it seemed doing this could be useful for languages like rust, when generating bindings automatically?
1482024-11-14T14:06:23 <josie> planning to follow up with the secp256k1 maintainers to see if this is worth doing for the silent payments module (perhaps a topic for the upcoming secp256k1 meeting this coming monday?)
1492024-11-14T14:06:39 <josie> thats all!
1502024-11-14T14:06:41 <sipa> josie: yeah, definitely worth bringing up
1512024-11-14T14:06:50 <achow101> #topic Cluster Mempool WG Update (sdaftuar, sipa)
1522024-11-14T14:07:14 <sdaftuar> hi, #31122 is still the PR to review. it seems to be getting close.
1532024-11-14T14:07:14 <josie> sipa: will do!
1542024-11-14T14:07:18 <gribble> https://github.com/bitcoin/bitcoin/issues/31122 | cluster mempool: Implement changeset interface for mempool by sdaftuar · Pull Request #31122 · bitcoin/bitcoin · GitHub
1552024-11-14T14:07:48 <sdaftuar> i think pieter is getting closer with his txgraph implementation as well -- will let him add any additional info
1562024-11-14T14:08:00 <sipa> i'm close to opening the first txgraph PR (the middle layer between cluster linearization algorithms, and the mempool, which deals with dependencies/clusters/linearizations/proposed changes for the entire mempool)
1572024-11-14T14:08:44 <sipa> nothing else from me
1582024-11-14T14:09:31 <achow101> #topic MuSig2 WG Update (achow101)
1592024-11-14T14:09:48 <achow101> We had a discussion about breaking up #29675, so i've opened 2 refactors (#31242, #31243) and a PR for the PSBT fields (#31247)
1602024-11-14T14:09:51 <gribble> https://github.com/bitcoin/bitcoin/issues/29675 | wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys by achow101 · Pull Request #29675 · bitcoin/bitcoin · GitHub
1612024-11-14T14:09:55 <gribble> https://github.com/bitcoin/bitcoin/issues/31242 | wallet, desc spkm: Return SigningProvider only if we have the privkey by achow101 · Pull Request #31242 · bitcoin/bitcoin · GitHub
1622024-11-14T14:09:56 <gribble> https://github.com/bitcoin/bitcoin/issues/31243 | descriptor: Move filling of keys from `DescriptorImpl::MakeScripts` to `PubkeyProvider::GetPubKey` by achow101 · Pull Request #31243 · bitcoin/bitcoin · GitHub
1632024-11-14T14:10:00 <gribble> https://github.com/bitcoin/bitcoin/issues/31247 | psbt: MuSig2 Fields by achow101 · Pull Request #31247 · bitcoin/bitcoin · GitHub
1642024-11-14T14:10:31 <achow101> The descriptors implementation is also in a separate draft PR ##31244, and 29675 is the final that require all of the above and adds signing
1652024-11-14T14:10:33 <gribble> https://github.com/bitcoin/bitcoin/issues/31244 | descriptors: MuSig2 by achow101 · Pull Request #31244 · bitcoin/bitcoin · GitHub
1662024-11-14T14:10:51 <achow101> #topic Legacy Wallet Removal WG Update (achow101)
1672024-11-14T14:12:13 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
1682024-11-14T14:12:28 <achow101> Also had a discussion about breaking up #28710, so there's now the migration test rework in #31248, and #31250 has legacy wallets disabled but not removed
1692024-11-14T14:12:30 <gribble> https://github.com/bitcoin/bitcoin/issues/28710 | Remove the legacy wallet and BDB dependency by achow101 · Pull Request #28710 · bitcoin/bitcoin · GitHub
1702024-11-14T14:12:33 <gribble> https://github.com/bitcoin/bitcoin/issues/31248 | test: Rework wallet_migration.py to use previous releases by achow101 · Pull Request #31248 · bitcoin/bitcoin · GitHub
1712024-11-14T14:12:35 <gribble> https://github.com/bitcoin/bitcoin/issues/31250 | wallet: Disable creating and loading legacy wallets by achow101 · Pull Request #31250 · bitcoin/bitcoin · GitHub
1722024-11-14T14:13:00 <achow101> furszy has opened #31241 as well
1732024-11-14T14:13:02 <gribble> https://github.com/bitcoin/bitcoin/issues/31241 | wallet: remove BDB dependency from wallet migration benchmark by furszy · Pull Request #31241 · bitcoin/bitcoin · GitHub
1742024-11-14T14:13:39 <jonatack> hi
1752024-11-14T14:13:51 <achow101> that's all for working groups that i see here
1762024-11-14T14:14:04 <achow101> Anything else to discuss?
1772024-11-14T14:14:40 <instagibbs> shoutout to all the ephemeral dust review, not exactly a topic
1782024-11-14T14:15:14 <vasild> achow101: I guess that once legacy wallet is removed (in 29?) softwares that use Bitcoin Core's wallet but don't support descriptor wallets will have to stick to v28?
1792024-11-14T14:15:16 <josie> instagibbs: congrats on moving that forward!
1802024-11-14T14:15:28 <achow101> vasild: yes
1812024-11-14T14:15:39 <vasild> ok
1822024-11-14T14:16:16 <sipa> vasild, achow101: though there are some RPCs we could realistically implement for descriptor wallets which are legacy-only currently (see #30175
1832024-11-14T14:16:18 <gribble> https://github.com/bitcoin/bitcoin/issues/30175 | Enable `importprivkey`, `addmultisigaddress` in descriptor wallets · Issue #30175 · bitcoin/bitcoin · GitHub
1842024-11-14T14:17:01 <jonatack> hi again (first one didn't seem to get through)
1852024-11-14T14:17:04 <vasild> https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/1571#issuecomment-2102790757 "JoinMarket uses importmulti call, which is not available for descriptor wallets"
1862024-11-14T14:17:11 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Quit: WeeChat 4.4.3)
1872024-11-14T14:17:48 <sipa> translating importmulti is not impossible, but it'd be a nontrivial amount of work, and i don't think many things besides joinmarket use it?
1882024-11-14T14:18:03 <sipa> it'd be easier i expect to make joinmarket use importdescriptors instead
1892024-11-14T14:18:33 <achow101> presumably the problem is that they don't create descriptors
1902024-11-14T14:19:11 <vasild> I think it is possible to do custom gap limits
1912024-11-14T14:19:17 <vasild> with descriptor wallets
1922024-11-14T14:19:56 <achow101> yeah, they can do things manually with keypoolrefill
1932024-11-14T14:20:02 <achow101> i'll leave a comment on that issue
1942024-11-14T14:20:06 <laanwj> sipa: i don't think so either, joinmarket is the only common software that's stuck at pre-descriptor wallets, that i know of
1952024-11-14T14:20:37 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1962024-11-14T14:21:28 <achow101> #endmeeting
1972024-11-14T14:22:46 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1982024-11-14T14:23:20 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Client Quit)
1992024-11-14T14:23:45 <nymius> bye
2002024-11-14T14:24:00 *** nymius <nymius!~nymius@user/nymius> has quit IRC (Quit: nymius)
2012024-11-14T14:24:24 <theStack> electrum personal server is also still relying on pre-descriptor wallets, fwiw (not sure how much it is used those days though)
2022024-11-14T14:24:47 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2032024-11-14T14:25:02 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Client Quit)
2042024-11-14T14:25:18 <laanwj> theStack: do you by any chance know what RPCs it's using that are missing for descriptors wallets?
2052024-11-14T14:25:20 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2062024-11-14T14:26:03 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 272 seconds)
2072024-11-14T14:27:06 <theStack> laanwj: IIRC, it was also importmulti
2082024-11-14T14:27:59 <theStack> (see e.g. https://github.com/chris-belcher/electrum-personal-server/issues/269 )
2092024-11-14T14:28:12 <achow101> I imagine that getting changes into electrum personal server may be difficult given belcher's health issues
2102024-11-14T14:28:26 <theStack> yeah :/
2112024-11-14T14:31:01 *** nymius <nymius!~nymius@169.150.198.86> has joined #bitcoin-core-dev
2122024-11-14T14:34:28 *** nymius <nymius!~nymius@169.150.198.86> has quit IRC (Client Quit)
2132024-11-14T14:37:01 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Read error: Connection reset by peer)
2142024-11-14T14:38:22 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2152024-11-14T14:54:00 <laanwj> yea :/ doesn't look like there's an actively maintained fork, either
2162024-11-14T15:04:29 *** sliv3r__ <sliv3r__!~sliv3r__@user/sliv3r-:76883> has quit IRC (Ping timeout: 256 seconds)
2172024-11-14T15:10:36 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has joined #bitcoin-core-dev
2182024-11-14T15:13:41 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Remote host closed the connection)
2192024-11-14T15:14:06 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2202024-11-14T15:16:23 *** dzxzg <dzxzg!~dzxzg@user/dzxzg> has quit IRC (Ping timeout: 256 seconds)
2212024-11-14T15:23:28 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 252 seconds)
2222024-11-14T15:24:38 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
2232024-11-14T15:30:27 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 276 seconds)
2242024-11-14T15:30:34 <bitcoin-git> [bitcoin] lulapainho opened pull request #31290: feati: mais moeda (master...master) https://github.com/bitcoin/bitcoin/pull/31290
2252024-11-14T15:31:47 <bitcoin-git> [bitcoin] fanquake closed pull request #31290: feati: mais moeda (master...master) https://github.com/bitcoin/bitcoin/pull/31290
2262024-11-14T15:33:55 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
2272024-11-14T15:34:04 <instagibbs> ^ nation states like Brazil trying to stack
2282024-11-14T15:44:32 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
2292024-11-14T15:51:00 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 260 seconds)
2302024-11-14T15:52:33 *** rsantacroce <rsantacroce!~textual@62.37.183.70> has joined #bitcoin-core-dev
2312024-11-14T15:56:28 <brunoerg> instagibbs: should i be proud of it?
2322024-11-14T15:59:15 *** rsantacroce <rsantacroce!~textual@62.37.183.70> has quit IRC (Quit: Textual IRC Client: www.textualapp.com)
2332024-11-14T15:59:50 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
2342024-11-14T16:04:57 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 265 seconds)
2352024-11-14T16:16:13 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
2362024-11-14T16:28:42 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
2372024-11-14T16:31:13 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
2382024-11-14T16:37:40 *** eval-exec <eval-exec!~Thunderbi@96.45.190.137.16clouds.com> has quit IRC (Ping timeout: 260 seconds)
2392024-11-14T17:47:51 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Remote host closed the connection)
2402024-11-14T17:48:14 *** jamesob443688173 <jamesob443688173!~jamesob@108.44.248.162> has quit IRC (Quit: The Lounge - https://thelounge.chat)
2412024-11-14T17:48:14 *** jamesob15 <jamesob15!~jamesob@108.44.248.162> has quit IRC (Quit: The Lounge - https://thelounge.chat)
2422024-11-14T17:52:30 *** jamesob443688173 <jamesob443688173!~jamesob@108.44.248.162> has joined #bitcoin-core-dev
2432024-11-14T17:52:30 *** jamesob15 <jamesob15!~jamesob@108.44.248.162> has joined #bitcoin-core-dev
2442024-11-14T18:00:09 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
2452024-11-14T18:00:15 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
2462024-11-14T18:04:35 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Ping timeout: 260 seconds)
2472024-11-14T18:09:21 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 248 seconds)
2482024-11-14T18:29:59 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e546b4e1a0c5...2d944e982c47
2492024-11-14T18:30:01 <bitcoin-git> bitcoin/master cdf34be fanquake: guix: remove util-linux
2502024-11-14T18:30:03 <bitcoin-git> bitcoin/master 4d66854 fanquake: ci: remove util-linux from centos CI
2512024-11-14T18:30:04 <bitcoin-git> bitcoin/master 2d944e9 merge-script: Merge bitcoin/bitcoin#31285: guix: remove `util-linux`
2522024-11-14T18:30:06 <bitcoin-git> [bitcoin] fanquake merged pull request #31285: guix: remove `util-linux` (master...remove_util_linux) https://github.com/bitcoin/bitcoin/pull/31285
2532024-11-14T19:50:36 *** andrewtoth_ <andrewtoth_!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
2542024-11-14T19:53:26 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has quit IRC (Ping timeout: 260 seconds)
2552024-11-14T19:53:26 *** qxs <qxs!~qxs@gateway/tor-sasl/qxs> has quit IRC (Ping timeout: 260 seconds)
2562024-11-14T19:54:55 *** qxs <qxs!~qxs@gateway/tor-sasl/qxs> has joined #bitcoin-core-dev
2572024-11-14T20:00:45 <bitcoin-git> [gui-qml] pablomartin4btc opened pull request #433: Persist proxy settings to settings.json (main...qml-proxy-settings-persistence) https://github.com/bitcoin-core/gui-qml/pull/433
2582024-11-14T20:05:14 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
2592024-11-14T20:05:39 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has quit IRC (Quit: PaperSword)
2602024-11-14T20:06:15 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
2612024-11-14T20:11:10 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 260 seconds)
2622024-11-14T20:11:44 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Read error: Connection reset by peer)
2632024-11-14T20:21:21 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Remote host closed the connection)
2642024-11-14T21:06:20 *** Guest16 <Guest16!~Guest16@2804:1e68:c211:b236:a58f:d5f3:117a:ae46> has joined #bitcoin-core-dev
2652024-11-14T21:06:37 *** Guest16 <Guest16!~Guest16@2804:1e68:c211:b236:a58f:d5f3:117a:ae46> has quit IRC (Client Quit)
2662024-11-14T21:12:52 <bitcoin-git> [bitcoin] furszy opened pull request #31291: test: add global time to place exec tests within the same dir (master...2024_test_global_path) https://github.com/bitcoin/bitcoin/pull/31291
2672024-11-14T21:19:36 <darosior> how do i enable the debug symbols but keep an optimized build with cmake?
2682024-11-14T21:20:17 <darosior> what im trying to achieve: having enough information for `perf` but keeping the optimizations so the flamegraph actually reflects reality
2692024-11-14T21:20:58 <sipa> my understanding is that that is the default: the default built type is RelWithDebInfo
2702024-11-14T21:21:09 <sipa> does running cmake say "CMAKE_BUILD_TYPE ...................... RelWithDebInfo
2712024-11-14T21:22:08 <bitcoin-git> [bitcoin] casey opened pull request #31292: Add `contrib/justfile` containing useful development workflow commands. (master...justfile) https://github.com/bitcoin/bitcoin/pull/31292
2722024-11-14T21:22:54 <darosior> Yeah, so looks like the problem is elsewhere.
2732024-11-14T21:24:09 <darosior> readelf also says my binary has them
2742024-11-14T21:25:54 <darosior> Ah, i just didn't have the kernel debug symbols on this new machine. If anyone's coming back to read this: apt install linux-image-`uname -r`-dbg did the trick.
2752024-11-14T21:31:04 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2d944e982c47...1a8f51e7453c
2762024-11-14T21:31:09 <bitcoin-git> bitcoin/master 192dac1 TheCharlatan: [refactor] Cleanup BlockAssembler mempool usage
2772024-11-14T21:31:11 <bitcoin-git> bitcoin/master 1a8f51e Ava Chow: Merge bitcoin/bitcoin#28843: [refactor] Cleanup BlockAssembler mempool usa...
2782024-11-14T21:31:14 <bitcoin-git> [bitcoin] achow101 merged pull request #28843: [refactor] Cleanup BlockAssembler mempool usage (master...blockAssemblerRemoveMempool) https://github.com/bitcoin/bitcoin/pull/28843
2792024-11-14T21:34:38 <sipa> darosior: ah good to know
2802024-11-14T21:36:41 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1a8f51e7453c...380e1f44e8ed
2812024-11-14T21:36:42 <bitcoin-git> bitcoin/master 42066f4 LÅrinc: Refactor SipHash_32b benchmark to improve accuracy and avoid optimization ...
2822024-11-14T21:36:42 <bitcoin-git> bitcoin/master 380e1f4 Ava Chow: Merge bitcoin/bitcoin#30349: benchmark: Improve SipHash_32b accuracy to av...
2832024-11-14T21:36:43 <bitcoin-git> [bitcoin] achow101 merged pull request #30349: benchmark: Improve SipHash_32b accuracy to avoid potential optimization issues (master...paplorinc/remove_siphash_benchmark_recursion) https://github.com/bitcoin/bitcoin/pull/30349
2842024-11-14T21:45:16 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/380e1f44e8ed...2257c6d68fae
2852024-11-14T21:45:16 <bitcoin-git> bitcoin/master 8610bce Sjors Provoost: ci: skip Github CI on branch pushes for forks
2862024-11-14T21:45:17 <bitcoin-git> bitcoin/master 2257c6d Ava Chow: Merge bitcoin/bitcoin#30487: ci: skip Github CI on branch pushes for forks
2872024-11-14T21:45:19 <bitcoin-git> [bitcoin] achow101 merged pull request #30487: ci: skip Github CI on branch pushes for forks (master...2024/07/ci-fork-github) https://github.com/bitcoin/bitcoin/pull/30487
2882024-11-14T21:54:49 <bitcoin-git> [bitcoin] achow101 pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/2257c6d68fae...85bcfeea2356
2892024-11-14T21:54:50 <bitcoin-git> bitcoin/master a51e917 Martin Zumsande: validation: add RecalculateBestHeader() function
2902024-11-14T21:54:50 <bitcoin-git> bitcoin/master 9275e96 Martin Zumsande: rpc: call RecalculateBestHeader as part of reconsiderblock
2912024-11-14T21:54:50 <bitcoin-git> bitcoin/master 783cb73 Martin Zumsande: validation: call RecalculateBestHeader in InvalidChainFound
2922024-11-14T21:54:52 <bitcoin-git> [bitcoin] achow101 merged pull request #30666: validation: fix m_best_header tracking and BLOCK_FAILED_CHILD assignment (master...202404_invalidblock) https://github.com/bitcoin/bitcoin/pull/30666
2932024-11-14T22:03:13 *** Guest24 <Guest24!~Guest24@host-79-21-107-85.retail.telecomitalia.it> has joined #bitcoin-core-dev
2942024-11-14T22:03:52 *** Guest24 <Guest24!~Guest24@host-79-21-107-85.retail.telecomitalia.it> has quit IRC (Client Quit)
2952024-11-14T22:08:13 *** __DuBPiRaTe__ <__DuBPiRaTe__!~E_bomb@2600:6c50:7f7f:d89a:a9ff:a8ae:e1a0:5f48> has joined #bitcoin-core-dev
2962024-11-14T22:08:28 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
2972024-11-14T22:10:19 *** conman <conman!~con@180-150-21-3.b49615.mel.static.aussiebb.net> has quit IRC (Read error: Connection reset by peer)
2982024-11-14T22:13:13 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 252 seconds)
2992024-11-14T22:27:24 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Quit: Leaving)
3002024-11-14T22:36:40 *** __DuBPiRaTe__ <__DuBPiRaTe__!~E_bomb@2600:6c50:7f7f:d89a:a9ff:a8ae:e1a0:5f48> has quit IRC (Remote host closed the connection)
3012024-11-14T22:38:34 *** __DuBPiRaTe__ <__DuBPiRaTe__!~E_bomb@2600:6c50:7f7f:d89a:a9ff:a8ae:e1a0:5f48> has joined #bitcoin-core-dev
3022024-11-14T22:56:41 *** conman <conman!~con@180-150-21-3.b49615.mel.static.aussiebb.net> has joined #bitcoin-core-dev
3032024-11-14T23:01:27 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Remote host closed the connection)
3042024-11-14T23:02:00 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
3052024-11-14T23:06:29 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Ping timeout: 248 seconds)
3062024-11-14T23:28:33 *** adam_ <adam_!~adam@2603:8001:6ef0:a660:1d97:ff5a:abec:3ce5> has joined #bitcoin-core-dev
3072024-11-14T23:51:36 *** pablomartin <pablomartin!~pablomart@155.133.17.140> has quit IRC (Ping timeout: 276 seconds)
3082024-11-14T23:57:27 *** adam_ <adam_!~adam@2603:8001:6ef0:a660:1d97:ff5a:abec:3ce5> has quit IRC (Ping timeout: 276 seconds)