12024-11-15T00:03:47 *** eval-exec <eval-exec!~Thunderbi@96.45.190.137.16clouds.com> has joined #bitcoin-core-dev
22024-11-15T00:10:21 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
32024-11-15T00:15:00 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 260 seconds)
42024-11-15T00:16:38 *** rizzling <rizzling!~rizzling@2a02:8109:b691:d400:b8ea:649d:8e51:9f5> has joined #bitcoin-core-dev
52024-11-15T00:16:39 *** pablomartin <pablomartin!~pablomart@155.133.17.130> has joined #bitcoin-core-dev
62024-11-15T00:28:42 *** rizzling <rizzling!~rizzling@2a02:8109:b691:d400:b8ea:649d:8e51:9f5> has quit IRC (Quit: Client closed)
72024-11-15T00:36:06 *** pablomartin <pablomartin!~pablomart@155.133.17.130> has quit IRC (Ping timeout: 252 seconds)
82024-11-15T00:36:31 *** pablomartin <pablomartin!~pablomart@155.133.17.133> has joined #bitcoin-core-dev
92024-11-15T00:46:20 *** pablomartin <pablomartin!~pablomart@155.133.17.133> has quit IRC (Ping timeout: 264 seconds)
102024-11-15T01:13:50 *** rodarmor_ is now known as rodarmor
112024-11-15T01:14:39 <rodarmor> I wrote a script to build an mdbook from the markdown docs in bitcoin/bitcoin. It's a bit of a mess, and uses Rust to generate the docs, so it's not really fit to merge in its current state, but it's pretty nice.
122024-11-15T01:14:51 <rodarmor> Docs here, hosted on GitHub pages: https://casey.github.io/bitcoin/
132024-11-15T01:14:59 <rodarmor> PR here: https://github.com/casey/bitcoin/pull/3
142024-11-15T01:27:28 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: leaving)
152024-11-15T01:37:52 *** _flood <_flood!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Remote host closed the connection)
162024-11-15T01:39:25 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
172024-11-15T01:47:59 *** __DuBPiRaTe__ <__DuBPiRaTe__!~E_bomb@2600:6c50:7f7f:d89a:a9ff:a8ae:e1a0:5f48> has quit IRC (Quit: Leaving)
182024-11-15T01:59:51 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Remote host closed the connection)
192024-11-15T02:01:22 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
202024-11-15T02:03:08 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has joined #bitcoin-core-dev
212024-11-15T02:03:26 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Read error: Connection reset by peer)
222024-11-15T02:04:45 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
232024-11-15T02:05:56 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Remote host closed the connection)
242024-11-15T03:13:24 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has joined #bitcoin-core-dev
252024-11-15T03:14:54 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
262024-11-15T03:17:55 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:2517:da70:25f3:ca8e> has quit IRC (Ping timeout: 252 seconds)
272024-11-15T03:19:34 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Ping timeout: 252 seconds)
282024-11-15T03:39:48 *** eval-exec <eval-exec!~Thunderbi@96.45.190.137.16clouds.com> has quit IRC (Ping timeout: 252 seconds)
292024-11-15T03:52:27 *** adil <adil!~Thunderbi@2402:d000:8134:2758:e505:f27d:3e1:f5d1> has joined #bitcoin-core-dev
302024-11-15T04:16:47 *** auci <auci!~auci@user/auci> has joined #bitcoin-core-dev
312024-11-15T04:16:58 *** auci <auci!~auci@user/auci> has quit IRC (Client Quit)
322024-11-15T05:01:02 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
332024-11-15T05:01:32 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
342024-11-15T05:19:45 *** adil <adil!~Thunderbi@2402:d000:8134:2758:e505:f27d:3e1:f5d1> has quit IRC (Quit: adil)
352024-11-15T05:51:25 *** aleggg <aleggg!~aleggg@177.204.246.39.dynamic.adsl.gvt.net.br> has quit IRC (Ping timeout: 252 seconds)
362024-11-15T05:52:17 *** aleggg <aleggg!~aleggg@189.114.69.140> has joined #bitcoin-core-dev
372024-11-15T06:01:31 *** mcey_ <mcey_!~emcy@85.255.234.203> has quit IRC (Remote host closed the connection)
382024-11-15T06:01:35 *** mcey <mcey!~emcy@85.255.234.203> has joined #bitcoin-core-dev
392024-11-15T06:14:32 *** eval-exec <eval-exec!~Thunderbi@96.45.190.137.16clouds.com> has joined #bitcoin-core-dev
402024-11-15T06:19:37 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has quit IRC (Quit: PaperSword)
412024-11-15T07:18:09 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:b837:b5e7:19a0:d736> has joined #bitcoin-core-dev
422024-11-15T07:22:24 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:b837:b5e7:19a0:d736> has quit IRC (Ping timeout: 260 seconds)
432024-11-15T07:23:45 *** cornfeedhobo <cornfeedhobo!~cornfeedh@user/cornfeedhobo> has quit IRC (Read error: Connection reset by peer)
442024-11-15T07:29:51 *** cornfeedhobo <cornfeedhobo!~cornfeedh@user/cornfeedhobo> has joined #bitcoin-core-dev
452024-11-15T07:43:06 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
462024-11-15T07:47:17 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Ping timeout: 252 seconds)
472024-11-15T08:00:19 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:1034:8a56:c093:8aa> has joined #bitcoin-core-dev
482024-11-15T08:05:09 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:1034:8a56:c093:8aa> has quit IRC (Ping timeout: 248 seconds)
492024-11-15T08:19:09 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:203d:79ec:d36c:ad35> has joined #bitcoin-core-dev
502024-11-15T08:23:13 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:203d:79ec:d36c:ad35> has quit IRC (Ping timeout: 248 seconds)
512024-11-15T08:51:06 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
522024-11-15T08:55:07 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has joined #bitcoin-core-dev
532024-11-15T08:56:45 <vasild> Maybe this can be labeled as "good first issue": #31293
542024-11-15T08:56:46 <gribble> https://github.com/bitcoin/bitcoin/issues/31293 | Discover() will not run if listening on any address with an explicit bind=0.0.0.0 · Issue #31293 · bitcoin/bitcoin · GitHub
552024-11-15T09:00:00 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has quit IRC (Ping timeout: 260 seconds)
562024-11-15T09:12:49 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has joined #bitcoin-core-dev
572024-11-15T09:24:09 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has quit IRC (Ping timeout: 245 seconds)
582024-11-15T09:36:45 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has joined #bitcoin-core-dev
592024-11-15T09:38:50 *** eval-exec <eval-exec!~Thunderbi@96.45.190.137.16clouds.com> has quit IRC (Ping timeout: 255 seconds)
602024-11-15T09:41:52 *** greypw <greypw!~greypw@user/greypw> has joined #bitcoin-core-dev
612024-11-15T09:53:42 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev (Closing Window)
622024-11-15T10:40:47 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has quit IRC (Ping timeout: 272 seconds)
632024-11-15T10:45:44 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has joined #bitcoin-core-dev
642024-11-15T11:03:04 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
652024-11-15T11:07:34 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Ping timeout: 260 seconds)
662024-11-15T11:22:29 *** S3RK <S3RK!~S3RK@user/s3rk> has joined #bitcoin-core-dev
672024-11-15T11:25:28 *** S3RK_ <S3RK_!~S3RK@user/s3rk> has quit IRC (Ping timeout: 252 seconds)
682024-11-15T11:27:45 *** Guest28 <Guest28!~Guest28@ns3158127.ip-51-83-237.eu> has joined #bitcoin-core-dev
692024-11-15T11:32:03 *** Guest28 <Guest28!~Guest28@ns3158127.ip-51-83-237.eu> has quit IRC (Client Quit)
702024-11-15T11:41:14 *** maflcko <maflcko!~none@107.172.8.183> has quit IRC (Ping timeout: 245 seconds)
712024-11-15T11:44:31 *** maflcko <maflcko!~none@107.172.8.183> has joined #bitcoin-core-dev
722024-11-15T11:50:59 *** Artea <Artea!~Lufia@artea.pt> has joined #bitcoin-core-dev
732024-11-15T12:14:12 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has quit IRC (Ping timeout: 246 seconds)
742024-11-15T12:27:25 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has joined #bitcoin-core-dev
752024-11-15T12:30:56 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
762024-11-15T12:35:04 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Ping timeout: 252 seconds)
772024-11-15T12:36:43 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has quit IRC (Ping timeout: 252 seconds)
782024-11-15T12:45:40 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has joined #bitcoin-core-dev
792024-11-15T12:53:09 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has quit IRC (Ping timeout: 272 seconds)
802024-11-15T12:55:58 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has joined #bitcoin-core-dev
812024-11-15T12:56:42 *** Guest91 <Guest91!~Guest91@2a0d:3344:34da:8a10:8498:4033:6aa4:6451> has joined #bitcoin-core-dev
822024-11-15T12:58:46 *** jespada <jespada!~jespada@cpc121308-nmal25-2-0-cust15.19-2.cable.virginm.net> has quit IRC (Read error: Connection reset by peer)
832024-11-15T12:59:02 *** jespada <jespada!~jespada@cpc121308-nmal25-2-0-cust15.19-2.cable.virginm.net> has joined #bitcoin-core-dev
842024-11-15T13:01:28 *** TheRec <TheRec!~toto@user/therec> has quit IRC ()
852024-11-15T13:03:45 *** jespada <jespada!~jespada@cpc121308-nmal25-2-0-cust15.19-2.cable.virginm.net> has quit IRC (Ping timeout: 248 seconds)
862024-11-15T13:07:51 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has quit IRC (Ping timeout: 276 seconds)
872024-11-15T13:11:03 *** jespada <jespada!~jespada@cpc121308-nmal25-2-0-cust15.19-2.cable.virginm.net> has joined #bitcoin-core-dev
882024-11-15T13:13:27 *** TheRec <TheRec!~toto@user/therec> has joined #bitcoin-core-dev
892024-11-15T13:21:13 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has joined #bitcoin-core-dev
902024-11-15T13:28:25 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has quit IRC (Ping timeout: 252 seconds)
912024-11-15T13:42:37 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has joined #bitcoin-core-dev
922024-11-15T13:49:55 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has quit IRC (Ping timeout: 260 seconds)
932024-11-15T13:56:58 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has joined #bitcoin-core-dev
942024-11-15T14:04:30 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has quit IRC (Ping timeout: 260 seconds)
952024-11-15T14:16:31 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has joined #bitcoin-core-dev
962024-11-15T14:23:25 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
972024-11-15T14:23:58 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has quit IRC (Ping timeout: 252 seconds)
982024-11-15T14:32:22 <jamesob15> This has two pretty well qualified ACKs and a number of concept ACKs. Is there anything else I can do to get some maintainer consideration on this? #30708
992024-11-15T14:32:25 <gribble> https://github.com/bitcoin/bitcoin/issues/30708 | rpc: add getdescriptoractivity by jamesob · Pull Request #30708 · bitcoin/bitcoin · GitHub
1002024-11-15T14:34:03 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has joined #bitcoin-core-dev
1012024-11-15T14:37:49 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has joined #bitcoin-core-dev
1022024-11-15T14:45:09 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has quit IRC (Ping timeout: 260 seconds)
1032024-11-15T14:48:09 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
1042024-11-15T14:53:41 <bitcoin-git> [bitcoin] ryanofsky pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/85bcfeea2356...ccc2d3abcd39
1052024-11-15T14:53:41 <bitcoin-git> bitcoin/master fa1177e MarcoFalke: refactor: Avoid std::string format strings
1062024-11-15T14:53:42 <bitcoin-git> bitcoin/master ccc2d3a Ryan Ofsky: Merge bitcoin/bitcoin#31287: refactor: Avoid std::string format strings
1072024-11-15T14:53:42 <bitcoin-git> [bitcoin] ryanofsky merged pull request #31287: refactor: Avoid std::string format strings (master...2411-check-fmt) https://github.com/bitcoin/bitcoin/pull/31287
1082024-11-15T14:55:22 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has joined #bitcoin-core-dev
1092024-11-15T15:21:53 *** __DuBPiRaTe__ <__DuBPiRaTe__!~E_bomb@2600:6c50:7f7f:d89a:94dd:afc9:60ad:6f0e> has joined #bitcoin-core-dev
1102024-11-15T15:23:13 *** Guest91 <Guest91!~Guest91@2a0d:3344:34da:8a10:8498:4033:6aa4:6451> has quit IRC (Quit: Client closed)
1112024-11-15T15:36:59 *** Guest91 <Guest91!~Guest91@2a0d:3344:34da:8a10:8498:4033:6aa4:6451> has joined #bitcoin-core-dev
1122024-11-15T15:41:47 <sipa> jamesob15: i like the change, but is there really no way i can convince you to drop the "spend-from address" part?
1132024-11-15T15:42:01 <instagibbs> im reviewing now btw.... thanks for the reminder
1142024-11-15T15:48:07 *** ghost43 <ghost43!~ghost43@gateway/tor-sasl/ghost43> has joined #bitcoin-core-dev
1152024-11-15T15:49:11 *** ghost43_ <ghost43_!~ghost43@gateway/tor-sasl/ghost43> has quit IRC (Remote host closed the connection)
1162024-11-15T15:52:34 *** Guest91 <Guest91!~Guest91@2a0d:3344:34da:8a10:8498:4033:6aa4:6451> has quit IRC (Quit: Client closed)
1172024-11-15T16:14:10 <kevkevin> taking a look at the PR as well rn, might need to finish up reviewing later today
1182024-11-15T16:19:26 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
1192024-11-15T16:20:16 <jamesob15> sipa: I'd really like it in there as an end user for this wallet thing I'm writing. I want to understand your concern - is there something above and beyond "this is just inconsistent with RPCs never having attempted to infer an address for spend coins before"?
1202024-11-15T16:20:31 <jamesob15> *spent
1212024-11-15T16:26:52 <sipa> jamesob15: yes
1222024-11-15T16:28:36 <sipa> jamesob15: there are two models of looking at the ledger that are common. the "wallet" model, where addresses are entry points into a wallet, but don't hold a balance of their own; it's the wallet that holds a balance in aggregate by having control of a number of coins. You can't "spend from" an address at all, because that is not where coins are held.
1232024-11-15T16:29:24 <sipa> the other is the "explorer" model, where addresses hold a balance of their own, and transactions have to-address and from-addresses, which increment and decrement that balance
1242024-11-15T16:29:41 <sipa> both of these models are wrong (addresses don't exist at all at the protocol level), but some models are useful
1252024-11-15T16:29:54 <sipa> i'm strongly of the opinion that the "explorer" model is harmful
1262024-11-15T16:31:01 <sipa> here, not too long ago: https://www.reddit.com/r/Bitcoin/comments/1fkjx2o/comment/lnwgnzp/
1272024-11-15T16:31:18 <instagibbs> fwiw any library can do spk->address formatting, so downstream wallets can trivially support whatever they want here
1282024-11-15T16:31:20 <jamesob15> sipa: I think there's a simple counterexample use. Let's say for the sake of convenience, I want to withdrawal coins from different exchanges and have them bucketed somehow by exchange. I generate an address that I use for river, one for cashapp, ... In certain cases, I may want to pull from _only_ the coins I have received from one exchange.
1292024-11-15T16:31:20 <jamesob15> Asking the wallet to "spend from this address" is a convenient interface in that case.
1302024-11-15T16:31:47 <jamesob15> instagibbs: but then the client has to implement the address logic, which is not trivial. It's nice to be able to reuse Core's implementation.
1312024-11-15T16:32:36 <sipa> jamesob15: yeah, that's the "coin control" idea; in my view it's a useful expert feature, but it's not how things should be presented in general (i also think that multiwallet is realistically far more useful than coin control, because it's just so trivial to get it wrong)
1322024-11-15T16:32:54 <jamesob15> I really don't see what the harm is of just including it. It's cheap to generate and it's not like it sets some precedent that has to be abided by other RPC calls.
1332024-11-15T16:33:18 <sipa> i'm philosophically opposed to supporting a model that i consider harmful to bitcoin
1342024-11-15T16:33:32 <jamesob15> But you just said that "an expert feature" would make use of this model?
1352024-11-15T16:33:40 <instagibbs> the extra hoop is integrate any real library that does it, or call decodescript. I left my order of preferences in the PR anyways
1362024-11-15T16:36:05 <sipa> jamesob15: you have a point
1372024-11-15T16:37:48 <bitcoin-git> [bitcoin] maflcko opened pull request #31295: refactor: Prepare compile-time check of bilingual format strings (master...2411-trans-fmt-prepare) https://github.com/bitcoin/bitcoin/pull/31295
1382024-11-15T16:38:01 <sipa> it's still the case that no RPC really uses the "spend from" model; even scantxoutset just lists the address a coin was last sent to, but it's fair to say that coin control inherently exposes the user to an address-based model
1392024-11-15T16:39:27 <achow101> it would probably be better to make it align with how we do it everywhere else with calling it "prevout" or "scriptPubKey" and having the address in that breakdown
1402024-11-15T16:39:34 <achow101> e.g. getrawtranasction with verbosity 2
1412024-11-15T16:40:47 <achow101> this is at least not unprecedented, and I think the way of presenting it as information attached to the output that was spent, rather than the input, is a reasonable compromise
1422024-11-15T16:41:21 <jamesob15> achow101: so you're talking about just namespacing some of the information about the prevout in a nested dict?
1432024-11-15T16:41:26 <achow101> jamesob15: yeah
1442024-11-15T16:42:59 <sipa> i think that makes sense, it's consistent with other RPCs
1452024-11-15T16:43:25 <sipa> (i also don't want to nack things if overall opinion is that including the address is not a big deal)
1462024-11-15T16:43:52 <jamesob15> well getrawtransction verbosity 2 doesn't seem to return the address by default (at least according to the RPC doc), so I'm not sure if there's even a consistency to be had there. Nesting or not nesting doesn't seem like a big deal to me, and I tend to like flatter, but if that would somehow appease everyone I can do it
1472024-11-15T16:44:40 <achow101> jamesob15: it should be the same decoding stuff as is used for outputs. the optionality of the address is just that some scriptPubKeys don't have addresses
1482024-11-15T16:45:10 <jamesob15> achow101: ahh yes, I see - `ScriptPubKeyDoc()`
1492024-11-15T16:45:10 <achow101> which, I guess is also something getdescriptoractivity would have to handle (idk, haven't read the pr yet) since you can do raw(whatever)
1502024-11-15T16:45:34 <instagibbs> well right now it returns a blank string for address, I'd rather it be optional result
1512024-11-15T16:46:32 <jamesob15> I would be happy to do optional result but I literally can't figure out how to get our RPCResult doc stuff to work with that. On the client side, really the difference between "empty string" and "key no exists" is immaterial
1522024-11-15T16:47:06 <jamesob15> I'll see about reworking this to use `ScriptPubKeyDoc()` as achow101 suggested
1532024-11-15T16:47:22 <sipa> i think it'd make sense to say have for outputs have an "output": { dict with information about UTXO which can include txid, vout, amount, scriptpubkey, address, descriptor, ...}, and for inputs have an "prevout" { dict with the exact same information as "output" }
1542024-11-15T16:50:11 <achow101> jamesob15: one of the constructors for RPCResult has an "optional" parameter
1552024-11-15T17:05:51 <jamesob15> achow101: yeah I had been trying to use that but then was getting runtime errors or something about the return value being out of conformance
1562024-11-15T17:05:57 <jamesob15> will try again
1572024-11-15T17:08:01 <bitcoin-git> [bitcoin] ryanofsky opened pull request #31296: wallet: Translate [default wallet] string in progress messages (master...pr/dtran) https://github.com/bitcoin/bitcoin/pull/31296
1582024-11-15T17:21:51 *** jetpack_ <jetpack_!~jetpack@2605:2700:1:100e:dc::f01d> has quit IRC (Ping timeout: 246 seconds)
1592024-11-15T17:22:57 *** EPiSKiNG- <EPiSKiNG-!~EPiSKiNG-@episking.com> has quit IRC (Ping timeout: 272 seconds)
1602024-11-15T17:23:04 *** jetpack <jetpack!~jetpack@2605:2700:1:100e:dc::f01d> has joined #bitcoin-core-dev
1612024-11-15T17:24:43 *** EPiSKiNG- <EPiSKiNG-!~EPiSKiNG-@episking.com> has joined #bitcoin-core-dev
1622024-11-15T17:32:39 <bitcoin-git> [bitcoin] Sjors opened pull request #31297: mining: add early return to waitTipChanged() (master...2024/11/waittipchanged) https://github.com/bitcoin/bitcoin/pull/31297
1632024-11-15T18:31:12 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
1642024-11-15T18:46:41 *** gf2718 <gf2718!~gf2718@user/gf2718> has quit IRC (Ping timeout: 248 seconds)
1652024-11-15T18:57:43 *** jarthur <jarthur!~jarthur@user/jarthur> has joined #bitcoin-core-dev
1662024-11-15T19:13:19 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has joined #bitcoin-core-dev
1672024-11-15T19:18:27 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has quit IRC (Ping timeout: 252 seconds)
1682024-11-15T19:19:04 *** ubbabeck <ubbabeck!~ubbabeck@user/ubbabeck> has quit IRC (Quit: WeeChat 4.4.3)
1692024-11-15T19:23:33 *** ubbabeck <ubbabeck!~ubbabeck@user/ubbabeck> has joined #bitcoin-core-dev
1702024-11-15T19:33:08 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has joined #bitcoin-core-dev
1712024-11-15T20:26:53 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Remote host closed the connection)
1722024-11-15T20:28:26 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
1732024-11-15T20:28:55 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Remote host closed the connection)
1742024-11-15T20:32:19 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
1752024-11-15T20:35:14 <bitcoin-git> [bitcoin] furszy closed pull request #31291: test: group executed tests within the same directory (master...2024_test_global_path) https://github.com/bitcoin/bitcoin/pull/31291
1762024-11-15T20:35:44 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has quit IRC (Ping timeout: 260 seconds)
1772024-11-15T20:36:04 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1782024-11-15T20:36:33 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has quit IRC (Ping timeout: 248 seconds)
1792024-11-15T20:36:52 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
1802024-11-15T20:42:16 *** __DuBPiRaTe__ <__DuBPiRaTe__!~E_bomb@2600:6c50:7f7f:d89a:94dd:afc9:60ad:6f0e> has quit IRC (Quit: Leaving)
1812024-11-15T20:42:45 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has joined #bitcoin-core-dev
1822024-11-15T20:47:11 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has quit IRC (Ping timeout: 252 seconds)
1832024-11-15T20:49:24 *** kevkevin <kevkevin!~kevkevin@142.147.59.145> has joined #bitcoin-core-dev
1842024-11-15T20:51:58 *** jespada <jespada!~jespada@cpc121308-nmal25-2-0-cust15.19-2.cable.virginm.net> has quit IRC (Ping timeout: 252 seconds)
1852024-11-15T21:01:12 *** Guest16 <Guest16!~Guest16@2804:1330:1c7:6b00:cc44:253a:2a50:ffdc> has joined #bitcoin-core-dev
1862024-11-15T21:01:59 *** Guest16 <Guest16!~Guest16@2804:1330:1c7:6b00:cc44:253a:2a50:ffdc> has quit IRC (Client Quit)
1872024-11-15T21:08:48 *** gf2718 <gf2718!~gf2718@2a01:e0a:2f0:5440:bd8c:4ca9:77e2:6e42> has joined #bitcoin-core-dev
1882024-11-15T21:12:43 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
1892024-11-15T21:24:25 <bitcoin-git> [bitcoin] adamandrews1 opened pull request #31298: rpc: combinerawtransaction now rejects unmergeable transactions (master...combinerawtransaction-check) https://github.com/bitcoin/bitcoin/pull/31298
1902024-11-15T21:24:43 *** kevkevin <kevkevin!~kevkevin@142.147.59.145> has quit IRC (Remote host closed the connection)
1912024-11-15T21:28:38 *** jon_atack <jon_atack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
1922024-11-15T21:44:28 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
1932024-11-15T22:11:30 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Remote host closed the connection)
1942024-11-15T22:23:50 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has joined #bitcoin-core-dev
1952024-11-15T22:24:25 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 272 seconds)
1962024-11-15T22:43:07 *** kevkevin <kevkevin!~kevkevin@209-242-39-30.rev.dls.net> has joined #bitcoin-core-dev
1972024-11-15T23:16:24 *** Guest28 <Guest28!~Guest28@70.22.182.14> has joined #bitcoin-core-dev
1982024-11-15T23:16:41 *** Guest28 <Guest28!~Guest28@70.22.182.14> has quit IRC (Client Quit)
1992024-11-15T23:27:54 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Quit: bye)
2002024-11-15T23:27:56 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Quit: Leaving)
2012024-11-15T23:29:55 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
2022024-11-15T23:36:27 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has quit IRC (Quit: jarthur_)