12025-02-05T00:15:39 *** synexic <synexic!~syn@toucht.one> has joined #bitcoin-core-dev
22025-02-05T00:31:09 *** eval-exec <eval-exec!~Thunderbi@98.142.129.90.16clouds.com> has joined #bitcoin-core-dev
32025-02-05T00:34:24 *** preimage <preimage!~halosghos@user/halosghost> has joined #bitcoin-core-dev
42025-02-05T00:35:30 *** eval-exec <eval-exec!~Thunderbi@98.142.129.90.16clouds.com> has quit IRC (Ping timeout: 260 seconds)
52025-02-05T00:36:38 *** eval-exec <eval-exec!~Thunderbi@154.201.95.126> has joined #bitcoin-core-dev
62025-02-05T00:52:05 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has quit IRC (Quit: PaperSword)
72025-02-05T01:01:16 *** Cory58 <Cory58!~Cory58@user/pasha> has quit IRC (Quit: Client closed)
82025-02-05T01:01:31 *** Cory58 <Cory58!~Cory58@user/pasha> has joined #bitcoin-core-dev
92025-02-05T01:08:37 *** twistedline <twistedline!~bitcoin@185.193.125.44> has quit IRC (Ping timeout: 248 seconds)
102025-02-05T01:09:15 *** twistedline <twistedline!~bitcoin@c-73-172-209-62.hsd1.md.comcast.net> has joined #bitcoin-core-dev
112025-02-05T01:44:36 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 264 seconds)
122025-02-05T01:56:59 *** twistedline <twistedline!~bitcoin@c-73-172-209-62.hsd1.md.comcast.net> has quit IRC (Ping timeout: 252 seconds)
132025-02-05T02:04:18 *** twistedline <twistedline!~bitcoin@185.193.125.44> has joined #bitcoin-core-dev
142025-02-05T02:09:13 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has joined #bitcoin-core-dev
152025-02-05T02:10:15 *** jarthur <jarthur!~jarthur@user/jarthur> has quit IRC (Ping timeout: 272 seconds)
162025-02-05T02:21:33 *** Victor_sueca <Victor_sueca!~Victorsue@user/victorsueca> has quit IRC (Ping timeout: 252 seconds)
172025-02-05T02:24:16 *** Victor_sueca <Victor_sueca!~Victorsue@user/victorsueca> has joined #bitcoin-core-dev
182025-02-05T02:32:25 *** Victor_sueca <Victor_sueca!~Victorsue@user/victorsueca> has quit IRC (Ping timeout: 272 seconds)
192025-02-05T02:33:29 *** Victor_sueca <Victor_sueca!~Victorsue@user/victorsueca> has joined #bitcoin-core-dev
202025-02-05T02:34:14 *** pyth <pyth!~pyth@user/pyth> has joined #bitcoin-core-dev
212025-02-05T02:37:49 *** MyNetAz <MyNetAz!~MyNetAz@user/MyNetAz> has quit IRC (Remote host closed the connection)
222025-02-05T02:39:04 *** MyNetAz <MyNetAz!~MyNetAz@user/MyNetAz> has joined #bitcoin-core-dev
232025-02-05T02:41:47 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Read error: Connection reset by peer)
242025-02-05T02:42:54 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
252025-02-05T02:49:22 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
262025-02-05T02:52:19 *** preimage <preimage!~halosghos@user/halosghost> has quit IRC (Quit: WeeChat 4.5.1)
272025-02-05T02:58:41 *** eval-exec <eval-exec!~Thunderbi@154.201.95.126> has quit IRC (Remote host closed the connection)
282025-02-05T02:58:54 *** eval-exec <eval-exec!~Thunderbi@154.201.95.128> has joined #bitcoin-core-dev
292025-02-05T03:43:00 <bitcoin-git> [bitcoin] ryanofsky closed pull request #30975: ci: build multiprocess on most jobs (master...2024/09/multiprocess-guix) https://github.com/bitcoin/bitcoin/pull/30975
302025-02-05T03:46:19 <bitcoin-git> [bitcoin] ryanofsky reopened pull request #30975: ci: build multiprocess on most jobs (master...2024/09/multiprocess-guix) https://github.com/bitcoin/bitcoin/pull/30975
312025-02-05T04:03:32 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Remote host closed the connection)
322025-02-05T04:05:02 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has quit IRC (Quit: leaving)
332025-02-05T04:05:38 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has joined #bitcoin-core-dev
342025-02-05T04:08:29 *** PaperSword1 <PaperSword1!~Thunderbi@securemail.qrsnap.io> has joined #bitcoin-core-dev
352025-02-05T04:10:06 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has quit IRC (Ping timeout: 252 seconds)
362025-02-05T04:10:06 *** PaperSword1 is now known as PaperSword
372025-02-05T04:30:14 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
382025-02-05T04:33:34 <bitcoin-git> [bitcoin] espi3 closed pull request #31755: doc: Add test coverage troubleshooting tip (master...doc-dev-notes) https://github.com/bitcoin/bitcoin/pull/31755
392025-02-05T04:35:04 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 260 seconds)
402025-02-05T04:36:12 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Ping timeout: 264 seconds)
412025-02-05T04:44:36 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has joined #bitcoin-core-dev
422025-02-05T05:01:01 *** cmirror <cmirror!~cmirror@4.53.92.114> has quit IRC (Remote host closed the connection)
432025-02-05T05:01:32 *** cmirror <cmirror!~cmirror@4.53.92.114> has joined #bitcoin-core-dev
442025-02-05T05:01:45 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
452025-02-05T05:06:11 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 252 seconds)
462025-02-05T05:19:57 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
472025-02-05T05:57:32 *** eval-exec <eval-exec!~Thunderbi@154.201.95.128> has quit IRC (Remote host closed the connection)
482025-02-05T05:57:45 *** eval-exec <eval-exec!~Thunderbi@154.201.95.128> has joined #bitcoin-core-dev
492025-02-05T06:01:40 *** mcey_ <mcey_!~emcy@85.255.236.24> has joined #bitcoin-core-dev
502025-02-05T06:01:54 *** mcey <mcey!~emcy@85.255.236.24> has quit IRC (Remote host closed the connection)
512025-02-05T06:06:32 *** eval-exec <eval-exec!~Thunderbi@154.201.95.128> has quit IRC (Remote host closed the connection)
522025-02-05T06:06:57 *** eval-exec <eval-exec!~Thunderbi@23.106.135.250.16clouds.com> has joined #bitcoin-core-dev
532025-02-05T06:15:11 <PaperSword> Hey! Question is there a way to determine if a mempool entry is TRUC via the RPC?
542025-02-05T06:16:31 <PaperSword> OR is the TXN being in the mempool V3 enough.
552025-02-05T06:16:31 <PaperSword> Wait: I just answered that.... sorry, yeah so being V3 you then can look at the array of descendants / ancestors to see if the TXN is TRUC and what set of rules for size apply.
562025-02-05T06:22:59 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 260 seconds)
572025-02-05T06:49:50 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
582025-02-05T07:16:56 *** jarthur_ <jarthur_!~jarthur@user/jarthur> has quit IRC (Quit: jarthur_)
592025-02-05T07:17:26 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 244 seconds)
602025-02-05T07:41:30 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
612025-02-05T07:59:08 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
622025-02-05T08:06:14 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 252 seconds)
632025-02-05T08:19:56 *** juleeho <juleeho!~juleeho@81.174.12.248> has joined #bitcoin-core-dev
642025-02-05T08:20:18 *** juleeho <juleeho!~juleeho@81.174.12.248> has quit IRC (Client Quit)
652025-02-05T08:33:56 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
662025-02-05T08:38:06 *** adiabat_ <adiabat_!~adiabat@63.209.32.102> has quit IRC (Ping timeout: 246 seconds)
672025-02-05T08:38:34 *** Guest87 <Guest87!~Guest47@213.226.14.2> has joined #bitcoin-core-dev
682025-02-05T08:40:59 *** adiabat_ <adiabat_!~adiabat@63.209.32.102> has joined #bitcoin-core-dev
692025-02-05T08:49:55 *** adiabat_ <adiabat_!~adiabat@63.209.32.102> has quit IRC (Remote host closed the connection)
702025-02-05T08:50:00 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has quit IRC (Quit: Going offline, see ya! (www.adiirc.com))
712025-02-05T08:50:14 *** adiabat_ <adiabat_!~adiabat@63.209.32.102> has joined #bitcoin-core-dev
722025-02-05T08:51:49 *** MyNetAz <MyNetAz!~MyNetAz@user/MyNetAz> has quit IRC (Remote host closed the connection)
732025-02-05T08:54:43 *** MyNetAz <MyNetAz!~MyNetAz@user/MyNetAz> has joined #bitcoin-core-dev
742025-02-05T08:55:08 *** MyNetAz <MyNetAz!~MyNetAz@user/MyNetAz> has quit IRC (Remote host closed the connection)
752025-02-05T08:56:24 *** MyNetAz <MyNetAz!~MyNetAz@user/MyNetAz> has joined #bitcoin-core-dev
762025-02-05T08:56:24 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 260 seconds)
772025-02-05T09:46:45 *** gnusha <gnusha!~gnusha@user/gnusha> has quit IRC (Ping timeout: 244 seconds)
782025-02-05T09:46:55 *** gnusha <gnusha!~gnusha@user/gnusha> has joined #bitcoin-core-dev
792025-02-05T09:49:30 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
802025-02-05T09:51:12 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has quit IRC (Ping timeout: 264 seconds)
812025-02-05T09:51:43 *** SpellChecker <SpellChecker!~SpellChec@user/SpellChecker> has joined #bitcoin-core-dev
822025-02-05T10:04:58 *** vasild_ <vasild_!~vd@user/vasild> has joined #bitcoin-core-dev
832025-02-05T10:05:29 *** vasild <vasild!~vd@user/vasild> has quit IRC (Remote host closed the connection)
842025-02-05T10:13:52 *** MyNetAz <MyNetAz!~MyNetAz@user/MyNetAz> has quit IRC (Remote host closed the connection)
852025-02-05T10:16:02 *** eval-exec <eval-exec!~Thunderbi@23.106.135.250.16clouds.com> has quit IRC (Ping timeout: 252 seconds)
862025-02-05T10:18:48 *** MyNetAz <MyNetAz!~MyNetAz@user/MyNetAz> has joined #bitcoin-core-dev
872025-02-05T10:21:54 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 252 seconds)
882025-02-05T10:35:41 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/94ca99ac51dd...2aa7be1744a4
892025-02-05T10:35:41 <bitcoin-git> bitcoin/master d9c8aac Hennadii Stepanov: depends, refactor: Avoid hardcoding `host_prefix` in toolchain file
902025-02-05T10:35:42 <bitcoin-git> bitcoin/master 2aa7be1 merge-script: Merge bitcoin/bitcoin#31358: depends: Avoid hardcoding `host_prefix` in to...
912025-02-05T10:35:43 <bitcoin-git> [bitcoin] fanquake merged pull request #31358: depends: Avoid hardcoding `host_prefix` in toolchain file (master...241122-toolchain) https://github.com/bitcoin/bitcoin/pull/31358
922025-02-05T10:38:06 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2aa7be1744a4...33932d30e382
932025-02-05T10:38:07 <bitcoin-git> bitcoin/master 7e0db87 kevkevinpal: test: added additional coverage to waitforblock and waitforblockheight rpc...
942025-02-05T10:38:07 <bitcoin-git> bitcoin/master 33932d3 merge-script: Merge bitcoin/bitcoin#31784: test: added additional coverage to waitforblo...
952025-02-05T10:38:09 <bitcoin-git> [bitcoin] fanquake merged pull request #31784: test: added additional coverage to waitforblock and waitforblockheight rpc's (master...moreTimeoutTests) https://github.com/bitcoin/bitcoin/pull/31784
962025-02-05T10:42:05 <willcl-ark> Do we support different debug levels (or categories) being sent to console and debug.log file?
972025-02-05T10:47:28 <laanwj> i'm getting a bit skeptical about #31177, sure, it'd be nice to report 1.0 exactly when we're sure we're entirely up to date, but solutions seem to muddle the estimate that makes it less useful in other ways
982025-02-05T10:48:09 <laanwj> willcl-ark: no, there's no such setting
992025-02-05T10:51:16 <fjahr> corebot seems dead? :/
1002025-02-05T10:51:16 <corebot> fjahr: Error: "seems" is not a valid command.
1012025-02-05T10:51:29 <fjahr> #31177
1022025-02-05T10:51:31 <corebot> https://github.com/bitcoin/bitcoin/issues/31177 | rpc, logging: return "verificationprogress" of 1 when up to date by polespinasa · Pull Request #31177 · bitcoin/bitcoin · GitHub
1032025-02-05T10:51:38 <fjahr> Oh, he's back :)
1042025-02-05T10:51:44 <laanwj> bitcoin#31177
1052025-02-05T10:52:00 <laanwj> huh
1062025-02-05T10:55:50 <willcl-ark> laanwj: ok thanks for confirming what I suspected
1072025-02-05T10:56:33 *** eval-exec <eval-exec!~Thunderbi@154.201.95.126> has joined #bitcoin-core-dev
1082025-02-05T10:58:14 <laanwj> i can see how it can be useful, but having multiple sets of logging category/level filter settings would complicate the logging system even more
1092025-02-05T11:02:50 <willcl-ark> Yeah, and I only want it for some benchmarking, but I don't think it would be a particularly generally-useful feature...
1102025-02-05T11:35:20 *** Guest87 <Guest87!~Guest47@213.226.14.2> has quit IRC (Quit: Client closed)
1112025-02-05T11:57:36 *** theStack <theStack!~theStack@95.179.145.232> has quit IRC (Ping timeout: 252 seconds)
1122025-02-05T12:03:46 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
1132025-02-05T12:17:02 *** eval-exec <eval-exec!~Thunderbi@154.201.95.126> has quit IRC (Remote host closed the connection)
1142025-02-05T12:17:15 *** eval-exec <eval-exec!~Thunderbi@23.106.135.250.16clouds.com> has joined #bitcoin-core-dev
1152025-02-05T12:19:45 *** Eric3 <Eric3!~exeric3@dbox.skgaming.net> has joined #bitcoin-core-dev
1162025-02-05T12:20:42 *** ExEric3 <ExEric3!~exeric3@dbox.skgaming.net> has quit IRC (Ping timeout: 252 seconds)
1172025-02-05T12:21:26 *** MyNetAz <MyNetAz!~MyNetAz@user/MyNetAz> has quit IRC (Ping timeout: 252 seconds)
1182025-02-05T12:22:00 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 276 seconds)
1192025-02-05T12:26:01 *** theStack <theStack!~theStack@95.179.145.232> has joined #bitcoin-core-dev
1202025-02-05T12:35:53 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
1212025-02-05T12:43:42 *** jespada <jespada!~jespada@2800:a4:2349:fd00:4cee:65a9:9995:4332> has joined #bitcoin-core-dev
1222025-02-05T12:44:08 *** jespada <jespada!~jespada@2800:a4:2349:fd00:4cee:65a9:9995:4332> has quit IRC (Client Quit)
1232025-02-05T12:46:19 *** jespada <jespada!~jespada@2800:a4:2349:fd00:4cee:65a9:9995:4332> has joined #bitcoin-core-dev
1242025-02-05T12:55:03 *** MyNetAz <MyNetAz!~MyNetAz@user/MyNetAz> has joined #bitcoin-core-dev
1252025-02-05T13:01:24 *** MyNetAz <MyNetAz!~MyNetAz@user/MyNetAz> has quit IRC (Ping timeout: 252 seconds)
1262025-02-05T13:08:07 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 252 seconds)
1272025-02-05T13:12:09 *** MyNetAz <MyNetAz!~MyNetAz@user/MyNetAz> has joined #bitcoin-core-dev
1282025-02-05T13:22:05 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/33932d30e382...1334ca6c0709
1292025-02-05T13:22:06 <bitcoin-git> bitcoin/master 846a138 Greg Sanders: func test: Expand tx download preference tests
1302025-02-05T13:22:06 <bitcoin-git> bitcoin/master 1334ca6 merge-script: Merge bitcoin/bitcoin#31437: func test: Expand tx download preference tests
1312025-02-05T13:22:08 <bitcoin-git> [bitcoin] fanquake merged pull request #31437: func test: Expand tx download preference tests (master...2024-12-inv_priority_tiebreaker) https://github.com/bitcoin/bitcoin/pull/31437
1322025-02-05T13:30:57 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1334ca6c0709...b9c241804c07
1332025-02-05T13:30:57 <bitcoin-git> bitcoin/master fa0232a Alfonso Roman Zubeldia: test: add validation for gettxout RPC response
1342025-02-05T13:30:58 <bitcoin-git> bitcoin/master 723440c Alfonso Roman Zubeldia: test framework, wallet: rename get_scriptPubKey method to get_output_script
1352025-02-05T13:30:58 <bitcoin-git> bitcoin/master b9c2418 merge-script: Merge bitcoin/bitcoin#30226: test: add validation for gettxout RPC response
1362025-02-05T13:31:00 <bitcoin-git> [bitcoin] fanquake merged pull request #30226: test: add validation for gettxout RPC response (master...missing-test) https://github.com/bitcoin/bitcoin/pull/30226
1372025-02-05T13:35:54 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
1382025-02-05T13:42:14 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has quit IRC (Ping timeout: 260 seconds)
1392025-02-05T13:44:47 <sipa> laanwj: hmm, yes, my initial preference was not do anything, because "fully synced" isn't very well defined of you take the possibility of a block whose header you have not seen into account, but people really wanted to see a 1.0 number
1402025-02-05T13:51:40 *** cygnet3 <cygnet3!~cygnet3@178.226.63.248> has joined #bitcoin-core-dev
1412025-02-05T14:04:43 <laanwj> sipa: sure, and i i can understand that, i do agree in theory it's an improvement to user friendliness, but doing it in a way that doesn't break other cases unexpectedly or makes questionable assumptions seems hard
1422025-02-05T14:06:34 <laanwj> also, that code has no business being in validation.cpp
1432025-02-05T14:09:59 <laanwj> (but that's orthogonal to the PR)
1442025-02-05T14:16:21 *** kevkevin <kevkevin!~kevkevin@209.242.39.30> has joined #bitcoin-core-dev
1452025-02-05T14:32:15 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has joined #bitcoin-core-dev
1462025-02-05T14:32:25 *** Guyver2 <Guyver2!~Guyver@77-174-98-73.fixed.kpn.net> has left #bitcoin-core-dev
1472025-02-05T14:36:14 <laanwj> #25832 seems RFM
1482025-02-05T14:36:16 <corebot> https://github.com/bitcoin/bitcoin/issues/25832 | tracing: network connection tracepoints by 0xB10C · Pull Request #25832 · bitcoin/bitcoin · GitHub
1492025-02-05T14:43:11 <sipa> can i have some review on #30535? it adds the ability to evaluate FeeFrac at a given size, making it possible to use as replacement for CFeeRate, and comes with nice tests
1502025-02-05T14:45:38 <abubakarsadiq> #30535
1512025-02-05T14:45:41 <corebot> https://github.com/bitcoin/bitcoin/issues/30535 | feefrac: add support for evaluating at given size by sipa · Pull Request #30535 · bitcoin/bitcoin · GitHub
1522025-02-05T14:51:23 <instagibbs> sipa will put it in the review pile
1532025-02-05T14:55:22 *** jespada <jespada!~jespada@2800:a4:2349:fd00:4cee:65a9:9995:4332> has quit IRC (Ping timeout: 252 seconds)
1542025-02-05T14:56:13 <sipa> instagibbs: dank
1552025-02-05T14:56:17 <bitcoin-git> [bitcoin] hebasto opened pull request #31800: depends: Avoid using the `-ffile-prefix-map` compiler option (master...250205-prefix-map) https://github.com/bitcoin/bitcoin/pull/31800
1562025-02-05T14:58:36 *** jespada <jespada!~jespada@2800:a4:22f0:ad00:71a5:a98b:21d:a1b4> has joined #bitcoin-core-dev
1572025-02-05T15:00:48 *** bitdex <bitdex!~bitdex@gateway/tor-sasl/bitdex> has quit IRC (Quit: = "")
1582025-02-05T15:01:54 *** eval-exec <eval-exec!~Thunderbi@23.106.135.250.16clouds.com> has quit IRC (Ping timeout: 276 seconds)
1592025-02-05T15:01:55 *** zeropoint <zeropoint!~alex@45-28-139-114.lightspeed.sntcca.sbcglobal.net> has joined #bitcoin-core-dev
1602025-02-05T15:24:25 *** PaperSword1 <PaperSword1!~Thunderbi@securemail.qrsnap.io> has joined #bitcoin-core-dev
1612025-02-05T15:24:27 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has quit IRC (Ping timeout: 246 seconds)
1622025-02-05T15:24:27 *** PaperSword1 is now known as PaperSword
1632025-02-05T15:29:47 <glozow> sipa: does it maybe need a rebase?
1642025-02-05T15:29:51 <yancy> sipa I'll take a look at 30535
1652025-02-05T15:30:03 <glozow> or i guess, couldnât hurt to rebase?
1662025-02-05T15:30:26 <sipa> glozow: i can rebase
1672025-02-05T15:30:59 <bitcoin-git> [bitcoin] fanquake pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/b9c241804c07...a43f08c4ae32
1682025-02-05T15:31:00 <bitcoin-git> bitcoin/master 85b2603 0xb10c: tracing: add inbound connection tracepoint
1692025-02-05T15:31:00 <bitcoin-git> bitcoin/master 4d61d52 0xb10c: tracing: add outbound connection tracepoint
1702025-02-05T15:31:00 <bitcoin-git> bitcoin/master 68c1ef4 0xb10c: tracing: add inbound connection eviction tracepoint
1712025-02-05T15:31:02 <bitcoin-git> [bitcoin] fanquake merged pull request #25832: tracing: network connection tracepoints (master...2022-05-connection-tracepoints) https://github.com/bitcoin/bitcoin/pull/25832
1722025-02-05T15:32:01 <glozow> I vaguely remember it just missing v28
1732025-02-05T15:37:25 *** hernanmarino <hernanmarino!~hernanmar@2800:2330:2800:10c:f4b5:f1bd:1c09:c579> has joined #bitcoin-core-dev
1742025-02-05T15:38:15 *** pyth <pyth!~pyth@user/pyth> has quit IRC (Remote host closed the connection)
1752025-02-05T15:39:58 *** pyth <pyth!~pyth@user/pyth> has joined #bitcoin-core-dev
1762025-02-05T15:58:22 <instagibbs> sipa when did the Cluster type get removed again? I can't recall
1772025-02-05T15:59:32 <sipa> instagibbs: in #30857
1782025-02-05T15:59:36 <corebot> https://github.com/bitcoin/bitcoin/issues/30857 | cluster mempool: extend DepGraph functionality by sipa · Pull Request #30857 · bitcoin/bitcoin · GitHub
1792025-02-05T15:59:55 <instagibbs> ah right
1802025-02-05T15:59:58 <instagibbs> dank
1812025-02-05T16:04:05 <bitcoin-git> [bitcoin] Sjors opened pull request #31802: Add bitcoin-{node,gui} to release binaries for IPC (master...2025/02/ipc-yea) https://github.com/bitcoin/bitcoin/pull/31802
1822025-02-05T16:25:30 *** Polaris <Polaris!~Polaris@38.207.137.250> has joined #bitcoin-core-dev
1832025-02-05T16:28:12 <abubakarsadiq> @sipa I see that all the getter and setter methods of txgraph on a ref assume checking whether the ref belongs to that txgraph. Could this methods just be part of ref? Since ref can access its txgraph internals, this would prevent those `Assumes` and the issues they are meant to prevent.
1842025-02-05T16:28:12 <abubakarsadiq> But I think you choose the current approach because it's better than my suggestion for some reasons?
1852025-02-05T16:29:06 <sipa> abubakarsadiq: it's a good question
1862025-02-05T16:30:47 <sipa> one reason is that it makes locking requirements clearer; we can't write those when operating on Refs directly (because the txgraph isn't in scope necessarily)
1872025-02-05T16:32:12 <abubakarsadiq> I see, I have not reviewed the commit you introduced locks yet
1882025-02-05T16:35:33 *** PaperSword <PaperSword!~Thunderbi@securemail.qrsnap.io> has quit IRC (Quit: PaperSword)
1892025-02-05T16:43:15 *** shesek <shesek!~shesek@user/shesek> has quit IRC (Quit: The Lounge - https://thelounge.chat)
1902025-02-05T16:43:37 *** shesek <shesek!~shesek@user/shesek> has joined #bitcoin-core-dev
1912025-02-05T16:46:21 <bitcoin-git> [bitcoin] fjahr opened pull request #31803: fuzz: Extend mini_miner fuzz coverage to max block weight (master...pr31384-fuzz-follow-up) https://github.com/bitcoin/bitcoin/pull/31803
1922025-02-05T16:46:25 <sipa> there are none
1932025-02-05T16:46:46 <sipa> the locking would be at the mempool level
1942025-02-05T16:46:49 *** monlovesmango <monlovesmango!~monlovesm@syn-047-012-107-020.res.spectrum.com> has joined #bitcoin-core-dev
1952025-02-05T16:47:38 *** Naiyoma <Naiyoma!~Naiyoma@154.70.35.218> has joined #bitcoin-core-dev
1962025-02-05T16:50:11 *** eugenesiegel <eugenesiegel!~eugenesie@syn-104-162-064-179.res.spectrum.com> has joined #bitcoin-core-dev
1972025-02-05T16:52:40 *** Naiyoma91 <Naiyoma91!~Naiyoma@154.70.35.218> has joined #bitcoin-core-dev
1982025-02-05T16:54:55 *** Polaris <Polaris!~Polaris@38.207.137.250> has quit IRC (Quit: Client closed)
1992025-02-05T16:55:40 *** Naiyoma <Naiyoma!~Naiyoma@154.70.35.218> has quit IRC (Ping timeout: 240 seconds)
2002025-02-05T17:00:15 *** Polaris <Polaris!~Polaris@38.207.137.250> has joined #bitcoin-core-dev
2012025-02-05T17:03:07 *** monlovesmango <monlovesmango!~monlovesm@syn-047-012-107-020.res.spectrum.com> has quit IRC (Remote host closed the connection)
2022025-02-05T17:07:02 *** jespada <jespada!~jespada@2800:a4:22f0:ad00:71a5:a98b:21d:a1b4> has quit IRC (Quit: My Mac has gone to sleep. ZZZzzzâ¦)
2032025-02-05T17:08:04 *** jespada <jespada!~jespada@2800:a4:22f0:ad00:71a5:a98b:21d:a1b4> has joined #bitcoin-core-dev
2042025-02-05T17:10:11 *** monlovesmango <monlovesmango!monlovesma@gateway/vpn/protonvpn/monlovesmango> has joined #bitcoin-core-dev
2052025-02-05T17:23:17 <bitcoin-git> [bitcoin] hebasto closed pull request #31726: ci: Replace `CMAKE_CXX_FLAGS` with `APPEND_CXXFLAGS` (master...250123-ci-flags) https://github.com/bitcoin/bitcoin/pull/31726
2062025-02-05T17:25:49 <bitcoin-git> [bitcoin] hebasto opened pull request #31804: ci: Remove no longer needed '-Wno-error=documentation' (master...250205-ci-flags) https://github.com/bitcoin/bitcoin/pull/31804
2072025-02-05T17:28:10 *** jespada <jespada!~jespada@2800:a4:22f0:ad00:71a5:a98b:21d:a1b4> has quit IRC (Quit: My Mac has gone to sleep. ZZZzzzâ¦)
2082025-02-05T17:32:01 *** Polaris <Polaris!~Polaris@38.207.137.250> has quit IRC (Quit: Client closed)
2092025-02-05T17:32:31 <bitcoin-git> [bitcoin] jonatack opened pull request #31805: doc: improve NODE_NETWORK_LIMITED documentation per BIP159 (master...2025-02-NODE_NETWORK_LIMITED-documentation) https://github.com/bitcoin/bitcoin/pull/31805
2102025-02-05T17:37:10 *** eugenesiegel <eugenesiegel!~eugenesie@user/eugenesiegel> has quit IRC (Ping timeout: 240 seconds)
2112025-02-05T17:46:59 <bitcoin-git> [bitcoin] brunoerg opened pull request #31806: fuzz: coinselection: cover `SetBumpFeeDiscount` (master...2025-02-fuzz-coinselection-bumpfee) https://github.com/bitcoin/bitcoin/pull/31806
2122025-02-05T17:47:31 *** Naiyoma91 <Naiyoma91!~Naiyoma@154.70.35.218> has quit IRC (Quit: Client closed)
2132025-02-05T18:11:19 *** Talkless <Talkless!~Talkless@mail.dargis.net> has joined #bitcoin-core-dev
2142025-02-05T18:11:21 *** monlovesmango <monlovesmango!monlovesma@gateway/vpn/protonvpn/monlovesmango> has quit IRC ()
2152025-02-05T18:18:30 *** monloves_ <monloves_!monlovesma@gateway/vpn/protonvpn/monlovesmango> has joined #bitcoin-core-dev
2162025-02-05T18:19:07 *** monlovesmango <monlovesmango!mon@gateway/vpn/protonvpn/monlovesmango> has joined #bitcoin-core-dev
2172025-02-05T18:19:59 *** brunoerg <brunoerg!~brunoerg@2804:14d:5285:84b2::1001> has quit IRC (Read error: Connection reset by peer)
2182025-02-05T18:20:09 *** brunoerg <brunoerg!~brunoerg@2804:14d:5285:84b2::1001> has joined #bitcoin-core-dev
2192025-02-05T18:26:27 *** brunoerg <brunoerg!~brunoerg@2804:14d:5285:84b2::1001> has quit IRC (Read error: Connection reset by peer)
2202025-02-05T18:26:35 *** brunoerg <brunoerg!~brunoerg@2804:14d:5285:84b2::1001> has joined #bitcoin-core-dev
2212025-02-05T18:27:12 *** Olsen <Olsen!~Olsen@2804:431:c7cb:91c6:3911:7255:fb05:6d0a> has joined #bitcoin-core-dev
2222025-02-05T18:27:26 *** Olsen <Olsen!~Olsen@2804:431:c7cb:91c6:3911:7255:fb05:6d0a> has quit IRC (Client Quit)
2232025-02-05T18:28:10 *** brunoerg <brunoerg!~brunoerg@2804:14d:5285:84b2::1001> has quit IRC (Client Quit)
2242025-02-05T18:32:22 *** brunoerg <brunoerg!~brunoerg@2804:14d:5285:84b2::1001> has joined #bitcoin-core-dev
2252025-02-05T18:37:17 *** monloves_ <monloves_!monlovesma@gateway/vpn/protonvpn/monlovesmango> has quit IRC (Remote host closed the connection)
2262025-02-05T18:50:44 *** monlovesmango <monlovesmango!mon@gateway/vpn/protonvpn/monlovesmango> has quit IRC (Quit: leaving)
2272025-02-05T18:50:44 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Read error: Connection reset by peer)
2282025-02-05T19:01:04 *** monlovesmango <monlovesmango!mon@gateway/vpn/protonvpn/monlovesmango> has joined #bitcoin-core-dev
2292025-02-05T19:01:58 *** monlovesmango <monlovesmango!mon@gateway/vpn/protonvpn/monlovesmango> has quit IRC (Client Quit)
2302025-02-05T19:12:25 *** monlovesmango <monlovesmango!monlovesma@gateway/vpn/protonvpn/monlovesmango> has joined #bitcoin-core-dev
2312025-02-05T19:14:05 *** monlovesmango <monlovesmango!monlovesma@gateway/vpn/protonvpn/monlovesmango> has quit IRC (Client Quit)
2322025-02-05T19:14:24 *** monlovesmango <monlovesmango!monlovesma@gateway/vpn/protonvpn/monlovesmango> has joined #bitcoin-core-dev
2332025-02-05T19:14:32 *** jespada <jespada!~jespada@2800:a4:22f0:ad00:99d3:1891:5585:fb7a> has joined #bitcoin-core-dev
2342025-02-05T19:18:20 *** monlovesmango <monlovesmango!monlovesma@gateway/vpn/protonvpn/monlovesmango> has quit IRC (Client Quit)
2352025-02-05T19:18:31 *** Cory58 <Cory58!~Cory58@user/pasha> has quit IRC (Quit: Client closed)
2362025-02-05T19:18:39 *** monlovesmango <monlovesmango!monlovesma@gateway/vpn/protonvpn/monlovesmango> has joined #bitcoin-core-dev
2372025-02-05T19:18:49 *** Cory58 <Cory58!~Cory58@user/pasha> has joined #bitcoin-core-dev
2382025-02-05T19:27:39 <bitcoin-git> [bitcoin] maflcko closed pull request #31332: contrib: fix BUILDDIR in gen-bitcoin-conf script (master...fix-builddir) https://github.com/bitcoin/bitcoin/pull/31332
2392025-02-05T19:32:46 <bitcoin-git> [bitcoin] theuni opened pull request #31807: kernel: Avoid duplicating symbols in the kernel and downstream users (master...fix-dupe-kernel-symbols) https://github.com/bitcoin/bitcoin/pull/31807
2402025-02-05T19:37:10 *** monlovesmango <monlovesmango!monlovesma@gateway/vpn/protonvpn/monlovesmango> has quit IRC (Quit: leaving)
2412025-02-05T19:38:26 *** monlovesmango <monlovesmango!monlovesma@gateway/vpn/protonvpn/monlovesmango> has joined #bitcoin-core-dev
2422025-02-05T19:39:38 *** monlovesmango <monlovesmango!monlovesma@gateway/vpn/protonvpn/monlovesmango> has quit IRC (Client Quit)
2432025-02-05T19:39:52 <sipa> abubakarsadiq: to be clear, what i mean is that CTxMemPool would have a `TxGraph m_txgraph GUARDED_BY(cs);` variable, so that it can be checked that any interactions with m_txgraph require the mempool lock
2442025-02-05T19:39:59 *** monlovesmango <monlovesmango!monlovesma@gateway/vpn/protonvpn/monlovesmango> has joined #bitcoin-core-dev
2452025-02-05T19:40:47 <sipa> but a direct TxGraph::Ref::RemoveTransaction() would invisbly access m_txgraph, by holding its own reference to it
2462025-02-05T19:41:28 <sipa> this problem does exist with TxGraph::Ref::~Ref, which one would need the mempool lock for too, but we can't avoid that
2472025-02-05T19:41:31 *** monlovesmango <monlovesmango!monlovesma@gateway/vpn/protonvpn/monlovesmango> has quit IRC (Client Quit)
2482025-02-05T19:41:45 <sipa> maybe in a follow-up TxGraph can be given its own internal locks
2492025-02-05T19:42:46 <abubakarsadiq> that will be better I think, the abstraction will be complete!
2502025-02-05T19:45:50 *** monlovesmango <monlovesmango!monlovesma@gateway/vpn/protonvpn/monlovesmango> has joined #bitcoin-core-dev
2512025-02-05T19:46:04 *** monlovesmango <monlovesmango!monlovesma@gateway/vpn/protonvpn/monlovesmango> has quit IRC (Client Quit)
2522025-02-05T19:46:51 <sipa> i don't know if it's really possible
2532025-02-05T19:47:19 <sipa> with CTxMempoolEntry deriving from TxGraph::Ref, they are kind of intertwined from an access level
2542025-02-05T19:49:48 *** andrewtoth <andrewtoth!~andrewtot@gateway/tor-sasl/andrewtoth> has joined #bitcoin-core-dev
2552025-02-05T19:56:32 <abubakarsadiq> hmm yeah we will want the additions to be atomic (for both `TxGraph` and mempool entry)
2562025-02-05T19:56:33 <abubakarsadiq> I think I will have to to look at #28676 on how the current `TxGraph` interface is used by the mempool
2572025-02-05T19:56:33 <abubakarsadiq> anyway I dont think it's super important for `TxGraph` to handle it's threadsafety internally
2582025-02-05T19:56:36 <corebot> https://github.com/bitcoin/bitcoin/issues/28676 | [WIP] Cluster mempool implementation by sdaftuar · Pull Request #28676 · bitcoin/bitcoin · GitHub
2592025-02-05T20:00:55 *** Talkless <Talkless!~Talkless@mail.dargis.net> has quit IRC (Quit: Konversation terminated!)
2602025-02-05T20:14:50 <darosior> Re the discussion about checking all consensus rules in ConnectBlock, i'm not sure if we should really be concerned about somehow an invalid block being let in by an unupgraded version being connected by an upgraded one, if the unupgraded version could just have connected it in the first place and the upgraded version wouldn't catch that either?
2612025-02-05T20:15:24 <darosior> I guess there is a slight advantage to being able to catch it with `verifychain` or a `-reindex-chainstate` but..
2622025-02-05T20:28:49 *** cygnet3 <cygnet3!~cygnet3@178.226.63.248> has quit IRC (Quit: Leaving)
2632025-02-05T20:49:36 <bitcoin-git> [qa-assets] murchandamus opened pull request #218: Add Murchâs inputs February 2025 merged without sanitizers (main...2025-02-murch-inputs-no-san) https://github.com/bitcoin-core/qa-assets/pull/218
2642025-02-05T20:51:03 *** jonatack <jonatack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2652025-02-05T20:54:17 *** Cory58 <Cory58!~Cory58@user/pasha> has quit IRC (Quit: Client closed)
2662025-02-05T20:54:35 *** Cory58 <Cory58!~Cory58@user/pasha> has joined #bitcoin-core-dev
2672025-02-05T21:00:29 *** pyth <pyth!~pyth@user/pyth> has quit IRC (Ping timeout: 244 seconds)
2682025-02-05T21:01:28 *** pyth <pyth!~pyth@user/pyth> has joined #bitcoin-core-dev
2692025-02-05T21:09:08 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has joined #bitcoin-core-dev
2702025-02-05T21:10:12 *** jespada <jespada!~jespada@2800:a4:22f0:ad00:99d3:1891:5585:fb7a> has quit IRC (Quit: My Mac has gone to sleep. ZZZzzzâ¦)
2712025-02-05T21:11:14 *** pyth <pyth!~pyth@user/pyth> has quit IRC (Ping timeout: 248 seconds)
2722025-02-05T21:11:40 *** pyth <pyth!~pyth@user/pyth> has joined #bitcoin-core-dev
2732025-02-05T21:13:45 *** instagibbs4 <instagibbs4!~instagibb@pool-100-15-116-202.washdc.fios.verizon.net> has joined #bitcoin-core-dev
2742025-02-05T21:14:03 *** jon_atack <jon_atack!~jonatack@user/jonatack> has joined #bitcoin-core-dev
2752025-02-05T21:14:08 *** dongcarl4 <dongcarl4!~dongcarl@syn-066-065-169-019.res.spectrum.com> has joined #bitcoin-core-dev
2762025-02-05T21:14:56 *** midnight_ <midnight_!~midnight@user/midnight> has joined #bitcoin-core-dev
2772025-02-05T21:16:32 *** javi404_ <javi404_!~quassel@2601:58b:4880:48b1:3beb:fd1f:824f:3caa> has joined #bitcoin-core-dev
2782025-02-05T21:17:10 *** otoburb_ <otoburb_!~otoburb@user/otoburb> has joined #bitcoin-core-dev
2792025-02-05T21:18:09 *** jonatack <jonatack!~jonatack@user/jonatack> has quit IRC (Ping timeout: 252 seconds)
2802025-02-05T21:18:10 *** otoburb <otoburb!~otoburb@user/otoburb> has quit IRC (Ping timeout: 252 seconds)
2812025-02-05T21:18:10 *** MyNetAz <MyNetAz!~MyNetAz@user/MyNetAz> has quit IRC (Ping timeout: 252 seconds)
2822025-02-05T21:18:10 *** adiabat_ <adiabat_!~adiabat@63.209.32.102> has quit IRC (Ping timeout: 252 seconds)
2832025-02-05T21:18:10 *** dongcarl <dongcarl!~dongcarl@syn-066-065-169-019.res.spectrum.com> has quit IRC (Ping timeout: 252 seconds)
2842025-02-05T21:18:11 *** midnight <midnight!~midnight@user/midnight> has quit IRC (Ping timeout: 252 seconds)
2852025-02-05T21:18:11 *** instagibbs <instagibbs!~instagibb@pool-100-15-116-202.washdc.fios.verizon.net> has quit IRC (Ping timeout: 252 seconds)
2862025-02-05T21:18:11 *** javi404 <javi404!~quassel@c-76-110-162-73.hsd1.fl.comcast.net> has quit IRC (Ping timeout: 252 seconds)
2872025-02-05T21:18:11 *** instagibbs4 is now known as instagibbs
2882025-02-05T21:18:12 *** dongcarl4 is now known as dongcarl
2892025-02-05T21:19:11 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has quit IRC (Remote host closed the connection)
2902025-02-05T21:19:36 *** flooded <flooded!flooded@gateway/vpn/protonvpn/flood/x-43489060> has joined #bitcoin-core-dev
2912025-02-05T21:24:31 *** Cory58 <Cory58!~Cory58@user/pasha> has quit IRC (Quit: Client closed)
2922025-02-05T21:24:48 *** Cory58 <Cory58!~Cory58@user/pasha> has joined #bitcoin-core-dev
2932025-02-05T21:29:21 *** adiabat_ <adiabat_!~adiabat@63.209.32.102> has joined #bitcoin-core-dev
2942025-02-05T21:50:20 *** Guest6 <Guest6!~Guest6@195.155.169.3> has joined #bitcoin-core-dev
2952025-02-05T21:50:41 *** Guest6 <Guest6!~Guest6@195.155.169.3> has quit IRC (Client Quit)
2962025-02-05T22:05:03 *** qxs <qxs!~qxs@gateway/tor-sasl/qxs> has quit IRC (Remote host closed the connection)
2972025-02-05T22:05:32 *** qxs <qxs!~qxs@gateway/tor-sasl/qxs> has joined #bitcoin-core-dev
2982025-02-05T22:08:47 *** MyNetAz <MyNetAz!~MyNetAz@user/MyNetAz> has joined #bitcoin-core-dev
2992025-02-05T22:15:04 *** LainExperiments <LainExperiments!~LainExper@user/LainExperiments> has joined #bitcoin-core-dev
3002025-02-05T23:28:48 *** LainExperiments <LainExperiments!~LainExper@user/LainExperiments> has quit IRC (Quit: Client closed)
3012025-02-05T23:47:02 *** bugs_ <bugs_!~bugs@user/bugs/x-5128603> has quit IRC (Quit: Leaving)