19:00:32 <meshcollider> #startmeeting
19:00:32 <lightningbot> Meeting started Fri Feb  8 19:00:32 2019 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
19:00:32 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
19:00:50 <meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
19:01:01 <achow101> only half here
19:01:12 <sipa> here
19:01:13 <promag> hi
19:01:15 <meshcollider> Ok, topics?
19:01:45 <meshcollider> I guess we should start with discussing what wallet PRs we can aim to get into 0.18
19:02:01 <jnewbery> hi
19:03:05 <meshcollider> https://github.com/bitcoin/bitcoin/milestone/35
19:03:43 <gwillen> yes hello
19:04:25 <gwillen> I am pestering for people to go review #13932
19:04:28 <gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
19:04:38 <sipa> will do
19:04:48 <jnewbery> https://github.com/bitcoin/bitcoin/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+milestone%3A0.18.0+label%3AWallet
19:04:56 <achow101> also review #15226 pls
19:05:00 <gribble> https://github.com/bitcoin/bitcoin/issues/15226 | Allow creating blank (empty) wallets (alternative) by achow101 · Pull Request #15226 · bitcoin/bitcoin · GitHub
19:05:01 <jnewbery> only wallet PRs ^
19:06:02 <achow101> #14075 and #14021 would be nice, but they're a bit more involved
19:06:04 <gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
19:06:07 <gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
19:06:44 <meshcollider> Yes, I put them on the milestone but not sure they'll be ready in time
19:07:09 <achow101> there's also a merge conflict between those two and 15226 which may not be trivial to resolve, so i don't think we can get all of them in
19:09:36 <meshcollider> I would really like at least #14021 but we'll see I guess
19:09:39 <gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
19:09:55 <meshcollider> achow101: Is 15226 your highest priority one
19:10:03 <jnewbery> I'd love to see #15288 merged soon since we now seem to have some momentum in that series of PRs, but it might be better to do that after forking 0.18
19:10:06 <gribble> https://github.com/bitcoin/bitcoin/issues/15288 | Remove wallet -> node global function calls by ryanofsky · Pull Request #15288 · bitcoin/bitcoin · GitHub
19:10:17 <kanzure> hi.
19:10:30 <jnewbery> it's a very easy review. Lots of line change but all very mechanical, and nicely structured commits
19:10:31 <meshcollider> jnewbery: yeah I think after 0.18 is better, but I agree
19:10:38 <achow101> currently 14021 is my highest priority
19:11:22 <achow101> (since 14491 is merged now)
19:12:08 <jnewbery> achow101: perhaps you could give a summary of the state of HWI? How far are we from HWI in master?
19:12:31 <jnewbery> instagibbs: or you if you're around ^
19:12:59 <meshcollider> I think #14912 is tracking
19:13:05 <gribble> https://github.com/bitcoin/bitcoin/issues/14912 | [WIP] External signer support (e.g. hardware wallet) by Sjors · Pull Request #14912 · bitcoin/bitcoin · GitHub
19:13:11 <achow101> hwi has all basic functionality completed for the 5 common hardware wallets
19:13:59 <achow101> provoostenator has a branch for calling it from core
19:14:48 <achow101> we would need that and 14021 and 14075 for hwi to work.
19:15:37 <achow101> (gtg, have to take a quiz now)
19:15:40 <meshcollider> Also #14481 is the last PR on the "Segwit" github project which hasn't gone in, it'd be nice to have that in for 0.18
19:15:42 <gribble> https://github.com/bitcoin/bitcoin/issues/14481 | Add P2SH-P2WSH support to listunspent RPC by MeshCollider · Pull Request #14481 · bitcoin/bitcoin · GitHub
19:16:36 <meshcollider> Quite a small PR to review
19:16:40 <sipa> meshcollider: i'm slightly inclined to instead just aim to have signrawtransaction etc work with descriptors
19:16:49 <sipa> as listunspent gives the descriptors already
19:17:08 <sipa> (not an objection to also doing that PR... but i suspect in the end the descriptor based approach is more convenient)
19:19:45 <meshcollider> sipa: I think having both is nice, but yeah making descriptors more consistently used across the RPCs would be a nice change
19:19:58 <meshcollider> But we can't aim for that in 0.18
19:20:07 <sipa> agree
19:21:03 <meshcollider> Does anyone have any other topics for the meeting?
19:21:47 <meshcollider> sipa: how's the checksum search coming
19:22:22 <sipa> meshcollider: #15368
19:22:23 <gribble> https://github.com/bitcoin/bitcoin/issues/15368 | Descriptor checksums by sipa · Pull Request #15368 · bitcoin/bitcoin · GitHub
19:22:38 <sipa> i'll add documentation and release notes today
19:24:30 <meshcollider> Ok
19:24:59 <meshcollider> Looks like there's nothing else to discuss this week
19:25:13 <meshcollider> #endmeeting